Add CMAke builder to build.webkit.org
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-30  Lucas Forschler  <lforschler@apple.com>
2
3         Add CMAke builder to build.webkit.org
4         https://bugs.webkit.org/show_bug.cgi?id=150738
5         
6         Reviewed by Alex Christensen.
7
8         * BuildSlaveSupport/build.webkit.org-config/config.json:
9
10 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
11
12         [Win] build-jsc and run-javascriptcore-tests do not work
13         https://bugs.webkit.org/show_bug.cgi?id=150700
14
15         Reviewed by Mark Lam.
16         
17         Correct our build system so that it expects Windows to be using CMake,
18         and to build the correct sub-projects for our JSC helper scripts.
19
20         * Scripts/build-jsc: Make sure to build the testapi harness when
21           building for Windows.
22         * Scripts/build-webkit:
23           (1) Use the existing 'cmakeBasedPortName()'
24           (2) Use File::Spec rather than hard-coding path delimeters.
25           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
26         method rather than hard-coding the name based on conditional.
27         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
28           LLVM libraries on Apple Windows build.
29         * Scripts/run-javascriptcore-tests:
30         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
31         * Scripts/run-jsc: Ditto.
32         * Scripts/webkitdirs.pm:
33         (cmakeBasedPortName): Update to return the right value for the Apple
34         Windows port and the WinCairo port.
35         (isCMakeBuild): Expect CMake build for all Windows ports.
36
37 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
38
39         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
40         https://bugs.webkit.org/show_bug.cgi?id=150665
41
42         Reviewed by Csaba Osztrogonác.
43
44         We check it only to wipe the directory or not, but we are still
45         tryihng to update every module even when the configuration hasn't
46         changed. This is problematic because it makes the whole build fail
47         when any repository fails to checkout an already checked out
48         revision, because the server is down for example. This is even
49         more problematic for the bots that skip perfectly valid revisions.
50         It's still possible to force an update passing --force command
51         line argument.
52
53         * Scripts/update-webkit-libs-jhbuild:
54         (deleteJhbuildMd5): Delete the md5sum files if exist.
55         (runJhbuild): Return early if the md5sum files haven't
56         changed. Only write them after a successful build and delete them
57         if the build fails to ensure we don't skip next run.
58
59 2015-10-30  Philippe Normand  <pnormand@igalia.com>
60
61         [GTK] Fix MacCLang build errors in Tools
62         https://bugs.webkit.org/show_bug.cgi?id=150031
63
64         Reviewed by Carlos Garcia Campos.
65
66         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
67         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
68         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
69         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
70
71 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
72
73         [EFL] MiniBrowser didn't work after r191749.
74         https://bugs.webkit.org/show_bug.cgi?id=150706
75
76         Reviewed by Alex Christensen.
77
78         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
79
80         * Scripts/run-minibrowser:
81
82 2015-10-29  Commit Queue  <commit-queue@webkit.org>
83
84         Unreviewed, rolling out r191766.
85         https://bugs.webkit.org/show_bug.cgi?id=150707
86
87         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
88
89         Reverted changeset:
90
91         "[Win] build-jsc and run-javascriptcore-tests do not work"
92         https://bugs.webkit.org/show_bug.cgi?id=150700
93         http://trac.webkit.org/changeset/191766
94
95 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
96
97         [Win] build-jsc and run-javascriptcore-tests do not work
98         https://bugs.webkit.org/show_bug.cgi?id=150700
99
100         Reviewed by Mark Lam.
101         
102         Correct our build system so that it expects Windows to be using CMake,
103         and to build the correct sub-projects for our JSC helper scripts.
104
105         * Scripts/build-jsc: Make sure to build the testapi harness when
106           building for Windows.
107         * Scripts/build-webkit:
108           (1) Use the existing 'cmakeBasedPortName()'
109           (2) Use File::Spec rather than hard-coding path delimeters.
110           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
111         method rather than hard-coding the name based on conditional.
112         * Scripts/run-javascriptcore-tests:
113         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
114         * Scripts/run-jsc: Ditto.
115         * Scripts/webkitdirs.pm:
116         (cmakeBasedPortName): Update to return the right value for the Apple
117         Windows port and the WinCairo port.
118         (isCMakeBuild): Expect CMake build for all Windows ports.
119
120 2015-10-29  Alex Christensen  <achristensen@webkit.org>
121
122         Fix build-jsc on Mac after r191749.
123
124         * Scripts/build-jsc:
125         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
126
127 2015-10-29  Alex Christensen  <achristensen@webkit.org>
128
129         Fix Mac CMake build
130         https://bugs.webkit.org/show_bug.cgi?id=150686
131
132         Reviewed by Filip Pizlo.
133
134         * Scripts/build-webkit:
135         * Scripts/webkitdirs.pm:
136         (isCachedArgumentfileOutOfDate):
137         (wrapperPrefixIfNeeded):
138         (generateBuildSystemFromCMakeProject):
139         (buildCMakeGeneratedProject):
140         (cmakeBasedPortName):
141         (determineIsCMakeBuild):
142         (isCMakeBuild):
143         (promptUser):
144         (jhbuildWrapperPrefixIfNeeded): Deleted.
145
146 2015-10-29  Lucas Forschler  <lforschler@apple.com>
147
148         Teach JSC bots to build 32bit instead of x86_64
149         
150         Reviewed by Mark Lam.
151
152         * BuildSlaveSupport/build.webkit.org-config/config.json:
153
154 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
155
156         [WinCairo] Fall back to AppleWin results in layout tests.
157         https://bugs.webkit.org/show_bug.cgi?id=150672
158
159         Reviewed by Alex Christensen.
160
161         * Scripts/webkitpy/port/win.py:
162         (WinCairoPort):
163         (WinCairoPort.default_baseline_search_path):
164
165 2015-10-28  Keith Rollin  <krollin@apple.com>
166
167         Do not sanitize user input for input[type=url]
168         https://bugs.webkit.org/show_bug.cgi?id=150346
169         <rdar://problem/23243240>
170
171         Reviewed by Brent Fulgham.
172
173         The Windows version of DumpRenderTree's eventSender.keyDown handler
174         simulates user-entry by decomposing the given character into a virtual
175         key code and a set of modifier keys. The code that determines if the
176         shift key should be simulated only worked if the character was an
177         upper case character. Extend this support to also include symbols that
178         (on the U.S. keyboard) require holding down the shift key.
179
180         This change allows fast/forms/input-user-input-sanitization.html
181         to succeed, which requires us to simulate the entering of '@' and ':'.
182
183         * DumpRenderTree/win/EventSender.cpp:
184         (keyDownCallback):
185
186 2015-10-28  Alex Christensen  <achristensen@webkit.org>
187
188         Compile and link with CMake on Mac
189         https://bugs.webkit.org/show_bug.cgi?id=150632
190
191         Reviewed by Tim Horton.
192
193         * TestWebKitAPI/PlatformMac.cmake:
194
195 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
196
197         Unreviewed.
198
199         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
200
201 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
202
203         Add WinCairo to list of ports in run-webkit-tests.
204         https://bugs.webkit.org/show_bug.cgi?id=150625
205
206         Reviewed by Brent Fulgham.
207
208         * Scripts/webkitpy/common/config/ports.py:
209         (DeprecatedPort.port):
210         (WinPort.run_webkit_tests_command):
211         (WinCairoPort):
212         (GtkWK2Port):
213         * Scripts/webkitpy/port/factory.py:
214         (PortFactory):
215         * Scripts/webkitpy/port/win.py:
216         (WinPort.find_system_pid):
217         (WinCairoPort):
218
219 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
220
221         WebKitTestRunner leaks in generateWhitelist()
222         https://bugs.webkit.org/show_bug.cgi?id=150563
223
224         Reviewed by Andreas Kling.
225
226         * WebKitTestRunner/mac/TestControllerMac.mm:
227         (WTR::generateWhitelist):
228
229 2015-10-27  Anders Carlsson  <andersca@apple.com>
230
231         Add an API test for _WKRemoteObjectRegistry
232         https://bugs.webkit.org/show_bug.cgi?id=150597
233
234         Reviewed by Andreas Kling.
235
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
238         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
239         (TEST):
240         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
241         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
242         (-[RemoteObjectRegistryPlugIn sayHello:]):
243
244 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
245
246         Add myself to the reviewers list
247         https://bugs.webkit.org/show_bug.cgi?id=150581
248
249         Unreviewed.
250
251         * Scripts/webkitpy/common/config/contributors.json:
252
253 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
254
255         Adding myself to contributors.json
256
257         * Scripts/webkitpy/common/config/contributors.json:
258
259 2015-10-26  Tim Horton  <timothy_horton@apple.com>
260
261         Don't expose the whitelist/blacklist in _WKUserStyleSheet
262         https://bugs.webkit.org/show_bug.cgi?id=150566
263
264         Reviewed by Anders Carlsson.
265
266         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
267         (TEST):
268
269 2015-10-26  Philippe Normand  <pnormand@igalia.com>
270
271         Unreviewed, rolling out r191576.
272
273         broke
274
275         Reverted changeset:
276
277         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
278         https://bugs.webkit.org/show_bug.cgi?id=149594
279         http://trac.webkit.org/changeset/191576
280
281 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
282
283         [GStreamer] Bump internal jhbuild versions to 1.6.0
284         https://bugs.webkit.org/show_bug.cgi?id=149594
285
286         Reviewed by Philippe Normand.
287
288         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
289         useful so they are removed accordingly.
290
291         * gtk/jhbuild.modules:
292         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
293         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
294         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
295
296 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
297
298         API tests fail on El Capitan after r191543
299         https://bugs.webkit.org/show_bug.cgi?id=150547
300
301         Reviewed by Dan Bernstein.
302
303         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
304
305 2015-10-24  Tim Horton  <timothy_horton@apple.com>
306
307         Add a way to add user style sheets to WKUserContentController
308         https://bugs.webkit.org/show_bug.cgi?id=150531
309         <rdar://problem/23191691>
310
311         Reviewed by Darin Adler.
312
313         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
314         (TEST):
315
316 2015-10-24  Tim Horton  <timothy_horton@apple.com>
317
318         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
319         https://bugs.webkit.org/show_bug.cgi?id=150525
320
321         Reviewed by Darin Adler.
322
323         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
324         (TEST):
325         Test the various new keys.
326
327 2015-10-24  Frederic Wang  <fred.wang@free.fr>
328
329         check-webkit-style complains about missing operator whitespace inside character literal
330         https://bugs.webkit.org/show_bug.cgi?id=150396
331
332         Reviewed by Darin Adler.
333
334         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
335         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
336         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
337
338 2015-10-23  Michael Saboff  <msaboff@apple.com>
339
340         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
341         https://bugs.webkit.org/show_bug.cgi?id=150513
342
343         Reviewed by Saam Barati.
344
345         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
346
347         * DumpRenderTree/TestRunner.cpp:
348         (simulateWebNotificationClickCallback):
349         (failNextCodeBlock):
350         (numberOfDFGCompiles):
351         (TestRunner::staticFunctions):
352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
354         (WTR::TestRunner::setBlockAllPlugins):
355         (WTR::TestRunner::failNextCodeBlock):
356         (WTR::TestRunner::numberOfDFGCompiles):
357         * WebKitTestRunner/InjectedBundle/TestRunner.h:
358
359 2015-10-23  Anders Carlsson  <andersca@apple.com>
360
361         Simplify the WebKitLegacy menu conversion code
362         https://bugs.webkit.org/show_bug.cgi?id=150509
363
364         Reviewed by Andreas Kling.
365
366         Implement the context menu delegate method so we'll test that code path.
367
368         * MiniBrowser/mac/WK1BrowserWindowController.m:
369         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
370
371 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
372
373         [WinCairo] Improve test results for fast layouttests.
374         https://bugs.webkit.org/show_bug.cgi?id=150464
375
376         Reviewed by Alex Christensen.
377
378         Set custom device scale factor to 1.0.
379
380         * DumpRenderTree/win/DumpRenderTree.cpp:
381         (createWebViewAndOffscreenWindow):
382
383 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
384
385         [GTK] update-webkitgtk-libs should use mesa tarball
386
387         https://bugs.webkit.org/show_bug.cgi?id=150470
388
389         update-webkitgtk-libs downloads all build dependencies; in fixing
390         bug 148941 mesa was switched from ftp to git access.  Now an http
391         tarball is available, which is preferred over accessing via git.
392
393         Reviewed by Philippe Normand
394
395         * gtk/jhbuild.modules:
396         Mesa access changed to http tarball.
397
398 2015-10-22  Sam Weinig  <sam@webkit.org>
399
400         Navigations on the same host (but with different schemes and ports) should not trigger universal links
401         <rdar://problem/22811325>
402         https://bugs.webkit.org/show_bug.cgi?id=150481
403
404         Reviewed by Dan Bernstein.
405
406         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
407         Update test to test that navigations on the same host but with different schemes does not
408         trigger universal links, but that changes in the host do.
409
410 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
411
412         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
413         https://bugs.webkit.org/show_bug.cgi?id=150428
414
415         Reviewed by Antti Koivisto.
416
417         Added a regression test using WebKit API test.
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
421         (TestWebKitAPI::didFinishLoadForFrame):
422         (TestWebKitAPI::TEST):
423
424 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         Unreviewed. Fix GTK+ build after r191423.
427
428         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
429
430         * gtk/webkitdom.py:
431         (WebKitDOMDocGenerator):
432
433 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
434
435         [Win][EFL][GTK] webkitpy test failed after r191374.
436         https://bugs.webkit.org/show_bug.cgi?id=150433
437
438         Reviewed by Alexey Proskuryakov.
439
440         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
441         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
442         (CrashLogsTest.test_find_log_darwin): Same.
443
444 2015-10-21  Brian Burg  <bburg@apple.com>
445
446         Unreviewed, update watchlist for JS builtins.
447
448         Add a category for JS builtins code generator, similar to other generators.
449
450         Add a nag message to rebaseline builtins generator tests when touching
451         code generator files in Source/JavaScriptCore/Scripts/builtins/.
452
453         * Scripts/webkitpy/common/config/watchlist:
454
455 2015-10-21  Brian Burg  <bburg@apple.com>
456
457         Restructure generate-js-bindings script to be modular and testable
458         https://bugs.webkit.org/show_bug.cgi?id=149929
459
460         Reviewed by Alex Christensen.
461
462         Add a stub shell script and basic webkitpy support for running builtins
463         generator tests.
464
465         * Scripts/run-builtins-generator-tests: Added.
466         (main):
467         * Scripts/webkitpy/codegen/__init__.py: Added.
468         * Scripts/webkitpy/codegen/main.py: Added.
469
470             The only interesting difference here from the inspector protocol
471             generator equivalent is that this implementation decodes the target
472             framework and output mode (combined or separate) from the test's file name.
473
474         (BuiltinsGeneratorTests):
475         (BuiltinsGeneratorTests.__init__):
476         (BuiltinsGeneratorTests.generate_from_js_builtins):
477         (BuiltinsGeneratorTests.write_error_file):
478         (BuiltinsGeneratorTests.detect_changes):
479         (BuiltinsGeneratorTests.run_tests):
480         (BuiltinsGeneratorTests.main):
481
482 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
483
484         run-webkit-tests does not copy all crash logs for layout test failures on Mac
485         https://bugs.webkit.org/show_bug.cgi?id=150407
486         <rdar://problem/22239750>
487
488         Reviewed by Alexey Proskuryakov.
489
490         * Scripts/webkitpy/port/mac.py:
491         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
492         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
493         the log directory.
494         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
495         from log directory and merge them with the list of already crashed tests.
496
497 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
498
499         Failures in PutStackSinkingPhase should be less severe
500         https://bugs.webkit.org/show_bug.cgi?id=150400
501
502         Reviewed by Geoffrey Garen.
503
504         Add a test mode for no PutStackSinkingPhase.
505
506         * Scripts/run-jsc-stress-tests:
507
508 2015-10-21  Nan Wang  <n_wang@apple.com>
509
510         AX: Expose table size and cell indexes on iOS
511         https://bugs.webkit.org/show_bug.cgi?id=150366
512
513         Reviewed by Chris Fleizach.
514
515         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
516         (AccessibilityUIElement::rowCount):
517         (AccessibilityUIElement::columnCount):
518         (AccessibilityUIElement::indexInTable):
519         (AccessibilityUIElement::numberAttributeValue):
520         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
521         (WTR::AccessibilityUIElement::numberAttributeValue):
522         (WTR::AccessibilityUIElement::rowCount):
523         (WTR::AccessibilityUIElement::columnCount):
524         (WTR::AccessibilityUIElement::indexInTable):
525
526 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
527
528         W3C test importer should not import reference files as regular tests
529         https://bugs.webkit.org/show_bug.cgi?id=150331
530
531         Reviewed by Darin Adler.
532
533         Updated test_parser to return information that a file can be a referencefile or a manual test.
534         Updated test importer to skip those files.
535         Updated/Added test parser unit tests accordingly.
536
537         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
538         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
539         to mark these files as Skip, since they are not direct tests. 
540
541         * Scripts/webkitpy/w3c/test_importer.py:
542         (TestImporter.__init__):
543         (TestImporter.find_importable_tests):
544         (TestImporter.import_tests):
545         * Scripts/webkitpy/w3c/test_parser.py:
546         (TestParser.analyze_test):
547         * Scripts/webkitpy/w3c/test_parser_unittest.py:
548         (test_analyze_non_html_file):
549         (test_reference_test):
550
551 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
552
553         run-webkit-tests does not copy all crash logs for layout test failures on iOS
554         https://bugs.webkit.org/show_bug.cgi?id=150056
555         <rdar://problem/9280656>
556
557         Reviewed by Alexey Proskuryakov.
558
559         * Scripts/webkitpy/common/system/crashlogs.py:
560         (CrashLogs.find_all_logs): Generic method to find all crash logs.
561         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
562         It iterates through log directory and returns all the logs based on timestamp.
563         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
564         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
565         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
566         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
567         * Scripts/webkitpy/layout_tests/controllers/manager.py:
568         (Manager.run): Modified start_time to start counting before simulator launch
569         so that we can capture crashes during simualator launch.
570         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
571         any test which is not already marked as CRASH to the run_results.
572         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
573         (TestExpectationsModel.get_expectations_string): return PASS in case there
574         are no expectations defined for this test.
575         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
576         (summarize_results): Add other_crashes in a separte category in full_results.json.
577         * Scripts/webkitpy/port/ios.py:
578         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
579         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
580         from the log directory.
581         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
582         logs from log directory and merge them with the list of already crashed tests.
583
584 2015-10-20  Dana Burkart  <dburkart@apple.com>
585
586         Fix the build
587
588         Unreviewed.
589
590         My previous patch was missing a necessary space character.
591
592         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
593
594 2015-10-20  Dana Burkart  <dburkart@apple.com>
595
596         svn-apply fails to apply binary diffs in some cases
597         https://bugs.webkit.org/show_bug.cgi?id=64647
598
599         Reviewed by Daniel Bates.
600
601         * Scripts/VCSUtils.pm:
602         (decodeGitBinaryPatchDeltaSize): Modified.
603         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
604         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
605
606 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
607
608         Mac Debug EWS never finishes when there are failures
609         https://bugs.webkit.org/show_bug.cgi?id=150334
610
611         Reviewed by Daniel Bates.
612
613         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
614         * Scripts/webkitpy/tool/commands/queues.py:
615
616 2015-10-20  Philippe Normand  <pnormand@igalia.com>
617
618         [GTK] Enable OpenWebRTC test video/audio sources in tests
619
620         This is needed because we can't expect the buildbots to have
621         webcam/mic devices plugged in.
622
623         Rubber-stamped by Carlos Garcia Campos.
624
625         * Scripts/run-gtk-tests:
626         (TestRunner._setup_testing_environment):
627         * Scripts/webkitpy/port/gtk.py:
628         (GtkPort.setup_environ_for_server):
629
630 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
631
632         Rename the PICTURE_SIZES flag to CURRENTSRC
633         https://bugs.webkit.org/show_bug.cgi?id=150275
634
635         Reviewed by Dean Jackson.
636
637         * Scripts/webkitperl/FeatureList.pm:
638
639 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
640
641         Unreviewed, add myself to the committers list.
642
643         * Scripts/webkitpy/common/config/contributors.json:
644
645 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
646
647         Add new EWS queues to bot watcher's dashboard
648         https://bugs.webkit.org/show_bug.cgi?id=150297
649
650         Reviewed by Darin Adler.
651
652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
653         (BubbleQueueServer):
654
655 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
656
657         REGRESSION(r190262): User media unit test failures after r190262
658         https://bugs.webkit.org/show_bug.cgi?id=149580
659
660         Reviewed by Carlos Garcia Campos.
661
662         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
663         So we do not need to skip them anymore.
664
665         * Scripts/run-gtk-tests:
666         (TestRunner): Deleted.
667
668 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
669
670         Add historical addresses to contributors.json
671         https://bugs.webkit.org/show_bug.cgi?id=150227
672
673         Reviewed by Darin Adler.
674
675         * Scripts/webkitpy/common/config/contributors.json:
676
677 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
678
679         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
680         https://bugs.webkit.org/show_bug.cgi?id=150307
681
682         Reviewed by Brent Fulgham.
683
684         The DLL build rules have been changed to generate "{Name}Lib.DLL",
685         but these changes have not yet been applied to the Visual Studio builds.
686
687         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
688
689 2015-10-16  Andreas Kling  <akling@apple.com>
690
691         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
692         <https://webkit.org/b/150153>
693
694         Unreviewed.
695
696         Just use simple arrays of LChar and UChar for this test instead of creating String
697         objects and then getting the characters8()/characters16() from them, since that
698         doesn't guarantee null-termination (the bug.)
699
700         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
701         (TestWebKitAPI::TEST):
702         (TestWebKitAPI::build): Deleted.
703
704 2015-10-16  Tim Horton  <timothy_horton@apple.com>
705
706         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
707         https://bugs.webkit.org/show_bug.cgi?id=150255
708
709         Reviewed by Simon Fraser.
710
711         * Scripts/run-api-tests:
712         (runTest):
713         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
714         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
715         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
716         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
717         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
718         Don't set the layout size until after the load finishes and we're waiting
719         for the reply, so that there is no race between the new size coming in
720         and us waiting for it.
721
722 2015-10-16  Anders Carlsson  <andersca@apple.com>
723
724         WebEditingDelegate should be a formal protocol
725         https://bugs.webkit.org/show_bug.cgi?id=150254
726         <rdar://problem/23149847>
727
728         Reviewed by Dan Bernstein.
729
730         * DumpRenderTree/mac/EditingDelegate.h:
731         Conform to the WebEditingDelegate protocol.
732
733 2015-10-16  Tim Horton  <timothy_horton@apple.com>
734
735         Hook up autolayout intrinsic sizing for WKWebView
736         https://bugs.webkit.org/show_bug.cgi?id=150219
737         <rdar://problem/20016905>
738
739         Reviewed by Simon Fraser.
740
741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
743         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
744         (-[AutoLayoutWKWebView load:expectingContentSize:]):
745         (-[AutoLayoutWKWebView expectContentSizeChange:]):
746         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
747         (TEST):
748         Add a variety of tests, including one which catches the bug that
749         the WebCore part of this patch fixes.
750
751 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
752
753         Update the help message of --system-malloc
754         https://bugs.webkit.org/show_bug.cgi?id=150169
755
756         Reviewed by Geoffrey Garen.
757
758         * Scripts/webkitperl/FeatureList.pm:
759
760 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
761
762         Update ImportExpectations according currently imported wpt tests
763         https://bugs.webkit.org/show_bug.cgi?id=150158
764
765         Reviewed by Chris Dumez.
766
767         * Scripts/webkitpy/w3c/test_downloader.py:
768         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
769
770 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
771
772         Unreviewed, Update my email address.
773
774         * Scripts/webkitpy/common/config/contributors.json:
775
776 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
777
778         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
779         https://bugs.webkit.org/show_bug.cgi?id=84960
780
781         Reviewed by Žan Doberšek.
782
783         * Scripts/run-gtk-tests:
784         (TestRunner): Unskip tests using SessionState.
785         * TestWebKitAPI/PlatformGTK.cmake: Add
786         WKPageCopySessionStateWithFiltering test.
787
788 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
789
790         [GTK] Missing return value on TestWebExtensions.cpp:193
791         https://bugs.webkit.org/show_bug.cgi?id=149755
792
793         Unreviewed. Add missing return value.
794
795         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
796         (permissionRequestCallback):
797
798 2015-10-14  Andy Estes  <aestes@apple.com>
799
800         [iOS] build-dumprendertree does not build ImageDiff
801         https://bugs.webkit.org/show_bug.cgi?id=150152
802
803         Reviewed by Tim Horton.
804
805         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
806         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
807         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
808         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
809
810         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
811         fine on that platform, and results in ImageDiff being built.
812
813         * Scripts/build-dumprendertree:
814
815 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
816
817         [Win] Enforce launcher/library naming scheme
818         https://bugs.webkit.org/show_bug.cgi?id=150124
819
820         Reviewed by Alex Christensen.
821
822         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
823         * MiniBrowser/win/CMakeLists.txt: Ditto.
824         * TestWebKitAPI/PlatformWin.cmake: Ditto.
825         * win/DLLLauncher/DLLLauncherMain.cpp:
826         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
827         original {name}.dll.
828
829 2015-10-14  Andreas Kling  <akling@apple.com>
830
831         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
832         <https://webkit.org/b/150135>
833
834         Reviewed by Geoffrey Garen.
835
836         Add a new WTF API test that covers this issue.
837
838         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
839         (TestWebKitAPI::build):
840         (TestWebKitAPI::TEST):
841
842 2015-10-14  Alex Christensen  <achristensen@webkit.org>
843
844         Add SPI for reloading without content blockers
845         https://bugs.webkit.org/show_bug.cgi?id=150058
846         rdar://problem/22742222
847
848         Reviewed by Sam Weinig.
849
850         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
851         (WTR::TestController::cocoaResetStateToConsistentValues):
852         * WebKitTestRunner/mac/TestControllerMac.mm:
853         (WTR::TestController::platformConfigureViewForTest):
854
855 2015-10-14  Mark Lam  <mark.lam@apple.com>
856
857         Rename some JSC option names to be more uniform.
858         https://bugs.webkit.org/show_bug.cgi?id=150127
859
860         Reviewed by Geoffrey Garen.
861
862         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
863         * Scripts/run-jsc-stress-tests:
864
865 2015-10-14  Anders Carlsson  <andersca@apple.com>
866
867         Change the bundle app cache APIs to take a page
868         https://bugs.webkit.org/show_bug.cgi?id=150123
869
870         Reviewed by Sam Weinig.
871
872         Update APIs.
873
874         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
875         (WTR::InjectedBundle::beginTesting):
876         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
877         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
879         (WTR::TestRunner::clearAllApplicationCaches):
880         (WTR::TestRunner::clearApplicationCacheForOrigin):
881         (WTR::TestRunner::setAppCacheMaximumSize):
882         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
883         (WTR::TestRunner::originsWithApplicationCache):
884
885 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
886
887         Update web-platform-tests tools to the latest revision
888         https://bugs.webkit.org/show_bug.cgi?id=149645
889
890         Reviewed by Darin Adler.
891
892         Disabling git submodules information conversion to json install file for web-platform-tests.
893         Disabling related python unit tests.
894         The tools submodules contain submodules and the conversion tool does not support that yet.
895
896         Updating wpt launcher script to aling it with web-platform-test main script.
897
898         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
899         (main):
900         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
901         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
902         * Scripts/webkitpy/w3c/test_importer_unittest.py:
903         (TestImporterTest.test_submodules_generation):
904
905 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
906
907         More debug queue build fixing.
908
909         Preserve the build style in one more place. Changed mock build_style from "both"
910         to "release", as we don't support testing both debug and release.
911
912         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
913         (MockCommitQueue.archive_last_test_results):
914         (MockCommitQueue):
915         (MockCommitQueue.build_style):
916         (MockCommitQueue.did_pass_testing_ews):
917         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
918         (PatchAnalysisTask._test):
919         (PatchAnalysisTask._build_and_test_without_patch):
920         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
921         (EarlyWarningSystemTest._default_expected_logs):
922         * Scripts/webkitpy/tool/commands/queues_unittest.py:
923
924 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
925
926         More debug queue build fixing.
927
928         Add build_style argument to derived classes as well.
929
930         * Scripts/webkitpy/common/config/ports.py:
931         (MacPort):
932         (MacPort.run_webkit_tests_command):
933         (WinPort.run_bindings_tests_command):
934         (WinPort):
935         (WinPort.run_webkit_tests_command):
936         (GtkWK2Port.build_webkit_command):
937         (GtkWK2Port):
938         (GtkWK2Port.run_webkit_tests_command):
939
940 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
941
942         [iOS] Build fix
943
944         Unreviewed.
945
946         Mach-O section names are limited to 16 characters.
947
948         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
949         * DumpRenderTree/mac/DumpRenderTree.mm:
950         (activateFontsIOS):
951
952 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
953
954         Build fix for mac-debug EWS queue.
955
956         Unreviewed.
957
958         Pass --debug to run-webkit-tests.
959
960         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
961         will need to be substantially modified to work in EWS, so the dummy implementation
962         was not helpful.
963
964         * Scripts/webkitpy/common/config/ports.py:
965         (DeprecatedPort.run_javascriptcore_tests_command):
966         (DeprecatedPort):
967         (DeprecatedPort.run_webkit_tests_command):
968         (DeprecatedPort.run_python_unittests_command):
969         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
970         * Scripts/webkitpy/common/config/ports_mock.py:
971         (MockPort.run_javascriptcore_tests_command):
972         (MockPort):
973         (MockPort.run_webkit_tests_command):
974         (MockPort.run_bindings_tests_command):
975         (MockPort.run_webkit_unit_tests_command): Deleted.
976         * Scripts/webkitpy/tool/commands/download_unittest.py:
977         * Scripts/webkitpy/tool/steps/runtests.py:
978         (RunTests.run):
979         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
980         (RunTestsTest.test_webkit_run_unit_tests):
981         * Scripts/webkitpy/tool/steps/steps_unittest.py:
982         (StepsTest.test_runtests_args):
983
984 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
985
986         [Win] Generate Crash Traces
987         https://bugs.webkit.org/show_bug.cgi?id=150103
988
989         Reviewed by Daniel Bates.
990
991         We were using an exception filter to try to emit "#CRASHED" to stderr
992         when a test program crashed. However, the modern Python implementation
993         seems capable of recognizing crashes on its own. Furthermore, registering
994         the exception handler was preventing the JIT debugger (NTSD) from
995         automatically attaching to the crashing program, so we were not getting
996         crash traces.
997         
998         * DumpRenderTree/win/DumpRenderTree.cpp:
999         (main): Don't register an exception filter.
1000         (exceptionFilter): Deleted.
1001         * Scripts/webkitpy/common/system/crashlogs.py:
1002         (CrashLogs): Add another regular expression to handle a second crash trace
1003         syntax I encountered during testing.
1004         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1005         try the new one. The PID found by the new expression is in hexadecimal, so
1006         convert it to an integer before returning it.
1007         * Scripts/webkitpy/port/driver.py:
1008         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1009         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1010         check for "#CRASHED" after stripping off the EOL characters.
1011         * Scripts/webkitpy/port/win.py:
1012         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1013         invocation. This is apparently used to signal an event when the debugger is finished.
1014
1015 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1016
1017         Mac Debug and 32-bit queues should be separate
1018         https://bugs.webkit.org/show_bug.cgi?id=150092
1019
1020         Reviewed by Lucas Forschler.
1021
1022         * QueueStatusServer/config/queues.py:
1023         * QueueStatusServer/model/queues.py:
1024         (Queue._capitalize_after_dash):
1025         (Queue._caplitalize_after_dash): Deleted.
1026         * Scripts/webkitpy/common/config/ews.json:
1027
1028 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1029
1030         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1031         https://bugs.webkit.org/show_bug.cgi?id=150085
1032
1033         Reviewed by Carlos Garcia Campos.
1034
1035         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1036
1037 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1038
1039         Unreviewed, add myself to the committers list.
1040
1041         * Scripts/webkitpy/common/config/contributors.json:
1042
1043 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1044
1045         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1046         https://bugs.webkit.org/show_bug.cgi?id=149983
1047
1048         Reviewed by Dan Bates.
1049
1050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1051         (BubbleQueueServer):
1052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1053
1054 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1055
1056         Fix webkitpy tests after r190922.
1057
1058         * Scripts/webkitpy/common/config/ews.json:
1059         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1060         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1061
1062 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1063
1064         Add a Mac debug EWS queue
1065         https://bugs.webkit.org/show_bug.cgi?id=150069
1066
1067         Reviewed by Geoffrey Garen.
1068
1069         * QueueStatusServer/config/queues.py:
1070         * Scripts/webkitpy/common/config/ews.json:
1071         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1072         (AbstractEarlyWarningSystem):
1073         (AbstractEarlyWarningSystem.archive_last_test_results):
1074         (AbstractEarlyWarningSystem.build_style):
1075         (AbstractEarlyWarningSystem.refetch_patch):
1076         (AbstractEarlyWarningSystem.load_ews_classes):
1077
1078 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1079
1080         [GTK] Update jhbuild's version of harfbuzz
1081         https://bugs.webkit.org/show_bug.cgi?id=149749
1082
1083         Reviewed by Martin Robinson.
1084
1085         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1086
1087         * gtk/jhbuild.modules: Updated details for harfbuzz.
1088
1089 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1090
1091         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1092         https://bugs.webkit.org/show_bug.cgi?id=150026
1093
1094         Reviewed by Philippe Normand.
1095
1096         Backport upstream patch from gst-plugins-bad so that the right version
1097         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1098         gets compiled properly, avoiding crashes on runtime while running tests.
1099
1100         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1101         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1102
1103 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1104
1105         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1106         https://bugs.webkit.org/show_bug.cgi?id=149777
1107
1108         Reviewed by Simon Fraser.
1109
1110         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1111         to the list of tests to preinstall at startup time.
1112
1113         Also, update the generation of the 'name' table in the FontWithFeatures font.
1114
1115         * DumpRenderTree/mac/DumpRenderTree.mm:
1116         (allowedFontFamilySet):
1117         (activateTestingFonts):
1118         (activateFontsIOS):
1119         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1120         (Generator::generate):
1121         (Generator::appendCFFTable):
1122         (Generator::appendNameSubtable):
1123         (Generator::appendNAMETable):
1124         * FontWithFeatures/FontWithFeatures/main.cpp:
1125         (main):
1126         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1127         (WTR::allowedFontFamilySet):
1128         (WTR::activateFonts):
1129         * WebKitTestRunner/mac/TestControllerMac.mm:
1130         (WTR::allowedFontFamilySet):
1131
1132 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1133
1134         Unreviewed. Add Jinyoung Hur as a committer. 
1135
1136         * Scripts/webkitpy/common/config/contributors.json:
1137
1138 2015-10-10  Dan Bernstein  <mitz@apple.com>
1139
1140         [iOS] Remove unnecessary iOS version checks
1141         https://bugs.webkit.org/show_bug.cgi?id=150002
1142
1143         Reviewed by Alexey Proskuryakov.
1144
1145         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1146         (-[HIDEventGenerator _createIOHIDEventType:]):
1147         (-[HIDEventGenerator _sendHIDEvent:]):
1148         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1149         * WebKitTestRunner/ios/UIKitSPI.h:
1150
1151 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1152
1153         Unreviewed, rolling out r190689
1154         https://bugs.webkit.org/show_bug.cgi?id=149992
1155
1156         Fixed in other repository.
1157
1158         Reverted changesets:
1159
1160         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1161         https://bugs.webkit.org/show_bug.cgi?id=149897
1162
1163 2015-10-09  Brian Burg  <bburg@apple.com>
1164
1165         Teach webkitperl how to figure out IOS versions from the SDK
1166         https://bugs.webkit.org/show_bug.cgi?id=149963
1167
1168         Reviewed by Daniel Bates.
1169
1170         It should be easier to check the major and minor version of IOS SDKs.
1171
1172         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1173         * Scripts/webkitdirs.pm:
1174         (splitVersionString): Added.
1175         (determineOSXVersion): Use splitVersionString.
1176         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1177         (iosVersion): Added.
1178
1179 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1180
1181         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1182         https://bugs.webkit.org/show_bug.cgi?id=149960
1183
1184         Reviewed by Tim Horton.
1185         
1186         Use adoptWK(), and null out some members (file is not using ARC).
1187
1188         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1189         (UIScriptContext::uiScriptComplete):
1190         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1191         (-[TestRunnerWKWebView dealloc]):
1192
1193 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1194
1195         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1196         https://bugs.webkit.org/show_bug.cgi?id=149954
1197
1198         Reviewed by Darin Adler.
1199
1200         * Scripts/webkitperl/FeatureList.pm:
1201
1202 2015-10-09  Daniel Bates  <dabates@apple.com>
1203
1204         Make iOS builders generate debug information in a separate dSYM file
1205         https://bugs.webkit.org/show_bug.cgi?id=149696
1206
1207         Reviewed by Darin Adler.
1208
1209         Similar to the Mac builders, the iOS builders should write debug information
1210         into a separate dSYM file instead of including such information in the binary
1211         itself (default Xcode behavior)
1212
1213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1214         (CompileWebKit.start):
1215
1216 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1217
1218         Fix webkitpy tests after r190779
1219         https://bugs.webkit.org/show_bug.cgi?id=149949
1220
1221         Reviewed by Ryosuke Niwa.
1222
1223         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1224         (BenchmarkResults.format):
1225         (BenchmarkResults._format_values):
1226
1227 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1228
1229         Extend run-benchmark script to support human-readable results conversion.
1230         https://bugs.webkit.org/show_bug.cgi?id=149944
1231
1232         Reviewed by Ryosuke Niwa.
1233
1234         Add '--read-results-json' and '--no-adjust-unit' options.
1235         '--read-results-json' option converts result file to human readable format.
1236         '--no-adjust-unit' option skips scientific notation convertion.
1237         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1238
1239         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1240         (BenchmarkResults.format):
1241         (BenchmarkResults._format_tests):
1242         (BenchmarkResults._format_values):
1243         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1244         (BenchmarkRunner.__init__):
1245         (BenchmarkRunner._run_benchmark):
1246         (BenchmarkRunner._dump):
1247         (BenchmarkRunner.show_results):
1248         (BenchmarkRunner._show_results): Deleted.
1249         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1250         (parse_args):
1251         (start):
1252
1253 2015-10-08  Daniel Bates  <dabates@apple.com>
1254
1255         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1256         https://bugs.webkit.org/show_bug.cgi?id=149945
1257
1258         Reviewed by Dan Bernstein.
1259
1260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1264         (WebKitBuildbot):
1265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1266         (table.queue-grid tr.platform.ios-9 img.logo):
1267
1268 2015-10-08  Daniel Bates  <dabates@apple.com>
1269
1270         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1271         https://bugs.webkit.org/show_bug.cgi?id=149943
1272
1273         Reviewed by Dan Bernstein.
1274
1275         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1276         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1277
1278         * Scripts/build-webkit:
1279
1280 2015-10-08  Daniel Bates  <dabates@apple.com>
1281
1282         Add LLVM binaries for iOS 9 device
1283         https://bugs.webkit.org/show_bug.cgi?id=149913
1284
1285         Reviewed by Filip Pizlo.
1286
1287         Implement support for building LLVM for ARM64-based iOS devices.
1288
1289         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1290         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1291         an existing build earlier in the file such that remove previously built
1292         libraries before building/copying new ones (if applicable).
1293         (fileContains): Moved function outside of if-block.
1294         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1295         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1296         added logic to build LLVM for ARM64-based iOS devices.
1297         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1298         LLVM into the WebKitBuild directory.
1299
1300 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1301
1302         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1303         https://bugs.webkit.org/show_bug.cgi?id=149848
1304
1305         Reviewed by Darin Adler.
1306
1307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1308
1309 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1310
1311         [Win] Support 64-bit Build and Testing
1312         https://bugs.webkit.org/show_bug.cgi?id=149904
1313
1314         Reviewed by Daniel Bates.
1315
1316         Extend our existing scripts to support 64-bit build and test operations on
1317         Windows.
1318
1319         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1320         Windows always builds the whole stack.
1321         * Scripts/webkit-build-directory: Add an option to return the location of
1322         the executable files produced by a specific configuration. This change is
1323         actually useful for Gtk and EFL, too.
1324         * Scripts/webkitdirs.pm:
1325         (executableProductDir): Added. This function appends the proper binary
1326         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1327         (jscProductDir): Use the new 'executableProductDir' method.
1328         (setPathForRunningWebKitApp): Ditto.
1329         (runSafari): Ditto.
1330         (runMiniBrowser): Ditto.
1331         * Scripts/webkitpy/port/factory.py:
1332         (configuration_options): Add a 64-bit option, used on Windows to specify
1333         which binary target should be used for testing.
1334         * Scripts/webkitpy/port/win.py:
1335         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1336         processes when needed.
1337         (WinPort._build_path): Add the correct binary target path to _build_path.
1338         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1339         64-bit paths for 64-bit tests.
1340         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1341         NTSD debugger does not understand this argument.
1342
1343 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1344
1345         Test font-variant-* and font-feature-settings with TrueType fonts
1346         https://bugs.webkit.org/show_bug.cgi?id=149776
1347
1348         Reviewed by Simon Fraser.
1349
1350         This test extends our existing FontWithFeatures project to be able to generate a
1351         TrueType font. This font is conceptually similar as the existing OpenType font,
1352         except the feature -> character mapping is different.
1353
1354         The font itself only supports the following characters:
1355         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1356         However, the shape of these letters are either an X or a check mark.
1357         The letter "A" always is a check mark.
1358         The letter "B" always is an X.
1359         Each font feature has an letter associated with it. When the font feature is enabled,
1360         that letter is shown as a check mark. For example, when
1361         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1362         mark.
1363
1364         Here are the mappings of font features to letters:
1365         kLigaturesType / kCommonLigaturesOnSelector: C
1366         kLigaturesType / kContextualLigaturesOnSelector: D
1367         kLigaturesType / kRareLigaturesOnSelector: G
1368         kLigaturesType / kHistoricalLigaturesOnSelector: I
1369         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1370         kVerticalPositionType / kInferiorsSelector: O
1371         kVerticalPositionType / kSuperiorsSelector: P
1372         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1373         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1374         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1375         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1376         kLetterCaseType / 14: Y
1377         kStyleOptionsType / kTitlingCapsSelector: a
1378         kNumberCaseType / kUpperCaseNumbersSelector: c
1379         kNumberCaseType / kLowerCaseNumbersSelector: d
1380         kNumberSpacingType / kProportionalNumbersSelector: f
1381         kNumberSpacingType / kMonospacedNumbersSelector: g
1382         kFractionsType / kDiagonalFractionsSelector: i
1383         kFractionsType / kVerticalFractionsSelector: j
1384         kVerticalPositionType / kOrdinalsSelector: Q
1385         kTypographicExtrasType / kSlashedZeroOnSelector: k
1386         kLigaturesType / kHistoricalLigaturesOnSelector: K
1387         kCharacterShapeType / kJIS1978CharactersSelector: m
1388         kCharacterShapeType / kJIS1983CharactersSelector: n
1389         kCharacterShapeType / kJIS1990CharactersSelector: o
1390         kCharacterShapeType / kJIS2004CharactersSelector: p
1391         kCharacterShapeType / kSimplifiedCharactersSelector: q
1392         kCharacterShapeType / kTraditionalCharactersSelector: r
1393         kTextSpacingType / kMonospacedTextSelector: t
1394         kTextSpacingType / kProportionalTextSelector: u
1395         kRubyKanaType / kRubyKanaOnSelector: v
1396
1397         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1398         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1399         (CFFBuilder::moveTo):
1400         (CFFBuilder::lineTo):
1401         (GLYFBuilder::GLYFBuilder):
1402         (GLYFBuilder::takeResult):
1403         (GLYFBuilder::moveTo):
1404         (GLYFBuilder::lineTo):
1405         (GLYFBuilder::closePath):
1406         (GLYFBuilder::writePoint):
1407         (GLYFBuilder::append16):
1408         (generateBoxCharString):
1409         (generateCheckCharString):
1410         (generateXCharString):
1411         (itemForGlyph):
1412         (Generator::generate):
1413         (Generator::insertSelector):
1414         (Generator::insertFeature):
1415         (Generator::generateFeatureDescription):
1416         (Generator::appendCFFTable):
1417         (Generator::appendGLYFTable):
1418         (Generator::appendLOCATable):
1419         (Generator::appendFEATTable):
1420         (Generator::appendMetamorphosisChain):
1421         (Generator::appendMORXTable):
1422         (Generator::appendHEADTable):
1423         (Generator::appendHMTXTable):
1424         (Generator::appendNameSubtable):
1425         (Generator::append2ByteASCIIString):
1426         (Generator::appendNAMETable):
1427         (generateFont):
1428         (CFFBuilder::curveToCubic): Deleted.
1429         (charStringForGlyph): Deleted.
1430         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1431         * FontWithFeatures/FontWithFeatures/main.cpp:
1432         (constructFontWithTrueTypeFeature):
1433         (constructFontWithOpenTypeFeature):
1434         (drawText):
1435         (main):
1436         (drawTextWithFeature): Deleted.
1437
1438 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1439
1440         Unreviewed, rolling out r190572, r190593, r190594, and
1441         r190639.
1442         https://bugs.webkit.org/show_bug.cgi?id=149897
1443
1444         Breaks Mavericks build (Requested by litherum on #webkit).
1445
1446         Reverted changesets:
1447
1448         "Allow WKRetainPtrs to be used as keys in hashing data
1449         structures"
1450         https://bugs.webkit.org/show_bug.cgi?id=149762
1451         http://trac.webkit.org/changeset/190572
1452
1453         "REGRESSION(189668?): http/tests/notifications/events.html
1454         flakily asserts or times out"
1455         https://bugs.webkit.org/show_bug.cgi?id=149218
1456         http://trac.webkit.org/changeset/190593
1457
1458         "Prospective Mavericks build fix."
1459         http://trac.webkit.org/changeset/190594
1460
1461         "Post-review cleanup after r190572."
1462         http://trac.webkit.org/changeset/190639
1463
1464 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1465
1466         [GTK] Add autocleanups
1467         https://bugs.webkit.org/show_bug.cgi?id=149588
1468
1469         Reviewed by Darin Adler.
1470
1471         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1472         (AutocleanupsTest::create):
1473         (AutocleanupsTest::testWebProcessAutocleanups):
1474         (registerTests):
1475         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1476         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1477         (testUIProcessAutocleanups):
1478         (testWebProcessAutocleanups):
1479         (beforeAll):
1480         (afterAll):
1481
1482 2015-10-06  Brian Burg  <bburg@apple.com>
1483
1484         Unreviewed, try to fix the iOS 8 build after r190368.
1485
1486         On older versions, IOHIDEventCreateForceEvent is not available.
1487
1488         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1489         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1490
1491 2015-10-06  Keith Miller  <keith_miller@apple.com>
1492
1493         Add gmalloc option to run-javascriptcore-tests.
1494         https://bugs.webkit.org/show_bug.cgi?id=149858
1495
1496         Reviewed by Geoffrey Garen.
1497
1498         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1499         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1500
1501         * Scripts/run-javascriptcore-tests:
1502
1503 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1504
1505         Post-review cleanup after r190572.
1506
1507         Unreviewed.
1508
1509         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1510
1511 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1512
1513         [Win] Unreviewed build correction.
1514
1515         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1516         are soft-linked at runtime.
1517
1518 2015-10-06  Keith Miller  <keith_miller@apple.com>
1519
1520         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1521         https://bugs.webkit.org/show_bug.cgi?id=149815
1522
1523         Reviewed by Filip Pizlo.
1524
1525         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1526         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1527         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1528         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1529         so should just use one test runner.
1530
1531         * Scripts/run-javascriptcore-tests:
1532         (runJSCStressTests):
1533         (runMozillaTests): Deleted.
1534         (defaultJsDriverArgsForMozillaTests): Deleted.
1535         * Scripts/run-jsc-stress-tests:
1536
1537 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1538
1539         [GTK] Make update-webkitgtk-libs work behind firewall
1540
1541         update-webkitgtk-libs can work behind a firewall with changes to
1542         a few packages.  Where outbound git and active FTP connections
1543         fail, using http protocol succeeds.  Most packages are
1544         already accessed using http.
1545
1546         https://bugs.webkit.org/show_bug.cgi?id=148941
1547
1548         Reviewed by Martin Robinson.
1549
1550         Tools
1551         * gtk/jhbuild.modules:
1552             Replace git URLs with http.  Remove no longer used ftp repositories.
1553             Update argument for libxml2's autogen.sh script (--without-python
1554             is ignored; --with-python=no is correct).
1555         * jhbuild/jhbuild-wrapper:
1556             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1557             http://git.gnome.org/browse/jhbuild.
1558
1559 2015-10-06  Daniel Bates  <dbates@webkit.org>
1560
1561         Enable XSLT when building WebKit for iOS using the public iOS SDK
1562         https://bugs.webkit.org/show_bug.cgi?id=149827
1563
1564         Reviewed by Alexey Proskuryakov.
1565
1566         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1567         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1568         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1569         headers cannot be found.
1570
1571         * Scripts/configure-xcode-for-ios-development:
1572         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1573
1574 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1575
1576         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1577         https://bugs.webkit.org/show_bug.cgi?id=149218
1578
1579         Reviewed by Alexey Proskuryakov.
1580
1581         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1582         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1583         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1584         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1585         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1586         WebNotificationProvider must be updated to appropriately handle multiple
1587         WKNotificationManagerRefs in flight at the same time.
1588
1589         * WebKitTestRunner/WebNotificationProvider.cpp:
1590         (WTR::WebNotificationProvider::~WebNotificationProvider):
1591         (WTR::WebNotificationProvider::showWebNotification):
1592         (WTR::WebNotificationProvider::closeWebNotification):
1593         (WTR::WebNotificationProvider::addNotificationManager):
1594         (WTR::WebNotificationProvider::removeNotificationManager):
1595         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1596         (WTR::WebNotificationProvider::reset):
1597         * WebKitTestRunner/WebNotificationProvider.h:
1598
1599 2015-10-05  Daniel Bates  <dabates@apple.com>
1600
1601         Disable Bitcode when building for iOS device
1602         https://bugs.webkit.org/show_bug.cgi?id=149818
1603
1604         Reviewed by Alexey Proskuryakov.
1605
1606         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1607         when building for iOS device.
1608
1609         * Scripts/webkitdirs.pm:
1610         (XcodeOptions):
1611
1612 2015-10-05  Daniel Bates  <dabates@apple.com>
1613
1614         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1615         https://bugs.webkit.org/show_bug.cgi?id=140828
1616         <rdar://problem/19520599>
1617
1618         Reviewed by Alexey Proskuryakov.
1619
1620         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1621         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1622         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1623         to build-webkit.
1624
1625         * Scripts/webkitdirs.pm:
1626         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1627         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1628         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1629         (hasIOSDevelopmentCertificate): Added.
1630
1631 2015-10-05  Daniel Bates  <dabates@apple.com>
1632
1633         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1634         https://bugs.webkit.org/show_bug.cgi?id=149766
1635
1636         Reviewed by Alexey Proskuryakov.
1637
1638         Create network storage testing session on iOS.
1639
1640         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1641         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1642         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1643         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1644         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1645         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1646         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1647         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1648         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1649
1650         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1651         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1652         returns a non-null pointer to a cookie store.
1653
1654         * DumpRenderTree/mac/DumpRenderTree.mm:
1655         (prepareConsistentTestingEnvironment):
1656
1657 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1658
1659         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1660         available.
1661
1662         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1663         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1664
1665 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1666
1667         Allow WKRetainPtrs to be used as keys in hashing data structures
1668         https://bugs.webkit.org/show_bug.cgi?id=149762
1669
1670         Reviewed by Anders Carlsson.
1671
1672         * TestWebKitAPI/PlatformGTK.cmake:
1673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1674         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1675         (TestWebKitAPI::TEST):
1676
1677 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1678
1679         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1680         available, and tidy up the #ifdefs in the UIKitSPI header.
1681
1682         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1683         (-[HIDEventGenerator _sendHIDEvent:]):
1684         * WebKitTestRunner/ios/UIKitSPI.h:
1685
1686 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1687
1688         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1689         https://bugs.webkit.org/show_bug.cgi?id=149792
1690
1691         Reviewed by Martin Robinson.
1692
1693         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1694         for WebKitTestRunner multiple times.
1695
1696 2015-10-04  Daniel Bates  <dabates@apple.com>
1697
1698         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1699         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1700
1701         For now, support calling build-layouttestrelay without --ios-simulator so long
1702         as we are building on a Mac.
1703
1704         * Scripts/build-layouttestrelay:
1705
1706 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1707
1708         Support Trac 1.0.x XML timeline link format
1709         https://bugs.webkit.org/show_bug.cgi?id=149786
1710
1711         Reviewed by Lucas Forschler.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1714         (Trac.prototype._convertCommitInfoElementToObject):
1715
1716 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1717
1718         Fix some errors on bot watcher's dashboard
1719         https://bugs.webkit.org/show_bug.cgi?id=149789
1720
1721         Reviewed by Lucas Forschler.
1722
1723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1724         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1725         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1726
1727 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1728
1729         Bot watcher's dashboard builders should turn yellow when svn fails
1730         https://bugs.webkit.org/show_bug.cgi?id=149791
1731
1732         Reviewed by Lucas Forschler.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1735         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1736         (BuildbotBuilderQueueView.prototype.update):
1737
1738 2015-10-02  Daniel Bates  <dabates@apple.com>
1739
1740         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1741         https://bugs.webkit.org/show_bug.cgi?id=149769
1742
1743         Reviewed by Alexey Proskuryakov.
1744
1745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1749         (WebKitBuildbot):
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1751         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1752
1753 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1754
1755         REGRESSION(r190370): Speedometer spits out an extra console message
1756         https://bugs.webkit.org/show_bug.cgi?id=149720
1757
1758         Unreviewed. Temporarily ignore the console error message.
1759
1760         * Scripts/webkitpy/performance_tests/perftest.py:
1761         (PerfTest._filter_output):
1762
1763 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1764
1765         Provide "--no-ninja" option to avoid using Ninja
1766         https://bugs.webkit.org/show_bug.cgi?id=149757
1767
1768         Reviewed by Alex Christensen.
1769
1770         Add a new command line argument understood by webkitdirs.pm so
1771         that we can conditionally avoid using Ninja. This is an
1772         'opt-out' argument, so no existing Ninja users should be affected.
1773         
1774         * Scripts/webkitdirs.pm:
1775         (canUseNinja): Check for option and block ninja if present.
1776
1777 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1778
1779         Flakiness dashboard should support OS X El Capitan
1780         https://bugs.webkit.org/show_bug.cgi?id=149648
1781
1782         Reviewed by Alexey Proskuryakov.
1783
1784         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1785
1786 2015-10-02  Daniel Bates  <dabates@apple.com>
1787
1788         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1789         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1790
1791         For now, pass --ios-simulator.
1792
1793         * Scripts/webkitpy/port/ios.py:
1794         (IOSSimulatorPort._build_relay):
1795
1796 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1797
1798         Remove a "nullable" that breaks the iOS 8 build.
1799
1800         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1801         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1802
1803 2015-10-02  Daniel Bates  <dabates@apple.com>
1804
1805         LayoutTestRelay is not built and archived when building for iOS Simulator
1806         https://bugs.webkit.org/show_bug.cgi?id=149753
1807
1808         Reviewed by Alexey Proskuryakov and Andy Estes.
1809
1810         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1811         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1812         product archive when building for iOS Simulator, respectively.
1813
1814         * BuildSlaveSupport/built-product-archive:
1815         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1816         differentiate between iOS device and iOS Simulator platforms.
1817         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1818         from determineWebKitBuildDirectories() into this function so that it can be used by both
1819         determineWebKitBuildDirectories() and archiveBuiltProduct().
1820         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1821         webkitBuildDirectoryForConfigurationAndPlatform().
1822         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1823         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1824         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1825         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1826         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1827         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1828         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1829         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1830         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1831         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1832         * Scripts/build-layouttestrelay:
1833             - Remove unnecessary include of Perl module POSIX.
1834             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1835         * Scripts/build-webkit:
1836             - Invoke script build-layouttestrelay when building for iOS Simulator.
1837
1838 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1839
1840         [Win] Unreviewed test fix.
1841
1842         You cannot run 'run-webkit-tests' from the command line because it does not know
1843         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1844         because they explicitly set use the 'root' argument to provide the full path to
1845         the test binaries.
1846
1847         * Scripts/webkitpy/port/win.py:
1848         (WinPort._build_path): Added.
1849
1850 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1851
1852         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1853         https://bugs.webkit.org/show_bug.cgi?id=149430
1854         rdar://problem/22742222
1855
1856         Reviewed by Geoffrey Garen.
1857
1858         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1859         (WTR::TestController::cocoaResetStateToConsistentValues):
1860         * WebKitTestRunner/mac/TestControllerMac.mm:
1861         (WTR::TestController::platformConfigureViewForTest):
1862         Test what happens when you disable content blockers from the SPI.
1863
1864 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1865
1866         [Win] Unreviewed build fix for run-api-tests
1867
1868         * Scripts/run-api-tests:
1869         (testToolPaths): Windows run needs to specify the binary path.
1870
1871 2015-10-01  Daniel Bates  <dabates@apple.com>
1872
1873         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1874         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1875
1876         Following r190424 we can now rely on webkit-build-directory to return the path to
1877         the correct configuration-specific build directory on Windows.
1878
1879         * BuildSlaveSupport/built-product-archive:
1880         (archiveBuiltProduct):
1881
1882 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1883
1884         [Win] Unreviewed build fix.
1885
1886         * Scripts/webkitdirs.pm:
1887         (setupAppleWinEnv): Use 64-bit build tools if available
1888
1889 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1890
1891         [Win] Fix TestWebKitAPI build under CMake.
1892
1893         Reviewed by Alex Christensen.
1894
1895         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1896         for Psapi.lib.
1897
1898 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1899
1900         [Win] Fix behavior of webkit-build-directory script
1901         https://bugs.webkit.org/show_bug.cgi?id=149718
1902
1903         Reviewed by Alex Christensen.
1904
1905         * Scripts/webkitdirs.pm:
1906         (determineConfigurationProductDir): Do not include the binary
1907         sub-directory in the configuration product directory output.
1908         (jscProductDir): Append correct binary path for Windows build.
1909         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1910         (runSafari): Update for revised productDir behavior.
1911         (runMiniBrowser): Ditto.
1912
1913 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1914
1915         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1916         use iOS SDK, like with all the others.
1917
1918         * Scripts/build-webkit:
1919
1920 2015-10-01  Daniel Bates  <dabates@apple.com>
1921
1922         Attempt to fix the iOS 9 Simulator testers
1923
1924         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1925         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1926         LayoutTestRelay when building for iOS Simulator.
1927
1928         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1929         * Scripts/build-webkit:
1930
1931 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         [GTK] Websites with invalid auth header keep loading forever
1934         https://bugs.webkit.org/show_bug.cgi?id=149710
1935
1936         Reviewed by Martin Robinson.
1937
1938         Add test case to check that we can authenticate sites with an
1939         empty realm.
1940
1941         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1942         (testWebViewAuthenticationEmptyRealm):
1943         (serverCallback):
1944         (beforeAll):
1945
1946 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1947
1948         [Mac] Make run-api-tests work with System Integrity Protection
1949         https://bugs.webkit.org/show_bug.cgi?id=149711
1950         rdar://problem/22928202
1951
1952         Reviewed by Dan Bernstein.
1953
1954         * Scripts/run-api-tests:
1955         (runTest):
1956         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1957
1958 2015-10-01  Daniel Bates  <dabates@apple.com>
1959
1960         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1961         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1962
1963         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1964         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1965         specific build directory.
1966
1967         * BuildSlaveSupport/built-product-archive:
1968         (archiveBuiltProduct):
1969
1970 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1971
1972         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1973         https://bugs.webkit.org/show_bug.cgi?id=145837
1974
1975         Reviewed by Philippe Normand.
1976
1977         * efl/jhbuild.modules:
1978         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1979         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1980
1981 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1982
1983         Unreviewed. Fix the iOS build after r190407.
1984
1985         * WebKitTestRunner/ios/IOKitSPI.h:
1986
1987 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1988
1989         Implement keyboard event sending for iOS in WebKitTestRunner
1990         https://bugs.webkit.org/show_bug.cgi?id=149676
1991
1992         Reviewed by Simon Fraser.
1993
1994         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1995         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1996         allows us to run code when the keyboard is shown or hidden.
1997
1998         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1999         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2000         (WTR::UIScriptController::setDidShowKeyboardCallback):
2001         (WTR::UIScriptController::didShowKeyboardCallback):
2002         (WTR::UIScriptController::setDidHideKeyboardCallback):
2003         (WTR::UIScriptController::didHideKeyboardCallback):
2004         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2005         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2006         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2007         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2008         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2009         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2010         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2011                 the notifications that the keyboard has been raised or lowered.
2012         (-[TestRunnerWKWebView _keyboardDidShow:]):
2013         (-[TestRunnerWKWebView _keyboardDidHide:]):
2014         * WebKitTestRunner/ios/HIDEventGenerator.h:
2015         * WebKitTestRunner/ios/HIDEventGenerator.m:
2016         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2017         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2018         (hidUsageCodeForCharacter): Ditto.
2019         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2020                 a keyDown event in WebKit.
2021         * WebKitTestRunner/ios/IOKitSPI.h:
2022         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2023
2024 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2025
2026         Unreviewed, rolling out r190399.
2027
2028         Tests are still failing even after r190362
2029
2030         Reverted changeset:
2031
2032         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2033         http://trac.webkit.org/changeset/190399
2034
2035 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2036
2037         [jhbuild] switch to new upstream usrsctp library
2038         https://bugs.webkit.org/show_bug.cgi?id=149494
2039
2040         Reviewed by Philippe Normand.
2041
2042         * efl/jhbuild.modules:
2043         * gtk/jhbuild.modules:
2044
2045 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2046
2047         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2048
2049         They should pass now.
2050
2051         * Scripts/run-gtk-tests:
2052         (TestRunner):
2053
2054 2015-09-30  Daniel Bates  <dabates@apple.com>
2055
2056         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2057         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2058
2059         * BuildSlaveSupport/built-product-archive:
2060         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2061         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2062
2063 2015-09-30  Daniel Bates  <dabates@apple.com>
2064
2065         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2066         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2067
2068         Actually, we need to pass --configuration to script webkit-build-directory to have
2069         it return the path to the configuration-specific build directory.
2070
2071         * BuildSlaveSupport/built-product-archive:
2072         (determineWebKitBuildDirectories):
2073
2074 2015-09-30  Daniel Bates  <dabates@apple.com>
2075
2076         built-product-archive archives incorrect build directory for iOS port
2077         https://bugs.webkit.org/show_bug.cgi?id=149695
2078
2079         Reviewed by Darin Adler.
2080
2081         Fixes an issue where the script built-product-archive archives a non-existent
2082         build directory for the iOS port. Without loss of generality, the script assumes
2083         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2084         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2085
2086         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2087         to determine the top-level build directory and computes the configuration-specific
2088         build directory to be the concatenation of the the top-level build directory and
2089         the configuration (e.g. Release). This is incorrect. Instead we should call
2090         webkit-build-directory omitting the flag --top-level to compute the path to the
2091         configuration-specific build directory.
2092
2093         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2094         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2095         its purpose and added global variable _configurationBuildDirectory to store the path
2096         to the configuration-specific build directory. Ensure that we have a non-empty string
2097         for both the top-level and configuration-specific build directories.
2098         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2099         Compute the configuration-specific build directory and store it in the global variable
2100         _configurationBuildDirectory.
2101         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2102         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2103         as needed.
2104         (determineWebKitBuildDirectory): Deleted.
2105
2106 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2107
2108         [EFL] css3/device-adapt/* tests failed after r190335.
2109         https://bugs.webkit.org/show_bug.cgi?id=149655
2110
2111         Reviewed by Simon Fraser.
2112
2113         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2114         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2115
2116         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2117         (WTR::shouldUseFixedLayout):
2118
2119 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2120
2121         Extend JetStream timeout for slow devices.
2122
2123         Reviewed by Chris Dumez.
2124
2125         Extend JetStream timeout to 20 minutes.
2126
2127         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2128
2129 2015-09-30  Daniel Bates  <dabates@apple.com>
2130
2131         Rename iOS builders/testers to include version
2132         https://bugs.webkit.org/show_bug.cgi?id=149685
2133
2134         Reviewed by Simon Fraser.
2135
2136         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2137         make it clear to a reader the version of iOS these builders/testers are using.
2138
2139         * BuildSlaveSupport/build.webkit.org-config/config.json:
2140         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2141
2142 2015-09-30  Daniel Bates  <dabates@apple.com>
2143
2144         Add iOS criterion for triggering a build
2145         https://bugs.webkit.org/show_bug.cgi?id=149679
2146
2147         Rubber-stamped by Alexey Proskuryakov.
2148
2149         First pass at defining criterion for triggering an iOS build.
2150
2151         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2152         (_should_file_trigger_build):
2153         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2154         (ShouldBuildTest):
2155         (ShouldBuildTest.test_should_build):
2156
2157 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2158
2159         [iOS] Allow tests to generate user gestures for UI testing
2160         https://bugs.webkit.org/show_bug.cgi?id=149653
2161
2162         Reviewed by Tim Horton.
2163
2164         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2165         and to listen for completion of scrolling and zooming in the WKWebView.
2166         
2167         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2168         which hides the complexity of creating these events. Event dispatch is asynchronous.
2169         We detect when the last event has been handled by dispatching a vendor-specific event,
2170         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2171         
2172         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2173         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2174         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2175         single and double taps.
2176         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2177         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2178         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2179         (UIScriptContext::unregisterCallback):
2180         (UIScriptContext::callbackWithID):
2181         (UIScriptContext::fireCallback):
2182         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2183         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2184         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2185         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2186         (WTR::UIScriptController::setDidEndZoomingCallback):
2187         (WTR::UIScriptController::didEndZoomingCallback):
2188         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2189         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2190         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2191         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2192         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2193         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2194         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2195         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2196         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2197         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2198         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2199         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2200         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2201         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2202         (simpleDragCurve):
2203         (calculateNextLocation):
2204         (delayBetweenMove):
2205         (+[HIDEventGenerator sharedHIDEventGenerator]):
2206         (+[HIDEventGenerator nextEventCallbackID]):
2207         (-[HIDEventGenerator init]):
2208         (-[HIDEventGenerator _createIOHIDEventType:]):
2209         (-[HIDEventGenerator _sendHIDEvent:]):
2210         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2211         (-[HIDEventGenerator _updateTouchPoints:count:]):
2212         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2213         (-[HIDEventGenerator touchDown:touchCount:]):
2214         (-[HIDEventGenerator touchDown:]):
2215         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2216         (-[HIDEventGenerator liftUp:touchCount:]):
2217         (-[HIDEventGenerator liftUp:]):
2218         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2219         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2220         (-[HIDEventGenerator tap:completionBlock:]):
2221         (-[HIDEventGenerator doubleTap:completionBlock:]):
2222         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2223         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2224         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2225         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2226         (-[HIDEventGenerator markerEventReceived:]):
2227         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2228         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2229         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2230         (WTR::globalToContentCoordinates):
2231         (WTR::UIScriptController::singleTapAtPoint):
2232         (WTR::UIScriptController::doubleTapAtPoint):
2233         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2234         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2235         * WebKitTestRunner/ios/mainIOS.mm:
2236         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2237
2238 2015-09-30  Dana Burkart  <dburkart@apple.com>
2239
2240         git-add-reviewer should trim trailing spaces/newlines
2241         https://bugs.webkit.org/show_bug.cgi?id=149513
2242
2243         Reviewed by Darin Adler.
2244
2245         * Scripts/git-add-reviewer:
2246         (nonInteractive):
2247
2248 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2249
2250         REGRESSION(r190262): User media unit test failures after r190262
2251         https://bugs.webkit.org/show_bug.cgi?id=149580
2252
2253         Reviewed by Darin Adler.
2254
2255         * WebKitTestRunner/TestController.cpp:
2256         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2257           order to WKUserMediaPermissionRequestAllow.
2258
2259 2015-09-30  Daniel Bates  <dabates@apple.com>
2260
2261         Add iOS builders and testers
2262         https://bugs.webkit.org/show_bug.cgi?id=149549
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2267         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2268
2269         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2270         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2271
2272 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2273
2274         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2275         https://bugs.webkit.org/show_bug.cgi?id=149674
2276
2277         Reviewed by Lucas Forschler.
2278
2279         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2280         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2281
2282 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2283
2284         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2285         have an associated trac instance.
2286         https://bugs.webkit.org/show_bug.cgi?id=149673
2287
2288         Reviewed by Alexey Proskuryakov.
2289
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2291         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2292         have an associated trac instance.
2293
2294 2015-09-30  Daniel Bates  <dabates@apple.com>
2295
2296         Prioritize testing latest build request on iOS test bots
2297         https://bugs.webkit.org/show_bug.cgi?id=149669
2298
2299         Reviewed by Darin Adler.
2300
2301         We should prioritize testing of the latest build request on the iOS test bots
2302         as we do for Mac and Windows test bots.
2303
2304         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2305         (loadBuilderConfig):
2306
2307 2015-09-30  Daniel Bates  <dabates@apple.com>
2308
2309         Add buildbot category for iOS builders and testers
2310         https://bugs.webkit.org/show_bug.cgi?id=149667
2311
2312         Reviewed by Darin Adler.
2313
2314         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2315         for iOS to the build.webkit.org home page.
2316
2317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2318         (loadBuilderConfig):
2319         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2320
2321 2015-09-30  Daniel Bates  <dabates@apple.com>
2322
2323         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2324         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2325
2326         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2327         in <http://trac.webkit.org/changeset/190351>.
2328
2329         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2330         (CompileWebKit.start):
2331
2332 2015-09-30  Daniel Bates  <dabates@apple.com>
2333
2334         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2335         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2336
2337         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2338         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2339
2340         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2341         (CompileWebKit.start):
2342
2343 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2344
2345         bot210 was configured for a queue instead of bot126.
2346         
2347         Unreviewed config.json fix.
2348         
2349         * BuildSlaveSupport/build.webkit.org-config/config.json:
2350
2351 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2352
2353         Bring El Capitan buildbot infrastructure online.
2354         https://bugs.webkit.org/show_bug.cgi?id=149605
2355         
2356         Reviewed by Darin Adler.
2357
2358         * BuildSlaveSupport/build.webkit.org-config/config.json:
2359
2360 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2361
2362         [GTK] Deprecation warnings in DOMNodeTest
2363         https://bugs.webkit.org/show_bug.cgi?id=149663
2364
2365         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2366         need to update the tests to use webkit_dom_document_query_selector_all
2367         to avoid compilation warnings.
2368
2369         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2370         (the suggested replacement for the deprecated function).
2371
2372         Reviewed by Carlos Garcia Campos.
2373
2374         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2375         (WebKitDOMNodeTest::testTagNamesNodeList):
2376         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2377         (registerTests):
2378         (WebKitDOMNodeTest::testTagNames): Deleted.
2379         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2380         (prepareDOMForTagNamesTests):
2381         (testWebKitDOMNodeTagNamesNodeList):
2382         (testWebKitDOMNodeTagNamesHTMLCollection):
2383         (beforeAll):
2384         (testWebKitDOMNodeTagNames): Deleted.
2385
2386 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2387
2388         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2389         https://bugs.webkit.org/show_bug.cgi?id=149650
2390
2391         Reviewed by Tim Horton.
2392         
2393         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2394         looks at the file path, and not the custom options that come from file comments.
2395         
2396         Fix by computing TestOptions before making the TestInvocation, and setting them
2397         as const TestInvocation data. This meant changing various call sites to take
2398         the std::string pathOrURL, rather than the TestInvocation itself.
2399         
2400         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2401
2402         * WebKitTestRunner/CMakeLists.txt:
2403         * WebKitTestRunner/TestController.cpp:
2404         (WTR::TestController::ensureViewSupportsOptionsForTest):
2405         (WTR::testPath):
2406         (WTR::createTestURL):
2407         (WTR::updateTestOptionsFromTestHeader):
2408         (WTR::TestController::testOptionsForTest):
2409         (WTR::TestController::updateWebViewSizeForTest):
2410         (WTR::TestController::updateWindowScaleForTest):
2411         (WTR::TestController::runTest):
2412         * WebKitTestRunner/TestController.h:
2413         * WebKitTestRunner/TestInvocation.cpp:
2414         (WTR::TestInvocation::TestInvocation):
2415         (WTR::TestInvocation::invoke):
2416         (WTR::createWKURL): Deleted.
2417         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2418         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2419         * WebKitTestRunner/TestInvocation.h:
2420         (WTR::TestInvocation::options):
2421         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2422         (WTR::pathContains):
2423         (WTR::shouldMakeViewportFlexible):
2424         (WTR::shouldUseFixedLayout):
2425         (WTR::isSVGTestPath):
2426         (WTR::isHiDPITestPath):
2427         (WTR::TestOptions::TestOptions):
2428         * WebKitTestRunner/TestOptions.h:
2429         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2430         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2431         (WTR::pathContains):
2432         (WTR::shouldUseFixedLayout):
2433         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2434         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2435         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2436         * WebKitTestRunner/ios/TestControllerIOS.mm:
2437         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2438         * WebKitTestRunner/mac/TestControllerMac.mm:
2439         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2440
2441 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2442
2443         Flakiness dashboard should support OS X El Capitan
2444         https://bugs.webkit.org/show_bug.cgi?id=149648
2445
2446         Reviewed by Alexey Proskuryakov.
2447
2448         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2449         difference between new appscale and old Google App Engine implementation.
2450         * TestResultServer/app.yaml: Same.
2451         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2452
2453 2015-09-29  Daniel Bates  <dabates@apple.com>
2454
2455         configure-xcode-for-ios-development does not work with Xcode 7
2456         https://bugs.webkit.org/show_bug.cgi?id=149640
2457
2458         Reviewed by Alexey Proskuryakov.
2459
2460         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2461         because it cannot find the Xcode specification files for iOS simulator and device. These
2462         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2463         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2464         new specification files with the added definitions (as we did in older versions of Xcode)
2465         in order for Xcode 7 to honor these definitions.
2466
2467         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2468         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2469         (updateXcode7SpecificationFile): Added.
2470         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2471         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2472         appropriate success message.
2473         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2474         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2475         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2476
2477 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2478
2479         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2480         https://bugs.webkit.org/show_bug.cgi?id=149639
2481
2482         Reviewed by Alex Christensen.
2483
2484         * Scripts/VCSUtils.pm:
2485         (exitStatus): Use 'isWindows()' method.
2486         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2487         an error. This method could probably just go away.
2488         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2489         always changing to Unix style. 
2490         (unixPath): Added. Needed so Windows can always show a Unix path in the
2491         ChangeLog file.
2492         (changeLogName): Work around the fact that 'getpwuid' is not available on
2493         a pure Windows build of Perl.
2494         * Scripts/prepare-ChangeLog:
2495         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2496         path on Windows.
2497         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2498         support using arrays for 'open' arguments.
2499         (resolveChangeLogsPath): Ditto.
2500         (resolveConflictedChangeLogs): Use new helper functions.
2501         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2502         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2503         quotes. Unix systems are happy either way.
2504         (statusCommand): Ditto.
2505         * Scripts/webkitdirs.pm:
2506         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2507
2508 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2509
2510         [Win] Unreviewed 64-bit build fix after switch to CMake.
2511
2512         * Scripts/webkitdirs.pm:
2513         (determineIsWin64FromArchitecture): Added.
2514
2515 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2516
2517         printing does not use minimum page zoom factor
2518         https://bugs.webkit.org/show_bug.cgi?id=108507
2519
2520         Reviewed by Darin Adler.
2521
2522         WebKitTestRunner always takes the snapshots from the UI process
2523         (expect for IOS), so in the case of printing, the layout in the
2524         web view is not the expected one. When printing, we need to take
2525         the snapshot in the web process and ensure it's rendered with a
2526         PrintContext.
2527
2528         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2529         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2530         kWKSnapshotOptionsPrinting option to
2531         WKBundlePageCreateSnapshotWithOptions() when printing.
2532
2533 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2534
2535         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2536         https://bugs.webkit.org/show_bug.cgi?id=149595
2537
2538         Reviewed by Tim Horton.
2539
2540         All ports except IOS implement
2541         PlatformWebView::windowSnapshotImage() to generate the snapshot
2542         for the pixel tests in the UI process. But we are still generating
2543         a snapshot for pixel tests in the Web process too, that is passed
2544         to the UI process but ignored.
2545         Whether a pixel result is needed or not, is only known by the web
2546         process depending on whether the test called dumpAsText with
2547         dumpPixels == true or not. Since the pixels are now dump in the UI
2548         process, we need to pass that information to the UI process when
2549         the test is done. For that we set a PixelResultIsPending bool
2550         parameter to the Done message, and we only add the PixelResult
2551         when UI process doesn't need to generate the pixels dump.
2552
2553         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2554         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2555         m_pixelResultIsPending to false on reset.
2556         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2557         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2558         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2559         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2560         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2561         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2562         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2563         port.
2564         * WebKitTestRunner/TestInvocation.cpp:
2565         (WTR::TestInvocation::dumpResults): Use either the pixel result
2566         from the web process or generate a pixel result from the web view
2567         if need it.
2568         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2569         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2570         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2571         is created by the caller now, but the CG implementation needs to
2572         know if it's a Web or UI process snapshot.
2573         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2574         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2575         cairo surface for the given image.
2576         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2577         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2578         CGContext for the given image.
2579
2580 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2581
2582         Fix JS errors on dashboard metrics page
2583         https://bugs.webkit.org/show_bug.cgi?id=149608
2584
2585         Reviewed by Alexey Proskuryakov.
2586
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2588         (initPlatformsByFamily): 
2589         (updateHiddenPlatforms):
2590         (parsePlatformFamily): Deleted.
2591         (updateToggleButtons): Deleted.
2592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2593         (updateHiddenPlatforms): Added to remove errors.
2594         (initPlatformsByFamily): Added to remove errors.
2595         (unhiddenQueues): Updated to use Settings.
2596         (documentReady): Added logic to add toggle buttons to the settings menu.
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2598         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2599         MetricsMain.js to Settings.
2600         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2601         MetricsMain.js to Settings.
2602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2603         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2604
2605 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2606
2607         Appscale query fails because of missing index
2608         https://bugs.webkit.org/show_bug.cgi?id=149609
2609
2610         Reviewed by Darin Adler.
2611
2612         * QueueStatusServer/index.yaml: Added the required index.
2613
2614 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2615
2616         [Win] Fix the 64-bit build after switch to cmake.
2617
2618         Reviewed by Alex Christensen.
2619
2620         * Scripts/webkitdirs.pm:
2621         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2622         run a 64-bit build.
2623
2624 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2625
2626         [Win] Allow Windows to run test-webkitpy without Cygwin
2627         https://bugs.webkit.org/show_bug.cgi?id=149602
2628
2629         Reviewed by Alex Christensen.
2630
2631         These changes mostly shift from hard-coded paths using UNIX-style
2632         separators to Python's "os.path.join" syntax that uses the correct
2633         path separator for each platform.
2634         
2635         * Scripts/webkitpy/common/system/path.py:
2636         (cygpath): Don't pass paths through Cygpath on native Windows.
2637         * Scripts/webkitpy/port/win.py:
2638         (WinPort._path_to_apache): Use os.path.join.
2639         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2640         in 64-bit environments).
2641         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2642         * Scripts/webkitpy/style/checker_unittest.py:
2643         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2644         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2645         (GlobalVariablesTest): Ditto.
2646         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2647         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2648         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2649         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2650         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2651         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2652         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2653         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2654         (StyleProcessor_CodeCoverageTest): Ditto.
2655         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2656         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2657         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2658         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2659         manual string concatenation of paths.
2660
2661 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2662
2663         Add bugzilla addresses of committers to contributors.json
2664         https://bugs.webkit.org/show_bug.cgi?id=149520
2665
2666         Reviewed by Darin Adler.
2667
2668         * Scripts/webkitpy/common/config/contributors.json:
2669
2670 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2671
2672         validate-committer-lists -b shouldn't need edituser privileges
2673         https://bugs.webkit.org/show_bug.cgi?id=149519
2674
2675         Reviewed by Darin Adler.
2676
2677         * Scripts/validate-committer-lists:
2678         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2679         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2680         (BugzillaQueries.is_invalid_bugzilla_email):
2681         (BugzillaQueries): Deleted.
2682         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2683
2684 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2685
2686         Unreviewed. Gardening: skip media stream tests failing after r190262.
2687
2688         * Scripts/run-gtk-tests:
2689         (TestRunner):
2690
2691 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2692
2693         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2694         https://bugs.webkit.org/show_bug.cgi?id=149571
2695
2696         Reviewed by Dan Bernstein.
2697
2698         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2699
2700         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2701         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2702         * LayoutTestRelay/Configurations/Base.xcconfig:
2703         * MiniBrowser/Configurations/Base.xcconfig:
2704         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2705         * TestWebKitAPI/Configurations/Base.xcconfig:
2706         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2707         * WebEditingTester/Configurations/Base.xcconfig:
2708         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2709         * WebKitTestRunner/Configurations/Base.xcconfig:
2710         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2711         * WebKitTestRunner/iOS.xcconfig: Removed.
2712
2713 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2714
2715         Clean up user media request internal API
2716         https://bugs.webkit.org/show_bug.cgi?id=149527
2717
2718         Reviewed by Tim Horton.
2719
2720         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2721         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2722
2723         * WebKitTestRunner/TestController.cpp:
2724         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2725
2726 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2727
2728         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2729         https://bugs.webkit.org/show_bug.cgi?id=149577
2730
2731         Reviewed by Tim Horton.
2732         
2733         When calling testRunner.runUIScript() from a page load event, the script could run
2734         in the UI process before the current remote layer tree transaction had been handled
2735         there. This meant that runUIScript() could query state which was about to change.
2736         
2737         Fix by delaying the execution of the UI script until a layer tree transaction has
2738         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2739
2740         * WebKitTestRunner/TestInvocation.cpp:
2741         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2742         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2743         * WebKitTestRunner/TestInvocation.h:
2744
2745 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2746
2747         [Mac] Media tests start to time out after a few days of bot uptime
2748         https://bugs.webkit.org/show_bug.cgi?id=149468
2749
2750         Reviewed by Darin Adler.
2751
2752         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2753         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2754         all temporary and cache files go to a custom location.
2755
2756         * Scripts/webkitpy/port/base.py:
2757         * Scripts/webkitpy/port/driver.py:
2758         * Scripts/webkitpy/port/mac.py:
2759         * Scripts/webkitpy/port/win.py:
2760         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2761
2762 2015-09-25  Dan Bernstein  <mitz@apple.com>
2763
2764         Removed MiniBrowser.entitlements.
2765
2766         Rubber-stamped by Anders Carlsson.
2767
2768         The entitlements weren’t used anyway.
2769
2770         * MiniBrowser/MiniBrowser.entitlements: Removed.
2771         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2772
2773 2015-09-24  Daniel Bates  <dabates@apple.com>
2774
2775         Add WebKitSystemInterface for iOS 9.0
2776         https://bugs.webkit.org/show_bug.cgi?id=149550
2777
2778         Rubber-stamped by Alexey Proskuryakov.
2779
2780         * Scripts/copy-webkitlibraries-to-product-directory:
2781
2782 2015-09-24  Daniel Bates  <dabates@apple.com>
2783
2784         Support building for arbitrary architectures
2785         https://bugs.webkit.org/show_bug.cgi?id=149539
2786
2787         Reviewed by Alexey Proskuryakov.
2788
2789         Teach buildbot to pass the architectures associated with the builder to build-webkit
2790         when building on OS X and iOS. As a side effect of this change we now support building
2791         universal binaries when multiples architectures are specified.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2794         (CompileWebKit.start):
2795
2796 2015-09-24  Daniel Bates  <dabates@apple.com>
2797
2798         Fix the build after <http://trac.webkit.org/changeset/190212>
2799         (http://trac.webkit.org/changeset/190212)
2800
2801         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2802
2803         * BuildSlaveSupport/built-product-archive:
2804         (main):
2805
2806 2015-09-24  Daniel Bates  <dabates@apple.com>
2807
2808         Support running unit tests on iOS Simulator test bot
2809         https://bugs.webkit.org/show_bug.cgi?id=149536
2810
2811         Reviewed by Alexey Proskuryakov.
2812
2813         Implements support for running unit tests on a iOS test bot. At the time of writing,
2814         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2817         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2818         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2819
2820 2015-09-24  Daniel Bates  <dabates@apple.com>
2821
2822         Add support infrastructure for OpenSource iOS builders and testers
2823         https://bugs.webkit.org/show_bug.cgi?id=149534
2824
2825         Reviewed by Darin Adler.
2826
2827         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2828         scripts about iOS.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2831         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2832         --ios-simulator or --device for a builder/tester whose full platform name begins with
2833         "ios-simulator" or "ios", respectively.
2834         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2835         * BuildSlaveSupport/built-product-archive:
2836         (main): Pass the full platform name to determineWebKitBuildDirectory().
2837         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2838         command line flag when building for iOS.
2839         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2840         parameter fullPlatform. This parameter was originally added in r125066 to support the
2841         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2842         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2843         * BuildSlaveSupport/clean-build:
2844         (main): Call script webkit-build-directory with the appropriate command line flag when
2845         building for iOS.
2846         * BuildSlaveSupport/delete-stale-build-files:
2847         (main): Use the same logic for iOS as we do for Mac.
2848         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2849         flag when building for iOS.
2850         * BuildSlaveSupport/test-result-archive:
2851         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2852
2853 2015-09-24  Daniel Bates  <dabates@apple.com>
2854
2855         Remove Chromium-specific changes to script built-product-archive
2856         https://bugs.webkit.org/show_bug.cgi?id=149530
2857
2858         Rubber-stamped by Csaba Osztrogonác.
2859
2860         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2861         Chromium code has long since been removed from the OpenSource WebKit Project.
2862
2863         * BuildSlaveSupport/built-product-archive:
2864         (createZipManually):
2865         (createZip):
2866         (archiveBuiltProduct):
2867
2868 2015-09-24  Dan Bernstein  <mitz@apple.com>
2869
2870         Build fix.
2871
2872         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2873
2874 2015-09-24  Mark Lam  <mark.lam@apple.com>
2875
2876         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2877
2878         * Scripts/webkitpy/common/config/contributors.json:
2879
2880 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2881
2882         Unreviewed. Fix GObject DOM API breaks after r190120.
2883
2884         Bring back code removed in r169931 to handle documentation of
2885         deleted classes.
2886
2887         * gtk/webkitdom.py:
2888         (WebKitDOMDocGenerator):
2889         (WebKitDOMDocGenerator.write_deleted_classes):
2890         (WebKitDOMDocGenerator.generate):
2891         (write_deleted_classes):
2892         (WebKitDOMDocGeneratorSections._deleted_class):
2893         (WebKitDOMDocGeneratorSections._deleted_class.in):
2894         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2895         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2896
2897 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2898
2899         [Cocoa] [Font Features] Implement font-variant-*
2900         https://bugs.webkit.org/show_bug.cgi?id=148413
2901
2902         Reviewed by Darin Adler.
2903
2904         Update test font to use "lnum" feature.
2905
2906         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2907         (Generator::appendGSUBTable):
2908
2909 2015-09-22  Andy Estes  <aestes@apple.com>
2910
2911         ContentFiltering.AllowDownloadAfterAddData is very flaky
2912         https://bugs.webkit.org/show_bug.cgi?id=148885
2913         <rdar://problem/22729563>
2914
2915         Reviewed by Alexey Proskuryakov.
2916
2917         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2918         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2919         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2920
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2922         (downloadTest):
2923
2924 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2925
2926         Mavericks: Media tests start to time out after a few days of bot uptime
2927         https://bugs.webkit.org/show_bug.cgi?id=149468
2928
2929         Reviewed by Chris Dumez.
2930
2931         * Scripts/webkitpy/port/base.py:
2932         * Scripts/webkitpy/port/driver.py:
2933         * Scripts/webkitpy/port/mac.py:
2934
2935 2015-09-22  Nan Wang  <n_wang@apple.com>
2936
2937         Unreviewed, add myself to the committers list.
2938
2939         * Scripts/webkitpy/common/config/contributors.json:
2940
2941 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2942
2943         Remove 'nullable' to fix older iOS builds.
2944
2945         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2946         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2947
2948 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2949
2950         [Win] Show tiled drawing debug overlay on Windows
2951         https://bugs.webkit.org/show_bug.cgi?id=149426
2952
2953         Reviewed by Dean Jackson.
2954
2955         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2956         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2957         * MiniBrowser/win/Common.cpp:
2958         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2959         flag if needed.
2960         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2961
2962 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2963
2964         [Win] Use command-line argument to launch in regular or High DPI mode.
2965         https://bugs.webkit.org/show_bug.cgi?id=149417
2966
2967         Reviewed by Dean Jackson.
2968
2969         * MiniBrowser/win/Common.cpp:
2970         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2971         very start of execution, before the MiniBrowser.dll is loaded.
2972         * win/DLLLauncher/DLLLauncherMain.cpp:
2973         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2974         present. On WinCairo, always use High DPI.
2975
2976 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2977
2978         32-bit Mac build fix attempt after r190065.
2979
2980         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2981
2982 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2983
2984         [OS X] Update for Xcode 7.0 on Yosemite
2985         https://bugs.webkit.org/show_bug.cgi?id=149389
2986
2987         Reviewed by Dan Bernstein.
2988
2989         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2990         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2991         Removed unneeded declarations - conforming to a protocol is sufficient.
2992
2993         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2994         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2995         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2996         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2997
2998 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2999
3000         Add the ability for tests to run script in the UI process in WebKitTestRunner
3001         https://bugs.webkit.org/show_bug.cgi?id=149356
3002
3003         Reviewed by Tim Horton.
3004
3005         This change adds testRunner.runUIScript(script, callback), which allows a test
3006         to execute script in a JSContext which runs in the UI process. That context
3007         has bindings exposed through the UIScriptController interface; currently one test
3008         function, and some iOS-specific functions are included. UIScriptController can be
3009         async with a callback, and runUIScript() itself is asynchronous. When the UI 
3010         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3011         is a string passed back to the web process, and given to the runUIScript()
3012         callback function.
3013         
3014         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3015
3016         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3017         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3018         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3019         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3020         complete, call back into TestRunner.
3021         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3022         (WTR::nextUIScriptCallbackID):
3023         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3024         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3025         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3026         * WebKitTestRunner/PlatformWebView.h:
3027         * WebKitTestRunner/TestController.cpp:
3028         (WTR::updateTestOptionsFromTestHeader):
3029         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3030         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3031         * WebKitTestRunner/TestInvocation.cpp:
3032         (WTR::TestInvocation::shouldUseFixedLayout):
3033         (WTR::TestInvocation::shouldUseThreadedScrolling):
3034         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3035         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3036         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3037         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3038         * WebKitTestRunner/TestInvocation.h:
3039         * WebKitTestRunner/TestOptions.h:
3040         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3041         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3042         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3043         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3044         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3045         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3046         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3047         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3048         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3049         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3050         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3051         (WTR::UIScriptController::doAsyncTask):
3052         (WTR::UIScriptController::zoomToScale):
3053         (WTR::UIScriptController::zoomScale):
3054         (WTR::UIScriptController::minimumZoomScale):
3055         (WTR::UIScriptController::maximumZoomScale):
3056         (WTR::UIScriptController::contentVisibleRect):
3057         * WebKitTestRunner/mac/EventSenderProxy.mm:
3058         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3059         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3060         * WebKitTestRunner/mac/TestControllerMac.mm:
3061         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3062         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3063         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3064         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3065         (UIScriptContext::UIScriptContext):
3066         (UIScriptContext::~UIScriptContext):
3067         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3068         asynchronous, call the callback.
3069         (UIScriptContext::nextTaskCallbackID):
3070         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3071         that has a callback). Has to store the callbackID of the script, so code called from the completion
3072         callback knows which UI script invoked it.
3073         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3074         (UIScriptContext::uiScriptComplete):
3075         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3076         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3077         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3078         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3079         (WTR::UIScriptController::UIScriptController):
3080         (WTR::UIScriptController::makeWindowObject):
3081         (WTR::UIScriptController::wrapperClass):
3082         (WTR::UIScriptController::doAsyncTask):
3083         (WTR::UIScriptController::zoomToScale):
3084         (WTR::UIScriptController::zoomScale):
3085         (WTR::UIScriptController::minimumZoomScale):
3086         (WTR::UIScriptController::maximumZoomScale):
3087         (WTR::UIScriptController::contentVisibleRect):
3088         (WTR::UIScriptController::uiScriptComplete):
3089         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3090         (WTR::UIScriptController::create):
3091         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3092
3093 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3094
3095         Turn on threaded scrolling by default in the tests
3096         https://bugs.webkit.org/show_bug.cgi?id=149377
3097
3098         Reviewed by Simon Fraser.
3099
3100         * WebKitTestRunner/mac/TestControllerMac.mm:
3101         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3102         (WTR::shouldUseThreadedScrolling): Deleted.
3103         Turn on threaded scrolling by default.
3104
3105 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3106
3107         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3108         https://bugs.webkit.org/show_bug.cgi?id=149252
3109
3110         Reviewed by Darin Adler.
3111
3112         In case of glib tests the test runner notifies about tests
3113         crashing, but for google tests we don't get any feedback, which
3114         means that in case of a test crashing we get a list of **PASS**
3115         messages and at the summary we are notified that the test suite
3116         has failed, but it's impossible to know which test cases have failed.
3117
3118         * Scripts/run-gtk-tests:
3119         (TestRunner._run_google_test): Add a **CRASH** message if test
3120         case crashed.
3121
3122 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3123
3124         WebKitTestRunner can leak user content script results between tests
3125         https://bugs.webkit.org/show_bug.cgi?id=149391
3126
3127         Reviewed by Sam Weinig.
3128
3129         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3130         about:blank, and thus about:blank doesn't have unintended side effects.
3131
3132         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3133         (WTR::InjectedBundle::beginTesting):
3134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3135         (WTR::InjectedBundlePage::resetAfterTest):
3136
3137 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3138
3139         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3140         https://bugs.webkit.org/show_bug.cgi?id=149384
3141
3142         Reviewed by Chris Fleizach.
3143
3144         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3145         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3146         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3147         regardless of whether someone else holds a reference (we also call -stopListening in
3148         -dealloc).
3149
3150         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3151         (AccessibilityController::platformResetToConsistentState):
3152         (AccessibilityController::addNotificationListener):
3153         Ditto.
3154
3155 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3156
3157         Remove XHR_TIMEOUT compilation guard
3158         https://bugs.webkit.org/show_bug.cgi?id=149260
3159
3160         Reviewed by Benjamin Poulain.
3161
3162         * Scripts/webkitperl/FeatureList.pm:
3163
3164 2015-09-19  Dan Bernstein  <mitz@apple.com>
3165
3166         Attempted build fix.
3167
3168         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3169
3170 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3171
3172         Unreviewed, rolling out r189908.
3173         https://bugs.webkit.org/show_bug.cgi?id=149368
3174
3175         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3176
3177         Reverted changeset:
3178
3179         "printing does not use minimum page zoom factor"
3180         https://bugs.webkit.org/show_bug.cgi?id=108507
3181         http://trac.webkit.org/changeset/189908
3182
3183 2015-09-18  Andy Estes  <aestes@apple.com>
3184
3185         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3186         https://bugs.webkit.org/show_bug.cgi?id=149360
3187
3188         Reviewed by Tim Horton.
3189
3190         Added an API test.
3191
3192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3193         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3194         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3195         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3196         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3197         (TEST):
3198         * TestWebKitAPI/ios/pages.pages: Added.
3199
3200 2015-09-18  Nan Wang  <n_wang@apple.com>
3201
3202         AX: Implement ARIA 1.1 @aria-current on iOS
3203         https://bugs.webkit.org/show_bug.cgi?id=149297
3204
3205         Reviewed by Chris Fleizach.
3206
3207         Added support to test aria-current on iOS.
3208
3209         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3210         (AccessibilityUIElement::stringAttributeValue):
3211         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3212         (WTR::AccessibilityUIElement::stringAttributeValue):
3213
3214 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3215
3216         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3217         https://bugs.webkit.org/show_bug.cgi?id=149352
3218
3219         Reviewed by Simon Fraser.
3220
3221         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3222         m_context can be null. This may indicate a bug in webkitpy too, but
3223         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3224         wrong with opening and immediately closing it.
3225
3226 2015-09-18  Daniel Bates  <dabates@apple.com>
3227
3228         isGitSVNDirectory() returns true when Git is not installed
3229         https://bugs.webkit.org/show_bug.cgi?id=149351
3230
3231         Reviewed by Alexey Proskuryakov.
3232
3233         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3234         Git is not installed on the machine.
3235
3236         * Scripts/VCSUtils.pm:
3237         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3238         status code 0 (success).
3239
3240 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3241
3242         Prevent build-webkit from building four times on Windows 
3243         https://bugs.webkit.org/show_bug.cgi?id=149336
3244
3245         Reviewed by Brent Fulgham.
3246
3247         * Scripts/build-webkit:
3248         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3249         They're built all at once.
3250         * Scripts/webkitdirs.pm:
3251         (buildVisualStudioProject):
3252         (cmakeGeneratedBuildfile):
3253         Don't generate the Visual Studio solution if it already exists.
3254         It will run CMake again if necessary.
3255
3256 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3257
3258         [iOS WK2] WTR fails to set the key window in the UIKit sense
3259         https://bugs.webkit.org/show_bug.cgi?id=149325
3260
3261         Reviewed by Tim Horton.
3262
3263         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3264         This causes UIKit to bypass code that actually sets the key window, resulting in
3265         [UIAppliation sharedApplication].keyWindow always being nil.
3266
3267         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3268         -[WebKitTestRunnerWindow isKeyWindow] call super.
3269
3270         * WebKitTestRunner/PlatformWebView.h:
3271         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3272         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3273         (WTR::PlatformWebView::setWindowIsKey):
3274         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3275         (WTR::PlatformWebView::setWindowIsKey):
3276         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3277         (-[WebKitTestRunnerWindow isKeyWindow]):
3278         (WTR::PlatformWebView::PlatformWebView):
3279         (WTR::PlatformWebView::~PlatformWebView):
3280         (WTR::PlatformWebView::setWindowIsKey):
3281         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3282         (WTR::PlatformWebView::setWindowIsKey):
3283
3284 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3285
3286         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3287         https://bugs.webkit.org/show_bug.cgi?id=149321
3288
3289         Reviewed by Tim Horton.
3290         
3291         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3292         enabled the "testing" viewport configuration, which disables page scaling.
3293         
3294         If we're running viewport tests, we want the normal web page configuration.
3295         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3296         based on whether the test is in a "viewport" directory.
3297
3298         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3299         (WTR::InjectedBundle::beginTesting):
3300         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3301         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3302         * WebKitTestRunner/TestInvocation.cpp:
3303         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3304         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3305         (WTR::TestInvocation::shouldMakeViewportFlexible):
3306         (WTR::TestInvocation::invoke):
3307         * WebKitTestRunner/TestInvocation.h:
3308         * WebKitTestRunner/ios/TestControllerIOS.mm:
3309         (WTR::TestController::platformConfigureViewForTest):
3310         (WTR::shouldMakeViewportFlexible): Deleted.
3311
3312 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3313
3314         Give iOS WebKitTestRunner a launch storyboard
3315         https://bugs.webkit.org/show_bug.cgi?id=149314
3316
3317         Reviewed by Dan Bates.
3318         
3319         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3320         that it's been built for specific device configurations, and puts the window
3321         at the top of the screen. This simplifies coordinate conversions in a future patch.
3322
3323         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3324         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3325         * WebKitTestRunner/ios/Launch.storyboard: Added.
3326
3327 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3328
3329         Update licence in r189890
3330         https://bugs.webkit.org/show_bug.cgi?id=149306
3331
3332         Reviewed by Dean Jackson.
3333
3334         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3335         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3336         * FontWithFeatures/FontWithFeatures/main.cpp:
3337
3338 2015-09-17  Mark Lam  <mark.lam@apple.com>
3339
3340         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3341         https://bugs.webkit.org/show_bug.cgi?id=149285
3342
3343         Reviewed by Saam Barati.
3344
3345         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3346
3347         * Scripts/run-javascriptcore-tests:
3348         (runJSCStressTests):
3349
3350 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3351
3352         Switch AppleWin build to use CMake
3353         https://bugs.webkit.org/show_bug.cgi?id=149163
3354
3355         Reviewed by Brent Fulgham.
3356
3357         * Scripts/build-webkit:
3358         * Scripts/run-api-tests:
3359         (runTest):
3360         (listAllTests):
3361         (prepareEnvironmentForRunningTestTool):
3362         (testToolPaths):
3363         (testToolPath): Deleted.
3364         Run the API tests as separate executables on Windows.
3365         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3366         * Scripts/webkitdirs.pm:
3367         (checkRequiredSystemConfig):
3368         (jhbuildWrapperPrefixIfNeeded):
3369         (generateBuildSystemFromCMakeProject):
3370         Fix configuration quirks.
3371
3372 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3373
3374         Added toggle options for hiding and showing certain platform families on the dashboard.
3375         https://bugs.webkit.org/show_bug.cgi?id=148403
3376
3377         Reviewed by David Kilzer.
3378
3379         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3380         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3381         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3382         in lieu of an "all" button in the toggle menu.
3383
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3385         (parsePlatformFamily): Helper function to parse out a platform family.
3386         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3387         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3388         (updateToggleButtons): Updates the status of the toggle buttons.
3389         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3390         (documentReady): Added creation of toggle buttons.
3391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3392         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3393         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3394         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3395         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3397         (QueueView): Updated to use hiddenPlatformFamilies.
3398         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3400         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3401         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3402         (Settings.prototype.toggleHiddenPlatform): Deleted.
3403         (Settings.prototype.clearHiddenPlatforms): Deleted.
3404         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3406         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3407         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3408         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3409         (table.queue-grid tr.headers th):
3410         (div.settingsWrapper.hide):
3411         (div.settingsWrapper):
3412         (div.familyToggleWrapper):
3413         (div.platformFamilyToggleButton):
3414         (div.platformFamilyShowToggleButton:not(:last-child)):
3415         (div.familyShown):
3416         (div.accessibilityButton):
3417         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3418         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3419         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3420         platformFamilyToggleButton and settingsWrapper class.
3421         (.accessibilityButton): Deleted.
3422
3423 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3424
3425         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3426         https://bugs.webkit.org/show_bug.cgi?id=148904
3427
3428         Reviewed by Myles Maxfield.
3429
3430         * WebKitTestRunner/TestController.cpp:
3431         (WTR::parseBooleanTestHeaderValue):
3432         (WTR::updateViewOptionsFromTestHeader):
3433         Check for the key "useThreadedScrolling".
3434         Add some code to check for "true" and "false" for boolean options.
3435
3436         (WTR::TestController::viewOptionsForTest):
3437         Apply the test's overrides last, even after the platform's.
3438
3439 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3440
3441         printing does not use minimum page zoom factor
3442         https://bugs.webkit.org/show_bug.cgi?id=108507
3443
3444         Reviewed by Darin Adler.
3445
3446         WebKitTestRunner always takes the snapshots from the UI process
3447         (expect for IOS), so in the case of printing, the layout in the
3448         web view is not the expected one. When printing, we need to take
3449         the snapshot in the web process and ensure it's rendered with a
3450         PrintContext.
3451
3452         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3453         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3454         kWKSnapshotOptionsPrinting option to
3455         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3456         printing, don't even create the snapshot, since it will be ignored
3457         by the UI process that always creates its own from the WebView (expect for IOS platform)
3458         * WebKitTestRunner/TestInvocation.cpp:
3459         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3460         received from the web process if any when comparing pixel
3461         results. Now we only receive a snapshot from the web process in
3462         case of printing, or when platform is IOS. Otherwhise, generate
3463         the snapshot from the WebView as usual.
3464         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3465         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3466         is created by the caller now, but the CG implementation needs to
3467         know if it's a Web or UI process snapshot.
3468         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3469         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3470         cairo surface for the given image.
3471         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3472         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3473         CGContext for the given image.
3474
3475 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3476
3477         Create a font which can be used for testing font features
3478         https://bugs.webkit.org/show_bug.cgi?id=149237
3479
3480         Reviewed by Simon Fraser.
3481
3482         This patch adds a new project in the Tools/ directory which generates a font which can
3483         be used for testing font features. This is a standalone project consisting of two files:
3484         1. A file which actually generates the byte vector representing the font. This file has
3485         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3486         specific, and only relies on the C++ STL.
3487         2. A file with a main() which calls generateFont() and writes out the font, as well as
3488         uses the font to render some demonstration text into a .png file. This file is platform
3489         specific.
3490
3491         The font itself only supports the following characters:
3492         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3493         However, the shape of these letters are either an X or a check mark.
3494
3495         The letter "A" always is a check mark.
3496         The letter "B" always is an X.
3497         Without any font features turned on, the rest of the letters are shown as X.
3498
3499         Each font feature has an letter associated with it. When the font feature is enabled,
3500         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3501         as a check mark.
3502
3503         Here are the mappings of font features to letters:
3504         liga: C
3505         clig: D
3506         dlig: E
3507         hlig: F
3508         calt: G
3509         subs: H
3510         sups: I
3511         smcp: J
3512         c2sc: K
3513         pcap: L
3514         c2pc: M
3515         unic: N
3516         titl: O
3517         onum: P
3518         pnum: Q
3519         tnum: R
3520         frac: S
3521         afrc: T
3522         ordn: U
3523         zero: V
3524         hist: W
3525         jp78: X
3526         jp83: Y
3527         jp90: Z
3528         jp04: a
3529         smpl: b
3530         trad: c
3531         fwid: d
3532         pwid: e
3533         ruby: f
3534
3535         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3536         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3537         (integralLog2):
3538         (roundDownToPowerOfTwo):
3539         (isFourByteAligned):
3540         (clampTo):
3541         (append32):
3542         (writeCFFEncodedNumber):
3543         (CFFBuilder::CFFBuilder):
3544         (CFFBuilder::takeResult):
3545         (CFFBuilder::moveTo):
3546         (CFFBuilder::lineTo):
3547         (CFFBuilder::curveToCubic):
3548         (CFFBuilder::closePath):
3549         (CFFBuilder::writePoint):
3550         (generateBoxCharString):
3551         (generateCheckCharString):
3552         (generateXCharString):
3553         (charStringForGlyph):
3554         (Generator::generate):
3555         (Generator::Placeholder::Placeholder):
3556         (Generator::Placeholder::populate):
3557         (Generator::Placeholder::~Placeholder):
3558         (Generator::placeholder):
3559         (Generator::append16):
3560         (Generator::append32):
3561         (Generator::append32BitCode):
3562         (Generator::overwrite16):
3563         (Generator::overwrite32):
3564         (Generator::appendCFFTable):
3565         (Generator::appendSubstitutionSubtable):
3566         (Generator::appendScriptSubtable):
3567         (Generator::appendGSUBTable):
3568         (Generator::appendOS2Table):
3569         (Generator::appendFormat12CMAPTable):
3570         (Generator::appendFormat4CMAPTable):
3571         (Generator::appendCMAPTable):
3572         (Generator::appendHEADTable):
3573         (Generator::appendHHEATable):
3574         (Generator::appendHMTXTable):
3575         (Generator::appendMAXPTable):
3576         (Generator::appendNAMETable):
3577         (Generator::appendPOSTTable):
3578         (Generator::calculateChecksum):
3579         (Generator::appendTable):
3580         (generateFont):
3581         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3582         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3583         (drawTextWithFeature):
3584         (main):
3585
3586 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3587
3588         Unreviewed, rolling out r189875 and r189878.
3589         https://bugs.webkit.org/show_bug.cgi?id=149235
3590
3591         cygwin cmake build not ready yet (Requested by alexchristensen
3592         on #webkit).
3593
3594         Reverted changesets:
3595
3596         "Switch AppleWin build to use CMake"
3597         https://bugs.webkit.org/show_bug.cgi?id=149163
3598         http://trac.webkit.org/changeset/189875
3599
3600         "Cygwin build fix after r189875"
3601         http://trac.webkit.org/changeset/189878
3602
3