1 2013-09-02 Nick Diego Yamane <nick.yamane@openbossa.org>
3 Save md5 correctly when jhbuildPath doesn't exist yet
4 https://bugs.webkit.org/show_bug.cgi?id=120548
6 Reviewed by Gustavo Noronha Silva.
8 After r152605, Md5 for jhbuild files are saved before the update
9 process, this prevents the script to restart update from scratch
10 when initial checkouts fail. However it causes an issue when builddir
11 (or builddir/Dependencies) doesn't exist yet. In that case the
12 saveJhbuildMd5 function fails to create md5 files.
13 This patch adds a checking for the jhbuildPath and creates it if
14 necessary before trying to open the md5 files.
16 * Scripts/update-webkit-libs-jhbuild:
19 2013-09-02 Mario Sanchez Prada <mario.prada@samsung.com>
21 Unreviewed. Move myself to the reviewers list.
23 * Scripts/webkitpy/common/config/contributors.json:
25 2013-09-01 Alexey Proskuryakov <ap@apple.com>
27 [WK2][Mac] Drag and drop tests interfere with user's UI
28 https://bugs.webkit.org/show_bug.cgi?id=120538
30 Reviewed by Dan Bernstein.
32 This makes running WebKit2 regression tests locally more viable. The patch doesn't
33 fix drag and drop tests to work as expected, I posted some thought about that in
34 <https://bugs.webkit.org/show_bug.cgi?id=68552>.
36 * WebKitTestRunner/EventSenderProxy.h:
37 (WTR::EventSenderProxy::position):
38 * WebKitTestRunner/TestController.h:
39 (WTR::TestController::eventSenderProxy):
40 Expose a way to get current mouse position from anywhere in WKTR code.
42 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
44 * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
45 Copied a FIXME comment from DumpRenderTree.
47 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
48 (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
49 Override drag initiation, using a custom NSDraggingInfo implementation.
51 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
52 Replace NSEvent with a custom class.
54 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
55 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
56 * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
57 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
58 Largely a copy of DumpRenderTree classes, modified to not use global variables.
59 We should consider making these variables static in EventSenderProxy though, as
60 it's strange that mouse state in WKTR is reset between tests without WebKit ever
61 being told about that.
63 2013-08-30 Brent Fulgham <bfulgham@apple.com>
65 [Windows] Unreviewed build fix.
67 * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
68 from the build machines.
70 2013-08-30 Gabor Abraham <abrhm@inf.u-szeged.hu>
72 [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
73 https://bugs.webkit.org/show_bug.cgi?id=120464
75 Reviewed by Jocelyn Turcotte.
77 * Scripts/webkitpy/port/qt.py:
78 (QtPort._search_paths):
79 * Scripts/webkitpy/port/qt_unittest.py:
82 2013-08-29 Filip Pizlo <fpizlo@apple.com>
84 Just linking LLVM into JSC causes all plugin tests to fail
85 https://bugs.webkit.org/show_bug.cgi?id=113915
87 Reviewed by Oliver Hunt.
89 Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
90 raise/abort/__assert_rtn.
92 * Scripts/configure-llvm:
94 2013-08-29 Joseph Pecoraro <pecoraro@apple.com>
96 new-run-webkit-tests does not respect --no-sample-on-timeout switch
97 https://bugs.webkit.org/show_bug.cgi?id=120491
99 Reviewed by Darin Adler.
101 * Scripts/webkitpy/port/server_process.py:
102 (ServerProcess._handle_timeout):
104 2013-08-29 Sam Weinig <sam@webkit.org>
106 Add ENABLE guards for Promises
107 https://bugs.webkit.org/show_bug.cgi?id=120488
109 Reviewed by Andreas Kling.
111 * Scripts/webkitperl/FeatureList.pm:
112 * qmake/mkspecs/features/features.pri:
114 2013-08-29 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
116 [GTK] Should enable WebGL by default on MiniBrowser
117 https://bugs.webkit.org/show_bug.cgi?id=120420
119 Reviewed by Gustavo Noronha Silva.
121 Enable WebGL by default on MiniBrowser.
123 * MiniBrowser/gtk/main.c:
126 2013-08-28 Simon Fraser <simon.fraser@apple.com>
128 Add a Command-R shortcut in MiniBrowser
129 https://bugs.webkit.org/show_bug.cgi?id=120442
131 Reviewed by Dean Jackson.
133 Add a "Reload Page" item to the View menu with a Command-R
136 * MiniBrowser/mac/MainMenu.xib:
138 2013-08-29 Alberto Garcia <berto@igalia.com>
140 [GTK] Update apt dependency list
141 https://bugs.webkit.org/show_bug.cgi?id=120399
143 Reviewed by Philippe Normand.
145 Remove bogus package gail-3.0, add xfonts-utils (needed by
146 xorg-xserver) and switch to the latest versions of libtiff and
149 * gtk/install-dependencies:
151 2013-08-28 Alexey Proskuryakov <ap@apple.com>
153 [WK2][Mac] WebKitTestRunner doesn't force system appearance
154 https://bugs.webkit.org/show_bug.cgi?id=120437
156 Reviewed by Darin Adler.
158 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
159 (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
160 AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
163 2013-08-16 Ryosuke Niwa <rniwa@webkit.org>
165 <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
167 Reviewed by Darin Adler.
169 Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
171 We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
172 editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
174 Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
175 ranges in a given attributed string.
177 * DumpRenderTree/mac/TextInputController.m:
178 (-[WebNSRange initWithNSRange:]):
179 (-[WebNSRange location]):
180 (-[WebNSRange length]):
181 (+[WebNSRange isSelectorExcludedFromWebScript:]):
182 (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
183 (+[NSMutableAttributedString webScriptNameForSelector:]):
184 (-[NSMutableAttributedString ranges]): Added.
185 (+[TextInputController isSelectorExcludedFromWebScript:]):
186 (+[TextInputController webScriptNameForSelector:]):
187 (-[TextInputController legacyAttributedString:]):
189 2013-08-28 Denis Nomiyama <d.nomiyama@samsung.com>
191 [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
192 https://bugs.webkit.org/show_bug.cgi?id=120419
194 Reviewed by Chris Fleizach.
196 Added a notification for AXFocusedUIElementChanged.
198 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
199 (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
201 2013-08-28 Roger Fong <roger_fong@apple.com>
203 Decrease number of workers used in NRWT by the Windows port.
204 https://bugs.webkit.org/show_bug.cgi?id=120435.
206 Reviewed by Brent Fulgham.
208 * Scripts/webkitpy/port/win.py:
209 (WinPort.default_child_processes):
211 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
213 Http tests fails on Debian with Apache 2.4
214 https://bugs.webkit.org/show_bug.cgi?id=120352
218 Remember to update unit-test expectations and old-run-webkit-tests as well.
220 * Scripts/webkitperl/httpd.pm:
221 (getHTTPDConfigPathForTestDirectory):
222 * Scripts/webkitpy/port/port_testcase.py:
223 (test_apache_config_file_name_for_platform):
225 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
227 Http tests fails on Debian with Apache 2.4
228 https://bugs.webkit.org/show_bug.cgi?id=120352
230 Reviewed by Andreas Kling.
232 Select httpd.conf file for debian based on version, matching Fedora behavior.
234 * Scripts/webkitpy/port/base.py:
235 (Port._apache_config_file_name_for_platform):
237 2013-08-28 Commit Queue <commit-queue@webkit.org>
239 Unreviewed, rolling out r154593.
240 http://trac.webkit.org/changeset/154593
241 https://bugs.webkit.org/show_bug.cgi?id=120403
243 Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
246 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
249 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
251 [Qt][Wk2] Many tests are flaky on Qt 5.1
252 https://bugs.webkit.org/show_bug.cgi?id=118232
254 Reviewed by Jocelyn Turcotte.
256 We need to set renderToOffscreenBuffer since we won't otherwise get
257 the paint calls necessary to synchronize UI- and Web-Process. It was
258 only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
259 which is no longer supported or needed.
261 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
262 (WTR::WrapperWindow::handleStatusChanged):
264 2013-08-27 Alexey Proskuryakov <ap@apple.com>
266 [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
267 https://bugs.webkit.org/show_bug.cgi?id=120379
269 Reviewed by Darin Adler.
271 All major platforms have implemented UI process eventSender support, keeping old
272 web process side code only adds confusion.
274 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
275 (WTR::EventSendingController::EventSendingController):
276 (WTR::EventSendingController::mouseDown):
277 (WTR::EventSendingController::mouseUp):
278 (WTR::EventSendingController::mouseMoveTo):
279 (WTR::EventSendingController::leapForward):
280 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
281 * WebKitTestRunner/TestController.cpp:
282 (WTR::TestController::resetStateToConsistentValues):
283 (WTR::TestController::didReceiveMessageFromInjectedBundle):
284 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
285 * WebKitTestRunner/TestController.h:
287 2013-08-27 Roger Fong <roger_fong@apple.com>
289 NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
290 https://bugs.webkit.org/show_bug.cgi?id=120370.
292 Reviewed by Brent Fulgham.
294 * Scripts/webkitpy/port/win.py:
295 (WinPort.delete_sem_locks):
296 (WinPort.setup_test_run):
298 2013-08-27 Denis Nomiyama <d.nomiyama@samsung.com>
300 [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
301 https://bugs.webkit.org/show_bug.cgi?id=119883
303 Implemented the notification listener for AccessibilityUIElement. The signal is generated
304 by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
305 axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
306 callback function. The global callback function and callbacks for specific elements are
307 stored in a HashMap in AccessibilityCallbacksAtk.cpp.
309 Reviewed by Chris Fleizach.
311 * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
312 * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
313 and removeAccessibilityNotificationListener()
314 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
315 (axObjectEventListener): Call JS callback for global notification or for a specific element
316 (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
318 (addAccessibilityNotificationHandler): Add notification listener to the list
319 (removeAccessibilityNotificationHandler): Remove notification listener from the list
320 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
321 (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
322 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
323 (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
324 (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
325 Remove handler from the list and disconnect callbacks
326 (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
327 callback and connect callbacks to signals
328 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
329 (AccessibilityNotificationHandler::setPlatformElement): Set platform element
330 (AccessibilityNotificationHandler::platformElement): Get platform element
331 (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
332 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
333 (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
334 platform element and the notification callback
335 (AccessibilityUIElement::removeNotificationListener):
336 * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
337 * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
339 2013-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
341 Unreviewed. Fix GTK+ build after r154601.
343 * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
344 compilation added by mistake in r154601.
346 2013-08-26 Alexey Proskuryakov <ap@apple.com>
348 WebKitTestRunner needs to protect the user's pasteboard contents while running
349 https://bugs.webkit.org/show_bug.cgi?id=81419
350 <rdar://problem/11066794>
352 Reviewed by Darin Adler.
354 Mostly a copy/paste of DRT code.
356 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
357 doesn't interfere with my clipboard while being run in a loop.
359 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
360 * WebKitTestRunner/mac/PoseAsClass.h: Added.
361 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
362 * WebKitTestRunner/mac/TestControllerMac.mm:
363 (WTR::TestController::platformInitialize):
364 (WTR::TestController::platformDestroy):
365 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
366 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
368 2013-08-26 Commit Queue <commit-queue@webkit.org>
370 Unreviewed, rolling out r154640.
371 http://trac.webkit.org/changeset/154640
372 https://bugs.webkit.org/show_bug.cgi?id=120329
374 Caused flaky crashes on a lot of editing tests (Requested by
377 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
378 * WebKitTestRunner/mac/PoseAsClass.h: Removed.
379 * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
380 * WebKitTestRunner/mac/TestControllerMac.mm:
381 (WTR::TestController::platformInitialize):
382 (WTR::TestController::platformDestroy):
383 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
384 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
386 2013-08-26 Dan Bernstein <mitz@apple.com>
388 Automatic bug reports case pain
389 https://bugs.webkit.org/show_bug.cgi?id=120330
391 Reviewed by Anders Carlsson.
393 * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
394 of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
395 “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
397 2013-08-23 Andy Estes <aestes@apple.com>
399 Fix issues found by the Clang Static Analyzer
400 https://bugs.webkit.org/show_bug.cgi?id=120230
402 Reviewed by Darin Adler.
404 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
405 (-[LocalPasteboard initWithName:]): Called [super init] first so that we
406 don't later use ivars from the wrong self.
407 * DumpRenderTree/mac/TestRunnerMac.mm:
408 (-[APITestDelegate initWithCompletionCondition:]): Ditto.
409 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
410 (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
411 WKBrowsingContextGroups, and WKViews.
413 2013-08-26 Alexey Proskuryakov <ap@apple.com>
415 WebKitTestRunner needs to protect the user's pasteboard contents while running
416 https://bugs.webkit.org/show_bug.cgi?id=81419
417 <rdar://problem/11066794>
419 Reviewed by Darin Adler.
421 Mostly a copy/paste of DRT code.
423 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
424 doesn't interfere with my clipboard while being run in a loop.
426 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
427 * WebKitTestRunner/mac/PoseAsClass.h: Added.
428 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
429 * WebKitTestRunner/mac/TestControllerMac.mm:
430 (WTR::TestController::platformInitialize):
431 (WTR::TestController::platformDestroy):
432 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
433 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
435 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
437 [GTK] Include most of the WebKit2 unit tests into the build and testing
438 https://bugs.webkit.org/show_bug.cgi?id=120307
440 Reviewed by Philippe Normand.
442 There are still various unit test source files that are not being included into
443 the build. This patch includes most of these, only leaving out tests that do not
444 compile or test features that are not supported by the GTK port.
446 * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
448 * TestWebKitAPI/GNUmakefile.am:
450 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
452 [GTK] Allow to run tests without Xvfb in run-gtk-tests
453 https://bugs.webkit.org/show_bug.cgi?id=120298
455 Reviewed by Philippe Normand.
457 Add --no-xvfb command line option to run tests in the current
460 * Scripts/run-gtk-tests:
461 (TestRunner._run_xvfb): Return early if option --no-xvfb has been
463 (TestRunner._setup_testing_environment): Use helper function
464 _run_xvfb to start Xvfb if needed.
465 (TestRunner._tear_down_testing_environment): Check Xvfb is
466 actually running before trying to terminate it.
468 2013-08-26 Zoltan Arvai <zarvai@inf.u-szeged.hu>
470 Adding Gabor Abraham to contributors.json.
472 Reviewed by Csaba Osztrogonác.
474 * Scripts/webkitpy/common/config/contributors.json:
476 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
478 [GTK] Add support for passing test directories to run-gtk-tests
479 https://bugs.webkit.org/show_bug.cgi?id=120296
481 Reviewed by Philippe Normand.
483 * Scripts/run-gtk-tests:
484 (TestRunner._get_tests_from_dir): Helper function to return all
485 unit tests found in a given directory.
486 (TestRunner._get_tests): Check the given tests passed in the
487 command line, so that if a directory is found the tests contained
488 in the directory are added to the list of tests to run.
490 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
492 [GTK] Improve the stop/reload button implementation in MiniBrowser
493 https://bugs.webkit.org/show_bug.cgi?id=120292
495 Reviewed by Philippe Normand.
497 - Use an instance member of BrowserWindow for the button widget
498 instead of a global variable.
499 - Use notify::is-loading to monitor the WebView load instead of
500 the estimated-load-progress property.
501 - Use webkit_web_view_is_loading() to check whether the view
502 is loading to change the button icon instead of a string
503 comparison of the gtk stock icon id.
504 - Use the right casts to fix compile warning.
506 * MiniBrowser/gtk/BrowserWindow.c:
507 (reloadOrStopCallback):
508 (webViewLoadProgressChanged):
509 (webViewIsLoadingChanged):
510 (browser_window_init):
511 (browserWindowConstructed):
513 2013-08-26 Arunprasad Rajkumar <arurajku@cisco.com>
515 [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
516 https://bugs.webkit.org/show_bug.cgi?id=119791
518 Reviewed by Jocelyn Turcotte.
520 Load empty url to send onunload event to currently running page. onunload event is
521 mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
522 LayoutTests/plugins/geturlnotify-during-document-teardown.html.
524 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
527 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
529 [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
530 https://bugs.webkit.org/show_bug.cgi?id=120290
532 Reviewed by Philippe Normand.
534 * MiniBrowser/gtk/GNUmakefile.am: Add
535 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
537 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
539 [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
540 https://bugs.webkit.org/show_bug.cgi?id=120288
542 Reviewed by Carlos Garcia Campos.
544 * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
545 into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
546 These unit tests are at the moment failing in debug configurations, so it would be nice to
547 have the GTK builds report these failures as well.
549 2013-08-25 Ryuan Choi <ryuan.choi@samsung.com>
551 [EFL] EWebLauncher is executed as full screen with device pixel ratio
552 https://bugs.webkit.org/show_bug.cgi?id=120282
554 Reviewed by Gyuyoung Kim.
556 * EWebLauncher/main.c:
557 Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
559 2013-08-25 Zan Dobersek <zdobersek@igalia.com>
561 [gdb] Remove the pretty printer for KURLGooglePrivate
562 https://bugs.webkit.org/show_bug.cgi?id=120263
564 Reviewed by Benjamin Poulain.
566 Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
567 was usable inside the gdb debugger. The structure was remove from the codebase
568 along with the GoogleURL backend for KURL.
571 (JSCJSStringPrinter.to_string):
572 (add_pretty_printers):
574 2013-08-24 Filip Pizlo <fpizlo@apple.com>
576 Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
577 prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
578 libraries depend on libgtest anyway.
580 * Scripts/copy-webkitlibraries-to-product-directory:
582 2013-08-24 Darin Adler <darin@apple.com>
584 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
585 https://bugs.webkit.org/show_bug.cgi?id=120255
587 Reviewed by Andreas Kling.
589 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
591 2013-08-24 Anders Carlsson <andersca@apple.com>
593 Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
594 https://bugs.webkit.org/show_bug.cgi?id=120249
596 Reviewed by Andreas Kling.
598 * Scripts/extract-localizable-strings:
600 2013-08-24 Carlos Garcia Campos <cgarcia@igalia.com>
602 [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
603 https://bugs.webkit.org/show_bug.cgi?id=119743
605 Reviewed by Anders Carlsson.
607 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
608 (WTR::InjectedBundlePage::InjectedBundlePage): Add
611 2013-08-23 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
613 Move TestWebKitAPI_LIBRARIES before platform specific cmake include
614 https://bugs.webkit.org/show_bug.cgi?id=120220
616 Reviewed by Martin Robinson.
618 * TestWebKitAPI/CMakeLists.txt:
620 2013-08-22 Filip Pizlo <fpizlo@apple.com>
622 build-jsc --ftl-jit should work
623 https://bugs.webkit.org/show_bug.cgi?id=120194
625 Reviewed by Oliver Hunt.
627 * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
629 2013-08-23 Commit Queue <commit-queue@webkit.org>
631 Unreviewed, rolling out r153534.
632 http://trac.webkit.org/changeset/153534
633 https://bugs.webkit.org/show_bug.cgi?id=120216
635 Too many tests failing just WinEWS bots (Requested by rfong on
638 * Scripts/webkitpy/common/config/ews.json:
640 2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
642 Unreviewed. Added my webkit.org email address.
644 * Scripts/webkitpy/common/config/contributors.json:
646 2013-08-23 Peter Gal <galpeter@inf.u-szeged.hu>
648 [WTR] Should dump as text when the mimetype is text/plain
649 https://bugs.webkit.org/show_bug.cgi?id=118306
651 Reviewed by Christophe Dumez.
653 Check for the text/plain mimetype and if true then mark it as
656 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
657 (WTR::InjectedBundlePage::dump):
659 2013-08-22 Filip Pizlo <fpizlo@apple.com>
661 Update LLVM binary drops and scripts to the latest version from SVN
662 https://bugs.webkit.org/show_bug.cgi?id=120184
664 Reviewed by Mark Hahnenberg.
666 * ReducedFTL/build.sh:
667 * Scripts/configure-llvm: Added.
668 * Scripts/copy-webkitlibraries-to-product-directory:
669 * Scripts/export-llvm-build:
671 2013-08-22 Andy Estes <aestes@apple.com>
673 <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
675 Reviewed by David Kilzer.
677 * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
678 OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
679 DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
681 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
683 NRWT: Add the ability to upload test results to new test results server
684 https://bugs.webkit.org/show_bug.cgi?id=120146
686 Reviewed by Andreas Kling.
688 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
689 that contains the full summary of the test run including information about passed tests.
691 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
694 --results-server-host
696 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
697 so we should be able to delete --test-results-server in time.
699 * Scripts/webkitpy/layout_tests/controllers/manager.py:
701 (Manager._upload_json_files):
703 (Manager.upload_results):
704 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
706 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
707 (summarized_results):
708 (SummarizedResultsTest.test_summarized_results_wontfix):
709 (SummarizedResultsTest):
710 (SummarizedResultsTest.test_summarized_results_include_passes):
711 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
714 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
716 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
718 * Scripts/webkitpy/tool/bot/irc_command.py:
721 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
723 [Qt] DRT bug revealed/caused by r154300
724 https://bugs.webkit.org/show_bug.cgi?id=120151
726 Reviewed by Simon Hausmann.
728 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
729 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
732 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
733 between native Qt methods and JSC bound methods. This patch changes the check to see if the
734 property is writable since the Qt methods are ReadOnly.
736 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
737 (DumpRenderTree::initJSObjects):
739 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
741 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
743 Reviewed by Benjamin Poulain.
745 WTFString moved the is8bit bit by one in r152201.
747 * lldb/lldb_webkit.py:
748 (WTFStringImplProvider.is_8bit):
750 2013-08-21 Tim Horton <timothy_horton@apple.com>
752 Revert http://trac.webkit.org/changeset/154022, as it failed to update
753 a variety of scripts that depended on the old format.
755 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
757 * Scripts/prepare-ChangeLog:
759 (generateNewChangeLogs):
761 2013-08-21 Brent Fulgham <bfulgham@apple.com>
763 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
765 * WinLauncher/WinLauncher.cpp:
766 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
768 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
770 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
772 Reviewed by Andreas Kling.
774 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
775 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
776 (WTR::activateFonts): Ditto.
778 2013-08-21 Brian Holt <brian.holt@samsung.com>
780 [GTK] Suppress irrelevant or known leaks for Valgrind
781 https://bugs.webkit.org/show_bug.cgi?id=119448
783 Reviewed by Martin Robinson.
785 Add a suppressions file to suppress known leaks for Valgrind.
786 Valgrind also takes longer when using suppressions and
787 times out unless the driver timeout is increased.
789 * Scripts/valgrind/suppressions.txt: Added.
790 * Scripts/webkitpy/port/gtk.py:
791 (GtkPort.driver_stop_timeout):
792 (GtkPort.setup_environ_for_server):
794 2013-08-20 Alex Christensen <achristensen@apple.com>
796 [Windows] Linking fix for Win64.
798 Rubberstamped by Brent Fulgham.
800 * win/DLLLauncher/DLLLauncherMain.cpp:
801 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
803 2013-08-20 Brent Fulgham <bfulgham@apple.com>
805 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
807 Reviewed by Tim Horton.
809 * win/DLLLauncher/DLLLauncherMain.cpp:
810 (getLastErrorString): New method to convert GetLastError to text.
811 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
813 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
815 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
817 Reviewed by Martin Robinson.
819 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
820 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
822 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
824 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
826 Reviewed by Martin Robinson.
828 Added stop button in MiniBrowser
830 * MiniBrowser/gtk/BrowserWindow.c:
831 (reloadOrStopCallback): Callback to handle stop or reload button click.
832 (webViewLoadProgressChanged): Update reload or stop button icon.
833 (browser_window_init): Save button pointer for further icon updates.
835 2013-08-20 Simon Pena <simon.pena@samsung.com>
837 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
839 Reviewed by Alexey Proskuryakov.
841 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
842 printing didFailLoadWithError.
844 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
845 DumpRenderTree, printing didFailLoadWithError.
847 * DumpRenderTree/gtk/DumpRenderTree.cpp:
848 (webFrameLoadStatusNotified):
850 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
852 <https://webkit.org/b/120049> Delete code for Snow Leopard
854 Reviewed by Benjamin Poulain.
856 * DumpRenderTree/mac/CheckedMalloc.cpp:
857 (protectionOfRegion):
858 (makeLargeMallocFailSilently):
859 * DumpRenderTree/mac/DumpRenderTree.mm:
860 (resetDefaultsToConsistentValues):
861 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
862 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
863 * DumpRenderTree/mac/FrameLoadDelegate.mm:
865 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
866 * DumpRenderTree/mac/LayoutTestHelper.m:
867 * DumpRenderTree/mac/TestRunnerMac.mm:
868 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
869 (WTR::InjectedBundle::platformInitialize):
870 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
871 (WTR::testPathFromURL):
872 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
874 2013-08-19 Alexey Proskuryakov <ap@apple.com>
876 https://bugs.webkit.org/show_bug.cgi?id=119915
877 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
879 Reviewed by Darin Adler.
881 The issue was that we ended up having no CFNetwork cache in the testing session due
882 to an incorrect cache model. There is a number of things not implemented when it
883 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
884 the easiest way to get this going is to initialize it to correct value upfront.
886 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
888 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
890 REGRESSION(r154275): webkitpy tests failing
891 https://bugs.webkit.org/show_bug.cgi?id=120010
893 Reviewed by Jocelyn Turcotte.
895 Update unit-tests to tests the new search-path structure,
896 but reverting the architecture search path addition.
898 * Scripts/webkitpy/port/qt.py:
901 (QtPort._generate_all_test_configurations):
902 (QtPort.qt_architecture):
903 * Scripts/webkitpy/port/qt_unittest.py:
905 (QtPortTest._assert_search_path):
906 (QtPortTest._assert_expectations_files):
907 (QtPortTest._qt_version):
909 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
911 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
913 Unreviewed meta gardening.
915 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
917 * Scripts/webkitpy/port/qt.py:
918 (QtPort._search_paths):
920 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
922 Restructure Qt test expectations
924 Unreviewed meta gardening.
926 Removed 5.0 name from WK1 and WK2 results and made it possible to set
927 expectations by both Qt version and mayor architectures.
929 * Scripts/webkitpy/port/qt.py:
930 (QtPort._wk2_port_name):
933 (QtPort.architecture):
934 (QtPort._search_paths):
935 (QtPort._port_specific_expectations_files):
937 2013-08-16 Brent Fulgham <bfulgham@apple.com>
939 [Windows] DRT is not using the same preferences as the Mac build.
940 https://bugs.webkit.org/show_bug.cgi?id=119822
942 Reviewed by Darin Adler.
944 * DumpRenderTree/win/DumpRenderTree.cpp:
945 (runTest): Process Windows message queue using CFRunLoop to allow
946 dispatch routines to run properly.
947 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
948 to prevent problems on WinCairo port.
950 2013-08-16 Brent Fulgham <bfulgham@apple.com>
952 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
953 https://bugs.webkit.org/show_bug.cgi?id=119583
955 Reviewed by Alexey Proskuryakov.
957 * DumpRenderTree/win/DumpRenderTree.cpp:
958 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
959 component if the URL does not contain the expected base URL.
961 2013-08-16 Pratik Solanki <psolanki@apple.com>
963 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
965 Reviewed by Andreas Kling.
967 m_script is never NULL so we can just return a reference. Also remove some pointless null
968 checks as a result of doing this.
970 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
971 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
973 2013-08-15 Alexey Proskuryakov <ap@apple.com>
975 [WK2] NetworkProcess should use a temporary storage session for test
976 https://bugs.webkit.org/show_bug.cgi?id=119855
978 Reviewed by Darin Adler.
980 Use a new API that takes care of both WebProcess and NetworkProcess.
982 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
983 (WTR::InjectedBundle::initialize):
984 * WebKitTestRunner/TestController.cpp:
985 (WTR::TestController::initialize):
987 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
989 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
991 Reviewed by Dirk Pranke.
993 This is a port from Blink of
994 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
995 originally by Dirk Pranke.
997 From the original commit:
999 This gives something like a 15x speedup over compiling and matching
1000 one property at a time and doing multiple passes over the file.
1002 * Scripts/webkitpy/w3c/test_converter.py:
1003 (W3CTestConverter.__init__):
1004 (W3CTestConverter.convert_prefixed_properties):
1005 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1007 2013-08-15 Dan Bernstein <mitz@apple.com>
1009 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
1011 Reviewed by Darin Adler.
1013 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
1014 added a message that points to the source code. Removed some unnecessary repetition of what
1015 is already in the file.
1017 2013-08-15 Andy Estes <aestes@apple.com>
1019 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
1021 Reviewed by Brady Eidson.
1023 Wrote an API test that verifies -[WebView stopLoading:] can be called
1024 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
1026 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1027 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
1028 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
1029 (TestWebKitAPI::TEST):
1031 2013-08-15 Alexey Proskuryakov <ap@apple.com>
1033 Adding Myles Maxfield to contributors.json.
1035 Oops, wrong section, fixing.
1037 * Scripts/webkitpy/common/config/contributors.json:
1039 2013-08-15 Alexey Proskuryakov <ap@apple.com>
1041 Adding Myles Maxfield to contributors.json.
1043 * Scripts/webkitpy/common/config/contributors.json:
1045 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
1047 [Qt] Do not check specifically for version 5.0
1048 https://bugs.webkit.org/show_bug.cgi?id=119846
1050 Reviewed by Jocelyn Turcotte.
1052 For Qt 5.x we should always use both wk1 and wk2 basepath results.
1054 * Scripts/webkitpy/port/qt.py:
1055 (QtPort._search_paths):
1057 2013-08-15 Simon Pena <simon.pena@samsung.com>
1059 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
1061 Reviewed by Gustavo Noronha Silva.
1063 Following a similar approach as in r153977, return a path string
1064 that is relative to main frame URL or just file name if the
1065 resource is not in the same directory subtree, and replace empty
1066 strings with "(null)".
1068 Update pathFromSoupURI so it behaves more closely to the other
1069 ports, and remove the unused code after we no longer print
1070 <unknown> in certain cases. Also move
1071 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
1072 be used both in TestRunnerGtk and in DumpRenderTree.
1074 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1075 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
1076 we can print Soup URIs with the password, since soup_uri_to_string
1077 doesn't preserve them.
1078 (pathFromSoupURI): Updated following EFL implementation in
1079 r153977, and return a WTFString instead of a CString.
1080 (convertSoupMessageToURLPath): Return "(null)" instead of empty
1081 strings, and handle the new return type of pathFromSoupURI.
1082 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
1083 reference, and handle the new return type of pathFromSoupURI.
1084 (descriptionSuitableForTestResult): Remove unused code.
1085 (didFinishLoading): Use convertResourceToURLPath.
1086 (didFailLoadingWithError): Use convertResourceToURLPath.
1087 (authenticationCallback): Display the URL of the authentication
1089 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
1090 soupURIToStringPreservingPassword.
1091 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
1092 soupURIToStringPreservingPassword.
1094 2013-08-14 Tim Horton <timothy_horton@apple.com>
1096 Un-inline dataLog dumpers for IntSize and IntPoint
1097 https://bugs.webkit.org/show_bug.cgi?id=119697
1099 Reviewed by Sam Weinig.
1101 * TestWebKitAPI/GNUmakefile.am:
1103 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
1105 Flakiness dashboard build fix.
1107 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1108 (processTestRunsForBuilder):
1110 2013-08-14 Martin Robinson <mrobinson@igalia.com>
1112 [GTK] [CMake] Add support for building TestWebKitAPI
1113 https://bugs.webkit.org/show_bug.cgi?id=116987
1115 Reviewed by Philippe Normand.
1117 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
1118 platform-specific file, so that GTK+ can override them.
1119 * TestWebKitAPI/PlatformGTK.cmake: Added.
1121 2013-08-14 Brent Fulgham <bfulgham@apple.com>
1123 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
1124 https://bugs.webkit.org/show_bug.cgi?id=119775
1126 This bug updates the WinLauncher program with a few useful menu
1127 options to toggle certain debugging and development features of
1130 Reviewed by Tim Horton.
1132 * WinLauncher/WinLauncher.cpp:
1133 (dllLauncherEntryPoint): Clean up preference objects on exit.
1134 (ToggleMenuItem): New function.
1135 (LaunchInspector): New function.
1136 (WndProc): Add handler for new menu items. Also properly terminate
1137 CFRunLoop operation on program exit.
1138 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
1140 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
1141 resource folder to search path.
1142 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
1145 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
1147 Add a hyperlink from build.webkit.org to the flakiness dashboard.
1149 Rubbers-tamped by Simon Fraser.
1151 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1153 2013-08-14 Benjamin Dupont <bdupont@nds.com>
1155 [Qt] Activate visibility API layout tests
1156 https://bugs.webkit.org/show_bug.cgi?id=119790
1158 Reviewed by Allan Sandfeld Jensen.
1160 * DumpRenderTree/qt/TestRunnerQt.cpp:
1161 (TestRunner::resetPageVisibility):
1162 (TestRunner::setPageVisibility):
1164 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
1166 [GTK] WK does not link properly against libxslt
1167 https://bugs.webkit.org/show_bug.cgi?id=119688
1169 Reviewed by Gustavo Noronha Silva.
1171 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
1173 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
1175 2013-08-13 Alexey Proskuryakov <ap@apple.com>
1177 [Mac] fast/dom/attr-style-too-lazy.html is flaky
1178 https://bugs.webkit.org/show_bug.cgi?id=119763
1180 Reviewed by Darin Adler.
1182 * DumpRenderTree/mac/UIDelegate.mm:
1183 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
1184 a test, it would just semi-randomly leak to the next one.
1185 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
1188 2013-08-13 Tim Horton <timothy_horton@apple.com>
1190 [mac] Give MiniBrowser a reasonable bundle identifier
1191 https://bugs.webkit.org/show_bug.cgi?id=119773
1193 Rubber-stamped by Simon Fraser.
1195 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
1197 * MiniBrowser/mac/Info.plist:
1198 * MiniBrowser/mac/WebBundle/Info.plist:
1200 2013-08-13 Dean Jackson <dino@apple.com>
1202 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
1204 Reviewed by Mark Rowe.
1206 Have prepare-ChangeLog produce webkit.org/b/id style
1207 URLs rather than exposing the inner workings of our
1208 cgi. I was going to use the term "Future Proofing"
1209 but that seems excessive :)
1211 * Scripts/prepare-ChangeLog:
1212 (main): Generate a more human readable form.
1213 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
1215 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1217 [EFL][DRT] Simplify call to reverseFind()
1218 https://bugs.webkit.org/show_bug.cgi?id=119746
1220 Reviewed by Christophe Dumez.
1222 Follow-up to r153977.
1224 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1225 (pathSuitableForTestResult): Instead of defining a static variable
1226 that's only used in a single place, pass '/' to reverseFind() directly.
1228 2013-08-13 Alberto Garcia <berto@igalia.com>
1230 [GTK] Closing inspector window crashes wk
1231 https://bugs.webkit.org/show_bug.cgi?id=110865
1233 Reviewed by Carlos Garcia Campos.
1235 Disconnect all signal handlers if the inspector window is
1238 * GtkLauncher/LauncherInspectorWindow.c:
1239 (inspectorWindowDestroyed):
1240 (launcherInspectorWindowNew):
1242 2013-08-12 Dan Bernstein <mitz@apple.com>
1244 extract-localizable-strings output is not suited for parsing by Xcode
1245 https://bugs.webkit.org/show_bug.cgi?id=119728
1247 Reviewed by Darin Adler.
1249 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
1250 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
1251 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
1254 * Scripts/extract-localizable-strings:
1256 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
1258 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
1259 https://bugs.webkit.org/show_bug.cgi?id=119585
1261 Reviewed by Gyuyoung Kim.
1263 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1264 (pathSuitableForTestResult):
1265 Return path string that's relative to main frame URL, or just file name if
1266 the resource is not in the same directory subtree.
1267 Referenced WebKitTestRunner code in r153852.
1268 (descriptionSuitableForTestResult):
1269 (DumpRenderTreeChrome::onFrameRedirectRequested):
1270 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
1272 2013-08-12 Dan Bernstein <mitz@apple.com>
1274 extract-localizable-strings doesn't know how to verify an existing strings file
1275 https://bugs.webkit.org/show_bug.cgi?id=119704
1277 Reviewed by Darin Adler.
1279 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
1280 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
1281 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
1282 the way directories to skip are specified from prefixing the directory with a “-” to
1283 specifying it with --skip.
1284 Finally, added a --verify option. When specified, the strings file is not written to, but
1285 instead read in and checked for consistency with the comments, keys and values derived from
1286 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
1287 mismatching comments are reported as errors.
1288 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
1289 directories to skip and no exceptions file.
1291 2013-08-12 Alexey Proskuryakov <ap@apple.com>
1293 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
1294 https://bugs.webkit.org/show_bug.cgi?id=85522
1296 Reviewed by Andy Estes.
1298 * DumpRenderTree/mac/UIDelegate.mm:
1299 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
1300 when already done with a test. We already had this check in all UI delegate functions,
1301 except for -webView:addMessageToConsole:withSource: somehow.
1303 2013-08-12 Alexey Proskuryakov <ap@apple.com>
1305 https://bugs.webkit.org/show_bug.cgi?id=119693
1306 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
1307 because of connect-src-websocket-allowed.html
1309 Reviewed by Darin Adler.
1311 Starting a load of about:blank and immediately stopping it cancels outstanding
1312 resource loads, but the page has to transition to committed state to have timers
1313 or WebSockets stopped too.
1315 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
1316 ensure that transition to committed state happens before we start the next test.
1318 2013-08-12 Beth Dakin <bdakin@apple.com>
1320 The LayoutMilestones didLayout callback should only fire for the main frame
1321 https://bugs.webkit.org/show_bug.cgi?id=119457
1323 Reviewed by Sam Weinig.
1325 Now that the didLayout callback only fires for the main frame, we want to make
1326 sure it will fire even when all of the content is in a subframe.
1328 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1329 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
1330 (TestWebKitAPI::didLayout):
1331 (TestWebKitAPI::TEST):
1332 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
1334 2013-08-12 Beth Dakin <bdakin@apple.com>
1336 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
1337 https://bugs.webkit.org/show_bug.cgi?id=119658
1339 Reviewed by Darin Adler.
1341 * MiniBrowser/mac/WK2BrowserWindowController.m:
1342 (-[WK2BrowserWindowController awakeFromNib]):
1343 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1344 (WTR::InjectedBundlePage::InjectedBundlePage):
1345 * WebKitTestRunner/TestController.cpp:
1346 (WTR::TestController::createWebViewWithOptions):
1348 2013-08-12 Seokju Kwon <seokju@webkit.org>
1350 Remove glu's libtest rule from checker.py
1351 https://bugs.webkit.org/show_bug.cgi?id=119674
1353 Reviewed by Darin Adler.
1355 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
1357 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
1359 Unreviewed. Change my primary mail address.
1361 * Scripts/webkitpy/common/config/contributors.json:
1363 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
1365 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
1366 https://bugs.webkit.org/show_bug.cgi?id=115751
1368 Reviewed by Martin Robinson.
1370 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
1373 2013-08-09 Beth Dakin <bdakin@apple.com>
1375 AX: Not able to use arrow keys to read text in a WK2 app
1376 https://bugs.webkit.org/show_bug.cgi?id=119605
1378 <rdar://problem/14281275>
1380 Reviewed by Darin Adler.
1382 New test verifies that didNotHandleKeyEvent will be called when there is nothing
1384 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1385 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
1386 (TestWebKitAPI::didFinishLoadForFrame):
1387 (TestWebKitAPI::didNotHandleKeyEventCallback):
1388 (TestWebKitAPI::TEST):
1390 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
1392 Add support for KeyboardEvent.location attribute
1393 https://bugs.webkit.org/show_bug.cgi?id=119326
1395 Reviewed by Benjamin Poulain.
1397 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
1399 * DumpRenderTree/mac/EventSendingController.mm:
1400 (-[EventSendingController keyDown:withModifiers:withLocation:]):
1401 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
1402 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
1403 (-[EventSendingController handleEvent:]):
1404 (-[EventSendingController fireKeyboardEventsToElement:]):
1406 2013-08-09 Alexey Proskuryakov <ap@apple.com>
1408 <unknown> is often dumped instead of path in test output
1409 https://bugs.webkit.org/show_bug.cgi?id=119590
1411 Reviewed by Anders Carlsson.
1413 There were two reasons for <unknown>:
1414 1. When delegate logging is enabled via a testRunner call, that obviously happens
1415 after main resource load starts, so we don't record its URL.
1416 2. Authentication delegate logging relied on URL recording, but it's only turned on
1417 when enabling resource loading delegate logging, not auth one.
1419 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
1420 landed without posted rationale and unreviewed. Just undoing that change now.
1422 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1423 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1424 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1425 (WTR::InjectedBundlePage::didInitiateLoadForResource):
1427 2013-08-08 Alex Christensen <achristensen@apple.com>
1429 Windows build fixes.
1431 Rubberstamped by Brent Fulgham.
1433 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1434 Removed /SAFESEH link option which doesn't work with x64.
1436 2013-08-08 Daniel Bates <dabates@apple.com>
1438 Add iOS support to run-javascriptcore-tests
1439 https://bugs.webkit.org/show_bug.cgi?id=119602
1441 Reviewed by Joseph Pecoraro.
1443 Make run-javascriptcore-tests work for iOS WebKit.
1445 * Scripts/run-javascriptcore-tests:
1447 2013-08-08 Alexey Proskuryakov <ap@apple.com>
1449 [WK2] loader/go-back-cached-main-resource.html fails
1450 https://bugs.webkit.org/show_bug.cgi?id=116491
1452 Reviewed by Tim Horton.
1454 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1455 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1456 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1457 * DumpRenderTree/win/DumpRenderTree.cpp:
1458 Added FIXMEs about making path printing normalization more compatible.
1460 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
1461 Return last path component in cases where we used to return a full path, which is
1462 never desirable. Added a null check to basePath to prevent potentially getting
1463 an Objective C exception.
1465 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1466 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
1467 for a currently loading one (which is different for tests that use multiple windows).
1468 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
1469 last path component as last fallback.
1470 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
1471 frame URL here, and it was potentially a wrong frame.
1472 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
1473 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
1474 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
1475 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
1476 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
1478 2013-08-08 Alex Christensen <achristensen@apple.com>
1480 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1481 https://bugs.webkit.org/show_bug.cgi?id=116125
1483 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
1485 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1486 (WTR::pathSuitableForTestResult):
1487 Changed string operations to match _drt_descriptionSuitableForTestResult.
1488 (WTR::dumpRequestDescriptionSuitableForTestResult):
1489 (WTR::dumpResponseDescriptionSuitableForTestResult):
1490 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1491 (WTR::InjectedBundlePage::didInitiateLoadForResource):
1492 (WTR::InjectedBundlePage::willSendRequestForFrame):
1493 (WTR::InjectedBundlePage::didReceiveResponseForResource):
1494 Pass the main frame's URL to pathSuitableForTestResult.
1495 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1496 Added WKBundlePageRef to willPerformClientRedirectForFrame.
1498 2013-08-07 Simon Fraser <simon.fraser@apple.com>
1500 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
1501 https://bugs.webkit.org/show_bug.cgi?id=119317
1503 Reviewed by Tim Horton.
1505 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
1506 the test to complete, which is not power friendly. Although DRT instances
1507 are generally busy anyway, not sitting in a busy loop should free up some CPU
1508 cycles for other instances of DRT.
1510 Editing tests continue to pass. All Java tests are skipped and were not
1511 tested, but when run fail similarly with and without the patch.
1513 * DumpRenderTree/mac/DumpRenderTree.mm:
1517 2013-08-07 Daniel Bates <dabates@apple.com>
1519 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
1520 <https://bugs.webkit.org/show_bug.cgi?id=119558>
1522 Reviewed by Martin Robinson.
1524 Currently we build the command line to execute jsDriver.pl twice so as to both
1525 print it to standard output and actually execute it. We should only build up
1526 this command line once. Moreover, we should print to standard output the actual
1527 command line that we are going to use including the GTK- and EFL-specific call
1528 to /Tools/jhbuild/jhbuild-wrapper.
1530 * Scripts/run-javascriptcore-tests:
1532 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
1534 [EFL] REGRESSION after r153432: some accessibility tests crash.
1535 https://bugs.webkit.org/show_bug.cgi?id=119333
1537 Reviewed by Darin Adler.
1539 Use a RefPtr to store a reference to the parent element of
1540 an AccessibilityUIElement instead of the raw pointer, so we
1541 never derefence a function from an invalid pointer.
1543 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1544 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
1546 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
1548 Unreviewed. Add myself as a committer.
1550 * Scripts/webkitpy/common/config/contributors.json:
1552 2013-08-04 Sam Weinig <sam@webkit.org>
1554 Remove support for HTML5 MicroData
1555 https://bugs.webkit.org/show_bug.cgi?id=119480
1557 Reviewed by Anders Carlsson.
1559 * Scripts/webkitperl/FeatureList.pm:
1560 * qmake/mkspecs/features/features.pri:
1562 2013-07-23 David Farler <dfarler@apple.com>
1564 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
1565 https://bugs.webkit.org/show_bug.cgi?id=117762
1567 Reviewed by Mark Rowe.
1569 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1570 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1571 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1572 Add ASAN_OTHER_LDFLAGS.
1573 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1574 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1575 * Scripts/check-for-weak-vtables-and-externals:
1576 Ignore ___asan externals, these are populated by compiler-rt.
1577 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1578 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1579 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1580 Add ASAN_OTHER_LDFLAGS.
1581 * WebKitLauncher/Configurations/Base.xcconfig:
1582 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1583 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
1584 Add ASAN_OTHER_LDFLAGS.
1585 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1586 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1587 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1588 Add ASAN_OTHER_LDFLAGS.
1589 * asan/asan.xcconfig: Added.
1590 * asan/webkit-asan-ignore.txt: Added.
1592 2013-08-05 Brian Holt <brian.holt@samsung.com>
1594 [GTK] Implement leak checking with valgrind
1595 https://bugs.webkit.org/show_bug.cgi?id=118785
1597 Reviewed by Dirk Pranke.
1599 Launch the DRT under Valgrind to generate xml files with details
1602 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1604 * Scripts/webkitpy/port/gtk.py:
1606 (GtkPort.default_timeout_ms): Allow extra time to run under
1608 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1609 using environment variables.
1611 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
1613 [EFL] REGRESSION after r153432: some accessibility tests crash.
1614 https://bugs.webkit.org/show_bug.cgi?id=119333
1616 Reviewed by Gustavo Noronha Silva.
1618 Add missing null-check to avoid dereferencing a non-existent parent.
1620 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1621 (WTR::attributesOfElement): Ditto.
1623 2013-08-02 Patrick Gansterer <paroga@webkit.org>
1625 Add --rmdir option to git svn dcommit
1626 https://bugs.webkit.org/show_bug.cgi?id=119398
1628 Reviewed by Ryosuke Niwa.
1630 Add this option tells git-svn to remove empty directories
1631 from the svn tree so they do not leave over there.
1633 * Scripts/webkitpy/common/checkout/scm/git.py:
1634 (Git.push_local_commits_to_server):
1636 2013-08-01 Brent Fulgham <bfulgham@apple.com>
1638 [Windows] WebKit1 Fullscreen Video Play is Broken
1639 https://bugs.webkit.org/show_bug.cgi?id=119415
1641 Reviewed by Jer Noble.
1643 * WinLauncher/WinLauncher.cpp:
1644 (dllLauncherEntryPoint): Activate full screen mode via
1645 IWebPreferencesInternal interface.
1647 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
1649 Unreviewed. Add an alternative address to show my affiliation in team.html.
1651 * Scripts/webkitpy/common/config/contributors.json:
1653 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
1655 Duplicate property names can cause test to fail
1656 https://bugs.webkit.org/show_bug.cgi?id=119399
1658 Reviewed by Dirk Pranke.
1660 This problem was noticed when porting the patch for
1661 http://wkb.ug/119357 to Blink: a test would fail because the converted
1662 and test property lists weren't the same length, but they contained
1663 all of the same property names. It looks like this is actually caused
1664 by a bug in converting the HTML, which is being currently rewritten.
1665 In the meantime, as long as this compares the number of unique
1666 properties, it makes the test more robust.
1668 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1669 (verify_prefixed_properties):
1671 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
1673 Unreviewed. Adding my expertise.
1675 * Scripts/webkitpy/common/config/contributors.json:
1677 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
1679 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1681 * Scripts/webkitpy/common/config/contributors.json:
1683 2013-08-01 Commit Queue <commit-queue@webkit.org>
1685 Unreviewed, rolling out r153518.
1686 http://trac.webkit.org/changeset/153518
1687 https://bugs.webkit.org/show_bug.cgi?id=119386
1689 The Jhbuild dep bump of GTK+ is not actually required by
1690 layout testing, is causing pango dep problems (Requested by
1691 zdobersek on #webkit).
1693 * gtk/jhbuild.modules:
1695 2013-08-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
1697 Unreviewed. Add myself as a committer.
1699 * Scripts/webkitpy/common/config/contributors.json:
1701 2013-08-01 Jaehun Lim <ljaehun.lim@samsung.com>
1703 Unreviewed. Add myself as a committer.
1705 * Scripts/webkitpy/common/config/contributors.json:
1707 2013-07-31 Jinwoo Song <jinwoo7.song@samsung.com>
1709 Unreviewed. Add myself as a committer.
1711 * Scripts/webkitpy/common/config/contributors.json:
1713 2013-08-01 Alberto Garcia <berto@igalia.com>
1715 Unreviewed. Add myself as a committer.
1717 * Scripts/webkitpy/common/config/contributors.json:
1719 2013-07-31 Seokju Kwon <seokju@webkit.org>
1721 Unreviewed. Add myself as a committer.
1723 * Scripts/webkitpy/common/config/contributors.json:
1725 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1727 W3C test import script prefixes some properties that it shouldn't
1728 https://bugs.webkit.org/show_bug.cgi?id=119357
1730 Reviewed by Dirk Pranke.
1732 Some prefixed properties also have unprefixed implemetations, but when
1733 the implementations aren't identical, they aren't declared in
1734 CSSPropertyNames.in on the same line. This fixes the import script so
1735 that it catches all instances of prefixed properties that have an
1736 unprefixed variant, and does not add the prefix in those cases.
1738 * Scripts/webkitpy/w3c/test_converter.py:
1739 (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1740 the properties on every line and record if they are prefixed or not.
1741 Use this information to only return prefixed properties that do not
1742 have any unprefixed variant. The prefixed property list has also
1743 changed to not include the '-webkit-' prefix, making it much easier to
1744 do the comparison, and removing the need to remove the prefix later.
1745 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1746 longer needs to remove the '-webkit-' prefix, but needs to add it in
1747 the case where a property that needs a prefix is found.
1748 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1749 (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1750 for '-webkit-' prefix, as it is no longer included in the properties
1751 in the prefixed property list.
1753 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1755 Update location of w3c shapes tests to reflect new import location
1756 https://bugs.webkit.org/show_bug.cgi?id=118156
1758 Reviewed by Dirk Pranke.
1760 Partial imports should not be imported to the same place as the full
1761 import, so this adds an option to allow importing to a different
1762 location than the default. In doing that, I found that imports from
1763 contributor directories didn't seem to be working correctly, so I
1764 updated the import to be smarter about both contributor directories
1765 and the test status directories. It should now be more likely that the
1766 script guesses the root directory properly.
1768 * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1769 script not working with the full set of contributors, as that is
1770 no longer true, and I didn't see a good way to keep that behavior.
1771 Also update documentation to properly explain what happens when a
1772 contributor dir is imported.
1773 (main): Attempt to find the proper repo dir by looking at the
1774 directory above the "test status" in the given path, this is still
1775 not exactly right, but is less error prone than just trimming.
1776 (parse_args): Add -d option to set the import directory.
1777 (TestImporter.__init__): Stop appending the subdirs to the
1778 destination_directory because it was making things more complex
1779 and isn't really needed.
1780 (TestImporter.update_test_status): Remove hardcoded strings and use
1781 the TEST_STATUS constants instead.
1782 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1783 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1784 support for new option.
1785 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1787 2013-07-31 Brent Fulgham <bfulgham@apple.com>
1789 [Windows] Winlauncher shouldn't look for Safari Install Directory
1790 https://bugs.webkit.org/show_bug.cgi?id=119351
1792 Reviewed by Darin Adler.
1794 * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1795 the Safari install location. Instead, use the proper support
1796 library path for the build architecture.
1798 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1800 Update scripts to reference contributors.json instead of committers.py in messaging
1801 https://bugs.webkit.org/show_bug.cgi?id=119342
1803 Reviewed by Ryosuke Niwa.
1805 Change the scripts to point people to contributors.json instead of
1806 committers.py since the latter no longer contains the list of
1809 * Scripts/webkitpy/common/config/committervalidator.py:
1810 (CommitterValidator._contributors_json_path):
1811 (CommitterValidator._flag_permission_rejection_message):
1812 * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1813 (CommitterValidatorTest.test_flag_permission_rejection_message):
1814 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1815 (Bugzilla._commit_queue_flag):
1816 * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1817 (WatchListParser._validate):
1818 * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1819 (WatchListParserTest.test_cc_rule_with_invalid_email):
1820 * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1821 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1822 * Scripts/webkitpy/tool/steps/validatereviewer.py:
1823 (ValidateReviewer.run):
1825 2013-07-31 Roger Fong <roger_fong@apple.com>
1827 Unreviewed. Re-enable WinEWS tests following r153527.
1829 * Scripts/webkitpy/common/config/ews.json:
1831 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1833 Unreviewed: Adding myself to the committers' list.
1835 * Scripts/webkitpy/common/config/contributors.json:
1837 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1839 [Qt] Build WebKit with C++11
1840 https://bugs.webkit.org/show_bug.cgi?id=119337
1842 Reviewed by Csaba Osztrogonác.
1844 Enable building with C++11.
1846 * qmake/mkspecs/features/default_pre.prf:
1847 * qmake/mkspecs/features/unix/default_post.prf:
1848 * qmake/mkspecs/features/unix/default_pre.prf:
1850 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1852 [Qt] ASSERTS trigger in release builds
1853 https://bugs.webkit.org/show_bug.cgi?id=119336
1855 Reviewed by Jocelyn Turcotte.
1857 Ensure the qmake also defaults to release if no configuration is known.
1859 * qmake/mkspecs/features/default_post.prf:
1861 2013-07-31 Zan Dobersek <zdobersek@igalia.com>
1863 [texmap][GStreamer][GTK] composited video shows tearing
1864 https://bugs.webkit.org/show_bug.cgi?id=118253
1866 Reviewed by Martin Robinson.
1868 * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1869 The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1870 screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1872 2013-07-30 Ruth Fong <ruth_fong@apple.com>
1874 Unreviewed: Adding myself to the committers' list.
1876 * Scripts/webkitpy/common/config/contributors.json:
1878 2013-07-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1880 Unreviewed, add my new email to contributors.json.
1882 * Scripts/webkitpy/common/config/contributors.json:
1884 2013-07-30 Krzysztof Czech <k.czech@samsung.com>
1886 [EFL] REGRESSION after r153439: layout tests do not run.
1887 https://bugs.webkit.org/show_bug.cgi?id=119240
1889 Reviewed by Christophe Dumez.
1891 Changed attribute name from check_xvfb to check_driver.
1893 * Scripts/webkitpy/port/efl.py:
1894 (EflPort.check_sys_deps):
1896 2013-07-29 Commit Queue <commit-queue@webkit.org>
1898 Unreviewed, rolling out r152860.
1899 http://trac.webkit.org/changeset/152860
1900 https://bugs.webkit.org/show_bug.cgi?id=119227
1902 Disable WinEWS tests until tests stop crashing (Requested by
1905 * Scripts/webkitpy/common/config/ews.json:
1907 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1909 [GTK] Add WestonDriver, use it when appropriate
1910 https://bugs.webkit.org/show_bug.cgi?id=119100
1912 Reviewed by Dirk Pranke.
1914 Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1915 and sets up an environment that enables the test runner to run inside it.
1917 The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1918 environment variable is set, that is when NRWT is being run under a Wayland display.
1920 * Scripts/webkitpy/port/base.py:
1921 (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1922 * Scripts/webkitpy/port/gtk.py:
1924 (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1925 should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1926 (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1927 instead of hard-coding the XvfbDriver class in the check.
1928 * Scripts/webkitpy/port/westondriver.py: Added.
1930 (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1931 (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1932 (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1933 driver and then launches the driver in said environment, using the driver's Weston display.
1934 (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1935 (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1936 and returns the absolute path to it.
1937 * Scripts/webkitpy/port/xvfbdriver.py:
1938 (XvfbDriver.check_driver): Renamed from check_xvfb.
1939 (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1941 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1943 [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1944 https://bugs.webkit.org/show_bug.cgi?id=118967
1946 Reviewed by Gustavo Noronha Silva.
1948 Implemented AccessibilityUIElement::attributesOfChildren() both
1949 in DumpRenderTree and the WebKitTestRunner.
1951 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1952 (AccessibilityUIElement::attributesOfChildren): Implemented.
1954 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1955 (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1957 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1959 [ATK] Implement allAttributes() for AccessibilityUIElement
1960 https://bugs.webkit.org/show_bug.cgi?id=118966
1962 Reviewed by Gustavo Noronha Silva.
1964 Implemented AccessibilityUIElement::allAttributes() both in
1965 DumpRenderTree and the WebKitTestRunner.
1967 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1968 (getAtkAttributeSetAsString): Moved up in the file, and refactored
1969 to use StringBuilder and return a String instead of a gchar*.
1970 (roleToString): Changed not to return the "AXRole: " prefix, so
1971 we can use it as well from attributesOfElement().
1972 (attributesOfElement): New function to dump attributes for an object.
1973 (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1974 (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1976 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1977 (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1978 a String instead of a gchar*.
1980 (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1981 so we can use it as well from attributesOfElement().
1982 (WTF::attributesOfElement): New function to dump attributes for an object.
1983 (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1984 (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1986 2013-07-29 Daniel Bates <dabates@apple.com>
1988 Add support infrastructure for iOS WebKit port
1989 https://bugs.webkit.org/show_bug.cgi?id=119168
1991 Reviewed by Ryosuke Niwa.
1993 Implement support infrastructure towards building iOS WebKit.
1995 * Scripts/webkitdirs.pm:
1996 (xcodeSDKPlatformName): Added.
1997 (determineConfigurationProductDir):
1998 (builtDylibPathForName):
1999 (willUseIOSDeviceSDKWhenBuilding): Added.
2000 (willUseIOSSimulatorSDKWhenBuilding): Added.
2001 (isIOSWebKit): Added.
2002 (copyInspectorFrontendFiles):
2004 2013-07-29 Sergio Correia <sergio.correia@openbossa.org>
2006 CoordinatedGraphics: Add API to get and set the active state of a WebView
2007 https://bugs.webkit.org/show_bug.cgi?id=119067
2009 Reviewed by Noam Rosenthal.
2011 Added API tests for WKViewIsActive and WKViewSetIsActive.
2013 * TestWebKitAPI/PlatformEfl.cmake:
2014 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
2015 (TestWebKitAPI::didFinishLoadForFrame):
2016 (TestWebKitAPI::webProcessCrashed):
2017 (TestWebKitAPI::webProcessRelaunched):
2018 (TestWebKitAPI::TEST):
2019 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
2020 Bundle added to allow crashing the WebProcess and testing the active state of a view
2021 under such condition.
2022 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
2023 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
2025 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
2027 [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
2028 https://bugs.webkit.org/show_bug.cgi?id=119212
2030 Reviewed by Carlos Garcia Campos.
2032 * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
2033 variables that are not defined during the configuration process.
2034 * TestWebKitAPI/GNUmakefile.am: Ditto.
2035 * WebKitTestRunner/GNUmakefile.am: Ditto.
2037 2013-07-28 Andy Estes <aestes@apple.com>
2039 Include <stdio.h> to declare perror()
2040 https://bugs.webkit.org/show_bug.cgi?id=119198
2042 Reviewed by Andreas Kling.
2044 Silences an implicit declaration warning.
2046 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
2048 2013-07-27 Ryuan Choi <ryuan.choi@samsung.com>
2050 [EFL] Bump required version of EFL to 1.7
2051 https://bugs.webkit.org/show_bug.cgi?id=119144
2053 Reviewed by Christophe Dumez.
2055 * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
2057 2013-07-26 Filip Pizlo <fpizlo@apple.com>
2059 WKTR should know about the JSC extensions to testRunner
2060 https://bugs.webkit.org/show_bug.cgi?id=119154
2062 Reviewed by Mark Hahnenberg and Geoffrey Garen.
2064 This makes some fast/js tests pass.
2066 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2067 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2068 (WTR::TestRunner::numberOfDFGCompiles):
2069 (WTR::TestRunner::neverInlineFunction):
2070 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2072 2013-07-25 Mark Rowe <mrowe@apple.com>
2074 Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
2076 * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
2077 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
2078 so they pull the version out of the SDK.
2080 2013-07-25 Anders Carlsson <andersca@apple.com>
2082 Localizable.strings generated by extract-localizable-strings should be UTF-8
2083 https://bugs.webkit.org/show_bug.cgi?id=119106
2085 Reviewed by Mark Rowe.
2087 Output strings as UTF-8.
2089 * Scripts/extract-localizable-strings:
2091 2013-07-25 Sam Weinig <sam@webkit.org>
2093 -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
2094 https://bugs.webkit.org/show_bug.cgi?id=119099
2095 <rdar://problem/13439291>
2097 Reviewed by Enrica Casucci.
2099 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2100 * TestWebKitAPI/Tests/mac/AttributedString.mm:
2101 (TestWebKitAPI::attributedString):
2102 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2103 (TestWebKitAPI::AttributedStringTest_CustomFont::url):
2104 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
2105 (TestWebKitAPI::TEST_F):
2106 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2107 (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
2108 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
2109 * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
2110 Add tests for attributed strings with strikethrough. Refactor the attributed string tests
2111 to make adding more easier in the future.
2113 2013-07-20 Filip Pizlo <fpizlo@apple.com>
2115 fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
2116 https://bugs.webkit.org/show_bug.cgi?id=118948
2118 Reviewed by Sam Weinig.
2120 - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
2121 by exporting it as a function.
2123 - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
2124 it even if you know that you've already done so. See processIRDump.sh.
2126 - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
2127 runs it through ReducedFTL automatically. You typically want to say something like:
2129 jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
2130 ./processIRDump.sh --timing < jsc-output.txt
2132 * ReducedFTL/ReducedFTL.c:
2134 * ReducedFTL/combineModules.rb:
2135 * ReducedFTL/processIRDump.sh: Added.
2137 2013-07-20 Filip Pizlo <fpizlo@apple.com>
2139 fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
2140 https://bugs.webkit.org/show_bug.cgi?id=118947
2142 Reviewed by Dan Bernstein.
2144 * Scripts/copy-webkitlibraries-to-product-directory:
2146 2013-07-16 Filip Pizlo <fpizlo@apple.com>
2148 fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
2149 https://bugs.webkit.org/show_bug.cgi?id=118647
2151 Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
2153 Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
2154 way that the FTL would.
2156 Also add a tool that combines multiple LLVM modules generated by FTL into a
2159 * ReducedFTL: Added.
2160 * ReducedFTL/ReducedFTL.c: Added.
2164 (mmAllocateCodeSection):
2165 (mmAllocateDataSection):
2166 (mmApplyPermissions):
2168 (symbolLookupCallback):
2170 * ReducedFTL/build.sh: Added.
2171 * ReducedFTL/combineModules.rb: Added.
2173 2013-06-09 Filip Pizlo <fpizlo@apple.com>
2175 Unreviewed, fix minor goof in profiling output layout. We weren't accounting
2176 for the "/" that is printed between engine counts.
2178 * Scripts/display-profiler-output:
2180 2013-05-28 Filip Pizlo <fpizlo@apple.com>
2182 testRunner should have a way of disabling inlining of functions
2183 https://bugs.webkit.org/show_bug.cgi?id=116875
2185 Reviewed by Mark Hahnenberg.
2187 * DumpRenderTree/TestRunner.cpp:
2188 (neverInlineFunction):
2189 (TestRunner::staticFunctions):
2191 2013-05-27 Filip Pizlo <fpizlo@apple.com>
2193 testRunner should be able to tell you if a function is DFG compiled
2194 https://bugs.webkit.org/show_bug.cgi?id=116847
2196 Reviewed by Mark Hahnenberg.
2198 * DumpRenderTree/TestRunner.cpp:
2199 (numberOfDFGCompiles):
2200 (TestRunner::staticFunctions):
2202 2013-05-21 Filip Pizlo <fpizlo@apple.com>
2204 fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
2205 https://bugs.webkit.org/show_bug.cgi?id=116556
2207 Reviewed by Oliver Hunt.
2209 This adds three new capabilities:
2211 - 'display' now accepts negative compilation indices, and allows specifying
2212 wildcard hashes combined with combination indices. Previously you could say
2213 'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
2214 latter would display every compilation. This improves this so that you can
2215 say 'display *-<index>-<engine>'. It also makes it so that you can give a
2216 negative index, which allows you to say things like 'display blah--1-dfg',
2217 which displays just the last DFG compilation. Also you can say
2218 'display *--1-dfg', which displays the last DFG compilation for each code
2219 block. I realize that this is kind of ugly, but gosh is it practical.
2221 - You can now say 'sort hash', which will henceforth sort all of the output
2222 by code hash rather than by the time when it was compiled. This means that
2223 if you're doing 'dispay *--1-dfg' and then want to diff the results against
2224 something else, you can ensure that this doesn't get confused just by
2225 changes in compilation order.
2227 - You can now say 'counts off', which will henceforth disable the display of
2228 execution counts from 'bytecode' and 'display'. This is also useful for
2229 diffs, since if you're trying to figure out why two compilations are
2230 different, they probably have radically different counts. 'counts off' gets
2231 this out of the output so that it doesn't confuse your diff.
2233 Note that to use this effectively you should also have a script that scrubs
2234 pointers from text so that the diff doesn't get confused by pointers. I'll
2235 post my elimptr script to the bug. Maybe at some point I'll integrate that
2236 into display-profiler-output.
2238 Put together this is pretty awesome. I was able to do the following:
2240 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
2241 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
2242 diff -u richards-serial.asm richards-concurrent.asm
2244 And this immediately told me that the reason why richards is slower in the
2245 concurrent compilation case is just that we end up compiling *tons* more
2246 functions, most of which are trivially inlineable. Basically, concurrent
2247 compilation breaks our previous heuristics for delaying compilation of
2248 inlineables just enough that they never trigger compilation. We should fix
2249 that in a separate bug.
2251 * Scripts/display-profiler-output:
2253 2013-04-30 Filip Pizlo <fpizlo@apple.com>
2255 fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
2257 Rubber stamped by Mark Rowe.
2259 * Scripts/copy-webkitlibraries-to-product-directory:
2261 2013-07-16 Oliver Hunt <oliver@apple.com>
2263 Merge dfgFourthTier r148853
2265 2013-04-21 Filip Pizlo <fpizlo@apple.com>
2267 fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
2268 https://bugs.webkit.org/show_bug.cgi?id=114933
2270 Reviewed by Andy Estes.
2272 This makes it easy to get set up for tandem LLVM builds.
2274 * Scripts/copy-webkitlibraries-to-product-directory:
2276 2013-07-16 Oliver Hunt <oliver@apple.com>
2278 Merge dfgFourthTier r148850
2280 2013-04-21 Filip Pizlo <fpizlo@apple.com>
2282 fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
2283 https://bugs.webkit.org/show_bug.cgi?id=114926
2285 Reviewed by Geoffrey Garen.
2287 If the LLVM libraries change, then touch a phony header, which will force relink
2290 * Scripts/copy-webkitlibraries-to-product-directory:
2291 (unpackIfNecessary):
2293 2013-07-16 Oliver Hunt <oliver@apple.com>
2295 Merge dfgFourthTier r148848
2297 2013-04-21 Filip Pizlo <fpizlo@apple.com>
2299 fourthTier: developing LLVM in tandem with WebKit should be fun and easy
2300 https://bugs.webkit.org/show_bug.cgi?id=114925
2302 Reviewed by Geoffrey Garen.
2304 This enables building LLVM along with WebKit, so that build-jsc and build-webkit
2305 will also optionally build LLVM and quickly symlink LLVM's built products into
2308 Most WebKit and JSC hackers will want to rely on the checked-in already-built
2309 versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
2310 increasingly common use-case for me, and it may become a common use case for a
2311 handful of others. Currently, this is really painful: you first have to build
2312 LLVM, then you have to export-llvm-build (which takes a while), and then you
2313 have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
2314 variables are set to point to the thing you exported. The whole process loses
2315 track of dependencies very quickly: making a tiny change in LLVM requires
2316 packaging, and then unpackaging, a large number of potentially large headers and
2317 static libraries. Not only is this slow but it then causes the WebKit build
2318 system to rebuild anything that transitively includes any LLVM header, which is
2319 now quite a few files. While this sort of use pattern is still worthwhile if
2320 you're trying to package a binary drop and test it, it's not great if you're
2321 just trying to do experimental development that involves making small changes
2324 This change fixes this use case while keeping the old use cases intact. You can
2325 do tandem development using one of two modes:
2327 Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
2328 the LLVM directory you're using. Once this is done, any invocation of a WebKit
2329 build via build-jsc or build-webkit will also build LLVM, and then quickly
2330 symlink things into place without perturbing dependency tracking.
2332 Internal LLVM directory: if you check out llvm into a directory called 'llvm'
2333 right off of the WebKit source tree, then the build system will automatically
2336 Here's how this takes care of dependencies:
2338 Headers: the include/llvm and include/llvm-c directories are symlinked into
2339 $productsDir/usr/local/include. And then everything just works.
2341 Libraries: the build system detects, by reading LLVM's Makefile.config, which
2342 mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
2343 the .a files into $productsDir/<thingy>. It will ranlib those libraries only
2344 if they have changed, by checking both the modification time and also whether
2345 the last time we had a symlink, that symlink was from the same directory.
2346 This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
2347 but that build wasn't yet ranlib'd.
2349 One problem that this does not yet solve is that xcodebuild will not relink
2350 JavaScriptCore if the only thing that changed was the libraries. I will work
2351 on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
2353 * Scripts/copy-webkitlibraries-to-product-directory:
2354 (unpackIfNecessary):
2356 (fileContentsEquals):
2358 2013-04-15 Filip Pizlo <fpizlo@apple.com>
2360 fourthTier: Update LLVM-related build scripts to copy generated headers as well
2361 https://bugs.webkit.org/show_bug.cgi?id=114551
2363 Reviewed by Oliver Hunt.
2365 Also added the ability to use something other than bzip2 compression, since although
2366 it is great for checking things into the tree, it increases turn-around times when
2369 * Scripts/copy-webkitlibraries-to-product-directory:
2370 (unpackIfNecessary):
2371 * Scripts/export-llvm-build:
2373 2013-04-03 Filip Pizlo <fpizlo@apple.com>
2375 fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
2376 https://bugs.webkit.org/show_bug.cgi?id=113921
2378 Reviewed by Oliver Hunt.
2380 The LLVM community wants us to continue including all of LLVM's C++ headers. Change
2381 the export script to do this.
2383 * Scripts/export-llvm-build:
2385 2013-03-29 Filip Pizlo <fpizlo@apple.com>
2387 fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
2388 https://bugs.webkit.org/show_bug.cgi?id=113452
2390 Rubber stamped by Mark Hahnenberg.
2392 * Scripts/copy-webkitlibraries-to-product-directory:
2393 * Scripts/export-llvm-build:
2395 2013-03-29 Filip Pizlo <fpizlo@apple.com>
2397 fourthTier: FTL JIT should be able run some simple function
2398 https://bugs.webkit.org/show_bug.cgi?id=113481
2400 Reviewed by Geoffrey Garen.
2402 Give the scripts the ability to find an LLVM build and use it.
2404 Also added a script, export-llvm-build, that allows you to take your
2405 own build of LLVM and package it for use by WebKit's build system.
2407 The build system treats a "build" of LLVM as a pair of .tar.bz2's,
2408 one for the library archives and one for the headers. It then unpacks
2409 them into your built products directory in a mannner that is mostly
2410 analogous to how WebKitSystemInterface works.
2412 * Scripts/build-jsc:
2413 * Scripts/copy-webkitlibraries-to-product-directory:
2414 (unpackIfNecessary):
2416 * Scripts/export-llvm-build: Added.
2418 2013-07-24 Anders Carlsson <andersca@apple.com>
2420 Crash when calling WKPageGetProcessIdentifier after aborted process launch
2421 https://bugs.webkit.org/show_bug.cgi?id=119069
2422 <rdar://problem/14494064>
2424 Reviewed by Andreas Kling.
2428 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2429 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
2430 (TestWebKitAPI::didFinishLoadForFrame):
2431 (TestWebKitAPI::TEST):
2433 2013-07-24 Zan Dobersek <zdobersek@igalia.com>
2435 Make KURL::hasPath private
2436 https://bugs.webkit.org/show_bug.cgi?id=118279
2438 Reviewed by Darin Adler.
2440 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2441 (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
2443 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
2445 [GTK] TestInspectorServer unit test is timing out
2446 https://bugs.webkit.org/show_bug.cgi?id=105866
2448 Reviewed by Gustavo Noronha Silva.
2450 * Scripts/run-gtk-tests:
2453 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
2455 [GTK] [WK2] Handle wheel event with delta zero
2456 https://bugs.webkit.org/show_bug.cgi?id=118973
2458 Reviewed by Gustavo Noronha Silva.
2460 Added handling of zero mouse scroll deltas in EventSenderProxy similar
2461 to WK1 and Qt/EFL ports.
2463 fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
2466 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2467 (WTR::EventSenderProxy::mouseScrollBy):
2469 2013-07-23 Andreas Kling <akling@apple.com>
2471 REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
2472 <rdar://problem/14324895>
2473 <http://webkit.org/b/119023>
2475 Reviewed by Simon Fraser.
2477 Add a test for this rather specific problem.
2479 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2480 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
2481 (TestWebKitAPI::TEST):
2482 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
2483 (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
2484 (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
2485 (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2487 2013-07-23 Tim Horton <timothy_horton@apple.com>
2489 Add a test for plug-in unavailability indicator obscurity detection
2490 https://bugs.webkit.org/show_bug.cgi?id=119007
2492 Reviewed by Anders Carlsson.
2494 Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
2496 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2497 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2498 (WTR::TestRunner::setBlockAllPlugins):
2499 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2500 * WebKitTestRunner/TestInvocation.cpp:
2501 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2502 Add testRunner.setBlockAllPlugins function (and corresponding message to
2503 forward it through to TestController).
2505 * WebKitTestRunner/TestController.cpp:
2506 Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
2508 (WTR::TestController::createWebViewWithOptions):
2509 Register our pluginLoadPolicy callback.
2511 (WTR::TestController::resetStateToConsistentValues):
2512 Reset m_shouldBlockAllPlugins to false.
2514 (WTR::TestController::pluginLoadPolicy):
2515 Return the existing plugin load policy, unless setBlockAllPlugins(true)
2516 was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
2518 * WebKitTestRunner/TestController.h:
2519 (WTR::TestController::setBlockAllPlugins):
2521 2013-07-21 Andreas Kling <akling@apple.com>
2523 KURL creates duplicate strings when completing data: URIs.
2524 <http://webkit.org/b/118952>
2525 <rdar://problem/14504480>
2527 Reviewed by Anders Carlsson.
2529 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2530 (TestWebKitAPI::TEST_F):
2532 2013-07-19 Chris Fleizach <cfleizach@apple.com>
2534 AX: VoiceOver not detecting misspelled words don't work in all cases
2535 https://bugs.webkit.org/show_bug.cgi?id=118924
2537 Reviewed by Tim Horton.
2539 Make the misspelled detection dependent on both types of attributes being present.
2541 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2542 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2543 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2544 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2546 2013-07-19 Alex Christensen <achristensen@apple.com>
2548 Improved code coverage generation.
2549 https://bugs.webkit.org/show_bug.cgi?id=118926
2551 Reviewed by Tim Horton.
2553 * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
2554 * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
2555 (generateReport): Moved report generation to a subroutine.
2557 2013-07-19 Stephanie Lewis <slewis@apple.com>
2559 <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
2563 Rebaseline pagination test after http://trac.webkit.org/changeset/152911
2565 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2566 (TestWebKitAPI::didLayout):
2568 2013-07-19 Daniel Bates <dabates@apple.com>
2570 Make Perl tools work when using git bisect with Git branch build setup
2571 https://bugs.webkit.org/show_bug.cgi?id=118512
2573 Reviewed by Martin Robinson.
2575 The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
2576 during a git bisect session with a Git branch build setup (i.e. git config
2577 core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
2578 specific build of WebKit because they cannot determine the branch Git is on (since
2579 git bisect puts Git into a detached HEAD state). We should teach our tooling to
2580 parse the file .git/BISECT_START (created by git bisect start) for the name of the
2581 branch Git was on when we began a git bisect session. Then the tools can determine
2582 the path to the built WebKit.
2584 * Scripts/VCSUtils.pm:
2585 (gitDirectory): Added.
2586 (gitBisectStartBranch): Added.
2587 (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
2588 HEAD (e.g. running git bisect).
2589 (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2590 the .git directory in the Git checkout.
2592 2013-07-19 Alex Christensen <achristensen@apple.com>
2594 Added x64 configuration to Visual Studio build.
2595 https://bugs.webkit.org/show_bug.cgi?id=118888
2597 Reviewed by Brent Fulgham.
2599 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2600 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2601 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2602 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2603 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2604 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2605 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2606 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2607 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2608 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2609 * win/record-memory/record-memory.vcxproj:
2611 2013-07-19 Martin Robinson <mrobinson@igalia.com>
2613 Add a couple people to the MathML watchlist
2614 https://bugs.webkit.org/show_bug.cgi?id=118909
2616 Reviewed by Andreas Kling.
2618 Add a couple people to the MathML watchlist and add Kalyan's other
2619 email address to fix style checker warnings about the watchlist
2622 * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
2623 list of contributors and add Kalyan's second email address.
2624 * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
2627 2013-07-19 Simon Pena <simon.pena@samsung.com>
2629 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
2630 https://bugs.webkit.org/show_bug.cgi?id=118895
2632 Reviewed by Philippe Normand.
2634 In r152782 an uri is used to create an string representation without checking first if it
2635 is valid. That fails later when the string is used to check for existing redirections. This
2636 patch ensures that the uri is valid before using it.
2638 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2639 (willSendRequestCallback): Ensure an uri is valid before using it.
2641 2013-07-18 Timothy Hatcher <timothy@apple.com>
2643 Add extract-localizable-js-strings and use it for WebInspectorUI.
2645 https://bugs.webkit.org/show_bug.cgi?id=118851
2647 Reviewed by Joseph Pecoraro.
2649 * Scripts/extract-localizable-js-strings: Added.
2650 * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
2651 * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
2652 the WebInspectorUI project.
2654 2013-07-18 Brent Fulgham <bfulgham@apple.com>
2656 [Windows] Build correction #2 after r152861.
2658 * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2660 2013-07-18 Brent Fulgham <bfulgham@apple.com>
2662 [Windows] Build correction after r152861.
2664 * WinLauncher/WinLauncher.cpp: Don't reference private header.
2666 2013-07-16 Brent Fulgham <bfulgham@apple.com>
2668 [Win] Support in-band text tracks.
2669 https://bugs.webkit.org/show_bug.cgi?id=103770
2671 Reviewed by Eric Carlson.
2673 Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2674 libdispatch and CFRunLoop elements are services during the run loop.
2676 * WinLauncher/WinLauncher.cpp:
2677 (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2678 a CoreFoundation (or CFLite) support library.
2679 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2680 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2681 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2682 and WinLauncherCFLite.props.
2684 2013-07-18 Roger Fong <roger_fong@apple.com>
2686 Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2688 * Scripts/webkitpy/common/config/ews.json:
2690 2013-07-18 Daniel Bates <dabates@apple.com>
2692 REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2693 https://bugs.webkit.org/show_bug.cgi?id=118854
2694 <rdar://problem/14081339>
2696 Reviewed by David Kilzer.
2698 Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2699 Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2700 run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2701 listen on these ports so that we can run tests that use port 8443 and 8080.
2703 * Scripts/old-run-webkit-tests:
2704 (configureAndOpenHTTPDIfNeeded):
2706 2013-07-17 Tim Horton <timothy_horton@apple.com>
2708 Update blocked/missing plug-in UI
2709 https://bugs.webkit.org/show_bug.cgi?id=118347
2710 <rdar://problem/14209318>
2712 Reviewed by Sam Weinig.
2714 * MiniBrowser/mac/WK2BrowserWindowController.m:
2715 (-[WK2BrowserWindowController awakeFromNib]):
2716 * WebKitTestRunner/TestController.cpp:
2717 (WTR::TestController::createWebViewWithOptions):
2718 Match new WKPageLoaderClient entry.
2720 2013-07-17 Commit Queue <commit-queue@webkit.org>
2722 Unreviewed, rolling out r152701, r152703, r152739, r152754,
2724 http://trac.webkit.org/changeset/152701
2725 http://trac.webkit.org/changeset/152703
2726 http://trac.webkit.org/changeset/152739
2727 http://trac.webkit.org/changeset/152754
2728 http://trac.webkit.org/changeset/152756
2729 https://bugs.webkit.org/show_bug.cgi?id=118821
2731 this was a buggy fix and we're going to try something
2732 different (Requested by thorton on #webkit).
2734 * MiniBrowser/mac/WK2BrowserWindowController.m:
2735 (-[WK2BrowserWindowController awakeFromNib]):
2736 * WebKitTestRunner/TestController.cpp:
2737 (WTR::TestController::createWebViewWithOptions):
2739 2013-07-17 Commit Queue <commit-queue@webkit.org>
2741 Unreviewed, rolling out r151535.
2742 http://trac.webkit.org/changeset/151535
2743 https://bugs.webkit.org/show_bug.cgi?id=118804
2745 Re-disable WinEWS tests (Requested by rfong on #webkit).
2747 * Scripts/webkitpy/common/config/ews.json:
2749 2013-07-17 Simon Pena <simon.pena@samsung.com>
2751 [GTK] Make DRT obbey testRunner's addURLToRedirect
2752 https://bugs.webkit.org/show_bug.cgi?id=118239
2754 Reviewed by Gustavo Noronha Silva.
2756 Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2757 to the proper URI when indicated.
2759 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2760 (willSendRequestCallback):
2762 2013-07-17 Gabor Abraham <abrhm@inf.u-szeged.hu>
2764 Add a new find-resolved-bugs command to webkit-patch.
2765 https://bugs.webkit.org/show_bug.cgi?id=118060
2767 Reviewed by Csaba Osztrogonác.
2769 * Scripts/webkitpy/tool/commands/queries.py:
2770 (PrintBaselines._platform_for_path):
2772 (FindResolvedBugs.execute):
2774 2013-07-16 Balazs Kelemen <kbalazs@webkit.org>
2776 [CMake] Undefined references should be detected at build time
2777 https://bugs.webkit.org/show_bug.cgi?id=110236
2779 Reviewed by Christophe Dumez.
2781 Add library dependencies that were not defined explicitly before.
2783 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2784 * TestWebKitAPI/CMakeLists.txt:
2785 * WebKitTestRunner/CMakeLists.txt:
2787 2013-07-16 Kwang Yul Seo <skyul@company100.net>
2789 check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2790 https://bugs.webkit.org/show_bug.cgi?id=118755
2792 Reviewed by Ryosuke Niwa.
2794 Fix r152719 to check "using namespace foo;" only in headers.
2796 * Scripts/webkitpy/style/checkers/cpp.py:
2797 (check_using_namespace):
2799 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2800 (WebKitStyleTest.test_using_namespace):
2802 2013-07-16 Christophe Dumez <ch.dumez@sisa.samsung.com>
2804 Get rid of multiple inheritance support from the bindings generators
2805 https://bugs.webkit.org/show_bug.cgi?id=118353
2807 Reviewed by Kentaro Hara.
2809 Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2810 deprecated domInterface->parents.
2812 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2815 2013-07-16 Brian Holt <brian.holt@samsung.com>
2817 check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2818 https://bugs.webkit.org/show_bug.cgi?id=57241
2820 Reviewed by Ryosuke Niwa.
2822 Added check for "using namespace foo" and unit test.
2824 * Scripts/webkitpy/style/checkers/cpp.py:
2825 (check_using_namespace):
2828 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2829 (WebKitStyleTest.test_using_namespace):
2831 2013-07-16 Anton Obzhirov <a.obzhirov@samsung.com>
2833 [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2834 https://bugs.webkit.org/show_bug.cgi?id=110222
2836 Reviewed by Gustavo Noronha Silva.
2838 Added handling of zero mouse scroll deltas in EventSender.
2840 * DumpRenderTree/gtk/EventSender.cpp:
2841 (mouseScrollByCallback):
2843 2013-07-16 Brian Holt <brian.holt@samsung.com>
2845 webkitpy: replace urllib with urllib2 for downloading additional modules
2846 https://bugs.webkit.org/show_bug.cgi?id=118671
2848 Reviewed by Ryosuke Niwa.
2850 Urllib2 is available whereever urllib is, but has better proxy support.
2852 * Scripts/webkitpy/common/system/autoinstall.py:
2853 (AutoInstaller._download_to_stream):
2855 2013-07-16 Krzysztof Czech <k.czech@samsung.com>
2857 [ATK] Adds support for aria-haspopup property.
2858 https://bugs.webkit.org/show_bug.cgi?id=117834
2860 Reviewed by Christophe Dumez.
2862 Adds implementation for testing aria-haspopup property.
2864 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2865 (getAttributeSetValueForId):
2866 (AccessibilityUIElement::stringAttributeValue):
2867 (AccessibilityUIElement::hasPopup):
2868 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2869 (WTR::getAttributeSetValueForId):
2870 (WTR::AccessibilityUIElement::stringAttributeValue):
2871 (WTR::AccessibilityUIElement::hasPopup):
2873 2013-07-16 Michael Brüning <michael.bruning@digia.com>
2875 [Qt] Replace Nokia references.
2876 https://bugs.webkit.org/show_bug.cgi?id=118728
2878 Reviewed by Simon Hausmann.
2880 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2881 (MiniBrowserApplication::MiniBrowserApplication):
2882 * QtTestBrowser/qttestbrowser.cpp:
2883 (LauncherApplication::LauncherApplication):
2885 2013-07-15 Tim Horton <timothy_horton@apple.com>
2887 Update blocked/missing plug-in UI
2888 https://bugs.webkit.org/show_bug.cgi?id=118347
2889 <rdar://problem/14209318>
2891 Reviewed by Sam Weinig.
2893 * MiniBrowser/mac/WK2BrowserWindowController.m:
2894 (-[WK2BrowserWindowController awakeFromNib]):
2895 * WebKitTestRunner/TestController.cpp:
2896 (WTR::TestController::createWebViewWithOptions):
2897 Match new WKPageLoaderClient entry.
2899 2013-07-15 Chris Fleizach <cfleizach@apple.com>
2901 Update James Craig's email address.
2903 * Scripts/webkitpy/common/config/contributors.json:
2905 2013-07-15 Dong-Gwan Kim <donggwan.kim@samsung.com>
2907 [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2908 https://bugs.webkit.org/show_bug.cgi?id=118583
2910 Reviewed by Christophe Dumez.
2912 There're many fails on efl webkit2 API test if opengl is not available.
2913 So, add fallback to non-opengl evas engine.
2915 * TestWebKitAPI/efl/PlatformWebView.cpp:
2916 (TestWebKitAPI::initEcoreEvas):
2918 2013-07-15 Brian Holt <brian.holt@samsung.com>
2920 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2921 https://bugs.webkit.org/show_bug.cgi?id=118592
2923 Reviewed by Martin Robinson.
2925 Added a suppression for pylint false positives and a unit test.
2927 * Scripts/webkitpy/style/checkers/python.py:
2929 * Scripts/webkitpy/style/checkers/python_unittest.py:
2930 (PythonCheckerTest.test_check):
2931 (PythonCheckerTest):
2932 (PythonCheckerTest.test_pylint_false_positives):
2933 (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2934 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2937 2013-07-15 Xabier Rodriguez Calvar <calvaris@igalia.com>
2939 [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2940 https://bugs.webkit.org/show_bug.cgi?id=115166
2942 Reviewed by Philippe Normand.
2944 * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2946 2013-07-12 Kwang Yul Seo <skyul@company100.net>
2948 Unreviewed. Add an email address and update my domain of experts.
2950 * Scripts/webkitpy/common/config/contributors.json:
2952 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2954 [jhbuild] Avoid restarting from scratch failed initial checkouts
2955 https://bugs.webkit.org/show_bug.cgi?id=118603
2957 Reviewed by Martin Robinson.
2959 If the initial checkout is interrupted midway (eg. because the internet
2960 connection went down) config files do not get generated and that causes
2961 the next checkout to start from scratch (the missing files cause the
2962 script to delete the build root and the downloaded sources).
2964 By generating the files before invoking jhbuild, subsequent runs are able
2965 to start where the previous run left.
2967 * Scripts/update-webkit-libs-jhbuild:
2968 (saveJhbuildMd5): invoke it before runJhbuild().
2970 2013-07-12 Brent Fulgham <bfulgham@apple.com>
2972 [Windows] Remove single-worker restriction on tests.
2974 * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2976 2013-07-12 Commit Queue <commit-queue@webkit.org>
2978 Unreviewed, rolling out r152599.
2979 http://trac.webkit.org/changeset/152599
2980 https://bugs.webkit.org/show_bug.cgi?id=118612
2982 This patch includes a failing unit test (Requested by
2983 mrobinson on #webkit).
2985 * Scripts/webkitpy/style/checkers/python.py:
2987 * Scripts/webkitpy/style/checkers/python_unittest.py:
2988 (PythonCheckerTest.test_check):
2989 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2991 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2993 [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2994 https://bugs.webkit.org/show_bug.cgi?id=91223
2996 Reviewed by Martin Robinson.
2998 When run on a clean checkout, `build-webkit` complains that no
2999 GNUmakefile exists when trying to detect the previously configured
3000 architecture, but in this case there's no previous configuration so
3001 the warning is pointless.
3003 * Scripts/webkitdirs.pm:
3004 (determineArchitecture): Redirect grep stderr to /dev/null.
3006 2013-07-12 Brian Holt <brian.holt@samsung.com>
3008 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
3009 https://bugs.webkit.org/show_bug.cgi?id=118592
3011 Reviewed by Martin Robinson.
3013 Added a suppression for pylint false positives and a unit test.
3015 * Scripts/webkitpy/style/checkers/python.py:
3017 * Scripts/webkitpy/style/checkers/python_unittest.py:
3018 (PythonCheckerTest.test_check):
3019 (PythonCheckerTest):
3020 (PythonCheckerTest.test_pylint_false_positives):
3021 (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
3022 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
3025 2013-07-11 Arnaud Renevier <a.renevier@samsung.com>
3027 Unreviewed. Add myself as a committer.
3029 * Scripts/webkitpy/common/config/contributors.json:
3031 2013-07-10 Sergio Correia <sergio.correia@openbossa.org>
3033 Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
3034 https://bugs.webkit.org/show_bug.cgi?id=118538
3036 Reviewed by Christophe Dumez.
3038 When attempting some odd url such as ``foo'', MiniBrowser will now show an
3039 error message such as "Cannot resolve hostname (foo)".
3041 Previously, it had the following behavior if MiniBrowser was started with
3042 such urls, e.g ``./MiniBrowser foo'':
3045 It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
3048 No asserts, naturally, but the view would remain blank, even if we tried to
3049 change to a valid url.
3051 * MiniBrowser/efl/main.c:
3054 2013-07-10 Simon Pena <simon.pena@samsung.com>
3056 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
3057 https://bugs.webkit.org/show_bug.cgi?id=118509
3059 Reviewed by Martin Robinson.
3061 In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
3062 when trying to remove an event already removed, if another event is
3063 processed in the middle. By using a Deque's takeFirst, we ensure the
3064 element is removed before we dispatch it.
3066 fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
3067 crashes after this fix is added.
3069 * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
3070 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3071 (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
3074 2013-07-09 Ryuan Choi <ryuan.choi@samsung.com>
3076 [EFL] Add ewk_view_device_pixel_ratio_set
3077 https://bugs.webkit.org/show_bug.cgi?id=118521
3079 Reviewed by Gyuyoung Kim.
3081 * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
3083 (parseUserArguments):
3085 2013-07-09 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
3087 Unreviewed change of my email addresses.
3088 https://bugs.webkit.org/show_bug.cgi?id=100122
3090 * Scripts/webkitpy/common/config/contributors.json:
3092 2013-07-09 Anders Carlsson <andersca@apple.com>
3094 DumpRenderTree should stop sending unsupported URLs to NSWorkspace
3095 https://bugs.webkit.org/show_bug.cgi?id=118514
3096 <rdar://problem/13686836>
3098 Reviewed by Sam Weinig.
3100 Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
3102 * DumpRenderTree/DefaultPolicyDelegate.h: Added.
3103 * DumpRenderTree/DefaultPolicyDelegate.m: Added.
3104 (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3105 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3106 Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
3108 * DumpRenderTree/mac/DumpRenderTree.mm:
3109 (allocateGlobalControllers):
3110 Allocate a DefaultPolicyDelegate object.
3112 (resetWebViewToConsistentStateBeforeTesting):
3113 Set the policy delegate to the default policy delegate.
3115 * DumpRenderTree/mac/DumpRenderTreeMac.h:
3116 Declare the defaultPolicyDelegate object.
3118 * DumpRenderTree/mac/TestRunnerMac.mm:
3119 (TestRunner::setCustomPolicyDelegate):
3120 Set the policy delegate to the default delegate if setDelegate is false.
3122 2013-07-08 Zan Dobersek <zdobersek@igalia.com>
3124 KURL unit test fixture class should have a meaningful name
3125 https://bugs.webkit.org/show_bug.cgi?id=118467
3127 Reviewed by Sam Weinig.
3129 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
3130 (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
3131 instead of the generic and inappropriate 'WebCore' name.
3133 2013-07-08 Antti Koivisto <antti@apple.com>
3135 Add Deque::removeLast
3136 https://bugs.webkit.org/show_bug.cgi?id=118466
3138 Reviewed by Andreas Kling.
3140 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3141 * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
3142 (TestWebKitAPI::TEST):
3144 2013-07-08 Brian Holt <brian.holt@samsung.com>
3146 [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
3147 https://bugs.webkit.org/show_bug.cgi?id=118412
3149 Reviewed by Martin Robinson.
3151 An adoptRef is required to balance ref and deref calls.
3153 * DumpRenderTree/gtk/EventSender.cpp:
3154 (beginDragWithFilesCallback):
3156 2013-07-06 Sergio Correia <sergio.correia@openbossa.org>
3158 Update list of EFL WK2 API tests
3159 https://bugs.webkit.org/show_bug.cgi?id=118443
3161 Reviewed by Christophe Dumez.
3163 The following tests were included:
3166 - CloseThenTerminate
3167 - DidAssociateFormControls
3168 - PageVisibilityState
3169 - ResponsivenessTimerDoesntFireEarly
3174 - ResizeReversePaginatedWebView
3175 - ScrollPinningBehaviors
3177 This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
3180 * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
3181 * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
3183 2013-07-05 Tim Horton <timothy_horton@apple.com>
3185 Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
3186 https://bugs.webkit.org/show_bug.cgi?id=118439
3187 <rdar://problem/14366120>
3189 Reviewed by Anders Carlsson.
3191 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3192 (TestWebKitAPI::didLayout):
3193 (TestWebKitAPI::TEST):
3194 - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
3195 - Assert that we got the right number of pages for sanity.
3196 - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
3197 so much memory that SharedMemory asserts and makes the test time out.
3198 - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
3199 because paint doesn't fire if the window is offscreen.
3201 2013-07-05 Tim Horton <timothy_horton@apple.com>
3203 [wk2] Add API to lock the scroll position at the top or bottom of the page
3204 https://bugs.webkit.org/show_bug.cgi?id=118429
3205 <rdar://problem/14120323>
3207 Reviewed by Anders Carlsson.
3209 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
3211 (TestWebKitAPI::didFinishDocumentLoadForFrame):
3212 (TestWebKitAPI::TEST):
3213 Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
3214 all work correctly in the face of resizing the view and scrolling from JS.
3216 2013-07-05 Michael Pruett <michael@68k.org>
3218 Unreviewed. Add myself as a committer.
3220 * Scripts/webkitpy/common/config/contributors.json:
3222 2013-07-05 Xabier Rodriguez Calvar <calvaris@igalia.com>
3224 [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
3225 https://bugs.webkit.org/show_bug.cgi?id=111434
3227 Reviewed by Carlos Garcia Campos.
3229 * Scripts/run-gtk-tests:
3230 (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
3232 2013-07-04 Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
3234 [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
3235 https://bugs.webkit.org/show_bug.cgi?id=118370
3237 Reviewed by Christophe Dumez.
3239 Add fallback to software X11 engine if opengl_x11 engine creation fails.
3241 * DumpRenderTree/efl/DumpRenderTree.cpp:
3244 2013-07-04 Brian Holt <brian.holt@samsung.com>
3246 [ATK] Leak: AtkAttributeSet* should be freed
3247 https://bugs.webkit.org/show_bug.cgi?id=118307
3249 Reviewed by Christophe Dumez.
3251 Fixed memory leaks for AtkAttributeSet by calling
3252 atk_attribute_set_free().
3254 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3255 (AccessibilityController::childElementById):
3256 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3257 (getAtkAttributeSetAsString):
3258 (AccessibilityUIElement::allAttributes):
3259 (AccessibilityUIElement::stringAttributeValue):
3260 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3261 (WTR::childElementById):
3262 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3263 (WTR::getAtkAttributeSetAsString):
3264 (WTR::AccessibilityUIElement::allAttributes):
3265 (WTR::AccessibilityUIElement::stringAttributeValue):
3267 2013-07-03 David Farler <dfarler@apple.com>
3269 Add Makefile to WebKitLauncher
3270 https://bugs.webkit.org/show_bug.cgi?id=118365
3272 Reviewed by Mark Rowe.
3274 * WebKitLauncher/Makefile: Added.
3276 2013-07-03 Brian Holt <brian.holt@samsung.com>
3278 [ATK] Leak: more leaks in AccessibilityUIElement
3279 https://bugs.webkit.org/show_bug.cgi?id=118362
3281 Reviewed by Christophe Dumez.
3283 Free the memory created by g_strdup_printf.
3285 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3286 (AccessibilityUIElement::language):
3287 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3288 (WTR::AccessibilityUIElement::language):
3290 2013-07-03 Jer Noble <jer.noble@apple.com>
3292 Xcode often gets in a state where the debugger is completely unresponsive
3293 https://bugs.webkit.org/show_bug.cgi?id=118157
3295 The GetPointeeData() operations we use to retrieve strings is extremely expensive.
3296 Rather than pull the character data out of the debugger one byte at a time
3297 through the GetPointeeData() API, retrieve the memory contents of the string through
3298 the ReadMemory() API, and convert the retrieved memory into a python string.
3300 Reviewed by Anders Carlsson.
3302 * lldb/lldb_webkit.py:
3303 (__lldb_init_module.lldb_webkit):
3304 (guess_string_length):
3305 (ustring_to_string):
3306 (lstring_to_string):
3308 2013-07-03 Morten Stenshorne <mstensho@opera.com>
3310 [GTK] Let F5 refresh the page in MiniBrowser
3311 https://bugs.webkit.org/show_bug.cgi?id=117638
3313 Reviewed by Carlos Garcia Campos.
3315 Also use the correct icon for the refresh button that was already there.
3317 * MiniBrowser/gtk/BrowserWindow.c:
3318 (browser_window_init):
3320 2013-07-02 Kondapally Kalyan <kalyan.kondapally@intel.com>
3322 Unreviewed. Add my email to a few watchlists.
3324 * Scripts/webkitpy/common/config/watchlist:
3326 2013-07-02 David Farler <dfarler@apple.com>
3328 Unreviewed. Adding myself to contributors.json.
3330 * Scripts/webkitpy/common/config/contributors.json:
3332 2013-07-02 Brian Holt <brian.holt@samsung.com>
3334 [ATK] Leak: leaks in AccessibilityUIElement
3335 https://bugs.webkit.org/show_bug.cgi?id=118297
3339 Reviewed by Christophe Dumez.
3341 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3342 (AccessibilityUIElement::stringValue):
3344 2013-07-02 Byungwoo Lee <bw80.lee@samsung.com>
3346 Fix WebKitTestRunner crashes.
3347 https://bugs.webkit.org/show_bug.cgi?id=117630
3349 Reviewed by Darin Adler.
3351 Create static function to dump for WebProcess unresponsiveness status,
3352 and use it before calling TestController::runTest().
3354 Accessing TestController::m_currentInvocation before calling
3355 TestController::runTest() can make crash because the invocation
3356 instance will be assigned at the function.
3358 * WebKitTestRunner/TestController.cpp:
3359 (WTR::TestController::run):
3360 * WebKitTestRunner/TestInvocation.cpp:
3361 (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
3362 * WebKitTestRunner/TestInvocation.h:
3364 2013-07-02 Allan Sandfeld Jensen <allan.jensen@digia.com>
3366 [Qt][WK1] Support WebGL with EGL on Linux
3367 https://bugs.webkit.org/show_bug.cgi?id=118251
3369 Reviewed by Kenneth Rohde Christiansen.
3371 * qmake/mkspecs/features/features.prf:
3373 2013-07-01 Nick Diego Yamane <nick.yamane@openbossa.org>
3375 [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
3376 https://bugs.webkit.org/show_bug.cgi?id=118267
3378 Reviewed by Gyuyoung Kim.
3380 After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
3381 WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
3382 Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
3387 2013-07-01 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
3389 [GTK] Remove unsupported AC backends
3390 https://bugs.webkit.org/show_bug.cgi?id=117362
3392 Reviewed by Martin Robinson.
3394 * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
3395 and cogl, so removed.
3397 2013-07-01 Timothy Hatcher <timothy@apple.com>
3399 Link to WebInspectorUI.framework at build time instead of soft linking.
3401 https://bugs.webkit.org/show_bug.cgi?id=118261
3403 Reviewed by Joseph Pecoraro.
3405 * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
3407 2013-07-01 Tim Horton <timothy_horton@apple.com>
3409 Maximum scroll position can be negative in some cases
3410 https://bugs.webkit.org/show_bug.cgi?id=118175
3411 <rdar://problem/14301217>
3413 Reviewed by Anders Carlsson.
3415 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3416 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
3417 (TestWebKitAPI::didRunJavaScript):
3418 (TestWebKitAPI::didLayout):
3419 (TestWebKitAPI::TEST):
3420 * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
3421 Add a test that loads a vertical-lr document, paginates it horizontally
3422 from right to left, resizes the view to fit the entire document, and
3423 verifies that the scroll position is negative, as it must be for the
3424 document to be enclosed by the view.
3426 2013-07-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3428 [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
3429 https://bugs.webkit.org/show_bug.cgi?id=117249
3431 Reviewed by Brent Fulgham.
3433 Finish converting all use cases of WEBKITOUTPUTDIR to
3434 WEBKIT_OUTPUTDIR, which seems to be preferred these days.
3436 * DumpRenderTree/efl/FontManagement.cpp:
3437 (getCustomBuildDir):
3438 (getPlatformFontsPath):
3439 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3441 * Scripts/webkitdirs.pm:
3442 (determineBaseProductDir):
3443 (usesPerConfigurationBuildDirectory):
3444 * Scripts/webkitpy/port/base.py:
3445 (Port.to.setup_environ_for_server):
3446 * Scripts/webkitpy/port/driver.py:
3447 (Driver._setup_environ_for_driver):
3448 * Scripts/webkitpy/port/gtk.py:
3449 (GtkPort.setup_environ_for_server):
3450 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3451 (WTR::getOutputDir):
3452 * jhbuild/jhbuildutils.py:
3453 (get_dependencies_path):
3455 2013-07-01 Rafael Brandao <rafael.lobo@webkit.org>
3457 Unreviewed change of my email address.
3459 * Scripts/webkitpy/common/config/contributors.json:
3461 2013-06-28 Andreas Kling <akling@apple.com>
3463 Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
3465 * DumpRenderTree/win/DumpRenderTree.cpp:
3466 (addFontFallbackIfPresent):
3467 (removeFontFallbackIfPresent):
3469 2013-06-28 Anders Carlsson <andersca@apple.com>
3471 Remove String::deprecatedCharactersWithNullTermination() and related code
3472 https://bugs.webkit.org/show_bug.cgi?id=118211
3474 Reviewed by Benjamin Poulain.
3476 Remove all hasTerminatingNullCharacter() checks.
3478 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3479 (TestWebKitAPI::TEST):
3480 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3481 (TestWebKitAPI::TEST):
3482 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3483 (TestWebKitAPI::TEST):
3485 2013-06-28 Alexey Proskuryakov <ap@apple.com>
3487 [Mac] Crash when loading is stopped from -didReceiveResponse
3488 https://bugs.webkit.org/show_bug.cgi?id=118209
3489 <rdar://problem/14259249>
3491 Reviewed by Brady Eidson.
3493 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3494 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
3495 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
3496 (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
3497 (TestWebKitAPI::TEST):
3499 2013-06-28 Andy Estes <aestes@apple.com>
3501 [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
3502 https://bugs.webkit.org/show_bug.cgi?id=118208
3504 Reviewed by Mark Rowe.
3506 Newer versions of clang use a default template depth of 128, but this
3507 is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
3510 Clang lowered the default to keep recursive template instantiation
3511 from overflowing the stack (see <rdar://problem/13935016>), but
3512 TestWebKitAPI's C++ files don't trigger a stack overflow even with the
3513 higher limit. If for some reason this starts happening then we can
3514 lower the limit back down.
3516 * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
3518 2013-06-28 Nick Diego Yamane <nick.yamane@openbossa.org>
3520 [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
3521 https://bugs.webkit.org/show_bug.cgi?id=118195
3523 Reviewed by Daniel Bates.
3525 Currently, ports that use jhbuild fail to determine jhbuild directory
3526 when "webKitBranchBuild" git configuration property is enabled. To reproduce
3527 that issue in Efl port, enable that flag in .git/config, switch to a git branch
3528 other than "master" and try to build webkit. The build will fail to
3529 locate dependencies due to lack of pkg-config paths which should be set
3532 For more details about "webKitBranchBuild" option, see:
3533 https://trac.webkit.org/wiki/UsingGitWithWebKit
3535 * Scripts/webkitdirs.pm:
3538 2013-06-28 Jessie Berlin <jberlin@apple.com>
3540 WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
3541 https://bugs.webkit.org/show_bug.cgi?id=118201
3543 Reviewed by Dean Jackson.
3545 * WebKitTestRunner/mac/main.mm:
3547 Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
3548 setAutomaticDashSubstitutionEnabled are not exposed on WKView.
3550 2013-06-28 David Farler <dfarler@apple.com>
3552 Upstream WebKit Nightly’s WebKitLauncher
3553 https://bugs.webkit.org/show_bug.cgi?id=117418
3555 Reviewed by Mark Rowe.
3557 Literal patch from Nightly's OpenSource repo.
3559 * WebKitLauncher/Configurations/Base.xcconfig:
3560 * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
3561 * WebKitLauncher/Info.plist:
3562 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3563 * WebKitLauncher/WebKitLauncherURLProtocol.m:
3564 (+[WebKitLauncherURLProtocol load]):
3565 (+[WebKitLauncherURLProtocol canInitWithRequest:]):
3566 (-[WebKitLauncherURLProtocol startLoading]):
3567 (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
3568 (-[WebKitLauncherURLProtocol resourceNotFound]):
3569 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3570 (initializeSparkle):
3571 * WebKitLauncher/main.m:
3572 (determineExecutablePath):
3573 (currentMacOSXVersion):
3575 * WebKitLauncher/start.html:
3577 2013-06-28 Balazs Kelemen <b.kelemen@samsung.com>
3579 [EFL] back/forward keyboard shortcuts are non-intuitive
3580 https://bugs.webkit.org/show_bug.cgi?id=118193
3582 Reviewed by Christophe Dumez.
3584 Changed shortcuts for go-back/go-forward to alt+left and alt+right.
3586 * EWebLauncher/main.c:
3588 * MiniBrowser/efl/main.c:
3591 2013-06-28 Roger Fong <roger_fong@apple.com>
3593 Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3594 https://bugs.webkit.org/show_bug.cgi?id=118194.
3596 Reviewed by Brent Fulgham.
3598 * DumpRenderTree/win/DumpRenderTree.cpp:
3599 (dllLauncherEntryPoint):
3600 * WinLauncher/WinLauncher.cpp:
3601 (dllLauncherEntryPoint):
3603 2013-06-28 Roger Fong <roger_fong@apple.com>
3605 Unreviewed build fix for AppleWin port. Fix some file paths.
3607 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3608 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3610 2013-06-27 Roger Fong <roger_fong@apple.com>
3612 Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
3613 https://bugs.webkit.org/show_bug.cgi?id=118160.
3615 Reviewed by Brent Fulgham.
3617 * WinLauncher/AccessibilityDelegate.cpp: Added.
3618 (AccessibilityDelegate::QueryInterface):
3619 (AccessibilityDelegate::AddRef):
3620 (AccessibilityDelegate::Release):
3621 (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
3622 (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
3623 * WinLauncher/AccessibilityDelegate.h: Added.
3624 (AccessibilityDelegate::AccessibilityDelegate):
3625 * WinLauncher/WinLauncher.cpp:
3626 (dllLauncherEntryPoint):
3627 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3628 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3630 2013-06-28 Christophe Dumez <ch.dumez@sisa.samsung.com>
3632 Clean up temporary files created by the bindings test script
3633 https://bugs.webkit.org/show_bug.cgi?id=118189
3635 Reviewed by Kentaro Hara.
3637 Remove temporary files created by preprocess-idls.pl script after
3638 the bindings tests are executed.
3640 Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
3642 * Scripts/webkitpy/bindings/main.py:
3643 (BindingsTests.main):
3645 2013-06-26 Dean Jackson <dino@apple.com>
3647 [Mac] Add Mavericks system font to Test systems
3648 https://bugs.webkit.org/show_bug.cgi?id=118109
3650 Reviewed by Simon Fraser.
3652 OS X Mavericks uses a different font for system controls. Tell DRT and
3653 WKTR about them otherwise they use a fallback font. Unfortunately the
3654 fonts are hidden (not found in the list of available fonts) so I
3655 had to add them manually.
3657 Even though there is only one at the moment, I implemented this
3658 as a set so it will be easier to add new fonts if necessary.
3660 * DumpRenderTree/mac/DumpRenderTree.mm:
3661 (allowedFontFamilySet): Fixed typo.
3662 (systemHiddenFontFamilySet): New method that returns the system control font.
3663 (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3664 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3665 (WTR::allowedFontFamilySet): Fixed typo.
3666 (WTR::systemHiddenFontFamilySet): As above.
3667 (WTR::wtr_NSFontManager_availableFonts):
3669 2013-06-27 Anders Carlsson <andersca@apple.com>
3671 Get rid of the last uses of deprecatedCharactersWithNullTermination()
3672 https://bugs.webkit.org/show_bug.cgi?id=118159
3674 Reviewed by Andreas Kling.
3676 Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3678 * DumpRenderTree/win/DumpRenderTree.cpp:
3681 2013-06-27 Bem Jones-Bey <bjonesbe@adobe.com>
3683 Sync up w3c import script with changes in Blink
3684 https://bugs.webkit.org/show_bug.cgi?id=118149
3686 Reviewed by Dirk Pranke.
3688 This is a port of the following blink changes:
3690 https://codereview.chromium.org/15366004
3691 https://chromiumcodereview.appspot.com/15592005
3692 https://codereview.chromium.org/16021006
3693 https://codereview.chromium.org/15590004
3694 https://codereview.chromium.org/15901008
3695 https://codereview.chromium.org/16171009
3696 https://codereview.chromium.org/16465007
3697 https://codereview.chromium.org/15981013
3699 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3701 (test_commit_message_for_this_commit):
3702 * Scripts/webkitpy/port/base.py:
3704 * Scripts/webkitpy/port/test.py:
3705 * Scripts/webkitpy/w3c/test_converter.py:
3706 (W3CTestConverter.__init__):
3707 (W3CTestConverter.read_webkit_prefixed_css_property_list):
3708 (W3CTestConverter.convert_for_webkit):
3709 (W3CTestConverter.convert_css):
3710 (W3CTestConverter.convert_html):
3711 (W3CTestConverter.convert_testharness_paths):
3712 (W3CTestConverter.convert_prefixed_properties):
3713 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3714 * Scripts/webkitpy/w3c/test_converter_unittest.py:
3715 * Scripts/webkitpy/w3c/test_importer.py:
3717 (configure_logging):
3718 (configure_logging.LogHandler):
3719 (configure_logging.LogHandler.format):
3721 (TestImporter.__init__):
3722 (TestImporter.find_importable_tests):
3723 (TestImporter.import_tests):
3724 (TestImporter.setup_destination_directory):
3725 (TestImporter.remove_deleted_files):
3726 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3727 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3728 (TestImporterTest.test_import_dir_with_no_tests):
3730 * Scripts/webkitpy/w3c/test_parser.py:
3731 (TestParser.load_file):
3732 (TestParser.analyze_test):
3733 (TestParser.support_files):
3734 * Scripts/webkitpy/w3c/test_parser_unittest.py:
3736 2013-06-27 Csaba Osztrogonác <ossy@webkit.org>
3738 [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3739 https://bugs.webkit.org/show_bug.cgi?id=118128
3741 Reviewed by Ryosuke Niwa.
3743 It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3744 https://bugs.webkit.org/show_bug.cgi?id=117831
3746 * Scripts/webkitpy/tool/commands/download.py:
3747 (AbstractPatchSequencingCommand):
3748 (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3749 (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3750 (AbstractPatchSequencingCommand._prepare_state): Added.
3752 2013-06-27 Brendan Long <b.long@cablelabs.com>
3754 [Qt] Build overrides -j when given --makeargs="-sj40"
3755 https://bugs.webkit.org/show_bug.cgi?id=116897
3757 Reviewed by Csaba Osztrogonác.
3759 * Scripts/webkitdirs.pm:
3760 (buildQMakeProjects):
3761 Change regex checking for -j* to also check for -*j*
3763 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3765 Remove [NoInterfaceObject] from WorkerGlobalScope
3766 https://bugs.webkit.org/show_bug.cgi?id=118071
3768 Reviewed by Kentaro Hara.
3770 Update bindings test script to pass 2 additional parameters
3771 now needed by the preprocess-idls.pl script.
3773 * Scripts/webkitpy/bindings/main.py:
3774 (BindingsTests.generate_supplemental_dependency):
3775 (BindingsTests.main):
3777 2013-06-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
3779 Fixing some compiler warnings
3780 https://bugs.webkit.org/show_bug.cgi?id=117791
3782 Reviewed by Martin Robinson.
3784 * GNUmakefile.am: Silenced format warning.
3785 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3786 (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3787 Solved warning about uninitialized variable.
3789 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3791 Fix bindings tests after r152080
3792 https://bugs.webkit.org/show_bug.cgi?id=118118
3794 Reviewed by Gyuyoung Kim.
3796 r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3797 to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3800 * Scripts/webkitpy/bindings/main.py:
3801 (BindingsTests.generate_supplemental_dependency):
3802 (BindingsTests.main):
3804 2013-06-26 Carlos Garcia Campos <cargarcia@blackberry.com>
3806 [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3807 https://bugs.webkit.org/show_bug.cgi?id=117982
3809 Reviewed by Rob Buis.
3811 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3812 (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3813 m_policyDelegateIsPermissive.
3814 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3815 Reset m_policyDelegateIsPermissive.
3816 (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3817 m_policyDelegateIsPermissive.
3818 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3819 (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3820 Return whether custom policy is enabled.
3821 (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3822 Return whether custom policy is permissive.
3824 2013-06-26 Anders Carlsson <andersca@apple.com>
3826 Deprecate StringImpl::charactersWithNullTermination
3827 https://bugs.webkit.org/show_bug.cgi?id=118108
3829 Reviewed by Beth Dakin.
3831 Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3833 * DumpRenderTree/win/DumpRenderTree.cpp:
3835 (addFontFallbackIfPresent):
3836 (removeFontFallbackIfPresent):
3838 2013-06-26 Nico Weber <thakis@chromium.org>
3840 Remove detect-mismached-virtual-const.
3841 https://bugs.webkit.org/show_bug.cgi?id=117999
3843 Reviewed by Anders Carlsson.
3845 Clang warns on mismatched virtual const, so there's no need for this
3848 * Scripts/detect-mismatched-virtual-const: Removed.
3850 2013-06-26 Alex Christensen <achristensen@apple.com>
3852 Added a code coverage report.
3853 https://bugs.webkit.org/show_bug.cgi?id=117941
3855 Reviewed by Joseph Pecoraro.
3857 * CodeCoverage: Added.
3858 * CodeCoverage/results-template.html: Added.
3859 * Scripts/generate-coverage-data: Generate and open the new report.
3861 2013-06-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3863 gdb: Remove the webcore.py pretty printer.
3864 https://bugs.webkit.org/show_bug.cgi?id=117992
3866 Reviewed by Jochen Eisinger.
3868 webcore.py has been only a placeholder for backwards compatibility
3869 for almost 3 years. It should be safe enough to remove it now.
3871 * gdb/webcore.py: Removed.
3873 2013-05-26 Peter Gal <galpeter@inf.u-szeged.hu>
3875 Creating cURL watchlist and adding myself to it.
3877 Reviewed by Csaba Osztrogonác.
3879 * Scripts/webkitpy/common/config/watchlist:
3881 2013-06-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3883 Unreviewed, change my email address for watch list.
3885 * Scripts/webkitpy/common/config/watchlist:
3887 2013-06-25 Byungwoo Lee <bw80.lee@samsung.com>
3889 [EFL] Add a script to install dependencies.
3890 https://bugs.webkit.org/show_bug.cgi?id=117968
3892 Reviewed by Christophe Dumez.
3894 Add a script which installs basic dependencies for building WebKit EFL.
3896 The dependencies are from the current EFLWebKit wiki page.
3897 After this patch is landed, the wiki page will be updated to use
3900 * efl/install-dependencies: Added.
3902 2013-06-24 Dean Jackson <dino@apple.com>
3904 [Mac] Update font used for Chinese in test systems
3905 https://bugs.webkit.org/show_bug.cgi?id=117970
3907 Reviewed by Alexey Proskuryakov.
3909 Add "Songti TC" and "Songti SC" to the list of allowed fonts
3912 * DumpRenderTree/mac/DumpRenderTree.mm:
3913 (allowedFontFamilySet):
3914 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3915 (WTR::allowedFontFamilySet):
3917 2013-06-24 Tim Horton <timothy_horton@apple.com>
3919 Make MiniBrowser paginated mode work with WebKit1
3920 https://bugs.webkit.org/show_bug.cgi?id=117950
3922 Reviewed by Beth Dakin.
3924 * MiniBrowser/mac/WK1BrowserWindowController.m:
3925 (-[WK1BrowserWindowController isPaginated]):
3926 (-[WK1BrowserWindowController togglePaginationMode:]):
3927 Hook up isPaginated and togglePaginationMode just as for WebKit2.
3929 2013-06-24 David Kilzer <ddkilzer@apple.com>
3931 bisect-builds: improve heuristic for choosing the next build after a broken build
3932 <http://webkit.org/b/117918>
3934 Reviewed by Simon Fraser.
3936 * Scripts/bisect-builds: When a build is broken, use a heuristic
3937 that "bisects" the left side or the right side of the remaining
3938 revisions to pick a revision that's sufficiently different from
3939 the revision of the broken build. This heuristic assumes there
3940 is a sequential range of broken builds whenever one broken build
3943 2013-06-24 Chris Rogers <crogers@google.com>
3945 WaveTable name has changed to PeriodicWave
3946 https://bugs.webkit.org/show_bug.cgi?id=117748
3948 Reviewed by Jer Noble.
3950 * Scripts/do-webcore-rename:
3952 2013-06-22 Santosh Mahto <santosh.ma@samsung.com>
3954 [EFL] Add support for MHTML save/load feature to MiniBrowser
3955 https://bugs.webkit.org/show_bug.cgi?id=106620
3957 Reviewed by Christophe Dumez.
3959 Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3962 * MiniBrowser/efl/CMakeLists.txt:
3963 * MiniBrowser/efl/main.c:
3964 (page_contents_callback):
3966 (show_file_entry_dialog): generic function to show file enrty
3969 2013-06-21 Brent Fulgham <bfulgham@apple.com>
3971 [Windows] Unreviewed crash protection for DRT
3973 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3974 to avoid crashing during test runs.
3976 2013-06-21 Christophe Dumez <ch.dumez@sisa.samsung.com>
3978 REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3979 https://bugs.webkit.org/show_bug.cgi?id=117825
3981 Reviewed by Kentaro Hara.
3983 DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3985 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3986 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3987 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3988 (TestRunner::overridePreference):
3990 2013-06-21 Krzysztof Czech <k.czech@samsung.com>
3992 [ATK] Added support for aria-required attribute.
3993 https://bugs.webkit.org/show_bug.cgi?id=117730
3995 Reviewed by Chris Fleizach.
3997 Added support for testing aria-required attribute.
3999 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4000 (AccessibilityUIElement::isRequired):
4001 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4002 (WTR::AccessibilityUIElement::isRequired):
4004 2013-06-20 Ryuan Choi <ryuan.choi@samsung.com>
4006 [CMAKE][EFL] Enable DOM4 Events Constructor
4007 https://bugs.webkit.org/show_bug.cgi?id=117858
4009 Reviewed by Laszlo Gombos.
4011 * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
4013 2013-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
4015 [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
4016 https://bugs.webkit.org/show_bug.cgi?id=117827
4018 Reviewed by Rob Buis.
4020 Reset the passed in request if willSendRequestReturnsNull() is
4021 true or willSendRequestReturnsNullOnRedirect() is true and it's a
4024 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4025 (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
4026 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4028 2013-06-20 Csaba Osztrogonác <ossy@webkit.org>
4030 Commit queue shouldn't reopen unrelated bugs because of flakiness
4031 https://bugs.webkit.org/show_bug.cgi?id=117503
4033 Reviewed by Ryosuke Niwa.
4035 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4036 (_follow_duplicate_chain):
4037 (_update_bug_for_flaky_test):
4039 2013-06-19 Brent Fulgham <bfulgham@apple.com>
4041 [Windows] AX: Expand notification support.
4042 https://bugs.webkit.org/show_bug.cgi?id=117761
4044 Reviewed by Anders Carlsson.
4046 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4047 (AccessibilityUIElement::isPressActionSupported): Provide implementation.
4048 (AccessibilityUIElement::press): Provide implementation.
4050 2013-06-19 Benjamin Poulain <bpoulain@apple.com>
4052 Use the PlatformEvent timestamp when creating a DOM Event
4053 https://bugs.webkit.org/show_bug.cgi?id=117179
4055 Reviewed by Darin Adler.
4057 * WebKitTestRunner/mac/EventSenderProxy.mm:
4058 (WTR::EventSenderProxy::mouseDown):
4059 (WTR::EventSenderProxy::mouseUp):
4060 (WTR::EventSenderProxy::mouseMoveTo):
4061 (WTR::EventSenderProxy::keyDown):
4063 2013-06-18 Alex Christensen <achristensen@apple.com>
4065 Working on coverage script, added xml to json data extraction script.
4066 https://bugs.webkit.org/show_bug.cgi?id=117648
4068 This is part of a new test code coverage analysis tool. This compiles WebKit to generate
4069 coverage data, runs the tests, and collects all of the data in json format.
4071 Reviewed by Stephanie Lewis.
4073 * Scripts/generate-coverage-data:
4075 (getFileHitsAndBranches):
4078 * Scripts/webkitpy/tool/gcovr: Added.
4080 2013-06-18 Ryuan Choi <ryuan.choi@samsung.com>
4082 Unreviewed build fix after r151699.
4084 * TestWebKitAPI/CMakeLists.txt:
4085 * WebKitTestRunner/CMakeLists.txt:
4086 Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
4088 2013-06-18 Roger Fong <roger_fong@apple.com>
4090 Replace tools32 folder with tools and update WebKit Windows solution accordingly.
4091 <rdar://problem/14118143>.
4093 Rubberstamped by Brent Fulgham.
4095 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
4096 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
4097 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
4098 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
4099 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
4100 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
4101 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
4102 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
4103 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
4104 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
4105 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
4106 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
4107 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
4108 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
4109 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
4110 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
4111 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
4112 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
4113 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
4114 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
4115 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
4116 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
4117 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
4118 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
4119 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4120 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
4121 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
4122 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
4123 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
4124 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
4125 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
4126 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
4127 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
4128 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
4129 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
4130 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
4131 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
4132 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
4133 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
4134 * win/record-memory/record-memory.vcxproj:
4135 * win/record-memory/record-memoryDebug.props:
4136 * win/record-memory/record-memoryDebugWinCairo.props:
4137 * win/record-memory/record-memoryProduction.props:
4138 * win/record-memory/record-memoryRelease.props:
4139 * win/record-memory/record-memoryReleaseWinCairo.props:
4141 2013-06-17 Kangil Han <kangil.han@samsung.com>
4143 Unreviewed. Add my email to a DOM watchlist.
4145 * Scripts/webkitpy/common/config/watchlist:
4147 2013-06-17 Zan Dobersek <zdobersek@igalia.com>
4149 Unreviewed GTK gardening.
4151 * Scripts/run-gtk-tests:
4152 (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
4154 2013-06-15 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
4156 Unreviewed. Reorder my email addresses.
4157 https://bugs.webkit.org/show_bug.cgi?id=100122
4159 * Scripts/webkitpy/common/config/contributors.json:
4161 2013-06-14 Enrica Casucci <enrica@apple.com>
4163 WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
4164 https://bugs.webkit.org/show_bug.cgi?id=117647
4165 <rdar://problem/13881024>
4167 Reviewed by Darin Adler.
4169 The test now uses content with a selection and tests both
4170 forwards and backward find as well as the case of a find
4171 that has no matches after the user selection.
4173 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4174 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
4175 (TestWebKitAPI::didFindStringMatches):
4176 * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
4178 2013-06-14 Tor Arne Vestbø <tor.arne.vestbo@digia.com>
4180 Remove myself from Qt build system watchlist
4182 Reviewed by Simon Hausmann.
4184 * Scripts/webkitpy/common/config/watchlist:
4186 2013-06-13 Michael Brüning <michael.bruning@digia.com>
4188 [Qt][Mac] Disable QTKit video on OS X.
4189 https://bugs.webkit.org/show_bug.cgi?id=117591
4191 Reviewed by Tor Arne Vestbø.
4193 Deployment of Qt binaries to different Mac OS X
4194 platform version makes it impossible to link against
4195 the correct version of the WebKitSystemInterface library,
4196 so we need to disable QTKit for media elements.
4198 * qmake/mkspecs/features/features.prf:
4200 2013-06-13 Michał Pakuła vel Rutka <m.pakula@samsung.com>
4202 [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
4203 https://bugs.webkit.org/show_bug.cgi?id=116610
4205 Reviewed by Noam Rosenthal.
4207 Remove unnecessary code adjusting context menu position to webview position.
4208 Now position is calculcated in EwkView.
4210 * MiniBrowser/efl/main.c:
4211 (on_context_menu_show):
4213 2013-06-12 Roger Fong <roger_fong@apple.com>
4215 Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
4217 * Scripts/webkitpy/common/config/ews.json:
4219 2013-06-12 Eduardo Lima Mitev <elima@igalia.com>
4221 [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
4222 https://bugs.webkit.org/show_bug.cgi?id=115647
4224 Reviewed by Martin Robinson.
4226 Locale resolution is moved to WebKitAccessibleWrapperAtk using
4227 AtkObject::get_object_locale() API. Now, implementation of
4228 AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
4229 be leveraged to get_object_locale() of AtkObject.
4231 Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
4234 No new functionality, no new tests.
4236 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4237 (AccessibilityUIElement::language): Leverage locale resolution to
4238 AtkObject::get_object_locale().
4239 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4240 (WTR::AccessibilityUIElement::language): Leverage locale resolution to
4241 AtkObject::get_object_locale().
4243 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
4245 Remove last bits of GYP from build-webkit and update-webkit scripts
4246 https://bugs.webkit.org/show_bug.cgi?id=117557
4248 Reviewed by Ryosuke Niwa.
4250 * Scripts/build-webkit:
4251 * Scripts/update-webkit:
4253 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
4255 Remove forgotten unused Tools/Script/make-gypi script
4256 https://bugs.webkit.org/show_bug.cgi?id=117558
4258 Reviewed by Ryosuke Niwa.
4260 This script isn't used since the GYP removal from WebKit.
4262 * Scripts/make-gypi: Removed.
4264 2013-06-12 Andres Gomez <agomez@igalia.com>
4266 [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
4267 https://bugs.webkit.org/show_bug.cgi?id=117533
4269 Reviewed by Carlos Garcia Campos.
4271 MiniBrowser now starts automatically the download of the documents
4272 that cannot be shown just by WebKit itself on link left clicking.
4274 * MiniBrowser/gtk/BrowserWindow.c:
4275 (webViewDecidePolicy): handled the
4276 WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
4278 2013-06-12 Zan Dobersek <zdobersek@igalia.com>
4280 [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
4281 https://bugs.webkit.org/show_bug.cgi?id=116723
4283 Reviewed by Carlos Garcia Campos.
4285 * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
4286 remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
4287 and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
4288 not expensive and produces a working archive without problems even on incremental builds.
4290 2013-06-11 Santosh Mahto <santosh.ma@samsung.com>
4292 [EFL] Window resize should close the popupmenu
4293 https://bugs.webkit.org/show_bug.cgi?id=117391
4295 Reviewed by Christophe Dumez.
4297 Added the code to close the popup when main window is resized.
4299 * MiniBrowser/efl/main.c:
4302 2013-06-11 Alex Christensen <achristensen@apple.com>
4304 Removed old broken code coverage tool.
4305 https://bugs.webkit.org/show_bug.cgi?id=117520
4307 Reviewed by Sam Weinig.
4309 * CodeCoverage: Removed.
4310 * CodeCoverage/README: Removed.
4311 * CodeCoverage/amber.png: Removed.
4312 * CodeCoverage/cov.py: Removed.
4313 * CodeCoverage/emerald.png: Removed.
4314 * CodeCoverage/gcov.css: Removed.
4315 * CodeCoverage/glass.png: Removed.
4316 * CodeCoverage/regenerate-coverage-display: Removed.
4317 * CodeCoverage/ruby.png: Removed.
4318 * CodeCoverage/run-generate-coverage-data: Removed.
4319 * CodeCoverage/snow.png: Removed.
4321 2013-06-11 Timothy Hatcher <timothy@apple.com>
4323 Have build-webkit build the WebInspectorUI project.
4325 * Scripts/build-webkit:
4327 2013-06-11 Ryosuke Niwa <rniwa@webkit.org>
4329 Add an option to run-webkit-tests to skip java dependency check
4330 https://bugs.webkit.org/show_bug.cgi?id=117516
4332 Reviewed by Andreas Kling.
4334 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4336 * Scripts/webkitpy/port/mac.py:
4337 (MacPort._check_port_build):
4339 2013-06-11 Alex Christensen <achristensen@apple.com>