c1850f9470c26248b1d3558bc6bf9ea5c222cce5
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Philippe Normand  <pnormand@igalia.com>
2
3         Unreviewed, update my IRC nickname.
4
5         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
6
7 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
8
9         Remove the rest of Chromium code from webkitpy
10         https://bugs.webkit.org/show_bug.cgi?id=114420
11
12         Reviewed by Benjamin Poulain.
13
14         * Scripts/webkitpy/common/config/urls.py:
15         (view_revision_url):
16         * Scripts/webkitpy/common/host.py:
17         (Host._engage_awesome_locale_hacks):
18         (Host.initialize_scm):
19         (Host):
20         * Scripts/webkitpy/common/host_mock.py:
21         (MockHost.__init__):
22         (MockHost.checkout):
23         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
24         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
25         (JSONResultsGeneratorBase._insert_generic_metadata):
26         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
27         (TestExpectationParser._tokenize_line):
28         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
29         (ExpectationSyntaxTests.test_bare_name_and_bugs):
30         (ExpectationSyntaxTests.test_warnings):
31         * Scripts/webkitpy/layout_tests/port/base.py:
32         (Port.skips_perf_test):
33         (Port.path_to_test_expectations_file):
34         (Port._port_flag_for_scripts):
35         * Scripts/webkitpy/style/checkers/cpp.py:
36         (check_function_definition):
37         (check_include_line):
38         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
39         (OrderOfIncludesTest.test_check_wtf_includes):
40         (WebKitStyleTest.test_webkit_export_check):
41         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
42         (TestExpectationsTestCase.test_valid_expectations):
43         * Scripts/webkitpy/tool/bot/irc_command.py:
44         (Rollout.execute):
45         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
46         (IRCCommandTest.test_whois):
47         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
48         (IRCBotTest.test_help):
49         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
50         (SheriffBotTest.test_command_aliases):
51
52 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
53
54         roll-chromium-deps doesn't roll DEPS
55         https://bugs.webkit.org/show_bug.cgi?id=114421
56
57         Reviewed by Antti Koivisto.
58
59         Roll DEPS. Rolling DEPS. Rolled DEPS.
60
61         * Scripts/webkitpy/tool/bot/irc_command.py:
62         (RollChromiumDEPS.execute):
63
64 2013-04-11  Glenn Adams  <glenn@skynav.com>
65
66         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
67         https://bugs.webkit.org/show_bug.cgi?id=114418
68
69         Reviewed by Ryosuke Niwa.
70
71         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
72         (MockSCM.add): Remove optional remove_exit_code argument.
73         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
74         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
75         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
76         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
77
78 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
79
80         Fix roll-chromium-deps and hi.
81
82         * Scripts/webkitpy/tool/bot/irc_command.py:
83         (Hi.execute):
84         (RollChromiumDEPS.execute):
85
86 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
87
88         Remove webkitpy code to roll Chromium DEPS
89         https://bugs.webkit.org/show_bug.cgi?id=114415
90
91         Reviewed by Benjamin Poulain.
92
93         Removed the code to roll Chromium DEPS in WebKit.
94
95         * Scripts/webkitpy/common/checkout/checkout.py:
96         (Checkout.bug_id_for_this_commit):
97         * Scripts/webkitpy/common/checkout/checkout_mock.py:
98         (MockCheckout.commit_message_for_this_commit):
99         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
100         (CheckoutTest.test_suggested_reviewers):
101         * Scripts/webkitpy/common/checkout/deps.py: Removed.
102         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
103         * Scripts/webkitpy/tool/bot/irc_command.py:
104         (RollChromiumDEPS): Teach webkitbot a sense of humor.
105         (RollChromiumDEPS.execute):
106         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
107         (IRCCommandTest.test_create_bug):
108         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
109         (IRCBotTest.test_revert):
110         * Scripts/webkitpy/tool/bot/sheriff.py:
111         (Sheriff.post_rollout_patch):
112         * Scripts/webkitpy/tool/commands/__init__.py:
113         * Scripts/webkitpy/tool/commands/roll.py: Removed.
114         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
115         * Scripts/webkitpy/tool/steps/__init__.py:
116         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
117         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
118         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
119
120 2013-04-11  Glenn Adams  <glenn@skynav.com>
121
122         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
123         https://bugs.webkit.org/show_bug.cgi?id=114386
124
125         Reviewed by Benjamin Poulain.
126
127         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
128         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
129         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
130         by default and to return exit code 1 if a file/dir had already been added.
131
132         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
133         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
134         * Scripts/webkitpy/common/checkout/scm/svn.py:
135         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
136
137 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
138
139         Unreviewed.
140
141         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
142
143 2013-04-10  Glenn Adams  <glenn@skynav.com>
144
145         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
146         https://bugs.webkit.org/show_bug.cgi?id=114410
147
148         Reviewed by Ryosuke Niwa.
149
150         * Scripts/webkitpy/common/checkout/scm/git.py:
151         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
152         * Scripts/webkitpy/common/checkout/scm/scm.py:
153         (SCM.add): Remove optional return_exit_code argument.
154         (SCM.add_list): Remove optional return_exit_code argument.
155         * Scripts/webkitpy/common/checkout/scm/svn.py:
156         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
157
158 2013-04-10  Eric Seidel  <eric@webkit.org>
159
160         Remove myself from the watchlists, I'm getting too much bug mail. :)
161
162         * Scripts/webkitpy/common/config/watchlist:
163
164 2013-04-10  Commit Queue  <rniwa@webkit.org>
165
166         Unreviewed, rolling out r148158.
167         http://trac.webkit.org/changeset/148158
168         https://bugs.webkit.org/show_bug.cgi?id=114405
169
170         We need to migrate status data (Requested by rniwa on
171         #webkit).
172
173         * Scripts/webkitpy/common/net/statusserver.py:
174         (StatusServer):
175
176 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
177
178         Mass remove all the empty directories
179
180         Rubberstamped by Ryosuke Niwa.
181
182         * BuildSlaveSupport/gtk/crashmon/log: Removed.
183         * BuildSlaveSupport/gtk/xvfb/log: Removed.
184         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
185         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
186         * MiniBrowser/gtk/WebBundle: Removed.
187         * MiniBrowser/win: Removed.
188         * QtTestPlatformPlugin/mac: Removed.
189         * Scripts/webkitpy/tool/bot/testdata: Removed.
190         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
191         * efl/ImageDiff: Removed.
192         * iExploder/htdocs: Removed.
193         * iExploder/iexploder-1.7.2/output: Removed.
194         * iExploder/tools: Removed.
195         * qmake/config.tests/libexecdir: Removed.
196         * qmake/config.tests/libjpeg: Removed.
197         * qmake/config.tests/libpng: Removed.
198
199 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
200
201         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
202         https://bugs.webkit.org/show_bug.cgi?id=114397
203
204         Reviewed by Benjamin Poulain.
205
206         * Scripts/webkitpy/common/net/statusserver.py:
207         (StatusServer):
208
209 2013-04-10  Adam Barth  <abarth@webkit.org>
210
211         Remove abarth from watchlists
212         https://bugs.webkit.org/show_bug.cgi?id=114390
213
214         Reviewed by Ryosuke Niwa.
215
216         I'm trying to cut down on the amount of bugmail I get so that I'll have
217         more of a chance to notice a piece of bugmail directed at me.
218
219         * Scripts/webkitpy/common/config/watchlist:
220
221 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
222
223         webkit-test-results.appspot.com loads the dashboard for Chromium by default
224         https://bugs.webkit.org/show_bug.cgi?id=114381
225
226         Reviewed by Benjamin Poulain.
227
228         Changed the defaults.
229
230         * TestResultServer/static-dashboards/builders.js:
231         * TestResultServer/static-dashboards/dashboard_base.js:
232         (currentBuilderGroupCategory):
233
234 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
235
236         Remove Chromium EWS bots from the queue status server
237         https://bugs.webkit.org/show_bug.cgi?id=113988
238
239         Reviewed by Benjamin Poulain.
240
241         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
242
243         * QueueStatusServer/app.yaml:
244         * QueueStatusServer/config/queues.py:
245         * QueueStatusServer/model/queues.py:
246         (Queue.short_name):
247         (Queue.display_name):
248         * QueueStatusServer/model/queues_unittest.py:
249         (QueueTest.test_short_name):
250         (QueueTest.test_display_name):
251         (QueueTest.test_name_with_underscores):
252         * QueueStatusServer/templates/activebots.html:
253
254 2013-04-10  Ojan Vafai  <ojan@chromium.org>
255
256         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
257         https://bugs.webkit.org/show_bug.cgi?id=114370
258
259         Reviewed by Ryosuke Niwa.
260
261         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
262         Unfortunately, there's no way to test this until this is committed and there is
263         a master restart.
264
265         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
271         * TestResultServer/generate_builders_json.py:
272         * TestResultServer/static-dashboards/dashboard_base.js:
273         * TestResultServer/static-dashboards/loader.js:
274
275 2013-04-10  Glenn Adams  <glenn@skynav.com>
276
277         [Qt] Fix regression to test-webkitpy.
278         https://bugs.webkit.org/show_bug.cgi?id=114368
279
280         Reviewed by Ryosuke Niwa.
281
282         * Scripts/webkitpy/layout_tests/port/factory.py:
283         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
284         (PortFactory.get): Remove obsolete chromium port related code.
285         * Scripts/webkitpy/layout_tests/port/mac.py:
286         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
287
288 2013-04-10  Anders Carlsson  <andersca@apple.com>
289
290         Remove unneeded headers from FrameLoader.h
291         https://bugs.webkit.org/show_bug.cgi?id=114223
292
293         Reviewed by Geoffrey Garen.
294
295         Add back headers implicitly included by other headers.
296
297         * WebKitTestRunner/WorkQueueManager.cpp:
298
299 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
300
301         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
302         https://bugs.webkit.org/show_bug.cgi?id=114365
303
304         Reviewed by Martin Robinson.
305
306         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
307         The patch addresses crashes in the tally_event_reply method. It is already committed into the
308         at-spi2-atk source tree and will be available with the next stable release, after which the
309         patch should be removed and the dependency version bumped.
310
311         * gtk/jhbuild.modules:
312         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
313
314 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
315
316         [WinCairo] Unreviewed build fix. Correct DropBox download link.
317
318         * Scripts/update-webkit-wincairo-libs: Revise download URL to
319         match change in DropBox server behavior.
320
321 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
322
323         Removed an annoying message from svn-create-patch
324         https://bugs.webkit.org/show_bug.cgi?id=114332
325
326         Reviewed by Alexey Proskuryakov.
327
328         I see this message basically every time I write a patch, so it must not
329         be true.
330
331         * Scripts/svn-create-patch:
332         (generateDiff):
333
334 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
335
336         [GTK] Add support for Page Visibility
337         https://bugs.webkit.org/show_bug.cgi?id=97324
338
339         Reviewed by Sam Weinig.
340
341         Implemented test runner API for page visibility layout tests.
342
343         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
344         (TestRunner::resetPageVisibility):
345         (TestRunner::setPageVisibility):
346         * Scripts/webkitperl/FeatureList.pm:
347
348 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
349
350         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
351         https://bugs.webkit.org/show_bug.cgi?id=114342
352
353         Reviewed by Gyuyoung Kim.
354
355         Commit 148033 only added an implementation for the Mac port, which made
356         other ports fail most tests since loading the injected bundle failed
357         with a missing symbol.
358
359         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
360         (WTR::AccessibilityUIElement::pathDescription):
361
362 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
363
364         [EFL] Add spell checking option to MiniBrowser
365         https://bugs.webkit.org/show_bug.cgi?id=114282
366
367         Reviewed by Ryosuke Niwa.
368
369         Spell checking is enabled by adding a flag (t/text-checking)
370         with launching MiniBrowser.
371
372         * MiniBrowser/efl/main.c:
373         (window_create):
374         (elm_main):
375
376 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
377
378         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
379         https://bugs.webkit.org/show_bug.cgi?id=113281
380
381         Reviewed by Darin Adler.
382
383         * Scripts/run-gtk-tests:
384         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
385
386 2013-04-09  Glenn Adams  <glenn@skynav.com>
387
388         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
389
390         Unreviewed.
391
392         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
393         (RunTest.test_build_check):
394
395 2013-04-09  Glenn Adams  <glenn@skynav.com>
396
397         [webkitpy] Remove chromium ports.
398         https://bugs.webkit.org/show_bug.cgi?id=114326
399
400         Reviewed by Dirk Pranke.
401
402         As a side effect, also:
403
404         - remove chromium builders from webkitpy.layout_tests.port.builders
405         - remove chromium builders from rebaseline
406         - rewrite chromium dependent tests in rebaseline_unittest
407         - remove chromium platform from garden-o-matic
408         - select apple platform as default platform in garden-o-matic
409         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
410
411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
413         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
414         (BaselineOptimizerTest.test_move_baselines):
415         (BaselineOptimizerTest.test_efl):
416         (BaselineOptimizerTest.test_no_add_mac_future):
417         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
418         (BaselineOptimizerTest.test_common_directory_includes_root):
419         (BaselineOptimizerTest.test_complex_shadowing):
420         (BaselineOptimizerTest.test_virtual_ports_filtered):
421         * Scripts/webkitpy/layout_tests/port/builders.py:
422         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
423         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
424         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
425         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
426         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
427         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
428         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
429         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
430         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
431         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
432         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
433         * Scripts/webkitpy/layout_tests/port/factory.py:
434         (platform_options):
435         (PortFactory):
436         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
437         (FactoryTest.test_qt):
438         (FactoryTest.test_get_from_builder_name):
439         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
440         (RunTest.test_build_check):
441         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
442         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
443         * Scripts/webkitpy/tool/commands/rebaseline.py:
444         (Rebaseline._builders_to_pull_from):
445         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
446         (_BaseTestCase):
447         (_BaseTestCase.setUp):
448         (TestRebaselineTest.setUp):
449         (TestRebaselineTest.test_baseline_directory):
450         (test_rebaseline_updates_expectations_file):
451         (test_rebaseline_does_not_include_overrides):
452         (test_rebaseline_test):
453         (test_rebaseline_test_and_print_scm_changes):
454         (test_rebaseline_and_copy_test):
455         (test_rebaseline_and_copy_test_no_existing_result):
456         (test_rebaseline_and_copy_test_with_lion_result):
457         (test_rebaseline_and_copy_no_overwrite_test):
458         (TestRebaselineExpectations.test_rebaseline_expectations):
459
460 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
461
462         newcommitbot (WKR) requires a subversion checkout
463         https://bugs.webkit.org/show_bug.cgi?id=114309
464
465         Reviewed by Benjamin Poulain.
466
467         Directly talk to the subversion server instead of relying on a local checkout.
468         This allows us to run WKR off of a git clone.
469
470         * Scripts/webkitpy/tool/commands/newcommitbot.py:
471         (NewCommitBot.next_work_item):
472         (NewCommitBot.process_work_item):
473
474 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
475
476         webkitbot refers to sheriffbot in help
477         https://bugs.webkit.org/show_bug.cgi?id=114307
478
479         Reviewed by Benjamin Poulain.
480
481         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
482
483         * Scripts/webkitpy/tool/bot/irc_command.py:
484         (Help):
485         (Help.execute):
486         (RollChromiumDEPS.execute):
487         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
488         (IRCBotTest.test_help):
489         * Scripts/webkitpy/tool/bot/sheriff.py:
490         (Sheriff.name):
491
492 2013-04-06  Roger Fong  <roger_fong@apple.com>
493
494         Kill old processes between runs on WinEWS bots.
495         Temporarily disable tests to let bots catch up again.
496
497         * EWSTools/start-queue-win.sh:
498         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
499         (WinEWS):
500
501 2013-04-09  Glenn Adams  <glenn@skynav.com>
502
503         [webkitpy] Remove chromium deprecated port support.
504         https://bugs.webkit.org/show_bug.cgi?id=114228
505
506         Reviewed by Ryosuke Niwa.
507
508         * Scripts/webkitpy/common/config/ports.py:
509         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
510         (ChromiumPort): Removed.
511         (ChromiumAndroidPort): Removed.
512         (ChromiumXVFBPort): Removed.
513         * Scripts/webkitpy/common/config/ports_unittest.py:
514         (DeprecatedPortTest.test_chromium_port): Removed.
515         (DeprecatedPortTest.test_chromium_android_port): Removed.
516         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
517         * Scripts/webkitpy/tool/steps/update_unittest.py:
518         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
519         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
520
521 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
522
523         AX: The bounding paths should be made available through accessibility
524         https://bugs.webkit.org/show_bug.cgi?id=113817
525
526         Reviewed by David Kilzer.
527
528         Add a pathDescription property for testing so that it's possible
529         to verify that a path is being returned correctly.
530
531         * DumpRenderTree/AccessibilityUIElement.cpp:
532         (getPathDescriptionCallback):
533         (AccessibilityUIElement::pathDescription):
534         (AccessibilityUIElement::getJSClass):
535         * DumpRenderTree/AccessibilityUIElement.h:
536         (AccessibilityUIElement):
537         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
538         (_CGPathEnumerationIteration):
539         (AccessibilityUIElement::pathDescription):
540         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
541         (AccessibilityUIElement::pathDescription):
542         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
543         (WTR::AccessibilityUIElement::pathDescription):
544         (WTR):
545         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
546         (AccessibilityUIElement):
547         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
548         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
549         (WTR::AccessibilityUIElement::pathDescription):
550         (WTR):
551
552 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
553
554         [EFL] Declare TEST_THEME_DIR in a single place.
555         https://bugs.webkit.org/show_bug.cgi?id=114285
556
557         Reviewed by Anders Carlsson.
558
559         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
560
561         * DumpRenderTree/efl/CMakeLists.txt:
562         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
563         (DumpRenderTreeChrome::createView):
564         (DumpRenderTreeChrome::createInspectorView):
565         (DumpRenderTreeChrome::initialize):
566         (DumpRenderTreeChrome::onDownloadRequest):
567         * EWebLauncher/CMakeLists.txt:
568         * EWebLauncher/main.c:
569         (findThemePath):
570         * EWebLauncher/url_bar.c:
571         (url_bar_add):
572         * MiniBrowser/efl/CMakeLists.txt:
573         * MiniBrowser/efl/main.c:
574         (window_create):
575         * TestWebKitAPI/PlatformEfl.cmake:
576         * TestWebKitAPI/efl/PlatformWebView.cpp:
577         (TestWebKitAPI::PlatformWebView::PlatformWebView):
578         * WebKitTestRunner/PlatformEfl.cmake:
579         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
580         (WTR::PlatformWebView::PlatformWebView):
581
582 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
583
584         [GTK][AC] upversion of clutter and its dependecy
585         https://bugs.webkit.org/show_bug.cgi?id=114016
586
587         Reviewed by Gustavo Noronha Silva.
588
589         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
590
591         * gtk/jhbuild-optional.modules:
592
593 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
594
595         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
596         https://bugs.webkit.org/show_bug.cgi?id=89875
597
598         Reviewed by Maciej Stachowiak.
599
600         Add unit tests to verify if the handling of the open, openat, creat syscall
601         is being done right. We check if the Read/Write/ReadAndWrite permissions
602         are respected, if the canonical path is being resolved and if
603         the permissions are falling back to the topmost parent directory with a
604         policy set when the directory being opened has no policy.
605
606         We also test if any attempt of blocking SIGSYS is silently ignored.
607         SIGSYS cannot be blocked because in it's handler is where we hook
608         syscalls to the broker process.
609
610         Also added libseccomp to EFL's jhbuild to make the life of developers
611         willing to help easier.
612
613         * Scripts/webkitperl/FeatureList.pm:
614         * TestWebKitAPI/PlatformEfl.cmake:
615         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
616         (TestWebKitAPI):
617         (SeccompEnvironment):
618         (TestWebKitAPI::SeccompEnvironment::SetUp):
619         (TestWebKitAPI::SeccompEnvironment::TearDown):
620         (TestWebKitAPI::dummyHandler):
621         (TestWebKitAPI::TEST):
622         (TestWebKitAPI::stressTest):
623         * efl/jhbuild.modules:
624         * qmake/mkspecs/features/features.pri:
625
626 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
627
628         REGRESSION: Autocorrection doesn't work in DumpRenderTree
629         https://bugs.webkit.org/show_bug.cgi?id=113846
630
631         Reviewed by Alexey Proskuryakov.
632
633         The problem was that we were replacing NSSpellCheck's dictionary with our own
634         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
635
636         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
637         and "would" respectively in DumpRenderTree.
638
639         * DumpRenderTree/mac/DumpRenderTree.mm:
640         (resetDefaultsToConsistentValues):
641
642 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
643
644         Remove the gyp files for Tools
645         https://bugs.webkit.org/show_bug.cgi?id=114248
646
647         Reviewed by Ryosuke Niwa.
648
649         * DumpRenderTree/DumpRenderTree.gyp: Removed.
650         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
651         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
652         * DumpRenderTree/DumpRenderTree.gypi: Removed.
653         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
654         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
655         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
656         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
657
658 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
659
660         WKR (new-commit-bot) is too slow
661         https://bugs.webkit.org/show_bug.cgi?id=110087
662
663         Reviewed by Geoffrey Garen.
664
665         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
666         Just run "svn log -r <revision>" instead to cut down the delay.
667
668         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
669
670         * Scripts/webkitpy/tool/commands/newcommitbot.py:
671         (NewCommitBot):
672         (NewCommitBot.next_work_item):
673         (NewCommitBot._is_empty_log):
674         (NewCommitBot._update_checkout):
675
676 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
677
678         Build fix. Can't remove appendCustomBuildFlags.
679
680         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
681         (appendCustomBuildFlags):
682
683 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
684
685         Remove Chromium builders from build.webkit.org
686         https://bugs.webkit.org/show_bug.cgi?id=113990
687
688         Reviewed by Benjamin Poulain.
689
690         Removed.
691
692         * BuildSlaveSupport/build.webkit.org-config/config.json:
693         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
694         (InstallGtkDependencies):
695         (RunUnitTests.start):
696         (RunWebKit2Tests.start):
697         (Factory.__init__):
698         (unitTestsSupported):
699         (TestFactory.__init__):
700         (BuildAndTestFactory.__init__):
701         (BuildAndPerfTestFactory.__init__):
702         (BuildAndPerfTestWebKit2Factory.__init__):
703         (DownloadAndPerfTestFactory.__init__):
704         (loadBuilderConfig):
705         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
706
707 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
708
709         Remove HTML Notification
710         https://bugs.webkit.org/show_bug.cgi?id=114231
711
712         Reviewed by Ryosuke Niwa.
713
714         * qmake/mkspecs/features/features.pri:
715
716 2013-04-08  Glenn Adams  <glenn@skynav.com>
717
718         Remove chromium EWS support, and fix broken test.
719         https://bugs.webkit.org/show_bug.cgi?id=114221
720
721         Reviewed by Ryosuke Niwa.
722
723         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
724         (AbstractChromiumEWS): Removed.
725         (ChromiumLinuxEWS): Removed.
726         (ChromiumLinuxDebugEWS): Removed.
727         (ChromiumWindowsEWS): Removed.
728         (ChromiumAndroidEWS): Removed.
729         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
730         (EarlyWarningSystemTest): Fix misspelled class name.
731         (test_ewses): Fix entry point name to ensure test is run.
732
733 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
734
735         [WIN] Remove WebKit2 source code
736         https://bugs.webkit.org/show_bug.cgi?id=114096
737
738         Reviewed by Anders Carlsson.
739
740         Remove the windows specific parts of the MiniBrowser.
741
742         * MiniBrowser/MiniBrowser.vcproj: Removed.
743         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
744         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
745         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
746         * MiniBrowser/win/BrowserView.cpp: Removed.
747         * MiniBrowser/win/BrowserView.h: Removed.
748         * MiniBrowser/win/BrowserWindow.cpp: Removed.
749         * MiniBrowser/win/BrowserWindow.h: Removed.
750         * MiniBrowser/win/MiniBrowser.cpp: Removed.
751         * MiniBrowser/win/MiniBrowser.h: Removed.
752         * MiniBrowser/win/MiniBrowser.rc: Removed.
753         * MiniBrowser/win/main.cpp: Removed.
754         * MiniBrowser/win/resource.h: Removed.
755         * MiniBrowser/win/stdafx.cpp: Removed.
756         * MiniBrowser/win/stdafx.h: Removed.
757
758 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
759
760         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
761
762         * Scripts/webkitpy/common/config/irc.py:
763
764 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
765
766         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
767         https://bugs.webkit.org/show_bug.cgi?id=113139
768
769         Reviewed by Anders Carlsson.
770
771         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
772         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
773         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
774         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
775         (ToStringAndValueOfObject):
776         (ToStringAndValueOfObject::ToStringAndValueOfObject):
777         (ScriptableObject):
778         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
779         (ToStringAndValueOfObject::ScriptableObject::invoke):
780         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
781         (ToStringAndValueOfObject::NPP_GetValue):
782         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
783         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
784         * GNUmakefile.am:
785
786 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
787
788         [GTK] Bump gnome-themes-standard to 3.6.0
789         https://bugs.webkit.org/show_bug.cgi?id=114155
790
791         Reviewed by Martin Robinson.
792
793         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
794         dependency of gnome-themes-standard accordingly.
795
796 2013-04-08  David Levin  <levin@chromium.org>
797
798         Remove my watchlist entries.
799         https://bugs.webkit.org/show_bug.cgi?id=114180
800
801         Reviewed by Adam Barth.
802
803         * Scripts/webkitpy/common/config/committers.py:
804         * Scripts/webkitpy/common/config/watchlist:
805
806 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
807
808         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
809         https://bugs.webkit.org/show_bug.cgi?id=114161
810
811         Reviewed by Gyuyoung Kim.
812
813         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
814         as it is crashing due to Bug 111074.
815
816         * TestWebKitAPI/PlatformEfl.cmake:
817
818 2013-04-07  David Kilzer  <ddkilzer@apple.com>
819
820         Remove the rest of SVG_DOM_OBJC_BINDINGS
821         <http://webkit.org/b/114112>
822
823         Reviewed by Geoffrey Garen.
824
825         * Scripts/webkitperl/FeatureList.pm:
826         - Remove --svg-dom-objc-bindings switch.
827         * qmake/mkspecs/features/features.pri:
828         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
829
830 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
831
832         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
833         https://bugs.webkit.org/show_bug.cgi?id=114089
834
835         Reviewed by Chris Fleizach.
836
837         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
838         * DumpRenderTree/AccessibilityController.cpp:
839         * DumpRenderTree/AccessibilityUIElement.cpp:
840         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
841         (DumpRenderTreeChrome::DumpRenderTreeChrome):
842         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
843         (DumpRenderTreeChrome):
844
845 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
846
847         Build fix after r147857, remove remaining USE(JSC) guards.
848
849         Unreviewed.
850
851         * DumpRenderTree/config.h:
852         * TestWebKitAPI/config.h:
853         * WebKitTestRunner/config.h:
854
855 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
856
857         Rename sheriffbot to webkitbot
858         https://bugs.webkit.org/show_bug.cgi?id=114109
859
860         Reviewed by Benjamin Poulain.
861
862         Renamed since sheriffbot will be used in Blink.
863
864         * Scripts/webkitpy/tool/commands/sheriffbot.py:
865         (SheriffBot):
866         (SheriffBot.begin_work_queue):
867
868 2013-04-06  Oliver Hunt  <oliver@apple.com>
869
870         Unify the many and varied stack trace mechanisms, and make the result sane.
871         https://bugs.webkit.org/show_bug.cgi?id=114072
872
873         Reviewed by Filip Pizlo.
874
875         The commandline jsc executable no longer requires arguments, so
876         I've made run-jsc work without them.
877
878         * Scripts/run-jsc:
879
880 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
881
882         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
883         https://bugs.webkit.org/show_bug.cgi?id=114086
884
885         Reviewed by Tim Horton.
886
887         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
888
889 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
890
891         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
892         https://bugs.webkit.org/show_bug.cgi?id=114083
893
894         Reviewed by Ryosuke Niwa.
895
896         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
897         in TestWebKitAPI and WebKitTestRunner.
898
899         * TestWebKitAPI/config.h:
900         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
901         (TestWebKitAPI::InjectedBundleController::platformInitialize):
902         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
903         (WTR::InjectedBundle::platformInitialize):
904
905 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
906
907         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
908         https://bugs.webkit.org/show_bug.cgi?id=114094
909
910         Reviewed by Anders Carlsson.
911
912         * Scripts/run-jsc:
913
914 2013-04-05  Ojan Vafai  <ojan@chromium.org>
915
916         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
917         https://bugs.webkit.org/show_bug.cgi?id=114080
918
919         Reviewed by Ryosuke Niwa.
920
921         This way, the WebKit and Blink dashboard code can change as appropriate without
922         needing to consider the other project's needs. This still doesn't update the
923         buildbots to upload to the new location, or the dashboard code to pull the
924         results.json files from the new location, but it at least allows for changing the
925         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
926
927         * TestResultServer/app.yaml:
928
929 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
930
931         Re-enable testing on the commit queue
932         https://bugs.webkit.org/show_bug.cgi?id=114078
933
934         Reviewed by Darin Adler.
935
936         Re-enabled the feature and the associated tests.
937
938         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
939         (CommitQueueTask.run):
940         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
941         (CommitQueueTaskTest._run_through_task):
942         * Scripts/webkitpy/tool/commands/queues_unittest.py:
943         (CommitQueueTest._mock_test_result):
944
945 2013-04-05  Oliver Hunt  <oliver@apple.com>
946
947         Unify the many and varied stack trace mechanisms, and make the result sane.
948         https://bugs.webkit.org/show_bug.cgi?id=114072
949
950         Reviewed by Filip Pizlo.
951
952         The commandline jsc executable no longer requires arguments, so
953         I've made run-jsc work without them.
954
955         * Scripts/run-jsc:
956
957 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
958
959         AX: Make SVG Group containers accessible elements
960         https://bugs.webkit.org/show_bug.cgi?id=113939
961
962         Reviewed by Simon Fraser.
963
964         Implement axController.elementAtPoint for iOS.
965         Implement a correct version of clickPoint for iOS.
966
967         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
968         (AccessibilityController::elementAtPoint):
969         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
970         (AccessibilityUIElement::clickPointX):
971         (AccessibilityUIElement::clickPointY):
972
973 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
974
975         Unreviewed, rolling out r147773 and r147774.
976         http://trac.webkit.org/changeset/147773
977         http://trac.webkit.org/changeset/147774
978         https://bugs.webkit.org/show_bug.cgi?id=114056
979
980         Causing some exceptions on AppEngine I don't understand
981         (Requested by rniwa on #webkit).
982
983         * QueueStatusServer/config/queues.py:
984         * QueueStatusServer/model/queues.py:
985         (Queue.short_name):
986         (Queue.display_name):
987         * QueueStatusServer/model/queues_unittest.py:
988         (QueueTest.test_short_name):
989         (QueueTest.test_display_name):
990         (QueueTest.test_name_with_underscores):
991
992 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
993
994         Fixed run-bindings-tests by removing V8
995         https://bugs.webkit.org/show_bug.cgi?id=114053
996
997         Reviewed by Benjamin Poulain.
998
999         * Scripts/run-bindings-tests:
1000         (main):
1001
1002 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1003
1004         Build fix.
1005
1006         * QueueStatusServer/model/queues.py:
1007         (Queue.short_name):
1008         (Queue.display_name):
1009
1010 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1011
1012         Remove Chromium EWS bots from the queue status server
1013         https://bugs.webkit.org/show_bug.cgi?id=113988
1014
1015         Reviewed by Benjamin Poulain.
1016
1017         Removed Chromium EWS bots.
1018
1019         * QueueStatusServer/config/queues.py:
1020         * QueueStatusServer/model/queues.py:
1021         (Queue.short_name):
1022         (Queue.display_name):
1023         * QueueStatusServer/model/queues_unittest.py:
1024         (QueueTest.test_short_name):
1025         (QueueTest.test_display_name):
1026         (QueueTest.test_name_with_underscores):
1027
1028 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1029
1030         [EFL] Enable indexed database
1031         https://bugs.webkit.org/show_bug.cgi?id=107248
1032
1033         Reviewed by Alexis Menard.
1034
1035         * Scripts/webkitperl/FeatureList.pm:
1036
1037 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1038
1039         Remove vestiges of Chromium bits from watchlists.
1040         https://bugs.webkit.org/show_bug.cgi?id=114047
1041
1042         Reviewed by Ryosuke Niwa.
1043
1044         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1045
1046 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1047
1048         Add James Craig to the contributors list.
1049
1050         * Scripts/webkitpy/common/config/committers.py:
1051
1052 2013-04-04  Kent Tamura  <tkent@chromium.org>
1053
1054         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1055
1056         * Scripts/webkitpy/common/config/watchlist:
1057
1058 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1059
1060         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1061         https://bugs.webkit.org/show_bug.cgi?id=113997
1062
1063         Reviewed by Ryosuke Niwa.
1064
1065         Disable the tests until Ryosuke gets the time and hardware to have
1066         a testing commit-queue.
1067
1068         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1069         (CommitQueueTaskTest):
1070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1071         (CommitQueueTest):
1072
1073 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1074
1075         Remove Chromium builders from build.webkit.org
1076         https://bugs.webkit.org/show_bug.cgi?id=113990
1077
1078         Reviewed by Benjamin Poulain.
1079
1080         Land the part to disable triggering of Chromium builders first so that we may start
1081         deleting more Chromium code that breaks the update step.
1082
1083         * BuildSlaveSupport/build.webkit.org-config/config.json:
1084
1085 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1086
1087         Remove Chromium's DumpRenderTree
1088         https://bugs.webkit.org/show_bug.cgi?id=113989
1089
1090         Reviewed by Kent Tamura.
1091
1092         On second thought, let's not go to Camelot. It is a silly place.
1093
1094         * DumpRenderTree/mac/DumpRenderTree.mm:
1095         (resetDefaultsToConsistentValues):
1096
1097 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1098
1099         Nixed the defunct chromium folder from DumpRenderTree
1100         https://bugs.webkit.org/show_bug.cgi?id=113993
1101
1102         Reviewed by Ryosuke Niwa.
1103
1104         * DumpRenderTree/chromium: Removed.
1105         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1106         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1107         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1108         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1109         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1110         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1111         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1112         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1113         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1114         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1115         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1116         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1117         * DumpRenderTree/chromium/Task.cpp: Removed.
1118         * DumpRenderTree/chromium/Task.h: Removed.
1119         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1120         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1121         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1122         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1123         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1124         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1125         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1126         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1127         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1128         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1129         * DumpRenderTree/chromium/TestRunner: Removed.
1130         * DumpRenderTree/chromium/TestRunner/public: Removed.
1131         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1132         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1133         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1134         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1135         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1136         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1137         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1138         * DumpRenderTree/chromium/TestRunner/src: Removed.
1139         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1140         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1141         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1142         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1143         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1144         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1145         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1146         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1147         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1148         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1149         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1150         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1151         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1152         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1153         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1154         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1155         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1156         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1157         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1158         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1159         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1160         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1161         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1162         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1163         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1164         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1165         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1166         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1167         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1168         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1169         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1170         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1171         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1172         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1173         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1174         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1175         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1176         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1177         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1178         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1179         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1180         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1181         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1182         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1183         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1184         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1185         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1186         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1187         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1188         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1189         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1190         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1191         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1192         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1193         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1194         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1195         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1196         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1197         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1198         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1199         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1200         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1201         * DumpRenderTree/chromium/TestShell.h: Removed.
1202         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1203         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1204         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1205         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1206         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1207         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1208         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1209         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1210         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1211         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1212         * DumpRenderTree/chromium/config.h: Removed.
1213         * DumpRenderTree/chromium/fonts.conf: Removed.
1214
1215 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1216
1217         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1218
1219         Rubber stamped by Benjamin Poulain.
1220
1221         * RebaselineQueueServer: Removed.
1222         * RebaselineQueueServer/app.yaml: Removed.
1223         * RebaselineQueueServer/handlers: Removed.
1224         * RebaselineQueueServer/handlers/__init__.py: Removed.
1225         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1226         * RebaselineQueueServer/handlers/pages.py: Removed.
1227         * RebaselineQueueServer/index.yaml: Removed.
1228         * RebaselineQueueServer/main.py: Removed.
1229         * RebaselineQueueServer/model: Removed.
1230         * RebaselineQueueServer/model/__init__.py: Removed.
1231         * RebaselineQueueServer/model/queueentry.py: Removed.
1232         * RebaselineQueueServer/static: Removed.
1233         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1234         * RebaselineQueueServer/static/styles.css: Removed.
1235         * RebaselineQueueServer/templates: Removed.
1236         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1237         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1238         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1239         * RebaselineQueueServer/templates/home.html: Removed.
1240
1241 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1242
1243         Fix setup-commit-queue and temporarily disable testing on commit-queue
1244         https://bugs.webkit.org/show_bug.cgi?id=113979
1245
1246         Reviewed by Benjamin Poulain.
1247
1248         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1249         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1250
1251         * EWSTools/setup-commit-queue.sh:
1252         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1253         (CommitQueueTask.run):
1254
1255 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1256
1257         temporarily make flakiness dashboard work again webkit.org bots
1258         https://bugs.webkit.org/show_bug.cgi?id=113972
1259
1260         Reviewed by Ojan Vafai.
1261
1262         This patch disables the chromium.org layout test bots TestExpectations
1263         parsing temporarily until we can work out the right way to split into
1264         two instances for webkit.org and chromium.org and figure out which
1265         code to delete where :).
1266
1267         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1268
1269 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1270
1271         Fix webkitpy tests after r147678.
1272
1273         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1274         (CommitQueueTest.test_commit_queue):
1275         (test_manual_reject_during_processing):
1276
1277 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1278
1279         The commit queue should use Mac MountainLion port
1280         https://bugs.webkit.org/show_bug.cgi?id=113971
1281
1282         Reviewed by Lucas Forschler.
1283
1284         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1285         * Scripts/webkitpy/tool/commands/queues.py:
1286         (CommitQueue):
1287
1288 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1289
1290         turn off running tests on chromium linux EWS bots
1291         https://bugs.webkit.org/show_bug.cgi?id=113959
1292
1293         Reviewed by Geoffrey Garen.
1294
1295         Now that the Chromium port is no longer being maintained
1296         there's little point in running the tests. Soon we should
1297         just shut this bot off altogether.
1298
1299         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1300         (ChromiumLinuxEWS):
1301
1302 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1303
1304         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1305
1306         * Scripts/webkitpy/common/config/watchlist:
1307
1308 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1309
1310         Indentation fix to get webkit-patch working again after r147625
1311
1312         Unreviewed.
1313
1314         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1315         (MacEWS):
1316         (MacWK2EWS):
1317
1318 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1319
1320         Turn tests back on for Mac WK1/WK2 EWS.
1321         
1322         Unreviewed.
1323         
1324         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1325         (MacEWS):
1326         (MacWK2EWS):
1327
1328 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1329
1330         [GTK][WK2] MiniBrowser custom URI scheme support
1331         https://bugs.webkit.org/show_bug.cgi?id=112419
1332
1333         Reviewed by Carlos Garcia Campos.
1334
1335         Add support for about URIs in MiniBrowser. An example about page is show
1336         with URI "about:minibrowser", the rest of the cases it will show a
1337         proper message explaining that the about page didn't exist.
1338
1339         Internally it uses "minibrowser-about" prefix instead of "about", but
1340         from the user point of view it works with "about" prefix.
1341
1342         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1343         (getInternalURI): Method to convert URIs from "about" prefix to
1344         "minibrowser-about".
1345         (getExternalURI): Opposite method.
1346         (webViewURIChanged): Use "about" prefix to show the URI to users.
1347         (webViewEnterFullScreen): Ditto.
1348         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1349         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1350         (aboutURISchemeRequestCallback): Callback to manage about calls.
1351         (main): Register the URI scheme to manage about URIs.
1352
1353 2013-04-03  Roger Fong  <roger_fong@apple.com>
1354
1355         Re-enable WinEWS tests.
1356
1357         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1358         (WinEWS):
1359
1360 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1361
1362         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1363         https://bugs.webkit.org/show_bug.cgi?id=113883
1364
1365         Reviewed by Martin Robinson.
1366
1367         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1368         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1369         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1370
1371 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1372
1373         [GTK] Include Pango in jhbuild-optional.modules
1374         https://bugs.webkit.org/show_bug.cgi?id=113878
1375
1376         Reviewed by Martin Robinson.
1377
1378         Since r147547 Pango 1.32.0 is required. Including the module in the
1379         JHBuild optional moduleset.
1380
1381         * gtk/jhbuild-optional.modules: Add Pango module.
1382
1383 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1384
1385         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1386         https://bugs.webkit.org/show_bug.cgi?id=113864
1387
1388         Moving setDefersLoading from TestRunnerQt to TestRunner
1389         requires access to the non-Qt TestRunner.
1390         As long as we instantiate both TestRunner and TestRunnerQt,
1391         we need a separate getter for the non-Qt TestRunner instance.
1392
1393         Reviewed by Simon Hausmann.
1394
1395         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1396         (WebPage::resetSettings):
1397         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1398         (DumpRenderTree::jscTestRunner):
1399         * DumpRenderTree/qt/TestRunnerQt.cpp:
1400         (TestRunner::setDefersLoading):
1401             Moving setDefersLoading from TestRunnerQt
1402             to TestRunner.
1403         * DumpRenderTree/qt/TestRunnerQt.h:
1404         (TestRunnerQt):
1405
1406 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1407
1408         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1409         https://bugs.webkit.org/show_bug.cgi?id=104779
1410
1411         Reviewed by Carlos Garcia Campos.
1412
1413         * Scripts/run-gtk-tests:
1414         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1415         passing in current trunk.
1416
1417 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1418
1419         Fix HAVE(QTTESTSUPPORT) logic
1420
1421         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1422         resulting in HAVE(QTTESTSUPPORT) never being true.
1423         Move that logic down in sanitizeFeatures.
1424
1425         Rubber-stamped by Tor Arne Vestbø.
1426
1427         * qmake/mkspecs/features/features.prf:
1428
1429 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1430
1431         [GTK] Bump required versions of some dependencies
1432         https://bugs.webkit.org/show_bug.cgi?id=113282
1433
1434         Reviewed by Martin Robinson.
1435
1436         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1437
1438 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1439
1440         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1441         https://bugs.webkit.org/show_bug.cgi?id=113809
1442
1443         Reviewed by Philippe Normand.
1444
1445         Newer Linux kernels have removed some deprecated macros from v4l2
1446         headers, causing gst-plugins-good's build to break. We don't need it
1447         right now, so just disable it.
1448
1449         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1450
1451 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1452
1453         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1454         https://bugs.webkit.org/show_bug.cgi?id=113535
1455
1456         Reviewed by Simon Hausmann.
1457
1458         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1459
1460         * qmake/mkspecs/features/features.prf:
1461
1462 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1463
1464         [Qt] Move logic of simple forwarding functions to TestRunner.
1465         https://bugs.webkit.org/show_bug.cgi?id=113863
1466
1467         Reviewed by Simon Hausmann.
1468
1469         * DumpRenderTree/qt/TestRunnerQt.cpp:
1470         (TestRunner::setTextDirection):
1471         (TestRunner::goBack):
1472         (TestRunner::evaluateScriptInIsolatedWorld):
1473         (TestRunner::addUserStyleSheet):
1474         * DumpRenderTree/qt/TestRunnerQt.h:
1475         (TestRunnerQt):
1476
1477 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1478
1479         [Qt] Disable media support using QuickTime if deployment target != SDK
1480
1481         We link to a single libWebKitSystemInterface static lib, so unless the
1482         deployment target matches the SDK let's not pretend like we'll be able
1483         to run on anything lower than the SDK version.
1484
1485         Reviewed by Simon Hausmann.
1486
1487         * qmake/mkspecs/features/features.prf:
1488
1489 2013-04-02  James Craig  <james@cookiecrook.com>
1490
1491         AXRoleDescripton for DL is "list"; should be "description list"
1492         https://bugs.webkit.org/show_bug.cgi?id=111665
1493
1494         Reviewed by Chris Fleizach.
1495
1496         Defining the role and description strings.
1497
1498         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1499
1500 2013-04-02  Roger Fong  <roger_fong@apple.com>
1501
1502         Unreviewed. Disable running tests on Win EWS queue.
1503
1504         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1505         (WinEWS):
1506
1507 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1508
1509         Disable running tests on the MAC WK2 EWS queue.
1510         
1511         Unreviewed.
1512         
1513         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1514         (MacWK2EWS):
1515
1516 2013-04-02  Julie Parent  <jparent@chromium.org>
1517
1518         Dashboard refactor: Move dashboard specific history related features to History.
1519         https://bugs.webkit.org/show_bug.cgi?id=113717
1520
1521         Reviewed by Ojan Vafai.
1522         
1523         Each dashboard now creates its own History object, with a custom
1524         configuration. This changes from just overriding global functions
1525         to passing in callbacks for generatePage, handleValidHashParameter,
1526         and handleQueryParameterChange. Same with passing in defaultStateValues
1527         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1528         variables.
1529         
1530         All functions related to these features are now (mostly) private
1531         function on History. 
1532         
1533         Loader no longer needs a loadingComplete callback, since it can just
1534         initialize the history object itself.
1535
1536         * TestResultServer/static-dashboards/aggregate_results.js:
1537         (handleValidHashParameter):
1538         * TestResultServer/static-dashboards/dashboard_base.js:
1539         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1540         (generatePage):
1541         (.switch.return):
1542         (handleQueryParameterChange):
1543         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1544         (resetGlobals):
1545         * TestResultServer/static-dashboards/history.js:
1546         (.):
1547         * TestResultServer/static-dashboards/loader.js:
1548         (.):
1549         * TestResultServer/static-dashboards/loader_unittests.js:
1550         * TestResultServer/static-dashboards/timeline_explorer.js:
1551         (generatePage):
1552         (initCurrentBuilderTestResults):
1553         * TestResultServer/static-dashboards/treemap.js:
1554         (generatePage):
1555         (.switch.return):
1556         (handleQueryParameterChange):
1557
1558 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1559
1560         Unreviewed, rolling out r147401.
1561         http://trac.webkit.org/changeset/147401
1562         https://bugs.webkit.org/show_bug.cgi?id=113767
1563
1564         The patch makes it extremely hard to set up the dependencies
1565         properly on the GTK builders (Requested by zdobersek on
1566         #webkit).
1567
1568         * gtk/jhbuild.modules:
1569
1570 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1571
1572         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1573         https://bugs.webkit.org/show_bug.cgi?id=113382
1574
1575         Reviewed by Gyuyoung Kim.
1576
1577         Do not show the empty tooltip box if the text is null.
1578
1579         * MiniBrowser/efl/main.c:
1580         (popup_menu_populate):
1581
1582 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1583
1584         [GTK] Bump required versions of some dependencies
1585         https://bugs.webkit.org/show_bug.cgi?id=113282
1586
1587         Reviewed by Martin Robinson.
1588
1589         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1590
1591 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1592
1593         Unreviewed, rolling out r147319.
1594         http://trac.webkit.org/changeset/147319
1595         https://bugs.webkit.org/show_bug.cgi?id=113707
1596
1597         The unit test is still failing on the buildbot (Requested by
1598         zdobersek on #webkit).
1599
1600         * Scripts/run-gtk-tests:
1601         (TestRunner):
1602
1603 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1604
1605         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1606         https://bugs.webkit.org/show_bug.cgi?id=104779
1607
1608         Reviewed by Carlos Garcia Campos.
1609
1610         * Scripts/run-gtk-tests:
1611         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1612         passing in current trunk.
1613
1614 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1615
1616         Unreviewed, rolling out r147289.
1617         http://trac.webkit.org/changeset/147289
1618         https://bugs.webkit.org/show_bug.cgi?id=113678
1619
1620         broke Win7 (dbg) build (Requested by shinyak|gardener on
1621         #webkit).
1622
1623         * DumpRenderTree/DumpRenderTree.gypi:
1624         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1625         (WebTestRunner):
1626         (WebUserMediaClientMock):
1627         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1628         (WebTestRunner::WebUserMediaClientMock::taskList):
1629         * Scripts/webkitpy/style/checkers/cpp.py:
1630         (check_function_definition):
1631
1632 2013-03-31  Adam Barth  <abarth@webkit.org>
1633
1634         configure-svn-config.sh fails
1635         https://codereview.chromium.org/13392007/
1636
1637         Reviewed by Eric Seidel.
1638
1639         This script was trying to use "svn checkout" to dowload a file from
1640         svn.webkit.org, but "svn checkout" only works with directories.
1641         Instead, we should use "svn export".
1642
1643         * EWSTools/configure-svn-config.sh:
1644
1645 2013-03-31  Wei Jia  <wjia@chromium.org>
1646
1647         Allow WebUserMediaClientMock to be used by client
1648         https://bugs.webkit.org/show_bug.cgi?id=113633
1649
1650         Reviewed by Adam Barth.
1651
1652         Export WebUserMediaClientMock.
1653         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1654
1655         * DumpRenderTree/DumpRenderTree.gypi:
1656         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1657         (WebUserMediaClientMock):
1658         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1659         * Scripts/webkitpy/style/checkers/cpp.py:
1660         (check_function_definition):
1661
1662 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1663
1664         Expose FeatureObserver data to WebKit clients
1665         https://bugs.webkit.org/show_bug.cgi?id=113613
1666
1667         Reviewed by Sam Weinig.
1668
1669         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1670         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1671
1672 2013-03-29  Greg Hughes  <ghughes@apple.com>
1673
1674         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1675         https://bugs.webkit.org/show_bug.cgi?id=112276
1676
1677         Reviewed by Chris Fleizach.
1678
1679         Added support to test accessibility search predicates with multiple keys.  
1680
1681         * DumpRenderTree/AccessibilityUIElement.cpp:
1682         (uiElementForSearchPredicateCallback):
1683         * DumpRenderTree/AccessibilityUIElement.h:
1684         (AccessibilityUIElement):
1685         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1686         (AccessibilityUIElement::uiElementForSearchPredicate):
1687         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1688         (AccessibilityUIElement::uiElementForSearchPredicate):
1689         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1690         (AccessibilityUIElement::uiElementForSearchPredicate):
1691         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1692         (AccessibilityUIElement::uiElementForSearchPredicate):
1693         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1694         (AccessibilityUIElement::uiElementForSearchPredicate):
1695         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1696         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1697         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1698         (AccessibilityUIElement):
1699         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1700         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1701         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1702         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1703         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1704
1705 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1706
1707         Fix a typo in r147147 to fix Mac EWS.
1708
1709         * Scripts/webkitpy/tool/commands/queues.py:
1710         (PatchProcessingQueue._new_port_name_from_old):
1711
1712 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1713
1714         [EFL] Build break with latest EFL libraries after r146265
1715         https://bugs.webkit.org/show_bug.cgi?id=113558
1716
1717         Unreviewed build fix.
1718
1719         * TestWebKitAPI/PlatformWebView.h:
1720         * WebKitTestRunner/PlatformWebView.h:
1721
1722 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1723
1724         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1725
1726         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1727         in libgcrypt build.
1728
1729 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1730
1731         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1732
1733         Unreviewed.
1734
1735         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1736         (MacEWS):
1737
1738 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1739
1740         Use the right OS name on Mac EWS instead of mac-future.
1741
1742         Rubber-stamped by Dirk Pranke.
1743
1744         * Scripts/webkitpy/tool/commands/queues.py:
1745         (PatchProcessingQueue._new_port_name_from_old):
1746         (PatchProcessingQueue.begin_work_queue):
1747         (PatchProcessingQueue._upload_results_archive_for_patch):
1748
1749 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1750
1751         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1752         https://bugs.webkit.org/show_bug.cgi?id=112546
1753
1754         Reviewed by Martin Robinson.
1755
1756         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1757         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1758
1759 2013-03-28  Ming Xie  <mxie@blackberry.com>
1760
1761         [BlackBerry] Committer Email Updates
1762         https://bugs.webkit.org/show_bug.cgi?id=113435
1763
1764         Reviewed by Rob Buis.
1765
1766         Add the @blackberry.com email address for all our BlackBerry
1767         WebKit committers. This is the first step for our email address
1768         migration.
1769
1770         * Scripts/webkitpy/common/config/committers.py:
1771
1772 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1773
1774         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1775         https://bugs.webkit.org/show_bug.cgi?id=113508
1776
1777         Reviewed by Martin Robinson.
1778
1779         Prevent the GStreamer plugin scanner to load system-wide
1780         plugins. Only the ones built in JHBuild should be loaded and used
1781         at runtime.
1782
1783         * efl/jhbuildrc:
1784         * gtk/jhbuildrc:
1785
1786 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1787
1788         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1789         https://bugs.webkit.org/show_bug.cgi?id=113386
1790
1791         Reviewed by Carlos Garcia Campos.
1792
1793         * Scripts/webkitdirs.pm:
1794         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1795         version to 3.0. Reflect this change so the builtDylibPathForName
1796         function doesn't fail to report the library as found.
1797
1798 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1799
1800         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1801         https://bugs.webkit.org/show_bug.cgi?id=113484
1802
1803         Unreviewed build fix.
1804
1805         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1806
1807         * TestWebKitAPI/CMakeLists.txt:
1808         * WebKitTestRunner/CMakeLists.txt:
1809
1810 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1811
1812         Revision for the internal jhbuild is too old
1813         https://bugs.webkit.org/show_bug.cgi?id=113324
1814
1815         Reviewed by Martin Robinson.
1816
1817         Update the minimum required version to a point where jhbuild won't
1818         fail installing packages when trying to remove a symlink to a directory.
1819
1820         * jhbuild/jhbuild-wrapper: Updated revision.
1821
1822 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1823
1824         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1825         https://bugs.webkit.org/show_bug.cgi?id=113203
1826
1827         Reviewed by Philippe Normand.
1828
1829         We build our libsoup without GNOME support. gst-plugins-good does separate
1830         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1831         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1832         build failures as the headers of those diverge. We do not use souphttpsrc, so
1833         disable it when building gst-plugins-good.
1834
1835         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1836
1837 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1838
1839         Build fix after r146852. Please another reference to the Lion leaks builder.
1840
1841         * BuildSlaveSupport/build.webkit.org-config/config.json:
1842
1843 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1844
1845         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1846         https://bugs.webkit.org/show_bug.cgi?id=113421
1847
1848         Reviewed by Dirk Pranke.
1849
1850         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1851         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1852         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1853         in the GTK-specific TestExpectations files.
1854
1855         To avoid this only enable the warnings only when not using WKTR.
1856
1857         * Scripts/webkitpy/layout_tests/port/gtk.py:
1858         (GtkPort.warn_if_bug_missing_in_test_expectations):
1859
1860 2013-03-27  Antti Koivisto  <antti@apple.com>
1861
1862         Fix Zalan's email.
1863
1864         * Scripts/webkitpy/common/config/committers.py:
1865
1866 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1867
1868         master.cfg cleanup
1869         https://bugs.webkit.org/show_bug.cgi?id=113195
1870
1871         Reviewed by Ryosuke Niwa.
1872
1873         * BuildSlaveSupport/build.webkit.org-config/config.json:
1874         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1875
1876 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1877
1878         master.cfg fine-tuning for Qt Mountain Lion Release bot
1879         https://bugs.webkit.org/show_bug.cgi?id=113191
1880
1881         Reviewed by Ryosuke Niwa.
1882
1883         * BuildSlaveSupport/build.webkit.org-config/config.json:
1884           - Rename the slave due to its location change.
1885           - Update the platform of the slave.
1886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1887         (RunQtAPITests): Enable running WK2 API tests on Qt.
1888         (RunQtAPITests.start):
1889         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1890         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1891
1892 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1893
1894         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1895         https://bugs.webkit.org/show_bug.cgi?id=113403
1896
1897         Reviewed by Kenneth Rohde Christiansen.
1898
1899         As of Evas 1.7.5, when Wayland is detected on the system, support for
1900         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1901         The code, however, seems to depend on a few other flags which must be
1902         explicitly enabled.
1903
1904         If those additional GL-related options are passed, we end up
1905         having issues on the WebKit side, so disable Wayland support for
1906         now.
1907
1908         * efl/jhbuild.modules:
1909
1910 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1911
1912         Unreviewed, rolling out r146864.
1913         http://trac.webkit.org/changeset/146864
1914         https://bugs.webkit.org/show_bug.cgi?id=113391
1915
1916         causes crashes on Wk2 EFL release bot (Requested by drott on
1917         #webkit).
1918
1919         * Scripts/webkitperl/FeatureList.pm:
1920
1921 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1922
1923         [jhbuild] Correctly specify an alternate number of make jobs.
1924         https://bugs.webkit.org/show_bug.cgi?id=113396
1925
1926         Reviewed by Philippe Normand.
1927
1928         So far, we were using the `MAKEFLAGS' environment variable to pass the
1929         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1930         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1931
1932         We now behave more closely to the rest of the WebKit tools by first
1933         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1934         not set, just letting jhbuild itself figure out how many jobs to use.
1935
1936         * efl/jhbuildrc:
1937         * gtk/jhbuildrc:
1938
1939 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1940
1941         [Qt] Remove Qt specific WorkQueueItem definitions.
1942         https://bugs.webkit.org/show_bug.cgi?id=112891
1943
1944         This patch is preparation work for removing
1945         WorkQueue related code from TestRunnerQt and
1946         replacing it with generic TestRunner code.
1947
1948         Reviewed by Benjamin Poulain.
1949
1950         * DumpRenderTree/qt/TestRunnerQt.cpp:
1951         (TestRunnerQt::queueBackNavigation):
1952         (TestRunnerQt::queueForwardNavigation):
1953         (TestRunnerQt::queueLoadHTMLString):
1954         (TestRunnerQt::queueReload):
1955         (TestRunnerQt::queueLoadingScript):
1956         (TestRunnerQt::queueNonLoadingScript):
1957         (TestRunner::queueLoad):
1958         * DumpRenderTree/qt/TestRunnerQt.h:
1959         (TestRunnerQt):
1960         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1961         (LoadItem::invoke):
1962         (LoadHTMLStringItem::invoke):
1963         (LoadAlternateHTMLStringItem::invoke):
1964         (ReloadItem::invoke):
1965         (ScriptItem::invoke):
1966         (BackForwardItem::invoke):
1967         * DumpRenderTree/qt/WorkQueueItemQt.h:
1968         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1969         (LoadAlternateHTMLStringItem):
1970
1971 2013-03-26  Julie Parent  <jparent@chromium.org>
1972
1973         Flakiness dashboard: simplify logic around which tests to show.
1974         https://bugs.webkit.org/show_bug.cgi?id=113250
1975
1976         Reviewed by Ojan Vafai.
1977         
1978         The different filters for showing results are only used for layout
1979         tests, otherwise, we show everything.
1980         
1981         Change the defaults to false (what layout tests used), and only
1982         look at the values when viewing layout tests.
1983
1984         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1985         (htmlForTestsWithExpectationsButNoFailures):
1986         (shouldHideTest):
1987
1988 2013-03-26  Isaac Levy  <ilevy@google.com>
1989
1990         Update bots on test-results.appspot
1991         https://bugs.webkit.org/show_bug.cgi?id=113333
1992
1993         Reviewed by Ojan Vafai.
1994
1995         * TestResultServer/static-dashboards/builders.jsonp:
1996
1997 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1998
1999         Unreviewed GTK gardening.
2000
2001         * Scripts/run-gtk-tests:
2002         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2003
2004 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2005
2006         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2007         https://bugs.webkit.org/show_bug.cgi?id=113287
2008
2009         Reviewed by Jocelyn Turcotte.
2010
2011         * Scripts/run-qtwebkit-tests:
2012         (Options.__init__):
2013
2014 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2015
2016         [EFL] Enable IndexedDB by default
2017         https://bugs.webkit.org/show_bug.cgi?id=107248
2018
2019         Reviewed by Laszlo Gombos.
2020
2021         * Scripts/webkitperl/FeatureList.pm:
2022         Enable IndexedDB by default on EFL.
2023
2024 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2025
2026         Sheriffbot should explain rollout failures in a human readable form.
2027         https://bugs.webkit.org/show_bug.cgi?id=107092
2028
2029         Reviewed by Ryosuke Niwa.
2030
2031         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2032
2033         * Scripts/webkitpy/tool/bot/irc_command.py:
2034         (Rollout._check_diff_failure):
2035         (Rollout.execute):
2036         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2037         (IRCCommandTest.test_rollout):
2038
2039 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2040
2041         Unreviewed GTK gardening.
2042
2043         * Scripts/run-gtk-tests:
2044         (TestRunner): Skipping a failing unit test after r146518.
2045
2046 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2047
2048         Remove Lion leaks builder
2049         https://bugs.webkit.org/show_bug.cgi?id=113252
2050
2051         Reviewed by Andreas Kling.
2052
2053         Removed.
2054
2055         * BuildSlaveSupport/build.webkit.org-config/config.json:
2056
2057 2013-03-25  Kent Tamura  <tkent@chromium.org>
2058
2059         Rename ENABLE_INPUT_TYPE_DATETIME
2060         https://bugs.webkit.org/show_bug.cgi?id=113254
2061
2062         Reviewed by Kentaro Hara.
2063
2064         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2065         Actually I'd like to remove the code, but we shouldn't remove it yet
2066         because we shipped products with it on some platforms.
2067
2068         * Scripts/webkitperl/FeatureList.pm:
2069         * qmake/mkspecs/features/features.pri:
2070
2071 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2072
2073         Remove one more line that was intended to be removed in r146657.
2074
2075         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2076         (summarize_results):
2077
2078 2013-03-25  Roger Fong  <roger_fong@apple.com>
2079
2080         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2081         Re-enable WinEWS tests.
2082
2083         * Scripts/webkitpy/common/config/ports.py:
2084         (WinPort.run_bindings_tests_command):
2085         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2086         (WinEWS):
2087
2088 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2089
2090         Unreviewed, rolling out r146793.
2091         http://trac.webkit.org/changeset/146793
2092         https://bugs.webkit.org/show_bug.cgi?id=113248
2093
2094         Fix did not work (Requested by rfong on #webkit).
2095
2096         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2097         (WinEWS):
2098
2099 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2100
2101         REGRESSION(r146657): Test failures reported incorrectly
2102         https://bugs.webkit.org/show_bug.cgi?id=113223
2103
2104         Reviewed by Dirk Pranke.
2105
2106         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2107
2108         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2109         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2110
2111         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2112         (Manager.run):
2113
2114         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2115         (RunDetails.__init__):
2116         (summarize_results): Remove the line I intended to remove in r146657.
2117
2118         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2119         (logging_run): Return details instead of the exit code.
2120         (run_and_capture): Ditto.
2121
2122         (RunTest.test_full_results_html):
2123         (RunTest.test_hung_thread):
2124         (RunTest.test_no_tests_found):
2125         (RunTest.test_no_tests_found_2):
2126         (RunTest.test_repeat_each_iterations_num_tests):
2127         (RunTest.test_run_singly_actually_runs_tests):
2128         (RunTest.test_test_list):
2129         (RunTest.test_missing_and_unexpected_results):
2130         (RunTest.test_pixel_test_directories):
2131         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2132         (RunTest.test_crash_with_stderr):
2133         (RunTest.test_no_image_failure_with_image_diff):
2134         (RunTest.test_crash_log):
2135         (RunTest.test_exit_after_n_failures_upload):
2136         (RunTest.test_results_directory_absolute):
2137         (RunTest.test_results_directory_relative):
2138         (RunTest.test_retrying_and_flaky_tests):
2139         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2140         (RunTest.test_retrying_uses_retries_directory):
2141         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2142         (RunTest.test_output_diffs):
2143         (EndToEndTest.test_reftest_with_two_notrefs):
2144         (RebaselineTest.test_reset_results):
2145         (RebaselineTest.test_missing_results):
2146         (RebaselineTest.test_new_baseline):
2147
2148         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2149         (BuildBotPrinter.print_results):
2150         (BuildBotPrinter.print_unexpected_results):
2151         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2152         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2153
2154 2013-03-25  Julie Parent  <jparent@chromium.org>
2155
2156         Dashboard refactor: Move cross dashboard history related code into history.js.
2157         https://bugs.webkit.org/show_bug.cgi?id=113104
2158
2159         Reviewed by Ojan Vafai.
2160
2161         All functions relating to cross dashboard behavior move from being
2162         globals to methods on the history.History object. Names stay the same,
2163         except many are made private, ones that should have been constants now
2164         are, and the long standing TODO to change "currentState" to 
2165         dashboardSpecificState is done.
2166         
2167         We now create a global history object in dashboard_base, as an 
2168         intermediate measure.  Once the dashboard specific code is
2169         added to history, each DB will need to create its own, and this
2170         global will be eliminated.
2171         
2172         * TestResultServer/static-dashboards/aggregate_results.js:
2173         (handleValidHashParameter):
2174         (htmlForBuilder):
2175         (rawValuesHTML):
2176         * TestResultServer/static-dashboards/dashboard_base.js:
2177         (parseDashboardSpecificParameters):
2178         (defaultValue):
2179         (currentBuilderGroupCategory):
2180         (currentBuilderGroupName):
2181         (handleLocationChange):
2182         (expectationsMap):
2183         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2184         (generatePage):
2185         (.switch.return):
2186         (platformAndBuildType):
2187         (individualTests):
2188         (substringList):
2189         (processMissingAndExtraExpectations):
2190         (pathToFailureLog):
2191         (showPopupForBuild):
2192         (htmlForTestsWithExpectationsButNoFailures):
2193         (shouldHideTest):
2194         (isCrossBuilderView):
2195         (tableHeaders):
2196         (htmlForSingleTestRow):
2197         (htmlForTableColumnHeader):
2198         (generatePageForExpectationsUpdate):
2199         (handleUpdate):
2200         (nextUpdate):
2201         (setUpdateIndex):
2202         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2203         (.appendExpectationsItem):
2204         (loadExpectations):
2205         (.dummyNode.onload):
2206         (loadExpectationsLayoutTests):
2207         (appendExpectations):
2208         (htmlForNavBar):
2209         (checkBoxToToggleState):
2210         (linkHTMLToToggleState):
2211         (generatePageForBuilder):
2212         (isInvalidKeyForCrossBuilderView):
2213         (handleQueryParameterChange):
2214         (showLegend):
2215         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2216         (resetGlobals):
2217         (test):
2218         * TestResultServer/static-dashboards/history.js:
2219         (.):
2220         * TestResultServer/static-dashboards/history_unittests.js:
2221         * TestResultServer/static-dashboards/loader.js:
2222         (.):
2223         * TestResultServer/static-dashboards/loader_unittests.js:
2224         * TestResultServer/static-dashboards/timeline_explorer.js:
2225         (generatePage):
2226         (initCurrentBuilderTestResults):
2227         (selectBuild):
2228         (showResultsDelta):
2229         * TestResultServer/static-dashboards/treemap.js:
2230         (generatePage):
2231         (.switch.return):
2232         (handleFocus):
2233         * TestResultServer/static-dashboards/ui.js:
2234
2235 2013-03-25  Roger Fong  <roger_fong@apple.com>
2236
2237         Unreviewed. Enable WinEWS tests again.
2238
2239         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2240         (WinEWS):
2241
2242 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2243
2244         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2245         https://bugs.webkit.org/show_bug.cgi?id=112166
2246
2247         HarfBuzz 0.9.14 merged my patch for icu detection without
2248         pkg-config files, as needed by for example Ubuntu 12.04.
2249         This obsoletes our local workaround. Removed it for GTK and EFL.
2250
2251         Reviewed by Martin Robinson.
2252
2253         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2254         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2255         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2256         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2257
2258 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2259
2260         Unreviewed.  Move self from contributor to committer list.
2261
2262         * Scripts/webkitpy/common/config/committers.py:
2263
2264 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2265
2266         EWS should use a human readable port name when uploading layout test archives
2267         https://bugs.webkit.org/show_bug.cgi?id=113099
2268
2269         Reviewed by Dirk Pranke.
2270
2271         Use new port's object's name() method to report human readable port names.
2272         This will also help us resolving the bug to apply layout test results posted by EWS.
2273
2274         * Scripts/webkitpy/tool/bot/botinfo.py:
2275         (BotInfo.__init__): Take port's name.
2276         (BotInfo.summary_text):
2277
2278         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2279         (BotInfoTest.test_summary_text):
2280
2281         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2282         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2283
2284         * Scripts/webkitpy/tool/commands/queues.py:
2285         (PatchProcessingQueue.__init__): Initialize self._port.
2286         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2287         and use that for the attachment filename and the comment posted.
2288
2289         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2290         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2291         "mac-snowleopard" as expected for TestPort.
2292
2293 2013-03-22  Roger Fong  <roger_fong@apple.com>
2294
2295         Unreviewed. Turn off EWS test on Win again.
2296         The battle continues.
2297
2298         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2299         (WinEWS):
2300
2301 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2302
2303         NRWT: Enable pixel tests when retrying tests
2304         https://bugs.webkit.org/show_bug.cgi?id=112898
2305
2306         Reviewed by Dirk Pranke.
2307
2308         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2309         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2310         if we've forced pixel tests in the retry.
2311         (Manager._run_tests):
2312         (Manager._clean_up_run): Fixed the capitalizations.
2313         (Manager._force_pixel_tests_if_needed): Added.
2314
2315         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2316         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2317         'image_diff_percent' if it doesn't already exist.
2318
2319         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2320         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2321         treat this as a regular regression instead of a flakiness.
2322
2323         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2324         run had image diffs.
2325
2326         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2327         (summarized_results):
2328
2329         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2330         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2331         Also removed some dead code.
2332
2333         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2334         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2335         is set and pixel_tests_enabled is set to false.
2336         (EndToEndTest.test_reftest_with_two_notrefs):
2337
2338 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2339
2340         Make it possible to run layout tests on Retina MBP
2341         https://bugs.webkit.org/show_bug.cgi?id=93673
2342
2343         Reviewed by Ryosuke Niwa.
2344
2345         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2346         windows on 2x machines still run at 1x.
2347
2348         * DumpRenderTree/mac/DumpRenderTree.mm:
2349         (createWebViewAndOffscreenWindow):
2350         Reset the window resolution to 1x on creation.
2351         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2352         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2353         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2354         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2355         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2356         (WTR::PlatformWebView::PlatformWebView):
2357         Add NSWindow details, reset the window resolution to 1x on creation.
2358
2359 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2360
2361         Leak bots shouldn't build
2362         https://bugs.webkit.org/show_bug.cgi?id=112774
2363
2364         Reviewed by Simon Fraser.
2365
2366         Since leak bots use regular debug builds, there is no need to build on these bots.
2367         Simply downloading builds will dramatically improve the cycle time of these bots.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/config.json:
2370         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2371         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2372         TestFactory instead of BuildAndTestFactory.
2373
2374 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2375
2376         [Qt] Fix the TestWebKitAPI build
2377         https://bugs.webkit.org/show_bug.cgi?id=113044
2378
2379         Reviewed by Tor Arne Vestbø.
2380
2381         The generate-forwarding-headers script would only be run
2382         after the targets in InjectedBundle.pri since the second
2383         addStrictSubdirOrderBetween call in
2384         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2385         the derived_sources -> injected_bundle order in SUBDIRS.
2386
2387         Fix it by only moving the dependent target at the end of
2388         SUBDIRS, don't touch its dependency.
2389
2390         * qmake/mkspecs/features/functions.prf:
2391
2392 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2393
2394         [EFL][WK2] View is not focused when fullscreen mode toggled
2395         https://bugs.webkit.org/show_bug.cgi?id=113009
2396
2397         Reviewed by Laszlo Gombos.
2398
2399         Set focus on view when fullscreen mode enabled/disabled
2400         by FullScreen API.
2401
2402         * MiniBrowser/efl/main.c:
2403         (on_fullscreen_accept):
2404         (on_fullscreen_deny):
2405
2406 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2407
2408         nrwt is no longer saving retry results in the retries/ subdirectory
2409         https://bugs.webkit.org/show_bug.cgi?id=112995
2410
2411         Reviewed by Ojan Vafai.
2412
2413         I think this has been broken a long time, unfortunately. This
2414         patch should fix that.
2415
2416         In order to do so, I had to pass the directory to use from
2417         the Worker object through the SingleTestWriter to the
2418         TestResultWriter. While I was plumbing that through, I rationalized
2419         the order of the parameter arguments a bit ...
2420
2421         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2422         (Worker._run_single_test):
2423         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2424         (run_single_test):
2425         (SingleTestRunner.__init__):
2426         (SingleTestRunner._run_compare_test):
2427         (SingleTestRunner._run_rebaseline):
2428         (SingleTestRunner._run_reftest):
2429         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2430         (write_test_result):
2431         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2432         (TestResultWriterTest.test_reftest_diff_image):
2433         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2434         (RunTest.test_retrying_uses_retries_directory):
2435
2436 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2437
2438         JSC profiler should have an at-a-glance report of the success of DFG optimization
2439         https://bugs.webkit.org/show_bug.cgi?id=112988
2440
2441         Reviewed by Geoffrey Garen.
2442
2443         * Scripts/display-profiler-output:
2444
2445 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2446
2447         [chromium] Linux ASAN WebKit canary is running out of memory
2448         https://bugs.webkit.org/show_bug.cgi?id=112978
2449
2450         Reviewed by Tony Chang.
2451
2452         Running the AddressSanitizer on a crash takes a lot of
2453         memory, so we should serialize access to it to avoid running
2454         out of memory on a machine.
2455
2456         * Scripts/webkitpy/layout_tests/port/chromium.py:
2457         (ChromiumPort._get_crash_log):
2458         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2459         (HttpLock.__init__):
2460         (HttpLock.wait_for_httpd_lock):
2461
2462 2013-03-21  Min Qin  <qinmin@chromium.org>
2463
2464         Cleanup android media layout test code
2465         https://bugs.webkit.org/show_bug.cgi?id=112944
2466
2467         Reviewed by Adam Barth.
2468
2469         Chromium change: https://codereview.chromium.org/12892010/
2470         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2471         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2472         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2473         Instead, we should switch to use content shell for layout tests.
2474
2475         * DumpRenderTree/chromium/TestShell.cpp:
2476         (TestShell::resetTestController):
2477
2478 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2479
2480         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2481         https://bugs.webkit.org/show_bug.cgi?id=112953
2482
2483         Reviewed by Tony Chang.
2484
2485         When I created the DumpRenderTree_resources target in r144863 I
2486         forgot to declare the needed dependencies on the other resource
2487         targets. Due to a quirk of ordering, this appears to have been fine
2488         w/ ninja but not w/ Xcode (which is still being used on the chromium
2489         mac valgrind bots). Declaring the dependencies fixes the build
2490         failures.
2491
2492         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2493
2494 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2495
2496         [WinCairo] Correct assert in Empty BitmapImage Test.
2497         https://bugs.webkit.org/show_bug.cgi?id=112934
2498
2499         Reviewed by Tim Horton.
2500
2501         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2502         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2503         to avoid ref counting assertion when leaving test scope.
2504
2505 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2506
2507         [GTK] generate-feature-defines-files is incompatible with Python3
2508         https://bugs.webkit.org/show_bug.cgi?id=112956
2509
2510         Reviewed by Martin Robinson.
2511
2512         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2513         method on the dictionary objects when iterating through said dictionaries.
2514
2515         * gtk/generate-feature-defines-files:
2516         (write_feature_defines_header):
2517         (write_flattened_feature_defines_file):
2518
2519 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2520
2521         kill-old-processes spits out error messages on Mac
2522         https://bugs.webkit.org/show_bug.cgi?id=112878
2523
2524         Reviewed by Jessie Berlin.
2525
2526         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2527         included in the list of options grep --help shows.
2528
2529         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2530
2531         * BuildSlaveSupport/kill-old-processes:
2532         (main):
2533
2534 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2535
2536         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2537         https://bugs.webkit.org/show_bug.cgi?id=112597
2538
2539         Reviewed by Xan Lopez.
2540
2541         These were introduced for the Chromium port in r105295. We need
2542         dummy implementations in order to compile the BlackBerry port.
2543
2544         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2545         (AccessibilityUIElement::scrollToMakeVisible):
2546         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2547         (AccessibilityUIElement::scrollToGlobalPoint):
2548
2549 2013-03-21  Roger Fong  <roger_fong@apple.com>
2550
2551         Re-enable WinEWS tests following r146376.
2552
2553         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2554         (WinEWS):
2555
2556 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2557
2558         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2559
2560         * Scripts/webkitpy/common/config/committers.py:
2561
2562 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2563
2564         [GTK] Missing atk in install-dependencies script
2565         https://bugs.webkit.org/show_bug.cgi?id=112272
2566
2567         Reviewed by Gustavo Noronha Silva.
2568
2569         * gtk/install-dependencies: Add missing atk dependency.
2570
2571 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2572
2573         [GTK] Missing backslash in install-dependencies script
2574         https://bugs.webkit.org/show_bug.cgi?id=112907
2575
2576         Reviewed by Philippe Normand.
2577
2578         * gtk/install-dependencies: Add missing backslash to dependencies
2579         list.
2580
2581 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2582
2583         EWS bots have stopped uploading results to bugzilla
2584         https://bugs.webkit.org/show_bug.cgi?id=101091
2585
2586         Reviewed by Adam Barth.
2587
2588         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2589         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2590         this relative file path resoled to a file inside a non-existent directory for "zip".
2591
2592         Fixed the bug by resolving both test results directory and zip archive paths in
2593         LayoutTestResultsReader.archive.
2594
2595         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2596         in the future.
2597
2598         * Scripts/webkitpy/common/system/filesystem_mock.py:
2599         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2600
2601         * Scripts/webkitpy/common/system/workspace.py:
2602         (Workspace.create_zip): Log the source path when "zip" failed.
2603
2604         * Scripts/webkitpy/common/system/workspace_mock.py:
2605         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2606
2607         * Scripts/webkitpy/common/system/workspace_unittest.py:
2608         (WorkspaceTest.test_create_zip_exception): Test that.
2609
2610         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2611         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2612         This is the actual bug fix.
2613
2614         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2615         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2616
2617 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2618
2619         [chromium] move WebThemeEngine implementations to TestRunner library
2620         https://bugs.webkit.org/show_bug.cgi?id=112751
2621
2622         Reviewed by Adam Barth.
2623
2624         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2625         * DumpRenderTree/DumpRenderTree.gypi:
2626         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2627         (WebKit):
2628         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2629         (WebTestRunner::TestInterfaces::themeEngine):
2630         (WebTestRunner):
2631         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2632         (WebKit):
2633         (TestInterfaces):
2634         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2635         (WebTestRunner::WebTestInterfaces::themeEngine):
2636         (WebTestRunner):
2637         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2638         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2639         (WebTestRunner):
2640         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2641         (WebTestRunner::WebTestThemeControlWin::box):
2642         (WebTestRunner::WebTestThemeControlWin::line):
2643         (WebTestRunner::WebTestThemeControlWin::triangle):
2644         (WebTestRunner::WebTestThemeControlWin::roundRect):
2645         (WebTestRunner::WebTestThemeControlWin::oval):
2646         (WebTestRunner::WebTestThemeControlWin::circle):
2647         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2648         (WebTestRunner::WebTestThemeControlWin::markState):
2649         (WebTestRunner::WebTestThemeControlWin::draw):
2650         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2651         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2652         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2653         (WebTestRunner):
2654         (WebTestThemeControlWin):
2655         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2656         (WebTestRunner):
2657         (WebTestThemeEngineMac):
2658         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2659         (+[FakeActiveWindow alwaysActiveWindow]):
2660         (+[FakeActiveWindow alwaysInactiveWindow]):
2661         (-[FakeActiveWindow initWithActiveControls:]):
2662         (-[FakeActiveWindow _hasActiveControls]):
2663         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2664         (WebTestRunner):
2665         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2666         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2667         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2668         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2669         (WebTestRunner):
2670         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2671         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2672         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2673         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2674         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2675         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2676         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2677         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2678         (WebTestRunner::WebTestThemeEngineWin::getSize):
2679         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2680         (WebTestRunner):
2681         (WebTestThemeEngineWin):
2682         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2683         * DumpRenderTree/chromium/TestShell.cpp:
2684         (TestShell::initialize):
2685         * DumpRenderTree/chromium/TestShell.h:
2686         (WebKit):
2687         * DumpRenderTree/chromium/TestShellMac.mm:
2688         (platformInit):
2689         * DumpRenderTree/chromium/TestShellWin.cpp:
2690         (platformInit):
2691         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2692
2693 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2694
2695         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2696
2697         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2698         New property sheet that does not link against CoreFoundation and
2699         CFNetwork.
2700         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2701         Use new TestWebKitAPICommonWinCairo property sheet.
2702         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2703         Ditto.
2704
2705 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2706
2707         [WinCairo] Unreviewed build fix for VS2010.
2708
2709         Had to add WinCairo-specific property sheets to deal with some
2710         library and path differences with the main Apple port.
2711
2712         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2713         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2714         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2715         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2716         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2717         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2718
2719 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2720
2721         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2722         https://bugs.webkit.org/show_bug.cgi?id=112849
2723
2724         Reviewed by Sam Weinig.
2725
2726         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2727         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2729
2730 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2731
2732         [WinCairo] Build WebKit Tools under VS2010
2733         https://bugs.webkit.org/show_bug.cgi?id=112821
2734
2735         Reviewed by Tim Horton.
2736
2737         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2738         Add WinCairo-specific build target.
2739         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2740         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2741         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2742         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2743         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2744         Add WinCairo-specific build target.
2745         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2746         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2747         Add WinCairo-specific build target.
2748         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2749         WinCairo-specific build target.
2750         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2751         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2752         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2753         specific build target.
2754         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2755         WinCairo-specific build target.
2756         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2757         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2758         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2759
2760 2013-03-20  Roger Fong  <roger_fong@apple.com>
2761
2762         API test gardening AppleWin port.
2763
2764         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2765
2766         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2767         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2768
2769 2013-03-20  Roger Fong  <roger_fong@apple.com>
2770
2771         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2772
2773         * EWSTools/start-queue-win.sh:
2774
2775 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2776
2777         Unreviewed, add myself to committers.py.
2778
2779 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2780
2781         Unreviewed. Adding another email for me.
2782
2783         * Scripts/webkitpy/common/config/committers.py:
2784
2785 2013-03-20  Justin Novosad  <junov@google.com>
2786
2787         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2788         https://bugs.webkit.org/show_bug.cgi?id=112605
2789
2790         Reviewed by James Robinson.
2791
2792         Deleting all the code that was used for propagating and supporting
2793         the Chromium setting for disabling deferred 2d canvas rendering.
2794
2795         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2796         (main):
2797         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2798         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2799         (WebTestRunner::WebPreferences::reset):
2800         (WebTestRunner::WebPreferences::applyTo):
2801         * DumpRenderTree/chromium/TestShell.cpp:
2802         (TestShell::TestShell):
2803         (TestShell::resetWebSettings):
2804         (TestShell::runFileTest):
2805         * DumpRenderTree/chromium/TestShell.h:
2806         (TestShell):
2807
2808 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2809
2810         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2811         https://bugs.webkit.org/show_bug.cgi?id=112699.
2812
2813         Reviewed by Adam Barth.
2814
2815         * Scripts/webkitpy/layout_tests/port/qt.py:
2816         (QtPort._search_paths):
2817         (QtPort._port_specific_expectations_files):
2818         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2819         (QtPortTest):
2820         (QtPortTest._assert_search_path):
2821         (QtPortTest._assert_expectations_files):
2822
2823 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2824
2825         [Qt] Enable kerning by default
2826         https://bugs.webkit.org/show_bug.cgi?id=112704
2827
2828         Reviewed by Jocelyn Turcotte.
2829
2830         Disable kerning by default, since some reference test expectations
2831         expect kerning to be default off.
2832
2833         * DumpRenderTree/qt/TestRunnerQt.cpp:
2834         (TestRunnerQt::reset):
2835         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2836         (WTR::activateFonts):
2837
2838 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2839
2840         [Qt] Remove empty function stubs from TestRunnerQt.
2841         https://bugs.webkit.org/show_bug.cgi?id=112799
2842
2843         We are reducing the code in TestRunnerQt step by step,
2844         in order to finally replace all of it with the generic
2845         TestRunner implementation.
2846         This patch removes several simple function stubs that
2847         currently do not implement any actual functionality.
2848
2849         Reviewed by Kenneth Rohde Christiansen.
2850
2851         * DumpRenderTree/qt/TestRunnerQt.cpp:
2852         * DumpRenderTree/qt/TestRunnerQt.h:
2853         (TestRunnerQt):
2854
2855 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2856
2857         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2858         https://bugs.webkit.org/show_bug.cgi?id=112687
2859
2860         Reviewed by Kenneth Rohde Christiansen.
2861
2862         Hide the SearchBar by default on window creation.
2863
2864         * MiniBrowser/efl/main.c:
2865         (window_create):
2866
2867 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2868
2869         Unreviewed, rolling out r146304.
2870         http://trac.webkit.org/changeset/146304
2871         https://bugs.webkit.org/show_bug.cgi?id=112788
2872
2873         to many expectations to update (Requested by antonm on
2874         #webkit).
2875
2876         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2877         * DumpRenderTree/DumpRenderTree.gypi:
2878         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2879         (WebKit):
2880         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2881         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2882         (TestInterfaces):
2883         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2884         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2885         * DumpRenderTree/chromium/TestShell.cpp:
2886         (TestShell::initialize):
2887         * DumpRenderTree/chromium/TestShell.h:
2888         (WebKit):
2889         * DumpRenderTree/chromium/TestShellMac.mm:
2890         (platformInit):
2891         * DumpRenderTree/chromium/TestShellWin.cpp:
2892         (platformInit):
2893         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2894         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2895         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2896         (WebThemeControlDRTWin::box):
2897         (WebThemeControlDRTWin::line):
2898         (WebThemeControlDRTWin::triangle):
2899         (WebThemeControlDRTWin::roundRect):
2900         (WebThemeControlDRTWin::oval):
2901         (WebThemeControlDRTWin::circle):
2902         (WebThemeControlDRTWin::nestedBoxes):
2903         (WebThemeControlDRTWin::markState):
2904         (WebThemeControlDRTWin::draw):
2905         (WebThemeControlDRTWin::drawTextField):
2906         (WebThemeControlDRTWin::drawProgressBar):
2907         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2908         (WebThemeControlDRTWin):
2909         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2910         (WebThemeEngineDRTMac):
2911         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2912         (+[FakeActiveWindow alwaysActiveWindow]):
2913         (+[FakeActiveWindow alwaysInactiveWindow]):
2914         (-[FakeActiveWindow initWithActiveControls:]):
2915         (-[FakeActiveWindow _hasActiveControls]):
2916         (WebThemeEngineDRTMac::paintScrollbarThumb):
2917         (stateToHIEnableState):
2918         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2919         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2920         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2921         (webRectToSkIRect):
2922         (drawControl):
2923         (drawTextField):
2924         (drawProgressBar):
2925         (WebThemeEngineDRTWin::paintButton):
2926         (WebThemeEngineDRTWin::paintMenuList):
2927         (WebThemeEngineDRTWin::paintScrollbarArrow):
2928         (WebThemeEngineDRTWin::paintScrollbarThumb):
2929         (WebThemeEngineDRTWin::paintScrollbarTrack):
2930         (WebThemeEngineDRTWin::paintSpinButton):
2931         (WebThemeEngineDRTWin::paintTextField):
2932         (WebThemeEngineDRTWin::paintTrackbar):
2933         (WebThemeEngineDRTWin::paintProgressBar):
2934         (WebThemeEngineDRTWin::getSize):
2935         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2936         (WebThemeEngineDRTWin):
2937         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2938
2939 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2940
2941         [Qt] Support -webkit-font-smoothing
2942         https://bugs.webkit.org/show_bug.cgi?id=106009
2943
2944         Reviewed by Jocelyn Turcotte.
2945
2946         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2947
2948         * DumpRenderTree/qt/TestRunnerQt.cpp:
2949         (TestRunnerQt::reset):
2950
2951 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2952
2953         [GTK] accessibility/aria-scrollbar-role.html is failing
2954         https://bugs.webkit.org/show_bug.cgi?id=98358
2955
2956         Reviewed by Martin Robinson.
2957
2958         Adds support for checking accessibility object's orientation.
2959         Orientation is checked by retrieving proper state of accessibility object.
2960
2961         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2962         (checkElementState):
2963         (AccessibilityUIElement::orientation):
2964         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2965         (WTR::AccessibilityUIElement::orientation):
2966
2967 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2968
2969         [chromium] move WebThemeEngine implementations to TestRunner library
2970         https://bugs.webkit.org/show_bug.cgi?id=112751
2971
2972         Reviewed by Adam Barth.
2973
2974         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2975         * DumpRenderTree/DumpRenderTree.gypi:
2976         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2977         (WebKit):
2978         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2979         (WebTestRunner::TestInterfaces::themeEngine):
2980         (WebTestRunner):
2981         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2982         (WebKit):
2983         (TestInterfaces):
2984         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2985         (WebTestRunner::WebTestInterfaces::themeEngine):
2986         (WebTestRunner):
2987         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2988         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2989         (WebTestRunner):
2990         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2991         (WebTestRunner::WebTestThemeControlWin::box):
2992         (WebTestRunner::WebTestThemeControlWin::line):
2993         (WebTestRunner::WebTestThemeControlWin::triangle):
2994         (WebTestRunner::WebTestThemeControlWin::roundRect):
2995         (WebTestRunner::WebTestThemeControlWin::oval):
2996         (WebTestRunner::WebTestThemeControlWin::circle):
2997         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2998         (WebTestRunner::WebTestThemeControlWin::markState):
2999         (WebTestRunner::WebTestThemeControlWin::draw):
3000         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3001         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3002         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3003         (WebTestRunner):
3004         (WebTestThemeControlWin):
3005         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3006         (WebTestRunner):
3007         (WebTestThemeEngineMac):
3008         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3009         (+[FakeActiveWindow alwaysActiveWindow]):
3010         (+[FakeActiveWindow alwaysInactiveWindow]):
3011         (-[FakeActiveWindow initWithActiveControls:]):
3012         (-[FakeActiveWindow _hasActiveControls]):
3013         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3014         (WebTestRunner):
3015         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3016         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3017         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3018         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3019         (WebTestRunner):
3020         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3021         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3022         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3023         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3024         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3025         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3026         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3027         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3028         (WebTestRunner::WebTestThemeEngineWin::getSize):
3029         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3030         (WebTestRunner):
3031         (WebTestThemeEngineWin):
3032         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3033         * DumpRenderTree/chromium/TestShell.cpp:
3034         (TestShell::initialize):
3035         * DumpRenderTree/chromium/TestShell.h:
3036         (WebKit):
3037         * DumpRenderTree/chromium/TestShellMac.mm:
3038         (platformInit):
3039         * DumpRenderTree/chromium/TestShellWin.cpp:
3040         (platformInit):
3041         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3042
3043 2013-03-19  Tony Chang  <tony@chromium.org>
3044
3045         Move testRunner.setTouchDragDropEnabled to internals.settings
3046         https://bugs.webkit.org/show_bug.cgi?id=112739
3047
3048         Reviewed by Adam Barth.
3049
3050         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3051         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3052         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3053         (TestRunner): Remove unnecessary code.
3054         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3055         (WebTestRunner::WebPreferences::reset):
3056         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3057
3058 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3059
3060         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3061         https://bugs.webkit.org/show_bug.cgi?id=112754
3062
3063         Reviewed by Darin Fisher.
3064
3065         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3066         now that it's always defined.
3067
3068         * DumpRenderTree/chromium/WebViewHost.cpp:
3069         * DumpRenderTree/chromium/WebViewHost.h:
3070         (WebViewHost):
3071
3072 2013-03-19  Kenneth Russell  <kbr@google.com>
3073
3074         Unreviewed, rolling out r146290.
3075         http://trac.webkit.org/changeset/146290
3076         https://bugs.webkit.org/show_bug.cgi?id=112751
3077
3078         Broke Chromium Mac build.
3079
3080         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3081         * DumpRenderTree/DumpRenderTree.gypi:
3082         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3083         (WebKit):
3084         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3085         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3086         (TestInterfaces):
3087         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3088         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3089         * DumpRenderTree/chromium/TestShell.cpp:
3090         (TestShell::initialize):
3091         * DumpRenderTree/chromium/TestShell.h:
3092         (WebKit):
3093         * DumpRenderTree/chromium/TestShellMac.mm:
3094         (platformInit):
3095         * DumpRenderTree/chromium/TestShellWin.cpp:
3096         (platformInit):
3097         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3098         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3099         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3100         (WebThemeControlDRTWin::box):
3101         (WebThemeControlDRTWin::line):
3102         (WebThemeControlDRTWin::triangle):
3103         (WebThemeControlDRTWin::roundRect):
3104         (WebThemeControlDRTWin::oval):
3105         (WebThemeControlDRTWin::circle):
3106         (WebThemeControlDRTWin::nestedBoxes):
3107         (WebThemeControlDRTWin::markState):
3108         (WebThemeControlDRTWin::draw):
3109         (WebThemeControlDRTWin::drawTextField):
3110         (WebThemeControlDRTWin::drawProgressBar):
3111         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3112         (WebThemeControlDRTWin):
3113         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3114         (WebThemeEngineDRTMac):
3115         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3116         (+[FakeActiveWindow alwaysActiveWindow]):
3117         (+[FakeActiveWindow alwaysInactiveWindow]):
3118         (-[FakeActiveWindow initWithActiveControls:]):
3119         (-[FakeActiveWindow _hasActiveControls]):
3120         (WebThemeEngineDRTMac::paintScrollbarThumb):
3121         (stateToHIEnableState):
3122         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3123         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3124         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3125         (webRectToSkIRect):
3126         (drawControl):
3127         (drawTextField):
3128         (drawProgressBar):
3129         (WebThemeEngineDRTWin::paintButton):
3130         (WebThemeEngineDRTWin::paintMenuList):
3131         (WebThemeEngineDRTWin::paintScrollbarArrow):
3132         (WebThemeEngineDRTWin::paintScrollbarThumb):
3133         (WebThemeEngineDRTWin::paintScrollbarTrack):
3134         (WebThemeEngineDRTWin::paintSpinButton):
3135         (WebThemeEngineDRTWin::paintTextField):
3136         (WebThemeEngineDRTWin::paintTrackbar):
3137         (WebThemeEngineDRTWin::paintProgressBar):
3138         (WebThemeEngineDRTWin::getSize):
3139         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3140         (WebThemeEngineDRTWin):
3141         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3142
3143 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3144
3145         [EFL] canvas-fallback-content.html is failing
3146         https://bugs.webkit.org/show_bug.cgi?id=111998
3147
3148         Reviewed by Chris Fleizach.
3149
3150         Adds support for getting platform name.
3151
3152         * DumpRenderTree/TestRunner.cpp:
3153         (TestRunner::staticValues):
3154         * DumpRenderTree/TestRunner.h:
3155         (TestRunner):
3156         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3157         (TestRunner::platformName):
3158
3159 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3160
3161         [chromium] move WebThemeEngine implementations to TestRunner library
3162         https://bugs.webkit.org/show_bug.cgi?id=112751
3163
3164         Reviewed by Adam Barth.
3165
3166         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3167         * DumpRenderTree/DumpRenderTree.gypi:
3168         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3169         (WebKit):
3170         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3171         (WebTestRunner::TestInterfaces::themeEngine):
3172         (WebTestRunner):
3173         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3174         (WebKit):
3175         (TestInterfaces):
3176         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3177         (WebTestRunner::WebTestInterfaces::themeEngine):
3178         (WebTestRunner):
3179         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3180         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3181         (WebTestRunner):
3182         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3183         (WebTestRunner::WebTestThemeControlWin::box):
3184         (WebTestRunner::WebTestThemeControlWin::line):
3185         (WebTestRunner::WebTestThemeControlWin::triangle):
3186         (WebTestRunner::WebTestThemeControlWin::roundRect):
3187         (WebTestRunner::WebTestThemeControlWin::oval):
3188         (WebTestRunner::WebTestThemeControlWin::circle):
3189         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3190         (WebTestRunner::WebTestThemeControlWin::markState):
3191         (WebTestRunner::WebTestThemeControlWin::draw):
3192         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3193         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3194         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3195         (WebTestRunner):
3196         (WebTestThemeControlWin):
3197         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3198         (WebTestRunner):
3199         (WebTestThemeEngineMac):
3200         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3201         (+[FakeActiveWindow alwaysActiveWindow]):
3202         (+[FakeActiveWindow alwaysInactiveWindow]):
3203         (-[FakeActiveWindow initWithActiveControls:]):
3204         (-[FakeActiveWindow _hasActiveControls]):
3205         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3206         (WebTestRunner):
3207         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3208         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3209         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3210         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3211         (WebTestRunner):
3212         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3213         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3214         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3215         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3216         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3217         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3218         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3219         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3220         (WebTestRunner::WebTestThemeEngineWin::getSize):
3221         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3222         (WebTestRunner):
3223         (WebTestThemeEngineWin):
3224         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3225         * DumpRenderTree/chromium/TestShell.cpp:
3226         (TestShell::initialize):
3227         * DumpRenderTree/chromium/TestShell.h:
3228         (WebKit):
3229         * DumpRenderTree/chromium/TestShellMac.mm:
3230         (platformInit):
3231         * DumpRenderTree/chromium/TestShellWin.cpp:
3232         (platformInit):
3233         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3234
3235 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3236
3237         [EFL][WK2] Separate WebView further from EwkView
3238         https://bugs.webkit.org/show_bug.cgi?id=111591
3239
3240         Reviewed by Caio Marcelo de Oliveira Filho.
3241
3242         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3243         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3244         since we can afford it having EWKViewGetWKView() private API to access WKView.
3245
3246         * TestWebKitAPI/PlatformWebView.h:
3247         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3248         (TestWebKitAPI::TEST):
3249         * TestWebKitAPI/efl/PlatformWebView.cpp:
3250         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3251         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3252         (TestWebKitAPI::PlatformWebView::resizeTo):
3253         (TestWebKitAPI::PlatformWebView::page):
3254         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3255         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3256         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3257         * WebKitTestRunner/PlatformWebView.h:
3258         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3259         (WTR::EventSenderProxy::dispatchEvent):
3260         (WTR::EventSenderProxy::keyDown):
3261         (WTR::EventSenderProxy::sendTouchEvent):
3262         (WTR::EventSenderProxy::setTouchModifier):
3263         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3264         (WTR::PlatformWebView::PlatformWebView):
3265         (WTR::PlatformWebView::~PlatformWebView):
3266         (WTR::PlatformWebView::resizeTo):
3267         (WTR::PlatformWebView::page):
3268         (WTR::PlatformWebView::focus):
3269         (WTR::PlatformWebView::windowSnapshotImage):
3270
3271 2013-03-19  Roger Fong  <roger_fong@apple.com>
3272
3273         Changes to VS2010 project files should only trigger builds on Windows bots.
3274         https://bugs.webkit.org/show_bug.cgi?id=112731
3275
3276         Reviewed by Timothy Horton.
3277
3278         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3279         (_should_file_trigger_build):
3280
3281 2013-03-19  Roger Fong  <roger_fong@apple.com>
3282
3283         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3284
3285         * Scripts/webkitpy/tool/steps/runtests.py:
3286         (RunTests.run):
3287         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3288         (RunTestsTest.test_webkit_run_unit_tests):
3289
3290 2013-03-19  Julie Parent  <jparent@chromium.org>
3291
3292         Dashboards: Introduce history namespace and unit tests.
3293         https://bugs.webkit.org/show_bug.cgi?id=112645
3294
3295         Reviewed by Ojan Vafai.
3296         
3297         Laying the framework for introducing the new history object and
3298         namespace.  This moves only static functions into the history
3299         namespace, and moves corresponding unit tests into seperate
3300         unit test file.
3301
3302         * TestResultServer/static-dashboards/aggregate_results.html:
3303         * TestResultServer/static-dashboards/dashboard_base.js:
3304         (parseCrossDashboardParameters):
3305         (parseDashboardSpecificParameters):
3306         (parseParameters):
3307         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3308         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3309         (.switch.return):
3310         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3311         * TestResultServer/static-dashboards/history.js: Added.
3312         * TestResultServer/static-dashboards/history_unittests.js: Added.
3313         * TestResultServer/static-dashboards/loader.js:
3314         (.):
3315         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3316         * TestResultServer/static-dashboards/run-unittests.html:
3317         * TestResultServer/static-dashboards/timeline_explorer.html:
3318         * TestResultServer/static-dashboards/timeline_explorer.js:
3319         * TestResultServer/static-dashboards/treemap.html:
3320         * TestResultServer/static-dashboards/treemap.js:
3321         (.switch.return):
3322         * TestResultServer/static-dashboards/ui.js:
3323
3324 2013-03-19  Daniel Bates  <dbates@webkit.org>
3325
3326         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3327         https://bugs.webkit.org/show_bug.cgi?id=112732
3328
3329         Reviewed by Eric Seidel.
3330
3331         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3332         of an existing file cannot be applied.
3333
3334         In particular, svn-{apply, unapply} compensate for differences in line endings
3335         by converting the line endings in a diff to match the line endings in the target
3336         file. The diff(1) command precedes the last line of a diff that adds a newline
3337         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3338         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3339         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3340         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3341         the newline characters in this special character sequence to match the line endings
3342         in the target file.
3343
3344         * Scripts/VCSUtils.pm:
3345         (parseDiff):
3346         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3347         Added tests:
3348             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3349             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3350             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3351             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3352         (escapeNewLineCharacters): Added.
3353         (toMacLineEndings): Added.
3354
3355 2013-03-19  James Robinson  <jamesr@chromium.org>
3356
3357         [chromium] Remove compositor settings that don't go through WebKit
3358         https://bugs.webkit.org/show_bug.cgi?id=112718
3359
3360         Reviewed by Adam Barth.
3361
3362         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3363         (main):
3364         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3365         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3366         (WebTestRunner::WebPreferences::reset):
3367         (WebTestRunner::WebPreferences::applyTo):
3368         * DumpRenderTree/chromium/TestShell.cpp:
3369         (TestShell::TestShell):
3370         (TestShell::resetWebSettings):
3371         * DumpRenderTree/chromium/TestShell.h:
3372         (TestShell):
3373
3374 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3375
3376         Unreviewed, rolling out r146101.
3377         https://bugs.webkit.org/show_bug.cgi?id=111884
3378
3379         re-enable custom freetype on asan; this needs to be on
3380         now that the bot is running lucid.
3381
3382         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3383
3384 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3385
3386         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3387         https://bugs.webkit.org/show_bug.cgi?id=112365
3388
3389         Reviewed by Benjamin Poulain.
3390
3391         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3392         harcoding it in wtf/Platform.h
3393
3394         * Scripts/webkitperl/FeatureList.pm:
3395
3396 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3397
3398         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3399         https://bugs.webkit.org/show_bug.cgi?id=94782
3400
3401         Based on patch by Csaba Osztrogonác.
3402         Reviewed by Jocelyn Turcotte.
3403
3404         The diff image is generated with bright red indicating errors, but letting the base image
3405         shine through so the context of the error-pixel can be identified.
3406
3407         * DumpRenderTree/qt/ImageDiff.cpp:
3408         (main):
3409
3410 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3411
3412         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3413
3414         Rubber-stamped by Csaba Osztrogonác.
3415
3416         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3417         since the latter might not cover the former.
3418
3419         * QtTestBrowser/launcherwindow.cpp:
3420         (LauncherWindow::print):
3421
3422 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3423
3424         Style tweeks to default.css.
3425         
3426         Rubber-stamped by David Kilzer.
3427         
3428         Give visited links a different color to other links, so you can
3429         see which builds you've viewed.
3430         
3431         Make the <small> text less tiny.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3434         (small):
3435         (a:link,a:visited,a:active):
3436         (a:visited):
3437
3438 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3439
3440         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3441         https://bugs.webkit.org/show_bug.cgi?id=112494
3442
3443         Reviewed by Dirk Pranke.
3444
3445         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3446         Also merged two pairs of methods to cleanup the code.
3447
3448         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3449         (PerfTestsRunner.run): Merged _upload_and_show_results.
3450         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3451
3452 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3453
3454         [chromium] build xdisplaycheck when building DRT
3455         https://bugs.webkit.org/show_bug.cgi?id=112636
3456
3457         Reviewed by Tony Chang.
3458
3459         It appears that we need xdisplaycheck to be built in order for
3460         Xvfb to be started correctly on the bots, and DRT was missing
3461         a dependency on it. This may be the cause of the ASAN bot not
3462         starting up properly (it only builds DRT).
3463
3464         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3465
3466 2013-03-18  David Levin  <levin@chromium.org>
3467
3468         Implement icon change notification dump for Chromium's test shell.
3469         https://bugs.webkit.org/show_bug.cgi?id=112614
3470
3471         This was previously implemented for some other platforms in r58111
3472         and r116547.
3473
3474         In r122806, fast/dom/icon-url-property.html stopped using it, but
3475         it is useful for tests, so I plan to re-add it to that test again.
3476
3477         Reviewed by Jochen Eisinger.
3478
3479         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3480         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3481          icon change notifications from WebKit may be logged in test output.
3482         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3483         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3484         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3485         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3486         (WebTestRunner):
3487         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3488         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3489         (TestRunner):
3490         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3491         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3492         (WebTestRunner):
3493         * DumpRenderTree/chromium/WebViewHost.cpp:
3494         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3495         * DumpRenderTree/chromium/WebViewHost.h:
3496         (WebViewHost):
3497
3498 2013-03-18  Julie Parent  <jparent@chromium.org>
3499
3500         Cleanup: Move js for treemap and aggregate_results into own js files.
3501         https://bugs.webkit.org/show_bug.cgi?id=112618
3502
3503         Reviewed by Dirk Pranke.
3504         
3505         No functional changes, just moving the code into separate js file
3506         rather than inlined in the html, so we can test it, make it more
3507         modular, etc.  Other dashboard types are already done this way.
3508
3509         * TestResultServer/static-dashboards/aggregate_results.html:
3510         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3511         (generatePage):
3512         (handleValidHashParameter):
3513         (htmlForBuilder):
3514         (rawValuesHTML):
3515         (chartHTML):
3516         (filteredValues):
3517         (chart):
3518         (htmlForRevisionRows):
3519         (wrapHTMLInTable):
3520         (htmlForSummaryTable):
3521         (valuesPerExpectation):
3522         (htmlForTestType):
3523         (htmlForTableRow):
3524         (extendedEncode):
3525         * TestResultServer/static-dashboards/treemap.html:
3526         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3527         (humanReadableTime):
3528         (convertToWebTreemapFormat):
3529         (reverseSortByAverage):
3530         (generatePage):
3531         (focusPath):
3532         (.switch.return):
3533         (handleQueryParameterChange):
3534         (extractName):
3535         (fullName):
3536         (handleFocus.):
3537         (handleFocus):
3538
3539 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3540
3541         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3542         https://bugs.webkit.org/show_bug.cgi?id=112622
3543
3544         Reviewed by Dirk Pranke.
3545
3546         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3547         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3548
3549 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3550
3551         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3552         https://bugs.webkit.org/show_bug.cgi?id=112619
3553
3554         Reviewed by Dirk Pranke.
3555
3556         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3557         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3558
3559         * Scripts/webkitpy/layout_tests/port/gtk.py:
3560         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3561         Port._webkit_baseline_path method.
3562         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3563         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3564         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3565         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3566         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3567         that are expected based on the builder name.
3568
3569 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3570
3571         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3572         https://bugs.webkit.org/show_bug.cgi?id=112571
3573
3574         Reviewed by Adam Barth.
3575
3576         Update function declarations for new WebFileSystemType enum. (All
3577         changes are behind an #ifdef so we can sync required changes in embedders.)
3578
3579         * DumpRenderTree/chromium/WebViewHost.cpp:
3580         (WebViewHost::openFileSystem):
3581         (WebViewHost::deleteFileSystem):
3582         * DumpRenderTree/chromium/WebViewHost.h:
3583         (WebViewHost):
3584
3585 2013-03-18  Julie Parent  <jparent@chromium.org>
3586
3587         Cleanup: Move timeline_exporer js out of html file into js.
3588         https://bugs.webkit.org/show_bug.cgi?id=112188
3589
3590         Reviewed by Dirk Pranke.
3591         
3592         Moves the javascript out of the html file and into a new js file.
3593         This follows the format of flakiness_dashboard.{html|js}.
3594         
3595         Also moves code from dashboard_base that is used only by this one
3596         dashboard, and makes it private to the dashboard.
3597
3598         * TestResultServer/static-dashboards/dashboard_base.js:
3599         * TestResultServer/static-dashboards/timeline_explorer.html:
3600         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3601         (generatePage):
3602         (initCurrentBuilderTestResults):
3603         (shouldShowWebKitRevisionsOnly):
3604         (updateTimelineForBuilder.):
3605         (updateTimelineForBuilder):
3606         (selectBuild):
3607         (updateBuildIndicator):
3608         (.addRow):
3609         (.addNumberRow):
3610         (.inspectorNode.getElementsByTagName.0.onclick):
3611         (.inspectorNode.getElementsByTagName.1.onclick):
3612         (.inspectorNode.getElementsByTagName.2.onclick):
3613         (updateBuildInspector):
3614         (showResultsDelta):
3615         (decompressResults.addFlakyDelta):
3616         (decompressResults):
3617
3618 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3619
3620         Unreviewed, rolling out r145272.
3621         http://trac.webkit.org/changeset/145272
3622         https://bugs.webkit.org/show_bug.cgi?id=111884
3623
3624         Turns out the ASAN build is still broken; possibly there's
3625         something still setting LD_LIBRARY_PATH, or possibly there's
3626         something else wrong. In the meantime, we need it to work again.
3627
3628         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3629
3630 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3631
3632         delete-stale-build-files is too aggressive
3633         https://bugs.webkit.org/show_bug.cgi?id=112595
3634
3635         Reviewed by Tim Horton.
3636
3637         It appears that whitelisting file extensions to keep is not a good idea.
3638         Blacklist files to delete instead, and only delete .o files for now.
3639         We can add more file extensions as needed.
3640
3641         * BuildSlaveSupport/delete-stale-build-files:
3642
3643 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3644
3645         Disable accessibility notifications after each test
3646         https://bugs.webkit.org/show_bug.cgi?id=112579
3647
3648         Reviewed by Tim Horton.
3649         
3650         In WebKitTestRunner, if any tests triggered accessibility notifications,
3651         the global notification handler would thereafter be active, and fire
3652         notifications for all subsequent tests.
3653         
3654         Fix by implementing AccessibilityController::resetToConsistentState() for
3655         Mac, and using it to clear the global notification handler.
3656
3657         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3658         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3659         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3660         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3661         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3662         (e.g. because of -autorelease).
3663         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3664         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3665         if there is one.
3666         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3667         Add -stopObserving
3668         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3669         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3670         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3671         center.
3672
3673 2013-03-18  Dana Jansens  <danakj@chromium.org>
3674
3675         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3676         https://bugs.webkit.org/show_bug.cgi?id=112392
3677
3678         Reviewed by James Robinson.
3679
3680         Removes the command line flag option from DRT.
3681
3682         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3683         (main):
3684
3685 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3686
3687         [GTK] plugins/plugin-clip-subframe.html is failing
3688         https://bugs.webkit.org/show_bug.cgi?id=112570
3689
3690         Reviewed by Martin Robinson.
3691
3692         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3693
3694 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3695
3696         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3697         https://bugs.webkit.org/show_bug.cgi?id=112442
3698
3699         Reviewed by Gustavo Noronha Silva.
3700
3701         * GtkLauncher/main.c:
3702         (reloadCb):
3703         (createToolbar):
3704         (createWindow):
3705
3706 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3707
3708         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3709         https://bugs.webkit.org/show_bug.cgi?id=112205
3710
3711         Disable this API test until Geoff can fix it.
3712
3713         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3714         (TestWebKitAPI::TEST):
3715
3716 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3717
3718         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3719         https://bugs.webkit.org/show_bug.cgi?id=112478
3720
3721         Reviewed by Tony Chang.
3722
3723         There is nothing that ensures that the log messages from the plugin
3724         come in before the layout test finished loading.
3725
3726         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3727         (PassDifferentNPPStruct::NPP_SetWindow):
3728         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3729         (NPP_SetWindow):
3730
3731 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3732
3733         Have the mac port support per_test_timeout in webkitpy
3734         https://bugs.webkit.org/show_bug.cgi?id=112466
3735
3736         Reviewed by Dirk Pranke.
3737         
3738         Both WTR and DRT handle --timeout arguments, so we can
3739         have the scripts pass the timeout values down to the tools.
3740
3741         * Scripts/webkitpy/layout_tests/port/mac.py:
3742         (MacPort.supports_per_test_timeout):
3743
3744 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3745
3746         Remove setAsynchronousSpellCheckingEnabled from test runners
3747         https://bugs.webkit.org/show_bug.cgi?id=112362
3748
3749         Reviewed by Tony Chang.
3750
3751         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3752         in internals.settings, so all ports can share it.
3753
3754         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3755         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3756         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3757         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3758         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3759         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3760         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3761         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3762         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3763         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3764         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3765         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3766
3767 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3768
3769         Fix the stupid unit tests.
3770
3771         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3772         (test_sample_process):
3773
3774 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3775
3776         Collect samples for unresponsive web processes
3777         https://bugs.webkit.org/show_bug.cgi?id=112409
3778
3779         Reviewed by Tim Horton.
3780         
3781         When we detect that a subprocess was unresponsive, run the 'sample'
3782         tool on that process, for the Mac port.
3783         
3784         The sample will be linked to from the results.html page, next
3785         to the crash log link.
3786
3787         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3788         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3789         look for samples on disk.
3790         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3791         (TestResultWriter):
3792         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3793         -sample.txt files, and have it copy their contents to a new file
3794         next to the test that spawned them (as we do for crash logs).
3795         * Scripts/webkitpy/layout_tests/port/base.py:
3796         (Port.look_for_new_samples): Base class does nothing for sampling.
3797         * Scripts/webkitpy/layout_tests/port/driver.py:
3798         (Driver._check_for_driver_crash): Kick off a sample if we detected
3799         that the subprocess was unresponsive.
3800         * Scripts/webkitpy/layout_tests/port/mac.py:
3801         (MacPort.sample_file_path): Utility to generate the file path
3802         to the generated sample files at the top level of layout-test-results.
3803         (MacPort.look_for_new_crash_logs): Fix typo
3804         (MacPort.look_for_new_samples): New function to find sample files.
3805         (MacPort.sample_process): Use the utility function to get the file path.
3806
3807 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3808
3809         [Qt] Remove simple getters and setters from TestRunnerQt
3810         https://bugs.webkit.org/show_bug.cgi?id=112343
3811
3812         Reviewed by Benjamin Poulain.
3813
3814         The removed functions and boolean members
3815         are being replaced by the implementations in the
3816         generic TestRunner.h.
3817
3818         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3819         (DumpRenderTree::dumpFrameScrollPosition):
3820         (DumpRenderTree::dumpFramesAsText):
3821         (DumpRenderTree::dump):
3822         (DumpRenderTree::titleChanged):
3823         (DumpRenderTree::dumpDatabaseQuota):
3824         (DumpRenderTree::dumpApplicationCacheQuota):
3825         (DumpRenderTree::statusBarMessage):
3826         (DumpRenderTree::createWindow):
3827         * DumpRenderTree/qt/TestRunnerQt.cpp:
3828         (TestRunnerQt::reset):
3829         * DumpRenderTree/qt/TestRunnerQt.h:
3830         (TestRunnerQt):
3831
3832 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3833
3834         Update the link on build.webkit.org to refer to perf.webkit.org
3835         https://bugs.webkit.org/show_bug.cgi?id=112416
3836
3837         Reviewed by Philip Rogers.
3838
3839         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3840
3841         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3842
3843 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3844
3845         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3846         https://bugs.webkit.org/show_bug.cgi?id=112394
3847
3848         Reviewed by Philippe Normand.
3849
3850         * GtkLauncher/main.c:
3851         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3852
3853 2013-03-14  Andreas Kling  <akling@apple.com>
3854
3855         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3856         <http://webkit.org/b/111815>
3857         <rdar://problem/13380145>
3858
3859         Reviewed by Anders Carlsson.
3860
3861         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3862         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3863         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3864
3865         * WebKitTestRunner/PlatformWebView.h:
3866         (PlatformWebView):
3867         * WebKitTestRunner/TestController.cpp:
3868         (WTR::TestController::createOtherPage):
3869         (WTR::TestController::createWebViewWithOptions):
3870         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3871         (WTR::PlatformWebView::didInitializeClients):
3872
3873 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3874
3875         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3876         https://bugs.webkit.org/show_bug.cgi?id=112122
3877
3878         Reviewed by Kenneth Rohde Christiansen.
3879
3880         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3881
3882         * MiniBrowser/efl/main.c:
3883         (_Browser_Window):
3884         (search_box_show):
3885         (search_box_hide):
3886         (on_key_down):
3887         (on_url_changed):
3888         (on_search_field_aborted):
3889         (on_search_field_activated):
3890         (on_search_field_clicked):
3891         (on_search_backward_button_clicked):
3892         (on_search_forward_button_clicked):
3893         (window_create):
3894
3895 2013-03-14  Julie Parent  <jparent@chromium.org>
3896
3897         Cleanup: Remove g_resourceLoader.
3898         https://bugs.webkit.org/show_bug.cgi?id=112305
3899
3900         Reviewed by Dirk Pranke.
3901         
3902         Removing another global.
3903         
3904         Now, each dashboard creates its own loader, rather than having
3905         a general global one.
3906         
3907         Remove usage of g_resourceLoader.isLoadingComplete from 
3908         handleLocationChange by ensuring that handleLocationChange is
3909         never called before the loader is done.  It was called in two
3910         places before: 1 was from the callback when the loader is done,
3911         so that was obviously true, and the other was from onhashchange,
3912         where it would just return rather than running.  Instead, lets
3913         only register the onhashchange handler once the loader is
3914         setup, so the check is no longer necessary.
3915         
3916         Remove isLoadingComplete since it is now unused.
3917         
3918         Callback for loader is now initializeHistory, rather than just
3919         handleLocationChange which will set up the hashchange handler now.
3920         This will all eventually be moving to a new History object.
3921
3922         * TestResultServer/static-dashboards/aggregate_results.html:
3923         * TestResultServer/static-dashboards/dashboard_base.js:
3924         (handleLocationChange):
3925         (intializeHistory):
3926         (decompressResults):
3927         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3928         (generatePage):
3929         * TestResultServer/static-dashboards/loader.js:
3930         (.):
3931         * TestResultServer/static-dashboards/loader_unittests.js:
3932         * TestResultServer/static-dashboards/timeline_explorer.html:
3933         * TestResultServer/static-dashboards/treemap.html:
3934
3935 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3936
3937         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3938         https://bugs.webkit.org/show_bug.cgi?id=109404
3939
3940         Reviewed by Tony Chang.
3941
3942         Removes all the code related to smartInsertDeleteEnabled and
3943         selectTrailingWhitespaceEnabled settings as they will be managed from
3944         internals from now on.
3945
3946         * DumpRenderTree/TestRunner.cpp:
3947         (TestRunner::staticFunctions):
3948         * DumpRenderTree/TestRunner.h:
3949         (TestRunner):
3950         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3951         (WebKit):
3952         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3953         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3954         (DumpRenderTree):
3955         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3956         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3957         (WebTestRunner::WebTestProxy::didStopLoading):
3958         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3959         (WebTestRunner::TestRunner::TestRunner):
3960         (WebTestRunner::TestRunner::reset):
3961         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3962         (TestRunner):
3963         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3964         (WebTestRunner::WebPreferences::applyTo): Set default values for
3965         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3966         Chromium DRT default values are different from Chromium browser.
3967         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3968         * DumpRenderTree/chromium/WebViewHost.cpp:
3969         * DumpRenderTree/chromium/WebViewHost.h:
3970         (WebViewHost):
3971         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3972         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3973         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3974         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3975         (resetDefaultsToConsistentValues):
3976         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3977         * DumpRenderTree/mac/DumpRenderTree.mm:
3978         (resetWebViewToConsistentStateBeforeTesting):
3979         * DumpRenderTree/mac/TestRunnerMac.mm:
3980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3981         (WebCore::WebPage::resetSettings):
3982         * DumpRenderTree/qt/TestRunnerQt.cpp:
3983         * DumpRenderTree/qt/TestRunnerQt.h:
3984         (TestRunnerQt):
3985         * DumpRenderTree/win/DumpRenderTree.cpp:
3986         (resetWebViewToConsistentStateBeforeTesting):
3987         * DumpRenderTree/win/TestRunnerWin.cpp:
3988         * DumpRenderTree/wx/TestRunnerWx.cpp:
3989
3990 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3991
3992         [Qt] Disable DRT on Windows
3993
3994         Reviewed by Jocelyn Turcotte.
3995
3996         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3997
3998         * qmake/mkspecs/features/configure.prf:
3999
4000 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4001
4002         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4003         https://bugs.webkit.org/show_bug.cgi?id=110728
4004
4005         Reviewed by Gyuyoung Kim.
4006
4007         Use the page group to create the view object.
4008
4009         * MiniBrowser/efl/main.c:
4010         (window_create):
4011
4012 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4013
4014         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4015
4016         Reviewed by Tor Arne Vestbø.
4017
4018         The mock versions of these web facing features should be instantiated when
4019         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4020         such as QtLocation are actually needed.
4021
4022         This patch decouples enabling device orientation/motion and geolocation from
4023         the underlying Qt modules and makes them available in developer builds
4024         (!production_build) and backed by mock backends when running in drt.
4025
4026         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4027         developers the web facing features are always enabled (although requests will
4028         time out) and the mock backends are enabled inside DRT, allowing for the layout
4029         tests to run with less dependencies.
4030
4031         In addition this also enables the mock device motion client, which was
4032         previously never instantiated.
4033
4034         * qmake/mkspecs/features/features.prf:
4035
4036 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4037
4038         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4039         https://bugs.webkit.org/show_bug.cgi?id=112340
4040
4041         Reviewed by Simon Hausmann.
4042
4043         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4044         (DumpRenderTree::dump):
4045             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4046         (DumpRenderTree::dumpApplicationCacheQuota):
4047         * DumpRenderTree/qt/TestRunnerQt.cpp:
4048         (TestRunnerQt::reset):
4049         * DumpRenderTree/qt/TestRunnerQt.h:
4050         (TestRunnerQt):
4051
4052 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4053
4054         [Qt] Port DRT to use TestRunner::dumpAsText()
4055         https://bugs.webkit.org/show_bug.cgi?id=112260
4056
4057         Reviewed by Benjamin Poulain.
4058
4059         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4060         (WebCore::DumpRenderTree::open):
4061         (WebCore::methodNameStringForFailedTest):
4062             Change parameter from type TestRunnerQt* to TestRunner*.
4063         (WebCore::DumpRenderTree::dump):
4064             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4065             Instead we should rely on TestRunner::generatePixelResults().
4066         * DumpRenderTree/qt/TestRunnerQt.cpp:
4067         (TestRunnerQt::reset):
4068         * DumpRenderTree/qt/TestRunnerQt.h:
4069         (TestRunnerQt):
4070
4071 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4072
4073         Implement FontLoader interface
4074         https://bugs.webkit.org/show_bug.cgi?id=98395
4075
4076         Reviewed by Eric Seidel.
4077
4078         Enable FontLoadEvents runtime flag for TestShell.
4079
4080         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4081         (WebTestRunner::TestInterfaces::TestInterfaces):
4082
4083 2013-03-13  Julie Parent  <jparent@chromium.org>
4084
4085         CLeanup: remove unnecessary call to parseParameters.
4086         https://bugs.webkit.org/show_bug.cgi?id=112309
4087
4088         Reviewed by Ojan Vafai.
4089         
4090         We call parseCrossDashboardParameters when the dashboard initially
4091         loads to set the state required for loadBuildersList, and then we
4092         call it again once we are fully done with loading, so there is no
4093         reason to call it in the middle of the loading process here.
4094
4095         * TestResultServer/static-dashboards/loader.js:
4096         (.):
4097
4098 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4099
4100         Unreviewed. Now I'm a reviewer :)
4101
4102         * Scripts/webkitpy/common/config/committers.py:
4103
4104 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4105
4106         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4107         https://bugs.webkit.org/show_bug.cgi?id=112277
4108
4109         Reviewed by Adam Barth.
4110
4111         * Scripts/webkitperl/FeatureList.pm:
4112         * qmake/mkspecs/features/features.pri:
4113
4114 2013-03-13  Adam Barth  <abarth@webkit.org>
4115
4116         run-perf-tests should support content_shell
4117         https://bugs.webkit.org/show_bug.cgi?id=112291
4118
4119         Reviewed by Eric Seidel.
4120
4121         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4122         (PerfTestsRunner._parse_args):
4123
4124 2013-03-13  Oliver Hunt  <oliver@apple.com>
4125
4126         Simplify Checked<> multiplication
4127         https://bugs.webkit.org/show_bug.cgi?id=112286
4128
4129         Reviewed by James Robinson.
4130
4131         Add tests for multiplication by zero and max to ensure we don't
4132         mess them up should we ever make changes to Checked<> in future.
4133
4134         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4135         (TestWebKitAPI):
4136
4137 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4138
4139         [Qt] Unreviewed prospective Windows build fix
4140
4141         Do the usual thing, include the moc generated code in the .cpp file instead
4142         of compiling it standalone, to ensure that config.h is included, too, and
4143         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4144
4145         * DumpRenderTree/qt/EventSenderQt.cpp:
4146
4147 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4148
4149         [Qt] Port TestRunner::findString to shared interface
4150         https://bugs.webkit.org/show_bug.cgi?id=112147
4151
4152         Reviewed by Jocelyn Turcotte.
4153
4154         This patch also removes DumpRenderTree and some other helper classes from
4155         the WebCore namespace, to which they do not really belong.
4156
4157         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4158         (main):
4159         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4160         (DumpRenderTree::DumpRenderTree):
4161         (DumpRenderTree::~DumpRenderTree):
4162         (DumpRenderTree::instance):
4163         (DumpRenderTree::setShouldTimeout):
4164         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4165         (DumpRenderTree):
4166         * DumpRenderTree/qt/EventSenderQt.cpp:
4167         (EventSender::contextClick):
4168         (EventSender::sendEvent):
4169         (EventSender::postEvent):
4170         * DumpRenderTree/qt/EventSenderQt.h:
4171         (EventSender::isGraphicsBased):
4172         * DumpRenderTree/qt/TestRunnerQt.cpp:
4173         (TestRunnerQt::TestRunnerQt):
4174         (TestRunner::findString):
4175         (TestRunnerQt::setMockDeviceOrientation):
4176         (TestRunnerQt::setGeolocationPermission):
4177         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4178         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4179         (TestRunnerQt::setMockGeolocationPosition):
4180         * DumpRenderTree/qt/TestRunnerQt.h:
4181         (TestRunnerQt):
4182
4183 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4184
4185         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4186         https://bugs.webkit.org/show_bug.cgi?id=112129
4187
4188         Reviewed by Adam Barth.
4189
4190         Following Chromium
4191         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4192         this is being renamed to better explain what it does.
4193
4194         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4195
4196 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4197
4198         [Qt] Unreviewed trivial typo fix
4199
4200         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4201         TextRunner.h. Thanks Zeno :)
4202
4203 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4204
4205         [Qt] Prepare DRT for transition to shared TestRunner interface
4206         https://bugs.webkit.org/show_bug.cgi?id=112144
4207
4208         Reviewed by Benjamin Poulain.
4209
4210         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4211         the JSC C API based one.
4212
4213         This is impplemented by instantiating the QObject based testRunner in
4214         the global object, then instantiating the JSC C based TestRunner
4215         separately and placing it "behind" the QObject based testRunner through
4216         injection of the individual functions through proxies. (prototype
4217         chaining doesn't work due to the this object and Function.prototype.bind
4218         doesn't work due to the native function)
4219
4220         This allows for porting over method by method by removing the method
4221         from the QObject TestRunnerQt and implementing it in the JSC C based
4222         TestRunner.
4223
4224         In order for this to link and run dummy implementations of all the
4225         necessary TestRunner functions are provided.
4226
4227         * DumpRenderTree/qt/DumpRenderTree.pro:
4228         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4229         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4230         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4231         (WebCore::DumpRenderTree::initJSObjects):
4232         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4233         (DumpRenderTree):
4234         * DumpRenderTree/qt/TestRunnerQt.cpp:
4235         (TestRunner::~TestRunner):
4236         (TestRunner::addDisallowedURL):
4237         (TestRunner::queueLoad):
4238         (TestRunner::removeAllVisitedLinks):
4239         (TestRunner::setAcceptsEditing):
4240         (TestRunner::simulateLegacyWebNotificationClick):
4241         (TestRunner::setWindowIsKey):
4242         (TestRunner::setAlwaysAcceptCookies):
4243         (TestRunner::addOriginAccessWhitelistEntry):
4244         (TestRunner::setWebViewEditable):
4245         (TestRunner::clearAllApplicationCaches):
4246         (TestRunner::setTextDirection):
4247         (TestRunner::notifyDone):
4248         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4249         (TestRunner::overridePreference):
4250         (TestRunner::pathToLocalResource):
4251         (TestRunner::removeAllWebNotificationPermissions):
4252         (TestRunner::simulateWebNotificationClick):
4253         (TestRunner::closeIdleLocalStorageDatabases):
4254         (TestRunner::focusWebView):
4255         (TestRunner::setBackingScaleFactor):
4256         (TestRunner::removeChromeInputField):
4257         (TestRunner::addChromeInputField):
4258         (TestRunner::originsWithLocalStorage):
4259         (TestRunner::deleteAllLocalStorage):
4260         (TestRunner::deleteLocalStorageForOrigin):
4261         (TestRunner::observeStorageTrackerNotifications):
4262         (TestRunner::syncLocalStorage):
4263         (TestRunner::windowCount):
4264         (TestRunner::setWaitToDump):
4265         (TestRunner::waitForPolicyDelegate):
4266         (TestRunner::webHistoryItemCount):
4267         (TestRunner::showWebInspector):
4268         (TestRunner::closeWebInspector):
4269         (TestRunner::evaluateInWebInspector):
4270         (TestRunner::setSerializeHTTPLoads):
4271         (TestRunner::apiTestNewWindowDataLoadBaseURL):
4272         (TestRunner::setCustomPolicyDelegate):
4273         (TestRunner::setDatabaseQuota):
4274         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
4275         (TestRunner::resetPageVisibility):
4276         (TestRunner::keepWebHistory):
4277         (TestRunner::goBack):
4278         (TestRunner::originsWithApplicationCache):
4279         (TestRunner::applicationCacheDiskUsageForOrigin):
4280         (TestRunner::display):
4281         (TestRunner::dispatchPendingLoadRequests):
4282         (TestRunner::clearPersistentUserStyleSheet):
4283         (TestRunner::callShouldCloseOnWebView):
4284         (TestRunner::copyDecodedHostName):
4285         (TestRunner::clearBackForwardList):
4286         (TestRunner::clearAllDatabases):
4287         (TestRunner::clearApplicationCacheForOrigin):
4288         (TestRunner::apiTestGoToCurrentBackForwardItem):
4289         (TestRunner::authenticateSession):
4290         (TestRunner::abortModal):
4291         (TestRunner::setStorageDatabaseIdleInterval):
4292         (TestRunner::setAsynchronousSpellCheckingEnabled):
4293         (TestRunner::setXSSAuditorEnabled):
4294         (TestRunner::setSpatialNavigationEnabled):
4295         (TestRunner::setScrollbarPolicy):
4296         (TestRunner::setJavaScriptCanAccessClipboard):
4297         (TestRunner::setAutomaticLinkDetectionEnabled):
4298         (TestRunner::setUserStyleSheetEnabled):
4299         (TestRunner::setUserStyleSheetLocation):
4300         (TestRunner::setUseDashboardCompatibilityMode):
4301         (TestRunner::setTabKeyCyclesThroughElements):
4302         (TestRunner::setSmartInsertDeleteEnabled):
4303         (TestRunner::setSelectTrailingWhitespaceEnabled):
4304         (TestRunner::setPrivateBrowsingEnabled):
4305         (TestRunner::setPluginsEnabled):
4306         (TestRunner::setPopupBlockingEnabled):
4307         (TestRunner::setMockSpeechInputDumpRect):
4308         (TestRunner::setPersistentUserStyleSheetLocation):
4309         (TestRunner::setMockGeolocationPosition):