c0c3f214111d1f77df34bfaf0bccfb09973f5e6b
[WebKit-https.git] / Tools / ChangeLog
1 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
2
3         Remove last bits of GYP from build-webkit and update-webkit scripts
4         https://bugs.webkit.org/show_bug.cgi?id=117557
5
6         Reviewed by Ryosuke Niwa.
7
8         * Scripts/build-webkit:
9         * Scripts/update-webkit:
10
11 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
12
13         Remove forgotten unused Tools/Script/make-gypi script
14         https://bugs.webkit.org/show_bug.cgi?id=117558
15
16         Reviewed by Ryosuke Niwa.
17
18         This script isn't used since the GYP removal from WebKit.
19
20         * Scripts/make-gypi: Removed.
21
22 2013-06-12  Andres Gomez  <agomez@igalia.com>
23
24         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
25         https://bugs.webkit.org/show_bug.cgi?id=117533
26
27         Reviewed by Carlos Garcia Campos.
28
29         MiniBrowser now starts automatically the download of the documents
30         that cannot be shown just by WebKit itself on link left clicking.
31
32         * MiniBrowser/gtk/BrowserWindow.c:
33         (webViewDecidePolicy): handled the
34         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
35
36 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
37
38         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
39         https://bugs.webkit.org/show_bug.cgi?id=116723
40
41         Reviewed by Carlos Garcia Campos.
42
43         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
44         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
45         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
46         not expensive and produces a working archive without problems even on incremental builds.
47
48 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
49
50         [EFL] Window resize should close the popupmenu
51         https://bugs.webkit.org/show_bug.cgi?id=117391
52
53         Reviewed by Christophe Dumez.
54         
55         Added the code to close the popup when main window is resized.
56
57         * MiniBrowser/efl/main.c:
58         (on_window_resize):
59
60 2013-06-11  Alex Christensen  <achristensen@apple.com>
61
62         Removed old broken code coverage tool.
63         https://bugs.webkit.org/show_bug.cgi?id=117520
64
65         Reviewed by Sam Weinig.
66
67         * CodeCoverage: Removed.
68         * CodeCoverage/README: Removed.
69         * CodeCoverage/amber.png: Removed.
70         * CodeCoverage/cov.py: Removed.
71         * CodeCoverage/emerald.png: Removed.
72         * CodeCoverage/gcov.css: Removed.
73         * CodeCoverage/glass.png: Removed.
74         * CodeCoverage/regenerate-coverage-display: Removed.
75         * CodeCoverage/ruby.png: Removed.
76         * CodeCoverage/run-generate-coverage-data: Removed.
77         * CodeCoverage/snow.png: Removed.
78
79 2013-06-11  Timothy Hatcher  <timothy@apple.com>
80
81         Have build-webkit build the WebInspectorUI project.
82
83         * Scripts/build-webkit:
84
85 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
86
87         Add an option to run-webkit-tests to skip java dependency check
88         https://bugs.webkit.org/show_bug.cgi?id=117516
89
90         Reviewed by Andreas Kling.
91
92         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
93         (parse_args):
94         * Scripts/webkitpy/port/mac.py:
95         (MacPort._check_port_build):
96
97 2013-06-11  Alex Christensen  <achristensen@apple.com>
98
99         https://bugs.webkit.org/show_bug.cgi?id=117514
100         Removed extra Xcode code coverage flags.
101
102         Reviewed by Sam Weinig.
103
104         * Scripts/webkitdirs.pm:
105         (XcodeCoverageSupportOptions):
106
107 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
108
109         [Windows] Implement 'attributeValue' accessor to support testing
110         https://bugs.webkit.org/show_bug.cgi?id=117513
111
112         Reviewed by Anders Carlsson.
113
114         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
115         (comparableObject): Move earlier in file.
116         (findAccessibleObjectById): New implemenation.
117         (AccessibilityController::accessibleElementById): New implementation.
118
119 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
120
121         Make WTR use its own temporary directory for application cache
122         https://bugs.webkit.org/show_bug.cgi?id=117143
123
124         Reviewed by Alexey Proskuryakov.
125
126         * WebKitTestRunner/TestController.cpp:
127         (WTR::TestController::initialize):
128
129 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
130
131         https://bugs.webkit.org/show_bug.cgi?id=117449
132         Remove dead code for storing fonts in __DATA section
133
134         Reviewed by Dan Bernstein.
135
136         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
137         Don't copy font resources to __DATA, as we don't have any code that reads them
138         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
139
140         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
141         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
142         Removed comments suggesting that we want to restore the old solution.
143
144 2013-06-10  Bear Travis  <betravis@adobe.com>
145
146         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
147         https://bugs.webkit.org/show_bug.cgi?id=117162
148
149         Reviewed by Alexandru Chiculita.
150
151         Adding the WebCore/rendering/shapes directory to the include list.
152
153         * DumpRenderTree/efl/CMakeLists.txt:
154
155 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
156
157         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
158         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
159         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
160         happends in some of the 'accessibility' test cases.
161
162 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
163
164         [WinCairo] TestWebKitAPI fails to link.
165         https://bugs.webkit.org/show_bug.cgi?id=117345
166
167         Reviewed by Brent Fulgham.
168
169         Need to link with WTF.lib.
170
171         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
172
173 2013-06-07  Roger Fong  <roger_fong@apple.com>
174
175         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
176
177         Rubberstamped by Ryousuke Niwa.
178
179         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
180         (RunTest.test_build_check):
181
182 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
183
184         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
185         https://bugs.webkit.org/show_bug.cgi?id=117315
186
187         Reviewed by Benjamin Poulain.
188
189         Qt doesn't use the default values specified on FeatureList since r44681,
190         this patch just remove a bit of noise.
191
192         * Scripts/webkitperl/FeatureList.pm:
193
194 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
195
196         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
197         https://bugs.webkit.org/show_bug.cgi?id=115890
198
199         Reviewed by Christophe Dumez.
200
201         When user clicks HTML5 input type color,
202         color selector window is created on browser object by using elm_colorchooser_add().
203         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
204         The evas_object_color_set() sets a color value returning to browser.
205
206         * MiniBrowser/efl/main.c:
207         (window_free): When we delete parent window, deleting the colorpicker object.
208         (on_color_changed): Change color of rectangle to show color selected by user.
209         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
210         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
211         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
212         (on_color_picker_dismiss): Delete colorpicker object.
213         (on_color_picker_request): Create colorpicker window object.
214         (window_create):
215
216 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
217
218         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
219         https://bugs.webkit.org/show_bug.cgi?id=111066
220
221         Reviewed by Daniel Bates.
222
223         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
224
225         ParseGitDiffHeader() should support the path which line has space characters.
226         To support this, I changed parsing algorithm like the following:
227         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
228         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
229
230         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
231
232         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
233         I added a dummy tab and revision when we convert git diff to svn diff.
234
235         * Scripts/VCSUtils.pm:
236         (parseGitDiffHeader):
237         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
238         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
239         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
240           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
241
242 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
243
244         Add a menu item to MiniBrowser to toggle Transparent windows
245         https://bugs.webkit.org/show_bug.cgi?id=117316
246
247         Reviewed by Anders Carlsson.
248         
249         Add a menu item that toggles "Transparent window" mode, which is exposed
250         via private WebKit API and WebKit2 API.
251
252         * MiniBrowser/mac/BrowserWindowController.h:
253         * MiniBrowser/mac/MainMenu.xib:
254         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
255         * MiniBrowser/mac/WK1BrowserWindowController.m:
256         (-[WK1BrowserWindowController validateMenuItem:]):
257         (-[WK1BrowserWindowController toggleTransparentWindow:]):
258         * MiniBrowser/mac/WK2BrowserWindowController.m:
259         (-[WK2BrowserWindowController validateMenuItem:]):
260         (-[WK2BrowserWindowController toggleTransparentWindow:]):
261         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
262         when testing.
263
264 2013-06-06  Roger Fong  <roger_fong@apple.com>
265
266         Stop copying AAS binaries into build folder.
267         https://bugs.webkit.org/show_bug.cgi?id=117319.
268
269         Rubberstamped by Darin Adler.
270
271         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
272
273 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
274
275         Aligning build-webkit command line switch names to the WebKit flag names
276         https://bugs.webkit.org/show_bug.cgi?id=117254
277
278         Reviewed by Laszlo Gombos.
279
280         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
281
282 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
283
284         AX: iOS ignores ARIA progressbar elements
285         https://bugs.webkit.org/show_bug.cgi?id=116727
286
287         Reviewed by David Kilzer.
288
289         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
290         (AccessibilityUIElement::minValue):
291         (AccessibilityUIElement::maxValue):
292
293 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
294
295         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
296         https://bugs.webkit.org/show_bug.cgi?id=117255
297
298         Reviewed by Daniel Bates.
299
300         Need to update configuration names according to solution file.
301
302         * Scripts/webkitdirs.pm:
303         (determineConfiguration):
304         (determinePassedConfiguration):
305
306 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
307
308         Remove run-performance-tests
309         https://bugs.webkit.org/show_bug.cgi?id=117285
310
311         Reviewed by Andreas Kling.
312         
313         Remove the script since it's not used anywhere.
314
315         * BuildSlaveSupport/run-performance-tests: Removed.
316
317 2013-06-05  Bear Travis  <betravis@adobe.com>
318
319         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
320         https://bugs.webkit.org/show_bug.cgi?id=117172
321
322         Reviewed by Alexandru Chiculita.
323
324         Adding the CSS_SHAPES compile flag.
325
326         * Scripts/webkitperl/FeatureList.pm:
327         * qmake/mkspecs/features/features.pri:
328
329 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
330
331         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
332         to UNIX-style they will not execute properly.
333
334         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
335         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
336
337 2013-06-05  Roger Fong  <roger_fong@apple.com>
338
339         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
340
341         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
342         (RunWebKitTests.start):
343
344 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
345
346         [Windows] Switch to NRWT
347         https://bugs.webkit.org/show_bug.cgi?id=117200
348
349         Reviewed by Anders Carlsson.
350
351         * Scripts/run-webkit-tests:
352         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
353
354 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
355
356         Unreviewed name fix after r150662
357
358         My firstname got duplicated when fixing bug 116737.
359
360         * Scripts/webkitpy/common/config/contributors.json:
361
362 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
363
364         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
365         https://bugs.webkit.org/show_bug.cgi?id=117244
366
367         Reviewed by Daniel Bates.
368
369         Fixed a regression introduced by r151196: not only does webkit.org
370         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
371         infrastructure used by ports such as GTK+ and EFL also use on it for
372         things such as jhbuild.
373
374         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
375         both environment variables.
376
377         * Scripts/webkitdirs.pm:
378         (determineBaseProductDir):
379
380 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
381
382         [GTK] Forwarding headers not generated for incremental build
383         https://bugs.webkit.org/show_bug.cgi?id=117198
384
385         Reviewed by Carlos Garcia Campos.
386
387         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
388
389 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
390
391         [Qt][WK2] Fix layout testing with Qt 5.1
392         https://bugs.webkit.org/show_bug.cgi?id=117203
393
394         Reviewed by Jocelyn Turcotte.
395
396         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
397         go into loading state but directly call handler functions for
398         finished state instead of relying on a connection.
399         Our wrapper QQuickView uses a data URI scheme to create the root
400         item for testing which results in a synchronous request when loading
401         the QML data, therefore the state of the QQuickWindow immediately
402         becomes Ready.
403         Since the final initialization of the root item depended on the
404         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
405         up with a partially initialized wrapper window, thus most of our
406         layout tests were failing.
407         For compatibility with pre-5.1 Qt versions keep the old behaviour
408         in case the WrapperWindow is not ready in the constructor yet.
409
410         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
411         (WTR::WrapperWindow::WrapperWindow):
412         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
413         (TestWebKitAPI::WrapperWindow::WrapperWindow):
414
415 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
416
417         Bad value in tests counter at new-run-webkit-tests
418         in --debug-rwt-logging mode
419         https://bugs.webkit.org/show_bug.cgi?id=116858
420
421         Reviewed by Dirk Pranke.
422
423         Fix by moving counter incrementation, from after printing line,
424         to before printing. Also changed variable name.
425
426         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
427         (LayoutTestRunner.run_tests):
428         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
429         (FakePrinter):
430         * Scripts/webkitpy/layout_tests/views/printing.py:
431         (Printer.__init__):
432         (Printer._test_status_line):
433         (Printer.print_started_test):
434         (Printer.print_finished_test):
435         * Scripts/webkitpy/test/printer.py:
436         (Printer.__init__):
437         (Printer.print_finished_test):
438         (Printer._test_line):
439         (Printer.print_result):
440
441 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
442
443         Move MemoryInfo under window.internals
444         https://bugs.webkit.org/show_bug.cgi?id=117197
445
446         Reviewed by Ryosuke Niwa.
447
448         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
449         the Automake build
450         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
451         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
452
453 2013-06-03  Roger Fong  <roger_fong@apple.com>
454
455         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
456         <rdar://problem/14042021>.
457
458         Reviewed by Brent Fulgham.
459
460         * Scripts/build-api-tests:
461         * Scripts/build-dumprendertree:
462         * Scripts/build-webkit:
463         * Scripts/update-webkit-dependency:
464         * Scripts/update-webkit-support-libs:
465         * Scripts/webkitdirs.pm:
466         (determineBaseProductDir):
467         (setupAppleWinEnv):
468         (setupCygwinEnv):
469
470 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
471
472         [Windows] NRWT is not putting crash logs in proper place (corrections)
473         https://bugs.webkit.org/show_bug.cgi?id=117212
474
475         Reviewed by Dirk Pranke.
476
477         * Scripts/webkitpy/common/system/crashlogs.py:
478         (CrashLogs.__init__): Accept a result directory argument in constructor.
479         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
480         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
481         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
482         (CrashLogsTest.test_find_log_win): Simplify test.
483         * Scripts/webkitpy/common/system/executive.py:
484         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
485         * Scripts/webkitpy/port/win.py:
486         (WinPort._get_crash_log): No longer require 'port' argument.
487
488 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
489
490         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
491
492         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
493
494 2013-06-04  Greg Hughes  <ghughes@apple.com>
495
496         Add "VisibleOnly" key to search predicate
497         https://bugs.webkit.org/show_bug.cgi?id=115491
498
499         Reviewed by Chris Fleizach.
500
501         Added support for accessibility clients to use the search predicate to find only visible elements
502
503         * DumpRenderTree/AccessibilityUIElement.cpp:
504         (uiElementForSearchPredicateCallback):
505         * DumpRenderTree/AccessibilityUIElement.h:
506         (AccessibilityUIElement):
507         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
508         (AccessibilityUIElement::uiElementForSearchPredicate):
509         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
510         (AccessibilityUIElement::uiElementForSearchPredicate):
511         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
512         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
513         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
514         (AccessibilityUIElement):
515         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
516         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
517         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
518
519 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
520
521         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
522         causing build failure.
523
524         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
525         DOS-style CR/LF endings.
526
527 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
528
529         [Windows] Unreviewed test correction.
530
531         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
532         QuartzCore dll's, which are needed by TestWebKitAPI.
533         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
534         with VS2010 will run when linked against VS2005 support libraries.
535
536 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
537
538         Automatically generate WorkerContext constructor attributes
539         https://bugs.webkit.org/show_bug.cgi?id=117183
540
541         Reviewed by Kentaro Hara.
542
543         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
544         tests.
545
546         * Scripts/webkitpy/bindings/main.py:
547         (BindingsTests.generate_supplemental_dependency):
548         (BindingsTests.main):
549
550 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
551
552         [EFL] File dialog of MiniBrowser have broken background.
553         https://bugs.webkit.org/show_bug.cgi?id=117189
554
555         Reviewed by Christophe Dumez.
556
557         * MiniBrowser/efl/main.c:
558         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
559
560 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
561
562         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
563         https://bugs.webkit.org/show_bug.cgi?id=117184
564
565         Reviewed by Gyuyoung Kim.
566
567         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
568         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
569
570         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
571         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
572         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
573
574 2013-06-03  Simon Pena  <simon.pena@samsung.com>
575
576         validate-committer-lists script is now outdated and does not work
577         https://bugs.webkit.org/show_bug.cgi?id=115860
578
579         Reviewed by Brent Fulgham.
580
581         The script validate-committer-lists was outdated, still using the deprecated log
582         system and having the old addresses for the mailing lists, as well as still referring
583         to committers.py, after this was renamed to contributors.json. This patch fixes that
584         so it can be used again.
585
586         * Scripts/validate-committer-lists: Replace calls to log and error with the
587         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
588         to committers.py, which should be contributors.json.
589         (CommitterListFromMailingList):
590         (CommitterListFromMailingList.check_for_emails_missing_from_list):
591         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
592         (CommitterListFromGit._fill_in_emails_for_old_logins):
593         (CommitterListFromGit.print_committers_missing_from_committer_list):
594
595 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
596
597         add a script to dump the tests run most recently by a given worker
598         https://bugs.webkit.org/show_bug.cgi?id=116571
599
600         Reviewed by Brent Fulgham.
601
602         The tests_run*.txt results files in layout-test-results/ were removed
603         in r137356, in favor of collecting more data about how the tests were
604         run and compressing it and storing it in stats.json. However, it was
605         nice to just be able to look at a flat text file.
606
607         This script will extract the tests run by a given worker from a
608         given stats.json file, and should help to address that.
609
610         * Scripts/dump-webkit-tests-run: Added.
611         (main):
612         (convert_trie_to_flat_paths):
613
614 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
615
616         [Windows] NRWT is not putting crash logs in proper place
617         https://bugs.webkit.org/show_bug.cgi?id=117098
618
619         Reviewed by Ryosuke Niwa.
620
621         Provide windows-specific overloads for various Port features needed to create and capture
622         crash logs.  This change makes it possible to view crash logs (when created) as part of the
623         summary report at the end of the NRWT run.
624
625         * Scripts/webkitpy/common/system/crashlogs.py:
626         (CrashLogs.find_newest_log): Add support for win32 crash logs
627         (CrashLogs._find_newest_log_win): Added
628         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
629         (make_mock_crash_report_win): Added
630         (CrashLogsTest.test_find_log_win): Added.
631         * Scripts/webkitpy/common/system/executive.py:
632         (Executive.running_pids): Add support for Cygwin win32 crash logs
633         * Scripts/webkitpy/common/system/executive_mock.py:
634         (MockExecutive.__init__):
635         * Scripts/webkitpy/common/system/filesystem_unittest.py:
636         (RealFileSystemTest.test_read_and_write_file): Add tests for
637         malformed ascii/utf8 handling (i.e., Windows log files)
638         * Scripts/webkitpy/port/base.py:
639         (Port.find_system_pid): Added
640         * Scripts/webkitpy/port/server_process.py:
641         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
642         * Scripts/webkitpy/port/win.py:
643         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
644         for user to hit enter.
645         (WinPort._get_crash_log): Added
646         (WinPort.look_for_new_crash_logs): Added
647         (WinPort.find_system_pid): Added
648         * Scripts/webkitpy/port/win_unittest.py:
649         (WinPortTest.test_get_crash_log): Added test
650
651 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
652
653         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
654         https://bugs.webkit.org/show_bug.cgi?id=116726
655
656         Reviewed by Gyuyoung Kim.
657
658         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
659         the platform (it is not listed in jhbuild moduleset). That version is
660         old-ish and contain deprecated symbols and missing API, that are blocking
661         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
662         moduleset, which is the same version the gtk port uses.
663
664         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
665         why this is needed.
666
667         * efl/jhbuild.modules: Adds ATK module as dependency
668
669 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
670
671         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
672         https://bugs.webkit.org/show_bug.cgi?id=117168
673
674         Reviewed by Martin Robinson.
675
676         The tool generate-gtkdoc internally calls pkg-config.
677         When cross-compiling it shouldn't use pkg-config, but
678         it should use the pkg-config which was detected by
679         the ./configure script (for example this can be
680         i686-w64-mingw32-pkg-config when cross-compiling)
681
682         * GNUmakefile.am:
683         * gtk/gtkdoc.py:
684         (PkgConfigGTKDoc.__init__):
685
686 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
687
688         [Windows] Unreviewed build fix.
689
690         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
691         allow VS2010 builds to use VS2005 runtime libraries as needed.
692
693 2013-06-03  Roger Fong  <roger_fong@apple.com>
694
695         Nuke VS2005 files from the tree.
696         <rdar://problem/14042021>.
697
698         Rubberstamped by Brent Fulgham.
699
700         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
701         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
702         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
703         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
704         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
705         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
706         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
707         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
708         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
709         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
710         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
711         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
712         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
713         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
714         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
715         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
716         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
717         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
718         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
719         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
720         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
721         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
722         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
723         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
724         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
725         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
726         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
727         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
728         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
729         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
730         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
731         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
732         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
733         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
734         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
735         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
736         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
737         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
738         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
739         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
740         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
741         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
742         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
743         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
744         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
745         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
746         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
747         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
748         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
749         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
750         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
751         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
752         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
753         * Scripts/pdevenv: Removed.
754         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
755         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
756         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
757         * WebKitLauncherWin: Removed.
758         * WebKitLauncherWin/Resource.h: Removed.
759         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
760         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
761         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
762         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
763         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
764         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
765         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
766         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
767         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
768         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
769         * WebKitLauncherWin/webkit.ico: Removed.
770         * WinLauncher/WinLauncher.ico: Removed.
771         * WinLauncher/WinLauncher.rc: Removed.
772         * WinLauncher/WinLauncher.vcproj: Removed.
773         * WinLauncher/WinLauncherCommon.vsprops: Removed.
774         * WinLauncher/WinLauncherDebug.vsprops: Removed.
775         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
776         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
777         * WinLauncher/WinLauncherLauncher.rc: Removed.
778         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
779         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
780         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
781         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
782         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
783         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
784         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
785         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
786         * WinLauncher/WinLauncherLauncherResource.h: Removed.
787         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
788         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
789         * WinLauncher/WinLauncherProduction.vsprops: Removed.
790         * WinLauncher/WinLauncherRelease.vsprops: Removed.
791         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
792         * WinLauncher/small.ico: Removed.
793         * record-memory-win: Removed.
794         * record-memory-win/main.cpp: Removed.
795         * record-memory-win/record-memory-win-common.vsprops: Removed.
796         * record-memory-win/record-memory-win.vcproj: Removed.
797         * record-memory-win/record-memory-winDebug.vsprops: Removed.
798         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
799         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
800         * record-memory-win/record-memory-winProduction.vsprops: Removed.
801         * record-memory-win/record-memory-winRelease.vsprops: Removed.
802         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
803
804 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
805
806         AX: MathML multiscripts not exposed in Accessibility
807         https://bugs.webkit.org/show_bug.cgi?id=115069
808
809         Reviewed by Tim Horton.
810
811         Add methods to help output components of math multiscripts for accessibility.
812
813         * DumpRenderTree/AccessibilityUIElement.cpp:
814         (mathPostscriptsDescriptionCallback):
815         (mathPrescriptsDescriptionCallback):
816         (AccessibilityUIElement::getJSClass):
817         * DumpRenderTree/AccessibilityUIElement.h:
818         (AccessibilityUIElement):
819         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
820         (convertMathMultiscriptPairsToString):
821         (AccessibilityUIElement::mathPostscriptsDescription):
822         (AccessibilityUIElement::mathPrescriptsDescription):
823         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
824         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
825         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
826         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
827         (AccessibilityUIElement):
828         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
829         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
830         (WTR::_convertMathMultiscriptPairsToString):
831         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
832         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
833
834 2013-06-03  Commit Queue  <commit-queue@webkit.org>
835
836         Unreviewed, rolling out r151109.
837         http://trac.webkit.org/changeset/151109
838         https://bugs.webkit.org/show_bug.cgi?id=117145
839
840         "Plugins in WK2 aren't implemented yet." (Requested by
841         jturcotte on #webkit).
842
843         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
844         * qmake/mkspecs/features/features.prf:
845         * qmake/mkspecs/features/unix/default_pre.prf:
846
847 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
848
849         [Qt] Re-enable plugins on Mac.
850         https://bugs.webkit.org/show_bug.cgi?id=116622
851
852         Reviewed by Tor Arne Vestbø.
853
854         Plugins on Mac were only enabled if !embedded but the later was set if
855         QPA is enabled, which is the default since Qt 5.0.
856
857         Remove references to 'embedded' and fix various build issues,
858         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
859         months.
860
861         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
862         * qmake/mkspecs/features/features.prf:
863         * qmake/mkspecs/features/unix/default_pre.prf:
864
865 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
866
867         [GTK][WK2] accessibility/placeholder.html is failing
868         https://bugs.webkit.org/show_bug.cgi?id=106344
869
870         Reviewed by Gyuyoung Kim.
871
872         Adds support for retrieving attribute value.
873
874         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
875         (WTR::coreAttributeToAtkAttribute):
876         (WTR::AccessibilityUIElement::stringAttributeValue):
877
878 2013-06-01  Tim Horton  <timothy_horton@apple.com>
879
880         Add a preferred email address and "expertise" for me.
881
882         * Scripts/webkitpy/common/config/contributors.json:
883
884 2013-05-31  Roger Fong  <roger_fong@apple.com>
885
886         Unreviewed. Make windows test bots search in the correct directory for build output.
887
888         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
889         (RunWebKitTests.start):
890         * Scripts/webkitdirs.pm:
891         (determineConfigurationProductDir):
892
893 2013-05-31  Roger Fong  <roger_fong@apple.com>
894
895         Unreviewed. Windows build fix...
896
897         * BuildSlaveSupport/built-product-archive:
898         (createZip):
899
900 2013-05-31  Roger Fong  <roger_fong@apple.com>
901
902         Unreviewed. Windows build fix. One more time!
903
904         * BuildSlaveSupport/built-product-archive:
905         (archiveBuiltProduct):
906         (extractBuiltProduct):
907
908 2013-05-31  Roger Fong  <roger_fong@apple.com>
909
910         Unreviewed. Windows build fix.
911
912         * Scripts/build-webkit:
913
914 2013-05-31  Roger Fong  <roger_fong@apple.com>
915
916         Unreviewed. Windows build fix.
917
918         * Scripts/build-webkit:
919
920 2013-05-31  Roger Fong  <roger_fong@apple.com>
921
922         Make build-webkit output VCExpress 2010 build logs properly.
923         https://bugs.webkit.org/show_bug.cgi?id=117096
924
925         Reviewed by Brent Fulgham.
926
927         Make it so that output from VCExpress is always printed to console.
928         Get build log results from AssembleBuildLogs project output.
929         We don't need those old VCExpress scripts anymore either. 
930
931         * Scripts/build-webkit:
932         * Scripts/print-msvc-project-dependencies: Removed.
933         * Scripts/print-vse-failure-logs: Removed.
934
935 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
936
937         [Windows] Use WinLauncher to display LayoutTest results
938         https://bugs.webkit.org/show_bug.cgi?id=117085
939
940         Reviewed by Oliver Hunt.
941
942         * Scripts/webkitdirs.pm:
943         (runSafari): Use WinLauncher to display content
944         * WinLauncher/WinLauncher.cpp:
945         (dllLauncherEntryPoint): Check for URL argument.
946
947 2013-05-31  Roger Fong  <roger_fong@apple.com>
948
949         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
950
951         * win/AssembleBuildLogs/AssembleLogs.cmd:
952
953 2013-05-31  Commit Queue  <commit-queue@webkit.org>
954
955         Unreviewed, rolling out r151022.
956         http://trac.webkit.org/changeset/151022
957         https://bugs.webkit.org/show_bug.cgi?id=117084
958
959         Also breaks build by introducing duplicate symbols (Requested
960         by bfulgham on #webkit).
961
962         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
963
964 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
965
966         [Windows] Unreviewed build fix to NRWT
967
968         * Scripts/webkitpy/port/win.py:
969         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
970
971 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
972
973         [Windows] Unreviewed build fix after r151012
974
975         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
976         WTF library to support SHA tests
977
978 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
979
980         [Windows] Unreviewed build fix after r151012
981
982         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
983         snprintf definition for Windows.
984
985 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
986
987         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
988         https://bugs.webkit.org/show_bug.cgi?id=116445
989
990         Reviewed by Benjamin Poulain.
991
992         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
993
994         * TestWebKitAPI/CMakeLists.txt:
995         * TestWebKitAPI/GNUmakefile.am:
996         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
997         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
999         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
1000         (TestWebKitAPI):
1001         (TestWebKitAPI::expectMD5):
1002         (TestWebKitAPI::TEST):
1003         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
1004         (TestWebKitAPI):
1005         (TestWebKitAPI::expectSHA1):
1006         (TestWebKitAPI::TEST):
1007         * TestWebKitAPI/Tests/WTF/WTF.pro:
1008         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1009
1010 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1011
1012         [Windows] Unreviewed build correction.
1013
1014         * Scripts/webkitpy/port/win.py:
1015         (WinPort.create_debugger_command_file): The directory needs to be
1016         a string, not a temporary directory object.
1017
1018 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1019
1020         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
1021         https://bugs.webkit.org/show_bug.cgi?id=76935
1022
1023         Reviewed by Ryosuke Niwa.
1024
1025         Extend the WinPort class with commands to set and clean up various registry
1026         values needed to invoke the correct debugger to get crash files.
1027
1028         * Scripts/webkitpy/port/win.py:
1029         (WinPort): Added global caches for registry keys and settings
1030         (WinPort._ntsd_location): Added
1031         (WinPort.create_debugger_command_file): Added
1032         (WinPort.read_registry_string): Added
1033         (WinPort.write_registry_string): Added
1034         (WinPort.setup_crash_log_saving): Added
1035         (WinPort.restore_crash_log_saving): Added
1036         (WinPort.setup_test_run): Added overload to add registry settings.
1037         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
1038
1039 2013-05-30  Roger Fong  <roger_fong@apple.com>
1040
1041         Get rid of JavaScript exports file on AppleWin port.
1042         https://bugs.webkit.org/show_bug.cgi?id=117050.
1043
1044         Reviewed by Darin Adler.
1045
1046         Start linking in WTF.lib now that it's a shared library.
1047
1048         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1049         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1050         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1051
1052 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1053
1054         Web Inspector: tests in PerformanceTests/inspector/ are timing out
1055         https://bugs.webkit.org/show_bug.cgi?id=77024
1056
1057         Reviewed by Andreas Kling.
1058
1059         Remove inspector performance tests since they have been disabled for ages,
1060         and they don't use the standard parser-style performance output.
1061
1062         It's adding a lot of code complexity to our infrastructure.
1063
1064         * Scripts/webkitpy/performance_tests/perftest.py:
1065         (SingleProcessPerfTest.__init__):
1066         (PerfTestFactory):
1067         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1068         (TestPerfTestFactory.test_regular_test):
1069         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1070         (TestDriver.run_test):
1071         (MainTest.run_test):
1072         (MainTest._tests_for_runner):
1073         (MainTest.test_run_test_set_kills_drt_per_run):
1074         (MainTest._test_run_with_json_output):
1075         (MainTest):
1076         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1077
1078 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1079
1080         Remove requires_http_server as Chromium Android was the only port that needed this
1081         https://bugs.webkit.org/show_bug.cgi?id=117018
1082
1083         Reviewed by Benjamin Poulain.
1084
1085         Removed the unused code that existed for Chromium Android port.
1086
1087         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1088         (LayoutTestRunner.run_tests):
1089         (LayoutTestRunner._handle_finished_test_list):
1090         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1091         (Manager._run_tests):
1092         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1093         (PerfTestsRunner._collect_tests):
1094         (PerfTestsRunner.run):
1095         * Scripts/webkitpy/port/base.py:
1096         (Port.to.start_helper):
1097         * Scripts/webkitpy/port/base_unittest.py:
1098         (PortTest.test_build_path):
1099
1100 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
1101
1102         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
1103         https://bugs.webkit.org/show_bug.cgi?id=113221
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         Teach prepare-Changelog to not list the names of modified namespaces, 
1108         classes, or structs in C++ files. Thus, if a change is made 
1109         within a namespace/class/struct yet outside a function, it will 
1110         not be reflected in the ChangeLog entry. 
1111         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
1112         for more details on how ChangeLog entries are affected.
1113
1114         * Scripts/prepare-ChangeLog:
1115         (get_function_line_ranges_for_cpp): 
1116         (delete_namespaces_from_ranges_for_cpp): Added.
1117         (is_function_in_namespace): Added.
1118         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
1119         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
1120
1121 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
1122
1123         Cleanup AudioSourceNode.idl from WebKit build.
1124         https://bugs.webkit.org/show_bug.cgi?id=116905.
1125
1126         Reviewed by Darin Adler.
1127
1128         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
1129         AudioNode is inherited directly in all the audio source nodes.
1130
1131         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1132
1133 2013-05-29  Andrew Lo  <anlo@rim.com>
1134
1135         Add Andrew Lo to contributors.json
1136         https://bugs.webkit.org/show_bug.cgi?id=116981
1137
1138         Reviewed by Rob Buis.
1139
1140         Adding Andrew Lo to contributors.json.
1141
1142         * Scripts/webkitpy/common/config/contributors.json:
1143
1144 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1145
1146         Unreviewed. Adding myself as a committer.
1147
1148         * Scripts/webkitpy/common/config/contributors.json:
1149
1150 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
1151
1152         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
1153         https://bugs.webkit.org/show_bug.cgi?id=116683
1154
1155         Reviewed by Noam Rosenthal.
1156
1157         A coordinates conversion test for WKViewUserViewportToContents was
1158         added to WebKit2 API tests.
1159
1160         * TestWebKitAPI/PlatformEfl.cmake:
1161         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
1162         (TestWebKitAPI):
1163         (TestWebKitAPI::TEST):
1164
1165 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
1166
1167         Unreviewed. Update my info.
1168
1169         * Scripts/webkitpy/common/config/contributors.json:
1170
1171 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
1172
1173         Unreviewed. Add myself as committer in contributors.json.
1174
1175         * Scripts/webkitpy/common/config/contributors.json:
1176
1177 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1178
1179         Unreviewed. Fix make distcheck.
1180
1181         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
1182         DISTCLEANFILES.
1183
1184 2013-05-29  Mary Wu  <mawu@blackberry.com>
1185
1186         Unreviewed: update my email address in contributors.json.
1187
1188         * Scripts/webkitpy/common/config/contributors.json:
1189
1190 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
1191
1192         Unreviewed: Adding myself to committers list.
1193
1194         * Scripts/webkitpy/common/config/contributors.json:
1195
1196 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
1197
1198         Unreviewed: Adding myself to committers list.
1199
1200         * Scripts/webkitpy/common/config/contributors.json:
1201
1202 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
1203
1204         [Windows] Many CSS2.1 tests fail under NRWT.
1205         https://bugs.webkit.org/show_bug.cgi?id=75707
1206
1207         Reviewed by Darin Adler.
1208
1209         * DumpRenderTree/win/DumpRenderTree.cpp:
1210         (findFontFallback): Added
1211         (addFontFallbackIfPresent): Added
1212         (removeFontFallbackIfPresent): Added
1213         (runTest): Set up/remove font fallbacks when needed.
1214
1215 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
1216
1217         [Windows] NRWT reports failure for 'mac' test cases.
1218         https://bugs.webkit.org/show_bug.cgi?id=116698
1219
1220         Reviewed by Ryosuke Niwa.
1221
1222         The Windows port falls back to the Mac port for many test results,
1223         and so adds the mac and mac-wk2 to its set of fallbacks.
1224         Unfortunately, NRWT thinks that this means that tests in these
1225         folders should be executed, resulting in many failures on
1226         Windows.
1227
1228         This change overloads the '_tests_for_other_platforms' method
1229         to return a subset of the result fallback list so that we do
1230         not attempt to execute Mac tests on Windows.
1231
1232         * Scripts/webkitpy/port/base.py:
1233         (Port.test_search_path): Added. Defaults to just calling the
1234         baseline_search_path method, which is how most ports behave.
1235         (Port._test_for_other_platforms): Modified to call the new
1236         test_search_path method.
1237
1238         * Scripts/webkitpy/port/win.py:
1239         (WinPort.test_search_path): Added custom overload. Strips
1240         out mac-specific test paths.
1241
1242 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
1243
1244         Fix GTK+ CMake build
1245
1246         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
1247         library target is simply "WebKit2."
1248
1249 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
1250
1251         [webkitpy] Explicitly specify the reference file extensions
1252         https://bugs.webkit.org/show_bug.cgi?id=116333
1253
1254         Reviewed by Benjamin Poulain.
1255
1256         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
1257         between valid reference files required by reftests and text baselines that have the same extension as
1258         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
1259         that were until this change recognized as reference files).
1260
1261         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
1262
1263         * Scripts/webkitpy/port/base.py:
1264         (Port.reference_files): Iterate through the _supported_reference_extensions set.
1265         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
1266         _supported_reference_extensions set, containing the extensions allowed for reference files.
1267         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
1268         (Port._has_supported_extension): Use _supported_test_extensions.
1269         * Scripts/webkitpy/port/base_unittest.py:
1270         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
1271         Port.is_reference_html_file method.
1272
1273 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1274
1275         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
1276
1277         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1278         (NewCommitBot.next_work_item):
1279
1280 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1281
1282         WKR and webkitbot build fixes.
1283
1284         * Scripts/webkitpy/tool/bot/irc_command.py:
1285         (RollChromiumDEPS.execute):
1286         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1287         (NewCommitBot.next_work_item):
1288
1289 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1290
1291         roll-chromium-deps doesn't repeat the full name.
1292
1293         Rubber-stamped by Andreas Kling.
1294
1295         * Scripts/webkitpy/tool/bot/irc_command.py:
1296         (RollChromiumDEPS.execute):
1297
1298 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1299
1300         Revert another erroneous change.
1301
1302         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1303         (NewCommitBot.next_work_item):
1304
1305 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1306
1307         Revert an erroneous change.
1308
1309         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1310         (SheriffBot):
1311
1312 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1313
1314         Some build fixes for WKR and webkitbot.
1315
1316         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1317         (IRCBotTest.test_help):
1318         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1319         (Agent):
1320         (Agent.__init__):
1321         (Agent.name):
1322         (NewCommitBot):
1323         (NewCommitBot.begin_work_queue):
1324         (NewCommitBot.next_work_item):
1325         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1326         (SheriffBot):
1327
1328 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1329
1330         Teach webkitbot and WKR how to respond to yt?
1331         https://bugs.webkit.org/show_bug.cgi?id=116775
1332
1333         Reviewed by Andreas Kling.
1334
1335         * Scripts/webkitpy/tool/bot/irc_command.py:
1336         (Hi): Fixed the usage string.
1337         (Hi.execute): Made it more generic so that it works in WKR.
1338         (YouThere): Added.
1339         (YouThere.execute): Added.
1340         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1341
1342 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1343
1344         Try to fix the EFL build.
1345         
1346         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1347         (TestRunner::setPageVisibility):
1348
1349 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1350
1351         Unprefix Page Visibility API
1352         https://bugs.webkit.org/show_bug.cgi?id=102340
1353
1354         Reviewed by Tim Horton.
1355         
1356         Rename "preview" state to "unloaded" state, and adjust the tests
1357         to test for it.
1358
1359         * DumpRenderTree/mac/TestRunnerMac.mm:
1360         (TestRunner::setPageVisibility):
1361         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
1362         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1363         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1364         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
1365         (TestWebKitAPI::didRunStep4InStateUnloaded):
1366         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
1367         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1368         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1370         (WTR::TestRunner::setPageVisibility):
1371
1372 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1373
1374         Unreviewed build fix. Don't use new NRWT logic needed
1375         by Windows yet. Activate (and fix test) when we cut over.
1376
1377         * Scripts/webkitpy/port/driver.py:
1378         (Driver._setup_environ_for_driver):
1379         (Driver._start):
1380
1381 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1382
1383         [Windows] Expose database storage and cache locations via preferences.
1384         https://bugs.webkit.org/show_bug.cgi?id=116729
1385
1386         Reviewed by Tim Horton.
1387
1388         Update DumpRenderTree to use CFPreferences to control where WebKit
1389         stores its local databases, URL caches, etc.
1390
1391         * DumpRenderTree/win/DumpRenderTree.cpp:
1392         (libraryPathForDumpRenderTree): Added.
1393         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
1394         * Scripts/webkitpy/port/base.py:
1395         (Port._driver_tempdir): Added (to allow port-specific overload).
1396         (Port._driver_tempdir_for_environment): Ditto
1397         * Scripts/webkitpy/port/driver.py:
1398         (Driver._setup_environ_for_driver): Use new overload to set
1399         environment variable.
1400         (Driver._start): Use new overload for temp directory location.
1401         * Scripts/webkitpy/port/win.py:
1402         (WinPort._driver_tempdir_for_environment): New overload to supply
1403         Windows path to DumpRenderTree environment (while still using
1404         cygwin paths for internal operations.
1405
1406 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1407
1408         Remove custom code for webkitAudioContext global constructor getter
1409         https://bugs.webkit.org/show_bug.cgi?id=116530
1410
1411         Reviewed by Geoffrey Garen.
1412
1413         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
1414         WebAudio feature instead of public ewk_view API since that API was
1415         removed.
1416
1417         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1418         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1419         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1420         (TestRunner::overridePreference):
1421
1422 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
1423
1424         Make team.html have each contributor's area of expertise
1425         https://bugs.webkit.org/show_bug.cgi?id=116737
1426
1427         Reviewed by Benjamin Poulain.
1428
1429         * Scripts/webkitpy/common/config/contributors.json:
1430         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
1431         
1432         Changed formatting of the file because the lines are getting way to
1433         long, and I generated this, so it's easier if the formatting of the
1434         file is regular.
1435
1436 2013-05-24  Simon Pena  <simon.pena@samsung.com>
1437
1438         Update WTF::Vector pretty printers
1439         https://bugs.webkit.org/show_bug.cgi?id=116719
1440
1441         Reviewed by Anders Carlsson.
1442
1443         After r148891, WTF::Vector pretty printers were left outdated, as
1444         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
1445         one as a member. This patch updates the pretty printers so they work
1446         again. 
1447
1448         * gdb/webkit.py:
1449         (WTFVectorPrinter.children):
1450         (WTFVectorPrinter.to_string):
1451
1452 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
1453
1454         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
1455         https://bugs.webkit.org/show_bug.cgi?id=116710
1456
1457         Reviewed by Mark Rowe.
1458
1459         * DumpRenderTree/mac/DumpRenderTree.mm:
1460         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
1461
1462 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
1463
1464         Add missing dependencies to deps script.
1465
1466         [GTK] Missing packages in install-dependencies script.
1467         https://bugs.webkit.org/show_bug.cgi?id=116632
1468
1469         Reviewed by Martin Robinson.
1470
1471         * gtk/install-dependencies:
1472
1473 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1474
1475         [Windows] Unreviewed change for NRWT support.
1476
1477         * Scripts/webkitpy/port/win.py:
1478         (WinPort.default_child_processes): Added a default implementation
1479         that limits NRWT to a single instance.
1480
1481 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1482
1483         Remove meaningless "test_uses_apache" from Python test cases.
1484         https://bugs.webkit.org/show_bug.cgi?id=38756
1485
1486         Reviewed by Ryosuke Niwa.
1487
1488         * Scripts/webkitpy/port/port_testcase.py:
1489         (PortTestCase.test_driver_cmd_line): Remove the meaningless
1490         "test_uses_apache" test case from the Python test infrastructure.
1491         It was hard-coded to true, even though not all ports use
1492         Apache.
1493
1494 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
1495
1496         [Windows] Update new-run-webkit-tests for Windows port.
1497         https://bugs.webkit.org/show_bug.cgi?id=38756
1498
1499         Reviewed by Ryosuke Niwa.
1500
1501         * Scripts/new-run-webkit-httpd:
1502         (run): Switch from 'chromium' to 'win'
1503         * Scripts/webkitpy/port/win.py:
1504         (WinPort): Add support methods for lighttpd server.
1505         (WinPort._uses_apache):
1506         (WinPort._path_to_lighttpd):
1507         (WinPort._path_to_lighttpd_modules):
1508         (WinPort._path_to_lighttpd_php):
1509
1510 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
1511
1512         Make default bug links in buildbot clickable
1513         https://bugs.webkit.org/show_bug.cgi?id=116673
1514
1515         Reviewed by Ryosuke Niwa.
1516
1517         Use changecommentlink of html.WebStatus to make the links clickable.
1518
1519         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1520
1521 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
1522
1523         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
1524         https://bugs.webkit.org/show_bug.cgi?id=116595
1525
1526         Temporarily skip this test.
1527
1528         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1529         (TestWebKitAPI::TEST):
1530
1531 2013-05-22  Alex Christensen  <achristensen@apple.com>
1532
1533         Unreviewed.  Added myself to contributors.json.
1534
1535         * Scripts/webkitpy/common/config/contributors.json:
1536         Added myself.
1537
1538 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1539
1540         [EFL][WK2] Add sub menus to MiniBrowser
1541         https://bugs.webkit.org/show_bug.cgi?id=114728
1542
1543         Reviewed by Christophe Dumez.
1544
1545         Elementary Ctxpopup widget API does not provide support for submenu item.
1546         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
1547         Elementary Menu widget.
1548
1549         * MiniBrowser/efl/main.c:
1550         (_Browser_Window):
1551         (on_window_resize):
1552         (window_free):
1553         (context_menu_item_selected_cb):
1554         (context_menu_populate):
1555         (on_context_menu_show):
1556         (on_context_menu_hide):
1557         (window_create):
1558
1559 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
1560
1561         [EFL] Add command line option to MiniBrowser to set cookies policy.
1562         https://bugs.webkit.org/show_bug.cgi?id=115028
1563
1564         Reviewed by Christophe Dumez.
1565
1566         Add command line option to MiniBrowser EFL to set cookies policy:
1567         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
1568         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
1569
1570         * MiniBrowser/efl/main.c:
1571         (elm_main):
1572
1573 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1574
1575         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
1576         https://bugs.webkit.org/show_bug.cgi?id=116585
1577
1578         Reviewed by Alexey Proskuryakov.
1579
1580         willLoadURLRequest and willLoadDataRequest require the API version 6.
1581
1582         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1583
1584 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1585
1586         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
1587         https://bugs.webkit.org/show_bug.cgi?id=116516
1588
1589         Reviewed by Alexey Proskuryakov.
1590
1591         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
1592
1593         * DumpRenderTree/mac/DumpRenderTree.mm:
1594         (createWebViewAndOffscreenWindow): Match the ordering.
1595         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
1596
1597 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
1598
1599         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
1600         https://bugs.webkit.org/show_bug.cgi?id=116568
1601
1602         Reviewed by Anders Carlsson.
1603
1604         * WebKitTestRunner/WebNotificationProvider.cpp:
1605         (WTR::WebNotificationProvider::~WebNotificationProvider):
1606         * WebKitTestRunner/WebNotificationProvider.h:
1607         When the provider is destroyed, it should no longer be registered with the manager.
1608
1609         * WebKitTestRunner/GeolocationProviderMock.cpp:
1610         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
1611         * WebKitTestRunner/GeolocationProviderMock.h:
1612         I wasn't seeing a crash here, but this code has the same issue as notification
1613         provider, so applying the same fix.
1614
1615         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1616         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
1617         destructor having fixed the above.
1618
1619 2013-05-21  Commit Queue  <commit-queue@webkit.org>
1620
1621         Unreviewed, rolling out r150386 and r150397.
1622         http://trac.webkit.org/changeset/150386
1623         http://trac.webkit.org/changeset/150397
1624         https://bugs.webkit.org/show_bug.cgi?id=116572
1625
1626         Broke a test; Alex is going to try again later. (Requested by
1627         thorton on #webkit).
1628
1629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1630         (WTR::pathSuitableForTestResult):
1631         (WTR::dumpRequestDescriptionSuitableForTestResult):
1632         (WTR::dumpResponseDescriptionSuitableForTestResult):
1633         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1634         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1635         (WTR::InjectedBundlePage::willSendRequestForFrame):
1636         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1637         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1638         (InjectedBundlePage):
1639
1640 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1641
1642         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
1643
1644         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1645         (AbstractCommitLogCommand._recent_commit_messages):
1646
1647 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
1648
1649         [GTK] [CMake] Add support for building WebKit2
1650         https://bugs.webkit.org/show_bug.cgi?id=116372
1651
1652         Reviewed by Gustavo Noronha Silva.
1653
1654         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
1655         * MiniBrowser/gtk/CMakeLists.txt: Added.
1656
1657 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1658
1659         Revert r149635, it was too optimistic.
1660
1661         Rubber-stamped by Andreas Kling.
1662
1663         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
1664         #ifdefs in WebCore code outside of WebCore/platform.
1665
1666         * Scripts/webkitpy/style/checkers/cpp.py:
1667         (check_invalid_increment):
1668         (process_line):
1669         (CppChecker):
1670         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1671         (CppStyleTest.test_plain_integral_bitfields):
1672
1673 2013-05-21  Jer Noble  <jer.noble@apple.com>
1674
1675         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
1676
1677         * lldb/lldb_webkit.py:
1678         (WTFVectorProvider.num_children):
1679         (WTFVectorProvider.get_child_index):
1680         (WTFVectorProvider.get_child_at_index):
1681         (WTFVectorProvider.update):
1682
1683 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1684
1685         Expose a way to know when forms are added to a page or when form controls are added to a form
1686         in the injected bundle
1687         https://bugs.webkit.org/show_bug.cgi?id=116334
1688
1689         Reviewed by Alexey Proskuryakov.
1690
1691         Add tests for the new callbacks.
1692
1693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1694         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1695
1696         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1697         (TestWebKitAPI::nullJavaScriptCallback):
1698         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1699         being passed in for the callback.
1700         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1701         After receiving the message that didAssociateFormControls callback was invoked from adding
1702         the form in the onload handler, tell the page to add a password field to the form, which
1703         should also invoke didAssociateFormControls callback.
1704         (TestWebKitAPI::setInjectedBundleClient):
1705         Register to receive messages.
1706         (TestWebKitAPI::TEST):
1707         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1708         been invoked for both adding the form and for adding a password field to the form.
1709
1710         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1711         (TestWebKitAPI::shouldNotifyOnFormChanges):
1712         Return true so the didAssociateFormControls callback is invoked.
1713         (TestWebKitAPI::didAssociateFormControls):
1714         Tell the UI process.
1715         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1716         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1717         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1718
1719         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1720         Add a form in response to the onload event. Add a button that will add the password field
1721         for manual testing.
1722
1723 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1724
1725         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
1726         https://bugs.webkit.org/show_bug.cgi?id=106341
1727
1728         Reviewed by Martin Robinson.
1729
1730         Adds support for retrieving accessibility element at exact point.
1731
1732         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1733         (WTR::AccessibilityUIElement::elementAtPoint):
1734
1735 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1736
1737         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
1738         https://bugs.webkit.org/show_bug.cgi?id=112913
1739
1740         Reviewed by Martin Robinson.
1741
1742         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
1743         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
1744         so the leak appears.
1745
1746         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1747         (WTR):
1748         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1749         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1750         (WTR::AccessibilityController::rootElement):
1751         (WTR):
1752         (WTR::AccessibilityController::focusedElement):
1753         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1754         (WTR::checkElementState):
1755         (WTR::indexRangeInTable):
1756         (WTR::alterCurrentValue):
1757         (WTR::AccessibilityUIElement::getChildren):
1758         (WTR::AccessibilityUIElement::getChildrenWithRange):
1759         (WTR::AccessibilityUIElement::childrenCount):
1760         (WTR::AccessibilityUIElement::indexOfChild):
1761         (WTR::AccessibilityUIElement::titleUIElement):
1762         (WTR::AccessibilityUIElement::parentElement):
1763         (WTR::AccessibilityUIElement::allAttributes):
1764         (WTR::AccessibilityUIElement::role):
1765         (WTR::AccessibilityUIElement::title):
1766         (WTR::AccessibilityUIElement::description):
1767         (WTR::AccessibilityUIElement::orientation):
1768         (WTR::AccessibilityUIElement::stringValue):
1769         (WTR::AccessibilityUIElement::language):
1770         (WTR::AccessibilityUIElement::x):
1771         (WTR::AccessibilityUIElement::y):
1772         (WTR::AccessibilityUIElement::width):
1773         (WTR::AccessibilityUIElement::height):
1774         (WTR::AccessibilityUIElement::intValue):
1775         (WTR::AccessibilityUIElement::minValue):
1776         (WTR::AccessibilityUIElement::maxValue):
1777         (WTR::AccessibilityUIElement::isEnabled):
1778         (WTR::AccessibilityUIElement::isFocused):
1779         (WTR::AccessibilityUIElement::isSelected):
1780         (WTR::AccessibilityUIElement::isExpanded):
1781         (WTR::AccessibilityUIElement::isChecked):
1782         (WTR::AccessibilityUIElement::rowCount):
1783         (WTR::AccessibilityUIElement::columnCount):
1784         (WTR::AccessibilityUIElement::rowIndexRange):
1785         (WTR::AccessibilityUIElement::columnIndexRange):
1786         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1787         (WTR::AccessibilityUIElement::increment):
1788         (WTR::AccessibilityUIElement::decrement):
1789         (WTR::AccessibilityUIElement::press):
1790         (WTR::AccessibilityUIElement::documentEncoding):
1791         (WTR::AccessibilityUIElement::documentURI):
1792         (WTR::AccessibilityUIElement::isFocusable):
1793         (WTR::AccessibilityUIElement::isSelectable):
1794         (WTR::AccessibilityUIElement::isMultiSelectable):
1795         (WTR::AccessibilityUIElement::isVisible):
1796
1797 2013-05-20  Lucas Forschler  <lforschler@apple.com>
1798
1799     Rollout 150398.
1800     
1801 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1802
1803         [GTK] Fix concatenations of string literals that are not C++11-compliant
1804         https://bugs.webkit.org/show_bug.cgi?id=116449
1805
1806         Reviewed by Martin Robinson.
1807
1808         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
1809         is simply a matter of separating the string and the string literal that are being concatenated with a space.
1810
1811         * ImageDiff/gtk/ImageDiff.cpp:
1812         (printImage):
1813
1814 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1815
1816         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
1817         https://bugs.webkit.org/show_bug.cgi?id=116450
1818
1819         Reviewed by Martin Robinson.
1820
1821         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
1822         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
1823         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
1824         TestWebKitAPI programs when compiling them.
1825
1826         * TestWebKitAPI/GNUmakefile.am:
1827
1828 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1829
1830         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
1831         https://bugs.webkit.org/show_bug.cgi?id=116492
1832
1833         Reviewed by Dirk Pranke.
1834
1835         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
1836
1837         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
1838         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
1839         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
1840         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
1841         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
1842         to memory pressure on the machine.
1843
1844         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
1845         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
1846         for a subsequent patch just to make things easier to follow.
1847
1848         * Scripts/webkitpy/port/driver.py:
1849         (DriverProxy.__init__):
1850         (DriverProxy.run_test):
1851         (DriverProxy.has_crashed):
1852         (DriverProxy.stop):
1853
1854 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1855
1856         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
1857         https://bugs.webkit.org/show_bug.cgi?id=116423
1858
1859         Reviewed by Ryosuke Niwa.
1860
1861         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
1862
1863         * BuildSlaveSupport/build.webkit.org-config/config.json:
1864
1865 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
1866
1867         Remove remaining link-prerender code
1868         https://bugs.webkit.org/show_bug.cgi?id=116429
1869
1870         Reviewed by Darin Adler.
1871
1872         Link prerendering code was removed in r150356.
1873
1874         * Scripts/webkitperl/FeatureList.pm:
1875         * qmake/mkspecs/features/features.pri:
1876
1877 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1878
1879         commit-queue should check for oops in changelog entries
1880         https://bugs.webkit.org/show_bug.cgi?id=116395
1881
1882         Reviewed by Martin Robinson.
1883
1884         Make changelog validation fail when it contains oops!.
1885
1886         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1887         (CommitQueueTask._validate_changelog):
1888         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1889         (CommitQueueTaskTest._run_through_task):
1890         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1891         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1892         (ValidateChangeLogs.options):
1893         (ValidateChangeLogs._check_changelog_diff):
1894         (ValidateChangeLogs._changelog_contains_oops):
1895         (ValidateChangeLogs.run):
1896         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1897         (ValidateChangeLogsTest._assert_start_line_produces_output):
1898         (ValidateChangeLogsTest.test_check_changelog_diff):
1899         (ValidateChangeLogsTest):
1900         (ValidateChangeLogsTest.test_changelog_contains_oops):
1901
1902 2013-05-20  Jessie Berlin  <jberlin@apple.com>
1903
1904         Expose a way to know when forms are added to a page or when form controls are added to a form
1905         in the injected bundle
1906         https://bugs.webkit.org/show_bug.cgi?id=116334
1907
1908         Reviewed by Alexey Proskuryakov.
1909
1910         Add tests for the new callbacks.
1911
1912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1913         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1914
1915         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1916         (TestWebKitAPI::nullJavaScriptCallback):
1917         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1918         being passed in for the callback.
1919         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1920         After receiving the message that didAssociateFormControls callback was invoked from adding
1921         the form in the onload handler, tell the page to add a password field to the form, which
1922         should also invoke didAssociateFormControls callback.
1923         (TestWebKitAPI::setInjectedBundleClient):
1924         Register to receive messages.
1925         (TestWebKitAPI::TEST):
1926         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1927         been invoked for both adding the form and for adding a password field to the form.
1928
1929         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1930         (TestWebKitAPI::shouldNotifyOnFormChanges):
1931         Return true so the didAssociateFormControls callback is invoked.
1932         (TestWebKitAPI::didAssociateFormControls):
1933         Tell the UI process.
1934         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1935         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1936         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1937
1938         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1939         Add a form in response to the onload event. Add a button that will add the password field
1940         for manual testing.
1941
1942 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1943
1944         [EFL][JHBUILD] Make sure eet is built before evas
1945         https://bugs.webkit.org/show_bug.cgi?id=116440
1946
1947         Reviewed by Gyuyoung Kim.
1948
1949         Mark eet as a dependency of evas since evas requires eet to enable some of its
1950         functionality.
1951
1952         * efl/jhbuild.modules:
1953
1954 2013-05-20  Alex Christensen  <achristensen@apple.com>
1955
1956         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1957         https://bugs.webkit.org/show_bug.cgi?id=116125
1958
1959         Reviewed by Tim Horton.
1960
1961         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1962         (WTR::pathSuitableForTestResult):
1963         Changed string operations to match _drt_descriptionSuitableForTestResult.
1964         (WTR::dumpRequestDescriptionSuitableForTestResult):
1965         (WTR::dumpResponseDescriptionSuitableForTestResult):
1966         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1967         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1968         (WTR::InjectedBundlePage::willSendRequestForFrame):
1969         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1970         Pass the main frame's URL to pathSuitableForTestResult.
1971         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1972         Added WKBundlePageRef to willPerformClientRedirectForFrame.
1973
1974 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
1975
1976         fix w3c test importer unit tests after r150324
1977         https://bugs.webkit.org/show_bug.cgi?id=116459
1978
1979         Reviewed by Ryosuke Niwa.
1980
1981         This patch fixes the unit tests to not actually call out to
1982         'hg' (by using a mock executive) and also changes the real
1983         directory we crawl from Source/WebCore/css to
1984         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
1985         still change this to a mock filesystem, but that's a separate change.
1986
1987         * Scripts/webkitpy/w3c/test_importer.py:
1988         (main):
1989         (TestImporter.__init__):
1990         (TestImporter.load_changeset):
1991         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1992         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1993         (TestImporterTest.test_import_dir_with_no_tests):
1994
1995 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1996
1997         Unreviewed EFL build fix.
1998
1999         Fix linking errors due to undefined symbols on Ubuntu 13.04.
2000
2001         * DumpRenderTree/efl/CMakeLists.txt:
2002         * EWebLauncher/CMakeLists.txt:
2003         * MiniBrowser/efl/CMakeLists.txt:
2004
2005 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2006
2007         [EFL] Reenabled INDEXED_DATABASE after r150344
2008         https://bugs.webkit.org/show_bug.cgi?id=116430
2009
2010         Reviewed by Gyuyoung Kim.
2011
2012         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
2013         build was fixed in r150344.
2014
2015         * Scripts/webkitperl/FeatureList.pm:
2016
2017 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
2018
2019         [EFL] init/shutdown should be paired in EWebLauncher
2020         https://bugs.webkit.org/show_bug.cgi?id=116427
2021
2022         Reviewed by Christophe Dumez.
2023
2024         Added ecore_file_shutdown() for cleanup of ecore_file.
2025         Removed edje_init and ecore_evas_init because it was in ewk_init().
2026
2027         * EWebLauncher/main.c:
2028         (main):
2029
2030 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
2031
2032         [EFL] Add command line option to MiniBrowser to set user agent
2033         https://bugs.webkit.org/show_bug.cgi?id=116387
2034
2035         Reviewed by Christophe Dumez.
2036
2037         We need this option to compare the rendering differences according to different user agents.
2038
2039         * MiniBrowser/efl/main.c:
2040         (window_create):
2041         (elm_main):
2042
2043 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
2044
2045         Unreviewed, addressing test-webkitpy failures after r150317.
2046
2047         * Scripts/webkitpy/w3c/test_converter.py:
2048         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
2049
2050 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
2051
2052         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
2053         https://bugs.webkit.org/show_bug.cgi?id=114554
2054
2055         Reviewed by Gyuyoung Kim.
2056
2057         Using variables as target names is very uncommon in CMake.
2058         The usual way to specify the name of the resulting binary
2059         is to set the OUTPUT_NAME target property.
2060
2061         * DumpRenderTree/efl/CMakeLists.txt:
2062         * EWebLauncher/CMakeLists.txt:
2063         * ImageDiff/CMakeLists.txt:
2064         * MiniBrowser/efl/CMakeLists.txt:
2065         * TestWebKitAPI/CMakeLists.txt:
2066         * WebKitTestRunner/CMakeLists.txt:
2067         * WebKitTestRunner/PlatformEfl.cmake:
2068         * WinCELauncher/CMakeLists.txt:
2069
2070 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2071
2072         Unreviewed EFL build fix.
2073
2074         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
2075         WK2 build after r150305.
2076
2077         * Scripts/webkitperl/FeatureList.pm:
2078
2079 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
2080
2081         [GTK] Parallel build fails if gtk-doc is enabled
2082         https://bugs.webkit.org/show_bug.cgi?id=116227
2083
2084         Reviewed by Martin Robinson.
2085
2086         * GNUmakefile.am:
2087         Don't use the 'all' target to generate the documentation.
2088         The prerequisites of this target must be files that need to be
2089         built _before_ the actual compilation of WebKit starts. Since the
2090         documentation depends on WebKit being built first, this means in
2091         practice that the code will be built in parallel with the
2092         generation of its dependencies, potentially making the build fail.
2093
2094 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2095
2096         Don't run hg.
2097
2098         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2099         (TestImporterTest):
2100
2101 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
2102
2103         Create a script to import W3C tests
2104         https://bugs.webkit.org/show_bug.cgi?id=111513
2105
2106         Reviewed by Ryosuke Niwa.
2107
2108         This patch attempts to re-land the 'import-w3c-tests'
2109         script and accompanying modules.  The tests and code have
2110         been cleaned up so that we do not log anything to stdout/stderr
2111         while running the tests (thanks to outputcapture) and do not
2112         write into the source tree while running the tests, and much
2113         but not all of the code has been converted over to using the webkitpy
2114
2115         * Scripts/import-w3c-tests: Added.
2116         * Scripts/webkitpy/w3c/__init__.py: Added.
2117         * Scripts/webkitpy/w3c/test_converter.py: Added.
2118         (W3CTestConverter):
2119         (W3CTestConverter.__init__):
2120         (W3CTestConverter.path_from_webkit_root):
2121         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2122         (W3CTestConverter.convert_for_webkit):
2123         (W3CTestConverter.convert_css):
2124         (W3CTestConverter.convert_html):
2125         (W3CTestConverter.convert_testharness_paths):
2126         (W3CTestConverter.convert_prefixed_properties):
2127         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2128         (W3CTestConverter.replace_tag):
2129         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2130         (W3CTestConverterTest):
2131         (W3CTestConverterTest.fake_dir_path):
2132         (W3CTestConverterTest.test_read_prefixed_property_list):
2133         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
2134         (test_convert_for_webkit_harness_only):
2135         (test_convert_for_webkit_properties_only):
2136         (test_convert_for_webkit_harness_and_properties):
2137         (test_convert_test_harness_paths):
2138         (test_convert_prefixed_properties):
2139         (verify_conversion_happened):
2140         (verify_no_conversion_happened):
2141         (verify_test_harness_paths):
2142         (verify_prefixed_properties):
2143         (generate_test_content):
2144         * Scripts/webkitpy/w3c/test_importer.py: Added.
2145         (main):
2146         (parse_args):
2147         (validate_import_directory):
2148         (TestImporter):
2149         (TestImporter.__init__):
2150         (TestImporter.path_from_webkit_root):
2151         (TestImporter.do_import):
2152         (TestImporter.load_changeset):
2153         (TestImporter.find_importable_tests):
2154         (TestImporter.import_tests):
2155         (TestImporter.setup_destination_directory):
2156         (TestImporter.update_test_status):
2157         (TestImporter.remove_deleted_files):
2158         (TestImporter.write_import_log):
2159         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2160         (TestImporterTest):
2161         (TestImporterTest.test_import_dir_with_no_tests):
2162         * Scripts/webkitpy/w3c/test_parser.py: Added.
2163         (TestParser):
2164         (TestParser.__init__):
2165         (TestParser.load_file):
2166         (TestParser.analyze_test):
2167         (TestParser.reference_links_of_type):
2168         (TestParser.is_jstest):
2169         (TestParser.support_files):
2170         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2171         (TestParserTest):
2172         (TestParserTest.test_analyze_test_reftest_one_match):
2173         (test_analyze_test_reftest_multiple_matches):
2174         (test_analyze_test_reftest_match_and_mismatch):
2175         (test_analyze_test_reftest_with_ref_support_Files):
2176         (test_analyze_jstest):
2177         (test_analyze_pixel_test_all_true):
2178         (test_analyze_pixel_test_all_false):
2179         (test_analyze_non_html_file):
2180
2181 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2182
2183         Leaks builders exit early frequently
2184         https://bugs.webkit.org/show_bug.cgi?id=116355
2185
2186         Reviewed by Stephanie Lewis.
2187
2188         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
2189         we tolerate from 20 to 50.
2190
2191         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2192         (RunWebKitTests.start):
2193         * Scripts/webkitpy/port/mac.py:
2194         (MacPort.default_child_processes):
2195
2196 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
2197
2198         Remove chrome-channels command from the webkit-patch
2199         https://bugs.webkit.org/show_bug.cgi?id=116303
2200
2201         Reviewed by Ryosuke Niwa.
2202
2203         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
2204         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
2205         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
2206         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
2207         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
2208         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
2209
2210 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2211
2212         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
2213         Part 3 of 3: <http://webkit.org/b/116247>
2214
2215         Reviewed by Benjamin Poulain.
2216
2217         * Scripts/filter-build-webkit: Change while() loop to for() loop
2218         to track $previousLine, then pass $previousLine into
2219         shouldIgnoreLine().
2220         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
2221         line that begins with four spaces if the previous line is a
2222         linker error message.
2223         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2224         - Add "Ignored: " to test descriptions to document expected
2225           behavior.
2226         - Add comment blocks for various groups of tests.
2227         - Expand "Build settings" tests since we're changing the code in
2228           shouldIgnoreLine() that ignores those lines.
2229         - Add tests for undefined symbols error message.
2230         (description): Add.  Extract from global code.
2231
2232 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2233
2234         Add tests for shouldIgnoreLine() in filter-build-webkit
2235         Part 2 of 3: <http://webkit.org/b/116247>
2236
2237         Reviewed by Benjamin Poulain.
2238
2239         * Scripts/filter-build-webkit:
2240         (shouldIgnoreLine): Add.  Extract code from global scope into
2241         subroutine to make it testable.
2242         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
2243         Tests shouldIgnoreLine() using output from a real build
2244         transcript.
2245
2246 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2247
2248         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
2249         https://bugs.webkit.org/show_bug.cgi?id=116341
2250
2251         Reviewed by Brady Eidson.
2252
2253         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2254
2255 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
2256
2257         [Windows] Don't use pdevenv when building with VS2010.
2258         https://bugs.webkit.org/show_bug.cgi?id=116338.
2259
2260         Reviewed by Adam Roben.
2261
2262         * Scripts/webkitdirs.pm:
2263         (setupCygwinEnv): Check if we are using VS2005, and only use
2264         the 'pdevenv' hack if we are. Otherwise, just build with
2265         our standard project since it uses VS2010+'s native
2266         parallel building features.
2267
2268 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2269
2270         Unreviewed. Disable accelerated compositing until we figure out why it does not work
2271         properly in the 64 bits release bot.
2272
2273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2274         (resetDefaultsToConsistentValues):
2275
2276 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2277
2278         Make filter-build-webkit testable using LoadAsModule
2279         Part 1 of 3: <http://webkit.org/b/116247>
2280
2281         Reviewed by Benjamin Poulain.
2282
2283         * Scripts/filter-build-webkit: Change global variables that are
2284         used in subroutines from 'my' to 'our' to make it possible to
2285         evaluate the script in a package context in LoadAsModule.pm.
2286
2287 2013-05-14  Sam Weinig  <sam@webkit.org>
2288
2289         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
2290         https://bugs.webkit.org/show_bug.cgi?id=116132
2291
2292         Reviewed by Anders Carlsson.
2293
2294         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
2295         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
2296
2297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2298         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
2299         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
2300         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2301
2302 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
2303
2304         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
2305         https://bugs.webkit.org/show_bug.cgi?id=114781
2306
2307         Reviewed by Christophe Dumez.
2308
2309         Add run_before_unload_confirm and
2310         Print the log message with "CONFIRM NAVIGATION: " in console.
2311
2312         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2313         (onBeforeUnloadConfirm):
2314         (drtViewAdd):
2315
2316 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
2317
2318         Fix Analyze ChangeLog's entry processing
2319         https://bugs.webkit.org/show_bug.cgi?id=116219
2320
2321         Reviewed by Ryosuke Niwa.
2322
2323         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2324         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
2325
2326 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
2327
2328         [Qt] UrlLoader::loadNext is broken in MiniBrowser
2329         https://bugs.webkit.org/show_bug.cgi?id=116099
2330
2331         Reviewed by Jocelyn Turcotte.
2332
2333         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
2334         are not available any more. So, UrlLoader::loadNext was broken
2335         because it failed to connect to those signals.
2336
2337         * MiniBrowser/qt/UrlLoader.cpp:
2338         (UrlLoader::UrlLoader):
2339         (UrlLoader::loadingChanged):
2340         * MiniBrowser/qt/UrlLoader.h:
2341         (UrlLoader):
2342
2343 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
2344
2345         [WebSocket] Update pywebsocket to r760
2346         https://bugs.webkit.org/show_bug.cgi?id=115863
2347
2348         Reviewed by Alexey Proskuryakov.
2349
2350         Version r760 supports a newer draft of message compression.
2351         We need this update to finish the permessage compression patch in
2352         bug 98840. This patch also fixes failing unit tests after the update.
2353
2354         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
2355         (StreamBase._read):
2356         (StreamBase._read.of):
2357         (StreamBase._write):
2358         (StreamBase.receive_bytes):
2359         (StreamBase._read_until):
2360         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2361         (parse_frame):
2362         (StreamOptions.__init__):
2363         (Stream.__init__):
2364         (Stream._receive_frame_as_frame_object):
2365         (Stream._get_message_from_frame):
2366         (Stream._process_close_message):
2367         (Stream.close_connection):
2368         (Stream.get_last_received_opcode):
2369         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2370         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
2371         (Dispatcher.do_extra_handshake):
2372         (Dispatcher.transfer_data):
2373         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2374         (ExtensionProcessorInterface.__init__):
2375         (ExtensionProcessorInterface.request):
2376         (ExtensionProcessorInterface):
2377         (ExtensionProcessorInterface.name):
2378         (ExtensionProcessorInterface.check_consistency_with_other_processors):
2379         (ExtensionProcessorInterface.set_active):
2380         (ExtensionProcessorInterface.is_active):
2381         (ExtensionProcessorInterface._get_extension_response_internal):
2382         (ExtensionProcessorInterface.get_extension_response):
2383         (ExtensionProcessorInterface._setup_stream_options_internal):
2384         (ExtensionProcessorInterface.setup_stream_options):
2385         (_log_outgoing_compression_ratio):
2386         (_log_incoming_compression_ratio):
2387         (_parse_window_bits):
2388         (_AverageRatioCalculator):
2389         (_AverageRatioCalculator.__init__):
2390         (_AverageRatioCalculator.add_original_bytes):
2391         (_AverageRatioCalculator.add_result_bytes):
2392         (_AverageRatioCalculator.get_average_ratio):
2393         (DeflateFrameExtensionProcessor):
2394         (DeflateFrameExtensionProcessor.__init__):
2395         (DeflateFrameExtensionProcessor._get_extension_response_internal):
2396         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
2397         (DeflateFrameExtensionProcessor._outgoing_filter):
2398         (DeflateFrameExtensionProcessor._incoming_filter):
2399         (CompressionExtensionProcessorBase.for):
2400         (CompressionExtensionProcessorBase.__init__):
2401         (CompressionExtensionProcessorBase._get_extension_response_internal):
2402         (CompressionExtensionProcessorBase._setup_stream_options_internal):
2403         (PerFrameCompressExtensionProcessor):
2404         (PerMessageDeflateExtensionProcessor):
2405         (PerMessageDeflateExtensionProcessor.__init__):
2406         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
2407         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
2408         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
2409         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
2410         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
2411         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
2412         (PerMessageDeflateExtensionProcessor.set_bfinal):
2413         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
2414         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
2415         (_PerMessageDeflateFramer):
2416         (_PerMessageDeflateFramer.__init__):
2417         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
2418         (_PerMessageDeflateFramer._process_incoming_message):
2419         (_PerMessageDeflateFramer._process_outgoing_message):
2420         (_PerMessageDeflateFramer.setup_stream_options):
2421         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
2422         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
2423         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
2424         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
2425         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
2426         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
2427         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
2428         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
2429         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
2430         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
2431         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
2432         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
2433         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
2434         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
2435         (PerMessageCompressExtensionProcessor):
2436         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
2437         (MuxExtensionProcessor.__init__):
2438         (MuxExtensionProcessor.check_consistency_with_other_processors):
2439         (MuxExtensionProcessor):
2440         (MuxExtensionProcessor._get_extension_response_internal):
2441         (MuxExtensionProcessor._setup_stream_options_internal):
2442         (MuxExtensionProcessor.set_quota):
2443         (MuxExtensionProcessor.quota):
2444         (MuxExtensionProcessor.set_extensions):
2445         (MuxExtensionProcessor.extensions):
2446         (is_compression_extension):
2447         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2448         (validate_subprotocol):
2449         (parse_host_header):
2450         (format_header):
2451         (check_request_line):
2452         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2453         (Handshaker.do_handshake):
2454         (Handshaker._create_handshake_response):
2455         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
2456         (_validate_subprotocol):
2457         (_check_header_lines):
2458         (_build_location):
2459         (Handshaker.do_handshake):
2460         (Handshaker._set_subprotocol):
2461         (Handshaker._set_location):
2462         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
2463         (_create_dispatcher):
2464         (headerparserhandler):
2465         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
2466         (_create_add_channel_response):
2467         (_create_drop_channel):
2468         (_create_flow_control):
2469         (_create_new_channel_slot):
2470         (_create_fallback_new_channel_slot):
2471         (_MuxFramePayloadParser._read_number):
2472         (_MuxFramePayloadParser._read_size_and_contents):
2473         (_MuxFramePayloadParser._read_flow_control):
2474         (_MuxFramePayloadParser._read_new_channel_slot):
2475         (_LogicalConnection.__init__):
2476         (_LogicalConnection.write):
2477         (_LogicalConnection.on_write_data_done):
2478         (_LogicalConnection):
2479         (_LogicalConnection.on_writer_done):
2480         (_InnerMessage):
2481         (_InnerMessage.__init__):
2482         (_InnerMessageBuilder):
2483         (_InnerMessageBuilder.that):
2484         (_InnerMessageBuilder.__init__):
2485         (_InnerMessageBuilder._handle_first):
2486         (_InnerMessageBuilder._process_first_fragmented_control):
2487         (_InnerMessageBuilder._process_first_fragmented_message):
2488         (_InnerMessageBuilder._handle_fragmented_control):
2489         (_InnerMessageBuilder._reassemble_fragmented_control):
2490         (_InnerMessageBuilder._handle_fragmented_message):
2491         (_InnerMessageBuilder._reassemble_fragmented_message):
2492         (_InnerMessageBuilder.build):
2493         (_LogicalStream.__init__):
2494         (_LogicalStream._create_inner_frame):
2495         (_LogicalStream._write_inner_frame):
2496         (_LogicalStream.replenish_send_quota):
2497         (_LogicalStream.send_message):
2498         (_LogicalStream._receive_frame):
2499         (_LogicalStream._get_message_from_frame):
2500         (_LogicalStream.stop_sending):
2501         (_PhysicalConnectionWriter.__init__):
2502         (_PhysicalConnectionWriter._write_data):
2503         (_PhysicalConnectionWriter.run):
2504         (_PhysicalConnectionWriter.stop):
2505         (_Worker.run):
2506         (_MuxHandshaker.__init__):
2507         (_MuxHandshaker._create_stream):
2508         (_MuxHandshaker._create_handshake_response):
2509         (_HandshakeDeltaBase.create_headers):
2510         (_MuxHandler.start):
2511         (_MuxHandler.wait_until_done):
2512         (_MuxHandler.notify_write_data_done):
2513         (_MuxHandler._process_drop_channel):
2514         (_MuxHandler._process_logical_frame):
2515         (_MuxHandler.notify_reader_done):
2516         (_MuxHandler):
2517         (_MuxHandler.notify_writer_done):
2518         (_MuxHandler.fail_physical_connection):
2519         (_MuxHandler.fail_logical_channel):
2520         (use_mux):
2521         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2522         (_StandaloneRequest.get_uri):
2523         (_StandaloneRequest.get_unparsed_uri):
2524         (_StandaloneRequest):
2525         (_StandaloneRequest.is_https):
2526         (_import_ssl):
2527         (_import_pyopenssl):
2528         (_StandaloneSSLConnection.for):
2529         (_StandaloneSSLConnection):
2530         (_StandaloneSSLConnection.__getattribute__):
2531         (_StandaloneSSLConnection.__setattr__):
2532         (_StandaloneSSLConnection.makefile):
2533         (_StandaloneSSLConnection.shutdown):
2534         (_StandaloneSSLConnection.recv):
2535         (WebSocketServer.__init__):
2536         (WebSocketServer._create_sockets):
2537         (WebSocketServer.handle_error):
2538         (WebSocketServer.get_request):
2539         (WebSocketServer.get_request.default_callback):
2540         (WebSocketRequestHandler.parse_request):
2541         (_build_option_parser):
2542         (_main):
2543         (_main.if):
2544         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2545         (RepeatedXorMasker.__init__):
2546         (RepeatedXorMasker._mask_using_swig):
2547         (RepeatedXorMasker):
2548         (RepeatedXorMasker._mask_using_array):
2549         (_Deflater.compress_and_finish):
2550         (_RFC1979Deflater.filter):
2551         (DeflateSocket.send):
2552
2553 2013-05-16  Jonathan Liu  <net147@gmail.com>
2554
2555         Fix testing if program exists in PATH
2556         https://bugs.webkit.org/show_bug.cgi?id=116216
2557
2558         Reviewed by Jocelyn Turcotte.
2559
2560         functions.prf incorrectly uses win_cmd_shell to test whether to
2561         add .exe to the executable name when checking if it exists in
2562         the PATH environment variable. This works correctly when
2563         building using Windows Command Prompt but not under MSYS shell.
2564
2565         To resolve this, check the win32 platform scope instead of
2566         win_cmd_shell so that it correctly adds .exe to the executable
2567         name on Windows regardless of the shell used when testing if
2568         it exists in PATH.
2569
2570         * qmake/mkspecs/features/functions.prf:
2571
2572 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
2573
2574         Fix the hard-coded names of EWS bots that run tests.
2575
2576         * Scripts/webkitpy/tool/commands/queues.py:
2577         (CommitQueue.did_pass_testing_ews):
2578
2579 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2580
2581         [GTK] Build Xvfb with jhbuild
2582         https://bugs.webkit.org/show_bug.cgi?id=115907
2583
2584         Reviewed by Martin Robinson.
2585
2586         Build our own Xvfb so that we can avoid problems with the system Xvfb
2587         relying on symbols not present in our jhbuilt libraries such as pixman,
2588         and also to ensure we have the fix for a GLX module crasher.
2589
2590         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2591         (resetDefaultsToConsistentValues): enable accelerated compositing.
2592         * gtk/install-dependencies: list packages required for building Xvfb.
2593         * gtk/jhbuild.modules: add xserver as a jhbuild module.
2594         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
2595         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
2596         initializing the GLX module for Xvfb.
2597
2598 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2599
2600         [jhbuild] Should remove the sources directory as well when cleaning
2601         https://bugs.webkit.org/show_bug.cgi?id=116229
2602
2603         Reviewed by Martin Robinson.
2604
2605         * Scripts/update-webkit-libs-jhbuild:
2606         (cleanJhbuild): remove the Source directory as well when cleaning.
2607
2608 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2609
2610         [EFL] Remove Intel Wk2 Buildbots from Master
2611         https://bugs.webkit.org/show_bug.cgi?id=116149
2612
2613         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
2614         since Gyuyoung Kim from Samsung plans to take over and maintain it.
2615
2616         Reviewed by Benjamin Poulain.
2617
2618         * BuildSlaveSupport/build.webkit.org-config/config.json:
2619
2620 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
2621
2622         [Windows] Update various build tools to understand VS2010 environment.
2623         https://bugs.webkit.org/show_bug.cgi?id=116169.
2624
2625         Reviewed by Anders Carlsson.
2626
2627         * Scripts/build-api-tests: Identify VS2010 environment.
2628         * Scripts/build-dumprendertree: Ditto.
2629         * Scripts/build-webkit: Ditto.
2630         * Scripts/webkitdirs.pm:
2631         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
2632         range of acceptable SDK's.
2633
2634 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2635
2636         Allow http tests on Arch Linux
2637         https://bugs.webkit.org/show_bug.cgi?id=116155
2638
2639         Reviewed by Ryosuke Niwa.
2640
2641         * Scripts/webkitpy/port/base.py:
2642         (Port._is_arch_based): Added check for /etc/arch-release file.
2643         (Port._apache_config_file_name_for_platform): Call the check.
2644         * Scripts/webkitpy/port/port_testcase.py:
2645         (test_linux_distro_detection): Testcase added.
2646
2647 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2648
2649         Remove a leftover v8 file from the watchlist
2650         https://bugs.webkit.org/show_bug.cgi?id=116158
2651
2652         Reviewed by Csaba Osztrogonác.
2653
2654         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2655
2656 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
2657
2658         [GTK] Fails to build while generating gtkdoc
2659         https://bugs.webkit.org/show_bug.cgi?id=115612
2660
2661         Reviewed by Philippe Normand.
2662
2663         Fix typo in the prerequisites of docs-build.stamp.
2664
2665         * GNUmakefile.am:
2666
2667 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
2668
2669         Unreviewed, fixing the current test-webkitpy failure.
2670
2671         * Scripts/webkitpy/port/mac_unittest.py:
2672         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
2673         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2674
2675 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
2676
2677         Fix build after r150090.
2678         https://bugs.webkit.org/show_bug.cgi?id=116129
2679
2680         Unreviewed build fix after r150090.
2681
2682         * WebKitTestRunner/TestInvocation.cpp:
2683         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2684
2685 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2686
2687         [Windows, others] Unreviewed build fix after r150090.
2688
2689         * DumpRenderTree/TestRunner.cpp:
2690         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
2691         doesn't exist on other platforms.
2692
2693 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
2694
2695         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
2696         https://bugs.webkit.org/show_bug.cgi?id=115889
2697
2698         Reviewed by Benjamin Poulain.
2699
2700         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2701         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2702
2703 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2704
2705         [Windows] Identify proper run environment for scripts.
2706         https://bugs.webkit.org/show_bug.cgi?id=116114
2707
2708         Reviewed by David Kilzer.
2709
2710         Determine (based on Visual Studio version) which path to use for
2711         executables (bin versus bin32).
2712
2713         * Scripts/webkitdirs.pm:
2714         (determineVisualStudioInstallDir): Added.
2715         (determineVisualStudioVersion): Added.
2716         (determineConfigurationProductDir): Modified to choose proper bin
2717         or bin32 directory.
2718         (visualStudioVersion): Added
2719         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2720
2721 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2722
2723         [Mac] Add tests for secure event input
2724         https://bugs.webkit.org/show_bug.cgi?id=116121
2725
2726         Reviewed by Mark Rowe.
2727
2728         * DumpRenderTree/TestRunner.cpp:
2729         (getSecureEventInputIsEnabledCallback):
2730         (TestRunner::staticValues):
2731         Expose an accessor for current secure event input state.
2732
2733         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2734         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2735         (WTR::TestRunner::secureEventInputIsEnabled):
2736         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2737         * WebKitTestRunner/TestInvocation.cpp:
2738         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2739         Expose an accessor for current secure event input state. This has to be done in
2740         UI process, as this is where it's changed by WebKit.
2741
2742 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2743
2744         [Mac] Add a testing shim for secure event input functions
2745         https://bugs.webkit.org/show_bug.cgi?id=116122
2746
2747         Reviewed by Mark Rowe.
2748
2749         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
2750         Inject WebCore testing shim library to override system framework functions.
2751
2752 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2753
2754         [Windows] Switch to embedded manifest commands for launcher executables.
2755         https://bugs.webkit.org/show_bug.cgi?id=116109
2756
2757         Reviewed by Darin Adler.
2758
2759         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
2760         now-unused WinLauncher.exe.manifest file.
2761         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2762         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
2763         when building with VS2010 or newer.
2764
2765 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2766
2767         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
2768         https://bugs.webkit.org/show_bug.cgi?id=116079
2769
2770         Reviewed by David Kilzer.
2771
2772         * Scripts/old-run-webkit-tests:
2773         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2774
2775 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
2776
2777         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
2778         https://bugs.webkit.org/show_bug.cgi?id=115921
2779
2780         Reviewed by Gustavo Noronha Silva.
2781
2782         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
2783         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2784
2785 2013-05-13  Alex Christensen  <achristensen@apple.com>
2786
2787         Added testRunner.setPrinting.
2788         https://bugs.webkit.org/show_bug.cgi?id=42693
2789         rdar://problem/8213845
2790
2791         Reviewed by Darin Adler.
2792
2793         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2794         Added setPrinting JavaScript function.
2795         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2796         (WTR::InjectedBundlePage::dump):
2797         Dump the external representation for printing if setPrinting has been called.
2798         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2799         (WTR::TestRunner::isPrinting): Added.
2800         (WTR::TestRunner::setPrinting): Added.
2801         Added and initialized m_isPrinting member boolean.
2802
2803 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
2804
2805         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
2806         https://bugs.webkit.org/show_bug.cgi?id=116016
2807
2808         Reviewed by Dirk Pranke.
2809
2810         Same fix as in the upstream style checker, but without hg support.
2811         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
2812
2813         * Scripts/webkitpy/style/checkers/cpp.py:
2814         (FileInfo.repository_name):
2815
2816 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
2817
2818         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
2819         https://bugs.webkit.org/show_bug.cgi?id=115918
2820
2821         Reviewed by Gustavo Noronha Silva.
2822
2823         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
2824         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
2825         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
2826         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
2827         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
2828         problems.
2829
2830         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
2831         These are then used as dependencies for the archive creation rule as well as the list from which the archive
2832         file paths are constructed and then used to dump the member files from these archives. The member files are
2833         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
2834         successfully link.
2835
2836         * TestWebKitAPI/GNUmakefile.am:
2837
2838 2013-05-13  Anders Carlsson  <andersca@apple.com>
2839
2840         Remove UnusedParam.h
2841         https://bugs.webkit.org/show_bug.cgi?id=116029
2842
2843         Reviewed by Andreas Kling.
2844
2845         Stop including UnusedParam.h.
2846
2847         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2848         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2849
2850 2013-05-12  Commit Queue  <commit-queue@webkit.org>
2851
2852         Unreviewed, rolling out r149955.
2853         http://trac.webkit.org/changeset/149955
2854         https://bugs.webkit.org/show_bug.cgi?id=115990
2855
2856         Broke lots of tests (Requested by smfr on #webkit).
2857
2858         * Scripts/webkitpy/port/mac.py:
2859
2860 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2861
2862         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
2863         https://bugs.webkit.org/show_bug.cgi?id=115914
2864
2865         Reviewed by Martin Robinson.
2866
2867         * GtkLauncher/main.c:
2868         (createToolbar):
2869         * MiniBrowser/gtk/BrowserWindow.c:
2870         (_BrowserWindow):
2871         (browserWindowSetStatusText):
2872         (fullScreenMessageTimeoutCallback):
2873         (webViewEnterFullScreen):
2874         (webViewLeaveFullScreen):
2875         (browserWindowFinalize):
2876         (browserWindowConstructed):
2877         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2878         (WTR::EventSenderProxy::mouseScrollBy):
2879         (WTR::EventSenderProxy::continuousMouseScrollBy):
2880
2881 2013-05-11  Anders Carlsson  <andersca@apple.com>
2882
2883         Crash when terminating a process that has not been fully launched
2884         https://bugs.webkit.org/show_bug.cgi?id=115962
2885         <rdar://problem/13660916>
2886
2887         Reviewed by Andreas Kling.
2888
2889         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
2890         before the process has had a chance to be fully launched.
2891
2892         * TestWebKitAPI/GNUmakefile.am:
2893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2894         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
2895         (TestWebKitAPI):
2896         (TestWebKitAPI::didFinishLoadForFrame):
2897         (TestWebKitAPI::TEST):
2898         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2899
2900 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
2901
2902         Remove Mac OS X Leopard (10.5) support
2903         https://bugs.webkit.org/show_bug.cgi?id=107964
2904
2905         Reviewed by Ryosuke Niwa.
2906
2907         Removed the code for 10.5 and removed if-def for 10.6.
2908
2909         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2910         (convertMIMEType):
2911         (createXMLStringFromWebArchiveData):
2912         * DumpRenderTree/mac/TestRunnerMac.mm:
2913         (TestRunner::authenticateSession):
2914         (TestRunner::setTextDirection):
2915         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2916         (convertMIMEType):
2917         (createXMLStringFromWebArchiveData):
2918
2919 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
2920
2921         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
2922         https://bugs.webkit.org/show_bug.cgi?id=115935
2923
2924         Reviewed by Jer Noble.
2925
2926         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
2927         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
2928         to the new manifest file.
2929         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2930
2931 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2932
2933         Fix some compiler warnings (miscellaneous)
2934         https://bugs.webkit.org/show_bug.cgi?id=80790
2935
2936         Reviewed by Rob Buis.
2937
2938         Fix the following warnings for BlackBerry:
2939         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
2940         used as truth value [-Wparentheses].
2941
2942         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2943         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2944
2945 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2946
2947         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
2948         https://bugs.webkit.org/show_bug.cgi?id=115928
2949
2950         Reviewed by Kenneth Rohde Christiansen.
2951
2952         WKViewSetThemePath was moved to WKViewEfl.h.
2953
2954         * TestWebKitAPI/efl/PlatformWebView.cpp:
2955
2956 2013-05-10  Andreas Kling  <akling@apple.com>
2957
2958         I accidentally the Java testing.
2959
2960         * Scripts/webkitpy/port/mac.py:
2961
2962 2013-05-10  Brian Holt  <brian.holt@samsung.com>
2963
2964         [GTK] Module Cairo fails to build under jhbuild
2965         https://bugs.webkit.org/show_bug.cgi?id=115854
2966
2967         Reviewed by Martin Robinson.
2968
2969         Make cairo depend on glib in jhbuild.modules.
2970
2971         * gtk/jhbuild.modules:
2972
2973 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2974
2975         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
2976         https://bugs.webkit.org/show_bug.cgi?id=115904
2977
2978         Reviewed by Martin Robinson.
2979
2980         * ImageDiff/gtk/ImageDiff.cpp:
2981         (main):
2982
2983 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
2984
2985         Add my new address to contributors.json. (Unreviewed)
2986
2987         * Scripts/webkitpy/common/config/contributors.json:
2988
2989 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2990
2991         Unreviewed. Move myself to the reviewers list.
2992
2993         * Scripts/webkitpy/common/config/contributors.json:
2994
2995 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2996
2997         Unreviewed. Add my email to a few watchlists.
2998
2999         * Scripts/webkitpy/common/config/watchlist:
3000
3001 2013-05-10  Simon Pena  <simon.pena@samsung.com>
3002
3003         Unicode support missing from string representation of Contributors in committers.py
3004         https://bugs.webkit.org/show_bug.cgi?id=115859
3005
3006         Reviewed by Darin Adler.
3007
3008         Contributors, in committers.py, provided a string representation in __str__ which
3009         didn't support unicode characters, so printing a contributor would fail in that case.
3010         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
3011         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
3012
3013         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
3014         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
3015         representation.
3016         (Contributor.__str__):
3017         (Contributor):
3018         (Contributor.__unicode__):
3019         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
3020         a contributor with unicode characters can be represented as a string.
3021         (CommittersTest):
3022         (CommittersTest.test_contributor_encoding):
3023
3024 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3025
3026         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
3027         https://bugs.webkit.org/show_bug.cgi?id=92371
3028
3029         Reviewed by Brent Fulgham.
3030
3031         Use JavaScriptThreading.cpp where the same functionality is
3032         implemented too. This reduces the dependency on the pthread
3033         library. Also replace assert() with WebKit ASSERT().
3034
3035         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3036         * DumpRenderTree/win/DumpRenderTree.cpp:
3037         (dumpHistoryItem):
3038         (dumpBackForwardList):
3039         * DumpRenderTree/win/DumpRenderTree.vcproj:
3040
3041 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3042
3043         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
3044         https://bugs.webkit.org/show_bug.cgi?id=92505
3045
3046         Reviewed by Brent Fulgham.
3047
3048         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3049         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
3050         (javaScriptThreadsMutex):
3051         (javaScriptThreads):
3052         (runJavaScriptThread):
3053         (startJavaScriptThreads):
3054         (stopJavaScriptThreads):
3055         * DumpRenderTree/pthreads: Removed.
3056         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
3057
3058 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3059
3060         Unreviewed. Update Simon Pena email on his behalf.
3061
3062         * Scripts/webkitpy/common/config/contributors.json:
3063
3064 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3065
3066         Add support for [NoInterfaceObject] Web IDL extended attribute
3067         https://bugs.webkit.org/show_bug.cgi?id=115714
3068
3069         Reviewed by Kentaro Hara.
3070
3071         Update BindingsTests.generate_supplemental_dependency() to pass an
3072         additional windowConstructorsFile argument to preprocess-idls.pl.
3073
3074         * Scripts/webkitpy/bindings/main.py:
3075         (BindingsTests.generate_supplemental_dependency):
3076         (BindingsTests.main):
3077
3078 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
3079
3080         [GTK][AC] Buildfix after r149694
3081         https://bugs.webkit.org/show_bug.cgi?id=115797
3082
3083         Reviewed by Gustavo Noronha Silva.
3084
3085         Add CLUTTER_LIBS for linking TestWebCore.
3086
3087         * TestWebKitAPI/GNUmakefile.am:
3088
3089 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3090
3091         [EFL] Remove unnecessary pkgs in EFL jhbuild
3092         https://bugs.webkit.org/show_bug.cgi?id=114908
3093
3094         Reviewed by Laszlo Gombos.
3095
3096         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
3097         handle them using jhbuild. We can reduce build time when using --update-efl.
3098
3099         * efl/jhbuild.modules:
3100
3101 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
3102
3103         [EFL] Disable SHADOW DOM feature in FeatureList.pm
3104         https://bugs.webkit.org/show_bug.cgi?id=115834
3105
3106         Reviewed by Gyuyoung Kim.
3107
3108         * Scripts/webkitperl/FeatureList.pm:
3109
3110 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3111
3112         Add Scheduler for Mac MtnLion 32bit Release builder.
3113         
3114         Unreviewed.
3115         
3116         * BuildSlaveSupport/build.webkit.org-config/config.json:
3117
3118 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
3119
3120         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
3121         https://bugs.webkit.org/show_bug.cgi?id=115808
3122
3123         Reviewed by Darin Adler.
3124
3125         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
3126         was left outdated after r127191, when the m_string member was changed
3127         from UString to String. This patch calls the right pretty printer for it.
3128
3129         * gdb/webkit.py:
3130         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
3131         WTFImplPrettyPrinter.
3132
3133 2013-05-08  Andy Estes  <aestes@apple.com>
3134
3135         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
3136         https://bugs.webkit.org/show_bug.cgi?id=115790
3137
3138         Reviewed by Alexey Proskuryakov.
3139
3140         Added two API tests:
3141
3142         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
3143         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
3144
3145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3146         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
3147         (TestWebKitAPI):
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
3150         (TestWebKitAPI):
3151         (TestWebKitAPI::decidePolicyForNavigationAction):
3152         (CustomProtocolInvalidSchemeTest):
3153         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
3154
3155 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3156
3157         Teach buildbot how to compile 32-bit on Mac.
3158
3159         Reviewed by Ryosuke Niwa.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3162         (CompileWebKit.start):
3163         (ExtractTestResultsAndLeaks):
3164
3165 2013-05-08  Eli Fidler  <efidler@blackberry.com>
3166
3167         [BlackBerry] Fix usage of BlackBerry::Platform::String
3168         https://bugs.webkit.org/show_bug.cgi?id=115781
3169
3170         Reviewed by Rob Buis.
3171
3172         BlackBerry PRs 304193 and 327181
3173         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
3174
3175         We currently have a problem where we're passing UTF-8 encoded data into
3176         the char* constructors of BlackBerry::Platform::String. This means the string
3177         thinks its data is not UTF-8.
3178
3179         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3180         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3181         (BlackBerry::WebKit::dumpHistoryItem):
3182         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3183         (TestRunner::setUserStyleSheetLocation):
3184         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3185         (LoadHTMLStringItem::invoke):
3186
3187 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
3188
3189         Tools: add new BlackBerry include dirs.
3190         https://bugs.webkit.org/show_bug.cgi?id=115514
3191
3192         Reviewed by Rob Buis.
3193
3194         iType include dirs are missing, and HarfBuzz needs to be fixed.
3195
3196         * Scripts/webkitdirs.pm:
3197         (blackberryCMakeArguments):
3198
3199 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3200
3201         [GTK] Plumb the Automake build system for the Battery Status API feature
3202         https://bugs.webkit.org/show_bug.cgi?id=115718
3203
3204         Reviewed by Martin Robinson.
3205
3206         * Scripts/webkitdirs.pm:
3207         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
3208         through the --(enable|disable)-battery-status flag passed to configure.
3209
3210 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
3211
3212         new-run-webkit-websocketserver doesn't work after Chromium removal
3213         https://bugs.webkit.org/show_bug.cgi?id=115816
3214
3215         Reviewed by Joseph Pecoraro.
3216
3217         Fix the bug by instantiating the correct port object.
3218
3219         * Scripts/new-run-webkit-websocketserver:
3220         (main):
3221
3222 2013-05-07  Lucas Forschler  <lforschler@apple.com>
3223
3224         Configure buildbot for 32bit builder.
3225         https://bugs.webkit.org/show_bug.cgi?id=115769
3226         
3227         Reviewed by Ryosuke Niwa.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/config.json:
3230
3231 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
3232
3233         Unreviewed. Update to show my apple.com address.
3234
3235         * Scripts/webkitpy/common/config/contributors.json: Added
3236         my apple.com e-mail address.
3237
3238 2013-05-08  David Kilzer  <ddkilzer@apple.com>
3239
3240         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
3241
3242         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3243         (concatenateAttributeAndValue): Switch to appendVector().
3244
3245 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3246
3247         [Qt][WTR] Fix the build on Mac after r149692
3248
3249         Unreviewed build fix.
3250
3251         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3252         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3253
3254 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
3255
3256         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
3257         to the watchlist for Accessibility.
3258
3259         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
3260         * Scripts/webkitpy/common/config/watchlist: Added myself.
3261
3262 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3263
3264         [Qt] Build fails with clang
3265         https://bugs.webkit.org/show_bug.cgi?id=115741
3266
3267         Reviewed by Benjamin Poulain.
3268
3269         Since r149112 std::move is used in AtomicString for compilers that
3270         support rvalue references and this requires a standard library
3271         implementing c++11 move semantics.
3272         We only explicitely require c++11 for WebKit2, but since clang supports
3273         rvalue references the build of subtargets using AtomicString fails because
3274         of missing std::move.
3275         It is safe to add CONFIG += c++11 for the whole project when using clang
3276         since we explicitely disable c++11 for ANGLE that had probems with libc++.
3277
3278         * qmake/mkspecs/features/unix/default_pre.prf:
3279
3280 2013-05-08  Darin Adler  <darin@apple.com>
3281
3282         Fix one more place that needed to use adoptCF/NS
3283         https://bugs.webkit.org/show_bug.cgi?id=115778
3284
3285         Reviewed by Benjamin Poulain.
3286
3287         Not sure why I missed this code last time, but found a bit more code that needs
3288         to switch to the newer style adoptCF/NS.
3289
3290         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3291         (convertWebResourceDataToString): Use adoptCF.
3292         (convertWebResourceResponseToDictionary): Ditto.
3293         (createXMLStringFromWebArchiveData): Ditto.
3294         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
3295         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
3296
3297 2013-05-08  Commit Queue  <commit-queue@webkit.org>
3298
3299         Unreviewed, rolling out r149271.
3300         http://trac.webkit.org/changeset/149271
3301         https://bugs.webkit.org/show_bug.cgi?id=115780
3302
3303         The mangled symbols are now enforced through LDFLAGS
3304         (Requested by zdobersek on #webkit).
3305
3306         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3307
3308 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
3309
3310         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
3311         https://bugs.webkit.org/show_bug.cgi?id=115636
3312
3313         Reviewed by Ryosuke Niwa.
3314
3315         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3316         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
3317         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
3318         while Chromium-specific, can't be removed just yet as there's more code that uses it.
3319
3320 2013-05-06  Darin Adler  <darin@apple.com>
3321
3322         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
3323         https://bugs.webkit.org/show_bug.cgi?id=115657
3324
3325         Reviewed by Sam Weinig.
3326
3327         This is similar to my last set of changes, but covers code that I missed with
3328         global replace using the Safari Xcode workspace.
3329
3330         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3331         (convertWebResourceDataToString):
3332         (convertWebResourceResponseToDictionary):
3333         (createXMLStringFromWebArchiveData):
3334         * DumpRenderTree/cg/ImageDiffCG.cpp:
3335         (createImageFromStdin):
3336         (createDifferenceImage):
3337         (main):
3338         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3339         (printPNG):
3340         (dumpBitmap):
3341         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3342         (BitmapContext::BitmapContext):
3343         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3344         (-[MockWebNotificationProvider init]):
3345         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3346         (createBitmapContext):
3347         * DumpRenderTree/mac/TestRunnerMac.mm:
3348         (TestRunner::addDisallowedURL):
3349         (TestRunner::applicationCacheDiskUsageForOrigin):
3350         (TestRunner::localStorageDiskUsageForOrigin):
3351         (TestRunner::clearApplicationCacheForOrigin):
3352         (TestRunner::deleteLocalStorageForOrigin):
3353         (TestRunner::copyDecodedHostName):
3354         (TestRunner::copyEncodedHostName):
3355         (TestRunner::queueLoad):
3356         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3357         (TestRunner::setMockGeolocationPositionUnavailableError):
3358         (TestRunner::setUserStyleSheetLocation):
3359         (TestRunner::setValueForUser):
3360         (TestRunner::overridePreference):
3361         (TestRunner::setPersistentUserStyleSheetLocation):
3362         (TestRunner::execCommand):
3363         (TestRunner::findString):
3364         (TestRunner::isCommandEnabled):
3365         (TestRunner::addOriginAccessWhitelistEntry):
3366         (TestRunner::removeOriginAccessWhitelistEntry):
3367         (TestRunner::addUserScript):
3368         (TestRunner::addUserStyleSheet):
3369         (TestRunner::evaluateInWebInspector):
3370         (TestRunner::evaluateScriptInIsolatedWorld):
3371         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3372         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3373         (TestRunner::authenticateSession):
3374         (TestRunner::grantWebNotificationPermission):
3375         (TestRunner::denyWebNotificationPermission):
3376         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3377         (createCFURLResponseFromResponseData):
3378         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3379         (LoadItem::invoke):
3380         (LoadHTMLStringItem::invoke):
3381         (ScriptItem::invoke):
3382         * DumpRenderTree/win/DumpRenderTree.cpp:
3383         (substringFromIndex):
3384         (urlSuitableForTestResult):
3385         (lastPathComponent):
3386         (sharedCFURLCache):
3387         * DumpRenderTree/win/ImageDiffCairo.cpp:
3388         (createImageFromStdin):
3389         (main):
3390         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3391         (createBitmapContextFromWebView):
3392         * DumpRenderTree/win/TestRunnerWin.cpp:
3393         (TestRunner::setUserStyleSheetLocation):
3394         (TestRunner::setPersistentUserStyleSheetLocation):
3395         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3396         (TestWebKitAPI::TEST):
3397         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
3398         (TestWebKitAPI::TEST):
3399         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3400         (TestWebKitAPI::TEST):
3401         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3402         (TestWebKitAPI::TEST):
3403         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3404         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3405         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3406         (TestWebKitAPI::createWindow):
3407         (TestWebKitAPI::TEST):
3408         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3409         (TestWebKitAPI::TEST):
3410         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3411         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3412         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3413         (TestWebKitAPI::TEST):
3414         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
3415         (TestWebKitAPI::TEST):
3416         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
3417         (TestWebKitAPI::TEST):
3418         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3419         (TestWebKitAPI::TEST):
3420         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
3421         (TestWebKitAPI::TEST):
3422         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3423         (TestWebKitAPI::TEST):
3424         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
3425         (TestWebKitAPI::TEST):
3426         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3427         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3428         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3429         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
3430         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3431         (TestWebKitAPI::TEST):
3432         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3435         (TestWebKitAPI::TEST):
3436         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
3437         (TestWebKitAPI::TEST):
3438         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3439         (TestWebKitAPI::TEST):
3440         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3441         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3442         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
3443         (TestWebKitAPI::TEST):
3444         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3445         (TestWebKitAPI::TEST):
3446         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3447         (TestWebKitAPI::TEST):
3448         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3449         (TestWebKitAPI::TEST):
3450         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
3451         (TestWebKitAPI::TEST):
3452         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3453         (TestWebKitAPI::TEST):
3454         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
3455         (TestWebKitAPI::TEST):
3456         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3457         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3458         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3459         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3460         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3461         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
3462         (WTR::testPathFromURL):
3463         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3464         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3465         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3466         (WTR::createCGContextFromImage):
3467         (WTR::dumpBitmap):
3468         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3469         * WebKitTestRunner/mac/EventSenderProxy.mm:
3470         (WTR::EventSenderProxy::mouseScrollBy):
3471         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3472         (WTR::PlatformWebView::windowSnapshotImage):
3473         * WebKitTestRunner/win/TestControllerWin.cpp:
3474         (WTR::TestController::initializeTestPluginDirectory):
3475         Use adoptCF and adoptNS.
3476
3477 2013-05-07  Alex Christensen  <achristensen@apple.com>
3478
3479         Fix a memory leak introduced in r149692
3480         https://bugs.webkit.org/show_bug.cgi?id=115766
3481
3482         Reviewed by Mark Rowe.
3483
3484         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
3485         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
3486
3487         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3488         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3489         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
3490
3491 2013-05-07  Darin Adler  <darin@apple.com>
3492
3493         [Win] Fix storage leak in Windows DumpRenderTree
3494         https://bugs.webkit.org/show_bug.cgi?id=115651
3495
3496         Reviewed by Sam Weinig.
3497
3498         * DumpRenderTree/win/DumpRenderTree.cpp:
3499         (lastPathComponent): Added a missing call to adoptCF.
3500
3501 2013-05-07  Alex Christensen  <achristensen@apple.com>
3502
3503         fixed a memory leak introduced by bug 42324 by using a RetainPtr
3504         https://bugs.webkit.org/show_bug.cgi?id=115760
3505
3506         Reviewed by Tim Horton.
3507
3508         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3509         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3510         fixed memory leak, added UNUSED_PARAM macros
3511
3512 2013-05-07  Alex Christensen  <achristensen@apple.com>
3513
3514         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
3515         https://bugs.webkit.org/show_bug.cgi?id=42324
3516         <rdar://problem/8193633>
3517
3518         Reviewed by Tim Horton.
3519
3520         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3521         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
3522         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3523         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3524         Added dumpDOMAsWebArchive code that is called when dumping.        
3525         (WTR::InjectedBundlePage::dump):
3526         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
3527         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3528         (InjectedBundlePage):
3529         Added dumpDOMAsWebArchive declaration.
3530         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
3531         (WTR::TestRunner::dumpDOMAsWebArchive):
3532         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
3533         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3534         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
3535         * Tools/WebKitTestRunner/cf: Added.
3536         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
3537         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
3538         (convertMIMEType):
3539         (convertWebResourceDataToString):
3540         (normalizeHTTPResponseHeaderFields):
3541         (normalizeWebResourceURL):
3542         (convertWebResourceResponseToDictionary):
3543         (compareResourceURLs):
3544         (createXMLStringFromWebArchiveData):
3545         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
3546         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
3547         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
3548         Copied from Tools/DumpRenderTree/mac for used functions.
3549         (createCFURLResponseFromResponseData):
3550         (supportedNonImageMIMETypes):
3551
3552 2013-05-07  Alex Christensen  <achristensen@apple.com>
3553
3554         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
3555         https://bugs.webkit.org/show_bug.cgi?id=115745
3556
3557         Reviewed by Tim Horton.
3558
3559         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3560         (compareResourceURLs):
3561         Updated style.
3562
3563 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
3564
3565         Add an 'isReadOnly' member to IDL parse tree structure
3566         https://bugs.webkit.org/show_bug.cgi?id=115704
3567
3568         Reviewed by Kentaro Hara.
3569
3570         Use newly added isReadOnly attribute.
3571
3572         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3573         (_generateHeaderFile):
3574         (_generateImplementationFile):
3575         (_staticValuesGetterImplementation):
3576
3577 2013-05-07  Anders Carlsson  <andersca@apple.com>
3578
3579         Remove AlwaysInline.h from WTF
3580         https://bugs.webkit.org/show_bug.cgi?id=115727
3581
3582         Reviewed by Brent Fulgham.
3583
3584         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
3585         to keep AlwaysInline.h around anymore.
3586
3587         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3588         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3589
3590 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
3591
3592         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
3593         https://bugs.webkit.org/show_bug.cgi?id=114808
3594
3595         Reviewed by Jocelyn Turcotte.
3596
3597         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
3598         (https://codereview.qt-project.org/#change,54234)
3599
3600         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3601         (WTR::WrapperWindow::handleStatusChanged):
3602
3603 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3604
3605         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
3606
3607         * Scripts/webkitpy/common/config/watchlist:
3608
3609 2013-05-06  Kangil Han  <kangil.han@samsung.com>
3610
3611         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
3612         https://bugs.webkit.org/show_bug.cgi?id=115645
3613
3614         Reviewed by Gyuyoung Kim.
3615
3616         To run performance tests in wk1, we need --no-timeout option implementation.
3617         So adopt it from gtk+ port.
3618
3619         * DumpRenderTree/efl/DumpRenderTree.cpp:
3620         (shouldSetWaitToDumpWatchdog):
3621         (parseCommandLineOptions):
3622         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
3623         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3624         (TestRunner::setWaitToDump):
3625
3626 2013-05-06  Commit Queue  <commit-queue@webkit.org>
3627
3628         Unreviewed, rolling out r149547.
3629         http://trac.webkit.org/changeset/149547
3630         https://bugs.webkit.org/show_bug.cgi?id=115682
3631
3632         Added unittests that fail on bots and spits out text into
3633         stdout (Requested by rniwa on #webkit).
3634
3635         * Scripts/import-w3c-tests: Removed.
3636         * Scripts/webkitpy/w3c/__init__.py: Removed.
3637         * Scripts/webkitpy/w3c/test_converter.py: Removed.
3638         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
3639         * Scripts/webkitpy/w3c/test_importer.py: Removed.
3640         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
3641         * Scripts/webkitpy/w3c/test_parser.py: Removed.
3642         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
3643
3644 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
3645
3646         [jhbuild] bump jhbuild version to take advantage of new improvements
3647         https://bugs.webkit.org/show_bug.cgi?id=115558
3648
3649         Reviewed by Martin Robinson.
3650
3651         One of the important improvements is jhbuild no longer fetches git
3652         repositories if they are already at the expected revision, which should
3653         make the EWS bots more robust to git servers unavailability.
3654
3655         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
3656
3657 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
3658
3659         [GTK] Add webkit_uri_scheme_request_finish_error
3660