c021590acd17ed3c74acc40800e01a1356bff55d
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-02  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r174120.
4         https://bugs.webkit.org/show_bug.cgi?id=137350
5
6         While number of failures is reasonable with 2 processes, test
7         results seem to be inconsistent between runs (Requested by
8         rfong on #webkit).
9
10         Reverted changeset:
11
12         "[Windows] Back to 2 child processes for NRWT on Windows."
13         http://trac.webkit.org/changeset/174120
14
15 2014-10-02  Jeff Miller  <jeffm@apple.com>
16
17         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
18         https://bugs.webkit.org/show_bug.cgi?id=137347
19
20         Reviewed by Dan Bernstein.
21
22         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
23         Use WebKitSystemInterfaceYosemite on OS X 10.10.
24
25         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
26         Ditto.
27
28 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
29
30         [GTK] [JHBuild] Switch sourceware.org mirror to http.
31
32         Unreviewed.
33
34         The ftp access is recently failing to work as expected, and the
35         bots fail to download the file.
36         The same mirror is available via http and seems to work better.
37
38         * gtk/jhbuild.modules:
39
40 2014-10-01  Commit Queue  <commit-queue@webkit.org>
41
42         Unreviewed, rolling out r174185.
43         https://bugs.webkit.org/show_bug.cgi?id=137334
44
45         Patch that adds logging causes webkitpy failures (Requested by
46         rfong on #webkit).
47
48         Reverted changeset:
49
50         "commitqueuetasks_unittest references a non-existent member
51         variable"
52         https://bugs.webkit.org/show_bug.cgi?id=137303
53         http://trac.webkit.org/changeset/174185
54
55 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
56
57         EWS and Commit Queue should know better than to spew 500 failed
58         results in the case of extremely red patches.
59         https://bugs.webkit.org/show_bug.cgi?id=137324
60
61         Reviewed by Alexey Proskuryakov.
62
63         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
64         Adds a check for did_exceed_test_failure_limit.
65         (AbstractEarlyWarningSystem._failing_tests_message):
66         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
67         Alters the task mock to respond properly to
68         results_from_patch_test_run(patch)
69         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
70         * Scripts/webkitpy/tool/commands/queues.py:
71         Adds a check for did_exceed_test_failure_limit.
72         (CommitQueue._failing_tests_message):
73
74 2014-10-01  Daniel Bates  <dabates@apple.com>
75
76         Unreviewed, rolling out r174192.
77
78         Revert the unit test fix in r174192 since we reverted r174187
79         in r174194 due to correctness issues. See
80         <http://webkit.org/b/137329> for more details.
81
82         Reverted changeset:
83
84         "Test fix after r174187"
85         http://trac.webkit.org/changeset/174192
86
87 2014-10-01  Mark Rowe  <mrowe@apple.com>
88
89         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
90
91         Reviewed by Dan Bernstein.
92
93         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
94         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
95         for the LLVM components when on Yosemite.
96
97 2014-10-01  Commit Queue  <commit-queue@webkit.org>
98
99         Unreviewed, rolling out r174187.
100         https://bugs.webkit.org/show_bug.cgi?id=137329
101
102         webkitpy failures, and thorton says the patch is wrong
103         (Requested by dethbakin on #webkit).
104
105         Reverted changeset:
106
107         "[Windows] Increase layout test timeout for Windows following
108         r174162."
109         http://trac.webkit.org/changeset/174187
110
111 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
112
113         Test fix after r174187
114
115         * Scripts/webkitpy/port/win_unittest.py:
116         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
117
118 2014-10-01  Roger Fong  <roger_fong@apple.com>
119
120         [Windows] Increase layout test timeout for Windows following r174162.
121
122         * Scripts/webkitpy/port/win.py:
123         (WinPort.default_timeout_ms):
124
125 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
126
127         commitqueuetasks_unittest references a non-existent member variable
128         when mock-reporting flaky tests.
129         https://bugs.webkit.org/show_bug.cgi?id=137303
130
131         Reviewed by Daniel Bates.
132
133         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
134         (MockCommitQueue.report_flaky_tests):
135         Makes the appropriate name change.
136         (test_simple_flaky_test_failure):
137         Adds a unit test to make sure that the code is excercised.
138
139 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
140
141         EWS is inconclusively spinning forever on a patch that breaks 500+
142         tests
143         https://bugs.webkit.org/show_bug.cgi?id=137223
144
145         Reviewed by Tim Horton.
146
147         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
148         Checks to see whether the tests have exceeded the failure limit, and
149         only spins off another test if they have not exceeded the limit.
150         (PatchAnalysisTask._test_patch):
151
152 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
153
154         Unreviewed, add Katie Madonna as a contributor.
155
156         * Scripts/webkitpy/common/config/contributors.json:
157
158 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
159
160         commitqueuetasks_unittest does not construct FailingTestCommitQueue
161         objects properly in its test cases.
162         https://bugs.webkit.org/show_bug.cgi?id=137281
163
164         Reviewed by Daniel Bates.
165
166         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
167         (FailingTestCommitQueue.test_results):
168         Adds an assert to make FailingTestCommitQueue harder to mis-use.
169         (test_double_flaky_test_failure):
170         Nests the intended test failure strings into one-length lists.
171         (test_red_test_failure):
172         Nests the intended test failure strings into one-length lists.
173
174 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
175
176         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
177         https://bugs.webkit.org/show_bug.cgi?id=136987
178
179         Reviewed by Daniel Bates.
180
181         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
182         Specify the default encoding for all WebKit developers to get consistent results.
183
184 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
185
186         EWS is too eager to say that a patch does not apply to trunk of repository
187         https://bugs.webkit.org/show_bug.cgi?id=137290
188
189         Reviewed by Ryosuke Niwa.
190
191         * QueueStatusServer/app.yaml: Updated app version.
192
193         * QueueStatusServer/handlers/statusbubble.py:
194         (StatusBubble._build_bubble):
195         (StatusBubble._build_bubbles_for_attachment):
196         Rewrote to make more sense.
197
198 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
199
200         Remove thirdparty/unittest2 from webkitpy
201         https://bugs.webkit.org/show_bug.cgi?id=137251
202
203         Reviewed by Brent Fulgham.
204
205         Additionally ordered imports in related webkitpy files and
206         removed unnecessary shebangs from unittest files.
207
208         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
209         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
210         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
211         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
212         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
213         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
214         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
215         * Scripts/webkitpy/common/config/committers_unittest.py:
216         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
217         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
218         * Scripts/webkitpy/common/config/ports_unittest.py:
219         * Scripts/webkitpy/common/config/urls_unittest.py:
220         * Scripts/webkitpy/common/editdistance_unittest.py:
221         * Scripts/webkitpy/common/find_files_unittest.py:
222         * Scripts/webkitpy/common/lru_cache_unittest.py:
223         * Scripts/webkitpy/common/memoized_unittest.py:
224         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
225         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
226         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
227         * Scripts/webkitpy/common/net/credentials_unittest.py:
228         * Scripts/webkitpy/common/net/failuremap_unittest.py:
229         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
230         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
231         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
232         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
233         * Scripts/webkitpy/common/net/statusserver_unittest.py:
234         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
235         * Scripts/webkitpy/common/newstringio_unittest.py:
236         * Scripts/webkitpy/common/prettypatch_unittest.py:
237         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
238         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
239         * Scripts/webkitpy/common/system/environment_unittest.py:
240         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
241         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
242         * Scripts/webkitpy/common/system/executive_unittest.py:
243         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
244         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
245         * Scripts/webkitpy/common/system/filesystem_unittest.py:
246         * Scripts/webkitpy/common/system/logtesting.py:
247         * Scripts/webkitpy/common/system/logutils_unittest.py:
248         * Scripts/webkitpy/common/system/outputcapture.py:
249         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
250         * Scripts/webkitpy/common/system/outputtee_unittest.py:
251         * Scripts/webkitpy/common/system/path_unittest.py:
252         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
253         * Scripts/webkitpy/common/system/profiler_unittest.py:
254         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
255         * Scripts/webkitpy/common/system/user_unittest.py:
256         * Scripts/webkitpy/common/system/workspace_unittest.py:
257         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
258         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
259         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
260         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
261         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
262         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
263         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
264         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
265         * Scripts/webkitpy/common/webkitunittest.py:
266         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
267         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
268         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
269         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
270         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
271         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
272         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
273         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
274         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
275         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
276         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
277         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
278         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
279         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
280         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
281         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
282         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
283         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
284         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
285         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
286         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
287         * Scripts/webkitpy/port/base_unittest.py:
288         * Scripts/webkitpy/port/builders_unittest.py:
289         * Scripts/webkitpy/port/config_unittest.py:
290         * Scripts/webkitpy/port/driver_unittest.py:
291         * Scripts/webkitpy/port/efl_unittest.py:
292         * Scripts/webkitpy/port/factory_unittest.py:
293         * Scripts/webkitpy/port/gtk_unittest.py:
294         * Scripts/webkitpy/port/http_lock_unittest.py:
295         * Scripts/webkitpy/port/image_diff_unittest.py:
296         * Scripts/webkitpy/port/leakdetector_unittest.py:
297         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
298         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
299         * Scripts/webkitpy/port/mock_drt_unittest.py:
300         * Scripts/webkitpy/port/port_testcase.py:
301         * Scripts/webkitpy/port/server_process_unittest.py:
302         * Scripts/webkitpy/port/westondriver_unittest.py:
303         * Scripts/webkitpy/port/win_unittest.py:
304         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
305         * Scripts/webkitpy/style/checker_unittest.py:
306         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
307         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
308         * Scripts/webkitpy/style/checkers/common_unittest.py:
309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
310         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
311         * Scripts/webkitpy/style/checkers/js_unittest.py:
312         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
313         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
314         * Scripts/webkitpy/style/checkers/png_unittest.py:
315         * Scripts/webkitpy/style/checkers/python_unittest.py:
316         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
317         * Scripts/webkitpy/style/checkers/text_unittest.py:
318         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
319         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
320         * Scripts/webkitpy/style/checkers/xml_unittest.py:
321         * Scripts/webkitpy/style/error_handlers_unittest.py:
322         * Scripts/webkitpy/style/filereader_unittest.py:
323         * Scripts/webkitpy/style/filter_unittest.py:
324         * Scripts/webkitpy/style/main_unittest.py:
325         * Scripts/webkitpy/style/optparser_unittest.py:
326         * Scripts/webkitpy/style/patchreader_unittest.py:
327         * Scripts/webkitpy/test/finder_unittest.py:
328         * Scripts/webkitpy/test/main.py: Ordered imports.
329         * Scripts/webkitpy/test/main_unittest.py:
330         * Scripts/webkitpy/test/printer.py: Ordered imports.
331         (Printer.configure):
332         * Scripts/webkitpy/test/runner_unittest.py:
333         * Scripts/webkitpy/test/skip_unittest.py:
334         * Scripts/webkitpy/thirdparty/__init__.py:
335         (AutoinstallImportHook._install_irc):
336         (AutoinstallImportHook._install_unittest2): Deleted.
337         * Scripts/webkitpy/thirdparty/__init___unittest.py:
338         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
339         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
340         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
341         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
342         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
343         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
344         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
345         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
346         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
347         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
348         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
349         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
350         * Scripts/webkitpy/tool/commands/download_unittest.py:
351         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
352         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
353         * Scripts/webkitpy/tool/commands/queries_unittest.py:
354         * Scripts/webkitpy/tool/commands/queuestest.py:
355         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
356         * Scripts/webkitpy/tool/grammar_unittest.py:
357         * Scripts/webkitpy/tool/mocktool_unittest.py:
358         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
359         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
360         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
361         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
362         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
363         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
364         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
365         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
366         * Scripts/webkitpy/tool/steps/commit_unittest.py:
367         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
368         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
369         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
370         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
371         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
372         * Scripts/webkitpy/tool/steps/steps_unittest.py:
373         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
374         * Scripts/webkitpy/tool/steps/update_unittest.py:
375         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
376         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
377         * Scripts/webkitpy/w3c/test_converter_unittest.py:
378         * Scripts/webkitpy/w3c/test_importer_unittest.py:
379         * Scripts/webkitpy/w3c/test_parser_unittest.py:
380
381 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
382
383         LayoutTestResults and ExpectedFailures should know about the
384         interrupted flag from the json results file
385         https://bugs.webkit.org/show_bug.cgi?id=137229
386
387         Reviewed by Daniel Bates.
388
389         Changes LayoutTestResults to use the interrupted flag instead of
390         counting failures.
391
392         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
393         (BuilderTest._install_fetch_build._mock_fetch_build):
394         (BuilderTest.test_latest_layout_test_results):
395         * Scripts/webkitpy/common/net/layouttestresults.py:
396         Removes notion of failure_limit_count, and adds
397         did_exceed_test_failure_limit.
398
399         (LayoutTestResults.results_from_string):
400         (LayoutTestResults.__init__):
401         (LayoutTestResults.did_exceed_test_failure_limit):
402         (LayoutTestResults): Deleted.
403         (LayoutTestResults.set_failure_limit_count): Deleted.
404         (LayoutTestResults.failure_limit_count): Deleted.
405         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
406         Removes unit test for failure_limit_count logic.
407
408         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
409         * Scripts/webkitpy/common/net/resultsjsonparser.py:
410         Instead of providing a class method that returns a list of
411         TestResults objects, resultsjsonparser now provides a class
412         ParsedJSONResults that serves as an interface between the results.json
413         file and the rest of webkitpy.
414
415         (ParsedJSONResults):
416         (ParsedJSONResults.__init__):
417         (ParsedJSONResults.did_exceed_test_failure_limit):
418         (ParsedJSONResults.test_results):
419         (ResultsJSONParser): Deleted.
420         (ResultsJSONParser.parse_results_json): Deleted.
421         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
422         Updates the unit test so that it can test the new ResultsJSONParser
423         class.
424
425         (ParsedJSONResultsTest):
426         (test_basic):
427         (ResultsJSONParserTest): Deleted.
428         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
429         Updates the unit test to instantiate ResultsJSONParser objects rather
430         than simple lists of TestResult objects.
431
432         (MockCommitQueue.test_results):
433         (FailingTestCommitQueue.test_results):
434         (test_flaky_test_failure):
435         (test_failed_archive):
436         * Scripts/webkitpy/tool/bot/expectedfailures.py:
437         Updates ExpectedFailures to use the did_exceed_test_failure_limit
438         method rather than counting the number of failed tests.
439
440         (ExpectedFailures._should_trust):
441         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
442         Updates MockResults to more closely resemble the updated
443         LayoutTestResults class.
444
445         (MockResults.__init__):
446         (MockResults.did_exceed_test_failure_limit):
447         (ExpectedFailuresTest.test_can_trust_results):
448         (ExpectedFailuresTest.test_unexpected_failures_observed):
449         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
450         (MockResults.failure_limit_count): Deleted.
451         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
452         Removes a FIXME regarding the use of the
453         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
454
455         (LayoutTestResultsReader.results):
456         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
457         Updates test to not check the now-nonexistant failure_count_limit
458         method.
459
460         (test_missing_unit_test_results_path):
461         (test_layout_test_results):
462         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
463         Accounts for name change: ResultsJSONParserTest ->
464         ParsedJSONParserTest.
465
466         (RebaselineTestTest.test_gather_baselines):
467
468 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
469
470         [EFL] Rename TEST_THEME_DIR macro
471         https://bugs.webkit.org/show_bug.cgi?id=137244
472
473         Reviewed by Csaba Osztrogonác.
474
475         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
476         DEFAULT_THEME_DIR is better than it.
477
478         * MiniBrowser/efl/main.c:
479         (window_create):
480         * TestWebKitAPI/efl/PlatformWebView.cpp:
481         (TestWebKitAPI::PlatformWebView::PlatformWebView):
482         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
483         (WTR::PlatformWebView::PlatformWebView):
484
485 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
486
487         Windows EWS went purple when it failed to build
488         https://bugs.webkit.org/show_bug.cgi?id=137267
489
490         Reviewed by Ryosuke Niwa.
491
492         * QueueStatusServer/app.yaml: Update the version.
493
494         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
495         Make it work for style and win-ews queues.
496
497 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
498
499         It should be fun and easy to run every possible JavaScript benchmark from the command line
500         https://bugs.webkit.org/show_bug.cgi?id=137245
501
502         Reviewed by Oliver Hunt.
503         
504         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
505         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
506         having their own private scripts for doing benchmark runs, and didn't share them in the open
507         source community, because of fears about the shady licensing of the benchmarks suites that
508         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
509         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
510         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
511         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
512         but some of them are. The non-public tests are exclusively those that were not made by any
513         WebKit contributor, but which JSC/WebKit devs found useful for testing.
514
515         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
516         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
517         checked into WebKit svn at all) can be run by passing the path to them via a configuration
518         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
519         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
520         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
521         probably never be checked in because there is no license text anywhere in that benchmark.
522         A valid ~/.run-jsc-benchmarks file will just be something like:
523         
524             {
525                 "OctanePath": "/path/to/Octane2",
526                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
527             }
528         
529         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
530         run-jsc-benchmarks will just gracefully avoid running that test suite.
531         
532         Finally, a word about policy: it is understood that different organizations that do
533         development on JSC may find themselves having internal benchmarks that they cannot share
534         because of weird licensing. It happens - usually because the organization doing JSC
535         development found some test in the wild that is owned by someone else and therefore cannot
536         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
537         that add support for some new kind of benchmark suite even if the suite is not made public
538         as part of the same patch - so long as the patch isn't too invasive. An example of
539         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
540         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
541         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
542         completely open-sourced and committed to the WebKit repo - but the reality is that this
543         can't always be done safely.
544
545         * Scripts/bencher: Removed.
546         * Scripts/run-jsc-benchmarks: Added.
547
548 2014-09-30  Roger Fong  <roger_fong@apple.com>
549
550         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
551
552         * Scripts/webkitpy/port/drdiver.py:
553         (Driver.stop):
554         * Scripts/webkitpy/port/server_process.py:
555         (ServerProcess.stop):
556
557 2014-09-30  Roger Fong  <roger_fong@apple.com>
558
559         [Windows] Back to 2 child processes for NRWT on Windows.
560
561         * Scripts/webkitpy/port/win.py:
562         (WinPort.default_child_processes):
563         Changing the number of processes to 1 did not have an effect on the layout test results. 
564         It does introduce an issue with one of the workers hanging indefinitely and causing the 
565         layout tests to timeout as a whole occasionally, but we should just fix that.
566
567 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
568
569         Remove an accidentally committed line..
570
571         * QueueStatusServer/handlers/statusbubble.py:
572         (StatusBubble._build_bubble):
573
574 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
575
576         build.webkit.org/dashboard: Switch EWS view to using actual retry count
577         https://bugs.webkit.org/show_bug.cgi?id=137240
578
579         Reviewed by Ryosuke Niwa.
580
581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
582         (EWSQueue.prototype.loadDetailedStatus):
583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
584         (EWSQueueView.prototype._popoverContentForEWSQueue):
585         Use the new retry_count data member from JSON.
586
587         * QueueStatusServer/app.yaml: Updating the version.
588
589         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
590         Instead of message_count, produce retry_count.
591
592 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
593
594         EWS doesn't need to show all the bubbles when a patch fails to apply
595         https://bugs.webkit.org/show_bug.cgi?id=137256
596
597         Reviewed by Ryosuke Niwa.
598
599         * QueueStatusServer/app.yaml: Updated app version.
600
601         * QueueStatusServer/handlers/statusbubble.py:
602         (StatusBubble._build_bubble):
603         (StatusBubble._build_bubbles_for_attachment):
604         (StatusBubble.get):
605         * QueueStatusServer/templates/statusbubble.html:
606         When some queues fail to apply, and no queues had meaningful output (meaning that
607         they will almost certainly fail to apply later), we can show a single bubble
608         telling the user just that.
609
610 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
611
612         [EFL] Bump EFL version to 1.11.2
613         https://bugs.webkit.org/show_bug.cgi?id=137118
614
615         Reviewed by Gyuyoung Kim.
616
617         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
618         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
619
620         * efl/jhbuild.modules:
621         * efl/patches/ecore.patch: Removed.
622
623 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
624
625         REGRESSION(r173929): [GTK] TestInspector fails after r173929
626         https://bugs.webkit.org/show_bug.cgi?id=137247
627
628         Reviewed by Philippe Normand.
629
630         Wait until can-attach property changes before trying to attach the
631         inspector after resizing the view.
632
633         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
634         (testInspectorDefault):
635
636 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
637
638         Require Python 2.7 version
639         https://bugs.webkit.org/show_bug.cgi?id=137112
640
641         Reviewed by Csaba Osztrogonác.
642
643         * Scripts/ensure-valid-python:
644         (checkPythonVersion):
645         * Scripts/webkitpy/common/version_check.py:
646
647 2014-09-30  Martin Hock  <mhock@apple.com>
648
649         Skip a JSC test after r174036.
650         https://bugs.webkit.org/show_bug.cgi?id=137236
651
652         Reviewed by Csaba Osztrogonác.
653
654         * Scripts/run-javascriptcore-tests:
655
656 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
657
658         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
659         https://bugs.webkit.org/show_bug.cgi?id=137212
660
661         This moves TestNetscapePlugin to a new folder (lib/plugins).
662         We should not use the same directory for TestNetscapePlugin and
663         the other libraries, because we end up scanning all the .so in the
664         lib dir for every test.
665
666         Reviewed by Carlos Garcia Campos.
667
668         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
669         * Scripts/webkitpy/port/efl.py:
670         (EflPort.setup_environ_for_server): Update plugin path.
671         * Scripts/webkitpy/port/gtk.py:
672         (GtkPort.setup_environ_for_server): Update plugin path.
673         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
674
675 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
676
677         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
678
679         Rubber-stamped by Tim Horton.
680
681         * QueueStatusServer/app.yaml:
682         * QueueStatusServer/handlers/statusbubble.py:
683         (StatusBubble._build_bubble):
684
685 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
686
687         Typo fix, suggested by Tim Horton.
688
689         * QueueStatusServer/handlers/statusbubble.py:
690         (StatusBubble._build_message_for_provisional_failure):
691
692 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
693
694         Improve Bugzilla status bubbles
695         https://bugs.webkit.org/show_bug.cgi?id=137232
696
697         Reviewed by Ryosuke Niwa.
698
699         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
700
701         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
702         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
703         that are stuck, as it was only confusing that they disappeared after 99.
704
705         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
706         by old bubbles. We need a lot more information to determine color, so the implementation
707         can not be here.
708
709         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
710         always have a link for consistency. Added code to convert timestamps in tooltips
711         to local time zone.
712
713 2014-09-29  Commit Queue  <commit-queue@webkit.org>
714
715         Unreviewed, rolling out r174045.
716         https://bugs.webkit.org/show_bug.cgi?id=137231
717
718         Introduced a crash during page loading tests on Mac (Requested
719         by rniwa on #webkit).
720
721         Reverted changeset:
722
723         "Replace OSObjectPtr with RetainPtr/adoptOS"
724         https://bugs.webkit.org/show_bug.cgi?id=137158
725         http://trac.webkit.org/changeset/174045
726
727 2014-09-29  Tim Horton  <timothy_horton@apple.com>
728
729         Add Jake as a contributor.
730
731         * Scripts/webkitpy/common/config/contributors.json:
732
733 2014-09-29  Roger Fong  <roger_fong@apple.com>
734
735         [Windows] Skip a javascriptcore test following r174036.
736
737         * Scripts/run-javascriptcore-tests:
738
739 2014-09-29  Roger Fong  <roger_fong@apple.com>
740
741         [Windows] Reduce number of processes used by NRWT on Windows to 1.
742
743         * Scripts/webkitpy/port/win.py:
744         (WinPort.default_child_processes):
745         Reduce number of processes to 1 so we can get a good baseline for what failures
746         we should be expecting to see from the Windows bots.
747
748 2014-09-29  Darin Adler  <darin@apple.com>
749
750         Tweak and tighten SVG font converter
751         https://bugs.webkit.org/show_bug.cgi?id=136956
752
753         Reviewed by Myles Maxfield.
754
755         I was investigating behavior of String::toInt, String::toDouble, and
756         String::toFloat for various failure cases, and decided to start some
757         unit tests for those functions here.
758
759         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
760         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
761         StringToDouble testing.
762
763 2014-09-29  Philippe Normand  <pnormand@igalia.com>
764
765         [GTK][CMake] TestWebCore target build sometimes fail
766         https://bugs.webkit.org/show_bug.cgi?id=137207
767
768         Reviewed by Csaba Osztrogon.
769
770         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
771         headers are generated before the TestWebCore target is built.
772
773 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
774
775         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
776         https://bugs.webkit.org/show_bug.cgi?id=137209
777
778         Reviewed by Philippe Normand.
779
780         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
781         from the WebCore test sources.
782
783 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
784
785         Allow webkit-patch upload to respect the --directory argument with git checkouts
786         https://bugs.webkit.org/show_bug.cgi?id=137166
787
788         Reviewed by Darin Adler.
789
790         We simply hadn't plumbed it through.
791
792         * Scripts/webkitpy/common/checkout/scm/detection.py:
793         (SCMDetector.detect_scm_system):
794         * Scripts/webkitpy/common/checkout/scm/git.py:
795         (Git.__init__):
796         (Git.changed_files):
797
798 2014-09-26  Sam Weinig  <sam@webkit.org>
799
800         Replace OSObjectPtr with RetainPtr/adoptOS
801         https://bugs.webkit.org/show_bug.cgi?id=137158
802
803         Reviewed by Dan Bernstein.
804
805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
806         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
807         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
808         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
809
810 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
811
812         Disable function.arguments
813         https://bugs.webkit.org/show_bug.cgi?id=137167
814
815         Rubber stamped by Geoffrey Garen
816         
817         Enable the feature by default during tests.
818
819         * Scripts/run-jsc-stress-tests:
820
821 2014-09-26  Beth Dakin  <bdakin@apple.com>
822
823         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
824         https://bugs.webkit.org/show_bug.cgi?id=137089
825
826         Reviewed by Tim Horton.
827
828         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
829         tests run at 1x, but that code does not seem to execute at the right time for 
830         these tests, so if we just ensure we start out at 1x, that appears to fix these 
831         tests and does not break the HiDPI tests either.
832         * WebKitTestRunner/TestController.cpp:
833         (WTR::TestController::createWebViewWithOptions):
834
835 2014-09-26  Roger Fong  <roger_fong@apple.com>
836
837         [Windows] Decrease default number of child processes used by Windows.
838
839         * Scripts/webkitpy/port/win.py:
840         (WinPort.default_child_processes):
841         Having too many seems to cause many tests to crash or timeout. 
842         We may even need to make it have only 1 child process if we’re still seeing problems after this.
843
844 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
845
846         Mac EWS bots do not keep logs as promised
847         https://bugs.webkit.org/show_bug.cgi?id=137151
848
849         Reviewed by Ryosuke Niwa.
850
851         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
852
853 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
854
855         Get rid of webkit-queues dashboard
856         https://bugs.webkit.org/show_bug.cgi?id=137141
857
858         Reviewed by Ryosuke Niwa.
859
860         * QueueStatusServer/app.yaml: Updated version.
861
862         * QueueStatusServer/templates/dashboard.html: Removed.
863         * QueueStatusServer/handlers/dashboard.py: Removed.
864         * QueueStatusServer/main.py:
865         Kill it!
866
867         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
868         (.status-cell): Deleted.
869         (.status-cell:hover): Deleted.
870         (.status-cell.pass): Deleted.
871         (.status-cell.fail): Deleted.
872         (.status-cell.pending): Deleted.
873         (.status-cell.error): Deleted.
874         * QueueStatusServer/stylesheets/dashboard.css: Removed.
875         * QueueStatusServer/templates/activebots.html:
876         * QueueStatusServer/templates/patch.html:
877         * QueueStatusServer/templates/queuestatus.html:
878         * QueueStatusServer/templates/recentstatus.html:
879         Renamed dashboard.css to common.css, and removed dashboard-only rules.
880
881 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
882
883         Get rid of Retry status in webkit-queues
884         https://bugs.webkit.org/show_bug.cgi?id=137135
885
886         Reviewed by Ryosuke Niwa.
887
888         * QueueStatusServer/config/messages.py: Removed Retry.
889
890         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
891         no longer needs to check the latest status. It just always both unlocks the patch
892         and removes it from WorkItems.
893
894         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
895         I don't understand why we even needed to check for retries here, but now that there
896         are no retries, that code can go to /dev/null.
897
898         * QueueStatusServer/loggers/recordpatchevent.py:
899         (RecordPatchEvent.started):
900         (RecordPatchEvent.retrying): Deleted.
901         Fixed retry counting, it should work for all queues now.
902
903         * QueueStatusServer/model/queuestatus.py:
904         (QueueStatus.is_retry_request): Deleted. These are no more.
905
906         * Scripts/webkitpy/common/net/statusserver_mock.py:
907         (MockStatusServer.release_lock):
908         * Scripts/webkitpy/tool/commands/queues_unittest.py:
909         Did whatever it took to keep passing the tests. The particular test doesn't seem
910         quite right, but whatever.
911
912         * Scripts/webkitpy/tool/commands/queues.py:
913         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
914         and let others pick up. Also, added explicit returns for clarity.
915         (AbstractPatchQueue._did_retry): Deleted.
916
917 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
918
919         [EFL] Fix the gst-libav build on ARM Thumb2
920         https://bugs.webkit.org/show_bug.cgi?id=137022
921
922         Reviewed by Zoltan Herczeg.
923
924         * efl/jhbuild.modules:
925         * efl/patches/gst-libav.patch: Added.
926
927 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
928
929         [EFL] Bump up dependencies not to conflict with the GTK port.
930         https://bugs.webkit.org/show_bug.cgi?id=137143
931
932         Reviewed by Gyuyoung Kim.
933
934         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
935         installing and removing different versions of libgnutls-dev, thus
936         hindering the development for both ports on the same machine. GTK is
937         using the newer version of the package, now bumping up EFL to use the 
938         same.
939
940         * efl/install-dependencies:
941
942 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
943
944         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
945         https://bugs.webkit.org/show_bug.cgi?id=136854
946
947         Reviewed by Gyuyoung Kim.
948
949         'Escape' key should exit fullscreen first and then should be used to stop page load.
950
951         * MiniBrowser/efl/main.c:
952         (on_key_down):
953
954 2014-09-25  Dean Jackson  <dino@apple.com>
955
956         Add Said to the contributors list so his name completes in bugzilla.
957
958         * Scripts/webkitpy/common/config/contributors.json:
959
960 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
961
962         EWS only repeats its cycle every two hours
963         https://bugs.webkit.org/show_bug.cgi?id=137129
964
965         Reviewed by Ryosuke Niwa.
966
967         * QueueStatusServer/app.yaml: Updated version.
968
969         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
970
971         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
972         the patch from work items.
973
974         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
975
976         * QueueStatusServer/main.py: Added release-lock.
977
978         * QueueStatusServer/model/activeworkitems.py:
979         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
980
981         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
982         we don't want it to be immediately picked up again, it's better to give other patches
983         a chance.
984
985         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
986         these interactive versions, but OK.
987
988         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
989         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
990         or svn is down).
991
992         * Scripts/webkitpy/tool/commands/queues.py:
993         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
994         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
995         meaning that these handlers could never do the right thing. We'd either get a duplicate
996         _did_fail, or try to unlock an already unlocked patch.
997         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
998         making it eligible for retry immediately.
999
1000         * Scripts/webkitpy/common/net/statusserver.py:
1001         (StatusServer._post_release_lock):
1002         (StatusServer.release_lock):
1003         Added a call to release-lock.
1004
1005 2014-09-25  Roger Fong  <roger_fong@apple.com>
1006
1007         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1008
1009         * Scripts/webkitpy/common/system/path.py:
1010         (_CygPath.convert):
1011
1012 2014-09-25  Roger Fong  <roger_fong@apple.com>
1013
1014         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1015
1016         * Scripts/webkitpy/common/system/path.py:
1017         (_CygPath.convert):
1018
1019 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1020
1021         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1022         https://bugs.webkit.org/show_bug.cgi?id=136377
1023
1024         Reviewed by Philippe Normand.
1025
1026         * Scripts/webkitdirs.pm:
1027         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1028
1029 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1030
1031         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1032         https://bugs.webkit.org/show_bug.cgi?id=137117
1033
1034         Tools/efl/install-dependencies relies on apt-get to install packages.
1035         Unfortunately, if a package does not exist (e.g., for a given
1036         architecture) then apt-get install is not able to ignore the missing
1037         package and install the rest but fails to run entirely (and there
1038         seems to be no intent to change this behaviour).
1039
1040         On ARM64, the luajit package is missing and currently it needs manual
1041         editing of install-dependencies to get the script install as much as it
1042         can.
1043
1044         This patch separates the installation of the universally available
1045         packages from those which might not be available for all architectures.
1046
1047         Reviewed by Gyuyoung Kim.
1048
1049         * efl/install-dependencies:
1050
1051 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1052
1053         Remove WinCE port from trunk
1054         https://bugs.webkit.org/show_bug.cgi?id=136951
1055
1056         Reviewed by Alex Christensen.
1057
1058         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1059         (_should_file_trigger_build):
1060         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1061         (ShouldBuildTest):
1062         * CMakeLists.txt:
1063         * DumpRenderTree/win/DRTDataObject.cpp:
1064         (DRTDataObject::CopyMedium):
1065         * Scripts/build-webkit:
1066         * Scripts/webkit-build-directory:
1067         * Scripts/webkitdirs.pm:
1068         (argumentsForConfiguration):
1069         (builtDylibPathForName):
1070         (isAppleWinWebKit):
1071         (launcherPath):
1072         (launcherName):
1073         (shouldRemoveCMakeCache):
1074         (cmakeBasedPortArguments):
1075         (cmakeBasedPortName):
1076         (isCMakeBuild):
1077         (isWinCE): Deleted.
1078         (determineIsWinCE): Deleted.
1079         * Scripts/webkitperl/FeatureList.pm:
1080         * Scripts/webkitpy/port/port_testcase.py:
1081         (test_apache_config_file_name_for_platform):
1082         * TestWebKitAPI/config.h:
1083         * WinCELauncher/CMakeLists.txt: Removed.
1084         * WinCELauncher/main.cpp: Removed.
1085         * gtk/manifest.txt:
1086
1087 2014-09-23  David Farler  <dfarler@apple.com>
1088
1089         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1090         https://bugs.webkit.org/show_bug.cgi?id=136895
1091
1092         Reviewed by David Kilzer.
1093
1094         Create Device, DeviceType, and Runtime data classes.
1095         Create Simulator class represent simctl output.
1096
1097         Wherever possible, use structured data classes anywhere a raw
1098         identifier or UDID string was used for a cleaner implementation
1099         and to encapsulate the inherent fragility of scraping simctl output.
1100
1101         Create a suitably named testing device if one doesn't exist.
1102
1103         Finally, accurately handle having multiple simulator runtimes (SDKs)
1104         installed in the active Xcode.app bundle.
1105
1106         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1107         (_set_up_derived_options):
1108         * Scripts/webkitpy/port/driver.py:
1109         (IOSSimulatorDriver.cmd_line):
1110         Construct DeviceType and Runtime objects from identifiers passed at the
1111         command line, still providing sensible defaults for 32- and 64-bit testing.
1112         * Scripts/webkitpy/port/ios.py:
1113         (IOSSimulatorPort.__init__):
1114         (IOSSimulatorPort.setup_test_run):
1115         (IOSSimulatorPort):
1116         (IOSSimulatorPort.testing_device):
1117         Cache the testing device once it is created or found.
1118         (IOSSimulatorPort.reset_preferences):
1119         Get the device path from the Device object instead of consructing it
1120         in the port class.
1121         (IOSSimulatorPort.simulator_udid): Deleted.
1122         Get the UDID from the testing_device :: Device object itself.
1123         * Scripts/webkitpy/xcode/simulator.py:
1124         Created Device, DeviceType, Runtime, and Simulator classes.
1125         (get_runtimes): Deleted.
1126         (get_devices): Deleted.
1127         (get_device_types): Deleted.
1128         (get_latest_runtime): Deleted.
1129
1130 2014-09-24  Roger Fong  <roger_fong@apple.com>
1131
1132         [Windows] Tentative fix for Windows test bots.
1133
1134         * Scripts/webkitpy/common/system/path.py:
1135         (_CygPath.convert):
1136
1137 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1138
1139         Change more build.webkit.org links to https
1140         https://bugs.webkit.org/show_bug.cgi?id=137049
1141
1142         Reviewed by Csaba Osztrogonác.
1143
1144         Fix appspot, svn.webkit.org and Trac links.
1145
1146         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1147         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1150         (ViewController.prototype._domForBuildName):
1151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1155         (.):
1156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1157         (EWS):
1158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1160         (TestHistory):
1161         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1162
1163 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1164
1165         Update the list of u-szeged contributors.
1166
1167         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1168
1169         * Scripts/webkitpy/common/config/contributors.json:
1170
1171 2014-09-23  Roger Fong  <roger_fong@apple.com>
1172
1173         [Windows] More debugging for the Windows bots.
1174
1175         * Scripts/webkitpy/common/system/path.py:
1176         (_CygPath):
1177
1178 2014-09-23  Roger Fong  <roger_fong@apple.com>
1179
1180         Unreviewed. Fix for r173899, those tabs should be spaces.
1181
1182         * Scripts/webkitpy/port/driver.py:
1183         (Driver._command_from_driver_input):
1184         (Driver): Deleted.
1185
1186 2014-09-23  Roger Fong  <roger_fong@apple.com>
1187
1188         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1189
1190         * Scripts/webkitpy/port/driver.py:
1191         (Driver):
1192
1193 2014-09-23  Jer Noble  <jer.noble@apple.com>
1194
1195         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1196         https://bugs.webkit.org/show_bug.cgi?id=137031
1197
1198         Reviewed by Joseph Pecoraro.
1199
1200         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1201         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1202         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1203         ChangeLog locations before passing them to createCommitMessage().
1204
1205         * Scripts/commit-log-editor:
1206
1207 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1208
1209         W3C test importer should detect manual and reference tests according their filenames
1210         https://bugs.webkit.org/show_bug.cgi?id=133852
1211
1212         Reviewed by Bem Jones-Bey.
1213
1214         * Scripts/webkitpy/w3c/test_parser.py:
1215         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1216         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1217         (TestParser):
1218         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1219         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1220         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1221         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1222
1223 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1224
1225         Unreviewed, add Rebecca Hauck as a contributor.
1226
1227         * Scripts/webkitpy/common/config/contributors.json:
1228
1229 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1230
1231         Switch build.webkit.org URLs to https
1232
1233         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1234
1235         * TestResultServer/app.yaml: Update version to this commit
1236         revision.
1237
1238         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1239         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1242         (WebKitBuildbot):
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1246         (.):
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1248         (WebKitBuildbot):
1249         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1250         * Scripts/webkitpy/common/config/urls.py:
1251         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1252         (test_builder_with_name):
1253         * Scripts/webkitpy/tool/commands/queries.py:
1254         (TreeStatus):
1255         * TestResultServer/generate_builders_json.py:
1256         (main):
1257         * TestResultServer/generate_builders_json_unittest.py:
1258         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1259         (GenerateBuildersJsonTest):
1260         (GenerateBuildersJsonTest.test_generate_json_data):
1261         * TestResultServer/static-dashboards/builders.jsonp:
1262         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1263         (loadExpectationsLayoutTests):
1264         * TestResultServer/static-dashboards/timeline_explorer.js:
1265
1266 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1267
1268         W3C test importer should copy .htaccess files
1269         https://bugs.webkit.org/show_bug.cgi?id=136850
1270
1271         Reviewed by Bem Jones-Bey.
1272
1273         * Scripts/webkitpy/w3c/test_importer.py:
1274         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1275         (TestImporter):
1276         (TestImporter.find_importable_tests): Making use of new helper function.
1277
1278 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1279
1280         Trying to revive bot watcher's dashboard after HSTS.
1281
1282         Unreviewed.
1283
1284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1285         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1286
1287 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1288
1289         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1290         https://bugs.webkit.org/show_bug.cgi?id=137026
1291
1292         Reviewed by Csaba Osztrogonác.
1293
1294         * BuildSlaveSupport/wait-for-SVN-server.py:
1295         (getLatestSVNRevision):
1296         (waitForSVNRevision):
1297
1298 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1299
1300         Remove unlinkZeroFiles from build-webkit
1301         https://bugs.webkit.org/show_bug.cgi?id=137018
1302
1303         Reviewed by Csaba Osztrogonác.
1304
1305         * Scripts/build-webkit:
1306         (unlinkZeroFiles): Deleted.
1307
1308 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1309
1310         [GTK] Minibrowser : Add keyboard support for stop page load
1311         https://bugs.webkit.org/show_bug.cgi?id=136857
1312
1313         Reviewed by Philippe Normand.
1314
1315         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1316
1317         * MiniBrowser/gtk/BrowserWindow.c:
1318         (stopPageLoad): Callback to stop page load.
1319         (browser_window_init):
1320
1321 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1322
1323         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1324         https://bugs.webkit.org/show_bug.cgi?id=136813
1325
1326         Reviewed by Gyuyoung Kim.
1327
1328         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1329
1330         * MiniBrowser/efl/main.c:
1331         (on_key_down):
1332
1333 2014-09-22  Daniel Bates  <dabates@apple.com>
1334
1335         [Cocoa] Add UI delegate callback when window.close() is called
1336         https://bugs.webkit.org/show_bug.cgi?id=137008
1337         <rdar://problem/17801001>
1338
1339         Reviewed by Anders Carlsson.
1340
1341         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1342         for window opened via JavaScript (i.e. window.open()).
1343
1344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1345         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1346         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1347
1348 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1349
1350         W3C importer should import html files within resources folders
1351         https://bugs.webkit.org/show_bug.cgi?id=127548
1352
1353         Reviewed by Ryosuke Niwa.
1354         
1355         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1356
1357         * Scripts/webkitpy/w3c/test_importer.py:
1358         (TestImporter.find_importable_tests):
1359
1360 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1361
1362         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1363         https://bugs.webkit.org/show_bug.cgi?id=136998
1364
1365         Reviewed by Philippe Normand.
1366
1367         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1368         (testWebViewCanShowMIMEType): Remove the check of PDF as
1369         unsupported MIME type.
1370
1371 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1372
1373         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1374
1375         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1376         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1377
1378         * Scripts/webkitpy/common/config/watchlist: Use
1379         Source/WebCore/platform/gtk/po/ as directory to watch for
1380         WebKitGTKTranslations rule and add berto and myself to the list of
1381         watchers.
1382
1383 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1384
1385         Fix syntaxError in watchlist since r173594
1386         https://bugs.webkit.org/show_bug.cgi?id=136996
1387
1388         Reviewed by Philippe Normand.
1389
1390         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1391
1392 2014-09-20  Sam Weinig  <sam@webkit.org>
1393
1394         Make possible HashSet<std::unique_ptr<>>
1395         https://bugs.webkit.org/show_bug.cgi?id=136166
1396
1397         Reviewed by Darin Adler.
1398
1399         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1400         * TestWebKitAPI/Counters.cpp: Added.
1401         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1402         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1403         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1404         translation unit.
1405     
1406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1407         Add new files.
1408
1409         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1410         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1411
1412         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1413         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1414
1415 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1416
1417         run-webkit-tests should count tests submitted as absolute paths once
1418         https://bugs.webkit.org/show_bug.cgi?id=136848
1419
1420         Reviewed by Darin Adler.
1421
1422         * Scripts/webkitpy/port/base.py:
1423         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1424
1425 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1426
1427         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1428         https://bugs.webkit.org/show_bug.cgi?id=136974
1429
1430         Reviewed by Chris Fleizach.
1431
1432         * DumpRenderTree/AccessibilityUIElement.cpp:
1433         (selectTextWithCriteriaCallback):
1434         Be sure to release the string if it was allocated.
1435
1436 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1437
1438         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1439         https://bugs.webkit.org/show_bug.cgi?id=136966
1440
1441         Reviewed by Daniel Bates.
1442
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1444         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1445
1446 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1447
1448         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1449         https://bugs.webkit.org/show_bug.cgi?id=136917
1450
1451         Reviewed by Darin Adler.
1452
1453         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1454
1455         * TestWebKitAPI/PlatformEfl.cmake:
1456         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1457         (TestWebKitAPI::didFinishLoadForFrame):
1458         (TestWebKitAPI::TEST):
1459         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1460
1461 2014-09-19  Daniel Bates  <dabates@apple.com>
1462
1463         Always assume internal SDK when building configuration Production
1464         https://bugs.webkit.org/show_bug.cgi?id=136925
1465         <rdar://problem/18362399>
1466
1467         Reviewed by Dan Bernstein.
1468
1469         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1470         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1471         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1472         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1473
1474 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1475
1476         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1477         https://bugs.webkit.org/show_bug.cgi?id=136847
1478
1479         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1480
1481         Reviewed by Alexey Proskuryakov.
1482
1483         * WebKitTestRunner/TestController.cpp:
1484         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1485
1486 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         [GTK] Missing inspector files in the tarball
1489         https://bugs.webkit.org/show_bug.cgi?id=136952
1490
1491         Reviewed by Gustavo Noronha Silva.
1492
1493         * gtk/manifest.txt: Add
1494         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1495         to the tarball.
1496
1497 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1498
1499         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1500         https://bugs.webkit.org/show_bug.cgi?id=136632
1501
1502         Reviewed by Gustavo Noronha Silva.
1503
1504         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1505         the gtk icons.
1506         * gtk/manifest.txt: Only include the free icons in the tarball.
1507
1508 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1509
1510         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1511         https://bugs.webkit.org/show_bug.cgi?id=136943
1512
1513         Reviewed by Philippe Normand.
1514
1515         Update the script to receive the list of files from the command
1516         line instead of scanning the given directories.
1517
1518         * gtk/generate-inspector-gresource-manifest.py:
1519         (get_filenames): Convert filenames to use relative paths.
1520         (find_all_files_in_directory): Deleted.
1521         (find_all_files_in_directory.select_file): Deleted.
1522
1523 2014-09-18  Tanay C  <tanay.c@samsung.com>
1524
1525         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1526         https://bugs.webkit.org/show_bug.cgi?id=136739
1527
1528         Reviewed by Gyuyoung Kim.
1529
1530         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1531         (on_mouse_wheel): Modified.
1532
1533 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1536         https://bugs.webkit.org/show_bug.cgi?id=136923
1537
1538         Reviewed by Gustavo Noronha Silva.
1539
1540         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1541         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1542         the source.
1543
1544 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1545
1546         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1547         https://bugs.webkit.org/show_bug.cgi?id=136856
1548
1549         Reviewed by Darin Adler.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1552         (RunLLINTCLoopTests.countFailures):
1553         (Run32bitJSCTests.countFailures):
1554         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1555         (RunLLINTCLoopTestsTest.test_failures):
1556         (RunLLINTCLoopTestsTest.test_failure):
1557         (RunLLINTCLoopTestsTest.test_no_failure):
1558         (Run32bitJSCTestsTest.test_failures):
1559         (Run32bitJSCTestsTest.test_failure):
1560         (Run32bitJSCTestsTest.test_no_failure):
1561
1562 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1563
1564         GMainLoopSource is exposed to race conditions
1565         https://bugs.webkit.org/show_bug.cgi?id=135800
1566
1567         Reviewed by Carlos Garcia Campos.
1568
1569         Add unit tests for GMainLoopSource.
1570
1571         The tests check correct behavior of GMainLoopSource in various conditions --
1572         from the most simple rescheduling to rescheduling during dispatch, cancelling
1573         or destroying the GMainLoopSource during dispatch, proper destroy callback
1574         dispatching etc.
1575
1576         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1577         State of the GMainLoopSource object (either ready, sheduled or active) is
1578         thoroughly tested throughout the lifetime of that object.
1579
1580         Still missing are tests for socket callbacks, which are a bit trickier because
1581         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1582         are also not tested thoroughly, simply because it is at the moment impossible
1583         to test that the objects are actually destroyed when the corresponding source
1584         is finally deleted.
1585
1586         * TestWebKitAPI/PlatformGTK.cmake:
1587         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1588         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1589         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1590         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1591         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1592         (TestWebKitAPI::GMainLoopSourceTest::finish):
1593         (TestWebKitAPI::GMainLoopSourceTest::source):
1594         (TestWebKitAPI::TEST):
1595
1596 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1597
1598         Unreviewed, Update my email in contributors.json
1599
1600         * Scripts/webkitpy/common/config/contributors.json:
1601
1602 2014-09-17  Daniel Bates  <dabates@apple.com>
1603
1604         Unreviewed, rolling out r173695.
1605
1606         Broke building third-party Legacy WebKit apps; will
1607         investigate offline
1608
1609         Reverted changeset:
1610
1611         "[iOS] Make WebCore build with public iOS SDK"
1612         https://bugs.webkit.org/show_bug.cgi?id=136487
1613         http://trac.webkit.org/changeset/173695
1614
1615 2014-09-17  Daniel Bates  <dabates@apple.com>
1616
1617         [iOS] Make WebCore build with public iOS SDK
1618         https://bugs.webkit.org/show_bug.cgi?id=136487
1619
1620         Reviewed by David Kilzer.
1621
1622         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
1623
1624         * DumpRenderTree/mac/CheckedMalloc.cpp:
1625
1626 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
1629         https://bugs.webkit.org/show_bug.cgi?id=136889
1630
1631         Reviewed by Gustavo Noronha Silva.
1632
1633         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1634         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
1635         event was added to the events vector.
1636         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1637         (loadFailedCallback): Do not assume the web view URI is the
1638         failing URI when the load fails before the committed state.
1639         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
1640         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
1641         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
1642         (LoadTrackingTest::loadFailedWithTLSErrors): Add
1643         LoadFailedWithTLSErrors event to the events vector.
1644         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1645
1646 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
1647
1648         [EFL][GTK] Remove WebKit1 related codes
1649         https://bugs.webkit.org/show_bug.cgi?id=136853
1650
1651         Reviewed by Csaba Osztrogonác.
1652
1653         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
1654         from scripts.
1655
1656         * BuildSlaveSupport/build.webkit.org-config/config.json:
1657         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1658         (Compile32bitJSC):
1659         (BuildAndTestWebKit2Factory):
1660         (CompileWebKit1Only): Deleted.
1661         (CompileWebKit2Only): Deleted.
1662         (BuildAndTestWebKit1OnlyFactory): Deleted.
1663         (BuildAndTestWebKit2OnlyFactory): Deleted.
1664         * Scripts/build-webkit:
1665         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1666         * Scripts/webkitpy/common/config/ports.py:
1667         (GtkWK2Port.build_webkit_command):
1668         (EflWK2Port.build_webkit_command):
1669         * Scripts/webkitpy/common/config/ports_unittest.py:
1670         (DeprecatedPortTest.test_gtk_wk2_port):
1671         * Scripts/webkitpy/port/efl.py:
1672         (EflPort.build_webkit_command):
1673         * Scripts/webkitpy/port/gtk.py:
1674         (GtkPort._built_libraries_path):
1675         (GtkPort._search_paths):
1676         (GtkPort.test_expectations_file_position):
1677         (GtkPort.build_webkit_command):
1678         (GtkPort.run_webkit_tests_command):
1679         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
1680
1681 2014-09-16  Daniel Bates  <dabates@apple.com>
1682
1683         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
1684         https://bugs.webkit.org/show_bug.cgi?id=136862
1685
1686         Reviewed by David Kilzer.
1687
1688         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1689         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1690         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
1691         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
1692
1693 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1694
1695         Mac queue slaves should reboot every so often
1696         https://bugs.webkit.org/show_bug.cgi?id=136791
1697
1698         Reviewed by Alexey Proskuryakov.
1699
1700         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
1701
1702         * EWSTools/start-queue-mac.sh:
1703
1704 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1705
1706         Unreviewed gardening, skip one more tests on Windows.
1707
1708         * Scripts/run-javascriptcore-tests:
1709
1710 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1711
1712         JSC test gardening
1713         https://bugs.webkit.org/show_bug.cgi?id=136823
1714
1715         Reviewed by Geoffrey Garen.
1716
1717         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
1718
1719 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1720
1721         Remove shouldAbortEarly cruft from master.cfg
1722         https://bugs.webkit.org/show_bug.cgi?id=136779
1723
1724         Reviewed by Csaba Osztrogonác.
1725
1726         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1727         (ConfigureBuild.start):
1728         (RunWebKitTests.start):
1729         (RunWebKit2Tests.start): Deleted.
1730
1731 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1732
1733         Remove ORWT related crufts from webkitdirs.pm
1734         https://bugs.webkit.org/show_bug.cgi?id=136821
1735
1736         Reviewed by Alexey Proskuryakov.
1737
1738         * Scripts/webkitdirs.pm:
1739         (isPerianInstalled): Deleted.
1740         (determineIPhoneSimulatorVersion): Deleted.
1741         (iPhoneSimulatorVersion): Deleted.
1742         (isSnowLeopard): Deleted.
1743         (isLion): Deleted.
1744         (quitIOSSimulator): Deleted.
1745
1746 2014-09-15  Roger Fong  <roger_fong@apple.com>
1747
1748         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
1749         https://bugs.webkit.org/show_bug.cgi?id=25160
1750
1751         * Scripts/run-javascriptcore-tests:
1752
1753 2014-09-15  Lucas Forschler  <lforschler@apple.com>
1754
1755         Add another Apple build slave to the Mountain Lion Debug WK1 queue
1756         
1757         Rubber stamped by Matt Hanson.
1758         
1759         * BuildSlaveSupport/build.webkit.org-config/config.json:
1760
1761 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1762
1763         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
1764         https://bugs.webkit.org/show_bug.cgi?id=136822
1765
1766         Reviewed by Gyuyoung Kim.
1767
1768         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
1769         initialized as we already does it in PlatformWebView::PlatformWebView
1770         calling ewk_init(). The reason for that was to ensure testing for example,
1771         WTF where creating the view is not mandatory.
1772
1773         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
1774         in order to properly initalize and release EWebKit.
1775
1776         * TestWebKitAPI/PlatformEfl.cmake:
1777         * TestWebKitAPI/efl/PlatformWebView.cpp:
1778         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1779         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1780         * TestWebKitAPI/efl/main.cpp:
1781         (main):
1782
1783 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
1784
1785         [WinCairo] Make it easier to enable/disable GStreamer.
1786         https://bugs.webkit.org/show_bug.cgi?id=135766
1787
1788         Reviewed by Brent Fulgham.
1789
1790         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
1791
1792         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
1793
1794 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
1795
1796         Web Inspector: remind about rebaselining generator test results
1797         https://bugs.webkit.org/show_bug.cgi?id=136759
1798
1799         Reviewed by Joseph Pecoraro.
1800
1801         For now, we can implement this as a watchlist message. Add watchlist
1802         groups and messages for the inspector and web replay generators.
1803
1804         * Scripts/webkitpy/common/config/watchlist:
1805
1806 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
1807
1808         build.webkit.org/dashboard: Overlapping text when status is long
1809         https://bugs.webkit.org/show_bug.cgi?id=136794
1810
1811         Reviewed by Timothy Hatcher.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1814         (.status-line): Replaces height with min-height.
1815
1816 2014-09-12  Timothy Hatcher  <timothy@apple.com>
1817
1818         Make Brian Burg a WebKit reviewer.
1819
1820         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
1821
1822 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
1823
1824         Multiple EWS or commit bots can pick up processing of the same patch
1825         https://bugs.webkit.org/show_bug.cgi?id=136793
1826
1827         Reviewed by Ryosuke Niwa.
1828
1829         Change timeout from one hour to two hours. This will let bots finish, and in the
1830         unlikely event of a bot being frozen, will only delay patch processing restart by
1831         one hour.
1832
1833         * QueueStatusServer/app.yaml:
1834         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
1835
1836 2014-09-11  Andy Estes  <aestes@apple.com>
1837
1838         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
1839         https://bugs.webkit.org/show_bug.cgi?id=136768
1840
1841         Reviewed by Tim Horton.
1842
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
1845         (TestWebKitAPI::TEST):
1846
1847 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1848
1849         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
1850         https://bugs.webkit.org/show_bug.cgi?id=136669
1851
1852         Reviewed by Antti Koivisto.
1853
1854         * Scripts/run-gtk-tests:
1855         (TestRunner): Unskip SSL test.
1856
1857 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
1858
1859         Strip extraneous AVFoundation and CoreMedia logging
1860         https://bugs.webkit.org/show_bug.cgi?id=136747
1861
1862         Reviewed by Jer Noble.
1863
1864         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1865         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
1866
1867         * Scripts/webkitpy/port/base.py:
1868         (Port.stderr_patterns_to_strip): Base class, empty list
1869
1870         * Scripts/webkitpy/port/driver.py:
1871         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
1872
1873         * Scripts/webkitpy/port/ios.py:
1874         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
1875
1876         * Scripts/webkitpy/port/mac.py:
1877         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
1878
1879
1880 2014-09-11  Michael Saboff  <msaboff@apple.com>
1881
1882         lldb_webkit.py:btjs doesn't work with release builds
1883         https://bugs.webkit.org/show_bug.cgi?id=136760
1884
1885         Reviewed by Jer Noble.
1886
1887         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
1888         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
1889         we can't get a valid result from trying either call.  In that case, we fallback to
1890         just showing the PC.  Also added check for both entry points.  If neither is found,
1891         we issue a warning and output the stack trace without JavaScript annotations.
1892
1893         * lldb/lldb_webkit.py:
1894         (btjs):
1895
1896 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
1897
1898         webkitpy test failures from import-w3c-tests
1899         https://bugs.webkit.org/show_bug.cgi?id=136752
1900
1901         Reviewed by Bem Jones-Bey.
1902
1903         This patch fixes a bug in import-w3c-tests where we were appending
1904         the wrong set of files to the copy_list. This also updates the tests
1905         to clear the failures introduced in the patch for bug 135929.
1906
1907         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1908         (W3CTestConverterTest.test_read_prefixed_property_list):
1909         * Scripts/webkitpy/w3c/test_parser.py:
1910         (TestParser.analyze_test):
1911         (TestParser.support_files):
1912         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1913
1914 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
1915
1916         Blink merge: Speculative fix for windows run-webkit-tests hangs
1917         https://bugs.webkit.org/show_bug.cgi?id=136727
1918
1919         Reviewed by Csaba Osztrogonác.
1920
1921         Merged from Blink (patch by Dirk Pranke):
1922         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
1923
1924         * Scripts/webkitpy/common/system/executive.py:
1925         (Executive.kill_process):
1926
1927 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1928
1929         Added myself as a committer.
1930
1931         Unreviewed.
1932
1933         * Scripts/webkitpy/common/config/contributors.json:
1934
1935 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
1936
1937         [JavaScriptCore] Fix FTL on platform EFL.
1938         https://bugs.webkit.org/show_bug.cgi?id=133571
1939
1940         Reviewed by Filip Pizlo.
1941
1942         * efl/install-dependencies: Revert r169181.
1943         * efl/jhbuild.modules: Clone and build a custom branch.
1944         This branch contains some fix for FTL of platform EFL.
1945         The branch is a fork of llvm r206311.
1946
1947 2014-09-10  Tanay C  <tanay.c@samsung.com>
1948
1949         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
1950         https://bugs.webkit.org/show_bug.cgi?id=136698
1951
1952         Reviewed by Gyuyoung Kim.
1953
1954         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
1955         (on_mouse_wheel): Added.
1956         (window_free):
1957         (window_create):
1958
1959 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
1960
1961         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
1962         https://bugs.webkit.org/show_bug.cgi?id=136284
1963
1964         Reviewed by Gyuyoung Kim.
1965
1966         * MiniBrowser/efl/main.c:
1967         (window_create):
1968
1969 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
1970
1971         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
1972         https://bugs.webkit.org/show_bug.cgi?id=135929
1973
1974         Reviewed by Bem Jones-Bey.
1975
1976         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
1977         were made when this script was originally written with respect to relative paths
1978         in ref files. This patch updates import-w3c-tests to update paths in ref files if
1979         they move relative to the test file.
1980
1981
1982         * Scripts/webkitpy/w3c/test_converter.py:
1983         (convert_for_webkit):
1984         (_W3CTestConverter.__init__):
1985         (_W3CTestConverter.convert_reference_relpaths):
1986         (_W3CTestConverter.convert_style_data):
1987         (_W3CTestConverter.convert_attributes_if_needed):
1988         * Scripts/webkitpy/w3c/test_importer.py:
1989         (TestImporter.find_importable_tests):
1990         (TestImporter.import_tests):
1991         * Scripts/webkitpy/w3c/test_parser.py:
1992         (TestParser.load_file):
1993         (TestParser.analyze_test):
1994         (TestParser.support_files):
1995
1996 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1997
1998         [GTK] allow overwriting destination of download
1999         https://bugs.webkit.org/show_bug.cgi?id=136372
2000
2001         Reviewed by Carlos Garcia Campos.
2002
2003         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2004         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2005         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2006         (createFileAtDestination): Added
2007         (testDownloadOverwriteDestinationAllowed): Added
2008         (testDownloadOverwriteDestinationDisallowed): Added
2009         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2010         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2011         (beforeAll): New tests
2012
2013 2014-08-05  David Farler  <dfarler@apple.com>
2014
2015         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2016         https://bugs.webkit.org/show_bug.cgi?id=135551
2017
2018         Reviewed by Daniel Bates.
2019
2020         Prevent printing invalid Unicode strings going to stderr.
2021         Also, make filesystem.py more tolerant about receiving
2022         Unicode (encoded as UTF-8) when writing to files, in the
2023         rare case that an NSError description will make it to
2024         stderr, such as -[LTRelayController createUniqueApp].
2025
2026         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2027         (-[LTRelayController launchSimulator]): Removed.
2028         (-[LTRelayController createUniqueApp]):
2029         Don't explicitly try to uninstall the app. It is automatically handled
2030         when installing an app with the same bundle identifier.
2031         (-[LTRelayController start]):
2032         (-[LTRelayController bootDevice]): Removed.
2033         The device already boots as a part of starting the simulator. Attempting
2034         to boot a second time may cause spurious stderr output.
2035         * Scripts/webkitpy/port/driver.py:
2036         (IOSSimulatorDriver._setup_environ_for_driver):
2037         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2038         Open the iOS Simulator once instead of the LayoutTestRelay trying
2039         to do it.
2040         * Scripts/webkitpy/port/ios.py:
2041         (IOSSimulatorPort._get_crash_log):
2042         Make sure stderr is at least an empty string.
2043         (IOSSimulatorPort):
2044         (IOSSimulatorPort.developer_dir):
2045         New property for setting up DEVELOPER_DIR in the driver environment.
2046
2047 2014-09-09  Dan Bernstein  <mitz@apple.com>
2048
2049         Clean up the MiniBrowser Xcode project
2050         https://bugs.webkit.org/show_bug.cgi?id=136684
2051
2052         Reviewed by Tim Horton.
2053
2054         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2055         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2056         WebKit2.framework. Upgraded project file version.
2057
2058 2014-09-09  Daniel Bates  <dbates@webkit.org>
2059
2060         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2061         https://bugs.webkit.org/show_bug.cgi?id=136379
2062
2063         Reviewed by David Kilzer.
2064
2065         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2066         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2067         and sets a property on F (say, the executable bit).
2068
2069         * Scripts/svn-apply:
2070         (patch): Only add file if the diff has text chunks.
2071         * Scripts/svn-unapply:
2072         (patch): Only delete added file if the diff has text chunks.
2073
2074 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2075
2076         [GTK] Unreviewed GTK gardening.
2077
2078         * Scripts/run-gtk-tests:
2079         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2080
2081 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2082
2083         Update my email in contributors.json
2084         https://bugs.webkit.org/show_bug.cgi?id=136671
2085
2086         Reviewed by Andreas Kling.
2087
2088         * Scripts/webkitpy/common/config/contributors.json:
2089
2090 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2091
2092         [EFL] Enable fixed layout by default
2093         https://bugs.webkit.org/show_bug.cgi?id=136607
2094
2095         Reviewed by Csaba Osztrogonác.
2096
2097         Fixed layout is being used by Tizen platform by default. However, the feature
2098         has still many defects now. So, we need to enable it by default, then should fix
2099         those bugs. 
2100
2101         * MiniBrowser/efl/main.c:
2102
2103 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2104
2105         Remove FILTERS flag
2106         https://bugs.webkit.org/show_bug.cgi?id=136571
2107
2108         Reviewed by Darin Adler.
2109
2110         * Scripts/webkitperl/FeatureList.pm:
2111
2112 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2113
2114         Dashboard metrics should ignore commits that didn't trigger builds
2115         https://bugs.webkit.org/show_bug.cgi?id=136618
2116
2117         Reviewed by Darin Adler.
2118
2119         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2120         other platforms etc. It does not make sense to count wait time for these, as it
2121         can be arbitrarily long.
2122
2123         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2124
2125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2126         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2127
2128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2129         We used to walk the timeline to see which revisions are fully tested, but that's not
2130         correct. A revision that's only tested by a subset of queues finishes independently
2131         of another that's tested by another subset. Now, we just search for the answer for
2132         each revision individually.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2135         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2136         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2137
2138 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2139
2140         Remove EWebLauncher from webkitdirs.pm
2141         https://bugs.webkit.org/show_bug.cgi?id=136622
2142
2143         Reviewed by Gyuyoung Kim.
2144
2145         * Scripts/webkitdirs.pm:
2146         (launcherName):
2147
2148 2014-09-06  Sam Weinig  <sam@webkit.org>
2149
2150         XPCPtr should be converted into an all purpose smart pointer for os_objects
2151         https://bugs.webkit.org/show_bug.cgi?id=136602
2152
2153         Reviewed by Darin Adler.
2154
2155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2156         * TestWebKitAPI/Tests/WTF/darwin: Added.
2157         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2158         Add basic unit tests for OSObjectPtr.
2159
2160 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2161
2162         Unreviewed. Add myself as a committer.
2163
2164         * Scripts/webkitpy/common/config/contributors.json:
2165
2166 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2167
2168         Unreviewed, EFL build fix when SHARED_CORE is on.
2169
2170         * TestWebKitAPI/PlatformEfl.cmake:
2171
2172 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2173
2174         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2175         
2176         Reviewed by Daniel Bates.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/config.json:
2179
2180 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2181
2182         Buildbot metrics page gives wrong results after a new bot gets added
2183         https://bugs.webkit.org/show_bug.cgi?id=136516
2184
2185         Reviewed by Tim Horton.
2186
2187         Part 2: Fix elapsed times.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2190         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2191         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2192
2193 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2194
2195         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2196         https://bugs.webkit.org/show_bug.cgi?id=136562
2197
2198         Reviewed by Martin Robinson.
2199
2200         * Scripts/run-gtk-tests:
2201         (TestRunner): Remove failure expectations for tests that now pass.
2202
2203 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2204
2205         Dashboard metrics page wastes a lot of time sorting iterations
2206         https://bugs.webkit.org/show_bug.cgi?id=136559
2207
2208         Reviewed by Tim Horton.
2209
2210         Also fixes comments here and there, and adds a missing "var".
2211
2212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2213         (BuildbotIteration.prototype._parseData):
2214         (BuildbotIteration.prototype._updateWithData):
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2216         (BuildbotQueue.prototype.loadAll):
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2218         (Analyzer.prototype._countTimes):
2219
2220 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2221
2222         [GTK] Unreviewed GTK gardening.
2223
2224         * Scripts/run-gtk-tests:
2225         (TestRunner): Skip tests failing since r173272.
2226
2227 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2228
2229         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2230         https://bugs.webkit.org/show_bug.cgi?id=136561
2231
2232         Reviewed by Tim Horton.
2233         
2234         Log for calloc() and CGBitmapContextCreate() failures.
2235
2236         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2237         (createBitmapContext):
2238         (createBitmapContextFromWebView):
2239
2240 2014-09-04  Andy Estes  <aestes@apple.com>
2241
2242         Fix the Mac Production build after r173283.
2243
2244         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2245
2246 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2247
2248         [Win] webkitpy test suite frequently fails to complete
2249         https://bugs.webkit.org/show_bug.cgi?id=136546
2250
2251         Reviewed by Daniel Bates.
2252
2253         Properly convert the ASCII crash log produced by ntsd into
2254         a unicode string as early as possible so that we handle it
2255         properly when generating our logs and other test support output.
2256
2257         We were mixing ASCII/unicode strings under Windows, which was
2258         causing test system failures when we processed some crash logs.
2259
2260         Also do a better job of handling garbage pid entries in the
2261         Cygwin lock files.
2262
2263         * Scripts/webkitpy/common/system/crashlogs.py:
2264         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2265         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2266         handle the strings as unicode from that point on.
2267         * Scripts/webkitpy/port/http_lock.py:
2268         (HttpLock._current_lock_pid): Add logging and handle case of
2269         the current_pid failing to cleanly convert to 'int'.
2270         * Scripts/webkitpy/port/win.py:
2271         (WinPort): Add 64-bit architecture as a known target for the
2272         Windows build.
2273
2274 2014-09-04  Andy Estes  <aestes@apple.com>
2275
2276         Address additional review feedback after landing r173283.
2277
2278         Reviewed by Daniel Bates.
2279
2280         * DumpRenderTree/config.h: Removed redundant includes.
2281         * TestWebKitAPI/config.h: Ditto.
2282         * WebKitTestRunner/config.h: Ditto.
2283
2284 2014-09-03  Andy Estes  <aestes@apple.com>
2285
2286         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2287         https://bugs.webkit.org/show_bug.cgi?id=136521
2288
2289         Reviewed by Anders Carlsson.
2290
2291         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2292         * TestWebKitAPI/config.h: Ditto.
2293         * WebKitTestRunner/config.h: Ditto.
2294
2295 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2296
2297         REGRESSION: Dashboard metrics page aggregation counts performance bots
2298         https://bugs.webkit.org/show_bug.cgi?id=136539
2299
2300         Reviewed by Tim Horton.
2301
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2303
2304 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2305
2306         [Win] Perl test fix.
2307
2308         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2309         VersionStamp.exe tool, not just the driver script.
2310
2311 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2312
2313         Remove CSS_FILTERS flag
2314         https://bugs.webkit.org/show_bug.cgi?id=136529
2315
2316         Reviewed by Dirk Schulze.
2317
2318         * Scripts/webkitperl/FeatureList.pm:
2319
2320 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2321
2322         Unreviewed, rolling out r173201.
2323         https://bugs.webkit.org/show_bug.cgi?id=136538
2324
2325         Improves the situation but also introduces additional crashes.
2326         (Requested by zdobersek on #webkit).
2327
2328         Reverted changeset:
2329
2330         "GMainLoopSource is exposed to race conditions"
2331         https://bugs.webkit.org/show_bug.cgi?id=135800
2332         http://trac.webkit.org/changeset/173201
2333
2334 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2335
2336         Buildbot metrics page gives wrong results after a new bot gets added
2337         https://bugs.webkit.org/show_bug.cgi?id=136516
2338
2339         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2340         if all the bots that ever had results before this time are green.
2341
2342         This doesn't (and cannot) address situations where the bot gets removed and then
2343         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2344         know that it was ever displayed on the dashboard.
2345
2346         Reviewed by Darin Adler.
2347
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2349         (Analyzer.prototype._dashboardIsAllGreen):
2350         (Analyzer.prototype._updateStretchOfRedCounters):
2351         (Analyzer.prototype._countPercentageOfGreen):
2352         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2353
2354 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2355
2356         [Win] Unreviewed test fix.
2357
2358         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2359         test if user doesn't have the VersionStamp.exe program.
2360
2361 2014-09-03  Dana Burkart  <dburkart@apple.com>
2362
2363         Unreviewed. Add myself as a committer.
2364
2365         * Scripts/webkitpy/common/config/contributors.json:
2366
2367 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2368
2369         build.webkit.org/dashboard performance popover is unstyled
2370         https://bugs.webkit.org/show_bug.cgi?id=136499
2371
2372         Reviewed by Tim Horton.
2373
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2375         (.performance-popover):
2376         (.performance-popover .dashboard-link):
2377
2378 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2379
2380         Create tests for type profiling
2381         https://bugs.webkit.org/show_bug.cgi?id=136161
2382
2383         Reviewed by Geoffrey Garen.
2384
2385         Have run-javascriptcore-tests run the newly created
2386         tests for the type profiler.
2387
2388         * Scripts/run-javascriptcore-tests:
2389         * Scripts/run-jsc-stress-tests:
2390
2391 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2392
2393         [Win] Revise test environment for Windows build.
2394         https://bugs.webkit.org/show_bug.cgi?id=136486
2395
2396         Reviewed by David Kilzer.
2397
2398         The various calls to get the Safari path really only have
2399         meaning on the Mac. Other ports get access to the build
2400         and test environment separately, so remove the various
2401         checks in the Safari-specific code to simplify things.
2402
2403         Remove some 64-bit hacks used on Windows now that the
2404         various tools know how to find the 64-bit runtime environment.
2405
2406         * Scripts/run-javascriptcore-tests: 
2407         * Scripts/webkitdirs.pm:
2408         (safariPathFromSafariBundle): Revise to expect Mac.
2409         (installedSafariPath): Ditto.
2410         (safariPath): Ditto.
2411         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2412         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2413         argument for Windows runs.
2414
2415 2014-09-03  Dana Burkart  <dburkart@apple.com>
2416
2417         Dashboard should show performance bots.
2418         https://bugs.webkit.org/show_bug.cgi?id=136386
2419
2420         Reviewed by Alexey Proskuryakov.
2421
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2423         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2424         (BuildbotIteration.prototype._parseData):
2425         Support possible performance failures.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2428         New QueueView to manage the way we present performance data.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2431         (BuildbotQueue):
2432         Support new 'performance' and 'performanceTestName' keys.
2433
2434
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2436         Add performance column to the main page.
2437
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2439         (WebKitBuildbot):
2440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2441         (body):
2442         Make sure everything fits on 13 inch screens.
2443
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2445
2446 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2447
2448         GMainLoopSource is exposed to race conditions
2449         https://bugs.webkit.org/show_bug.cgi?id=135800
2450
2451         Reviewed by Carlos Garcia Campos.
2452
2453         Add a unit test for GMainLoopSource that tests different
2454         types of rescheduling tasks on already-active sources.
2455
2456         * TestWebKitAPI/PlatformGTK.cmake:
2457         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2458         (GMainLoopSourceTest::GMainLoopSourceTest):
2459         (GMainLoopSourceTest::~GMainLoopSourceTest):
2460         (GMainLoopSourceTest::runLoop):
2461         (GMainLoopSourceTest::finish):
2462         (GMainLoopSourceTest::source):
2463         (testGMainLoopSourceBasicRescheduling):
2464         (testGMainLoopSourceReentrantRescheduling):
2465         (testGMainLoopSourceDifferentThreadRescheduling):
2466         (beforeAll):
2467         (afterAll):
2468         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2469         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2470         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2471         (TestWebKitAPI::GMainLoopSourceTest::finish):
2472         (TestWebKitAPI::GMainLoopSourceTest::source):
2473         (TestWebKitAPI::TEST):
2474
2475 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2476
2477         Make sure WK1 prefs are initialized in MiniBrowser
2478         https://bugs.webkit.org/show_bug.cgi?id=136465
2479
2480         Reviewed by Tim Horton.
2481         
2482         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2483         for WK2 windows, to make sure that WebPreferences are updated (to get
2484         layer borders to work consistently).
2485
2486         * MiniBrowser/mac/WK1BrowserWindowController.m:
2487         (-[WK1BrowserWindowController awakeFromNib]):
2488
2489 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2490
2491         check-webkit-style should complain about C++ comments in Platform.h
2492         https://bugs.webkit.org/show_bug.cgi?id=133802
2493
2494         Reviewed by Csaba Osztrogonác.
2495
2496         * Scripts/webkitpy/style/checkers/cpp.py:
2497         (check_platformh_comments):
2498         (_process_lines):
2499         (CppChecker):
2500         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2501         (CppStyleTest.test_platformh_comment):
2502
2503 2014-09-02  Brendan Long  <self@brendanlong.com>
2504
2505         [Gtk] Make install-dependencies work on Arch Linux
2506         https://bugs.webkit.org/show_bug.cgi?id=136374
2507
2508         Reviewed by Philippe Normand.
2509
2510         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2511
2512 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2513
2514         Provide column numbers to DTrace willExecute/didExecute probes
2515         https://bugs.webkit.org/show_bug.cgi?id=136434
2516
2517         Reviewed by Antti Koivisto.
2518
2519         Create a directory for DTrace scripts. Add an example script that
2520         shows how to use static probes provided by JavaScriptCore's profiler.
2521
2522         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2523
2524 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2525
2526         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2527         https://bugs.webkit.org/show_bug.cgi?id=136431
2528
2529         Reviewed by Martin Robinson.
2530
2531         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2532         Add missing dependencies for librsvg (glib and cairo).
2533
2534 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2535
2536         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2537         https://bugs.webkit.org/show_bug.cgi?id=136425
2538
2539         Reviewed by Martin Robinson.
2540
2541         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2542
2543 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2544
2545         Update my list of email addresses in contributors.json
2546         https://bugs.webkit.org/show_bug.cgi?id=136424
2547
2548         Reviewed by Gyuyoung Kim.
2549
2550         * Scripts/webkitpy/common/config/contributors.json:
2551
2552 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2553
2554         [RJST] eager-no-cjit should really mean eager
2555         https://bugs.webkit.org/show_bug.cgi?id=136407
2556
2557         Reviewed by Mark Hahnenberg.
2558         
2559         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2560         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2561         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2562         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2563         threshold setting that NO_CJIT_OPTIONS was currently setting
2564         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2565         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2566         
2567         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2568
2569         * Scripts/run-jsc-stress-tests:
2570
2571 2014-08-29  Daniel Bates  <dabates@apple.com>
2572
2573         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2574         https://bugs.webkit.org/show_bug.cgi?id=136388
2575
2576         Reviewed by David Kilzer.
2577
2578         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2579         support building a command line tool for the iOS Simulator. You must run this
2580         script as root.
2581
2582         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2583         iOS Simulator SDK with the product- and package- type definitions to build a
2584         command line tool, if applicable.
2585
2586         * Scripts/configure-xcode-for-ios-development: Added.
2587
2588 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2589
2590         Remove Windows WebKit2 code from TestWebKitAPI
2591         https://bugs.webkit.org/show_bug.cgi?id=136385
2592
2593         Reviewed by Alexey Proskuryakov.
2594
2595         * TestWebKitAPI/PlatformUtilities.h:
2596         * TestWebKitAPI/PlatformWebView.h:
2597         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2598         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2599         (TestWebKitAPI::TEST): Deleted.
2600         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2601         (TestWebKitAPI::TEST):
2602         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2603         (TestWebKitAPI::TEST):
2604         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2605         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2606         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2607         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2608         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2609         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2610         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2611
2612 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2613
2614         [JSC] Some JSC tests are dependent on the machine time zone.
2615         https://bugs.webkit.org/show_bug.cgi?id=136363
2616
2617         Reviewed by Filip Pizlo.
2618
2619         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
2620         Unskip the tests that were skipped on r99580.
2621
2622 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2623
2624         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
2625         https://bugs.webkit.org/show_bug.cgi?id=135560
2626
2627         Reviewed by Gyuyoung Kim.
2628
2629         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
2630
2631 2014-08-28  Daniel Bates  <dabates@apple.com>
2632
2633         [Win] update-webkit should update auxiliary libs by default
2634
2635         Reviewed by Dan Bernstein.
2636
2637         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
2638         from updating the Windows auxiliary libs by default. We should make update-webkit update the
2639         Windows auxiliary libs by default. This will make its behavior match its usage text.
2640
2641         * Scripts/update-webkit:
2642
2643 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
2644
2645         build-webkit --inspector-frontend tries to copy files from old inspector path
2646         https://bugs.webkit.org/show_bug.cgi?id=136346
2647
2648         Reviewed by Timothy Hatcher.
2649
2650         Remove the old code path for copying inspector resources. It doesn't work.
2651         Complain if this option is passed to CMake-based builds.
2652
2653         * Scripts/build-webkit:
2654         * Scripts/webkitdirs.pm:
2655         (copyInspectorFrontendFiles): Deleted.
2656
2657 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
2658
2659         Dashboard metrics page could show longest stretch of red
2660         https://bugs.webkit.org/show_bug.cgi?id=136334
2661
2662         Reviewed by Sam Weinig.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2665         (Analyzer.prototype._updateStretchOfRedCounters):
2666         (Analyzer.prototype._countPercentageOfGreen):
2667         When counting percentage of green, also keep track of how long the page was red.
2668
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2670         (MetricsView.prototype._update.addDivider):
2671         (MetricsView.prototype._update.appendQueueResults):
2672         Show it in aggregate queues (can't think of a reason to have it in individual ones).
2673
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2675         Changed to use an explicit divider element between green time and performance groups,
2676         as there are too many combinations to easily express in CSS.
2677
2678 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2679
2680         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
2681         https://bugs.webkit.org/show_bug.cgi?id=136248
2682
2683         Reviewed by Gustavo Noronha Silva.
2684
2685         Add new test case for webkit_uri_response_get_http_headers().
2686
2687         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2688         (testURIResponseHTTPHeaders):
2689         (serverCallback):
2690         (beforeAll):
2691
2692 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2693
2694         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2695         https://bugs.webkit.org/show_bug.cgi?id=131668
2696
2697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2698         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
2699
2700 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2701
2702         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
2703         https://bugs.webkit.org/show_bug.cgi?id=136264
2704
2705         Reviewed by Simon Fraser.
2706         
2707         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
2708         functions. ->snappedIntSize()/snapSizeToDevicePixel().
2709         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
2710
2711         Covered by existing tests.
2712
2713         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2714         (TestWebKitAPI::TEST): Deleted.
2715
2716 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2717
2718         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2719         https://bugs.webkit.org/show_bug.cgi?id=131668
2720
2721         Reviewed by Daniel Bates.
2722
2723         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
2724         to not just hardcode.
2725
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2727         (EWS.prototype.queueStatusURL): Added.
2728
2729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2730         (EWSQueue.prototype.get statusPageURL): Use the above function.
2731         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
2732
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2734         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
2735         are no patches in the queue. The popover has other useful information, such as charts
2736         link and bot status.
2737
2738 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2739
2740         https://bugs.webkit.org/show_bug.cgi?id=136317
2741         Dashboard metrics page sometimes shows 0 for best time
2742
2743         Reviewed by Tim Horton.
2744
2745         This also affects regular dashboard display in a good way - iterations that failed
2746         due to infrastructure misbehavior will more reliably show up as yellow and not red.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2749         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
2750         updated if we rename steps.
2751         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
2752         do it once.
2753         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
2754         that failed e.g. at downloading built archive step are not productive.
2755
2756 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
2757
2758         [Win] Unreviewed gardening.
2759
2760         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
2761         of logs assembled into the final build output.
2762
2763 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2764
2765         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
2766         https://bugs.webkit.org/show_bug.cgi?id=136196
2767
2768         Reviewed by Timothy Hatcher.
2769
2770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
2771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
2772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
2773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
2774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
2775         A date range picker control with dependencies.
2776         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
2777         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
2778         (it didn't happen again upon re-opening the picker).
2779         - Made made style tweaks to match Dashboard UI.
2780
2781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2782         Don't create objects that are not needed by the given app, and thus are not loaded at all.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
2785         Math to count all the things. Only supports open source tree and trunk at the moment,
2786         but written with internal tree and branches in mind.
2787
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
2789         Like dashboard Main.js, draws the UI and creates all necessary objects.
2790
2791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
2792         A view for table cells.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2795         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
2796         Metrics page has individual platforms initially scrolled away form the view, so 
2797         it needs to scroll down to reveal what's being configured.
2798
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2800         Added Array.prototype.average and Array.prototype.median.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2803         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
2804         in settings mode.
2805
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2807         Additional style rules.
2808
2809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2810         The metrics page.
2811
2812 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2813
2814         Remove networkinfo watch category in watchlist
2815         https://bugs.webkit.org/show_bug.cgi?id=136279
2816
2817         Reviewed by Alexey Proskuryakov.
2818
2819         Network info was removed. So, it is not needed anymore.
2820
2821         * Scripts/webkitpy/common/config/watchlist:
2822
2823 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2824
2825         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
2826         https://bugs.webkit.org/show_bug.cgi?id=136281
2827
2828         Reviewed by Tim Horton.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2831         Track and expose whether the itertion is being loaded. Made update() a no-op if
2832         the iteration is already being loaded.
2833
2834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2835         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
2836         loading everything at once, ask the queue to load a little more. We can always repeat
2837         if we still don't have enough data.
2838
2839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2840         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
2841         10 more iterations intelligently.
2842
2843 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2844
2845         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
2846         https://bugs.webkit.org/show_bug.cgi?id=136283
2847
2848         Reviewed by Tim Horton.
2849
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2851         Don't.
2852
2853 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2854
2855         build.webkit.org/dashboard raises an exception after a hidden platform is removed
2856         https://bugs.webkit.org/show_bug.cgi?id=136282
2857
2858         Reviewed by Tim Horton.
2859
2860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2861         (updateHiddenPlatforms): Check that the platform is still valid.
2862
2863 2014-08-26  Matt Lilek  <mrl@apple.com>
2864
2865         Add WebKit SPI to control the navigator.standalone property
2866         https://bugs.webkit.org/show_bug.cgi?id=136189
2867
2868         Reviewed by Andy Estes.
2869
2870         Add API test for WKPreferences
2871
2872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2873         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2874         (TEST):
2875
2876 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2877
2878         Remove ENABLE_DRT environment variable to enable SHARED_CORE
2879         https://bugs.webkit.org/show_bug.cgi?id=136205
2880
2881         Reviewed by Andrei Bucur.
2882
2883         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
2884         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
2885
2886         * Scripts/webkitdirs.pm:
2887         (generateBuildSystemFromCMakeProject):
2888
2889 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2890
2891         [Win] Version stamp should include package-level version
2892         https://bugs.webkit.org/show_bug.cgi?id=136266
2893         <rdar://problem/18134138>
2894
2895         Reviewed by David Kilzer.
2896
2897         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
2898         tests for the full 3+ digit version.
2899         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2900         Confirm that the final output DLL uses the 3+ digit version.
2901
2902 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2903
2904         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
2905         https://bugs.webkit.org/show_bug.cgi?id=136258
2906         <rdar://problem/18134138>
2907
2908         Reviewed by Tim Horton.
2909
2910         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
2911         values from passing through the 32-bit OLE_HANDLE data type.
2912
2913         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2914         (AccessibilityController::rootElement):
2915         * DumpRenderTree/win/DumpRenderTree.cpp:
2916         (resetWebViewToConsistentStateBeforeTesting):
2917         (runTest):
2918         (createWebViewAndOffscreenWindow):
2919         * DumpRenderTree/win/FrameLoadDelegate.h:
2920         (FrameLoadDelegate::didReceiveIcon):
2921         * DumpRenderTree/win/TestRunnerWin.cpp:
2922         (TestRunner::setWindowIsKey):
2923         * DumpRenderTree/win/UIDelegate.cpp:
2924         (UIDelegate::trackCustomPopupMenu):
2925         (UIDelegate::drawHeaderInRect):
2926         (UIDelegate::drawFooterInRect):
2927         (UIDelegate::webViewClose):
2928         (UIDelegate::webViewFocus):
2929         (UIDelegate::webViewSetCursor):
2930         (UIDelegate::drawBackground):
2931         * DumpRenderTree/win/UIDelegate.h:
2932         (UIDelegate::webViewFirstResponder):
2933         (UIDelegate::makeFirstResponder):
2934         (UIDelegate::contextMenuItemsForElement):
2935         (UIDelegate::addCustomMenuDrawingData):
2936         (UIDelegate::cleanUpCustomMenuDrawingData):
2937         (UIDelegate::webViewLostFocus):
2938         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2939         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
2940         * WinLauncher/PrintWebUIDelegate.cpp:
2941         (PrintWebUIDelegate::drawHeaderInRect):
2942         (PrintWebUIDelegate::drawFooterInRect):
2943         * WinLauncher/PrintWebUIDelegate.h:
2944         (PrintWebUIDelegate::webViewFirstResponder):
2945         (PrintWebUIDelegate::makeFirstResponder):
2946         (PrintWebUIDelegate::contextMenuItemsForElement):
2947         (PrintWebUIDelegate::trackCustomPopupMenu):
2948         (PrintWebUIDelegate::addCustomMenuDrawingData):
2949         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
2950         * WinLauncher/WinLauncher.cpp:
2951         (WinLauncher::prepareViews):
2952         * WinLauncher/WinLauncherWebHost.h:
2953         (WinLauncherWebHost::didReceiveIcon):
2954
2955 2014-08-26  Daniel Bates  <dabates@apple.com>
2956
2957         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
2958
2959         Rubber-stamped by Tim Horton.
2960
2961         The Windows and iOS ports are the only ports that make use of WebCore headers
2962         in DumpRenderTree.
2963
2964         * DumpRenderTree/config.h:
2965
2966 2014-08-26  Dan Bernstein  <mitz@apple.com>
2967
2968         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
2969         https://bugs.webkit.org/show_bug.cgi?id=136254
2970
2971         Reviewed by Tim Horton.
2972
2973         * Scripts/webkitdirs.pm:
2974         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
2975         not the invoking script.
2976
2977 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
2978
2979         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
2980         https://bugs.webkit.org/show_bug.cgi?id=136127
2981
2982         Reviewed by Gyuyoung Kim.
2983
2984         Add espeak dependency.
2985
2986         * efl/install-dependencies:
2987
2988 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2989
2990         Remove a little more accidentally landed code from r172891.
2991
2992         iteration.branch also wasn't meant to be landed.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2995         (BuildbotIteration.prototype._parseData):
2996
2997 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2998
2999         REGRESSION (r172891): Internal dashboard is broken.
3000
3001         Removing some accidentally landed code - I needed "changes" for another patch, but
3002         not here, and then I decided to not use it anyway.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3005         (BuildbotIteration.prototype._parseData):
3006
3007 2014-08-25  Daniel Bates  <dabates@apple.com>
3008
3009         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
3010         (https://bugs.webkit.org/show_bug.cgi?id=136108)
3011
3012         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
3013         so that we can compile DumpRenderTree for iOS.
3014
3015         * DumpRenderTree/config.h:
3016
3017 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3018
3019         Make build.webkit.org/dashboard work with changeset_show_files=location
3020         https://bugs.webkit.org/show_bug.cgi?id=136237
3021
3022         Reviewed by Tim Horton.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3025         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
3026         from description before getting title, and also actually parse the location into
3027         result object when available.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3030         (String.prototype.startsWith): Added.
3031
3032 2014-08-25  Tanay C  <tanay.c@samsung.com>
3033
3034         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
3035         https://bugs.webkit.org/show_bug.cgi?id=135795
3036
3037         Reviewed by Gyuyoung Kim.
3038
3039         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
3040         (history_list_hide): Hiding and dereferencing the history list and items
3041         (on_key_down):
3042         (on_mouse_down):
3043         (on_back_button_clicked): Early return for longpress 
3044         (on_forward_button_clicked): Early return for longpress 
3045         (list_item_label_get): Populate item labels
3046         (on_list_item_select): Navigates on selection from history list
3047         (navigation_button_longpress_process): Populates the history list and displays it
3048         (on_forward_button_longpress):
3049         (on_back_button_longpress):
3050         (window_create): Add the widget for history list
3051
3052 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3053
3054         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
3055         https://bugs.webkit.org/show_bug.cgi?id=136152
3056
3057         Reviewed by Philippe Normand.
3058
3059         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
3060         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
3061         Cherry pick upstream patches daa194 and 4e3d101.
3062
3063 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
3064
3065         GenericHashTraits::peek() is producing copies of passed-in temporary values
3066         https://bugs.webkit.org/show_bug.cgi?id=131461
3067
3068         Reviewed by Darin Adler.
3069
3070         Add a test case that checks the number of copies and moves of the mapped objects
3071         when calling HashMap::get(). Exactly one copy of the mapped value should be
3072         performed when there exists a value that is mapped to the specified key, and
3073         exactly one move and no copies of the empty value should be performed when there
3074         isn't any mapped value for the specified key.
3075
3076         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
3077         (CopyMoveCounter::TestingScope::TestingScope):
3078         (CopyMoveCounter::CopyMoveCounter):
3079         (CopyMoveCounter::operator=):
3080         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3081         (TestWebKitAPI::TEST):
3082
3083 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
3084
3085         [EFL] Introduce DEVELOPER_MODE
3086         https://bugs.webkit.org/show_bug.cgi?id=135884
3087
3088         Reviewed by Gyuyoung Kim.
3089
3090         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
3091         (generateBuildSystemFromCMakeProject):
3092
3093 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
3094
3095         build.webkit.org/dashboard unnecessarily loads results of hidden queues
3096         https://bugs.webkit.org/show_bug.cgi?id=136195
3097
3098         Reviewed by Tim Horton.
3099
3100         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
3101
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3104         Don't start an update just because a queue object was created. Periodic updates
3105         are triggered by views, so it only makes sense to do the same for the initial update.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3108         Now that Trac object doesn't auto-load, start loading here.
3109
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3111         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
3112         a data member added by subclasses later. With this.platform being undefined, it
3113         always looked like this queue was not hidden.
3114         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
3115
3116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3117         (Trac): Don't load anything here, the client may choose to load a custom date range.
3118         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
3119
3120 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3121
3122         build.webkit.org/dashboard: Further improve Trac loading
3123         https://bugs.webkit.org/show_bug.cgi?id=136174
3124
3125         Reviewed by Timothy Hatcher.
3126
3127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3128         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
3129         error, the oldest commit within the range wasn't returned. The correct argument for
3130         "no limit" is 0.
3131         (Trac.prototype.load): Added a function to load a specific time range.
3132         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
3133         positioned with regards to ones that were already known.
3134
3135 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3136
3137         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
3138         https://bugs.webkit.org/show_bug.cgi?id=136182
3139
3140         Reviewed by Timothy Hatcher.
3141
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3143         Make it possible to create a complete BuildbotIteration object with JSON, not only by
3144         loading data from the network.
3145
3146         An iteration has three states:
3147         1. Just created, it only knows the revision, and whether it's already finished.
3148         BuildbotIteration constructor used to create these.
3149         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
3150         3. Data about tests is fetched.
3151
3152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3153         Make it possible to pull all data from a buildbot queue. This needs to be better
3154         optimized eventually, as it's somewhat slow.
3155
3156 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3157
3158         Remove LevelDB.
3159         https://bugs.webkit.org/show_bug.cgi?id=136170
3160
3161         Reviewed by Gyuyoung Kim.
3162
3163         * Scripts/webkitpy/common/config/watchlist:
3164         * Scripts/webkitpy/style/checker.py:
3165
3166 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3167
3168         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
3169         https://bugs.webkit.org/show_bug.cgi?id=136153
3170
3171         Reviewed by Martin Robinson.
3172
3173         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
3174
3175 2014-08-21  Alex Christensen  <achristensen@webkit.org>
3176
3177         [Win] Another unreviewed build fix.
3178
3179         * DumpRenderTree/config.h:
3180         Defined WEBCORE_EXPORT on Windows.
3181
3182 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
3183
3184         [EFL][WK2] Minibrowser : Add stop button to abort page load
3185         https://bugs.webkit.org/show_bug.cgi?id=136122
3186
3187         Reviewed by Gyuyoung Kim.
3188
3189         * MiniBrowser/efl/main.c:
3190         (on_key_down):
3191         (on_stop_button_clicked): Callback for stop button press.
3192         (window_create):
3193
3194 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3195
3196         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
3197         https://bugs.webkit.org/show_bug.cgi?id=134070
3198
3199         Reviewed by Martin Robinson.
3200
3201         * Scripts/webkitpy/port/base.py:
3202         (Port.__init__): Set default _jhbuild_wrapper variable.
3203         (Port._should_use_jhbuild): Implement generic check.
3204         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
3205         to make it consistent with the other ports.
3206         * Scripts/webkitpy/port/gtk.py:
3207         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3208         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3209         querying the jhbuild with printenv. Also check that the path contains
3210         the libraries we expect. Preload this path only for XvfbDriver.
3211         * Scripts/webkitpy/port/xvfbdriver.py:
3212         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3213         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3214         configured at setup_environ_for_server()
3215         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3216         (XvfbDriverTest.make_driver): Get the port default environment.
3217         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3218         should include the environment that is passed when running Xvfb.
3219         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3220         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3221         (XvfbDriverTest.test_start_next_worker): Ditto.
3222         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3223         prevent future problems when the version is raised. Add also a
3224         comment with a warning.
3225         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3226         that has the llvm optimized Gallium libGL libraries.
3227
3228 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3229
3230         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3231         https://bugs.webkit.org/show_bug.cgi?id=136125
3232
3233         Reviewed by Csaba Osztrogonác.
3234
3235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3236         (RunLLINTCLoopTests.countFailures):
3237         (Run32bitJSCTests.countFailures):
3238         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3239         (RunLLINTCLoopTestsTest):
3240         (RunLLINTCLoopTestsTest.assertResults):
3241         (RunLLINTCLoopTestsTest.test_failures):
3242         (RunLLINTCLoopTestsTest.test_failure):
3243         (RunLLINTCLoopTestsTest.test_no_failure):
3244         (Run32bitJSCTestsTest):
3245         (Run32bitJSCTestsTest.assertResults):
3246         (Run32bitJSCTestsTest.test_failures):
3247         (Run32bitJSCTestsTest.test_failure):
3248         (Run32bitJSCTestsTest.test_no_failure):
3249
3250 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3251
3252         Unreviewed, EFL build fix since r172814.
3253
3254         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3255
3256 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3257
3258         Introducing WEBCORE_EXPORT macro.
3259         https://bugs.webkit.org/show_bug.cgi?id=136108
3260
3261         Reviewed by Antti Koivisto.
3262
3263         * TestWebKitAPI/config.h:
3264         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
3265
3266 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
3267
3268         import-w3c-tests doesn't import .svg support files
3269         https://bugs.webkit.org/show_bug.cgi?id=135928
3270
3271         Reviewed by Bem Jones-Bey.
3272
3273         This patch fixes the W3C import script to not treat all
3274         files with an xml mimetype as convertible tests, which
3275         was causing SVG support files to not be imported.
3276
3277         * Scripts/webkitpy/w3c/test_importer.py:
3278         (TestImporter.find_importable_tests):
3279
3280 2014-08-19  Dan Bernstein  <mitz@apple.com>
3281
3282         update-webkit should not check for the presence of Apple’s Internal directory
3283         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
3284
3285         Reviewed by Tim Horton.
3286
3287         * Scripts/update-webkit:
3288
3289 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3290
3291         Remove ENABLE(SUBPIXEL_LAYOUT).
3292         https://bugs.webkit.org/show_bug.cgi?id=136077
3293
3294         Reviewed by Simon Fraser.
3295
3296         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3297
3298         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3299
3300 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
3301
3302         Let the caller define JSC_timeout for run-javascriptcore-tests
3303         https://bugs.webkit.org/show_bug.cgi?id=136068
3304
3305         Reviewed by Csaba Osztrogonác.
3306
3307         Keep the 60 second timeout for jsc tests as the default setting but
3308         don't override the value of JSC_timeout if already set.
3309
3310         * Scripts/run-javascriptcore-tests:
3311
3312 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3313
3314         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
3315         https://bugs.webkit.org/show_bug.cgi?id=136039
3316
3317         Reviewed by Csaba Osztrogonác.
3318
3319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3320         (RunJavaScriptCoreTests.commandComplete):
3321         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3322         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
3323         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3324         (RunJavaScriptCoreTestsTest):
3325         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3326         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
3327         (test_layout_failure_new_output): Deleted.
3328         (test_layout_crash_new_output): Deleted.
3329         (test_mozilla_and_layout_failure_new_output): Deleted.
3330         (test_jsc_stress_failure_new_output): Deleted.
3331         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
3332
3333 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
3334
3335         build.webkit.org/dashboard should not request 50 revisions from trac each time
3336         https://bugs.webkit.org/show_bug.cgi?id=127130
3337
3338         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
3339         https://bugs.webkit.org/show_bug.cgi?id=127131
3340
3341         Reviewed by Timothy Hatcher.
3342
3343         Turns out that requesting 50 builds is much slower than requesting by date - even
3344         if the request ends up returning more than 50 results. There is no way to only
3345         request updates, but this change brings request time from 6-8 seconds down to
3346         less than a second.
3347
3348         This patch generalizes date handling for later use in metrics code. As part of the
3349         rewrite, I made newly fetched data update author e-mail in previously fetched
3350         revisions, as it changes after commit queue first lands.
3351
3352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3353         Updated for event rename. I changed the trac event to not contain the list of new
3354         commits, as we now sometimes update old commits, and that couldn't be expressed
3355         in event data. We never used the list anywhere in the first place.
3356
3357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3358         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
3359         without arguments, return commits for today and yesterday.
3360         (Trac.prototype._loaded):
3361         (Trac.prototype.update): Moved the function for processing loaded results out of
3362         here for clarity, and also because I'm going to have a separate loading code path
3363         for metrics.
3364
3365 2014-08-18  Dan Bernstein  <mitz@apple.com>
3366
3367         Added an update-webkit option to override the ../Internal check.
3368         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
3369
3370         Reviewed by Tim Horton.
3371
3372         * Scripts/update-webkit:
3373         Added an explicit --internal option to control updating ../Internal, defaulting to whether
3374         ../Internal exists.
3375         (runSvnUpdate): Moved to webkitdirs.pm.
3376         (runGitUpdate): Ditto.
3377         * Scripts/webkitdirs.pm:
3378         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
3379         (runGitUpdate): Moved from update-webkit.
3380
3381 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3382
3383         Make update-webkit more lenient for pure git svn repositories
3384         https://bugs.webkit.org/show_bug.cgi?id=135805
3385
3386         Reviewed by Oliver Hunt.
3387
3388         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
3389         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
3390         provide an optimization when you have a git repository setup. We should not fail if the
3391         git setup does not have svn-remote.svn.fetch set.
3392
3393         * Scripts/update-webkit:
3394         (runGitUpdate):
3395
3396 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
3397
3398         Enable Web Inspector in MiniBrowser WK2 windows
3399         https://bugs.webkit.org/show_bug.cgi?id=136045
3400
3401         Reviewed by Tim Horton.
3402         
3403         Set the pref to enable developer extras for all WK2 windows.
3404
3405         * MiniBrowser/mac/WK2BrowserWindowController.m:
3406         (-[WK2BrowserWindowController awakeFromNib]):
3407
3408 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3409
3410         master.cfg should handle special return codes of run-perf-tests
3411         https://bugs.webkit.org/show_bug.cgi?id=135974
3412
3413         Reviewed by Ryosuke Niwa.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3416         (RunAndUploadPerfTests.getText2):
3417         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3418         (RunAndUploadPerfTestsTest):
3419         (RunAndUploadPerfTestsTest.assertResults):
3420         (RunAndUploadPerfTestsTest.test_tests_failed):
3421         (RunAndUploadPerfTestsTest.test_build_bad_build):
3422         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
3423         (RunAndUploadPerfTestsTest.test_build_bad_marge):
3424         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
3425         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
3426
3427 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
3428
3429         [Win] Unreviewed change to force rebuild
3430         (plus drive-by add an accessor I wanted for
3431         some future tooling).
3432
3433         * WinLauncher/WinLauncher.h:
3434         (WinLauncher::webView): Added.
3435
3436 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
3437
3438         Update contributors.json for my new email
3439         https://bugs.webkit.org/show_bug.cgi?id=136021
3440
3441         Reviewed by Filip Pizlo.
3442
3443         * Scripts/webkitpy/common/config/contributors.json:
3444
3445 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
3446
3447         REGRESSION (r172660): WebKit2.TerminateTwice asserts
3448         https://bugs.webkit.org/show_bug.cgi?id=136012
3449
3450         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
3451
3452 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
3453
3454         Unreviewed build fix attempt on the CMake based pots since r172665
3455
3456         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
3457
3458 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
3459
3460         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
3461         https://bugs.webkit.org/show_bug.cgi?id=131596
3462
3463         Reviewed by Joseph Pecoraro.
3464
3465         * Scripts/run-inspector-generator-tests: Added.
3466         (main):
3467         * Scripts/webkitpy/inspector/__init__.py: Added.
3468         * Scripts/webkitpy/inspector/main.py: Added.
3469         (InspectorGeneratorTests):
3470         (InspectorGeneratorTests.__init__):
3471         (InspectorGeneratorTests.generate_from_json):
3472         (InspectorGeneratorTests.write_error_file):
3473         (InspectorGeneratorTests.detect_changes):
3474         (InspectorGeneratorTests.run_tests):
3475         (InspectorGeneratorTests.main):
3476
3477 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
3478
3479         run-webkit-tests should skip 'support' directories
3480         https://bugs.webkit.org/show_bug.cgi?id=135910
3481
3482         Reviewed by Bem Jones-Bey.
3483         
3484         This patch adds the 'support' directory to the list
3485         of dirs to skip when looking for runnable tests.
3486         the W3C uses this name for support files, so tests
3487         imported from the W3C will not work without this change
3488         or without many edits.
3489
3490         * Scripts/webkitpy/port/base.py:
3491         (Port._real_tests):
3492
3493 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
3494
3495         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
3496         https://bugs.webkit.org/show_bug.cgi?id=135948
3497         <rdar://problem/18022221>
3498
3499         Reviewed by David Kilzer.
3500
3501         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
3502         for RC_ProjectBuildVersion.
3503
3504 2014-08-05  David Farler  <dfarler@apple.com>
3505
3506         [iOS] run-webkit-tests runs webkit-build-directory on every test
3507         https://bugs.webkit.org/show_bug.cgi?id=135409
3508
3509         Reviewed by Daniel Bates.
3510
3511         * Scripts/webkitpy/port/ios.py:
3512         (IOSSimulatorPort.__init__): Cache Mac build directory.
3513         (IOSSimulatorPort.relay_path): Use cached build directory.
3514         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
3515
3516 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
3517
3518         Initialize a separate variable (TestWTF_SOURCES) with the list of files
3519         that are built into the TestWTF executable and move it above the platform-specific
3520         config file inclusion. This makes it possible to add platform-specific files to that
3521         list (e.g. GUniquePtr.cpp for the GTK port).
3522
3523         Rubber-stamped by Carlos Garcia Campos.
3524
3525         * TestWebKitAPI/CMakeLists.txt:
3526         * TestWebKitAPI/PlatformGTK.cmake:
3527
3528 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
3529
3530         [EFL] Bump up and patch dependencies to allow building for aarch64
3531         https://bugs.webkit.org/show_bug.cgi?id=135885
3532
3533         Reviewed by Gyuyoung Kim.
3534
3535         The currently used versions of pixman, libffi, glib, glib-networking,
3536         and fontconfig fail to configure for aarch64, so they are bumped up to
3537         the latest stable version.
3538
3539         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
3540         ARM NEON assembly support, so it is patched with a change that has been
3541         accepted by upstream.
3542
3543         * efl/jhbuild.modules:
3544         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
3545
3546 2014-08-13  Mark Rowe  <mrowe@apple.com>
3547
3548         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3549
3550         Reviewed by Darin Adler.
3551
3552         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
3553
3554 2014-08-13  Alex Christensen  <achristensen@webkit.org>
3555
3556         Progress towards CMake on Mac.
3557         https://bugs.webkit.org/show_bug.cgi?id=135819
3558
3559         Reviewed by Laszlo Gombos.
3560
3561         * WebKitTestRunner/CMakeLists.txt:
3562         Added new cpp parameter for the extension of the generated files.
3563
3564 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3565
3566         Make check-webkit-style run sort-export-file
3567         https://bugs.webkit.org/show_bug.cgi?id=135877
3568
3569         Reviewed by Csaba Osztrogonác.
3570
3571         * Scripts/webkitpy/style/checker.py:
3572         (_all_categories):
3573         (FileType):
3574         (CheckerDispatcher._file_type):
3575         (CheckerDispatcher._create_checker):
3576         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
3577         (ExportFileChecker):
3578         (ExportFileChecker.__init__):
3579         (ExportFileChecker.check):
3580         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
3581         (handle_style_error):
3582         (MockErrorHandler):
3583         (MockErrorHandler.__init__):
3584         (MockErrorHandler.turn_off_line_filtering):
3585         (MockErrorHandler.__call__):
3586         (ExportFileTest):
3587         (ExportFileTest.setUp):
3588         (ExportFileTest.tearDown):
3589         (ExportFileTest.test_sorted):
3590         (ExportFileTest.test_non_sorted):
3591         (ExportFileTest.test_parse_error):
3592
3593 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
3594
3595         [EFL] Sets the persistent storage for cookies in MiniBrowser
3596         https://bugs.webkit.org/show_bug.cgi?id=135875
3597
3598         Reviewed by Gyuyoung Kim.
3599
3600         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
3601         for non-session cookies can be stored persistently.
3602
3603         * MiniBrowser/efl/main.c:
3604         (elm_main):
3605
3606 2014-08-12  Daniel Bates  <dabates@apple.com>
3607
3608         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
3609         https://bugs.webkit.org/show_bug.cgi?id=135845
3610
3611         Reviewed by Andy Estes.
3612
3613         Towards building the iOS WebKit port using the public SDK, remove the logic
3614         added to build-webkit to build projects WebKitSystemInterface and
3615         WebKitAdditions when building the iOS WebKit port.
3616
3617         * Scripts/build-webkit:
3618
3619 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3620
3621         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
3622         https://bugs.webkit.org/show_bug.cgi?id=135850
3623
3624         Reviewed by Philippe Normand.
3625
3626         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
3627         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
3628
3629         * gtk/install-dependencies:
3630
3631 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
3632
3633         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
3634         https://bugs.webkit.org/show_bug.cgi?id=135798
3635
3636         Reviewed by Philippe Normand.
3637
3638         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
3639             toggle SUBTLE_CRYPTO feature.
3640
3641 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
3642
3643         [EFL] Disable ecore logs about bad fd
3644         https://bugs.webkit.org/show_bug.cgi?id=135831
3645
3646         Reviewed by Gyuyoung Kim.
3647
3648         ecore checks EBADF and prints the warnings.
3649         But, it looks noise in layout test because it's not webkit issue.
3650         This patch disables it until we found right solution.
3651
3652         * efl/jhbuild.modules:
3653         * efl/patches/ecore_remove_warnings.patch: Added.
3654
3655 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
3656
3657         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
3658         https://bugs.webkit.org/show_bug.cgi?id=135791
3659
3660         Reviewed by Gyuyoung Kim.
3661
3662         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
3663         user.
3664
3665         * MiniBrowser/efl/main.c:
3666         (on_download_request):
3667
3668 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3669
3670         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
3671         https://bugs.webkit.org/show_bug.cgi?id=135606
3672
3673         Reviewed by Gyuyoung Kim.
3674
3675         TestWebKitAPI does not initialize EWebkit using ewk_init()
3676         which is not recommended.
3677
3678         * TestWebKitAPI/efl/PlatformWebView.cpp:
3679         (TestWebKitAPI::createEcoreEvas):
3680         Renamed from initEcoreEvas() since it doesn't not initialize
3681         ecore evas.
3682
3683         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3684         Call ewk_init() that initalizes all EFL modules needed by EWebKit
3685         instead of ecore_evas_init() only.
3686
3687         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3688         Call ewk_shutdown() to finalize EWebkit.
3689         (TestWebKitAPI::initEcoreEvas): Deleted.
3690
3691 2014-08-11  Dan Bernstein  <mitz@apple.com>
3692
3693         Added an update-webkit option to update the auxiliary libraries or not.
3694         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
3695
3696         Reviewed by Tim Horton.
3697
3698         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
3699         an Internal directory exists alongside the WebKit root directory.
3700
3701 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
3702
3703         Remove hg changeset from w3c-import.log
3704         https://bugs.webkit.org/show_bug.cgi?id=135735
3705
3706         Reviewed by Ryosuke Niwa.
3707
3708         Since the csswg's test suite is now accessible via github and it is
3709         possible to push changes by creating github pull requests, the hg
3710         changeset makes less sense, as many people will just use a clone of
3711         the git repo. There isn't an obvious thing to replace it with, so
3712         might as well remove it for now instead of having it just be set to
3713         UNKNOWN in imports.
3714
3715         This also adds a pointer to the github repo in the generated comments
3716         in the w3c-import.log.
3717
3718         * Scripts/webkitpy/w3c/test_importer.py:
3719         (TestImporter.__init__): Remove changeset handling.
3720         (TestImporter.do_import): Ditto.
3721         (TestImporter.write_import_log): Ditto.
3722         (TestImporter.load_changeset): Deleted.
3723
3724 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3725
3726         Unreviewed. Fix GTK+ make distcheck.
3727
3728         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
3729
3730 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
3731
3732         Unbreak webkitpy unit tests by checking for the existence of the image diff template
3733         file before trying to open it (as the tests do for results.html).
3734
3735         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3736         (TestResultWriter.write_image_diff_files):
3737
3738 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
3739
3740         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
3741         https://bugs.webkit.org/show_bug.cgi?id=135780
3742
3743         Reviewed by Dan Bates.
3744         
3745         Pull the HTML for the image diff file into a separate file, for easier hackability.
3746
3747         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3748         (TestResultWriter.write_image_diff_files):
3749
3750 2014-08-08  Mark Lam  <mark.lam@apple.com>
3751
3752         Gardening: fix Windows build after r172259.
3753
3754         Not reviewed.
3755
3756         * DumpRenderTree/win/TestRunnerWin.cpp:
3757         (TestRunner::addMockSpeechInputResult): Deleted.
3758         (TestRunner::setMockSpeechInputDumpRect): Deleted.
3759         (TestRunner::startSpeechInput): Deleted.
3760
3761 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3762
3763         make clean does not work in OpenSource, fails in WebKitLibraries
3764         https://bugs.webkit.org/show_bug.cgi?id=135734
3765
3766         Reviewed by David Kilzer.
3767
3768         * Scripts/copy-webkitlibraries-to-product-directory:
3769         Add a --clean switch that removes possible WebKitSystemInterface
3770         and LLVM libraries and headers that may have been copied to the
3771         product directory.
3772
3773 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3774
3775         commit-log-message has extra blank line at the top of pre-populated message
3776         https://bugs.webkit.org/show_bug.cgi?id=135744
3777
3778         Reviewed by Csaba Osztrogonác.
3779
3780         Do not add a blank leading line in single ChangeLog commit messages.
3781
3782         * Scripts/commit-log-editor:
3783         (createCommitMessage):
3784         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3785         (test_commit_message_for_one_reviewed_changelog):
3786         (test_commit_message_for_one_rollout_changelog):
3787
3788 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
3789
3790         [Win] Unreviewed gardening.
3791
3792         Have 'Assemble Build Logs' step work properly for DebugSuffix target
3793         (both 32-bit and 64-bit).
3794
3795         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3796
3797 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3798
3799         Get rid of INPUT_SPEECH
3800         https://bugs.webkit.org/show_bug.cgi?id=135672
3801
3802         Reviewed by Andreas Kling.
3803
3804         * DumpRenderTree/TestRunner.cpp:
3805         (TestRunner::staticFunctions):
3806         (addMockSpeechInputResultCallback): Deleted.
3807         (setMockSpeechInputDumpRectCallback): Deleted.
3808         * DumpRenderTree/TestRunner.h:
3809         * DumpRenderTree/mac/TestRunnerMac.mm:
3810         (TestRunner::addMockSpeechInputResult): Deleted.
3811         (TestRunner::setMockSpeechInputDumpRect): Deleted.
3812         (TestRunner::startSpeechInput): Deleted.
3813
3814 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
3815
3816         The support directory shouldn't be skipped unconditionally in test import
3817         https://bugs.webkit.org/show_bug.cgi?id=135660
3818
3819         Reviewed by Ryosuke Niwa.
3820
3821         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
3822         of the test repo, as that's the only time they are special. In
3823         addition, instead of hardcoding .hg and .git as special, skip all
3824         directories that begin with '.', just like with files that begin with '.'.
3825         
3826         In order to make this work, the root directory must always be
3827         passed in, so the interface to the script has been changed to take the
3828         root directory, and if one wants to only import a subset of the tests,
3829         a new -t option can be used to limit the tests imported.
3830
3831         * Scripts/webkitpy/w3c/test_importer.py:
3832         (main): Remove repo_dir command line argument.
3833         (parse_args): Add -t option and set expected non-option args to 1.
3834         (TestImporter.__init__): Remove repo_dir.
3835         (TestImporter.do_import): Handle the varying number of import
3836             directories.
3837         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
3838             determine if a subdirectory should be skipped.
3839         (TestImporter.find_importable_tests): Filter directories using new
3840             helper.
3841         (TestImporter.import_tests): Remove use of repo_dir.
3842         (TestImporter.setup_destination_directory): Unused, Deleted. 
3843         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3844         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
3845             new API.
3846         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
3847
3848 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3849
3850         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
3851         https://bugs.webkit.org/show_bug.cgi?id=135695
3852
3853         Reviewed by Gustavo Noronha Silva.
3854
3855         Use WebKitNavigationAction API.
3856
3857         * MiniBrowser/gtk/BrowserWindow.c:
3858         (webViewDecidePolicy):
3859         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3860         (testNavigationPolicy):
3861
3862 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3863
3864         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
3865         https://bugs.webkit.org/show_bug.cgi?id=135696
3866
3867         Reviewed by Sergio Villar Senin.
3868
3869         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
3870         exception (that happens when testing the script hasn't been injected) the JavaScript
3871         result is NULL.
3872
3873         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3874         (isScriptInjectedForURLAtPath):
3875
3876 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
3877
3878         [GTK] Disable IndexedDB
3879         https://bugs.webkit.org/show_bug.cgi?id=135692
3880
3881         Reviewed by Carlos Garcia Campos.
3882
3883         * Scripts/webkitperl/FeatureList.pm:
3884
3885 2014-08-06  Dean Jackson  <dino@apple.com>
3886
3887         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3888         https://bugs.webkit.org/show_bug.cgi?id=135675
3889
3890         Reviewed by Sam Weinig.
3891
3892         * Scripts/webkitperl/FeatureList.pm:
3893
3894 2014-08-06  David Farler  <dfarler@apple.com>
3895
3896         Set DSYMUTIL_NUM_THREADS to the number of logical cores
3897         https://bugs.webkit.org/show_bug.cgi?id=135655
3898
3899         Reviewed by Mark Rowe.
3900
3901         * Scripts/webkitdirs.pm:
3902         (buildXCodeProject): Set before calling xcodebuild.
3903
3904 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
3905
3906         [GTK] Add support for user scripts to WebKitUserContentManager
3907         https://bugs.webkit.org/show_bug.cgi?id=134738
3908
3909         Reviewed by Carlos Garcia Campos.
3910
3911         Add support for user scripts, to complement the user style sheet
3912         support already present in WebKitUserContentManager. Most of the
3913         moving parts are already present, so this just adds a boxed type
3914         for user scripts (WebKitUserScript) and the corresponding methods
3915         to add and remove scripts from the WebKitUserContentManager.
3916
3917         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3918         Add test case for injected user scripts.
3919         (isScriptInjectedForURLAtPath):
3920         (removeOldInjectedContentAndResetLists):
3921         (testUserContentManagerInjectedStyleSheet):
3922         (testUserContentManagerInjectedScript):
3923         (beforeAll):
3924         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
3925
3926 2014-08-06  Philippe Normand  <pnormand@igalia.com>
3927
3928         [GTK] run-launcher --gtk still fails
3929         https://bugs.webkit.org/show_bug.cgi?id=135642
3930
3931         Reviewed by Carlos Garcia Campos.
3932
3933         The perl interpreter is confused by the combination of string
3934         concatenation and a ternary in the same line. Using a separate
3935         variable to determine the library file extension fixes this issue.
3936
3937         * Scripts/webkitdirs.pm:
3938         (builtDylibPathForName): Use an intermediate variable, it's more
3939         readable and unambiguous.
3940
3941 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
3942
3943         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
3944
3945     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
3946     
3947             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
3948             https://bugs.webkit.org/show_bug.cgi?id=134333
3949     
3950             Reviewed by Geoffrey Garen.
3951     
3952             * Scripts/display-profiler-output:
3953     
3954 2014-08-05  David Farler  <dfarler@apple.com>
3955
3956         [iOS] Run ImageDiff in the sim bootstrap
3957         https://bugs.webkit.org/show_bug.cgi?id=135624
3958
3959         Reviewed by David Kilzer.
3960
3961         * Scripts/webkitpy/port/image_diff.py:
3962         (ImageDiffer.stop):
3963         (IOSSimulatorImageDiffer):
3964         (IOSSimulatorImageDiffer._start):
3965         * Scripts/webkitpy/port/ios.py:
3966         (IOSSimulatorPort.diff_image):
3967
3968 2014-08-05  David Farler  <dfarler@apple.com>
3969
3970         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
3971         https://bugs.webkit.org/show_bug.cgi?id=135441
3972
3973         Reviewed by Tim Horton.
3974
3975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3976         (parse_args):
3977         (_set_up_derived_options):
3978         If using the ios-simulator platform and runtime or device-type
3979         aren't defined, get the latest runtime from the active Xcode.app
3980         and pick a default device type based on the desired architecture:
3981         iPhone 5 for i386 and iPhone 5s for x86_64.
3982         * Scripts/webkitpy/xcode/__init__.py: Added.
3983         * Scripts/webkitpy/xcode/simulator.py: Added.
3984
3985 2014-08-05  David Farler  <dfarler@apple.com>
3986
3987         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
3988         https://bugs.webkit.org/show_bug.cgi?id=135626
3989
3990         Reviewed by Dan Bernstein.
3991
3992         * Scripts/webkitpy/port/ios.py:
3993         (IOSSimulatorPort.setup_test_run):
3994         Remove call to simctl shutdown <device> - telling the simulator app to quit
3995         will shut down all booted devices.
3996
3997 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
3998
3999         Remove an unused argument from BuildbotQueue.update()
4000         https://bugs.webkit.org/show_bug.cgi?id=135623
4001
4002         Reviewed by Timothy Hatcher.
4003
4004         Also remaned a constant to better match what it means.
4005
4006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4007
4008 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
4009
4010         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
4011         https://bugs.webkit.org/show_bug.cgi?id=135555
4012
4013         Reviewed by Philippe Normand.
4014
4015         Initial setup of gtk on linux requires this package to be installed.
4016         This is required during the build configuration of mesa through jhbuild.
4017
4018         * gtk/install-dependencies:
4019
4020 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4021
4022         Fix the commit-log-editor after r167243 and add more unit tests
4023         https://bugs.webkit.org/show_bug.cgi?id=131727
4024
4025         Reviewed by Csaba Osztrogonác.
4026
4027         * Scripts/commit-log-editor:
4028         (createCommitMessage):
4029         (removeLongestCommonPrefixEndingInNewline):
4030         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4031         (CommitMessageForThisCommitTest):
4032         (CommitMessageForThisCommitTest.mock_changelog):
4033         (CommitMessageForThisCommitTest.mock_checkout_for_test):
4034         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
4035         (test_commit_message_for_one_reviewed_changelog):
4036         (test_commit_message_for_changelogs_with_same_messages):
4037         (test_commit_message_for_changelogs_with_different_messages):
4038         (test_commit_message_for_one_rollout_changelog):
4039         (test_commit_message_for_rollout_changelogs_with_different_directories):
4040         (setUp): Deleted.
4041         (test_commit_message_for_this_commit): Deleted.
4042
4043 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4044
4045         [GTK] run-launcher --gtk is broken
4046         https://bugs.webkit.org/show_bug.cgi?id=135571
4047
4048         Reviewed by Martin Robinson.
4049
4050         * Scripts/webkitdirs.pm:
4051         (builtDylibPathForName): Search for libwebkit2gtk-4.0
4052
4053 2014-08-04  Matt Baker  <mattbaker@apple.com>
4054
4055         lldb_webkit.py throws exception when generating summary of null StringImpl
4056         https://bugs.webkit.org/show_bug.cgi?id=129448
4057
4058         Reviewed by Jer Noble.
4059
4060         Added checks for null StringImpl and 0 byte ReadMemory calls.
4061
4062         * lldb/lldb_webkit.py:
4063         (WTFStringImpl_SummaryProvider):
4064         (ustring_to_string):
4065         (lstring_to_string):
4066         (WTFStringImplProvider.to_string):
4067         (WTFStringImplProvider.is_initialized):
4068
4069 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4070
4071         [GTK] Do not include JavaScriptCore stress tests in release tarballs
4072         https://bugs.webkit.org/show_bug.cgi?id=135503
4073
4074         Reviewed by Martin Robinson.
4075
4076         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
4077
4078 2014-07-30  David Farler  <dfarler@apple.com>
4079
4080         build-webkittestrunner doesn't build the app target for iOS SDKs
4081         https://bugs.webkit.org/show_bug.cgi?id=135433
4082
4083         Reviewed by Dan Bernstein.
4084
4085         * Scripts/build-dumprendertree: Build the app target on iOS.
4086         * Scripts/build-webkittestrunner: Build the app target on iOS.
4087         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
4088         (buildXCodeProject):
4089         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
4090         (IOSSimulatorPort._build_driver_flags):
4091
4092 2014-07-30  David Farler  <dfarler@apple.com>
4093
4094         Remove iOS Perl DumpRenderTree support target
4095         https://bugs.webkit.org/show_bug.cgi?id=135271
4096
4097         Reviewed by Dan Bernstein.
4098
4099         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
4100         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
4101         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
4102         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
4103         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
4104         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
4105         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
4106         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
4107         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
4108         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
4109         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
4110         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
4111         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
4112
4113 2014-07-30  David Farler  <dfarler@apple.com>
4114
4115         Remove old-run-webkit-tests
4116         https://bugs.webkit.org/show_bug.cgi?id=135374
4117
4118         Reviewed by Csaba Osztrogonác.
4119
4120         * Scripts/old-run-webkit-tests: Removed.
4121
4122 2014-08-02  Dan Bernstein  <mitz@apple.com>
4123
4124         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
4125         https://bugs.webkit.org/show_bug.cgi?id=135542
4126
4127         Reviewed by Tim Horton.
4128
4129         * Scripts/prepare-ChangeLog:
4130         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
4131         findChangeLogs.
4132         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
4133         requireChangeLogToExist argument is true.
4134
4135 2014-08-01  Dan Bernstein  <mitz@apple.com>
4136
4137         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
4138         https://bugs.webkit.org/show_bug.cgi?id=135527
4139
4140         Reviewed by Tim Horton.
4141
4142         * Scripts/commit-log-editor:
4143         In the case of a git repository when there are no changed ChangeLog files, changed to pass
4144         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
4145         commitMessageFromChangeLogEntry.
4146         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
4147         (sortKey): Factored out from createCommitMessage.
4148         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
4149         subroutines.
4150
4151         * Scripts/prepare-ChangeLog:
4152         (main): Parse new --delimiters option.
4153         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
4154         the label before each change log entry, and a "~" delimiter on a new line after each entry.
4155
4156 2014-08-01  Bear Travis  <betravis@adobe.com>
4157
4158         [Feature Queries] Enable Feature Queries on EFL/GTK
4159         https://bugs.webkit.org/show_bug.cgi?id=134902
4160
4161         Reviewed by Benjamin Poulain.
4162
4163         Turn the feature on by default for the build script.
4164
4165         * Scripts/webkitperl/FeatureList.pm:
4166
4167 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
4168
4169         Build fix for 32-bit after r171926.
4170
4171         * MiniBrowser/mac/SettingsController.h:
4172         * MiniBrowser/mac/SettingsController.m:
4173
4174 2014-08-01  Tim Horton  <timothy_horton@apple.com>
4175
4176         Confusing build fix after r171926.
4177
4178         * MiniBrowser/mac/AppDelegate.h:
4179         * MiniBrowser/mac/AppDelegate.m:
4180         * MiniBrowser/mac/SettingsController.m:
4181
4182 2014-08-01  Tim Horton  <timothy_horton@apple.com>
4183
4184         Make it easer to add switches to MiniBrowser
4185         https://bugs.webkit.org/show_bug.cgi?id=135499
4186
4187         Reviewed by Simon Fraser.
4188
4189         Add a single class to manage a set of persistent, global settings for MiniBrowser.
4190         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
4191
4192         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4193         Add SettingsController.{m, h}.
4194
4195         * MiniBrowser/mac/AppDelegate.h:
4196         Move _browserWindowControllers to the implementation.
4197         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
4198         of that; instead, we'll receive didChangeSettings.
4199
4200         * MiniBrowser/mac/AppDelegate.m:
4201         Move the default URL, default URL preference key, and use-WebKit2-by-default
4202         preference key into SettingsController.
4203
4204         (-[BrowserAppDelegate awakeFromNib]):
4205         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
4206
4207         (-[BrowserAppDelegate newWindow:]):
4208         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
4209
4210         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
4211         SettingsController now takes care of reading the default URL preference.
4212         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
4213
4214         (-[BrowserAppDelegate didChangeSettings]):
4215         When settings change, update the key equivalents for the new-window menu items, as they
4216         might have changed (as use-WebKit2-by-default is one of the settings).
4217
4218         Dispatch settings change notifications to all live BrowserControllers.
4219
4220         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
4221         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
4222         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
4223         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
4224         All menu item validation for settings is moved into SettingsController.
4225
4226         * MiniBrowser/mac/BrowserWindowController.h:
4227         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
4228         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
4229
4230         * MiniBrowser/mac/MainMenu.xib:
4231         Remove the settings menu items from the "Debug" menu.
4232
4233         * MiniBrowser/mac/SettingsController.h: Added.
4234         * MiniBrowser/mac/SettingsController.m: Added.
4235         (+[SettingsController shared]):
4236         (-[SettingsController menu]):
4237
4238         (-[SettingsController _addItemWithTitle:action:indented:]):
4239         (-[SettingsController _addHeaderWithTitle:]):
4240         NSMenuItem-creating helpers.
4241
4242         (-[SettingsController _populateMenu]):
4243         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
4244
4245         (-[SettingsController validateMenuItem:]):
4246         Validate menu items; since they can be used to toggle the default state of a setting,
4247         we'll always return YES. However, we will use this opportunity to set the 'checked' state
4248         of each item.
4249
4250
4251         (-[SettingsController _toggleBooleanDefault:]):
4252         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
4253
4254         (-[SettingsController toggleUseWebKit2ByDefault:]):
4255         (-[SettingsController useWebKit2ByDefault]):
4256         (-[SettingsController toggleUseTransparentWindows:]):
4257         (-[SettingsController useTransparentWindows]):
4258         (-[SettingsController toggleUsePaginatedMode:]):
4259         (-[SettingsController usePaginatedMode]):
4260         (-[SettingsController toggleUseUISideCompositing:]):
4261         (-[SettingsController useUISideCompositing]):
4262         (-[SettingsController toggleShowLayerBorders:]):
4263         (-[SettingsController layerBordersVisible]):
4264         (-[SettingsController toggleShowTiledScrollingIndicator:]):
4265         (-[SettingsController tiledScrollingIndicatorVisible]):
4266         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
4267         (-[SettingsController subPixelCSSOMMetricsEnabled]):
4268         (-[SettingsController defaultURL]):
4269         Toggle or return the current state of each preference.
4270
4271         * MiniBrowser/mac/WK1BrowserWindowController.m:
4272         (-[WK1BrowserWindowController awakeFromNib]):
4273         (-[WK1BrowserWindowController validateMenuItem:]):
4274         (-[WK1BrowserWindowController windowWillClose:]):
4275         (-[WK1BrowserWindowController find:]):
4276         (-[WK1BrowserWindowController dumpSourceToConsole:]):
4277         (-[WK1BrowserWindowController didChangeSettings]):
4278         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
4279         (-[WK1BrowserWindowController isPaginated]): Deleted.
4280         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
4281         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
4282         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
4283         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
4284         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
4285         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
4286         * MiniBrowser/mac/WK2BrowserWindowController.m:
4287         (-[WK2BrowserWindowController awakeFromNib]):
4288         (-[WK2BrowserWindowController validateMenuItem:]):
4289         (-[WK2BrowserWindowController forceRepaint:]):
4290         (-[WK2BrowserWindowController windowWillClose:]):
4291         (-[WK2BrowserWindowController didChangeSettings]):
4292         (-[WK2BrowserWindowController isPaginated]): Deleted.
4293         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
4294         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
4295         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
4296         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
4297         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
4298         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
4299         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
4300         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
4301
4302 2014-08-01  Tim Horton  <timothy_horton@apple.com>