bf11482254da2310e69d17d3072338c792ab152d
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         Unreviewed. Adding myself to committers.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2014-06-20  Tim Horton  <timothy_horton@apple.com>
8
9         Make WebKit2 more accessible in MiniBrowser
10         https://bugs.webkit.org/show_bug.cgi?id=134099
11
12         Reviewed by Anders Carlsson.
13
14         * MiniBrowser/mac/AppDelegate.h:
15         * MiniBrowser/mac/AppDelegate.m:
16         (-[BrowserAppDelegate newWindow:]):
17         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
18         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
19         (-[BrowserAppDelegate _useWebKit2ByDefault]):
20         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
21         (-[BrowserAppDelegate validateMenuItem:]):
22         * MiniBrowser/mac/MainMenu.xib:
23         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
24         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
25         Make the non-default new-window menu item always show up, because people often don't find it
26         when you have to press option to have it show up.
27
28         * MiniBrowser/mac/BrowserWindowController.h:
29         * MiniBrowser/mac/BrowserWindowController.m:
30         (-[BrowserWindowController initWithWindow:]):
31         
32         * MiniBrowser/mac/WK1BrowserWindowController.m:
33         (-[WK1BrowserWindowController validateMenuItem:]):
34         * MiniBrowser/mac/WK2BrowserWindowController.m:
35         (-[WK2BrowserWindowController validateMenuItem:]):
36         Use the cached [menuItem action] like the earlier cases do.
37
38 2014-06-20  Daniel Bates  <dabates@apple.com>
39
40         Teach run-{safari, webkit-app} about iOS Simulator
41         https://bugs.webkit.org/show_bug.cgi?id=133986
42
43         Reviewed by David Kilzer.
44
45         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
46         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
47         and run-safari.
48
49         * Scripts/old-run-webkit-tests:
50         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
51         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
52         to call it.
53         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
54         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
55         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
56         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
57         when the iOS device SDK is used as we don't support launching an app on the device at this time.
58         * Scripts/webkitdirs.pm:
59         (xcodeSDKVersion): Added.
60         (setupIOSWebKitEnvironment): Added.
61         (installedMobileSafariBundle): Added.
62         (mobileSafariBundle): Added.
63         (plistPathFromBundle): Added.
64         (appIdentiferFromBundle): Added.
65         (appDisplayNameFromBundle): Added.
66         (loadIPhoneSimulatorNotificationIfNeeded): Added.
67         (openIOSSimulator): Added.
68         (quitIOSSimulator): Added.
69         (iosSimulatorDeviceByName): Added.
70         (iosSimulatorRuntime): Added.
71         (findOrCreateSimulatorForIOSDevice): Added.
72         (runIOSWebKitAppInSimulator): Added.
73         (installAndLaunchIOSWebKitAppInSimulator): Added.
74         (runIOSWebKitApp): Added.
75         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
76         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
77         device at this time.
78
79 2014-06-19  Anders Carlsson  <andersca@apple.com>
80
81         Add WTF::Optional class
82         https://bugs.webkit.org/show_bug.cgi?id=134083
83
84         Reviewed by Andreas Kling.
85
86         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
87         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
88         (TestWebKitAPI::TEST):
89
90 2014-06-20  Ion Rosca  <rosca@adobe.com>
91
92         Unreviewed. Adding myself to Committers list.
93
94         * Scripts/webkitpy/common/config/contributors.json:
95
96 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
97
98         [EFL] Add gstreamer as dependecy of EFL after r169785
99         https://bugs.webkit.org/show_bug.cgi?id=134066
100
101         Reviewed by Gyuyoung Kim.
102
103         * efl/jhbuild.modules:
104
105 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
106
107         [EFL] Merge url_utils.c to MiniBrowser
108         https://bugs.webkit.org/show_bug.cgi?id=134095
109
110         Reviewed by Csaba Osztrogonác.
111
112         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
113         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
114
115         * MiniBrowser/efl/CMakeLists.txt:
116         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
117         * MiniBrowser/efl/main.c:
118         (has_scheme): Copied from url_utils.c
119         (url_from_user_input): Ditto.
120
121 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
122
123         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
124
125         Reviewed by Csaba Osztrogonác.
126
127         * Scripts/webkitpy/common/config/ports_unittest.py:
128         (DeprecatedPortTest.test_gtk_wk2_port):
129         (DeprecatedPortTest.test_efl_port): Deleted.
130         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
131         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
132         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
133         (TestRebaselineExpectations.test_rebaseline_expectations):
134
135 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
136
137         [EFL][CMAKE] Disable WebKit1 build as a default
138         https://bugs.webkit.org/show_bug.cgi?id=134093
139
140         Reviewed by Gyuyoung Kim.
141
142         * CMakeLists.txt:
143
144 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
145
146         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
147         https://bugs.webkit.org/show_bug.cgi?id=93002
148
149         Reviewed by Gustavo Noronha Silva.
150
151         Add unit tests to check WebKitDOMNodefilter API used from both
152         TreeWalker and NodeIterator.
153
154         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
155         public headers and add WebKitDOMNodeFilter to the list of exceptions.
156         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
157         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
158         (webkitNodeFilterAcceptNode):
159         (webkitNodeFilterDOMNodeFilterIfaceInit):
160         (webkit_node_filter_init):
161         (webkit_node_filter_class_init):
162         (WebKitDOMNodeFilterTest::create):
163         (WebKitDOMNodeFilterTest::webPageFromArgs):
164         (WebKitDOMNodeFilterTest::testTreeWalker):
165         (WebKitDOMNodeFilterTest::testNodeIterator):
166         (WebKitDOMNodeFilterTest::runTest):
167         (registerTests):
168         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
169         (runTest):
170         (testWebKitDOMNodeFilterTreeWalker):
171         (testWebKitDOMNodeFilterNodeIterator):
172         (beforeAll):
173         (afterAll):
174         * gtk/webkitdom.py:
175         (WebKitDOMDocGeneratorSections.__init__):
176         (WebKitDOMDocGeneratorSections._symbol_list):
177         (WebKitDOMDocGeneratorSections.write_section):
178
179 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
180
181         [GTK] Limit the amount of API exposed to GObject DOM bindings API
182         https://bugs.webkit.org/show_bug.cgi?id=133726
183
184         Reviewed by Gustavo Noronha Silva.
185
186         Don't make fatal finding files without a .symbols file, since now
187         only the stable DOM API has .symbols files.
188
189         * gtk/webkitdom.py:
190         (get_all_webkitdom_symbol_files):
191
192 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
193
194         Remove efl wk1 buildbot and ews
195         https://bugs.webkit.org/show_bug.cgi?id=134089
196
197         Reviewed by Benjamin Poulain.
198
199         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
200
201         * BuildSlaveSupport/build.webkit.org-config/config.json:
202         * QueueStatusServer/config/queues.py:
203         * Scripts/webkitpy/common/config/ews.json:
204         * Scripts/webkitpy/common/config/ports.py:
205         (DeprecatedPort.port):
206         (QtWK2Port.run_webkit_tests_command):
207         (EflPort): Deleted.
208         (EflPort.build_webkit_command): Deleted.
209         * Scripts/webkitpy/port/builders.py:
210         * TestResultServer/static-dashboards/flakiness_dashboard.js:
211         * TestResultServer/static-dashboards/loader_unittests.js:
212
213 2014-06-19  David Kilzer  <ddkilzer@apple.com>
214
215         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
216         <http://webkit.org/b/134061>
217
218         Reviewed by Dan Bernstein.
219
220         * Scripts/webkitpy/style/checkers/cpp.py:
221         (check_spacing): Ignore '@' immediately before '{'.
222         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
223         (CppStyleTest.test_spacing_before_braces): Add unit test for
224         '^{' block syntax and '@{' Objective-C liternal NSDitionary
225         syntax.
226
227 2014-06-18  Tim Horton  <timothy_horton@apple.com>
228
229         All of MiniBrowser's WKWebViews should share a configuration
230         https://bugs.webkit.org/show_bug.cgi?id=134017
231
232         Reviewed by Anders Carlsson.
233
234         * MiniBrowser/mac/WK2BrowserWindowController.m:
235         (-[WK2BrowserWindowController awakeFromNib]):
236         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
237         This means that they'll share things like preferences, visited links, etc.
238         It also means that we'll properly share processes once we hit the process limit.
239
240 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
241
242         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
243         https://bugs.webkit.org/show_bug.cgi?id=133971
244
245         Reviewed by Martin Robinson.
246
247         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
248         building for the Wayland target. The latest 3.12 version is required to match
249         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
250         as well due to GTK+ depending on a newer version.
251
252 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
253
254         [EFL] Turn on NOSNIFF in FeatureList.pm
255         https://bugs.webkit.org/show_bug.cgi?id=134010
256
257         Reviewed by Csaba Osztrogonác.
258
259         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
260
261         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
262
263 2014-06-17  Tim Horton  <timothy_horton@apple.com>
264
265         MiniBrowser should show Web Content process pids in the window title
266         https://bugs.webkit.org/show_bug.cgi?id=134016
267
268         Reviewed by Sam Weinig.
269
270         * MiniBrowser/mac/WK2BrowserWindowController.m:
271         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
272
273 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
274
275         [GTK] Fix the handling of resize events after r169505.
276         https://bugs.webkit.org/show_bug.cgi?id=133517
277
278         Reviewed by Martin Robinson.
279
280         * Scripts/webkitpy/port/xvfbdriver.py:
281         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
282         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
283         need at least 900x640 pixels to pass.
284         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
285         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
286         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
287         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
288         (XvfbDriverTest.test_start_next_worker): Update resolution.
289         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
290         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
291         be requested over the main widget instead of the window.
292         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
293         the Mac port.
294         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
295         (WTR::PlatformWebView::setWindowFrame): Set the size and position
296         of the Window and the web view.
297
298 2014-06-17  Matthew Mirman <mmirman@apple.com>
299
300         Unreviewed. Added myself to list of contributors.
301
302         * Scripts/webkitpy/common/config/contributors.json: Added myself.
303
304 2014-06-17  Commit Queue  <commit-queue@webkit.org>
305
306         Unreviewed, rolling out r170058.
307         https://bugs.webkit.org/show_bug.cgi?id=133993
308
309         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
310         on #webkit).
311
312         Reverted changeset:
313
314         "[GTK] Fix the handling of resize events after r169505."
315         https://bugs.webkit.org/show_bug.cgi?id=133517
316         http://trac.webkit.org/changeset/170058
317
318 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
319
320         Update import-w3c-tests to reflect current W3C test repo directory structure
321         https://bugs.webkit.org/show_bug.cgi?id=133460
322
323         Reviewed by Bem Jones-Bey.
324
325         Removed all references to test status, which are no longer reflected in the
326         directory names in the W3C CSS test repo.  No tests are required for this 
327         change, the existing tests pass.
328
329         * Scripts/webkitpy/w3c/test_importer.py:
330         (main):
331         (TestImporter.__init__):
332         (TestImporter.find_importable_tests):
333         (TestImporter.setup_destination_directory):
334         (TestImporter.write_import_log):
335         (TestImporter.update_test_status): Deleted.
336
337 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
338
339         [GTK] Fix the handling of resize events after r169505.
340         https://bugs.webkit.org/show_bug.cgi?id=133517
341
342         Reviewed by Martin Robinson.
343
344         * Scripts/webkitpy/port/xvfbdriver.py:
345         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
346         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
347         need at least 900x640 pixels to pass.
348         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
349         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
350         be requested over the main widget instead of the window.
351         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
352         the Mac port.
353         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
354         (WTR::PlatformWebView::setWindowFrame): Set the size and position
355         of the Window and the web view.
356
357 2014-06-17  Dan Bernstein  <mitz@apple.com>
358
359         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
360         https://bugs.webkit.org/show_bug.cgi?id=133968
361
362         Reviewed by Anders Carlsson.
363
364         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
365         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
366         share an impl() with the original.
367
368 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
369
370         [EFL][WK2] Skip failing EFL API tests
371         https://bugs.webkit.org/show_bug.cgi?id=133981
372
373         Reviewed by Csaba Osztrogonác.
374
375         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
376
377         * TestWebKitAPI/PlatformEfl.cmake:
378
379 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
380
381         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
382         https://bugs.webkit.org/show_bug.cgi?id=133962
383
384         Reviewed by Gyuyoung Kim.
385
386         Since we bumped EFL to 1.9, this workaround is unnecessary.
387
388         * MiniBrowser/efl/main.c:
389         (update_view_favicon):
390
391 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
392
393         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
394         https://bugs.webkit.org/show_bug.cgi?id=131472
395
396         Reviewed by Martin Robinson.
397
398         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
399
400         * Scripts/webkitpy/port/xvfbdriver.py:
401         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
402         when running WebKitTestRunner with the Xvfb driver.
403         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
404         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
405         installed.
406         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
407         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
408         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
409         deal.
410
411 2014-06-16  Tanay C  <tanay.c@samsung.com>
412
413         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
414         https://bugs.webkit.org/show_bug.cgi?id=133792
415
416         Reviewed by Gyuyoung Kim.
417
418         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
419         (show_file_entry_dialog):
420         (window_create):
421
422 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
423
424         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
425         https://bugs.webkit.org/show_bug.cgi?id=133512
426
427         Reviewed by Chris Fleizach.
428
429         Added support for connecting to AtkSelection's 'selection-changed'
430         signal, and print it out as AXSelectedChildrenChanged in the tests.
431
432         Also removed some dead code, that became useless after r169487.
433
434         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
435         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
436
437 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
438
439         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
440         https://bugs.webkit.org/show_bug.cgi?id=133841
441
442         Reviewed by Gyuyoung Kim.
443
444         * MiniBrowser/efl/main.c:
445         (window_create):
446
447 2014-06-15  Dan Bernstein  <mitz@apple.com>
448
449         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
450
451         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
452
453 2014-06-15  Anders Carlsson  <andersca@apple.com>
454
455         Fix build.
456
457         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
458         (callRunJavaScriptBlockAndRelease):
459         (runJavaScriptInMainFrame):
460         (TEST_F):
461
462 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
463
464         Create MSE and EME watchlist
465         https://bugs.webkit.org/show_bug.cgi?id=133810
466
467         Reviewed by Eric Carlson.
468
469         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
470         definition and add Eric Carlson and myself to it.
471
472 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
473
474         [GTK] Remove all deprecated API from GObject DOM bindings
475         https://bugs.webkit.org/show_bug.cgi?id=133728
476
477         Reviewed by Martin Robinson.
478
479         * gtk/webkitdom.py:
480         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
481         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
482
483 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
484
485         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
486         https://bugs.webkit.org/show_bug.cgi?id=133835
487
488         Reviewed by Tim Horton.
489         
490         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
491
492         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
493         (-[WebKitTestRunnerWindow initWithFrame:]):
494         (-[WebKitTestRunnerWindow setFrame:]):
495
496 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
497
498         [GTK] Performance tests should be always ran with WKTR.
499         https://bugs.webkit.org/show_bug.cgi?id=133780
500
501         Reviewed by Ryosuke Niwa.
502
503         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
504         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
505         is GTK.
506
507 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
508
509         [GTK] REGRESSION: application name is not correctly appended to the UA
510         https://bugs.webkit.org/show_bug.cgi?id=133793
511
512         Reviewed by Carlos Garcia Campos.
513
514         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
515         (testWebKitSettingsUserAgent):
516
517 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
518
519         [GTK] Unsupported browser in www.icloud.com
520         https://bugs.webkit.org/show_bug.cgi?id=133403
521
522         Reviewed by Martin Robinson.
523
524         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
525         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
526         quirk that was removed.
527
528 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
529
530         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
531         https://bugs.webkit.org/show_bug.cgi?id=133779
532
533         Reviewed by Benjamin Poulain.
534         
535         Tell the WebPage to use the testing viewport configuration from the injected bundle.
536
537         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
538         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
539         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
540         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
541         on iOS.
542
543 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
544
545         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
546         https://bugs.webkit.org/show_bug.cgi?id=133770
547
548         Reviewed by Anders Carlsson.
549         
550         Push the per-test view configuration up to TestController, so that platforms
551         can modify the behavior. This also allows platform-specific changes (e.g.
552         for threaded scrolling) to made without #ifefs.
553
554         * WebKitTestRunner/TestController.cpp:
555         (WTR::TestController::updateWebViewSizeForTest):
556         (WTR::TestController::updateWindowScaleForTest):
557         (WTR::shouldUseFixedLayout):
558         (WTR::TestController::updateLayoutTypeForTest):
559         (WTR::TestController::platformConfigureViewForTest):
560         (WTR::TestController::configureViewForTest):
561         * WebKitTestRunner/TestController.h:
562         * WebKitTestRunner/TestInvocation.cpp:
563         (WTR::TestInvocation::invoke):
564         (WTR::sizeWebViewForCurrentTest): Deleted.
565         (WTR::changeWindowScaleIfNeeded): Deleted.
566         (WTR::shouldUseThreadedScrolling): Deleted.
567         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
568         (WTR::shouldUseFixedLayout): Deleted.
569         (WTR::updateLayoutType): Deleted.
570         * WebKitTestRunner/TestInvocation.h:
571         (WTR::TestInvocation::pathOrURL):
572         * WebKitTestRunner/ios/TestControllerIOS.mm:
573         (WTR::shouldMakeViewportFlexible):
574         (WTR::TestController::platformConfigureViewForTest):
575         * WebKitTestRunner/mac/TestControllerMac.mm:
576         (WTR::shouldUseThreadedScrolling):
577         (WTR::TestController::platformConfigureViewForTest):
578
579 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
580
581         [EFL] Add dependencies packages to efl install-dependencies file
582         https://bugs.webkit.org/show_bug.cgi?id=133720
583
584         Reviewed by Csaba Osztrogonác.
585
586         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
587         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
588
589         * efl/install-dependencies:
590
591 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
592
593         Unreviewed. Moving myself to the list of reviewers.
594
595         * Scripts/webkitpy/common/config/contributors.json:
596
597 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
598
599         [EFL] Drop to maintain EFL 32bit release bot
600         https://bugs.webkit.org/show_bug.cgi?id=133710
601
602         Reviewed by Csaba Osztrogonác.
603
604         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
605
606 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
607
608         [GTK] Use a different user agent string depending on the site
609         https://bugs.webkit.org/show_bug.cgi?id=132681
610
611         Reviewed by Anders Carlsson.
612
613         Add a unit test to check user agent quirks.
614
615         * TestWebKitAPI/PlatformGTK.cmake:
616         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
617         (TestWebKitAPI::TEST):
618         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
619         (testWebKitSettings): Site specific quirks setting is now enabled
620         by default.
621
622 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
623
624         Unreviewed, update my list of email addresses in contributors.json.
625
626         * Scripts/webkitpy/common/config/contributors.json:
627
628 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
629
630         Always switch to an sRGB screen color profile when running tests
631         https://bugs.webkit.org/show_bug.cgi?id=133712
632
633         Reviewed by Tim Horton.
634         
635         Switch the screen color profile to sRGB when running tests, because even ref
636         tests need the screen to use the correct color profile.
637
638         * DumpRenderTree/mac/LayoutTestHelper.m:
639         (installLayoutTestColorProfile):
640         * Scripts/webkitpy/port/mac.py:
641         (MacPort.start_helper):
642
643 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
644
645         [EFL] Bump EFL libraries to 1.9
646         https://bugs.webkit.org/show_bug.cgi?id=125479
647
648         Reviewed by Gyuyoung Kim.
649
650         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
651         and László Langó <llango.u-szeged@partner.samsung.com>.
652
653         * ImageDiff/CMakeLists.txt:
654         * MiniBrowser/efl/CMakeLists.txt:
655         * efl/install-dependencies:
656         * efl/jhbuild.modules:
657         * efl/jhbuildrc:
658
659 2014-06-10  David Farler  <dfarler@apple.com>
660
661         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
662         https://bugs.webkit.org/show_bug.cgi?id=133663
663
664         Reviewed by David Kilzer.
665
666         * Scripts/old-run-webkit-tests:
667         (installAndLaunchDumpToolAppUsingNotification):
668         - Remove obsolete notification keys
669         - Key off of mandatory device UDID (a UUID)
670         - Create a device on demand via CoreSimulator if necessary
671         -- Grab the UDID from the created device plist.
672         * Scripts/webkitdirs.pm:
673         (iOSSimulatorDevicesPath): Added
674         (iOSSimulatorDevices): Added
675         (createiOSSimulatorDevice): Added
676         (deleteiOSSimulatorDevice): Added
677
678 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
679
680         [GTK][gtkdoc] remove -Wcast-align
681         https://bugs.webkit.org/show_bug.cgi?id=133640
682
683         Apparently gcc warns that GParamSpec is not castable to
684         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
685         though ARM hackers claim that those only need 4byte alignment. As long as gcc
686         behaves that way, this warning is not very useful, also they break the Debian
687         packaging.
688
689         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
690         scanner compilation, thus the compiler ignores the previous
691         -Waling-cast flag.
692
693         Reviewed by Martin Robinson.
694
695         * gtk/generate-gtkdoc:
696         (get_generator_for_config):
697
698 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
699
700         Disable button animations in regression tests
701         https://bugs.webkit.org/show_bug.cgi?id=133647
702         <rdar://problem/16677530>
703
704         Reviewed by Tim Horton.
705
706         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
707         (WTR::InjectedBundle::platformInitialize):
708
709 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
710
711         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
712         https://bugs.webkit.org/show_bug.cgi?id=133650
713
714         Reviewed by Tim Horton.
715         
716         No point checking for a Windows-style path in Cocoa code.
717
718         * WebKitTestRunner/TestInvocation.cpp:
719         (WTR::shouldUseThreadedScrolling):
720
721 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
722
723         Fix more latched scrolling test flakiness and slowness
724         https://bugs.webkit.org/show_bug.cgi?id=133601
725
726         Reviewed by Brent Fulgham.
727         
728         Latched scrolling tests were flakey for two reasons. First, the EventSender
729         wheel events were async from the web to the UI process, and the resulting
730         synthetic events also async from the UI to the web process. Make them sync
731         for testing.
732         
733         Secondly, the timer-based scrolling tree commit could result in the scrolling
734         tree (specifically the frame node's notion of the scrollable area and content
735         size) not being updated before the scrolling thread starts getting wheel events.
736         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
737         
738         Finally remove all the now-unnecessary timeouts from the tests.
739
740         * WebKitTestRunner/mac/EventSenderProxy.mm:
741         (WTR::EventSenderProxy::mouseMoveTo):
742         (WTR::EventSenderProxy::mouseScrollBy):
743         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
744
745 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
746
747         [EFL] Add parameter to MiniBrowser to disable web security
748         https://bugs.webkit.org/show_bug.cgi?id=121095
749
750         Reviewed by Gyuyoung Kim.
751
752         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
753         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
754         resources from other domains (cross-domain requests) such as access map location on another server.
755         Another possibility is to launch in a webkit browser local file tests that will refer to the links
756         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
757
758         * MiniBrowser/efl/main.c:
759         (window_create):
760         (elm_main):
761
762 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
763
764         32-bit build fix.
765
766         * WebKitTestRunner/mac/EventSenderProxy.mm:
767         (WTR::EventSenderProxy::mouseMoveTo):
768         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
769
770 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
771
772         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
773
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (createWebViewAndOffscreenWindow):
776         * DumpRenderTree/mac/EventSendingController.mm:
777         (-[EventSendingController mouseScrollByX:andY:continuously:]):
778         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
779         * WebKitTestRunner/mac/EventSenderProxy.mm:
780         (WTR::EventSenderProxy::mouseScrollBy):
781         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
782
783 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
784
785         Latched scrolling tests are flakey on Mavericks
786         https://bugs.webkit.org/show_bug.cgi?id=133578
787         <rdar://problem/17180591>
788
789         Reviewed by Brent Fulgham.
790         
791         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
792         be wrong on machines with more than one screen. This is because we use
793         [NSScreen mainScreen] when computing the global coordinates of the events, but
794         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
795         
796         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
797         add comments clarifying why the coordinate math works (which is not obvious given
798         the events have no target window).
799         
800         Some scrolling tests also dispatched events outside the 800x600 test window, so
801         fix those tests, and add logging that will appear in test output when this happens.
802
803         * DumpRenderTree/mac/DumpRenderTree.mm:
804         (createWebViewAndOffscreenWindow):
805         * DumpRenderTree/mac/EventSendingController.mm:
806         (-[EventSendingController mouseScrollByX:andY:continuously:]):
807         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
808         * WebKitTestRunner/mac/EventSenderProxy.mm:
809         (WTR::EventSenderProxy::mouseMoveTo):
810         (WTR::EventSenderProxy::mouseScrollBy):
811         (WTR::EventSenderProxy::continuousMouseScrollBy):
812         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
813
814 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
815
816         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
817         https://bugs.webkit.org/show_bug.cgi?id=133533
818
819         Reviewed by Carlos Garcia Campos.
820
821         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
822         (run): Remove the jhbuild-wrapper wrapper from here. It should be
823         on Scripts/webkitpy/port/gtk.py.
824         * Scripts/webkitpy/port/base.py:
825         (Port.set_option): Add a set_option(name, value) function to set
826         the optparse parameter "name" to the value "value", even if the
827         parameter "name" is already initialized.
828         * Scripts/webkitpy/port/gtk.py:
829         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
830         If another wrapper is specified via the option "-l --wrapper=x",
831         then prepend the jhbuild-wrapper to the one specified.
832
833 2014-06-04  David Farler  <dfarler@apple.com>
834
835         Build ASan WebKit for iOS Simulator
836         https://bugs.webkit.org/show_bug.cgi?id=133489
837
838         Reviewed by Darin Adler.
839
840         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
841         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
842         - Add missing ASan LDFLAGS.
843         * asan/asan.xcconfig:
844         - Split compiler-rt linker flags for OS X and iOS Simulator
845
846 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
847
848         Add myself (yoav@yoav.ws) to contributors.json
849         https://bugs.webkit.org/show_bug.cgi?id=133492
850
851         * Scripts/webkitpy/common/config/contributors.json:
852
853 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
854
855         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
856         https://bugs.webkit.org/show_bug.cgi?id=133149
857
858         Reviewed by Csaba Osztrogonác.
859
860         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
861
862 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
863
864         Add a verbose flag to binding tests
865         https://bugs.webkit.org/show_bug.cgi?id=122303
866
867         Reviewed by Csaba Osztrogonác.
868
869         This patch will:
870         - Add a verbose keyword argument to the BindingsTests constructor,
871         - Add --no-verbose option to the run-bindigs-test.
872         Verbose mode, which is on by default, prints positive results to stdout as before.
873         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
874
875         Original patch from Matthew Hanson <matthew_hanson@apple.com>
876
877         * Scripts/run-bindings-tests:
878         (main):
879         * Scripts/webkitpy/bindings/main.py:
880         (BindingsTests.__init__):
881         (BindingsTests.detect_changes):
882
883 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
884
885         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
886         https://bugs.webkit.org/show_bug.cgi?id=133455
887
888         Reviewed by Timothy Hatcher.
889
890         Since the perf. dashboard doesn't support following renamed benchmarks,
891         keep reporting Speedometer results as DoYouEvenBench results.
892
893         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
894         (_generate_results_dict):
895
896 2014-05-31  Darin Adler  <darin@apple.com>
897
898         Viewport percentage tests that resize the viewport are flaky
899         https://bugs.webkit.org/show_bug.cgi?id=133351
900
901         Reviewed by Anders Carlsson.
902
903         * DumpRenderTree/mac/DumpRenderTree.mm:
904         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
905         happens to be stored in the UI delegate object. This is part of resetting the
906         window position.
907
908         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
909         a frame rectangle. The size is stored in the size of the web view itself.
910         * DumpRenderTree/mac/UIDelegate.mm:
911         (-[UIDelegate resetWindowOrigin]): Added.
912         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
913         old version would store the frame, but not resize the web view!
914         (-[UIDelegate webViewFrame:]): Get the size from the web view.
915
916         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
917         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
918
919         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
920         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
921         the window.
922
923         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
924         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
925         window gets resized too, not just the web view.
926         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
927
928         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
929         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
930         window gets resized too, not just the web view.
931         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
932
933 2014-05-30  Michael Saboff  <msaboff@apple.com>
934
935         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
936         https://bugs.webkit.org/show_bug.cgi?id=133409
937
938         Reviewed by Filip Pizlo.
939
940         Handle creating a tarball the same way as running remote when processing
941         paths in prepareBundle.
942
943         * Scripts/run-jsc-stress-tests:
944
945 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
946
947         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
948         https://bugs.webkit.org/show_bug.cgi?id=132280
949
950         Reviewed by Chris Fleizach.
951
952         Remove implementation of logAccessibilityEvents() for ATK based
953         ports, as this has proved to be a flaky method of checking that
954         ATK events are being properly emitted. Instead, it's better to use
955         the addNotificationListener() functions and provide a JS callback
956         to check that the right events are being emmitted from the tests.
957
958         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
959         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
960         with dummy implementation.
961         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
962         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
963
964 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
965
966         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
967         https://bugs.webkit.org/show_bug.cgi?id=132280
968
969         Rubber stamped by Carlos Garcia Campos.
970
971         Fix two small issues with previous patch (r169483), that caused some tests to break.
972
973         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
974         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
975         duplicated entry.
976         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
977         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
978
979 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
980
981         [ATK] Added new accessibility signal: text-caret-moved.
982         Make AccessibilityUIElement.setSelectedTextRange work
983         as atk_text_set_caret_offset when given offset == 0.
984         https://bugs.webkit.org/show_bug.cgi?id=132527
985
986         Reviewed by Mario Sanchez Prada.
987
988         text-caret-moved signal in accessibilityController is needed to
989         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
990         as LayoutTests. Add the signal to the controller.
991
992         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
993         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
994         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
995         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
996         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
997         (setSelectedTextRange): Change return type to bool.
998         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
999         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
1000         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1001         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
1002         for extra arguments passed to handler and use it for text-caret-moved offset.
1003         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1004         Connect callback to new listener for ATK:AtkText:text-caret-moved.
1005         Refactor so that failures be reported.
1006         Initialize atk interfaces before trying to connect to them, see
1007         https://bugzilla.gnome.org/show_bug.cgi?id=729922
1008         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1009         Simplify code by using a vector in place of dozen variables.
1010         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1011         Comment about not synchronizing with accessibilityController.
1012
1013 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1014
1015         [GTK] Add a WebKit2 Performance bot.
1016         https://bugs.webkit.org/show_bug.cgi?id=132862
1017
1018         Reviewed by Csaba Osztrogonác.
1019
1020         This adds a GTK WebKit2 perf bot.
1021
1022         * BuildSlaveSupport/build.webkit.org-config/config.json:
1023
1024 2014-05-29  Dan Bernstein  <mitz@apple.com>
1025
1026         Fixed the WebKitTestRunner build after r169452.
1027
1028         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1029         (WTR::InjectedBundle::initialize):
1030
1031 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
1032
1033         Unreviewed. Update my email addresses in contributors.json.
1034
1035         * Scripts/webkitpy/common/config/contributors.json:
1036
1037 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
1038
1039         Need an API test for bug #133193 (r169315)
1040         <https://bugs.webkit.org/show_bug.cgi?id=133324>
1041
1042         This adds an API test that ensures that calling "stop loading" during a
1043         "did fail provisional load" callback doesn't crash.
1044
1045         Reviewed by Andy Estes.
1046
1047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048         Add new files to project.
1049
1050         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
1051         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1052         If the message is the "test done" message, record that.
1053         (TestWebKitAPI::setInjectedBundleClient):
1054         Register a function for the "did receive message from injected bundle"
1055         callback.
1056         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1057         Assert that we received the message from the injected bundle, and set
1058         'done' to finish the test.
1059         (TestWebKitAPI::TEST):
1060         Create a WebView, register a page loader client for the "did fail
1061         provisional load" callback, and load a non-existent resource.
1062
1063         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
1064         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
1065         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
1066         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
1067         provisional load failed.
1068         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
1069         Register a page loader client for the "did fail provisional load"
1070         callback.
1071         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
1072         Call WKBundlePageStopLoading() during the callback. This not crashing
1073         is what we're ensuring with this test.
1074
1075 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1076
1077         [GTK] Make it possible to build with FTL enabled
1078         https://bugs.webkit.org/show_bug.cgi?id=133219
1079
1080         Reviewed by Philippe Normand.
1081
1082         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
1083         same revision than mac.
1084
1085 2014-05-27  Michael Saboff  <msaboff@apple.com>
1086
1087         REGRESSION(r169265): sh: line 0: cd: ../.vm
1088         https://bugs.webkit.org/show_bug.cgi?id=133242
1089
1090         Rubber stamped by Oliver Hunt.
1091
1092         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
1093         array since the command may contain character escapes that don't work with the
1094         array form of system().
1095
1096         * Scripts/run-jsc-stress-tests:
1097
1098 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1099
1100         [EFL] Change download url of freetype6
1101         https://bugs.webkit.org/show_bug.cgi?id=133303
1102
1103         Reviewed by Csaba Osztrogonác.
1104
1105         freetype6 tarball isn't downloaded in Korea. So, we need to
1106         change the url for now.
1107
1108         * efl/jhbuild.modules:
1109
1110 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1111
1112         Remove BLOB guards
1113         https://bugs.webkit.org/show_bug.cgi?id=132863
1114
1115         Reviewed by Csaba Osztrogonác.
1116
1117         * Scripts/webkitperl/FeatureList.pm:
1118
1119 2014-05-27  Alberto Garcia  <berto@igalia.com>
1120
1121         Remove leftover comment from r165182.
1122
1123         Rubber stamped by Carlos Garcia Campos.
1124
1125         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1126
1127 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1128
1129         [EFL] Add LLVM as optional jhbuild module for FTL developers
1130         https://bugs.webkit.org/show_bug.cgi?id=133216
1131
1132         Reviewed by Gyuyoung Kim.
1133
1134         * efl/jhbuild.modules:
1135
1136 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1137
1138         Fix test failures on python test
1139         https://bugs.webkit.org/show_bug.cgi?id=133297
1140
1141         Reviewed by Dirk Schulze.
1142
1143         2 tests are failing because of unbounded local variable reference in test_importer.py.
1144
1145         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
1146         (TestImporter.import_tests):
1147
1148 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1149
1150         [GTK] GObject DOM bindings API break test fails in the tests bots
1151         https://bugs.webkit.org/show_bug.cgi?id=133211
1152
1153         Reviewed by Martin Robinson.
1154
1155         When generating the built product archive on platform GTK, we need
1156         to copy also the file gtkdoc-webkitdom.cfg and the directory
1157         DerivedSources/webkitdom.
1158
1159         * BuildSlaveSupport/built-product-archive:
1160         (archiveBuiltProduct):
1161
1162 2014-05-26  Commit Queue  <commit-queue@webkit.org>
1163
1164         Unreviewed, rolling out r169122.
1165         https://bugs.webkit.org/show_bug.cgi?id=133288
1166
1167         Broke CJK font fallback (Requested by ap on #webkit).
1168
1169         Reverted changeset:
1170
1171         "[Mac] WebProcess doesn't follow localization of UI process
1172         when run as a service"
1173         https://bugs.webkit.org/show_bug.cgi?id=133126
1174         http://trac.webkit.org/changeset/169122
1175
1176 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1177
1178         [GTK] WebProcess leaked when closing pages with network process enabled
1179         https://bugs.webkit.org/show_bug.cgi?id=129684
1180
1181         Reviewed by Anders Carlsson.
1182
1183         Enable the test to check that web processes finish when the web
1184         view is destroyed.
1185
1186         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1187
1188 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1189
1190         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
1191         https://bugs.webkit.org/show_bug.cgi?id=133279
1192
1193         Reviewed by Philippe Normand.
1194
1195         generator.saw_warnings is only set by GTKDoc::generate(), so it
1196         should only be used after generate.
1197
1198         * gtk/generate-gtkdoc:
1199         (generate_documentation_for_config): Do not check
1200         generator.saw_warnings again, simply return the value returned by
1201         generate_doc() which is generator.saw_warnings. When rebasing,
1202         returns always False since there aren't warnings.
1203
1204 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1205
1206         W3C test importer should catch exceptions coming from HTML/CSS conversion
1207         https://bugs.webkit.org/show_bug.cgi?id=133176
1208
1209         Reviewed by Darin Adler.
1210
1211         Exceptions raised when converting HTML/CSS are caught.
1212         Files for which conversion failed are still copied to the target directory.
1213         Each individual conversion failure is logged.
1214         Total conversion failure number is logged at the end of the import process.
1215
1216         * Scripts/webkitpy/w3c/test_importer.py:
1217         (TestImporter.import_tests):
1218
1219 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1220
1221         [GTK] Allow to run the tests on the native X display.
1222         https://bugs.webkit.org/show_bug.cgi?id=133157
1223
1224         Reviewed by Benjamin Poulain.
1225
1226         This adds a new driver (xorgdriver) that runs the tests on the
1227         X display referenced by the environment variable DISPLAY.
1228
1229         This new driver will be activated only if the environment variable
1230         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
1231         tests and performance tests.
1232
1233         This patch also makes the script run-perf-tests to check the
1234         system dependencies before starting the tests. Previously this
1235         was not checked, and if the system dependencies were not met,
1236         the script tried to execute the tests anyway, causing massive
1237         failures. For example, if you had Xvfb not installed and you
1238         wanted to use the Xvfb driver (the default on GTK and EFL),
1239         run-perf-tests would not abort.
1240
1241         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1242         (PerfTestsRunner._parse_args): Check the system dependencies of
1243         the driver before starting the tests.
1244         * Scripts/webkitpy/port/driver.py:
1245         (Driver): Implement generic check_driver method.
1246         (Driver.check_driver):
1247         (Driver.check_driver.implementation):
1248         * Scripts/webkitpy/port/gtk.py:
1249         (GtkPort._driver_class): Check for environment variable
1250         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
1251         * Scripts/webkitpy/port/xorgdriver.py: Added.
1252         (XorgDriver): Implement Xorg driver.
1253         (XorgDriver.check_driver):
1254         (XorgDriver._start):
1255
1256 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1257
1258         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
1259         https://bugs.webkit.org/show_bug.cgi?id=133215
1260
1261         Reviewed by Csaba Osztrogonác.
1262
1263         This reverts r166798.
1264
1265         * BuildSlaveSupport/kill-old-processes:
1266         (main):
1267
1268 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1269
1270         [EFL] Turn on ENABLE_CSS_FILTERS in build script
1271         https://bugs.webkit.org/show_bug.cgi?id=133278
1272
1273         Reviewed by Gyuyoung Kim.
1274
1275         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
1276
1277 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1278
1279         run-javascriptcore-tests warning fix on non Mac platforms
1280         https://bugs.webkit.org/show_bug.cgi?id=133260
1281
1282         Reviewed by Darin Adler.
1283
1284         * Scripts/webkitdirs.pm:
1285         (argumentsForConfiguration):
1286
1287 2014-05-23  Michael Saboff  <msaboff@apple.com>
1288
1289         REGRESSION(r169265): sh: line 0: cd: ../.vm
1290         https://bugs.webkit.org/show_bug.cgi?id=133242
1291
1292         Rubber stamped by Geoffrey Garen.
1293
1294         Added missing shell escapes '\' required as part of previous fix.
1295
1296         * Scripts/run-jsc-stress-tests:
1297
1298 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
1299
1300         Revert the erroneous change committed in r169286.
1301
1302         * Scripts/webkitpy/performance_tests/perftest.py:
1303         (PerfTest._run_with_driver):
1304
1305 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
1306
1307         run-perf-tests should ignore whitespace lines when snarfing test output
1308         https://bugs.webkit.org/show_bug.cgi?id=133238
1309
1310         Reviewed by Ryosuke Niwa.
1311
1312         Required for PerformanceTests/Canvas/terrain.html.
1313
1314         * Scripts/webkitpy/performance_tests/perftest.py:
1315         (PerfTest._run_with_driver):
1316         (PerfTest):
1317
1318 2014-05-23  Michael Saboff  <msaboff@apple.com>
1319
1320         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
1321         https://bugs.webkit.org/show_bug.cgi?id=133223
1322
1323         Reviewed by Geoffrey Garen.
1324
1325         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
1326         string before calling IO.popen() to work with older versions of ruby.
1327         Changed the remote path in runShellTestRunner to quote the command
1328         string we want to run via ssh so that it will work correctly with array
1329         to string conversion needed for popen.
1330
1331         * Scripts/run-jsc-stress-tests:
1332
1333 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1334
1335         Remove 'css-shaders' option from the build-webkit
1336         https://bugs.webkit.org/show_bug.cgi?id=133212
1337
1338         Reviewed by Daniel Bates.
1339
1340         Original CSS shaders removed in r162644.
1341
1342         * Scripts/webkitperl/FeatureList.pm:
1343
1344 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1345
1346         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
1347         https://bugs.webkit.org/show_bug.cgi?id=133209
1348
1349         Reviewed by Sergio Villar Senin.
1350
1351         Return FAILURE when the command failed to run.
1352
1353         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1354         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
1355
1356 2014-05-23  Alberto Garcia  <berto@igalia.com>
1357
1358         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
1359         https://bugs.webkit.org/show_bug.cgi?id=133210
1360
1361         Reviewed by Carlos Garcia Campos.
1362
1363         * gtk/install-dependencies:
1364
1365 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1366
1367         Add Yusuke Suzuki to the list of contributors (for real)
1368
1369         Wrong section...
1370
1371         * Scripts/webkitpy/common/config/contributors.json:
1372
1373 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1374
1375         Add Yusuke Suzuki to the list of contributors
1376
1377         * Scripts/webkitpy/common/config/contributors.json:
1378
1379 2014-05-22  Michael Saboff  <msaboff@apple.com>
1380
1381         Eliminate n/total progress update from run-jsc-stress-tests output to file
1382         https://bugs.webkit.org/show_bug.cgi?id=133191
1383
1384         Reviewed by Geoffrey Garen.
1385
1386         Changed progressMeter setting to be based on stdout being a tty instead of
1387         stdin.  Unified the processing of output from the shell runner to match the
1388         same processing as is used by the makefile runner.  As part of this, the 
1389         shell runner script was simplified.  It now forwards the output of each
1390         test_script just like the Makefile and doesn't provide its own progress.
1391
1392         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1393         * Scripts/run-jsc-stress-tests:
1394
1395 2014-05-22  Michael Saboff  <msaboff@apple.com>
1396
1397         Add option to run-jsc-stress-tests to use installed jsc
1398         https://bugs.webkit.org/show_bug.cgi?id=133102
1399
1400         Reviewed by Geoffrey Garen.
1401
1402         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
1403         provied with the --jsc option.
1404
1405         * Scripts/run-jsc-stress-tests:
1406
1407 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1408
1409         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
1410         https://bugs.webkit.org/show_bug.cgi?id=132907
1411
1412         Reviewed by Gyuyoung Kim.
1413
1414         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
1415         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
1416
1417         * efl/install-dependencies:
1418
1419 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1420
1421         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
1422         https://bugs.webkit.org/show_bug.cgi?id=133145
1423
1424         Reviewed by Csaba Osztrogonác.
1425
1426         * Scripts/run-jsc-stress-tests:
1427
1428 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
1429
1430         [Mac] WebProcess doesn't follow localization of UI process when run as a service
1431         https://bugs.webkit.org/show_bug.cgi?id=133126
1432         <rdar://problem/13396515>
1433         <rdar://problem/16561084>
1434
1435         Reviewed by Sam Weinig and Tim Horton.
1436
1437         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1438         (WTR::InjectedBundle::platformInitialize): It was too late to override language
1439         here, and it's not necessary any more. Keeping the code for older OS versions in
1440         case it did have effect in some code paths.
1441
1442 2014-05-19  David Farler  <dfarler@apple.com>
1443
1444         Move WebKitTestRunner to std::unique_ptr
1445         https://bugs.webkit.org/show_bug.cgi?id=133081
1446
1447         Reviewed by Daniel Bates.
1448
1449         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1450         (WTR::InjectedBundle::didCreatePage):
1451         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1452         * WebKitTestRunner/TestController.cpp:
1453         (WTR::TestController::initialize):
1454         (WTR::TestController::createWebViewWithOptions):
1455         (WTR::TestController::resetStateToConsistentValues):
1456         (WTR::TestController::runTest):
1457         * WebKitTestRunner/TestController.h:
1458         * WebKitTestRunner/TestInvocation.cpp:
1459         * WebKitTestRunner/TestInvocation.h:
1460         * WebKitTestRunner/WorkQueueManager.cpp:
1461         (WTR::WorkQueueManager::processWorkQueue):
1462         (WTR::WorkQueueManager::enqueue):
1463         * WebKitTestRunner/WorkQueueManager.h:
1464
1465 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1466
1467         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
1468         https://bugs.webkit.org/show_bug.cgi?id=133119
1469
1470         Reviewed by Sergio Villar Senin.
1471
1472         Check that redirect response parameter of
1473         WebKitWebPage::send-request signal is NULL when not redirecting
1474         and a valid WebKitURIResponse object when redirecting.
1475
1476         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1477         (testWebResourceSendRequest):
1478         (serverCallback):
1479         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1480         (sendRequestCallback):
1481
1482 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1483
1484         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1485         https://bugs.webkit.org/show_bug.cgi?id=133117
1486
1487         Reviewed by Philippe Normand.
1488
1489         Bring back missing tests to the build.
1490
1491         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1492
1493 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
1494
1495         Take care of some ARM64 test failures
1496         https://bugs.webkit.org/show_bug.cgi?id=133090
1497
1498         Reviewed by Geoffrey Garen.
1499
1500         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1501
1502 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1503
1504         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1505         <http://webkit.org/b/133089>
1506
1507         Reviewed by Darin Adler.
1508
1509         * Scripts/webkitdirs.pm:
1510         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1511         specified on the command line, we would remove the '--sdk'
1512         arguments, but leave '--sim', potentially passing it along to
1513         xcodebuild causing a build failure.  This happens when
1514         'old-run-webkit-tests --release --sim' invokes
1515         build-dumprendertree when DumpRenderTree hasn't been built yet.
1516
1517 2014-05-19  David Farler  <dfarler@apple.com>
1518
1519         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1520         https://bugs.webkit.org/show_bug.cgi?id=133086
1521
1522         Reviewed by Daniel Bates.
1523
1524         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1525
1526 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1527
1528         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1529         <http://webkit.org/b/132954>
1530
1531         * Scripts/webkitdirs.pm:
1532         (sharedCommandLineOptionsUsage): Remove the prototype for the
1533         subroutine.  Older perls don't like the "+@" syntax.
1534
1535 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1536
1537         run-javascriptcore-tests should sort the list of failing stress tests
1538         https://bugs.webkit.org/show_bug.cgi?id=132989
1539
1540         Reviewed by Csaba Osztrogonác.
1541
1542         * Scripts/run-javascriptcore-tests:
1543
1544 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1545
1546         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1547         <http://webkit.org/b/132954>
1548
1549         Reviewed by Darin Adler.
1550
1551         Extract code into setupMacWebKitEnvironment() for setting up
1552         common environment variables so it may be shared.  Sets
1553         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1554         using guardmalloc to some scripts.
1555
1556         Also adds support for parsing shared (common) command-line
1557         switches, initially just -g|--guard-malloc.
1558
1559         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1560         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1561         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
1562         local copy of %ENV when launching Safari so we don't have to
1563         restore variables.
1564
1565         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1566         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1567         Check result of GetOptions() to catch invalid command-line
1568         switches.
1569         (runTest): Use a local copy of %ENV when running tests so we
1570         don't have to restore variables.
1571         (prepareEnvironmentForRunningTestTool): Call
1572         setupMacWebKitEnvironment().
1573
1574         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1575         using sharedCommandLineOptions() and
1576         sharedCommandLineOptionsUsage().  Call
1577         setupMacWebKitEnvironment().
1578
1579         * Scripts/webkitdirs.pm:
1580         (sharedCommandLineOptions): Return array of common switches to
1581         pass to Getopt::Long::GetOptions().
1582         (sharedCommandLineOptionsUsage): Return formatted string of
1583         common switches for printing usage help text.
1584         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1585         guardmalloc.
1586         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1587         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1588         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1589         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
1590         local copy of %ENV when launching Safari so we don't have to
1591         restore variables.
1592         (execMacWebKitAppForDebugging): Call
1593         setupMacWebKitEnvironment().
1594
1595 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
1596
1597         support for navigator.hardwareConcurrency
1598         https://bugs.webkit.org/show_bug.cgi?id=132588
1599
1600         Reviewed by Filip Pizlo.
1601
1602         * Scripts/webkitperl/FeatureList.pm:
1603
1604 2014-05-18  Anders Carlsson  <andersca@apple.com>
1605
1606         Implement Navigations for all methods declared returning one
1607         https://bugs.webkit.org/show_bug.cgi?id=133048
1608         <rdar://problem/16830064>
1609
1610         Reviewed by Sam Weinig.
1611
1612         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1613         Import WebKit.h.
1614         
1615         * MiniBrowser/mac/WK2BrowserWindowController.m:
1616         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1617         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1618         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1619         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1620         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1621         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1622         Print out the navigations.
1623
1624 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1625
1626         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1627         https://bugs.webkit.org/show_bug.cgi?id=133029
1628
1629         Reviewed by Simon Fraser.
1630
1631         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1632         toggling it on a WK2 window needs restart.
1633         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1634         the WebPreferences just to support this temporary toggle.
1635
1636         * MiniBrowser/mac/BrowserWindowController.h:
1637         * MiniBrowser/mac/MainMenu.xib:
1638         * MiniBrowser/mac/WK1BrowserWindowController.m:
1639         (-[WK1BrowserWindowController validateMenuItem:]):
1640         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1641         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1642         * MiniBrowser/mac/WK2BrowserWindowController.m:
1643         (-[WK2BrowserWindowController validateMenuItem:]):
1644         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1645         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1646
1647 2014-05-17  Anders Carlsson  <andersca@apple.com>
1648
1649         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1650         https://bugs.webkit.org/show_bug.cgi?id=133033
1651         <rdar://problem/16830143>
1652
1653         Reviewed by Sam Weinig.
1654
1655         Set up the WebSQL and IndexedDB directories.
1656
1657         * WebKitTestRunner/TestController.cpp:
1658         (WTR::TestController::initialize):
1659
1660 2014-05-16  Martin Hock  <mhock@apple.com>
1661
1662         MemoryCache::addImageToCache should return the result of add().
1663         https://bugs.webkit.org/show_bug.cgi?id=132928
1664         <rdar://problem/16651547>
1665
1666         Reviewed by Alexey Proskuryakov.
1667
1668         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1670         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1671         (TestWebKitAPI::TEST):
1672
1673 2014-05-15  David Farler  <dfarler@apple.com>
1674
1675         old-run-webkit-tests: allow specifying a simulator app path
1676         https://bugs.webkit.org/show_bug.cgi?id=132975
1677
1678         Reviewed by Anders Carlsson.
1679
1680         * Scripts/old-run-webkit-tests:
1681         (openIPhoneSimulator):
1682         Add new --simulator-app command line parameter for specifying the
1683         absolute path to the simulator app to launch before starting a
1684         session.
1685
1686 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1687
1688         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1689         https://bugs.webkit.org/show_bug.cgi?id=131363
1690
1691         Reviewed by Csaba Osztrogonác.
1692
1693         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1694         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1695         (MockBugzilla):
1696         * Scripts/webkitpy/tool/commands/download_unittest.py:
1697         (test_create_rollout_multiple_revision_with_one_resolved):
1698         (test_create_rollout_multiple_resolved):
1699         (test_rollout_two_revisions):
1700         (test_rollout_multiple_revisions):
1701         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1702         * Scripts/webkitpy/tool/steps/createbug.py:
1703         (CreateBug.run):
1704         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1705         (ReopenBugAfterRollout.run):
1706
1707 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1708
1709         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1710         https://bugs.webkit.org/show_bug.cgi?id=132956
1711
1712         Reviewed by Sam Weinig.
1713
1714         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1715         * MiniBrowser/mac/AppDelegate.m:
1716         * MiniBrowser/mac/WK2BrowserWindowController.m:
1717         * TestWebKitAPI/InjectedBundleController.h:
1718         * TestWebKitAPI/InjectedBundleMain.cpp:
1719         * TestWebKitAPI/JavaScriptTest.cpp:
1720         * TestWebKitAPI/PlatformUtilities.h:
1721         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1722         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1723         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1724         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1725         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1726         (TestWebKitAPI::TEST):
1727         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1728         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1729         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1730         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1731         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1732         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1733         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1734         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1735         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1736         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1737         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1738         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1739         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1740         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1741         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1742         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1743         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1744         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1745         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1746         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1747         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1748         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1749         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1750         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1751         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1752         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1753         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1754         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1755         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1756         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1757         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1758         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1759         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1760         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1761         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1762         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1763         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1764         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1765         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1766         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1767         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1768         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1769         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1770         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1771         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1772         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1773         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1774         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1775         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1776         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1777         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1778         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1779         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1780         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1781         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1782         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1783         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1784         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1785         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1786         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1787         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1788         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1789         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1790         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1791         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1792         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1793         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1794         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1795         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1796         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1797         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1798         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1799         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1800         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1801         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1802         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1803         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1804         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1805         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1806         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1807         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1808         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1809         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1810         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1811         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1812         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1813         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1814         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1815         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1816         * TestWebKitAPI/config.h:
1817         * TestWebKitAPI/efl/PlatformWebView.cpp:
1818         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1819         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1820         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1821         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1822         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1823         * WebKitTestRunner/EventSenderProxy.h:
1824         * WebKitTestRunner/GeolocationProviderMock.cpp:
1825         * WebKitTestRunner/GeolocationProviderMock.h:
1826         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1827         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1828         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1829         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1830         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1831         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1832         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1833         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1834         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1835         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1836         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1837         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1838         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1839         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1840         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1841         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1842         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1843         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1844         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1845         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1846         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1847         * WebKitTestRunner/PlatformWebView.h:
1848         * WebKitTestRunner/StringFunctions.h:
1849         * WebKitTestRunner/TestController.cpp:
1850         * WebKitTestRunner/TestController.h:
1851         * WebKitTestRunner/TestInvocation.cpp:
1852         * WebKitTestRunner/TestInvocation.h:
1853         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1854         * WebKitTestRunner/WebNotificationProvider.cpp:
1855         * WebKitTestRunner/WebNotificationProvider.h:
1856         * WebKitTestRunner/WorkQueueManager.cpp:
1857         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1858         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1859         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1860         * WebKitTestRunner/config.h:
1861         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1862         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1863         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1864         * WebKitTestRunner/ios/TestControllerIOS.mm:
1865         * WebKitTestRunner/mac/EventSenderProxy.mm:
1866         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1867         * WebKitTestRunner/mac/TestControllerMac.mm:
1868
1869 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1870
1871         [EFL][WK2] Skip failing unit tests
1872         https://bugs.webkit.org/show_bug.cgi?id=132979
1873
1874         Reviewed by Daniel Bates.
1875
1876         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1877
1878 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1879
1880         [iOS] Support TestWebKitAPI in the iOS Simulator
1881         <http://webkit.org/b/129535>
1882         <rdar://problem/16203529>
1883
1884         Reviewed by Daniel Bates.
1885
1886         * Scripts/run-api-tests:
1887         (runTest):
1888         (listAllTests):
1889         - Extract common arguments into local variable.
1890         - Use xcrun to find the sim tool in order to invoke
1891         TestWebKitAPI properly in the iOS Simulator. 
1892
1893         * Scripts/webkitdirs.pm:
1894         (argumentsForConfiguration): Set --device or --sim as
1895         appropriate to fix buildTestTool() in run-api-tests.
1896
1897 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1898
1899         Fix a logging typo in copy-webkitlibraries-to-product-directory
1900
1901         Reviewed by Dean Jackson.
1902
1903         * Scripts/copy-webkitlibraries-to-product-directory:
1904
1905 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1906
1907         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1908         <http://webkit.org/b/132959>
1909
1910         Reviewed by Dan Bernstein.
1911
1912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1913         Cocoa directory to project and move URLExtras.mm into it.
1914         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1915
1916 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1917
1918         [GTK] Compile all installed resources as GResources
1919         https://bugs.webkit.org/show_bug.cgi?id=131099
1920
1921         Reviewed by Philippe Normand.
1922
1923         * Scripts/webkitpy/port/gtk.py:
1924         (GtkPort.setup_environ_for_server): Removed now unneeded
1925         AUDIO_RESOURCES_PATH env var.
1926
1927 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1928
1929         Remove CSS_STICKY_POSITION guards
1930         https://bugs.webkit.org/show_bug.cgi?id=132676
1931
1932         Reviewed by Simon Fraser.
1933
1934         * Scripts/webkitperl/FeatureList.pm:
1935
1936 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1937
1938         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1939         https://bugs.webkit.org/show_bug.cgi?id=132686
1940
1941         Reviewed by Philippe Normand.
1942
1943         Bring back InputMethodFilter test to the build and compile it into
1944         a single binary TestWebCore with the other WebCore tests. Also
1945         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1946
1947         * Scripts/run-gtk-tests:
1948         (TestRunner): Remove WebCoreGtk from the list of test directories.
1949         * TestWebKitAPI/PlatformGTK.cmake:
1950         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1951
1952 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1953
1954         [EFL] Make XVFBDriver optional
1955         https://bugs.webkit.org/show_bug.cgi?id=131036
1956
1957         Reviewed by Gyuyoung Kim.
1958
1959         * Scripts/webkitpy/port/efl.py:
1960         (EflPort._driver_class):
1961
1962 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1963
1964         Flakiness dashboard contains outdated list of bots on builders.jsonp
1965         https://bugs.webkit.org/show_bug.cgi?id=132874
1966
1967         Reviewed by Darin Adler.
1968
1969         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1970         file by changing to the directory Tools/TestResultServer and executing
1971         the script generate_builders_json.py
1972
1973 2014-05-11  Anders Carlsson  <andersca@apple.com>
1974
1975         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1976         https://bugs.webkit.org/show_bug.cgi?id=132809
1977
1978         Reviewed by Dan Bernstein.
1979
1980         * WebKitTestRunner/TestController.cpp:
1981         (WTR::TestController::initialize):
1982         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1983
1984 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1985
1986         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1987         https://bugs.webkit.org/show_bug.cgi?id=132739
1988
1989         Reviewed Anders Carlsson.
1990
1991         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1992         the JSC unit tests.
1993         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1994
1995 2014-05-11  Anders Carlsson  <andersca@apple.com>
1996
1997         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1998         https://bugs.webkit.org/show_bug.cgi?id=132806
1999
2000         Reviewed by Beth Dakin.
2001
2002         Migrate to WKContextConfiguration.
2003
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::TestController::initialize):
2006
2007 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2008
2009         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
2010         https://bugs.webkit.org/show_bug.cgi?id=132685
2011
2012         Reviewed by Martin Robinson.
2013
2014         Use a single TestWebKit2 binary for all WebKit2 C API tests.
2015
2016         * TestWebKitAPI/PlatformGTK.cmake:
2017
2018 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
2019
2020         [iOS] Switch geolocation to an explicit authorization query model
2021         https://bugs.webkit.org/show_bug.cgi?id=132717
2022
2023         Reviewed by Sam Weinig.
2024
2025         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2026         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
2027         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
2028
2029 2014-05-09  David Farler  <dfarler@apple.com>
2030
2031         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
2032         https://bugs.webkit.org/show_bug.cgi?id=132718
2033
2034         Reviewed by David Kilzer.
2035
2036         The simulator may not be able to look up runtimes by SDK paths
2037         and instead will map SDK versions to runtimes instead. In
2038         com.apple.iphonesimulator.startSession notifications,
2039         'runtimeIdentifier' (SDK version string) is preferred over
2040         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
2041         when creating a new DRT or WKTR simulator session.
2042
2043         IPhoneSimulatorNotification.pm filters out keys for this
2044         notification's userInfo with a hard-coded list. There's no harm
2045         in including extra key-value pairs in an NSNotification userInfo
2046         dictionary anyway and the simulator may again change its
2047         userInfo schema for this notification.
2048
2049         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2050         (postStartSessionNotification):
2051         * Scripts/old-run-webkit-tests:
2052         (installAndLaunchDumpToolAppUsingNotification):
2053
2054 2014-05-09  Anders Carlsson  <andersca@apple.com>
2055
2056         Another build fix.
2057
2058         * Scripts/build-webkit:
2059         WebKit2 should always be built for OS X and iOS.
2060
2061 2014-05-09  Anders Carlsson  <andersca@apple.com>
2062
2063         Follow-up build fix.
2064
2065         * Scripts/build-webkit:
2066         WebKit2 should no longer be built before WebKit.
2067
2068 2014-05-09  Anders Carlsson  <andersca@apple.com>
2069
2070         Rename WebKit2.framework to WebKit.framework
2071         https://bugs.webkit.org/show_bug.cgi?id=132743
2072         <rdar://problem/15920046>
2073
2074         Reviewed by Dan Bernstein.
2075
2076         * Scripts/check-for-inappropriate-files-in-framework:
2077         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
2078         Change WebKit2 to WebKit.
2079
2080         * Scripts/check-for-webkit-framework-include-consistency:
2081         Change WebKit to WebKitLegacy.
2082
2083 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
2084
2085         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
2086         https://bugs.webkit.org/show_bug.cgi?id=132732
2087
2088         Reviewed by Alexey Proskuryakov.
2089
2090         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2093         (EWS): Remove GTK+ WK1 EWS.
2094
2095 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2096
2097         Add new u-szeged contributors.
2098
2099         Reviewed by Csaba Osztrogonác.
2100
2101         * Scripts/webkitpy/common/config/contributors.json:
2102
2103 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2104
2105         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
2106         https://bugs.webkit.org/show_bug.cgi?id=132736
2107
2108         Reviewed by Philippe Normand.
2109
2110         There are two problems, the path returned by common.library_build_path() is wrong when
2111         common.binary_build_path() has previously been called, and the test is still looking for
2112         the .la instead of .so
2113
2114         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
2115         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
2116         of .la as extension of the injected bundle library.
2117         * gtk/common.py:
2118         (binary_build_path): Remove unused global variable and add a new
2119         one for binary_build_dir instead of sharing the same global
2120         variable for library_build_path and binary_build_path.
2121
2122 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
2123
2124         [EFL] Enable MEDIA_STREAM for EFL port
2125         https://bugs.webkit.org/show_bug.cgi?id=132648
2126
2127         Reviewed by Gyuyoung Kim.
2128
2129         Script modified to enable MEDIA_STREAM for EFL build.
2130
2131         * Scripts/webkitperl/FeatureList.pm: 
2132
2133 2014-05-08  David Farler  <dfarler@apple.com>
2134
2135         old-run-webkit-tests: update strings for simulator devices and app name
2136         https://bugs.webkit.org/show_bug.cgi?id=132687
2137
2138         Reviewed by Darin Adler.
2139
2140         iPhone Retina (4-inch) -> iPhone 5
2141         iPhone Retina (4-inch 64-bit) -> iPhone 5s
2142
2143         * Scripts/old-run-webkit-tests:
2144         (installAndLaunchDumpToolAppUsingNotification):
2145         (openIPhoneSimulator):
2146         (quitIPhoneSimulator):
2147         quit iOS Simulator, not iPhone Simulator.
2148
2149 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2150
2151         REGRESSION(r168471): Update the builder names on the scheduler list.
2152         https://bugs.webkit.org/show_bug.cgi?id=132699
2153
2154         Reviewed by Martin Robinson.
2155
2156         On r168471 I missed to update the builder names for the GTK build
2157         bots on the AnyBranchScheduler type scheduler list of bots.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/config.json:
2160
2161 2014-05-08  Brady Eidson  <beidson@apple.com>
2162
2163         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
2164         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
2165
2166         Reviewed by Tim Horton.
2167
2168         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2169         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2170
2171 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2172
2173         REGRESSION(r168471): Duplicate builddirs broke the build master.
2174         https://bugs.webkit.org/show_bug.cgi?id=132688
2175
2176         Reviewed by Carlos Garcia Campos.
2177
2178         Rename the builddirs of the new GTK bots introduced on r168471 to
2179         be unique. Otherwise the master will break.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/config.json:
2182
2183 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2184
2185         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
2186         https://bugs.webkit.org/show_bug.cgi?id=132674
2187
2188         Reviewed by Philippe Normand.
2189
2190         Only ignore mkdir failure when exception is raised because the
2191         file already exists and it's a directory.
2192
2193         * gtk/webkitdom.py:
2194         (write_doc_files):
2195
2196 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2197
2198         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
2199         https://bugs.webkit.org/show_bug.cgi?id=131358
2200
2201         Reviewed by Carlos Garcia Campos.
2202
2203         Current 64-bit GTK build bots (Release and Debug) not only test
2204         the build, but run all tests. Split each one of the bots in
2205         BuildOnly and TestWebKit2.
2206
2207         This will allow us to have a better overview of the status of
2208         the GTK port.
2209
2210         Original patch from Sergio Villar Senin <svillar@igalia.com>
2211
2212         * BuildSlaveSupport/build.webkit.org-config/config.json:
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2215         (WebKitBuildbot):
2216         * Scripts/webkitpy/port/builders.py:
2217         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2218         (TestRebaselineTest.test_baseline_directory):
2219         * TestResultServer/static-dashboards/builders.jsonp:
2220         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2221         (resetGlobals):
2222         * TestResultServer/static-dashboards/loader_unittests.js:
2223
2224 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2225
2226         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
2227         https://bugs.webkit.org/show_bug.cgi?id=126022
2228
2229         Reviewed by Benjamin Poulain.
2230
2231         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
2232
2233         Added an unit test case to check if scroll position and scale are restored properly.
2234
2235         * TestWebKitAPI/PlatformEfl.cmake:
2236         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
2237         (TestWebKitAPI::didFinishLoadForFrame):
2238         (TestWebKitAPI::didChangeContentsPosition):
2239         (TestWebKitAPI::TEST):
2240         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
2241         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
2242
2243 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
2244
2245         WebKit1 is flashy when compositing layers come and go
2246         https://bugs.webkit.org/show_bug.cgi?id=132655
2247         <rdar://problem/16830981&16788846>
2248
2249         Reviewed by Sam Weinig.
2250         
2251         Revert the change from r166117.
2252
2253         * DumpRenderTree/mac/DumpRenderTree.mm:
2254         (updateDisplay):
2255
2256 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
2257
2258         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
2259         https://bugs.webkit.org/show_bug.cgi?id=132622
2260
2261         Reviewed by Mario Sanchez Prada.
2262
2263         * DumpRenderTree/AccessibilityUIElement.cpp:
2264         (selectTextWithCriteriaCallback):
2265         (isEqualCallback):
2266         * DumpRenderTree/AccessibilityUIElement.h:
2267         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2268         (AccessibilityUIElement::selectTextWithCriteria):
2269         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2270         (AccessibilityUIElement::selectTextWithCriteria):
2271         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2272         (selectTextParameterizedAttributeForCriteria):
2273         (AccessibilityUIElement::selectTextWithCriteria):
2274         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2275         (AccessibilityUIElement::selectTextWithCriteria):
2276         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2277         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2278         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2279         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2280         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2281         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2282         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2283         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2284         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2285         (WTR::selectTextParameterizedAttributeForCriteria):
2286         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2287
2288 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2289
2290         [SOUP] TLSErrors do not cause page load to fail when not ignored
2291         https://bugs.webkit.org/show_bug.cgi?id=121548
2292
2293         Reviewed by Sergio Villar Senin.
2294
2295         Add unit tests to check that the load fails with TLS errors in
2296         case of a redirection.
2297
2298         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2299         (testTLSErrorsRedirect):
2300         (httpsServerCallback):
2301         (beforeAll):
2302
2303 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
2304
2305         [CSS Grid Layout] Remove runtime feature
2306         https://bugs.webkit.org/show_bug.cgi?id=132382
2307
2308         Reviewed by Benjamin Poulain.
2309
2310         Remove cssGridLayoutEnabled setting usage.
2311
2312         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2313         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2314         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2315         (TestRunner::overridePreference):
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (resetWebPreferencesToConsistentValues):
2318
2319 2014-05-06  David Kilzer  <ddkilzer@apple.com>
2320
2321         Add Makefile targets for copying static libraries (LLVM and WKSI)
2322         <http://webkit.org/b/132619>
2323
2324         Reviewed by Mark Rowe.
2325
2326         * Scripts/copy-webkitlibraries-to-product-directory: Set a
2327         sensible default for product directory if not specified on
2328         either the command-line or in the environment (by Xcode) by
2329         calling productDir() in webkitdirs.pm.
2330
2331 2014-05-06  Brady Eidson  <beidson@apple.com>
2332
2333         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
2334         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
2335
2336         Reviewed by Sam Weinig.
2337
2338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2339
2340         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
2341         (TestWebKitAPI::itemURLLastComponentIsString):
2342         (TestWebKitAPI::didFinishLoadForFrame):
2343         (TestWebKitAPI::willGoToBackForwardListItem):
2344         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2345         (TestWebKitAPI::setPageLoaderClient):
2346         (TestWebKitAPI::TEST):
2347         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
2348         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
2349
2350         * WebKitTestRunner/TestController.cpp:
2351         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
2352
2353 2014-05-06  Darin Adler  <darin@apple.com>
2354
2355         Try to fix iOS build.
2356
2357         * DumpRenderTree/mac/TestRunnerMac.mm:
2358         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
2359         Updated since I changed testRunner into a pointer instead of a reference.
2360         Updated argument names to avoid conflict with field names.
2361         (-[APITestDelegateIPhone run]): Ditto.
2362         (-[APITestDelegateIPhone _cleanUp]): Ditto.
2363
2364 2014-05-06  Commit Queue  <commit-queue@webkit.org>
2365
2366         Unreviewed, rolling out r168304.
2367         https://bugs.webkit.org/show_bug.cgi?id=132607
2368
2369         Broke the build (Requested by KaL on #webkit).
2370
2371         Reverted changeset:
2372
2373         "[GTK][CMake] Unable to do make install"
2374         https://bugs.webkit.org/show_bug.cgi?id=130188
2375         http://trac.webkit.org/changeset/168304
2376
2377 2014-05-04  Darin Adler  <darin@apple.com>
2378
2379         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
2380         https://bugs.webkit.org/show_bug.cgi?id=80222
2381
2382         Reviewed by Alexey Proskuryakov.
2383
2384         * DumpRenderTree/mac/TestRunnerMac.mm:
2385         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
2386         do more work here so we don't use RetainPtr local variables.
2387         (-[APITestDelegateIPhone dealloc]): Added.
2388         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
2389         created. Updated for changes to member names and types.
2390         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
2391         updated for changes to member names and types. Changed to two word spelling.
2392         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
2393         name of _cleanUp method.
2394         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
2395         Ditto.
2396         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
2397
2398 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
2399
2400         Clean up Image Document and tweak the layout and viewport
2401         https://bugs.webkit.org/show_bug.cgi?id=132552
2402
2403         Reviewed by Anders Carlsson.
2404
2405         * DumpRenderTree/mac/DumpRenderTree.mm:
2406         (resetWebPreferencesToConsistentValues):
2407         Update the default settings to have something consistent with WebKit2.
2408
2409 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
2410
2411         [GTK][CMake] Unable to do make install
2412         https://bugs.webkit.org/show_bug.cgi?id=130188
2413
2414         Reviewed by Carlos Garcia Campos.
2415
2416         * Scripts/webkitdirs.pm:
2417         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
2418         will give an early signal that a change has broken the documentation.
2419
2420 2014-05-05  Pratik Solanki  <psolanki@apple.com>
2421
2422         Update framework locations in package-root
2423         https://bugs.webkit.org/show_bug.cgi?id=132571
2424
2425         Reviewed by Simon Fraser.
2426
2427         * Scripts/package-root:
2428
2429 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
2430
2431         [EFL][WK2] Refactor favicon database APIs
2432         https://bugs.webkit.org/show_bug.cgi?id=132519
2433
2434         Reviewed by Gyuyoung Kim.
2435
2436         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
2437         (update_view_favicon):
2438         (on_icon_changed_cb):
2439         (window_free):
2440         (on_url_changed):
2441         (window_create):
2442         (on_view_favicon_changed): Deleted.
2443
2444 2014-05-02  Mark Rowe  <mrowe@apple.com>
2445
2446         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
2447
2448         Reviewed by Dan Bernstein.
2449
2450         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
2451         when determining which LLVM archive to extract.
2452
2453 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2454
2455         Add Jeremy as a committer.
2456         https://bugs.webkit.org/show_bug.cgi?id=132492
2457
2458         Reviewed by Jer Noble.
2459
2460         Add myself as a committer.
2461
2462         * Scripts/webkitpy/common/config/contributors.json:
2463
2464 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2465
2466         Add Jeremy as a committer.
2467         https://bugs.webkit.org/show_bug.cgi?id=132492
2468
2469         Reviewed by Jer Noble.
2470
2471         Add Jeremy Jones to the committers file.
2472
2473         * Scripts/webkitpy/common/config/contributors.json:
2474
2475 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
2476
2477         Hard to figure out how to run a single test with run-api-tests
2478         https://bugs.webkit.org/show_bug.cgi?id=116332
2479
2480         Reviewed by Alexey Proskuryakov.
2481
2482         * Scripts/run-api-tests: add two examples to the help message.
2483
2484 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
2485
2486         Fix several memory leaks found by code inspection
2487         https://bugs.webkit.org/show_bug.cgi?id=132472
2488
2489         Reviewed by Geoffrey Garen.
2490         
2491         Fix memory leaks.
2492
2493         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2494         (TestWebKitAPI::TEST):
2495         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2496         (WTR::InjectedBundlePage::willSendRequestForFrame):
2497         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2498         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2499
2500 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
2501
2502         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2503         https://bugs.webkit.org/show_bug.cgi?id=132446
2504
2505         Reviewed by Mark Hahnenberg.
2506         
2507         Test the FTL by default now that it's enabled by default.
2508
2509         * Scripts/run-javascriptcore-tests:
2510
2511 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
2512
2513         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2514         https://bugs.webkit.org/show_bug.cgi?id=132240
2515
2516         Reviewed by Anders Carlsson.
2517
2518         Removed ewk_view_setting_tiled_backingstore related code.
2519
2520         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2521         (DumpRenderTreeChrome::createView):
2522         (shouldUseTiledBackingStore): Deleted.
2523         * EWebLauncher/main.c:
2524         (windowCreate):
2525         (parseUserArguments):
2526
2527 2014-05-01  Anders Carlsson  <andersca@apple.com>
2528
2529         window.testRunner.keepWebHistory() should update the UI process state
2530         https://bugs.webkit.org/show_bug.cgi?id=132440
2531
2532         Reviewed by Dan Bernstein.
2533
2534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2535         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2536         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2537         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2538         (WTR::TestRunner::keepWebHistory):
2539         * WebKitTestRunner/TestInvocation.cpp:
2540         (WTR::TestInvocation::invoke):
2541         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2542
2543 2014-05-01  David Kilzer  <ddkilzer@apple.com>
2544
2545         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2546         <http://webkit.org/b/132432>
2547
2548         Reviewed by Tim Horton.
2549
2550         * Scripts/webkitperl/FeatureList.pm: Remove support for
2551         --plugin-proxy-for-video switch.
2552
2553 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2554
2555         Kernel sysctl interface hw.activecpu don't exists on Linux.
2556         https://bugs.webkit.org/show_bug.cgi?id=132286
2557
2558         Reviewed by Filip Pizlo.
2559
2560         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2561         calling sysctl over hw.activecpu
2562
2563 2014-04-30  Anders Carlsson  <andersca@apple.com>
2564
2565         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2566         https://bugs.webkit.org/show_bug.cgi?id=132399
2567         <rdar://problem/15920046>
2568
2569         Reviewed by Dan Bernstein.
2570
2571         * Scripts/check-for-webkit-framework-include-consistency:
2572         Allos WAK headers in WebKitLegacy as well as WebKit.
2573
2574         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2575         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2576         Update header imports.
2577
2578 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2579
2580         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2581         https://bugs.webkit.org/show_bug.cgi?id=131954
2582
2583         Reviewed by Darin Adler.
2584         
2585         WebKitTestRunner was adding application-specific information to crash reports
2586         to log the test path, but only in the web process. Fix it to also do this
2587         for the UI process, for both iOS and OS X.
2588         
2589         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2590         both iOS and OS X.
2591         
2592         Factored crash reprorter-related code into CrashReporterInfo, and call it from
2593         a new TestController::platformWillRunTest() function on Mac and iOS.
2594         
2595         Also remove Xcode-added unit test junk from the project.
2596
2597         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2598         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2599         * WebKitTestRunner/TestController.cpp:
2600         (WTR::TestController::runTest):
2601         * WebKitTestRunner/TestController.h:
2602         * WebKitTestRunner/TestInvocation.cpp:
2603         (WTR::TestInvocation::url):
2604         * WebKitTestRunner/TestInvocation.h:
2605         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2606         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2607         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2608         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2609         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2610         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2611         (WTR::testPathFromURL):
2612         (WTR::setCrashReportApplicationSpecificInformationToURL):
2613         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2614         (WTR::TestController::platformWillRunTest):
2615         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2616         (WTR::TestController::platformWillRunTest):
2617         * WebKitTestRunner/ios/TestControllerIOS.mm:
2618         (WTR::TestController::platformWillRunTest):
2619         (WTR::TestController::setHidden):
2620         * WebKitTestRunner/mac/TestControllerMac.mm:
2621         (WTR::TestController::platformWillRunTest):
2622
2623 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2624
2625         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2626
2627         Reviewed by Tim Horton.
2628
2629         * DumpRenderTree/mac/DumpRenderTree.mm:
2630         (resetWebPreferencesToConsistentValues):
2631         (prepareConsistentTestingEnvironment):
2632
2633 2014-04-30  Anders Carlsson  <andersca@apple.com>
2634
2635         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2636         https://bugs.webkit.org/show_bug.cgi?id=132397
2637
2638         Reviewed by Dan Bernstein.
2639
2640         * Scripts/check-for-inappropriate-macros-in-external-headers:
2641
2642 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2643
2644         [GTK] Make it easier to run CMake for downstreams
2645         https://bugs.webkit.org/show_bug.cgi?id=132370
2646
2647         Reviewed by Carlos Garcia Campos.
2648
2649         * Scripts/webkitdirs.pm:
2650         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2651         the GTK+ port.
2652
2653 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2654
2655         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2656         
2657         Rubber stamped by Jessie Berlin.
2658
2659         JSON.pm was removed from our tools setup.
2660
2661         * Scripts/generate-coverage-data:
2662
2663 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2664
2665         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2666         https://bugs.webkit.org/show_bug.cgi?id=112840
2667
2668         Rubber stamped by Geoffrey Garen.
2669
2670         * Scripts/build-jsc: Enable it on Mac.
2671         * Scripts/build-webkit: Enable it on Mac.
2672         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2673
2674 2014-04-28  Sam Weinig  <sam@webkit.org>
2675
2676         REGRESSION (r167751): svn-create-patch is very slow
2677         https://bugs.webkit.org/show_bug.cgi?id=132300
2678
2679         Reviewed by Alexey Proskuryakov.
2680
2681         * Scripts/svn-create-patch:
2682         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2683         by calling `svn-create-patch --style`.
2684
2685 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2686
2687         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2688         https://bugs.webkit.org/show_bug.cgi?id=132190
2689
2690         Reviewed by Gustavo Noronha Silva.
2691
2692         * Scripts/webkitdirs.pm:
2693         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2694             if ninja is in the path.
2695         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2696             to the previous ninja generator if not.
2697
2698 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2699
2700         check-webkit-style should understand --git-index
2701         https://bugs.webkit.org/show_bug.cgi?id=125364
2702
2703         Reviewed by Csaba Osztrogonác.
2704
2705         * Scripts/webkitpy/common/checkout/scm/git.py:
2706         (Git.create_patch): The command now supports the --cached option.
2707         * Scripts/webkitpy/style/main.py:
2708         (CheckWebKitStyle.main): Passing the --git-index option.
2709         * Scripts/webkitpy/style/optparser.py:
2710         (CommandOptionValues.__init__): The git-index option is switched off by default.
2711         (CommandOptionValues.__eq__): Equality check for the new option.
2712         (ArgumentParser._create_option_parser):Adding the --git-index option
2713         (ArgumentParser.parse):
2714         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2715         (CommandOptionValuesTest.test_init): 
2716         (CommandOptionValuesTest.test_eq):
2717
2718 2014-04-28  Michael Saboff  <msaboff@apple.com>
2719
2720         Crash in platform/mac/accessibility/table-visible-rows.html
2721         https://bugs.webkit.org/show_bug.cgi?id=132146
2722
2723         Reviewed by Filip Pizlo.
2724
2725         Instead of creating a local JSValueRef array on the stack and passing that to
2726         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2727         values using the JSObjectSetPropertyAtIndex() API.
2728
2729         * DumpRenderTree/AccessibilityUIElement.cpp:
2730         (elementsForRangeCallback):
2731         (convertElementsToObjectArray):
2732         * DumpRenderTree/mac/TestRunnerMac.mm:
2733         (originsArrayToJS):
2734         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2735         (WTR::EventSendingController::contextClick):
2736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2737         (WTR::stringArrayToJS):
2738         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2739         (WTR::convertElementsToObjectArray):
2740
2741 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2742
2743         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2744         "no-cjit" runs force the old-school threshold.
2745
2746         Rubber stamped by Mark Hahnenberg.
2747
2748         * Scripts/run-jsc-stress-tests:
2749
2750 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2751
2752         [GTK] install-dependencies should also install ruby-json and ruby-highline
2753         https://bugs.webkit.org/show_bug.cgi?id=132292
2754
2755         Reviewed by Philippe Normand.
2756
2757         * gtk/install-dependencies: Install ruby json and highline packages.
2758
2759 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2760
2761         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2762         https://bugs.webkit.org/show_bug.cgi?id=132176
2763
2764         Reviewed by Gyuyoung Kim.
2765
2766         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2767         and turn off indexedDB feature until the sqlite implementation is introduced.
2768
2769         * Scripts/webkitperl/FeatureList.pm:
2770
2771 2014-04-25  James Craig  <jcraig@apple.com>
2772
2773         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2774         https://bugs.webkit.org/show_bug.cgi?id=132209
2775
2776         Reviewed by Daniel Bates.
2777
2778         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2779         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2780
2781         * Scripts/prepare-ChangeLog:
2782         (main): 
2783
2784 2014-04-25  Michael Saboff  <msaboff@apple.com>
2785
2786         Crash in platform/mac/accessibility/table-visible-rows.html
2787         https://bugs.webkit.org/show_bug.cgi?id=132146
2788
2789         Reviewed by Mark Lam.
2790
2791         Changed to use a local JSValueRef array temporary instead of a
2792         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2793         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2794         the temporary values could be collected.
2795
2796         * DumpRenderTree/AccessibilityUIElement.cpp:
2797         (convertElementsToObjectArray):
2798         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2799         (WTR::EventSendingController::contextClick):
2800         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2801         (WTR::convertElementsToObjectArray):
2802
2803 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2804
2805         Unreviewed GTK gardening
2806
2807         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2808         (TestRunner):
2809
2810 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2811
2812         prepare-ChangeLog reports as deleted methods that has not been removed.
2813         https://bugs.webkit.org/show_bug.cgi?id=131733
2814
2815         Reviewed by Ryosuke Niwa.
2816
2817         * Scripts/prepare-ChangeLog:
2818         (originalFile): Set merge base to origin/master by default.
2819
2820 2014-04-23  James Craig  <jcraig@apple.com>
2821
2822         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2823         https://bugs.webkit.org/show_bug.cgi?id=131115
2824
2825         Reviewed by Daniel Bates.
2826
2827         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2828
2829         * Scripts/commit-log-editor: Added --no-style.
2830         * Scripts/prepare-ChangeLog: Primary patch.
2831         (main): Primary patch.
2832         (createPatchCommand): Added --no-style.
2833         * Scripts/svn-create-patch: Primary patch.
2834         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2835         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2836         (SVN.create_patch): Added --no-style.
2837
2838 2014-04-23  Anders Carlsson  <andersca@apple.com>
2839
2840         Try to fix iOS build.
2841
2842         * DumpRenderTree/mac/DumpRenderTree.mm:
2843
2844 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2845
2846         Eliminate internals.setMockScrollbarsEnabled()
2847         https://bugs.webkit.org/show_bug.cgi?id=132085
2848
2849         Reviewed by Tim Horton.
2850
2851         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2852         No need to reset the preference, there is no way it can change.
2853
2854 2014-04-23  James Craig  <jcraig@apple.com>
2855
2856         Unreviewed. Moving myself from Contributors to Committers list.
2857
2858         * Scripts/webkitpy/common/config/contributors.json:
2859
2860 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2861
2862         Mock scrollbars don't always work in DumpRenderTree
2863         https://bugs.webkit.org/show_bug.cgi?id=132082
2864
2865         Reviewed by Alexey Proskuryakov.
2866
2867         * DumpRenderTree/mac/DumpRenderTree.mm:
2868         (prepareConsistentTestingEnvironment):
2869         Set the mock scrollbar setting before creating the WebView, as this setting
2870         cannot be dynamically changed, so any scrollbars that are created during
2871         WebView initialization and are not replaced before snapshotting will end
2872         up being platform scrollbars instead of mock ones.
2873         WebKitTestRunner already sets this preference before creating WKViews,
2874         so we're just matching its behavior.
2875
2876 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2877
2878         [GTK] ShadowRoot API was removed in r164131
2879         https://bugs.webkit.org/show_bug.cgi?id=132059
2880
2881         Reviewed by Gustavo Noronha Silva.
2882
2883         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2884         the API docs.
2885
2886         * gtk/webkitdom.py:
2887         (WebKitDOMDocGenerator):
2888
2889 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2890
2891         [GTK] run-webkit-tests script is failing to invoke run-launcher
2892         https://bugs.webkit.org/show_bug.cgi?id=132051
2893
2894         Reviewed by Philippe Normand.
2895
2896         After the WK1 support was dropped, if run-webkit-tests is executed
2897         without --no-show-results parameter, the launcher is being called
2898         using a -2 parameter that is it causing the run-launcher to break.
2899
2900         * Scripts/webkitpy/port/gtk.py:
2901         (GtkPort.show_results_html_file):
2902
2903 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2904
2905         DumpRenderTree generates black snapshots on some platforms
2906         https://bugs.webkit.org/show_bug.cgi?id=132029
2907         <rdar://problem/16679363>
2908
2909         Reviewed by Simon Fraser.
2910
2911         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2912         (createBitmapContextFromWebView):
2913         DRT checks with the WebView to determine whether it can use the window's
2914         backing store directly or (because of compositing) needs to take a WindowServer
2915         snapshot. However, on some platforms and in some situations, the window can
2916         be layer backed without the WebView necessarily currently being composited.
2917         We should check with the window in addition to the WebView before going
2918         ahead and using its backing store.
2919
2920 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2921
2922         DumpRenderTree generates white snapshots on some platforms
2923         https://bugs.webkit.org/show_bug.cgi?id=132026
2924         <rdar://problem/16679363>
2925
2926         Reviewed by Simon Fraser.
2927
2928         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2929         Link DRT against QuartzCore.
2930
2931         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2932         (createBitmapContextFromWebView):
2933         Force CoreAnimation to synchronously update layers in a more explicit
2934         way that doesn't depend on AppKit behavior. This is very similar to what
2935         WebKitTestRunner does (indirectly) during its force repaint.
2936
2937 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2938
2939         [Win] Support Python 2.7 in Cygwin
2940         https://bugs.webkit.org/show_bug.cgi?id=132023
2941
2942         Reviewed by Michael Saboff.
2943
2944         * Scripts/webkitdirs.pm:
2945         (checkInstalledTools): Remove check for Python 2.7, since
2946         it now works properly.
2947
2948 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2949
2950         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2951         https://bugs.webkit.org/show_bug.cgi?id=130867
2952         <rdar://problem/16432456> 
2953
2954         Reviewed by Mark Hahnenberg.
2955
2956         * Scripts/build-webkit:
2957         * Scripts/copy-webkitlibraries-to-product-directory:
2958
2959 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2960
2961         [GTK] Fails to build documentation when output is redirected
2962         https://bugs.webkit.org/show_bug.cgi?id=131178
2963
2964         Reviewed by Martin Robinson.
2965
2966         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2967         explicitly to avoid encoding issues when they are redirected.
2968
2969 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2970
2971         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2972         https://bugs.webkit.org/show_bug.cgi?id=131911
2973
2974         Reviewed by Martin Robinson.
2975
2976         common.get_build_path returns release path even though Debug configuration
2977         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2978
2979         * gtk/ycm_extra_conf.py:
2980         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2981         (FlagsForFile):
2982
2983 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2984
2985         Unreviewed build fix.
2986
2987         * DumpRenderTree/mac/EventSendingController.mm:
2988         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2989         Correct a typo that prevented tests from working properly.
2990
2991 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2992
2993         [GTK] Should have the ability to output composited contents during layout testing
2994         https://bugs.webkit.org/show_bug.cgi?id=131864
2995
2996         Reviewed by Philippe Normand.
2997
2998         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2999         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
3000         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
3001         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3002         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
3003
3004 2014-04-21  Sam Weinig  <sam@webkit.org>
3005
3006         Attempt to fix the tests.
3007
3008         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3009         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3010         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
3011
3012 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
3013
3014         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
3015         being the same as a "quick run", which is meant for genuinely slow tests).
3016
3017         * Scripts/run-jsc-stress-tests:
3018
3019 2014-04-21  Darin Adler  <darin@apple.com>
3020
3021         Add HashSet::takeAny
3022         https://bugs.webkit.org/show_bug.cgi?id=131928
3023
3024         Reviewed by Benjamin Poulain.
3025
3026         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
3027
3028 2014-04-20  Dan Bernstein  <mitz@apple.com>
3029
3030         Fixed a test timing out after r167572.
3031
3032         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3033         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
3034         -webView:didFinishLoadingNavigation:.
3035
3036 2014-04-20  Commit Queue  <commit-queue@webkit.org>
3037
3038         Unreviewed, rolling out r167510.
3039         https://bugs.webkit.org/show_bug.cgi?id=131915
3040
3041         broke GTK Debug bot (Requested by philn on #webkit).
3042
3043         Reverted changeset:
3044
3045         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
3046         it when running layout tests"
3047         https://bugs.webkit.org/show_bug.cgi?id=131472
3048         http://trac.webkit.org/changeset/167510
3049
3050 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
3051
3052         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
3053         https://bugs.webkit.org/show_bug.cgi?id=131472
3054
3055         Reviewed by Philippe Normand.
3056
3057         * Scripts/webkitpy/port/gtk.py:
3058         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
3059         when running WebKitTestRunner with run-webkit-tests.
3060         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
3061         installed.
3062         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
3063         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
3064         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
3065         deal.
3066
3067 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
3068
3069         DownloadDecideDestinationCrash API test uses an incorrect value for path
3070         https://bugs.webkit.org/show_bug.cgi?id=131845
3071         <rdar://problem/15925560>
3072
3073         Reviewed by Enrica Casucci.
3074
3075         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3076         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
3077
3078 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
3079
3080         [Mac] AttributedStringTest API tests fail with async text input
3081         https://bugs.webkit.org/show_bug.cgi?id=131833
3082
3083         Reviewed by Enrica Casucci.
3084
3085         Don't run sync NSTextInputClient tests where we don't implement these calls.
3086
3087         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3088         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
3089         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
3090         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
3091         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
3092         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
3093         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
3094
3095 2014-04-18  Philippe Normand  <pnormand@igalia.com>
3096
3097         Remove NETWORK_INFO support
3098         https://bugs.webkit.org/show_bug.cgi?id=131841
3099
3100         Reviewed by Gyuyoung Kim.
3101
3102         * Scripts/webkitperl/FeatureList.pm:
3103
3104 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
3105
3106         [GTK] YouCompleteMe doesn't work for cmake build system.
3107         https://bugs.webkit.org/show_bug.cgi?id=131591
3108
3109         Reviewed by Martin Robinson.
3110
3111         Add cmake build system support for YouCompleteMe. It should work regardless of
3112         using make or ninja. In addition, autotools related code is removed since it's
3113         not used anymore in WebKit.
3114
3115         * Scripts/webkitdirs.pm:
3116         (generateBuildSystemFromCMakeProject):
3117         * gtk/ycm_extra_conf.py:
3118         (transform_relative_paths_to_absolute_paths):
3119         (FlagsForFile):
3120
3121 2014-04-17  Anders Carlsson  <andersca@apple.com>
3122
3123         Fix build.
3124
3125         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3126         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3127         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3128
3129 2014-04-17  Anders Carlsson  <andersca@apple.com>
3130
3131         Remove unused API enums
3132         https://bugs.webkit.org/show_bug.cgi?id=131836
3133
3134         Reviewed by Tim Horton.
3135
3136         * MiniBrowser/mac/WK2BrowserWindowController.m:
3137         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3138
3139 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
3140
3141         [Win] A few final cleanups to the DataObject classes.
3142         https://bugs.webkit.org/show_bug.cgi?id=131784
3143
3144         Reviewed by Anders Carlsson.
3145
3146         * DumpRenderTree/win/DRTDataObject.cpp:
3147         (DRTDataObject::clearData): Use 'last()' method.
3148         * DumpRenderTree/win/UIDelegate.cpp:
3149         (DRTUndoStack::pop): Use 'takeLast()' method.
3150
3151 2014-04-17  Andres Gomez  <agomez@igalia.com>
3152
3153         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
3154         https://bugs.webkit.org/show_bug.cgi?id=131365
3155
3156         Reviewed by Brent Fulgham.
3157
3158         The cygwin installer is now downloading the wanted versions for
3159         the local installation given to the setup wizard.
3160
3161         * CygwinDownloader/cygwin-downloader.py:
3162         * CygwinDownloader/cygwin-downloader.zip:
3163
3164 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
3165
3166         [GTK] Make run-webkit-tests always use WKTR
3167         https://bugs.webkit.org/show_bug.cgi?id=131737
3168
3169         Reviewed by Darin Adler.
3170
3171         Now that the GTK+ port only has support for WebKit2, instruct
3172         run-webkit-tests to always use WKTR. This avoids needing to pass
3173         flag "-2" every time.
3174
3175         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
3176         (_set_up_derived_options): Always set webkit_test_runner when
3177         the platform is GTK+.
3178
3179 2014-04-17  Brendan Long  <b.long@cablelabs.com>
3180
3181         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
3182         https://bugs.webkit.org/show_bug.cgi?id=131760
3183
3184         Reviewed by Philippe Normand.
3185
3186         * gtk/install-dependencies: Install ninja-build when it's available.
3187
3188 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
3189
3190         [Win] run-javascriptcore-tests fails to run.
3191         https://bugs.webkit.org/show_bug.cgi?id=131761
3192
3193         Reviewed by Brent Fulgham.
3194
3195         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
3196
3197 2014-04-16  Andres Gomez  <agomez@igalia.com>
3198
3199         [Win] Pass default parameters to cygwin setup wizard
3200         https://bugs.webkit.org/show_bug.cgi?id=131361
3201
3202         Reviewed by Brent Fulgham.
3203
3204         Added some parameters to the cygwin setup wizard so the user
3205         doesn't really have to do any interaction.
3206
3207         * CygwinDownloader/cygwin-downloader.py:
3208         * CygwinDownloader/cygwin-downloader.zip:
3209
3210 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
3211
3212         [Win] Eliminate use of deleteAllValues in Windows Files
3213         https://bugs.webkit.org/show_bug.cgi?id=131631
3214
3215         Reviewed by Darin Adler.
3216
3217         Switch to std::unique_ptr for memory lifetime. Get rid of
3218         deleteAllValues now that it is no longer needed. Use ranged
3219         for loops where possible.
3220
3221         * DumpRenderTree/win/DRTDataObject.cpp:
3222         (WCEnumFormatEtc::WCEnumFormatEtc):
3223         (DRTDataObject::~DRTDataObject):
3224         (DRTDataObject::GetData):
3225         (DRTDataObject::QueryGetData):
3226         (DRTDataObject::SetData):
3227         (DRTDataObject::clearData):
3228         * DumpRenderTree/win/DRTDataObject.h:
3229         * DumpRenderTree/win/UIDelegate.cpp:
3230         (DRTUndoObject::DRTUndoObject):
3231         (DRTUndoObject::~DRTUndoObject):
3232         (DRTUndoStack::~DRTUndoStack):
3233         (DRTUndoStack::clear):
3234         (DRTUndoStack::pop):
3235         (DRTUndoManager::DRTUndoManager):
3236         (DRTUndoManager::redo):
3237         (DRTUndoManager::undo):
3238         (UIDelegate::UIDelegate):
3239         (UIDelegate::resetUndoManager):
3240         * DumpRenderTree/win/UIDelegate.h:
3241
3242 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3243
3244         [GTK] Unreviewed GTK gardening.
3245
3246         Update list of skipped unit tests:
3247
3248           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
3249
3250           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
3251           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
3252
3253         * Scripts/run-gtk-tests:
3254         (TestRunner):
3255
3256 2014-04-16  Tim Horton  <timothy_horton@apple.com>
3257
3258         check-webkit-style doesn't check code style in .mm or .m files
3259         https://bugs.webkit.org/show_bug.cgi?id=131708
3260
3261         Reviewed by Darin Adler.
3262
3263         * Scripts/webkitpy/style/checker.py:
3264         * Scripts/webkitpy/style/checker_unittest.py:
3265         (CheckerDispatcherDispatchTest.test_cpp_paths):
3266         (CheckerDispatcherDispatchTest.test_text_paths):
3267         Check .mm and .m files as C++.
3268
3269         * Scripts/webkitpy/style/checkers/cpp.py:
3270         (check_spacing):
3271         Add an override for our ordinary "missing spaces around =" for @synthesize,
3272         which should look like "@synthesize propertyName=_varName;"
3273
3274         Add an override for "missing space before {" for blocks' "^{".
3275
3276         Don't follow the "extra space before [" rule for Objective-C, because
3277         it breaks this rule in a multitude of ways because of method calls.
3278
3279         (check_braces):
3280         Don't complain about { not being on the end of the previous line if
3281         the previous line starts with "- (" or "+ (", which would indicate a
3282         Objective-C method definition.
3283
3284 2014-04-16  Darin Adler  <darin@apple.com>
3285
3286         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
3287         https://bugs.webkit.org/show_bug.cgi?id=131735
3288
3289         Reviewed by Alexey Proskuryakov.
3290
3291         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
3292         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
3293         is on the right. This can be confusing since our JavaScript test framework does it the opposite
3294         way, but gtest works better this way.
3295
3296 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
3297
3298         [EFL] Fix problems with the pixel dump.
3299         https://bugs.webkit.org/show_bug.cgi?id=131265
3300
3301         Reviewed by Gyuyoung Kim.
3302
3303         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
3304         However pixel dump codes still call deprecated functions like ewk_view_paint(),
3305         which causes that nothing is drawn.
3306
3307         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
3308         One of new functions is AcceleratedCompositingContext::extractImageData(),
3309         which replaces deprecated function calls. Besides the extractImageData() is invoked by
3310         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
3311
3312         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3313         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
3314
3315 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
3316
3317         Update LLVM export scrpt to handle the build directory being different from the
3318         source directory.
3319
3320         Rubber stamped by Geoffrey Garen.
3321
3322         * Scripts/export-llvm-build:
3323
3324 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
3325
3326         Update the hyperlink to waterfall views of perf bots on build.webkit.org
3327         https://bugs.webkit.org/show_bug.cgi?id=131695
3328
3329         Reviewed by Antti Koivisto.
3330
3331         Updated.
3332
3333         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3334
3335 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3336
3337         [GTK] Reduce the binary size by compressing the text based web inspector resources
3338         https://bugs.webkit.org/show_bug.cgi?id=121545
3339
3340         Reviewed by Gustavo Noronha Silva.
3341
3342         Compress text based files when compiling inspector resources. It
3343         reduces the binary size in 3MB.
3344
3345         * gtk/generate-inspector-gresource-manifest.py:
3346         (find_all_files_in_directory):
3347         (is_compressible):
3348
3349 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3350
3351         Remove Gtk WebKit1 tester.
3352
3353         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
3354         results over and over as fast as it could.
3355
3356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3357         (WebKitBuildbot):
3358
3359 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3360
3361         Wrong link for webkitpy tests results in dashboard popover
3362         https://bugs.webkit.org/show_bug.cgi?id=131664
3363
3364         Reviewed by Timothy Hatcher.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3367         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3368         Use a correct link.
3369
3370 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3371
3372         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
3373
3374         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
3375
3376         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3377         (CommitMessageForThisCommitTest):
3378
3379 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3380
3381         Fix commit-log-editor bug revealed by r165447
3382         https://bugs.webkit.org/show_bug.cgi?id=130676
3383
3384         Reviewed by Csaba Osztrogonác.
3385
3386         * Scripts/commit-log-editor:
3387         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
3388         Add \n before the first block too, because the longest common prefix now ends with only one newline.
3389         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
3390         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
3391
3392 2014-04-13  Darin Adler  <darin@apple.com>
3393
3394         userVisibleString should not try to "encode" host names
3395         https://bugs.webkit.org/show_bug.cgi?id=131587
3396         rdar://problem/14686849
3397
3398         Reviewed by Alexey Proskuryakov.
3399
3400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
3401
3402         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
3403         Coverage is tiny at this point; we could add a lot more cases!
3404
3405 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
3406
3407         Use #include instead of #import
3408         https://bugs.webkit.org/show_bug.cgi?id=131604
3409
3410         Reviewed by Darin Adler.
3411
3412         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
3413
3414         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3415
3416 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
3417
3418         Make slow-stress tests run faster by running fewer VM variants.
3419
3420         Rubber stamped by Geoffrey Garen.
3421
3422         * Scripts/run-javascriptcore-tests:
3423         * Scripts/run-jsc-stress-tests:
3424
3425 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
3426
3427         [CMake] Add missing WTF unit tests
3428         https://bugs.webkit.org/show_bug.cgi?id=131459
3429
3430         Reviewed by Martin Robinson.
3431
3432         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
3433         that should be compiled into the TestWTF binary.
3434
3435 2014-04-10  Brendan Long  <b.long@cablelabs.com>
3436
3437         [Gtk] run-launcher doesn't work by default
3438         https://bugs.webkit.org/show_bug.cgi?id=131494
3439
3440         Reviewed by Philippe Normand.
3441
3442         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
3443         * Scripts/webkitdirs.pm:
3444         (launcherName): Same.
3445         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
3446         * gtk/common.py:
3447         (get_build_path.is_valid_build_directory): Same.
3448         * gtk/manifest.txt: Same.
3449
3450 2014-04-09  Commit Queue  <commit-queue@webkit.org>
3451
3452         Unreviewed, rolling out r167046.
3453         https://bugs.webkit.org/show_bug.cgi?id=131479
3454
3455         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
3456         on #webkit).
3457
3458         Reverted changeset:
3459
3460         "Remove "System Font" from whitelisted DRT fonts and char
3461         width calculations"
3462         https://bugs.webkit.org/show_bug.cgi?id=131411
3463         http://trac.webkit.org/changeset/167046
3464
3465 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3466
3467         Remove "System Font" from whitelisted DRT fonts and char width calculations
3468         https://bugs.webkit.org/show_bug.cgi?id=131411
3469
3470         Reviewed by Tim Horton.
3471
3472         Covered by existing tests.
3473
3474         * DumpRenderTree/mac/DumpRenderTree.mm:
3475         (allowedFontFamilySet):
3476
3477 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3478
3479         systemHiddenFontFamilySet in DRT is unnecessary
3480         https://bugs.webkit.org/show_bug.cgi?id=131414
3481
3482         Reviewed by Tim Horton.
3483
3484         It doesn't seem to affect test results on my machine.
3485
3486         * DumpRenderTree/mac/DumpRenderTree.mm:
3487         (drt_NSFontManager_availableFonts):
3488         (systemHiddenFontFamilySet): Deleted.
3489
3490 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3491
3492         [Win] Unreviewed test fix: Don't double-release BSTR.
3493
3494         * DumpRenderTree/win/DumpRenderTree.cpp:
3495         (dump): Remove unneeded call to SysFreeString now that we are
3496         using _bstr_t for this variable.
3497
3498 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3499
3500         [Win] Various DumpRenderTree Fixes.
3501         https://bugs.webkit.org/show_bug.cgi?id=131446.
3502
3503         Reviewed by Tim Horton.
3504
3505         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3506         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3507         (AccessibilityUIElement::description): Ditto.
3508         (AccessibilityUIElement::helpText): Ditto.
3509         (AccessibilityUIElement::intValue): Ditto.
3510         (AccessibilityUIElement::isPressActionSupported): Ditto.
3511         (AccessibilityUIElement::accessibilityValue): Ditto.
3512         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3513         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3514         (DRTDesktopNotificationPresenter::AddRef): Ditto.
3515         (DRTDesktopNotificationPresenter::Release): Ditto.
3516         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3517         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3518         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3519         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3520         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3521         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3522         * DumpRenderTree/win/DumpRenderTree.cpp:
3523         (dumpFrameScrollPosition): Ditto.
3524         (dumpFramesAsText): Ditto.
3525         (compareHistoryItems): Ditto.
3526         (dumpHistoryItem): Ditto.
3527         (dump): Ditto.
3528         (resetDefaultsToConsistentValues): Ditto.
3529         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3530         (runTest): Ditto.
3531         (createWebViewAndOffscreenWindow): Ditto.
3532         * DumpRenderTree/win/EditingDelegate.cpp:
3533         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3534         (EditingDelegate::AddRef): Ditto.
3535         (EditingDelegate::Release): Ditto.
3536         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3537         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3538         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3539         (EditingDelegate::shouldInsertNode): Ditto.
3540         (EditingDelegate::shouldInsertText): Ditto.
3541         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3542         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3543         (EditingDelegate::shouldApplyStyle): Ditto.
3544         (EditingDelegate::shouldChangeTypingStyle): Ditto.
3545         (EditingDelegate::doPlatformCommand): Ditto.
3546         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3547         (EditingDelegate::webViewDidChange): Ditto.
3548         (EditingDelegate::webViewDidEndEditing): Ditto.
3549         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3550         (EditingDelegate::webViewDidChangeSelection): Ditto.
3551         (EditingDelegate::checkSpellingOfString): Ditto.
3552         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3553         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3554         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3555         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3556         (FrameLoadDelegate::AddRef): Ditto.
3557         (FrameLoadDelegate::Release): Ditto.
3558         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3559         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3560         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3561         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3562         (FrameLoadDelegate::didReceiveTitle): Ditto.
3563         (FrameLoadDelegate::didChangeIcons): Ditto.
3564         (delegatesWithDelayedWork): Ditto.
3565         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3566         (FrameLoadDelegate::didFailLoadWithError): Ditto.
3567         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3568         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3569         (FrameLoadDelegate::willCloseFrame): Ditto.
3570         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3571         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3572         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3573         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3574         (FrameLoadDelegate::didRunInsecureContent): Ditto.
3575         * DumpRenderTree/win/FrameLoadDelegate.h:
3576         * DumpRenderTree/win/HistoryDelegate.cpp:
3577         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3578         (HistoryDelegate::updateHistoryTitle): Ditto.
3579         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3580         * DumpRenderTree/win/PolicyDelegate.cpp:
3581         (dumpPath):
3582         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3583         (PolicyDelegate::AddRef): Ditto.
3584         (PolicyDelegate::Release): Ditto.
3585         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3586         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3587         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3588         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3589         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3590         (ResourceLoadDelegate::AddRef): Ditto.
3591         (ResourceLoadDelegate::Release): Ditto.
3592         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3593         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3594         (ResourceLoadDelegate::willSendRequest): Ditto.
3595         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3596         (ResourceLoadDelegate::didReceiveResponse): Ditto.
3597         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3598         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3599         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3600         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3601         (TestRunner::setUserStyleSheetLocation): Ditto.
3602         (TestRunner::execCommand): Ditto.
3603         (TestRunner::overridePreference): Ditto.
3604         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3605         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3606         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3607         (TextInputController::insertText): Ditto.
3608         * DumpRenderTree/win/UIDelegate.cpp:
3609         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3610         (UIDelegate::AddRef): Ditto.
3611         (UIDelegate::Release): Ditto.
3612         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3613         (UIDelegate::trackCustomPopupMenu): Ditto.
3614         (UIDelegate::registerUndoWithTarget): Ditto.
3615         (UIDelegate::removeAllActionsWithTarget): Ditto.
3616         (UIDelegate::setActionTitle): Ditto.
3617         (UIDelegate::undo): Ditto.
3618         (UIDelegate::redo): Ditto.
3619         (UIDelegate::canUndo): Ditto.
3620         (UIDelegate::canRedo): Ditto.
3621         (UIDelegate::printFrame): Ditto.
3622         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3623         (UIDelegate::webViewHeaderHeight): Ditto.
3624         (UIDelegate::webViewFooterHeight): Ditto.
3625         (UIDelegate::drawHeaderInRect): Ditto.
3626         (UIDelegate::drawFooterInRect): Ditto.
3627         (UIDelegate::webViewPrintingMarginRect): Ditto.
3628         (UIDelegate::canRunModal): Ditto.
3629         (UIDelegate::createModalDialog): Ditto.
3630         (UIDelegate::runModal): Ditto.
3631         (UIDelegate::isMenuBarVisible): Ditto.
3632         (UIDelegate::setMenuBarVisible): Ditto.
3633         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3634         (UIDelegate::paintCustomScrollbar): Ditto.
3635         (UIDelegate::paintCustomScrollCorner): Ditto.
3636         (UIDelegate::setFrame): Ditto.
3637         (UIDelegate::webViewFrame): Ditto.
3638         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3639         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3640         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3641         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3642         (UIDelegate::webViewAddMessageToConsole): Ditto.
3643         (UIDelegate::doDragDrop): Ditto.
3644         (UIDelegate::webViewGetDlgCode): Ditto.
3645         (UIDelegate::createWebViewWithRequest): Ditto.
3646         (UIDelegate::webViewClose): Ditto.
3647         (UIDelegate::webViewFocus): Ditto.
3648         (UIDelegate::webViewUnfocus): Ditto.
3649         (UIDelegate::webViewPainted): Ditto.
3650         (UIDelegate::exceededDatabaseQuota): Ditto.
3651         (UIDelegate::embeddedViewWithArguments): Ditto.
3652         (UIDelegate::webViewClosing): Ditto.
3653         (UIDelegate::webViewSetCursor): Ditto.
3654         (UIDelegate::webViewDidInvalidate): Ditto.
3655         (UIDelegate::setStatusText): Ditto.
3656         (UIDelegate::desktopNotificationsDelegate): Ditto.
3657         (UIDelegate::drawBackground): Ditto.
3658         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3659         (UIDelegate::didPressMissingPluginButton): Ditto.
3660         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3661         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
3662         (LoadHTMLStringItem::invoke): Ditto.
3663         (ScriptItem::invoke): Ditto.
3664
3665 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3666
3667         Stylechecker: False positive on inline asm code.
3668         https://bugs.webkit.org/show_bug.cgi?id=130570
3669
3670         Reviewed by Csaba Osztrogonác.
3671
3672         Disable stylechecking in asm blocks.
3673
3674         * Scripts/webkitpy/style/checkers/cpp.py:
3675         (process_line):
3676         (_InlineASMState):
3677         (_InlineASMState.__init__):
3678         (_InlineASMState.process_line):
3679         (_InlineASMState.isInside):
3680         (_process_lines):
3681         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3682         (WebKitStyleTest.test_member_initialization_list):
3683
3684 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3685
3686         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3687         https://bugs.webkit.org/show_bug.cgi?id=131029
3688
3689         Reviewed by Philippe Normand.
3690
3691         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3692         tests and remove the getWebKit1TestResoucesDir() method.
3693
3694         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3695         (testDownloadLocalFile): Use Test::getResourcesDir().
3696         (testDownloadLocalFileError): Ditto.
3697         (serverCallback): Ditto.
3698         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3699         (serverCallback): Ditto.
3700         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3701         (httpServerCallback): Ditto.
3702         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3703         (serverCallback): Ditto.
3704         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3705         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3706         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3707         (Test::getWebKit1TestResoucesDir): Deleted.
3708
3709 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
3710
3711         [WK2] HTTP authentication regression tests fail
3712         https://bugs.webkit.org/show_bug.cgi?id=81627
3713         <rdar://problem/11079296>
3714
3715         Reviewed by Anders Carlsson.
3716
3717         * WebKitTestRunner/TestController.h:
3718         * WebKitTestRunner/TestController.cpp:
3719         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3720         to pageLoaderClient structure.
3721         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3722         for password based authentication (we do get server trust challenges on some tests,
3723         which WKTR can't handle).
3724         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3725         calls won't be made, at least on CFNetwork based platforms.
3726         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3727         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3728         make sense to associate auth requests with individual resources - there can be
3729         multiple resources loading at once from the same protection space, so WebKit1 API
3730         that had a resource identifier was inherently racy.
3731
3732 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3733
3734         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3735         https://bugs.webkit.org/show_bug.cgi?id=131427
3736
3737         Reviewed by Gyuyoung Kim.
3738
3739         Since r166973, font path was changed.
3740
3741         * DumpRenderTree/PlatformEfl.cmake:
3742         * WebKitTestRunner/PlatformEfl.cmake:
3743
3744 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3745
3746         Fix the build-jsc build
3747         https://bugs.webkit.org/show_bug.cgi?id=131410
3748
3749         Reviewed by Michael Saboff.
3750
3751         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3752         WTF depends on it.
3753
3754 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3755
3756         [GTK] Remove WebKit1 unit tests
3757         https://bugs.webkit.org/show_bug.cgi?id=131359
3758
3759         Reviewed by Anders Carlsson.
3760
3761         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3762         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3763         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3764
3765         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3766         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3767         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3768         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3769         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3770         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3771         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3772         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3773         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3774         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3775         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3776         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3777         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3778         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3779         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3780         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3781         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3782         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3783         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3784         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3785         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3786         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3787         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3788         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3789         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3790         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3791         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3792         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3793         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3794         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3795         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3796         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3797         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3798         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3799         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3800         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3801         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3802         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3803
3804 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3805
3806         Unreviewed gardening (Take 2): Prevent users from attempting
3807         to build with known invalid cURL. 
3808
3809         * Scripts/webkitdirs.pm:
3810         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3811         7.33.0 (the known good version).
3812
3813 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3814
3815         [GTK] Remove DumpRenderTree and GtkLauncher
3816         https://bugs.webkit.org/show_bug.cgi?id=131373
3817
3818         Reviewed by Andreas Kling.
3819
3820         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3821         no longer necessary now that WebKit1 GTK+ will be removed.
3822
3823         * CMakeLists.txt:
3824         * DumpRenderTree/PlatformGTK.cmake: Removed.
3825         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3826         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3827         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3828         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3829         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3830         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3831         * DumpRenderTree/gtk/EventSender.h: Removed.
3832         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3833         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3834         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3835         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3836         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3837         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3838         * DumpRenderTree/gtk/TextInputController.h: Removed.
3839         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3840         * GtkLauncher/CMakeLists.txt: Removed.
3841         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3842         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3843         * GtkLauncher/main.c: Removed.
3844         * GtkLauncher/simple.svg: Removed.
3845         * GtkLauncher/text.html: Removed.
3846         * WebKitTestRunner/PlatformGTK.cmake:
3847         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3848         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3849         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3850
3851 2014-04-08  Mark Rowe  <mrowe@apple.com>
3852
3853         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3854         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3855
3856         Reviewed by Alexey Proskuryakov.
3857
3858         * Scripts/webkitdirs.pm:
3859         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3860         (execMacWebKitAppForDebugging): Ditto.
3861
3862 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3863
3864         Build bmalloc on iOS too
3865         https://bugs.webkit.org/show_bug.cgi?id=131381
3866
3867         Reviewed by Andreas Kling.
3868
3869         * Scripts/build-webkit:
3870
3871 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3872
3873         Unreviewed gardening: Prevent users from attempting
3874         to build with known invalid cURL.
3875
3876         * Scripts/webkitdirs.pm:
3877         (checkInstalledTools): Block build attempts with bad
3878         Cygwin tool set.
3879
3880 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3881
3882         Build bmalloc on Mac
3883         https://bugs.webkit.org/show_bug.cgi?id=131333
3884
3885         Reviewed by Mark Rowe.
3886
3887         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3888         (Note: Just testing Mac is not good enough because in this
3889         script 'Mac' means 'Mac or iOS'.)
3890
3891 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3892
3893         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3894         https://bugs.webkit.org/show_bug.cgi?id=130951
3895
3896         Reviewed by Geoffrey Garen.
3897
3898         * Scripts/run-javascriptcore-tests:
3899
3900 2014-04-06  Darin Adler  <darin@apple.com>
3901
3902         Rework CSS calc logic, fixing some reference count mistakes in Length
3903         https://bugs.webkit.org/show_bug.cgi?id=131280
3904
3905         Reviewed by Andreas Kling.
3906
3907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3908         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3909
3910 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3911
3912         Enable WEB_REPLAY for PLATFORM(MAC)
3913         https://bugs.webkit.org/show_bug.cgi?id=130700
3914
3915         Reviewed by Timothy Hatcher.
3916
3917         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3918
3919 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3920
3921         [CMake] Include X11's include dirs in TestNetscapePlugin
3922         https://bugs.webkit.org/show_bug.cgi?id=131270
3923
3924         Reviewed by Martin Robinson.
3925
3926         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3927         TestNetscapePlugin includes WebCore code that includes X headers.
3928
3929 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3930
3931         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3932         <http://webkit.org/b/130986>
3933
3934         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3935         prefix to TileCache class names in exception list.
3936
3937 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3938
3939         [GTK] kill-old-processes should kill dbus-daemon processes
3940         https://bugs.webkit.org/show_bug.cgi?id=127352
3941
3942         Reviewed by Martin Robinson.
3943
3944         * BuildSlaveSupport/kill-old-processes:
3945         (main):
3946
3947 2014-04-04  Andres Gomez  <agomez@igalia.com>
3948
3949         [Win] Update obsolete packages in cygwin
3950         https://bugs.webkit.org/show_bug.cgi?id=126264
3951
3952         Reviewed by Brent Fulgham.
3953
3954         Removed "apache" and "minires" as the first has been replaced by
3955         "lighttpd" and the second is now integrated into
3956         "cygwin". Replaced the transitional and now obsolete "gcc" package
3957         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3958         since the newer version available is "2.7.3" which breaks the
3959         build due to some funniness with environment variable handling.
3960
3961         * CygwinDownloader/cygwin-downloader.py:
3962         * CygwinDownloader/cygwin-downloader.zip:
3963
3964 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3965
3966         check-webkit-style: Improve warnings on Objective-C @property syntax
3967         https://bugs.webkit.org/show_bug.cgi?id=131200
3968
3969         Reviewed by Dan Bernstein.
3970
3971         * Scripts/webkitpy/style/checkers/cpp.py:
3972         (check_spacing):
3973         (CppChecker):
3974         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3975         (CppStyleTest.test_spacing_in_objective_c_properties):
3976
3977 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3978
3979         Unreviewed. Moving my name to commiter section
3980
3981         * Scripts/webkitpy/common/config/contributors.json:
3982
3983 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3984
3985         Unreviewed. Add myself as a committer.
3986
3987         * Scripts/webkitpy/common/config/contributors.json:
3988
3989 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3990
3991         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3992         https://bugs.webkit.org/show_bug.cgi?id=130391
3993
3994         Reviewed by Gyuyoung Kim.
3995
3996         Change the implementation of the zoom functionality from ewk_view_scale_set
3997         to ewk_view_page_zoom_set.
3998
3999         * MiniBrowser/efl/main.c:
4000
4001 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
4002
4003         [webkitpy] perf profiler does not understand --call-graph argument
4004         https://bugs.webkit.org/show_bug.cgi?id=131132
4005
4006         Reviewed by Ryosuke Niwa.
4007
4008         New versions of perf profiler have changed the argument from --call-graph to -g.
4009
4010         * Scripts/webkitpy/common/system/profiler.py:
4011         (Perf.wrapper_arguments): Use -g instead of --call-graph.
4012         * Scripts/webkitpy/port/driver_unittest.py:
4013         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
4014
4015 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
4016
4017         Add EFL WK2 performance bot to build.webkit.org
4018         https://bugs.webkit.org/show_bug.cgi?id=131034
4019
4020         Fix after r166707, use "Perf" instead of "perf" for consistency.
4021
4022         Reviewed by Csaba Osztrogonác.
4023
4024         * BuildSlaveSupport/build.webkit.org-config/config.json:
4025
4026 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
4027
4028         Add EFL WK2 performance bot to build.webkit.org
4029         https://bugs.webkit.org/show_bug.cgi?id=131034
4030
4031         Reviewed by Csaba Osztrogonác.
4032
4033         * BuildSlaveSupport/build.webkit.org-config/config.json:
4034
4035 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
4036
4037         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
4038         https://bugs.webkit.org/show_bug.cgi?id=131151
4039
4040         Reviewed by Gyuyoung Kim.
4041
4042         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
4043         (TouchEventInfo::TouchEventInfo):
4044         (sendTouchEvent):
4045         (addTouchPointCallback):
4046         (updateTouchPointCallback):
4047         (cancelTouchPointCallback):
4048         (releaseTouchPointCallback):
4049
4050 2014-04-02  David Kilzer  <ddkilzer@apple.com>
4051
4052         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
4053         <http://webkit.org/b/131045>
4054
4055         Reviewed by Daniel Bates.
4056
4057         * Scripts/filter-build-webkit:
4058         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
4059         of clang, plus debug data for all DVTAssertions.
4060
4061 2014-04-01  Dean Jackson  <dino@apple.com>
4062
4063         Load Media Controls js/css from bundle
4064         https://bugs.webkit.org/show_bug.cgi?id=131086
4065
4066         Reviewed by Eric Carlson.
4067
4068         We're now putting CSS files into the bundle, so remove the test for them.
4069
4070         * Scripts/check-for-inappropriate-files-in-framework:
4071
4072 2014-04-02  Martin Hock  <mhock@apple.com>
4073
4074         Unify private browsing with sessions.
4075         https://bugs.webkit.org/show_bug.cgi?id=130099
4076
4077         Reviewed by Alexey Proskuryakov.
4078
4079         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
4080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4081         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
4082         (TestWebKitAPI::didNavigateWithNavigationData):
4083         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4084         (TestWebKitAPI::TEST):
4085
4086         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
4087         (TestWebKitAPI::didNavigateWithoutNavigationData):
4088         (TestWebKitAPI::didNavigateWithNavigationData):
4089         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4090         (TestWebKitAPI::TEST):
4091
4092 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
4093
4094         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
4095         https://bugs.webkit.org/show_bug.cgi?id=130343
4096
4097         Reviewed by Gustavo Noronha Silva.
4098
4099         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
4100         of directories on the command line and look for all appropriate files in those directories for the
4101         GResource archive. Also make archive paths relative to those directories.
4102         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
4103         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
4104
4105 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4106
4107         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
4108         https://bugs.webkit.org/show_bug.cgi?id=131106
4109
4110         Reviewed by Csaba Osztrogonác.
4111
4112         * Scripts/webkitpy/tool/commands/download.py:
4113         (AbstractRolloutPrepCommand._prepare_state):
4114         * Scripts/webkitpy/tool/commands/download_unittest.py:
4115         (test_prepare_rollout):
4116         (test_create_rollout):
4117         (test_create_rollout_resolved):
4118         (test_rollout):
4119
4120 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
4121
4122         [EFL] Add option to use separate web process for new window in MiniBrowser
4123         https://bugs.webkit.org/show_bug.cgi?id=130190
4124
4125         Reviewed by Gyuyoung Kim.
4126
4127         New created window (CTRL + n) will be open in separated web process.
4128         This option is enabled by adding a flag (S/separate-process) with launching
4129         MiniBrowser.
4130
4131         * MiniBrowser/efl/main.c:
4132         (elm_main):
4133
4134 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4135
4136         [GTK] Move NEWS file to a new location
4137         https://bugs.webkit.org/show_bug.cgi?id=130901
4138
4139         Reviewed by Brent Fulgham.
4140
4141         * gtk/manifest.txt: Update the NEWS file path.
4142
4143 2014-04-01  Anders Carlsson  <andersca@apple.com>
4144
4145         Fix build.
4146
4147         * MiniBrowser/mac/WK2BrowserWindowController.m:
4148         (-[WK2BrowserWindowController awakeFromNib]):
4149         (-[WK2BrowserWindowController dealloc]):
4150         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
4151
4152 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
4153
4154         Unreviewed test gardening.
4155
4156         * Scripts/webkitpy/port/base_unittest.py:
4157         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
4158
4159 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
4160
4161         [CSS Exclusions] Remove exclusions parsing support
4162         https://bugs.webkit.org/show_bug.cgi?id=131046
4163
4164         Reviewed by David Hyatt.
4165
4166         * Scripts/webkitperl/FeatureList.pm:
4167
4168 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
4169
4170         [GTK] Remove last reference to GTK+ WK1 EWS
4171         https://bugs.webkit.org/show_bug.cgi?id=131058
4172
4173         Reviewed by Martin Robinson.
4174
4175         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
4176
4177         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
4178
4179 2014-04-01  Lucas Forschler  <lforschler@apple.com>
4180
4181         Add a 32bit JSC builder/tester.
4182         https://bugs.webkit.org/show_bug.cgi?id=131054
4183         
4184         Reviewed by Michael Saboff.
4185
4186         * BuildSlaveSupport/build.webkit.org-config/config.json:
4187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4188         (Compile32bitJSC):
4189         (Run32bitJSCTests):
4190         (Run32bitJSCTests.countFailures):
4191         (BuildAndTest32bitJSCFactory):
4192         (BuildAndTest32bitJSCFactory.__init__):
4193
4194 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
4195
4196         [GTK] No longer build WebKit1 gtkdoc
4197         https://bugs.webkit.org/show_bug.cgi?id=130970
4198
4199         Reviewed by Anders Carlsson.
4200
4201         * gtk/common.py:
4202         (gtk_version_of_pkg_config_file): Deleted.
4203         * gtk/generate-gtkdoc:
4204         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
4205         was only applicable for WebKit1.
4206         (get_generator_for_config): No longer look for the WebKit1 configuration file.
4207
4208 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
4209
4210         [GTK] Running minibrowser with url crashes in debug build
4211         https://bugs.webkit.org/show_bug.cgi?id=130492
4212
4213         Reviewed by Martin Robinson.
4214
4215         Update "uri-scheme" test not to use invalid URIs in it, so we
4216         don't get a mistmatch when comparing the original URI stored in
4217         the test class with the one returned by the WebKitWebView.
4218
4219         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4220         (testWebContextURIScheme): Update the test.
4221
4222 2014-04-01  Mihai Tica  <mitica@adobe.com>
4223
4224         Unreviewed: Add myself as a commiter to the contributors list.
4225
4226         * Scripts/webkitpy/common/config/contributors.json:
4227
4228 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
4229
4230         [EFL][WK2] Extract the control of page background out of color_set
4231         https://bugs.webkit.org/show_bug.cgi?id=127539
4232
4233         Reviewed by Gyuyoung Kim.
4234
4235         Added an option(C) to change background color.
4236
4237         * MiniBrowser/efl/main.c:
4238         (window_create):
4239         (elm_main):
4240
4241 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
4242
4243         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
4244
4245         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
4246
4247 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
4248
4249         Unreviewed test correction after r166530.
4250
4251         * DumpRenderTree/mac/DumpRenderTree.mm:
4252         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
4253         fine-grained setting for swipe tests. This prevents existing tests from breaking.
4254
4255 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4256
4257         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
4258         https://bugs.webkit.org/show_bug.cgi?id=130987
4259
4260         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
4261         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
4262
4263         Reviewed by Martin Robinson.
4264
4265         * BuildSlaveSupport/build.webkit.org-config/config.json:
4266
4267 2014-03-31  Dean Jackson  <dino@apple.com>
4268
4269         Remove WEB_ANIMATIONS
4270         https://bugs.webkit.org/show_bug.cgi?id=130989
4271
4272         Reviewed by Simon Fraser.
4273
4274         Remove this feature flag until we plan to implement.
4275
4276         * Scripts/webkitperl/FeatureList.pm:
4277
4278 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
4279
4280         Reduced Latched Scroll Test Flakiness
4281         https://bugs.webkit.org/show_bug.cgi?id=130983
4282
4283         Reviewed by Darin Adler.
4284
4285         * DumpRenderTree/mac/DumpRenderTree.mm:
4286         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
4287         * DumpRenderTree/mac/EventSendingController.mm:
4288         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
4289         with high resolution flags turned on.
4290         * WebKitTestRunner/mac/EventSenderProxy.mm:
4291         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
4292
4293 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4294
4295         run-webkit-tests should have a --no-timeout option
4296         https://bugs.webkit.org/show_bug.cgi?id=128286
4297
4298         Reviewed by Joseph Pecoraro.
4299
4300         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4301         (Worker._run_test): Renaming _run_test_with_timeout()
4302         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
4303         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
4304         (Worker._run_test_in_this_thread):
4305         (Worker._run_test_with_timeout): Deleted.
4306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4307         (parse_args): Added the --no-timeout option
4308
4309 2014-03-31  Samuel White  <samuel_white@apple.com>
4310
4311         AX: Need ability to get line range for text marker.
4312         https://bugs.webkit.org/show_bug.cgi?id=130906
4313
4314         Reviewed by Chris Fleizach.
4315
4316         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
4317
4318         * DumpRenderTree/AccessibilityUIElement.cpp:
4319         (lineTextMarkerRangeForTextMarkerCallback):
4320         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
4321         (AccessibilityUIElement::getJSClass):
4322         * DumpRenderTree/AccessibilityUIElement.h:
4323         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4324         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
4325         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4326