Tools/ChangeLog

   1 2010-12-22  Lucas Forschler  <lforschler@apple.com>
   2
   3         Unreviewed rollout r74489, because it was missing changelog.
   4
   5         * record-memory-win/main.cpp:
   6
   7 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
   8
   9         Adding myself as a reviewer.
  10
  11         * Scripts/webkitpy/common/config/committers.py:
  12
  13 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
  14
  15         Unreviewed.  Adding myself to committers.py.
  16
  17         * Scripts/webkitpy/common/config/committers.py:
  18
  19 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
  20
  21         Reviewed by Kenneth Rohde Christiansen.
  22
  23         TestNetscapePlugIn should use #if defined
  24         https://bugs.webkit.org/show_bug.cgi?id=51471
  25
  26         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  27         (NP_Initialize):
  28         (NPP_New):
  29
  30 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
  31
  32         Reviewed by Yury Semikhatsky.
  33
  34         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
  35
  36         DevTools window should be closed explicitly because it has custom deinitialization code.
  37
  38         https://bugs.webkit.org/show_bug.cgi?id=50722
  39
  40         * DumpRenderTree/chromium/TestShell.cpp:
  41         (TestShell::closeRemainingWindows):
  42
  43 2010-12-22  David Levin  <levin@chromium.org>
  44
  45         Reviewed by Shinichiro Hamaji.
  46
  47         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
  48         https://bugs.webkit.org/show_bug.cgi?id=51452
  49
  50         * Scripts/webkitpy/style/checkers/cpp.py:
  51         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
  52         Using the file extension if possible but falling back to the file contents if we have a header file.
  53         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
  54         (_FileState.is_c_or_objective_c):
  55         (check_using_std): Changed to using _FileState to determine the file type.
  56         (check_max_min_macros): Ditto.
  57         (check_for_null): Ditto.
  58         (check_style): Changed the parameters to various calls since they now need _FileState
  59         to determine the file type.
  60         (check_language): Added the file_state parameter so it could be passed
  61         to check_identifier_name_in_declaration.
  62         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
  63         this is an Objective C file.
  64         (_process_lines): Added information for the _FileState constructor (and moved the
  65         call to a place that had the information).
  66         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  67         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
  68         its functionality.
  69         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
  70
  71 2010-12-21  Andy Estes  <aestes@apple.com>
  72
  73         Reviewed by Mark Rowe.
  74
  75         Do not build non-Intel architectures for WebKit2-related projects.
  76         https://bugs.webkit.org/show_bug.cgi?id=51440
  77
  78         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
  79         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  80         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
  81
  82 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
  83
  84         Reviewed by Darin Fisher.
  85
  86         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
  87         https://bugs.webkit.org/show_bug.cgi?id=51406
  88
  89         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
  90         to WebThemeEngineDRTWin and update references everywhere.
  91
  92         * DumpRenderTree/DumpRenderTree.gypi:
  93         * DumpRenderTree/chromium/TestShellWin.cpp:
  94         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
  95         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
  96         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
  97         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
  98
  99 2010-12-21  Anders Carlsson  <andersca@apple.com>
 100
 101         Reviewed by John Sullivan.
 102
 103         Clicking missing plug-in text does not show a sheet
 104         https://bugs.webkit.org/show_bug.cgi?id=51403
 105
 106         Update for changes to the WebPageUIClient.
 107
 108         * MiniBrowser/mac/BrowserWindowController.m:
 109         (-[BrowserWindowController awakeFromNib]):
 110         * WebKitTestRunner/TestController.cpp:
 111         (WTR::createOtherPage):
 112         (WTR::TestController::initialize):
 113
 114 2010-12-21  Eric Seidel  <eric@webkit.org>
 115
 116         Reviewed by Adam Barth.
 117
 118         commit-queue will report constant failures as flaky if other tests flake
 119         https://bugs.webkit.org/show_bug.cgi?id=51272
 120
 121         This patch just removes functionality and adds testing.
 122         Previously we attempted to report flaky tests when we had
 123         two different tests fail in a row.  However, since we stop
 124         running the tests at the first failure, our code was wrong in
 125         trying to determine flakiness from the incomplete runs.
 126
 127         Originally I posted an alternate patch:
 128         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
 129         which fixed our flaky logic in this case, however it was decided
 130         that that patch would be too difficult to maintain, so now
 131         I'm just removing the broken logic.
 132
 133         This will dramatically cut-down on our flaky-test false positives
 134         at the (small) cost of the queues being unable to report
 135         any flakiness if the tree is very flaky.  (With at least one test
 136         flaking on every run, we'll never report failures anymore.)  I think
 137         this is a tradeoff worth making.
 138
 139         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 140         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 141
 142 2010-12-20  Eric Seidel  <eric@webkit.org>
 143
 144         Reviewed by Adam Barth.
 145
 146         commit-queue wrongly rejects patches when it can't update itself
 147         https://bugs.webkit.org/show_bug.cgi?id=46636
 148
 149         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 150         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 151         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 152
 153 2010-12-20  Adam Barth  <abarth@webkit.org>
 154
 155         Move web sites to Websites directory
 156         https://bugs.webkit.org/show_bug.cgi?id=51323
 157
 158         Update references to BugsSite to point to the new location.
 159
 160         This patch was never officially reviewed (because it was too large to
 161         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
 162         Rowe gave me the green light.
 163
 164         * Scripts/old-run-webkit-tests:
 165         * Scripts/webkitpy/common/config/build.py:
 166         * Scripts/webkitpy/common/config/build_unittest.py:
 167         * Scripts/webkitpy/common/prettypatch.py:
 168         * Scripts/webkitpy/layout_tests/port/base.py:
 169         * Scripts/webkitpy/style/main.py:
 170
 171 2010-12-20  Adrienne Walker  <enne@google.com>
 172
 173         Unreviewed. Adding myself to the list of committers.
 174
 175         * webkitpy/common/config/committers.py:
 176
 177 2010-12-20  Mark Rowe  <mrowe@apple.com>
 178
 179         Reviewed by Dan Bernstein.
 180
 181         <rdar://problem/8757601> Don't install header files in to the Resources directory.
 182
 183         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
 184         Resources directory.
 185
 186 2010-12-20  Eric Seidel  <eric@webkit.org>
 187
 188         Reviewed by Adam Barth.
 189
 190         commit-queue should include bot id when attaching failure diffs
 191         https://bugs.webkit.org/show_bug.cgi?id=51280
 192
 193         This is a tiny change to include the bot id in the name of the attachment.
 194         Most of this diff is just changing the unit test expectations
 195         now that I hid the comment printing when the comment is None.
 196
 197         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 198         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 199         * Scripts/webkitpy/tool/commands/upload_unittest.py:
 200         * Scripts/webkitpy/tool/mocktool.py:
 201
 202 2010-12-20  Jeff Miller  <jeffm@apple.com>
 203
 204         Reviewed by Dan Bernstein.
 205
 206         Tools/vcbin/midl.exe needs to be rebuilt
 207         https://bugs.webkit.org/show_bug.cgi?id=51347
 208
 209         * vcbin/midl.exe: Rebuilt.
 210
 211 2010-12-20  David Levin  <levin@chromium.org>
 212
 213         Reviewed by Ariya Hidayat.
 214
 215         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
 216         https://bugs.webkit.org/show_bug.cgi?id=51343
 217
 218         Follow up from the WebKitTools -> Tools rename.
 219
 220         * Scripts/webkit-tools-completion.sh:
 221
 222 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
 223
 224         Reviewed by James Robinson.
 225
 226         new-run-webkit-tests ignores trailing EOL differences in text tests
 227         https://bugs.webkit.org/show_bug.cgi?id=36983
 228
 229         Changed the handling of new-line characters within new-run-webkit-tests
 230         to match old-run-webkit-tests.  Differences in leading and trailing empty
 231         lines in text expectation files are no longer ignored.
 232
 233         * Scripts/webkitpy/layout_tests/port/base.py:
 234         * Scripts/webkitpy/layout_tests/port/test.py:
 235         Added unit tests.  Removed old duplicate unit test entries.
 236         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 237
 238 2010-12-20  David Levin  <levin@chromium.org>
 239
 240         Reviewed by Shinichiro Hamaji.
 241
 242         check-webkit-style should detect function declarations (and trivial functions).
 243         https://bugs.webkit.org/show_bug.cgi?id=51303
 244
 245         * Scripts/webkitpy/style/checkers/cpp.py:
 246         (_FunctionState.begin): Add is_declaration and changed the line count
 247         start to begin at -1 (which will keep the results consistent, since
 248         the starting line number passed in is one less in this change).
 249         (detect_functions): changed function detection to now catch trivial
 250         functions and declarations.
 251         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
 252         of the function as this may look at return values (when processing
 253         a declaration).
 254         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 255         (FunctionDetectionTest.perform_function_detection): Basic mechanics
 256         of testing the function detection.
 257         (FunctionDetectionTest.test_basic_function_detection): Test a simple
 258         function.
 259         (FunctionDetectionTest.test_function_declaration_detection): Test a
 260         declaration.
 261         (FunctionDetectionTest.test_non_functions): A test case for a case
 262         that caused the code to fail due to the { being in quotes.
 263         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
 264         cases to help catch false alarms for return values.
 265         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
 266         we don't get false alarms for member variables either.
 267
 268 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
 269
 270         Reviewed by Antonio Gomes.
 271
 272         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
 273         https://bugs.webkit.org/show_bug.cgi?id=51319
 274
 275         * CMakeListsEfl.txt:
 276
 277 2010-12-18  Adam Barth  <abarth@webkit.org>
 278
 279         Reviewed by Sam Weinig.
 280
 281         Move WebKitExamplePlugins to Examples
 282         https://bugs.webkit.org/show_bug.cgi?id=51291
 283
 284         * Scripts/webkitpy/common/config/build.py:
 285
 286 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
 287
 288         Unreviewed Qt buildfix after r74301.
 289
 290         Rename WebKitTools to Tools
 291         https://bugs.webkit.org/show_bug.cgi?id=49861
 292
 293         * MiniBrowser/DerivedSources.pro:
 294         * MiniBrowser/qt/MiniBrowser.pro:
 295
 296 2010-12-17  Dan Bernstein  <mitz@apple.com>
 297
 298         Reviewed by Simon Fraser.
 299
 300         Rename WebKitTools to Tools
 301         https://bugs.webkit.org/show_bug.cgi?id=49861
 302
 303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 304         * CodeCoverage/README:
 305         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 306         (WebCore::DumpRenderTree::initializeFonts):
 307         * EWSTools/start-commit-queue.sh:
 308         * EWSTools/start-queue.sh:
 309         * GNUmakefile.am:
 310         * MIDLWrapper/MIDLWrapper.cpp:
 311         (wmain):
 312         * MiniBrowser/qt/MiniBrowser.pro:
 313         * Scripts/build-api-tests:
 314         * Scripts/build-dumprendertree:
 315         * Scripts/build-webkit:
 316         * Scripts/build-webkittestrunner:
 317         * Scripts/generate-coverage-data:
 318         * Scripts/old-run-webkit-tests:
 319         * Scripts/run-api-tests:
 320         * Scripts/run-iexploder-tests:
 321         * Scripts/run-javascriptcore-tests:
 322         * Scripts/run-mangleme-tests:
 323         * Scripts/run-sunspider:
 324         * Scripts/run-webkit-websocketserver:
 325         * Scripts/sunspider-compare-results:
 326         * Scripts/test-webkitperl:
 327         * Scripts/test-webkitpy:
 328         * Scripts/update-iexploder-cssproperties:
 329         * Scripts/update-webkit:
 330         * Scripts/update-webkit-localizable-strings:
 331         * Scripts/webkitdirs.pm:
 332         * Scripts/webkitpy/common/checkout/scm.py:
 333         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 334         * Scripts/webkitpy/common/config/committervalidator.py:
 335         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
 336         * Scripts/webkitpy/common/config/ports.py:
 337         * Scripts/webkitpy/common/config/ports_unittest.py:
 338         * Scripts/webkitpy/common/system/logutils_unittest.py:
 339         * Scripts/webkitpy/common/system/ospath_unittest.py:
 340         * Scripts/webkitpy/layout_tests/port/chromium.py:
 341         * Scripts/webkitpy/layout_tests/port/config.py:
 342         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
 343         * Scripts/webkitpy/layout_tests/port/http_server.py:
 344         * Scripts/webkitpy/layout_tests/port/test.py:
 345         * Scripts/webkitpy/style/checker.py:
 346         * Scripts/webkitpy/style/checker_unittest.py:
 347         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
 348         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 349         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 350         * WebKitTestRunner/DerivedSources.pro:
 351         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 352         (WTR::activateFonts):
 353         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 354         * wx/build/build_utils.py:
 355
 356 2010-12-16  Antonio Gomes  <agomes@rim.com>
 357
 358         Reviewed by Martin Robinson.
 359
 360         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
 361         https://bugs.webkit.org/show_bug.cgi?id=51163
 362
 363         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
 364         GTK+'s DRT should also reset to UNIX after each test execution.
 365
 366         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 367         (resetDefaultsToConsistentValues):
 368
 369 2010-12-17  David Levin  <levin@chromium.org>
 370
 371         Reviewed by Eric Seidel.
 372
 373         check-webkit-style should understand WTF #include guards
 374         https://bugs.webkit.org/show_bug.cgi?id=44911
 375
 376         * Scripts/webkitpy/style/checkers/cpp.py:
 377         (get_header_guard_cpp_variable): modify to suggest the WTF style
 378         of header guard when appropriate.
 379         (check_for_header_guard): handle multiple return values from
 380         get_header_guard_cpp_variable
 381         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 382         (CppStyleTest.test_build_header_guard): Added tests for the WTF
 383         header style.
 384
 385 2010-12-16  David Levin  <levin@chromium.org>
 386
 387         Reviewed by Eric Seidel.
 388
 389         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
 390         https://bugs.webkit.org/show_bug.cgi?id=51210
 391
 392         The error only shows up when using python 2.6 or later.
 393
 394         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
 395         the decprecated field error,message with something equivalent.
 396
 397 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
 398
 399         Reviewed by Eric Seidel.
 400
 401         Add --exit-after-n-failures/crashes to NRWT
 402         https://bugs.webkit.org/show_bug.cgi?id=51160
 403
 404         Abort test run (in a similar way to how control-C is handled) when
 405         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
 406         that number of unexpected failures/crashes/timeouts.
 407
 408         * Scripts/webkitpy/layout_tests/port/test.py:
 409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 410         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 411
 412 2010-12-16  David Levin  <levin@chromium.org>
 413
 414         Reviewed by Shinichiro Hamaji.
 415
 416         check-webkit-style unit tests has some duplicate boilerplate code.
 417         https://bugs.webkit.org/show_bug.cgi?id=49519
 418
 419         * Scripts/webkitpy/style/checkers/cpp.py:
 420         (update_include_state): Replaced the "io" parameter with the global
 421         configuration _unit_test_config. This allowed not calling into
 422         functions at a low level and also not plumbing through the injection
 423         information through many levels of code.
 424         (check_for_include_what_you_use): Ditto.
 425         (process_file_data): Added the ability to set up the unit test config
 426         to allow for injection.
 427         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 428         (ErrorCollector.__init__): Added support for having a filter for errors.
 429         (ErrorCollector.__call__): Ditto.
 430         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
 431         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
 432         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
 433         functions in the cpp.py with generic processing and a filter that
 434         indicates what errors should be kept.
 435         (CppStyleTestBase.perform_multi_line_lint): Ditto.
 436         (CppStyleTestBase.perform_language_rules_check): Ditto.
 437         (CppStyleTestBase.perform_function_lengths_check): Ditto.
 438         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
 439         (CppStyleTestBase.perform_include_what_you_use): Ditto.
 440         (CppStyleTest.test_multi_line_comments): Added another
 441         error message which applies to the test case.
 442         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
 443         to not have config.h, since it is processed as a header file.
 444         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
 445         style and indentation in checked code.
 446         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
 447         Fixed line number.
 448         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
 449         Ditto.
 450
 451 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
 452
 453         Unreviewed, rolling out r74136.
 454         http://trac.webkit.org/changeset/74136
 455         https://bugs.webkit.org/show_bug.cgi?id=51135
 456
 457         r74136 breaks chromium canary bots because some tests are not
 458         rebaselined correctly to resolve EOL differences (Requested by
 459         jianli on #webkit).
 460
 461         * Scripts/webkitpy/layout_tests/port/base.py:
 462         * Scripts/webkitpy/layout_tests/port/test.py:
 463         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 464
 465 2010-12-15  Adam Roben  <aroben@apple.com>
 466
 467         Teach check-webkit-style to check .vcproj and .vsprops files for XML
 468         syntax errors
 469
 470         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
 471         XML syntax errors in .vcproj/.vsprops files
 472
 473         Reviewed by Dave Levin.
 474
 475         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
 476         that should be treated as XML and that should be allowed to contain
 477         carriage returns. (These lists happen to be identical currently.)
 478         (FileType): Added a new XML type.
 479         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
 480         Just does a simple file extension check.
 481         (CheckerDispatcher._file_type): Added a case for XML files.
 482         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
 483         files (surprise!).
 484         (StyleProcessor.process): Ask the dispatcher whether we should pass the
 485         lines through the carriage checker.
 486
 487         * Scripts/webkitpy/style/checker_unittest.py:
 488         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
 489         Added. Checks a few file names to see if carriage returns are allowed
 490         or not.
 491         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
 492         other assert_checker_* functions.
 493         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
 494         test_*_paths functions.
 495         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
 496         test_*_paths functions.
 497         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
 498         file from this test case, as vcproj files now have a type.
 499         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
 500         Added. Similar to the other should_* functions.
 501         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
 502         Added. Checks that carriage returns aren't checked for or stripped for
 503         allowed files.
 504
 505         * Scripts/webkitpy/style/checkers/xml.py: Added.
 506         (XMLChecker.__init__): Simple init method.
 507         (XMLChecker.check): Pass each line through the expat parser, and record
 508         a style error for any errors thrown by the parser.
 509
 510         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
 511         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
 512         produce a style error.
 513         (XMLCheckerTest.assert_error): Checks that the given XML produces an
 514         error of the given category on the given line.
 515         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
 516         checking that the XMLChecker constructor works properly.
 517         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
 518         cause a style error (see, e.g., r73887).
 519         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
 520         cause a style error (see, e.g., r73773).
 521         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
 522         properly.
 523         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
 524         tags cause a style error (see, e.g., r72795).
 525         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
 526         style error.
 527
 528 2010-12-15  Lucas Forschler  <lforschler@apple.com>
 529
 530         Reviewed by Stephanie Lewis.
 531
 532         https://bugs.webkit.org/show_bug.cgi?id=51117
 533         Add a new leopard test bot
 534         really really commit to trunk this time.
 535
 536         * BuildSlaveSupport/build.webkit.org-config/config.json:
 537
 538 2010-12-15  Sam Weinig  <sam@webkit.org>
 539
 540         Reviewed by Anders Carlsson.
 541
 542         WebKit2: Can't add files to an <input type=file>
 543         https://bugs.webkit.org/show_bug.cgi?id=51087
 544
 545         * MiniBrowser/mac/BrowserWindowController.m:
 546         (runOpenPanel):
 547         (-[BrowserWindowController awakeFromNib]):
 548         Add simple implementation of runOpenPanel callback.
 549
 550         * MiniBrowser/win/BrowserView.cpp:
 551         (BrowserView::create):
 552         * WebKitTestRunner/TestController.cpp:
 553         (WTR::createOtherPage):
 554         (WTR::TestController::initialize):
 555         Stub out runOpenPanel callback.
 556
 557 2010-12-14  Eric Seidel  <eric@webkit.org>
 558
 559         Reviewed by Adam Barth.
 560
 561         commit-queue should upload failure diffs when tests flake
 562         https://bugs.webkit.org/show_bug.cgi?id=51051
 563
 564         To make this testable I needed to pipe FileSystem down onto tool.
 565         We've wanted it there for a long time anyway.
 566
 567         This patch is kinda a big hack.  But we don't have a nice
 568         way to read results.html files.  I think this will need further
 569         revision before this code actually feels clean.
 570
 571         As part of testing this change, I had to make MockBugzilla.create_bug
 572         actually return an id (like it should) which required updating
 573         a few other unit test results (for the better).
 574
 575         The results_matching_keys change in layouttestresults/rebasline
 576         was an alternate path which I decided not to use in the end, but
 577         I left the change as it seemed an improvement.
 578
 579         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 580         * Scripts/webkitpy/common/net/layouttestresults.py:
 581         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 582         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 583         * Scripts/webkitpy/tool/commands/queues.py:
 584         * Scripts/webkitpy/tool/commands/rebaseline.py:
 585         * Scripts/webkitpy/tool/main.py:
 586         * Scripts/webkitpy/tool/mocktool.py:
 587
 588 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
 589
 590         Reviewed by James Robinson.
 591
 592         new-run-webkit-tests ignores trailing EOL differences in text tests
 593         https://bugs.webkit.org/show_bug.cgi?id=36983
 594
 595         Changed the handling of new-line characters within new-run-webkit-tests
 596         to match old-run-webkit-tests.  Differences in leading and trailing empty
 597         lines in text expectation files are no longer ignored.
 598
 599         * Scripts/webkitpy/layout_tests/port/base.py:
 600         * Scripts/webkitpy/layout_tests/port/test.py:
 601         Added unit tests.  Removed old duplicate unit test entries.
 602         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 603
 604 2010-12-15  Ojan Vafai  <ojan@chromium.org>
 605
 606         Reviewed by Adam Barth.
 607
 608         make status-bubble white-space:nowrap so we can measure it's width without wrapping
 609         https://bugs.webkit.org/show_bug.cgi?id=51149
 610
 611         * QueueStatusServer/templates/statusbubble.html:
 612
 613 2010-12-15  Ojan Vafai  <ojan@chromium.org>
 614
 615         Reviewed by Adam Barth.
 616
 617         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
 618         https://bugs.webkit.org/show_bug.cgi?id=51125
 619
 620         * QueueStatusServer/templates/statusbubble.html:
 621
 622 2010-12-15  Darin Adler  <darin@apple.com>
 623
 624         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
 625
 626 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
 627
 628         Unreviewed, rolling out r74117.
 629         http://trac.webkit.org/changeset/74117
 630         https://bugs.webkit.org/show_bug.cgi?id=51113
 631
 632         This broke the GTK1 build. (Requested by mrobinson on
 633         #webkit).
 634
 635         * Scripts/webkitdirs.pm:
 636
 637 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
 638
 639         Reviewed by Martin Robinson.
 640
 641         Change generate-forwarding-headers.pl for GTK port usage
 642         (https://bugs.webkit.org/show_bug.cgi?id=37369)
 643
 644         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
 645
 646 2010-12-14  Kent Tamura  <tkent@chromium.org>
 647
 648         Reviewed by Jian Li.
 649
 650         [DRT/Chromium] Remove another unnecessary error message
 651         https://bugs.webkit.org/show_bug.cgi?id=51083
 652
 653         * DumpRenderTree/chromium/WebViewHost.cpp:
 654         (WebViewHost::didInvalidateRect):
 655
 656 2010-12-14  Lucas Forschler  <lforschler@apple.com>
 657
 658         Reviewed by Stephanie Lewis.
 659
 660         Add a new Leopard Debug Test WK2 Bot
 661
 662         * BuildSlaveSupport/build.webkit.org-config/config.json:
 663
 664 2010-12-14  Ojan Vafai  <ojan@chromium.org>
 665
 666         Fix python unittests after http://trac.webkit.org/changeset/74070.
 667
 668         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 669
 670 2010-12-14  Kent Tamura  <tkent@chromium.org>
 671
 672         Reviewed by Jian Li.
 673
 674         [DRT/Chromium] Remove a unnecessary error message
 675         https://bugs.webkit.org/show_bug.cgi?id=51069
 676
 677         * DumpRenderTree/chromium/WebViewHost.cpp:
 678         (WebViewHost::paintInvalidatedRegion):
 679
 680 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
 681
 682         Reviewed by Ojan Vafai.
 683
 684         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
 685         https://bugs.webkit.org/show_bug.cgi?id=48926
 686
 687         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 688         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
 689
 690 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 691
 692         Reviewed by Eric Seidel.
 693
 694         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
 695         https://bugs.webkit.org/show_bug.cgi?id=50231
 696
 697         Guard CONFIG+=link_pkgconfig with !symbian.
 698
 699         * DumpRenderTree/qt/DumpRenderTree.pro:
 700         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 701         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 702
 703 2010-12-14  Philippe Normand  <pnormand@igalia.com>
 704
 705         Reviewed by Ojan Vafai.
 706
 707         [new-run-webkit-tests] expectations parsing is slow
 708         https://bugs.webkit.org/show_bug.cgi?id=50635
 709
 710         Avoid expensive iteration of all the tests when checking if a test
 711         file is to be skipped or not.
 712
 713         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 714         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 715         * Scripts/webkitpy/layout_tests/port/test.py:
 716
 717 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
 718
 719         Reviewed by Xan Lopez.
 720
 721         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
 722         https://bugs.webkit.org/show_bug.cgi?id=27048
 723
 724         Add support in DRT for checking whether an accessibility UI
 725         element is focusable and/or focused. Implemented for GTK.
 726
 727         * DumpRenderTree/AccessibilityUIElement.cpp:
 728         (getIsFocusedCallback): New.
 729         (getIsFocusableCallback): New.
 730         (AccessibilityUIElement::getJSClass): Add the new available
 731         callbacks for isFocused and isFocusable.
 732         * DumpRenderTree/AccessibilityUIElement.h:
 733         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 734         (AccessibilityUIElement::isFocused): New, implemented by checking
 735         whether the related AtkState value is in the object's state set.
 736         (AccessibilityUIElement::isFocusable): Ditto.
 737         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 738         (AccessibilityUIElement::isFocused): New, dummy implementation.
 739         (AccessibilityUIElement::isFocusable): Ditto.
 740         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 741         (AccessibilityUIElement::isFocused): Ditto.
 742         (AccessibilityUIElement::isFocusable): Ditto.
 743
 744 2010-12-14  Eric Seidel  <eric@webkit.org>
 745
 746         Reviewed by Ojan Vafai.
 747
 748         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
 749         https://bugs.webkit.org/show_bug.cgi?id=50715
 750
 751         This patch makes webkit-patch print the following:
 752
 753         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
 754         Install a 64-bit git for better performance, see:
 755         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
 756
 757         I wrote this mostly because I have approximately 8 machines that I use
 758         and making sure each one is using a good Git install seemed folly.
 759         webkit-patch makes a lot of git calls, so using a fast git can shave
 760         several seconds in every invocation.  See the webkit-dev thread for more info.
 761
 762         This message will print twice during 'webkit-patch upload',
 763         once from webkit-patch and once from check-webkit-style.
 764
 765         Unfortunately there is no good way to test this due to how machine-dependent
 766         the code is.  I considered writing a test for the log message, but it seemed not worth it.
 767
 768         * Scripts/webkitpy/common/checkout/scm.py:
 769
 770 2010-12-13  Eric Seidel  <eric@webkit.org>
 771
 772         Reviewed by Adam Barth.
 773
 774         FlakyTestReporter doesn't understand bots running from multiple email addresses
 775         https://bugs.webkit.org/show_bug.cgi?id=50960
 776
 777         This explains at least one of the dupes of:
 778         https://bugs.webkit.org/show_bug.cgi?id=50863
 779         that we saw filed by the commit-queue this morning.
 780         I think the other one was explained by my previous fix to result counting code.
 781
 782         Since this is really hard to test with a unit test, instead I
 783         create a new (possibly useful in the future) command
 784         which given a layout test path will return you
 785         the one bug which our tools would assume it the flaky test bug.
 786         If some other script wants to use bug-for-test we'll
 787         need to extend it with some options like --create-if-missing or similar.
 788
 789         * Scripts/webkitpy/common/net/bugzilla/bug.py:
 790         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 791         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 792         * Scripts/webkitpy/tool/commands/__init__.py:
 793         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
 794
 795 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
 796
 797         Reviewed by James Robinson.
 798
 799         Add option to build-webkit to not build WebKit2
 800         https://bugs.webkit.org/show_bug.cgi?id=50988
 801
 802         Add support for a --no-webkit2 option to build-webkit. It seems to save
 803         ~1 minute from clean builds and ~10 seconds from no-op builds.
 804
 805         * Scripts/build-webkit:
 806
 807 2010-12-13  Lucas Forschler  <lforschler@apple.com>
 808
 809         Reviewed by Dave Kilzer.
 810
 811         Update iexploder from 1.3.2 to 1.7.2
 812         Move 1.3.2 into its own subdir
 813         Add 1.7.2 into its own subdir
 814         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
 815
 816         * Scripts/run-iexploder-tests:
 817         * Scripts/update-iexploder-cssproperties:
 818         * iExploder/CHANGELOG.txt: Removed.
 819         * iExploder/LICENSE.txt: Removed.
 820         * iExploder/README.txt: Removed.
 821         * iExploder/htdocs: Removed.
 822         * iExploder/iexploder-1.3.2: Added.
 823         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
 824         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
 825         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
 826         * iExploder/iexploder-1.3.2/htdocs: Added.
 827         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
 828         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
 829         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
 830         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
 831         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
 832         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
 833         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
 834         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
 835         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
 836         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
 837         * iExploder/iexploder-1.3.2/tools: Added.
 838         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
 839         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
 840         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
 841         * iExploder/iexploder-1.7.2: Added.
 842         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
 843         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
 844         * iExploder/iexploder-1.7.2/README.txt: Added.
 845         * iExploder/iexploder-1.7.2/output: Added.
 846         * iExploder/iexploder-1.7.2/src: Added.
 847         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
 848         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
 849         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
 850         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
 851         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
 852         * iExploder/iexploder-1.7.2/src/css-properties: Added.
 853         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
 854         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
 855         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
 856         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
 857         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
 858         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
 859         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
 860         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
 861         * iExploder/iexploder-1.7.2/src/css-values: Added.
 862         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
 863         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
 864         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
 865         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
 866         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
 867         * iExploder/iexploder-1.7.2/src/headers: Added.
 868         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
 869         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
 870         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
 871         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
 872         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
 873         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
 874         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
 875         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
 876         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
 877         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
 878         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
 879         * iExploder/iexploder-1.7.2/src/html-tags: Added.
 880         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
 881         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
 882         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
 883         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
 884         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
 885         * iExploder/iexploder-1.7.2/src/html-values: Added.
 886         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
 887         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
 888         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
 889         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
 890         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
 891         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
 892         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
 893         * iExploder/iexploder-1.7.2/src/index.html: Added.
 894         * iExploder/iexploder-1.7.2/src/media: Added.
 895         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
 896         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
 897         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
 898         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
 899         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
 900         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
 901         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
 902         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
 903         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
 904         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
 905         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
 906         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
 907         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
 908         * iExploder/iexploder-1.7.2/src/mime-types: Added.
 909         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
 910         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
 911         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
 912         * iExploder/iexploder-1.7.2/src/protocols: Added.
 913         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
 914         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
 915         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
 916         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
 917         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
 918         * iExploder/iexploder-1.7.2/src/version.rb: Added.
 919         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
 920         * iExploder/iexploder-1.7.2/testcases: Added.
 921         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
 922         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
 923         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
 924         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
 925         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
 926         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
 927         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
 928         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
 929         * iExploder/iexploder-1.7.2/tools: Added.
 930         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
 931         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
 932         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
 933         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
 934         * iExploder/tools: Removed.
 935
 936 2010-12-13  Sam Weinig  <sam@webkit.org>
 937
 938         Reviewed by Anders Carlsson.
 939
 940         Remove associated page concept from WKView constructor
 941         https://bugs.webkit.org/show_bug.cgi?id=50983
 942
 943         Step 1: Remove associate page constructors from WKView and make
 944         all views use the shared namespace for the context.
 945
 946         * TestWebKitAPI/PlatformWebView.h:
 947         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 948         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
 949         * WebKitTestRunner/PlatformWebView.h:
 950         * WebKitTestRunner/TestController.cpp:
 951         (WTR::createOtherPage):
 952         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 953         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 954         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
 955
 956 2010-12-13  Sam Weinig  <sam@webkit.org>
 957
 958         Reviewed by Anders Carlsson.
 959
 960         Change the WebKit2 public API so there is no explicit WKPageNamespace object
 961         https://bugs.webkit.org/show_bug.cgi?id=50898
 962
 963         * MiniBrowser/mac/AppDelegate.h:
 964         * MiniBrowser/mac/AppDelegate.m:
 965         * MiniBrowser/mac/BrowserWindowController.h:
 966         * MiniBrowser/mac/BrowserWindowController.m:
 967         * MiniBrowser/win/BrowserView.cpp:
 968         Convert MiniBrowser to not use PageNamespaces.
 969
 970         * TestWebKitAPI/PlatformWebView.h:
 971         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 972         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
 973         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
 974         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
 975         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
 976         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
 977         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
 978         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
 979         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
 980         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
 981         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
 982         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
 983         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
 984         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 985         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
 986         Convert TestWebKitAPI to not use PageNamespaces.
 987
 988         * WebKitTestRunner/PlatformWebView.h:
 989         * WebKitTestRunner/TestController.cpp:
 990         * WebKitTestRunner/TestController.h:
 991         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 992         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 993         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
 994         Convert WebKitTestRunner to not use PageNamespaces.
 995
 996 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 997
 998         Reviewed by Eric Seidel.
 999
1000         webkit-patch rollout should be able to do multi-revision rollouts
1001         https://bugs.webkit.org/show_bug.cgi?id=33336
1002
1003         Make it possible to pass more than one revision to webkit-patch.
1004
1005         * Scripts/webkitpy/common/checkout/api.py:
1006         * Scripts/webkitpy/common/checkout/changelog.py:
1007         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1008         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1009         * Scripts/webkitpy/tool/commands/download.py:
1010         * Scripts/webkitpy/tool/commands/download_unittest.py:
1011         * Scripts/webkitpy/tool/mocktool.py:
1012         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1013         * Scripts/webkitpy/tool/steps/revertrevision.py:
1014
1015 2010-12-13  Eric Seidel  <eric@webkit.org>
1016
1017         Unreviewed.
1018
1019         Teach webkit-patch how to search bugzilla
1020         https://bugs.webkit.org/show_bug.cgi?id=50500
1021
1022         webkit-patch bug-search fails when there is only one result.
1023         Turns out we needed a bit more logic in our result count parsing code.
1024
1025         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1026         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1027
1028 2010-12-13  Antti Koivisto  <antti@apple.com>
1029
1030         Reviewed by Alexey Proskuryakov.
1031
1032         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1033         https://bugs.webkit.org/show_bug.cgi?id=50758
1034
1035         * DumpRenderTree/LayoutTestController.cpp:
1036         (setSerializeHTTPLoadsCallback):
1037         (LayoutTestController::staticFunctions):
1038         * DumpRenderTree/LayoutTestController.h:
1039         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1040         (LayoutTestController::setSerializeHTTPLoads):
1041         * DumpRenderTree/mac/DumpRenderTree.mm:
1042         (resetDefaultsToConsistentValues):
1043         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1044         (LayoutTestController::setSerializeHTTPLoads):
1045         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1046         (LayoutTestController::setSerializeHTTPLoads):
1047
1048 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1049
1050         Reviewed by Ojan Vafai.
1051
1052         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1053         https://bugs.webkit.org/show_bug.cgi?id=50936
1054
1055         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1056
1057 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1058
1059         Reviewed by Csaba Osztrogonác.
1060
1061         Add revlink to BuildBot status
1062         https://bugs.webkit.org/show_bug.cgi?id=50914
1063
1064         This adds a hyperlink to trac changeset on the revision numbers.
1065
1066         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1067
1068 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1069
1070         Reviewed by Csaba Osztrogonác.
1071
1072         [Qt][WK2] Fix build if WebKitTools are not available
1073         https://bugs.webkit.org/show_bug.cgi?id=50242
1074
1075         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1076         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1077         * MiniBrowser/DerivedSources.pro: Added.
1078
1079 2010-12-13  Eric Seidel  <eric@webkit.org>
1080
1081         Reviewed by Adam Barth.
1082
1083         EWS Queues should remove orpahned pyc files before starting
1084         https://bugs.webkit.org/show_bug.cgi?id=50904
1085
1086         A previous check added a platform.py which caused
1087         EWS bots on some platforms to hit an import exception.
1088         The platform.py file was removed in a subsequent commit, but
1089         the EWS bots in question stayed stuck.  This change will
1090         fix those bots once restarted (and prevent this in the future).
1091
1092         I also went ahead and unified start-queue and start-commit-queue
1093         since they were nearly identical.  I also added bot_id support
1094         to both force all EWSes to have bot ids as well as get rid of the one
1095         remaining reason why I had my own copies of these scripts.
1096         Hopefully this will be enough to get all the other bot admins
1097         (ahem, Adam, ahem) to move to using these checked in copies as well.
1098
1099         * EWSTools/start-commit-queue.sh: Removed.
1100         * EWSTools/start-queue.sh:
1101
1102 2010-10-28  MORITA Hajime  <morrita@google.com>
1103
1104         Reviewed by Ojan Vafai.
1105
1106         spellcheck does not check pasted text
1107         https://bugs.webkit.org/show_bug.cgi?id=40092
1108
1109         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1110         to control the setting.
1111
1112         * DumpRenderTree/LayoutTestController.cpp:
1113         (setAsynchronousSpellCheckingEnabledCallback):
1114         (LayoutTestController::staticFunctions):
1115         * DumpRenderTree/LayoutTestController.h:
1116         * DumpRenderTree/chromium/LayoutTestController.h:
1117         * DumpRenderTree/chromium/LayoutTestController.cpp:
1118         (LayoutTestController::LayoutTestController):
1119         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1120         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1121         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1122         * DumpRenderTree/mac/DumpRenderTree.mm:
1123         (resetDefaultsToConsistentValues):
1124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1125         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1126         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1128         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1129         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1130         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1131         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1132         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1133
1134 2010-12-12  Sam Weinig  <sam@webkit.org>
1135
1136         Reviewed by Anders Carlsson.
1137
1138         Fix failing API test. It turns out that a pop-state event
1139         is sent before every fragment navigation, so we have to test
1140         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1141
1142         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1143         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1144
1145 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1146
1147         Reviewed by Eric Seidel.
1148
1149         [GTK] Add new-run-webkit-tests support to gtk
1150         https://bugs.webkit.org/show_bug.cgi?id=50681
1151
1152         Adding the basic support to run the new-run-webkit-tests.
1153
1154         * Scripts/webkitpy/layout_tests/port/gtk.py:
1155
1156 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1157
1158         Reviewed by Kenneth Rohde Christiansen.
1159
1160         [Qt] Mock DeviceOrientation client for DRT
1161         https://bugs.webkit.org/show_bug.cgi?id=47490
1162
1163         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1164         (WebCore::DumpRenderTree::DumpRenderTree):
1165         (WebCore::DumpRenderTree::~DumpRenderTree):
1166         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1167         (LayoutTestController::setMockDeviceOrientation):
1168
1169 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1170
1171         Reviewed by Gustavo Noronha Silva.
1172
1173         [GTK] launcher: disable the Mozilla-style fullscreen API
1174         https://bugs.webkit.org/show_bug.cgi?id=50874
1175
1176         Disabling the fullscreen API until its implementation for GTK is
1177         mature enough. The webview setting for it is already FALSE by
1178         default.
1179
1180         * GtkLauncher/main.c:
1181         (createWindow):
1182
1183 2010-12-10  Eric Seidel  <eric@webkit.org>
1184
1185         Reviewed by Adam Barth.
1186
1187         commit-queue flaky test messages show cryptic version information for mac os x
1188         https://bugs.webkit.org/show_bug.cgi?id=50864
1189
1190         Turns out platform.platform() returns kernel version information
1191         which isn't helpful, and just plain confusing on Mac
1192         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1193
1194         So I've updated PlatformInfo.display_name() to special case
1195         mac.  I also found a bad use of sys.platform in the process
1196         and fixed that.  (sys.platform always returns 'darwin' on mac).
1197
1198         * Scripts/webkitpy/common/system/platforminfo.py:
1199         * Scripts/webkitpy/common/system/user.py:
1200         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1201         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1202         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1203
1204 2010-12-10  Eric Seidel  <eric@webkit.org>
1205
1206         Unreviewed.
1207
1208         Exception seen while reporting flaky test with commit-queue.
1209         Just a missing include.
1210
1211         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1212         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1213
1214 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1215
1216         Reviewed by Eric Seidel.
1217
1218         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1219         https://bugs.webkit.org/show_bug.cgi?id=50796
1220
1221         Also updating the test code to use JSONResultsGeneratorBase and
1222         to improve test coverage for incremental cases.
1223
1224         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1225         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1226
1227 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1228
1229         Reviewed by Darin Adler.
1230
1231         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1232         https://bugs.webkit.org/show_bug.cgi?id=50835
1233
1234         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1235
1236 2010-12-10  Eric Seidel  <eric@webkit.org>
1237
1238         Reviewed by Adam Barth.
1239
1240         Bugs created by the commit-queue should all block on a master bug
1241         https://bugs.webkit.org/show_bug.cgi?id=50857
1242
1243         This makes all bugs created by the commit-queue block on:
1244         https://bugs.webkit.org/show_bug.cgi?id=50856
1245
1246         In the process of testing this, I found that the existing
1247         create_bug code was wrong.  I also found that existing
1248         unit tests for create-rollout used invalid values
1249         for options.blocks.  I fixed both issues and tested.
1250
1251         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1252         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1253         * Scripts/webkitpy/tool/commands/commandtest.py:
1254         * Scripts/webkitpy/tool/commands/download_unittest.py:
1255         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1256         * Scripts/webkitpy/tool/mocktool.py:
1257         * Scripts/webkitpy/tool/steps/options.py:
1258
1259 2010-12-10  Eric Seidel  <eric@webkit.org>
1260
1261         Reviewed by Adam Barth.
1262
1263         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1264         https://bugs.webkit.org/show_bug.cgi?id=50853
1265
1266         I also discovered when doing this that the code was posting
1267         the comment on the wrong bug, but that's fixed here too.
1268
1269         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1270         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1271         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1272         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1273         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1274         * Scripts/webkitpy/tool/mocktool.py:
1275
1276 2010-12-10  Anders Carlsson  <andersca@apple.com>
1277
1278         Reviewed by John Sullivan.
1279
1280         Make WKContextGetStatistics gather global statistics
1281         https://bugs.webkit.org/show_bug.cgi?id=50850
1282
1283         Remove the code that gets the statistics and fills in the per context
1284         statistics information for now.
1285
1286         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1287         (-[BrowserStatisticsWindowController refreshStatistics:]):
1288
1289 2010-12-10  Eric Seidel  <eric@webkit.org>
1290
1291         Unreviewed.
1292
1293         commit-queue should report port/platform information when commenting on flaky test bugs
1294         https://bugs.webkit.org/show_bug.cgi?id=50839
1295
1296         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1297         which was only used by new run webkit tests (and clearly not unit tested).
1298
1299         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1300         * Scripts/webkitpy/tool/main.py:
1301         * Scripts/webkitpy/tool/mocktool.py:
1302
1303 2010-12-10  Eric Seidel  <eric@webkit.org>
1304
1305         Reviewed by Tony Chang.
1306
1307         commit-queue should report port/platform information when commenting on flaky test bugs
1308         https://bugs.webkit.org/show_bug.cgi?id=50839
1309
1310         This was a suggestion from Tony Chang this morning.
1311         I added a platform.py class so I could easily mock the platform call,
1312         but that may not be the final solution for this mocking.
1313         We'll try it and see.
1314
1315         * Scripts/webkitpy/common/system/platform.py: Added.
1316         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1317         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1318         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1319         * Scripts/webkitpy/tool/main.py:
1320         * Scripts/webkitpy/tool/mocktool.py:
1321
1322 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1323
1324         Reviewed by Joseph Pecoraro.
1325
1326         Bug 43455 - [Qt]: Implement Application Cache Quotas
1327         https://bugs.webkit.org/show_bug.cgi?id=43455
1328
1329         Introduce functions to allow new appcache layout test origin-quota.html
1330         to work correctly under Qt.
1331
1332         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1333         (WebCore::DumpRenderTree::DumpRenderTree):
1334         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1335         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1336
1337         Introduce functions to allow new appcache layout test origin-quota.html
1338         to be successful under qt. Changes required because LayoutTestControllerQt
1339         does not inherit from LayoutController.
1340
1341         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1342         (LayoutTestController::reset):
1343         (LayoutTestController::clearAllApplicationCaches):
1344         (LayoutTestController::setApplicationCacheOriginQuota):
1345         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1346         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1347         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1348
1349 2010-12-10  Eric Seidel  <eric@webkit.org>
1350
1351         Reviewed by Adam Barth.
1352
1353         Move buildbot.py into its own module so we can split it out into one-file-per-class
1354         https://bugs.webkit.org/show_bug.cgi?id=50806
1355
1356         We're adding more buildbot logic these days, so it makes sense
1357         to give buildbot its own module.
1358
1359         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1360         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1361         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1362         * Scripts/webkitpy/common/net/failuremap.py:
1363         * Scripts/webkitpy/common/net/regressionwindow.py:
1364         * Scripts/webkitpy/tool/commands/rebaseline.py:
1365
1366 2010-12-10  Tony Chang  <tony@chromium.org>
1367
1368         Reviewed by Eric Seidel.
1369
1370         Use FileSystem::remove when cleaning up http lock files
1371         https://bugs.webkit.org/show_bug.cgi?id=50830
1372
1373         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1374
1375 2010-12-10  Joone Hur  <joone@kldp.org>
1376
1377         Reviewed by Martin Robinson.
1378
1379         [GTK] DRT needs layoutTestController.setCacheModel
1380         https://bugs.webkit.org/show_bug.cgi?id=50705
1381
1382         webkit_set_cache_mode() is called to set the cache model.
1383
1384         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1385         (LayoutTestController::setCacheModel): Set the cache model.
1386
1387 2010-12-10  Tony Chang  <tony@chromium.org>
1388
1389         Reviewed by Ojan Vafai.
1390
1391         [chromium] remove --use-drt and add --use-test-shell
1392         https://bugs.webkit.org/show_bug.cgi?id=50701
1393
1394         * Scripts/webkitpy/common/config/ports.py:
1395         * Scripts/webkitpy/common/config/ports_unittest.py:
1396         * Scripts/webkitpy/layout_tests/port/chromium.py:
1397         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1398         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1399         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1400         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1401         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1402         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1403         * Scripts/webkitpy/layout_tests/port/webkit.py:
1404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1405         * Scripts/webkitpy/style/checkers/test_expectations.py:
1406         * Scripts/webkitpy/tool/commands/queries.py:
1407
1408 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1409
1410         Reviewed by Steve Block.
1411
1412         [Chromium] Implement mocks for client-based geolocation
1413         https://bugs.webkit.org/show_bug.cgi?id=46895
1414
1415         * DumpRenderTree/chromium/LayoutTestController.cpp:
1416         (LayoutTestController::setGeolocationPermission):
1417         (LayoutTestController::setMockGeolocationPosition):
1418         (LayoutTestController::setMockGeolocationError):
1419         * DumpRenderTree/chromium/LayoutTestController.h:
1420         * DumpRenderTree/chromium/WebViewHost.cpp:
1421         (WebViewHost::geolocationClient):
1422         (WebViewHost::geolocationClientMock):
1423         (WebViewHost::reset):
1424         * DumpRenderTree/chromium/WebViewHost.h:
1425
1426 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1427
1428         Reviewed by Martin Robinson.
1429
1430         [GTK] Add hasSpellingMarker support to the DRT
1431         https://bugs.webkit.org/show_bug.cgi?id=50739
1432
1433         Implemented the hasSpellingMarker to support spelling tests.
1434
1435         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1436         (LayoutTestController::hasSpellingMarker):
1437
1438 2010-12-10  Eric Seidel  <eric@webkit.org>
1439
1440         Reviewed by Ojan Vafai.
1441
1442         webkit-patch: not possible to use build-and-test with local commits
1443         https://bugs.webkit.org/show_bug.cgi?id=33378
1444
1445         Make --no-clean not even check if we have local commits.
1446         It's unclear to me why the code was originally written this way.
1447         I was unable to dig up a reason from svn history.
1448
1449         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1450         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1451
1452 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1453
1454         Reviewed by Martin Robinson.
1455
1456         [GTK] AX: implement isEnabled in DRT
1457         https://bugs.webkit.org/show_bug.cgi?id=50814
1458
1459         Implement AccessibilityUIElement::isEnabled() for GTK.
1460
1461         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1462         (checkElementState): New function to refactor common code.
1463         (AccessibilityUIElement::isEnabled): Implement this by checking
1464         the current state of the AtkObject.
1465         (AccessibilityUIElement::isSelected): Use the new
1466         checkElementState function.
1467
1468 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1469
1470         Reviewed by Kenneth Rohde Christiansen.
1471
1472         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1473         https://bugs.webkit.org/show_bug.cgi?id=50750
1474
1475         * MiniBrowser/qt/BrowserView.cpp:
1476         (BrowserView::BrowserView):
1477         * MiniBrowser/qt/BrowserView.h:
1478         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1479         (WTR::WebView::WebView):
1480
1481 2010-12-10  Joone Hur  <joone@kldp.org>
1482
1483         Reviewed by Xan Lopez.
1484
1485         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1486         https://bugs.webkit.org/show_bug.cgi?id=50808
1487
1488         Unskipping the following test cases:
1489         userscripts/mixed-case-stylesheet.html
1490         userscripts/simple-stylesheet.html
1491         userscripts/user-style-all-frames.html
1492
1493         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1494         (LayoutTestController::addUserStyleSheet):
1495
1496 2010-12-10  Joone Hur  <joone@kldp.org>
1497
1498         Reviewed by Eric Seidel.
1499
1500         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1501         https://bugs.webkit.org/show_bug.cgi?id=50783
1502
1503         This patch allows to unskip the following test cases:
1504         printing/page-rule-selection.html
1505         printing/page-format-data.html
1506
1507         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1508         (LayoutTestController::pageProperty): Added.
1509         (LayoutTestController::isPageBoxVisible): Ditto.
1510         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1511         (LayoutTestController::addUserStyleSheet): Ditto.
1512
1513 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1514
1515         Reviewed by Kenneth Rohde Christiansen.
1516
1517         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1518
1519         A menu allows to switch QNAM back to the same thread.
1520
1521         * QtTestBrowser/launcherwindow.cpp:
1522         (LauncherWindow::initializeView):
1523         (LauncherWindow::createChrome):
1524         (LauncherWindow::toggleThreadedQnam):
1525         * QtTestBrowser/launcherwindow.h:
1526         (WindowOptions::WindowOptions):
1527         * QtTestBrowser/webpage.cpp:
1528         (WebPage::WebPage):
1529         (WebPage::setQnamThreaded):
1530         * QtTestBrowser/webpage.h:
1531         (QnamThread::QnamThread):
1532         (QnamThread::~QnamThread):
1533         (QnamThread::networkAccessManager):
1534         (QnamThread::run):
1535
1536 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1537
1538         Reviewed by Xan Lopez.
1539
1540         [Gtk] style="font-family: courier" makes text disappear
1541         https://bugs.webkit.org/show_bug.cgi?id=47452
1542
1543         Add a test that verifies that fonts without valid charmaps are
1544         never selected.
1545
1546         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1547         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1548         that has no valid charmap.
1549         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1550         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1551         settings which may disable selection of bitmap fonts.
1552
1553 2010-12-10  Eric Seidel  <eric@webkit.org>
1554
1555         Unreviewed.
1556
1557         The commit-queue should file bugs about flaky tests it encounters
1558         https://bugs.webkit.org/show_bug.cgi?id=50803
1559
1560         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1561         Now it's tested.
1562
1563         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1564         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1565
1566 2010-12-10  Eric Seidel  <eric@webkit.org>
1567
1568         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1569
1570         The commit-queue should file bugs about flaky tests it encounters
1571         https://bugs.webkit.org/show_bug.cgi?id=50803
1572
1573         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1574
1575 2010-12-09  Eric Seidel  <eric@webkit.org>
1576
1577         Reviewed by Adam Barth.
1578
1579         The commit-queue should file bugs about flaky tests it encounters
1580         https://bugs.webkit.org/show_bug.cgi?id=50803
1581
1582         This change got a bit big.  I also added a new config.urls file
1583         because I needed to share the view_source_url code with committervalidator.py.
1584
1585         This adds a new class FlakyTestReporter which holds all the logic about
1586         reporting flaky tests to bugzilla.
1587
1588         Right now this code knows how to look up bugs for flaky tests.
1589         If it can't find a bug filed from the commit-queue, it will open a new
1590         one, ccing the relevant people and adding information about the failure.
1591
1592         It is not yet smart enough to chase down duplicate chains, or to include
1593         the actual failure diff.  But those can be added in later iterations.
1594
1595         * Scripts/webkitpy/common/checkout/api.py:
1596         * Scripts/webkitpy/common/checkout/changelog.py:
1597         * Scripts/webkitpy/common/checkout/commitinfo.py:
1598         * Scripts/webkitpy/common/config/committervalidator.py:
1599         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1600         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1601         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1602         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1603         * Scripts/webkitpy/tool/bot/irc_command.py:
1604         * Scripts/webkitpy/tool/bot/sheriff.py:
1605         * Scripts/webkitpy/tool/commands/download.py:
1606         * Scripts/webkitpy/tool/commands/queues.py:
1607         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1608         * Scripts/webkitpy/tool/comments.py:
1609         * Scripts/webkitpy/tool/mocktool.py:
1610         * Scripts/webkitpy/tool/steps/commit.py:
1611
1612 2010-12-09  Eric Seidel  <eric@webkit.org>
1613
1614         Reviewed by Adam Barth.
1615
1616         Teach webkit-patch how to search bugzilla
1617         https://bugs.webkit.org/show_bug.cgi?id=50500
1618
1619         This is a step towards teaching webkitpy how to file
1620         new bugs for flaky tests and update them when new flakes occur.
1621
1622         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1623         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1624         * Scripts/webkitpy/tool/commands/__init__.py:
1625         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1626
1627 2010-12-09  Adam Barth  <abarth@webkit.org>
1628
1629         Reviewed by Ojan Vafai.
1630
1631         commit-queue errors out due to local commits
1632         https://bugs.webkit.org/show_bug.cgi?id=50766
1633
1634         We seem to be tripping over having local commits in the working copy a
1635         lot recently.  I don't quite fully understand what the issue is, but
1636         this patch attempts to solve the problem by adding an explicit clean
1637         step before processing a patch.  Previously, we did the cleaning as
1638         part of the apply-attachment step, so this might not actually fix the
1639         problem.
1640
1641         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1642         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1643         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1644
1645 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1646
1647         Reviewed by Ojan Vafai.
1648
1649         Make new-run-webkit-tests --lint-test-files log slightly better
1650         messages and return -1 if lint fails. Remove the
1651         'suppress_errors' keyword param to the TestExpectationsFile
1652         class, and clean up logging and exception raising for error
1653         handling. Also add more unit tests and clean up the unit test code a bit.
1654
1655         https://bugs.webkit.org/show_bug.cgi?id=50205
1656
1657         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1658         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1659         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1660         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1661         * Scripts/webkitpy/layout_tests/port/chromium.py:
1662         * Scripts/webkitpy/style/checkers/test_expectations.py:
1663         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1664
1665 2010-12-09  Tony Chang  <tony@chromium.org>
1666
1667         Unreviewed, fix for windows code.  We were catching the wrong
1668         exception in Windows.
1669
1670         * Scripts/webkitpy/common/system/filesystem.py:
1671
1672 2010-12-09  Antonio Gomes  <agomes@rim.com>
1673
1674         Reviewed by Martin Robinson.
1675
1676         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1677         https://bugs.webkit.org/show_bug.cgi?id=48429
1678
1679         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1680
1681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1682         (LayoutTestController::workerThreadCount):
1683
1684 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1685
1686         Reviewed by Martin Robinson.
1687
1688         [GTK] Support the Mozilla-style Fullscreen Javascript API
1689         https://bugs.webkit.org/show_bug.cgi?id=50572
1690
1691         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1692         make DRT update the Chrome when the WebView settings have been
1693         reset to consistent values.
1694
1695         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1696         (resetDefaultsToConsistentValues):
1697         * GtkLauncher/main.c:
1698         (create_window):
1699         * Scripts/build-webkit:
1700
1701 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1702
1703         Reviewed by Tor Arne Vestbø
1704
1705         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1706         https://bugs.webkit.org/show_bug.cgi?id=50742
1707
1708         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1709
1710         * Scripts/webkitdirs.pm:
1711
1712 2010-12-09  Joone Hur  <joone@kldp.org>
1713
1714          Reviewed by Martin Robinson.
1715
1716          [GTK] Support for viewport meta tag
1717          https://bugs.webkit.org/show_bug.cgi?id=45443
1718
1719          Add support for testing the viewport properties for WebKitGtk.
1720
1721          * DumpRenderTree/LayoutTestController.cpp:
1722          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1723          (LayoutTestController::staticFunctions):
1724          * DumpRenderTree/LayoutTestController.h:
1725          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1726          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1727          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1728          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1729          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1730          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1731          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1732          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1733          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1734          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1735
1736 2010-12-08  William Siegrist <wsiegrist@apple.com>
1737
1738         Reviewed by Eric Seidel.
1739
1740         Migrate buildbot.py from xmlrpc to json.
1741         https://bugs.webkit.org/show_bug.cgi?id=50647
1742
1743         * Scripts/webkitpy/common/net/buildbot.py:
1744
1745 2010-12-08  Tony Chang  <tony@chromium.org>
1746
1747         Reviewed by Eric Seidel.
1748
1749         make starting the websocket server more reliable on windows
1750         https://bugs.webkit.org/show_bug.cgi?id=50712
1751
1752         * Scripts/webkitpy/common/system/filesystem.py:
1753         (remove): Substitute method for os.remove to retry on error on Windows
1754         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1755         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1756
1757 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1758
1759         Reviewed by Adam Roben.
1760
1761         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1762         https://bugs.webkit.org/show_bug.cgi?id=50656
1763
1764         * MiniBrowser/mac/BrowserWindowController.m:
1765         (-[BrowserWindowController awakeFromNib]):
1766         Indicate that exceededDatabaseQuota is not implemented.
1767         * MiniBrowser/win/BrowserView.cpp:
1768         (BrowserView::create):
1769         Ditto.
1770         * WebKitTestRunner/TestController.cpp:
1771         (WTR::createOtherPage):
1772         Ditto.
1773         (WTR::TestController::initialize):
1774         Ditto.
1775
1776 2010-12-08  Antonio Gomes  <agomes@rim.com>
1777
1778         Reviewed by Martin Robinson.
1779
1780         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1781         https://bugs.webkit.org/show_bug.cgi?id=48429
1782
1783         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1784         * webkit_gc_collect_javascript_objects;
1785         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1786         * webkit_gc_count_javascript_objects;
1787         * webkit_web_frame_layout.
1788
1789         These were all only used by GTK+ DRT.
1790
1791         * DumpRenderTree/gtk/EventSender.cpp:
1792         (dispatchEvent):
1793         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1794         (GCController::collect):
1795         (GCController::collectOnAlternateThread):
1796         (GCController::getJSObjectCount):
1797
1798 2010-12-07  Tony Chang  <tony@chromium.org>
1799
1800         Reviewed by Ojan Vafai.
1801
1802         [chromium] force NRWT to use DRT
1803         https://bugs.webkit.org/show_bug.cgi?id=50359
1804
1805         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1806
1807 2010-12-06  Sam Weinig  <sam@webkit.org>
1808
1809         Reviewed by Anders Carlsson.
1810
1811         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1812         https://bugs.webkit.org/show_bug.cgi?id=50584
1813
1814         * MiniBrowser/mac/BrowserWindowController.m:
1815         (didSameDocumentNavigationForFrame):
1816         (-[BrowserWindowController awakeFromNib]):
1817         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1818         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1819         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1820         (TestWebKitAPI::TEST):
1821         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1822         (WTR::InjectedBundlePage::InjectedBundlePage):
1823         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1824         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::initialize):
1827
1828 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1829
1830         Reviewed by Ojan Vafai.
1831
1832         Make TestResultsServer return 404 for non-existing results files.
1833         https://bugs.webkit.org/show_bug.cgi?id=50581
1834
1835         * TestResultServer/handlers/testfilehandler.py:
1836
1837 2010-12-06  Tony Chang  <tony@chromium.org>
1838
1839         Reviewed by Ojan Vafai.
1840
1841         [chromium] fix an assert hit in DRT
1842         https://bugs.webkit.org/show_bug.cgi?id=50575
1843
1844         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1845         semantics.
1846
1847         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1848         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1849         WTF::RefCountedBase::ref()).
1850
1851         * DumpRenderTree/chromium/TestWebWorker.h:
1852         (TestWebWorker::TestWebWorker):
1853
1854 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1855
1856         Reviewed by Eric Seidel.
1857
1858         make webkit-patch command work when the git branch is not synced to the remote svn branch
1859         https://bugs.webkit.org/show_bug.cgi?id=50424
1860
1861         * Scripts/webkitpy/common/checkout/scm.py:
1862         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1863
1864 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1865
1866         Reviewed by Andreas Kling.
1867
1868         [WINCE] Add build system
1869         https://bugs.webkit.org/show_bug.cgi?id=50522
1870
1871         * CMakeListsWinCE.txt: Added.
1872
1873 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1874
1875         Reviewed by Tony Chang.
1876
1877         Allow the Chromium port to have Leopard-specific baselines
1878         https://bugs.webkit.org/show_bug.cgi?id=50506
1879
1880         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1881
1882 2010-12-03  Tony Chang  <tony@chromium.org>
1883
1884         Reviewed by Kent Tamura.
1885
1886         [chromium] fix 2 bugs with inspector tests in DRT
1887         https://bugs.webkit.org/show_bug.cgi?id=50492
1888
1889         Tasks can outlive the tasklist (even when canceled) so this was
1890         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1891         when a task is canceled.
1892
1893         Also fix an assert when closing devtool windows by copying some
1894         logic from test_shell.
1895
1896         * DumpRenderTree/chromium/Task.cpp:
1897         (WebTask::~WebTask):
1898         (TaskList::revokeAll):
1899         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1900             the tasklist (since the task can outlive the tasklist).
1901         * DumpRenderTree/chromium/TestShell.h:
1902         (TestShell::devToolsWebView):
1903         * DumpRenderTree/chromium/WebViewHost.cpp:
1904         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1905             a window if the window has devtools loaded.  This avoids an
1906             ASSERT and matches test_shell.
1907
1908 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1909
1910         Reviewed by Martin Robinson.
1911
1912         [GTK] Fix GtkLauncher.c style, use webkit style
1913         https://bugs.webkit.org/show_bug.cgi?id=50542
1914
1915         * GtkLauncher/main.c:
1916         (activateUriEntryCb):
1917         (updateTitle):
1918         (linkHoverCb):
1919         (notifyTitleCb):
1920         (notifyLoadStatusCb):
1921         (notifyProgressCb):
1922         (destroyCb):
1923         (goBackCb):
1924         (goForwardCb):
1925         (create_webViewCb):
1926         (webViewReadyCb):
1927         (closeWebViewCb):
1928         (createBrowser):
1929         (createStatusbar):
1930         (createToolbar):
1931         (createWindow):
1932         (main):
1933
1934 2010-12-04  Antonio Gomes  <agomes@rim.com>
1935
1936         Reviewed by Martin Robinson.
1937
1938         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1939         https://bugs.webkit.org/show_bug.cgi?id=48429
1940
1941         Moved more private method declared with WEBKIT_API to
1942         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1943
1944         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1945         (resetDefaultsToConsistentValues):
1946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1947         (LayoutTestController::addOriginAccessWhitelistEntry):
1948         (LayoutTestController::execCommand):
1949         (LayoutTestController::isCommandEnabled):
1950
1951 2010-12-04  Antonio Gomes  <agomes@rim.com>
1952
1953         Reviewed by Andreas Kling.
1954
1955         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1956
1957         Method was removed by http://trac.webkit.org/changeset/71604
1958
1959         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1960
1961 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1962
1963         Reviewed by Xan Lopez.
1964
1965         [GTK] Fix compilation warnings reported by clang
1966         https://bugs.webkit.org/show_bug.cgi?id=50252
1967
1968         * GtkLauncher/main.c:
1969         (create_window): The create_statusbar function does not have
1970         parameters.
1971
1972 2010-12-05  Robert Hogan  <robert@webkit.org>
1973
1974         Reviewed by Andreas Kling.
1975
1976         [Qt] Zero-sized font does not yet work
1977
1978         Fix fast/text/font-size-zero.html
1979
1980         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1981
1982         https://bugs.webkit.org/show_bug.cgi?id=49759
1983
1984         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1985         (WebCore::WebPage::WebPage):
1986
1987 2010-12-04  Sam Weinig  <sam@webkit.org>
1988
1989         Reviewed by Jon Honeycutt.
1990
1991         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1992         https://bugs.webkit.org/show_bug.cgi?id=50511
1993
1994         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1995         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1996
1997         * MiniBrowser/mac/BrowserWindowController.m:
1998         (didChangeLocationWithinPageForFrame):
1999         (-[BrowserWindowController awakeFromNib]):
2000         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2001         * TestWebKitAPI/PlatformUtilities.cpp:
2002         (TestWebKitAPI::Util::toWK):
2003         * TestWebKitAPI/PlatformUtilities.h:
2004         (TestWebKitAPI::Util::adoptWK):
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2007         (TestWebKitAPI::nullJavaScriptCallback):
2008         (TestWebKitAPI::didFinishLoadForFrame):
2009         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2010         (TestWebKitAPI::TEST):
2011         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2012         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2013         * TestWebKitAPI/win/copy-resources.cmd:
2014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2015         (WTR::InjectedBundlePage::InjectedBundlePage):
2016         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2017         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2018         * WebKitTestRunner/TestController.cpp:
2019         (WTR::TestController::initialize):
2020
2021 2010-11-08  Antonio Gomes  <agomes@rim.com>
2022
2023         Reviewed by Martin Robinson.
2024
2025         [Gtk] Populate DumpRenderTreeSupportGtk
2026         https://bugs.webkit.org/show_bug.cgi?id=48429
2027
2028         Made the previous calls to webkit_web_frame* functions defined as private
2029         APIs in webkitprivate.h go through DRTSupportGtk.
2030
2031         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2032         (AccessibilityController::focusedElement):
2033         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2034         (dumpFramesAsText):
2035         (resetDefaultsToConsistentValues):
2036         (dump):
2037         (webViewDocumentLoadFinished):
2038         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2039         (LayoutTestController::counterValueForElementById):
2040         (LayoutTestController::pageNumberForElementById):
2041         (LayoutTestController::numberOfPages):
2042         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2043         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2044         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2045         (LayoutTestController::numberOfActiveAnimations):
2046         (LayoutTestController::suspendAnimations):
2047         (LayoutTestController::resumeAnimations):
2048         (LayoutTestController::markerTextForListItem):
2049
2050 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2051
2052         Reviewed by Tony Chang.
2053
2054         Rebaseline server: use pretty text diff output
2055         https://bugs.webkit.org/show_bug.cgi?id=50484
2056
2057         Serve *-pretty-diff.html for text diff output.
2058
2059         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2060         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2061         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2062         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2063
2064 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2065
2066         Unreviewed, rolling out r73302.
2067         http://trac.webkit.org/changeset/73302
2068         https://bugs.webkit.org/show_bug.cgi?id=50499
2069
2070         Causes crashes in debug LayoutTests (Requested by xan_ on
2071         #webkit).
2072
2073         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2074         (AccessibilityUIElement::AccessibilityUIElement):
2075         (AccessibilityUIElement::parentElementCallback):
2076         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2077         * DumpRenderTree/chromium/CppBoundClass.cpp:
2078         * DumpRenderTree/chromium/CppBoundClass.h:
2079
2080 2010-12-03  Sam Weinig  <sam@webkit.org>
2081
2082         Reviewed by Maciej Stachowiak.
2083
2084         Enable <a ping> for Mac/Windows/WebKit2 builds
2085         <rdar://problem/8504473>
2086         https://bugs.webkit.org/show_bug.cgi?id=50488
2087
2088         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2089         (TestWebKitAPI::TEST): Test that the default value of
2090         WKPreferencesGetHyperlinkAuditingEnabled is true.
2091
2092 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2093
2094         Reviewed by Chris Fleizach.
2095
2096         Include the FrameView widget of a RenderWidget in the accessibility tree.
2097         https://bugs.webkit.org/show_bug.cgi?id=49106
2098
2099         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2100         (AccessibilityUIElement::AccessibilityUIElement):
2101         (AccessibilityUIElement::parentElementCallback):
2102         (AccessibilityUIElement::isEqualCallback):
2103         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2104         * DumpRenderTree/chromium/CppBoundClass.cpp:
2105         (CppBoundClass::getFromCppVariant):
2106         * DumpRenderTree/chromium/CppBoundClass.h:
2107
2108 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2109
2110         Reviewed by Tony Chang.
2111
2112         Rebaseline server: organize tests by state, add dry run mode
2113         https://bugs.webkit.org/show_bug.cgi?id=50473
2114
2115         Group tests in the menu by state, so that it's easier to see after
2116         processing the queue which failed.
2117
2118         Add support for the --dry-run flag so that it's easier to test changes
2119         such as this (stubs out filesystem and SCM operations).
2120
2121         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2122         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2123         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2124
2125 2010-12-03  Brady Eidson  <beidson@apple.com>
2126
2127         Reviewed by Anders Carlsson.
2128
2129         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2130         WebKit2 Authentication Support
2131
2132         Keep these builds working:
2133         * MiniBrowser/mac/BrowserWindowController.m:
2134         (-[BrowserWindowController awakeFromNib]):
2135
2136         * WebKitTestRunner/TestController.cpp:
2137         (WTR::TestController::initialize):
2138
2139 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2140
2141         Reviewed by Tony Chang.
2142
2143         Rebaseline server: move existing baselines
2144         https://bugs.webkit.org/show_bug.cgi?id=50421
2145
2146         Implement moving of existing baselines: move all files that are about
2147         to be overwriten by update baselines.
2148
2149         Also fix a typo in the UI JS.
2150
2151         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2152         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2153         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2154
2155 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2156
2157         Unreviewed, rolling out r73211.
2158         http://trac.webkit.org/changeset/73211
2159         https://bugs.webkit.org/show_bug.cgi?id=50450
2160
2161         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2162         yutak on #webkit).
2163
2164         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2165
2166 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2167
2168         Unreviewed, rolling out r73222.
2169         http://trac.webkit.org/changeset/73222
2170         https://bugs.webkit.org/show_bug.cgi?id=50449
2171
2172         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2173         (Requested by yutak on #webkit).
2174
2175         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2176         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2177         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2178         * Scripts/webkitpy/layout_tests/port/base.py:
2179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2180         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2181
2182 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2183
2184         Unreviewed, rolling out r73228.
2185         http://trac.webkit.org/changeset/73228
2186         https://bugs.webkit.org/show_bug.cgi?id=50448
2187
2188         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2189         (Requested by yutak on #webkit).
2190
2191         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2192         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2193         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2194         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2195         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2196
2197 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2198
2199         Unreviewed, rolling out r73231.
2200         http://trac.webkit.org/changeset/73231
2201         https://bugs.webkit.org/show_bug.cgi?id=50443
2202
2203         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2204         (Requested by yutak on #webkit).
2205
2206         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2207         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2208         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2209         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2210
2211 2010-12-03  David Levin  <levin@chromium.org>
2212
2213         Reviewed by Shinichiro Hamaji.
2214
2215         check-webkit-style: false positive reported for #if macro
2216         https://bugs.webkit.org/show_bug.cgi?id=48242
2217
2218         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2219           all preprocessor commands.
2220         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2221
2222 2010-12-02  Eric Seidel  <eric@webkit.org>
2223
2224         Reviewed by Adam Barth.
2225
2226         Update the EWSTools scripts to use modern-style git repos
2227         https://bugs.webkit.org/show_bug.cgi?id=50402
2228
2229         * EWSTools/create-webkit-git:
2230         * EWSTools/start-commit-queue.sh:
2231         * EWSTools/start-queue.sh:
2232
2233 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2234
2235         Fix Chromium Linux plugin tests by not logging
2236         unconditionally from the event handling code.
2237
2238         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2239         (handleEventX11):
2240
2241 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2242
2243         Reviewed by Tony Chang.
2244
2245         nrwt multiprocessing - move logic back into run_webkit_tests
2246
2247         This change moves a bunch of logic that I had put into
2248         message_broker back into run_webkit_tests, in a slightly
2249         different format. WorkerMessageBroker needed to become less aware of
2250         the logic the TestRunner class uses, and more generic.
2251         Eventually the MessageBroker will only do generic messaging and
2252         thread/process-pooling, and (almost) all of the
2253         run-webkit-tests-specific logic will be moved to
2254         run_webkit_tests.py and dump_render_tree_thread.py.
2255
2256         The biggest changes are that the Broker can now start a single
2257         worker, but the responsibility for starting all of them is pushed
2258         back to the TestRunner (Manager), and the logic for checking if
2259         the threads are done or wedged is moved back to TestRunner. We
2260         also remove WorkerMessageBroker.cleanup (not needed) and
2261         cancel_workers (they have to be cancelled individually).
2262
2263         The  message_broker is now encapsulated inside
2264         TestRunner._run_tests(); it only needs to exist while actually
2265         running the tests.
2266
2267         Also, delete a bunch of tests in message_broker_unittest that no
2268         longer make much sense.
2269
2270         This patch depends on bug 50372.
2271
2272         https://bugs.webkit.org/show_bug.cgi?id=50374
2273
2274         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2275         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2276         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2277         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2278         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2279
2280 2010-12-02  Hayato Ito  <hayato@chromium.org>
2281
2282         Reviewed by Eric Seidel.
2283
2284         Refactor test_types's compare_output() method so that it takes a
2285         TestInput object.
2286
2287         compare_output() will need additional information included in a TestInput
2288         object to support reftests. This change is a pre-requirement of that.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=50362
2291
2292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2293         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2294         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2295         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2296         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2297
2298 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2299
2300         Reviewed by Anders Carlsson.
2301
2302         Add the ability to run script on 'new' and 'paint' in the test plugin
2303         https://bugs.webkit.org/show_bug.cgi?id=50425
2304
2305         Add "onnew" and "onpaintevent" attributes to the test plugin,
2306         so that tests can run JS at these times.
2307
2308         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2309         (pluginAllocate):
2310         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2311         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2312         (NPP_New):
2313         (NPP_Destroy):
2314         (handleEventCarbon):
2315         (handleEventCocoa):
2316         (NPP_HandleEvent):
2317
2318 2010-12-02  Sam Weinig  <sam@webkit.org>
2319
2320         Fix Qt build.
2321
2322         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2323         (WTR::PlatformWebView::PlatformWebView):
2324
2325 2010-12-02  Sam Weinig  <sam@webkit.org>
2326
2327         Reviewed by Anders Carlsson.
2328
2329         WebKit2 Preferences should be held off the PageGroup, not the Context
2330         https://bugs.webkit.org/show_bug.cgi?id=50414
2331
2332         Update for API changes.
2333
2334         * WebKitTestRunner/PlatformWebView.h:
2335         * WebKitTestRunner/TestController.cpp:
2336         (WTR::createOtherPage):
2337         (WTR::TestController::initialize):
2338         (WTR::TestController::resetStateToConsistentValues):
2339         * WebKitTestRunner/TestController.h:
2340         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2341         (WTR::PlatformWebView::PlatformWebView):
2342         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2343         (WTR::PlatformWebView::PlatformWebView):
2344
2345 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2346
2347         Reviewed by Tony Chang.
2348
2349         new-run-webkit-tests: minor cleanup for multiprocessing work
2350
2351         This change:
2352         * moves worker naming into TestShellThread, eliminating a
2353           parameter to the constructor and putting the responsibility in
2354           the correct place.
2355         * eliminates the _WorkerState() class in message_broker, because
2356           it turns out that state really needs to be in run_webkit_tests
2357         * renames the Broker classes to be module-private.
2358         * fixes a bunch of minor commenting and whitespace issues to
2359           make subsequent patches a bit clearer.
2360         * Adds a Port hook for default_worker_model() so that we can
2361           accomodate the potential for different worker models on
2362           different ports.
2363         * merge in the fix from 50420 for the brokenness introduced in
2364           bug 50367.
2365
2366         This patch depends on bug 50367.
2367
2368         https://bugs.webkit.org/show_bug.cgi?id=50372
2369
2370         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2371         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2372         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2373         * Scripts/webkitpy/layout_tests/port/base.py:
2374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2375         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2376
2377 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2378
2379         Reviewed by Tony Chang.
2380
2381         This change is a bunch of cleanup / refactoring of the file
2382         below. It moves a bunch of free functions to methods on the
2383         TestShellThread class, and restructures other methods to be
2384         closer to the structure we'll need for the multiprocessing
2385         rewrite.
2386
2387         It also makes the logic of --run-singly a *lot* easier to follow
2388         by nestling all of the separate-thread logic into a single
2389         routine.
2390
2391         There should be no semantic changes in this patch, just cleanup.
2392
2393         https://bugs.webkit.org/show_bug.cgi?id=50367
2394
2395         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2396
2397 2010-12-02  Tony Chang  <tony@chromium.org>
2398
2399         Unreviewed, rolling out r73164.
2400         http://trac.webkit.org/changeset/73164
2401         https://bugs.webkit.org/show_bug.cgi?id=50359
2402
2403         broke debugger tests on win
2404
2405         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2406
2407 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2408
2409         Reviewed by Tony Chang.
2410
2411         Rebaseline server: add updating of baselines
2412         https://bugs.webkit.org/show_bug.cgi?id=50305
2413
2414         Implements updating of baselines, where we copy -actual.* files over
2415         the current -expected.* files. To do this, we need a
2416         _get_actual_result_files method to get test results files and a
2417         _rebaseline_test method to actually do the file copy and SCM operation.
2418         _rebaseline_test logs output into a buffer, this is useful for both
2419         showing result in the UI and for unit tests.
2420
2421         To make passing around of the various test environment properties
2422         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2423         class for them.
2424
2425         Moving of existing baselines is not implemented yet, this patch is big
2426         enough as it is.
2427
2428         * Scripts/webkitpy/common/system/filesystem.py:
2429         * Scripts/webkitpy/common/system/filesystem_mock.py:
2430         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2431         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2432         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2433         * Scripts/webkitpy/tool/mocktool.py:
2434
2435 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2436
2437         Unreviewed build fix after vcproj updates.
2438
2439         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2440         that WIN_CAIRO is defined for this build.
2441         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2442         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2443         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2444
2445 2010-12-02  Sam Weinig  <sam@webkit.org>
2446
2447         Reviewed by Anders Carlsson.
2448
2449         WebKit2 needs API to turn on popup blocking
2450         https://bugs.webkit.org/show_bug.cgi?id=50407
2451
2452         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2453         (TestWebKitAPI::TEST):
2454         * WebKitTestRunner/TestController.cpp:
2455         (WTR::TestController::resetStateToConsistentValues):
2456
2457 2010-12-01  Tony Chang  <tony@chromium.org>
2458
2459         Reviewed by Ojan Vafai.
2460
2461         [chromium] force NRWT to use DRT
2462         https://bugs.webkit.org/show_bug.cgi?id=50359
2463
2464         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2465
2466 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2467
2468         Reviewed by Xan Lopez.
2469
2470         [GTK] DumpRenderTree has two copies of JavaScriptCore
2471         https://bugs.webkit.org/show_bug.cgi?id=49877
2472
2473         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2474         LDADD list for DumpRenderTree.
2475
2476 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2477
2478         Unreviewed: Added myself to list of Committers.
2479
2480         * Scripts/webkitpy/common/config/committers.py:
2481
2482 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2483
2484         Reviewed by Adam Barth.
2485
2486         build-webkit --chromium always updates DEPS and re-generates project files
2487         https://bugs.webkit.org/show_bug.cgi?id=50340
2488
2489         Make build-webkit --chromium invoke update-webkit-chromium only when
2490         --update-chromium is passed in, so that we don't add 20 seconds to all
2491         builds.
2492
2493         Making all invocations update was added with r61883, with the goal of
2494         making EWS bots always update. The bots will switch to using this flag
2495         (as will all other webkit-patch build steps) so nothing should change
2496         for them.
2497
2498         * Scripts/webkitdirs.pm:
2499         * Scripts/webkitpy/common/config/ports.py:
2500         * Scripts/webkitpy/common/config/ports_unittest.py:
2501
2502 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2503
2504         Reviewed by Tony Chang.
2505
2506         new-run-webkit-tests: add a --dry-run / -n flag
2507         https://bugs.webkit.org/show_bug.cgi?id=50045
2508
2509         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2510         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2511
2512 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2513
2514         Reviewed by Adam Roben.
2515
2516         WinCairo build should not use link-time code generation (LTCG)
2517         https://bugs.webkit.org/show_bug.cgi?id=50353
2518
2519         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2520         * DumpRenderTree/win/DumpRenderTree.vcproj:
2521         * DumpRenderTree/win/ImageDiff.vcproj:
2522         * FindSafari/FindSafari.vcproj:
2523         * MiniBrowser/MiniBrowser.vcproj:
2524         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2525         * WebKitAPITest/WebKitAPITest.vcproj:
2526         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2527         * WebKitTestRunner/win/InjectedBundle.vcproj:
2528         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2529         * WinLauncher/WinLauncher.vcproj:
2530         * record-memory-win/record-memory-win.vcproj:
2531
2532 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2533
2534         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2535         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2536         adding the file to the sources list was not enough to force the rebuild.
2537
2538         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2539         Remove an empty line at the end of this file to force a rebuild.
2540
2541 2010-12-01  Sam Weinig  <sam@webkit.org>
2542
2543         Fix windows build.
2544
2545         * MiniBrowser/win/BrowserView.cpp:
2546         (BrowserView::create):
2547
2548 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2549
2550         Add missing file to the TestNetscapePlugin sources list after r73057.
2551
2552         * GNUmakefile.am: Add missing file.
2553
2554 2010-12-01  Sam Weinig  <sam@webkit.org>
2555
2556         Reviewed by Anders Carlsson.
2557
2558         Add PageGrouping to WebKit2 API
2559         https://bugs.webkit.org/show_bug.cgi?id=50332
2560
2561         - Update testing harnesses to deal with new PageGroup API.
2562
2563         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2564         (WKBundleInitialize):
2565         * TestWebKitAPI/InjectedBundleController.cpp:
2566         (TestWebKitAPI::InjectedBundleController::initialize):
2567         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2568         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2569         * TestWebKitAPI/InjectedBundleController.h:
2570         * TestWebKitAPI/InjectedBundleTest.h:
2571         (TestWebKitAPI::InjectedBundleTest::initialize):
2572         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2573         * TestWebKitAPI/PlatformUtilities.cpp:
2574         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2575         * TestWebKitAPI/PlatformUtilities.h:
2576         * TestWebKitAPI/PlatformWebView.h:
2577         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2578         (TestWebKitAPI::TEST):
2579         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2580         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2581         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2582         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2583         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2584         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2586         (WTR::InjectedBundle::didInitializePageGroup):
2587         (WTR::InjectedBundle::initialize):
2588         (WTR::InjectedBundle::beginTesting):
2589         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2590         (WTR::InjectedBundle::pageGroup):
2591         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2592         (WTR::LayoutTestController::addUserScript):
2593         (WTR::LayoutTestController::addUserStyleSheet):
2594         (WTR::LayoutTestController::setXSSAuditorEnabled):
2595         * WebKitTestRunner/TestController.cpp:
2596         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2597         (WTR::PlatformWebView::PlatformWebView):
2598
2599 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2600
2601         Reviewed by Adam Roben.
2602
2603         vcproj changes can't be applied cleanly by the Windows EWS bot
2604         https://bugs.webkit.org/show_bug.cgi?id=50328
2605
2606         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2607         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2608         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2609         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2610         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2611         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2612         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2613         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2614         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2615         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2616         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2617         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2618         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2619         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2620         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2621         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2622         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2623         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2624         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2625         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2626         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2627         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2628         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2629         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2630         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2631         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2632         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2633         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2634         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2635         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2636         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2637         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2638         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2639         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2640         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2641         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2642         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2643         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2644         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2645         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2646         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2647         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2648         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2649         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2650         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2651
2652 2010-12-01  Anders Carlsson  <andersca@apple.com>
2653
2654         Reviewed by Darin Adler.
2655
2656         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2657         https://bugs.webkit.org/show_bug.cgi?id=50336
2658
2659         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2660         Add new test.
2661
2662         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2663         (PluginTest::NPP_New):
2664         Add default implementation/
2665
2666         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2667         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2668         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2669         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2670         Get the user agent.
2671
2672         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2673         (NPP_New):
2674         Call PluginTest::NPP_New.
2675
2676         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2677         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2678         Add new files.
2679
2680         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2681         (webkit_test_plugin_new_instance):
2682         Call PluginTest::NPP_New.
2683
2684 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2685
2686         [wx] Build fixes after recent trunk changes.
2687
2688         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2689         (LayoutTestController::findString):
2690         * wx/build/settings.py:
2691
2692 2010-12-01  Dan Bernstein  <mitz@apple.com>
2693
2694         Reviewed by Darin Adler.
2695
2696         WebKitTestRunner needs layoutTestController.findString
2697         https://bugs.webkit.org/show_bug.cgi?id=50238
2698
2699         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2700         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2701         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2702         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2703
2704 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2705
2706         Try using svn:eol-style native on a vcproj file.
2707
2708         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2709
2710 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2711
2712         Reviewed by Adam Roben.
2713
2714         [WINCE] Add WinCELauncher
2715         https://bugs.webkit.org/show_bug.cgi?id=50217
2716
2717         * WinCELauncher/main.cpp: Added.
2718
2719 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2720
2721         Reviewed by Kenneth Rohde Christiansen.
2722
2723         [Qt] Implement layoutTestController.findString
2724         https://bugs.webkit.org/show_bug.cgi?id=50236
2725
2726         Add the missing function to the LayoutTestController.
2727
2728         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2729         (LayoutTestController::findString):
2730         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2731
2732 2010-11-30  Tony Chang  <tony@chromium.org>
2733
2734         Reviewed by Adam Barth.
2735
2736         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2737         https://bugs.webkit.org/show_bug.cgi?id=49036
2738
2739         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2740             for CppVariants.
2741         (LayoutTestController::cppVariantToBool):
2742         (LayoutTestController::cppVariantToInt32):
2743         (LayoutTestController::setDatabaseQuota):
2744         (LayoutTestController::evaluateInWebInspector):
2745         (LayoutTestController::setMockGeolocationError):
2746
2747 2010-11-30  Eric Seidel  <eric@webkit.org>
2748
2749         Reviewed by Tony Chang.
2750
2751         update-webkit should call git fetch before git svn rebase
2752         https://bugs.webkit.org/show_bug.cgi?id=50273
2753
2754         After discussion on webkit-dev, we've decided to move the "default"
2755         git setup to pulling updates from git.webkit.org in preference
2756         to rebuilding the local svn index using git svn fetch every time.
2757
2758         This change should have no effect on people using the "old" git setup
2759         and should dramatically increase the speed of updates for those using
2760         the "new" git setup along with update-webkit.  I'm about to move the
2761         EWS and other queues over to this setup once this lands.
2762
2763         * Scripts/update-webkit:
2764
2765 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2766
2767         Reviewed by Xan Lopez.
2768
2769         GTK: AX: implement press in DRT
2770         https://bugs.webkit.org/show_bug.cgi?id=36146
2771
2772         Implement AccessibilityUIElement::press() for GTK.
2773
2774         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2775         (AccessibilityUIElement::press): Implemented.
2776
2777 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2778
2779         Reviewed by Tony Chang.
2780
2781         config.webkit_base_dir returns a path with a trailing slash
2782         https://bugs.webkit.org/show_bug.cgi?id=50197
2783
2784         config.webkit_base_dir() should return a path without a trailing slash,
2785         like all the other methods that return paths.
2786
2787         Undoes MockFileSytem changes by r72640, since they're no longer
2788         necessary for GetBaselinesTest to pass.
2789
2790         * Scripts/webkitpy/common/system/filesystem_mock.py:
2791         * Scripts/webkitpy/layout_tests/port/base.py:
2792         * Scripts/webkitpy/layout_tests/port/config.py:
2793         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2794
2795 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2796
2797         Reviewed by Tony Chang.
2798
2799         Rebaseline server: baseline display tweaks
2800         https://bugs.webkit.org/show_bug.cgi?id=50207
2801
2802         Determine which baselines were used when running the tests and highlight
2803         them in the UI. Sort platform names alphabetically.
2804
2805         Also makes the server URL be launched in the user's browser
2806         automatically.
2807
2808         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2809         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2810         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2811         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2812         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2813
2814 2010-11-30  Dan Bernstein  <mitz@apple.com>
2815
2816         Reviewed by Anders Carlsson.
2817
2818         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2819         https://bugs.webkit.org/show_bug.cgi?id=50238
2820
2821         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2822         (WTR::LayoutTestController::findString): Added.
2823         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2824
2825 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2826
2827         Reviewed by Adam Roben.
2828
2829         All projects on Windows should use cmd files for build events
2830         https://bugs.webkit.org/show_bug.cgi?id=50213
2831
2832         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2833         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2834         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2835         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2836         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2837         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2838         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2839         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2840         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2841         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2842         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2843         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2844         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2845         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2846         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2847         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2848         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2849         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2850         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2851         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2852         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2853         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2854         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2855         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2856         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2857         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2858         * WinLauncher/WinLauncherCommon.vsprops:
2859         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2860         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2861
2862 2010-11-29  Dan Bernstein  <mitz@apple.com>
2863
2864         GTK DumpRenderTree build fix after r72887.
2865
2866         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2867         (LayoutTestController::findString):
2868
2869 2010-11-29  Dan Bernstein  <mitz@apple.com>
2870
2871         Windows DumpRenderTree build fix after r72887.
2872
2873         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2874         (LayoutTestController::findString): Added empty implementation.
2875
2876 2010-11-29  Dan Bernstein  <mitz@apple.com>
2877
2878         Reviewed by Darin Adler.
2879
2880         DumpRenderTree changes for testing the text search API.
2881         https://bugs.webkit.org/show_bug.cgi?id=50038
2882
2883         * DumpRenderTree/LayoutTestController.cpp:
2884         (findStringCallback):
2885         (LayoutTestController::staticFunctions):
2886         * DumpRenderTree/LayoutTestController.h:
2887         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2888         (LayoutTestController::findString):
2889         * MiniBrowser/mac/BrowserWindowController.m:
2890         (-[BrowserWindowController find:]):
2891
2892 2010-11-29  Johnny Ding  <jnd@chromium.org>
2893
2894         Unreviewed: Add myself to the list of Committers.
2895
2896         * Scripts/webkitpy/common/config/committers.py:
2897
2898 2010-11-29  Mark Rowe  <mrowe@apple.com>
2899
2900         Reviewed by Adele Peterson.
2901
2902         <rdar://problem/8694997> DumpRenderTree fails to build.
2903
2904         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2905
2906 2010-11-29  Mark Rowe  <mrowe@apple.com>
2907
2908         Reviewed by Adele Peterson.
2909
2910         <rdar://problem/8694997> DumpRenderTree fails to build.
2911
2912         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2913         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2914         * DumpRenderTree/mac/PerlSupport/Makefile:
2915
2916 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2917
2918         Reviewed by Martin Robinson.
2919
2920         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2921         https://bugs.webkit.org/show_bug.cgi?id=50154
2922
2923         Added missing checks to allAttributes().
2924
2925         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2926         (AccessibilityUIElement::allAttributes): Added missing checks.
2927
2928 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2929
2930         Reviewed by Kenneth Rohde Christiansen.
2931
2932         [Qt] Allow pre-generation for package builds for WebKit2
2933         https://bugs.webkit.org/show_bug.cgi?id=50139
2934
2935         Use a build variable for the generated directory path and set the
2936         value based on CONFIG just like for WebKit1.
2937
2938         For non-package builds use a relative base path for the
2939         genrated directory just like for WebKit1.
2940
2941         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2942         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2943
2944 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2945
2946         Reviewed by Kenneth Rohde Christiansen.
2947
2948         [Qt] Move some build logic from Qt to platform independent code
2949         https://bugs.webkit.org/show_bug.cgi?id=50134
2950
2951         Create target directories inside generate-forwarding-headers.pl.
2952
2953         * Scripts/generate-forwarding-headers.pl:
2954
2955 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2956
2957         Reviewed by Martin Robinson.
2958
2959         [GTK] Windowless plugins gets broken key input
2960         https://bugs.webkit.org/show_bug.cgi?id=49927
2961
2962         Convert the XEvent::keycode to ASCII before printing it. Not
2963         doing this was causing false positive in
2964         plugins/keyboard-events.html.
2965
2966         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2967         (keycode_to_char):
2968         (webkit_test_plugin_handle_event):
2969
2970 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2971
2972         Reviewed by Antonio Gomes.
2973
2974         [Qt] Html autofocus not working with QGraphicsWebView
2975         https://bugs.webkit.org/show_bug.cgi?id=43169
2976
2977         Tell the scene to set the webview item as the currently
2978         focused item. This makes the input field with autofocus get
2979         focus as it should.
2980
2981         * QtTestBrowser/webview.cpp:
2982         (WebViewGraphicsBased::WebViewGraphicsBased):
2983
2984 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2985
2986         Reviewed by Tony Chang.
2987
2988         nrwt - clean up create_driver interface and print out the
2989         command line used for DumpRenderTree/TestShell.
2990
2991         This patch adds a driver_cmd_line() call to the Port class in
2992         order to retrive the command line to print it out (as part of
2993         --print config).
2994
2995         In addition, this patch cleans up the Port.create_driver()
2996         signature and the Driver constructor interface to take a worker
2997         number and no longer require the image_path argument (Chromium's
2998         drivers now synthesize the image_path from the worker number
2999         internally).
3000
3001         https://bugs.webkit.org/show_bug.cgi?id=49934
3002
3003         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3004         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3005         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3006         * Scripts/webkitpy/layout_tests/port/base.py:
3007         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3008         * Scripts/webkitpy/layout_tests/port/chromium.py:
3009         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3010         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3011         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3012         * Scripts/webkitpy/layout_tests/port/test.py:
3013         * Scripts/webkitpy/layout_tests/port/webkit.py:
3014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3015         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3016
3017 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3018
3019         Reviewed by Tony Chang.
3020
3021         [chromium] improve memory usage for test results server and store fewer runs
3022         https://bugs.webkit.org/show_bug.cgi?id=50035
3023
3024         Store fewer runs and don't pass full files around when we only need bools.
3025         Greatly improves error rates on test-results.appspot.com.
3026
3027         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3028         * TestResultServer/handlers/testfilehandler.py:
3029         * TestResultServer/model/dashboardfile.py:
3030         * TestResultServer/model/jsonresults.py:
3031
3032 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3033
3034         Reviewed by Tony Chang.
3035
3036         This patch implements the first part of the manager side of the
3037         Broker objects - it handles creating threads, waiting for them
3038         to complete, and running a single-threaded loop as well.
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=49779
3041
3042         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3043         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3044         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3045         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3046
3047 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3048
3049         Reviewed by David Levin.
3050
3051         DRT should not generate pixel output for text/plain tests
3052         https://bugs.webkit.org/show_bug.cgi?id=50002
3053
3054         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3055         when encountering a text/plain response (the Chromium one already does
3056         this, and none of the other ports special-case text/plain output in
3057         the first place).
3058
3059         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3060         (dump):
3061         * DumpRenderTree/mac/DumpRenderTree.mm:
3062         (dump):
3063         * DumpRenderTree/win/DumpRenderTree.cpp:
3064         (dump):
3065
3066 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3067
3068         Unreviewed.
3069
3070         Add my other email address to committers.py.
3071
3072         * Scripts/webkitpy/common/config/committers.py:
3073
3074 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3075
3076         Reviewed by Csaba Osztrogonác.
3077
3078         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3079         https://bugs.webkit.org/show_bug.cgi?id=49975
3080
3081         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3082         to enable the script to define it 0 in case of a minimal build.
3083
3084 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3085
3086         Reviewed by Xan Lopez.
3087
3088         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3089         https://bugs.webkit.org/show_bug.cgi?id=49143
3090
3091         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3092         (createWebView): Call the new connectEditingCallbacks function.
3093         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3094         (dumpNodePath):
3095         (dumpRange):
3096         (insertActionString):
3097         (selectionAffinityString):
3098         (shouldBeginEditing):
3099         (shouldEndEditing):
3100         (shouldInsertNode):
3101         (shouldInsertText):
3102         (shouldDeleteRange):
3103         (shouldShowDeleteInterfaceForElement):
3104         (shouldChangeSelectedRange):
3105         (shouldApplyStyle):
3106         (editingBegan):
3107         (userChangedContents):
3108         (editingEnded):
3109         (selectionChanged):
3110         (connectEditingCallbacks):
3111         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3112         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3113
3114 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3115
3116         Reviewed by Andreas Kling.
3117
3118         [Qt] Make QtTestBrowser remember the selected user agent
3119         https://bugs.webkit.org/show_bug.cgi?id=50021
3120
3121         Set user agent for a new page by using the old page's
3122
3123         * QtTestBrowser/mainwindow.cpp:
3124         (MainWindow::setPage):
3125
3126 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3127
3128         Reviewed by Csaba Osztrogonác.
3129
3130         Remove Bakefile build system files
3131         https://bugs.webkit.org/show_bug.cgi?id=49983
3132
3133         r53757 only removed the content, but not the files.
3134         This patch removes that empty files.
3135
3136         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3137         * wx/browser/browser.bkl: Removed.
3138         * wx/build-wxwebkit: Removed.
3139
3140 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3141
3142         Reviewed by Tony Chang.
3143
3144         This patch cleans up the logic used to shard tests into groups a
3145         bit and adds the --worker-model flag to NRWT. The flag is only
3146         used at the moment to control whether to run single-threaded or
3147         not, but eventually will also allow toggling between threads and
3148         processes.
3149
3150         Also add a minor cleanup with _test_is_slow(), which just
3151         eliminates some repetition and gives slightly better encapsulation.
3152
3153         https://bugs.webkit.org/show_bug.cgi?id=49773
3154
3155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3156         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3157
3158 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3159
3160         Reviewed by Tony Chang.
3161
3162         Rebaseline server: list current baselines and platforms
3163         https://bugs.webkit.org/show_bug.cgi?id=49991
3164
3165         List existing baselines (with Trac links) for tests.
3166
3167         Add dropdowns for choosing with platform baselines to target (and what
3168         to do with existing ones).
3169
3170         Also fix MockFileSystem.join to behave more like os.path.join (unit
3171         test was ending up with two consecutive slashes in a layout test
3172         path).
3173
3174         * Scripts/webkitpy/common/system/filesystem_mock.py:
3175         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3176         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3177         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3178         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3179         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3180         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3181         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3182
3183 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3184
3185         Reviewed by Tony Chang.
3186
3187         remove timeout argument to urlopen
3188         https://bugs.webkit.org/show_bug.cgi?id=49995
3189
3190         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3191
3192         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3193
3194 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3195
3196         Unreviewed, rolling out r72628.
3197         http://trac.webkit.org/changeset/72628
3198         https://bugs.webkit.org/show_bug.cgi?id=49994
3199
3200         This patch is causing layout-test failtures on GTK Linux
3201         64-bit Debug (Requested by ctguil on #webkit).
3202
3203         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3204         (AccessibilityUIElement::AccessibilityUIElement):
3205         (AccessibilityUIElement::parentElementCallback):
3206         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3207         * DumpRenderTree/chromium/CppBoundClass.cpp:
3208         * DumpRenderTree/chromium/CppBoundClass.h:
3209
3210 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3211
3212         Reviewed by Tony Chang.
3213
3214         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3215         https://bugs.webkit.org/show_bug.cgi?id=49944
3216
3217         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3218
3219 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3220
3221         Reviewed by Dimitri Glazkov.
3222
3223         Include the FrameView widget of a RenderWidget in the accessibility tree.
3224         https://bugs.webkit.org/show_bug.cgi?id=49106
3225
3226         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3227         (AccessibilityUIElement::AccessibilityUIElement):
3228         (AccessibilityUIElement::parentElementCallback):
3229         (AccessibilityUIElement::isEqualCallback):
3230         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3231         * DumpRenderTree/chromium/CppBoundClass.cpp:
3232         (CppBoundClass::getFromCppVariant):
3233         * DumpRenderTree/chromium/CppBoundClass.h:
3234
3235 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3236
3237         Reviewed by Kenneth Rohde Christiansen.
3238
3239         [EFL] Add tiled backing store to EWebLauncher
3240         https://bugs.webkit.org/show_bug.cgi?id=45777
3241
3242         Allow EWebLauncher to choose between single and tiled backing store
3243
3244         * EWebLauncher/main.c:
3245         (on_key_down):
3246         (browserCreate):
3247         (main):
3248
3249 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3250
3251         Reviewed by Tor Arne Vestbø.
3252
3253         [Qt] Review the setUserPermission & friends API
3254         https://bugs.webkit.org/show_bug.cgi?id=46810
3255
3256         Renamed requestPermissionFromUser to featurePermissionRequested
3257         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3258
3259         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3260         (WebCore::WebPage::WebPage):
3261         * QtTestBrowser/webpage.cpp:
3262         (WebPage::WebPage):
3263         (WebPage::featurePermissionRequestCanceled):
3264         * QtTestBrowser/webpage.h:
3265
3266 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3267
3268         Reviewed by Tor Arne Vestbø.
3269
3270         [Qt] Review the setUserPermission & friends API
3271         https://bugs.webkit.org/show_bug.cgi?id=46810
3272
3273         Rename setUserPermission to setFeaturePermission
3274
3275         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3276         (WebCore::WebPage::requestPermission):
3277         (WebCore::WebPage::permissionSet):
3278         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3279         (LayoutTestController::grantDesktopNotificationPermission):
3280         * QtTestBrowser/webpage.cpp:
3281         (WebPage::requestPermission):
3282
3283 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3284
3285         Reviewed by Tor Arne Vestbø.
3286
3287         [Qt] Review the setUserPermission & friends API
3288         https://bugs.webkit.org/show_bug.cgi?id=46810
3289
3290         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3291         and GeolocationPermissionDomain to Geolocation.
3292
3293         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3294         (WebCore::WebPage::WebPage):
3295         (WebCore::WebPage::requestPermission):
3296         (WebCore::WebPage::cancelPermission):
3297         (WebCore::WebPage::permissionSet):
3298         (WebCore::DumpRenderTree::geolocationPermissionSet):
3299         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3300         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3301         (LayoutTestController::grantDesktopNotificationPermission):
3302         * QtTestBrowser/webpage.cpp:
3303         (WebPage::WebPage):
3304         (WebPage::requestPermission):
3305         (WebPage::cancelRequestsForPermission):
3306         * QtTestBrowser/webpage.h:
3307
3308 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3309
3310         Reviewed by Tor Arne Vestbø.
3311
3312         [Qt] Review the setUserPermission & friends API
3313         https://bugs.webkit.org/show_bug.cgi?id=46810
3314
3315         Add a ByUser suffix to PermissionGranted/Denied. In the future
3316         we can add PermissionGrantedByDefault.
3317
3318
3319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3320         (WebCore::WebPage::requestPermission):
3321         (WebCore::WebPage::permissionSet):
3322         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3323         (LayoutTestController::grantDesktopNotificationPermission):
3324         * QtTestBrowser/webpage.cpp:
3325         (WebPage::requestPermission):
3326
3327 2010-11-18  Satish Sampath  <satish@chromium.org>
3328
3329         Reviewed by Jeremy Orlow.
3330
3331         For speech input event, send an event object containing all the recognition results and metadata.
3332         https://bugs.webkit.org/show_bug.cgi?id=49736
3333
3334         Updated DRT by renaming the mock result method on all platforms to the new signature.
3335
3336         * DumpRenderTree/LayoutTestController.cpp:
3337         (addMockSpeechInputResultCallback):
3338         (LayoutTestController::staticFunctions):
3339         * DumpRenderTree/LayoutTestController.h:
3340         * DumpRenderTree/chromium/LayoutTestController.cpp:
3341         (LayoutTestController::LayoutTestController):
3342         (LayoutTestController::addMockSpeechInputResult):
3343         * DumpRenderTree/chromium/LayoutTestController.h:
3344         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3345         (LayoutTestController::addMockSpeechInputResult):
3346         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3347         (LayoutTestController::addMockSpeechInputResult):
3348         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3349         (LayoutTestController::addMockSpeechInputResult):
3350         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3351         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3352         (LayoutTestController::addMockSpeechInputResult):
3353         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3354         (LayoutTestController::addMockSpeechInputResult):
3355
3356 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3357
3358         Reviewed by Tony Chang.
3359
3360         Fix some spacing issues with log messages with
3361         new-run-webkit-tests --verbose.
3362
3363         https://bugs.webkit.org/show_bug.cgi?id=49936
3364
3365         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3366
3367 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3368
3369         Reviewed by Adam Barth.
3370
3371         update scm to work with different remote branches
3372         https://bugs.webkit.org/show_bug.cgi?id=49949
3373
3374         This works if there are multiple svn tracking branches
3375         and/or if the tracking branch is refs/remots/origin/master
3376         instead of refs/remotes/trunk which is the direction we're trying
3377         to head since that makes fetches faster.
3378
3379         * Scripts/webkitpy/common/checkout/scm.py:
3380         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3381
3382 2010-11-22  Hayato Ito  <hayato@chromium.org>
3383
3384         Reviewed by Shinichiro Hamaji.
3385
3386         Ignore reference files which will be used by reftests when collecting
3387         test cases.
3388         https://bugs.webkit.org/show_bug.cgi?id=49835
3389
3390         * Scripts/webkitpy/layout_tests/port/test_files.py:
3391         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3392
3393 2010-11-22  Adam Roben  <aroben@apple.com>
3394
3395         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3396
3397         Apple's Windows build allows placing header files and import libraries for WebKit's
3398         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3399         $WebKitLibrariesDir environment variable. This is both required for production builds and
3400         convenient for Apple-internal developer builds. Apple's production builds also require that
3401         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3402         builds, the files are copied into that directory tree by the
3403         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3404         copying is done by
3405         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3406
3407         This .vsprops copying is problematic in one very important case: when a developer updates
3408         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3409         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3410         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3411         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3412         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3413         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3414
3415         To fix this, we now use normal relative paths to access the .vsprops files in the source
3416         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3417         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3418         unset, so the normal relative paths are used to read the .vsprops files out of the source
3419         tree directly. In production builds, this environment variable is set to a fake directory
3420         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3421         is resolved.
3422
3423         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3424
3425         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3426
3427         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3428         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3429         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3430         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3431         FeatureDefines.vsprops becomes:
3432
3433         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3434
3435         which resolves to:
3436
3437         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3438
3439         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3440         actually exist since they are matched by an equal number of ".." path components.)
3441
3442         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3443         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3444
3445         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3446         updated
3447
3448         Reviewed by Dave Hyatt.
3449
3450         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3451         * DumpRenderTree/win/DumpRenderTree.vcproj:
3452         * DumpRenderTree/win/ImageDiff.vcproj:
3453         * FindSafari/FindSafari.vcproj:
3454         * MiniBrowser/MiniBrowser.vcproj:
3455         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3456         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3457         * WebKitAPITest/WebKitAPITest.vcproj:
3458         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3459         * WebKitTestRunner/win/InjectedBundle.vcproj:
3460         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3461         * WinLauncher/WinLauncher.vcproj:
3462         * record-memory-win/record-memory-win.vcproj:
3463         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3464         files.
3465
3466 2010-11-22  Adam Roben  <aroben@apple.com>
3467
3468         Make it possible to run tests on Windows without Visual Studio or VC++
3469         Express installed
3470
3471         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3472         are not installed. But this function doesn't need to be called when we
3473         already have a build available and are just trying to run the tests.
3474
3475         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3476         because Visual Studio/VC++ Express aren't installed
3477
3478         Reviewed by Dave Hyatt.
3479
3480         * Scripts/webkitdirs.pm:
3481         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3482         it is not needed by this function. Also added a FIXME.
3483
3484         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3485         relying on determineConfigurationForVisualStudio doing it.
3486
3487 2010-11-19  Hayato Ito  <hayato@chromium.org>
3488
3489         Reviewed by Shinichiro Hamaji.
3490
3491         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3492
3493         https://bugs.webkit.org/show_bug.cgi?id=49812
3494
3495         * Scripts/webkitpy/layout_tests/driver_test.py:
3496         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3497         * Scripts/webkitpy/layout_tests/port/base.py:
3498         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3499         * Scripts/webkitpy/layout_tests/port/chromium.py:
3500         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3501         * Scripts/webkitpy/layout_tests/port/test.py:
3502         * Scripts/webkitpy/layout_tests/port/webkit.py:
3503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3504         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3505
3506 2010-11-22  Hayato Ito  <hayato@chromium.org>
3507
3508         Reviewed by Tony Chang.
3509
3510         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3511
3512         https://bugs.webkit.org/show_bug.cgi?id=49924
3513
3514         * Scripts/webkitpy/layout_tests/port/chromium.py:
3515
3516 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3517
3518         Reviewed by Kenneth Rohde Christiansen.
3519
3520         Fix EWebLauncher zoom discretization
3521         https://bugs.webkit.org/show_bug.cgi?id=49810
3522
3523         * EWebLauncher/main.c:
3524         (nearest_zoom_level_get):
3525         (zoom_level_set):
3526         (on_load_finished):
3527         (on_key_down):
3528
3529 2010-11-21  Sam Weinig  <sam@webkit.org>
3530
3531         Rubber-stamped by Dan Bernstein.
3532
3533         Fix ~300 WebKit2 tests by enabling developer extras preference.
3534
3535         * WebKitTestRunner/TestController.cpp:
3536         (WTR::TestController::resetStateToConsistentValues):
3537
3538 2010-11-21  Sam Weinig  <sam@webkit.org>
3539
3540         Reviewed by Dan Bernstein.
3541
3542         Textareas should be resizable by default
3543         https://bugs.webkit.org/show_bug.cgi?id=49892
3544
3545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3546         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3547         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3548         Add preferences test.
3549
3550 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3551
3552         Reviewed by Tony Chang.
3553
3554         Rebaseline server: checksum-only differences and prefetching
3555         https://bugs.webkit.org/show_bug.cgi?id=49841
3556
3557         Add support for image test results where the only difference is in the
3558         checksum.
3559
3560         Add prefetching of the image results from the next test.
3561
3562         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3563         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3564         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3565
3566 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3567
3568         Reviewed by Tony Chang.
3569
3570         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3571
3572         Add the 'worker number' and 'worker name' concepts to the
3573         TestShellThread objects, and move test_types and test_args from
3574         the TestRunner to the TestShellThread.
3575
3576         https://bugs.webkit.org/show_bug.cgi?id=49768
3577
3578         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3579         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3580
3581 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3582
3583         Reviewed by Ojan Vafai.
3584
3585         Do some minor cleanup and bug fixing.
3586
3587         https://bugs.webkit.org/show_bug.cgi?id=49777
3588
3589         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3590         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3591
3592 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3593
3594         Reviewed by Ojan Vafai.
3595
3596         nrwt - config.build_directory() is busted
3597
3598         Fixes a typo that was causing us to usually return the top level
3599         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3600         bug was hidden by test stubs that were too simplistic :(.
3601
3602         https://bugs.webkit.org/show_bug.cgi?id=49815
3603
3604         * Scripts/webkitpy/common/system/executive_mock.py:
3605         * Scripts/webkitpy/layout_tests/port/config.py:
3606         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3607
3608 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3609
3610         Reviewed by Adam Roben.
3611
3612         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3613         https://bugs.webkit.org/show_bug.cgi?id=49819
3614
3615         * DumpRenderTree/DumpRenderTree.sln:
3616         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3617         * DumpRenderTree/win/DumpRenderTree.vcproj:
3618         * DumpRenderTree/win/ImageDiff.vcproj:
3619         * FindSafari/FindSafari.vcproj:
3620         * MiniBrowser/MiniBrowser.vcproj:
3621         * TestWebKitAPI/win/TestWebKitAPI.sln:
3622         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3623         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3624         * WebKitAPITest/WebKitAPITest.vcproj:
3625         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3626         * WebKitTestRunner/win/InjectedBundle.vcproj:
3627         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3628         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3629         * WinLauncher/WinLauncher.vcproj:
3630         * record-memory-win/record-memory-win.vcproj:
3631
3632 2010-11-19  Adam Roben  <aroben@apple.com>
3633
3634         Add some more Windows slaves
3635
3636         This is probably more than we will be using in the immediate future,
3637         but having some extra slave names makes experimenting with different
3638         configurations easier.
3639
3640         Reviewed by Jon Honeycutt.
3641
3642         *&