bd3a7b0f6b2881ceec7582e1c499590af2716ff1
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-25  Brady Eidson  <beidson@apple.com>
2
3         ResourceLoadStatistics grandfathering happens much too often.
4         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
5
6         Reviewed by Chris Dumez.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
10         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
11         (TEST):
12
13 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
14
15         Fix autoinstaller failing on autoinstall_everything
16         https://bugs.webkit.org/show_bug.cgi?id=174830
17
18         Reviewed by Joseph Pecoraro.
19
20         * Scripts/webkitpy/thirdparty/__init__.py:
21         (AutoinstallImportHook.find_module):
22         (AutoinstallImportHook.install_chromedriver):
23         (AutoinstallImportHook.install_geckodriver):
24         (AutoinstallImportHook._install_chromedriver): Deleted.
25         (AutoinstallImportHook._install_geckodriver): Deleted.
26
27 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
28
29         Replace --runtime with something for both ios-simulator and ios-device
30         https://bugs.webkit.org/show_bug.cgi?id=173775
31         <rdar://problem/32952164>
32
33         Reviewed by Aakash Jain.
34
35         Add --version flag for both iOS simulator and iOS device.
36
37         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
38         (parse_args): Add --version flag and move --no-install.
39         * Scripts/webkitpy/port/factory.py:
40         (platform_options): Move --no-intall to run_webkit_tests.py.
41         * Scripts/webkitpy/port/ios.py:
42         (IOSPort):
43         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
44         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
45         * Scripts/webkitpy/port/ios_device.py:
46         (IOSDevicePort.ios_version): Consult --version flag before checking connected
47         devices for iOS version.
48         * Scripts/webkitpy/port/ios_device_unittest.py:
49         (IOSDeviceTest.make_port): Set --version option so that we can generate test
50         expectation paths without devices connected.
51         (IOSDeviceTest.test_additional_platform_directory): Deleted.
52         (IOSDeviceTest.test_baseline_searchpath): Deleted.
53         (IOSDeviceTest.test_expectations_ordering): Deleted.
54         * Scripts/webkitpy/port/ios_simulator.py:
55         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
56         flag to specify a runtime.
57         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
58         flag and then use the default runtime.
59
60 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
61
62         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
63         https://bugs.webkit.org/show_bug.cgi?id=174815
64
65         Reviewed by Carlos Alberto Lopez Perez.
66
67         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
68         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
69         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
70         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
71         think), probably because of a newer CMake version.
72
73         * CMakeLists.txt:
74         * TestWebKitAPI/CMakeLists.txt:
75         * TestWebKitAPI/PlatformGTK.cmake:
76
77 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
78
79         Fix BenchmarkRunner to only import selenium when needed
80         https://bugs.webkit.org/show_bug.cgi?id=174808
81
82         Reviewed by Stephanie Lewis.
83
84         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
85         (LinuxChromeDriver.launch_driver):
86         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
87         (LinuxFirefoxDriver.launch_driver):
88         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
89         (OSXChromeDriver.launch_driver):
90         (OSXChromeCanaryDriver.launch_driver):
91         (create_chrome_options):
92         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
93         (OSXFirefoxDriver.launch_driver):
94         (OSXFirefoxNightlyDriver.launch_driver):
95         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
96         (OSXSafariDriver.launch_driver):
97         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
98         (WebDriverBenchmarkRunner._run_one_test):
99
100 2017-07-23  Darin Adler  <darin@apple.com>
101
102         More NeverDestroyed and related cleanup
103         https://bugs.webkit.org/show_bug.cgi?id=174745
104
105         Reviewed by Alex Christensen.
106
107         * DumpRenderTree/JavaScriptThreading.cpp:
108         (javaScriptThreadsMutex): Use NeverDestroyed instead of
109         DEPRECATED_DEFINE_STATIC_LOCAL.
110         (javaScriptThreads): Ditto.
111
112 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
113
114         Subclass Benchmark Runner script for WebDriver support
115         https://bugs.webkit.org/show_bug.cgi?id=174390
116
117         Reviewed by Dewei Zhu, Stephanie Lewis.
118
119         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
120
121         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
122         (BenchmarkBuilder.__init__):
123         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
124         (BenchmarkRunner.__init__):
125         (BenchmarkRunner._find_plan_file):
126         (BenchmarkRunner._run_one_test.and):
127         (BenchmarkRunner.execute):
128         (BenchmarkRunner._get_result): Deleted.
129         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
130         (parse_args):
131         (start):
132         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
133         (WebDriverBenchmarkRunner):
134         (WebDriverBenchmarkRunner._get_result):
135         (WebDriverBenchmarkRunner._run_one_test):
136         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
137         (WebServerBenchmarkRunner):
138         (WebServerBenchmarkRunner.__init__):
139         (WebServerBenchmarkRunner._get_result):
140         (WebServerBenchmarkRunner._run_one_test):
141
142 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
143
144         Add BenchmarkRunner patches with WebDriver support for each testing plan
145         https://bugs.webkit.org/show_bug.cgi?id=174443
146
147         Reviewed by Dewei Zhu, Stephanie Lewis.
148
149         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
150         (BenchmarkBuilder.__enter__):
151         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
152         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
153         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
154         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
155         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
156         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
157         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
158         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
159         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
160         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
161         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
162         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
163         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
164         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
165         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
166         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
167         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
168         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
169         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
170         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
171         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
172         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
173         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
174         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
175         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
176         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
177         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
178         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
179         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
180         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
181         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
182         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
183         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
184
185 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
186
187         Add functions to autoinstaller needed for Benchmark Runner script
188         https://bugs.webkit.org/show_bug.cgi?id=174331
189
190         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
191
192         Adds autoinstaller functions to install selenium and webdriver binaries
193         which will be used by the browser driver part of Benchmark Runner.
194
195         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
196         (BrowserDriver.restore_env):
197         (BrowserDriver):
198         (BrowserDriver.get_webdriver_binary_path):
199         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
200         (LinuxChromeDriver.launch_driver):
201         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
202         (LinuxFirefoxDriver.launch_driver):
203         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
204         (OSXChromeDriver.launch_driver):
205         (OSXChromeCanaryDriver.launch_driver):
206         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
207         (OSXFirefoxDriver.launch_driver):
208         (OSXFirefoxNightlyDriver.launch_driver):
209         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
210         * Scripts/webkitpy/benchmark_runner/utils.py:
211         (get_driver_binary_path):
212         * Scripts/webkitpy/common/system/autoinstall.py:
213         (AutoInstaller._unzip):
214         * Scripts/webkitpy/thirdparty/__init__.py:
215         (AutoinstallImportHook.find_module):
216         (AutoinstallImportHook._install_selenium):
217         (AutoinstallImportHook):
218         (AutoinstallImportHook._install_chromedriver):
219         (AutoinstallImportHook._install_geckodriver):
220         (AutoinstallImportHook.get_latest_pypi_url):
221         (AutoinstallImportHook.install_binary):
222         (autoinstall_everything):
223         (get_driver_filename):
224         (get_os_info):
225
226 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
227
228         Add WebDriver support in browser driver part of BenchmarkRunner
229         https://bugs.webkit.org/show_bug.cgi?id=174445
230
231         Reviewed by Stephanie Lewis.
232
233         Adds a launch_driver function to each BrowserDriver subclass. This
234         function sets up the arguments for the webdriver and launches the
235         webdriver specific to that browser.
236
237         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
238         (BrowserDriver.launch_webdriver):
239         (BrowserDriver):
240         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
241         (LinuxBrowserDriver.launch_webdriver):
242         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
243         (LinuxChromeDriver.launch_url):
244         (LinuxChromeDriver):
245         (LinuxChromeDriver.launch_driver):
246         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
247         (EpiphanyBrowserDriver.launch_url):
248         (EpiphanyBrowserDriver):
249         (EpiphanyBrowserDriver.launch_driver):
250         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
251         (LinuxFirefoxDriver):
252         (LinuxFirefoxDriver.launch_url):
253         (LinuxFirefoxDriver.launch_driver):
254         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
255         (GTKMiniBrowserDriver.launch_url):
256         (GTKMiniBrowserDriver):
257         (GTKMiniBrowserDriver.launch_driver):
258         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
259         (OSXBrowserDriver._launch_webdriver):
260         (OSXBrowserDriver):
261         (OSXBrowserDriver._screen_size):
262         (OSXBrowserDriver._insert_url):
263         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
264         (OSXChromeDriver):
265         (OSXChromeDriver.launch_url):
266         (OSXChromeDriver.launch_driver):
267         (OSXChromeCanaryDriver):
268         (OSXChromeCanaryDriver.launch_url):
269         (OSXChromeCanaryDriver.launch_driver):
270         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
271         (OSXFirefoxDriver):
272         (OSXFirefoxDriver.launch_url):
273         (OSXFirefoxDriver.launch_driver):
274         (OSXFirefoxNightlyDriver):
275         (OSXFirefoxNightlyDriver.launch_url):
276         (OSXFirefoxNightlyDriver.launch_driver):
277         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
278         (OSXSafariDriver.launch_driver):
279
280 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
281
282         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
283         https://bugs.webkit.org/show_bug.cgi?id=174793
284
285         Reviewed by Tim Horton.
286
287         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
288         down. Without r219765, this test will dereference null and crash.
289
290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
291         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
292         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
293         (TEST):
294
295 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
296
297         [Win] Implement Authentication dialog in MiniBrowser
298         https://bugs.webkit.org/show_bug.cgi?id=174662
299
300         Reviewed by Alex Christensen.
301
302         * MiniBrowser/win/Common.cpp:
303         (CustomUserAgent):
304         (DisplayAuthDialog):
305         (AuthDialogProc):
306         * MiniBrowser/win/MiniBrowserLib.rc:
307         * MiniBrowser/win/MiniBrowserLibResource.h:
308         * MiniBrowser/win/ResourceLoadDelegate.cpp:
309         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
310
311 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
312
313         Handle case where line_numbers is None instead of an array of line numbers
314         https://bugs.webkit.org/show_bug.cgi?id=174775
315
316         Reviewed by Aakash Jain.
317
318         Added files set line_numbers to None in process_file.
319
320         * Scripts/webkitpy/style/filereader.py:
321         (TextFileReader.process_file): Handle case where line_number is set to None.
322         * Scripts/webkitpy/style/main_unittest.py:
323         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
324
325 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
326
327         [WPE] Add libepoxy to the Jhbuild moduleset
328         https://bugs.webkit.org/show_bug.cgi?id=174711
329
330         Reviewed by Carlos Alberto Lopez Perez.
331
332         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
333
334 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
335
336         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
337         https://bugs.webkit.org/show_bug.cgi?id=174780
338
339         Reviewed by Carlos Garcia Campos.
340
341         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
342         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
343         in case the eglplatform.h header doesn't provide that macro. This replicates
344         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
345
346 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
347
348         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
349         https://bugs.webkit.org/show_bug.cgi?id=174758
350
351         Reviewed by Dan Bernstein.
352
353         Migrate position-information-related unit tests from the PositionInformationTests suite to
354         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
357         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
358         (TestWebKitAPI::checkElementTypeAndBoundingRect):
359         (TestWebKitAPI::TEST):
360         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
361         * TestWebKitAPI/cocoa/TestWKWebView.h:
362         * TestWebKitAPI/cocoa/TestWKWebView.mm:
363         (-[TestWKWebView activatedElementAtPosition:]):
364
365 2017-07-22  Chris Dumez  <cdumez@apple.com>
366
367         REGRESSION(r204565): WKObject is broken
368         https://bugs.webkit.org/show_bug.cgi?id=174736
369         <rdar://problem/33246169>
370
371         Reviewed by Dan Bernstein.
372
373         Add API test that used to crash.
374
375         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
376         (TestWebKitAPI::TEST):
377
378 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
379
380         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
381         https://bugs.webkit.org/show_bug.cgi?id=174705
382
383         Reviewed by Mark Lam.
384
385         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
386         (TestWebKitAPI::testThreadGroup):
387         (TestWebKitAPI::TEST):
388
389 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
390
391         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
392         https://bugs.webkit.org/show_bug.cgi?id=174724
393
394         Reviewed by Aakash Jain.
395
396         * Scripts/webkitpy/port/ios_simulator.py:
397         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
398         simulator. Errors here should be treated the same as no simulators found.
399
400 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
401
402         [CMake] Add an option to stop build after generating project files
403         https://bugs.webkit.org/show_bug.cgi?id=174664
404
405         Reviewed by Konstantin Tokarev.
406
407         Add "--generate-project-only" to stop build after generating project files.
408
409         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
410         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
411         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
412         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
413         (isGenerateProjectOnly): ditto
414
415 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
416
417         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
418         https://bugs.webkit.org/show_bug.cgi?id=174501
419
420         Reviewed by Darin Adler.
421
422         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
423         (TestWebKitAPI::TEST):
424
425 2017-07-20  David Quesada  <david_quesada@apple.com>
426
427         Add SPI to notify WKNavigationDelegate about client redirects
428         https://bugs.webkit.org/show_bug.cgi?id=174680
429         rdar://problem/33184886
430
431         Reviewed by Brady Eidson.
432
433         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
434         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
435         (TEST):
436         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
437
438 2017-07-20  Brady Eidson  <beidson@apple.com>
439
440         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
441         https://bugs.webkit.org/show_bug.cgi?id=174685
442
443         Reviewed by Andy Estes.
444
445         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
446         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
447
448 2017-07-20  Brady Eidson  <beidson@apple.com>
449
450         Deprecate WebIconDatabase in WebKitLegacy/mac.
451         https://bugs.webkit.org/show_bug.cgi?id=174607
452
453         Reviewed by Alex Christensen.
454
455         * DumpRenderTree/mac/TestRunnerMac.mm:
456
457 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
458
459         lint-test-expectations should be run during style checking
460         https://bugs.webkit.org/show_bug.cgi?id=173559
461         <rdar://problem/32854941>
462
463         Reviewed by Aakash Jain.
464
465         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
466         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
467         prevents identifying errors on specific lines in a file.
468         * Scripts/webkitpy/style/main_unittest.py:
469         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
470         case where a linter error is in the file modified, but the line modified is not related to
471         the linter error.
472
473 2017-07-20  Brady Eidson  <beidson@apple.com>
474
475         Remove WebIconDatabase from WebKitLegacy/win.
476         https://bugs.webkit.org/show_bug.cgi?id=174608
477
478         Reviewed by Alex Christensen.
479
480         * DumpRenderTree/win/DumpRenderTree.cpp:
481         (main):
482         * DumpRenderTree/win/TestRunnerWin.cpp:
483         (TestRunner::setIconDatabaseEnabled):
484
485 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
486
487         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
488         https://bugs.webkit.org/show_bug.cgi?id=174671
489
490         Reviewed by Carlos Garcia Campos.
491
492         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
493         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
494         priority for this source in order to have it dispatched on the same
495         priority as the other WebKit-controlled GSource objects.
496
497 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
498
499         lint-test-expectations should be run during style checking
500         https://bugs.webkit.org/show_bug.cgi?id=173559
501         <rdar://problem/32854941>
502
503         Reviewed by Daniel Bates.
504
505         Follow up fix addressing style and a few minor bugs.
506
507         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
508         (TestExpectationParser.__init__): Use lambda x: x instead of str
509         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
510         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
511         reduce the calls of _shorten_filename, fix minor bug in appending the current
512         expectation's line number instead of the previous ones, clarify treatment of None
513         in file-to-line-number mapping.
514         (TestExpectations._report_warnings): Collapse call.
515         * Scripts/webkitpy/style/checkers/test_expectations.py:
516         (TestExpectationsChecker.lint_test_expectations):
517         * Scripts/webkitpy/style/filereader.py: Re-write comment.
518         (TextFileReader.process_file): Add comment explaining treatment of None in
519         file-to-line-number mapping.
520         (TextFileReader.delete_file): Collapse call.
521
522 2017-07-19  Chris Dumez  <cdumez@apple.com>
523
524         Unreviewed attempt to fix API test failure after r219663.
525
526         The test was hard-coding an exception string and the string has changed slightly
527         in r219663.
528
529         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
530         (TEST):
531
532 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
533
534         Don't write file URLs to iOS Pasteboard
535         https://bugs.webkit.org/show_bug.cgi?id=174647
536         <rdar://problem/33199730>
537
538         Reviewed by Wenson Hsieh.
539
540         Updating tests to reflect the lack of file URLs for images.
541
542         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
543         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
544         (checkEstimatedSize):
545         (TestWebKitAPI::TEST):
546
547 2017-07-19  Brady Eidson  <beidson@apple.com>
548
549         iBooks sometimes crashes when closing a book.
550         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
551
552         Reviewed by Oliver Hunt.
553
554         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
555         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
556         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
557         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
558         (TestWebKitAPI::TEST):
559
560         Add a "spin the runloop X number of times" utility:
561         * TestWebKitAPI/Utilities.h:
562         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
563         (TestWebKitAPI::Util::spinRunLoop):
564
565 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
566
567         lint-test-expectations should be run during style checking
568         https://bugs.webkit.org/show_bug.cgi?id=173559
569         <rdar://problem/32854941>
570
571         Reviewed by David Kilzer.
572
573         Running the test expectation linter requires reading both files and lines not in the
574         patch because, for example, deletion of a test can cause a lint failure even though
575         no test expectations where modified. This means that the linter will occasionally warn
576         about lines which were not changed in a given patch but whose error is related to a
577         change made in that patch.
578
579         * Scripts/webkitpy/common/system/filesystem_mock.py:
580         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
581         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
582         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
583         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
584         content, description of the error and the name of the associated test.
585         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
586         (TestExpectationParser.__init__): Pass shorten_filename function to
587         TestExpectationsParser to add a deleted file to the related_files dictionary.
588         (TestExpectationParser._check_test_exists): If the test does not exist, add the
589         missing path to the related_files dictionary.
590         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
591         files and line numbers related to this test expectation line. This will allow
592         tracking linter errors in the style checker occurring across multiple files.
593         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
594         lines to related_files dictionary.
595         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
596         (TestExpectations._report_warnings): Construct warning object instead of string
597         when adding to warnings list.
598         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
599         clean-up log.
600         * Scripts/webkitpy/style/checker.py:
601         (ProcessorBase.do_association_check): Add required function for processor classes.
602         (StyleProcessor):
603         (StyleProcessor.do_association_check): Run the TestExpectations linter when
604         checking for errors between associated files.
605         * Scripts/webkitpy/style/checkers/test_expectations.py:
606         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
607         (TestExpectationsChecker):
608         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
609         of modified files, the current working directory and the host, determine if the linter
610         warning is associated with the changes.
611         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
612         style checker.
613         * Scripts/webkitpy/style/filereader.py:
614         (TextFileReader):
615         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
616         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
617         (TextFileReader.process_file): Track both the number of files changed and which lines
618         in those files were changed.
619         (TextFileReader.do_association_check): Run the processor's association check on all
620         modified or deleted files processed by TextFileReader.
621         (TextFileReader.delete_file): Track deleted files in _files dictionary.
622         (TextFileReader.count_delete_only_file): Deleted.
623         * Scripts/webkitpy/style/filereader_unittest.py:
624         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
625         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
626         * Scripts/webkitpy/style/main.py:
627         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
628         explicitly run the association check on the file reader.
629         * Scripts/webkitpy/style/main_unittest.py:
630         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
631         embedded in the style checker.
632         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
633         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
634         construct the TextFileReader object with a StyleProcessor used to run style checks on
635         specific files.
636         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
637         testing the test expectation linter inside the style checker. This host must contain a
638         mock file system with the basic structure of test expectations.
639         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
640         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
641         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
642         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
643         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
644         * Scripts/webkitpy/style/patchreader.py:
645         (PatchReader.check): Specify which file was deleted, run the association check.
646         * Scripts/webkitpy/style/patchreader_unittest.py:
647         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
648         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
649         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
650
651 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
652
653         [WTF] Implement WTF::ThreadGroup
654         https://bugs.webkit.org/show_bug.cgi?id=174081
655
656         Reviewed by Mark Lam.
657
658         Add WTF::ThreadGroup tests.
659
660         * TestWebKitAPI/CMakeLists.txt:
661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
662         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
663         (TestWebKitAPI::testThreadGroup):
664         (TestWebKitAPI::TEST):
665
666 2017-07-18  Andy Estes  <aestes@apple.com>
667
668         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
669         https://bugs.webkit.org/show_bug.cgi?id=174631
670
671         Reviewed by Tim Horton.
672
673         * DumpRenderTree/mac/Configurations/Base.xcconfig:
674         * MiniBrowser/Configurations/Base.xcconfig:
675         * MobileMiniBrowser/Configurations/Base.xcconfig:
676         * TestWebKitAPI/Configurations/Base.xcconfig:
677         * WebKitTestRunner/Configurations/Base.xcconfig:
678
679 2017-07-18  Andy Estes  <aestes@apple.com>
680
681         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
682         https://bugs.webkit.org/show_bug.cgi?id=174631
683
684         Reviewed by Sam Weinig.
685
686         * DumpRenderTree/mac/Configurations/Base.xcconfig:
687         * MiniBrowser/Configurations/Base.xcconfig:
688         * MobileMiniBrowser/Configurations/Base.xcconfig:
689         * TestWebKitAPI/Configurations/Base.xcconfig:
690         * WebKitTestRunner/Configurations/Base.xcconfig:
691
692 2017-07-18  Daniel Bates  <dabates@apple.com>
693
694         lldb: Add type summary for StringView
695         https://bugs.webkit.org/show_bug.cgi?id=174637
696
697         Reviewed by Sam Weinig.
698
699         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
700         StringView object will print output that has the form:
701
702             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
703               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
704               m_length = 2
705               m_is8Bit = true
706               m_underlyingString = 0x0000614000000a90
707             }
708
709         * lldb/lldb_webkit.py:
710         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
711         (WTFStringView_SummaryProvider):
712         (WTFStringViewProvider):
713         (WTFStringViewProvider.__init__):
714         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
715         (WTFStringViewProvider.get_length): Access field StringView.m_length.
716         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
717         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
718
719 2017-07-18  Andy Estes  <aestes@apple.com>
720
721         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
722         https://bugs.webkit.org/show_bug.cgi?id=174631
723
724         Reviewed by Dan Bernstein.
725
726         * DumpRenderTree/mac/Configurations/Base.xcconfig:
727         * MiniBrowser/Configurations/Base.xcconfig:
728         * MobileMiniBrowser/Configurations/Base.xcconfig:
729         * TestWebKitAPI/Configurations/Base.xcconfig:
730         * WebKitTestRunner/Configurations/Base.xcconfig:
731
732 2017-07-18  Devin Rousso  <drousso@apple.com>
733
734         Web Inspector: Add memoryCost to Inspector Protocol objects
735         https://bugs.webkit.org/show_bug.cgi?id=174478
736
737         Reviewed by Joseph Pecoraro.
738
739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
740         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
741         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
742         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
743         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
744         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
745         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
746         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
747         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
748         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
749         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
750         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
751         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
752         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
753         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
754         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
755         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
756
757 2017-07-18  Andy Estes  <aestes@apple.com>
758
759         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
760         https://bugs.webkit.org/show_bug.cgi?id=174631
761
762         Reviewed by Darin Adler.
763
764         * DumpRenderTree/mac/Configurations/Base.xcconfig:
765         * MiniBrowser/Configurations/Base.xcconfig:
766         * MobileMiniBrowser/Configurations/Base.xcconfig:
767         * TestWebKitAPI/Configurations/Base.xcconfig:
768         * WebKitTestRunner/Configurations/Base.xcconfig:
769
770 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
771
772         Unreviewed, fix the iOS build.
773
774         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
775
776         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
777         (TestWebKitAPI::TEST):
778
779 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
780
781         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
782         https://bugs.webkit.org/show_bug.cgi?id=174585
783         <rdar://problem/33302541>
784
785         Reviewed by Tim Horton.
786
787         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
788         being dragged when initiating a drag.
789
790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
791         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
792         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
793         (TestWebKitAPI::TEST):
794         * TestWebKitAPI/cocoa/TestWKWebView.h:
795
796         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
797
798         * TestWebKitAPI/cocoa/TestWKWebView.mm:
799         (-[TestWKWebView synchronouslyLoadHTMLString:]):
800
801 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
802
803         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
804         https://bugs.webkit.org/show_bug.cgi?id=174547
805
806         Reviewed by Alex Christensen.
807
808         * DumpRenderTree/PlatformWin.cmake:
809         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
810
811 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
812
813         Update style checker to deal with "final"
814         https://bugs.webkit.org/show_bug.cgi?id=174528
815
816         Reviewed by Alex Christensen.
817         
818         check-webkit-style shouldn't complain about an open brace to start a
819         line after a function definition with "final" or "const final".
820
821         * Scripts/webkitpy/style/checkers/cpp.py:
822         (check_braces):
823         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
824         (CppStyleTest.test_brace_at_begin_of_line):
825
826 2017-07-17  Alex Christensen  <achristensen@webkit.org>
827
828         Modernize content extension code
829         https://bugs.webkit.org/show_bug.cgi?id=174588
830
831         Reviewed by Sam Weinig.
832
833         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
834         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
835         (TestWebKitAPI::testRequest):
836         (TestWebKitAPI::makeBackend):
837         (TestWebKitAPI::TEST_F):
838
839 2017-07-17  Brady Eidson  <beidson@apple.com>
840
841         WKHTTPCookieStore observing only works on the default cookie store.
842         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
843
844         Reviewed by Sam Weinig.
845
846         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
847         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
848           called for the default store, a non-persistent store, and a custom store.
849         (TEST):
850
851 2017-07-16  Sam Weinig  <sam@webkit.org>
852
853         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
854         https://bugs.webkit.org/show_bug.cgi?id=174575
855
856         Reviewed by Brady Eidson.
857
858         * Scripts/svn-create-patch:
859         (findModificationType):
860         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
861         default value of "unknown".
862
863         (generateFileList):
864         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
865         for untracked, which matches our old behavior.
866
867 2017-07-17  Charlie Turner  <cturner@igalia.com>
868
869         Add some missing build dependencies on Fedora
870         https://bugs.webkit.org/show_bug.cgi?id=174578
871
872         Unreviewed dependency update.
873
874         * gtk/install-dependencies:
875
876 2017-07-16  Brady Eidson  <beidson@apple.com>
877
878         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
879         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
880
881         Reviewed by Tim Horton.
882
883         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
884         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
885         (TEST):
886
887 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
888
889         [GTK] Sort inspector GResource manifest to ensure reproducible builds
890         https://bugs.webkit.org/show_bug.cgi?id=174540
891
892         Reviewed by Michael Catanzaro.
893
894         * gtk/generate-inspector-gresource-manifest.py:
895         (get_filenames): sort list of input files
896
897 2017-07-15  Brady Eidson  <beidson@apple.com>
898
899         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
900         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
901
902         Reviewed by Tim Horton.
903
904         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
905         (TEST): Make this test more reliable by clearing everything beforehand.
906
907 2017-07-15  David Kilzer  <ddkilzer@apple.com>
908
909         Make it possible to extend check-webkit-style with Apple-internal checkers
910         <https://webkit.org/b/174464>
911         <rdar://problem/25564402>
912
913         Reviewed by Darin Adler.
914
915         * Scripts/webkitpy/style/checker.py: Import apple_additions.
916         (_all_categories): Add categories from apple_additions() if it
917         exists.
918         (CheckerDispatcher._create_checker): Create python checker
919         from apple_additions() if it exists.
920
921 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
922
923         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
924         https://bugs.webkit.org/show_bug.cgi?id=174539
925         <rdar://problem/33307395>
926
927         Reviewed by Darin Adler.
928
929         Adds a new unit test suite to cover action sheet popover presentation.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
933         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
934         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
935
936         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
937
938         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
939         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
940
941         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
942
943         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
944         (TestWebKitAPI::TEST):
945
946 2017-07-15  Sam Weinig  <sam@webkit.org>
947
948         [Scripts] Make svn-create-patch work better when called in sub directories
949         https://bugs.webkit.org/show_bug.cgi?id=174551
950
951         Reviewed by Darin Adler.
952
953         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
954           by ensuring that the prefix is applied as is done in generateDiff.
955         - Silence output of explanatory lines from svn stat (" > move to ...")
956           that show up in STDERR when running svn-create-patch.
957         - Add verbose logging that I found useful while debugging this issue.
958
959         * Scripts/svn-create-patch:
960         (findBaseUrl):
961         (findMimeType):
962         (findSourceFileAndRevision):
963         (generateDiff):
964         (generateFileList):
965         (manufacturePatchForAdditionWithHistory):
966
967 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
968
969         Unreviewed build fix after r219537.
970
971         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
972
973 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
974
975         Add iOS 11 SPI
976         https://bugs.webkit.org/show_bug.cgi?id=174430
977         <rdar://problem/33269288>
978
979         Reviewed by Tim Horton.
980
981         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
982         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
983         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
984
985 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
986
987         Failing to install on iPad simulators
988         https://bugs.webkit.org/show_bug.cgi?id=174532
989         <rdar://problem/33328347>
990
991         Reviewed by Stephanie Lewis.
992
993         * Scripts/webkitpy/xcode/simulated_device.py:
994         (SimulatedDevice.install_app): Place install command in retry try-except block.
995
996 2017-07-14  Jeff Miller  <jeffm@apple.com>
997
998         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
999         https://bugs.webkit.org/show_bug.cgi?id=174524
1000
1001         Reviewed by Sam Weinig.
1002
1003         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1004         (TEST):
1005         Renamed TestParameter to TestParameter1.
1006         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1007
1008         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1009         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1010         Observe changes for two bundle parameters.
1011
1012         (-[BundleParametersPlugIn dealloc]):
1013         Remove observers for two bundle parameters.
1014
1015 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1016
1017         Unreviewed, rolling out r219510.
1018         https://bugs.webkit.org/show_bug.cgi?id=174525
1019
1020         Need to revert length() == 0 check for null string (Requested
1021         by yusukesuzuki on #webkit).
1022
1023         Reverted changeset:
1024
1025         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1026         static string if StringImpl is static"
1027         https://bugs.webkit.org/show_bug.cgi?id=174501
1028         http://trac.webkit.org/changeset/219510
1029
1030 2017-07-14  Jer Noble  <jer.noble@apple.com>
1031
1032         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1033         https://bugs.webkit.org/show_bug.cgi?id=174514
1034
1035         Reviewed by Sam Weinig.
1036
1037         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1038         (TestWebKitAPI::TEST_F):
1039
1040 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1041
1042         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1043         https://bugs.webkit.org/show_bug.cgi?id=174501
1044
1045         Reviewed by Darin Adler.
1046
1047         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1048         (TestWebKitAPI::TEST):
1049
1050 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1051
1052         Bring mac expectations in-line with other platforms
1053         https://bugs.webkit.org/show_bug.cgi?id=174472
1054         <rdar://problem/33297388>
1055
1056         Reviewed by David Kilzer.
1057
1058         The override order for Mac test expectations does not conform to the pattern used by iOS,
1059         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1060
1061             platform/mac-wk2
1062             platform/wk2
1063             platform/mac-elcapitan
1064             platform/mac-sierra
1065             generic
1066
1067         After this change, El Capitan's baseline search path looks like this:
1068
1069             platform/mac-sierra-wk2
1070             platform/mac-sierra
1071             platform/mac-wk2
1072             platform/wk2
1073             generic
1074
1075         * Scripts/webkitpy/port/mac.py:
1076         (MacPort.__init__): If a specific version is specified in the port name, use that
1077         as the os version.
1078         (MacPort.default_baseline_search_path): Expectation search paths should work the
1079         same way they do on other ports. Port + version overrides port, port overrides generic
1080         and wk1/wk2 should override expectations for the two combined.
1081         * Scripts/webkitpy/port/mac_unittest.py:
1082         (MacTest.test_tests_for_other_platforms): Deleted.
1083         (MacTest._assert_search_path): Deleted.
1084         (MacTest.test_baseline_search_path): Deleted.
1085         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1086         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1087         (test_rebaseline_test_and_print_scm_changes): Ditto.
1088         (test_rebaseline_and_copy_test): Ditto.
1089         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1090         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1091         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1092
1093 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1094
1095         Fix style checker unit test
1096
1097         Unreviewed WebKit2 => WebKit fixup.
1098
1099         * Scripts/webkitpy/style/checker_unittest.py:
1100         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1101
1102 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1103
1104         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1105
1106         Unreviewed build fix.
1107
1108         r219492 missed one hunk from its partial revert of r219489.
1109         This patch reverts that hunk.
1110
1111         * TestWebKitAPI/CMakeLists.txt:
1112
1113 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1114
1115         Use the old WebKit/WebKit2 targets for CMake builds.
1116
1117         Unreviewed build fix.
1118
1119         We can update the target names to match the Framework names in a future patch.
1120         This is a partial revert of r219489.
1121
1122         * TestWebKitAPI/CMakeLists.txt:
1123         WebKitLegacy => WebKit
1124         WebKit => WebKit2
1125
1126 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1127
1128         Fix TestWebKit API.
1129         https://bugs.webkit.org/show_bug.cgi?id=174164
1130         rdar://problem/33137595
1131
1132         Reviewed by Dan Bernstein.
1133
1134         * TestWebKitAPI/CMakeLists.txt:
1135         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1136         * TestWebKitAPI/PlatformGTK.cmake:
1137
1138 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1139
1140         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1141         https://bugs.webkit.org/show_bug.cgi?id=174164
1142         rdar://problem/33137595
1143
1144         Reviewed by Dan Bernstein.
1145
1146         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1147         (ShouldBuildTest):
1148         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1149         * Scripts/build-webkit:
1150         * Scripts/do-file-rename:
1151         * Scripts/do-webcore-rename:
1152         * Scripts/update-webkit-localizable-strings:
1153         * Scripts/webkitpy/common/config/watchlist:
1154         * Scripts/webkitpy/style/checker.py:
1155         * Scripts/webkitpy/style/checkers/featuredefines.py:
1156         * gtk/make-dist.py:
1157         (ensure_version_if_possible):
1158         * gtk/manifest.txt.in:
1159
1160 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1161
1162         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1163         https://bugs.webkit.org/show_bug.cgi?id=174162
1164         rdar://problem/33137594
1165
1166         Reviewed by Dan Bernstein.
1167
1168         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1169
1170         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1171         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1172         * EWSTools/configure-clang-linux.sh:
1173         * Scripts/build-webkit:
1174         * Scripts/do-file-rename:
1175         * Scripts/do-webcore-rename:
1176         * Scripts/update-webkit-localizable-strings:
1177         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1178         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1179         * Scripts/webkitpy/style/checkers/featuredefines.py:
1180         * gtk/manifest.txt.in:
1181
1182 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1183
1184         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1185         https://bugs.webkit.org/show_bug.cgi?id=174438
1186         <rdar://problem/33277112>
1187
1188         Reviewed by Aakash Jain.
1189
1190         Given a patch, this will convert the changes from the path to the new directory structure.
1191
1192         * Scripts/rebase-patch-after-webkit-move: Added.
1193         (append_source): Append 'Source' to the provided path.
1194         (is_editable_line): Return true if a line the script expects to modify.
1195         (needs_rebase): Return if a line needs to be rebased based on it's content.
1196         (rebase_line): Rebase the provided line.
1197         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1198         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1199         were provided.
1200
1201 2017-07-12  Nan Wang  <n_wang@apple.com>
1202
1203         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1204         https://bugs.webkit.org/show_bug.cgi?id=174393
1205         <rdar://problem/33248006>
1206
1207         Reviewed by Chris Fleizach.
1208
1209         * DumpRenderTree/AccessibilityUIElement.cpp:
1210         (textMarkerRangeMatchesTextNearMarkersCallback):
1211         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1212         (AccessibilityUIElement::getJSClass):
1213         * DumpRenderTree/AccessibilityUIElement.h:
1214         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1215         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1216         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1217         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1218         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1219         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1220         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1221         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1222
1223 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1224
1225         Unreviewed, rolling out r219409.
1226
1227         The revision caused the Windows builds to fail.
1228
1229         Reverted changeset:
1230
1231         "AX: [iOS] Implement a way to retrieve a text marker range
1232         with desired text that is closest to a position"
1233         https://bugs.webkit.org/show_bug.cgi?id=174393
1234         http://trac.webkit.org/changeset/219409
1235
1236 2017-07-12  Nan Wang  <n_wang@apple.com>
1237
1238         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1239         https://bugs.webkit.org/show_bug.cgi?id=174393
1240         <rdar://problem/33248006>
1241
1242         Reviewed by Chris Fleizach.
1243
1244         * DumpRenderTree/AccessibilityUIElement.cpp:
1245         (textMarkerRangeMatchesTextNearMarkersCallback):
1246         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1247         (AccessibilityUIElement::getJSClass):
1248         * DumpRenderTree/AccessibilityUIElement.h:
1249         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1250         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1251         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1252         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1253         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1254         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1255         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1256         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1257
1258 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1259
1260         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1261         https://bugs.webkit.org/show_bug.cgi?id=174197
1262
1263         Reviewed by Darin Adler.
1264
1265         This bit me the first time I tried to submit a patch to WebKit, and still I have
1266         to manually edit the ChangeLog every time I use the script.
1267
1268         This generates a more convenient and standard ChangeLog entry.
1269
1270         * Scripts/prepare-ChangeLog:
1271         (generateNewChangeLogs):
1272
1273 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1274
1275         Unreviewed, rolling out r219401.
1276
1277         This revision rolled out the previous patch, but after talking
1278         with reviewer, a rebaseline is what was needed.Rolling back in
1279         before rebaseline.
1280
1281         Reverted changeset:
1282
1283         "Unreviewed, rolling out r219379."
1284         https://bugs.webkit.org/show_bug.cgi?id=174400
1285         http://trac.webkit.org/changeset/219401
1286
1287 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1288
1289         Unreviewed, rolling out r219379.
1290
1291         This revision caused a consistent failure in the test
1292         fast/dom/Window/property-access-on-cached-window-after-frame-
1293         removed.html.
1294
1295         Reverted changeset:
1296
1297         "Remove NAVIGATOR_HWCONCURRENCY"
1298         https://bugs.webkit.org/show_bug.cgi?id=174400
1299         http://trac.webkit.org/changeset/219379
1300
1301 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1302
1303         [WPE] Use libepoxy
1304         https://bugs.webkit.org/show_bug.cgi?id=172104
1305
1306         Reviewed by Michael Catanzaro.
1307
1308         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1309         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1310
1311 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1312
1313         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1314         https://bugs.webkit.org/show_bug.cgi?id=174363
1315
1316         Reviewed by Michael Catanzaro.
1317
1318         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1319         between the GTK+ and WPE port. There's no reason for the two ports to apply
1320         different patches over same versions of GStreamer releases.
1321
1322         This aligns the two ports on this specific issue. Next we'll look into
1323         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1324         to keep these patches in a single place, avoiding duplicate files.
1325
1326         * gtk/jhbuild.modules:
1327         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1328         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1329         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1330         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1331
1332 2017-07-11  Dean Jackson  <dino@apple.com>
1333
1334         Remove NAVIGATOR_HWCONCURRENCY
1335         https://bugs.webkit.org/show_bug.cgi?id=174400
1336
1337         Reviewed by Sam Weinig.
1338
1339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1340
1341 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1342
1343         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1344         https://bugs.webkit.org/show_bug.cgi?id=174239
1345
1346         Reviewed by Brady Eidson.
1347
1348         Create windows with specific features set and make sure those are properly reflected in the
1349         WKWindowFeatures object.
1350
1351         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1352         (resetToConsistentState):
1353         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1354         (TEST):
1355
1356 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1357
1358         Do not duplicate files when deleting directories with svn 1.9
1359         https://bugs.webkit.org/show_bug.cgi?id=174339
1360         <rdar://problem/33226781>
1361
1362         Reviewed by David Kilzer.
1363
1364         * Scripts/svn-create-patch:
1365         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1366         (generateFileList): Determine which files are deleted because they are part of a
1367         directory being deleted.
1368
1369 2017-07-11  Dean Jackson  <dino@apple.com>
1370
1371         Rolling out r219372.
1372
1373         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1374
1375 2017-07-11  Dean Jackson  <dino@apple.com>
1376
1377         Remove NAVIGATOR_HWCONCURRENCY
1378         https://bugs.webkit.org/show_bug.cgi?id=174400
1379
1380         Reviewed by Sam Weinig.
1381
1382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1383
1384 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1385
1386         Teach build workers to fetch archives from S3.
1387         https://bugs.webkit.org/show_bug.cgi?id=174384
1388
1389         Reviewed by Aakash Jain.
1390
1391         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1392         (DownloadBuiltProduct):
1393
1394 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1395
1396         Configure buildbot to transfer all archives to S3.
1397         Previously this was Mac only, but it's time to expand!
1398         https://bugs.webkit.org/show_bug.cgi?id=174378
1399         
1400         Reviewed by Aakash Jain.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1403         (BuildFactory.__init__):
1404
1405 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1406
1407         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1408         https://bugs.webkit.org/show_bug.cgi?id=174350
1409
1410         Reviewed by Xabier Rodriguez-Calvar.
1411
1412         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1413         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1414         patches are removed. The patches for gst-plugins-good are updated, removing
1415         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1416         rtpbin elements that will help with the EMEv3 development.
1417
1418         * wpe/jhbuild.modules:
1419         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1420         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1421         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1422         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1423         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1424         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1425         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1426         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1427         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1428
1429 2017-07-10  John Wilander  <wilander@apple.com>
1430
1431         Resource Load Statistics: Prune statistics in orders of importance
1432         https://bugs.webkit.org/show_bug.cgi?id=174215
1433         <rdar://problem/33164403>
1434
1435         Reviewed by Chris Dumez.
1436
1437         Nest infrastructure. Adds these functions:
1438         1. testRunner.setStatisticsLastSeen()
1439         2. setStatisticsMaxStatisticsEntries()
1440         3. setStatisticsPruneEntriesDownTo()
1441
1442         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1444         (WTR::TestRunner::setStatisticsLastSeen):
1445         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1446         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1447         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::TestController::setStatisticsLastSeen):
1450         (WTR::TestController::setMaxStatisticsEntries):
1451         (WTR::TestController::setPruneEntriesDownTo):
1452         * WebKitTestRunner/TestController.h:
1453         * WebKitTestRunner/TestInvocation.cpp:
1454         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1455         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1456         (WTR::TestController::setStatisticsLastSeen):
1457         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1458         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1459
1460 2017-07-03  Brian Burg  <bburg@apple.com>
1461
1462         Web Replay: remove some unused code
1463         https://bugs.webkit.org/show_bug.cgi?id=173903
1464
1465         Rubber-stamped by Joseph Pecoraro.
1466
1467         * Scripts/run-input-generator-tests: Removed.
1468         * Scripts/webkitpy/replay/__init__.py: Removed.
1469         * Scripts/webkitpy/replay/main.py: Removed.
1470
1471 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1472
1473         [WPE] Fix layout test baseline and TestExpectations hierarchy
1474         https://bugs.webkit.org/show_bug.cgi?id=174092
1475
1476         Reviewed by Michael Catanzaro.
1477
1478         Like for the GTK+ port, override the default_baseline_search_path() and
1479         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1480         Both methods operate on a short list of search paths that defaults to 'wpe' and
1481         'wk2', along with any other user-specified platform directory.
1482
1483         The test_expectations_file_position() method is overridden for testing purposes,
1484         and relevant unit tests are added.
1485
1486         * Scripts/webkitpy/port/wpe.py:
1487         (WPEPort._search_paths):
1488         (WPEPort):
1489         (WPEPort.default_baseline_search_path):
1490         (WPEPort._port_specific_expectations_files):
1491         (WPEPort.test_expectations_file_position):
1492         * Scripts/webkitpy/port/wpe_unittest.py:
1493         (WPEPortTest.test_default_baseline_search_path):
1494         (WPEPortTest):
1495         (WPEPortTest.test_port_specific_expectations_files):
1496
1497 2017-07-10  Chris Dumez  <cdumez@apple.com>
1498
1499         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1500         https://bugs.webkit.org/show_bug.cgi?id=174301
1501
1502         Reviewed by Brent Fulgham.
1503
1504         Rename some of the testRunner API for clarity and to better match what it calls
1505         internally.
1506
1507         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1508         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1509         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1510         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1511         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1512         * WebKitTestRunner/TestController.cpp:
1513         (WTR::TestController::statisticsUpdateCookiePartitioning):
1514         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1515         * WebKitTestRunner/TestController.h:
1516         * WebKitTestRunner/TestInvocation.cpp:
1517         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1518         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1519         (WTR::TestController::statisticsUpdateCookiePartitioning):
1520         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1521
1522 2017-07-10  Charlie Turner  <cturner@igalia.com>
1523
1524         [GStreamer] Live twitch.tv videos do not play
1525         https://bugs.webkit.org/show_bug.cgi?id=174222
1526
1527         Reviewed by Michael Catanzaro.
1528
1529         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1530         fixes videos not playing on twitch.tv.
1531
1532         * gtk/jhbuild.modules:
1533
1534 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1535
1536         Add WebGL2 configuration option to build-webkit
1537         https://bugs.webkit.org/show_bug.cgi?id=174251
1538
1539         Reviewed by Michael Catanzaro.
1540
1541         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1542         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1543         is marked as enabled for the Apple Cocoa ports.
1544
1545 2017-07-08  Chris Dumez  <cdumez@apple.com>
1546
1547         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1548         https://bugs.webkit.org/show_bug.cgi?id=174290
1549
1550         Reviewed by Brent Fulgham.
1551
1552         Rename testRunner API to match the new internal API names.
1553
1554         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1556         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1557         (WTR::TestRunner::statisticsSubmitTelemetry):
1558         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1559         * WebKitTestRunner/TestController.cpp:
1560         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1561         (WTR::TestController::statisticsSubmitTelemetry):
1562         * WebKitTestRunner/TestController.h:
1563         * WebKitTestRunner/TestInvocation.cpp:
1564         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1565         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1566         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1567         (WTR::TestController::statisticsSubmitTelemetry):
1568
1569 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1570
1571         Drop NOSNIFF compile flag
1572         https://bugs.webkit.org/show_bug.cgi?id=174289
1573
1574         Reviewed by Michael Catanzaro.
1575
1576         * Scripts/webkitperl/FeatureList.pm:
1577         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1578
1579 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1580
1581         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1582         https://bugs.webkit.org/show_bug.cgi?id=174219
1583         <rdar://problem/32083177>
1584
1585         Reviewed by Ryosuke Niwa.
1586
1587         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1588         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1589         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1590         place.
1591
1592         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1593         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1594         no action is taken when dropping.
1595
1596         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1597         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1598         (TestWebKitAPI::TEST):
1599         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1600         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1601         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1602         (-[MockDragDropSession allowsMoveOperation]):
1603         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1604         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1605         (-[DataInteractionSimulator initWithWebView:]):
1606         (-[DataInteractionSimulator runFrom:to:]):
1607         (-[DataInteractionSimulator _advanceProgress]):
1608         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1609         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1610         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1611
1612 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1613
1614         Unreviewed, rolling out r219238, r219239, and r219241.
1615         https://bugs.webkit.org/show_bug.cgi?id=174265
1616
1617         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1618         (Requested by yusukesuzuki on #webkit).
1619
1620         Reverted changesets:
1621
1622         "[WTF] Implement WTF::ThreadGroup"
1623         https://bugs.webkit.org/show_bug.cgi?id=174081
1624         http://trac.webkit.org/changeset/219238
1625
1626         "Unreviewed, build fix after r219238"
1627         https://bugs.webkit.org/show_bug.cgi?id=174081
1628         http://trac.webkit.org/changeset/219239
1629
1630         "Unreviewed, CLoop build fix after r219238"
1631         https://bugs.webkit.org/show_bug.cgi?id=174081
1632         http://trac.webkit.org/changeset/219241
1633
1634 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1635
1636         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1637         https://bugs.webkit.org/show_bug.cgi?id=174250
1638
1639         Reviewed by Carlos Alberto Lopez Perez.
1640
1641         * Scripts/webkitperl/FeatureList.pm:
1642
1643 2017-07-07  Charlie Turner  <cturner@igalia.com>
1644         [GStreamer] vid.me videos do not play
1645         https://bugs.webkit.org/show_bug.cgi?id=172240
1646
1647         Reviewed by Xabier Rodriguez-Calvar.
1648
1649         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1650         have the existing libsoup build against GNOME to avoid header drift
1651         against GStreamer's linked Soup library.
1652
1653         * gtk/jhbuild.modules:
1654
1655 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1656
1657         Write a support script to enable buildbot to upload to S3
1658         https://bugs.webkit.org/show_bug.cgi?id=174196
1659         
1660         Reviewed by Stephanie Lewis.
1661
1662         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1663         (uploadToS3):
1664         (archiveExists):
1665
1666 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1667
1668         Enabling uploading archives to S3.
1669         https://bugs.webkit.org/show_bug.cgi?id=174198
1670         
1671         Reviewed by Stephanie Lewis.
1672
1673         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1674         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1675         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1676         (TransferToS3): Transfer full and minified archives to S3
1677
1678 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1679
1680         [WTF] Implement WTF::ThreadGroup
1681         https://bugs.webkit.org/show_bug.cgi?id=174081
1682
1683         Reviewed by Mark Lam.
1684
1685         Add WTF::ThreadGroup tests.
1686
1687         * TestWebKitAPI/CMakeLists.txt:
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1690         (TestWebKitAPI::TEST):
1691
1692 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1693
1694         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1695         https://bugs.webkit.org/show_bug.cgi?id=174150
1696
1697         Reviewed by Mark Lam.
1698
1699         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1700         (TestWebKitAPI::TEST):
1701         * TestWebKitAPI/TestsController.cpp:
1702         (TestWebKitAPI::TestsController::TestsController):
1703
1704 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1705
1706         Enabling uploading archives to S3.
1707         https://bugs.webkit.org/show_bug.cgi?id=174198
1708         
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1712         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1713         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1714         (TransferToS3): Transfer full and minified archives to S3
1715
1716 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1717
1718         [GTK][WPE] kill-old-process should kill more webkit related process
1719         https://bugs.webkit.org/show_bug.cgi?id=174220
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         Generate list of possible webkit-related process names and add
1724         them to the list of process to kill.
1725         Also update the possible system related process for GTK+/WPE.
1726
1727         * BuildSlaveSupport/kill-old-processes:
1728         (listAllWebKitPrograms):
1729         (main):
1730
1731 2017-07-06  Chris Dumez  <cdumez@apple.com>
1732
1733         FileMonitor should not be ref counted
1734         https://bugs.webkit.org/show_bug.cgi?id=174166
1735
1736         Reviewed by Brent Fulgham.
1737
1738         Update the API tests to reflect the API change.
1739
1740         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1741         (TestWebKitAPI::TEST_F):
1742
1743 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1744
1745         Unreviewed, rolling out r219194.
1746         https://bugs.webkit.org/show_bug.cgi?id=174207
1747
1748         it broke some layout tests (Requested by clopez on #webkit).
1749
1750         Reverted changeset:
1751
1752         "[GStreamer] vid.me videos do not play"
1753         https://bugs.webkit.org/show_bug.cgi?id=172240
1754         http://trac.webkit.org/changeset/219194
1755
1756 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1757
1758         Unreviewed, rolling out r219178.
1759
1760         This caused a consistent failure with the API test
1761         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1762
1763         Reverted changeset:
1764
1765         "[WTF] Clean up StringStatics.cpp by using
1766         LazyNeverDestroyed<> for Atoms"
1767         https://bugs.webkit.org/show_bug.cgi?id=174150
1768         http://trac.webkit.org/changeset/219178
1769
1770 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1771
1772         Add CWD to Perl library path (no longer the default since 5.26.0)
1773         https://bugs.webkit.org/show_bug.cgi?id=174200
1774
1775         Reviewed by Michael Catanzaro.
1776
1777         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1778         (SetupGitClone._get_username_and_email):
1779
1780 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1781
1782         Unreviewed, update my email address.
1783
1784         * Scripts/webkitpy/common/config/contributors.json:
1785
1786 2017-07-06  Charlie Turner  <cturner@igalia.com>
1787         [GStreamer] vid.me videos do not play
1788         https://bugs.webkit.org/show_bug.cgi?id=172240
1789
1790         Reviewed by Xabier Rodriguez-Calvar.
1791
1792         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1793         have the existing libsoup build against GNOME to avoid header drift
1794         against GStreamer's linked Soup library.
1795
1796         * gtk/jhbuild.modules:
1797
1798 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1799
1800         [WTF] Move SoftLinking.h into WTF
1801         https://bugs.webkit.org/show_bug.cgi?id=174000
1802
1803         Reviewed by Alex Christensen.
1804
1805         * DumpRenderTree/mac/TestRunnerMac.mm:
1806         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1807         (test_primary_header):
1808         (ErrorCollector.__init__): Deleted.
1809         (ErrorCollector.__call__): Deleted.
1810         (ErrorCollector.results): Deleted.
1811         (ErrorCollector.result_list): Deleted.
1812         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1813         (MockIo.open): Deleted.
1814         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1815         (CppFunctionsTest.test_create_acronym): Deleted.
1816         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1817         (CppFunctionsTest.test_parameter): Deleted.
1818         (CppFunctionsTest.test_single_line_view): Deleted.
1819         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1820         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1821         (CppFunctionsTest.test_parameter_list): Deleted.
1822         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1823         (CppStyleTestBase.process_file_data): Deleted.
1824         (CppStyleTestBase.perform_lint): Deleted.
1825         (CppStyleTestBase.perform_single_line_lint): Deleted.
1826         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1827         (CppStyleTestBase.perform_language_rules_check): Deleted.
1828         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1829         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1830         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1831         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1832         (CppStyleTestBase.perform_header_guard_check): Deleted.
1833         (CppStyleTestBase.assert_lint): Deleted.
1834         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1835         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1836         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1837         (CppStyleTestBase.assert_language_rules_check): Deleted.
1838         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1839         (CppStyleTestBase.assert_header_guard): Deleted.
1840         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1841         (CppStyleTestBase.assert_positions_equal): Deleted.
1842         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1843         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1844         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1845         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1846         (FunctionDetectionTest.test_ignore_macros): Deleted.
1847         (FunctionDetectionTest.test_non_functions): Deleted.
1848         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1849         (FunctionDetectionTest.test_parameter_list): Deleted.
1850         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1851         (CppStyleTest.test_asm_lines_ignored): Deleted.
1852         (CppStyleTest.test_get_line_width): Deleted.
1853         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1854         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1855         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1856         (CppStyleTest.test_position): Deleted.
1857         (CppStyleTest.test_rfind_in_lines): Deleted.
1858         (CppStyleTest.test_close_expression): Deleted.
1859         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1860         (CppStyleTest.test_cstyle_cast): Deleted.
1861         (CppStyleTest.test_runtime_casting): Deleted.
1862         (CppStyleTest.test_runtime_selfinit): Deleted.
1863         (CppStyleTest.test_runtime_rtti): Deleted.
1864         (CppStyleTest.test_static_cast_readability): Deleted.
1865         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1866         (CppStyleTest.void): Deleted.
1867         (CppStyleTest.test_deprecated_cast): Deleted.
1868         (CppStyleTest.test_mock_method): Deleted.
1869         (CppStyleTest.test_sizeof_type): Deleted.
1870         (CppStyleTest.cases): Deleted.
1871         (CppStyleTest.for): Deleted.
1872         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1873         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1874         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1875         (CppStyleTest.test_include_what_you_use): Deleted.
1876         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1877         (CppStyleTest.test_cleanse_line): Deleted.
1878         (CppStyleTest.test_multi_line_comments): Deleted.
1879         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1880         (CppStyleTest.test_multiline_strings): Deleted.
1881         (CppStyleTest.test_platformh_comments): Deleted.
1882         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1883         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1884         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1885         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1886         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1887         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1888         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1889         (CppStyleTest.test_check_posix_threading): Deleted.
1890         (CppStyleTest.test_insecure_string_operations): Deleted.
1891         (CppStyleTest.test_format_strings): Deleted.
1892         (CppStyleTest.test_insecure_temp_file): Deleted.
1893         (CppStyleTest.test_variable_length_array_detection): Deleted.
1894         (CppStyleTest.test_braces): Deleted.
1895         (CppStyleTest.test_check_check): Deleted.
1896         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1897         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1898         (CppStyleTest.test_spacing_for_fncall): Deleted.
1899         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1900         (CppStyleTest.test_spacing_before_braces): Deleted.
1901         (CppStyleTest.test_spacing_between_braces): Deleted.
1902         (CppStyleTest.test_spacing_before_brackets): Deleted.
1903         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1904         (CppStyleTest.test_objective_c_block): Deleted.
1905         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1906         (CppStyleTest.test_spacing_around_else): Deleted.
1907         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1908         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1909         (CppStyleTest.test_operator_methods): Deleted.
1910         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1911         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1912         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1913         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1914         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1915         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1916         (CppStyleTest.test_space_after_comment_marker): Deleted.
1917         (CppStyleTest.test_newline_at_eof): Deleted.
1918         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1919         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1920         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1921         (CppStyleTest.test_invalid_utf8): Deleted.
1922         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1923         (CppStyleTest.test_is_blank_line): Deleted.
1924         (CppStyleTest.test_blank_lines_check): Deleted.
1925         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1926         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1927         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1928         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1929         (CppStyleTest.test_comma): Deleted.
1930         (CppStyleTest.test_declaration): Deleted.
1931         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1932         (CppStyleTest.test_indent): Deleted.
1933         (CppStyleTest.test_indent.Foo): Deleted.
1934         (CppStyleTest.test_not_alabel): Deleted.
1935         (CppStyleTest.test_tab): Deleted.
1936         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1937         (CppStyleTest.test_build_class): Deleted.
1938         (CppStyleTest.test_build_class.definitions): Deleted.
1939         (CppStyleTest.test_build_class.Foo): Deleted.
1940         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1941         (CppStyleTest.test_build_end_comment): Deleted.
1942         (CppStyleTest.test_build_forward_decl): Deleted.
1943         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1944         (CppStyleTest.test_build_header_guard): Deleted.
1945         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1946         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1947         (CppStyleTest.test_build_printf_format): Deleted.
1948         (CppStyleTest.test_runtime_printf_format): Deleted.
1949         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1950         (CppStyleTest.test_build_storage_class): Deleted.
1951         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1952         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1953         (CppStyleTest.test_build_storage_class.after): Deleted.
1954         (CppStyleTest.test_build_storage_class.is): Deleted.
1955         (CppStyleTest.test_legal_copyright): Deleted.
1956         (CppStyleTest.test_invalid_increment): Deleted.
1957         (CppStyleTest.test_enum_bitfields): Deleted.
1958         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1959         (CleansedLinesTest.test_init_empty): Deleted.
1960         (CleansedLinesTest.test_collapse_strings): Deleted.
1961         (OrderOfIncludesTest.tearDown): Deleted.
1962         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1963         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1964         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1965         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1966         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1967         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1968         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1969         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1970         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1971         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1972         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1973         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1974         (OrderOfIncludesTest.test_primary_header): Deleted.
1975         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1976         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1977         (OrderOfIncludesTest.test_classify_include): Deleted.
1978         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1979         (CheckForFunctionLengthsTest.tearDown): Deleted.
1980         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1981         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1982         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1983         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1984         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1985         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1986         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1987         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1988         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1989         (CheckForFunctionLengthsTest.function_body): Deleted.
1990         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1991         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1992         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1993         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1994         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1995         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1996         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1997         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1998         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1999         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2000         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2001         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2002         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2003         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2004         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2005         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2006         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2007         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2008         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2009         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2010         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2011         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2012         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2013         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2014         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2015         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2016         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2017         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2018         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2019         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2020         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2021         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2022         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2023         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2024         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2025         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2026         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2027         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2028         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2029         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2030         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2031         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2032         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2033         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2034         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2035         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2036         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2037         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2038         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2039         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2040         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2041         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2042         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2043         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2044         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2045         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2046         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2047         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2048         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2049         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2050         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2051         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2052         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2053         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2054         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2055         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2056         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2057         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2058         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2059         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2060         (LeakyPatternTest.test_get_dc): Deleted.
2061         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2062         (LeakyPatternTest.test_own_get_dc): Deleted.
2063         (LeakyPatternTest.test_create_dc): Deleted.
2064         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2065         (WebKitStyleTest.test_indentation): Deleted.
2066         (WebKitStyleTest.test_indentation.Foo): Deleted.
2067         (WebKitStyleTest.test_indentation.Document): Deleted.
2068         (WebKitStyleTest.test_spacing): Deleted.
2069         (WebKitStyleTest.test_line_breaking): Deleted.
2070         (WebKitStyleTest.test_braces): Deleted.
2071         (WebKitStyleTest.test_braces.MyClass): Deleted.
2072         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2073         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2074         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2075         (WebKitStyleTest.test_null_false_zero): Deleted.
2076         (WebKitStyleTest.test_directive_indentation): Deleted.
2077         (WebKitStyleTest.test_using_std): Deleted.
2078         (WebKitStyleTest.test_using_namespace): Deleted.
2079         (WebKitStyleTest.test_max_macro): Deleted.
2080         (WebKitStyleTest.test_min_macro): Deleted.
2081         (WebKitStyleTest.test_wtf_move): Deleted.
2082         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2083         (WebKitStyleTest.test_names): Deleted.
2084         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2085         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2086         (WebKitStyleTest.test_names.declarations): Deleted.
2087         (WebKitStyleTest.test_names.struct): Deleted.
2088         (WebKitStyleTest.test_names.VectorType): Deleted.
2089         (WebKitStyleTest.test_parameter_names): Deleted.
2090         (WebKitStyleTest.test_comments): Deleted.
2091         (WebKitStyleTest.test_webkit_export_check): Deleted.
2092         (WebKitStyleTest.test_member_initialization_list): Deleted.
2093         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2094         (WebKitStyleTest.test_other): Deleted.
2095         (CppCheckerTest.mock_handle_style_error): Deleted.
2096         (CppCheckerTest._checker): Deleted.
2097         (CppCheckerTest.test_init): Deleted.
2098         (CppCheckerTest.test_eq): Deleted.
2099         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2100         (CppCheckerTest.test_ne): Deleted.
2101         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2102         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2103         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2104         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2105         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2106         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2107
2108 2017-07-05  Saam Barati  <sbarati@apple.com>
2109
2110         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2111         https://bugs.webkit.org/show_bug.cgi?id=174188
2112         <rdar://problem/30581423>
2113
2114         Reviewed by Mark Lam.
2115
2116         * Scripts/run-jsc-stress-tests:
2117
2118 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2119
2120         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2121         https://bugs.webkit.org/show_bug.cgi?id=174150
2122
2123         Reviewed by Mark Lam.
2124
2125         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2126         (TestWebKitAPI::TEST):
2127
2128 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2129
2130         Remove copy of ICU headers from WebKit
2131         https://bugs.webkit.org/show_bug.cgi?id=116407
2132
2133         Reviewed by Alex Christensen.
2134
2135         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2136         * TestWebKitAPI/Configurations/Base.xcconfig:
2137         * WebKitTestRunner/Configurations/Base.xcconfig:
2138
2139 2017-07-05  Chris Dumez  <cdumez@apple.com>
2140
2141         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2142         https://bugs.webkit.org/show_bug.cgi?id=174163
2143         <rdar://problem/33067518>
2144
2145         Reviewed by Alex Christensen.
2146
2147         Add API test coverage.
2148
2149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2150         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2151         (TEST):
2152
2153 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2154
2155         When dragging a selection, clearing the selection in dragstart should not crash the web process
2156         https://bugs.webkit.org/show_bug.cgi?id=174142
2157         <rdar://problem/33067501>
2158
2159         Reviewed by Tim Horton.
2160
2161         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2162         drag is starting up.
2163
2164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2165         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2166         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2167         (TestWebKitAPI::TEST):
2168
2169 2017-07-05  Daniel Bates  <dabates@apple.com>
2170
2171         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2172         API navigation
2173         https://bugs.webkit.org/show_bug.cgi?id=174170
2174         <rdar://problem/33140328>
2175
2176         Reviewed by Brady Eidson.
2177
2178         Update tests as needed for the behavior change.
2179
2180         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2181         (TEST):
2182
2183 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2184
2185         Add WebKitPrivateFrameworkStubs for iOS 11
2186         https://bugs.webkit.org/show_bug.cgi?id=173988
2187
2188         Reviewed by David Kilzer.
2189
2190         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2191         should use the same directory for private framework stubs.
2192         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2193
2194 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2195
2196         [MediaStream] Protect request and web view during gUM client callback
2197         https://bugs.webkit.org/show_bug.cgi?id=174096
2198         <rdar://problem/32833102>
2199
2200         Reviewed by Youenn Fablet.
2201
2202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2203         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2204
2205 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2206
2207         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2208
2209         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2210
2211 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2212
2213         Unreviewed, rolling out r219128.
2214
2215         Spoke with engineer who originally submitted, Patch for APi
2216         test to follow.
2217
2218         Reverted changeset:
2219
2220         "Unreviewed, rolling out r219070."
2221         https://bugs.webkit.org/show_bug.cgi?id=174082
2222         http://trac.webkit.org/changeset/219128
2223
2224 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2225
2226         Unreviewed, rolling out r219070.
2227
2228         This revision caused consistent failures of the API test
2229         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2230
2231         Reverted changeset:
2232
2233         "Pasting single words copied to UIPasteboard inserts URLs in
2234         editable areas"
2235         https://bugs.webkit.org/show_bug.cgi?id=174082
2236         http://trac.webkit.org/changeset/219070
2237
2238 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2239
2240         Remove unused EFL logo from bot watcher dashboard
2241         https://bugs.webkit.org/show_bug.cgi?id=174136
2242
2243         Reviewed by Alexey Proskuryakov.
2244
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2247
2248 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2249
2250         [GTK] Add more GTK bots to dashboard
2251         https://bugs.webkit.org/show_bug.cgi?id=174129
2252
2253         Reviewed by Carlos Alberto Lopez Perez.
2254
2255         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2256         them.
2257
2258         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2259         less-essential GTK bots.
2260
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2263         (WebKitBuildbot):
2264
2265 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2266
2267         [WPE] Add WPE to bot watcher dashboard
2268         https://bugs.webkit.org/show_bug.cgi?id=174119
2269
2270         Reviewed by Alexey Proskuryakov.
2271
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2277         (WebKitBuildbot):
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2279         (table.queue-grid tr.platform.linux-wpe img.logo):
2280
2281 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2282
2283         https://bugs.webkit.org/show_bug.cgi?id=174105
2284         
2285         Reviewed by Stephanie Lewis.
2286
2287         * BuildSlaveSupport/built-product-archive:
2288         (main): Add a -minify parser option
2289         (createZip): Pass along the optional Minify argument if requested
2290         (minifySource): This will trim down archives, logic limited to Mac platform.
2291
2292 2017-07-03  Matt Rajca  <mrajca@apple.com>
2293
2294         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2295         https://bugs.webkit.org/show_bug.cgi?id=174103
2296
2297         Reviewed by Alex Christensen.
2298
2299         Added an API test.
2300
2301         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2302         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2303         (TEST): Added test.
2304         * TestWebKitAPI/cocoa/TestWKWebView.h:
2305         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2306         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2307
2308 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2309
2310         Unreviewed, rolling out r219103.
2311
2312         Caused multiple build failures.
2313
2314         Reverted changeset:
2315
2316         "Remove copy of ICU headers from WebKit"
2317         https://bugs.webkit.org/show_bug.cgi?id=116407
2318         http://trac.webkit.org/changeset/219103
2319
2320 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2321
2322         Remove copy of ICU headers from WebKit
2323         https://bugs.webkit.org/show_bug.cgi?id=116407
2324
2325         Reviewed by Alex Christensen.
2326
2327         Use WTF's copy of ICU headers.
2328
2329         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2330         * TestWebKitAPI/Configurations/Base.xcconfig:
2331         * WebKitTestRunner/Configurations/Base.xcconfig:
2332
2333 2017-07-03  Brady Eidson  <beidson@apple.com>
2334
2335         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2336         https://bugs.webkit.org/show_bug.cgi?id=174073
2337
2338         Reviewed by Andy Estes.
2339
2340         * DumpRenderTree/mac/TestRunnerMac.mm:
2341         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2342
2343         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2344         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2345
2346 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2347
2348         Unreviewed, rolling out r219083.
2349
2350         The revision caused an API failure on all testing platforms.
2351
2352         Reverted changeset:
2353
2354         "[MediaStream] Protect request and web view during gUM client
2355         callback"
2356         https://bugs.webkit.org/show_bug.cgi?id=174096
2357         http://trac.webkit.org/changeset/219083
2358
2359 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2360
2361         webkitpy: Properly number duplicated crashlogs
2362         https://bugs.webkit.org/show_bug.cgi?id=172002
2363
2364         Reviewed by Aakash Jain.
2365
2366         * Scripts/webkitpy/common/system/crashlogs.py:
2367         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2368         an increasing integer.
2369         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2370         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2371         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2372         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2373
2374 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2375
2376         WebContent processes crash when the network process crashes with pending connection requests
2377         https://bugs.webkit.org/show_bug.cgi?id=174065
2378         <rdar://problem/30359835>
2379
2380         Reviewed by Tim Horton.
2381
2382         Add a API to ensure UI process tries to relaunch a new network process when the network process
2383         crashes with pending network connection requests.
2384
2385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2387         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2388         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2389         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2390
2391 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2392
2393         [MediaStream] Protect request and web view during gUM client callback
2394         https://bugs.webkit.org/show_bug.cgi?id=174096
2395         <rdar://problem/32833102>
2396
2397         Reviewed by Youenn Fablet.
2398
2399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2400         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2401
2402 2017-07-03  Andy Estes  <aestes@apple.com>
2403
2404         [Xcode] Add an experimental setting to build with ccache
2405         https://bugs.webkit.org/show_bug.cgi?id=173875
2406
2407         Reviewed by Tim Horton.
2408
2409         On systems that already have ccache(1) installed, this patch adds experimental support for
2410         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2411
2412         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2413         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2414         find the toolchain from which to run clang, and then invokes ccache with the required
2415         arguments.
2416
2417         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2418         precompiled headers to work properly [1].
2419
2420         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2421         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2422         during linking.
2423         
2424         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2425
2426         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2427         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2428         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2429         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2430         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2431         * ccache/README.md: Added.
2432         * ccache/ccache-clang: Added.
2433         * ccache/ccache-clang++: Added.
2434         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2435
2436 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2437
2438         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2439         https://bugs.webkit.org/show_bug.cgi?id=174051
2440
2441         Reviewed by Tim Horton.
2442
2443         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2444         (TestWebKitAPI::TEST_F):
2445
2446 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2447
2448         Unreviewed, rolling out r219024.
2449
2450         This patch cause 3 didferent test to fail.
2451
2452         Reverted changeset:
2453
2454         "REGRESSION(r215096) Queries of URLs with non-special schemes
2455         should not percent-encode single quotes"
2456         https://bugs.webkit.org/show_bug.cgi?id=174051
2457         http://trac.webkit.org/changeset/219024
2458
2459 2017-07-03  Chris Dumez  <cdumez@apple.com>
2460
2461         Drop ResourceLoadStatisticsStore's statisticsLock
2462         https://bugs.webkit.org/show_bug.cgi?id=174080
2463
2464         Reviewed by Brent Fulgham.
2465
2466         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2467
2468         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2469         (WTR::TestController::isStatisticsPrevalentResource):
2470         (WTR::TestController::isStatisticsHasHadUserInteraction):
2471         (WTR::TestController::isStatisticsGrandfathered):
2472
2473 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2474
2475         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2476         https://bugs.webkit.org/show_bug.cgi?id=174082
2477         <rdar://problem/33046992>
2478
2479         Reviewed by Tim Horton.
2480
2481         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2482
2483         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2484         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2485         (TestWebKitAPI::TEST):
2486
2487 2017-07-02  Brady Eidson  <beidson@apple.com>
2488
2489         Add API test for all parts of WebKit1 API related to favicons.
2490         https://bugs.webkit.org/show_bug.cgi?id=174069
2491
2492         Reviewed by Andy Estes.
2493
2494         These two API tests cover all WebKit1 API related to icons.
2495         
2496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2497         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2498         (mainResourceData):
2499         (defaultFaviconData):
2500         (customFaviconData):
2501         (imageFromData):
2502         (+[IconLoadingProtocol canInitWithRequest:]):
2503         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2504         (-[IconLoadingProtocol startLoading]):
2505         (-[IconLoadingProtocol stopLoading]):
2506         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2507         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2508         (TestWebKitAPI::TEST):
2509
2510 2017-07-01  Dan Bernstein  <mitz@apple.com>
2511
2512         [iOS] Remove code only needed when building for iOS 9.x
2513         https://bugs.webkit.org/show_bug.cgi?id=174068
2514
2515         Reviewed by Tim Horton.
2516
2517         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2518         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2519         (WTR::initializeWebViewConfiguration):
2520         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2521         (-[HIDEventGenerator _createIOHIDEventType:]):
2522
2523 2017-07-01  Brady Eidson  <beidson@apple.com>
2524
2525         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2526         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2527
2528         Reviewed by Alex Christensen.
2529
2530         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2531
2532 2017-07-01  Dan Bernstein  <mitz@apple.com>
2533
2534         [macOS] Remove code only needed when building for OS X Yosemite
2535         https://bugs.webkit.org/show_bug.cgi?id=174067
2536
2537         Reviewed by Tim Horton.
2538
2539         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2540         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2541         * DumpRenderTree/mac/DumpRenderTree.mm:
2542         (setDefaultsToConsistentValuesForTesting):
2543         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2544         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2545         * MiniBrowser/Configurations/Base.xcconfig:
2546         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2547         * TestWebKitAPI/Configurations/Base.xcconfig:
2548         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2550         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2551         (TestWebKitAPI::TEST_F):
2552         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2553         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2554         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2555         (TestWebKitAPI::TEST_F):
2556         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2557         (TestWebKitAPI::TEST):
2558         * WebKitTestRunner/Configurations/Base.xcconfig:
2559         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2560         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2561         (WTR::InjectedBundle::platformInitialize):
2562         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2563         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2564
2565 2017-07-01  Chris Dumez  <cdumez@apple.com>
2566
2567         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2568         https://bugs.webkit.org/show_bug.cgi?id=174060
2569
2570         Reviewed by Brent Fulgham.
2571
2572         Port WebKitTestRunner over to the new Cocoa SPI.
2573
2574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2575         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2576         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2577         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2578         no-ops since this code runs in the WebContent process, not the
2579         UIProcess.
2580
2581         * WebKitTestRunner/TestController.cpp:
2582         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2583
2584 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2585
2586         Unreviewed mac build fix.
2587
2588         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2589         (TestWebKitAPI::TEST):
2590
2591 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2592
2593         Add API to get WKActivatedElementInfo
2594         https://bugs.webkit.org/show_bug.cgi?id=174001
2595         <rdar://problem/29165518>
2596         
2597         Tests for now SPI to get activatedElementInfo.
2598
2599         Reviewed by Tim Horton.
2600
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2602         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2603         (TestWebKitAPI::TEST):
2604
2605 2017-06-30  Chris Dumez  <cdumez@apple.com>
2606
2607         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2608         https://bugs.webkit.org/show_bug.cgi?id=174038
2609
2610         Reviewed by Brent Fulgham.
2611
2612         Fix typo in API name.
2613
2614         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2615         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2616         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2617         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2618         * WebKitTestRunner/TestController.cpp:
2619         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2620         * WebKitTestRunner/TestController.h:
2621         * WebKitTestRunner/TestInvocation.cpp:
2622         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2623
2624 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2625
2626         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2627         https://bugs.webkit.org/show_bug.cgi?id=174051
2628         <rdar://problem/33002846>
2629
2630         Reviewed by Tim Horton.
2631
2632         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2633         (TestWebKitAPI::TEST_F):
2634
2635 2017-06-30  Daniel Bates  <dabates@apple.com>
2636
2637         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2638         https://bugs.webkit.org/show_bug.cgi?id=165160
2639         <rdar://problem/29451999>
2640
2641         Reviewed by Brady Eidson.
2642
2643         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2644         for navigations and window creation.
2645
2646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2647         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2648         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2649         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2650         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2651         (TEST):
2652
2653 2017-06-29  Jer Noble  <jer.noble@apple.com>
2654
2655         Make Legacy EME API controlled by RuntimeEnabled setting.
2656         https://bugs.webkit.org/show_bug.cgi?id=173994
2657
2658         Reviewed by Sam Weinig.
2659
2660         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2661
2662 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2663
2664         Follow-up fix for r218996
2665
2666         Unreviewed infrastructure fix.
2667
2668         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2669
2670         * Scripts/webkitpy/port/ios_simulator.py:
2671         (IOSSimulatorPort): Memoize ios_version().
2672
2673 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2674
2675         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2676         https://bugs.webkit.org/show_bug.cgi?id=174017
2677         <rdar://problem/32959782>
2678
2679         Reviewed by Simon Fraser.
2680
2681         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2682         changes, the caret would appear outside of the iframe.
2683
2684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2685         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2686         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2687         (checkDragCaretRectIsContainedInRect):
2688         (TestWebKitAPI::TEST):
2689         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2690         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2691         (-[DataInteractionSimulator _resetSimulatedState]):
2692         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2693         (-[DataInteractionSimulator _advanceProgress]):
2694         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2695
2696 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2697
2698         Add support for different versions of iOS when loading test expectations
2699         https://bugs.webkit.org/show_bug.cgi?id=173774
2700         <rdar://problem/32951132>
2701
2702         Rubber-stamped by Aakash Jain.
2703
2704         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2705
2706         * Scripts/webkitpy/port/ios.py:
2707         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2708         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2709         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2710         * Scripts/webkitpy/port/ios_device.py:
2711         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2712         * Scripts/webkitpy/port/ios_device_unittest.py:
2713         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2714         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2715         (IOSDeviceTest.test_expectations_ordering): Ditto.
2716         * Scripts/webkitpy/port/ios_simulator.py:
2717         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2718         ask the platform.
2719
2720 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2721
2722         Fontconfig build breaks with glibc 2.15+
2723         https://bugs.webkit.org/show_bug.cgi?id=174019
2724
2725         Reviewed by Carlos Alberto Lopez Perez.
2726
2727         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2728
2729         * wpe/jhbuild.modules:
2730         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2731
2732 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2733
2734         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2735         https://bugs.webkit.org/show_bug.cgi?id=174010
2736         <rdar://problem/32597802>
2737
2738         Reviewed by Tim Horton.
2739
2740         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2741         snapshot fails for any reason.
2742
2743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2744         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2745         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2746         (TestWebKitAPI::TEST):
2747
2748 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2749
2750         AX: Cannot call setValue() on contenteditable or ARIA text controls
2751         https://bugs.webkit.org/show_bug.cgi?id=173520
2752
2753         Reviewed by Ryosuke Niwa.
2754
2755         Add setValue() method to WKTR (already existed in DRT).
2756
2757         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2758         (WTR::AccessibilityUIElement::setValue):
2759         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2760         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2761         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2762         (WTR::AccessibilityUIElement::setValue):
2763
2764 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2765
2766         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2767         https://bugs.webkit.org/show_bug.cgi?id=173841
2768         rdar://problem/32983841
2769
2770         Reviewed by Dean Jackson.
2771
2772         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2773         always did text zooming.
2774
2775         * MiniBrowser/mac/WK1BrowserWindowController.m:
2776         (-[WK1BrowserWindowController zoomIn:]):
2777         (-[WK1BrowserWindowController zoomOut:]):
2778         (-[WK1BrowserWindowController canResetZoom]):
2779         (-[WK1BrowserWindowController resetZoom:]):
2780
2781 2017-06-29  John Wilander  <wilander@apple.com>
2782
2783         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2784         https://bugs.webkit.org/show_bug.cgi?id=173940
2785         <rdar://problem/33018125>
2786
2787         Reviewed by Brent Fulgham.
2788
2789         This change allows the TestController to turn off
2790         regular resource load statistics telemetry submission
2791         and to manually control when telemetry is calculated
2792         and submitted.
2793
2794         * WebKitTestRunner/TestController.cpp:
2795         (WTR::TestController::initialize):
2796             Turns off automatic resource load statistics telemetry submission.
2797
2798 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2799
2800         Unreviewed, rolling out r218512.
2801         https://bugs.webkit.org/show_bug.cgi?id=173981
2802
2803         "It changes the behavior of the JS API's JSEvaluateScript
2804         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2805
2806         Reverted changeset:
2807
2808         "test262: Completion values for control flow do not match the
2809         spec"
2810         https://bugs.webkit.org/show_bug.cgi?id=171265
2811         http://trac.webkit.org/changeset/218512
2812
2813 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2814
2815         Add WebKitSystemInterface for iOS 11
2816         https://bugs.webkit.org/show_bug.cgi?id=173936
2817
2818         Reviewed by Lucas Forschler.
2819
2820         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2821
2822 2017-06-28  Keith Miller  <keith_miller@apple.com>
2823
2824         VMTraps has some races
2825         https://bugs.webkit.org/show_bug.cgi?id=173941
2826
2827         Reviewed by Michael Saboff.
2828
2829         Add new testing mode for testing the Watchdog with our stress
2830         tests.
2831
2832         * Scripts/run-jsc-stress-tests:
2833
2834 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2835
2836         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2837         https://bugs.webkit.org/show_bug.cgi?id=173877
2838
2839         Reviewed by Brady Eidson.
2840
2841         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2842         the next tests.
2843
2844         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2845         (testGetFavicon):
2846
2847 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2848
2849         MobileSafari was constantly using 10-15% CPU viewing a PDF
2850         https://bugs.webkit.org/show_bug.cgi?id=173944
2851         <rdar://problem/33039910>
2852
2853         Reviewed by Simon Fraser.
2854
2855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2856         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2857         Add a test that we ever call the stable presentation update callback
2858         when we have a WKPDFView up, instead of infinitely looping.
2859
2860 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2861
2862         Prevent displaying URLs with small capital letters
2863         https://bugs.webkit.org/show_bug.cgi?id=173949
2864         <rdar://problem/32952058>
2865
2866         Reviewed by Brent Fulgham.
2867
2868         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2869         (TestWebKitAPI::TEST):
2870
2871 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2872
2873         Unreviewed test fix.
2874
2875         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2876
2877         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2878
2879 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2880
2881         Teach ResourceLoadStatistics to recognize changes in the file system
2882         https://bugs.webkit.org/show_bug.cgi?id=173800
2883         <rdar://problem/32937842>
2884
2885         Reviewed by Chris Dumez.
2886
2887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2888         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2889         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2890         (TestWebKitAPI::handleFileModification):
2891         (TestWebKitAPI::handleFileDeletion):
2892         (TestWebKitAPI::resetTestState):
2893         (TestWebKitAPI::TEST_F):
2894
2895 2017-06-28  Brady Eidson  <beidson@apple.com>
2896
2897         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2898         https://bugs.webkit.org/show_bug.cgi?id=173874
2899
2900         Reviewed by Alex Christensen.
2901
2902         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2903
2904 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2905
2906         Unreviewed, adding Don Olmstead to contributors.json
2907
2908         * Scripts/webkitpy/common/config/contributors.json:
2909
2910 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2911
2912         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2913         https://bugs.webkit.org/show_bug.cgi?id=173886
2914         <rdar://problem/32543191>
2915
2916         Reviewed by Andy Estes.
2917
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2919         (ParsedRange::ParsedRange):
2920         (-[TestSchemeHandler initWithVideoData:]):
2921         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2922         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2923         (TEST):
2924
2925 2017-06-27  JF Bastien  <jfbastien@apple.com>
2926
2927         WebAssembly: running out of executable memory should throw OoM
2928         https://bugs.webkit.org/show_bug.cgi?id=171537
2929         <rdar://problem/32963338>
2930
2931         Reviewed by Saam Barati.
2932
2933         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2934         tests under limited executable memory and avoids non-WebAssembly
2935         code generation so that we more reliably run out of executable
2936         memory in WebAssembly.
2937
2938 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2939
2940         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2941         https://bugs.webkit.org/show_bug.cgi?id=173854
2942         <rdar://problem/32236827>
2943
2944         Reviewed by Ryosuke Niwa and Tim Horton.
2945
2946         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2947
2948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2949         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2950         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2951         (TestWebKitAPI::TEST):
2952
2953 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2954
2955         [PAL] Add symbol export macros for PAL
2956         https://bugs.webkit.org/show_bug.cgi?id=171519
2957
2958         Reviewed by Konstantin Tokarev.
2959
2960         * DumpRenderTree/config.h:
2961         * TestWebKitAPI/CMakeLists.txt:
2962         * TestWebKitAPI/config.h:
2963         * WebKitTestRunner/config.h:
2964
2965 2017-06-27  John Wilander  <wilander@apple.com>
2966
2967         Resource Load Statistics: Add telemetry
2968         https://bugs.webkit.org/show_bug.cgi?id=173499
2969         <rdar://problem/32826094>
2970
2971         Reviewed by Brent Fulgham.
2972
2973         Adds three new testRunner functions:
2974         - installStatisticsDidRunTelemetryCallback()
2975         - statisticsFireTelemetryHandler()
2976         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2977
2978         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2979         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2980         (WTR::InjectedBundle::didReceiveMessageToPage):
2981         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2982         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2983         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2984         (WTR::TestRunner::statisticsFireTelemetryHandler):
2985         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2986         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2987         * WebKitTestRunner/TestController.cpp:
2988         (WTR::TestController::resetStateToConsistentValues):
2989         (WTR::TestController::statisticsFireTelemetryHandler):
2990         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2991         * WebKitTestRunner/TestController.h:
2992         * WebKitTestRunner/TestInvocation.cpp:
2993         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2994
2995 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2996
2997         Add missing includes to fix compilation error on FreeBSD
2998         https://bugs.webkit.org/show_bug.cgi?id=172919
2999
3000         Reviewed by Mark Lam.
3001
3002         * ImageDiff/cairo/PlatformImageCairo.cpp:
3003
3004 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
3005
3006         Unreviewed, rolling out r218783.
3007
3008         Causing accessibility/mac/setting-attributes-is-
3009         asynchronous.html to crash consistently on mac-wk2 Debug
3010
3011         Reverted changeset:
3012
3013         "AX: Cannot call setValue() on contenteditable or ARIA text
3014         controls"
3015         https://bugs.webkit.org/show_bug.cgi?id=173520
3016         http://trac.webkit.org/changeset/218783
3017
3018 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3019
3020         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3021         https://bugs.webkit.org/show_bug.cgi?id=173825
3022
3023         Reviewed by Saam Barati.
3024
3025         * DumpRenderTree/JavaScriptThreading.cpp:
3026         (runJavaScriptThread):
3027         (startJavaScriptThreads):
3028         * DumpRenderTree/mac/DumpRenderTree.mm:
3029         (runThread):
3030         (runPthread):
3031         (testThreadIdentifierMap):
3032
3033 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3034
3035         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3036         <https://webkit.org/b/173837>
3037
3038         Reviewed by Geoffrey Garen.
3039
3040         The clang static analyzer can't reason about objects that are
3041         assigned to a delegate as +1 retained, and then released
3042         later in a different method when the delegate is cleared.
3043
3044         Instead, use a common idiom where the object setting the
3045         delegate retains it as an instance variable on initialization.
3046         Then the same object clears the delegate and releases its
3047         instance variable during teardown.
3048
3049         Also add EXPECT_TRUE() tests to make sure the delegate objects
3050         match before teardown.
3051
3052         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3053         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3054         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3055         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3056         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3057         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3058
3059 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3060
3061         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3062         <https://webkit.org/b/173836>
3063
3064         Reviewed by Brady Eidson.
3065
3066         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3067         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3068         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3069         objects in this test.
3070
3071 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3072
3073         [ATK] Add support for aria-details and aria-errormessage
3074         https://bugs.webkit.org/show_bug.cgi?id=172588
3075
3076         Reviewed by Chris Fleizach.
3077
3078         Add additional methods to test ARIA properties which are exposed via
3079         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3080         to versions which support the details and error-message relation types.
3081
3082         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3083         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3084         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3085         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3086         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3087         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3088         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3089         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3090         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3091         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3092         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3093         * gtk/jhbuild.modules:
3094
3095 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3096
3097         Unreviewed. Add libfii to GTK+ install dependencies script.
3098
3099         * gtk/install-dependencies:
3100
3101 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3102
3103         Unreviewed, rolling out r215190.
3104
3105         Broke product select element on GNOME Bugzilla
3106
3107         Reverted changeset:
3108
3109         "[GTK] Misplaced right click menu on web page due to
3110         deprecated gtk_menu_popup()"
3111         https://bugs.webkit.org/show_bug.cgi?id=170553
3112         http://trac.webkit.org/changeset/215190
3113
3114 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3115
3116         Remove Reflect.enumerate
3117         https://bugs.webkit.org/show_bug.cgi?id=173806
3118
3119         Reviewed by Yusuke Suzuki.
3120
3121         * Scripts/run-jsc-stress-tests:
3122
3123 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3124
3125         AX: Cannot call setValue() on contenteditable or ARIA text controls
3126         https://bugs.webkit.org/show_bug.cgi?id=173520
3127
3128         Reviewed by Ryosuke Niwa.
3129
3130         Add setValue() method to WKTR (already existed in DRT).
3131
3132         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3133         (WTR::AccessibilityUIElement::setValue):
3134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3136         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3137         (WTR::AccessibilityUIElement::setValue):
3138
3139 2017-06-23  Keith Miller  <keith_miller@apple.com>
3140
3141         Switch VMTraps to use halt instructions rather than breakpoint instructions
3142         https://bugs.webkit.org/show_bug.cgi?id=173677
3143
3144         Reviewed by JF Bastien.
3145
3146         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3147         (TEST):
3148
3149 2017-06-23  Youenn Fablet  <youenn@apple.com>
3150
3151         Set getUserMedia permission to true by default on WTR
3152         https://bugs.webkit.org/show_bug.cgi?id=173610
3153
3154         Reviewed by Alex Christensen.
3155
3156         Adding a way to reset the getUserMedia permission to pending.
3157
3158         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3159         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3160         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3161         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3163         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3164         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3165         * WebKitTestRunner/TestController.cpp:
3166         (WTR::TestController::resetStateToConsistentValues):
3167         (WTR::TestController::setUserMediaPermissionAsUnset):
3168         * WebKitTestRunner/TestController.h:
3169         * WebKitTestRunner/TestInvocation.cpp:
3170         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3171
3172 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3173
3174         Add SPI to WKURLSchemeTask for redirection
3175         https://bugs.webkit.org/show_bug.cgi?id=173730
3176
3177         Reviewed by Brady Eidson.
3178
3179         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3180         (-[SchemeHandler webView:startURLSchemeTask:]):
3181         (-[SchemeHandler webView:stopURLSchemeTask:]):
3182         (TEST):
3183         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3184         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3185         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3186         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3187         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3188
3189 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3190
3191         [WPE] Use JSC API to send script messages from web extension in tests
3192         https://bugs.webkit.org/show_bug.cgi?id=173757
3193
3194         Reviewed by Žan Doberšek.
3195
3196         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3197         to run postMessage().
3198
3199         Fixes: /wpe/WebKitSecurityManager/file-xhr
3200                /wpe/WebKitConsoleMessage/console-api
3201                /wpe/WebKitConsoleMessage/js-exception
3202                /wpe/WebKitConsoleMessage/network-error
3203                /wpe/WebKitConsoleMessage/security-error
3204
3205         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3206         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3207         (beforeAll): Ditto.
3208         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3209         (testWebContextSecurityFileXHR): Ditto.
3210         (beforeAll): Ditto.
3211         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3212         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3213         (pageCreatedCallback): Remove ifdefs.
3214
3215 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3216
3217         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3218
3219         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3220         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3221         doesn't exist yet in WPE.
3222
3223         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3224         (testWebViewJavaScriptDialogs):
3225         (testWebViewWindowProperties):
3226
3227 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3228
3229         [GTK] Upgrade pixman and cairo in jhbuild
3230         https://bugs.webkit.org/show_bug.cgi?id=173710
3231
3232         Reviewed by Carlos Alberto Lopez Perez.
3233
3234         * gtk/jhbuild.modules:
3235
3236 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3237
3238         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3239         https://bugs.webkit.org/show_bug.cgi?id=173711
3240
3241         Reviewed by Carlos Alberto Lopez Perez.
3242
3243         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3244         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3245
3246         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3247         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3248
3249 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3250
3251         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3252         <https://webkit.org/b/173721>
3253
3254         Reviewed by Joseph Pecoraro.
3255
3256         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3257         objects to fix leaks and to avoid the autoreleasepool.
3258
3259         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3260         (TEST):
3261
3262 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3263
3264         Unreviewed, rolling out r218633.
3265
3266         The test is failing frequently on Sierra Debug and Windows
3267
3268         Reverted changeset:
3269
3270         "AX: Cannot call setValue() on contenteditable or ARIA text
3271         controls"
3272         https://bugs.webkit.org/show_bug.cgi?id=173520
3273         http://trac.webkit.org/changeset/218633
3274
3275 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3276
3277         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3278         <https://webkit.org/b/173690>
3279
3280         Reviewed by Chris Dumez.
3281
3282         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3283         ownership of malloc()-ed memory, then frees it when it's
3284         released.  These tests were passing global variables into the
3285         method, which is not malloc()-ed memory, which violates the API
3286         contract.
3287
3288         The fix is to switch to use
3289         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3290         NO for the last argument.
3291
3292         Caught by the clang static analyzer.
3293
3294         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3295         (TEST):
3296         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3297         (TEST):
3298
3299 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3300
3301         [GTK] Upgrade Harfbuzz to version 1.4.2
3302         https://bugs.webkit.org/show_bug.cgi?id=173592
3303
3304         Reviewed by Carlos Alberto Lopez Perez.
3305
3306         * gtk/jhbuild.modules:
3307
3308 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         [WPE] Update WPEBackend-mesa
3311         https://bugs.webkit.org/show_bug.cgi?id=173705
3312
3313         Reviewed by Carlos Alberto Lopez Perez.
3314
3315         A crash has been fixed, needed for unit tests to work.
3316
3317         * wpe/jhbuild.modules:
3318
3319 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3320
3321         Remove unused coordinated graphics C API
3322         https://bugs.webkit.org/show_bug.cgi?id=173706
3323
3324         Reviewed by Žan Doberšek.
3325
3326         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3327         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3328         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3329         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3330         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3331         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3332
3333 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3334
3335         [WPE] Build glib API tests
3336         https://bugs.webkit.org/show_bug.cgi?id=173702
3337
3338         Reviewed by Žan Doberšek.
3339
3340         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3341         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3342         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3343         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3344         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3345         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3346         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3347         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3348         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3349         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3350         and implement the missing features.
3351
3352         * CMakeLists.txt:
3353         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3354         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3355         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3356         (testAutomationSessionRequestSession):
3357         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3358         (testWebKitWebViewSessionState):
3359         (testWebKitWebViewSessionStateWithFormData):
3360         (testWebKitWebViewNavigationAfterSessionRestore):
3361         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3362         (beforeAll):
3363         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3364         (testCookieManagerEphemeral):
3365         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3366         (testBlobDownload):
3367         (beforeAll):
3368         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3369         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3370         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3371         (testProcessPerWebView):
3372         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3373         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3374         (testWebViewCreateNavigationData):
3375         (testWebViewJavaScriptDialogs):
3376         (testWebViewWindowProperties):
3377         (testWebViewMouseTarget):
3378         (testWebViewGeolocationPermissionRequests):
3379         (testWebViewUserMediaPermissionRequests):
3380         (testWebViewAudioOnlyUserMediaPermissionRequests):
3381         (testWebViewFileChooserRequest):
3382         (beforeAll):
3383         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3384         (beforeAll):
3385         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3386         (testPrivateBrowsing):
3387         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3388         (testFindControllerHide):
3389         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3390         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3391         (testWebKitSettings):
3392         (beforeAll):
3393         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3394         (testWebViewNewWithUserContentManager):
3395         (beforeAll):
3396         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3397         (testWebContextEphemeral):
3398         (testWebContextProxySettings):
3399         (beforeAll):
3400         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3401         (testWebViewWebContext):
3402         (testWebViewWebContextLifetime):
3403         (testWebViewEphemeral):
3404         (testWebViewSettings):
3405         (testWebViewCanShowMIMEType):
3406         (testWebViewPageVisibility):
3407         (testWebViewIsPlayingAudio):
3408         (beforeAll):
3409         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3410         (testWebsiteDataEphemeral):
3411         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3412         (documentLoadedCallback):
3413         (pageCreatedCallback):
3414         (methodCallCallback):
3415         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3416         * TestWebKitAPI/glib/CMakeLists.txt:
3417         * TestWebKitAPI/glib/PlatformGTK.cmake:
3418         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3419         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3420         (main):
3421         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3422         (Test::adoptView):
3423         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3424         (WebKitTestBus::run):
3425         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3426         (WebViewTest::~WebViewTest):
3427         (WebViewTest::initializeWebView):
3428         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3429         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3430         (WebViewTest::platformDestroy):
3431         (WebViewTest::platformInitializeWebView):
3432         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3433         (WebViewTest::resizeView):
3434         (WebViewTest::hideView):
3435         (parentWindowMapped):
3436         (WebViewTest::showInWindow):
3437         (WebViewTest::showInWindowAndWaitUntilMapped):
3438         (WebViewTest::mouseMoveTo):
3439         (WebViewTest::clickMouseButton):
3440         (WebViewTest::emitPopupMenuSignal):
3441         (WebViewTest::keyStroke):
3442         (WebViewTest::doMouseButtonEvent):
3443         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3444         (WebViewTest::platformDestroy):
3445         (WebViewTest::platformInitializeWebView):
3446         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3447         (WebViewTest::resizeView):
3448         (WebViewTest::hideView):
3449         (WebViewTest::mouseMoveTo):
3450         (WebViewTest::clickMouseButton):
3451         (WebViewTest::keyStroke):
3452
3453 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3454
3455         [GTK] Move WebKit2 GLib API tests to glib directories
3456         https://bugs.webkit.org/show_bug.cgi?id=173642
3457
3458         Reviewed by Žan Doberšek.
3459
3460         * CMakeLists.txt:
3461         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3462         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3463         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3464         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3465         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3466         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3467         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3468         (testWebKitConsoleMessageNetworkError):
3469         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3470         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3471         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3472         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3473         (testLoadFromGResource):
3474         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3475         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3476         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3477         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3478         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3479         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3480         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3481         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3482         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3483         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3484         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3485         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3486         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3487         (testWebViewRunJavaScript):
3488         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3489         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3490         (registerGResource):
3491         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3492         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3493         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3494         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3495         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3496         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3497         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3498         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3499         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3500         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3501         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3502         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3503         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3504         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3505         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3506         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3507         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3508         (registerGResource):
3509         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3510         (Test::getResourcesDir):
3511         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3512         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3513         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3514         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3515         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3516         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3517
3518 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3519
3520         [WPE] Add initial web extensions API
3521         https://bugs.webkit.org/show_bug.cgi?id=173640
3522
3523         Reviewed by Žan Doberšek.
3524
3525         Add style checker exceptions for WPE web extensions API files.
3526
3527         * Scripts/webkitpy/style/checker.py:
3528
3529 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3530
3531         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3532         https://bugs.webkit.org/show_bug.cgi?id=173659
3533         <rdar://problem/32879788>
3534
3535         Reviewed by Tim Horton.
3536
3537         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3538
3539         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3540
3541         Augment this test page to log dragend and dragstart events on the drag source as well.
3542
3543         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3544         (checkStringArraysAreEqual):
3545         (TestWebKitAPI::TEST):
3546
3547 2017-06-21  Antoine Quint  <graouts@apple.com>
3548
3549         Ensure DRT always logs rAF suspension debugging code
3550         https://bugs.webkit.org/show_bug.cgi?id=173681
3551
3552         Reviewed by Tim "Mr. T" Horton.
3553
3554         * DumpRenderTree/mac/DumpRenderTree.mm:
3555         (resetWebPreferencesToConsistentValues):
3556
3557 2017-06-21  Chris Dumez  <cdumez@apple.com>
3558
3559         Allow constructing a WTF:Function from a function pointer
3560         https://bugs.webkit.org/show_bug.cgi?id=173660
3561
3562         Reviewed by Alex Christensen.
3563
3564         Add API test coverage.
3565
3566         * TestWebKitAPI/Tests/WTF/Function.cpp:
3567         (TestWebKitAPI::returnThree):
3568         (TestWebKitAPI::returnFour):
3569         (TestWebKitAPI::returnPassedValue):
3570         (TestWebKitAPI::TEST):
3571
3572 2017-06-21  Antoine Quint  <graouts@apple.com>
3573
3574         Add logging to identify when the Page suspends scripted animations
3575         https://bugs.webkit.org/show_bug.cgi?id=173626
3576
3577         Reviewed by Tim Horton.
3578
3579         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3580
3581         * DumpRenderTree/mac/DumpRenderTree.mm:
3582         (resetWebPreferencesToConsistentValues):
3583
3584 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3585
3586         AX: Cannot call setValue() on contenteditable or ARIA text controls
3587         https://bugs.webkit.org/show_bug.cgi?id=173520
3588
3589         Reviewed by Ryosuke Niwa.
3590
3591         Add setValue() method to WKTR (already existed in DRT).
3592
3593         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3594         (WTR::AccessibilityUIElement::setValue):
3595         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3596         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3597         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3598         (WTR::AccessibilityUIElement::setValue):
3599
3600 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3601
3602         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3603         as one of the dependencies required to build the product.
3604
3605         Rubber-stamped by Carlos Garcia Campos.
3606
3607         * gtk/install-dependencies:
3608         * wpe/install-dependencies:
3609
3610 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3611
3612         Disable font variations on macOS Sierra and iOS 10
3613         https://bugs.webkit.org/show_bug.cgi?id=173618
3614         <rdar://problem/32879164>
3615
3616         Reviewed by Jon Lee.
3617
3618         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3619
3620 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3621
3622         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3623         https://bugs.webkit.org/show_bug.cgi?id=173578
3624         <rdar://problem/32825028>
3625
3626         Reviewed by Tim Horton.
3627
3628         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3629         a custom popover does not cause dragging to fail when the popover is presented.
3630
3631         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3632         (-[DataInteractionSimulator _advanceProgress]):
3633
3634 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3635
3636         [WPE] Add initial implementation of glib API
3637         https://bugs.webkit.org/show_bug.cgi?id=173546
3638
3639         Reviewed by Žan Doberšek.
3640
3641         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3642         include WPE glib API files.
3643
3644         * Scripts/webkitperl/FeatureList.pm:
3645         * Scripts/webkitpy/style/checker.py:
3646         * Scripts/webkitpy/style/checkers/cpp.py:
3647         (check_identifier_name_in_declaration):
3648
3649 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3650
3651         [GTK] Upgrade to ICU to version 57.1
3652         https://bugs.webkit.org/show_bug.cgi?id=173538
3653
3654         Reviewed by Žan Doberšek.
3655
3656         * gtk/jhbuild.modules:
3657
3658 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3659
3660         [GTK] Remove unneeded modules from the jhbuild
3661         https://bugs.webkit.org/show_bug.cgi?id=170540
3662
3663         Reviewed by Michael Catanzaro.
3664
3665         We are building libxslt and libffi that we don't really need to build from sources.
3666
3667         * gtk/jhbuild.modules:
3668
3669 2017-06-19  Frederic Wang  <fwang@igalia.com>
3670
3671         [Mac] Add an experimental feature setting for async frame scrolling
3672         https://bugs.webkit.org/show_bug.cgi?id=173359
3673
3674         Reviewed by Simon Fraser.
3675
3676         * DumpRenderTree/mac/DumpRenderTree.mm:
3677         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3678         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3679         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3680         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3681
3682 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3683
3684         Unreviewed, adding myself to contributors.json
3685
3686         * Scripts/webkitpy/common/config/contributors.json:
3687
3688 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3689
3690         test262: Completion values for control flow do not match the spec
3691         https://bugs.webkit.org/show_bug.cgi?id=171265
3692
3693         Reviewed by Saam Barati.
3694
3695         * Scripts/run-jsc-stress-tests:
3696         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3697
3698 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3699
3700         Opening certain mails brings up a mail that grows indefinitely.
3701         https://bugs.webkit.org/show_bug.cgi?id=173562
3702         <rdar://problem/32766579>
3703
3704         Reviewed by Tim Horton.
3705
3706         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3707         (TEST):
3708
3709 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3710
3711         [iOS DnD] Support .zip archives for file uploads via drag and drop
3712         https://bugs.webkit.org/show_bug.cgi?id=173511
3713         <rdar://problem/32521025>
3714
3715         Reviewed by Tim Horton.
3716
3717         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3718         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3719
3720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3721         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3722         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3723         (testZIPArchive):
3724         (TestWebKitAPI::TEST):
3725
3726 2017-06-18  Darin Adler  <darin@apple.com>
3727
3728         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3729         https://bugs.webkit.org/show_bug.cgi?id=173526
3730
3731         Reviewed by Sam Weinig.
3732
3733         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3735
3736         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3737         tests for assignment before destruction ones.
3738
3739         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3740         as a function, so it can be used in WTF::Function tests.
3741
3742         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3743         Added tests for swap and for assignment before deref.
3744
3745         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3746         to inline everything. Also removed the unnecessary clearing of the log every time
3747         the DerivedRefLogger constructor is called.
3748         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3749
3750         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3751         Added tests for assignment before deref and similar for releaseNonNull.
3752
3753 2017-06-19  Sam Weinig  <sam@webkit.org>
3754
3755         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3756         https://bugs.webkit.org/show_bug.cgi?id=173513
3757
3758         Reviewed by Alex Christensen.
3759
3760         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3761         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3762         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3763
3764 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3765
3766         [Win] fast/dom/assign-to-window-status.html is flaky.
3767         https://bugs.webkit.org/show_bug.cgi?id=173512
3768
3769         Reviewed by Alex Christensen.
3770
3771         We should not dump status callbacks when test is done.
3772
3773         * DumpRenderTree/win/UIDelegate.cpp:
3774         (UIDelegate::setStatusText):
3775
3776 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3777
3778         [WPE][JHBuild] Update WPEBackend-mesa
3779         https://bugs.webkit.org/show_bug.cgi?id=173433
3780
3781         Unreviewed.
3782
3783         Update WPEBackend-mesa back (like it was done originally in r218344)
3784         after fixing the issue with the DISPLAY environment variables that
3785         caused the crashes.
3786
3787         * wpe/jhbuild.modules:
3788
3789 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3790
3791         Rename unit test file after r218482
3792         https://bugs.webkit.org/show_bug.cgi?id=173483
3793
3794         Unreviewed.
3795
3796         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3797
3798 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3799
3800         Unreviewed. Fix wrong style checker condition added in r218487.
3801
3802         * Scripts/webkitpy/style/checkers/cpp.py:
3803         (check_identifier_name_in_declaration):
3804
3805 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3806
3807         Missing <functional> includes make builds fail with GCC 7.x
3808         https://bugs.webkit.org/show_bug.cgi?id=173544
3809
3810         Unreviewed gardening.
3811
3812         Fix compilation with GCC 7.
3813
3814         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3815         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3816
3817 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3818
3819         [GTK] Move GTK+ API files that could be shared to glib dirs
3820         https://bugs.webkit.org/show_bug.cgi?id=173545
3821
3822         Reviewed by Žan Doberšek.
3823
3824         Update paths of GTK+ API in watchlist and style checker.
3825
3826         * Scripts/webkitpy/common/config/watchlist:
3827         * Scripts/webkitpy/style/checker.py:
3828         * Scripts/webkitpy/style/checkers/cpp.py:
3829         (check_identifier_name_in_declaration):
3830
3831 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3832
3833         Port setup_environ_for_server should not set environment variables related with the driver.
3834         https://bugs.webkit.org/show_bug.cgi?id=173483
3835
3836         Reviewed by Carlos Garcia Campos.
3837
3838         The port setup_environ_for_server() should not set environment variables
3839         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3840         This varibles should be only set on the driver setup_environ_for_test().
3841
3842         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3843         into the test environment even when running the tests with a driver
3844         that is not the Xorg or Xvfb one.
3845
3846         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3847         (Port.to.setup_environ_for_server):
3848         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3849         (Driver._setup_environ_for_driver):
3850         * Scripts/webkitpy/port/driver_unittest.py:
3851         (DriverTest.test_setup_environ_for_test):
3852         (DriverTest):
3853         (DriverTest.test_setup_environ_base_vars):
3854         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3855         (GtkPort.setup_environ_for_server):
3856         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3857         (WaylandDriverTest):
3858         (WaylandDriverTest.make_driver):
3859         (WaylandDriverTest.make_environment):
3860         (WaylandDriverTest.test_checkdriver):
3861         (WaylandDriverTest.test_environment_needed_variables):
3862         (WaylandDriverTest.test_environment_forbidden_variables):
3863         (WaylandDriverTest.test_environment_optional_variables):
3864         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3865         (WaylandDriver.check_driver):
3866         (WaylandDriver._setup_environ_for_test):
3867         * Scripts/webkitpy/port/xorgdriver.py:
3868         (XorgDriver.check_driver):
3869         (XorgDriver._setup_environ_for_test):
3870         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3871         (XorgDriverTest):
3872         (XorgDriverTest.make_driver):
3873         (XorgDriverTest.make_environment):
3874         (XorgDriverTest.test_checkdriver):
3875         (XorgDriverTest.test_environment_needed_variables):
3876         (XorgDriverTest.test_environment_forbidden_variables):
3877         (XorgDriverTest.test_environment_optional_variables):
3878         * Scripts/webkitpy/port/xvfbdriver.py:
3879         (XvfbDriver._setup_environ_for_test):
3880         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3881         (XvfbDriverTest.assertDriverStartSuccessful):
3882
3883
3884 2017-05-14 Frederic Wang  <fwang@igalia.com>
3885
3886         Add heuristic to avoid flattening "fullscreen" iframes
3887         https://bugs.webkit.org/show_bug.cgi?id=171914
3888
3889         Reviewed by Simon Fraser.
3890
3891         * DumpRenderTree/mac/DumpRenderTree.mm:
3892         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3893
3894 2017-06-18  Chris Dumez  <cdumez@apple.com>
3895
3896         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3897         https://bugs.webkit.org/show_bug.cgi?id=173522
3898         <rdar://problem/31185739>
3899
3900         Reviewed by Darin Adler.
3901
3902         Add API test for re-entering Function's assignment operators.
3903
3904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3905         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3906         (TestWebKitAPI::TestObject::TestObject):
3907         (TestWebKitAPI::TestObject::~TestObject):
3908         (TestWebKitAPI::TestObject::operator()):
3909         (TestWebKitAPI::TEST):
3910
3911 2017-06-16  Dan Bernstein  <mitz@apple.com>
3912
3913         [Cocoa] Some declarations have missing or incorrect availability attributes
3914         https://bugs.webkit.org/show_bug.cgi?id=173508
3915
3916         Reviewed by Tim Horton.
3917
3918         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3919         (TestWebKitAPI::TEST): Updated for renames.
3920
3921 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3922
3923         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3924         https://bugs.webkit.org/show_bug.cgi?id=173366
3925         <rdar://problem/32767014>
3926
3927         Reviewed by Tim Horton.
3928
3929         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3930         change in behavior.
3931
3932         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3934         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3935         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3936         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3937         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3938         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3939         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3940         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3941         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3942         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
3943         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
3944         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
3945         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
3946         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3947         (-[MockDragDropSession initWithItems:location:window:]):
3948         (-[MockDragDropSession allowsMoveOperation]):
3949         (-[MockDragDropSession isRestrictedToDraggingApplication]):
3950         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
3951         (-[MockDragDropSession canLoadObjectsOfClass:]):
3952         (-[MockDragDropSession canLoadObjectsOfClasses:]):
3953         (-[MockDragDropSession items]):
3954         (-[MockDragDropSession setItems:]):
3955         (-[MockDragDropSession locationInView:]):
3956         (-[MockDataOperationSession initWithProviders:location:window:]):
3957         (-[MockDataOperationSession session]):
3958         (-[MockDataOperationSession isLocal]):
3959         (-[MockDataOperationSession progress]):
3960         (-[MockDataOperationSession setProgressIndicatorStyle:]):
3961         (-[MockDataOperationSession progressIndicatorStyle]):
3962         (-[MockDataOperationSession operationMask]):
3963         (-[MockDataOperationSession localDragSession]):
3964         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
3965         (-[MockDataOperationSession canCreateItemsOfClass:]):
3966         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
3967         (-[MockDataInteractionSession initWithWindow:]):
3968         (-[MockDataInteractionSession localOperationMask]):
3969         (-[MockDataInteractionSession externalOperationMask]):
3970         (-[MockDataInteractionSession session]):
3971         (-[DataInteractionSimulator _advanceProgress]):
3972
3973 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3974
3975         Show punycode to user if a URL has dotless i or j followed by diacritic dot
3976         https://bugs.webkit.org/show_bug.cgi?id=173431
3977
3978         Reviewed by Darin Adler.
3979
3980         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3981         (TestWebKitAPI::TEST):
3982
3983 2017-06-16  Chris Dumez  <cdumez@apple.com>
3984
3985         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
3986         https://bugs.webkit.org/show_bug.cgi?id=173472
3987         <rdar://problem/28858817>
3988
3989         Reviewed by Brady Eidson.
3990
3991         Add API test coverage.
3992
3993         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3994         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
3995         (TEST):
3996
3997 2017-06-16  Brady Eidson  <beidson@apple.com>
3998
3999         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
4000         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
4001
4002         Reviewed by Daniel Bates.
4003
4004         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
4005
4006 2017-06-16  Chris Dumez  <cdumez@apple.com>
4007
4008         DRT fails to reset page visibility between tests
4009         https://bugs.webkit.org/show_bug.cgi?id=173485
4010
4011         Reviewed by Alexey Proskuryakov.
4012
4013         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
4014         Fix this to address flakiness.
4015
4016         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
4017         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
4018         The test became flaky without the DRT change and was no longer flaky with the DRT
4019         change.
4020
4021         WebKitTestRunner already does this.
4022
4023         * DumpRenderTree/mac/DumpRenderTree.mm:
4024         (resetWebViewToConsistentStateBeforeTesting):
4025
4026 2017-06-16  Alex Christensen  <achristensen@webkit.org>
4027
4028         Implement basic authentication in MiniBrowser
4029         https://bugs.webkit.org/show_bug.cgi?id=173443
4030
4031         Reviewed by Tim Horton.
4032
4033         * MiniBrowser/mac/WK2BrowserWindowController.m:
4034         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
4035
4036 2017-06-16  Jer Noble  <jer.noble@apple.com>
4037
4038         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4039         https://bugs.webkit.org/show_bug.cgi?id=173398
4040         <rdar://problem/32592961>
4041
4042         Reviewed by Eric Carlson.
4043
4044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4045         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4046         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4047         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4048         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4049         (TestWebKitAPI::TEST):
4050         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4051
4052 2017-06-16  Matt Lewis  <jlewis3@apple.com>
4053
4054         Unreviewed, rolling out r218375.
4055
4056         The API test MediaStreamTrackDetached is still timing out
4057         after the patch
4058
4059         Reverted changeset:
4060
4061         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
4062         reports no recording to WebKit clients"
4063         https://bugs.webkit.org/show_bug.cgi?id=173398
4064         http://trac.webkit.org/changeset/218375
4065
4066 2017-06-15  Jer Noble  <jer.noble@apple.com>
4067
4068         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4069         https://bugs.webkit.org/show_bug.cgi?id=173398
4070         <rdar://problem/32592961>
4071
4072         Reviewed by Eric Carlson.
4073
4074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4075         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4076         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4077         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4078         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4079         (TestWebKitAPI::TEST):
4080         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4081
4082 2017-06-15  Matt Lewis  <jlewis3@apple.com>
4083
4084         Unreviewed, rolling out r218365.
4085
4086         The revision caused API timeouts on all builds.
4087
4088         Reverted changeset:
4089
4090         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
4091         reports no recording to WebKit clients"
4092         https://bugs.webkit.org/show_bug.cgi?id=173398
4093         http://trac.webkit.org/changeset/218365
4094
4095 2017-06-15  Jer Noble  <jer.noble@apple.com>
4096
4097         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4098         https://bugs.webkit.org/show_bug.cgi?id=173398
4099         <rdar://problem/32592961>
4100
4101         Reviewed by Eric Carlson.
4102
4103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4104         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4105         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4106         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4107         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4108         (TestWebKitAPI::TEST):
4109         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4110
4111 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4112
4113         REGRESSION(r218344): [WPE] Thousands of layout test crashes
4114         https://bugs.webkit.org/show_bug.cgi?id=173433
4115
4116         Unreviewed.
4117
4118         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
4119
4120 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4121
4122         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
4123         https://bugs.webkit.org/show_bug.cgi?id=173061
4124
4125         Reviewed by Žan Doberšek.
4126
4127         Launch dyz <https://github.com/Igalia/dyz> with the script
4128         run-minibrowser for the wpe port. It is now built as part of the
4129         WPE dependencies with JHBuild.
4130
4131         * Scripts/run-minibrowser:
4132         * Scripts/webkitdirs.pm:
4133         (launcherPath):
4134         (launcherName):
4135         * wpe/install-dependencies: Luajit is needed for building dyz.
4136         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
4137
4138 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4139
4140         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
4141         https://bugs.webkit.org/show_bug.cgi?id=173338
4142         <rdar://problem/32777720>
4143
4144         Reviewed by Tim Horton.
4145
4146         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
4147         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
4148         these remaining items on drop.
4149
4150         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4151         (TestWebKitAPI::TEST):
4152         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4153         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4154
4155         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
4156
4157         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
4158
4159 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
4160
4161         [Win] Crash in accessibility layout test.
4162         https://bugs.webkit.org/show_bug.cgi?id=173401
4163
4164         Reviewed by Brent Fulgham.
4165
4166         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
4167         member will be automatically released when the _variant_t object goes out of scope if the vt member
4168         does not equal VT_UNKNOWN | VT_BYREF.
4169         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
4170
4171         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4172         (AccessibilityUIElement::titleUIElement):
4173
4174 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4175
4176         [GTK] Add API to allow overriding popup menus
4177         https://bugs.webkit.org/show_bug.cgi?id=172905
4178
4179         Reviewed by Michael Catanzaro.
4180
4181         Add a unit test to check the new API.
4182
4183         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4184         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
4185         (OptionMenuTest::OptionMenuTest):
4186         (OptionMenuTest::~OptionMenuTest):
4187         (OptionMenuTest::destroyMenu):
4188         (OptionMenuTest::showOptionMenuCallback):
4189         (OptionMenuTest::menuCloseCallback):
4190         (OptionMenuTest::showOptionMenu):
4191         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
4192         (OptionMenuTest::close):
4193         (OptionMenuTest::activateItem):
4194         (OptionMenuTest::selectItem):
4195         (testOptionMenuSimple):
4196         (testOptionMenuGroups):
4197         (testOptionMenuActivate):
4198         (testOptionMenuSelect):
4199         (beforeAll):
4200         (afterAll):
4201
4202 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
4203
4204         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
4205         https://bugs.webkit.org/show_bug.cgi?id=173399
4206
4207         Reviewed by Per Arne Vollan.
4208
4209         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
4210         Curl port needs to do nothing because libcurl doesn't have disk cache.
4211
4212         * DumpRenderTree/win/DumpRenderTree.cpp:
4213         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
4214         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
4215
4216 2017-06-14  Tomas Popela  <tpopela@redhat.com>
4217
4218         [GTK] integer expression expected if running Tools/gtk/install-dependencies
4219         https://bugs.webkit.org/show_bug.cgi?id=173356
4220
4221         Reviewed by Michael Catanzaro.
4222
4223         Use the correct operator to compare the strings.
4224
4225         * gtk/install-dependencies:
4226
4227 2017-06-14  Commit Queue  <commit-queue@webkit.org>
4228
4229         Unreviewed, rolling out r218285.
4230         https://bugs.webkit.org/show_bug.cgi?id=173391
4231
4232         API test fails on iOS (Requested by alexchristensen on
4233         #webkit).
4234
4235         Reverted changeset:
4236
4237         "Add SPI for immediate injection of user scripts"
4238         https://bugs.webkit.org/show_bug.cgi?id=173342
4239         http://trac.webkit.org/changeset/218285
4240
4241 2017-06-14  Chris Dumez  <cdumez@apple.com>
4242
4243         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
4244         https://bugs.webkit.org/show_bug.cgi?id=173384
4245         <rdar://problem/32723779>
4246
4247         Reviewed by Dan Bernstein.
4248
4249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4250         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
4251         Add API test coverage.
4252
4253         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
4254         (TestWebKitAPI::Util::sleep):
4255         Update implementation of Util::sleep() so that we actually run the run loop.
4256         Otherwise, we don't process events while sleeping.
4257
4258 2017-06-14  Alex Christensen  <achristensen@webkit.org>
4259
4260         Add SPI for immediate injection of user scripts
4261         https://bugs.webkit.org/show_bug.cgi?id=173342
4262         <rdar://problem/29202285>
4263
4264         Reviewed by Brady Eidson.
4265
4266         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: