bc5e6d73b102b2b9dea89d4473cd929c4da42243
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         nrwt: make webaudio work w/o content-length header
6         https://bugs.webkit.org/show_bug.cgi?id=61819
7
8         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
9         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
10         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
11         * Scripts/webkitpy/layout_tests/port/webkit.py:
12
13 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
14
15         Reviewed by Andreas Kling.
16
17         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
18         https://bugs.webkit.org/show_bug.cgi?id=61802
19
20         Add command line parameter and menu item to MiniBrowser application 
21         enabling use of QGLWidget for browser viewport.
22
23         * MiniBrowser/qt/BrowserWindow.cpp:
24         (BrowserWindow::BrowserWindow):
25         (BrowserWindow::toggleGLViewport):
26         * MiniBrowser/qt/BrowserWindow.h:
27         * MiniBrowser/qt/MiniBrowserApplication.cpp:
28         (MiniBrowserApplication::handleUserOptions):
29         * MiniBrowser/qt/MiniBrowserApplication.h:
30         (WindowOptions::WindowOptions):
31
32 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
33
34         Reviewed by Xan Lopez.
35
36         Print out autogen arguments when they differ from the last set, to help
37         with debugging build issues.
38
39         * Scripts/webkitdirs.pm: Print out previous and current build arguments
40         when they differ.
41
42 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
43
44         Reviewed by Martin Robinson.
45
46         [GTK] run-launcher should run MiniBrowser in WebKit2
47         https://bugs.webkit.org/show_bug.cgi?id=61858
48
49         * Scripts/run-launcher: Check whether -2 command line option has
50         been passed and run MiniBrowser instead of GtkLauncher.
51
52 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
53
54         Reviewed by Dirk Pranke.
55
56         Fix exception in verbose printing mode.
57         https://bugs.webkit.org/show_bug.cgi?id=61723
58
59         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
60
61 2011-05-31  Yong Li  <yoli@rim.com>
62
63         Reviewed by Eric Seidel.
64
65         https://bugs.webkit.org/show_bug.cgi?id=54807
66         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
67         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
68         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
69         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
70         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
71         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
72         rule we should have in order to make our code independent from compilers and compiler flags.
73
74         * Scripts/webkitpy/style/checkers/cpp.py:
75
76 2011-05-31  Hironori Bono  <hbono@chromium.org>
77
78         Reviewed by Eric Seidel.
79
80         Add a JavaScript function layoutTestController.setTextDirection().
81         https://bugs.webkit.org/show_bug.cgi?id=50952
82
83         This change adds a new JavaScript function setTextDirection() to the
84         LayoutTestController class of Safari and Chrome to write layout tests
85         that changes the text direction of an editable element.
86
87         * DumpRenderTree/LayoutTestController.cpp:
88         (setTextDirectionCallback):
89         (LayoutTestController::staticFunctions):
90         * DumpRenderTree/LayoutTestController.h:
91         * DumpRenderTree/chromium/LayoutTestController.cpp:
92         (LayoutTestController::LayoutTestController):
93         (LayoutTestController::setTextDirection):
94         * DumpRenderTree/chromium/LayoutTestController.h:
95         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
96         (LayoutTestController::setTextDirection):
97         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
98         (LayoutTestController::setTextDirection):
99         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
100         (LayoutTestController::setTextDirection):
101
102 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
103
104         Reviewed by Simon Hausmann.
105
106         [Qt] User-agent list of Qt test browsers is very outdated
107         https://bugs.webkit.org/show_bug.cgi?id=61531
108
109         The user can edit the user-agent manually, so there's no need to have
110         a super complete and up to date list, but it's nice to have it
111         minimally updated.
112
113         * MiniBrowser/qt/useragentlist.txt:
114         * QtTestBrowser/useragentlist.txt:
115
116 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
117
118         Reviewed by Adam Roben.
119
120         [GTK] [WebKit2] Implement a basic WebKitTestRunner
121         https://bugs.webkit.org/show_bug.cgi?id=57068
122
123         Add an implementation of WebKitTestRunner for GTK+.
124
125         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
126         * Scripts/old-run-webkit-tests: Ditto.
127         * Scripts/run-launcher: Ditto.
128         * Scripts/webkitdirs.pm: Ditto.
129         * WebKitTestRunner/GNUmakefile.am: Added.
130         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
131         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
132         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
133         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
134         * WebKitTestRunner/PlatformWebView.h:
135         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
136         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
137         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
138         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
139         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
140         (main): Added.
141
142 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
143
144         Reviewed by Tony Chang.
145
146         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
147         https://bugs.webkit.org/show_bug.cgi?id=60241
148
149         * Scripts/new-run-webkit-tests:
150
151 2011-05-31  Eric Seidel  <eric@webkit.org>
152
153         Reviewed by David Kilzer.
154
155         webkitpy should create zips with zip -9
156         https://bugs.webkit.org/show_bug.cgi?id=61789
157
158         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
159
160         * Scripts/webkitpy/common/system/workspace.py:
161         * Scripts/webkitpy/common/system/workspace_unittest.py:
162
163 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
164
165         Reviewed by Csaba Osztrogonác.
166
167         [Qt] Implement find feature for QtTestBrowser
168         https://bugs.webkit.org/show_bug.cgi?id=61425
169
170         Buildfix for --minimal and CONFIG+=qt_minimal build.
171
172         * QtTestBrowser/launcherwindow.cpp:
173         (LauncherWindow::LauncherWindow):
174         (LauncherWindow::createChrome):
175         * QtTestBrowser/launcherwindow.h:
176
177 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
178
179         Reviewed by Csaba Osztrogonác.
180
181         [Qt] Implement find feature for QtTestBrowser
182         https://bugs.webkit.org/show_bug.cgi?id=61425
183
184         * QtTestBrowser/launcherwindow.cpp:
185         (LauncherWindow::LauncherWindow):
186         (LauncherWindow::createChrome):
187         (LauncherWindow::showFindBar):
188         (LauncherWindow::find):
189         * QtTestBrowser/launcherwindow.h:
190
191 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
192
193         Reviewed by Martin Robinson.
194
195         [GTK] Implement JavaScript dialogs in MiniBrowser
196         https://bugs.webkit.org/show_bug.cgi?id=61725
197
198         * MiniBrowser/gtk/BrowserWindow.c:
199         (WKStringGetCString): Helper function to get a UTF-8 c string from
200         a WKStringRef.
201         (WKURLGetCString): Helper function to get a UTF-8 c string from a
202         WKURLRef.
203         (browserWindowUpdateURL): Update to use WKURLGetCString.
204         (didReceiveTitleForFrame): Update to use WKStringGetCString.
205         (createMessageDialog): Create a GtkMessageDialog.
206         (runJavaScriptAlert):
207         (runJavaScriptConfirm):
208         (runJavaScriptPrompt):
209         (browserWindowUIClientInit):
210
211 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
212
213         Reviewed by Kent Tamura.
214
215         WebSocket closing handshake
216         https://bugs.webkit.org/show_bug.cgi?id=35721
217
218         * Scripts/webkitpy/thirdparty/__init__.py:
219         Pull in pywebsocket 0.6b1. We need to update pywebsocket
220         to get the right behavior of closing handshake.
221
222 2011-05-29  Daniel Bates  <dbates@rim.com>
223
224         Reviewed by David Kilzer.
225
226         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
227         https://bugs.webkit.org/show_bug.cgi?id=61162
228
229         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
230         that omits a line count. In particular, the chunk range regular expression does
231         not match a chunk range line that omits a line count. GNU diff(1) will omit the
232         line count in the chunk range if the line count is exactly 1. For example, appending
233         a new line to the end of an existing file F that contains exactly one line of text will
234         be represented in a diff with a chunk range line that omits the line count for F.
235
236         * Scripts/VCSUtils.pm:
237           (parseChunkRange): Added.
238         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
239         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
240           - Added unit test "Git: Append new line to the end of an existing file".
241
242 2011-05-28  Adam Barth  <abarth@webkit.org>
243
244         Reviewed by Eric Seidel.
245
246         EWS builds patches that fail to build twice, which seems useless and slows down the bots
247         https://bugs.webkit.org/show_bug.cgi?id=55585
248
249         This patch switches all the early warning system bots over to the new
250         PatchAnalysisTask-based infrastructure.  This patch makes these bots
251         more efficient (in the case where patches fail to build) and paves the
252         way for running tests on these bots!
253
254         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
255         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
256         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
257         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
258         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
259         * Scripts/webkitpy/tool/commands/queues.py:
260
261 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
262
263         Reviewed by Kent Tamura.
264
265         Add bashi as a committer.
266
267         https://bugs.webkit.org/show_bug.cgi?id=61685
268
269         * Scripts/webkitpy/common/config/committers.py:
270
271 2011-05-27  Adam Barth  <abarth@webkit.org>
272
273         Reviewed by Eric Seidel.
274
275         When checking whether the tree is red, the EWS posts a link to the wrong log
276         https://bugs.webkit.org/show_bug.cgi?id=61072
277
278         We need to cache the original script error because that contains the
279         failure log we want to upload.  If we don't cache that script error,
280         self._script_error will get overwritten when we sanity check the clean
281         tree (and it also has test failures).
282
283         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
284             - This testing approach is slightly goofy.  We'd like to use
285               assertRaisesRegexp, but that's not available until Python 2.7.
286         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
287
288 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
289
290         Reviewed by Adam Barth.
291
292         Add layoutTestController.setStorageAllowed() to control whether access
293         to the localStorage API is enabled via the WebPermissionClient
294         https://bugs.webkit.org/show_bug.cgi?id=61581
295
296         * DumpRenderTree/chromium/LayoutTestController.cpp:
297         (LayoutTestController::LayoutTestController):
298         (LayoutTestController::setStorageAllowed):
299         * DumpRenderTree/chromium/LayoutTestController.h:
300         * DumpRenderTree/chromium/TestShell.cpp:
301         (TestShell::TestShell):
302         (TestShell::createNewWindow):
303         * DumpRenderTree/chromium/TestShell.h:
304         * DumpRenderTree/chromium/WebPermissions.h: Added.
305         (WebPermissions::WebPermissions):
306         (WebPermissions::allowStorage):
307         (WebPermissions::setStorageAllowed):
308         (WebPermissions::reset):
309
310 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
311
312         Reviewed by Eric Seidel.
313
314         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
315         https://bugs.webkit.org/show_bug.cgi?id=60326
316
317         This patch removes a lot of the complexity from the
318         metered_stream implementation that was unnecessary since there
319         was only one caller and the logic could be coordinated better.
320
321         There should be no functional changes in this patch, just code
322         getting deleted and cleaned up.
323
324         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
325         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
326         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
327         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
328
329 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
330
331         Reviewed by Eric Seidel.
332
333         NRWT: minor cleanup in printing module
334         https://bugs.webkit.org/show_bug.cgi?id=60329
335
336         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
337
338 2011-05-27  Steve Lacey  <sjl@chromium.org>
339
340         Reviewed by David Levin.
341
342         Add sjl@chromium.org as a committer.
343
344         https://bugs.webkit.org/show_bug.cgi?id=61672
345
346         * Scripts/webkitpy/common/config/committers.py:
347
348 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
349
350         Reviewed by Adam Barth.
351
352         NRWT: remove --print detailed-progress
353         https://bugs.webkit.org/show_bug.cgi?id=60324
354
355         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
356         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
357         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
358         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
359
360 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
361
362         Reviewed by Ojan Vafai.
363
364         NRWT: debug messages from the workers are being logged twice
365         https://bugs.webkit.org/show_bug.cgi?id=60428
366
367         It looks like when the workers are run in separate processes
368         we end up getting two copies of every log message they print.
369         This has to do with the multiprocessing module on UNIX cloning
370         the log configuration in a way I wasn't expecting, and so two
371         log handlers end up getting registered.
372
373         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
374         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
375         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
376         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
377
378 2011-05-27  Adam Roben  <aroben@apple.com>
379
380         Always decode tester names from location.hash
381
382         When navigating directly to a tester-specific URL (e.g.,
383         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
384         with a URL-encoded tester name in the page, and then the encoded name could make its way
385         into Bugzilla bugs. Bad!
386
387         Reviewed by David Kilzer.
388
389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
390         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
391         decodeURIComponent before trying to use it.
392
393 2011-05-27  Adam Roben  <aroben@apple.com>
394
395         Remove testing code that snuck into r87528
396
397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
398         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
399
400 2011-05-27  Adam Roben  <aroben@apple.com>
401
402         Add links to TestFailures to easily file bugs about failing tests
403
404         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
405         links to file bugs for failing tests
406
407         Reviewed by David Kilzer.
408
409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
410         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
411         for a particular build.
412         (Builder.prototype._getFailingTests): Use resultsPageURL.
413
414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
415         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
416         failures.
417         (ViewController.prototype._domForBuildName): Use resultsPageURL.
418         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
419         new bug link. The bug has a title, description, and URL already filled in for you!
420
421 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
422
423         Unreviewed, rolling out r87464.
424         http://trac.webkit.org/changeset/87464
425         https://bugs.webkit.org/show_bug.cgi?id=61643
426
427         client-close/server-close tests are flaky on Chromium Mac and
428         Windows (Requested by aklein on #webkit).
429
430         * Scripts/webkitpy/thirdparty/__init__.py:
431
432 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
433
434         Added Douglas Davidson to contributors list for easier CC'ing.
435
436         * Scripts/webkitpy/common/config/committers.py:
437
438 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
439
440         Reviewed by Adam Barth.
441
442         Fix worldID and destinationDomain argument names
443         https://bugs.webkit.org/show_bug.cgi?id=61571
444
445         As part of working on r87423, I noticed a couple of inconsistencies in
446         argument names:
447         - We would use worldId in .h files but worldID in .cpp files.
448           Standardize on the latter
449         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
450           destinationDomains argument, even though the actual parameter was for
451           a single domain (renamed to be singular).
452
453         * DumpRenderTree/LayoutTestController.h:
454         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
455         (LayoutTestController::evaluateScriptInIsolatedWorld):
456
457 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
458
459         Reviewed by Kent Tamura.
460
461         WebSocket closing handshake
462         https://bugs.webkit.org/show_bug.cgi?id=35721
463
464         * Scripts/webkitpy/thirdparty/__init__.py:
465         Pull in pywebsocket 0.6b1. We need to update pywebsocket
466         to get the right behavior of closing handshake.
467
468 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
469
470         Reviewed by Andreas Kling.
471
472         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
473         https://bugs.webkit.org/show_bug.cgi?id=42676
474
475         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
476
477         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
478         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
479         (WTR::InjectedBundle::beginTesting):
480         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
481         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
482         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
483
484 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
485
486         Reviewed by Andreas Kling.
487
488         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
489         https://bugs.webkit.org/show_bug.cgi?id=61527
490
491         The setMaximumHeight() call is unecessary and breaks the dialog at
492         least on my setup.
493
494         * QtTestBrowser/launcherwindow.cpp:
495         (LauncherWindow::showUserAgentDialog):
496
497 2011-05-02  Robert Hogan  <robert@webkit.org>
498
499         Reviewed by Adam Roben.
500
501         [Qt] Allow popup windows from plugins when initiated by a user gesture
502
503         https://bugs.webkit.org/show_bug.cgi?id=41292
504
505         Support parameters introduced in plugin-initiate-popup-window.html
506
507         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
508         (webkit_test_plugin_new_instance):
509         (webkit_test_plugin_handle_event):
510
511 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
512
513         Reviewed by Adam Barth.
514
515         Support cross-origin XMLHttpRequest in isolated worlds
516         https://bugs.webkit.org/show_bug.cgi?id=59843
517
518         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
519
520         * DumpRenderTree/chromium/LayoutTestController.cpp:
521         (LayoutTestController::LayoutTestController):
522         (LayoutTestController::setIsolatedWorldSecurityOrigin):
523         * DumpRenderTree/chromium/LayoutTestController.h:
524
525 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
526
527         Reviewed by Adam Roben.
528
529         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
530         https://bugs.webkit.org/show_bug.cgi?id=61474
531         <rdar://problem/9468337>
532
533         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
534         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
535
536 2011-05-26  Andreas Kling  <kling@webkit.org>
537
538         Unreviewed, correct address to webkit-committers mailing list.
539
540         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
541
542 2011-05-25  Adam Roben  <aroben@apple.com>
543
544         Don't assume that builds finish in the order they were started
545
546         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
547         build when one slave is taking a long time to finish a build
548
549         Reviewed by Antti Koivisto.
550
551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
552         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
553         newer than the oldest in-progress build are also themselves in progress. Just check whether
554         each build is actually in progress (as signified by its presence in the currentBuilds set).
555
556 2011-05-25  Adam Roben  <aroben@apple.com>
557
558         Correctly detect cases where only a single test failed/crashed/timed out
559
560         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
561         failing test
562
563         Reviewed by Darin Adler.
564
565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
566         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
567         will be singular when only a single test fails/crashes/times out.
568
569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
570         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
571         failed/crashed/timed out.
572
573 2011-05-26  Tom Hudson  <tomhudson@google.com>
574
575         Reviewed by Tony Chang.
576
577         Add flags to Chromium ImageDiff to write image comparison metrics on
578         stdout.
579         https://bugs.webkit.org/show_bug.cgi?id=60569
580
581         * DumpRenderTree/chromium/ImageDiff.cpp:
582         (Image::createFromStdin): Fix spelling.
583         (maxOf3): New function to do 3-way maximum.
584         (getRedComponent): Extract red component from ABGR packed encoding.
585         (getGreenComponent): Extract green component from ABGR packed encoding.
586         (getBlueComponent): Extract blue component from ABGR packed encoding.
587         (weightedPercentageDifferent): Determine % of pixels different in two
588         images multiplied by intensity difference of each pixel.
589         (printHelp): Document new arguments.
590         (compareImages): Parameterize.
591         (untestedCompareImages): Parameterize.
592         (diffImages): Parameterize; write results on stdout if requested.
593         (main): Parse new arguments.
594
595 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
596
597         Reviewed by Simon Hausmann.
598
599         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
600         https://bugs.webkit.org/show_bug.cgi?id=42697
601
602         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
603
604         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
605         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
606         (WTR::InjectedBundle::beginTesting):
607         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
608         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
609         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
610
611 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
612
613         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
614         https://bugs.webkit.org/show_bug.cgi?id=61428
615         <rdar://problem/9457006>
616
617         Reviewed by Adam Roben.
618
619         The crash occurs when Flash posts a message to a window that it
620         creates, and in processing the message, it calls NPN_Evaluate to
621         evaluate JavaScript that removes the plug-in from the page. Flash then
622         crashes when we return to Flash code.
623
624         This test emulates that behavior.
625
626         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
627         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
628         Initialize member vars.
629         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
630         Remove our custom property from the message window, and destroy it.
631         (CallJSThatDestroysPlugin::NPP_Destroy):
632         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
633         layout test controller that we're done.
634         (wndProc):
635         Get the PluginTest object, and call its runTest() function.
636         (CallJSThatDestroysPlugin::NPP_New):
637         Setup the test: register a class for the message-only window, create
638         it, and post a message to it to run the test.
639         (CallJSThatDestroysPlugin::runTest):
640         Execute JS that removes the plug-in from the page, and if we're not
641         destroyed, log a success message.
642
643         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
644         Add new test to project.
645
646 2011-05-25  Tony Chang  <tony@chromium.org>
647
648         Reviewed by Adam Barth.
649
650         webkitpy's NetworkTransaction shouldn't use mechanize
651         https://bugs.webkit.org/show_bug.cgi?id=61450
652
653         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
654         use urllib2 directly.  Re-add NetworkTransaction to
655         test_results_uploader.py (reverting r87124).
656
657         * Scripts/webkitpy/common/net/networktransaction.py:
658         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
659
660 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
661
662         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
663         until the port begins using those export macros.
664
665         * DumpRenderTree/chromium/config.h:
666
667 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
668
669         Unreviewed, rolling out r87257.
670         http://trac.webkit.org/changeset/87257
671         https://bugs.webkit.org/show_bug.cgi?id=61457
672
673         This broke layout tests, see bug 61431. (Requested by
674         hwennborg on #webkit).
675
676         * DumpRenderTree/chromium/LayoutTestController.cpp:
677         (LayoutTestController::LayoutTestController):
678         (LayoutTestController::clearAllDatabases):
679         * DumpRenderTree/chromium/LayoutTestController.h:
680
681 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
682
683         Reviewed by Andreas Kling.
684
685         [Qt] fast/css/disabled-author-styles.html failed
686         https://bugs.webkit.org/show_bug.cgi?id=61438
687
688         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
689
690         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
691         (WebCore::WebPage::resetSettings):
692         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
693         (LayoutTestController::setAuthorAndUserStylesEnabled):
694         * DumpRenderTree/qt/LayoutTestControllerQt.h:
695
696 2011-05-25  Adam Roben  <aroben@apple.com>
697
698         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
699
700         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
701         started exiting early due to too many crashes, timeouts, or failures
702
703         Reviewed by David Kilzer.
704
705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
706         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
707         run-webkit-tests exits early due to too many failures, pass that information in another
708         argument to the callback.
709         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
710         the new structure of the object passed to the callback.
711         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
712         getNumberOfFailingTests and to pass that along to our own callbacks.
713         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
714         from _getFailingTests and to store that value in the history object.
715
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
717         (.info): Added.
718
719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
720         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
721         object and to add a note when run-webkit-tests exited early due to too many failures.
722         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
723         latestBuildInfos since each entry now contains more than just the tester and failure count.
724         Now displays a message for testers where the latest build exited early due to too many
725         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
726         store that value in latestBuildInfos.
727
728 2011-05-24  Keishi Hattori  <keishi@webkit.org>
729
730         Reviewed by Kent Tamura.
731
732         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
733         https://bugs.webkit.org/show_bug.cgi?id=61273
734
735         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
736
737 2011-05-24  Greg Simon  <gregsimon@chromium.org>
738
739         Reviewed by Dimitri Glazkov.
740
741         Control Indexeddb backends from LayoutTestController
742         https://bugs.webkit.org/show_bug.cgi?id=61000
743
744         * DumpRenderTree/chromium/LayoutTestController.cpp:
745         (LayoutTestController::LayoutTestController):
746         (LayoutTestController::setOverrideIndexedDBBackingStore):
747         (LayoutTestController::clearAllDatabases):
748         * DumpRenderTree/chromium/LayoutTestController.h:
749
750 2011-05-24  Robert Hogan  <robert@webkit.org>
751
752         Reviewed by Ryosuke Niwa.
753
754         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
755         https://bugs.webkit.org/show_bug.cgi?id=61393
756
757         * DumpRenderTree/qt/EventSenderQt.h:
758         * DumpRenderTree/qt/EventSenderQt.cpp:
759         (getModifiers): static function for interpreting modifiers
760         (EventSender::mouseDown): Respect keyboard modifiers
761         (EventSender::keyDown): use new static function
762         (EventSender::sendOrQueueEvent): whitespace fix
763
764 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
765
766         Reviewed by Adam Barth.
767
768         Adding MHTML reading support.
769         https://bugs.webkit.org/show_bug.cgi?id=7168
770
771         * Scripts/build-webkit:
772         * Scripts/old-run-webkit-tests:
773         * Scripts/webkitperl/features.pm:
774         * Scripts/webkitpy/layout_tests/port/test_files.py:
775         * Scripts/webkitpy/layout_tests/port/webkit.py:
776
777 2011-05-24  Stephen White  <senorblanco@chromium.org>
778
779         Reviewed by Kenneth Russell.
780
781         Remove most style checks on Source/ThirdParty/glu, since it doesn't
782         follow WebKit style.
783         https://bugs.webkit.org/show_bug.cgi?id=61365
784
785         * Scripts/webkitpy/style/checker.py:
786
787 2011-05-24  Adam Roben  <aroben@apple.com>
788
789         Don't allow forcing builds through the build.webkit.org web interface
790
791         Someone has been forcing bogus builds.
792
793         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
794
795 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
796
797         Reviewed by Adam Roben.
798
799         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
800         https://bugs.webkit.org/show_bug.cgi?id=42669
801
802         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
803         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
804         Because that case changed the setting.
805
806         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
807         (WTR::InjectedBundle::beginTesting):
808
809 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
810
811         Reviewed by Kenneth Rohde Christiansen.
812
813         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
814         https://bugs.webkit.org/show_bug.cgi?id=61052
815
816         * Scripts/old-run-webkit-tests:
817
818 2011-05-24  Adam Roben  <aroben@apple.com>
819
820         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
821
822         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
823         that don't have any failing tests, which isn't useful
824
825         Reviewed by David Kilzer.
826
827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
828         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
829         instead of name strings.
830         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
831         builder names into an array of builders.
832
833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
834         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
835         the most recently completed build, or -1 if there is no such build.
836         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
837         in the given build, or -1 if the number could not be determined. Some of this code came from
838         _getFailingTests.
839         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
840         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
841         getNumberOfFailingTests functions.
842
843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
844         (ViewController.prototype._displayTesters): Get the current number of test failures for each
845         tester and show it in the list. Omit testers that have no failures at all. We keep the
846         testers and failure counts in an array and sort it before displaying the current data, as
847         the order in which data will be fetched is unpredictable.
848
849 2011-05-23  Tony Chang  <tony@chromium.org>
850
851         Reviewed by Ojan Vafai.
852
853         [nrwt] don't use NetworkTranslation when uploading results
854         https://bugs.webkit.org/show_bug.cgi?id=61315
855
856         This avoids autoinstalling mechanize.  It didn't matter anyway
857         because test_results_uploader.py wasn't using mechanize to make the
858         request so NetworkTransaction::run wasn't doing anything extra
859         (it only matters if it catches mechanize.HTTPError).
860
861         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
862
863 2011-05-23  Tony Chang  <tony@chromium.org>
864
865         Reviewed by Dirk Pranke.
866
867         [chromium] fix the rebaseline tool to work with Linux GPU failures
868         https://bugs.webkit.org/show_bug.cgi?id=61312
869
870         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
871
872 2011-05-23  Darin Adler  <darin@apple.com>
873
874         Ignore generated .pyc files in a directory full of python code.
875
876         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
877
878 2011-05-23  Adam Barth  <abarth@webkit.org>
879
880         Reviewed by Eric Seidel.
881
882         sheriffbot should give more details about the failures in IRC
883         https://bugs.webkit.org/show_bug.cgi?id=61233
884
885         With this patch, sheriffbot will annonce the set of failing tests,
886         which might help folks triage the problem.
887
888         * Scripts/webkitpy/tool/commands/sheriffbot.py:
889         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
890
891 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
892
893         Unreviewed, rolling out r87078.
894         http://trac.webkit.org/changeset/87078
895         https://bugs.webkit.org/show_bug.cgi?id=61294
896
897         Patch contains errors and seems likely to break a bunch of
898         bots (Requested by abarth on #webkit).
899
900         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
901         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
902         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
903
904 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
905
906         Reviewed by Ojan Vafai.
907
908         Convert json_results_generator.py to output version 4 JSON.
909         https://bugs.webkit.org/show_bug.cgi?id=60869
910
911         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
912         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
913         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
914
915 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
916
917         Reviewed by Adam Barth.
918
919         Move generation of shell_command from port to executive
920         https://bugs.webkit.org/show_bug.cgi?id=61251
921
922         After move it's possible to use the code in other places too.
923
924         * Scripts/webkitpy/common/config/ports.py:
925         * Scripts/webkitpy/common/system/executive.py:
926
927 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
928
929         Reviewed by Darin Adler.
930
931         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
932         https://bugs.webkit.org/show_bug.cgi?id=42669
933
934         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
935
936         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
937         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
938         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
939         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
940
941 2011-05-22  Robert Hogan  <robert@webkit.org>
942
943         Reviewed by Kenneth Rohde Christiansen.
944
945         Fix policyDelegate in Qt DRT
946         https://bugs.webkit.org/show_bug.cgi?id=61247
947
948         Use the 'policy delegate' implemented in FrameLoaderClient
949         for layout tests. The partial implementation in DumpRenderTreeQt
950         is redundant, so remove it.
951
952         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
953         (WebCore::WebPage::acceptNavigationRequest):
954         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
955         (LayoutTestController::waitForPolicyDelegate):
956
957 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
958
959         Reviewed by Darin Adler.
960
961         Use double quotes for filename arguments
962         https://bugs.webkit.org/show_bug.cgi?id=61250
963
964         Windows does not support single quotes on the command line,
965         so replace them with double quotes.
966
967         * Scripts/prepare-ChangeLog:
968
969 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
970
971         Reviewed by Sam Weinig.
972
973         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
974         https://bugs.webkit.org/show_bug.cgi?id=42550
975         
976         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
977
978         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
979         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
980         Copy the code for pausing animations, FIXME comments and all.
981         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
982         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
983
984 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
985
986         Reviewed by Stephen White.
987
988         Adding myself to the committers list.
989
990         * Scripts/webkitpy/common/config/committers.py:
991
992 2011-05-19  Adam Roben  <aroben@apple.com>
993
994         Test that the WebKit2 UI process doesn't crash when starting a download
995
996         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
997         (preceded by assertion) in fastMalloc when downloading a file
998
999         Reviewed by Darin Adler.
1000
1001         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1002
1003         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1004         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1005         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1006         started, cancel the download, and return a bogus string.
1007
1008         (TestWebKitAPI::setContextDownloadClient):
1009         (TestWebKitAPI::setPagePolicyClient):
1010         Simple helper functions.
1011
1012         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1013         our policy client, and run until we know that the download was started. If we haven't
1014         crashed, we win!
1015
1016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1017         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1018         * TestWebKitAPI/win/copy-resources.cmd:
1019         Added new files.
1020
1021 2011-05-20  Kent Tamura  <tkent@chromium.org>
1022
1023         Reviewed by Ryosuke Niwa.
1024
1025         Fix style errors in DumpRenderTree/chromium/.
1026         https://bugs.webkit.org/show_bug.cgi?id=61172
1027
1028         * DumpRenderTree/chromium/CppBoundClass.cpp:
1029         (CppBoundClass::getAsCppVariant):
1030         (CppBoundClass::bindToJavascript):
1031         * DumpRenderTree/chromium/CppBoundClass.h:
1032         (CppBoundClass::GetterCallback::~GetterCallback):
1033         (CppBoundClass::CppBoundClass):
1034         (CppBoundClass::Callback::~Callback):
1035         (CppBoundClass::MemberCallback::MemberCallback):
1036         (CppBoundClass::MemberCallback::~MemberCallback):
1037         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1038         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1039         * DumpRenderTree/chromium/CppVariant.h:
1040         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1041         (DRTDevToolsAgent::~DRTDevToolsAgent):
1042         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1043         (DRTDevToolsClient::sendFrontendLoaded):
1044         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1045         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1046         (main):
1047         * DumpRenderTree/chromium/EventSender.cpp:
1048         (SavedEvent::SavedEvent):
1049         (EventSender::EventSender):
1050         (EventSender::keyDown):
1051         * DumpRenderTree/chromium/EventSender.h:
1052         * DumpRenderTree/chromium/ImageDiff.cpp:
1053         (Image::Image):
1054         * DumpRenderTree/chromium/LayoutTestController.cpp:
1055         (LayoutTestController::LayoutTestController):
1056         (LayoutTestController::WorkQueue::reset):
1057         (WorkItemBackForward::WorkItemBackForward):
1058         (WorkItemLoadingScript::WorkItemLoadingScript):
1059         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1060         (WorkItemLoad::WorkItemLoad):
1061         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1062         (LayoutTestController::pathToLocalResource):
1063         * DumpRenderTree/chromium/LayoutTestController.h:
1064         (LayoutTestController::WorkItem::~WorkItem):
1065         (LayoutTestController::WorkQueue::WorkQueue):
1066         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1067         (MockSpellCheck::MockSpellCheck):
1068         (MockSpellCheck::~MockSpellCheck):
1069         * DumpRenderTree/chromium/MockSpellCheck.h:
1070         * DumpRenderTree/chromium/NotificationPresenter.h:
1071         (NotificationPresenter::NotificationPresenter):
1072         * DumpRenderTree/chromium/Task.cpp:
1073         (WebTask::WebTask):
1074         * DumpRenderTree/chromium/Task.h:
1075         (TaskList::TaskList):
1076         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1077         (DRTPrinter::DRTPrinter):
1078         (TestShellPrinter::TestShellPrinter):
1079         * DumpRenderTree/chromium/TestNavigationController.cpp:
1080         (TestNavigationEntry::TestNavigationEntry):
1081         (TestNavigationEntry::~TestNavigationEntry):
1082         (TestNavigationController::TestNavigationController):
1083         (TestNavigationController::reload):
1084         (TestNavigationController::loadEntry):
1085         (TestNavigationController::didNavigateToEntry):
1086         * DumpRenderTree/chromium/TestNavigationController.h:
1087         (TestShellExtraData::TestShellExtraData):
1088         * DumpRenderTree/chromium/TestShell.cpp:
1089         (dumpHistoryItem):
1090         * DumpRenderTree/chromium/TestShell.h:
1091         (TestParams::TestParams):
1092         * DumpRenderTree/chromium/TestShellWin.cpp:
1093         (TestShell::waitTestFinished):
1094         * DumpRenderTree/chromium/TestWebWorker.h:
1095         (TestWebWorker::startWorkerContext):
1096         (TestWebWorker::terminateWorkerContext):
1097         (TestWebWorker::postMessageToWorkerContext):
1098         (TestWebWorker::clientDestroyed):
1099         (TestWebWorker::postMessageToWorkerObject):
1100         (TestWebWorker::postExceptionToWorkerObject):
1101         (TestWebWorker::postConsoleMessageToWorkerObject):
1102         (TestWebWorker::confirmMessageFromWorkerObject):
1103         (TestWebWorker::reportPendingActivity):
1104         (TestWebWorker::workerContextClosed):
1105         (TestWebWorker::~TestWebWorker):
1106         * DumpRenderTree/chromium/TextInputController.cpp:
1107         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1108         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1109         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1110         (WebThemeEngineDRTWin::paintButton):
1111         (WebThemeEngineDRTWin::paintMenuList):
1112         (WebThemeEngineDRTWin::paintTrackbar):
1113         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1114         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1115         * DumpRenderTree/chromium/WebViewHost.cpp:
1116         (WebViewHost::navigate):
1117         (WebViewHost::updateSessionHistory):
1118         (WebViewHost::paintInvalidatedRegion):
1119         * DumpRenderTree/chromium/WebViewHost.h:
1120
1121 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1122
1123         Reviewed by Adam Roben.
1124
1125         Detect hangs in run-api-tests
1126         https://bugs.webkit.org/show_bug.cgi?id=48043
1127
1128         * Scripts/run-api-tests: Added test timeouts
1129
1130 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1131
1132         Reviewed by Adam Roben.
1133
1134         run-api-tests should run one test per process
1135         https://bugs.webkit.org/show_bug.cgi?id=61088
1136
1137         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1138         return code, and parsing GTest output format.
1139
1140 2011-05-15  Robert Hogan  <robert@webkit.org>
1141
1142         Reviewed by Antonio Gomes.
1143
1144         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1145         https://bugs.webkit.org/show_bug.cgi?id=60834
1146         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1147
1148         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1149         (webkit_test_plugin_new_stream):
1150         (webkit_test_plugin_write_ready):
1151         (webkit_test_plugin_write):
1152
1153 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1154
1155         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1156         http://trac.webkit.org/changeset/86869
1157         http://trac.webkit.org/changeset/86873
1158         http://trac.webkit.org/changeset/86875
1159         http://trac.webkit.org/changeset/86877
1160         https://bugs.webkit.org/show_bug.cgi?id=61139
1161
1162         broke builds and debug DRT (Requested by rniwa on #webkit).
1163
1164         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1165         * DumpRenderTree/chromium/TestShell.cpp:
1166         (TestShell::bindJSObjectsToWindow):
1167         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1168         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1169
1170 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1171
1172         Reviewed by Darin Adler.
1173
1174         Add build logistics and plumbing for window.internals object.
1175         https://bugs.webkit.org/show_bug.cgi?id=60313
1176
1177         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1178         * DumpRenderTree/chromium/TestShell.cpp:
1179         (TestShell::bindJSObjectsToWindow): Added injection code.
1180         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1181         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1182
1183 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1184
1185         Reviewed by Csaba Osztrogonác.
1186
1187         [Qt] Implement eventSender.scalePageBy
1188         https://bugs.webkit.org/show_bug.cgi?id=60015
1189
1190         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1191         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1192         * DumpRenderTree/qt/EventSenderQt.cpp:
1193         (EventSender::scalePageBy):
1194         * DumpRenderTree/qt/EventSenderQt.h:
1195
1196 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
1197
1198         Reviewed by Kent Tamura.
1199
1200         [Chromium] IME candidate window appears wrong position in an iframe
1201         https://bugs.webkit.org/show_bug.cgi?id=61023
1202
1203         Call the focused frame's firstRectForCharacterRange() instead of the
1204         main frame so that DRT behaves as the same as Chromium.
1205
1206         * DumpRenderTree/chromium/TextInputController.cpp:
1207         (TextInputController::firstRectForCharacterRange):
1208
1209 2011-05-18  Adam Roben  <aroben@apple.com>
1210
1211         Add a new page to build.webkit.org to help find when tests started failing
1212
1213         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
1214         right now, but already shows some useful information. It's somewhat similar to webkit-patch
1215         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
1216         little more convenient than either of them, though, because it's all done in the browser
1217         (and thus it's easy to go directly to the relevant test results).
1218
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
1220         (Buildbot): This class represents a Buildbot server.
1221         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
1222         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
1223         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
1224         callback.
1225         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
1226         be implemented by a derived class that understands this server's build naming scheme.
1227         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1228         particular build.
1229
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
1231         (Builder): This class represents one builder on the buildbot.
1232         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
1233         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
1234         information about a particular test failure.
1235         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
1236         information about when tests started failing.
1237         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1238         particular build.
1239         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
1240         callback.
1241         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
1242         extracts all the failing tests listed in it, passing them to the callback.
1243         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
1244         build, merges them into the build history, and calls the callback telling it whether the
1245         next build should be fetched to provide more information.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1248         Added. Just some simple styles.
1249
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
1251         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
1252         (getResource): Wrapper around XMLHttpRequest.
1253         (Array.prototype.findFirst): Finds the first element matching the given predicate and
1254         returns it.
1255         (Array.prototype.last): Returns the last element of the array.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
1258         (ViewController): This class contains the main logic for displaying the page.
1259         (ViewController.loaded): Just calls through to parseHash.
1260         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
1261         shows the list of all testers so one can be chosen. This function is called when the page
1262         loads and whenever we get a hashchange event.
1263         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
1264         as it is fetched. The display ends up grouping tests by when they started failing.
1265         (ViewController._displayTesters): Gets the list of testers and displays it.
1266
1267         (ViewController._domForBuildName):
1268         (ViewController._domForFailedTest):
1269         Helper functions to create descriptions and links for a particular build or failed test.
1270
1271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
1272         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
1273         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
1274
1275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
1276         loads all the files and sets up a ViewController, which does the rest.
1277
1278         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
1279         page.
1280
1281 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1282
1283         Reviewed by Csaba Osztrogonác.
1284
1285         [Qt] Implement layoutTestController.setValueForUser()
1286         https://bugs.webkit.org/show_bug.cgi?id=60956
1287
1288         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1289         (LayoutTestController::setValueForUser):
1290         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1291
1292 2011-05-16  Robert Hogan  <robert@webkit.org>
1293
1294         Reviewed by Kenneth Rohde Christiansen.
1295
1296         plugins/invalidate_rect.html fails on linux ports
1297
1298         - Make the unix test netscape plugin recognize the onPaintEvent
1299           and windowedPlugin parameters.
1300
1301         https://bugs.webkit.org/show_bug.cgi?id=54051
1302
1303         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1304         (handleEventX11):
1305         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1306         (LayoutTestController::displayInvalidatedRegion):
1307         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1308         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1309         (webkit_test_plugin_new_instance):
1310         (webkit_test_plugin_handle_event):
1311
1312 2011-05-17  Tony Chang  <tony@chromium.org>
1313
1314         Reviewed by Ojan Vafai.
1315
1316         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
1317         https://bugs.webkit.org/show_bug.cgi?id=60895
1318
1319         Update the tools to handle the move.  Lucid 32 results now go in
1320         chromium-linux-x86 and the default platform on Linux is now x86_64.
1321
1322         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
1323         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1324         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
1325         * Scripts/webkitpy/layout_tests/port/base.py: ditto
1326         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
1327         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1328         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
1329         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
1330         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
1331
1332 2011-05-17  Adam Roben  <aroben@apple.com>
1333
1334         Make run-api-tests work on Windows when there are spaces in the path
1335
1336         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
1337         spaces in the path to TestWebKitAPI.exe
1338
1339         Reviewed by David Levin.
1340
1341         * Scripts/run-api-tests:
1342         (runTestTool): Use the "direct object" form of system() to avoid having the path to
1343         TestWebKitAPI.exe be split by the shell.
1344
1345 2011-05-16  Ian Henderson  <ianh@apple.com>
1346
1347         Reviewed by Joseph Pecoraro.
1348
1349         Page::goToItem doesn't work while loading is deferred
1350         https://bugs.webkit.org/show_bug.cgi?id=60412
1351
1352         Add setDefersLoading and goBack methods to LayoutTestController.  We
1353         need to use goBack() instead of history.back() because the latter goes
1354         through NavigationScheduler, hence doesn't exhibit the bug.
1355
1356         * DumpRenderTree/LayoutTestController.cpp:
1357         (goBackCallback):
1358         (setDefersLoadingCallback):
1359         (LayoutTestController::staticFunctions):
1360         * DumpRenderTree/LayoutTestController.h:
1361         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1362         (LayoutTestController::goBack):
1363         (LayoutTestController::setDefersLoading):
1364         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1365         (LayoutTestController::goBack):
1366         (LayoutTestController::setDefersLoading):
1367         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1368         (LayoutTestController::goBack):
1369         (LayoutTestController::setDefersLoading):
1370         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1371         (LayoutTestController::goBack):
1372         (LayoutTestController::setDefersLoading):
1373
1374 2011-05-16  Sam Weinig  <sam@webkit.org>
1375
1376         Reviewed by Anders Carlsson.
1377
1378         TestWebKitAPI should build with clang if it can
1379         https://bugs.webkit.org/show_bug.cgi?id=60918
1380
1381         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1382         Update CompilerVersion.xcconfig to match others.
1383
1384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1385         Add CompilerVersion.xcconfig to the project.
1386
1387         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1388         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1389         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1390         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1391         Add some casts to quiet warnings from clang.
1392
1393 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
1394
1395         Reviewed by David Levin.
1396
1397         add dpranke as a reviewer
1398         https://bugs.webkit.org/show_bug.cgi?id=60919
1399
1400         * Scripts/webkitpy/common/config/committers.py:
1401
1402 2011-05-16  Robert Hogan  <robert@webkit.org>
1403
1404         Reviewed by Anders Carlsson.
1405
1406         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
1407
1408         https://bugs.webkit.org/show_bug.cgi?id=60838
1409
1410         The unix test plugin needs to call the test's NPP_URLNotify
1411         rather than the browsers.
1412
1413         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1414         (webkit_test_plugin_url_notify):
1415
1416 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
1417
1418         Rubber-stamped by Adam Roben.
1419
1420         Adding myself as a reviewer.
1421         * Scripts/webkitpy/common/config/committers.py:
1422
1423 2011-05-16  Sam Weinig  <sam@webkit.org>
1424
1425         Fix typo pointed out by Dave Levin.
1426
1427         * TestWebKitAPI/PlatformUtilities.h:
1428         (TestWebKitAPI::Util::assertWKStringEqual):
1429         Strig -> String.
1430
1431 2011-05-16  Sam Weinig  <sam@webkit.org>
1432
1433         Reviewed by David Levin.
1434
1435         Convert api tester over to using gtest expectations directly
1436         https://bugs.webkit.org/show_bug.cgi?id=60862
1437
1438         * TestWebKitAPI/PlatformUtilities.cpp:
1439         (TestWebKitAPI::Util::toSTD):
1440         * TestWebKitAPI/PlatformUtilities.h:
1441         (TestWebKitAPI::Util::assertWKStrigEqual):
1442         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
1443         the implementation of the macro simpler.
1444
1445         * TestWebKitAPI/Test.h:
1446         Remove TEST_ASSERT forwarder.
1447
1448         [Test changes elided]
1449
1450 2011-05-16  David Kilzer  <ddkilzer@apple.com>
1451
1452         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1453         <rdar://problem/9446430>
1454
1455         Reviewed by Mark Rowe.
1456
1457         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
1458         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1459         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1460
1461 2011-05-16  Jon Lee  <jonlee@apple.com>
1462
1463         Reviewed by Simon Fraser.
1464
1465         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1466         https://bugs.webkit.org/show_bug.cgi?id=60779
1467
1468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1469         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
1470
1471 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1472
1473         Reviewed by Csaba Osztrogonác.
1474
1475         [Qt] Tools.pro misses include(common.pri)
1476         https://bugs.webkit.org/show_bug.cgi?id=60883
1477
1478         It includes features.pri, which depends on common.pri (the build is
1479         not broken today with the default options, but this is the right
1480         thing to do).
1481
1482         * Tools.pro:
1483
1484 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
1485
1486         Unreviewed: adding myself to committers.py.
1487
1488         * Scripts/webkitpy/common/config/committers.py:
1489
1490 2011-05-15  Daniel Bates  <dbates@webkit.org>
1491
1492         Reviewed by Chris Jerdonek.
1493
1494         svn-apply can't handle Git diff that only changes executable bit
1495         https://bugs.webkit.org/show_bug.cgi?id=60848
1496
1497         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
1498         that only has an executable bit change.
1499
1500         * Scripts/VCSUtils.pm:
1501           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
1502         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
1503         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
1504         * Scripts/svn-apply:
1505         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
1506         * Scripts/svn-unapply:
1507         (patch): Ditto.
1508         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1509           - Updated expected results for test cases to account for numTextChunks.
1510           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
1511           - Added test case "Git: file that only has an executable bit change".
1512         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1513           - Updated expected results for test cases to account for numTextChunks.
1514
1515 2011-05-15  Sam Weinig  <sam@webkit.org>
1516
1517         Fix windows build.
1518
1519         * TestWebKitAPI/win/main.cpp:
1520         (main):
1521
1522 2011-05-15  Sam Weinig  <sam@webkit.org>
1523
1524         Reviewed by David Levin.
1525
1526         Make API tester more gtest friendly
1527         https://bugs.webkit.org/show_bug.cgi?id=60859
1528
1529         * Scripts/run-api-tests:
1530         Numerous changes:
1531         - Remove logic to run tests one at a time.
1532         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
1533           the test runner and allow gtest to print it for us.
1534         - Forward stdout from the test tool to stdout, even in non-verbose runs.
1535         - Run test tool from the current working directory instead of the root webkit
1536           directory.
1537
1538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1539         Move plist to be with other bundle sources.
1540
1541         * TestWebKitAPI/TestsController.cpp:
1542         (TestWebKitAPI::TestsController::TestsController):
1543         (TestWebKitAPI::TestsController::run):
1544         * TestWebKitAPI/TestsController.h:
1545         * TestWebKitAPI/mac/main.mm:
1546         Simplify TestController down to a single run function. We should consider removing the class
1547         entirely at some point.
1548
1549 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1550
1551         Unreviewed, rolling out r86504.
1552         http://trac.webkit.org/changeset/86504
1553         https://bugs.webkit.org/show_bug.cgi?id=60853
1554
1555         "Broke Qt EventSender in editing/selection tests" (Requested
1556         by mwenge on #webkit).
1557
1558         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1559         (WebCore::WebPage::WebPage):
1560         (WebCore::DumpRenderTree::DumpRenderTree):
1561         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1562         (WebCore::DumpRenderTree::initJSObjects):
1563         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1564         (WebCore::DumpRenderTree::eventSender):
1565         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1566         (webkit_test_plugin_new_instance):
1567         (webkit_test_plugin_set_window):
1568         (webkit_test_plugin_handle_event):
1569
1570 2011-05-12  Robert Hogan  <robert@webkit.org>
1571
1572         Reviewed by Benjamin Poulain.
1573
1574         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1575
1576         The support for this test added to the unix test plugin here
1577         may allow other platforms to pass it (nearly everyone
1578         skips it). On Qt it required a bit of trickiness with
1579         the page's EventSender object to get it working fully though,
1580         so only unskipping Qt here.
1581
1582         https://bugs.webkit.org/show_bug.cgi?id=60722
1583
1584         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1585         (WebCore::WebPage::WebPage):
1586         (WebCore::WebPage::eventSender):
1587         (WebCore::DumpRenderTree::DumpRenderTree):
1588         (WebCore::DumpRenderTree::initJSObjects):
1589         (WebCore::DumpRenderTree::createWindow):
1590         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1591         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1592         (webkit_test_plugin_new_instance):
1593         (webkit_test_plugin_set_window):
1594         (webkit_test_plugin_handle_event):
1595
1596 2011-05-14  Arno Renevier  <arno@renevier.net>
1597
1598         Reviewed by Martin Robinson.
1599
1600         make run-gtk-tests executable
1601         https://bugs.webkit.org/show_bug.cgi?id=59278
1602
1603         * Scripts/run-gtk-tests:
1604
1605 2011-05-14  Anders Carlsson  <andersca@apple.com>
1606
1607         Reviewed by Kevin Decker.
1608
1609         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1610         https://bugs.webkit.org/show_bug.cgi?id=60823
1611         <rdar://problem/9430386>
1612
1613         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1614
1615         * DumpRenderTree/DumpRenderTree.gypi:
1616         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1617         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1618         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1619         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1620         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1621         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1622         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1623         * GNUmakefile.am:
1624
1625 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1626
1627         Unreviewed, rolling out r86476.
1628         http://trac.webkit.org/changeset/86476
1629         https://bugs.webkit.org/show_bug.cgi?id=60832
1630
1631         It made plugins/get-url-notify-with-url-that-fails-to-
1632         load.html crash on GTK (Requested by Ossy on #webkit).
1633
1634         * DumpRenderTree/DumpRenderTree.gypi:
1635         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1636         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
1637         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1638         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1639         * GNUmakefile.am:
1640
1641 2011-05-13  Anders Carlsson  <andersca@apple.com>
1642
1643         Reviewed by Sam Weinig.
1644
1645         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1646         https://bugs.webkit.org/show_bug.cgi?id=60823
1647         <rdar://problem/9430386>
1648
1649         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1650
1651         * DumpRenderTree/DumpRenderTree.gypi:
1652         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1653         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1654         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1655         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1656         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1657         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1658         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1659         * GNUmakefile.am:
1660
1661 2011-05-13  Anders Carlsson  <andersca@apple.com>
1662
1663         Build fix.
1664
1665         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
1666
1667 2011-05-13  Anders Carlsson  <andersca@apple.com>
1668
1669         Reviewed by Sam Weinig.
1670
1671         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
1672         https://bugs.webkit.org/show_bug.cgi?id=60810
1673
1674         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
1675
1676         * DumpRenderTree/DumpRenderTree.gypi:
1677         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1678         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1679         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1680         * GNUmakefile.am:
1681         Add files.
1682
1683         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1684         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1685         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
1686
1687         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
1688         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
1689         (GetURLWithJavaScriptURL::NPP_New):
1690         (GetURLWithJavaScriptURL::NPP_NewStream):
1691         (GetURLWithJavaScriptURL::NPP_DestroyStream):
1692         (GetURLWithJavaScriptURL::NPP_WriteReady):
1693         (GetURLWithJavaScriptURL::NPP_Write):
1694         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1695         (NPP_NewStream):
1696         (NPP_WriteReady):
1697         (NPP_Write):
1698         (NPP_URLNotify):
1699         call the PluginTest NPP wrappers.
1700
1701 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1702
1703         Unreviewed, rolling out r86447.
1704         http://trac.webkit.org/changeset/86447
1705         https://bugs.webkit.org/show_bug.cgi?id=60809
1706
1707         "Broke some uses of EventSender object on Qt" (Requested by
1708         mwenge on #webkit).
1709
1710         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1711         (WebCore::WebPage::WebPage):
1712         (WebCore::DumpRenderTree::DumpRenderTree):
1713         (WebCore::DumpRenderTree::initJSObjects):
1714         (WebCore::DumpRenderTree::createWindow):
1715         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1716         (WebCore::DumpRenderTree::eventSender):
1717         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1718         (webkit_test_plugin_new_instance):
1719         (webkit_test_plugin_set_window):
1720         (webkit_test_plugin_handle_event):
1721
1722 2011-05-13  Robert Hogan  <robert@webkit.org>
1723
1724         Reviewed by Benjamin Poulain.
1725
1726         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1727
1728         The support for this test added to the unix test plugin here
1729         may allow other platforms to pass it (nearly everyone
1730         skips it). On Qt it required a bit of trickiness with
1731         the page's EventSender object to get it working fully though,
1732         so only unskipping Qt here.
1733
1734         https://bugs.webkit.org/show_bug.cgi?id=60722
1735
1736         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1737         (WebCore::WebPage::WebPage):
1738         (WebCore::WebPage::eventSender):
1739         (WebCore::DumpRenderTree::DumpRenderTree):
1740         (WebCore::DumpRenderTree::initJSObjects):
1741         (WebCore::DumpRenderTree::createWindow):
1742         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1743         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1744         (webkit_test_plugin_new_instance):
1745         (webkit_test_plugin_set_window):
1746         (webkit_test_plugin_handle_event):
1747
1748 2011-05-13  Adam Roben  <aroben@apple.com>
1749
1750         Exclude the Leopard NRWT bot from the core builder set
1751
1752         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
1753
1754         Reviewed by Darin Adler.
1755
1756         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1757         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
1758         in the core builder set.
1759
1760         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1761         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
1762         regexps.
1763
1764 2011-05-13  Adam Roben  <aroben@apple.com>
1765
1766         Group all the NRWT bots together
1767
1768         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
1769         bots are experimental, it seems best not to clutter up the non-experimental bots with
1770         experimental ones.
1771
1772         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
1773         on build.webkit.org
1774
1775         Reviewed by Dan Bernstein.
1776
1777         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
1778         Chromium testers, which also use new-run-webkit-tests.
1779
1780 2011-05-13  Adam Roben  <aroben@apple.com>
1781
1782         Add a plugin test that dumps the plugin window's rect
1783
1784         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
1785         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
1786
1787         Reviewed by Dan Bernstein.
1788
1789         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
1790         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
1791         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
1792         harness window and log it.
1793
1794         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
1795
1796 2011-05-13  Adam Roben  <aroben@apple.com>
1797
1798         Move code required for most tests of plugin window geometry into a base class
1799
1800         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
1801         having all the trickiness in a shared base class, writing new window geometry tests will be
1802         much easier.
1803
1804         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
1805
1806         Reviewed by Anders Carlsson.
1807
1808         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1809         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
1810         WindowGeometryTest base class. Most of the code from this class was moved to the new base
1811         class.
1812         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
1813         This is called by the base class when it is safe to check the window's geometry. Note that
1814         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
1815         just vestigial code from an earlier version of this test.
1816
1817         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
1818         WindowGeometryTest class.
1819
1820         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
1821         WindowRegionIsSetToClipRect.
1822         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
1823         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
1824         Subclasses can implement that function to perform their own tests.
1825
1826         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
1827
1828 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
1829
1830         Reviewed by Csaba Osztrogonác.
1831
1832         Missing 2nd #EOF if WebProcess is killed.
1833         https://bugs.webkit.org/show_bug.cgi?id=60761
1834
1835         If the WebProcess is killed, only one #EOF is yielded
1836         by WebKitTestRunner. However, run-webkit-test wait for
1837         a second #EOF, which signals the finishing of pixel dump.
1838         Since this never happens, run-webkit-test waits forever.
1839
1840         * WebKitTestRunner/TestInvocation.cpp:
1841         (WTR::TestInvocation::dump):
1842         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1843         * WebKitTestRunner/TestInvocation.h:
1844
1845 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1846
1847         Reviewed by Csaba Osztrogonác.
1848
1849         [NRWT] chromium-linux tests shouldn't run on other platforms
1850         https://bugs.webkit.org/show_bug.cgi?id=60162
1851
1852         Remove _tests_for_other_platforms defs because r82753
1853         implemented it properly in the baseclass in webkit.py.
1854
1855         * Scripts/webkitpy/layout_tests/port/gtk.py:
1856         * Scripts/webkitpy/layout_tests/port/qt.py:
1857         * Scripts/webkitpy/layout_tests/port/win.py:
1858
1859 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
1860
1861         Reviewed by Antonio Gomes.
1862
1863         [EFL] Remove unused option of EWeblauncher
1864         https://bugs.webkit.org/show_bug.cgi?id=60747
1865
1866         Remove sudo-workaround option.
1867         This option is not used and make other option wrong.
1868
1869         * EWebLauncher/main.c:
1870
1871 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1872
1873         Reviewed by Stephanie Lewis.
1874
1875         Fix config.json to address missing WK2 builder/tester config.
1876         Fix naming of machines (xserve not macpro)
1877
1878         * BuildSlaveSupport/build.webkit.org-config/config.json:
1879
1880 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1881
1882         Reviewed by Stephanie Lewis.
1883
1884         Add SnowLeopard Debug builder and Test bot.
1885         apple-xserve-8 = SL Debug Tester.
1886         apple-xserve-9 = SL Debug Builder.
1887         
1888         * BuildSlaveSupport/build.webkit.org-config/config.json:
1889
1890 2011-05-12  Adam Barth  <abarth@webkit.org>
1891
1892         This patch disables sheriffbot's bug postings.  He's just been way too
1893         spammy recently due to test flakiness.
1894
1895         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1896         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1897
1898 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1899
1900         Reviewed by Anders Carlsson.
1901
1902         After relaunching an unresponsive web process, web page stops responding to mouse movement
1903         https://bugs.webkit.org/show_bug.cgi?id=60669
1904         <rdar://problem/9409934>
1905         
1906         This test follows the steps needed to reproduce this bug:
1907         1) Hang the web process
1908         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
1909         3) Kill and restart the WebProcess
1910         4) Move the mouse
1911         
1912         We are testing that we receive mouse move events after the WebProcess has restarted.
1913
1914         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
1915         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
1916         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
1917         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
1918         (TestWebKitAPI::setPageLoaderClient):
1919         (TestWebKitAPI::TEST):
1920         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
1921         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
1922         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
1923         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
1924
1925         * TestWebKitAPI/PlatformWebView.h:
1926         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1927         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
1928         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1929         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
1930
1931         Add new files.
1932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1933         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1934         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1935         * TestWebKitAPI/win/copy-resources.cmd:
1936
1937 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
1938
1939         Reviewed by Antonio Gomes.
1940
1941         [EFL] Added initialization/shutdown for ecore_file library
1942         https://bugs.webkit.org/show_bug.cgi?id=60457
1943
1944         Added initialization and shuthown for ecore_file library and replaced
1945         realpath function to ecore_file_realpath.
1946
1947         * EWebLauncher/main.c:
1948         (quit):
1949         (findThemePath):
1950         (main):
1951
1952 2011-05-12  Young Han Lee  <joybro@company100.net>
1953
1954         Reviewed by Kenneth Rohde Christiansen.
1955
1956         [Qt] Implement layoutTestController.layerTreeAsText()
1957         https://bugs.webkit.org/show_bug.cgi?id=60367
1958
1959         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1960         (LayoutTestController::layerTreeAsText):
1961         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1962
1963 2011-05-11  Eric Seidel  <eric@webkit.org>
1964
1965         Reviewed by David Levin.
1966
1967         Teach validate-committer-lists how to validate committers bugzilla_email()
1968         https://bugs.webkit.org/show_bug.cgi?id=60651
1969
1970         It turns out we currently have 9 committers with invalid values for their
1971         bugzilla_email field (meaning we don't know what email is their bugzilla account).
1972         "Alexander Kellett" <lypanov@mac.com>
1973         "Andre Boule" <aboule@apple.com>
1974         "Cameron McCormack" <cam@webkit.org>
1975         "Chris Petersen" <cpetersen@apple.com>
1976         "Eli Fidler" <eli@staikos.net>
1977         "Matt Lilek" <webkit@mattlilek.com>
1978         "Pierre d'Herbemont" <pdherbemont@free.fr>
1979         "Scott Violet" <sky@chromium.org>
1980         "Adam Treat" <treat@kde.org>
1981
1982         Most of those haven't committed in a very long time, so it's not suprising
1983         that we haven't noticed that their bugzilla emails are bogus.
1984
1985         * Scripts/validate-committer-lists:
1986         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1987         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1988
1989 2011-05-11  Dmitry Lomov  <dslomov@google.com>
1990
1991         Reviewed by David Levin.
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=59561
1994         Switch TestWebKitAPI to GTest
1995
1996         Fixes Makefiles and WinCairo build as well
1997
1998         * Makefile:
1999         * Scripts/build-api-tests:
2000         * Scripts/run-api-tests:
2001         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2002         * TestWebKitAPI/Test.h:
2003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2004         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2005         (TestWebKitAPI::TEST):
2006         * TestWebKitAPI/TestsController.cpp:
2007         (TestWebKitAPI::TestsController::TestsController):
2008         (TestWebKitAPI::TestsController::dumpTestNames):
2009         (TestWebKitAPI::TestsController::runTestNamed):
2010         (TestWebKitAPI::TestsController::runAllTests):
2011         * TestWebKitAPI/TestsController.h:
2012         * TestWebKitAPI/mac/main.mm:
2013         (main):
2014
2015 2011-05-11  Eric Seidel  <eric@webkit.org>
2016
2017         Reviewed by Alexey Proskuryakov.
2018
2019         Add Luke Macpherson to committers.py as a Contributor
2020         https://bugs.webkit.org/show_bug.cgi?id=60639
2021
2022         * Scripts/webkitpy/common/config/committers.py:
2023
2024 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2025
2026         Reviewed by Kenneth Rohde Christiansen.
2027
2028         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2029         https://bugs.webkit.org/show_bug.cgi?id=60439
2030
2031         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2032
2033         * Scripts/build-webkit:
2034
2035 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2036
2037         Reviewed by Adam Roben.
2038
2039         REGRESSION (r86161): WKPreferences API test failing on Windows
2040         https://bugs.webkit.org/show_bug.cgi?id=60658
2041
2042         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2043         (TestWebKitAPI::TEST):
2044
2045 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2046
2047         Reviewed by Ojan Vafai.
2048
2049         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2050         https://bugs.webkit.org/show_bug.cgi?id=60521
2051
2052         First steps towards making the results JSON all hierarchical.
2053
2054         * TestResultServer/model/jsonresults.py:
2055         * TestResultServer/model/jsonresults_unittest.py:
2056
2057 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2058
2059         [wx] Build fix, adding new LayoutTestController method stubs.
2060
2061         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2062         (LayoutTestController::localStorageDiskUsageForOrigin):
2063         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2064
2065 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2066
2067         Reviewed by Darin Adler.
2068
2069         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2070         about the usage for both the origin overall and the database in question.
2071         https://bugs.webkit.org/show_bug.cgi?id=60573
2072
2073         * WebKitTestRunner/TestController.cpp:
2074         (WTR::exceededDatabaseQuota):
2075
2076 2011-05-10  Stephen White  <senorblanco@chromium.org>
2077
2078         Reviewed by David Levin.
2079
2080         Adding myself as a reviewer.
2081         https://bugs.webkit.org/show_bug.cgi?id=60587
2082
2083         * Scripts/webkitpy/common/config/committers.py:
2084
2085 2011-05-11  Eric Seidel  <eric@webkit.org>
2086
2087         Reviewed by Csaba Osztrogonác.
2088
2089         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2090         https://bugs.webkit.org/show_bug.cgi?id=60614
2091
2092         AppEngine has a result limit of 1000.  We hit that when trying
2093         to find out how many patches the style-queue (and other queues)
2094         have passed in the last 30 days.  So lets display 1000+ instead
2095         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2096
2097         I also made the status pages show "never" instead of just "ago" when we
2098         haven't seen a pass or boot message in the last 1000 messages.
2099
2100         * QueueStatusServer/handlers/queuestatus.py:
2101         * QueueStatusServer/templates/queuestatus.html:
2102
2103 2011-05-11  Adam Barth  <abarth@webkit.org>
2104
2105         Reviewed by Eric Seidel.
2106
2107         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2108         https://bugs.webkit.org/show_bug.cgi?id=60613
2109
2110         This patch limits the number of bugs sheriffbot will spam to three.
2111         Ideally, we'd come up with some smarter huerstics, but hopefully this
2112         will cut down on the bugmail spam for slow bots.
2113
2114         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2115
2116 2011-05-10  Eric Seidel  <eric@webkit.org>
2117
2118         Reviewed by Adam Barth.
2119
2120         EWS bots should be robust against test-webkitpy hangs
2121         https://bugs.webkit.org/show_bug.cgi?id=60579
2122
2123         Added a killAfterTimeout subroutine, which takes a child_pid
2124         and timeout, and will setup a watchdog process to kill that child
2125         after the timeout.  killAfterTimeout will waitpid on the child.
2126
2127         * EWSTools/start-queue.sh:
2128
2129 2011-05-10  MORITA Hajime  <morrita@google.com>
2130
2131         Unreviewed, moved myself to the reviewers list.
2132
2133         * Scripts/webkitpy/common/config/committers.py:
2134
2135 2011-05-10  Anton D'Auria  <adauria@apple.com>
2136
2137         Reviewed by David Levin.
2138
2139         StorageTracker should report actual local storage usage on disk
2140         https://bugs.webkit.org/show_bug.cgi?id=60558
2141
2142         * DumpRenderTree/LayoutTestController.cpp:
2143         (localStorageDiskUsageForOriginCallback):
2144         (LayoutTestController::staticFunctions):
2145         * DumpRenderTree/LayoutTestController.h:
2146         * DumpRenderTree/chromium/LayoutTestController.cpp:
2147         (LayoutTestController::LayoutTestController):
2148         (LayoutTestController::localStorageDiskUsageForOrigin):
2149         * DumpRenderTree/chromium/LayoutTestController.h:
2150         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2151         (LayoutTestController::localStorageDiskUsageForOrigin):
2152         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2153         (LayoutTestController::localStorageDiskUsageForOrigin):
2154         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2155         (LayoutTestController::localStorageDiskUsageForOrigin):
2156         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2158         (LayoutTestController::localStorageDiskUsageForOrigin):
2159
2160 2011-05-10  Anton D'Auria  <adauria@apple.com>
2161
2162         Reviewed by Alexey Proskuryakov.
2163
2164         Add ApplicationCache API to get disk usage per origin
2165         https://bugs.webkit.org/show_bug.cgi?id=57127
2166
2167         Added test that loads two frames with ~15Kb image, checks usage,
2168         deletes app cache, verifies usage is 0.
2169
2170         * DumpRenderTree/LayoutTestController.cpp:
2171         (applicationCacheDiskUsageForOriginCallback):
2172         (LayoutTestController::staticFunctions):
2173         * DumpRenderTree/LayoutTestController.h:
2174         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2175         (LayoutTestController::LayoutTestController):
2176         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2177         * DumpRenderTree/chromium/LayoutTestController.h:
2178         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2179         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2180         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2181         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2182         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2183         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2184         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2185         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2186         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2187
2188 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2189
2190         Unreviewed, adding Rafael Antognolli as a committer.
2191
2192         * Scripts/webkitpy/common/config/committers.py:
2193
2194 2011-05-10  Chris Evans  <cevans@chromium.org>
2195
2196         Reviewed by Adam Barth.
2197
2198         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2199         https://bugs.webkit.org/show_bug.cgi?id=58378
2200
2201         * DumpRenderTree/chromium/LayoutTestController.cpp:
2202         (LayoutTestController::LayoutTestController):
2203         (LayoutTestController::setAllowDisplayOfInsecureContent):
2204         (LayoutTestController::setAllowRunningOfInsecureContent):
2205         * DumpRenderTree/chromium/LayoutTestController.h:
2206         * DumpRenderTree/chromium/WebPreferences.cpp:
2207         (WebPreferences::reset):
2208         (WebPreferences::applyTo):
2209         * DumpRenderTree/chromium/WebPreferences.h:
2210         Add plumbing for new settings to Chromium DRT.
2211
2212 2011-05-10  Enrica Casucci  <enrica@apple.com>
2213
2214         Reviewed by Beth Dakin.
2215
2216         Added my name to the reviewers list and removed my name from
2217         to committer-only list.
2218
2219         * Scripts/webkitpy/common/config/committers.py:
2220
2221 2011-05-10  David Levin  <levin@chromium.org>
2222
2223         Reviewed by Shinichiro Hamaji.
2224
2225         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
2226         https://bugs.webkit.org/show_bug.cgi?id=60466
2227
2228         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
2229         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
2230           that property was removed.
2231         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
2232           filtering for errors.
2233         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
2234           verify that the line filtering is turned off.
2235         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
2236           and remove the unused file_path parameter.
2237         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
2238           line filtering is turned off (and fix test_no_error).
2239         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
2240           of errors based on the lines changed in the patch.
2241         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
2242           the filtering.
2243
2244 2011-05-10  Adam Roben  <aroben@apple.com>
2245
2246         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
2247
2248         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
2249         platform/win/plugins/window-geometry-initialized-before-set-window.html and
2250         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
2251         (WebKit2 Tests)
2252
2253         Reviewed by Anders Carlsson.
2254
2255         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2256         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
2257         WindowedPluginTest::testHarnessWindow function.
2258
2259         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2260         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
2261         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
2262         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
2263         created for.
2264
2265         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2266         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
2267         WindowedPluginTest, and initialized new members.
2268         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
2269         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
2270         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
2271         then clean up and tell the test harness we're done.
2272         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
2273         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
2274         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
2275         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
2276         window becomes visible.
2277         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
2278         if it was hidden at the start of the test.
2279         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
2280         This should cause our window to become visible and our window region to get set. When we get
2281         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
2282         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
2283         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
2284         "startTest".
2285         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
2286
2287         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2288         (WindowedPluginTest::testHarnessWindow):
2289         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
2290         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
2291
2292 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2293
2294         Reviewed by Kenneth Rohde Christiansen.
2295
2296         [Qt] Add new qt-4.8 platform for layout testing
2297         https://bugs.webkit.org/show_bug.cgi?id=60544
2298
2299         * Scripts/old-run-webkit-tests:
2300         * Scripts/webkitdirs.pm:
2301
2302 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2303
2304         Unreviewed, rolling out r86108.
2305         http://trac.webkit.org/changeset/86108
2306         https://bugs.webkit.org/show_bug.cgi?id=60533
2307
2308         Broke makefile based builds and Cairo (Requested by weinig on
2309         #webkit).
2310
2311         * Scripts/build-api-tests:
2312         * Scripts/run-api-tests:
2313         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2314         * TestWebKitAPI/Test.h:
2315         (TestWebKitAPI::Test::~Test):
2316         (TestWebKitAPI::Test::name):
2317         (TestWebKitAPI::Test::Register::Register):
2318         (TestWebKitAPI::Test::Register::create):
2319         (TestWebKitAPI::Test::Test):
2320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2321         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2322         (TestWebKitAPI::TEST):
2323         * TestWebKitAPI/TestsController.cpp:
2324         (TestWebKitAPI::TestsController::TestsController):
2325         (TestWebKitAPI::TestsController::dumpTestNames):
2326         (TestWebKitAPI::TestsController::runTestNamed):
2327         (TestWebKitAPI::TestsController::testFailed):
2328         (TestWebKitAPI::TestsController::registerCreateTestFunction):
2329         * TestWebKitAPI/TestsController.h:
2330         * TestWebKitAPI/mac/main.mm:
2331         (main):
2332
2333 2011-05-09  Hayato Ito  <hayato@chromium.org>
2334
2335         Reviewed by Ojan Vafai.
2336
2337         Skip reftests if pixel tests are disabled.
2338
2339         https://bugs.webkit.org/show_bug.cgi?id=59078
2340
2341         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2342         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2343         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2344         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2345
2346 2011-05-09  Chang Shu  <cshu@webkit.org>
2347
2348         Reviewed by Kenneth Rohde Christiansen.
2349
2350         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
2351         https://bugs.webkit.org/show_bug.cgi?id=60499
2352
2353         The implementation is similar to gtk.
2354
2355         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2356         (TextInputController::unmarkText):
2357         * DumpRenderTree/qt/TextInputControllerQt.h:
2358
2359 2011-05-09  James Robinson  <jamesr@chromium.org>
2360
2361         Reviewed by Eric Seidel.
2362
2363         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
2364         https://bugs.webkit.org/show_bug.cgi?id=60520
2365
2366         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2367
2368 2011-05-09  Dmitry Lomov  <dslomov@google.com>
2369
2370         Reviewed by Sam Weinig.
2371
2372         Switch TestWebKitAPI to GTest
2373         https://bugs.webkit.org/show_bug.cgi?id=59561
2374
2375         * Scripts/build-api-tests:
2376         * Scripts/run-api-tests:
2377         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2378         * TestWebKitAPI/Test.h:
2379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2380         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/TestsController.cpp:
2383         (TestWebKitAPI::TestsController::TestsController):
2384         (TestWebKitAPI::TestsController::dumpTestNames):
2385         (TestWebKitAPI::TestsController::runTestNamed):
2386         (TestWebKitAPI::TestsController::runAllTests):
2387         * TestWebKitAPI/TestsController.h:
2388         * TestWebKitAPI/mac/main.mm:
2389         (main):
2390
2391 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
2392
2393         Reviewed by Andreas Kling.
2394
2395         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
2396         https://bugs.webkit.org/show_bug.cgi?id=60487
2397
2398         When adding a new touch point, the start position of this point needs to be set.
2399
2400         * DumpRenderTree/qt/EventSenderQt.cpp:
2401         (EventSender::addTouchPoint):
2402
2403 2011-05-09  Robert Hogan  <robert@webkit.org>
2404
2405         Reviewed by Adam Roben.
2406
2407         https://bugs.webkit.org/show_bug.cgi?id=57137
2408
2409         Unskip plugins/embed-prefers-plugins-for-images.html
2410
2411         Add image/png mime-type to test netscape plugin on Unix.
2412
2413         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2414         (NP_GetMIMEDescription):
2415
2416 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
2417
2418         Reviewed by Ojan Vafai.
2419
2420         Pull jsonresults_unittest test cases out into separate test methods.
2421         https://bugs.webkit.org/show_bug.cgi?id=60418
2422
2423         * TestResultServer/model/jsonresults_unittest.py:
2424
2425 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2426
2427         Reviewed by Andreas Kling.
2428
2429         [Qt] fix fast/dom/Geolocation/window-close-crash.html
2430         https://bugs.webkit.org/show_bug.cgi?id=60458
2431
2432         Update all pages with Mock position/error/permission.
2433
2434         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2435         (LayoutTestController::setGeolocationPermission):
2436         (LayoutTestController::setMockGeolocationError):
2437         (LayoutTestController::setMockGeolocationPosition):
2438
2439 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
2440
2441         Reviewed by Tony Gentilcore.
2442
2443         Implement Page Visibility API.
2444         https://bugs.webkit.org/show_bug.cgi?id=54181
2445
2446         * DumpRenderTree/LayoutTestController.cpp:
2447         (setPageVisibilityCallback):
2448         (resetPageVisibilityCallback):
2449         (LayoutTestController::staticFunctions):
2450         * DumpRenderTree/LayoutTestController.h:
2451         (LayoutTestController::setPageVisibility):
2452         (LayoutTestController::resetPageVisibility):
2453         * DumpRenderTree/chromium/LayoutTestController.cpp:
2454         (LayoutTestController::LayoutTestController):
2455         (LayoutTestController::resetPageVisibility):
2456         (LayoutTestController::setPageVisibility):
2457         * DumpRenderTree/chromium/LayoutTestController.h:
2458
2459 2011-05-07  Adam Barth  <abarth@webkit.org>
2460
2461         Reviewed by Eric Seidel.
2462
2463         Testing EWS spins on patches with a large number of failures
2464         https://bugs.webkit.org/show_bug.cgi?id=60441
2465
2466         In cases where the tree has a small number of persistent failures but a
2467         patch has a large number of failures, we weren't believing any results.
2468         That lead to us retrying the patch forever while we waited for
2469         trustworthy results that would never come.
2470
2471         This patch loosens the semantics of unexpected_failures to return a
2472         subset (rather than the exact set) of unexpected failures.  In the case
2473         where the tree has a bounded number of failures and the patch has an
2474         unbounded number of failures, we can accurately compute such a subset
2475         and reject the patch.
2476
2477         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2478         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2479         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2480         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2481         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2482
2483 2011-05-07  Joe Mason  <jmason@rim.com>
2484
2485         Reviewed by Daniel Bates.
2486
2487         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
2488         https://bugs.webkit.org/show_bug.cgi?id=52211
2489
2490         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
2491         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
2492
2493         * DumpRenderTree/chromium/WebViewHost.cpp:
2494         (WebViewHost::willPerformClientRedirect):
2495         (WebViewHost::didStartProvisionalLoad):
2496         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2497         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2498
2499 2011-05-07  Daniel Bates  <dbates@webkit.org>
2500
2501         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
2502         <http://trac.webkit.org/changeset/86007> (bug #60438).
2503
2504         * Scripts/old-run-webkit-tests:
2505           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
2506             file local variable. 
2507
2508 2011-05-07  Pratik Solanki  <psolanki@apple.com>
2509
2510         Reviewed by Darin Adler.
2511
2512         Remove references to Tiger in scripts
2513         https://bugs.webkit.org/show_bug.cgi?id=60438
2514
2515         Remove isTiger() and all of the code that depends on it.
2516
2517         * Scripts/build-webkit:
2518         * Scripts/ensure-valid-python:
2519         * Scripts/gdb-safari:
2520         * Scripts/webkitdirs.pm:
2521
2522 2011-05-06  David Grogan  <dgrogan@chromium.org>
2523
2524         Reviewed by Eric Seidel.
2525
2526         update link to message about mac 64bit git binaries
2527         https://bugs.webkit.org/show_bug.cgi?id=60411
2528
2529         The original message implied (correctly, at-the-time) that
2530         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
2531         binaries. The new message notes that they do. This might prevent someone
2532         else from spending a few minutes confused.
2533
2534         * Scripts/webkitpy/common/checkout/scm/git.py:
2535
2536 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
2537
2538         Reviewed by Ojan Vafai.
2539
2540         new-run-webkit-tests: crashes in race with crashing DRT
2541         https://bugs.webkit.org/show_bug.cgi?id=60238
2542
2543         This fixes a race where if we wrote the URL to DRT and
2544         DRT crashed immediately, we could get a broken pipe
2545         error back during the write() and not handle it correctly,
2546         causing NRWT to also crash.
2547
2548         * Scripts/webkitpy/layout_tests/port/server_process.py:
2549         * Scripts/webkitpy/layout_tests/port/webkit.py:
2550
2551 2011-05-06  Adam Barth  <abarth@webkit.org>
2552
2553         Reviewed by Eric Seidel.
2554
2555         Add a --skip-integrationtests mode to test-webkitpy
2556         https://bugs.webkit.org/show_bug.cgi?id=60354
2557
2558         These two test suites account for 2/3 of test-webkitpy's running time
2559         because they're not actually unit tests.  They're integration tests.
2560         This patch adds the ability to skip integration tests by passing a
2561         command line argument to test-webkitpy.  The buildbots will continue to
2562         run these integration tests to make sure they don't regress.  This
2563         option is for use by developers when working on parts of the code that
2564         are well-covered by unit tests.
2565
2566         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
2567         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2568         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
2569         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
2570         * Scripts/webkitpy/test/main.py:
2571
2572 2011-05-06  Adam Barth  <abarth@webkit.org>
2573
2574         Reviewed by Eric Seidel.
2575
2576         The results.zip generated by the Chromium EWS are too big
2577         https://bugs.webkit.org/show_bug.cgi?id=60352
2578
2579         Currently results.zip created by the Chromium EWS bot contain roughly
2580         1000 tests that we expect to fail.  These test results are not helpful
2581         to contributors.
2582
2583         There are several approaches to solving this problem:
2584
2585         1) We could be more selective about which files to include in the zip.
2586         2) We could ask new-run-webkit-tests not to generate results for
2587            expected failures.
2588         3) We could ask new-run-webkit-tests not to run tests that we expect to
2589            fail.
2590
2591         This patch takes approach (3).  Currently, we're ignoring the outcome
2592         of failing tests anyway, so there's not much point in actually running
2593         them.  As a side benefit, this will speed up the test run by about 6%.
2594         In the future, we might revisit this decision and choose another
2595         approach.
2596
2597         * Scripts/webkitpy/common/config/ports.py:
2598         * Scripts/webkitpy/common/config/ports_unittest.py:
2599
2600 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
2601
2602         Reviewed by Csaba Osztrogonác.
2603
2604         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
2605
2606         * Scripts/old-run-webkit-tests:
2607
2608 2011-05-06  Adam Barth  <abarth@webkit.org>
2609
2610         Reviewed by Ojan Vafai.
2611
2612         Add an option to NRWT to skip failing tests
2613         https://bugs.webkit.org/show_bug.cgi?id=60295
2614
2615         This option is similar to the way old-run-webkit-tests works.  We're
2616         planning to use this option on the testing EWS bots because they don't
2617         use information from failing tests yet.
2618
2619         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2620         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2621         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2622
2623 2011-05-04  Philippe Normand  <pnormand@igalia.com>
2624
2625         Reviewed by Dimitri Glazkov.
2626
2627         Implement LayoutTestController::pseudoShadowId()
2628         https://bugs.webkit.org/show_bug.cgi?id=60034
2629
2630         shadowPseudoId support in the various LayoutTestController
2631         implementations.
2632
2633         * DumpRenderTree/LayoutTestController.cpp:
2634         (shadowPseudoIdCallback):
2635         (LayoutTestController::staticFunctions):
2636         * DumpRenderTree/LayoutTestController.h:
2637         * DumpRenderTree/chromium/LayoutTestController.cpp:
2638         (LayoutTestController::LayoutTestController):
2639         (LayoutTestController::shadowPseudoId):
2640         * DumpRenderTree/chromium/LayoutTestController.h:
2641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2642         (LayoutTestController::shadowPseudoId):
2643         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2644         (LayoutTestController::shadowPseudoId):
2645         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2646         (LayoutTestController::shadowPseudoId):
2647         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2648         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2649         (LayoutTestController::shadowPseudoId):
2650         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2651         (LayoutTestController::shadowPseudoId):
2652         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2653         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2654         (WTR::LayoutTestController::shadowPseudoId):
2655         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2656
2657 2011-05-06  Adam Barth  <abarth@webkit.org>
2658
2659         EWS can't reject patches
2660         https://bugs.webkit.org/show_bug.cgi?id=60345
2661
2662         We're supposed to use patch.id() for the attachment ID, silly.
2663
2664         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2665         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2666
2667 2011-05-05  Steve Lacey  <sjl@chromium.org>
2668
2669         Reviewed by Ojan Vafai.
2670
2671         Fix generation of results html file by passing relative path to scm
2672         methods.
2673         Generate diff images for results html file.
2674
2675         https://bugs.webkit.org/show_bug.cgi?id=60086
2676
2677         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2678         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2679
2680 2011-05-05  Andy Estes  <aestes@apple.com>
2681
2682         Reviewed by Daniel Bates.
2683
2684         update-webkit should handle Internal using a different VCS than OpenSource.
2685         https://bugs.webkit.org/show_bug.cgi?id=60310
2686
2687         isGit() and isSVN() cache their results, so Internal will always be
2688         updated using the VCS commands used for OpenSource. If Internal uses a
2689         different VCS, this will fail. Fix this by calling isGitDirectory() and
2690         isSVNDirectory() instead, which do not cache their results.
2691
2692         * Scripts/update-webkit:
2693
2694 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2695
2696         Reviewed by Ojan Vafai.
2697
2698         nrwt: revamp integration tests incl. tests for servers
2699         https://bugs.webkit.org/show_bug.cgi?id=59985
2700
2701         This change adds the ability to run "integration tests" that
2702         depend on (and affect) the local environment on your machine.
2703         These tests can be run manually by invoking python on the
2704         test file in question and passing the '-i' flag, but are
2705         not run automatically as part of test-webkitpy.
2706
2707         Integration tests are identified by being methods named as
2708         "integration_test_*" instead of "test_*", and we use a
2709         custom TestLoader instead of the default one provided by
2710         unittest.
2711
2712         This change also adds a protected "_default_to_apache" method
2713         to the port object so we can do the right thing when starting
2714         and stopping web servers with less mechanism.
2715
2716         * Scripts/webkitpy/layout_tests/port/base.py:
2717         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2718         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2719         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2720         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2721         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2722
2723 2011-05-05  Adam Roben  <aroben@apple.com>
2724
2725         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
2726
2727         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
2728         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
2729         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
2730         safeguard against this, we fill the alpha channel with constant full opacity after the
2731         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
2732         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
2733         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
2734         results need an alpha channel, too.)
2735
2736         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
2737         generated due to alpha channel weirdness
2738
2739         Reviewed by Sam Weinig.
2740
2741         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2742         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
2743         constant full opacity.
2744         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
2745         in a CGContext or cairo_surface.
2746
2747 2011-05-05  Adam Roben  <aroben@apple.com>
2748
2749         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
2750
2751         Passing true tells the test harness to dump pixels even though we're not dumping a render
2752         tree.
2753
2754         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
2755         WebKitTestRunner doesn't result in pixel results being generated
2756
2757         Reviewed by Sam Weinig.
2758
2759         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
2760         argument to dumpAsText.
2761
2762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2763         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
2764
2765         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2766         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
2767
2768         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
2769
2770         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
2771         developers.
2772
2773 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2774
2775         Reviewed by Ojan Vafai.
2776
2777         new-run-webkit-tests: merge os, version fields in test config
2778         https://bugs.webkit.org/show_bug.cgi?id=60004
2779
2780         This change removes the 'o/s' field from the TestConfiguration
2781         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
2782         the expectations file to macros that expand to the version names
2783         for each platform.
2784
2785         This means that you can once again put any subset of the
2786         operating system versions on a single line, e.g.:
2787           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
2788
2789         This change will break any existing test_expectations.txt
2790         file that uses the "OS-VERSION" macros, which are no longer
2791         needed. It turns out they were never needed, as just VERSION
2792         by itself was sufficient. The test_expectations.txt file should
2793         be updated accordingly prior to landing this change.
2794
2795         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2796         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2797         * Scripts/webkitpy/layout_tests/port/base.py:
2798
2799 2011-05-05  Tony Chang  <tony@chromium.org>
2800
2801         Reviewed by Adam Barth.
2802
2803         [chromium] switch from Lucida to free fonts for Hindi and Thai
2804         https://bugs.webkit.org/show_bug.cgi?id=60287
2805
2806         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
2807         packages on Lucid. There are actually multiple Thai fonts in the
2808         package, so I just picked one.
2809
2810         * DumpRenderTree/chromium/TestShellGtk.cpp:
2811         (setupFontconfig):
2812
2813 2011-05-05  Tony Chang  <tony@chromium.org>
2814
2815         Reviewed by Ojan Vafai.
2816
2817         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
2818         https://bugs.webkit.org/show_bug.cgi?id=60290
2819
2820         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
2821         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
2822         lucid64.  Because of that, google-chrome-64 used to skip the
2823         chromium-linux-x86_64 results since they were more incorrect.
2824
2825         Now that we're switching to lucid for google-chrome, we want
2826         google-chrome-64 to fall back to chromium-linux-x86_64.
2827
2828         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2829
2830 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2831
2832         Reviewed by Ojan Vafai.
2833
2834         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
2835         https://bugs.webkit.org/show_bug.cgi?id=60002
2836
2837         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2838         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2839         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2840         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2841         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2842         * Scripts/webkitpy/style/checkers/test_expectations.py:
2843
2844 2011-05-05  Eric Seidel  <eric@webkit.org>
2845
2846         Reviewed by Adam Barth.
2847
2848         commit-queue should reject patches which fail ewses
2849         https://bugs.webkit.org/show_bug.cgi?id=47534
2850
2851         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2852         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2853         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2854
2855 2011-05-05  Chang Shu  <cshu@webkit.org>
2856
2857         Reviewed by Andreas Kling.
2858
2859         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
2860         https://bugs.webkit.org/show_bug.cgi?id=59638
2861
2862         1. Call QGraphicsWKView constructor with pageGroupRef.
2863         2. Disable setFontFamily calls as it breaks Qt test fonts.
2864
2865         * WebKitTestRunner/TestController.cpp:
2866         (WTR::TestController::resetStateToConsistentValues):
2867         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2868         (WTR::WebView::WebView):
2869         (WTR::PlatformWebView::PlatformWebView):
2870
2871 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
2872
2873         Reviewed by David Kilzer.
2874
2875         Add --only-webkit option to build-webkit
2876         https://bugs.webkit.org/show_bug.cgi?id=60245
2877
2878         * Scripts/build-webkit: If --only-webkit was specified
2879         just build the WebKit project, and not its dependencies.
2880
2881 2011-05-05  Jeff Miller  <jeffm@apple.com>
2882
2883         Reviewed by Darin Adler.
2884
2885         Add didNotHandleWheelEvent callback to WKPageUIClient
2886         https://bugs.webkit.org/show_bug.cgi?id=60203
2887
2888         * MiniBrowser/gtk/BrowserWindow.c:
2889         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
2890         * MiniBrowser/mac/BrowserWindowController.m:
2891         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
2892         * MiniBrowser/win/BrowserView.cpp:
2893         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
2894         * WebKitTestRunner/TestController.cpp:
2895         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
2896         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2897
2898 2011-05-04  Eric Seidel  <eric@webkit.org>
2899
2900         Reviewed by Adam Barth.
2901
2902         Add more missing imports from scm refactor
2903         https://bugs.webkit.org/show_bug.cgi?id=60239
2904
2905         * Scripts/webkitpy/common/checkout/scm/git.py:
2906         * Scripts/webkitpy/common/checkout/scm/svn.py:
2907
2908 2011-05-04  Eric Seidel  <eric@webkit.org>
2909
2910         Reviewed by Adam Barth.
2911
2912         sheriff-bot is having more exception trouble
2913         https://bugs.webkit.org/show_bug.cgi?id=60233
2914
2915         A webpage-forced build was causing SB to throw an exception.
2916         We've long had this bug, but we just didn't notice it until now.
2917
2918         In debugging this I found we fetch an absurd amount of data now
2919         that we use buildbot's json (instead of xmlrpc), so I added
2920         the filter=1 parameter to reduce it a little.  That required
2921         me to handle the case where filter=1 would strip
2922         result=0 in some cases (it's unclear why it does that).
2923
2924         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2925         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2926
2927 2011-05-04  Cris Neckar  <cdn@chromium.org>
2928
2929         Unreviewed, Adding Cris Neckar as a committer
2930
2931         * Scripts/webkitpy/common/config/committers.py:
2932
2933 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2934
2935         Reviewed by Laszlo Gombos.
2936
2937         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
2938         https://bugs.webkit.org/show_bug.cgi?id=59462
2939
2940         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
2941
2942 2011-05-04  Eric Seidel  <eric@webkit.org>
2943
2944         Reviewed by Adam Barth.
2945
2946         The testing EWS bots should upload layout-test-results.zip to bugs after failures
2947         https://bugs.webkit.org/show_bug.cgi?id=60223
2948
2949         This required sharing a bit of code between the commit-queue
2950         (which already knew how to do this) and the new EWS testing bots.
2951
2952         In the process I also cleaned up EWS testing a little and
2953         removed some dead code from the commit-queue.
2954
2955         * Scripts/webkitpy/common/config/committervalidator.py:
2956         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2957         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2958         * Scripts/webkitpy/tool/commands/queues.py:
2959         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2960
2961 2011-05-04  James Kozianski  <koz@chromium.org>
2962
2963         Reviewed by Eric Seidel.
2964
2965         Add method to make a Port able to retrieve TestOutputSets from its builders.
2966         https://bugs.webkit.org/show_bug.cgi?id=58211
2967
2968         This will be used in the new rebaseline script - TestOutputs are
2969         potential new baselines.
2970
2971         * Scripts/webkitpy/common/config/urls.py:
2972         * Scripts/webkitpy/layout_tests/port/base.py:
2973         * Scripts/webkitpy/layout_tests/port/chromium.py:
2974         * Scripts/webkitpy/layout_tests/port/factory.py:
2975         * Scripts/webkitpy/layout_tests/port/webkit.py:
2976
2977 2011-05-04  Eric Seidel  <eric@webkit.org>
2978
2979         Reviewed by Ojan Vafai.
2980
2981         sheriff-bot can't parse results.html
2982         https://bugs.webkit.org/show_bug.cgi?id=60196
2983
2984         The problem was that the NRWT bots are currently core
2985         and so sheriff-bot was trying to diagnose failures on
2986         them.  It was trying to parse their results.html file
2987         and BeautifulSoup was throwing an exception.
2988
2989         It seems our version of BeautifulSoup was quite old
2990         and unable to handle <script> tags correctly.
2991         This moves us to 3.2 which doesn't seem to have this bug.
2992
2993         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
2994
2995 2011-05-04  Adam Barth  <abarth@webkit.org>
2996
2997         Reviewed by Eric Seidel.
2998
2999         Make the EWS test logging less verbose
3000         https://bugs.webkit.org/show_bug.cgi?id=60201
3001
3002         This should help us generate less than a hundred MB of logs per hour.
3003
3004         * Scripts/webkitpy/common/config/ports.py:
3005         * Scripts/webkitpy/common/config/ports_unittest.py:
3006
3007 2011-05-04  Tao Bai  <michaelbai@chromium.org>
3008
3009         Reviewed by David Kilzer.
3010
3011         Populate touch-icon url to FrameLoaderClient
3012         https://bugs.webkit.org/show_bug.cgi?id=59143
3013
3014         Disable touch icon by default. 
3015
3016         * Scripts/build-webkit:
3017
3018 2011-05-04  Justin Novosad  <junov@chromium.org>
3019
3020         Reviewed by Kenneth Russell.
3021
3022         [Chromium] Add gpu acceleration flags to DumpRenderTree
3023         https://bugs.webkit.org/show_bug.cgi?id=60168
3024         Adding support for command line flags 
3025         enable-accelerated-2d-canvas an
3026         enable-accelerated-drawing in DumpRenderTree.
3027
3028         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3029         (main):
3030         * DumpRenderTree/chromium/TestShell.cpp:
3031         (TestShell::TestShell):
3032         (TestShell::resetWebSettings):
3033         * DumpRenderTree/chromium/TestShell.h:
3034         (TestShell::setLegacyAccelerated2dCanvasEnabled):
3035         (TestShell::setAcceleratedDrawingEnabled):
3036         * DumpRenderTree/chromium/WebPreferences.cpp:
3037         (WebPreferences::reset):
3038         (WebPreferences::applyTo):
3039         * DumpRenderTree/chromium/WebPreferences.h:
3040
3041 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3042
3043         Reviewed by Csaba Osztrogonác.
3044
3045         [Qt] run-qtwebkit-tests misses exec bit
3046         https://bugs.webkit.org/show_bug.cgi?id=60188
3047
3048         Also removing an unecessary import (mostly to let this bugfix goes
3049         through the system, as this is just a chmod).
3050
3051         * Scripts/run-qtwebkit-tests:
3052
3053 2011-05-04  Adam Barth  <abarth@webkit.org>
3054
3055         Fix import of ircproxy module to actually import the module.  I don't
3056         really understand how this code could have worked before.
3057
3058         * Scripts/webkitpy/common/host.py:
3059
3060 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3061
3062         Reviewed by Andreas Kling.
3063
3064         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3065         https://bugs.webkit.org/show_bug.cgi?id=60172
3066
3067         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3068         (BrowserWindow::BrowserWindow):
3069
3070 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3071
3072         Reviewed by Ojan Vafai.
3073
3074         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3075         https://bugs.webkit.org/show_bug.cgi?id=60088
3076         
3077         Makes --new-baseline put new baselines into the first entry in the
3078         baseline search path, including any additional directories passed in via
3079         --additional-platform-directory.
3080         
3081         Simplifies baseline_path() by making it return the first entry in the
3082         baseline search path instead of requiring each port to have an
3083         implementation (should not result in any behavior change).
3084
3085         * Scripts/webkitpy/layout_tests/port/base.py:
3086         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3087         * Scripts/webkitpy/layout_tests/port/chromium.py:
3088         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3089         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3090         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3091         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3092         * Scripts/webkitpy/layout_tests/port/mac.py:
3093         * Scripts/webkitpy/layout_tests/port/test.py:
3094         * Scripts/webkitpy/layout_tests/port/webkit.py:
3095
3096 2011-05-04  Adam Barth  <abarth@webkit.org>
3097
3098         Reviewed by Eric Seidel.
3099
3100         Fix circular dependency in webkitpy
3101         https://bugs.webkit.org/show_bug.cgi?id=60075
3102
3103         These functions don't belong in bugzilla.py.  They only exist there
3104         because they are old.  Really, these functions shouldn't be free
3105         functions at all, but that's a patch for another day.
3106
3107         * Scripts/webkitpy/common/checkout/changelog.py:
3108         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3109         * Scripts/webkitpy/common/checkout/checkout.py:
3110         * Scripts/webkitpy/common/config/urls.py:
3111         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3112         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3113         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3114         * Scripts/webkitpy/style/checkers/changelog.py:
3115         * Scripts/webkitpy/tool/bot/irc_command.py:
3116         * Scripts/webkitpy/tool/bot/sheriff.py:
3117         * Scripts/webkitpy/tool/commands/upload.py:
3118
3119 2011-05-03  Pratik Solanki  <psolanki@apple.com>
3120
3121         Reviewed by Dan Bernstein.
3122
3123         https://bugs.webkit.org/show_bug.cgi?id=60141
3124         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
3125
3126         * Scripts/build-webkit:
3127
3128 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
3129
3130         Reviewed by Ojan Vafai.
3131
3132         Update rebaseline queue server to handle hierarchical test results
3133         https://bugs.webkit.org/show_bug.cgi?id=60063
3134         
3135         Update test result parsing done by the rebaseline queue server to handle
3136         the hierarchical test result output that is generated as of r85254.
3137
3138         * RebaselineQueueServer/templates/builder-queue-edit.html:
3139
3140 2011-05-03  Eric Seidel  <eric@webkit.org>
3141
3142         Reviewed by Adam Roben.
3143
3144         webkit-patch post-commits HEAD^.. throws an exception
3145         https://bugs.webkit.org/show_bug.cgi?id=60027
3146
3147         * Scripts/webkitpy/common/checkout/scm/git.py:
3148
3149 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
3150
3151         Reviewed by Kenneth Rohde Christiansen.
3152
3153         [Qt] Layout tests may timeout if loadFinished receives false
3154         https://bugs.webkit.org/show_bug.cgi?id=60064
3155
3156         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
3157         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
3158         a response is ignored, like it should be for 204 responses. It is a problem for creating
3159         tests for 204 responses for example.
3160
3161         This change has been tested and it causes no regressions in layout tests.
3162
3163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3164         (LayoutTestController::maybeDump):
3165
3166 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3167
3168         Unreviewed, rolling out r85659.
3169         http://trac.webkit.org/changeset/85659
3170         https://bugs.webkit.org/show_bug.cgi?id=59977
3171
3172         restarting isn't working correctly
3173
3174         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3175         * Scripts/webkitpy/layout_tests/port/http_server.py:
3176         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3177         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3178
3179 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3180
3181         Reviewed by Ojan Vafai.
3182
3183         new-run-webkit-tests: fix http server startup/shutdown
3184
3185         Previous versions of the code had three problems that made startup
3186         and shutdown flaky. The first is that it would throw exceptions
3187         if it couldn't delete stale log files, which was overly
3188         paranoid. The second is that some of the exceptions weren't
3189         defined properly. The third, and most important, is that it was
3190         using urllib to check if ports were available, which was leaving
3191         sockets in a half-closed state, and keeping ports from being
3192         reused. By switching to raw sockets, we are able to now reliably
3193         restart.
3194
3195         This change also switches the code to using Executives to stop
3196         processes, which will let us delete a bunch of code in the
3197         port/* implementations and fix a weird layering problem in a
3198         subsequent patch.
3199
3200         https://bugs.webkit.org/show_bug.cgi?id=59977
3201
3202         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3203         * Scripts/webkitpy/layout_tests/port/http_server.py:
3204         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3205         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3206
3207 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3208
3209         Reviewed by Adam Barth.
3210
3211         fix failing printing_unittest on win32
3212         https://bugs.webkit.org/show_bug.cgi?id=59963
3213
3214         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3215
3216 2011-05-03  Adam Roben  <aroben@apple.com>
3217
3218         Fix most strict PassOwnPtr violations on Windows
3219
3220         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3221         enabled
3222
3223         Reviewed by Anders Carlsson.
3224
3225         * WebKitAPITest/Test.h: Use adoptPtr.
3226
3227 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3228
3229         Reviewed by Andreas Kling.
3230
3231         Add myself to the committers list.
3232
3233         * Scripts/webkitpy/common/config/committers.py:
3234
3235 2011-05-03  James Robinson  <jamesr@chromium.org>
3236
3237         Reviewed by Kenneth Russell.
3238
3239         [chromium] Layout test animations/3d/replace-filling-transform.html failing
3240         https://bugs.webkit.org/show_bug.cgi?id=59839
3241
3242         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
3243
3244         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3245
3246 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3247
3248         Unreviewed, rolling out r85471.
3249         http://trac.webkit.org/changeset/85471
3250         https://bugs.webkit.org/show_bug.cgi?id=59922
3251
3252         The rule of thumb in EFL is that you init in all the places
3253         you use it. So, if in your application you call ecore_evas_*
3254         functions, you have to call ecore_evas_init() first.
3255
3256         * EWebLauncher/main.c: always call *_init() functions when you use
3257         that namespace.
3258         (quit):
3259         (main):
3260
3261 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3262
3263         Reviewed by Tony Chang.
3264
3265         remove no longer used method
3266         https://bugs.webkit.org/show_bug.cgi?id=59981
3267
3268         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3269         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3270
3271 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3272
3273         Reviewed by Tony Chang.
3274
3275         add image toggling behavior from old-run-webkit-tests
3276         https://bugs.webkit.org/show_bug.cgi?id=59978
3277
3278         Output -diffs.html files. This matches old-run-webkit-tests.
3279         In theory, we could use data urls in the results.html file, but
3280         data urls don't currently have access to local files.
3281
3282         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3283
3284 2011-05-02  Tony Chang  <tony@chromium.org>
3285
3286         Reviewed by Ojan Vafai.
3287
3288         [nrwt] remove some obsolete references to .checksum files
3289         https://bugs.webkit.org/show_bug.cgi?id=59971
3290
3291         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3292         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3293         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3294         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3295         * Scripts/webkitpy/layout_tests/port/test.py:
3296         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3297
3298 2011-05-02  Adam Roben  <aroben@apple.com>
3299
3300         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
3301
3302         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3303         doesn't work, but should
3304
3305         Reviewed by Adam Barth.
3306
3307         * DumpRenderTree/chromium/CppBoundClass.h:
3308         * DumpRenderTree/chromium/WebViewHost.cpp:
3309
3310 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3311
3312         Reviewed by Xan Lopez.
3313
3314         [GTK] Compiler warning in Tools/MiniBrowser/main.c
3315         https://bugs.webkit.org/show_bug.cgi?id=59986
3316
3317         Remove a compiler warning.
3318
3319         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
3320         from complaining.
3321
3322 2011-05-02  Adam Barth  <abarth@webkit.org>
3323
3324         Reviewed by Eric Seidel.
3325
3326         Add runtests_unittest.py
3327         https://bugs.webkit.org/show_bug.cgi?id=59955
3328
3329         I forgot to add this file in a previous patch.
3330
3331         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
3332
3333 2011-05-02  Adam Barth  <abarth@webkit.org>
3334
3335         Change the testing EWS to log failures explicitly to avoid an infinite loop.
3336
3337         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3338
3339 2011-05-02  Adrienne Walker  <enne@google.com>
3340
3341         Unreviewed, fix misspelled contributor name.
3342
3343         * Scripts/webkitpy/common/config/committers.py:
3344
3345 2011-05-02  Adam Barth  <abarth@webkit.org>
3346
3347         Reviewed by Eric Seidel.
3348
3349         cr-linux-ews should run tests
3350         https://bugs.webkit.org/show_bug.cgi?id=59272
3351
3352         This patch turns on testing for the cr-linux-ews.  Yay!
3353
3354         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3355         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3356         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3357         * Scripts/webkitpy/tool/steps/runtests.py:
3358         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3359
3360 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3361
3362         Incorporate a review comment that I mistakenly omitted from my last commit.
3363
3364         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
3365
3366 2011-05-02  Adam Barth  <abarth@webkit.org>
3367
3368         Reviewed by Eric Seidel.
3369
3370         EWS should report the list of unexpected failures
3371         https://bugs.webkit.org/show_bug.cgi?id=59923
3372
3373         We cache the results of the first layout test results run on the task
3374         so the EWS can grab them later.  Another option is to include them in
3375         the exception that's thrown, but this approach seemed slightly more
3376         aesthetic.
3377
3378         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3379         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3380
3381 2011-05-02  Adam Barth  <abarth@webkit.org>
3382
3383         Reviewed by Eric Seidel.
3384
3385         Add base case for a test-running EWS
3386         https://bugs.webkit.org/show_bug.cgi?id=59920
3387
3388         Later I will subclass this to run the Chromium Linux EWS.
3389
3390         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3391         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3392         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3393
3394 2011-05-02  Anders Carlsson  <andersca@apple.com>
3395
3396         Build fix.
3397
3398         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3399         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3400
3401 2011-05-02  Nico Weber  <thakis@chromium.org>
3402
3403         Reviewed by Mihai Parparita.
3404
3405         Add --no-webkit2 to the output of "build-webkit -h"
3406         https://bugs.webkit.org/show_bug.cgi?id=59942
3407
3408         * Scripts/build-webkit:
3409
3410 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3411
3412         Reviewed by Xan Lopez.
3413
3414         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
3415         https://bugs.webkit.org/show_bug.cgi?id=59943
3416
3417         Disable the Ubuntu overlay scrollbar while testing, by injecting the
3418         LIBOVERLAY_SCROLLBAR=0 environment variable.
3419
3420         * Scripts/old-run-webkit-tests:
3421
3422 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3423
3424         Reviewed by Eric Seidel.
3425
3426         [GTK] editing/selection/select-out-of-editable.html failing after r83967
3427         https://bugs.webkit.org/show_bug.cgi?id=58667
3428
3429         Do not trigger mouse down events when the EventSender knows that a mouse button is
3430         already down. These type of situations can confuse Xvfb and cause dragging failures.
3431
3432         * DumpRenderTree/gtk/EventSender.cpp:
3433         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
3434         is already down. This can interfere with drags in Xvfb.
3435
3436 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3437
3438         Reviewed by Csaba Osztrogonác.
3439
3440         DRT sideeffect revealed by r71268.
3441         https://bugs.webkit.org/show_bug.cgi?id=48958
3442
3443         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
3444
3445         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
3446         PageZoomFactor too. It should be done before resetsettings() 
3447         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
3448
3449         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3450         (WebCore::WebPage::resetSettings):
3451         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3452
3453 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3454
3455         Unreviewed, rolling out r85469.
3456         http://trac.webkit.org/changeset/85469
3457         https://bugs.webkit.org/show_bug.cgi?id=59928
3458
3459         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
3460         bbandix on #webkit).
3461
3462         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
3463         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3464         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3465
3466 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
3467
3468         Reviewed by Kenneth Rohde Christiansen.
3469
3470         Cleanup EFL initialization/shutdown in the EWebLauncher
3471         https://bugs.webkit.org/show_bug.cgi?id=59922
3472
3473         Removed ecore_evas_init and edje_init form main function due to they
3474         are also called in the ewk_init. Moved ewk_shutdown to quit function.
3475
3476         * EWebLauncher/main.c:
3477         (quit):
3478         (main):
3479
3480 2011-05-02  Adam Barth  <abarth@webkit.org>
3481
3482         Reviewed by Eric Seidel.
3483
3484         Add base case for a test-running EWS
3485         https://bugs.webkit.org/show_bug.cgi?id=59920
3486
3487         Later I will subclass this to run the Chromium Linux EWS.
3488
3489         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3490         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3491         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3492
3493 2011-05-02  Adam Barth  <abarth@webkit.org>
3494
3495         Reviewed by Eric Seidel.
3496
3497         Add the ability to skip python and perl unit tests on EC2
3498         https://bugs.webkit.org/show_bug.cgi?id=59918
3499
3500         * Scripts/webkitpy/common/config/ports.py:
3501             - This is slightly ugly, but it's useful...
3502         * Scripts/webkitpy/common/config/ports_unittest.py:
3503         * Scripts/webkitpy/tool/mocktool.py:
3504         * Scripts/webkitpy/tool/steps/runtests.py:
3505
3506 2011-05-02  Adam Barth  <abarth@webkit.org>
3507
3508         Reviewed by Eric Seidel.
3509
3510         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
3511         https://bugs.webkit.org/show_bug.cgi?id=59919
3512
3513         new-run-webkit-tests doesn't support --wait-for-httpd (because it
3514         always waits for HTTPD, as I understand things).  It turns out we're
3515         not really using this flag for anything, so we should just remove it.
3516
3517         * Scripts/webkitpy/tool/steps/runtests.py:
3518         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3519
3520 2011-05-01  Eric Seidel  <eric@webkit.org>
3521
3522         Reviewed by Adam Barth.
3523
3524         The bots should learn from expected failures without having to retry
3525         https://bugs.webkit.org/show_bug.cgi?id=59279
3526
3527         Rather than re-trying the whole patch, we can just check whether we now
3528         expect the failures we see with the patch applied, saving a lot of time.
3529
3530         This patch also teaches the CommitQueue how to reject patches even
3531         when the tree is red using the new unexpected_failures() method on
3532         ExpectedFailures.
3533
3534         Finally in testing we found a bug in ExpectedFailures where it would
3535         "trust" results which had many many failures, due to using an
3536         equal sign instead of a less-than sign.
3537
3538         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
3539         * Scripts/webkitpy/tool/bot/expectedfailures.py
3540         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
3541         * Scripts/webkitpy/tool/bot/patchanalysistask.py
3542
3543
3544 2011-05-02  Adam Barth  <abarth@webkit.org>
3545
3546         Reviewed by Eric Seidel.
3547
3548         workspace.py fails to import ScriptError
3549         https://bugs.webkit.org/show_bug.cgi?id=59915
3550
3551         If the workspace fails to create a zip, webkitpy crashes instead of
3552         handling the error as expected.
3553
3554         * Scripts/webkitpy/common/system/workspace.py:
3555         * Scripts/webkitpy/common/system/workspace_unittest.py:
3556         * Scripts/webkitpy/tool/mocktool.py:
3557
3558 2011-05-01  Adam Barth  <abarth@webkit.org>
3559
3560         Remove unadvertantly added file.
3561
3562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3563
3564 2011-05-01  Adam Barth  <abarth@webkit.org>
3565
3566         Reviewed by Eric Seidel.
3567
3568         expectedfailures.py should report the unexpected failures when asked
3569         https://bugs.webkit.org/show_bug.cgi?id=59916
3570
3571         This information is useful when the EWS runs tests.
3572
3573         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3574         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3575
3576 2011-05-01  Adam Barth  <abarth@webkit.org>
3577
3578         Reviewed by Eric Seidel.
3579
3580         JSONTestResult needs to handle multiple results
3581         https://bugs.webkit.org/show_bug.cgi?id=59269
3582
3583         This case occurs when a test is flaky because NRWT will run the test
3584         twice and report both results as "actual."
3585
3586         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3587         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3588
3589 2011-05-01  Adam Barth  <abarth@webkit.org>
3590
3591         Reviewed by Eric Seidel.
3592
3593         Move checkout/api.py to checkout/checkout.py
3594         https://bugs.webkit.org/show_bug.cgi?id=59906
3595
3596         This is more consistent with Python style.
3597
3598         * Scripts/webkitpy/common/checkout/__init__.py:
3599         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3600         * Scripts/webkitpy/common/host.py:
3601         * Scripts/webkitpy/tool/main.py:
3602
3603 2011-05-01  Eric Seidel  <eric@webkit.org>
3604
3605         Reviewed by Adam Barth.
3606
3607         scm.py should be split into many pieces
3608         https://bugs.webkit.org/show_bug.cgi?id=59908
3609
3610         Forgot an AuthenticationError import.
3611
3612         * Scripts/webkitpy/common/checkout/scm/git.py:
3613         * Scripts/webkitpy/common/checkout/scm/svn.py:
3614
3615 2011-05-01  Arno Renevier  <arno@renevier.net>
3616
3617         Reviewed by Eric Seidel.
3618
3619         wrong exception raised in Lighttpd start method
3620         https://bugs.webkit.org/show_bug.cgi?id=59283
3621
3622         raise standard Exception instead of non existent
3623         google.httpd_utils.HttpdNotStarted
3624
3625         * Scripts/webkitpy/layout_tests/port/http_server.py:
3626
3627 2011-05-01  Eric Seidel  <eric@webkit.org>
3628
3629         Reviewed by Adam Barth.
3630
3631         scm.py should be split into many pieces
3632         https://bugs.webkit.org/show_bug.cgi?id=59908
3633
3634         * Scripts/webkitpy/common/checkout/scm/__init__.py:
3635         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
3636         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
3637         * Scripts/webkitpy/common/checkout/scm/scm.py:
3638         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3639         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
3640
3641 2011-05-01  Eric Seidel  <eric@webkit.org>
3642
3643         Reviewed by Adam Barth.
3644
3645         Make most scm.py tests pass in preparation for splitting them up
3646         https://bugs.webkit.org/show_bug.cgi?id=59904
3647
3648         There is one remaining failure:
3649         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
3650         which identifies a difference between the SVN and Git versions of the
3651         SCM api.  I'm not going to bother fixing that until we split out all
3652         the tests.
3653
3654         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3655
3656 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3657
3658         [WIN] Unreviewed buildfix after r85440.
3659
3660         * DumpRenderTree/win/UIDelegate.cpp:
3661         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
3662
3663 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3664
3665         [WIN] Unreviewed buildfix after r85434.
3666
3667         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
3668         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
3669
3670 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3671
3672         [WIN] Unreviewed buildfix after r85434.
3673
3674         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3675         (FrameLoadDelegate::FrameLoadDelegate):
3676         * DumpRenderTree/win/UIDelegate.cpp:
3677         (DRTUndoManager::DRTUndoManager):
3678         (UIDelegate::UIDelegate):
3679         (UIDelegate::resetUndoManager):
3680
3681 2011-05-01  Eric Seidel  <eric@webkit.org>
3682
3683         Reviewed by Adam Barth.
3684
3685         Move scm.py into its own module in preparation for splitting it up
3686         https://bugs.webkit.org/show_bug.cgi?id=59884
3687
3688         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
3689         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
3690         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
3691         * Scripts/webkitpy/test/main.py:
3692
3693 2011-05-01  Adam Barth  <abarth@webkit.org>
3694
3695         Reviewed by Eric Seidel.
3696
3697         webkit-patch fails when not run from root
3698         https://bugs.webkit.org/show_bug.cgi?id=59882
3699
3700         We need to set the CWD when running svn so that svn interprets file
3701         paths relative to the root of the working copy.
3702
3703         * Scripts/webkitpy/common/checkout/scm.py:
3704
3705 2011-04-29  Eric Seidel  <eric@webkit.org>
3706
3707         Reviewed by Adam Barth.
3708
3709         land-safely patches should show show their place in the commit-queue
3710         https://bugs.webkit.org/show_bug.cgi?id=59853
3711
3712         This complicated the "should we show the bubbles or the submit-to-ews button"
3713         logic substantially. :(  But now we'll show both the commit-queue position
3714         as well as the submit-to-ews button for land-safely (cq+ only) patches.
3715         Previously we would only show the submit-to-ews button.
3716
3717         * QueueStatusServer/handlers/statusbubble.py:
3718         * QueueStatusServer/templates/statusbubble.html:
3719
3720 2011-04-29  Naoki Takano  <takano.naoki@gmail.com>
3721
3722         Reviewed by Adam Barth.
3723
3724         Add my name to contributers.
3725         https://bugs.webkit.org/show_bug.cgi?id=59854
3726
3727         * Scripts/webkitpy/common/config/committers.py:
3728
3729 2011-04-29  Keith Kyzivat  <keith.kyzivat@nokia.com>
3730
3731         Reviewed by Csaba Osztrogonác.
3732
3733         [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
3734         https://bugs.webkit.org/show_bug.cgi?id=59772
3735
3736         * Tools.pro:
3737
3738 2011-04-29  Stephanie Lewis  <slewis@apple.com>
3739
3740         Rubber-stamped by Adam Roben.   
3741
3742         Remove the production configuration guard since installs only happen in production anyway.  
3743         Works around a bug in Xcode
3744
3745         * DumpRenderTree/mac/PerlSupport/Makefile:
3746
3747 2011-04-29  Adam Roben  <aroben@apple.com>
3748
3749         Remove a PHP setting that is now provided by httpd.conf
3750
3751         r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
3752         isn't dependent on paths that could be different on each user's machine).
3753
3754         Reviewed by Sam Weinig.
3755
3756         * Scripts/webkitperl/httpd.pm:
3757         (getDefaultConfigForTestDirectory): Removed log_errors setting.
3758
3759 2011-04-29  Jon Lee  <jonlee@apple.com>
3760
3761         Unreviewed, Adding Jon Lee as a committer
3762
3763         * Scripts/webkitpy/common/config/committers.py:
3764
3765 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3766
3767         Reviewed by Tony Chang.
3768
3769         fix pretty_patch_available and wdiff_available
3770         https://bugs.webkit.org/show_bug.cgi?id=59761
3771
3772         These methods rely on the check_* method being called first.
3773         This would only happen when we actually tried to compute a diff,
3774         but computing the diff happens on a different process.
3775         
3776         Also fix setting _wdiff_avialable to True by default.
3777
3778         * Scripts/webkitpy/layout_tests/port/base.py:
3779         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3780         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3781
3782 2011-04-29  Ojan Vafai  <ojan@chromium.org>
3783
3784         Reviewed by Eric Seidel.
3785
3786         exclude skipped tests from the summarized results
3787         https://bugs.webkit.org/show_bug.cgi?id=59813
3788
3789         If we find a need fo skipped tests later, we should either create
3790         a skipped.json file or expose this some other way. As it is, the data
3791         is unused and is hugely bloating the size of full_results.json.
3792
3793         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3794
3795 2011-04-29  Adam Roben  <aroben@apple.com>
3796
3797         Make DumpRenderTreeSupport get installed when the default configuration is built
3798
3799         The default configuration is Production, but in that case the CONFIGURATION environment
3800         variable is set to the empty string.
3801
3802         Reviewed by Sam Weinig.
3803
3804         * DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't
3805         already set so that later logic that depends on CONFIGURATION having that value will work.
3806
3807 2011-04-29  Dean Jackson  <dino@apple.com>
3808
3809         Reviewed by Simon Fraser.
3810
3811         Add ENABLE macro for WebKitAnimation
3812         https://bugs.webkit.org/show_bug.cgi?id=59729
3813
3814         Add new feature to toggle WebKit Animation API.
3815
3816         * Scripts/build-webkit:
3817
3818 2011-04-29  Sam Weinig  <sam@webkit.org>
3819
3820         Reviewed by Adam Roben.
3821
3822         Make production the default build type for WebKitTestRunner, matching
3823         all other projects.
3824
3825         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3826
3827 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
3828
3829         [wx] Unreviewed build fix, add new directory to the build.
3830
3831         * waf/build/settings.py:
3832
3833 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3834
3835         Reviewed by Martin Robinson.
3836
3837         [GTK] Implement UI client in minibrowser
3838         https://bugs.webkit.org/show_bug.cgi?id=58416
3839
3840         It also allows to open more than one minibrowser window from the
3841         command line.
3842
3843         * MiniBrowser/gtk/BrowserWindow.c:
3844         (browserWindowFinalize):
3845         (browser_window_init):
3846         (browserWindowConstructed):
3847         (createNewPage):
3848         (showPage):
3849         (closePage):
3850         (runJavaScriptAlert):
3851         (browserWindowUIClientInit):
3852         * MiniBrowser/gtk/main.c:
3853         (loadURI):
3854         (main):
3855
3856 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3857
3858         Reviewed by Martin Robinson.
3859
3860         [GTK] Implement page loader client in MiniBrowser
3861         https://bugs.webkit.org/show_bug.cgi?id=58024
3862
3863         A new class BrowserWindow has been added to implement the page
3864         loader client. It makes supporting multiple windows easier. Window
3865         title and url entry are now updated during the loading process.
3866
3867         * MiniBrowser/gtk/BrowserWindow.c: Added.
3868         (activateUriEntryCallback):
3869         (goBackCallback):
3870         (goForwardCallback):
3871         (browserWindowFinalize):
3872         (browserWindowGetProperty):
3873         (browserWindowSetProperty):
3874         (browser_window_init):
3875         (browserWindowConstructed):
3876         (browser_window_class_init):
3877         (browserWindowUpdateTitle):
3878         (browserWindowSetTitle):
3879         (browserWindowSetLoadProgress):
3880         (browserWindowUpdateURL):
3881         (didStartProvisionalLoadForFrame):
3882         (didReceiveServerRedirectForProvisionalLoadForFrame):
3883         (didFailProvisionalLoadWithErrorForFrame):
3884         (didCommitLoadForFrame):
3885         (didFinishDocumentLoadForFrame):
3886         (didFinishLoadForFrame):
3887         (didFailLoadWithErrorForFrame):
3888         (didReceiveTitleForFrame):
3889         (didFirstLayoutForFrame):
3890         (didFirstVisuallyNonEmptyLayoutForFrame):
3891         (didRemoveFrameFromHierarchy):
3892         (didStartProgress):
3893         (didChangeProgress):
3894         (didFinishProgress):
3895         (didBecomeUnresponsive):
3896         (didBecomeResponsive):
3897         (browserWindowLoaderClientInit):
3898         (browser_window_new):
3899         (browser_window_get_view):
3900         * MiniBrowser/gtk/BrowserWindow.h: Added.
3901         * MiniBrowser/gtk/GNUmakefile.am:
3902         * MiniBrowser/gtk/main.c:
3903         (createWindow):
3904
3905 2011-04-28  Stephanie Lewis  <slewis@apple.com>
3906
3907         Reviewed by Mark Rowe.
3908
3909         http://bugs.webkit.org/show_bug.cgi?id=59743
3910         <rdar://problem/9040413> Add an install target for production builds.
3911
3912         * DumpRenderTree/mac/PerlSupport/Makefile:
3913
3914 2011-04-28  Adam Roben  <aroben@apple.com>
3915
3916         Stop and restart ATSServer before each test run on Leopard
3917
3918         This is to work around an ATSServer leak that eventually causes tests
3919         to fail.
3920
3921         Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
3922         fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
3923         (due to ATSServer leak)
3924
3925         Reviewed by Dan Bernstein.
3926
3927         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3928         (StopATSServer):
3929         (StartATSServer):
3930         Added these new commands to stop and start ATSServer.
3931
3932         (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
3933
3934 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3935
3936         Reviewed by Adam Roben.
3937
3938         add Leopard NRWT bot to the scheduler
3939         https://bugs.webkit.org/show_bug.cgi?id=59766
3940
3941         * BuildSlaveSupport/build.webkit.org-config/config.json:
3942
3943 2011-04-28  Sam Weinig  <sam@webkit.org>
3944
3945         Fix WebKitTestRunner build.
3946
3947         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3948         The Derived Sources target needs a product name.
3949
3950 2011-04-28  Sam Weinig  <sam@webkit.org>
3951
3952         Reviewed by Mark Rowe.
3953
3954         Add install support for WebKitTestRunner.
3955         <rdar://problem/9349055>
3956
3957         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3958         Add missing CompilerVersion.xcconfig.
3959
3960         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3961         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3962         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3963         Add install path and tell it not to skip installation.
3964
3965         Add missing CompilerVersion.xcconfig.
3966
3967 2011-04-28  David Levin  <levin@chromium.org>
3968
3969         Reviewed by Adam Barth.
3970
3971         Remove IMAGE_RESIZER related code.
3972         https://bugs.webkit.org/show_bug.cgi?id=59735
3973
3974         * Scripts/build-webkit:
3975
3976 2011-04-28  Sam Weinig  <sam@webkit.org>
3977
3978         Reviewed by Adam Roben.
3979
3980         Make reading skipped files from additional platform
3981         directories work in WebKit2 mode.
3982
3983         * Scripts/old-run-webkit-tests:
3984         (buildPlatformTestHierarchy): Simplify logic to always use the first
3985         and last platforms in the build hierarchy as the test hierarchy, and to
3986         insert the WebKit2 platform in the middle if it exists. Yum.
3987
3988 2011-04-28  Adam Barth  <abarth@webkit.org>
3989
3990         Reviewed by Eric Seidel.
3991
3992         Remove WML
3993         https://bugs.webkit.org/show_bug.cgi?id=59678
3994
3995         Remove build system integration and test harness integration for WML.
3996
3997         * Scripts/build-webkit:
3998         * Scripts/old-run-webkit-tests:
3999         * Scripts/webkitperl/features.pm:
4000         * Scripts/webkitpy/layout_tests/port/webkit.py:
4001         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4002
4003 2011-04-28  Ojan Vafai  <ojan@chromium.org>
4004
4005         Reviewed by Mihai Parparita.
4006
4007         use a hierarchical data structure to store results json
4008         https://bugs.webkit.org/show_bug.cgi?id=59736
4009
4010         Instead of a map from test name to results dict, we now store a hierarchical
4011         data structure.
4012
4013         Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
4014         New:
4015         { foo: {
4016             bar: {
4017               baz.html: results_dict,
4018               baz2.html: results_dict } } }
4019
4020         This cut ~52% of the size of times_ms.json. I expect it will cut
4021         30-40% of full_results.json and unexpected_results.json.
4022
4023         * Scripts/webkitpy/common/net/resultsjsonparser.py:
4024         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
4025         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4026         Using os.sep was just wrong since relative_test_filename canonicalizes separators.
4027         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4028         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4029         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4030         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4031         Instead of plumbing through the change to all of the rebaselineserver
4032         python and JS, just convert to the old format after reading in the json.
4033
4034 2011-04-28  Eric Seidel  <eric@webkit.org>
4035
4036         Reviewed by Adam Barth.
4037
4038         EWS Bubbles should show commit-queue position when patch is in the commit-queue
4039         https://bugs.webkit.org/show_bug.cgi?id=59744
4040
4041         Add target="_top" to the bubble links.  This was
4042         forgotten when I moved from using an onclick to a normal link.
4043
4044         * QueueStatusServer/templates/statusbubble.html:
4045
4046 2011-04-28  Eric Seidel  <eric@webkit.org>
4047
4048         Reviewed by Adam Barth.
4049
4050         EWS bubbles should show "submit to ews" button if they've not been processed
4051         https://bugs.webkit.org/show_bug.cgi?id=59751
4052
4053         * QueueStatusServer/handlers/statusbubble.py:
4054         * QueueStatusServer/handlers/submittoews.py:
4055         * QueueStatusServer/templates/statusbubble.html:
4056         * QueueStatusServer/templates/submittoews.html:
4057
4058 2011-04-28  Eric Seidel  <eric@webkit.org>
4059
4060         Reviewed by Adam Barth.
4061
4062         EWS Bubbles should show commit-queue position when patch is in the commit-queue
4063         https://bugs.webkit.org/show_bug.cgi?id=59744
4064
4065         This was actually just a 2 line change to statusbubble.py.
4066         I also cleaned up statusbubble.html a little while I was there
4067         (the links are now actual <a> tags and have hover).
4068
4069         * QueueStatusServer/handlers/statusbubble.py:
4070         * QueueStatusServer/templates/statusbubble.html:
4071
4072 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
4073
4074         Reviewed by Eric Seidel.
4075
4076         add a mac leopard release NRWT bot
4077         https://bugs.webkit.org/show_bug.cgi?id=59733
4078
4079         * BuildSlaveSupport/build.webkit.org-config/config.json:
4080
4081 2011-04-28  Ojan Vafai  <ojan@chromium.org>
4082
4083         Avoid crashing when running new-run-webkit-tests outside of
4084         version control.
4085
4086         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4087
4088 2011-04-28  Xan Lopez  <xlopez@igalia.com>
4089
4090         Unreviewed build fix.
4091
4092         * GNUmakefile.am:
4093
4094 2011-04-28  Ojan Vafai  <ojan@chromium.org>
4095
4096         Reviewed by Eric Seidel.
4097
4098         fix python printing test
4099         https://bugs.webkit.org/show_bug.cgi?id=59719
4100
4101         Now that we run scm commands in summarize_results, --verbose prints
4102         debug logging to stderr.
4103
4104         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4105
4106 2011-04-28  Ojan Vafai  <ojan@chromium.org>
4107
4108         Reviewed by Tony Chang.
4109
4110         link to tests at a specific revision in the results.html file
4111         https://bugs.webkit.org/show_bug.cgi?id=59711
4112
4113         * Scripts/webkitpy/common/checkout/scm.py:
4114         Add a method to get the head svn revision.
4115         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4116         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4117         Include the svn revision in the results json.
4118
4119 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
4120
4121         Reviewed by Sam Weinig.
4122
4123         [GTK] Remove WKURLCreateWithURL()
4124         https://bugs.webkit.org/show_bug.cgi?id=59691
4125
4126         Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().
4127
4128         * MiniBrowser/gtk/main.c:
4129         (activateUriEntryCallback):
4130         (main):
4131
4132 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
4133
4134         Reviewed by Martin Robinson.
4135
4136         [GTK] WKView should be a GtkWidget
4137         https://bugs.webkit.org/show_bug.cgi?id=59603
4138
4139         Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.
4140
4141         * MiniBrowser/gtk/main.c:
4142         (createWindow):
4143         (main):
4144
4145 2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>
4146
4147         Reviewed by Csaba Osztrogonác.
4148
4149         [Qt] Add ARM specific Skipped list
4150         https://bugs.webkit.org/show_bug.cgi?id=59680
4151
4152         * Scripts/old-run-webkit-tests:
4153         * Scripts/webkitdirs.pm:
4154
4155 2011-04-27  Eric Seidel  <eric@webkit.org>
4156
4157         Reviewed by Adam Barth.
4158
4159         error_log.txt should include PHP errors
4160         https://bugs.webkit.org/show_bug.cgi?id=59643
4161
4162         Turns out this was really easy after I finally learned
4163         enough about PHP to do it...
4164
4165         I'm adding this in hopes of better tracking down
4166         our random http failures.
4167
4168         * Scripts/webkitperl/httpd.pm:
4169
4170 2011-04-27  David Levin  <levin@chromium.org>
4171
4172         Reviewed by Adam Barth.
4173
4174         check-webkit-style should flags spacing errors for braces on the same line.
4175         https://bugs.webkit.org/show_bug.cgi?id=59665
4176
4177         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
4178         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
4179           and fixed some test cases to not trigger this error since it isn't what they are verifying.
4180
4181 2011-04-27  David Levin  <levin@chromium.org>
4182
4183         Reviewed by Adam Barth.
4184
4185         check-webkit-style error for spaces after periods in a comment has a bad error
4186         message and warns about end of line spaces.
4187         https://bugs.webkit.org/show_bug.cgi?id=59663
4188
4189         * Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
4190         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
4191         and changed the error messages.
4192
4193 2011-04-27  Ojan Vafai  <ojan@chromium.org>
4194
4195         remove assertion now that platform/mac-tiger no longer exists
4196         https://bugs.webkit.org/show_bug.cgi?id=59660
4197
4198         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4199
4200 2011-04-27  Ojan Vafai  <ojan@chromium.org>
4201
4202         Reviewed by Eric Seidel.
4203
4204         remove test that didn't make sense
4205         https://bugs.webkit.org/show_bug.cgi?id=59658
4206
4207         It was artifically saying the test wasn't expected to pass,
4208         but the expectations string was empty. The case of unexpected
4209         passes with a real expectations string is tested later in the
4210         same test.
4211
4212         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4213
4214 2011-04-27  Sam Weinig  <sam@webkit.org>
4215
4216         Reviewed by Adam Roben.
4217
4218         WebKit2 needs to notify the client when a plugin fails to initialize
4219         https://bugs.webkit.org/show_bug.cgi?id=59657
4220
4221         * MiniBrowser/mac/BrowserWindowController.m:
4222         (-[BrowserWindowController awakeFromNib]):
4223         * WebKitTestRunner/TestController.cpp:
4224         (WTR::TestController::initialize):
4225         Add stubs.
4226
4227 2011-04-26  Sam Weinig  <sam@webkit.org>
4228
4229         Reviewed by David Levin.
4230
4231         Add a few more missing options to new-run-webkit-tests
4232         https://bugs.webkit.org/show_bug.cgi?id=59567
4233
4234         Add support for:
4235             --threaded
4236             --gc-between-tests
4237             --complex-text
4238
4239         * Scripts/webkitpy/layout_tests/port/webkit.py:
4240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4241         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4242
4243 2011-04-27  Mark Rowe  <mrowe@apple.com>
4244
4245         Build fix.
4246
4247         Fix an OwnPtr-related issue that was missed before the strictness was turned on.
4248         
4249         * WebKitTestRunner/TestController.cpp:
4250         (WTR::TestController::runTest):
4251
4252 2011-04-27  Ojan Vafai  <ojan@chromium.org>
4253
4254         Forgot to upload the new times_ms.json file after splitting
4255         it out from full_results.json.
4256
4257         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4258
4259 2011-04-27  Ojan Vafai  <ojan@chromium.org>
4260
4261         Fix snafu in generating the JSON for the chromium tests.
4262
4263         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4264
4265 2011-04-27  Ojan Vafai  <ojan@chromium.org>
4266
4267         Fix bad merge. This broke the chromium tests generating JSON files.
4268         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4269
4270 2011-04-27  Mark Rowe  <mrowe@apple.com>
4271
4272         Rubber-stamped by Geoff Garen.
4273
4274         Don't look for results in a location that no longer exists.
4275
4276         * Scripts/old-run-webkit-tests:
4277
4278 2011-04-27  Adrienne Walker  <enne@google.com>
4279
4280         Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
4281
4282         * Scripts/webkitpy/common/config/committers.py:
4283
4284 2011-04-22  Ojan Vafai  <ojan@chromium.org>
4285
4286         Reviewed by Tony Chang.
4287
4288         only include failures in full_results.json
4289         https://bugs.webkit.org/show_bug.cgi?id=59256
4290
4291         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4292
4293 2011-04-22  Ojan Vafai  <ojan@chromium.org>
4294
4295         Reviewed by Adam Roben.
4296
4297         move times into their own json file
4298         https://bugs.webkit.org/show_bug.cgi?id=59239
4299
4300         The test runtimes are the only case where we need an entry for
4301         every test that was run, including passing tests. Move them into
4302         their own json file so we can prune the other json files to only
4303         include failing tests.
4304
4305         Use a trie-like data structure to hold the tests to avoid including
4306         full test paths. This cuts 52% of the filesize. The end result is ~700k
4307         pre-gzip.
4308
4309         * Scripts/webkitpy/common/net/resultsjsonparser.py:
4310         Exclude times from the parsed TestResults.
4311         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
4312         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4313         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4314         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4315
4316 2011-04-27  Anders Carlsson  <andersca@apple.com>
4317
4318         More casts and more clang++ build fixes.
4319
4320         * DumpRenderTree/mac/DumpRenderTree.mm:
4321         (createWebViewAndOffscreenWindow):
4322         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4323         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4324         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4325         (WTR::PlatformWebView::PlatformWebView):
4326
4327 2011-04-27  Tony Chang  <tony@chromium.org>
4328
4329         Reviewed by Ojan Vafai.
4330
4331         lazily autoinstall thirdparty python libraries
4332         https://bugs.webkit.org/show_bug.cgi?id=55723
4333
4334         This helps by only having pywebsocket installed when the bots run.  It
4335         doesn't help much for devs since webkit-patch pulls in almost everything.
4336
4337         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4338         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4339         * Scripts/webkitpy/common/net/networktransaction.py:
4340         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4341         * Scripts/webkitpy/common/net/statusserver.py:
4342         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4343         * Scripts/webkitpy/thirdparty/__init__.py: Add an import hook so we can install based on
4344             the import command rather than just installing everythin