REGRESSION (r226395): test-webkitperl test expectations incorrect
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2
3         REGRESSION (r226395): test-webkitperl test expectations incorrect
4         https://bugs.webkit.org/show_bug.cgi?id=181307
5         <rdar://problem/36306558>
6
7         Rubber-stamped by Aakash Jain.
8
9         r226395 added two lines towards the beginning of
10         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
11         numbers in the test expectations need to update.
12
13         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
14
15 2018-01-04  Tim Horton  <timothy_horton@apple.com>
16
17         WKWebView loses minimum layout size overrides that happen while the process is terminated
18         https://bugs.webkit.org/show_bug.cgi?id=181306
19         <rdar://problem/34398288>
20
21         Reviewed by Dan Bernstein.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
24         (TEST):
25         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
26         while the process is terminated results in the page getting the correct
27         minimum layout size.
28
29 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
30
31         [MediaStream] Add Mock screen capture source
32         https://bugs.webkit.org/show_bug.cgi?id=181291
33         <rdar://problem/36298164>
34
35         Reviewed by Dean Jackson.
36
37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
38         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
39         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
40
41 2018-01-04  Lucas Forschler  <lforschler@apple.com>
42
43         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
44
45         Reviewed by Ling Ho.
46
47         * BuildSlaveSupport/build.webkit.org-config/steps.py:
48
49 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
50
51         [Attachment Support] Create attachment elements when dropping files on iOS
52         https://bugs.webkit.org/show_bug.cgi?id=181192
53         <rdar://problem/36280945>
54
55         Reviewed by Tim Horton.
56
57         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
58         switch is enabled. See below for more details.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
61         (-[NSItemProvider registerData:type:]):
62         (platformCopyPNG):
63         (TestWebKitAPI::TEST):
64         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
65
66         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
67         source item provider when dragging rich text *without* attachments, so this should have been a check for just
68         kUTTypeRTF instead.
69
70         (TestWebKitAPI::TEST):
71
72         Tests a few cases of inserting attachment elements via drop:
73         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
74             Instead of inserting the contents as inline web content, this should generate attachment elements.
75         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
76             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
77             back to inserting the content as an attachment.
78         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
79             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
80             or at the end).
81
82         * TestWebKitAPI/cocoa/TestWKWebView.h:
83         * TestWebKitAPI/cocoa/TestWKWebView.mm:
84         (-[TestWKWebView objectByEvaluatingJavaScript:]):
85
86         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
87         -stringByEvaluatingJavaScript to just turn around and call this.
88
89         (-[TestWKWebView stringByEvaluatingJavaScript:]):
90
91 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
92
93         Replace hard-coded paths in shebangs with #!/usr/bin/env
94         https://bugs.webkit.org/show_bug.cgi?id=181040
95
96         Reviewed by Alex Christensen.
97
98         * BuildSlaveSupport/build-launcher-app:
99         * BuildSlaveSupport/build-launcher-dmg:
100         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
101         * BuildSlaveSupport/built-product-archive:
102         * BuildSlaveSupport/clean-build:
103         * BuildSlaveSupport/delete-stale-build-files:
104         * BuildSlaveSupport/download-built-product:
105         * BuildSlaveSupport/gtk/buildbot/log/run:
106         * BuildSlaveSupport/gtk/buildbot/run:
107         * BuildSlaveSupport/gtk/pulseaudio/run:
108         * BuildSlaveSupport/kill-old-processes:
109         * BuildSlaveSupport/test-result-archive:
110         * BuildSlaveSupport/win/kill-old-processes:
111         * Scripts/SpacingHeuristics.pm:
112         * Scripts/add-include:
113         * Scripts/build-api-tests:
114         * Scripts/build-dumprendertree:
115         * Scripts/build-imagediff:
116         * Scripts/build-jsc:
117         * Scripts/build-webkit:
118         * Scripts/build-webkittestrunner:
119         * Scripts/check-Xcode-source-file-types:
120         * Scripts/check-dom-results:
121         * Scripts/check-for-exit-time-destructors:
122         * Scripts/check-for-global-initializers:
123         * Scripts/check-for-inappropriate-objc-class-names:
124         * Scripts/check-for-weak-vtables-and-externals:
125         * Scripts/clean-header-guards:
126         * Scripts/compare-timing-files:
127         * Scripts/configure-xcode-for-ios-development:
128         * Scripts/copy-webkitlibraries-to-product-directory:
129         * Scripts/create-exports:
130         * Scripts/debug-minibrowser:
131         * Scripts/debug-safari:
132         * Scripts/debug-test-runner:
133         * Scripts/do-file-rename:
134         * Scripts/do-webcore-rename:
135         * Scripts/dump-webkit-tests-run:
136         * Scripts/ensure-valid-python:
137         * Scripts/execAppWithEnv:
138         * Scripts/extract-localizable-js-strings:
139         * Scripts/filter-build-webkit:
140         * Scripts/find-extra-includes:
141         * Scripts/fix-blink-patch:
142         * Scripts/generate-coverage-data:
143         * Scripts/git-add-reviewer:
144         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
145         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
146         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
147         * Scripts/make-new-script-test:
148         * Scripts/make-script-test-wrappers:
149         * Scripts/package-root:
150         * Scripts/parse-malloc-history:
151         * Scripts/report-include-statistics:
152         * Scripts/resolve-ChangeLogs:
153         * Scripts/run-api-tests:
154         * Scripts/run-bindings-tests:
155         * Scripts/run-content-extension-tester:
156         * Scripts/run-iexploder-tests:
157         * Scripts/run-javascriptcore-tests:
158         * Scripts/run-jsc:
159         * Scripts/run-leaks:
160         * Scripts/run-mangleme-tests:
161         * Scripts/run-minibrowser:
162         * Scripts/run-pageloadtest:
163         * Scripts/run-regexp-tests:
164         * Scripts/run-safari:
165         * Scripts/run-sunspider:
166         * Scripts/run-test-runner:
167         * Scripts/run-webkit-app:
168         * Scripts/run-webkit-httpd:
169         * Scripts/run-webkit-websocketserver:
170         * Scripts/set-webkit-configuration:
171         * Scripts/show-pretty-diff:
172         * Scripts/sort-Xcode-project-file:
173         * Scripts/split-file-by-class:
174         * Scripts/sunspider-compare-results:
175         * Scripts/svn-apply:
176         * Scripts/svn-unapply:
177         * Scripts/test-webkit-scripts:
178         * Scripts/test-webkitperl:
179         * Scripts/update-iexploder-cssproperties:
180         * Scripts/update-javascriptcore-test-results:
181         * Scripts/update-webkit:
182         * Scripts/update-webkit-auxiliary-libs:
183         * Scripts/update-webkit-dependency:
184         * Scripts/update-webkit-libs-jhbuild:
185         * Scripts/update-webkit-localizable-strings:
186         * Scripts/update-webkit-support-libs:
187         * Scripts/update-webkitgtk-libs:
188         * Scripts/update-webkitwpe-libs:
189         * Scripts/webkit-build-directory:
190         * Scripts/webkitperl/LoadAsModule.pm:
191         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
192         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
193         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
194         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
195         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
196         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
197         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
198         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
199         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
200         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
201         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
202         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
203         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
204         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
205         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
206         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
207         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
208         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
209         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
210         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
211         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
212         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
213         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
214         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
215         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
216         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
217         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
218         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
219         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
220         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
221         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
222         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
223         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
224         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
225         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
226         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
227         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
228         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
229         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
230         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
231         * ccache/ccache-clang:
232         * ccache/ccache-clang++:
233         * ccache/ccache-wrapper:
234         * gtk/install-dependencies:
235         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
236         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
237         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
238         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
239         * iExploder/iexploder-1.3.2/tools/showtest.rb:
240         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
241         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
242         * iExploder/iexploder-1.7.2/src/webserver.rb:
243         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
244         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
245         * wpe/install-dependencies:
246
247 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
248
249         filter-build-webkit filters out useful compiler error lines
250         https://bugs.webkit.org/show_bug.cgi?id=179864
251
252         Reviewed by Tim Horton.
253
254         Don't filter out lines that contain information about build errors by always showing lines
255         after a line that contains "note:" or "error:".
256
257         * Scripts/filter-build-webkit:
258         (shouldShowSubsequentLine):
259         (shouldIgnoreLine):
260
261 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
262
263         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
264         https://bugs.webkit.org/show_bug.cgi?id=173915
265
266         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
267         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
268         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
269         empty string in this case.
270
271         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
272         (emitFormSubmissionEvent):
273
274 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
275
276         [GTK] Add web process API to detect when form is submitted via JavaScript
277         https://bugs.webkit.org/show_bug.cgi?id=173915
278
279         Reviewed by Carlos Garcia Campos.
280
281         Test it.
282
283         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
284         (FormSubmissionTest::FormSubmissionTest):
285         (FormSubmissionTest::~FormSubmissionTest):
286         (FormSubmissionTest::testFormSubmissionResult):
287         (FormSubmissionTest::willSendDOMEventCallback):
288         (FormSubmissionTest::willCompleteCallback):
289         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
290         (testWebExtensionFormSubmissionSteps):
291         (beforeAll):
292         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
293         (DelayedSignal::DelayedSignal):
294         (emitFormSubmissionEvent):
295         (handleFormSubmissionCallback):
296         (willSubmitFormCallback):
297         (pageCreatedCallback):
298
299 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
300
301         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
302         https://bugs.webkit.org/show_bug.cgi?id=181251
303
304         * Scripts/run-gtk-tests:
305         (GtkTestRunner):
306
307 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
308
309         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
310         https://bugs.webkit.org/show_bug.cgi?id=181136
311
312         * Scripts/run-gtk-tests:
313         (GtkTestRunner):
314
315 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
316
317         [macOS, iOS] Adopt new secure coding APIs in WebKit
318         https://bugs.webkit.org/show_bug.cgi?id=181085
319         <rdar://problem/34837397>
320
321         Reviewed by Tim Horton.
322
323         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
324         capable of supporting NSSecureCoding, so pass through the current coding routines.
325
326         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
327         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
328         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
329         routines if necessary.
330         (TEST): Updated for NSSecureCoding.
331         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
332         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
333
334 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
335
336         Remove std::chrono completely
337         https://bugs.webkit.org/show_bug.cgi?id=181186
338
339         Reviewed by Alex Christensen.
340
341         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
342         (WTR::TestController::platformRunUntil):
343
344 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
345
346         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
347         https://bugs.webkit.org/show_bug.cgi?id=181231
348
349         Reviewed by Alex Christensen.
350
351         Implement TestController APIs needed by ResourceLoadStatistics tests.
352
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
355         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
356
357 2018-01-02  Tim Horton  <timothy_horton@apple.com>
358
359         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
360         https://bugs.webkit.org/show_bug.cgi?id=181219
361
362         Reviewed by Wenson Hsieh.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
365
366 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
367
368         Add a WebAuthentication runtime feature flag
369         https://bugs.webkit.org/show_bug.cgi?id=181220
370         <rdar://problem/36055305>
371
372         Reviewed by Brent Fulgham.
373
374         Renames the CredentialManagement runtime feature flag into WebAuthentication.
375
376         * DumpRenderTree/TestOptions.h:
377         * DumpRenderTree/TestOptions.mm:
378         (TestOptions::TestOptions):
379         * DumpRenderTree/mac/DumpRenderTree.mm:
380         (enableExperimentalFeatures):
381         (setWebPreferencesForTestOptions):
382         * WebKitTestRunner/TestController.cpp:
383         (WTR::TestController::resetPreferencesToConsistentValues):
384         (WTR::updateTestOptionsFromTestHeader):
385         * WebKitTestRunner/TestOptions.h:
386         (WTR::TestOptions::hasSameInitializationOptions const):
387
388 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
389
390         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
391         https://bugs.webkit.org/show_bug.cgi?id=181143
392         <rdar://problem/36200381>
393
394         Reviewed by Tim Horton.
395
396         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
397         attachment elements are enabled.
398
399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
400         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
401         (TestWebKitAPI::TEST):
402
403 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
404
405         Update Credential Management API for WebAuthentication
406         https://bugs.webkit.org/show_bug.cgi?id=181082
407         <rdar://problem/36055239>
408
409         Reviewed by Brent Fulgham.
410
411         Enable Credential Management API for testing.
412
413         * DumpRenderTree/TestOptions.h:
414         * WebKitTestRunner/TestOptions.h:
415
416 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
417
418         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
419         https://bugs.webkit.org/show_bug.cgi?id=168194
420
421         Reviewed by Carlos Garcia Campos.
422
423         Fix an assertion and unskip the test. The order that form controls are associated is not
424         guaranteed.
425
426         * Scripts/run-gtk-tests:
427         (GtkTestRunner):
428         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
429         (didAssociateFormControlsCallback):
430
431 2018-01-02  Alex Christensen  <achristensen@webkit.org>
432
433         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
434         https://bugs.webkit.org/show_bug.cgi?id=180897
435         <rdar://problem/35535328>
436
437         Reviewed by Brent Fulgham.
438
439         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
440
441         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
442         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
443         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
444         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
445         (websiteDataStoreTestWebView):
446         (TEST):
447
448 == Rolled over to ChangeLog-2018-01-01 ==