Unreviewed build fix after r105256.
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
2
3         Unreviewed build fix after r105256.
4
5         There was a cyclic dependency between self._port and self._host assigments.
6
7         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
8         (PerfTestsRunner.__init__):
9
10 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
11
12         Add new watchlist rule for the Qt build system
13
14         Reviewed by Simon Hausmann.
15
16         * Scripts/webkitpy/common/config/watchlist:
17
18 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19
20         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
21
22         Reviewed by Simon Hausmann.
23
24         * Tools.pro:
25
26 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
27
28         [Qt] Allow building only a subset of the WebKit sub-projects
29
30         Fixes build-jsc, broken in r104825.
31
32         We no longer need the intermediate buildQMakeQtProject(), as we're the
33         only port using qmake, and buildQMakeProject is now highly Qt specific.
34
35         <http://webkit.org/b/76179>
36
37         Reviewed by Simon Hausmann.
38
39         * Scripts/build-jsc:
40         * Scripts/build-webkit:
41         * Scripts/webkitdirs.pm:
42         (buildQMakeProjects):
43
44 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
45
46         run-perf-tests should generate a json file that summaries the result
47         https://bugs.webkit.org/show_bug.cgi?id=76504
48
49         Reviewed by Adam Barth.
50
51         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
52         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
53         another json file to be merged into the generated json file.
54
55         Also fixed a bug that --build wasn't set by default.
56
57         * Scripts/webkitpy/layout_tests/port/test.py:
58         (TestPort.webkit_base):
59         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
60         (PerfTestsRunner.__init__):
61         (PerfTestsRunner):
62         (PerfTestsRunner._parse_args):
63         (PerfTestsRunner.run):
64         (PerfTestsRunner._generate_json_if_specified):
65         (PerfTestsRunner._process_chromium_style_test_result):
66         (PerfTestsRunner._process_parser_test_result):
67         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
68         (MainTest):
69         (create_runner):
70         (test_run_test_set):
71         (test_run_test_set_for_parser_tests):
72         (test_run_test_set_with_summary_json):
73         (test_collect_tests):
74         (test_parse_args):
75
76 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
77
78         Unreviewed, rolling out r105244.
79         http://trac.webkit.org/changeset/105244
80         https://bugs.webkit.org/show_bug.cgi?id=76518
81
82         broke Chromium Mac (Requested by rolandsteiner on #webkit).
83
84         * DumpRenderTree/AccessibilityUIElement.h:
85         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
86         (AccessibilityUIElement::AccessibilityUIElement):
87         * DumpRenderTree/chromium/AccessibilityUIElement.h:
88         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
89         (AccessibilityUIElement::removeSelection):
90         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
91         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
92         (AccessibilityUIElement::removeSelection):
93
94 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
95
96         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
97         https://bugs.webkit.org/show_bug.cgi?id=73460
98
99         Reviewed by Chris Fleizach.
100
101         * DumpRenderTree/AccessibilityUIElement.h:
102         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
103         (AccessibilityUIElement::AccessibilityUIElement):
104         (AccessibilityUIElement::scrollToMakeVisibleCallback):
105         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
106         (AccessibilityUIElement::scrollToGlobalPointCallback):
107         * DumpRenderTree/chromium/AccessibilityUIElement.h:
108         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
109         (AccessibilityUIElement::scrollToMakeVisible):
110         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
111         (AccessibilityUIElement::scrollToGlobalPoint):
112         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
113         (AccessibilityUIElement::scrollToMakeVisible):
114         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
115         (AccessibilityUIElement::scrollToGlobalPoint):
116         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
117         (AccessibilityUIElement::scrollToMakeVisible):
118         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
119         (AccessibilityUIElement::scrollToGlobalPoint):
120
121 2012-01-17  Adam Barth  <abarth@webkit.org>
122
123         Enable tests on the mac-ews
124         https://bugs.webkit.org/show_bug.cgi?id=76502
125
126         Reviewed by Simon Fraser.
127
128         Apple now has five machines running the mac-ews.  Lucas Forschler has
129         asked that we try enabling tests to see if we have enough bandwidth.
130
131         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
132         (MacEWS):
133
134 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
135
136         Add a check-webkit-style exception for GDBInterface.cpp
137         https://bugs.webkit.org/show_bug.cgi?id=76187
138
139         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
140         that it does not fail the style check.
141
142         Reviewed by Martin Robinson.
143
144         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
145         readability/naming tests on
146         Source/JavaScriptCore/jit/GDBInterface.cpp.
147         * Scripts/webkitpy/style/checker_unittest.py:
148         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
149         the above exception.
150
151 2012-01-17  Hajime Morrita  <morrita@chromium.org>
152
153         https://bugs.webkit.org/show_bug.cgi?id=76245
154         [Mac][DRT] should allow query string for the file URL.
155
156         Reviewed by Tony Chang.
157
158         Taught DRT about file:// as a url instead of a file path.
159         We are now able to use a path file:///foo/bar.html?baz as a url
160         with which DRT opens "/foo/bar.html" with "baz" as a query string.
161
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (runTest):
164
165 2012-01-17  Ojan Vafai  <ojan@chromium.org>
166
167         Check style on test_expectations.txt files before commit
168         https://bugs.webkit.org/show_bug.cgi?id=76484
169
170         Reviewed by Adam Barth.
171
172         Unlike other style rules, if you get the syntax of the test_expectations.txt
173         file wrong, the layout tests won't run. Also, this check is simple and only
174         slows down committing if you actually modify one of the test_expectations.txt files.
175
176         * Scripts/webkitpy/tool/steps/commit.py:
177         (Commit._check_test_expectations):
178         (Commit.run):
179         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
180         (CommitTest):
181         (CommitTest.test_check_test_expectations):
182
183 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
184
185         [Qt] Debug build fails with debug qt5
186         https://bugs.webkit.org/show_bug.cgi?id=76463
187
188         Reviewed by Simon Hausmann.
189
190         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
191
192         * QtTestBrowser/cookiejar.h:
193
194 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
195
196         webkitpy: fix json import on linux
197         https://bugs.webkit.org/show_bug.cgi?id=76481
198
199         Reviewed by Adam Barth.
200
201         For some reason, the version of simplejson autoinstalled on my linux
202         box seems to be broken. We should really only be using
203         simplejson if json isn't available anyway, so this change looks
204         for json first.
205
206         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
207         (JSONGeneratorTest.test_test_timings_trie):
208
209 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
210
211         Fix failures in test-webkitpy caused by r105177.
212
213         Unreviewed, build fix.
214
215         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
216         (ChromiumLinuxPort._determine_driver_path_statically):
217         (ChromiumLinuxPort._static_build_path):
218
219 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
220
221         webkitpy: make PortFactory.get() be fully data-driven
222         https://bugs.webkit.org/show_bug.cgi?id=76360
223
224         Reviewed by Eric Seidel.
225
226         Refactor PortFactory.get() to be fully data-driven.
227
228         * Scripts/webkitpy/layout_tests/port/factory.py:
229         (PortFactory):
230         (PortFactory._default_port):
231         (PortFactory.get):
232         (PortFactory.get.in):
233         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
234         (FactoryTest.assert_port):
235
236 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
237
238         webkitpy: add determine_full_port_name(), clean up port.__init__()
239         https://bugs.webkit.org/show_bug.cgi?id=76357
240
241         Reviewed by Adam Barth.
242
243         Each Port class is now required to implement a 'port_name' field
244         that will match the start of all ports constructed by this class and
245         a 'determine_full_port_name' field that will make the port
246         fully-qualified.
247
248         * Scripts/webkitpy/layout_tests/port/apple.py:
249         (ApplePort.__init__):
250         * Scripts/webkitpy/layout_tests/port/base.py:
251         (Port):
252         (Port.determine_port_name):
253         (Port.__init__):
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255         (ChromiumPort.for):
256         (ChromiumPort.__init__):
257         (ChromiumPort):
258         (ChromiumPort._chromium_base_dir):
259         (ChromiumPort.path_from_chromium_base):
260         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
261         (ChromiumGpuLinuxPort):
262         (ChromiumGpuLinuxPort.__init__):
263         (ChromiumGpuMacPort):
264         (ChromiumGpuMacPort.__init__):
265         (ChromiumGpuWinPort):
266         (ChromiumGpuWinPort.__init__):
267         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
268         (ChromiumLinuxPort):
269         (ChromiumLinuxPort.determine_port_name):
270         (ChromiumLinuxPort.__init__):
271         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
272         (ChromiumMacPort):
273         (ChromiumMacPort.determine_port_name):
274         (ChromiumMacPort.__init__):
275         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
276         (ChromiumWinPort):
277         (ChromiumWinPort.determine_port_name):
278         (ChromiumWinPort.__init__):
279         * Scripts/webkitpy/layout_tests/port/dryrun.py:
280         (DryRunPort):
281         (DryRunPort.determine_port_name):
282         (DryRunPort.__init__):
283         * Scripts/webkitpy/layout_tests/port/efl.py:
284         (EflPort):
285         * Scripts/webkitpy/layout_tests/port/factory.py:
286         (PortFactory):
287         (PortFactory._default_port):
288         (PortFactory.get):
289         (PortFactory.get.in):
290         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
291         (FactoryTest.assert_port):
292         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
293         (GoogleChromeLinux32Port):
294         (GoogleChromeLinux32Port.determine_port_name):
295         (GoogleChromeLinux64Port):
296         (GoogleChromeLinux64Port.determine_port_name):
297         (GoogleChromeMacPort):
298         (GoogleChromeMacPort.determine_port_name):
299         (GoogleChromeWinPort):
300         (GoogleChromeWinPort.determine_port_name):
301         * Scripts/webkitpy/layout_tests/port/gtk.py:
302         (GtkPort):
303         * Scripts/webkitpy/layout_tests/port/mac.py:
304         (MacPort):
305         (MacPort.determine_port_name):
306         (MacPort.__init__):
307         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
308         (test_versions):
309         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
310         (MockDRTPort):
311         (MockDRTPort.determine_port_name):
312         (MockDRTPort.__init__):
313         (MockDRT):
314         (MockDRT.determine_port_name):
315         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
316         (PortTestCase.make_port):
317         * Scripts/webkitpy/layout_tests/port/qt.py:
318         (QtPort):
319         (QtPort.determine_port_name):
320         (QtPort.__init__):
321         * Scripts/webkitpy/layout_tests/port/test.py:
322         (TestPort):
323         (TestPort.determine_port_name):
324         (TestPort.__init__):
325         * Scripts/webkitpy/layout_tests/port/webkit.py:
326         (WebKitPort.__init__):
327         * Scripts/webkitpy/layout_tests/port/win.py:
328         (WinPort):
329         (WinPort.determine_port_name):
330         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
331         (get_test_baselines.AllPlatformsPort.__init__):
332         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
333         (get_test_config.TestMacPort):
334         (get_test_config):
335
336 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
337
338         webkitpy: clean up port code in preparation for static port names
339         https://bugs.webkit.org/show_bug.cgi?id=76356
340
341         Reviewed by Adam Barth.
342
343         To fix bug 76215 and be able to determine appropriate port names
344         in webkitpy without actually constructing Port objects, we need
345         to shuffle some logic in the chromium ports to be able to figure
346         out whether we built DRT in 32 or 64-bit mode.
347
348         * Scripts/webkitpy/layout_tests/port/chromium.py:
349         (ChromiumPort):
350         (ChromiumPort._chromium_base_dir):
351         (ChromiumPort.__init__):
352         (ChromiumPort.path_from_chromium_base):
353         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
354         (ChromiumLinuxPort):
355         (ChromiumLinuxPort._determine_driver_path_statically):
356         (ChromiumLinuxPort._static_build_path):
357         (ChromiumLinuxPort._determine_architecture):
358         (ChromiumLinuxPort.__init__):
359         (ChromiumLinuxPort._build_path):
360
361 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
362
363         Do not remove pixel failures for ref tests.
364         https://bugs.webkit.org/show_bug.cgi?id=76243
365
366         Reviewed by Tony Chang.
367
368         'NRWT --no-pixel-tests' complains when reftests are expected to
369         be image mismatch.
370
371         * Scripts/webkitpy/layout_tests/controllers/manager.py:
372         (Manager._update_summary_with_result):
373         * Scripts/webkitpy/layout_tests/models/test_failures.py:
374         (is_reftest_failure):
375         (determine_result_type):
376
377 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
378
379         REGRESSION(r81225): ORWT should ignore reftests
380         https://bugs.webkit.org/show_bug.cgi?id=67936
381
382         Reviewed by Csaba Osztrogonác.
383
384         * Scripts/old-run-webkit-tests:
385         (isUsedInReftest): $filename should be the first parameter
386         (findTestsToRun): run test if it isn't reftest
387
388 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
389
390         Unreviewed. Fix python unit test I broke with r105142
391
392         * Scripts/webkitpy/common/config/ports_unittest.py:
393         (WebKitPortTest.test_gtk_port):
394
395 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
396
397         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
398
399         Qt 5 no longer has that flag.
400
401         Reviewed by Simon Hausmann.
402
403         * MiniBrowser/qt/MiniBrowserApplication.cpp:
404         (MiniBrowserApplication::notify):
405
406 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
407
408         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
409         https://bugs.webkit.org/show_bug.cgi?id=75857
410
411         Reviewed by Adam Barth.
412
413         * Scripts/webkitdirs.pm:
414         (buildAutotoolsProject): move cleaning the build to happen early,
415         and handle --update-gtk right after that
416         * Scripts/webkitpy/common/config/ports.py:
417         (GtkPort.build_webkit_command): pass --update-gtk as an option to
418         build-webkit, so that it is used in the EWS
419
420 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
421
422         [Qt] Don't add _debug postfix to targets when building debug only
423
424         Reviewed by Simon Hausmann.
425
426         * qmake/mkspecs/features/default_post.prf:
427         * qmake/mkspecs/features/functions.prf:
428
429 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
430
431         [Qt] Add more files to project-files for easier navigation in Qt Creator
432
433         Reviewed by Simon Hausmann.
434
435         * Tools.pro:
436         * qmake/config.tests/README: Added.
437
438 2012-01-17  Philippe Normand  <pnormand@igalia.com>
439
440         [GTK] fast/dom/constructed-objects-prototypes.html fails
441         https://bugs.webkit.org/show_bug.cgi?id=75432
442
443         Reviewed by Martin Robinson.
444
445         * Scripts/build-webkit: Enable video-track in GTK.
446
447 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
448
449         Add toyoshim as a committer.
450         https://bugs.webkit.org/show_bug.cgi?id=76390
451
452         Reviewed by Hajime Morita.
453
454         * Scripts/webkitpy/common/config/committers.py:
455
456 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
457
458         [WinCairo] Build fix after r104155. Several debug targets were not
459         properly including the '*Common' property sheets.
460
461         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
462         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
463         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
464         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
465         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
466
467 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
468
469         REGRESSION(r105072): It broke committers_unittest.py
470         https://bugs.webkit.org/show_bug.cgi?id=76396
471
472         Reviewed by Adam Barth.
473
474         * Scripts/webkitpy/common/config/committers_unittest.py:
475         (CommittersTest._assert_fuzz_match): It should handle more names.
476         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
477
478 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
479
480         [GTK] Include gtk+3 in the jhbuild modules
481         https://bugs.webkit.org/show_bug.cgi?id=76284
482
483         Reviewed by Philippe Normand.
484
485         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
486
487 2012-01-16  Dan Winship  <danw@gnome.org>
488
489         Add myself as a committer
490
491         Unreviewed
492
493         * Scripts/webkitpy/common/config/committers.py:
494
495 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
496
497         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
498
499         Some recent versions of a few Linux distributions have started passing
500         --as-needed and --no-copy-dt-needed-entries by default to the linker,
501         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
502         needed a few symbols from libjavascriptcore_efl.so.
503
504         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
505         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
506         libraries are searched in the right order by the linker.
507
508 2012-01-16  Philippe Normand  <pnormand@igalia.com>
509
510         [GTK] set audio resources path in NRTW
511         https://bugs.webkit.org/show_bug.cgi?id=76380
512
513         Reviewed by Martin Robinson.
514
515         * Scripts/webkitpy/layout_tests/port/gtk.py:
516         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
517         the uninstalled audio resources are used during webaudio tests.
518
519 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
520
521         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
522         https://bugs.webkit.org/show_bug.cgi?id=76369
523
524         Reviewed by Xan Lopez.
525
526         If there's an installed version of webkit and there are new
527         symbols in the build tree, gtkdoc-scanobj fails due to undefined
528         references, because the env ldflags are given before the local
529         ones.
530
531         * gtk/gtkdoc.py:
532         (GTKDoc._run_gtkdoc_scangobj):
533
534 2012-01-15  Pablo Flouret  <pablof@motorola.com>
535
536         Fix compilation errors on build-webkit --debug --no-video on mac.
537         https://bugs.webkit.org/show_bug.cgi?id=75867
538
539         Reviewed by Philippe Normand.
540
541         Add --[no-]video-track to build-webkit, since video track feature
542         depends on video.
543
544         * Scripts/build-webkit:
545
546 2012-01-14  James Robinson  <jamesr@chromium.org>
547
548         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
549         https://bugs.webkit.org/show_bug.cgi?id=76313
550
551         Reviewed by Adam Barth.
552
553         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
554
555         * Scripts/run-chromium-webkit-unit-tests:
556
557 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
558
559         Unreviewed, rolling out r105017.
560         http://trac.webkit.org/changeset/105017
561         https://bugs.webkit.org/show_bug.cgi?id=76333
562
563         broke the build (Requested by philn-tp on #webkit).
564
565         * gtk/jhbuild.modules:
566
567 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
568
569         [GTK] Include gtk+3 in the jhbuild modules
570         https://bugs.webkit.org/show_bug.cgi?id=76284
571
572         Reviewed by Philippe Normand.
573
574         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
575
576 2012-01-13  Adam Barth  <abarth@webkit.org>
577
578         Remove --dry-run support from webkit-patch
579         https://bugs.webkit.org/show_bug.cgi?id=76300
580
581         Reviewed by Dirk Pranke.
582
583         This is the rest of the patch from Bug 76300.  I landed it separtely
584         because main.py had some stray conflict markers that I needed to clean
585         up first.
586
587         * Scripts/webkitpy/test/main.py:
588         (Tester.parse_args):
589         (Tester._run_tests):
590
591 2012-01-13  Adam Barth  <abarth@webkit.org>
592
593         test-webkitpy does not run
594         https://bugs.webkit.org/show_bug.cgi?id=76318
595
596         Unreviewed.
597
598         Looks like some conflict markers got left in the file.
599
600         * Scripts/webkitpy/test/main.py:
601         (Tester.run):
602
603 2012-01-13  Adam Barth  <abarth@webkit.org>
604
605         Remove --dry-run support from webkit-patch
606         https://bugs.webkit.org/show_bug.cgi?id=76300
607
608         Reviewed by Dirk Pranke.
609
610         We don't use this functionality for anything, and it doesn't really
611         work.  Someone in #webkit tried using it and and got sad/confused.  We
612         should just remove it.
613
614         * Scripts/webkitpy/common/checkout/scm/git.py:
615         (Git.push_local_commits_to_server):
616         * Scripts/webkitpy/common/checkout/scm/scm.py:
617         (SCM.__init__):
618         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
619         (_shared_test_commit_with_message):
620         (GitSVNTest.test_commit_text_parsing):
621         * Scripts/webkitpy/common/checkout/scm/svn.py:
622         (SVN.commit_with_message):
623         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
624         (Bugzilla.__init__):
625         (Bugzilla.quips):
626         (Bugzilla.authenticate):
627         (Bugzilla.add_attachment_to_bug):
628         (Bugzilla.add_patch_to_bug):
629         (Bugzilla.create_bug):
630         (Bugzilla.clear_attachment_flags):
631         (Bugzilla.set_flag_on_attachment):
632         (Bugzilla.obsolete_attachment):
633         (Bugzilla.add_cc_to_bug):
634         (Bugzilla.post_comment_to_bug):
635         (Bugzilla.close_bug_as_fixed):
636         (Bugzilla.reassign_bug):
637         (reopen_bug):
638         * Scripts/webkitpy/test/main.py:
639         (Tester.parse_args):
640         (Tester.run_tests):
641
642 2012-01-13  David Levin  <levin@chromium.org>
643
644         check-webkit-style: should encourage the use of Own* classes for Windows DC.
645         https://bugs.webkit.org/show_bug.cgi?id=76227
646
647         Reviewed by Dirk Pranke.
648
649         * Scripts/webkitpy/style/checkers/cpp.py:
650         (check_for_leaky_patterns): The new check.
651         (process_line): Added a call to the new check.
652         (CppChecker): Added the new error type.
653         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
654         (CppStyleTestBase):
655         (CppStyleTestBase.perform_leaky_pattern_check):
656         The check for only leaky pattern errors.
657         (LeakyPatternTest): Test cases.
658
659 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
660
661         test-webkitpy: clean up handling of test directories, QueueStatusServer
662         https://bugs.webkit.org/show_bug.cgi?id=76238
663
664         Reviewed by Adam Barth.
665
666         This patch cleans up a bunch of hacks related to how we find all
667         of the python unit tests and set up the sys.path variable in
668         test-webkitpy.
669
670         This patch changes how test-webkitpy works slightly in that we
671         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
672         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
673         This greatly simplifies the mapping of paths to module names and
674         appears to have no significant performance impact or other drawbacks.
675
676         There are other ways that we could remove all of the hacks and
677         still have a more flexible mapping of paths to module names, but
678         the ones I've thought of so far add a decent amount of complexity to
679         the implementation and don't seem to buy us much.
680         
681         * QueueStatusServer/__init__.py:
682         * Scripts/test-webkitpy:
683         * Scripts/webkitpy/test/main.py:
684         (Tester._modules_from_paths):
685         (Tester._is_module):
686
687 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
688
689         test-webkitpy: should support classes and individual test names as well as modules
690         https://bugs.webkit.org/show_bug.cgi?id=76233
691
692         Reviewed by Adam Barth.
693
694         The default unittest.main() supports a list of individual
695         TestCase classes or individual tests as well as modules. This
696         change adds support for the same to test-webkitpy, so now you
697         can say
698
699           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
700
701         and
702
703           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
704
705         in addition to
706
707           % test-wekbitpy webkitpy.test.cat_unittest
708
709         * Scripts/test-webkitpy:
710         * Scripts/webkitpy/test/cat_unittest.py:
711         * Scripts/webkitpy/test/main.py:
712         (Tester.parse_args):
713         (Tester.run):
714         (Tester):
715         (Tester._find_modules):
716         (Tester._exclude):
717         (Tester._run_tests):
718         (Tester._is_module):
719         (Tester._log_exception):
720
721 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
722
723         test-webkitpy: add basic code coverage support
724         https://bugs.webkit.org/show_bug.cgi?id=76201
725
726         Reviewed by Adam Barth.
727
728         This test adds basic code coverage support to test-webkitpy; if
729         you pass the -c flag, we will generate a new coverage file. We
730         can start simply with this and add more features as necessary.
731
732         This patch requires coverage to be already installed on the
733         machine. I am not auto-installing this for now.
734
735         * Scripts/webkitpy/test/main.py:
736         (Tester.parse_args):
737         (Tester.run_tests):
738
739 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
740
741         StatusBubbleTest.test_build_bubble is failing
742         https://bugs.webkit.org/show_bug.cgi?id=76222
743
744         Reviewed by Adam Barth.
745
746         * QueueStatusServer/handlers/statusbubble_unittest.py:
747         (StatusBubbleTest.test_build_bubble):
748
749 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
750
751         nrwt should use multiple http shards
752         https://bugs.webkit.org/show_bug.cgi?id=75958
753
754         Add --max-locked-shards option to the nrwt for manual set
755         the maximum number of the locked shards
756
757         Reviewed by Dirk Pranke.
758
759         * Scripts/webkitpy/layout_tests/controllers/manager.py:
760         (Manager._max_locked_shards):
761         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
762         (ShardingTests.get_shards):
763         (ShardingTests.test_multiple_locked_shards):
764         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
765         (parse_args):
766
767 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
768
769         prepare-ChangeLog: Look for a text editor in a few more variables.
770         https://bugs.webkit.org/show_bug.cgi?id=76289
771
772         Reviewed by Ryosuke Niwa.
773
774         A text editor was looked for only in the CHANGE_LOG_EDITOR and
775         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
776         to the OS X-specific open(1) command.
777
778         As there does not seem to be a common way of looking for a text editor
779         among the scripts in Tools/Scripts right now, just look at $VISUAL and
780         $EDITOR (set much more often than the other variables in Unix systems)
781         before falling back to open(1).
782
783         * Scripts/prepare-ChangeLog:
784         (openChangeLogs):
785
786 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
787
788         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
789         https://bugs.webkit.org/show_bug.cgi?id=76269
790
791         Reviewed by Martin Robinson.
792
793         * gtk/gtkdoc.py:
794         (GTKDoc._run_gtkdoc_scangobj):
795
796 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
797
798         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
799         https://bugs.webkit.org/show_bug.cgi?id=76247
800
801         Reviewed by Kenneth Rohde Christiansen.
802
803         * WebKitTestRunner/TestController.cpp:
804         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
805
806 2012-01-13  Hajime Morrita  <morrita@chromium.org>
807
808         [Mac][DRT] Should support --no-timeout
809         https://bugs.webkit.org/show_bug.cgi?id=76242
810
811         Reviewed by Darin Adler.
812
813         * DumpRenderTree/mac/DumpRenderTree.mm:
814         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
815         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
816         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
817         * DumpRenderTree/mac/DumpRenderTreeMac.h:
818         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
819         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
820
821 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
822
823         Mitigate scrollbar differences when running pixel tests
824         https://bugs.webkit.org/show_bug.cgi?id=67217
825
826         Reviewed by Dan Bernstein.
827         
828         Enable mock scrollbars by default for tests.
829
830         * DumpRenderTree/mac/DumpRenderTree.mm:
831         (resetDefaultsToConsistentValues):
832         * WebKitTestRunner/TestController.cpp:
833         (WTR::TestController::resetStateToConsistentValues):
834
835 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
836
837         Need a script to run tests in PerformanceTests
838         https://bugs.webkit.org/show_bug.cgi?id=76132
839
840         Reviewed by Adam Barth.
841
842         Add run-perf-tests to run performance tests using parser/resources/runner.js.
843         Unfortunately, there isn't an easy way of telling which test uses which format
844         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
845
846         All test outputs are re-formatted to match Chromium perf-bot style.
847
848         * Scripts/run-inspector-perf-tests.py:
849         * Scripts/run-perf-tests: Added.
850         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
851         (PerfTestsRunner):
852         (PerfTestsRunner.__init__):
853         (PerfTestsRunner._collect_tests):
854         (PerfTestsRunner.run):
855         (PerfTestsRunner._print_status):
856         (PerfTestsRunner._run_tests_set):
857         (PerfTestsRunner._process_chromium_style_test_result):
858         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
859         (PerfTestsRunner._process_parser_test_result):
860         (PerfTestsRunner._run_single_test):
861         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
862         (MainTest.TestDriver.run_test):
863         (create_runner):
864         (run_test):
865         (test_run_test_set):
866         (test_run_test_set_for_parser_tests):
867         (test_collect_tests):
868
869 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
870
871         webkitpy: clean up port unit tests in preparation for making port_name mandatory
872         https://bugs.webkit.org/show_bug.cgi?id=76123
873
874         Reviewed by Adam Barth.
875
876         This change updates the unit tests to be more consistent in how
877         ports are created, in preparation for making port_name a
878         mandatory parameter to the constructor and removing any version
879         interpretation from it.
880
881         There should be no functional changes in this patch, but some
882         tests that are no longer relevant have been removed or reworked.
883
884         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
885         (PortTest.test_get_option__default):
886         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
887         (ChromiumLinuxPortTest):
888         (ChromiumLinuxPortTest.assert_architecture):
889         (ChromiumLinuxPortTest.test_determine_architecture_fails):
890         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
891         (ChromiumMacPortTest):
892         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
893         (ChromiumPortTest):
894         (ChromiumPortTest.test_all_test_configurations):
895         (ChromiumPortTest.TestMacPort.__init__):
896         (ChromiumPortTest.TestLinuxPort.__init__):
897         (ChromiumPortTest.TestWinPort.__init__):
898         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
899         (ChromiumWinTest):
900         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
901         (EflPortTest):
902         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
903         (GtkPortTest):
904         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
905         (MacTest):
906         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
907         (MockDRTPortTest):
908         (MockDRTPortTest.make_port):
909         * Scripts/webkitpy/layout_tests/port/qt.py:
910         (QtPort._port_flag_for_scripts):
911         (QtPort.__init__):
912         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
913         (QtPortTest):
914         (QtPortTest._assert_search_path):
915         (QtPortTest.test_baseline_search_path):
916         (QtPortTest.test_operating_system):
917         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
918         (WebKitPortTest):
919         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
920         (WinPortTest):
921         (WinPortTest._assert_search_path):
922         (WinPortTest.test_baseline_search_path):
923         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
924         (get_test_config.TestMacPort.__init__):
925
926 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
927
928         test-webkitpy: clean up logging and provide a real --help message
929         https://bugs.webkit.org/show_bug.cgi?id=76142
930
931         Reviewed by Adam Barth.
932
933         This test is mostly more refactoring - it calls objects in
934         unittest directly instead of routing through unittest.main() --
935         in order to gain more control over the logging and to provide a
936         correct --help message. This will also give us a better
937         foundation for adding more feautures down the road.
938
939         This patch adds different levels of logging controlled by the
940         '-s', '-q', and '-v' options (see --help for details), and
941         removes the --verbose-logging option.
942
943         * Scripts/test-webkitpy:
944         * Scripts/webkitpy/test/main.py:
945         (Tester):
946         (Tester.clean_packages):
947         (Tester.__init__):
948         (Tester.parse_args):
949         (Tester.configure):
950         (Tester._configure_logging):
951         (Tester.find_modules):
952         (Tester._exclude):
953         (Tester._modules_from_paths):
954         (Tester.run_tests):
955
956 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
957
958         Make the new WTF module build on Qt
959         https://bugs.webkit.org/show_bug.cgi?id=76163
960
961         Reviewed by Tor Arne Vestbø.
962
963         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
964
965 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
966
967         Unreviewed, mac DumpRenderTree fix.
968
969         * DumpRenderTree/mac/UIDelegate.mm:
970         (-[UIDelegate webView:addMessageToConsole:withSource:]):
971
972 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
973
974         WebKitTestRunner should not print console message line number when it is equal to zero.
975         https://bugs.webkit.org/show_bug.cgi?id=76167
976
977         Reviewed by Csaba Osztrogonác.
978
979         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
980         (WTR::InjectedBundlePage::willAddMessageToConsole):
981
982 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
983
984         Make default console messages line numbers consistent.
985         https://bugs.webkit.org/show_bug.cgi?id=74075
986
987         Reviewed by Pavel Feldman.
988
989         Unset line numbers are not printed to console now.
990         Added Source/WebCore/inspector to efl DumpRenderTree include path.
991
992         * DumpRenderTree/chromium/WebViewHost.cpp:
993         (WebViewHost::didAddMessageToConsole):
994         * DumpRenderTree/efl/CMakeLists.txt:
995         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
996         (onConsoleMessage):
997         * DumpRenderTree/gtk/DumpRenderTree.cpp:
998         (webViewConsoleMessage):
999         * DumpRenderTree/mac/UIDelegate.mm:
1000         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1001         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1002         (WebCore::WebPage::javaScriptConsoleMessage):
1003         * DumpRenderTree/win/UIDelegate.cpp:
1004         (UIDelegate::webViewAddMessageToConsole):
1005         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1006         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1007
1008 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1009
1010         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1011         https://bugs.webkit.org/show_bug.cgi?id=76021
1012
1013         Reviewed by Eric Seidel.
1014
1015         I plan to add more functionality to test-webkitpy, but it is
1016         difficult to hack on now; this patch is the first of two that
1017         brings test-webkitpy more inline with current coding style by
1018         pushing more logic into the webkitpy.test.main.Tester class (so
1019         that it will be testable itself).
1020         
1021         There should be no functional changes in this patch.
1022
1023         * Scripts/test-webkitpy:
1024         (_path_from_webkit_root):
1025         * Scripts/webkitpy/test/main.py:
1026         (Tester):
1027         (Tester.init):
1028         (Tester.configure_logging):
1029         (Tester.configure_logging.filter):
1030         (Tester.clean_packages):
1031         (Tester.run_tests):
1032
1033 2012-01-11  Wei Jia  <wjia@chromium.org>
1034
1035         implement layout tests for <video> with media stream
1036         https://bugs.webkit.org/show_bug.cgi?id=74882
1037
1038         Reviewed by Kent Tamura.
1039
1040         * DumpRenderTree/DumpRenderTree.gypi:
1041         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1042         (WebKit::WebUserMediaClientMock::create):
1043         (WebKit::WebUserMediaClientMock::IsMockStream):
1044         (WebKit::WebUserMediaClientMock::requestUserMedia):
1045         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1046         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1047         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1048         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1049         * DumpRenderTree/chromium/WebViewHost.cpp:
1050         (WebViewHost::userMediaClient):
1051         (WebViewHost::userMediaClientMock):
1052         (WebViewHost::createMediaPlayer):
1053         (WebViewHost::mediaStreamUtil):
1054         (WebViewHost::testMediaStreamClient):
1055         * DumpRenderTree/chromium/WebViewHost.h:
1056
1057 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1058
1059         Unreviewed, build fix.
1060
1061         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1062
1063         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1064         (ChromiumWinPort.__init__):
1065
1066 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1067
1068         Sheriffbot build fix. Don't emit empty lines on IRC.
1069
1070         * Scripts/webkitpy/tool/bot/irc_command.py:
1071         (LastGreenRevision.execute):
1072
1073 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1074
1075         last-green-revision should report the revision that succeeded on all bots
1076         https://bugs.webkit.org/show_bug.cgi?id=76109
1077
1078         Reviewed by Adam Barth.
1079
1080         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1081         considered green by this algorithm, all matching builders must have a successful run at the revision
1082         or two consecutive successful runs before and after the revision.
1083
1084         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1085         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1086
1087         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1088         (BuildBot._revisions_for_builder):
1089         (BuildBot):
1090         (BuildBot._find_green_revision):
1091         (BuildBot.last_green_revision):
1092         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1093         (MockBuildBot.last_green_revision):
1094         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1095         (test_revisions_for_builder):
1096         (test_find_green_revision):
1097         (test_last_green_revision):
1098         * Scripts/webkitpy/tool/bot/irc_command.py:
1099         (LastGreenRevision.execute):
1100         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1101         (SheriffIRCBotTest.test_lgr):
1102         * Scripts/webkitpy/tool/commands/queries.py:
1103         (LastGreenRevision):
1104
1105 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1106
1107         Unreviewed, fix build bustage on win32 introduced by r104725.
1108
1109         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1110         (MockDRTPortTest.make_port):
1111         (MockChromiumDRTTest.test_pixeltest__fails):
1112
1113 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1114
1115         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1116         https://bugs.webkit.org/show_bug.cgi?id=75618
1117
1118         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1119
1120         Reviewed by Tony Chang.
1121
1122         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1123         (installLayoutTestColorProfile):
1124         (restoreUserColorProfile):
1125         (main):
1126
1127 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1128
1129         test-webkitpy: fix -v and eliminate some spurious warnings
1130         https://bugs.webkit.org/show_bug.cgi?id=76099
1131
1132         Reviewed by Adam Barth.
1133
1134         when we added support for --xml output, we broke the -v flag.
1135
1136         Also, fix the code to swallow a harmless warning from
1137         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1138
1139         test-webkitpy is now silent again except for the one known
1140         logging issue.
1141
1142         * Scripts/webkitpy/common/checkout/checkout.py:
1143         (Checkout.commit_message_for_this_commit):
1144         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1145         (test_commit_message_for_this_commit):
1146         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1147         (JSONChecker.check):
1148         (JSONChecker.line_number_from_json_exception):
1149         * Scripts/webkitpy/test/main.py:
1150         (Tester.run_tests):
1151
1152 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1153
1154         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1155         https://bugs.webkit.org/show_bug.cgi?id=76084
1156
1157         Reviewed by Adam Barth.
1158
1159         This will help make it easier to catch layering violations. This
1160         change just refactors test code; there are no changes to
1161         production code.
1162
1163         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1164         (PortTest.make_port):
1165         (PortTest.test_find_no_paths_specified):
1166         (PortTest.test_find_one_test):
1167         (PortTest.test_find_glob):
1168         (PortTest.test_find_with_skipped_directories):
1169         (PortTest.test_find_with_skipped_directories_2):
1170         (PortTest.test_parse_reftest_list):
1171         (PortTest.test_httpd_returns_error_code):
1172         (PortTest.test_virtual_methods):
1173         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1174         (ChromiumGpuTest.assert_port_works):
1175         (ChromiumGpuTest._assert_baseline_path):
1176         (ChromiumGpuTest.test_graphics_type):
1177         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1178         (ChromiumGpuTest.test_test_files):
1179         (ChromiumGpuTest.test_test_files.test_paths):
1180         (ChromiumGpuTest):
1181         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1182         (ChromiumLinuxPortTest.assert_architecture):
1183         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1184         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1185         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1186         (DriverTest.make_port):
1187         (DriverTest):
1188         (DriverTest.assertVirtual):
1189         (DriverTest._assert_wrapper):
1190         (DriverTest.test_virtual_driver_methods):
1191         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1192         (MockDRTPortTest.make_port):
1193         (MockDRTPortTest.test_port_name_in_constructor):
1194         (MockDRTTest.assertTest):
1195         (MockDRTTest.test_main):
1196         (MockChromiumDRTTest.test_pixeltest__fails):
1197         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1198         (QtPortTest._assert_search_path):
1199         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1200         (TestWebKitPort.__init__):
1201         (WebKitPortUnitTests.test_default_options):
1202         (test_runtime_feature_list):
1203         (test_test_expectations):
1204
1205 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1206
1207         Style skipped tests in the flakiness dashboard
1208         https://bugs.webkit.org/show_bug.cgi?id=76091
1209
1210         Reviewed by Tony Chang.
1211
1212         * TestResultServer/static-dashboards/dashboard_base.js:
1213         Removed "FLAKY" from this list since we don't ever mark individual runs
1214         as flaky. Also deleted an outdated line.
1215         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1216
1217 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1218
1219         Remove gtest normalization code from the test results server
1220         https://bugs.webkit.org/show_bug.cgi?id=76089
1221
1222         Reviewed by Tony Chang.
1223
1224         The normalization now happens on the gtest side.
1225
1226         * TestResultServer/model/jsonresults.py:
1227         (JsonResults.merge):
1228         * TestResultServer/model/jsonresults_unittest.py:
1229         (JsonResultsTest.test_gtest):
1230
1231 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1232
1233         Be more aggressive about deleting unnecessary results from the test-results-server json files
1234         https://bugs.webkit.org/show_bug.cgi?id=76086
1235
1236         Reviewed by Tony Chang.
1237
1238         Remove any tests that only contain skip/pass/nodata values whose runtime
1239         is less than 5 seconds.
1240
1241         * TestResultServer/model/jsonresults.py:
1242         (JsonResults._normalize_results_json):
1243         * TestResultServer/model/jsonresults_unittest.py:
1244         (JsonResultsTest.test_merge_remove_test):
1245         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
1246
1247 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1248
1249         last-green-revision should give us per-bot information
1250         https://bugs.webkit.org/show_bug.cgi?id=76011
1251
1252         Reviewed by Adam Barth.
1253
1254         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
1255         we report the latest green run on each bot from the last 100 runs.
1256
1257         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1258         (BuildBot._fetch_builder_page):
1259         (BuildBot):
1260         (BuildBot._green_revision_for_builder):
1261         (BuildBot.last_green_revision):
1262         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1263         (test_green_revision_for_builder):
1264         (test_last_green_revision):
1265         * Scripts/webkitpy/tool/bot/irc_command.py:
1266         (LastGreenRevision.execute):
1267         * Scripts/webkitpy/tool/commands/queries.py:
1268         (LastGreenRevision.execute):
1269
1270 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1271
1272         webkitpy: clean up version detection in webkitpy.layout_tests.port
1273         https://bugs.webkit.org/show_bug.cgi?id=76016
1274
1275         Reviewed by Adam Barth.
1276
1277         This change updates the code in webkitpy.layout_tests.port to
1278         use the new os_name and os_version fields on host.platform. This
1279         gets layout_tests.port out of the version parsing business. Most
1280         of the diffs are just cleaning up test code to accomodate the
1281         changes.
1282
1283         * Scripts/webkitpy/common/system/executive_mock.py:
1284         (MockExecutive):
1285         (MockExecutive.ignore_error):
1286         (MockExecutive2):
1287         (MockExecutive2.ignore_error):
1288         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1289         (MockPlatformInfo.is_mac):
1290         (MockPlatformInfo.is_linux):
1291         (MockPlatformInfo.is_win):
1292         * Scripts/webkitpy/common/system/systemhost_mock.py:
1293         (MockSystemHost.__init__):
1294         * Scripts/webkitpy/layout_tests/port/apple.py:
1295         (ApplePort.__init__):
1296         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1297         (ChromiumMacPort.__init__):
1298         (ChromiumMacPort.check_wdiff):
1299         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1300         (ChromiumMacPortTest):
1301         (ChromiumMacPortTest.assert_name):
1302         (ChromiumMacPortTest.test_versions):
1303         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1304         (ChromiumPortTest.test_all_test_configurations):
1305         (ChromiumPortTest.TestMacPort.__init__):
1306         (ChromiumPortTest.TestLinuxPort.__init__):
1307         (ChromiumPortTest.TestWinPort.__init__):
1308         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1309         (ChromiumWinPort.__init__):
1310         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1311         (ChromiumWinTest):
1312         (ChromiumWinTest.assert_name):
1313         (ChromiumWinTest.test_versions):
1314         (ChromiumWinTest.test_baseline_path):
1315         (ChromiumWinTest.test_build_path):
1316         * Scripts/webkitpy/layout_tests/port/factory.py:
1317         (PortFactory._port_name_from_arguments_and_options):
1318         (PortFactory.get):
1319         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1320         (FactoryTest):
1321         (FactoryTest.setUp):
1322         (FactoryTest.assert_port):
1323         (FactoryTest.test_mac):
1324         (FactoryTest.test_win):
1325         (FactoryTest.test_google_chrome):
1326         (FactoryTest.test_gtk):
1327         (FactoryTest.test_qt):
1328         (FactoryTest.test_chromium_gpu):
1329         (FactoryTest.test_chromium_gpu_linux):
1330         (FactoryTest.test_chromium_gpu_mac):
1331         (FactoryTest.test_chromium_gpu_win):
1332         (FactoryTest.test_chromium_mac):
1333         (FactoryTest.test_chromium_linux):
1334         (FactoryTest.test_chromium_win):
1335         (FactoryTest.test_unknown_specified):
1336         (FactoryTest.test_unknown_default):
1337         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1338         (TestGoogleChromePort):
1339         (TestGoogleChromePort._verify_baseline_path):
1340         (TestGoogleChromePort._verify_expectations_overrides):
1341         (TestGoogleChromePort.test_get_google_chrome_port):
1342         * Scripts/webkitpy/layout_tests/port/mac.py:
1343         (MacPort):
1344         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1345         (MacTest):
1346         (assert_name):
1347         (test_tests_for_other_platforms):
1348         (test_version):
1349         (test_versions):
1350         (test_is_version_methods):
1351         (test_setup_environ_for_server):
1352         (_assert_search_path):
1353         (test_show_results_html_file):
1354         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1355         (PortTestCase):
1356         (PortTestCase.make_port):
1357         * Scripts/webkitpy/layout_tests/port/win.py:
1358         (WinPort):
1359         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1360         (WinPortTest):
1361         (WinPortTest.test_show_results_html_file):
1362         (WinPortTest._assert_search_path):
1363         (WinPortTest._assert_version):
1364
1365 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
1366
1367         [Qt][WK2] Remove workaround introduced into bug 75470
1368         https://bugs.webkit.org/show_bug.cgi?id=75889
1369
1370         Reviewed by Tor Arne Vestbø.
1371
1372         * MiniBrowser/qt/qml/BrowserWindow.qml:
1373
1374 2012-01-10  Dmitry Lomov  <dslomov@google.com>
1375
1376         [Chromium] Remove obsolete references to WebWorker class.
1377         https://bugs.webkit.org/show_bug.cgi?id=76020
1378
1379         Reviewed by David Levin.
1380
1381         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
1382         * DumpRenderTree/chromium/WebViewHost.cpp:
1383         * DumpRenderTree/chromium/WebViewHost.h:
1384
1385 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1386
1387         [Qt] Some css3 filter tests are failing after r104698
1388         https://bugs.webkit.org/show_bug.cgi?id=76055
1389
1390         Reviewed by Simon Hausmann.
1391
1392         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1393         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
1394
1395 2012-01-11  Tony Chang  <tony@chromium.org>
1396
1397         Don't remove 0 byte files when running build-webkit --chromium
1398         https://bugs.webkit.org/show_bug.cgi?id=75997
1399
1400         Reviewed by Csaba Osztrogonác.
1401
1402         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
1403
1404         * Scripts/webkitdirs.pm:
1405         (determineIsQt):
1406
1407 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1408
1409         Add TestWebKitAPI tests for KURL
1410         <http://webkit.org/b/75774>
1411
1412         Reviewed by Adam Barth.
1413
1414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
1415         WebCore folder and KURL.cpp source file to the project.
1416         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
1417         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
1418         during setup since this test doesn't go through WebKit or
1419         WebKit2.
1420         (TestWebKitAPI::TEST_F): Add two basic tests.
1421
1422 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1423
1424         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
1425
1426         Reviewed by Adam Barth.
1427
1428         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
1429
1430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1431         WTFStringUtilities.h to the project.
1432         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
1433         WTFStringUtilities.h.
1434         * TestWebKitAPI/WTFStringUtilities.h: Added.
1435         (WTF::operator<<):
1436
1437 2012-01-10  Vincent Scheib  <scheib@chromium.org>
1438
1439         Clarify run-webkit-tests options reset-results and new-baseline
1440         https://bugs.webkit.org/show_bug.cgi?id=75993
1441
1442         Reviewed by Dirk Pranke.
1443
1444         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1445         (parse_args):
1446
1447 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
1448
1449         Disabled mock scrollbars should draw differently
1450         https://bugs.webkit.org/show_bug.cgi?id=75995
1451
1452         Reviewed by James Robinson.
1453
1454         When the scrollbar is disabled, paint the entire track of
1455         mock scrollbars with a lighter gray, and hide the thumb.
1456
1457         * DumpRenderTree/mac/DumpRenderTree.mm:
1458         (-[DRTMockScroller drawKnob]):
1459         (-[DRTMockScroller drawRect:]):
1460
1461 2012-01-10  James Robinson  <jamesr@chromium.org>
1462
1463         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
1464         https://bugs.webkit.org/show_bug.cgi?id=75988
1465
1466         Reviewed by Adam Barth.
1467
1468         * Scripts/webkitpy/common/config/ports.py:
1469         (WebKitPort.run_webkit_unit_tests_command):
1470         (WebKitPort):
1471         (ChromiumPort.run_webkit_unit_tests_command):
1472         (ChromiumPort):
1473         * Scripts/webkitpy/common/config/ports_mock.py:
1474         (MockPort.run_webkit_unit_tests_command):
1475         * Scripts/webkitpy/tool/commands/download_unittest.py:
1476         (DownloadCommandsTest.test_build_and_test):
1477         (test_land):
1478         (test_land_red_builders):
1479         * Scripts/webkitpy/tool/steps/runtests.py:
1480         (RunTests.run):
1481         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1482
1483 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1484
1485         webkitpy: add os_name, os_version to platforminfo
1486         https://bugs.webkit.org/show_bug.cgi?id=75931
1487
1488         Reviewed by Eric Siedel.
1489
1490         As a first step in cleaning up the version parsing logic in
1491         webkitpy.layout_tests.port, this adds common routines for
1492         getting the os_name and os_version fields to the PlatformInfo
1493         class. Nothing uses them yet but I've added FIXME's to some of
1494         the code that needs to be deleted in the port files.
1495
1496         * Scripts/webkitpy/common/system/platforminfo.py:
1497         (PlatformInfo.__init__):
1498         (PlatformInfo):
1499         (PlatformInfo._determine_os_name):
1500         (PlatformInfo._determine_mac_version):
1501         (PlatformInfo._determine_linux_version):
1502         (PlatformInfo._determine_win_version):
1503         (PlatformInfo.display_name):
1504         (PlatformInfo.total_bytes_memory):
1505         (PlatformInfo._compute_bytes_from_vm_stat_output):
1506         (PlatformInfo.free_bytes_memory):
1507         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
1508         (TestPlatformInfo):
1509         (TestPlatformInfo.make_info):
1510         (TestPlatformInfo.make_info.mock_run_command):
1511         (TestPlatformInfo.setUp):
1512         (TestPlatformInfo.tearDown):
1513         (TestPlatformInfo.test_basic):
1514         (TestPlatformInfo.integration_test_basic):
1515         (TestPlatformInfo.test_display_name_mac):
1516         (TestPlatformInfo.test_display_name_win32):
1517         (TestPlatformInfo.test_memory_mac):
1518         (TestPlatformInfo.test_memory_win32):
1519         (TestPlatformInfo.test_determine_os_name):
1520         (TestPlatformInfo.test_determine_mac_version):
1521         (TestPlatformInfo.test_determine_linux_version):
1522         (TestPlatformInfo.test_determine_win_version_from_tuple):
1523         (TestPlatformInfo.test_determine_win_version_from_cmd):
1524         * Scripts/webkitpy/layout_tests/port/apple.py:
1525         (ApplePort.__init__):
1526         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1527         (ChromiumMacPort.__init__):
1528         * Scripts/webkitpy/layout_tests/port/mac.py:
1529         (MacPort):
1530         * Scripts/webkitpy/layout_tests/port/win.py:
1531         (WinPort):
1532
1533 2012-01-10  Adam Roben  <aroben@apple.com>
1534
1535         Make it possible to type data: URLs into MiniBrowser on Windows
1536
1537         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
1538         MiniBrowser on Windows
1539
1540         Reviewed by Darin Adler.
1541
1542         * MiniBrowser/win/BrowserWindow.cpp:
1543         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
1544         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
1545         does, we assume it already has a scheme and don't modify it.
1546
1547 2012-01-10  Adam Roben  <aroben@apple.com>
1548
1549         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
1550
1551         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
1552         MiniBrowser on Windows
1553
1554         Reviewed by Darin Adler.
1555
1556         * MiniBrowser/win/BrowserView.cpp:
1557         (BrowserView::goToURL): Pass the typed string through
1558         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
1559
1560 2012-01-10  Ben Wells  <benwells@chromium.org>
1561
1562         Adding myself (benwells) to committers.py
1563         https://bugs.webkit.org/show_bug.cgi?id=75971
1564
1565         Reviewed by Ojan Vafai.
1566
1567         * Scripts/webkitpy/common/config/committers.py:
1568
1569 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
1570
1571         AX: support helpText() in DumpRenderTree
1572         https://bugs.webkit.org/show_bug.cgi?id=40193
1573
1574         Reviewed by Chris Fleizach.
1575
1576         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1577         (AccessibilityUIElement::helpText): Implemented.
1578
1579 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1580
1581         Unreviewed, rolling out r104572.
1582         http://trac.webkit.org/changeset/104572
1583         https://bugs.webkit.org/show_bug.cgi?id=75967
1584
1585         It broke zillion tests (Requested by Ossy on #webkit).
1586
1587         * DumpRenderTree/qt/EventSenderQt.cpp:
1588         (EventSender::EventSender):
1589         (EventSender::sendOrQueueEvent):
1590         (EventSender::replaySavedEvents):
1591         (EventSender::eventFilter):
1592         * DumpRenderTree/qt/EventSenderQt.h:
1593
1594 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
1595
1596         [Qt] fast/events/dont-loose-last-event test fails on WK1
1597         https://bugs.webkit.org/show_bug.cgi?id=73894
1598
1599         Reviewed by Simon Hausmann.
1600
1601         Empty the entire event queue when requested besides using
1602         sendEvent instead of postEvent to make sure all events were
1603         delivered.
1604         This commit also removes not working DRT code to handle drag and drop,
1605         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
1606
1607         * DumpRenderTree/qt/EventSenderQt.cpp:
1608         (EventSender::EventSender):
1609         (EventSender::sendOrQueueEvent):
1610         (EventSender::replaySavedEvents):
1611         * DumpRenderTree/qt/EventSenderQt.h:
1612
1613 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1614
1615         [Qt] Enable CSS_FILTERS in Qt build
1616         https://bugs.webkit.org/show_bug.cgi?id=75777
1617
1618         Add the CSS_FILTERS feature flag to Qt.
1619
1620         Reviewed by Kenneth Rohde Christiansen.
1621
1622         * qmake/mkspecs/features/features.prf:
1623
1624 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1625
1626         [Qt] Unreviewed -Werror build fix.
1627
1628         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1629         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
1630         declaration.
1631
1632 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1633
1634         [Qt] Remove dependency to uitools
1635         https://bugs.webkit.org/show_bug.cgi?id=75952
1636
1637         Reviewed by Tor Arne Vestbø.
1638
1639         QUiLoader is used for creating QLabel/QProgressBar widgets for
1640         a layout test, to verify some widget embedding feature. Unfortunately
1641         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
1642         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
1643         let's break the circular dependency.
1644
1645         * DumpRenderTree/qt/DumpRenderTree.pro:
1646         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1647         (WebCore::WebPage::createPlugin):
1648         * QtTestBrowser/QtTestBrowser.pro:
1649         * QtTestBrowser/launcherwindow.h:
1650         * QtTestBrowser/webpage.cpp:
1651         (WebPage::createPlugin):
1652         * qmake/mkspecs/features/minimal_qt.prf:
1653         * qmake/mkspecs/features/uitools.prf: Removed.
1654
1655 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
1656
1657         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
1658         https://bugs.webkit.org/show_bug.cgi?id=75894
1659
1660         Reviewed by Tor Arne Vestbø.
1661
1662         * MiniBrowser/qt/MiniBrowserApplication.h:
1663         (MiniBrowserApplication::windowOptions):
1664         * MiniBrowser/qt/main.cpp:
1665         (main):
1666
1667 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1668
1669         [Qt] DRT crashes with Qt 5
1670         https://bugs.webkit.org/show_bug.cgi?id=75951
1671
1672         Reviewed by Ossy.
1673
1674         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
1675         Qt relies on font-config to define the default font family.
1676
1677 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
1678
1679         [Qt] REGRESSION(r100130): Clean build feature is broken.
1680         https://bugs.webkit.org/show_bug.cgi?id=75863
1681
1682         Reviewed by Tor Arne Vestbø.
1683
1684         * Scripts/webkitdirs.pm:
1685         (buildQMakeProject):
1686
1687 2012-01-10  Zeno Albisser  <zeno@webkit.org>
1688
1689         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
1690         https://bugs.webkit.org/show_bug.cgi?id=75885
1691
1692         In QML events are propagated through parents. But since the
1693         WebView may consume key events, a shortcut might never reach
1694         the top QtQuickItem.
1695         Therefore an application wide event handling function in C++
1696         needs to take care of shortcuts for MiniBrowser.
1697
1698         Reviewed by Kenneth Rohde Christiansen.
1699
1700         * MiniBrowser/qt/BrowserWindow.cpp:
1701         (BrowserWindow::reload):
1702         (BrowserWindow::focusAddressBar):
1703         * MiniBrowser/qt/BrowserWindow.h:
1704         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1705         (MiniBrowserApplication::notify):
1706         * MiniBrowser/qt/qml/BrowserWindow.qml:
1707
1708 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1709
1710         Add --efl alias for --platform=efl to run-webkit-test
1711         https://bugs.webkit.org/show_bug.cgi?id=75937
1712
1713         Reviewed by Andreas Kling.
1714         
1715         * Scripts/run-webkit-tests: Add --efl alias.
1716         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
1717         (parse_args):
1718
1719 2012-01-09  Dan Bernstein  <mitz@apple.com>
1720
1721         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
1722         https://bugs.webkit.org/show_bug.cgi?id=75920
1723
1724         Reviewed by Darin Adler.
1725
1726         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
1727         (TestWebKitAPI::TEST): Added a test for a range in a
1728         -webkit-user-select: none; block.
1729
1730 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1731
1732         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
1733         https://bugs.webkit.org/show_bug.cgi?id=75884
1734
1735         Reviewed by Ryosuke Niwa.
1736
1737         Fix regression introduced (revealed?) in r104340. Chromium file         
1738         url syntax is different on win32 and the test results weren't           
1739         expecting that.                                                         
1740
1741         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1742         (TestExpectations._report_errors):
1743         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1744         (test_parse_error_nonfatal):
1745         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1746         (MockDRTTest.input_line):
1747         (MockChromiumDRTTest.test_pixeltest__fails):
1748         * Scripts/webkitpy/layout_tests/port/test.py:
1749         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1750         (TestRebaseliner.make_rebaseliner):
1751         (TestRebaseliner.test_one_platform):
1752         (TestRebaseliner.test_all_platforms):
1753         (TestRebaseliner.test_png_file_with_comment):
1754         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
1755         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
1756         (TestRealMain.test_all_platforms):
1757
1758 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1759
1760         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
1761
1762         Unreviewed, build fix.
1763
1764         test-webkitpy had a built-in self-test routine to verify that
1765         deleting the .pyc files worked correctly. When I removed the
1766         python24 directory in r104482, I broke the self-test.
1767
1768         I have deleted the self-test for now. Since I am reworking
1769         test-webkitpy I will make sure the new version is adequately
1770         tested.
1771
1772         * Scripts/test-webkitpy:
1773         (configure_logging):
1774         (_clean_pyc_files):
1775         (_clean_packages):
1776         (init):
1777
1778 2012-01-09  Justin Novosad  <junov@chromium.org>
1779
1780         [Chromium] remove all references to the legacy accelerated 2d Canvas
1781         implementation
1782         https://bugs.webkit.org/show_bug.cgi?id=75108
1783
1784         Purging an old settings flag that is no longer referenced
1785
1786         Reviewed by Darin Fisher.
1787
1788         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1789         (main):
1790         * DumpRenderTree/chromium/TestShell.cpp:
1791         (TestShell::TestShell):
1792         (TestShell::resetWebSettings):
1793         * DumpRenderTree/chromium/TestShell.h:
1794         (TestShell::setAccelerated2dCanvasEnabled):
1795         * DumpRenderTree/chromium/WebPreferences.cpp:
1796         (WebPreferences::reset):
1797         (WebPreferences::applyTo):
1798         * DumpRenderTree/chromium/WebPreferences.h:
1799
1800 2012-01-09  Adam Roben  <aroben@apple.com>
1801
1802         Convert Cygwin paths to Windows paths before passing them to DRT
1803
1804         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
1805         NRWT
1806
1807         I couldn't find a way to test this because I couldn't figure out how to override the
1808         cygpath function as it is used by WebKitDriver.
1809
1810         Reviewed by Dirk Pranke.
1811
1812         * Scripts/webkitpy/layout_tests/port/webkit.py:
1813         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
1814         Windows-style path before passing it to DRT.
1815
1816 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
1817
1818         webkitpy: revamp version checking
1819         https://bugs.webkit.org/show_bug.cgi?id=75765
1820
1821         Reviewed by Adam Barth.
1822
1823         The version-checking code in webkitpy/python24/versioning seems really
1824         awkward and overdesigned, especially since we don't support python 2.4
1825         any more.
1826
1827         In addition, I am tired of getting warnings about Python 2.6 being "a
1828         newer release than what is supported" :).
1829
1830         I'm taking a page from the depot_tools python code and just creating a
1831         new webkitpy.common.version_check module that will print a message on
1832         stderr and call sys.exit() if we're running an unsupported version.
1833
1834         * Scripts/check-webkit-style:
1835         * Scripts/new-run-webkit-httpd:
1836         * Scripts/new-run-webkit-tests:
1837         * Scripts/rebaseline-chromium-webkit-tests:
1838         * Scripts/test-webkitpy:
1839         (configure_logging):
1840         (init):
1841         * Scripts/webkit-patch:
1842         (main):
1843         * Scripts/webkitpy/common/system/executive.py:
1844         (Executive._child_process_encoding):
1845         (Executive._should_encode_child_process_arguments):
1846         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
1847         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1848         * Scripts/webkitpy/python24/__init__.py: Removed.
1849         * Scripts/webkitpy/python24/versioning.py: Removed.
1850         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
1851
1852 2012-01-09  Adam Barth  <abarth@webkit.org>
1853
1854         Remove Chromium Mac CG from the flakiness dashboard
1855         https://bugs.webkit.org/show_bug.cgi?id=75873
1856
1857         Reviewed by Ojan Vafai.
1858
1859         This configuration no longer exists.
1860
1861         * TestResultServer/static-dashboards/builders.js:
1862         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1863         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1864         (testOverrideJustBuildType):
1865         (testPlatformAndBuildType):
1866
1867 2012-01-06  Adam Roben  <aroben@apple.com>
1868
1869         Print an error message when NRWT can't run Apache
1870
1871         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
1872
1873         Reviewed by Dirk Pranke.
1874
1875         * Scripts/webkitpy/layout_tests/port/base.py:
1876         (Port.check_httpd): Print an error message when Apache returns an error code instead of
1877         failing silently.
1878
1879         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1880         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
1881         run Apache.
1882         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
1883         fails.
1884
1885 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
1886
1887         [Gtk][ARM] Cross compiler buildbot is failing after r103040
1888         https://bugs.webkit.org/show_bug.cgi?id=75846
1889
1890         Reviewed by Philippe Normand.
1891
1892         * Scripts/webkitdirs.pm:
1893         (runAutogenForAutotoolsProjectIfNecessary):
1894
1895 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
1896
1897         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
1898         https://bugs.webkit.org/show_bug.cgi?id=75807
1899
1900         This patch adds a new icon to navigationbar of the Qt MiniBrowser
1901         which allows you to dynamically toggle whether touch mocking is
1902         enabled or disabled.
1903
1904         Reviewed by Tor Arne Vestbø.
1905
1906         * MiniBrowser/qt/MiniBrowser.qrc:
1907         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1908         (MiniBrowserApplication::notify):
1909         * MiniBrowser/qt/MiniBrowserApplication.h:
1910         (WindowOptions::WindowOptions):
1911         (WindowOptions::touchMockingEnabled):
1912         (WindowOptions::setTouchMockingEnabled):
1913         * MiniBrowser/qt/icons/touch.png: Added.
1914         * MiniBrowser/qt/qml/BrowserWindow.qml:
1915
1916 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1917
1918         Unreviewed. Fix make distcheck issues.
1919
1920         * MiniBrowser/gtk/GNUmakefile.am:
1921
1922 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1923
1924         Unreviewed, rolling out r104421.
1925         http://trac.webkit.org/changeset/104421
1926         https://bugs.webkit.org/show_bug.cgi?id=75816
1927
1928         Need to rebaseline some tests on Linux (Requested by noamr on
1929         #webkit).
1930
1931         * qmake/mkspecs/features/features.prf:
1932
1933 2012-01-08  Adam Barth  <abarth@webkit.org>
1934
1935         Remove support for Chromium Mac CG from garden-o-matic
1936         https://bugs.webkit.org/show_bug.cgi?id=75814
1937
1938         Reviewed by Eric Seidel.
1939
1940         This configuration no longer exists.  This patch is mostly a matter of
1941         updating config.js and removing the examples from the unit tests.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1948
1949 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1950
1951         [Qt] Enable CSS_FILTERS in Qt build
1952         https://bugs.webkit.org/show_bug.cgi?id=75777
1953
1954         Add the CSS_FILTERS feature flag to Qt.
1955
1956         Reviewed by Kenneth Rohde Christiansen.
1957
1958         * qmake/mkspecs/features/features.prf:
1959
1960 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1961
1962         Categorize bots by ports instead of core/non-core separation
1963         https://bugs.webkit.org/show_bug.cgi?id=75766
1964
1965         Reviewed by Eric Seidel.
1966
1967         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
1968         (Chromium still comes before GTK and Qt).
1969
1970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1971         (loadBuilderConfig):
1972         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1973
1974 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1975
1976         Remove the concept of core builders from webkitpy
1977         https://bugs.webkit.org/show_bug.cgi?id=75809
1978
1979         Reviewed by Ryosuke Niwa.
1980
1981         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
1982         and remove the relevant code.
1983
1984         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1985         (BuildBot.__init__):
1986         (BuildBot._matches_regexps):
1987         (BuildBot._builder_statuses_with_names_matching_regexps):
1988         (BuildBot.builder_statuses):
1989         (BuildBot.failure_map):
1990         (BuildBot._latest_builds_from_builders):
1991         (BuildBot.last_green_revision):
1992         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1993         (MockBuildBot.builder_statuses):
1994         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1995         (test_status_parsing):
1996         (test_last_green_revision):
1997         (test_last_green_revision.mock_builds_from_builders):
1998
1999 2012-01-08  Adam Barth  <abarth@webkit.org>
2000
2001         Remove Chromium Mac CG concept from webkitpy
2002         https://bugs.webkit.org/show_bug.cgi?id=75810
2003
2004         Reviewed by Ryosuke Niwa.
2005
2006         This configuration no longer exists.  We can remove all the supporting
2007         code from webkitpy.
2008
2009         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2010         (BaselineOptimizerTest.test_move_baselines):
2011         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2012         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2013         (BaselineOptimizerTest.test_common_directory_includes_root):
2014         (BaselineOptimizerTest.test_complex_shadowing):
2015         * Scripts/webkitpy/common/config/build.py:
2016         (_should_file_trigger_build):
2017         * Scripts/webkitpy/common/config/build_unittest.py:
2018         (ShouldBuildTest):
2019         * Scripts/webkitpy/layout_tests/port/builders.py:
2020         * Scripts/webkitpy/layout_tests/port/chromium.py:
2021         (ChromiumPort):
2022         (ChromiumPort._generate_all_test_configurations):
2023         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2024         (_default_tests_paths):
2025         (ChromiumGpuLinuxPort.tests):
2026         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2027         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2028         (ChromiumGpuTest.assert_port_works):
2029         (ChromiumGpuTest.test_baseline_paths):
2030         (ChromiumGpuTest.test_graphics_type):
2031         (ChromiumGpuTest.test_default_tests_paths):
2032         (ChromiumGpuTest.test_test_files):
2033         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2034         (ChromiumMacPort):
2035         (ChromiumMacPort.__init__):
2036         (ChromiumMacPort.baseline_search_path):
2037         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2038         (ChromiumMacPortTest.test_graphics_type):
2039         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2040         (ChromiumPortTest.test_all_test_configurations):
2041         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2042         * Scripts/webkitpy/layout_tests/port/factory.py:
2043         (PortFactory._port_name_from_arguments_and_options):
2044         (PortFactory.get):
2045         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2046         (FactoryTest.test_chromium_gpu_mac):
2047         (FactoryTest.test_chromium_mac):
2048         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2049         (GetGoogleChromePortTest._verify_expectations_overrides):
2050         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2051         (MockChromiumDRTTest.test_chromium_parse_options):
2052         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2053         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2054         (test_url_fetcher):
2055         (test_zip_factory):
2056         (test_archive):
2057         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2058         (TestRebaseline.test_rebaseline_expectations):
2059
2060 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2061
2062         Categorize bots by ports instead of core/non-core separation
2063         https://bugs.webkit.org/show_bug.cgi?id=75766
2064
2065         Reviewed by Adam Barth.
2066
2067         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2068
2069         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2070         (loadBuilderConfig):
2071         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2072
2073 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2074
2075         Unreviewed, rolling out r104403.
2076         http://trac.webkit.org/changeset/104403
2077         https://bugs.webkit.org/show_bug.cgi?id=75803
2078
2079         It broke all tests on Qt5 (Requested by Ossy_weekend on
2080         #webkit).
2081
2082         * qmake/mkspecs/features/features.prf:
2083
2084 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2085
2086         [Qt] Enable CSS_FILTERS in Qt build
2087         https://bugs.webkit.org/show_bug.cgi?id=75777
2088
2089         Add the CSS_FILTERS feature flag to Qt.
2090
2091         Reviewed by Kenneth Rohde Christiansen.
2092
2093         * qmake/mkspecs/features/features.prf:
2094
2095 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2096
2097         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2098         https://bugs.webkit.org/show_bug.cgi?id=75202
2099
2100         Reviewed by David Kilzer.
2101
2102         The current CSS parser can just parse simple CSSes like
2103
2104             foo bar baz {
2105                 property1: value;
2106                 property2: value;
2107             }
2108
2109         , and cannot parse comments nor a CSS in which a selector and {
2110         appears in different lines. This patch rewrites the CSS parser
2111         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2112         shown in css_unittests.css.
2113
2114         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2115
2116         * Scripts/prepare-ChangeLog:
2117         (get_selector_line_ranges_for_css):
2118         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2119         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2120         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2121         (element1):
2122         (element2):
2123         (element3):
2124         (element4.p):
2125         (element5.p.q.r.s):
2126         (element6#p):
2127         (element7 element8):
2128         (element9.p element10.q):
2129         (element11#p element12#q):
2130         (element13, element14):
2131         (.p):
2132         (#p):
2133         (.p element15 #q element16.r element17#s):
2134         (element18:target):
2135         (element19):
2136         (element20):
2137         (element21):
2138         (element22):
2139
2140 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2141
2142         The Perl parser of prepare-ChangeLog can parse here-documents
2143         https://bugs.webkit.org/show_bug.cgi?id=73208
2144
2145         Reviewed by David Kilzer.
2146
2147         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2148         which results in wrong subroutine names in ChangeLogs.
2149         With this patch, prepare-ChangeLog can judge whether the line of "}"
2150         is the end of a subroutine or a line inside a here-document.
2151
2152         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2153
2154         * Scripts/prepare-ChangeLog:
2155         (get_function_line_ranges_for_perl):
2156         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2157         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2158         Added test cases for here-documents.
2159         (func7):
2160         (func8):
2161         (func9):
2162         (func10):
2163         (func11):
2164         (func12):
2165         (func13):
2166         (func14):
2167         (func15):
2168         (func16):
2169
2170 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2171
2172         Add unittests for the JavaScript parser of prepare-ChangeLog
2173         https://bugs.webkit.org/show_bug.cgi?id=75201
2174
2175         Reviewed by David Kilzer.
2176
2177         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2178         of prepare-ChangeLog.
2179
2180         * Scripts/prepare-ChangeLog:
2181         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2182         omitted from parsing. Thus,
2183
2184             str = "foo"
2185             function func() {
2186             }
2187
2188         was recognized as equivalent to
2189
2190             str = function func() {
2191             }
2192
2193         This patch replaces a string with a dummy identifier 'string_appeared_here'
2194         to tell the parser that a string appeared there.
2195
2196         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2197         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2198         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2199         (func1):
2200         (func2):
2201         (func3):
2202         (func4):
2203         (func5):
2204         (func6):
2205         (func7):
2206         (func8):
2207         (func9):
2208         (func10):
2209         (func11):
2210         (func12):
2211         (funcOverloaded):
2212         (Func1.prototype.get x1):
2213         (Func1.prototype.get x2):
2214         (Func1.prototype.set x1):
2215         (Func1.prototype.set x3):
2216         (Func2.prototype.func13):
2217         (Func2.prototype.func14):
2218         (Func2.prototype.func15):
2219         (func16.func17):
2220         (func16.func18):
2221         (func16.func19):
2222         (func16):
2223
2224 2012-01-08  David Levin  <levin@chromium.org>
2225
2226         [chromium] Add layout test support for autosize code in FrameView.
2227         https://bugs.webkit.org/show_bug.cgi?id=73631
2228
2229         Reviewed by Dmitry Titov.
2230
2231         * DumpRenderTree/chromium/LayoutTestController.cpp:
2232         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
2233         (LayoutTestController::reset): Set the autoresize mode back to false.
2234         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
2235         * DumpRenderTree/chromium/LayoutTestController.h:
2236         * DumpRenderTree/chromium/WebViewHost.cpp:
2237         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
2238         * DumpRenderTree/chromium/WebViewHost.h:
2239
2240 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2241
2242         [WK2][GTK] Each test takes roughly half a second to load
2243         https://bugs.webkit.org/show_bug.cgi?id=70699
2244
2245         Reviewed by Martin Robinson.
2246
2247         Set the XDG_CACHE_HOME environment variable when testing with
2248         WebKitTestRunner. This way the testing is started with a non-existing
2249         application cache. If the cache exists and is not empty, the emptying
2250         and vacuuming that is performed before every test can consume a lot of
2251         time.
2252
2253         This is just a temporary workaround until it becomes possible to set
2254         a desired directory to be used as the application cache location through
2255         WebKitWebContext.
2256
2257         * Scripts/webkitpy/layout_tests/port/gtk.py:
2258         (GtkPort.setup_environ_for_server):
2259
2260 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2261
2262         [GTK] Enable requestAnimationFrame in build-webkit
2263         https://bugs.webkit.org/show_bug.cgi?id=75773
2264
2265         Reviewed by Martin Robinson.
2266
2267         Enable requestAnimationFrame for the Gtk port.
2268
2269         * Scripts/build-webkit:
2270
2271 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
2272
2273         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
2274
2275         * Scripts/webkitdirs.pm:
2276         (buildChromium):
2277         Missing parentheses.
2278
2279 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2280
2281         Fix DRT build on case-sensitive file systems.
2282
2283         Fix case of include of WebDynamicScrollBarsView.h
2284         
2285         * DumpRenderTree/mac/DumpRenderTree.mm:
2286
2287 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2288
2289         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
2290         https://bugs.webkit.org/show_bug.cgi?id=75662
2291
2292         Reviewed by Dan Bernstein.
2293         
2294         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
2295         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
2296         test window uses the main display's color space, so that the pixel values in the bitmap
2297         that gets checksummed are identical to the CSS colors.
2298         
2299         Removed the code that switches the display profile in DRT, since that is no longer required.
2300
2301         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
2302         * DumpRenderTree/mac/DumpRenderTree.mm:
2303         (crashHandler): Remove code that switches display profiles.
2304         (prepareConsistentTestingEnvironment): Ditto.
2305         (dumpRenderTree): Ditto.
2306         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
2307         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
2308         (createBitmapContextFromWebView): Add comment about the colorspace handling.
2309         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2310         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
2311         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
2312         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2313         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
2314         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
2315
2316 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2317
2318         run-api-tests: specify individual suites and tests on the command-line
2319
2320         Reviewed by Adam Roben.
2321
2322         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2323
2324         The run-api-tests script will now accept a list of arguments on
2325         the command-line that are used as prefix filters.  To run all
2326         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
2327         use:
2328
2329             $ run-api-tests WTF
2330
2331         To run only the tests in the "WTF" suite, not the "WTF_Vector"
2332         suite, use:
2333
2334             $ run-api-tests WTF.
2335
2336         * Scripts/run-api-tests: Filter tests if any prefix arguments
2337         are passed on the command-line.
2338
2339 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2340
2341         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
2342
2343         Reviewed by Adam Roben.
2344
2345         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2346
2347         * Scripts/run-api-tests:
2348         (dumpTestsBySuite): Update to accept array of tests instead of
2349         hash data structure.
2350         (runTestsBySuite): Ditto.
2351         (listAllTests): Rename from populateTests().  Update to return
2352         an array of tests instad of the hash data structure.
2353
2354 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2355
2356         webkitpy: clean up test/uri conversion routines
2357         https://bugs.webkit.org/show_bug.cgi?id=75648
2358
2359         Reviewed by Eric Seidel.
2360
2361         This change moves test_to_uri and uri_to_test from the Port
2362         class to the Driver class (the routines were only being
2363         called by the drivers), and removes a bunch of stale and/or
2364         busted logic.
2365
2366         * Scripts/webkitpy/layout_tests/port/base.py:
2367         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2368         * Scripts/webkitpy/layout_tests/port/chromium.py:
2369         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2370         * Scripts/webkitpy/layout_tests/port/driver.py:
2371         (is_http_test):
2372         (test_to_uri):
2373         (uri_to_test):
2374         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2375         (run_one_test):
2376         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2377         (MockDRTTest.input_line):
2378         (input_line):
2379         (expected_output):
2380         * Scripts/webkitpy/layout_tests/port/test.py:
2381         * Scripts/webkitpy/layout_tests/port/webkit.py:
2382         (_command_from_driver_input):
2383
2384 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2385
2386         Mitigate scrollbar differences when running pixel tests
2387         https://bugs.webkit.org/show_bug.cgi?id=67217
2388
2389         Reviewed by Dan Bernstein.
2390         
2391         Add an NSScroller subclass that draws mock scrollbars identically
2392         to the WebCore mock scrollbar theme, and register it with the
2393         WebDynamicScrollbarsView.
2394
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (-[DRTMockScroller rectForPart:]):
2397         (-[DRTMockScroller drawKnob]):
2398         (-[DRTMockScroller drawRect:]):
2399         (registerMockScrollbars):
2400         (prepareConsistentTestingEnvironment):
2401
2402 2012-01-05  Jon Lee  <jonlee@apple.com>
2403
2404         Update DRT on Mac to draw resize handles on text areas.
2405
2406         Reviewed by John Sullivan.
2407
2408         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
2409         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
2410
2411         * DumpRenderTree/mac/DumpRenderTree.mm:
2412         (resetDefaultsToConsistentValues):
2413
2414 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2415
2416         [Qt] Move listing of include paths and libs to pri files in sources
2417
2418         Includepaths are sometimes modified by non-Qt contributors so keeping
2419         them in files inside Sources makes it more likely that they are updated
2420         along with project files for the other ports.
2421
2422         Using pri files instead of prf files for this also has the benefit that
2423         the include() from the main target file can be parsed and followed by
2424         Qt Creator -- something that does not work with load().
2425
2426         Dependency from a target to a library through the WEBKIT variable are
2427         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
2428         set the source root of the module and include the right pri file.
2429
2430         Ideally we'd use the variant of include() that takes an optional
2431         namespace to read the variables into, or the fromfile() function,
2432         but both of these add an overhead of about 40% on the total qmake
2433         runtime, due to making a deep copy of all the variables in the
2434         project or re-reading all the prf files from scratch.
2435
2436         Reviewed by Simon Hausmann.
2437         Reviewed by Ossy.
2438
2439         * qmake/mkspecs/features/default_post.prf:
2440         * qmake/mkspecs/modules/javascriptcore.prf: Added.
2441         * qmake/mkspecs/modules/webcore.prf: Added.
2442         * qmake/mkspecs/modules/webkit2.prf: Added.
2443         * qmake/mkspecs/modules/wtf.prf: Added.
2444
2445 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
2446
2447         [EFL] Add pre-render handling code in EWebLauncher.
2448         https://bugs.webkit.org/show_bug.cgi?id=73430
2449
2450         Reviewed by Zoltan Herczeg.
2451
2452         Add pre-render handling code by pressing Insert key.
2453
2454         * EWebLauncher/main.c:
2455         (on_key_down):
2456
2457 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
2458
2459         NRWT should use test_expectation.txt on wk2 platforms
2460         https://bugs.webkit.org/show_bug.cgi?id=75417
2461
2462         Reviewed by Dirk Pranke.
2463
2464         * Scripts/webkitpy/layout_tests/port/webkit.py:
2465         (path_to_test_expectations_file):
2466         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2467         (test_path_to_test_expectations_file):
2468
2469 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2470
2471         Don't hardcode expected file URIs in as they depend on the platform
2472         https://bugs.webkit.org/show_bug.cgi?id=75666
2473
2474         Reviewed by Dirk Pranke.
2475
2476         * Scripts/webkitpy/layout_tests/port/win.py:
2477         (WinPort.show_results_html_file):
2478         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2479         (MainTest.test_unexpected_failures):
2480         (MainTest.test_results_directory_default):
2481         (MainTest.test_results_directory_relative):
2482
2483 2012-01-05  Anders Carlsson  <andersca@apple.com>
2484
2485         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
2486         https://bugs.webkit.org/show_bug.cgi?id=75667
2487         <rdar://problem/10389454>
2488
2489         Reviewed by Kevin Decker.
2490
2491         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
2492
2493         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2494         (PluginTest::executeScript):
2495         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2496         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2497         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
2498         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
2499         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2500
2501 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2502
2503         webkitpy: clean up port factory methods
2504         https://bugs.webkit.org/show_bug.cgi?id=75590
2505
2506         Reviewed by Eric Seidel.
2507
2508         This change consolidates much of the "factory method" logic
2509         of determining which port objects to create for a given set
2510         of configurations by merging the separate factory methods in
2511         chromium_gpu and google_chrome into PortFactory so that at least
2512         all of the logic is in one place.
2513
2514         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2515         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2516         * Scripts/webkitpy/layout_tests/port/factory.py:
2517         (_port_name_from_arguments_and_options):
2518         (get):
2519         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2520         (test_google_chrome):
2521         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2522         (GoogleChromeLinux32Port):
2523         (GoogleChromeLinux32Port.baseline_search_path):
2524         (test_expectations_overrides):
2525         (architecture):
2526         (GoogleChromeLinux64Port):
2527         (GoogleChromeLinux64Port.baseline_search_path):
2528         (GoogleChromeMacPort):
2529         (GoogleChromeMacPort.baseline_search_path):
2530         (GoogleChromeWinPort):
2531         (GoogleChromeWinPort.baseline_search_path):
2532         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2533         (_verify_baseline_path):
2534
2535 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2536
2537         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
2538         https://bugs.webkit.org/show_bug.cgi?id=75617
2539
2540         Reviewed by Dirk Pranke.
2541
2542         * Scripts/webkitpy/common/system/filesystem.py:
2543         (FileSystem.exists):
2544         * Scripts/webkitpy/common/system/filesystem_mock.py:
2545         (MockFileSystem.exists):
2546         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2547         (GenericFileSystemTests.teardown_generic_test_dir):
2548         * Scripts/webkitpy/layout_tests/port/base.py:
2549         (Port.to.show_results_html_file):
2550         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2551         (MainTest.test_results_directory_absolute):
2552
2553 2012-01-05  Adam Roben  <aroben@apple.com>
2554
2555         Remove some unnecessary code from old-run-webkit-tests
2556
2557         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
2558         WebKitTestRunner.
2559
2560         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
2561         Windows
2562
2563         Reviewed by Eric Seidel.
2564
2565         * Scripts/old-run-webkit-tests:
2566         (top level):
2567         (openDumpTool):
2568         Removed calls to setPathForRunningWebKitApp.
2569
2570 2012-01-05  Adam Roben  <aroben@apple.com>
2571
2572         Teach NRWT to use run-safari to open results.html on Apple's Windows port
2573
2574         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
2575         better, since we always want to open results.html using the user's build of WebKit, not
2576         whatever their default browser is.
2577
2578         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
2579         for Apple's Windows port
2580
2581         Reviewed by Eric Seidel.
2582
2583         * Scripts/webkitpy/layout_tests/port/win.py:
2584         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
2585         an obsolete comment.
2586
2587         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2588         (WinPortTest.test_show_results_html_file): Updated expected results.
2589
2590 2012-01-05  Adam Roben  <aroben@apple.com>
2591
2592         Prepend Safari.exe's path to the command-line passed to CreateProcess
2593
2594         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
2595         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
2596         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
2597         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
2598         first argument that WebKitLauncherWin was trying to pass to it.
2599
2600         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
2601
2602         Reviewed by Steve Falkenburg.
2603
2604         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2605         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
2606         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
2607
2608 2012-01-05  Adam Roben  <aroben@apple.com>
2609
2610         Stop using explicit memory management in WebKitLauncherWin
2611
2612         We now use stack-allocated STL objects instead.
2613
2614         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
2615         Safari
2616
2617         Reviewed by Steve Falkenburg.
2618
2619         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2620         (getStringValue):
2621         (applePathFromRegistry):
2622         (safariInstallDir):
2623         (safariBrowserExe):
2624         (_tWinMain):
2625         Changed to use stack-allocated STL objects instead of malloc/free.
2626
2627 2012-01-05  Adam Roben  <aroben@apple.com>
2628
2629         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
2630
2631         This allows us to add the Safari and Apple Application Support directories to PATH before
2632         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
2633
2634         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
2635         Windows port of DumpRenderTree/WebKitTestRunner
2636
2637         Reviewed by Steve Falkenburg.
2638
2639         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
2640         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
2641
2642         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2643         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2644         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
2645
2646         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
2647         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
2648         the stub launcher.
2649
2650         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
2651         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
2652         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
2653         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
2654         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
2655         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
2656         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
2657
2658         * WebKitTestRunner/win/main.cpp:
2659         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
2660
2661 2012-01-05  Adam Roben  <aroben@apple.com>
2662
2663         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
2664
2665         This allows us to add the Safari and Apple Application Support directories to PATH before
2666         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
2667
2668         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
2669         Windows port of DumpRenderTree/WebKitTestRunner
2670
2671         Reviewed by Steve Falkenburg.
2672
2673         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
2674         which I forgot to add to this .sln when that project was created.
2675
2676         * DumpRenderTree/win/DumpRenderTree.cpp:
2677         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
2678
2679         * DumpRenderTree/win/DumpRenderTree.vcproj:
2680         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2681         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
2682
2683         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
2684         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
2685         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
2686         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
2687         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
2688         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
2689         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
2690         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
2691
2692         * win/DLLLauncher/DLLLauncherMain.cpp:
2693         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
2694         Safari's directory to PATH so that SafariTheme.dll can be found.
2695
2696         (main):
2697         (wWinMain):
2698         Changed to use the new modifyPath function.
2699
2700 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2701
2702         [Qt] Never enable FontConfig on Mac OS X
2703         https://bugs.webkit.org/show_bug.cgi?id=75616
2704
2705         Reviewed by Tor Arne Vestbø.
2706
2707         * qmake/mkspecs/features/features.prf:
2708
2709 2012-01-05  Alpha Lam  <hclam@chromium.org>
2710
2711         Unreviewed, rolling out r104159.
2712         http://trac.webkit.org/changeset/104159
2713         https://bugs.webkit.org/show_bug.cgi?id=75590
2714
2715         Chromium port GPU tests cannot be executed.
2716
2717         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2718         (get):
2719         (_default_tests_paths):
2720         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2721         (ChromiumGpuTest.assert_port_works):
2722         * Scripts/webkitpy/layout_tests/port/factory.py:
2723         (PortFactory._port_name_from_arguments_and_options):
2724         (PortFactory):
2725         (PortFactory._get_kwargs):
2726         (PortFactory.get):
2727         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2728         (FactoryTest.test_google_chrome.names):
2729         (FactoryTest.test_google_chrome):
2730         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2731         (GetGoogleChromePort):
2732         (GetGoogleChromePort.GoogleChromeLinux32Port):
2733         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
2734         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
2735         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
2736         (GetGoogleChromePort.GoogleChromeLinux64Port):
2737         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
2738         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
2739         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
2740         (GetGoogleChromePort.GoogleChromeMacPort):
2741         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
2742         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
2743         (GetGoogleChromePort.GoogleChromeWinPort):
2744         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
2745         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
2746         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2747         (GetGoogleChromePortTest._verify_baseline_path):
2748         (GetGoogleChromePortTest._verify_expectations_overrides):
2749
2750 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2751
2752         webkitpy: clean up port factory methods
2753         https://bugs.webkit.org/show_bug.cgi?id=75590
2754
2755         Reviewed by Eric Seidel.
2756
2757         This change consolidates much of the "factory method" logic
2758         of determining which port objects to create for a given set
2759         of configurations by merging the separate factory methods in
2760         chromium_gpu and google_chrome into PortFactory so that at least
2761         all of the logic is in one place.
2762
2763         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2764         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2765         * Scripts/webkitpy/layout_tests/port/factory.py:
2766         (_port_name_from_arguments_and_options):
2767         (get):
2768         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2769         (test_google_chrome):
2770         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2771         (GoogleChromeLinux32Port):
2772         (GoogleChromeLinux32Port.baseline_search_path):
2773         (test_expectations_overrides):
2774         (architecture):
2775         (GoogleChromeLinux64Port):
2776         (GoogleChromeLinux64Port.baseline_search_path):
2777         (GoogleChromeMacPort):
2778         (GoogleChromeMacPort.baseline_search_path):
2779         (GoogleChromeWinPort):
2780         (GoogleChromeWinPort.baseline_search_path):
2781         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2782         (_verify_baseline_path):
2783
2784 2012-01-04  Adam Roben  <aroben@apple.com>
2785
2786         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
2787
2788         This allows us to add the Apple Application Support directory to PATH before trying to load
2789         WebKit so that CoreGraphics.dll and friends can be found.
2790
2791         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
2792
2793         Reviewed by Anders Carlsson.
2794
2795         * DumpRenderTree/win/ImageDiff.vcproj:
2796         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2797         Changed to build ImageDiff.dll instead of ImageDiff.exe.
2798
2799         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
2800         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
2801
2802         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
2803         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
2804         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
2805         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
2806         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
2807         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
2808         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
2809
2810         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
2811         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
2812         to main.
2813
2814         * win/DLLLauncher/DLLLauncherMain.cpp:
2815         (main):
2816         (wWinMain):
2817         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
2818         stub launcher acts as a console program and calls a console version of
2819         dllLauncherEntryPoint.
2820
2821 2012-01-04  Adam Roben  <aroben@apple.com>
2822
2823         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
2824
2825         This allows us to add the Apple Application Support directory to PATH before trying to load
2826         WebKit so that CoreGraphics.dll and friends can be found.
2827
2828         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
2829         double-clicked
2830
2831         Reviewed by Anders Carlsson.
2832
2833         * MiniBrowser/MiniBrowser.vcproj:
2834         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2835         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
2836
2837         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
2838         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
2839         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
2840         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
2841         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
2842         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
2843         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
2844
2845         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
2846         but changed to build the stub launcher.
2847
2848         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
2849         it needs to be compiled into the .exe instead of the .dll.
2850         (DllMain): Added. We use this to store the DLL's HINSTANCE.
2851         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
2852         DLLLauncherMain code.
2853
2854         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
2855         to here.
2856
2857 2012-01-04  Adam Roben  <aroben@apple.com>
2858
2859         Make WinLauncher's window frame respond to clicks/drags again
2860
2861         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
2862         bar when Aero is disabled
2863
2864         Reviewed by Brent Fulgham.
2865
2866         * WinLauncher/WinLauncher.cpp:
2867         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
2868         Also removed an unnecessary "break" keyword.
2869
2870 2012-01-04  Adam Roben  <aroben@apple.com>
2871
2872         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
2873
2874         This allows us to add the Apple Application Support directory to PATH before trying to load
2875         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
2876         should use this mechanism.
2877
2878         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
2879         double-clicked
2880
2881         Reviewed by Anders Carlsson.
2882
2883         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
2884         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
2885         done by the now-removed InitInstance function.
2886         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
2887         calls. Merged code from InitInstance into this function, and change to use the global hInst
2888         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
2889         function, which corresponds to WinLauncher.exe.
2890
2891         * WinLauncher/WinLauncher.vcproj:
2892         * WinLauncher/WinLauncherCommon.vsprops:
2893         Changed to build WinLauncher.dll instead of WinLauncher.exe.
2894
2895         * WinLauncher/WinLauncherLauncher.rc: Added.
2896         * WinLauncher/WinLauncherLauncherResource.h: Added.
2897         This just references the WinLauncher.ico file to set the application icon (though it looks
2898         like that's a default icon).
2899
2900         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
2901         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
2902
2903         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
2904         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
2905         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
2906         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
2907         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
2908         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
2909         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
2910
2911         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
2912         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
2913         program if it detects heap corruption.
2914         (getStringValue): Helper function to read a string value from the registry.
2915         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
2916         application from the registry.
2917         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
2918         Application Support directory.
2919         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
2920         (prependPath): Helper function to prepend a directory to the PATH.
2921         (fatalError): Helper function to display an error to the user.
2922         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
2923         dllLauncherEntryPoint function.
2924
2925 2012-01-05  Kentaro Hara  <haraken@chromium.org>
2926
2927         prepare-ChangeLog cannot parse python code that nests classes and defs
2928         https://bugs.webkit.org/show_bug.cgi?id=75524
2929
2930         Reviewed by Ryosuke Niwa.
2931
2932         This patch fixes the python parser of prepare-ChangeLog so that it can parse
2933         python code that nests classes and defs, like this:
2934
2935         class C:
2936             pass
2937             def f():
2938                 pass
2939             pass
2940
2941         Also, this patch fixes the python parser so that it inserts a dummy line
2942         at the end of the file to pop out all popped scopes.
2943
2944         * Scripts/prepare-ChangeLog:
2945         (get_function_line_ranges_for_python):
2946
2947         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
2948         Added test cases that nest classes and defs.
2949         (func7):
2950         (func7.func8):
2951         (func7.func8.func9):
2952         (Class2):
2953         (Class2.Class3):
2954         (Class2.Class3.Class4):
2955         (Class5):
2956         (Class5.func10):
2957         (Class5.func11):
2958         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
2959
2960 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2961
2962         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
2963         https://bugs.webkit.org/show_bug.cgi?id=75433
2964
2965         Reviewed by Martin Robinson.
2966
2967         * MiniBrowser/gtk/BrowserWindow.c:
2968         (webViewLoadFailed): Reset the progress bar when load fails.
2969         (browserWindowConstructed): Connect to load-failed signal.
2970
2971 2012-01-04  Dan Bernstein  <mitz@apple.com>
2972
2973         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
2974         start WebProcess under gdb and WebProcess will then run the client executable.
2975
2976         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
2977
2978         Reviewed by Anders Carlsson.
2979
2980         * Scripts/webkitdirs.pm:
2981         (shouldTargetWebProcess): Added.
2982         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
2983         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
2984         app using the -client-executable option if targeting the web process.
2985
2986 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2987
2988         Adding myself to committers list.
2989
2990         Unreviewed.
2991
2992         * Scripts/webkitpy/common/config/committers.py:
2993
2994 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2995
2996         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
2997
2998         This reverts commit r103546.
2999
3000         * TestWebKitAPI/TestsController.cpp:
3001         (TestWebKitAPI::TestsController::TestsController):
3002
3003 2012-01-04  James Robinson  <jamesr@chromium.org>
3004
3005         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3006         https://bugs.webkit.org/show_bug.cgi?id=74583
3007
3008         Reviewed by Darin Fisher.
3009
3010         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3011
3012         * Scripts/webkitpy/style/checkers/cpp.py:
3013         (check_function_definition):
3014
3015 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3016
3017         [Qt] Fix link order of static libraries and unbreak QtWin32
3018
3019         We were keeping the correct static link order between the intermediate
3020         WebKit libraries, but not the internal dependencies for each of those
3021         libraries. The load() will in some instances mess with LIBS, so we need
3022         to ensure that the dependent libraries are added after the library we
3023         are linking against.
3024
3025         Reviewed by Simon Hausmann.
3026
3027         * qmake/mkspecs/features/default_post.prf:
3028
3029 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3030
3031         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3032
3033         The custom qmake variable 'WEBKIT' is used for signaling that a
3034         target depends in some way on other subproject of the WebKit
3035         project. For now this is limited to the set of intermediate
3036         libraries: wtf, javascriptcore, webcore, and webkit2.
3037
3038         This replaces the previous convension of using load(foo) for
3039         just include paths, and CONFIG += foo to also link against foo.
3040
3041         Adding a dependency results in additional include paths being
3042         available, and potentially linking to the library. This is
3043         decided by the build system based on conditions such as what
3044         kind of target is being built and the general build config.
3045
3046         An advantage to his approach is that it simplifies the individual
3047         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3048         and LIBS += as normal instead of prepending.
3049
3050         Reviewed by Simon Hausmann.
3051
3052         * DumpRenderTree/qt/DumpRenderTree.pro:
3053         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3054         * QtTestBrowser/QtTestBrowser.pro:
3055         * WebKitTestRunner/InjectedBundle/Target.pri:
3056         * WebKitTestRunner/Target.pri:
3057         * qmake/README:
3058         * qmake/mkspecs/features/default_post.prf:
3059         * qmake/mkspecs/features/functions.prf:
3060         * qmake/mkspecs/features/javascriptcore.prf:
3061         * qmake/mkspecs/features/qtwebkit.prf:
3062         * qmake/mkspecs/features/webcore.prf:
3063         * qmake/mkspecs/features/webkit2.prf:
3064         * qmake/mkspecs/features/wtf.prf:
3065
3066 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3067
3068         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3069         https://bugs.webkit.org/show_bug.cgi?id=75488
3070
3071         Reviewed by Tor Arne Vestbø.
3072
3073         * MiniBrowser/qt/MiniBrowser.qrc:
3074         * MiniBrowser/qt/qml/BrowserWindow.qml:
3075         * MiniBrowser/qt/qml/Dialog.qml:
3076         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3077         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3078
3079 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3080
3081         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3082
3083         It wasn't really a problem at runtime since the right QtWebKit was
3084         already loaded as a dependency of the web process, but the ldd output
3085         would still be busted.
3086
3087         Reviewed by Simon Hausmann.
3088
3089         * WebKitTestRunner/InjectedBundle/Target.pri:
3090
3091 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3092
3093         [Qt] Move use of $$qtLibraryTarget() to a single place
3094
3095         Reviewed by Kenneth Rohde Christiansen.
3096
3097         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3098         * WebKitTestRunner/InjectedBundle/Target.pri:
3099         * qmake/mkspecs/features/default_post.prf:
3100         * qmake/mkspecs/features/webcore.prf:
3101
3102 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3103
3104         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3105         https://bugs.webkit.org/show_bug.cgi?id=75238
3106
3107         Reviewed by Antonio Gomes.
3108
3109         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3110         it could initiate download directly if it has the download attribute in the link 
3111         and doesn't need to open new blank page for the target="_blank". Enabling this 
3112         feature in the BlackBerry porting also prepares for later blob feature implementation.
3113
3114         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3115         for the BlackBerry porting.
3116
3117 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3118
3119         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3120         https://bugs.webkit.org/show_bug.cgi?id=75475
3121
3122         Reviewed by Martin Robinson.
3123
3124         The problem is that the property blurb contains <a ping> and tree
3125         view uses gtk_tooltip_set_markup() internally, so we need to
3126         escape the text.
3127
3128         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3129         (browserSettingsDialogConstructed): Escape property blurb before
3130         storing it in the GtkTreeModel.
3131
3132 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3133
3134         When showing results.html pass a correct URL to webbrowser.open
3135         https://bugs.webkit.org/show_bug.cgi?id=75438
3136
3137         Reviewed by Adam Barth.
3138
3139         * Scripts/webkitpy/common/system/filesystem.py:
3140         (file_path_as_url):
3141         * Scripts/webkitpy/common/system/filesystem_mock.py:
3142         (file_path_as_url):
3143         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3144         (test_file_path_as_url):
3145         * Scripts/webkitpy/layout_tests/port/base.py:
3146         (show_results_html_file):
3147         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3148         (test_show_results_html_file):
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3150         (test_results_directory_relative):
3151
3152 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3153
3154         shrink the header on the flakiness dashboard
3155         https://bugs.webkit.org/show_bug.cgi?id=65153
3156
3157         Reviewed by Adam Roben.
3158
3159         Move some of the "show" links to be to the right of the header
3160         instead of below the header when they content they're showing
3161         is hidden. That way we don't waste vertical space on them.
3162
3163         No new tests. This code is covered by existing tests.
3164
3165         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3166
3167 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3168
3169         Add a tool to analyze change logs
3170         https://bugs.webkit.org/show_bug.cgi?id=72243
3171
3172         Reviewed by Eric Seidel.
3173
3174         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3175         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3176         for visualizing json files.
3177
3178         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3179         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3180         generates json files, and N is the number of changelogs to parse.
3181
3182         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3183         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3184         * Scripts/webkitpy/tool/commands/__init__.py:
3185         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3186         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3187         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3188         * Scripts/webkitpy/tool/steps/options.py:
3189
3190 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3191
3192         Add a tool to analyze change logs
3193         https://bugs.webkit.org/show_bug.cgi?id=72243
3194
3195         Reviewed by Eric Seidel.
3196
3197         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3198         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3199         for visualizing json files.
3200
3201         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3202         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3203         generates json files, and N is the number of changelogs to parse.
3204
3205         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3206         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3207         * Scripts/webkitpy/tool/commands/__init__.py:
3208         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3209         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3210         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3211         * Scripts/webkitpy/tool/steps/options.py:
3212
3213 2012-01-03  Adam Roben  <aroben@apple.com>
3214
3215         Make Port subclasses override the operating_system method rather than setting an attribute
3216
3217         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3218         return the default value ("mac"). This was confusing the version-checking logic inside
3219         ApplePort.__init__ on Windows.
3220
3221         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
3222         crashes on launch on Windows 7 SP1
3223
3224         Reviewed by Eric Seidel.
3225
3226         * Scripts/webkitpy/layout_tests/port/apple.py:
3227         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
3228
3229         * Scripts/webkitpy/layout_tests/port/base.py:
3230         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
3231         should now override the operating_system method instead.
3232         (Port.operating_system): Changed to always return "mac". Subclasses should override to
3233         return something else.
3234
3235         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3236         (ChromiumLinuxPort.__init__):
3237         (ChromiumLinuxPort.operating_system):
3238         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3239         (ChromiumMacPort.__init__):
3240         (ChromiumMacPort.operating_system):
3241         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3242         (ChromiumWinPort.__init__):
3243         (ChromiumWinPort.operating_system):
3244         * Scripts/webkitpy/layout_tests/port/mac.py:
3245         (MacPort.__init__):
3246         (MacPort.operating_system):
3247         * Scripts/webkitpy/layout_tests/port/win.py:
3248         (WinPort.__init__):
3249         (WinPort.operating_system):
3250         Changed to override the operating_system method rather than setting the _operating_system
3251         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
3252
3253         * Scripts/webkitpy/layout_tests/port/qt.py:
3254         (QtPort.__init__):
3255         (QtPort._path_to_webcore_library):
3256         Changed to use self.operating_system() instead of self._operating_system, for consistency
3257         with other Port-related code.
3258
3259         (QtPort.operating_system): Added this override of Port.operating_system that returns the
3260         value we determined in our __init__ method.
3261
3262         * Scripts/webkitpy/layout_tests/port/test.py:
3263         (TestPort.operating_system): Added this override of Port.operating_system that returns the
3264         value we determined in our __init__ method.
3265
3266         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3267         (PortTest.test_operating_system):
3268         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3269         (ChromiumLinuxPortTest.test_operating_system):
3270         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3271         (ChromiumMacPortTest.test_operating_system):
3272         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3273         (ChromiumWinPortTest.test_operating_system):
3274         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3275         (MacPortTest.test_operating_system):
3276         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3277         (QtPortTest.test_operating_system):
3278         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3279         (WinPortTest.test_operating_system):
3280         Test that all ports return the expected operating system string.
3281
3282 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
3283
3284         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
3285         https://bugs.webkit.org/show_bug.cgi?id=75474
3286
3287         Reviewed by Philippe Normand.
3288
3289         * Scripts/run-gtk-tests: Ignore files whose name does not start
3290         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
3291
3292 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
3293
3294         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
3295         https://bugs.webkit.org/show_bug.cgi?id=75472
3296
3297         Reviewed by Tor Arne Vestbø.
3298
3299         * MiniBrowser/qt/MiniBrowser.pro:
3300         * MiniBrowser/qt/MiniBrowser.qrc:
3301         * MiniBrowser/qt/qml/BrowserWindow.qml:
3302         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
3303
3304 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
3305
3306         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
3307         https://bugs.webkit.org/show_bug.cgi?id=75471
3308
3309         Reviewed by Tor Arne Vestbø.
3310
3311         Add simple UI for JavaScript Alert dialogs. This patch also adds a
3312         simple DialogButton QML type and a Dialog QML type which will be
3313         reusable for other JavaScript dialogs.
3314
3315         * MiniBrowser/qt/MiniBrowser.qrc:
3316         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
3317         * MiniBrowser/qt/qml/BrowserWindow.qml:
3318         * MiniBrowser/qt/qml/Dialog.qml: Added.
3319         * MiniBrowser/qt/qml/DialogButton.qml: Added.
3320
3321 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
3322
3323         [Qt][WK2] MiniBrowser doesn't show url bar
3324         https://bugs.webkit.org/show_bug.cgi?id=75470
3325
3326         Reviewed by Tor Arne Vestbø.
3327
3328         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
3329         on QtDeclarative (QTBUG-23422).
3330
3331 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3332
3333         [GTK] Simplify loader client WebKit2 GTK+ API
3334         https://bugs.webkit.org/show_bug.cgi?id=74605
3335
3336         Reviewed by Gustavo Noronha Silva.
3337
3338         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
3339         private API.
3340
3341 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3342
3343         [Qt] Clean up detection of fontconfig
3344
3345         We decide in features.prf whether or not fontconfig is available, and
3346         set the HAVE_FONTCONFIG define accordingly. All leaf project files
3347         should use this define to decide whether or not to link against
3348         fontconfig, not do their own detection.
3349
3350         We don't need to add link_pkgconfig to CONFIG in each project file,
3351         as we selectivly enable that configuration in defaults_post when
3352         needed.
3353
3354         Reviewed by Ossy.
3355
3356         * DumpRenderTree/qt/DumpRenderTree.pro:
3357         * QtTestBrowser/QtTestBrowser.pro:
3358         * WebKitTestRunner/InjectedBundle/Target.pri:
3359         * qmake/mkspecs/features/unix/default_post.prf:
3360         * qmake/mkspecs/features/unix/default_pre.prf:
3361
3362 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3363
3364         [Qt] Introduce qmake replace function for the active build config
3365
3366         Reviewed by Ossy.
3367
3368         * qmake/mkspecs/features/default_post.prf:
3369         * qmake/mkspecs/features/functions.prf:
3370
3371 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3372
3373         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
3374         https://bugs.webkit.org/show_bug.cgi?id=75435
3375
3376         Reviewed by Martin Robinson.
3377
3378         * GNUmakefile.am: Make sure DRT links to X11.
3379         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
3380
3381 2011-12-04  Philippe Normand  <pnormand@igalia.com>
3382
3383         [WK2][GTK] WebSettings support in MiniBrowser
3384         https://bugs.webkit.org/show_bug.cgi?id=73773
3385
3386         Reviewed by Martin Robinson.
3387
3388         Patch heavily inspired from the WebKit GtkLauncher to support
3389         command-line WebSettings. Example: --enable-fullscreen=TRUE.
3390         The full list of options can be consulted with --help-websettings.
3391
3392         * MiniBrowser/gtk/main.c:
3393         (loadURI):
3394         (parseOptionEntryCallback):
3395         (isValidParameterType):
3396         (getOptionEntriesFromWebKitSettings):
3397         (addSettingsGroupToContext):
3398         (main):
3399
3400 2012-01-02  Philippe Normand  <pnormand@igalia.com>
3401
3402         [GTK] GtkLauncher settings improvements
3403         https://bugs.webkit.org/show_bug.cgi?id=75439
3404
3405         Reviewed by Martin Robinson.
3406
3407         * GtkLauncher/main.c:
3408         (filenameToURL): We can use NULL in C.
3409         (isValidParameterType): Utility function to filter GParamTypes
3410         that can be edited.
3411         (getOptionEntriesFromWebKitWebSettings): Avoid handling
3412         construct-only properties and use the isValidParameterType
3413         function. Makes the code a bit cleaner.
3414
3415 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3416
3417         [EFL] Remove whitespace/declaration style exception
3418         https://bugs.webkit.org/show_bug.cgi?id=75424
3419
3420         Reviewed by David Levin.
3421
3422         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
3423         application. So, they still need to use EFL coding style.
3424
3425         * Scripts/webkitpy/style/checker.py:
3426
3427 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3428
3429         [GTK] Add a way to change web view settings in MiniBrowser
3430         https://bugs.webkit.org/show_bug.cgi?id=71568
3431
3432         Reviewed by Philippe Normand.
3433
3434         Add a preferences button to the toolbar that shows a dialog to
3435         change settings of the current web view. It uses a GtkTreeView
3436         with a custom cell renderer to support multiple types of values.
3437
3438         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
3439         (browserCellRendererVariantFinalize):
3440         (browserCellRendererVariantGetProperty):
3441         (browserCellRendererVariantSetModeForValue):
3442         (browserCellRendererVariantSetProperty):
3443         (browserCellRendererVariantGetRendererForValue):
3444         (browserCellRendererVariantCellRendererTextEdited):
3445         (browserCellRendererVariantCellRendererSpinEdited):
3446         (browserCellRendererVariantCellRendererActivate):
3447         (browserCellRendererVariantCellRendererRender):
3448         (browserCellRendererVariantCellRendererStartEditing):
3449         (browserCellRendererVariantCellRendererGetPreferredWidth):
3450         (browserCellRendererVariantCellRendererGetPreferredHeight):
3451         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
3452         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
3453         (browserCellRendererVariantCellRendererGetAlignedArea):
3454         (browser_cell_renderer_variant_init):
3455         (browser_cell_renderer_variant_class_init):
3456         (browser_cell_renderer_variant_new):
3457         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
3458         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
3459         (cellRendererChanged):
3460         (browserSettingsDialogSetProperty):
3461         (browser_settings_dialog_init):
3462         (browserSettingsDialogConstructed):
3463         (browser_settings_dialog_class_init):
3464         (browser_settings_dialog_new):
3465         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
3466         * MiniBrowser/gtk/BrowserWindow.c:
3467         (settingsCallback):
3468         (browser_window_init):
3469         * MiniBrowser/gtk/GNUmakefile.am:
3470         * MiniBrowser/gtk/browser-marshal.list: Added.
3471
3472 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3473
3474         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
3475         https://bugs.webkit.org/show_bug.cgi?id=74711
3476
3477         Reviewed by Philippe Normand.
3478
3479         * MiniBrowser/gtk/BrowserWindow.c:
3480         (webViewClose): Destroy the window.
3481         (webViewReadyToShow): Use WindowProperties of the new view to
3482         setup and show the window.
3483         (webViewCreate): Create a new view and add it to a browser window.
3484         (browser_window_init):
3485         (browserWindowConstructed): Connect to WebKitWebView::create signal.
3486
3487 2011-12-31  Dan Bernstein  <mitz@apple.com>
3488
3489         MiniBrowser sets the WKView’s frame incorrectly
3490         https://bugs.webkit.org/show_bug.cgi?id=75393
3491
3492         Reviewed by Anders Carlsson.
3493
3494         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
3495         which is not needed since the binray is linked with the frameworks search path set to the
3496         built products directory.
3497         * MiniBrowser/mac/BrowserWindowController.m:
3498         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
3499         container’s bounds rather than its frame.
3500         * MiniBrowser/mac/make-launchable.sh: Removed.
3501
3502 2011-12-29  Dan Bernstein  <mitz@apple.com>
3503
3504         debug-safari --no-saved-state fails to start the debugger
3505         https://bugs.webkit.org/show_bug.cgi?id=75374
3506
3507         Reviewed by Sam Weinig.
3508
3509         * Scripts/webkitdirs.pm:
3510         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
3511         the executable being debugged.
3512
3513 2011-12-29  Sam Weinig  <sam@webkit.org>
3514
3515         It should be easier to iterate a Vector backwards
3516         https://bugs.webkit.org/show_bug.cgi?id=75359
3517
3518         Reviewed by Anders Carlsson.
3519
3520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3521         * TestWebKitAPI/TestWebKitAPI.gypi:
3522         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3523         Add new Vector test.
3524
3525         * TestWebKitAPI/Tests/Vector.cpp: Added.
3526         (TestWebKitAPI::TEST):
3527         Test Vector iterators, reverse_iterators and new reversed proxy.
3528
3529 2011-12-28  Dmitry Lomov  <dslomov@google.com>
3530
3531         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
3532         https://bugs.webkit.org/show_bug.cgi?id=66509
3533         Just renames, merges and removal of dead code. Here are the list of renames:
3534           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
3535           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
3536           - WebWorkerBase merged into WebSharedWorkerImpl
3537           - NewWebWorkerBase renamed into WebWorkerBase
3538  
3539         Reviewed by David Levin.
3540
3541         * DumpRenderTree/chromium/TestWebWorker.h:
3542         (TestWebWorker::createWorker):
3543         * DumpRenderTree/chromium/WebViewHost.cpp:
3544         (WebViewHost::createWorker):
3545         * DumpRenderTree/chromium/WebViewHost.h:
3546
3547 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3548
3549         Unreviewed, rolling out r103785.
3550         http://trac.webkit.org/changeset/103785
3551         https://bugs.webkit.org/show_bug.cgi?id=75332
3552
3553         Broke builders; looks like clobbering didnt help (Requested by
3554         dslomov on #webkit).
3555
3556         * DumpRenderTree/chromium/TestWebWorker.h:
3557         (TestWebWorker::createWorker):
3558         * DumpRenderTree/chromium/WebViewHost.cpp:
3559         (WebViewHost::createWorker):
3560         * DumpRenderTree/chromium/WebViewHost.h:
3561
3562 2011-12-28  Dmitry Lomov  <dslomov@google.com>
3563
3564
3565         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
3566         https://bugs.webkit.org/show_bug.cgi?id=66509
3567         Just renames, merges and removal of dead code. Here are the list of renames:
3568           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
3569           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
3570           - WebWorkerBase merged into WebSharedWorkerImpl
3571           - NewWebWorkerBase renamed into WebWorkerBase
3572  
3573         Reviewed by David Levin.
3574
3575         * DumpRenderTree/chromium/TestWebWorker.h:
3576         (TestWebWorker::createWorker):
3577         * DumpRenderTree/chromium/WebViewHost.cpp:
3578         (WebViewHost::createWorker):
3579         * DumpRenderTree/chromium/WebViewHost.h:
3580
3581 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3582
3583         Unreviewed, rolling out r103620.
3584         http://trac.webkit.org/changeset/103620
3585         https://bugs.webkit.org/show_bug.cgi?id=75316
3586
3587         Causes many crashes (Requested by abarth on #webkit).
3588
3589         * DumpRenderTree/chromium/LayoutTestController.cpp:
3590         (LayoutTestController::LayoutTestController):
3591         (LayoutTestController::reset):
3592         * DumpRenderTree/chromium/LayoutTestController.h:
3593         * DumpRenderTree/chromium/WebViewHost.cpp:
3594         * DumpRenderTree/chromium/WebViewHost.h:
3595
3596 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3597
3598         Unreviewed, rolling out r103734.
3599         http://trac.webkit.org/changeset/103734
3600         https://bugs.webkit.org/show_bug.cgi?id=75278
3601
3602         Broke cr-mac (Requested by dslomov on #webkit).
3603
3604         * DumpRenderTree/chromium/TestWebWorker.h:
3605         (TestWebWorker::createWorker):
3606         * DumpRenderTree/chromium/WebViewHost.cpp:
3607         (WebViewHost::createWorker):
3608         * DumpRenderTree/chromium/WebViewHost.h:
3609
3610 2011-12-27  Dmitry Lomov  <dslomov@google.com>
3611
3612
3613         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
3614         https://bugs.webkit.org/show_bug.cgi?id=66509
3615         Just renames, merges and removal of dead code. Here are the list of renames:
3616           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
3617           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
3618           - WebWorkerBase merged into WebSharedWorkerImpl
3619           - NewWebWorkerBase renamed into WebWorkerBase
3620  
3621         Reviewed by David Levin.
3622
3623         * DumpRenderTree/chromium/TestWebWorker.h:
3624         (TestWebWorker::createWorker):
3625         * DumpRenderTree/chromium/WebViewHost.cpp:
3626         (WebViewHost::createWorker):
3627         * DumpRenderTree/chromium/WebViewHost.h:
3628
3629 2011-12-27  Anders Carlsson  <andersca@apple.com>
3630
3631         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
3632         https://bugs.webkit.org/show_bug.cgi?id=75266
3633
3634         Reviewed by Sam Weinig.
3635
3636         * TestWebKitAPI/Tests/WTF/Functional.cpp:
3637         (TestWebKitAPI::Number::create):
3638         (TestWebKitAPI::Number::~Number):
3639         (TestWebKitAPI::Number::value):
3640         (TestWebKitAPI::Number::Number):
3641         (TestWebKitAPI::multiplyNumberByTwo):
3642         (TestWebKitAPI::TEST):
3643
3644 2011-12-24  Kentaro Hara  <haraken@chromium.org>
3645
3646         Add unittests for the C++ parser of prepare-ChangeLog
3647         https://bugs.webkit.org/show_bug.cgi?id=75191
3648
3649         Reviewed by Ryosuke Niwa.
3650
3651         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
3652         of prepare-ChangeLog.
3653
3654         * Scripts/prepare-ChangeLog:
3655         (get_function_line_ranges): Renames get_function_line_ranges_for_c()