2010-12-22 Lucas Forschler <lforschler@apple.com>
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2
3         Reviewed by Alice Liu.
4
5         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
6         Verified on Chrome, Safari, and IE.
7         With this change, we will record memory from a parent browser window and all child processes.
8
9         * record-memory-win/main.cpp:
10         (ProcessArgs):
11         (PrintUsage):
12         (getMemoryInfo):
13         (printProcessInfo):
14         (evalProcesses):
15         (UseImage):
16         (QueryContinuously):
17         (ElapsedTime):
18
19 2010-12-22  Lucas Forschler  <lforschler@apple.com>
20
21         Unreviewed rollout r74489, because it was missing changelog.
22
23         * record-memory-win/main.cpp:
24         
25 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
26
27         Adding myself as a reviewer.
28
29         * Scripts/webkitpy/common/config/committers.py:
30
31 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
32
33         Unreviewed.  Adding myself to committers.py.
34
35         * Scripts/webkitpy/common/config/committers.py:
36
37 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
38
39         Reviewed by Kenneth Rohde Christiansen.
40
41         TestNetscapePlugIn should use #if defined
42         https://bugs.webkit.org/show_bug.cgi?id=51471
43
44         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
45         (NP_Initialize):
46         (NPP_New):
47
48 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
49
50         Reviewed by Yury Semikhatsky.
51
52         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
53
54         DevTools window should be closed explicitly because it has custom deinitialization code.
55
56         https://bugs.webkit.org/show_bug.cgi?id=50722
57
58         * DumpRenderTree/chromium/TestShell.cpp:
59         (TestShell::closeRemainingWindows):
60
61 2010-12-22  David Levin  <levin@chromium.org>
62
63         Reviewed by Shinichiro Hamaji.
64
65         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
66         https://bugs.webkit.org/show_bug.cgi?id=51452
67
68         * Scripts/webkitpy/style/checkers/cpp.py:
69         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
70         Using the file extension if possible but falling back to the file contents if we have a header file.
71         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
72         (_FileState.is_c_or_objective_c):
73         (check_using_std): Changed to using _FileState to determine the file type.
74         (check_max_min_macros): Ditto.
75         (check_for_null): Ditto.
76         (check_style): Changed the parameters to various calls since they now need _FileState
77         to determine the file type.
78         (check_language): Added the file_state parameter so it could be passed
79         to check_identifier_name_in_declaration.
80         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
81         this is an Objective C file.
82         (_process_lines): Added information for the _FileState constructor (and moved the
83         call to a place that had the information).
84         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
85         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
86         its functionality.
87         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
88
89 2010-12-21  Andy Estes  <aestes@apple.com>
90
91         Reviewed by Mark Rowe.
92
93         Do not build non-Intel architectures for WebKit2-related projects.
94         https://bugs.webkit.org/show_bug.cgi?id=51440
95
96         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
97         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
98         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
99
100 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
101
102         Reviewed by Darin Fisher.
103
104         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
105         https://bugs.webkit.org/show_bug.cgi?id=51406 
106         
107         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
108         to WebThemeEngineDRTWin and update references everywhere.
109
110         * DumpRenderTree/DumpRenderTree.gypi:
111         * DumpRenderTree/chromium/TestShellWin.cpp:
112         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
113         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
114         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
115         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
116
117 2010-12-21  Anders Carlsson  <andersca@apple.com>
118
119         Reviewed by John Sullivan.
120
121         Clicking missing plug-in text does not show a sheet
122         https://bugs.webkit.org/show_bug.cgi?id=51403
123
124         Update for changes to the WebPageUIClient.
125
126         * MiniBrowser/mac/BrowserWindowController.m:
127         (-[BrowserWindowController awakeFromNib]):
128         * WebKitTestRunner/TestController.cpp:
129         (WTR::createOtherPage):
130         (WTR::TestController::initialize):
131
132 2010-12-21  Eric Seidel  <eric@webkit.org>
133
134         Reviewed by Adam Barth.
135
136         commit-queue will report constant failures as flaky if other tests flake
137         https://bugs.webkit.org/show_bug.cgi?id=51272
138
139         This patch just removes functionality and adds testing.
140         Previously we attempted to report flaky tests when we had
141         two different tests fail in a row.  However, since we stop
142         running the tests at the first failure, our code was wrong in
143         trying to determine flakiness from the incomplete runs.
144
145         Originally I posted an alternate patch:
146         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
147         which fixed our flaky logic in this case, however it was decided
148         that that patch would be too difficult to maintain, so now
149         I'm just removing the broken logic.
150
151         This will dramatically cut-down on our flaky-test false positives
152         at the (small) cost of the queues being unable to report
153         any flakiness if the tree is very flaky.  (With at least one test
154         flaking on every run, we'll never report failures anymore.)  I think
155         this is a tradeoff worth making.
156
157         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
158         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
159
160 2010-12-20  Eric Seidel  <eric@webkit.org>
161
162         Reviewed by Adam Barth.
163
164         commit-queue wrongly rejects patches when it can't update itself
165         https://bugs.webkit.org/show_bug.cgi?id=46636
166
167         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
168         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
169         * Scripts/webkitpy/tool/commands/queues_unittest.py:
170
171 2010-12-20  Adam Barth  <abarth@webkit.org>
172
173         Move web sites to Websites directory
174         https://bugs.webkit.org/show_bug.cgi?id=51323
175
176         Update references to BugsSite to point to the new location.
177
178         This patch was never officially reviewed (because it was too large to
179         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
180         Rowe gave me the green light.
181
182         * Scripts/old-run-webkit-tests:
183         * Scripts/webkitpy/common/config/build.py:
184         * Scripts/webkitpy/common/config/build_unittest.py:
185         * Scripts/webkitpy/common/prettypatch.py:
186         * Scripts/webkitpy/layout_tests/port/base.py:
187         * Scripts/webkitpy/style/main.py:
188
189 2010-12-20  Adrienne Walker  <enne@google.com>
190
191         Unreviewed. Adding myself to the list of committers.
192
193         * webkitpy/common/config/committers.py:
194
195 2010-12-20  Mark Rowe  <mrowe@apple.com>
196
197         Reviewed by Dan Bernstein.
198
199         <rdar://problem/8757601> Don't install header files in to the Resources directory.
200
201         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
202         Resources directory.
203
204 2010-12-20  Eric Seidel  <eric@webkit.org>
205
206         Reviewed by Adam Barth.
207
208         commit-queue should include bot id when attaching failure diffs
209         https://bugs.webkit.org/show_bug.cgi?id=51280
210
211         This is a tiny change to include the bot id in the name of the attachment.
212         Most of this diff is just changing the unit test expectations
213         now that I hid the comment printing when the comment is None.
214
215         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
216         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
217         * Scripts/webkitpy/tool/commands/upload_unittest.py:
218         * Scripts/webkitpy/tool/mocktool.py:
219
220 2010-12-20  Jeff Miller  <jeffm@apple.com>
221
222         Reviewed by Dan Bernstein.
223
224         Tools/vcbin/midl.exe needs to be rebuilt
225         https://bugs.webkit.org/show_bug.cgi?id=51347
226
227         * vcbin/midl.exe: Rebuilt.
228
229 2010-12-20  David Levin  <levin@chromium.org>
230
231         Reviewed by Ariya Hidayat.
232
233         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
234         https://bugs.webkit.org/show_bug.cgi?id=51343
235
236         Follow up from the WebKitTools -> Tools rename.
237
238         * Scripts/webkit-tools-completion.sh:
239
240 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
241
242         Reviewed by James Robinson.
243
244         new-run-webkit-tests ignores trailing EOL differences in text tests
245         https://bugs.webkit.org/show_bug.cgi?id=36983
246
247         Changed the handling of new-line characters within new-run-webkit-tests
248         to match old-run-webkit-tests.  Differences in leading and trailing empty
249         lines in text expectation files are no longer ignored.
250
251         * Scripts/webkitpy/layout_tests/port/base.py:
252         * Scripts/webkitpy/layout_tests/port/test.py:
253         Added unit tests.  Removed old duplicate unit test entries.
254         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
255
256 2010-12-20  David Levin  <levin@chromium.org>
257
258         Reviewed by Shinichiro Hamaji.
259
260         check-webkit-style should detect function declarations (and trivial functions).
261         https://bugs.webkit.org/show_bug.cgi?id=51303
262
263         * Scripts/webkitpy/style/checkers/cpp.py:
264         (_FunctionState.begin): Add is_declaration and changed the line count
265         start to begin at -1 (which will keep the results consistent, since
266         the starting line number passed in is one less in this change).
267         (detect_functions): changed function detection to now catch trivial
268         functions and declarations.
269         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
270         of the function as this may look at return values (when processing
271         a declaration).
272         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
273         (FunctionDetectionTest.perform_function_detection): Basic mechanics
274         of testing the function detection.
275         (FunctionDetectionTest.test_basic_function_detection): Test a simple
276         function.
277         (FunctionDetectionTest.test_function_declaration_detection): Test a
278         declaration.
279         (FunctionDetectionTest.test_non_functions): A test case for a case
280         that caused the code to fail due to the { being in quotes.
281         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
282         cases to help catch false alarms for return values.
283         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
284         we don't get false alarms for member variables either.
285
286 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
287
288         Reviewed by Antonio Gomes.
289
290         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
291         https://bugs.webkit.org/show_bug.cgi?id=51319
292
293         * CMakeListsEfl.txt:
294
295 2010-12-18  Adam Barth  <abarth@webkit.org>
296
297         Reviewed by Sam Weinig.
298
299         Move WebKitExamplePlugins to Examples
300         https://bugs.webkit.org/show_bug.cgi?id=51291
301
302         * Scripts/webkitpy/common/config/build.py:
303
304 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
305
306         Unreviewed Qt buildfix after r74301.
307
308         Rename WebKitTools to Tools
309         https://bugs.webkit.org/show_bug.cgi?id=49861
310
311         * MiniBrowser/DerivedSources.pro:
312         * MiniBrowser/qt/MiniBrowser.pro:
313
314 2010-12-17  Dan Bernstein  <mitz@apple.com>
315
316         Reviewed by Simon Fraser.
317
318         Rename WebKitTools to Tools
319         https://bugs.webkit.org/show_bug.cgi?id=49861
320
321         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
322         * CodeCoverage/README:
323         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
324         (WebCore::DumpRenderTree::initializeFonts):
325         * EWSTools/start-commit-queue.sh:
326         * EWSTools/start-queue.sh:
327         * GNUmakefile.am:
328         * MIDLWrapper/MIDLWrapper.cpp:
329         (wmain):
330         * MiniBrowser/qt/MiniBrowser.pro:
331         * Scripts/build-api-tests:
332         * Scripts/build-dumprendertree:
333         * Scripts/build-webkit:
334         * Scripts/build-webkittestrunner:
335         * Scripts/generate-coverage-data:
336         * Scripts/old-run-webkit-tests:
337         * Scripts/run-api-tests:
338         * Scripts/run-iexploder-tests:
339         * Scripts/run-javascriptcore-tests:
340         * Scripts/run-mangleme-tests:
341         * Scripts/run-sunspider:
342         * Scripts/run-webkit-websocketserver:
343         * Scripts/sunspider-compare-results:
344         * Scripts/test-webkitperl:
345         * Scripts/test-webkitpy:
346         * Scripts/update-iexploder-cssproperties:
347         * Scripts/update-webkit:
348         * Scripts/update-webkit-localizable-strings:
349         * Scripts/webkitdirs.pm:
350         * Scripts/webkitpy/common/checkout/scm.py:
351         * Scripts/webkitpy/common/checkout/scm_unittest.py:
352         * Scripts/webkitpy/common/config/committervalidator.py:
353         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
354         * Scripts/webkitpy/common/config/ports.py:
355         * Scripts/webkitpy/common/config/ports_unittest.py:
356         * Scripts/webkitpy/common/system/logutils_unittest.py:
357         * Scripts/webkitpy/common/system/ospath_unittest.py:
358         * Scripts/webkitpy/layout_tests/port/chromium.py:
359         * Scripts/webkitpy/layout_tests/port/config.py:
360         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
361         * Scripts/webkitpy/layout_tests/port/http_server.py:
362         * Scripts/webkitpy/layout_tests/port/test.py:
363         * Scripts/webkitpy/style/checker.py:
364         * Scripts/webkitpy/style/checker_unittest.py:
365         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
366         * Scripts/webkitpy/tool/commands/queues_unittest.py:
367         * Scripts/webkitpy/tool/steps/steps_unittest.py:
368         * WebKitTestRunner/DerivedSources.pro:
369         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
370         (WTR::activateFonts):
371         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
372         * wx/build/build_utils.py:
373
374 2010-12-16  Antonio Gomes  <agomes@rim.com>
375
376         Reviewed by Martin Robinson.
377
378         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
379         https://bugs.webkit.org/show_bug.cgi?id=51163
380
381         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
382         GTK+'s DRT should also reset to UNIX after each test execution.
383
384         * DumpRenderTree/gtk/DumpRenderTree.cpp:
385         (resetDefaultsToConsistentValues):
386
387 2010-12-17  David Levin  <levin@chromium.org>
388
389         Reviewed by Eric Seidel.
390
391         check-webkit-style should understand WTF #include guards
392         https://bugs.webkit.org/show_bug.cgi?id=44911
393
394         * Scripts/webkitpy/style/checkers/cpp.py:
395         (get_header_guard_cpp_variable): modify to suggest the WTF style
396         of header guard when appropriate.
397         (check_for_header_guard): handle multiple return values from
398         get_header_guard_cpp_variable
399         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
400         (CppStyleTest.test_build_header_guard): Added tests for the WTF
401         header style.
402
403 2010-12-16  David Levin  <levin@chromium.org>
404
405         Reviewed by Eric Seidel.
406
407         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
408         https://bugs.webkit.org/show_bug.cgi?id=51210
409
410         The error only shows up when using python 2.6 or later.
411
412         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
413         the decprecated field error,message with something equivalent.
414
415 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
416
417         Reviewed by Eric Seidel.
418
419         Add --exit-after-n-failures/crashes to NRWT
420         https://bugs.webkit.org/show_bug.cgi?id=51160
421         
422         Abort test run (in a similar way to how control-C is handled) when
423         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
424         that number of unexpected failures/crashes/timeouts.
425
426         * Scripts/webkitpy/layout_tests/port/test.py:
427         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
428         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
429
430 2010-12-16  David Levin  <levin@chromium.org>
431
432         Reviewed by Shinichiro Hamaji.
433
434         check-webkit-style unit tests has some duplicate boilerplate code.
435         https://bugs.webkit.org/show_bug.cgi?id=49519
436
437         * Scripts/webkitpy/style/checkers/cpp.py:
438         (update_include_state): Replaced the "io" parameter with the global
439         configuration _unit_test_config. This allowed not calling into
440         functions at a low level and also not plumbing through the injection
441         information through many levels of code.
442         (check_for_include_what_you_use): Ditto.
443         (process_file_data): Added the ability to set up the unit test config
444         to allow for injection.
445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
446         (ErrorCollector.__init__): Added support for having a filter for errors.
447         (ErrorCollector.__call__): Ditto.
448         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
449         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
450         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
451         functions in the cpp.py with generic processing and a filter that
452         indicates what errors should be kept.
453         (CppStyleTestBase.perform_multi_line_lint): Ditto.
454         (CppStyleTestBase.perform_language_rules_check): Ditto.
455         (CppStyleTestBase.perform_function_lengths_check): Ditto.
456         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
457         (CppStyleTestBase.perform_include_what_you_use): Ditto.
458         (CppStyleTest.test_multi_line_comments): Added another
459         error message which applies to the test case.
460         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
461         to not have config.h, since it is processed as a header file.
462         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
463         style and indentation in checked code.
464         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
465         Fixed line number.
466         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
467         Ditto.
468
469 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
470
471         Unreviewed, rolling out r74136.
472         http://trac.webkit.org/changeset/74136
473         https://bugs.webkit.org/show_bug.cgi?id=51135
474
475         r74136 breaks chromium canary bots because some tests are not
476         rebaselined correctly to resolve EOL differences (Requested by
477         jianli on #webkit).
478
479         * Scripts/webkitpy/layout_tests/port/base.py:
480         * Scripts/webkitpy/layout_tests/port/test.py:
481         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
482
483 2010-12-15  Adam Roben  <aroben@apple.com>
484
485         Teach check-webkit-style to check .vcproj and .vsprops files for XML
486         syntax errors
487
488         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
489         XML syntax errors in .vcproj/.vsprops files
490
491         Reviewed by Dave Levin.
492
493         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
494         that should be treated as XML and that should be allowed to contain
495         carriage returns. (These lists happen to be identical currently.)
496         (FileType): Added a new XML type.
497         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
498         Just does a simple file extension check.
499         (CheckerDispatcher._file_type): Added a case for XML files.
500         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
501         files (surprise!).
502         (StyleProcessor.process): Ask the dispatcher whether we should pass the
503         lines through the carriage checker.
504
505         * Scripts/webkitpy/style/checker_unittest.py:
506         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
507         Added. Checks a few file names to see if carriage returns are allowed
508         or not.
509         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
510         other assert_checker_* functions.
511         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
512         test_*_paths functions.
513         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
514         test_*_paths functions.
515         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
516         file from this test case, as vcproj files now have a type.
517         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
518         Added. Similar to the other should_* functions.
519         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
520         Added. Checks that carriage returns aren't checked for or stripped for
521         allowed files.
522
523         * Scripts/webkitpy/style/checkers/xml.py: Added.
524         (XMLChecker.__init__): Simple init method.
525         (XMLChecker.check): Pass each line through the expat parser, and record
526         a style error for any errors thrown by the parser.
527
528         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
529         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
530         produce a style error.
531         (XMLCheckerTest.assert_error): Checks that the given XML produces an
532         error of the given category on the given line.
533         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
534         checking that the XMLChecker constructor works properly.
535         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
536         cause a style error (see, e.g., r73887).
537         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
538         cause a style error (see, e.g., r73773).
539         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
540         properly.
541         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
542         tags cause a style error (see, e.g., r72795).
543         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
544         style error.
545
546 2010-12-15  Lucas Forschler  <lforschler@apple.com>
547
548         Reviewed by Stephanie Lewis.
549
550         https://bugs.webkit.org/show_bug.cgi?id=51117
551         Add a new leopard test bot
552         really really commit to trunk this time.
553
554         * BuildSlaveSupport/build.webkit.org-config/config.json:
555
556 2010-12-15  Sam Weinig  <sam@webkit.org>
557
558         Reviewed by Anders Carlsson.
559
560         WebKit2: Can't add files to an <input type=file>
561         https://bugs.webkit.org/show_bug.cgi?id=51087
562
563         * MiniBrowser/mac/BrowserWindowController.m:
564         (runOpenPanel):
565         (-[BrowserWindowController awakeFromNib]):
566         Add simple implementation of runOpenPanel callback.
567
568         * MiniBrowser/win/BrowserView.cpp:
569         (BrowserView::create):
570         * WebKitTestRunner/TestController.cpp:
571         (WTR::createOtherPage):
572         (WTR::TestController::initialize):
573         Stub out runOpenPanel callback. 
574
575 2010-12-14  Eric Seidel  <eric@webkit.org>
576
577         Reviewed by Adam Barth.
578
579         commit-queue should upload failure diffs when tests flake
580         https://bugs.webkit.org/show_bug.cgi?id=51051
581
582         To make this testable I needed to pipe FileSystem down onto tool.
583         We've wanted it there for a long time anyway.
584
585         This patch is kinda a big hack.  But we don't have a nice
586         way to read results.html files.  I think this will need further
587         revision before this code actually feels clean.
588
589         As part of testing this change, I had to make MockBugzilla.create_bug
590         actually return an id (like it should) which required updating
591         a few other unit test results (for the better).
592
593         The results_matching_keys change in layouttestresults/rebasline
594         was an alternate path which I decided not to use in the end, but
595         I left the change as it seemed an improvement.
596
597         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
598         * Scripts/webkitpy/common/net/layouttestresults.py:
599         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
600         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
601         * Scripts/webkitpy/tool/commands/queues.py:
602         * Scripts/webkitpy/tool/commands/rebaseline.py:
603         * Scripts/webkitpy/tool/main.py:
604         * Scripts/webkitpy/tool/mocktool.py:
605
606 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
607
608         Reviewed by James Robinson.
609
610         new-run-webkit-tests ignores trailing EOL differences in text tests
611         https://bugs.webkit.org/show_bug.cgi?id=36983
612
613         Changed the handling of new-line characters within new-run-webkit-tests
614         to match old-run-webkit-tests.  Differences in leading and trailing empty
615         lines in text expectation files are no longer ignored.
616
617         * Scripts/webkitpy/layout_tests/port/base.py:
618         * Scripts/webkitpy/layout_tests/port/test.py:
619         Added unit tests.  Removed old duplicate unit test entries.
620         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
621
622 2010-12-15  Ojan Vafai  <ojan@chromium.org>
623
624         Reviewed by Adam Barth.
625
626         make status-bubble white-space:nowrap so we can measure it's width without wrapping
627         https://bugs.webkit.org/show_bug.cgi?id=51149
628
629         * QueueStatusServer/templates/statusbubble.html:
630
631 2010-12-15  Ojan Vafai  <ojan@chromium.org>
632
633         Reviewed by Adam Barth.
634
635         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
636         https://bugs.webkit.org/show_bug.cgi?id=51125
637
638         * QueueStatusServer/templates/statusbubble.html:
639
640 2010-12-15  Darin Adler  <darin@apple.com>
641
642         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
643
644 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
645
646         Unreviewed, rolling out r74117.
647         http://trac.webkit.org/changeset/74117
648         https://bugs.webkit.org/show_bug.cgi?id=51113
649
650         This broke the GTK1 build. (Requested by mrobinson on
651         #webkit).
652
653         * Scripts/webkitdirs.pm:
654
655 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
656
657         Reviewed by Martin Robinson.
658
659         Change generate-forwarding-headers.pl for GTK port usage 
660         (https://bugs.webkit.org/show_bug.cgi?id=37369)
661
662         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
663
664 2010-12-14  Kent Tamura  <tkent@chromium.org>
665
666         Reviewed by Jian Li.
667
668         [DRT/Chromium] Remove another unnecessary error message
669         https://bugs.webkit.org/show_bug.cgi?id=51083
670
671         * DumpRenderTree/chromium/WebViewHost.cpp:
672         (WebViewHost::didInvalidateRect):
673
674 2010-12-14  Lucas Forschler  <lforschler@apple.com>
675
676         Reviewed by Stephanie Lewis.
677
678         Add a new Leopard Debug Test WK2 Bot
679
680         * BuildSlaveSupport/build.webkit.org-config/config.json:
681
682 2010-12-14  Ojan Vafai  <ojan@chromium.org>
683
684         Fix python unittests after http://trac.webkit.org/changeset/74070.
685
686         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
687
688 2010-12-14  Kent Tamura  <tkent@chromium.org>
689
690         Reviewed by Jian Li.
691
692         [DRT/Chromium] Remove a unnecessary error message
693         https://bugs.webkit.org/show_bug.cgi?id=51069
694
695         * DumpRenderTree/chromium/WebViewHost.cpp:
696         (WebViewHost::paintInvalidatedRegion):
697
698 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
699
700         Reviewed by Ojan Vafai.
701
702         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
703         https://bugs.webkit.org/show_bug.cgi?id=48926
704
705         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
706         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
707
708 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
709
710         Reviewed by Eric Seidel.
711
712         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
713         https://bugs.webkit.org/show_bug.cgi?id=50231
714
715         Guard CONFIG+=link_pkgconfig with !symbian.
716
717         * DumpRenderTree/qt/DumpRenderTree.pro:
718         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
719         * WebKitTestRunner/qt/WebKitTestRunner.pro:
720
721 2010-12-14  Philippe Normand  <pnormand@igalia.com>
722
723         Reviewed by Ojan Vafai.
724
725         [new-run-webkit-tests] expectations parsing is slow
726         https://bugs.webkit.org/show_bug.cgi?id=50635
727
728         Avoid expensive iteration of all the tests when checking if a test
729         file is to be skipped or not.
730
731         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
732         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
733         * Scripts/webkitpy/layout_tests/port/test.py:
734
735 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
736
737         Reviewed by Xan Lopez.
738
739         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
740         https://bugs.webkit.org/show_bug.cgi?id=27048
741
742         Add support in DRT for checking whether an accessibility UI
743         element is focusable and/or focused. Implemented for GTK.
744
745         * DumpRenderTree/AccessibilityUIElement.cpp:
746         (getIsFocusedCallback): New.
747         (getIsFocusableCallback): New.
748         (AccessibilityUIElement::getJSClass): Add the new available
749         callbacks for isFocused and isFocusable.
750         * DumpRenderTree/AccessibilityUIElement.h:
751         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
752         (AccessibilityUIElement::isFocused): New, implemented by checking
753         whether the related AtkState value is in the object's state set.
754         (AccessibilityUIElement::isFocusable): Ditto.
755         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
756         (AccessibilityUIElement::isFocused): New, dummy implementation.
757         (AccessibilityUIElement::isFocusable): Ditto.
758         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
759         (AccessibilityUIElement::isFocused): Ditto.
760         (AccessibilityUIElement::isFocusable): Ditto.
761
762 2010-12-14  Eric Seidel  <eric@webkit.org>
763
764         Reviewed by Ojan Vafai.
765
766         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
767         https://bugs.webkit.org/show_bug.cgi?id=50715
768
769         This patch makes webkit-patch print the following:
770
771         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
772         Install a 64-bit git for better performance, see:
773         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
774
775         I wrote this mostly because I have approximately 8 machines that I use
776         and making sure each one is using a good Git install seemed folly.
777         webkit-patch makes a lot of git calls, so using a fast git can shave
778         several seconds in every invocation.  See the webkit-dev thread for more info.
779
780         This message will print twice during 'webkit-patch upload',
781         once from webkit-patch and once from check-webkit-style.
782
783         Unfortunately there is no good way to test this due to how machine-dependent
784         the code is.  I considered writing a test for the log message, but it seemed not worth it.
785
786         * Scripts/webkitpy/common/checkout/scm.py:
787
788 2010-12-13  Eric Seidel  <eric@webkit.org>
789
790         Reviewed by Adam Barth.
791
792         FlakyTestReporter doesn't understand bots running from multiple email addresses
793         https://bugs.webkit.org/show_bug.cgi?id=50960
794
795         This explains at least one of the dupes of:
796         https://bugs.webkit.org/show_bug.cgi?id=50863
797         that we saw filed by the commit-queue this morning.
798         I think the other one was explained by my previous fix to result counting code.
799
800         Since this is really hard to test with a unit test, instead I
801         create a new (possibly useful in the future) command
802         which given a layout test path will return you
803         the one bug which our tools would assume it the flaky test bug.
804         If some other script wants to use bug-for-test we'll
805         need to extend it with some options like --create-if-missing or similar.
806
807         * Scripts/webkitpy/common/net/bugzilla/bug.py:
808         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
809         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
810         * Scripts/webkitpy/tool/commands/__init__.py:
811         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
812
813 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
814
815         Reviewed by James Robinson.
816
817         Add option to build-webkit to not build WebKit2
818         https://bugs.webkit.org/show_bug.cgi?id=50988
819         
820         Add support for a --no-webkit2 option to build-webkit. It seems to save
821         ~1 minute from clean builds and ~10 seconds from no-op builds.
822
823         * Scripts/build-webkit:
824
825 2010-12-13  Lucas Forschler  <lforschler@apple.com>
826
827         Reviewed by Dave Kilzer.
828
829         Update iexploder from 1.3.2 to 1.7.2
830         Move 1.3.2 into its own subdir
831         Add 1.7.2 into its own subdir
832         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
833
834         * Scripts/run-iexploder-tests:
835         * Scripts/update-iexploder-cssproperties:
836         * iExploder/CHANGELOG.txt: Removed.
837         * iExploder/LICENSE.txt: Removed.
838         * iExploder/README.txt: Removed.
839         * iExploder/htdocs: Removed.
840         * iExploder/iexploder-1.3.2: Added.
841         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
842         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
843         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
844         * iExploder/iexploder-1.3.2/htdocs: Added.
845         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
846         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
847         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
848         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
849         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
850         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
851         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
852         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
853         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
854         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
855         * iExploder/iexploder-1.3.2/tools: Added.
856         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
857         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
858         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
859         * iExploder/iexploder-1.7.2: Added.
860         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
861         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
862         * iExploder/iexploder-1.7.2/README.txt: Added.
863         * iExploder/iexploder-1.7.2/output: Added.
864         * iExploder/iexploder-1.7.2/src: Added.
865         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
866         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
867         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
868         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
869         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
870         * iExploder/iexploder-1.7.2/src/css-properties: Added.
871         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
872         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
873         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
874         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
875         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
876         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
877         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
878         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
879         * iExploder/iexploder-1.7.2/src/css-values: Added.
880         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
881         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
882         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
883         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
884         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
885         * iExploder/iexploder-1.7.2/src/headers: Added.
886         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
887         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
888         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
889         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
890         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
891         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
892         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
893         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
894         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
895         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
896         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
897         * iExploder/iexploder-1.7.2/src/html-tags: Added.
898         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
899         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
900         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
901         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
902         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
903         * iExploder/iexploder-1.7.2/src/html-values: Added.
904         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
905         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
906         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
907         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
908         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
909         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
910         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
911         * iExploder/iexploder-1.7.2/src/index.html: Added.
912         * iExploder/iexploder-1.7.2/src/media: Added.
913         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
914         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
915         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
916         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
917         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
918         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
919         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
920         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
921         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
922         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
923         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
924         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
925         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
926         * iExploder/iexploder-1.7.2/src/mime-types: Added.
927         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
928         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
929         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
930         * iExploder/iexploder-1.7.2/src/protocols: Added.
931         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
932         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
933         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
934         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
935         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
936         * iExploder/iexploder-1.7.2/src/version.rb: Added.
937         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
938         * iExploder/iexploder-1.7.2/testcases: Added.
939         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
940         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
941         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
942         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
943         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
944         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
945         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
946         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
947         * iExploder/iexploder-1.7.2/tools: Added.
948         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
949         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
950         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
951         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
952         * iExploder/tools: Removed.
953
954 2010-12-13  Sam Weinig  <sam@webkit.org>
955
956         Reviewed by Anders Carlsson.
957
958         Remove associated page concept from WKView constructor
959         https://bugs.webkit.org/show_bug.cgi?id=50983
960
961         Step 1: Remove associate page constructors from WKView and make
962         all views use the shared namespace for the context.
963
964         * TestWebKitAPI/PlatformWebView.h:
965         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
966         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
967         * WebKitTestRunner/PlatformWebView.h:
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::createOtherPage):
970         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
971         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
972         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
973
974 2010-12-13  Sam Weinig  <sam@webkit.org>
975
976         Reviewed by Anders Carlsson.
977
978         Change the WebKit2 public API so there is no explicit WKPageNamespace object
979         https://bugs.webkit.org/show_bug.cgi?id=50898
980
981         * MiniBrowser/mac/AppDelegate.h:
982         * MiniBrowser/mac/AppDelegate.m:
983         * MiniBrowser/mac/BrowserWindowController.h:
984         * MiniBrowser/mac/BrowserWindowController.m:
985         * MiniBrowser/win/BrowserView.cpp:
986         Convert MiniBrowser to not use PageNamespaces.
987
988         * TestWebKitAPI/PlatformWebView.h:
989         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
990         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
991         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
992         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
993         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
994         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
995         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
996         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
997         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
998         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
999         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1000         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1001         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1002         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1003         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1004         Convert TestWebKitAPI to not use PageNamespaces.
1005
1006         * WebKitTestRunner/PlatformWebView.h:
1007         * WebKitTestRunner/TestController.cpp:
1008         * WebKitTestRunner/TestController.h:
1009         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1010         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1011         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1012         Convert WebKitTestRunner to not use PageNamespaces.
1013
1014 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1015
1016         Reviewed by Eric Seidel.
1017
1018         webkit-patch rollout should be able to do multi-revision rollouts
1019         https://bugs.webkit.org/show_bug.cgi?id=33336
1020
1021         Make it possible to pass more than one revision to webkit-patch.
1022
1023         * Scripts/webkitpy/common/checkout/api.py:
1024         * Scripts/webkitpy/common/checkout/changelog.py:
1025         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1026         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1027         * Scripts/webkitpy/tool/commands/download.py:
1028         * Scripts/webkitpy/tool/commands/download_unittest.py:
1029         * Scripts/webkitpy/tool/mocktool.py:
1030         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1031         * Scripts/webkitpy/tool/steps/revertrevision.py:
1032
1033 2010-12-13  Eric Seidel  <eric@webkit.org>
1034
1035         Unreviewed.
1036
1037         Teach webkit-patch how to search bugzilla
1038         https://bugs.webkit.org/show_bug.cgi?id=50500
1039
1040         webkit-patch bug-search fails when there is only one result.
1041         Turns out we needed a bit more logic in our result count parsing code.
1042
1043         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1044         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1045
1046 2010-12-13  Antti Koivisto  <antti@apple.com>
1047
1048         Reviewed by Alexey Proskuryakov.
1049
1050         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1051         https://bugs.webkit.org/show_bug.cgi?id=50758
1052
1053         * DumpRenderTree/LayoutTestController.cpp:
1054         (setSerializeHTTPLoadsCallback):
1055         (LayoutTestController::staticFunctions):
1056         * DumpRenderTree/LayoutTestController.h:
1057         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1058         (LayoutTestController::setSerializeHTTPLoads):
1059         * DumpRenderTree/mac/DumpRenderTree.mm:
1060         (resetDefaultsToConsistentValues):
1061         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1062         (LayoutTestController::setSerializeHTTPLoads):
1063         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1064         (LayoutTestController::setSerializeHTTPLoads):
1065
1066 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1067
1068         Reviewed by Ojan Vafai.
1069
1070         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1071         https://bugs.webkit.org/show_bug.cgi?id=50936
1072
1073         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1074
1075 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1076
1077         Reviewed by Csaba Osztrogonác.
1078
1079         Add revlink to BuildBot status
1080         https://bugs.webkit.org/show_bug.cgi?id=50914
1081
1082         This adds a hyperlink to trac changeset on the revision numbers. 
1083
1084         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1085
1086 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1087
1088         Reviewed by Csaba Osztrogonác.
1089
1090         [Qt][WK2] Fix build if WebKitTools are not available
1091         https://bugs.webkit.org/show_bug.cgi?id=50242
1092
1093         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1094         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1095         * MiniBrowser/DerivedSources.pro: Added.
1096
1097 2010-12-13  Eric Seidel  <eric@webkit.org>
1098
1099         Reviewed by Adam Barth.
1100
1101         EWS Queues should remove orpahned pyc files before starting
1102         https://bugs.webkit.org/show_bug.cgi?id=50904
1103
1104         A previous check added a platform.py which caused
1105         EWS bots on some platforms to hit an import exception.
1106         The platform.py file was removed in a subsequent commit, but
1107         the EWS bots in question stayed stuck.  This change will
1108         fix those bots once restarted (and prevent this in the future).
1109
1110         I also went ahead and unified start-queue and start-commit-queue
1111         since they were nearly identical.  I also added bot_id support
1112         to both force all EWSes to have bot ids as well as get rid of the one
1113         remaining reason why I had my own copies of these scripts.
1114         Hopefully this will be enough to get all the other bot admins
1115         (ahem, Adam, ahem) to move to using these checked in copies as well.
1116
1117         * EWSTools/start-commit-queue.sh: Removed.
1118         * EWSTools/start-queue.sh:
1119
1120 2010-10-28  MORITA Hajime  <morrita@google.com>
1121
1122         Reviewed by Ojan Vafai.
1123
1124         spellcheck does not check pasted text
1125         https://bugs.webkit.org/show_bug.cgi?id=40092
1126
1127         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1128         to control the setting.
1129
1130         * DumpRenderTree/LayoutTestController.cpp:
1131         (setAsynchronousSpellCheckingEnabledCallback):
1132         (LayoutTestController::staticFunctions):
1133         * DumpRenderTree/LayoutTestController.h:
1134         * DumpRenderTree/chromium/LayoutTestController.h:
1135         * DumpRenderTree/chromium/LayoutTestController.cpp:
1136         (LayoutTestController::LayoutTestController):
1137         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1138         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1139         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1140         * DumpRenderTree/mac/DumpRenderTree.mm:
1141         (resetDefaultsToConsistentValues):
1142         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1143         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1144         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1145         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1146         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1147         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1148         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1149         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1150         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1151
1152 2010-12-12  Sam Weinig  <sam@webkit.org>
1153
1154         Reviewed by Anders Carlsson.
1155
1156         Fix failing API test. It turns out that a pop-state event
1157         is sent before every fragment navigation, so we have to test
1158         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1159
1160         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1161         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1162
1163 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1164
1165         Reviewed by Eric Seidel.
1166
1167         [GTK] Add new-run-webkit-tests support to gtk
1168         https://bugs.webkit.org/show_bug.cgi?id=50681
1169
1170         Adding the basic support to run the new-run-webkit-tests.
1171
1172         * Scripts/webkitpy/layout_tests/port/gtk.py:
1173
1174 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1175
1176         Reviewed by Kenneth Rohde Christiansen.
1177
1178         [Qt] Mock DeviceOrientation client for DRT
1179         https://bugs.webkit.org/show_bug.cgi?id=47490
1180
1181         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1182         (WebCore::DumpRenderTree::DumpRenderTree):
1183         (WebCore::DumpRenderTree::~DumpRenderTree):
1184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1185         (LayoutTestController::setMockDeviceOrientation):
1186
1187 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1188
1189         Reviewed by Gustavo Noronha Silva.
1190
1191         [GTK] launcher: disable the Mozilla-style fullscreen API
1192         https://bugs.webkit.org/show_bug.cgi?id=50874
1193
1194         Disabling the fullscreen API until its implementation for GTK is
1195         mature enough. The webview setting for it is already FALSE by
1196         default.
1197
1198         * GtkLauncher/main.c:
1199         (createWindow):
1200
1201 2010-12-10  Eric Seidel  <eric@webkit.org>
1202
1203         Reviewed by Adam Barth.
1204
1205         commit-queue flaky test messages show cryptic version information for mac os x
1206         https://bugs.webkit.org/show_bug.cgi?id=50864
1207
1208         Turns out platform.platform() returns kernel version information
1209         which isn't helpful, and just plain confusing on Mac
1210         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1211
1212         So I've updated PlatformInfo.display_name() to special case
1213         mac.  I also found a bad use of sys.platform in the process
1214         and fixed that.  (sys.platform always returns 'darwin' on mac).
1215
1216         * Scripts/webkitpy/common/system/platforminfo.py:
1217         * Scripts/webkitpy/common/system/user.py:
1218         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1219         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1220         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1221
1222 2010-12-10  Eric Seidel  <eric@webkit.org>
1223
1224         Unreviewed.
1225
1226         Exception seen while reporting flaky test with commit-queue.
1227         Just a missing include.
1228
1229         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1230         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1231
1232 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1233
1234         Reviewed by Eric Seidel.
1235
1236         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1237         https://bugs.webkit.org/show_bug.cgi?id=50796
1238
1239         Also updating the test code to use JSONResultsGeneratorBase and
1240         to improve test coverage for incremental cases.
1241
1242         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1243         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1244
1245 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1246
1247         Reviewed by Darin Adler.
1248
1249         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1250         https://bugs.webkit.org/show_bug.cgi?id=50835
1251
1252         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1253
1254 2010-12-10  Eric Seidel  <eric@webkit.org>
1255
1256         Reviewed by Adam Barth.
1257
1258         Bugs created by the commit-queue should all block on a master bug
1259         https://bugs.webkit.org/show_bug.cgi?id=50857
1260
1261         This makes all bugs created by the commit-queue block on:
1262         https://bugs.webkit.org/show_bug.cgi?id=50856
1263
1264         In the process of testing this, I found that the existing
1265         create_bug code was wrong.  I also found that existing
1266         unit tests for create-rollout used invalid values
1267         for options.blocks.  I fixed both issues and tested.
1268
1269         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1270         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1271         * Scripts/webkitpy/tool/commands/commandtest.py:
1272         * Scripts/webkitpy/tool/commands/download_unittest.py:
1273         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1274         * Scripts/webkitpy/tool/mocktool.py:
1275         * Scripts/webkitpy/tool/steps/options.py:
1276
1277 2010-12-10  Eric Seidel  <eric@webkit.org>
1278
1279         Reviewed by Adam Barth.
1280
1281         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1282         https://bugs.webkit.org/show_bug.cgi?id=50853
1283
1284         I also discovered when doing this that the code was posting
1285         the comment on the wrong bug, but that's fixed here too.
1286
1287         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1288         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1289         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1290         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1291         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1292         * Scripts/webkitpy/tool/mocktool.py:
1293
1294 2010-12-10  Anders Carlsson  <andersca@apple.com>
1295
1296         Reviewed by John Sullivan.
1297
1298         Make WKContextGetStatistics gather global statistics
1299         https://bugs.webkit.org/show_bug.cgi?id=50850
1300
1301         Remove the code that gets the statistics and fills in the per context
1302         statistics information for now.
1303
1304         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1305         (-[BrowserStatisticsWindowController refreshStatistics:]):
1306
1307 2010-12-10  Eric Seidel  <eric@webkit.org>
1308
1309         Unreviewed.
1310
1311         commit-queue should report port/platform information when commenting on flaky test bugs
1312         https://bugs.webkit.org/show_bug.cgi?id=50839
1313
1314         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1315         which was only used by new run webkit tests (and clearly not unit tested).
1316
1317         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1318         * Scripts/webkitpy/tool/main.py:
1319         * Scripts/webkitpy/tool/mocktool.py:
1320
1321 2010-12-10  Eric Seidel  <eric@webkit.org>
1322
1323         Reviewed by Tony Chang.
1324
1325         commit-queue should report port/platform information when commenting on flaky test bugs
1326         https://bugs.webkit.org/show_bug.cgi?id=50839
1327
1328         This was a suggestion from Tony Chang this morning.
1329         I added a platform.py class so I could easily mock the platform call,
1330         but that may not be the final solution for this mocking.
1331         We'll try it and see.
1332
1333         * Scripts/webkitpy/common/system/platform.py: Added.
1334         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1335         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1336         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1337         * Scripts/webkitpy/tool/main.py:
1338         * Scripts/webkitpy/tool/mocktool.py:
1339
1340 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1341
1342         Reviewed by Joseph Pecoraro.
1343
1344         Bug 43455 - [Qt]: Implement Application Cache Quotas
1345         https://bugs.webkit.org/show_bug.cgi?id=43455
1346
1347         Introduce functions to allow new appcache layout test origin-quota.html
1348         to work correctly under Qt.
1349
1350         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1351         (WebCore::DumpRenderTree::DumpRenderTree):
1352         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1353         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1354
1355         Introduce functions to allow new appcache layout test origin-quota.html
1356         to be successful under qt. Changes required because LayoutTestControllerQt
1357         does not inherit from LayoutController.
1358
1359         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1360         (LayoutTestController::reset):
1361         (LayoutTestController::clearAllApplicationCaches):
1362         (LayoutTestController::setApplicationCacheOriginQuota):
1363         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1364         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1365         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1366
1367 2010-12-10  Eric Seidel  <eric@webkit.org>
1368
1369         Reviewed by Adam Barth.
1370
1371         Move buildbot.py into its own module so we can split it out into one-file-per-class
1372         https://bugs.webkit.org/show_bug.cgi?id=50806
1373
1374         We're adding more buildbot logic these days, so it makes sense
1375         to give buildbot its own module.
1376
1377         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1378         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1379         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1380         * Scripts/webkitpy/common/net/failuremap.py:
1381         * Scripts/webkitpy/common/net/regressionwindow.py:
1382         * Scripts/webkitpy/tool/commands/rebaseline.py:
1383
1384 2010-12-10  Tony Chang  <tony@chromium.org>
1385
1386         Reviewed by Eric Seidel.
1387
1388         Use FileSystem::remove when cleaning up http lock files
1389         https://bugs.webkit.org/show_bug.cgi?id=50830
1390
1391         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1392
1393 2010-12-10  Joone Hur  <joone@kldp.org>
1394
1395         Reviewed by Martin Robinson.
1396
1397         [GTK] DRT needs layoutTestController.setCacheModel
1398         https://bugs.webkit.org/show_bug.cgi?id=50705
1399         
1400         webkit_set_cache_mode() is called to set the cache model.
1401         
1402         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1403         (LayoutTestController::setCacheModel): Set the cache model. 
1404
1405 2010-12-10  Tony Chang  <tony@chromium.org>
1406
1407         Reviewed by Ojan Vafai.
1408
1409         [chromium] remove --use-drt and add --use-test-shell
1410         https://bugs.webkit.org/show_bug.cgi?id=50701
1411
1412         * Scripts/webkitpy/common/config/ports.py:
1413         * Scripts/webkitpy/common/config/ports_unittest.py:
1414         * Scripts/webkitpy/layout_tests/port/chromium.py:
1415         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1416         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1417         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1418         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1419         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1420         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1421         * Scripts/webkitpy/layout_tests/port/webkit.py:
1422         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1423         * Scripts/webkitpy/style/checkers/test_expectations.py:
1424         * Scripts/webkitpy/tool/commands/queries.py:
1425
1426 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1427
1428         Reviewed by Steve Block.
1429
1430         [Chromium] Implement mocks for client-based geolocation
1431         https://bugs.webkit.org/show_bug.cgi?id=46895
1432
1433         * DumpRenderTree/chromium/LayoutTestController.cpp:
1434         (LayoutTestController::setGeolocationPermission):
1435         (LayoutTestController::setMockGeolocationPosition):
1436         (LayoutTestController::setMockGeolocationError):
1437         * DumpRenderTree/chromium/LayoutTestController.h:
1438         * DumpRenderTree/chromium/WebViewHost.cpp:
1439         (WebViewHost::geolocationClient):
1440         (WebViewHost::geolocationClientMock):
1441         (WebViewHost::reset):
1442         * DumpRenderTree/chromium/WebViewHost.h:
1443
1444 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1445
1446         Reviewed by Martin Robinson.
1447
1448         [GTK] Add hasSpellingMarker support to the DRT
1449         https://bugs.webkit.org/show_bug.cgi?id=50739
1450
1451         Implemented the hasSpellingMarker to support spelling tests.
1452
1453         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1454         (LayoutTestController::hasSpellingMarker):
1455
1456 2010-12-10  Eric Seidel  <eric@webkit.org>
1457
1458         Reviewed by Ojan Vafai.
1459
1460         webkit-patch: not possible to use build-and-test with local commits
1461         https://bugs.webkit.org/show_bug.cgi?id=33378
1462
1463         Make --no-clean not even check if we have local commits.
1464         It's unclear to me why the code was originally written this way.
1465         I was unable to dig up a reason from svn history.
1466
1467         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1468         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1469
1470 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1471
1472         Reviewed by Martin Robinson.
1473
1474         [GTK] AX: implement isEnabled in DRT
1475         https://bugs.webkit.org/show_bug.cgi?id=50814
1476
1477         Implement AccessibilityUIElement::isEnabled() for GTK.
1478
1479         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1480         (checkElementState): New function to refactor common code.
1481         (AccessibilityUIElement::isEnabled): Implement this by checking
1482         the current state of the AtkObject.
1483         (AccessibilityUIElement::isSelected): Use the new
1484         checkElementState function.
1485
1486 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1487
1488         Reviewed by Kenneth Rohde Christiansen.
1489
1490         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1491         https://bugs.webkit.org/show_bug.cgi?id=50750
1492
1493         * MiniBrowser/qt/BrowserView.cpp:
1494         (BrowserView::BrowserView):
1495         * MiniBrowser/qt/BrowserView.h:
1496         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1497         (WTR::WebView::WebView):
1498
1499 2010-12-10  Joone Hur  <joone@kldp.org>
1500
1501         Reviewed by Xan Lopez.
1502
1503         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1504         https://bugs.webkit.org/show_bug.cgi?id=50808
1505
1506         Unskipping the following test cases:
1507         userscripts/mixed-case-stylesheet.html
1508         userscripts/simple-stylesheet.html
1509         userscripts/user-style-all-frames.html
1510
1511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1512         (LayoutTestController::addUserStyleSheet):
1513
1514 2010-12-10  Joone Hur  <joone@kldp.org>
1515
1516         Reviewed by Eric Seidel.
1517
1518         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1519         https://bugs.webkit.org/show_bug.cgi?id=50783
1520
1521         This patch allows to unskip the following test cases:
1522         printing/page-rule-selection.html
1523         printing/page-format-data.html
1524
1525         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1526         (LayoutTestController::pageProperty): Added.
1527         (LayoutTestController::isPageBoxVisible): Ditto.
1528         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1529         (LayoutTestController::addUserStyleSheet): Ditto.
1530
1531 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1532
1533         Reviewed by Kenneth Rohde Christiansen.
1534
1535         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1536
1537         A menu allows to switch QNAM back to the same thread.
1538
1539         * QtTestBrowser/launcherwindow.cpp:
1540         (LauncherWindow::initializeView):
1541         (LauncherWindow::createChrome):
1542         (LauncherWindow::toggleThreadedQnam):
1543         * QtTestBrowser/launcherwindow.h:
1544         (WindowOptions::WindowOptions):
1545         * QtTestBrowser/webpage.cpp:
1546         (WebPage::WebPage):
1547         (WebPage::setQnamThreaded):
1548         * QtTestBrowser/webpage.h:
1549         (QnamThread::QnamThread):
1550         (QnamThread::~QnamThread):
1551         (QnamThread::networkAccessManager):
1552         (QnamThread::run):
1553
1554 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1555
1556         Reviewed by Xan Lopez.
1557
1558         [Gtk] style="font-family: courier" makes text disappear
1559         https://bugs.webkit.org/show_bug.cgi?id=47452
1560
1561         Add a test that verifies that fonts without valid charmaps are
1562         never selected.
1563
1564         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1565         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1566         that has no valid charmap.
1567         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1568         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1569         settings which may disable selection of bitmap fonts.
1570
1571 2010-12-10  Eric Seidel  <eric@webkit.org>
1572
1573         Unreviewed.
1574
1575         The commit-queue should file bugs about flaky tests it encounters
1576         https://bugs.webkit.org/show_bug.cgi?id=50803
1577
1578         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1579         Now it's tested.
1580
1581         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1582         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1583
1584 2010-12-10  Eric Seidel  <eric@webkit.org>
1585
1586         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1587
1588         The commit-queue should file bugs about flaky tests it encounters
1589         https://bugs.webkit.org/show_bug.cgi?id=50803
1590
1591         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1592
1593 2010-12-09  Eric Seidel  <eric@webkit.org>
1594
1595         Reviewed by Adam Barth.
1596
1597         The commit-queue should file bugs about flaky tests it encounters
1598         https://bugs.webkit.org/show_bug.cgi?id=50803
1599
1600         This change got a bit big.  I also added a new config.urls file
1601         because I needed to share the view_source_url code with committervalidator.py.
1602
1603         This adds a new class FlakyTestReporter which holds all the logic about
1604         reporting flaky tests to bugzilla.
1605
1606         Right now this code knows how to look up bugs for flaky tests.
1607         If it can't find a bug filed from the commit-queue, it will open a new
1608         one, ccing the relevant people and adding information about the failure.
1609
1610         It is not yet smart enough to chase down duplicate chains, or to include
1611         the actual failure diff.  But those can be added in later iterations.
1612
1613         * Scripts/webkitpy/common/checkout/api.py:
1614         * Scripts/webkitpy/common/checkout/changelog.py:
1615         * Scripts/webkitpy/common/checkout/commitinfo.py:
1616         * Scripts/webkitpy/common/config/committervalidator.py:
1617         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1618         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1619         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1620         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1621         * Scripts/webkitpy/tool/bot/irc_command.py:
1622         * Scripts/webkitpy/tool/bot/sheriff.py:
1623         * Scripts/webkitpy/tool/commands/download.py:
1624         * Scripts/webkitpy/tool/commands/queues.py:
1625         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1626         * Scripts/webkitpy/tool/comments.py:
1627         * Scripts/webkitpy/tool/mocktool.py:
1628         * Scripts/webkitpy/tool/steps/commit.py:
1629
1630 2010-12-09  Eric Seidel  <eric@webkit.org>
1631
1632         Reviewed by Adam Barth.
1633
1634         Teach webkit-patch how to search bugzilla
1635         https://bugs.webkit.org/show_bug.cgi?id=50500
1636
1637         This is a step towards teaching webkitpy how to file
1638         new bugs for flaky tests and update them when new flakes occur.
1639
1640         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1641         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1642         * Scripts/webkitpy/tool/commands/__init__.py:
1643         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1644
1645 2010-12-09  Adam Barth  <abarth@webkit.org>
1646
1647         Reviewed by Ojan Vafai.
1648
1649         commit-queue errors out due to local commits
1650         https://bugs.webkit.org/show_bug.cgi?id=50766
1651
1652         We seem to be tripping over having local commits in the working copy a
1653         lot recently.  I don't quite fully understand what the issue is, but
1654         this patch attempts to solve the problem by adding an explicit clean
1655         step before processing a patch.  Previously, we did the cleaning as
1656         part of the apply-attachment step, so this might not actually fix the
1657         problem.
1658
1659         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1660         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1661         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1662
1663 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1664
1665         Reviewed by Ojan Vafai.
1666
1667         Make new-run-webkit-tests --lint-test-files log slightly better
1668         messages and return -1 if lint fails. Remove the
1669         'suppress_errors' keyword param to the TestExpectationsFile
1670         class, and clean up logging and exception raising for error
1671         handling. Also add more unit tests and clean up the unit test code a bit.
1672
1673         https://bugs.webkit.org/show_bug.cgi?id=50205
1674
1675         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1676         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1677         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1678         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1679         * Scripts/webkitpy/layout_tests/port/chromium.py:
1680         * Scripts/webkitpy/style/checkers/test_expectations.py:
1681         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1682
1683 2010-12-09  Tony Chang  <tony@chromium.org>
1684
1685         Unreviewed, fix for windows code.  We were catching the wrong
1686         exception in Windows.
1687
1688         * Scripts/webkitpy/common/system/filesystem.py:
1689
1690 2010-12-09  Antonio Gomes  <agomes@rim.com>
1691
1692         Reviewed by Martin Robinson.
1693
1694         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1695         https://bugs.webkit.org/show_bug.cgi?id=48429
1696
1697         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1698
1699         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1700         (LayoutTestController::workerThreadCount):
1701
1702 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1703
1704         Reviewed by Martin Robinson.
1705
1706         [GTK] Support the Mozilla-style Fullscreen Javascript API
1707         https://bugs.webkit.org/show_bug.cgi?id=50572
1708
1709         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1710         make DRT update the Chrome when the WebView settings have been
1711         reset to consistent values.
1712
1713         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1714         (resetDefaultsToConsistentValues):
1715         * GtkLauncher/main.c:
1716         (create_window):
1717         * Scripts/build-webkit:
1718
1719 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1720
1721         Reviewed by Tor Arne Vestbø
1722
1723         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1724         https://bugs.webkit.org/show_bug.cgi?id=50742
1725
1726         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1727
1728         * Scripts/webkitdirs.pm:
1729
1730 2010-12-09  Joone Hur  <joone@kldp.org>
1731
1732          Reviewed by Martin Robinson.
1733
1734          [GTK] Support for viewport meta tag
1735          https://bugs.webkit.org/show_bug.cgi?id=45443
1736
1737          Add support for testing the viewport properties for WebKitGtk.
1738
1739          * DumpRenderTree/LayoutTestController.cpp:
1740          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1741          (LayoutTestController::staticFunctions):
1742          * DumpRenderTree/LayoutTestController.h:
1743          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1744          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1745          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1746          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1747          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1748          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1749          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1750          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1751          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1752          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1753
1754 2010-12-08  William Siegrist <wsiegrist@apple.com>
1755
1756         Reviewed by Eric Seidel.
1757
1758         Migrate buildbot.py from xmlrpc to json.
1759         https://bugs.webkit.org/show_bug.cgi?id=50647
1760
1761         * Scripts/webkitpy/common/net/buildbot.py:
1762
1763 2010-12-08  Tony Chang  <tony@chromium.org>
1764
1765         Reviewed by Eric Seidel.
1766
1767         make starting the websocket server more reliable on windows
1768         https://bugs.webkit.org/show_bug.cgi?id=50712
1769
1770         * Scripts/webkitpy/common/system/filesystem.py:
1771         (remove): Substitute method for os.remove to retry on error on Windows
1772         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1773         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1774
1775 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1776
1777         Reviewed by Adam Roben.
1778
1779         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1780         https://bugs.webkit.org/show_bug.cgi?id=50656
1781
1782         * MiniBrowser/mac/BrowserWindowController.m:
1783         (-[BrowserWindowController awakeFromNib]):
1784         Indicate that exceededDatabaseQuota is not implemented.
1785         * MiniBrowser/win/BrowserView.cpp:
1786         (BrowserView::create):
1787         Ditto.
1788         * WebKitTestRunner/TestController.cpp:
1789         (WTR::createOtherPage):
1790         Ditto.
1791         (WTR::TestController::initialize):
1792         Ditto.
1793
1794 2010-12-08  Antonio Gomes  <agomes@rim.com>
1795
1796         Reviewed by Martin Robinson.
1797
1798         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1799         https://bugs.webkit.org/show_bug.cgi?id=48429
1800
1801         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1802         * webkit_gc_collect_javascript_objects;
1803         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1804         * webkit_gc_count_javascript_objects;
1805         * webkit_web_frame_layout.
1806
1807         These were all only used by GTK+ DRT.
1808
1809         * DumpRenderTree/gtk/EventSender.cpp:
1810         (dispatchEvent):
1811         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1812         (GCController::collect):
1813         (GCController::collectOnAlternateThread):
1814         (GCController::getJSObjectCount):
1815
1816 2010-12-07  Tony Chang  <tony@chromium.org>
1817
1818         Reviewed by Ojan Vafai.
1819
1820         [chromium] force NRWT to use DRT
1821         https://bugs.webkit.org/show_bug.cgi?id=50359
1822
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824
1825 2010-12-06  Sam Weinig  <sam@webkit.org>
1826
1827         Reviewed by Anders Carlsson.
1828
1829         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1830         https://bugs.webkit.org/show_bug.cgi?id=50584
1831
1832         * MiniBrowser/mac/BrowserWindowController.m:
1833         (didSameDocumentNavigationForFrame):
1834         (-[BrowserWindowController awakeFromNib]):
1835         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1836         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1837         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1838         (TestWebKitAPI::TEST):
1839         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1840         (WTR::InjectedBundlePage::InjectedBundlePage):
1841         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1842         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::initialize):
1845
1846 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1847
1848         Reviewed by Ojan Vafai.
1849
1850         Make TestResultsServer return 404 for non-existing results files.
1851         https://bugs.webkit.org/show_bug.cgi?id=50581
1852
1853         * TestResultServer/handlers/testfilehandler.py:
1854
1855 2010-12-06  Tony Chang  <tony@chromium.org>
1856
1857         Reviewed by Ojan Vafai.
1858
1859         [chromium] fix an assert hit in DRT
1860         https://bugs.webkit.org/show_bug.cgi?id=50575
1861
1862         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1863         semantics.
1864
1865         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1866         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1867         WTF::RefCountedBase::ref()).
1868
1869         * DumpRenderTree/chromium/TestWebWorker.h:
1870         (TestWebWorker::TestWebWorker):
1871
1872 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1873
1874         Reviewed by Eric Seidel.
1875
1876         make webkit-patch command work when the git branch is not synced to the remote svn branch
1877         https://bugs.webkit.org/show_bug.cgi?id=50424
1878
1879         * Scripts/webkitpy/common/checkout/scm.py:
1880         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1881
1882 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1883
1884         Reviewed by Andreas Kling.
1885
1886         [WINCE] Add build system
1887         https://bugs.webkit.org/show_bug.cgi?id=50522
1888
1889         * CMakeListsWinCE.txt: Added.
1890
1891 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1892
1893         Reviewed by Tony Chang.
1894
1895         Allow the Chromium port to have Leopard-specific baselines
1896         https://bugs.webkit.org/show_bug.cgi?id=50506
1897
1898         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1899
1900 2010-12-03  Tony Chang  <tony@chromium.org>
1901
1902         Reviewed by Kent Tamura.
1903
1904         [chromium] fix 2 bugs with inspector tests in DRT
1905         https://bugs.webkit.org/show_bug.cgi?id=50492
1906
1907         Tasks can outlive the tasklist (even when canceled) so this was
1908         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1909         when a task is canceled.
1910
1911         Also fix an assert when closing devtool windows by copying some
1912         logic from test_shell.
1913
1914         * DumpRenderTree/chromium/Task.cpp:
1915         (WebTask::~WebTask):
1916         (TaskList::revokeAll):
1917         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1918             the tasklist (since the task can outlive the tasklist).
1919         * DumpRenderTree/chromium/TestShell.h:
1920         (TestShell::devToolsWebView):
1921         * DumpRenderTree/chromium/WebViewHost.cpp:
1922         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1923             a window if the window has devtools loaded.  This avoids an
1924             ASSERT and matches test_shell.
1925
1926 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1927
1928         Reviewed by Martin Robinson.
1929
1930         [GTK] Fix GtkLauncher.c style, use webkit style
1931         https://bugs.webkit.org/show_bug.cgi?id=50542
1932
1933         * GtkLauncher/main.c:
1934         (activateUriEntryCb):
1935         (updateTitle):
1936         (linkHoverCb):
1937         (notifyTitleCb):
1938         (notifyLoadStatusCb):
1939         (notifyProgressCb):
1940         (destroyCb):
1941         (goBackCb):
1942         (goForwardCb):
1943         (create_webViewCb):
1944         (webViewReadyCb):
1945         (closeWebViewCb):
1946         (createBrowser):
1947         (createStatusbar):
1948         (createToolbar):
1949         (createWindow):
1950         (main):
1951
1952 2010-12-04  Antonio Gomes  <agomes@rim.com>
1953
1954         Reviewed by Martin Robinson.
1955
1956         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1957         https://bugs.webkit.org/show_bug.cgi?id=48429
1958
1959         Moved more private method declared with WEBKIT_API to
1960         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1961
1962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1963         (resetDefaultsToConsistentValues):
1964         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1965         (LayoutTestController::addOriginAccessWhitelistEntry):
1966         (LayoutTestController::execCommand):
1967         (LayoutTestController::isCommandEnabled):
1968
1969 2010-12-04  Antonio Gomes  <agomes@rim.com>
1970
1971         Reviewed by Andreas Kling.
1972
1973         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1974
1975         Method was removed by http://trac.webkit.org/changeset/71604
1976
1977         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1978
1979 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1980
1981         Reviewed by Xan Lopez.
1982
1983         [GTK] Fix compilation warnings reported by clang
1984         https://bugs.webkit.org/show_bug.cgi?id=50252
1985
1986         * GtkLauncher/main.c:
1987         (create_window): The create_statusbar function does not have
1988         parameters.
1989
1990 2010-12-05  Robert Hogan  <robert@webkit.org>
1991
1992         Reviewed by Andreas Kling.
1993
1994         [Qt] Zero-sized font does not yet work
1995
1996         Fix fast/text/font-size-zero.html
1997
1998         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1999
2000         https://bugs.webkit.org/show_bug.cgi?id=49759
2001
2002         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2003         (WebCore::WebPage::WebPage):
2004
2005 2010-12-04  Sam Weinig  <sam@webkit.org>
2006
2007         Reviewed by Jon Honeycutt.
2008
2009         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2010         https://bugs.webkit.org/show_bug.cgi?id=50511
2011
2012         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2013         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2014
2015         * MiniBrowser/mac/BrowserWindowController.m:
2016         (didChangeLocationWithinPageForFrame):
2017         (-[BrowserWindowController awakeFromNib]):
2018         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2019         * TestWebKitAPI/PlatformUtilities.cpp:
2020         (TestWebKitAPI::Util::toWK):
2021         * TestWebKitAPI/PlatformUtilities.h:
2022         (TestWebKitAPI::Util::adoptWK):
2023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2024         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2025         (TestWebKitAPI::nullJavaScriptCallback):
2026         (TestWebKitAPI::didFinishLoadForFrame):
2027         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2030         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2031         * TestWebKitAPI/win/copy-resources.cmd:
2032         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2033         (WTR::InjectedBundlePage::InjectedBundlePage):
2034         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2035         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2036         * WebKitTestRunner/TestController.cpp:
2037         (WTR::TestController::initialize):
2038
2039 2010-11-08  Antonio Gomes  <agomes@rim.com>
2040
2041         Reviewed by Martin Robinson.
2042
2043         [Gtk] Populate DumpRenderTreeSupportGtk
2044         https://bugs.webkit.org/show_bug.cgi?id=48429
2045
2046         Made the previous calls to webkit_web_frame* functions defined as private
2047         APIs in webkitprivate.h go through DRTSupportGtk.
2048
2049         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2050         (AccessibilityController::focusedElement):
2051         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2052         (dumpFramesAsText):
2053         (resetDefaultsToConsistentValues):
2054         (dump):
2055         (webViewDocumentLoadFinished):
2056         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2057         (LayoutTestController::counterValueForElementById):
2058         (LayoutTestController::pageNumberForElementById):
2059         (LayoutTestController::numberOfPages):
2060         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2061         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2062         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2063         (LayoutTestController::numberOfActiveAnimations):
2064         (LayoutTestController::suspendAnimations):
2065         (LayoutTestController::resumeAnimations):
2066         (LayoutTestController::markerTextForListItem):
2067
2068 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2069
2070         Reviewed by Tony Chang.
2071
2072         Rebaseline server: use pretty text diff output
2073         https://bugs.webkit.org/show_bug.cgi?id=50484
2074         
2075         Serve *-pretty-diff.html for text diff output.
2076
2077         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2078         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2079         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2080         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2081
2082 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2083
2084         Unreviewed, rolling out r73302.
2085         http://trac.webkit.org/changeset/73302
2086         https://bugs.webkit.org/show_bug.cgi?id=50499
2087
2088         Causes crashes in debug LayoutTests (Requested by xan_ on
2089         #webkit).
2090
2091         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2092         (AccessibilityUIElement::AccessibilityUIElement):
2093         (AccessibilityUIElement::parentElementCallback):
2094         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2095         * DumpRenderTree/chromium/CppBoundClass.cpp:
2096         * DumpRenderTree/chromium/CppBoundClass.h:
2097
2098 2010-12-03  Sam Weinig  <sam@webkit.org>
2099
2100         Reviewed by Maciej Stachowiak.
2101
2102         Enable <a ping> for Mac/Windows/WebKit2 builds
2103         <rdar://problem/8504473>
2104         https://bugs.webkit.org/show_bug.cgi?id=50488
2105
2106         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2107         (TestWebKitAPI::TEST): Test that the default value of
2108         WKPreferencesGetHyperlinkAuditingEnabled is true.
2109
2110 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2111
2112         Reviewed by Chris Fleizach.
2113
2114         Include the FrameView widget of a RenderWidget in the accessibility tree.
2115         https://bugs.webkit.org/show_bug.cgi?id=49106
2116
2117         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2118         (AccessibilityUIElement::AccessibilityUIElement):
2119         (AccessibilityUIElement::parentElementCallback):
2120         (AccessibilityUIElement::isEqualCallback):
2121         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2122         * DumpRenderTree/chromium/CppBoundClass.cpp:
2123         (CppBoundClass::getFromCppVariant):
2124         * DumpRenderTree/chromium/CppBoundClass.h:
2125
2126 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2127
2128         Reviewed by Tony Chang.
2129
2130         Rebaseline server: organize tests by state, add dry run mode
2131         https://bugs.webkit.org/show_bug.cgi?id=50473
2132         
2133         Group tests in the menu by state, so that it's easier to see after
2134         processing the queue which failed.
2135         
2136         Add support for the --dry-run flag so that it's easier to test changes
2137         such as this (stubs out filesystem and SCM operations).
2138
2139         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2140         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2141         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2142
2143 2010-12-03  Brady Eidson  <beidson@apple.com>
2144
2145         Reviewed by Anders Carlsson.
2146
2147         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2148         WebKit2 Authentication Support
2149
2150         Keep these builds working:
2151         * MiniBrowser/mac/BrowserWindowController.m:
2152         (-[BrowserWindowController awakeFromNib]):
2153
2154         * WebKitTestRunner/TestController.cpp:
2155         (WTR::TestController::initialize):
2156
2157 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2158
2159         Reviewed by Tony Chang.
2160
2161         Rebaseline server: move existing baselines
2162         https://bugs.webkit.org/show_bug.cgi?id=50421
2163         
2164         Implement moving of existing baselines: move all files that are about
2165         to be overwriten by update baselines.
2166         
2167         Also fix a typo in the UI JS.
2168
2169         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2170         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2171         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2172
2173 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2174
2175         Unreviewed, rolling out r73211.
2176         http://trac.webkit.org/changeset/73211
2177         https://bugs.webkit.org/show_bug.cgi?id=50450
2178
2179         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2180         yutak on #webkit).
2181
2182         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2183
2184 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2185
2186         Unreviewed, rolling out r73222.
2187         http://trac.webkit.org/changeset/73222
2188         https://bugs.webkit.org/show_bug.cgi?id=50449
2189
2190         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2191         (Requested by yutak on #webkit).
2192
2193         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2194         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2195         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2196         * Scripts/webkitpy/layout_tests/port/base.py:
2197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2198         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2199
2200 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2201
2202         Unreviewed, rolling out r73228.
2203         http://trac.webkit.org/changeset/73228
2204         https://bugs.webkit.org/show_bug.cgi?id=50448
2205
2206         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2207         (Requested by yutak on #webkit).
2208
2209         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2210         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2211         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2212         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2213         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2214
2215 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2216
2217         Unreviewed, rolling out r73231.
2218         http://trac.webkit.org/changeset/73231
2219         https://bugs.webkit.org/show_bug.cgi?id=50443
2220
2221         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2222         (Requested by yutak on #webkit).
2223
2224         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2225         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2227         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2228
2229 2010-12-03  David Levin  <levin@chromium.org>
2230
2231         Reviewed by Shinichiro Hamaji.
2232
2233         check-webkit-style: false positive reported for #if macro
2234         https://bugs.webkit.org/show_bug.cgi?id=48242
2235
2236         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2237           all preprocessor commands.
2238         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2239
2240 2010-12-02  Eric Seidel  <eric@webkit.org>
2241
2242         Reviewed by Adam Barth.
2243
2244         Update the EWSTools scripts to use modern-style git repos
2245         https://bugs.webkit.org/show_bug.cgi?id=50402
2246
2247         * EWSTools/create-webkit-git:
2248         * EWSTools/start-commit-queue.sh:
2249         * EWSTools/start-queue.sh:
2250
2251 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2252
2253         Fix Chromium Linux plugin tests by not logging
2254         unconditionally from the event handling code.
2255
2256         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2257         (handleEventX11):
2258
2259 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2260
2261         Reviewed by Tony Chang.
2262
2263         nrwt multiprocessing - move logic back into run_webkit_tests
2264
2265         This change moves a bunch of logic that I had put into
2266         message_broker back into run_webkit_tests, in a slightly
2267         different format. WorkerMessageBroker needed to become less aware of
2268         the logic the TestRunner class uses, and more generic.
2269         Eventually the MessageBroker will only do generic messaging and
2270         thread/process-pooling, and (almost) all of the
2271         run-webkit-tests-specific logic will be moved to
2272         run_webkit_tests.py and dump_render_tree_thread.py.
2273         
2274         The biggest changes are that the Broker can now start a single
2275         worker, but the responsibility for starting all of them is pushed
2276         back to the TestRunner (Manager), and the logic for checking if
2277         the threads are done or wedged is moved back to TestRunner. We
2278         also remove WorkerMessageBroker.cleanup (not needed) and
2279         cancel_workers (they have to be cancelled individually).
2280         
2281         The  message_broker is now encapsulated inside
2282         TestRunner._run_tests(); it only needs to exist while actually
2283         running the tests.
2284
2285         Also, delete a bunch of tests in message_broker_unittest that no
2286         longer make much sense.
2287
2288         This patch depends on bug 50372.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=50374
2291
2292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2293         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2294         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2295         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2296         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2297
2298 2010-12-02  Hayato Ito  <hayato@chromium.org>
2299
2300         Reviewed by Eric Seidel.
2301
2302         Refactor test_types's compare_output() method so that it takes a
2303         TestInput object.
2304
2305         compare_output() will need additional information included in a TestInput
2306         object to support reftests. This change is a pre-requirement of that.
2307
2308         https://bugs.webkit.org/show_bug.cgi?id=50362
2309
2310         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2311         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2312         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2313         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2314         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2315
2316 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2317
2318         Reviewed by Anders Carlsson.
2319
2320         Add the ability to run script on 'new' and 'paint' in the test plugin
2321         https://bugs.webkit.org/show_bug.cgi?id=50425
2322         
2323         Add "onnew" and "onpaintevent" attributes to the test plugin,
2324         so that tests can run JS at these times.
2325
2326         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2327         (pluginAllocate):
2328         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2329         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2330         (NPP_New):
2331         (NPP_Destroy):
2332         (handleEventCarbon):
2333         (handleEventCocoa):
2334         (NPP_HandleEvent):
2335
2336 2010-12-02  Sam Weinig  <sam@webkit.org>
2337
2338         Fix Qt build.
2339
2340         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2341         (WTR::PlatformWebView::PlatformWebView):
2342
2343 2010-12-02  Sam Weinig  <sam@webkit.org>
2344
2345         Reviewed by Anders Carlsson.
2346
2347         WebKit2 Preferences should be held off the PageGroup, not the Context
2348         https://bugs.webkit.org/show_bug.cgi?id=50414
2349
2350         Update for API changes.
2351
2352         * WebKitTestRunner/PlatformWebView.h:
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::createOtherPage):
2355         (WTR::TestController::initialize):
2356         (WTR::TestController::resetStateToConsistentValues):
2357         * WebKitTestRunner/TestController.h:
2358         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2359         (WTR::PlatformWebView::PlatformWebView):
2360         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2361         (WTR::PlatformWebView::PlatformWebView):
2362
2363 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2364
2365         Reviewed by Tony Chang.
2366
2367         new-run-webkit-tests: minor cleanup for multiprocessing work
2368
2369         This change:
2370         * moves worker naming into TestShellThread, eliminating a
2371           parameter to the constructor and putting the responsibility in
2372           the correct place.
2373         * eliminates the _WorkerState() class in message_broker, because
2374           it turns out that state really needs to be in run_webkit_tests
2375         * renames the Broker classes to be module-private.
2376         * fixes a bunch of minor commenting and whitespace issues to
2377           make subsequent patches a bit clearer.
2378         * Adds a Port hook for default_worker_model() so that we can
2379           accomodate the potential for different worker models on
2380           different ports.
2381         * merge in the fix from 50420 for the brokenness introduced in
2382           bug 50367.
2383
2384         This patch depends on bug 50367.
2385
2386         https://bugs.webkit.org/show_bug.cgi?id=50372
2387
2388         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2389         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2390         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2391         * Scripts/webkitpy/layout_tests/port/base.py:
2392         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2393         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2394
2395 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2396
2397         Reviewed by Tony Chang.
2398
2399         This change is a bunch of cleanup / refactoring of the file
2400         below. It moves a bunch of free functions to methods on the
2401         TestShellThread class, and restructures other methods to be
2402         closer to the structure we'll need for the multiprocessing
2403         rewrite.
2404
2405         It also makes the logic of --run-singly a *lot* easier to follow
2406         by nestling all of the separate-thread logic into a single
2407         routine.
2408
2409         There should be no semantic changes in this patch, just cleanup.
2410
2411         https://bugs.webkit.org/show_bug.cgi?id=50367
2412
2413         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2414
2415 2010-12-02  Tony Chang  <tony@chromium.org>
2416
2417         Unreviewed, rolling out r73164.
2418         http://trac.webkit.org/changeset/73164
2419         https://bugs.webkit.org/show_bug.cgi?id=50359
2420
2421         broke debugger tests on win
2422
2423         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2424
2425 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2426
2427         Reviewed by Tony Chang.
2428
2429         Rebaseline server: add updating of baselines
2430         https://bugs.webkit.org/show_bug.cgi?id=50305
2431         
2432         Implements updating of baselines, where we copy -actual.* files over
2433         the current -expected.* files. To do this, we need a
2434         _get_actual_result_files method to get test results files and a
2435         _rebaseline_test method to actually do the file copy and SCM operation.
2436         _rebaseline_test logs output into a buffer, this is useful for both
2437         showing result in the UI and for unit tests.
2438         
2439         To make passing around of the various test environment properties
2440         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2441         class for them.
2442         
2443         Moving of existing baselines is not implemented yet, this patch is big
2444         enough as it is.
2445
2446         * Scripts/webkitpy/common/system/filesystem.py:
2447         * Scripts/webkitpy/common/system/filesystem_mock.py:
2448         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2449         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2450         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2451         * Scripts/webkitpy/tool/mocktool.py:
2452
2453 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2454
2455         Unreviewed build fix after vcproj updates.
2456
2457         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2458         that WIN_CAIRO is defined for this build.
2459         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2460         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2461         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2462
2463 2010-12-02  Sam Weinig  <sam@webkit.org>
2464
2465         Reviewed by Anders Carlsson.
2466
2467         WebKit2 needs API to turn on popup blocking
2468         https://bugs.webkit.org/show_bug.cgi?id=50407
2469
2470         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2471         (TestWebKitAPI::TEST):
2472         * WebKitTestRunner/TestController.cpp:
2473         (WTR::TestController::resetStateToConsistentValues):
2474
2475 2010-12-01  Tony Chang  <tony@chromium.org>
2476
2477         Reviewed by Ojan Vafai.
2478
2479         [chromium] force NRWT to use DRT
2480         https://bugs.webkit.org/show_bug.cgi?id=50359
2481
2482         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2483
2484 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2485
2486         Reviewed by Xan Lopez.
2487
2488         [GTK] DumpRenderTree has two copies of JavaScriptCore
2489         https://bugs.webkit.org/show_bug.cgi?id=49877
2490
2491         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2492         LDADD list for DumpRenderTree.
2493
2494 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2495
2496         Unreviewed: Added myself to list of Committers.
2497
2498         * Scripts/webkitpy/common/config/committers.py:
2499
2500 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2501
2502         Reviewed by Adam Barth.
2503
2504         build-webkit --chromium always updates DEPS and re-generates project files
2505         https://bugs.webkit.org/show_bug.cgi?id=50340
2506         
2507         Make build-webkit --chromium invoke update-webkit-chromium only when
2508         --update-chromium is passed in, so that we don't add 20 seconds to all
2509         builds.
2510         
2511         Making all invocations update was added with r61883, with the goal of
2512         making EWS bots always update. The bots will switch to using this flag
2513         (as will all other webkit-patch build steps) so nothing should change
2514         for them.
2515
2516         * Scripts/webkitdirs.pm:
2517         * Scripts/webkitpy/common/config/ports.py:
2518         * Scripts/webkitpy/common/config/ports_unittest.py:
2519
2520 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2521
2522         Reviewed by Tony Chang.
2523
2524         new-run-webkit-tests: add a --dry-run / -n flag
2525         https://bugs.webkit.org/show_bug.cgi?id=50045
2526
2527         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2528         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2529
2530 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2531
2532         Reviewed by Adam Roben.
2533
2534         WinCairo build should not use link-time code generation (LTCG)
2535         https://bugs.webkit.org/show_bug.cgi?id=50353
2536
2537         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2538         * DumpRenderTree/win/DumpRenderTree.vcproj:
2539         * DumpRenderTree/win/ImageDiff.vcproj:
2540         * FindSafari/FindSafari.vcproj:
2541         * MiniBrowser/MiniBrowser.vcproj:
2542         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2543         * WebKitAPITest/WebKitAPITest.vcproj:
2544         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2545         * WebKitTestRunner/win/InjectedBundle.vcproj:
2546         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2547         * WinLauncher/WinLauncher.vcproj:
2548         * record-memory-win/record-memory-win.vcproj:
2549
2550 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2551
2552         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2553         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2554         adding the file to the sources list was not enough to force the rebuild.
2555
2556         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2557         Remove an empty line at the end of this file to force a rebuild.
2558
2559 2010-12-01  Sam Weinig  <sam@webkit.org>
2560
2561         Fix windows build.
2562
2563         * MiniBrowser/win/BrowserView.cpp:
2564         (BrowserView::create):
2565
2566 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2567
2568         Add missing file to the TestNetscapePlugin sources list after r73057.
2569
2570         * GNUmakefile.am: Add missing file.
2571
2572 2010-12-01  Sam Weinig  <sam@webkit.org>
2573
2574         Reviewed by Anders Carlsson.
2575
2576         Add PageGrouping to WebKit2 API
2577         https://bugs.webkit.org/show_bug.cgi?id=50332
2578
2579         - Update testing harnesses to deal with new PageGroup API.
2580
2581         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2582         (WKBundleInitialize):
2583         * TestWebKitAPI/InjectedBundleController.cpp:
2584         (TestWebKitAPI::InjectedBundleController::initialize):
2585         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2586         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2587         * TestWebKitAPI/InjectedBundleController.h:
2588         * TestWebKitAPI/InjectedBundleTest.h:
2589         (TestWebKitAPI::InjectedBundleTest::initialize):
2590         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2591         * TestWebKitAPI/PlatformUtilities.cpp:
2592         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2593         * TestWebKitAPI/PlatformUtilities.h:
2594         * TestWebKitAPI/PlatformWebView.h:
2595         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2596         (TestWebKitAPI::TEST):
2597         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2598         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2599         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2600         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2601         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2602         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2604         (WTR::InjectedBundle::didInitializePageGroup):
2605         (WTR::InjectedBundle::initialize):
2606         (WTR::InjectedBundle::beginTesting):
2607         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2608         (WTR::InjectedBundle::pageGroup):
2609         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2610         (WTR::LayoutTestController::addUserScript):
2611         (WTR::LayoutTestController::addUserStyleSheet):
2612         (WTR::LayoutTestController::setXSSAuditorEnabled):
2613         * WebKitTestRunner/TestController.cpp:
2614         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2615         (WTR::PlatformWebView::PlatformWebView):
2616
2617 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2618
2619         Reviewed by Adam Roben.
2620
2621         vcproj changes can't be applied cleanly by the Windows EWS bot
2622         https://bugs.webkit.org/show_bug.cgi?id=50328
2623
2624         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2625         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2626         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2627         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2628         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2629         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2630         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2631         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2632         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2633         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2634         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2635         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2636         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2637         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2638         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2639         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2640         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2641         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2642         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2643         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2644         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2645         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2646         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2647         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2648         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2649         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2650         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2651         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2652         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2653         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2654         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2655         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2656         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2657         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2658         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2659         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2660         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2661         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2662         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2663         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2664         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2665         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2666         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2667         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2668         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2669
2670 2010-12-01  Anders Carlsson  <andersca@apple.com>
2671
2672         Reviewed by Darin Adler.
2673
2674         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2675         https://bugs.webkit.org/show_bug.cgi?id=50336
2676
2677         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2678         Add new test.
2679
2680         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2681         (PluginTest::NPP_New):
2682         Add default implementation/
2683
2684         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2685         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2686         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2687         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2688         Get the user agent.
2689
2690         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2691         (NPP_New):
2692         Call PluginTest::NPP_New.
2693
2694         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2695         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2696         Add new files.
2697
2698         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2699         (webkit_test_plugin_new_instance):
2700         Call PluginTest::NPP_New.
2701
2702 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2703
2704         [wx] Build fixes after recent trunk changes.
2705
2706         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2707         (LayoutTestController::findString):
2708         * wx/build/settings.py:
2709
2710 2010-12-01  Dan Bernstein  <mitz@apple.com>
2711
2712         Reviewed by Darin Adler.
2713
2714         WebKitTestRunner needs layoutTestController.findString
2715         https://bugs.webkit.org/show_bug.cgi?id=50238
2716
2717         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2718         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2719         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2720         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2721
2722 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2723
2724         Try using svn:eol-style native on a vcproj file.
2725
2726         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2727
2728 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2729
2730         Reviewed by Adam Roben.
2731
2732         [WINCE] Add WinCELauncher
2733         https://bugs.webkit.org/show_bug.cgi?id=50217
2734
2735         * WinCELauncher/main.cpp: Added.
2736
2737 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2738
2739         Reviewed by Kenneth Rohde Christiansen.
2740
2741         [Qt] Implement layoutTestController.findString
2742         https://bugs.webkit.org/show_bug.cgi?id=50236
2743
2744         Add the missing function to the LayoutTestController.
2745
2746         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2747         (LayoutTestController::findString):
2748         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2749
2750 2010-11-30  Tony Chang  <tony@chromium.org>
2751
2752         Reviewed by Adam Barth.
2753
2754         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2755         https://bugs.webkit.org/show_bug.cgi?id=49036
2756
2757         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2758             for CppVariants.
2759         (LayoutTestController::cppVariantToBool):
2760         (LayoutTestController::cppVariantToInt32):
2761         (LayoutTestController::setDatabaseQuota):
2762         (LayoutTestController::evaluateInWebInspector):
2763         (LayoutTestController::setMockGeolocationError):
2764
2765 2010-11-30  Eric Seidel  <eric@webkit.org>
2766
2767         Reviewed by Tony Chang.
2768
2769         update-webkit should call git fetch before git svn rebase
2770         https://bugs.webkit.org/show_bug.cgi?id=50273
2771
2772         After discussion on webkit-dev, we've decided to move the "default"
2773         git setup to pulling updates from git.webkit.org in preference
2774         to rebuilding the local svn index using git svn fetch every time.
2775
2776         This change should have no effect on people using the "old" git setup
2777         and should dramatically increase the speed of updates for those using
2778         the "new" git setup along with update-webkit.  I'm about to move the
2779         EWS and other queues over to this setup once this lands.
2780
2781         * Scripts/update-webkit:
2782
2783 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2784
2785         Reviewed by Xan Lopez.
2786
2787         GTK: AX: implement press in DRT
2788         https://bugs.webkit.org/show_bug.cgi?id=36146
2789
2790         Implement AccessibilityUIElement::press() for GTK.
2791
2792         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2793         (AccessibilityUIElement::press): Implemented.
2794
2795 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2796
2797         Reviewed by Tony Chang.
2798
2799         config.webkit_base_dir returns a path with a trailing slash
2800         https://bugs.webkit.org/show_bug.cgi?id=50197
2801         
2802         config.webkit_base_dir() should return a path without a trailing slash,
2803         like all the other methods that return paths.
2804         
2805         Undoes MockFileSytem changes by r72640, since they're no longer
2806         necessary for GetBaselinesTest to pass.
2807
2808         * Scripts/webkitpy/common/system/filesystem_mock.py:
2809         * Scripts/webkitpy/layout_tests/port/base.py:
2810         * Scripts/webkitpy/layout_tests/port/config.py:
2811         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2812
2813 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2814
2815         Reviewed by Tony Chang.
2816
2817         Rebaseline server: baseline display tweaks
2818         https://bugs.webkit.org/show_bug.cgi?id=50207
2819         
2820         Determine which baselines were used when running the tests and highlight
2821         them in the UI. Sort platform names alphabetically.
2822         
2823         Also makes the server URL be launched in the user's browser
2824         automatically.
2825
2826         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2827         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2828         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2829         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2830         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2831
2832 2010-11-30  Dan Bernstein  <mitz@apple.com>
2833
2834         Reviewed by Anders Carlsson.
2835
2836         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2837         https://bugs.webkit.org/show_bug.cgi?id=50238
2838
2839         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2840         (WTR::LayoutTestController::findString): Added.
2841         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2842
2843 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2844
2845         Reviewed by Adam Roben.
2846
2847         All projects on Windows should use cmd files for build events
2848         https://bugs.webkit.org/show_bug.cgi?id=50213
2849
2850         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2851         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2852         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2853         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2854         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2855         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2856         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2857         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2858         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2859         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2860         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2861         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2862         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2863         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2864         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2865         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2866         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2867         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2868         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2869         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2870         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2871         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2872         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2873         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2874         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2875         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2876         * WinLauncher/WinLauncherCommon.vsprops:
2877         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2878         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2879
2880 2010-11-29  Dan Bernstein  <mitz@apple.com>
2881
2882         GTK DumpRenderTree build fix after r72887.
2883
2884         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2885         (LayoutTestController::findString):
2886
2887 2010-11-29  Dan Bernstein  <mitz@apple.com>
2888
2889         Windows DumpRenderTree build fix after r72887.
2890
2891         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2892         (LayoutTestController::findString): Added empty implementation.
2893
2894 2010-11-29  Dan Bernstein  <mitz@apple.com>
2895
2896         Reviewed by Darin Adler.
2897
2898         DumpRenderTree changes for testing the text search API.
2899         https://bugs.webkit.org/show_bug.cgi?id=50038
2900
2901         * DumpRenderTree/LayoutTestController.cpp:
2902         (findStringCallback):
2903         (LayoutTestController::staticFunctions):
2904         * DumpRenderTree/LayoutTestController.h:
2905         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2906         (LayoutTestController::findString):
2907         * MiniBrowser/mac/BrowserWindowController.m:
2908         (-[BrowserWindowController find:]):
2909
2910 2010-11-29  Johnny Ding  <jnd@chromium.org>
2911
2912         Unreviewed: Add myself to the list of Committers.
2913
2914         * Scripts/webkitpy/common/config/committers.py:
2915
2916 2010-11-29  Mark Rowe  <mrowe@apple.com>
2917
2918         Reviewed by Adele Peterson.
2919
2920         <rdar://problem/8694997> DumpRenderTree fails to build.
2921
2922         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2923
2924 2010-11-29  Mark Rowe  <mrowe@apple.com>
2925
2926         Reviewed by Adele Peterson.
2927
2928         <rdar://problem/8694997> DumpRenderTree fails to build.
2929
2930         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2931         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2932         * DumpRenderTree/mac/PerlSupport/Makefile:
2933
2934 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2935
2936         Reviewed by Martin Robinson.
2937
2938         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2939         https://bugs.webkit.org/show_bug.cgi?id=50154
2940
2941         Added missing checks to allAttributes().
2942
2943         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2944         (AccessibilityUIElement::allAttributes): Added missing checks.
2945
2946 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2947
2948         Reviewed by Kenneth Rohde Christiansen.
2949
2950         [Qt] Allow pre-generation for package builds for WebKit2
2951         https://bugs.webkit.org/show_bug.cgi?id=50139
2952
2953         Use a build variable for the generated directory path and set the
2954         value based on CONFIG just like for WebKit1.
2955
2956         For non-package builds use a relative base path for the
2957         genrated directory just like for WebKit1.
2958
2959         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2960         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2961
2962 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2963
2964         Reviewed by Kenneth Rohde Christiansen.
2965
2966         [Qt] Move some build logic from Qt to platform independent code
2967         https://bugs.webkit.org/show_bug.cgi?id=50134
2968
2969         Create target directories inside generate-forwarding-headers.pl.
2970
2971         * Scripts/generate-forwarding-headers.pl:
2972
2973 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2974
2975         Reviewed by Martin Robinson.
2976
2977         [GTK] Windowless plugins gets broken key input
2978         https://bugs.webkit.org/show_bug.cgi?id=49927
2979
2980         Convert the XEvent::keycode to ASCII before printing it. Not
2981         doing this was causing false positive in 
2982         plugins/keyboard-events.html.
2983
2984         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2985         (keycode_to_char):
2986         (webkit_test_plugin_handle_event):
2987
2988 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2989
2990         Reviewed by Antonio Gomes.
2991
2992         [Qt] Html autofocus not working with QGraphicsWebView
2993         https://bugs.webkit.org/show_bug.cgi?id=43169
2994
2995         Tell the scene to set the webview item as the currently
2996         focused item. This makes the input field with autofocus get
2997         focus as it should.
2998
2999         * QtTestBrowser/webview.cpp:
3000         (WebViewGraphicsBased::WebViewGraphicsBased):
3001
3002 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3003
3004         Reviewed by Tony Chang.
3005
3006         nrwt - clean up create_driver interface and print out the
3007         command line used for DumpRenderTree/TestShell.
3008
3009         This patch adds a driver_cmd_line() call to the Port class in
3010         order to retrive the command line to print it out (as part of
3011         --print config).
3012
3013         In addition, this patch cleans up the Port.create_driver()
3014         signature and the Driver constructor interface to take a worker
3015         number and no longer require the image_path argument (Chromium's
3016         drivers now synthesize the image_path from the worker number
3017         internally).
3018
3019         https://bugs.webkit.org/show_bug.cgi?id=49934
3020
3021         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3022         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3023         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3024         * Scripts/webkitpy/layout_tests/port/base.py:
3025         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3026         * Scripts/webkitpy/layout_tests/port/chromium.py:
3027         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3028         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3029         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3030         * Scripts/webkitpy/layout_tests/port/test.py:
3031         * Scripts/webkitpy/layout_tests/port/webkit.py:
3032         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3033         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3034
3035 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3036
3037         Reviewed by Tony Chang.
3038
3039         [chromium] improve memory usage for test results server and store fewer runs
3040         https://bugs.webkit.org/show_bug.cgi?id=50035
3041
3042         Store fewer runs and don't pass full files around when we only need bools.
3043         Greatly improves error rates on test-results.appspot.com.
3044
3045         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3046         * TestResultServer/handlers/testfilehandler.py:
3047         * TestResultServer/model/dashboardfile.py:
3048         * TestResultServer/model/jsonresults.py:
3049
3050 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3051
3052         Reviewed by Tony Chang.
3053
3054         This patch implements the first part of the manager side of the
3055         Broker objects - it handles creating threads, waiting for them
3056         to complete, and running a single-threaded loop as well.
3057
3058         https://bugs.webkit.org/show_bug.cgi?id=49779
3059
3060         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3061         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3062         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3063         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3064
3065 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3066
3067         Reviewed by David Levin.
3068
3069         DRT should not generate pixel output for text/plain tests
3070         https://bugs.webkit.org/show_bug.cgi?id=50002
3071         
3072         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3073         when encountering a text/plain response (the Chromium one already does
3074         this, and none of the other ports special-case text/plain output in
3075         the first place).
3076
3077         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3078         (dump):
3079         * DumpRenderTree/mac/DumpRenderTree.mm:
3080         (dump):
3081         * DumpRenderTree/win/DumpRenderTree.cpp:
3082         (dump):
3083
3084 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3085
3086         Unreviewed.
3087
3088         Add my other email address to committers.py.
3089
3090         * Scripts/webkitpy/common/config/committers.py:
3091
3092 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3093
3094         Reviewed by Csaba Osztrogonác.
3095
3096         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3097         https://bugs.webkit.org/show_bug.cgi?id=49975
3098
3099         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3100         to enable the script to define it 0 in case of a minimal build.
3101
3102 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3103
3104         Reviewed by Xan Lopez.
3105
3106         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3107         https://bugs.webkit.org/show_bug.cgi?id=49143
3108
3109         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3110         (createWebView): Call the new connectEditingCallbacks function.
3111         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3112         (dumpNodePath):
3113         (dumpRange):
3114         (insertActionString):
3115         (selectionAffinityString):
3116         (shouldBeginEditing):
3117         (shouldEndEditing):
3118         (shouldInsertNode):
3119         (shouldInsertText):
3120         (shouldDeleteRange):
3121         (shouldShowDeleteInterfaceForElement):
3122         (shouldChangeSelectedRange):
3123         (shouldApplyStyle):
3124         (editingBegan):
3125         (userChangedContents):
3126         (editingEnded):
3127         (selectionChanged):
3128         (connectEditingCallbacks):
3129         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3130         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3131
3132 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3133
3134         Reviewed by Andreas Kling.
3135
3136         [Qt] Make QtTestBrowser remember the selected user agent
3137         https://bugs.webkit.org/show_bug.cgi?id=50021
3138
3139         Set user agent for a new page by using the old page's
3140
3141         * QtTestBrowser/mainwindow.cpp:
3142         (MainWindow::setPage):
3143
3144 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3145
3146         Reviewed by Csaba Osztrogonác.
3147
3148         Remove Bakefile build system files
3149         https://bugs.webkit.org/show_bug.cgi?id=49983
3150
3151         r53757 only removed the content, but not the files.
3152         This patch removes that empty files.
3153
3154         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3155         * wx/browser/browser.bkl: Removed.
3156         * wx/build-wxwebkit: Removed.
3157
3158 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3159
3160         Reviewed by Tony Chang.
3161
3162         This patch cleans up the logic used to shard tests into groups a
3163         bit and adds the --worker-model flag to NRWT. The flag is only
3164         used at the moment to control whether to run single-threaded or
3165         not, but eventually will also allow toggling between threads and
3166         processes.
3167
3168         Also add a minor cleanup with _test_is_slow(), which just
3169         eliminates some repetition and gives slightly better encapsulation.
3170
3171         https://bugs.webkit.org/show_bug.cgi?id=49773
3172
3173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3174         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3175
3176 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3177
3178         Reviewed by Tony Chang.
3179
3180         Rebaseline server: list current baselines and platforms
3181         https://bugs.webkit.org/show_bug.cgi?id=49991
3182         
3183         List existing baselines (with Trac links) for tests.
3184         
3185         Add dropdowns for choosing with platform baselines to target (and what
3186         to do with existing ones).
3187
3188         Also fix MockFileSystem.join to behave more like os.path.join (unit
3189         test was ending up with two consecutive slashes in a layout test
3190         path).        
3191
3192         * Scripts/webkitpy/common/system/filesystem_mock.py:
3193         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3194         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3195         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3196         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3197         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3198         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3199         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3200
3201 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3202
3203         Reviewed by Tony Chang.
3204
3205         remove timeout argument to urlopen
3206         https://bugs.webkit.org/show_bug.cgi?id=49995
3207
3208         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3209
3210         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3211
3212 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3213
3214         Unreviewed, rolling out r72628.
3215         http://trac.webkit.org/changeset/72628
3216         https://bugs.webkit.org/show_bug.cgi?id=49994
3217
3218         This patch is causing layout-test failtures on GTK Linux
3219         64-bit Debug (Requested by ctguil on #webkit).
3220
3221         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3222         (AccessibilityUIElement::AccessibilityUIElement):
3223         (AccessibilityUIElement::parentElementCallback):
3224         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3225         * DumpRenderTree/chromium/CppBoundClass.cpp:
3226         * DumpRenderTree/chromium/CppBoundClass.h:
3227
3228 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3229
3230         Reviewed by Tony Chang.
3231
3232         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3233         https://bugs.webkit.org/show_bug.cgi?id=49944
3234
3235         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3236
3237 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3238
3239         Reviewed by Dimitri Glazkov.
3240
3241         Include the FrameView widget of a RenderWidget in the accessibility tree.
3242         https://bugs.webkit.org/show_bug.cgi?id=49106
3243
3244         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3245         (AccessibilityUIElement::AccessibilityUIElement):
3246         (AccessibilityUIElement::parentElementCallback):
3247         (AccessibilityUIElement::isEqualCallback):
3248         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3249         * DumpRenderTree/chromium/CppBoundClass.cpp:
3250         (CppBoundClass::getFromCppVariant):
3251         * DumpRenderTree/chromium/CppBoundClass.h:
3252
3253 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3254
3255         Reviewed by Kenneth Rohde Christiansen.
3256
3257         [EFL] Add tiled backing store to EWebLauncher
3258         https://bugs.webkit.org/show_bug.cgi?id=45777
3259
3260         Allow EWebLauncher to choose between single and tiled backing store
3261
3262         * EWebLauncher/main.c:
3263         (on_key_down):
3264         (browserCreate):
3265         (main):
3266
3267 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3268
3269         Reviewed by Tor Arne Vestbø.
3270
3271         [Qt] Review the setUserPermission & friends API
3272         https://bugs.webkit.org/show_bug.cgi?id=46810
3273
3274         Renamed requestPermissionFromUser to featurePermissionRequested
3275         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3276
3277         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3278         (WebCore::WebPage::WebPage):
3279         * QtTestBrowser/webpage.cpp:
3280         (WebPage::WebPage):
3281         (WebPage::featurePermissionRequestCanceled):
3282         * QtTestBrowser/webpage.h:
3283
3284 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3285
3286         Reviewed by Tor Arne Vestbø.
3287
3288         [Qt] Review the setUserPermission & friends API
3289         https://bugs.webkit.org/show_bug.cgi?id=46810
3290
3291         Rename setUserPermission to setFeaturePermission
3292
3293         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3294         (WebCore::WebPage::requestPermission):
3295         (WebCore::WebPage::permissionSet):
3296         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3297         (LayoutTestController::grantDesktopNotificationPermission):
3298         * QtTestBrowser/webpage.cpp:
3299         (WebPage::requestPermission):
3300
3301 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3302
3303         Reviewed by Tor Arne Vestbø.
3304
3305         [Qt] Review the setUserPermission & friends API
3306         https://bugs.webkit.org/show_bug.cgi?id=46810
3307
3308         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3309         and GeolocationPermissionDomain to Geolocation.
3310
3311         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3312         (WebCore::WebPage::WebPage):
3313         (WebCore::WebPage::requestPermission):
3314         (WebCore::WebPage::cancelPermission):
3315         (WebCore::WebPage::permissionSet):
3316         (WebCore::DumpRenderTree::geolocationPermissionSet):
3317         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3318         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3319         (LayoutTestController::grantDesktopNotificationPermission):
3320         * QtTestBrowser/webpage.cpp:
3321         (WebPage::WebPage):
3322         (WebPage::requestPermission):
3323         (WebPage::cancelRequestsForPermission):
3324         * QtTestBrowser/webpage.h:
3325
3326 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3327
3328         Reviewed by Tor Arne Vestbø.
3329
3330         [Qt] Review the setUserPermission & friends API
3331         https://bugs.webkit.org/show_bug.cgi?id=46810
3332
3333         Add a ByUser suffix to PermissionGranted/Denied. In the future
3334         we can add PermissionGrantedByDefault.
3335
3336
3337         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3338         (WebCore::WebPage::requestPermission):
3339         (WebCore::WebPage::permissionSet):
3340         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3341         (LayoutTestController::grantDesktopNotificationPermission):
3342         * QtTestBrowser/webpage.cpp:
3343         (WebPage::requestPermission):
3344
3345 2010-11-18  Satish Sampath  <satish@chromium.org>
3346
3347         Reviewed by Jeremy Orlow.
3348
3349         For speech input event, send an event object containing all the recognition results and metadata.
3350         https://bugs.webkit.org/show_bug.cgi?id=49736
3351
3352         Updated DRT by renaming the mock result method on all platforms to the new signature.
3353
3354         * DumpRenderTree/LayoutTestController.cpp:
3355         (addMockSpeechInputResultCallback):
3356         (LayoutTestController::staticFunctions):
3357         * DumpRenderTree/LayoutTestController.h:
3358         * DumpRenderTree/chromium/LayoutTestController.cpp:
3359         (LayoutTestController::LayoutTestController):
3360         (LayoutTestController::addMockSpeechInputResult):
3361         * DumpRenderTree/chromium/LayoutTestController.h:
3362         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3363         (LayoutTestController::addMockSpeechInputResult):
3364         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3365         (LayoutTestController::addMockSpeechInputResult):
3366         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3367         (LayoutTestController::addMockSpeechInputResult):
3368         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3369         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3370         (LayoutTestController::addMockSpeechInputResult):
3371         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3372         (LayoutTestController::addMockSpeechInputResult):
3373
3374 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3375
3376         Reviewed by Tony Chang.
3377
3378         Fix some spacing issues with log messages with
3379         new-run-webkit-tests --verbose.
3380
3381         https://bugs.webkit.org/show_bug.cgi?id=49936
3382
3383         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3384
3385 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3386
3387         Reviewed by Adam Barth.
3388
3389         update scm to work with different remote branches
3390         https://bugs.webkit.org/show_bug.cgi?id=49949
3391
3392         This works if there are multiple svn tracking branches
3393         and/or if the tracking branch is refs/remots/origin/master
3394         instead of refs/remotes/trunk which is the direction we're trying
3395         to head since that makes fetches faster.
3396
3397         * Scripts/webkitpy/common/checkout/scm.py:
3398         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3399
3400 2010-11-22  Hayato Ito  <hayato@chromium.org>
3401
3402         Reviewed by Shinichiro Hamaji.
3403
3404         Ignore reference files which will be used by reftests when collecting
3405         test cases.
3406         https://bugs.webkit.org/show_bug.cgi?id=49835
3407
3408         * Scripts/webkitpy/layout_tests/port/test_files.py:
3409         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3410
3411 2010-11-22  Adam Roben  <aroben@apple.com>
3412
3413         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3414
3415         Apple's Windows build allows placing header files and import libraries for WebKit's
3416         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3417         $WebKitLibrariesDir environment variable. This is both required for production builds and
3418         convenient for Apple-internal developer builds. Apple's production builds also require that
3419         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3420         builds, the files are copied into that directory tree by the
3421         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3422         copying is done by
3423         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3424
3425         This .vsprops copying is problematic in one very important case: when a developer updates
3426         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3427         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3428         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3429         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3430         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3431         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3432
3433         To fix this, we now use normal relative paths to access the .vsprops files in the source
3434         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3435         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3436         unset, so the normal relative paths are used to read the .vsprops files out of the source
3437         tree directly. In production builds, this environment variable is set to a fake directory
3438         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3439         is resolved.
3440         
3441         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3442
3443         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3444
3445         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3446         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3447         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3448         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3449         FeatureDefines.vsprops becomes:
3450
3451         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3452
3453         which resolves to:
3454
3455         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3456
3457         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3458         actually exist since they are matched by an equal number of ".." path components.)
3459
3460         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3461         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3462
3463         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3464         updated
3465
3466         Reviewed by Dave Hyatt.
3467
3468         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3469         * DumpRenderTree/win/DumpRenderTree.vcproj:
3470         * DumpRenderTree/win/ImageDiff.vcproj:
3471         * FindSafari/FindSafari.vcproj:
3472         * MiniBrowser/MiniBrowser.vcproj:
3473         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3474         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3475         * WebKitAPITest/WebKitAPITest.vcproj:
3476         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3477         * WebKitTestRunner/win/InjectedBundle.vcproj:
3478         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3479         * WinLauncher/WinLauncher.vcproj:
3480         * record-memory-win/record-memory-win.vcproj:
3481         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3482         files.
3483
3484 2010-11-22  Adam Roben  <aroben@apple.com>
3485
3486         Make it possible to run tests on Windows without Visual Studio or VC++
3487         Express installed
3488
3489         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3490         are not installed. But this function doesn't need to be called when we
3491         already have a build available and are just trying to run the tests.
3492
3493         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3494         because Visual Studio/VC++ Express aren't installed
3495
3496         Reviewed by Dave Hyatt.
3497
3498         * Scripts/webkitdirs.pm:
3499         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3500         it is not needed by this function. Also added a FIXME.
3501
3502         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3503         relying on determineConfigurationForVisualStudio doing it.
3504
3505 2010-11-19  Hayato Ito  <hayato@chromium.org>
3506
3507         Reviewed by Shinichiro Hamaji.
3508
3509         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3510
3511         https://bugs.webkit.org/show_bug.cgi?id=49812
3512
3513         * Scripts/webkitpy/layout_tests/driver_test.py:
3514         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3515         * Scripts/webkitpy/layout_tests/port/base.py:
3516         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3517         * Scripts/webkitpy/layout_tests/port/chromium.py:
3518         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3519         * Scripts/webkitpy/layout_tests/port/test.py:
3520         * Scripts/webkitpy/layout_tests/port/webkit.py:
3521         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3522         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3523
3524 2010-11-22  Hayato Ito  <hayato@chromium.org>
3525
3526         Reviewed by Tony Chang.
3527
3528         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3529
3530         https://bugs.webkit.org/show_bug.cgi?id=49924
3531
3532         * Scripts/webkitpy/layout_tests/port/chromium.py:
3533
3534 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3535
3536         Reviewed by Kenneth Rohde Christiansen.
3537
3538         Fix EWebLauncher zoom discretization
3539         https://bugs.webkit.org/show_bug.cgi?id=49810
3540
3541         * EWebLauncher/main.c:
3542         (nearest_zoom_level_get):
3543         (zoom_level_set):
3544         (on_load_finished):
3545         (on_key_down):
3546
3547 2010-11-21  Sam Weinig  <sam@webkit.org>
3548
3549         Rubber-stamped by Dan Bernstein.
3550
3551         Fix ~300 WebKit2 tests by enabling developer extras preference.
3552
3553         * WebKitTestRunner/TestController.cpp:
3554         (WTR::TestController::resetStateToConsistentValues):
3555
3556 2010-11-21  Sam Weinig  <sam@webkit.org>
3557
3558         Reviewed by Dan Bernstein.
3559
3560         Textareas should be resizable by default
3561         https://bugs.webkit.org/show_bug.cgi?id=49892
3562
3563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3564         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3565         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3566         Add preferences test.
3567
3568 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3569
3570         Reviewed by Tony Chang.
3571
3572         Rebaseline server: checksum-only differences and prefetching
3573         https://bugs.webkit.org/show_bug.cgi?id=49841
3574         
3575         Add support for image test results where the only difference is in the
3576         checksum.
3577         
3578         Add prefetching of the image results from the next test.
3579         
3580         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3581         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3582         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3583
3584 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3585
3586         Reviewed by Tony Chang.
3587
3588         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3589
3590         Add the 'worker number' and 'worker name' concepts to the 
3591         TestShellThread objects, and move test_types and test_args from
3592         the TestRunner to the TestShellThread.
3593
3594         https://bugs.webkit.org/show_bug.cgi?id=49768
3595
3596         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3597         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3598
3599 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3600
3601         Reviewed by Ojan Vafai.
3602
3603         Do some minor cleanup and bug fixing.
3604
3605         https://bugs.webkit.org/show_bug.cgi?id=49777
3606
3607         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3608         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3609
3610 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3611
3612         Reviewed by Ojan Vafai.
3613
3614         nrwt - config.build_directory() is busted
3615
3616         Fixes a typo that was causing us to usually return the top level
3617         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3618         bug was hidden by test stubs that were too simplistic :(.
3619
3620         https://bugs.webkit.org/show_bug.cgi?id=49815
3621
3622         * Scripts/webkitpy/common/system/executive_mock.py:
3623         * Scripts/webkitpy/layout_tests/port/config.py:
3624         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3625
3626 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3627
3628         Reviewed by Adam Roben.
3629
3630         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3631         https://bugs.webkit.org/show_bug.cgi?id=49819
3632
3633         * DumpRenderTree/DumpRenderTree.sln:
3634         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3635         * DumpRenderTree/win/DumpRenderTree.vcproj:
3636         * DumpRenderTree/win/ImageDiff.vcproj:
3637         * FindSafari/FindSafari.vcproj:
3638         * MiniBrowser/MiniBrowser.vcproj: