ba5c772fbedc0582213600a95eae15e229b67451
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2
3         [WebEditingTester] Expand "WK" to "WebKit" in a few places
4         https://bugs.webkit.org/show_bug.cgi?id=141833
5
6         Reviewed by Anders Carlsson.
7
8         * WebEditingTester/AppDelegate.h:
9         * WebEditingTester/AppDelegate.m:
10         (-[WebEditingAppDelegate newEditor:]):
11         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
12         (-[WebEditingAppDelegate validateMenuItem:]):
13         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
14         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
15         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
16         (-[WebEditingAppDelegate showOperations:]): Deleted.
17         * WebEditingTester/MainMenu.xib:
18         The WK abbreviation is unnaturally grating in menu items for some reason.
19
20 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
21
22         [WebEditingTester] Add a custom protocol for loading canned content
23         https://bugs.webkit.org/show_bug.cgi?id=141830
24
25         Reviewed by Enrica Casucci.
26
27         Add a canned:// protocol handler, which can be used to emulate behaviors
28         in WebKit client apps (like Mail) that use custom protocol handlers,
29         which can have important effects on editing (mostly, the URLs are only
30         valid inside of the client application, but not when copied/dragged out).
31
32         For now, we only support two canned files:
33
34             canned://dice is a PNG of dice (stolen from LayoutTests/)
35             canned://text is the string "canned text" served as text/html
36
37         In the future we could support things like very large (generated) files,
38         progressive loading, etc. to further simulate conditions in other apps.
39
40         * WebEditingTester/AppDelegate.m:
41         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
42         Register the protocol with CFNetwork, and the scheme with WebKit2.
43
44         * WebEditingTester/Canned Content/dice.png: Added.
45         * WebEditingTester/CannedContent.h: Added.
46         * WebEditingTester/CannedContent.m: Added.
47         (-[CannedContent initWithRequest:cachedResponse:client:]):
48         (+[CannedContent canonicalRequestForRequest:]):
49         (+[CannedContent canInitWithRequest:]):
50         We only want to handle canned:// URLs.
51
52         (-[CannedContent startLoading]):
53         For now, immediately load the two files we know about.
54         Otherwise, immediately fail the load.
55
56         (-[CannedContent stopLoading]):
57         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
58
59 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
60
61         [WebEditingTester] Implement an open panel
62         https://bugs.webkit.org/show_bug.cgi?id=141829
63
64         Reviewed by Simon Fraser.
65
66         * WebEditingTester/AppDelegate.m:
67         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
68         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
69         (-[WebEditingAppDelegate openDocument:]):
70         Add an open panel (with radio buttons to pick which WebKit to open with).
71         Loads the file as an HTML string.
72
73 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
74
75         [WebEditingTester] @properties, dot syntax, and remember the window position
76         https://bugs.webkit.org/show_bug.cgi?id=141843
77
78         Reviewed by Tim Horton.
79         
80         Modernize a bit with more dot syntax, use @property for the web views,
81         and give the main window an Autosave name so it remembers the widow position.
82
83         * WebEditingTester/WK1WebDocumentController.m:
84         (-[WK1WebDocumentController awakeFromNib]):
85         (-[WK1WebDocumentController loadHTMLString:]):
86         * WebEditingTester/WK2WebDocumentController.m:
87         (-[WK2WebDocumentController awakeFromNib]):
88         * WebEditingTester/WebDocument.xib:
89
90 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
91
92         [WebEditingTester] Hook up key equivalents for new window action
93         https://bugs.webkit.org/show_bug.cgi?id=141828
94
95         Reviewed by Enrica Casucci.
96
97         * WebEditingTester/AppDelegate.h:
98         * WebEditingTester/AppDelegate.m:
99         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
100         (-[WebEditingAppDelegate newEditor:]):
101         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
102         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
103         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
104         (defaultConfiguration): Deleted.
105         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
106         Move WKWebViewConfiguration setup into WK2WebDocumentController.
107         Remove unused application termination code.
108         Update new-window menu item key equivalents when launching and when
109         changing the use-WebKit2-by-default setting.
110         Make WebDocumentController subclasses all initialized the same way,
111         and use that to factor out alloc/init.
112         Rename loadContent to loadHTMLString for future use.
113
114         * WebEditingTester/MainMenu.xib:
115         Add default key equivalents.
116         Cmd-N will always make the default kind of window (controlled by the pref).
117         Cmd-Opt-N will always make the other kind.
118         The menu items are configured as alternates so they only show up if you
119         press alt (just like in MiniBrowser).
120
121         * WebEditingTester/WK1WebDocumentController.m:
122         (-[WK1WebDocumentController loadHTMLString:]):
123         (-[WK1WebDocumentController loadContent]): Deleted.
124         * WebEditingTester/WK2WebDocumentController.h:
125         * WebEditingTester/WK2WebDocumentController.m:
126         (defaultConfiguration):
127         (-[WK2WebDocumentController awakeFromNib]):
128         (-[WK2WebDocumentController loadHTMLString:]):
129         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
130         (-[WK2WebDocumentController dealloc]): Deleted.
131         * WebEditingTester/WebDocumentController.h:
132         * WebEditingTester/WebDocumentController.m:
133         (-[WebDocumentController init]):
134         (-[WebDocumentController initWithWindow:]):
135         (+[WebDocumentController defaultEditingSource]):
136         (-[WebDocumentController loadHTMLString:]):
137         (-[WebDocumentController windowDidLoad]): Deleted.
138         (-[WebDocumentController defaultEditingSource]): Deleted.
139         (-[WebDocumentController applicationTerminating]): Deleted.
140         (-[WebDocumentController loadContent]): Deleted.
141
142 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
143
144         [WebEditingTester] ARC-ify WebEditingTester
145         https://bugs.webkit.org/show_bug.cgi?id=141827
146
147         Reviewed by Sam Weinig.
148
149         * WebEditingTester/AppDelegate.m:
150         (-[WebEditingAppDelegate showOperations:]):
151         * WebEditingTester/EditingOperations.m:
152         (editingOperations):
153         * WebEditingTester/WK1WebDocumentController.m:
154         (-[WK1WebDocumentController dealloc]): Deleted.
155         * WebEditingTester/WK2WebDocumentController.m:
156         (-[WK2WebDocumentController dealloc]): Deleted.
157         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
158         Turn on ARC and remove a few retain/release/autorelease calls.
159         We don't need to implement dealloc in either document controller
160         because WebView and WKWebView's UIDelegate property does not hold a
161         strong reference.
162
163 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
164
165         [WebEditingTester] Factor out list of editing operations
166         https://bugs.webkit.org/show_bug.cgi?id=141826
167
168         Reviewed by Sam Weinig.
169
170         * WebEditingTester/AppDelegate.m:
171         (-[WebEditingAppDelegate showOperations:]):
172         * WebEditingTester/EditingOperations.h: Added.
173         * WebEditingTester/EditingOperations.m: Added.
174         (editingOperations):
175         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
176         Move EditingOperations array to its own file, and make it an NSArray
177         instead of a C array. Adjust accordingly in showOperations:.
178
179 2015-02-20  Michael Saboff  <msaboff@apple.com>
180
181         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
182         https://bugs.webkit.org/show_bug.cgi?id=141676
183
184         Reviewed by Filip Pizlo.
185
186         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
187         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
188         large string expression that we want to eval.
189
190         * Scripts/run-jsc-stress-tests:
191
192 2015-02-19  Daniel Bates  <dabates@apple.com>
193
194         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
195         https://bugs.webkit.org/show_bug.cgi?id=141815
196         <rdar://problem/19893933>
197
198         Reviewed by Simon Fraser.
199
200         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
201         was booted by iOS Simulator in a previous run of run-webkit-test.
202
203         * Scripts/webkitpy/port/ios.py:
204         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
205         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
206         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
207
208 2015-02-19  David Kilzer  <ddkilzer@apple.com>
209
210         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
211         <http://webkit.org/b/141799>
212
213         Reviewed by Alex Christensen.
214
215         * Scripts/webkitpy/style/checkers/cpp.py:
216         (_IncludeState.check_next_include_order): Don't emit a warning
217         if the primary header exists and the source file name ends with
218         "SoftLink.cpp".  Add 'filename' argument to method.
219         (check_include_line): Pass in 'filename'.
220
221         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
222         (OrderOfIncludesTest.test_check_next_include_order__no_config):
223         (OrderOfIncludesTest.test_check_next_include_order__no_self):
224         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
225         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
226         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
227         - Add test filename arguments for calls to
228           check_next_include_order().
229         (OrderOfIncludesTest.test_primary_header): Add test for a file
230         name ending in "SoftLink.cpp".
231
232 2015-02-18  Enrica Casucci  <enrica@apple.com>
233
234         Add new tool to test editable Webviews.
235         https://bugs.webkit.org/show_bug.cgi?id=141772
236
237         Reviewed by Tim Horton.
238
239         Adding WebEditingTester, a Cocoa application to
240         test WK1 and Wk2 views in editable mode.
241
242         * WebEditingTester: Added.
243         * WebEditingTester/AppDelegate.h: Added.
244         * WebEditingTester/AppDelegate.m: Added.
245         (-[WebEditingAppDelegate init]):
246         (defaultConfiguration):
247         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
248         (-[WebEditingAppDelegate applicationWillTerminate:]):
249         (-[WebEditingAppDelegate newEditor:]):
250         (-[WebEditingAppDelegate showOperations:]):
251         (-[WebEditingAppDelegate useWebKit2ByDefault]):
252         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
253         (-[WebEditingAppDelegate validateMenuItem:]):
254         * WebEditingTester/Info.plist: Added.
255         * WebEditingTester/MainMenu.xib: Added.
256         * WebEditingTester/WK1WebDocumentController.h: Added.
257         * WebEditingTester/WK1WebDocumentController.m: Added.
258         (-[WK1WebDocumentController awakeFromNib]):
259         (-[WK1WebDocumentController loadContent]):
260         (-[WK1WebDocumentController dealloc]):
261         (-[WK1WebDocumentController pasteAsMarkup:]):
262         * WebEditingTester/WK2WebDocumentController.h: Added.
263         * WebEditingTester/WK2WebDocumentController.m: Added.
264         (-[WK2WebDocumentController initWithConfiguration:]):
265         (-[WK2WebDocumentController pasteAsMarkup:]):
266         (-[WK2WebDocumentController awakeFromNib]):
267         (-[WK2WebDocumentController dealloc]):
268         (-[WK2WebDocumentController loadContent]):
269         * WebEditingTester/WebDocument.xib: Added.
270         * WebEditingTester/WebDocumentController.h: Added.
271         * WebEditingTester/WebDocumentController.m: Added.
272         (-[WebDocumentController initWithWindow:]):
273         (-[WebDocumentController windowDidLoad]):
274         (-[WebDocumentController defaultEditingSource]):
275         (-[WebDocumentController applicationTerminating]):
276         (-[WebDocumentController loadContent]):
277         * WebEditingTester/WebEditingTester.xcodeproj: Added.
278         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
279         * WebEditingTester/main.m: Added.
280         (main):
281
282 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
283
284         Run JSC tests on ARM EFL bots
285         https://bugs.webkit.org/show_bug.cgi?id=141165
286
287         Reviewed by Alexey Proskuryakov.
288
289         * BuildSlaveSupport/build.webkit.org-config/config.json:
290         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
291         (RunJavaScriptCoreTests.countFailures):
292         (RunRemoteJavaScriptCoreTests):
293         (RunRemoteJavaScriptCoreTests.start):
294         (BuildAndRemoteJSCTestsFactory):
295         (BuildAndRemoteJSCTestsFactory.__init__):
296
297 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
298
299         Streamline unexported function build fixes
300         https://bugs.webkit.org/show_bug.cgi?id=141761
301
302         Reviewed by Alex Christensen.
303
304         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
305         We don't need to ignore symbols that are not exported due to the .unexp file.
306
307 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
308
309         Remove more references to WebCore.exp.in
310         https://bugs.webkit.org/show_bug.cgi?id=141747
311
312         Reviewed by Alexey Proskuryakov.
313
314         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
315         (ShouldBuildTest):
316
317 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
318
319         Windows test results should not fall back to mac-mountainlion after r180176
320         https://bugs.webkit.org/show_bug.cgi?id=141719
321
322         Reviewed by Brent Fulgham.
323
324         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
325         (_should_file_trigger_build):
326         * Scripts/webkitpy/port/win.py:
327         (WinPort.default_baseline_search_path):
328         * Scripts/webkitpy/port/win_unittest.py:
329         (WinPortTest.test_baseline_search_path):
330
331 2015-02-17  Daniel Bates  <dabates@apple.com>
332
333         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
334         https://bugs.webkit.org/show_bug.cgi?id=141718
335
336         Reviewed by Alex Christensen.
337
338         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
339
340         * Scripts/webkitpy/port/ios.py:
341         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
342         Log a error and return False if we are unable to boot the simulator device so that the caller can take
343         appropriate action, say exit(3) before running any layout tests.
344         * Scripts/webkitpy/xcode/simulator.py:
345         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
346         with the specified UDID.
347         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
348         with the specified UDID can successfully boot and shut down. We make at most two attempts to
349         boot and shut down the device, erasing the device between tries so as to restore the device
350         to a known good state.
351
352 2015-02-17  Daniel Bates  <dabates@apple.com>
353
354         run_webkit_tests.py should not know about iOS Simulator details
355         https://bugs.webkit.org/show_bug.cgi?id=141711
356
357         Reviewed by Alex Christensen.
358
359         Run_webkit_tests.py should only parse the iOS-specific command
360         line options --runtime and --device-type. Let the port-specific
361         logic in ios.py validate the parsed options and instantiate
362         internal data structures.
363
364         Currently run_webkit_tests.py parses the iOS-specific command
365         line options --runtime and --device-type, validates them, and
366         instantiates internal data structures from the parsed strings.
367         Instead the validation logic and instantiation of internal
368         data structures should be handled by the iOS port object.
369
370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
371         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
372         and instantiate internal data structures for them.
373         * Scripts/webkitpy/port/driver.py:
374         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
375         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
376         respectively.
377         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
378         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
379         object from --runtime, if specified. Otherwise, instantiates a Runtime
380         object for the latest installed iphonesimulator SDK version.
381         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
382         object from --device-type, if specified. Otherwise, instantiates
383         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
384         machine, respectively.
385         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
386         runtime is available to use.
387         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
388         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
389         * Scripts/webkitpy/xcode/simulator.py:
390         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
391         with a runtime identifier for the specified iOS version.
392
393 2015-02-17  Dana Burkart  <dburkart@apple.com>
394
395         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
396         https://bugs.webkit.org/show_bug.cgi?id=141672
397
398         Reviewed by David Kilzer.
399
400         * asan/webkit-asan-ignore.txt:
401
402 2015-02-17  Alex Christensen  <achristensen@webkit.org>
403
404         Remove WebCore.exp.in and clean up.
405         https://bugs.webkit.org/show_bug.cgi?id=141491
406
407         Reviewed by Andreas Kling.
408
409         * Scripts/sort-export-file: Removed.
410         * Scripts/webkitpy/style/checker.py:
411         (_all_categories):
412         (FileType):
413         (CheckerDispatcher._file_type):
414         (CheckerDispatcher._create_checker):
415         Don't check if the export files are sorted.
416         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
417         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
418
419 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
420
421         Unreviewed. Fix GTK+ make distcheck.
422
423         Do not exclude bmalloc directory from the tarball.
424
425         * gtk/manifest.txt.in:
426
427 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
428
429         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
430
431         I forgot to add the return of a bool function.
432
433         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
434         (WebKitDOMNodeTest::testDOMCache):
435
436 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
437
438         [GTK] GObject DOM bindings object are cached forever
439         https://bugs.webkit.org/show_bug.cgi?id=141558
440
441         Reviewed by Sergio Villar Senin.
442
443         Add checks for all DOM objects to ensure they are not leaked. Also
444         add a dedicated test for the DOM Object Cache.
445
446         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
447         (WebKitDOMNodeFilterTest::testTreeWalker):
448         (WebKitDOMNodeFilterTest::testNodeIterator):
449         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
450         (WebKitDOMNodeTest::testHierarchyNavigation):
451         (WebKitDOMNodeTest::testInsertion):
452         (WebKitDOMNodeTest::testTagNames):
453         (WebKitDOMNodeTest::testDOMCache):
454         (registerTests):
455         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
456         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
457         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
458         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
459         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
460         (testWebKitDOMObjectCache):
461         (beforeAll):
462         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
463         (documentLoadedCallback):
464
465 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
466
467         [GTK] WebKitFrame objects are never released
468         https://bugs.webkit.org/show_bug.cgi?id=141641
469
470         Reviewed by Martin Robinson.
471
472         Add a way to check GObjects leaks for WebProcess tests and check
473         WebKitFrame objects are not leaked.
474
475         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
476         (WebKitFrameTest::testMainFrame):
477         (WebKitFrameTest::testURI):
478         (WebKitFrameTest::testJavaScriptContext):
479         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
480         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
481         (runTest):
482         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
483
484 2015-02-16  Tim Horton  <timothy_horton@apple.com>
485
486         Fix the MiniBrowser build with newer clang
487
488         * MiniBrowser/mac/SettingsController.m:
489         (-[SettingsController _toggleBooleanDefault:]):
490         * MiniBrowser/mac/WK1BrowserWindowController.m:
491         (-[WK1BrowserWindowController windowWillClose:]):
492         * MiniBrowser/mac/WK2BrowserWindowController.m:
493         (-[WK2BrowserWindowController windowWillClose:]):
494         NSApp is id and clang gets confused about which -delegate we're talking about.
495
496 2015-02-16  Antti Koivisto  <antti@apple.com>
497
498         Develop/Disable Caches does not properly disable disk cache
499         https://bugs.webkit.org/show_bug.cgi?id=141636
500
501         Reviewed by Anders Carlsson.
502
503         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
504         the network process too.
505
506         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
507
508         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
509         (WTR::InjectedBundle::beginTesting):
510         (WTR::InjectedBundle::setCacheModel):
511         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
512         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
513
514             Forward to TestController.
515
516         (WTR::TestRunner::setCacheModel):
517         * WebKitTestRunner/TestInvocation.cpp:
518         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
519
520 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
521
522         Unreviewed. Add myself as a committer.
523
524         * Scripts/webkitpy/common/config/contributors.json:
525
526 2015-02-15  David Kilzer  <ddkilzer@apple.com>
527
528         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
529         <http://webkit.org/b/141607>
530
531         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
532         externals in Source/WebCore/Configurations/WebCore.unexp when
533         building with Xcode 5.x.
534         (readXcode5SymbolsToIgnore): Add.
535
536 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
537
538         [EFL] fix Evas GL engine error.
539         https://bugs.webkit.org/show_bug.cgi?id=141621
540
541         Reviewed by Gyuyoung Kim.
542
543         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
544
545         * MiniBrowser/efl/main.c:
546         (elm_main):
547
548 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
549
550         [buildbot] Enable run-api-tests on release Mac bots
551         https://bugs.webkit.org/show_bug.cgi?id=141518
552
553         Reviewed by Darin Adler.
554
555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
556         (RunUnitTests):
557         (BuildFactory.__init__):
558         (TestFactory.__init__):
559         (BuildAndTestFactory.__init__):
560         (RunUnitTests.start): Deleted.
561         (unitTestsSupported): Deleted.
562
563 2015-02-13  Anders Carlsson  <andersca@apple.com>
564
565         Add a move constructor and move assignment operator to Deque
566         https://bugs.webkit.org/show_bug.cgi?id=141571
567
568         Reviewed by Andreas Kling.
569
570         * TestWebKitAPI/Tests/WTF/Deque.cpp:
571         (TestWebKitAPI::TEST):
572
573 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
574
575         run-jsc-stress-tests --remote should skip profiler tests
576         https://bugs.webkit.org/show_bug.cgi?id=141470
577
578         Reviewed by Filip Pizlo.
579
580         * Scripts/run-jsc-stress-tests:
581
582 2015-02-13  Anders Carlsson  <andersca@apple.com>
583
584         Add an initializer list constructor to Deque
585         https://bugs.webkit.org/show_bug.cgi?id=141565
586
587         Reviewed by Andreas Kling.
588
589         * TestWebKitAPI/Tests/WTF/Deque.cpp:
590         (TestWebKitAPI::TEST):
591
592 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
593
594         [buildbot] Remove buildJSCTool cruft from master.cfg
595         https://bugs.webkit.org/show_bug.cgi?id=141513
596
597         Reviewed by Alexey Proskuryakov.
598
599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
600         (RunJavaScriptCoreTests):
601         (RunJavaScriptCoreTests.start):
602         (RunWebKitTests):
603         (RunWebKitTests.start):
604         (TestFactory.__init__):
605         (TestLeaksFactory.__init__):
606         (RunJavaScriptCoreTests.__init__): Deleted.
607         (RunWebKitTests.__init__): Deleted.
608
609 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
610
611         Unreviewed, remove empty directories.
612
613         * DumpRenderTree/gtk: Removed.
614         * DumpRenderTree/gtk/fonts: Removed.
615         * DumpRenderTree/unix: Removed.
616         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
617         * GtkLauncher: Removed.
618         * TestWebKitAPI/Tests/WebKitGtk: Removed.
619         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
620         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
621         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
622
623 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
624
625         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
626         https://bugs.webkit.org/show_bug.cgi?id=141519
627
628         Reviewed by Alexey Proskuryakov.
629
630         * Scripts/build-webkittestrunner:
631
632 2015-02-12  Alex Christensen  <achristensen@webkit.org>
633
634         Removed empty directory.
635
636         * WinCELauncher: Removed.
637
638 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
639
640         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
641         https://bugs.webkit.org/show_bug.cgi?id=141202
642
643         Reviewed by Darin Adler.
644
645         * Scripts/run-jsc-stress-tests:
646
647 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
648
649         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
650         https://bugs.webkit.org/show_bug.cgi?id=141517
651
652         Reviewed by Anders Carlsson.
653
654         We do not need to locate or use the DLL's that came with Safari, so stop
655         failing when we cannot find them. Also remove some old Qt cruft from this
656         script.
657
658         * BuildSlaveSupport/built-product-archive:
659         (archiveBuiltProduct): 
660         (extractBuiltProduct):
661
662 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
663
664         [Win] [64-bit] Work around MSVC2013 Runtime Bug
665         https://bugs.webkit.org/show_bug.cgi?id=141498
666         <rdar://problem/19803642>
667
668         Reviewed by Anders Carlsson.
669
670         Disable FMA3 instruction use in the MSVC math library to
671         work around a VS2013 runtime crash. We can remove this
672         workaround when we switch to VS2015.
673
674         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
675         disable FMA3 support.
676         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
677         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
678         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
679         * Scripts/webkitperl/httpd.pm: Ditto.
680         * TestWebKitAPI/win/main.cpp: Ditto.
681         * WinLauncher/Common.cpp: Ditto.
682         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
683
684 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
685
686         run-jsc-stress-tests should accept remote host config from JSON file
687         https://bugs.webkit.org/show_bug.cgi?id=141509
688
689         Reviewed by Michael Saboff.
690
691         * Scripts/run-javascriptcore-tests:
692         (runJSCStressTests):
693         * Scripts/run-jsc-stress-tests:
694
695 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
696
697         [GTK] Add API to allow overriding the default color chooser implementation
698         https://bugs.webkit.org/show_bug.cgi?id=98935
699
700         Reviewed by Gustavo Noronha Silva.
701
702         Add a color chooser implementation for MiniBrowser using
703         GtkPopover when the GTK+ version is recent enough.
704         And a test case to check the new color chooser API.
705
706         * MiniBrowser/gtk/BrowserWindow.c:
707         (colorChooserRGBAChanged):
708         (popoverColorClosed):
709         (colorChooserRequestFinished):
710         (runColorChooserCallback):
711         (browserWindowConstructed):
712         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
713         (testWebViewColorChooserRequest):
714         (beforeAll):
715
716 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
717
718         Make run-jsc-stress-tests --remote work with make-based runner
719         https://bugs.webkit.org/show_bug.cgi?id=141079
720
721         Reviewed by Darin Adler.
722
723         * Scripts/run-javascriptcore-tests:
724         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
725         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
726         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
727         to avoid code duplication.
728
729 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
730
731         run-jsc-stress tests should detect the number of processors on the remote machine too
732         https://bugs.webkit.org/show_bug.cgi?id=141196
733
734         Reviewed by Darin Adler.
735
736         * Scripts/run-javascriptcore-tests:
737         (runJSCStressTests): Pass through the --child-processes argument.
738         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
739         to detect the number of local and remote processors with the same algorithm.
740         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
741         same as $numProcessors.
742
743 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
744
745         run-jsc-stress-tests should pass JSC_timeout to remote hosts
746         https://bugs.webkit.org/show_bug.cgi?id=141164
747
748         Reviewed by Darin Adler.
749
750         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
751
752         * Scripts/run-jsc-stress-tests:
753
754 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         [GTK] Add default color chooser implementation using GtkColorChooserDialog
757         https://bugs.webkit.org/show_bug.cgi?id=141392
758
759         Reviewed by Gustavo Noronha Silva.
760
761         Enable INPUT_TYPE_COLOR by default for GTK+ port.
762
763         * Scripts/webkitperl/FeatureList.pm:
764
765 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
766
767         run-jsc-stress-tests shell test runner should run tests in fixed order
768         https://bugs.webkit.org/show_bug.cgi?id=141383
769
770         Reviewed by Darin Adler.
771
772         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
773
774 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
775
776         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
777         https://bugs.webkit.org/show_bug.cgi?id=140485
778
779         Reviewed by Anders Carlsson.
780
781         Implement takeFocus() as a way to set focus through accessibility wrappers.
782
783         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
784         (AccessibilityUIElement::takeFocus):
785         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
786         (WTR::AccessibilityUIElement::takeFocus):
787
788 2015-02-08  Darin Adler  <darin@apple.com>
789
790         Remove the SVG instance tree
791         https://bugs.webkit.org/show_bug.cgi?id=140602
792
793         Reviewed by Dean Jackson.
794
795         * Scripts/check-for-global-initializers: Removed special case for
796         SVGElementInstance.o.
797
798 2015-02-07  David Kilzer  <ddkilzer@apple.com>
799
800         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
801         <http://webkit.org/b/141365>
802
803         Reviewed by Daniel Bates.
804
805         * Scripts/webkitpy/xcode/simulator.py:
806         (Simulator): Add unavailable_version_re precompiled regex.
807         (Simulator._parse_devices): Check for unavailable versions and
808         ignore them if found when parsing the output of
809         `xcrun simctl list`.
810         * Scripts/webkitpy/xcode/simulator_unittest.py:
811         (test_unavailable_devices): Add test with output from
812         `xcrun simctl list` with unavailable runtimes that fails before
813         the fix.
814
815 2015-02-07  Chris Dumez  <cdumez@apple.com>
816
817         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
818         https://bugs.webkit.org/show_bug.cgi?id=141321
819
820         Reviewed by Darin Adler.
821
822         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
823
824 2015-02-07  David Kilzer  <ddkilzer@apple.com>
825
826         [iOS] Make Simulator class testable
827         <http://webkit.org/b/141358>
828
829         Rubber-stamped by Darin Adler.
830
831         * Scripts/webkitpy/common/system/platforminfo.py:
832         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
833         command to here from Simulator.refresh() in xcode/simulator.py
834         so that the output of the command can be mocked.
835
836         * Scripts/webkitpy/common/system/platforminfo_mock.py:
837         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
838         to None.
839         (MockPlatformInfo.xcode_simctl_list): Add method that returns
840         self.expected_xcode_simctl_list expectation.
841
842         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
843         and license header.
844         (Simulator.__init__): Add optional 'host' parameter to make it
845         possible to pass in a mock object for testing.  Set self._host
846         to 'host' parameter or create Host() object.
847         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
848         method.
849
850         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
851         for current code.
852         (SimulatorTest):
853         (SimulatorTest.setUp):
854         (SimulatorTest._set_expected_xcrun_simctl_list):
855         (SimulatorTest.test_simulator_device_types):
856         (test_invalid_device_types_header):
857         (test_invalid_runtimes_header):
858         (test_invalid_devices_header):
859
860 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
861
862         run-jsc-stress-tests --remote should use the default ssh port
863         https://bugs.webkit.org/show_bug.cgi?id=141287
864
865         Reviewed by Darin Adler.
866
867         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
868
869 2015-02-06  Dana Burkart  <dburkart@apple.com>
870
871         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
872         https://bugs.webkit.org/show_bug.cgi?id=141349
873
874         Reviewed by Alexey Proskuryakov.
875
876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
877         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
878         (BuildbotTesterQueueView.prototype.update):
879
880 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
881
882         Report network process crashes during layout tests
883         https://bugs.webkit.org/show_bug.cgi?id=139646
884
885         Reviewed by Anders Carlsson.
886
887         * WebKitTestRunner/TestController.cpp:
888         (WTR::TestController::initialize):
889         (WTR::TestController::networkProcessName):
890         (WTR::TestController::networkProcessDidCrash):
891         * WebKitTestRunner/TestController.h:
892
893 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
894
895         run-jsc-stress-tests --remote should create remote directory before copying the bundle
896         https://bugs.webkit.org/show_bug.cgi?id=141329
897
898         Reviewed by Michael Saboff.
899
900         * Scripts/run-jsc-stress-tests:
901
902 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
903
904         [GTK] Remove WebKitWebView::close-notification signal
905         https://bugs.webkit.org/show_bug.cgi?id=141330
906
907         Reviewed by Gustavo Noronha Silva.
908
909         Update notifications unit tests according to the API changes, and
910         add a test case to check that onclose event is fired when a
911         notification is closed by the user.
912
913         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
914         (testWebViewNotification):
915
916 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
917
918         Dashboard doesn't consider building ASan a productive step
919         https://bugs.webkit.org/show_bug.cgi?id=141312
920
921         Reviewed by Simon Fraser.
922
923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
924
925 2015-02-05  Daniel Bates  <dabates@apple.com>
926
927         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
928         https://bugs.webkit.org/show_bug.cgi?id=141306
929
930         Reviewed by Alexey Proskuryakov.
931
932         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
933         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
934         existent runtime.
935
936         * Scripts/webkitpy/xcode/simulator.py:
937         (Runtime.from_identifier):
938
939 2015-02-05  Daniel Bates  <dabates@apple.com>
940
941         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
942         https://bugs.webkit.org/show_bug.cgi?id=139746
943         <rdar://problem/19283658>
944
945         Reviewed by Alexey Proskuryakov.
946
947         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
948         if the simulator device is not in state Booted.
949
950         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
951         launching/relaunching the iOS Simulator app and a simulator app can only be installed
952         on a device that is in the Booted state. LayoutTestRelay may run before the
953         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
954         We should defer executing LayoutTestRelay until the simulator device booted by
955         iOS Simulator is in the Booted state.
956
957         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
958         Simulator methods with the module name, simulator.
959         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
960         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
961         before launching iOS Simulator to boot it.
962         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
963         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
964         * Scripts/webkitpy/xcode/simulator.py:
965         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
966         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
967         interested in the state of the device are more likely interested in the current state of the device as
968         opposed to the state of the device when the Device object was created.
969         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
970         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
971         from both this function and Simulator.device_state().
972         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
973         (Simulator.DeviceState): Added; class of constants.
974         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
975         device is in the specified state.
976         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
977         (Simulator.device_directory): Added.
978         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
979
980 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
981
982         Disable retries on Mac debug testers
983         https://bugs.webkit.org/show_bug.cgi?id=141296
984
985         Reviewed by Simon Fraser.
986
987         * BuildSlaveSupport/build.webkit.org-config/config.json:
988
989 2015-02-05  Dan Bernstein  <mitz@apple.com>
990
991         Need a way to force $xcodeSDK in webkitdirs.pm
992         https://bugs.webkit.org/show_bug.cgi?id=141291
993
994         Reviewed by Anders Carlsson.
995
996         * Scripts/webkitdirs.pm:
997         (setXcodeSDK): Added.
998
999 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1000
1001         [Streams API] Implement a barebone ReadableStream interface
1002         https://bugs.webkit.org/show_bug.cgi?id=141045
1003
1004         Reviewed by Benjamin Poulain.
1005
1006         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
1007
1008 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
1009
1010         filter-build-webkit: reduce more unfiltered output
1011         https://bugs.webkit.org/show_bug.cgi?id=141282
1012
1013         Reviewed by Daniel Bates.
1014
1015         * Scripts/filter-build-webkit:
1016         Report CompileDTraceScript and Preprocess lines as successful.
1017
1018 2015-02-04  Dana Burkart  <dburkart@apple.com>
1019
1020         Botwatcher's Dashboard is cramped
1021         https://bugs.webkit.org/show_bug.cgi?id=140273
1022
1023         Reviewed by Alexey Proskuryakov.
1024
1025         Add a heading key which will allow for arbitrary headings in builder queues.
1026
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1028         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1029         (BuildbotBuilderQueueView.prototype.update):
1030         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1032         (BuildbotIteration.prototype._parseData):
1033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1034         (BuildbotLeaksQueueView.prototype.update):
1035         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
1036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1037         (BuildbotPerformanceQueueView.prototype.update):
1038         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1040         (BuildbotQueue):
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1042         (BuildbotQueueView.prototype._unauthorizedAccess):
1043         (BuildbotQueueView.prototype._appendBuild):
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1045         (BuildbotTestResults):
1046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1047         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1048         (BuildbotTesterQueueView.prototype.update):
1049         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
1050
1051 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
1052
1053         WKTR should not use -mainScreen to pick a color profile
1054         https://bugs.webkit.org/show_bug.cgi?id=141265
1055
1056         Reviewed by Tim Horton.
1057         
1058         -[NSScreen mainScreen] depends on the active window, so use the first screen
1059         (which is the one we put the window on anyway).
1060         
1061         Do some cleanup in DRT that makes the code look similar.
1062
1063         * DumpRenderTree/mac/DumpRenderTree.mm:
1064         (createWebViewAndOffscreenWindow):
1065         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1066         (WTR::PlatformWebView::PlatformWebView):
1067
1068 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
1069
1070         LayoutTestHelper should set the color profile of all displays
1071         https://bugs.webkit.org/show_bug.cgi?id=141260
1072
1073         Reviewed by Tim Horton.
1074         
1075         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
1076         which is the screen with the active window. Make things more robust by changing
1077         the colorspace of all displays, not just the main screen, when running layout tests.
1078
1079         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
1080         * DumpRenderTree/mac/LayoutTestHelper.m: 
1081         (originalColorProfileURLs):
1082         (colorProfileURLForDisplay):
1083         (displayUUIDStrings):
1084         (saveDisplayColorProfiles):
1085         (setDisplayColorProfile):
1086         (restoreDisplayColorProfiles):
1087         (installLayoutTestColorProfile):
1088         (restoreUserColorProfile):
1089         (main):        
1090         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
1091         toll-free bridged, sadly). Use the map to restore all profiles on exit.
1092         Convert to use more Obj-C types.
1093
1094 2015-02-04  Daniel Bates  <dabates@apple.com>
1095
1096         test-webkitpy fails on Mac without iphoneos SDK
1097         https://bugs.webkit.org/show_bug.cgi?id=141255
1098         <rdar://problem/19619691>
1099
1100         I inadvertently committed the wrong exception message. Fix up the exception message
1101         to instruct a person to install the iOS SDK when it cannot be found.
1102
1103         * Scripts/webkitpy/port/ios.py:
1104         (IOSPort.determine_full_port_name):
1105
1106 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1107
1108         W3C test importer should sort the list of files when generating the w3c-import.log
1109         https://bugs.webkit.org/show_bug.cgi?id=141156
1110
1111         Reviewed by Bem Jones-Bey.
1112
1113         Sort explicitly the list of imported files written in the w3c-import.log.
1114         Removed logging of the import date.
1115
1116         * Scripts/webkitpy/w3c/test_importer.py:
1117         (TestImporter.write_import_log):
1118
1119 2015-02-04  Daniel Bates  <dabates@apple.com>
1120
1121         test-webkitpy fails on Mac without iphoneos SDK
1122         https://bugs.webkit.org/show_bug.cgi?id=141255
1123         <rdar://problem/19619691>
1124
1125         Reviewed by David Kilzer and Alexey Proskuryakov.
1126
1127         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
1128         should not require the iphoneos SDK to be installed to run the webkitpy tests.
1129
1130         * Scripts/webkitpy/common/system/platforminfo.py:
1131         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
1132         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
1133         to standard output if the SDK is installed to return the empty string if the SDK is
1134         not installed.
1135         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1136         (MockPlatformInfo.xcode_sdk_version): Added.
1137         * Scripts/webkitpy/port/ios.py:
1138         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
1139         to get the version of the iphoneos SDK, if installed.
1140
1141 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1142
1143         run-webkit-tests doesn't always capture ASan violation reports
1144         https://bugs.webkit.org/show_bug.cgi?id=141231
1145
1146         Reviewed by Darin Adler.
1147
1148         * Scripts/webkitpy/port/driver.py:
1149         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
1150         by the driver already (as is the case with ASan violations, which are printed to
1151         stderr).
1152         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
1153         report.
1154         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
1155         a separate variable for reporting.
1156
1157 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1158
1159         [webkitpy] Add platform specific Skipped file mechanism for performance tests
1160         https://bugs.webkit.org/show_bug.cgi?id=141152
1161
1162         Reviewed by Csaba Osztrogonác.
1163
1164         Support a test-expectation-like syntax in performance tests' skipped files.
1165         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
1166
1167         * Scripts/webkitpy/port/base.py:
1168         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
1169
1170         * Scripts/webkitpy/port/base_unittest.py:
1171         (PortTest.test_skipped_perf_tests): Test the new syntax.
1172
1173 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1174
1175         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
1176         https://bugs.webkit.org/show_bug.cgi?id=141236
1177
1178         Reviewed by Sam Weinig.
1179
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1181         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
1182
1183 2015-02-04  Chris Dumez  <cdumez@apple.com>
1184
1185         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
1186         https://bugs.webkit.org/show_bug.cgi?id=141192
1187
1188         Reviewed by Benjamin Poulain.
1189
1190         Add API tests for Vector::removeFirst(value) and
1191         Vector::removeAll(value).
1192
1193         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1194         (TestWebKitAPI::TEST):
1195
1196 2015-02-03  Tim Horton  <timothy_horton@apple.com>
1197
1198         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
1199         https://bugs.webkit.org/show_bug.cgi?id=141217
1200
1201         Reviewed by Sam Weinig.
1202
1203         * WebKitTestRunner/TestController.cpp:
1204         (WTR::copyWebCryptoMasterKey):
1205         (WTR::TestController::createOtherPage):
1206         (WTR::TestController::createWebViewWithOptions):
1207         (WTR::TestController::ensureViewSupportsOptions):
1208         (WTR::TestController::didCommitNavigation):
1209         (WTR::TestController::didFinishNavigation):
1210         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
1211         (WTR::TestController::didReceiveAuthenticationChallenge):
1212         (WTR::TestController::decidePolicyForPluginLoad):
1213         (WTR::TestController::decidePolicyForNavigationAction):
1214         (WTR::TestController::decidePolicyForNavigationResponse):
1215         (WTR::TestController::didCommitLoadForFrame): Deleted.
1216         (WTR::TestController::didFinishLoadForFrame): Deleted.
1217         * WebKitTestRunner/TestController.h:
1218         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
1219
1220 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
1221
1222         Unreviewed. Add myself as a committer.
1223
1224         * Scripts/webkitpy/common/config/contributors.json:
1225
1226 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1227
1228         [Win] Unreviewed test fix.
1229
1230         * DumpRenderTree/win/PolicyDelegate.cpp:
1231         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
1232         so was not matching expected output.
1233
1234 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1235
1236         Unreviewed. Moving myself to the committer section at last.
1237
1238         * Scripts/webkitpy/common/config/contributors.json:
1239
1240 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1241
1242         [Win] Tests fail because DRT reports '(null)' instead of an empty string
1243         https://bugs.webkit.org/show_bug.cgi?id=141205
1244
1245         Reviewed by Anders Carlsson.
1246
1247         * DumpRenderTree/win/HistoryDelegate.cpp:
1248         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
1249         properly so that we match expected DumpRenderTree output.
1250
1251 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1252
1253         [GTK] TestWebKitAccessibility is not skipped
1254         https://bugs.webkit.org/show_bug.cgi?id=141179
1255
1256         Reviewed by Carlos Garcia Campos.
1257
1258         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
1259         skipped, and it apparently works reliably on the bots.
1260
1261         * Scripts/run-gtk-tests:
1262         (TestRunner):
1263
1264 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1265
1266         run-perf-tests: allow to specify a wrapper command.
1267         https://bugs.webkit.org/show_bug.cgi?id=141172
1268
1269         Reviewed by Ryosuke Niwa.
1270
1271         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1272         (parse_args): Update text to indicate is also valid for WTR.
1273         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1274         (PerfTestsRunner._parse_args): Add wrapper command.
1275
1276 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1277
1278         [Win] Correct version parsing warning in update-webkit
1279         https://bugs.webkit.org/show_bug.cgi?id=141200
1280
1281         Reviewed by Anders Carlsson.
1282
1283         * Scripts/webkitdirs.pm:
1284         (setupAppleWinEnv): Strip out any specific version build level
1285         from the Cygwin version information.
1286   
1287
1288 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1289
1290         [Win] Attempt to improve the reliability of HTTP service
1291         https://bugs.webkit.org/show_bug.cgi?id=141191
1292
1293         Reviewed by Darin Adler.
1294
1295         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1296         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
1297         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
1298         when stopping the service doesn't do so on its own (for Windows runs).
1299
1300 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1301
1302         Web platform test server should not need to create __init__.py files
1303         https://bugs.webkit.org/show_bug.cgi?id=141030
1304
1305         Reviewed by Ryosuke Niwa.
1306
1307         W3C TestImporter ensures that copied __init__.py files are not empty.
1308         If needed, a comment is inserted in __init__.py files.
1309         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
1310
1311         * Scripts/webkitpy/common/system/filesystem.py:
1312         (FileSystem.getsize):
1313         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1314         (TestWebPlatformTestServer.test_start_cmd):
1315         (TestWebPlatformTestServer):
1316         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
1317         * Scripts/webkitpy/w3c/test_importer.py:
1318         (TestImporter.import_tests):
1319
1320 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1321
1322         Unreviewed. Moving myself to the committer section.
1323
1324         * Scripts/webkitpy/common/config/contributors.json:
1325
1326 2015-02-02  Saam Barati  <saambarati1@gmail.com>
1327
1328         Create tests for JSC's Control Flow Profiler
1329         https://bugs.webkit.org/show_bug.cgi?id=141123
1330
1331         Reviewed by Filip Pizlo.
1332
1333         * Scripts/run-javascriptcore-tests:
1334         (runJSCStressTests):
1335         * Scripts/run-jsc-stress-tests:
1336
1337 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1338
1339         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1340         https://bugs.webkit.org/show_bug.cgi?id=141158
1341
1342         Reviewed by Darin Adler.
1343
1344         * Scripts/run-jsc-stress-tests:
1345
1346 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1347
1348         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1349         https://bugs.webkit.org/show_bug.cgi?id=141142
1350
1351         Reviewed by Carlos Garcia Campos.
1352
1353         * MiniBrowser/gtk/BrowserWindow.c:
1354         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1355
1356 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1357
1358         Web platform test server is not always launching properly on Mac EWS bots
1359         https://bugs.webkit.org/show_bug.cgi?id=141141
1360
1361         Unreviewed.
1362
1363         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1364         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1365
1366 2015-01-31  Sam Weinig  <sam@webkit.org>
1367
1368         Remove even more Mountain Lion support
1369         https://bugs.webkit.org/show_bug.cgi?id=141124
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1374         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1375         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1376         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1377         * DumpRenderTree/mac/DumpRenderTree.mm:
1378         (activateTestingFonts):
1379         (prepareConsistentTestingEnvironment):
1380         * DumpRenderTree/mac/EventSendingController.mm:
1381         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1382         (-[EventSendingController contextClick]):
1383         * DumpRenderTree/mac/TextInputController.m:
1384         * LayoutTestRelay/Configurations/Base.xcconfig:
1385         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1386         * MiniBrowser/Configurations/Base.xcconfig:
1387         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1388         * MiniBrowser/mac/WK2BrowserWindowController.m:
1389         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1390         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1391         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1392         * TestWebKitAPI/Configurations/Base.xcconfig:
1393         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1394         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1395         (-[DownloadDelegate _downloadDidFinish:]):
1396         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1397         (TestWebKitAPI::TEST):
1398         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1399         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1400         * WebKitLauncher/Configurations/Base.xcconfig:
1401         * WebKitTestRunner/Configurations/Base.xcconfig:
1402         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1403         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1404         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1405         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1406         (WTR::activateFonts):
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::TestController::initialize):
1409         (WTR::TestController::webProcessName):
1410         * WebKitTestRunner/mac/EventSenderProxy.mm:
1411         * asan/asan.xcconfig:
1412
1413 2015-01-31  Commit Queue  <commit-queue@webkit.org>
1414
1415         Unreviewed, rolling out r179408.
1416         https://bugs.webkit.org/show_bug.cgi?id=141117
1417
1418         This didn't fully fix the issue (Requested by anttik on
1419         #webkit).
1420
1421         Reverted changeset:
1422
1423         "OSObjectPtr does not work with dispatch_data_t on Maverics"
1424         https://bugs.webkit.org/show_bug.cgi?id=141081
1425         http://trac.webkit.org/changeset/179408
1426
1427 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1428
1429         https://trac.webkit.org/changeset/179439 breaks a python test
1430         https://bugs.webkit.org/show_bug.cgi?id=141114
1431
1432         Unreviewed.
1433
1434         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1435         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
1436
1437 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1438
1439         Import W3C web platform tests infrastructure
1440         https://bugs.webkit.org/show_bug.cgi?id=140934
1441
1442         Reviewed by Ryosuke Niwa.
1443
1444         Loading necessary web platform tests modules before launching server.
1445         Ensuring that some empty __init__.py files are present and create them if necessary. 
1446
1447         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1448         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1449
1450 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1451
1452         [Win] Another unreviewed test fix.
1453
1454         Correct copy/paste error in buildbot handling.
1455
1456         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1457         (LayoutTestApacheHttpd.__init__):
1458         (LayoutTestApacheHttpd._get_apache_config_file_path):
1459
1460 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1461
1462         [Win] Unreviewed test fix.
1463
1464         Correct path handling based on failures on test bots to get things running again.
1465
1466         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1467         (LayoutTestApacheHttpd.__init__):
1468         (LayoutTestApacheHttpd._get_apache_config_file_path):
1469
1470 2015-01-30  Chris Dumez  <cdumez@apple.com>
1471
1472         Unreviewed. Fix Windows build after r179409.
1473
1474         * DumpRenderTree/win/TestRunnerWin.cpp:
1475         (TestRunner::notifyDone):
1476         (TestRunner::queueLoad):
1477
1478 2015-01-30  Chris Dumez  <cdumez@apple.com>
1479
1480         Rename shared() static member functions to singleton() for singleton classes.
1481         https://bugs.webkit.org/show_bug.cgi?id=141088
1482
1483         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1484
1485         Rename shared() static member functions to singleton() for singleton
1486         classes as per the recent coding style change.
1487
1488 2015-01-30  Antti Koivisto  <antti@apple.com>
1489
1490         OSObjectPtr does not work with dispatch_data_t on Maverics
1491         https://bugs.webkit.org/show_bug.cgi?id=141081
1492
1493         Reviewed by Pratik Solanki.
1494
1495         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1496         (TestWebKitAPI::TEST):
1497
1498 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1499
1500         [Win] Switch to Apache on Windows
1501         https://bugs.webkit.org/show_bug.cgi?id=141060
1502
1503         Reviewed by Alexey Proskuryakov.
1504
1505         Update our scripts under Windows (and Cygwin) to locate and use
1506         the XAMPP installation of Apache for running tests.
1507
1508         * Scripts/run-webkit-httpd:
1509         * Scripts/webkitperl/httpd.pm:
1510         (getHTTPDPath):
1511         (getDefaultConfigForTestDirectory):
1512         (getHTTPDConfigPathForTestDirectory):
1513         * Scripts/webkitpy/common/system/executive_unittest.py:
1514         (ExecutiveTest.serial_test_kill_process):
1515         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1516         (LayoutTestApacheHttpd.__init__):
1517         (LayoutTestApacheHttpd._get_apache_config_file_path):
1518         (LayoutTestApacheHttpd._stop_running_server):
1519         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1520         (HttpServerBase._is_server_running_on_all_ports):
1521         * Scripts/webkitpy/port/base.py:
1522         (Port._apache_config_file_name_for_platform):
1523         * Scripts/webkitpy/port/port_testcase.py:
1524         (test_apache_config_file_name_for_platform):
1525         * Scripts/webkitpy/port/win.py:
1526         (WinPort.show_results_html_file):
1527         (WinPort._uses_apache):
1528         (WinPort):
1529         (WinPort._path_to_apache):
1530
1531 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1532
1533         Built result takes too long to be compressed on bots
1534         https://bugs.webkit.org/show_bug.cgi?id=141056
1535
1536         Reviewed by Daniel Bates.
1537
1538         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1539
1540         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1541
1542 2015-01-29  Sam Weinig  <sam@webkit.org>
1543
1544         Remove support for screen font substitution
1545         https://bugs.webkit.org/show_bug.cgi?id=141038
1546
1547         Reviewed by Tim Horton.
1548
1549         * DumpRenderTree/win/DumpRenderTree.cpp:
1550         (resetWebPreferencesToConsistentValues):
1551         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1552
1553 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1554
1555         Make run-jsc-stress-tests --remote work on Linux too
1556         https://bugs.webkit.org/show_bug.cgi?id=141000
1557
1558         Reviewed by Darin Adler.
1559
1560         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1561         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1562         use bash/dash compatible functions.
1563         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1564
1565 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1566
1567         [buildbot] Simplify jscore-test buildstep
1568         https://bugs.webkit.org/show_bug.cgi?id=140821
1569
1570         Reviewed by Alexey Proskuryakov.
1571
1572         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1573         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1574         (RunJavaScriptCoreTests.countFailures): Added.
1575         (RunJavaScriptCoreTests.commandComplete): Deleted.
1576         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1577         (RunJavaScriptCoreTests.getText): Deleted.
1578         (RunJavaScriptCoreTests.getText2): Deleted.
1579         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1580         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1581         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1582         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1583         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1584
1585 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1586
1587         Unreviewed, revert r179337, we don't need this dependency.
1588
1589         * efl/install-dependencies:
1590         * gtk/install-dependencies:
1591
1592 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1593
1594         Unreviewed. Moving myself to the committer section.
1595
1596         * Scripts/webkitpy/common/config/contributors.json:
1597
1598 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1599
1600         URTBF after r179326, added uuid-dev package as new dependency.
1601
1602         * efl/install-dependencies:
1603         * gtk/install-dependencies:
1604
1605 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1606
1607         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1608         https://bugs.webkit.org/show_bug.cgi?id=140673
1609
1610         Reviewed by Sam Weinig.
1611
1612         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1613         Add a DTrace script that outputs a small blob of JSON per message.
1614
1615 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1616
1617         Removed fastMallocForbid / fastMallocAllow
1618         https://bugs.webkit.org/show_bug.cgi?id=141012
1619
1620         Reviewed by Mark Hahnenberg.
1621
1622         Fixed a test bug I noticed while testing.
1623
1624         * DumpRenderTree/JavaScriptThreading.cpp:
1625         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1626         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1627
1628 2015-01-28  Dana Burkart  <dburkart@apple.com>
1629
1630         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1631         https://bugs.webkit.org/show_bug.cgi?id=141015
1632
1633         Reviewed by Alexey Proskuryakov.
1634
1635         * asan/asan.xcconfig:
1636
1637 2015-01-28  Sam Weinig  <sam@webkit.org>
1638
1639         Fix the build.
1640
1641         * Scripts/copy-webkitlibraries-to-product-directory:
1642
1643 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1644
1645         Increase the FileUpload block size in an attempt to improve network performance.
1646         
1647         Reviewed by Alexey Proskuryakov.
1648         
1649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1650         (UploadBuiltProduct.__init__):
1651
1652 2015-01-28  Dana Burkart  <dburkart@apple.com>
1653
1654         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1655         https://bugs.webkit.org/show_bug.cgi?id=136765
1656
1657         Reviewed by Alexey Proskuryakov.
1658
1659         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1660         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1661         * LayoutTestRelay/Configurations/Base.xcconfig:
1662         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1663         * MiniBrowser/Configurations/Base.xcconfig:
1664         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1665         * TestWebKitAPI/Configurations/Base.xcconfig:
1666         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1667         * WebKitLauncher/Configurations/Base.xcconfig:
1668         * WebKitTestRunner/Configurations/Base.xcconfig:
1669         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1670
1671 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1672
1673         AX: [ATK] Implement support for new AtkRole types for MathML
1674         https://bugs.webkit.org/show_bug.cgi?id=140916
1675
1676         Reviewed by Chris Fleizach.
1677
1678         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1679         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1680
1681 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         [GTK] Stop removing color marks from unit tests output
1684         https://bugs.webkit.org/show_bug.cgi?id=140996
1685
1686         Reviewed by Philippe Normand.
1687
1688         Since r178236 google tests use a custom simplified output without
1689         any colors, so we don't need to handle the case of non ttys to
1690         remove the color marks.
1691
1692         * Scripts/run-gtk-tests:
1693         (TestRunner.__init__):
1694         (TestRunner._run_test_command.parse_line):
1695
1696 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1697
1698         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1699         https://bugs.webkit.org/show_bug.cgi?id=131731
1700
1701         Reviewed by Žan Doberšek.
1702
1703         A web page loaded offscreen is in prerender state not hidden.
1704
1705         * Scripts/run-gtk-tests:
1706         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1707         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1708         (testWebViewPageVisibility):
1709
1710 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1711
1712         Partially revert r178802.
1713
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1716
1717 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1718
1719         build.webkit.org/dashboard asserts on some commits
1720         https://bugs.webkit.org/show_bug.cgi?id=140926
1721
1722         Reviewed by Tim Horton.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1725         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1726
1727 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1728
1729         Make flakiness dashboard OS list actually match test_expectations.py
1730         https://bugs.webkit.org/show_bug.cgi?id=140969
1731
1732         Reviewed by Ryosuke Niwa.
1733
1734         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1735
1736 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1737
1738         [Win] WinLauncher crashes on eleventh site visited
1739         https://bugs.webkit.org/show_bug.cgi?id=140960
1740
1741         Reviewed by Anders Carlsson.
1742
1743         * WinLauncher/WinLauncher.cpp:
1744         (WinLauncher::showLastVisitedSites): Don't access off the end of
1745         the history array.
1746
1747 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1748
1749         [Mac] Disable building Java applets by default
1750         https://bugs.webkit.org/show_bug.cgi?id=140957
1751         rdar://problem/19619529
1752
1753         Reviewed by Anders Carlsson.
1754
1755         It was actually already disabled unconditionally, by accident.
1756
1757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1758         * Scripts/webkitpy/port/mac.py:
1759         (MacPort._check_port_build):
1760         (MacPort._build_java_test_support):
1761
1762 2015-01-27  Daniel Bates  <dabates@apple.com>
1763
1764         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1765         https://bugs.webkit.org/show_bug.cgi?id=140949
1766
1767         Reviewed by Alexey Proskuryakov.
1768
1769         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1770         builders so that run-webkit-tests can lint the appropriate TestExpectation
1771         files.
1772
1773         * Scripts/webkitpy/port/builders.py:
1774         * Scripts/webkitpy/port/ios.py:
1775         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1776         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1777         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1778         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1779         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1780         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1781         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1782
1783
1784 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1785
1786         Update bots on the flakiness dashboard
1787         https://bugs.webkit.org/show_bug.cgi?id=140956
1788
1789         Reviewed by Ryosuke Niwa.
1790
1791         * TestResultServer/static-dashboards/builders.jsonp:
1792         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1793
1794 2015-01-27  Daniel Bates  <dabates@apple.com>
1795
1796         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1797         https://bugs.webkit.org/show_bug.cgi?id=140942
1798
1799         Reviewed by Alexey Proskuryakov.
1800
1801         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1802         are applicable to all WebKit2 ports. We should make use of this information when
1803         running layout tests using iOS WebKit2.
1804
1805         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1806         of the WebKit2 port instead of directly using string concatenation.
1807
1808         * Scripts/webkitpy/port/ios.py:
1809         (IOSSimulatorPort.default_baseline_search_path):
1810
1811 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1812
1813         [Win] Disable FTL stress tests
1814         https://bugs.webkit.org/show_bug.cgi?id=140932
1815
1816         Reviewed by Brent Fulgham.
1817
1818         * Scripts/run-javascriptcore-tests:
1819
1820 2015-01-27  Daniel Bates  <dabates@apple.com>
1821
1822         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1823         https://bugs.webkit.org/show_bug.cgi?id=140939
1824
1825         Reviewed by Eric Carlson.
1826
1827         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1828
1829         * Scripts/webkitdirs.pm:
1830         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1831         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1832         and define a function called wanted.
1833
1834 2015-01-27  Daniel Bates  <dabates@apple.com>
1835
1836         Teach run-webkit-app --simulator how to install custom built app
1837         https://bugs.webkit.org/show_bug.cgi?id=140691
1838
1839         Fix inadvertent omission of directory test flag in expression to check for the
1840         existence of the iOS simulator device-specific directory for user installed apps.
1841
1842         * Scripts/webkitdirs.pm:
1843         (hasUserInstalledAppInSimulatorDevice):
1844
1845 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1846
1847         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1848         https://bugs.webkit.org/show_bug.cgi?id=87426
1849         <rdar://problem/11527899>
1850
1851         Reviewed by Darin Adler.
1852
1853         Revise COMPtr to work better with our HashMap implementation. Use
1854         modern loop syntax.
1855
1856         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1857         (AccessibilityController::~AccessibilityController):
1858         (AccessibilityController::winNotificationReceived):
1859         * DumpRenderTree/win/DumpRenderTree.cpp:
1860         (dumpBackForwardListForAllWindows):
1861
1862 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1863
1864         [Win] Enable JSC stress tests by default
1865         https://bugs.webkit.org/show_bug.cgi?id=128307
1866
1867         Reviewed by Brent Fulgham.
1868
1869         * Scripts/run-javascriptcore-tests:
1870
1871 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1872
1873         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1874         arguments for build and test scripts
1875         https://bugs.webkit.org/show_bug.cgi?id=139748
1876
1877         Reviewed by Daniel Bates.
1878
1879         There was much confusion resulting from the multitude of aliases used to build/test for
1880         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1881         tests directory.
1882
1883         This fixes an issue where run-api-tests and some other scripts failed when run with
1884         --simulator.
1885
1886         * Scripts/build-webkit:
1887         * Scripts/package-root:
1888         (usage):
1889         * Scripts/webkitdirs.pm:
1890         (argumentsForConfiguration):
1891         (determineXcodeSDK):
1892         * Scripts/webkitpy/port/factory.py:
1893         (platform_options):
1894
1895 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1896
1897         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1898         https://bugs.webkit.org/show_bug.cgi?id=140203
1899         rdar://problem/19198492
1900
1901         Reviewed by Sam Weinig.
1902
1903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1904         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1905         (TEST):
1906
1907 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1908
1909         Add iOS EWS to build.webkit.org/dashboard
1910         <http://webkit.org/b/140627>
1911
1912         Reviewed by Alexey Proskuryakov.
1913
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1917         (BubbleQueueServer): Add ios-ews queue info.
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1919         Add iOS8Device platform.
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1921         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1922         iOS device logo.
1923
1924 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1925
1926         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1927         https://bugs.webkit.org/show_bug.cgi?id=140896
1928
1929         Reviewed by Michael Saboff.
1930         
1931         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1932         makes our script do this.
1933         
1934         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1935         this would be harder given llvm's autoconf setup.
1936
1937         * Scripts/copy-webkitlibraries-to-product-directory:
1938
1939 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1940
1941         Update bot assignments.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/config.json:
1944
1945 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1946
1947         Integrate WP python server into WebKit test framework
1948         https://bugs.webkit.org/show_bug.cgi?id=127094
1949
1950         Reviewed by Ryosuke Niwa.
1951
1952         This patch adds W3C web server (wptserver) as a new HTTP server.
1953         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1954         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1955
1956         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1957         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1958         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1959
1960         * Scripts/webkitpy/common/system/executive_mock.py:
1961         (MockProcess.communicate):
1962         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1963         (LayoutTestRunner.__init__):
1964         (LayoutTestRunner.run_tests):
1965         (LayoutTestRunner.start_servers):
1966         (LayoutTestRunner.stop_servers):
1967         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1968         (LayoutTestRunnerTests._run_tests):
1969         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1970         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1971         (LayoutTestRunnerTests):
1972         (LayoutTestRunnerTests.test_servers_started):
1973         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1974         (Manager.__init__):
1975         (Manager._is_http_test):
1976         (Manager._is_web_platform_test):
1977         (Manager._run_tests):
1978         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1979         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1980         (ManagerTest.test_needs_servers.get_manager):
1981         (ManagerTest.test_needs_servers):
1982         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1983         (parse_args):
1984         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1985         (main):
1986         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1987         (doc_root):
1988         (base_url):
1989         (WebPlatformTestServer):
1990         (WebPlatformTestServer.__init__):
1991         (WebPlatformTestServer._set_start_cmd):
1992         (WebPlatformTestServer._copy_webkit_test_files):
1993         (WebPlatformTestServer._clean_webkit_test_files):
1994         (WebPlatformTestServer._prepare_config):
1995         (WebPlatformTestServer._spawn_process):
1996         (WebPlatformTestServer._stop_running_server):
1997         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1998         (TestWebPlatformTestServer):
1999         (TestWebPlatformTestServer.test_start_cmd):
2000         * Scripts/webkitpy/port/base.py:
2001         (Port.__init__):
2002         (Port.to.start_web_platform_test_server):
2003         (Port.to):
2004         (Port.to.web_platform_test_server_doc_root):
2005         (Port.to.web_platform_test_server_base_url):
2006         (Port.to.stop_web_platform_test_server):
2007         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
2008         (Driver.__init__):
2009         (Driver.is_web_platform_test):
2010         (Driver.test_to_uri):
2011         (Driver.uri_to_test):
2012         (Driver._command_from_driver_input):
2013         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
2014         (DriverTest.test_test_to_uri):
2015         (DriverTest.test_uri_to_test):
2016
2017 2015-01-26  Daniel Bates  <dabates@apple.com>
2018
2019         Teach run-webkit-app --simulator how to install custom built app
2020         https://bugs.webkit.org/show_bug.cgi?id=140691
2021
2022         Reviewed by David Kilzer.
2023
2024         We should teach run-webkit-app --simulator how to install a custom built app.
2025
2026         Currently run-webkit-app --simulator can only run a system app or an app that
2027         was installed using the simctl command line tool. For convenience we should
2028         teach run-webkit-app --simulator how to install a custom built app.
2029
2030         As a side effect of this change run-safari --simulator will install and run
2031         a custom built of MobileSafari (if it exists).
2032
2033         * Scripts/webkitdirs.pm:
2034         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
2035         Perl from the structure of the device.plist file.
2036         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
2037         file system check to determine the plist path for a Mac app bundle.
2038         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
2039         it will complain that it cannot find the file: "Domain ... does not exist".
2040         (appDisplayNameFromBundle): Ditto.
2041         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
2042         until a simulator device is the specified state.
2043         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
2044         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
2045         the specified device.
2046         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
2047         As implied by its name, this function will not return until the specified simulator
2048         device UDID is in the shutdown state.
2049         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
2050         device with the specified UDID.
2051         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
2052         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
2053         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
2054         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
2055         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
2056         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
2057         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
2058         (hasUserInstalledAppInSimulatorDevice): Added.
2059         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
2060         "Booted" state.
2061         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
2062         switching between a system installed app and a custom built version of the same app (e.g.
2063         custom build of MobileSafari) will erase all contents and settings in the simulator device.
2064         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
2065         as that was the only caller of this function.
2066         (bootedIOSSimulatorDevice): Deleted.
2067         (openIOSSimulator): Deleted.
2068
2069 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2070
2071         Update bot assignments.
2072
2073         * BuildSlaveSupport/build.webkit.org-config/config.json:
2074
2075 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2076
2077         Leaks bot shouldn't run JSC tests
2078         https://bugs.webkit.org/show_bug.cgi?id=140877
2079
2080         Reviewed by Darin Adler.
2081
2082         Shaves off 48 minutes of time.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2085         (TestLeaksFactory): Slim down the leaks queue.
2086
2087         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2088         * Scripts/webkitpy/port/ios.py:
2089         (IOSSimulatorPort.print_leaks_summary):
2090         * Scripts/webkitpy/port/mac.py:
2091         (MacPort.print_leaks_summary):
2092         Don't yell when leaks are detected.
2093
2094 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2095
2096         Refactor run-javascriptcore-tests
2097         https://bugs.webkit.org/show_bug.cgi?id=140824
2098
2099         Reviewed by Darin Adler.
2100
2101         Separated mozilla, stress test code paths and
2102         determining skipped mozilla tests into subroutines.
2103
2104         * Scripts/run-javascriptcore-tests:
2105         (runMozillaTests):
2106         (runJSCStressTests):
2107         (defaultJsDriverArgsForMozillaTests):
2108
2109 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2110
2111         [buildbot] Fix grammar of TestWithFailureCount
2112         https://bugs.webkit.org/show_bug.cgi?id=140884
2113
2114         Reviewed by Alexey Proskuryakov.
2115
2116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2117         (TestWithFailureCount):
2118         (TestWithFailureCount.commandComplete):
2119         (TestWithFailureCount.getText2):
2120         (RunUnitTests):
2121         (RunPythonTests):
2122         (RunPerlTests):
2123         (RunLLINTCLoopTests):
2124         (Run32bitJSCTests):
2125         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2126         (RunLLINTCLoopTestsTest.test_failure):
2127         (Run32bitJSCTestsTest.test_failure):
2128         (RunUnitTestsTest.assertFailures):
2129
2130 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2131
2132         Unreviewed. Moving myself to the committer section.
2133
2134         * Scripts/webkitpy/common/config/contributors.json:
2135
2136 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
2137
2138         [GTK] gtkdoc does not appear in DevHelp
2139         https://bugs.webkit.org/show_bug.cgi?id=139369
2140
2141         Reviewed by Philippe Normand.
2142
2143         * gtk/generate-gtkdoc: Create the generators in the main function
2144         and use them to get the local cross renference dependencies. Also
2145         pass the generator module name to webkitdom.write_doc_files().
2146         (get_gtkdoc_module_paths): Receive a list of local cross reference
2147         dependencies.
2148         (get_generator_for_config): Set the main_sgml_file property of the
2149         GtkDoc object from the configuration file.
2150         (generate_documentation): Generate the documentation for the given
2151         generator.
2152         (generate_documentation_for_config): Deleted.
2153         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
2154         * gtk/webkitdom.py:
2155         (write_doc_files): Receive the module name used to build the
2156         -sections.txt filename.
2157
2158 2015-01-26  Commit Queue  <commit-queue@webkit.org>
2159
2160         Unreviewed, rolling out r179107.
2161         https://bugs.webkit.org/show_bug.cgi?id=140880
2162
2163         The GCC in the bots doesn't support the AsyncTask
2164         implementation (Requested by KaL on #webkit).
2165
2166         Reverted changeset:
2167
2168         "[GTK] Enable IndexedDB"
2169         https://bugs.webkit.org/show_bug.cgi?id=98932
2170         http://trac.webkit.org/changeset/179107
2171
2172 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2173
2174         [EFL] Bump libseccomp version to 2.1.1
2175         https://bugs.webkit.org/show_bug.cgi?id=140357
2176
2177         Reviewed by Gyuyoung Kim.
2178
2179         * efl/jhbuild.modules:
2180
2181 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2182
2183         [GTK] Enable IndexedDB
2184         https://bugs.webkit.org/show_bug.cgi?id=98932
2185
2186         Reviewed by Žan Doberšek.
2187
2188         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2189
2190 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
2191
2192         Would like leaks bot results at build.webkit.org/dashboard
2193         https://bugs.webkit.org/show_bug.cgi?id=122657
2194
2195         Reviewed by Darin Adler.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2198         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
2199         than necessary, could use the ones from buildbot in more places.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2202         (BuildbotQueue): Reflect configuration option for leaks queues.
2203
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2205         Add leaks queues to performance column. First, leaks are about performance indeed,
2206         and second, this is where we have some space to spare.
2207
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2209         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
2210         least a year.
2211
2212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2213         (table.queue-grid td): Moved height from queue-view - we can now have more than one
2214         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
2215         results - once the results are loaded, all rows are currently higher than that.
2216
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2218         (.leaks-popover): Added.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2221         Added.
2222
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2224         Load BuildbotLeaksQueueView.js.
2225
2226 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
2227
2228         [Win] Add WebKit message loop interface.
2229         https://bugs.webkit.org/show_bug.cgi?id=140857
2230
2231         Reviewed by Brent Fulgham.
2232
2233         Added message loop interface which will run the message loop,
2234         and perform required tasks (like calling CFRunLoopRunInMode)
2235         on each iteration of the loop.
2236
2237         * WinLauncher/WinMain.cpp:
2238         (wWinMain): Use new message loop interface.
2239
2240 2015-01-24  Dan Bernstein  <mitz@apple.com>
2241
2242         update-webkit’s --internal option is unused
2243         https://bugs.webkit.org/show_bug.cgi?id=140861
2244
2245         Reviewed by Anders Carlsson.
2246
2247         * Scripts/update-webkit: Removed the option.
2248
2249 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
2250
2251         DumpRenderTree needs to run with Windows native controls on Windows
2252         https://bugs.webkit.org/show_bug.cgi?id=25592
2253
2254         Reviewed by Anders Carlsson.
2255
2256         * DumpRenderTree/win/DumpRenderTree.cpp:
2257         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
2258         (prepareConsistentTestingEnvironment): Ditto.
2259
2260 2015-01-23  David Kilzer  <ddkilzer@apple.com>
2261
2262         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
2263         <http://webkit.org/b/140787>
2264
2265         Reviewed by Daniel Bates.
2266
2267         * Scripts/webkitpy/port/ios.py:
2268         (IOSPort.determine_full_port_name): Instead of checking the type
2269         of the current host, test if /usr/bin/xcrun exists before trying
2270         to use it.
2271
2272 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
2273
2274         Fix the false positive build failures on the Windows buildbots
2275         https://bugs.webkit.org/show_bug.cgi?id=140819
2276
2277         Reviewed by Brent Fulgham.
2278
2279         Increase the build timeout (without producing output) to 2 hours for Windows bots,
2280         the default 20 minutes is enough for others since they produce output during the build.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2283         (BuildFactory.__init__):
2284
2285 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2286
2287         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
2288         https://bugs.webkit.org/show_bug.cgi?id=140839
2289
2290         Reviewed by Dean Jackson.
2291
2292         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2293         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
2294         from the IA2Locale structure and pass it to DRT.
2295
2296 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2297
2298         [Win] Update DRT Accessibility implementation to better match Mac.
2299         https://bugs.webkit.org/show_bug.cgi?id=140830
2300
2301         Reviewed by Dean Jackson.
2302
2303         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2304         (AccessibilityUIElement::titleUIElement):
2305         (AccessibilityUIElement::parentElement):
2306         (convertToDRTLabel):
2307         (AccessibilityUIElement::role):
2308         (AccessibilityUIElement::title):
2309         (AccessibilityUIElement::description):
2310         (AccessibilityUIElement::stringValue):
2311         (AccessibilityUIElement::helpText):
2312         (AccessibilityUIElement::isFocused):
2313
2314 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
2315
2316         REGRESSION: run-perf-tests --profiler= seems to have broken
2317         https://bugs.webkit.org/show_bug.cgi?id=113528
2318
2319         Reviewed by Daniel Bates.
2320
2321         The problem is that "perf --record" (or the equivalent call for
2322         other profilers) is never called whenever there is a wrapper
2323         option in the port. We should inject the profiler call first
2324         (should it exists) and then use the port wrapper.
2325
2326         * Scripts/webkitpy/port/driver.py:
2327         (Driver._command_wrapper):
2328         * Scripts/webkitpy/port/driver_unittest.py:
2329         (DriverTest.test_profiler_and_wrapper): New unit test.
2330
2331 2015-01-22  David Kilzer  <ddkilzer@apple.com>
2332
2333         configure-xcode-for-ios-development needs to import webkitdirs.pm
2334         <http://webkit.org/b/140704>
2335
2336         Fixes the following runtime error:
2337
2338             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2339
2340         * Scripts/configure-xcode-for-ios-development: Add back code to
2341         import webkitdirs.pm for the exitStatus() method.  Not sure why
2342         I removed it before patch review.
2343
2344 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
2345
2346         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2347         https://bugs.webkit.org/show_bug.cgi?id=140795
2348
2349         Reviewed by Jon Honeycutt.
2350
2351         * BuildSlaveSupport/build.webkit.org-config/config.json:
2352         r178847 accidentally remove the scheduler for this bot. Re-add it to the
2353         Yosemite scheduler.
2354
2355 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
2356
2357         [Win] Expose missing editing features through WebView interface
2358         https://bugs.webkit.org/show_bug.cgi?id=140773
2359         <rdar://problem/19565421>
2360
2361         Reviewed by Dean Jackson.
2362
2363         Connect the various WebView editing delegate methods to our
2364         test infrastructure. Also prefer _bstr_t to raw BSTR types
2365         to simplify life cycle management.
2366
2367         * DumpRenderTree/win/DumpRenderTree.cpp:
2368         (resetWebViewToConsistentStateBeforeTesting):
2369         * DumpRenderTree/win/EditingDelegate.cpp:
2370         (EditingDelegate::QueryInterface):
2371         (dumpPath):
2372         (dump):
2373         (EditingDelegate::shouldBeginEditingInDOMRange):
2374         (EditingDelegate::shouldEndEditingInDOMRange):
2375         (EditingDelegate::shouldInsertNode):
2376         (EditingDelegate::shouldInsertText):
2377         (EditingDelegate::shouldDeleteDOMRange):
2378         (EditingDelegate::shouldChangeSelectedDOMRange):
2379         (EditingDelegate::shouldApplyStyle):
2380         (EditingDelegate::shouldChangeTypingStyle):
2381         (EditingDelegate::doPlatformCommand):
2382         (EditingDelegate::webViewDidBeginEditing):
2383         (EditingDelegate::webViewDidChange):
2384         (EditingDelegate::webViewDidEndEditing):
2385         (EditingDelegate::webViewDidChangeTypingStyle):
2386         (EditingDelegate::webViewDidChangeSelection):
2387         (EditingDelegate::checkSpellingOfString):
2388         (EditingDelegate::onNotify):
2389         * DumpRenderTree/win/EditingDelegate.h:
2390
2391 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2392
2393         Add a build flag for ES6 class syntax
2394         https://bugs.webkit.org/show_bug.cgi?id=140760
2395
2396         Reviewed by Michael Saboff.
2397
2398         * Scripts/webkitperl/FeatureList.pm:
2399
2400 2015-01-22  Daniel Bates  <dabates@apple.com>
2401
2402         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2403         runtime in simctl output
2404         https://bugs.webkit.org/show_bug.cgi?id=140751
2405
2406         Reviewed by David Kilzer.
2407
2408         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2409         with an error because it does not know how to parse the output of the simctl tool
2410         to identify an Apple Internal runtime.
2411
2412         * Scripts/webkitpy/xcode/simulator.py:
2413         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2414         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2415         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2416         the runtime is an internal runtime.
2417         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2418         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2419         appropriate value.
2420         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2421         it updates the appropriate Runtime object.
2422         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2423         looking up a Runtime object for an internal runtime.
2424
2425 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
2426
2427         LeaksViewer doesn't show recent builds if there are less than 10
2428         https://bugs.webkit.org/show_bug.cgi?id=140716
2429
2430         Reviewed by Tim Horton.
2431
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2433
2434 2015-01-22  Lucas Forschler  <lforschler@apple.com>
2435
2436         Add Apple build slaves.
2437         Fixed text alignment for slave list.
2438         
2439         Unreviewed.
2440         
2441         * BuildSlaveSupport/build.webkit.org-config/config.json:
2442
2443 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2444
2445         Teach build.webkit.org about bot308 and bot309.
2446         
2447         Unreviewed.
2448         
2449         * BuildSlaveSupport/build.webkit.org-config/config.json:
2450
2451 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2452
2453         Add two Apple Mavericks slaves.
2454         
2455         Unreviewed.
2456         
2457         * BuildSlaveSupport/build.webkit.org-config/config.json:
2458
2459 2015-01-21  Daniel Bates  <dabates@apple.com>
2460
2461         Add iOS WebKit1 TestExpectation file
2462         https://bugs.webkit.org/show_bug.cgi?id=140739
2463
2464         Reviewed by David Kilzer.
2465
2466         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2467         expectations in directory LayoutTests/platform/ios-simulator-wk1.
2468
2469         * Scripts/webkitpy/port/ios.py:
2470         (IOSSimulatorPort.default_baseline_search_path):
2471
2472 2015-01-21  David Kilzer  <ddkilzer@apple.com>
2473
2474         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2475         <http://webkit.org/b/140704>
2476
2477         Reviewed by Daniel Bates.
2478
2479         * Scripts/configure-xcode-for-ios-development:
2480         - Update copyright.
2481         - Remove FIXME addressed by r178709.
2482         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2483         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2484         missing headers from iphonesimulator SDK to iphoneos SDK.
2485         (sdkDirectory): Add method that returns SDK directory.
2486         (sdkPlatformDirectory): Extract method from
2487         xcodeSDKSpecificationsPath() that returns SDK platform
2488         directory.
2489         (xcodeSDKSpecificationsPath): Update to use
2490         sdkPlatformDirectory().
2491
2492 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2493
2494         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2495         https://bugs.webkit.org/show_bug.cgi?id=140731
2496
2497         Reviewed by Tim Horton.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2500         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2501
2502 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2503
2504         [Win] eventSender does not support scalePageBy
2505         https://bugs.webkit.org/show_bug.cgi?id=140726
2506         <rdar://problem/19549865>
2507
2508         Reviewed by Dean Jackson.
2509
2510         * DumpRenderTree/win/EventSender.cpp:
2511         (scalePageByCallback): Provide implementation using new WebView method.
2512
2513 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2514
2515         Remove Apple Mountain Lion Build & Test slaves.
2516         
2517         Unreviewed.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/config.json:
2520
2521 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2522
2523         Remove ENABLE(INSPECTOR) ifdef guards
2524         https://bugs.webkit.org/show_bug.cgi?id=140668
2525
2526         Reviewed by Darin Adler.
2527
2528         * DumpRenderTree/mac/TestRunnerMac.mm:
2529         (TestRunner::showWebInspector):
2530         (TestRunner::closeWebInspector):
2531         (TestRunner::evaluateInWebInspector):
2532         * Scripts/webkitperl/FeatureList.pm:
2533         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2534         (WTR::TestRunner::showWebInspector):
2535         (WTR::TestRunner::closeWebInspector):
2536         (WTR::TestRunner::evaluateInWebInspector):
2537         * WebKitTestRunner/TestInvocation.cpp:
2538         (WTR::TestInvocation::invoke):
2539
2540 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2541
2542         Update build.webkit.org/dashboard to match current Mac queues.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2551         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2552         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2553
2554 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2555
2556         Update Apple MountainLion Leaks slave to Yosemite
2557         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2558         
2559         Unreviewed.
2560
2561         * BuildSlaveSupport/build.webkit.org-config/config.json:
2562
2563 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2564
2565         Update LeaksViewer from MountainLion to Yosemite
2566         
2567         Reviewed by Alexey Proskuryakov.
2568
2569         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2570         (LeaksViewer._displayURLPrompt):
2571
2572 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2573
2574         Fix EWS python unit tests and address code comments as per 140476
2575         https://bugs.webkit.org/show_bug.cgi?id=140637
2576
2577         Reviewed by David Kilzer.
2578
2579         * Scripts/webkitpy/port/base.py:
2580         (Port):
2581         (Port.__init__):
2582         Adds DEFAULT_ARCHITECTURE member.
2583         (Port.architecture):
2584         Removes architecture member and instead uses
2585         self.get_option('architecture'). Also removes redundant architecture
2586         method.
2587         (Port.set_architecture):
2588         Adds a setter for the architecture variable to be able to set a flag
2589         upon modification.
2590         (Port.test_configuration):
2591         Uses self.architecture() instead of self._architecture.
2592         * Scripts/webkitpy/port/ios.py:
2593         Overrides DEFAULT_ARCHITECTURE.
2594         (IOSPort):
2595         (IOSPort.determine_full_port_name):
2596         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2597         strip. Fixes regex to not match arbitrary characters after the
2598         relevent digits are matched.
2599         (IOSPort.__init__):
2600         Removes old _architecture defaulting strategy.
2601         (IOSPort._build_driver_flags):
2602         Uses self.architecture() instead of self._architecture.
2603         (IOSSimulatorPort):
2604         Overrides DEFAULT_ARCHITECTURE.
2605         (IOSSimulatorPort.__init__):
2606         Removes old _architecture defaulting strategy.
2607         * Scripts/webkitpy/port/mac.py:
2608         (MacPort):
2609         Overrides DEFAULT_ARCHITECTURE.
2610         (MacPort.__init__):
2611         Removes old _architecture defaulting strategy.
2612         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2613         (AbstractEarlyWarningSystem.run_command):
2614         Checks the did_override_architecture flag to determine whether to add
2615         the --architecture option.
2616         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2617         Uses ews.architecture rather than trying to discern the correct
2618         architecture using a port object.
2619         (EarlyWarningSystemTest._default_expected_logs):
2620         * Scripts/webkitpy/tool/commands/queues.py:
2621         Removes use of optparse, and removes the import statement.
2622         (AbstractQueue.__init__):
2623         (PatchProcessingQueue.begin_work_queue):
2624
2625 2015-01-20  Sam Weinig  <sam@webkit.org>
2626
2627         Attempt to fix Mountain Lion and EFL tests.
2628
2629         * WebKitTestRunner/TestController.cpp:
2630         (WTR::TestController::initialize):
2631         Disable Process-per-tab and network process on Mountain Lion and EFL.
2632
2633 2015-01-20  Darin Adler  <darin@apple.com>
2634
2635         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2636         https://bugs.webkit.org/show_bug.cgi?id=140679
2637
2638         Reviewed by Anders Carlsson.
2639
2640         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2641         Removed a reference to SVGElementInstanceList.
2642
2643 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2644
2645         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2646         https://bugs.webkit.org/show_bug.cgi?id=140028
2647
2648         Reviewed by Carlos Garcia Campos.
2649
2650         This won't work as expected, since this function is called before the
2651         WebViewTest constructor completes.
2652
2653         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2654
2655 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2656
2657         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2658         <http://webkit.org/b/140661>
2659
2660         Reviewed by Daniel Bates.
2661
2662         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2663         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2664         "iphoneos" and "iphonesimulator" SDKs.
2665         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2666         the main body of the script.
2667
2668 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2669
2670         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2671         https://bugs.webkit.org/show_bug.cgi?id=139443
2672
2673         Reviewed by Carlos Garcia Campos.
2674
2675         Create the new test cases for setting the editable property on the web
2676         view and on the contenteditable enabled document. Also rework the
2677         current tests that are expecting that the web view is editable.
2678
2679         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2680         (loadTestHtml):
2681         (testWebViewEditorCutCopyPasteNonEditable):
2682         (testWebViewEditorCutCopyPasteEditable):
2683         (testWebViewEditorSelectAllNonEditable):
2684         (testWebViewEditorSelectAllEditable):
2685         (runEditorEditableCutTests):
2686         (testWebViewEditorEditableOnNonEditable):
2687         (testWebViewEditorEditableOnContentEditable):
2688         (testWebViewEditorNonEditable):
2689         (beforeAll):
2690         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2691         (WebViewTest::isEditable):
2692         (WebViewTest::setEditable):
2693
2694 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2695
2696         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2697         https://bugs.webkit.org/show_bug.cgi?id=140617
2698
2699         Reviewed by Gustavo Noronha Silva.
2700
2701         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2702         (testWebViewSnapshot): Check that the same snapshot with
2703         transparent background is different than the default one filled
2704         with white.
2705
2706 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         [GTK] Add API to change the WebKitWebView background color
2709         https://bugs.webkit.org/show_bug.cgi?id=140610
2710
2711         Reviewed by Gustavo Noronha Silva.
2712
2713         Add --bg-color command line option to MiniBrowser to be able to
2714         manually test the API passing any RGBA color to MiniBrowser.
2715         Also add a simple unit test to check that getting and setting
2716         colors from the API point of view.
2717
2718         * MiniBrowser/gtk/BrowserWindow.c:
2719         (browser_window_set_background_color):
2720         * MiniBrowser/gtk/BrowserWindow.h:
2721         * MiniBrowser/gtk/main.c:
2722         (createBrowserWindow):
2723         (parseBackgroundColor):
2724         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2725         (testWebViewBackgroundColor):
2726         (beforeAll):
2727
2728 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2729
2730         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2731         https://bugs.webkit.org/show_bug.cgi?id=140665
2732
2733         Reviewed by Brian Burg.
2734
2735         * DumpRenderTree/win/UIDelegate.cpp:
2736         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2737         match expected test output.
2738
2739 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2740
2741         Remove the support for custom suffixes on ChangeLog
2742         https://bugs.webkit.org/show_bug.cgi?id=140648
2743
2744         Reviewed by David Kilzer.
2745
2746         Custom suffixes were used for the iOS branch of WebKit.
2747         Now that everything is opensource, there is no need for it.
2748
2749         * Scripts/VCSUtils.pm:
2750         (changeLogSuffix): Deleted.
2751         (changeLogFileName): Deleted.
2752         * Scripts/commit-log-editor:
2753         * Scripts/prepare-ChangeLog:
2754         (getLatestChangeLogs):
2755         (generateNewChangeLogs):
2756         (generateFileList):
2757         * Scripts/resolve-ChangeLogs:
2758         (findChangeLog):
2759
2760 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2761
2762         Adjust naming of action menu SPI
2763         https://bugs.webkit.org/show_bug.cgi?id=140644
2764         <rdar://problem/19448129>
2765
2766         Reviewed by Brian Weinstein.
2767
2768         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2769         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2770         (TestWebKitAPI::TEST):
2771
2772 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2773
2774         [GTK] Generate the make dist manifest from a CMake template file
2775         https://bugs.webkit.org/show_bug.cgi?id=139387
2776
2777         Reviewed by Martin Robinson.
2778
2779         Remove the code that performs variable substitution on manifest.txt.
2780         Replace the custom variables used in that file with CMake variables.
2781
2782         * gtk/make-dist.py:
2783         (Manifest.add_directory):
2784         (Manifest.get_full_source_path):
2785         (Manifest.process_line):
2786         (Manifest.resolve_variables): Deleted.
2787         (Manifest.get_full_tarball_path): Deleted.
2788         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2789
2790 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2791
2792         [Win] Correct merge error in last commit.
2793
2794         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2795         (findAccessibleObjectById): Undo accidental paste made during landing.
2796
2797 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2798
2799         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2800         https://bugs.webkit.org/show_bug.cgi?id=139906
2801
2802         Reviewed by Dean Jackson.
2803
2804         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2805         to use them. This patch fixes that.
2806
2807         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2808         (findAccessibleObjectById):
2809         (AccessibilityController::focusedElement):
2810         (logEventProc):
2811         (notificationListenerProc):
2812         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2813         (AccessibilityUIElement::getChildAtIndex):
2814         (AccessibilityUIElement::titleUIElement):
2815         (self):
2816         (AccessibilityUIElement::role):
2817         (AccessibilityUIElement::valueDescription):
2818         (accessibilityState):
2819         (AccessibilityUIElement::isChecked):
2820         * DumpRenderTree/win/DumpRenderTree.cpp:
2821         (dumpFrameScrollPosition):
2822         (dumpFramesAsText):
2823         * DumpRenderTree/win/PolicyDelegate.cpp:
2824         (PolicyDelegate::decidePolicyForNavigationAction):
2825         * DumpRenderTree/win/UIDelegate.cpp:
2826         (UIDelegate::exceededDatabaseQuota):
2827         * WinLauncher/Common.cpp:
2828         (setWindowText):
2829
2830 2015-01-19  Dean Jackson  <dino@apple.com>
2831
2832         Add "override" to fix the build with newer clangs.
2833
2834         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2835         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2836
2837 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2838
2839         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2840         <http://webkit.org/b/140623>
2841
2842         Reviewed by Daniel Bates.
2843
2844         * Scripts/build-webkit: Update help for --device switch.
2845         * Scripts/webkitdirs.pm:
2846         (determineXcodeSDK): When passing --device, prefer the internal
2847         iOS SDK if it exists, else fall back to the external iOS SDK.
2848         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2849         xcodebuild instead of trying to sanitize values.
2850
2851 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2852
2853         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2854         https://bugs.webkit.org/show_bug.cgi?id=140606
2855
2856         Reviewed by Csaba Osztrogonác.
2857
2858         * Scripts/webkitpy/bindings/main.py:
2859         (BindingsTests.generate_supplemental_dependency):
2860         (BindingsTests.main):
2861
2862 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2863
2864         [GTK] [WK2] TestWebKitWebView snapshot fails
2865         https://bugs.webkit.org/show_bug.cgi?id=120404
2866
2867         Reviewed by Žan Doberšek.
2868
2869         Rework the test to make sure the snapshot is always created at the
2870         desired size.
2871
2872         * Scripts/run-gtk-tests:
2873         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2874         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2875         (testWebViewSnapshot): Use a fixed size for the document, and
2876         disable scrollbars to make sure the visible area is always the
2877         WebView size.
2878         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2879         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2880         and height parameters to create the window with a given size.
2881         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2882
2883 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2884
2885         iOS EWS queue name should be consistent
2886         <http://webkit.org/b/140585>
2887
2888         Reviewed by Daniel Bates.
2889
2890         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2891         to 'ios'.
2892         * Scripts/webkitpy/common/config/ports.py: Ditto.
2893         (DeprecatedPort.port):
2894         (IOSPort):
2895         * Scripts/webkitpy/port/ios.py: Ditto.
2896         (IOSPort):
2897
2898         * Scripts/webkitpy/port/factory.py:
2899         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2900         appears before ios.IOSPort.  If this is not done,
2901         `run-webkit-tests --ios-simulator` will get the wrong Port class
2902         (IOSPort instead of IOSSimulatorPort) due to the way that
2903         PortFactory.get() uses prefix matching of <Port>.port_name to
2904         find the correct class to use.
2905
2906 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2907
2908         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2909         https://bugs.webkit.org/show_bug.cgi?id=140595
2910
2911         Reviewed by Csaba Osztrogonác.
2912
2913         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2914         (BubbleQueueServer):
2915
2916 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2917
2918         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2919
2920         * Scripts/webkitpy/port/ios.py:
2921         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2922         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2923         the Mountain Lion and Mavericks bots.
2924
2925 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2926
2927         Attempt to fix webkitpy tests on GTK Linux ports
2928
2929         * Scripts/webkitpy/port/ios.py:
2930         (IOSPort.determine_full_port_name): Set a sensible default if
2931         not running on a Mac platform or if no iOS SDK is installed.
2932
2933 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2934
2935         Create iOS-EWS client queue
2936         https://bugs.webkit.org/show_bug.cgi?id=140476
2937
2938         Reviewed by Alexey Proskuryakov.
2939
2940         * EWSTools/start-queue-mac.sh:
2941         Adds call to configure-xcode-for-ios-development for iOS EWS.
2942         * Scripts/webkitpy/common/config/ews.json:
2943         Adds the iOS EWS config entry.
2944         * Scripts/webkitpy/common/config/ports.py:
2945         (DeprecatedPort.port):
2946         Adds IOSPort to the port map.
2947         (IOSPort):
2948         (IOSPort.build_webkit_command):
2949         Adds --sdk=iphoneos to the webkit build command.
2950         * Scripts/webkitpy/port/base.py:
2951         (Port.architecture):
2952         Adds an accessor for the architecture member variable.
2953         * Scripts/webkitpy/port/factory.py:
2954         (PortFactory):
2955         Adds IOSPort to the port class list.
2956         * Scripts/webkitpy/port/ios.py:
2957         Adds the IOSPort to encapsulate iOS-specific things.
2958         (IOSPort):
2959         (IOSPort.determine_full_port_name):
2960         (IOSPort.__init__):
2961         (IOSPort._build_driver_flags):
2962         (IOSPort.operating_system):
2963         * Scripts/webkitpy/tool/commands/download_unittest.py:
2964         Adds the archetecture option to the mock options.
2965         (DownloadCommandsTest._default_options):
2966         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2967         Appends the archetecture option into calls to webkit-patch.
2968         (AbstractEarlyWarningSystem.review_patch):
2969         (AbstractEarlyWarningSystem.run_command):
2970         (AbstractEarlyWarningSystem.load_ews_classes):
2971         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2972         Adds logic to soothe the unittest now that --architecture is being
2973         thrown around everywhere.
2974         (EarlyWarningSystemTest._default_expected_logs):
2975         * Scripts/webkitpy/tool/commands/queues.py:
2976         Adds glue code to ferry the --architecture option around.
2977         (AbstractQueue.__init__):
2978         (PatchProcessingQueue.begin_work_queue):
2979         * Scripts/webkitpy/tool/steps/abstractstep.py:
2980         Adds the archetecture option to all AbstractSteps so that
2981         EarlyWarningSystem doesn't start shoving --architecture into
2982         unsuspecting commands.
2983         (AbstractStep.options):
2984         * Scripts/webkitpy/tool/steps/build.py:
2985         Translates the --architecture option into an ARCHS= format to pass to
2986         build-webkit.
2987         (Build.build):
2988         * Scripts/webkitpy/tool/steps/options.py:
2989         Adds a definition for the --architecture option.
2990         (Options):
2991
2992 2015-01-16  Sam Weinig  <sam@webkit.org>
2993
2994         Add a basic configuration object for WKView
2995         https://bugs.webkit.org/show_bug.cgi?id=140559
2996
2997         Reviewed by Anders Carlsson.
2998
2999         Add tests for WKPageConfigurationRef.
3000
3001         * TestWebKitAPI/PlatformWebView.h:
3002         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3003         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
3004         (TestWebKitAPI::TEST):
3005         (TestWebKitAPI::didFinishLoadForFrame):
3006         (TestWebKitAPI::setPageLoaderClient):
3007         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3008         (TestWebKitAPI::PlatformWebView::initialize):
3009         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3010
3011 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
3012
3013         WeakPtr functions crash when created with default constructor
3014         https://bugs.webkit.org/show_bug.cgi?id=140479
3015
3016         Reviewed by Andreas Kling.
3017
3018         Add WeakPtr API tests.
3019
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
3022         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
3023
3024 2015-01-16  Chris Dumez  <cdumez@apple.com>
3025
3026         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
3027         https://bugs.webkit.org/show_bug.cgi?id=140568
3028
3029         Reviewed by Alexey Proskuryakov.
3030
3031         Fix the script parsing CSSPropertyNames.in to stop splitting lines
3032         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
3033         e.g. "Longhands=background-position-x|background-position-y".
3034         This would confuse the script and treat this as a CSS property:
3035         "background-position-x|background-position-y".
3036
3037         We now split on white space and treat the first string on the line
3038         to be the property name (this is the syntax in this file).
3039
3040         * Scripts/webkitpy/w3c/test_converter.py:
3041         (_W3CTestConverter.__init__):
3042         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
3043
3044 2015-01-16  Daniel Bates  <dabates@apple.com>
3045
3046         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
3047         https://bugs.webkit.org/show_bug.cgi?id=135589
3048
3049         Reviewed by David Kilzer.
3050
3051         Derived from a patch by David Farler.
3052
3053         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
3054         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
3055         in terms of the simctl command line utility.
3056
3057         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
3058         (eraseIOSSimulatorDevice): Added.
3059         (bootedIOSSimulatorDevice): Added.
3060         (iosSimulatorApplicationsPath): Added.
3061         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
3062         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
3063         (quitIOSSimulator): Added.
3064         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
3065         the specified name and currently selected iOS runtime.
3066         (isIOSSimulatorSystemInstalledApp): Added.
3067         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
3068         (deleteiOSSimulatorDevice): Deleted.
3069         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
3070         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
3071
3072 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
3073
3074         Resurrect the WinCairo bot.
3075         https://bugs.webkit.org/show_bug.cgi?id=139908
3076
3077         Reviewed by Csaba Osztrogonác.
3078
3079         * BuildSlaveSupport/build.webkit.org-config/config.json:
3080         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3081         (appendCustomBuildFlags):
3082         * BuildSlaveSupport/test-result-archive:
3083         (archiveTestResults):
3084         Add WinCairo buildbot.
3085
3086 2015-01-16  Chris Dumez  <cdumez@apple.com>
3087
3088         webkit-patch should auto-install the keyring python module
3089         https://bugs.webkit.org/show_bug.cgi?id=140547
3090
3091         Reviewed by David Kilzer.
3092
3093         Auto-install the keyring python module. This is the module that
3094         webkit-patch uses for cross-platform access to the keyring
3095         service.
3096
3097         Without this module, if the password if not in the keychain,
3098         webkit-patch will keep asking for your username / password and
3099         never remember them.
3100
3101         * Scripts/webkitpy/common/net/credentials.py:
3102         * Scripts/webkitpy/thirdparty/__init__.py:
3103         (AutoinstallImportHook.find_module):
3104         (AutoinstallImportHook._install_keyring):
3105
3106 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
3107
3108         Remove ENABLE(SQL_DATABASE) guards
3109         https://bugs.webkit.org/show_bug.cgi?id=140434
3110
3111         Reviewed by Darin Adler.
3112
3113         * Scripts/webkitperl/FeatureList.pm:
3114
3115 2015-01-15  Daniel Bates  <dabates@apple.com>
3116
3117         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
3118         https://bugs.webkit.org/show_bug.cgi?id=139685
3119         <rdar://problem/19281317>
3120
3121         Reviewed by Simon Fraser.
3122
3123         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
3124         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
3125
3126         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
3127         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
3128         before DRT dumps the output of a test. In particular, the WebThread may start a new page
3129         load (say, as a result of continued JavaScript execution), which will ultimately lead to
3130         dumping the test result again. Instead we want DRT to dump the test result synchronously
3131         such that we capture the state of the web page either when the page is loaded or when
3132         window.testRunner.notifyDone() is called.
3133
3134         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3135         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
3136         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
3137         flush CA transactions to the window.
3138         * DumpRenderTree/mac/DumpRenderTree.mm:
3139         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
3140         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
3141         (dump): Renamed; formerly named dumpTestResults().
3142         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
3143         enabling repaint support on iOS.
3144         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
3145         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
3146         (dumpTestResults): Deleted.
3147
3148 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
3149
3150         [Win] Miscellaneous DRT fixes
3151         https://bugs.webkit.org/show_bug.cgi?id=116562
3152
3153         Reviewed by Tim Horton.
3154
3155         While investigating the cause of several Windows crashes, I found:
3156         (1) Messy conversions to and from BSTR types
3157         (2) Weird mixes of wide-string and narrow string conversions
3158         (3) Passing nullptr to some CoreFoundation routines that do not
3159             permit null arguments.
3160         (4) Commands to link the executable to the VS2005 runtime.
3161
3162         This patch cleans up these issues to improve DRT reliability on
3163         Windows.
3164
3165         * DumpRenderTree/cg/ImageDiffCG.cpp:
3166         (main): Get rid of VS2005 runtime linking.
3167         * DumpRenderTree/win/DumpRenderTree.cpp:
3168         (urlSuitableForTestResult): Protect against being asked
3169         to process an empty URL.
3170         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
3171         than converting to/from wchar_t buffers.
3172         (runTest): Simplify string and BSTR handling.
3173         (createWebViewAndOffscreenWindow): Ditto.
3174         (main): Get rid of VS2005 runtime linking.
3175         * DumpRenderTree/win/TestRunnerWin.cpp:
3176         (jsStringRefToWString): Simplify code.
3177         (TestRunner::pathToLocalResource):
3178         (TestRunner::setUserStyleSheetLocation):
3179         * TestWebKitAPI/win/main.cpp: Get rid of
3180         VS2005 runtime linking.
3181         * win/DLLLauncher/DLLLauncherMain.cpp:
3182         (wWinMain): Ditto.
3183
3184 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
3185
3186         Stop hardcoding mac-mountainlion in commit queue
3187         https://bugs.webkit.org/show_bug.cgi?id=140492
3188
3189         Reviewed by Anders Carlsson.
3190
3191         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
3192         there should be no change in behavior, because:
3193         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
3194         using it to create a port object.
3195         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
3196         is actually correct to use "mac" for the name there. We only used to get the expected
3197         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
3198         for unknown deprecated port names.
3199
3200         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
3201
3202 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
3203
3204         Create iOS-EWS server queue
3205         https://bugs.webkit.org/show_bug.cgi?id=140473
3206
3207         Reviewed by Benjamin Poulain.
3208
3209         * QueueStatusServer/app.yaml: Updates the SVN version number.
3210         * QueueStatusServer/config/queues.py: Add ios-ews queue.
3211         * QueueStatusServer/model/queues.py:         
3212         (Queue.display_name): Makes sure the display name is pretty!
3213
3214 2015-01-14  Daniel Bates  <dabates@apple.com>
3215
3216         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
3217         https://bugs.webkit.org/show_bug.cgi?id=140301
3218         <rdar://problem/19389266>
3219
3220         Reviewed by Jon Honeycutt.
3221
3222         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
3223         with an unavailable runtime.
3224
3225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3226         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
3227         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
3228         specified runtime cannot be used because it is unavailable.
3229         * Scripts/webkitpy/port/ios.py:
3230         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
3231         which was formerly named testing_device.
3232         * Scripts/webkitpy/xcode/simulator.py:
3233         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
3234         more robust than looking up the simulator device by name and runtime. This approach also
3235         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
3236         unavailable runtimes under the same iOS heading it would use to show it as available).
3237         (Simulator.find_device_by_udid): Added.
3238         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
3239         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
3240         (Simulator.available_runtimes): Added.
3241         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
3242         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
3243         first element of the sorted list is the runtime with the highest version number.
3244         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
3245
3246 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
3247
3248         Remove WK2 Windows cruft
3249         https://bugs.webkit.org/show_bug.cgi?id=140440
3250
3251         Reviewed by Anders Carlsson.
3252
3253         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
3254         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
3255         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
3256
3257 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
3258
3259         Fix TestWTF failed in TestWebKitAPI
3260         https://bugs.webkit.org/show_bug.cgi?id=140333
3261
3262         Reviewed by Sam Weinig.
3263
3264         Clear the std::ostringstream before starting test.
3265
3266         * TestWebKitAPI/Tests/WTF/RefLogger.h:
3267         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
3268
3269 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3270
3271         TestWebKitWebContext depends on British English spellcheck dictionary
3272         https://bugs.webkit.org/show_bug.cgi?id=140403
3273
3274         Reviewed by Martin Robinson.
3275
3276         Install all English hunspell dictionaries on Fedora and Arch.
3277
3278         * gtk/install-dependencies:
3279
3280 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3281
3282         [GTK] install-dependencies should grok dnf
3283         https://bugs.webkit.org/show_bug.cgi?id=140396
3284
3285         Reviewed by Martin Robinson.
3286
3287         Fedora: install dependencies with dnf if yum is not installed.
3288
3289         * gtk/install-dependencies:
3290
3291 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
3292
3293         [EFL][GTK] Fix build after r178309  
3294         https://bugs.webkit.org/show_bug.cgi?id=140381
3295
3296         Reviewed by Gyuyoung Kim.
3297
3298         * TestWebKitAPI/CMakeLists.txt: Added the API directory
3299
3300 2015-01-11  Sam Weinig  <sam@webkit.org>
3301
3302         Remove support for SharedWorkers
3303         https://bugs.webkit.org/show_bug.cgi?id=140344
3304
3305         Reviewed by Anders Carlsson.
3306
3307         * Scripts/webkitperl/FeatureList.pm:
3308
3309 2015-01-12  Anders Carlsson  <andersca@apple.com>
3310
3311         Make delegates conform to formal delegate protocols
3312         https://bugs.webkit.org/show_bug.cgi?id=140370
3313
3314         Reviewed by Dan Bernstein.
3315
3316         * DumpRenderTree/mac/TestRunnerMac.mm:
3317         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3318         (TestRunner::setGeolocationPermission):
3319
3320 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3321
3322         build-webkit: silence output of 'which'
3323         https://bugs.webkit.org/show_bug.cgi?id=140278
3324
3325         Reviewed by Daniel Bates.
3326
3327         Use a more elegent test for the existance of ninja and eclipse.
3328
3329         * Scripts/webkitdirs.pm:
3330         (commandExists): Don't assume the command supports --version
3331         (canUseNinja): Use commandExists()
3332         (canUseEclipse): Use commandExists()
3333
3334 2015-01-09  Sam Weinig  <sam@webkit.org>
3335
3336         Update the output format for run-api-tests
3337         https://bugs.webkit.org/show_bug.cgi?id=140332
3338
3339         Reviewed by Dan Bernstein.
3340
3341         Changes the output format for run-api-tests be a bit simpler (no longer 
3342         indented based on suite, as we were not really using suite very well) but
3343         also include details in the case of failure.
3344
3345         Changes verbose mode to no longer spew out the gtest default printer output,
3346         as the custom printer now includes the failure information.
3347
3348         * Scripts/run-api-tests:
3349         (runTestsBySuite):
3350         (runTest):
3351         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
3352         with colorized variants and strip out leaks spew (the leaks can be added back using
3353         the new --show-leaks argument).
3354
3355         * TestWebKitAPI/TestsController.cpp:
3356         (TestWebKitAPI::Printer::OnTestPartResult):
3357         (TestWebKitAPI::Printer::OnTestEnd):
3358         (TestWebKitAPI::TestsController::run):
3359         Implement a custom result printer that just prints out the information we want.
3360
3361 2015-01-09  Sam Weinig  <sam@webkit.org>
3362
3363         TestWebKitAPI should print out the lists that fail at the end
3364         https://bugs.webkit.org/show_bug.cgi?id=140329
3365
3366         Reviewed by Tim Horton.
3367
3368         * Scripts/run-api-tests:
3369         (runTestsBySuite):
3370         Print out failures and timeouts in all modes, not just verbose.
3371
3372 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
3373
3374         Make bmalloc work with ASan
3375         https://bugs.webkit.org/show_bug.cgi?id=140194
3376
3377         Reviewed by Mark Lam.
3378
3379         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
3380         ASan automatically (by forwarding to system malloc at runtime).
3381
3382 2015-01-09  Daniel Bates  <dabates@apple.com>
3383
3384         [iOS] Make DumpRenderTree build with public SDK
3385         https://bugs.webkit.org/show_bug.cgi?id=140311
3386
3387         Reviewed by Sam Weinig.
3388
3389         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
3390         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
3391         Additionally, remove unused header CoreGraphics/CGFontDB.h.
3392
3393         * DumpRenderTree/mac/DumpRenderTree.mm:
3394         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
3395
3396 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
3397
3398         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
3399         https://bugs.webkit.org/show_bug.cgi?id=140300
3400
3401         Reviewed by Simon Fraser.
3402
3403         * WebKitTestRunner/TestController.cpp:
3404         (WTR::TestController::createOtherPage):
3405         (WTR::TestController::updateWindowScaleForTest):
3406         (WTR::TestController::configureViewForTest):
3407         * WebKitTestRunner/TestController.h:
3408
3409 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3410
3411         Unreviewed. Moving myself to the committer section.
3412
3413         * Scripts/webkitpy/common/config/contributors.json:
3414
3415 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3416
3417         Add a script to check for platform layering violations
3418         https://bugs.webkit.org/show_bug.cgi?id=140248
3419
3420         Reviewed by Darin Adler.
3421
3422         It prints all the cases where files inside platform include
3423         headers that are not in platform directory.
3424
3425         * Scripts/check-for-platform-layering-violations: Added.
3426         (get_platform_headers):
3427         (check_source_file):
3428
3429 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3430
3431         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
3432         https://bugs.webkit.org/show_bug.cgi?id=139884
3433
3434         Reviewed by Tim Horton.
3435
3436         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3437         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
3438         what the "nominal resolution" is, but this appears to work in practice.
3439
3440 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
3441
3442         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
3443         https://bugs.webkit.org/show_bug.cgi?id=140256
3444
3445         Reviewed by Anders Carlsson.
3446
3447         * DumpRenderTree/win/DumpRenderTree.cpp:
3448         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
3449         running with heap validation checks.
3450         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
3451         the "svg\\W3C-SVG-1.1" test directory.
3452         (removeFontFallbackIfPresent): Use nullptr instead of 0.
3453         * DumpRenderTree/win/TestRunnerWin.cpp:
3454         (TestRunner::clearPersistentUserStyleSheet): Ditto.
3455
3456 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3457
3458         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3459         https://bugs.webkit.org/show_bug.cgi?id=140218
3460
3461         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
3462         Undone an accidental change - check for self.has_crashed() again. This code path
3463         is for ports that don't have a signal handler printing #CRASHED when main process
3464         crashes.
3465
3466         * Scripts/webkitpy/port/driver_unittest.py:
3467         (DriverTest.test_check_for_driver_crash.assert_crash):
3468         (DriverTest.test_check_for_driver_crash):
3469         Updated the tests, all changes are expected.
3470
3471 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3472
3473         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3474         https://bugs.webkit.org/show_bug.cgi?id=140218
3475
3476         Reviewed by Darin Adler.
3477
3478         * Scripts/webkitpy/port/driver.py:
3479         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
3480         "process crashed" condition. These don't make sense together - it's either a crash
3481         or a timeout, and we should detect those properly at a much lower level.
3482         (Driver.run_test): Ditto.
3483         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3484         cases.
3485
3486         * WebKitTestRunner/TestController.h:
3487         * WebKitTestRunner/TestController.cpp:
3488         (WTR::TestController::webProcessName): 
3489         (WTR::TestController::processDidCrash):
3490         Factored out hardcoded child process names, as we now use these in two places.
3491
3492         * WebKitTestRunner/TestInvocation.cpp:
3493         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3494         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3495
3496 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3497
3498         Reorder my list of email addresses, keeping the Bugzilla address at the
3499         top since Bugzilla and other webkitpy scripts rely on that ordering.
3500
3501         * Scripts/webkitpy/common/config/contributors.json:
3502
3503 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3504
3505         Moving myself to the reviewers section and updating
3506         the list of my email addresses.
3507
3508         * Scripts/webkitpy/common/config/contributors.json:
3509
3510 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3511
3512         [GTK] Build gtk-doc without gtkdoc-mktmpl
3513         https://bugs.webkit.org/show_bug.cgi?id=140225
3514
3515         Reviewed by Darin Adler.
3516
3517         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3518         don't modify the tmpl files that it generates, it's not doing anything
3519         for us.
3520
3521         * gtk/gtkdoc.py:
3522         (GTKDoc.generate):
3523         (GTKDoc._run_gtkdoc_scangobj):
3524         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3525
3526 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3527
3528         [GTK][ThreadedCompositor] Add support for threaded compositor.
3529         https://bugs.webkit.org/show_bug.cgi?id=118265
3530
3531         Reviewed by Martin Robinson.
3532
3533         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3534         autotools build systems. The feature is disabled by default.
3535         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3536         from the feature flags.
3537
3538         * Scripts/webkitperl/FeatureList.pm:
3539
3540 2015-01-07  Daniel Bates  <dabates@apple.com>
3541
3542         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3543         https://bugs.webkit.org/show_bug.cgi?id=137371
3544
3545         Reviewed by David Kilzer.
3546
3547         Use SPI wrapper headers instead of directly referencing private SPI headers.
3548
3549         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3550         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3551         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3552         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3553         * DumpRenderTree/mac/DumpRenderTree.mm:
3554         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3555         * DumpRenderTree/mac/EventSendingController.mm:
3556         * DumpRenderTree/mac/TestRunnerMac.mm:
3557
3558 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3559
3560         Unreviewed, rolling out r178068.
3561         https://bugs.webkit.org/show_bug.cgi?id=140235
3562
3563         Breaks the iOS build (Requested by enrica on #webkit).
3564
3565         Reverted changeset:
3566
3567         "[iOS] Make WebKit2 build with public iOS SDK and more build
3568         fixes for DRT"
3569         https://bugs.webkit.org/show_bug.cgi?id=137371
3570         http://trac.webkit.org/changeset/178068
3571
3572 2015-01-07  Daniel Bates  <dabates@apple.com>
3573
3574         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3575         https://bugs.webkit.org/show_bug.cgi?id=137371
3576
3577         Reviewed by David Kilzer.
3578
3579         Use SPI wrapper headers instead of directly referencing private SPI headers.
3580
3581         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3582         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3583         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3584         to the list of header search directories so that we can include header UIKitSPI.h.
3585         * DumpRenderTree/mac/DumpRenderTree.mm:
3586         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3587         * DumpRenderTree/mac/EventSendingController.mm:
3588         * DumpRenderTree/mac/TestRunnerMac.mm:
3589
3590 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3591
3592         [Win] Unreviewed test change to improve run reproducibility
3593
3594         * Scripts/webkitpy/port/win.py:
3595         (WinPort.default_child_processes): Run a single DRT instance to help
3596         identify failures caused by earlier test runs.
3597
3598 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3599
3600         Myles C. Maxfield is a reviewer now
3601         https://bugs.webkit.org/show_bug.cgi?id=140196
3602
3603         Reviewed by Dean Jackson.
3604
3605         * Scripts/webkitpy/common/config/contributors.json:
3606
3607 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3608
3609         Make webkit-patch try harder to find keychain credentials
3610         https://bugs.webkit.org/show_bug.cgi?id=140170
3611
3612         Reviewed by Ryosuke Niwa.
3613
3614         When the user manually enters a password into webkit-patch, we hand that off to the
3615         Keyring Python module. However, that module creates a generic password entry instead
3616         of an internet password entry. We should look for both kinds.
3617
3618         * Scripts/webkitpy/common/net/credentials.py:
3619         (Credentials._run_security_tool):
3620         (Credentials._credentials_from_keychain):
3621         * Scripts/webkitpy/common/net/credentials_unittest.py:
3622         (test_security_output_parse_entry_not_found):
3623         (_assert_security_call):
3624
3625 2015-01-06  Anders Carlsson  <andersca@apple.com>
3626
3627         Try to fix the Mountain Lion build.
3628
3629         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3630         (TestWebKitAPI::didGetImageForMatchResult):
3631
3632 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3633
3634         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3635         https://bugs.webkit.org/show_bug.cgi?id=140095
3636
3637         Reviewed by Anders Carlsson.
3638
3639         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3640         builds, but not in debug ones.
3641
3642 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3643
3644         [Win] Extend WinLauncher with support for Page Zoom
3645         https://bugs.webkit.org/show_bug.cgi?id=140152