ba1433806b86d7df95cabd3eacf5261f51111246
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-09  Dan Bernstein  <mitz@apple.com>
2
3         [Cocoa] Promote WKBackForwardList{,Item}.h to public
4         https://bugs.webkit.org/show_bug.cgi?id=126707
5
6         Reviewed by Sam Weinig.
7
8         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
9         left behind in the build products directory after a private header is made public.
10
11 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
14         https://bugs.webkit.org/show_bug.cgi?id=126686
15
16         Reviewed by Martin Robinson.
17
18         Test that partial files are not left on disk after a download has
19         been cancelled after the destination has been decided. To make
20         sure the download is cancelled after the destination has been
21         decided and before the operation finishes, we cancel the download
22         in the destination decided callback, and we use an infinite
23         resource that writes chunks to the response body and never
24         completes the body.
25
26         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
27         (addContentDispositionHTTPHeaderToResponse): Helper function to
28         add the Content-Disposition to the response headers.
29         (writeNextChunkIdle): Write next chunk to response body.
30         (writeNextChunk): Write next chunk in an idle to avoid flooding
31         the network with the inifnite resource.
32         (serverCallback): Add an inifinite resource.
33         (testDownloadRemoteFileError): Check that partial file is not
34         present after the download has been cancelled.
35
36 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
37
38         Move myself to the committers list.
39
40         Unreviewed.
41
42         * Scripts/webkitpy/common/config/contributors.json:
43
44 2014-01-08  Seokju Kwon  <seokju@webkit.org>
45
46         [GTK] Unreviewed build fix after r161522.
47
48         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
49
50 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
51
52         Missleading style error when mixing system and non-system header include lines.
53         https://bugs.webkit.org/show_bug.cgi?id=126564
54
55         Reviewed by Ryosuke Niwa.
56
57         * Scripts/webkitpy/style/checkers/cpp.py:
58         (check_include_line):
59         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
60         (OrderOfIncludesTest.test_check_alphabetical_include_order):
61         (OrderOfIncludesTest.test_public_primary_header):
62
63 2014-01-08  Seokju Kwon  <seokju@webkit.org>
64
65         [EFL] Unreviewed build fix after r161522.
66
67         * TestWebKitAPI/CMakeLists.txt:
68         * TestWebKitAPI/PlatformEfl.cmake:
69
70 2014-01-08  Anders Carlsson  <andersca@apple.com>
71
72         Remove WKConnectionRef tests
73         https://bugs.webkit.org/show_bug.cgi?id=126666
74
75         Reviewed by Dan Bernstein.
76
77         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
78         Remove the API tests as a first step towards killing the entire thing.
79
80         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
81         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
82         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
83
84 2014-01-08  Commit Queue  <commit-queue@webkit.org>
85
86         Unreviewed, rolling out r161512.
87         http://trac.webkit.org/changeset/161512
88         https://bugs.webkit.org/show_bug.cgi?id=126655
89
90         Broke webkitpy tests (Requested by ap on #webkit).
91
92         * Scripts/webkitpy/port/gtk.py:
93         (GtkPort.__init__):
94         (GtkPort.setup_test_run):
95         (GtkPort._port_specific_expectations_files):
96         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
97         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
98
99 2014-01-08  Commit Queue  <commit-queue@webkit.org>
100
101         Unreviewed, rolling out r161517.
102         http://trac.webkit.org/changeset/161517
103         https://bugs.webkit.org/show_bug.cgi?id=126659
104
105         The fix didn't completely remove the problem and is now
106         standing in the way of the rollout of the offending patch
107         (Requested by zdobersek on #webkit).
108
109         * Scripts/webkitpy/port/gtk.py:
110         (GtkPort.__init__):
111
112 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
113
114         Unreviewed. Attempting to fix webkitpy tests after r161512.
115
116         * Scripts/webkitpy/port/gtk.py:
117         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
118
119 2014-01-08  Brian Holt  <brian.holt@samsung.com>
120
121         [GTK] Parse Valgrind xml leak files
122         https://bugs.webkit.org/show_bug.cgi?id=119446
123
124         Reviewed by Alejandro G. Castro.
125
126         Parse the xml files generated by Valgrind to yield useful
127         information about the memory leaks.
128
129         * Scripts/webkitpy/port/gtk.py:
130         (GtkPort.__init__):
131         (GtkPort.setup_test_run): Clear the previous output files before new
132         run.
133         (GtkPort.print_leaks_summary):
134
135         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
136         Parse the xml files generated by Valgrind and summarise leaks
137         into an easily understandable list.
138         (get_text_of):
139         (get_CDATA_of):
140         (gather_frames):
141         (ValgrindError):
142         (ValgrindError.__init__):
143         (ValgrindError.__str__):
144         (ValgrindError.unique_string):
145         (ValgrindError.error_hash):
146         (ValgrindError.__hash__):
147         (ValgrindError.__eq__):
148         (LeakDetectorValgrind):
149         (LeakDetectorValgrind.__init__):
150         (LeakDetectorValgrind._parse_leaks_output):
151         (LeakDetectorValgrind.leaks_files_in_results_directory):
152         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
153         (LeakDetectorValgrind.parse_and_print_leaks_detail):
154
155         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
156         (make_mock_valgrind_output):
157         (make_mock_incomplete_valgrind_output):
158         (make_mock_valgrind_results):
159         (make_mock_valgrind_results_incomplete):
160         (make_mock_valgrind_results_empty):
161         (make_mock_valgrind_results_misformatted):
162         (LeakDetectorValgrindTest):
163         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
164         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
165         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
166         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
167         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
168         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
169         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
170         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
171
172 2014-01-08  Commit Queue  <commit-queue@webkit.org>
173
174         Unreviewed, rolling out r161427.
175         http://trac.webkit.org/changeset/161427
176         https://bugs.webkit.org/show_bug.cgi?id=126645
177
178         Emits a stye error on any newly added files (Requested by ap
179         on #webkit).
180
181         * Scripts/webkitpy/style/checkers/cpp.py:
182         (check_style):
183         (CppChecker):
184         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
185         (WebKitStyleTest.test_other):
186
187 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
188
189         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
190         https://bugs.webkit.org/show_bug.cgi?id=126580
191
192         Reviewed by Csaba Osztrogonác.
193
194         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
195         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
196         run-webkit-tests script.
197         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
198         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
199
200 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
201
202         Update the list of non-committer u-szeged contributors
203         https://bugs.webkit.org/show_bug.cgi?id=126640
204
205         Reviewed by Csaba Osztrogonác.
206
207         * Scripts/webkitpy/common/config/contributors.json:
208
209 2014-01-08  Alberto Garcia  <berto@igalia.com>
210
211         Fix some compilation warnings
212         https://bugs.webkit.org/show_bug.cgi?id=126635
213
214         Reviewed by Csaba Osztrogonác.
215
216         * GtkLauncher/main.c:
217         (createWindow): This function is not supposed to receive any
218         parameter, yet we are passing one.
219
220 2014-01-08  Brian Holt  <brian.holt@samsung.com>
221
222         [GTK][WK2] unskip passing unit tests
223         https://bugs.webkit.org/show_bug.cgi?id=126637
224
225         Reviewed by Carlos Garcia Campos.
226
227         Unskip TestResources and TestAuthentication unit tests since they
228         are passing both under Xvfb and X.
229
230         * Scripts/run-gtk-tests:
231         (TestRunner):
232
233 2014-01-08  Alberto Garcia  <berto@igalia.com>
234
235         REGRESSION(r160304): [GTK] Disable libtool fast install
236         https://bugs.webkit.org/show_bug.cgi?id=126381
237
238         Reviewed by Gustavo Noronha Silva.
239
240         Disable the libtool fast-install mode in developer/test builds.
241
242         In this mode binaries are generated ready to be used directly from
243         the build tree. Otherwise they would need to be relinked when they
244         are executed, which can take a lot of resources, particularly in
245         debug builds.
246
247         * Scripts/webkitdirs.pm:
248         (runAutogenForAutotoolsProjectIfNecessary):
249
250 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
251
252         Unreviewed GTK gardening.
253
254         * Scripts/run-gtk-tests:
255         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
256         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
257
258 2014-01-07  Lucas Forschler  <lforschler@apple.com>
259
260         Add buildbot infrasctructure for building and testing JSC cloop
261         https://bugs.webkit.org/show_bug.cgi?id=126604
262
263         Reviewed by Geoffrey Garen.
264
265         * BuildSlaveSupport/build.webkit.org-config/config.json:
266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
267         (CompileCLOOP):
268         (RunCLOOPTests):
269         (RunCLOOPTests.countFailures):
270         (BuildAndTestCLOOP):
271
272 2014-01-07  Brian Burg  <bburg@apple.com>
273
274         Unreviewed. Add myself as a committer.
275
276         * Scripts/webkitpy/common/config/contributors.json:
277
278 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
279
280         Popovers at build.webkit.org/dashboard could have titles
281         https://bugs.webkit.org/show_bug.cgi?id=126495
282
283         Reviewed by Timothy Hatcher.
284
285         Added titles to all popovers except for pending revisions one, which I would like
286         to improve more (probably add an ETA).
287
288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
289         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
290         adding a title to base class.
291
292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
293         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
294         a divider to a separate function.
295         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
296         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
297         title from above function.
298         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
299         variable to "content" to match all other code.
300         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
301         (BuildbotQueueView.prototype._addDividerToPopover): Added.
302
303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
304         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
305         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
306         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
307
308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
309
310 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
311
312         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
313         https://bugs.webkit.org/show_bug.cgi?id=126472
314
315         Reviewed by Timothy Hatcher.
316
317         Added a delay when quickly switching to a different popover, making it easier to
318         move mouse pointer from active element to its popover without accidentally opening
319         a different popover.
320
321         Used this code to add a delay before creating a popover. This doesn't change UI
322         behavior, as there was alerady a delay before it became visible, but it avoids
323         flooding buildbot server with http requests when quickly moving the mouse over
324         dashboard page.
325
326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
327         Fixed a case where popover could get stuck. If content was updated while fade-out
328         transition was already in place, the transition was removed for no good reason.
329
330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
331         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
332
333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
334         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
335         popover delay from 1s to 800ms.
336
337 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
338
339         Improve display of failed builds at build.webkit.org/dashboard
340         https://bugs.webkit.org/show_bug.cgi?id=126542
341         <rdar://problem/15753550>
342
343         Reviewed by Timothy Hatcher.
344
345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
346         Instead of hardcoding step name, look for the first step that failed.
347         While at it, added a popover with more links. There are multiple, and it's good
348         to have a choice of which one to look at in each situation.
349
350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
351         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
352         of having failed. Many iterations are interrupted for whatever reason internal to
353         Buildbot, and these are suppoed to be orange, not red.
354         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
355         not only WillRetry ones.
356         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
357         actually failed, more likely indicating a problem with code base.
358         (BuildbotIteration.prototype.get firstFailedStepName):
359         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
360         (BuildbotIteration.prototype.get failureLogs): Ditto.
361         (BuildbotIteration.prototype.update): Store complete results for the failed step.
362         Not every failure stops the iteration, so we could have multiple failed steps,
363         but let's see if seeing just the first one will be enough.
364
365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
366         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
367         terms of successful iterations.
368         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
369
370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
371         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
372         terms of successful iterations.
373
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
375         Removed code to create a path to build output, we now take it from results JSON.
376
377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
378         Added styles for the new popover.
379
380 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
381
382         defined constants should use all uppercase names with words separated by underscores.
383         https://bugs.webkit.org/show_bug.cgi?id=126055
384
385         Reviewed by Alexey Proskuryakov.
386
387         * Scripts/webkitpy/style/checkers/cpp.py:
388         (check_style):
389         (CppChecker):
390         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
391         (WebKitStyleTest.test_define_constants):
392
393 2014-01-07  Brian Holt  <brian.holt@samsung.com>
394
395         Unreviewed. Add myself as a committer.
396
397         * Scripts/webkitpy/common/config/contributors.json:
398
399 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
400
401         Remove the WinCE buildbot from build.webkit.org
402         https://bugs.webkit.org/show_bug.cgi?id=126517
403
404         Reviewed by Alexey Proskuryakov.
405
406         * BuildSlaveSupport/build.webkit.org-config/config.json:
407         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
408         (appendCustomBuildFlags):
409
410 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
411
412         [EFL] Change ATK version to 2.11.4
413         https://bugs.webkit.org/show_bug.cgi?id=126573
414
415         Reviewed by Gyuyoung Kim.
416
417         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
418
419         * efl/jhbuild.modules:
420
421 2014-01-07  Alberto Garcia  <berto@igalia.com>
422
423         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
424         https://bugs.webkit.org/show_bug.cgi?id=117275
425
426         Reviewed by Carlos Garcia Campos.
427
428         If we are not using the internal jhbuild we must not use the
429         jhbuild-wrapper script, else it will try to download and install
430         it.
431
432         * Scripts/run-launcher:
433
434 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
435
436         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
437         https://bugs.webkit.org/show_bug.cgi?id=125855
438
439         Reviewed by Mario Sanchez Prada.
440
441         Added new function isIndeterminate for testing aria-checked mixed state.
442         I provided respective, but empty function in mac port. Mac testing it differently.
443
444         * DumpRenderTree/AccessibilityUIElement.cpp:
445         (getIsIndeterminate):
446         (AccessibilityUIElement::getJSClass):
447         * DumpRenderTree/AccessibilityUIElement.h:
448         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
449         (AccessibilityUIElement::isIndeterminate):
450         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
451         (AccessibilityUIElement::isIndeterminate):
452         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
453         (AccessibilityUIElement::isIndeterminate):
454         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
455         (AccessibilityUIElement::isIndeterminate):
456         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
457         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
458         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
459         (WTR::AccessibilityUIElement::isIndeterminate):
460         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
461         (WTR::AccessibilityUIElement::isIndeterminate):
462
463 2014-01-06  Mark Rowe  <mrowe@apple.com>
464
465         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
466
467         Reviewed by Ryosuke Niwa.
468
469         * DumpRenderTree/mac/DumpRenderTree.mm:
470         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
471         with a single case. This avoids the potential for warnings about unhandled cases.
472         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
473         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
474
475 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
476
477         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
478         https://bugs.webkit.org/show_bug.cgi?id=126342
479
480         Reviewed by Gustavo Noronha Silva.
481
482         * CMakeLists.txt: Include the new unit tests subdirectories.
483         * Scripts/run-gtk-tests: Update to refer to the new build locations.
484         * Scripts/webkitpy/style/checker.py: Update the style checker.
485         * Scripts/webkitpy/style/checker_unittest.py:
486         * TestWebKitAPI/GNUmakefile.am:
487         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
488         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
489         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
490         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
491         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
492         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
493         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
494         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
495         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
496         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
497         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
498         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
499         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
500         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
501         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
502         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
503         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
504         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
505         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
506         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
507         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
508         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
509         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
510         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
511         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
512         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
513         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
514         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
515         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
516         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
517         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
518         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
519         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
520         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
521         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
522         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
523         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
524         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
525         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
526         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
527         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
528         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
529         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
530         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
531         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
532         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
533         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
534         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
535         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
536         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
537         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
538         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
539         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
540         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
541         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
542         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
543         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
544         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
545         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
546         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
547         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
548         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
549         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
550         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
551         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
552         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
553         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
554         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
555         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
556         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
557         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
558         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
559         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
560         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
561         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
562         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
563         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
564         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
565         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
566         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
567         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
568         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
569         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
570         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
571         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
572         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
573         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
574
575 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
576
577         Gtk and Efl API test results confuse the dashboard
578         https://bugs.webkit.org/show_bug.cgi?id=126535
579
580         Reviewed by Tim Horton.
581
582         Added "API tests" step as "platform api tests".
583
584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
585         (Buildbot.prototype.platformAPITestResultsURLForIteration):
586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
587         (BuildbotIteration):
588         (BuildbotIteration.prototype.update):
589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
590         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
591         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
592
593 2014-01-06  Tim Horton  <timothy_horton@apple.com>
594
595         build.webkit.org/dashboard should still function if localStorage is disabled
596         https://bugs.webkit.org/show_bug.cgi?id=126511
597
598         Reviewed by Alexey Proskuryakov.
599
600         If localStorage is disabled, we should carry on with a warning.
601
602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
603         Don't show the gear if localStorage isn't working.
604
605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
606         (QueueView.prototype._updateHiddenState):
607         Bail if localStorage isn't working.
608
609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
610         (Settings.prototype.available):
611
612 2014-01-02  Roger Fong  <roger_fong@apple.com>
613
614         Set VSINSTALLDIR in win ews start script.
615         https://bugs.webkit.org/show_bug.cgi?id=126407
616
617         Reviewed by Brent Fulgham.
618
619         * EWSTools/start-queue-win.sh:
620
621 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
622
623         Adding myself as a reviewer.
624
625         Unreviewed.
626
627         * Scripts/webkitpy/common/config/contributors.json:
628
629 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
630
631         Unreviewed. Unbreaking JSC tests after r161328.
632
633         * Scripts/webkitdirs.pm:
634         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
635         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
636
637 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
638
639         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
640         https://bugs.webkit.org/show_bug.cgi?id=126212
641
642         Reviewed by Daniel Bates.
643
644         Allow building the GTK+ cmake port with --gtkcmake.
645
646         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
647         when appropriate. Skip the autotoos path when isGtkAutotools is false.
648         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
649         Add isGtk which checks isGtkCMake || isGtkAutotools
650         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
651         (argumentsForConfiguration): use --gtkcmake when appropriate.
652         (jscProductDir): Look in the CMake directory when appropriate.
653         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
654         (determineIsGtkCMake): Added.
655         (isGtkCMake): Added.
656         (isGtkAutotools): Renamed from isGtk.
657         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
658         (determineIsGtkAutotools): Renamed from determineIsGtk.
659         (cmakeBasedPortName): Added a GTK+ path.
660
661 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
662
663         [GTK] [CMake] Fix the video and audio build
664         https://bugs.webkit.org/show_bug.cgi?id=126464
665
666         Reviewed by Philippe Normand.
667
668         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
669
670 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
671
672         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
673         https://bugs.webkit.org/show_bug.cgi?id=126467
674
675         Reviewed by Geoffrey Garen.
676
677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
678         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
679         pointer, or to tap.
680
681 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
682
683         build.webkit.org/dashboard says "failed build" even if it's another step that failed
684         https://bugs.webkit.org/show_bug.cgi?id=126461
685
686         Reviewed by Geoffrey Garen.
687
688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
689         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
690         build page if it's not the compilation that failed. Use text from buildbot for description.
691         Show a yellow icon if it's a different kind of failure.
692
693         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
694         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
695
696 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
697
698         setup-git-clone fails to get email address from git
699         https://bugs.webkit.org/show_bug.cgi?id=126446
700
701         Reviewed by Ryosuke Niwa.
702
703         The setup-git-clone command fails to get an email address from git
704         because of a bug in VCSUtils. This patch fixes that bug, and also
705         makes it so that when VCSUtils fails for real because of a local
706         misconfiguration, the error message is actually presented to the user
707         of setup-git-clone.
708
709         * Scripts/VCSUtils.pm:
710         (gitConfig): Call isGit() instead of accessing $isGit directly to make
711             sure that $isGit is properly initialized.
712         * Scripts/webkitpy/tool/commands/setupgitclone.py:
713         (SetupGitClone.execute): Pull out username and email acquistion to
714             it's own method.
715         (SetupGitClone._get_username_and_email): Catch the exception thrown
716             when VCSUtils fails and print out the error message so that the
717             user actually knows why the command failed.
718
719 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
720
721         It feels too hard to get rid of a popover at build.webkit.org/dashboard
722         https://bugs.webkit.org/show_bug.cgi?id=126451
723
724         Reviewed by Simon Fraser.
725
726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
727         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
728         when moving the mouse from an element to its popover.
729
730 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
731
732         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
733         https://bugs.webkit.org/show_bug.cgi?id=122181
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
736         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
737         popover.present signature change.
738
739 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
740
741         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
742         https://bugs.webkit.org/show_bug.cgi?id=122181
743
744         Reviewed by Timothy Hatcher and Timothy Horton.
745
746         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
747         JSONP). Dashboard will load them on demand.
748
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
750         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
751         and made it use a function from WebKitBuildbot that builds results directory path.
752         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
753         a URL for full_results.json.
754         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
755         a URL for a crash log.
756
757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
758         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
759         the iteration.
760
761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
762         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
763         popover API (see below).
764         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
767         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
768         for iterations that were interrupted (previously, they were displayed incorrectly,
769         often as passes). Install popover trackers for failure bubbles for which we can currently
770         display something useful.
771         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
772         a popover for layout test regressions when we have the data loaded on demand.
773         We have test paths, special indicators for crashes/timeouts, and links to test history
774         at flakiness dashboard.
775         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
776         the popover for layout test regressions. Just shows "Loading..." until the data is
777         loaded.
778         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
779         types of failures if there are multiple. There is a lot of similarity with
780         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
781
782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
783         Create a global test history object, which is used for links in layout test popover.
784
785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
786         Changed the API to be more like WebInspector again, allowing for changing content
787         of an existing popover. As the size of a popover can change, making the mouse pointer
788         enter it without a mousenter event, install a handler for mousewheel instead, and block
789         document scrolling from this event handler when needed.
790
791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
792         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
793         bubble element, making it possible to install a popover on it.
794
795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
796         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
799         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
800         building a complete results URL to only building one for root results path. This is
801         the part that depends on specific buildbot installation, everything relative to it
802         is the same.
803
804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
805         Build a path to test history page. In the future, we may consider adding code to
806         load the data and display it inline.
807
808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
809         Added styles for this new popover.
810
811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
812         a new file, WebKitTestHistory.js.
813
814 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
815
816         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
817         https://bugs.webkit.org/show_bug.cgi?id=126430
818
819         Reviewed by Martin Robinson.
820
821         * Scripts/run-gtk-tests:
822         (TestRunner._setup_testing_environment):
823         * gtk/common.py: Use common.tests_library_build_path() instead.
824         (tests_library_build_path): Helper funtion that returns the path
825         where the tests libraries are built.
826
827 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
828
829         [CMake] Build TestWebKitAPI tests into a directory structure
830         https://bugs.webkit.org/show_bug.cgi?id=126358
831
832         Reviewed by Gyuyoung Kim.
833
834         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
835         is useful for keeping the "bin" directory tidy during building and will make it easier
836         to integrate the CMake build into the existing WebKitGTK+ scripts.
837
838         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
839         and make the names simpler now that the directory identifies what category the test is in.
840
841 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
842
843         Provide a visual clue when element has a popover at build.webkit.org/dashboard
844         https://bugs.webkit.org/show_bug.cgi?id=126281
845
846         Reviewed by Timothy Hatcher.
847
848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
849         (PopoverTracker): Add a class name to elements with popovers.
850
851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
852         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
853         I might have broke that recently.
854         (*:link): Show hand cursor over links.
855         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
856
857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
858         (.status-line .message .revision-number): Show text selection cursor on our only
859         selectable text element.
860         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
861         a white shadow than with a dark one on hover.
862
863 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
864
865         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
866         https://bugs.webkit.org/show_bug.cgi?id=124652
867
868         Reviewed by Martin Robinson.
869
870         * MiniBrowser/gtk/BrowserWindow.c:
871         (webViewDecidePolicy): Use the new API instead of
872         webkit_web_view_can_show_mime_type().
873
874 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
875
876         REGRESSION(r160304): [GTK] Disable libtool fast install
877         https://bugs.webkit.org/show_bug.cgi?id=126381
878
879         Reviewed by Martin Robinson.
880
881         Remove -no-fast-install ld flag since fast install is now disabled
882         globally.
883
884         * GNUmakefile.am:
885         * GtkLauncher/GNUmakefile.am:
886         * MiniBrowser/gtk/GNUmakefile.am:
887         * TestWebKitAPI/GNUmakefile.am:
888         * WebKitTestRunner/GNUmakefile.am:
889
890 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
891
892         Unreviewed. Add myself to EFL and related watch lists.
893
894         * Scripts/webkitpy/common/config/watchlist:
895
896 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
897
898         [GTK] fixing ycm_extra_conf.py file
899         https://bugs.webkit.org/show_bug.cgi?id=126371
900
901         It's an attempt to fix three problems with the current ycm_extra_conf file.
902         The current implementation assumes that it's a symlink, which is not true.
903         Usually python creates a pyc file, and this is what you get in __file__.
904         the .pyc is not a symlink, and the current implementation doesn't work
905         if that's the case.
906
907         It also assumes that the user is in the root folder.
908         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
909
910         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
911         exception since "flag" doesn't exists.
912
913         All those things were fixed.
914
915         Reviewed by Martin Robinson.
916
917         * gtk/ycm_extra_conf.py:
918         (transform_relative_paths_to_absolute_paths):
919
920 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
921
922         Bindings tests results links are broken at build.webkit.org/dashboard
923         https://bugs.webkit.org/show_bug.cgi?id=126402
924
925         Reviewed by Tim Horton.
926
927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
928         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
929         since the beginning.
930
931 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
932
933         "+" is very confusing at http://build.webkit.org/dashboard
934         https://bugs.webkit.org/show_bug.cgi?id=126400
935
936         Reviewed by Tim Horton.
937
938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
939         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
940         source and internal counts separately, simply add them. One can always open a popover
941         for more detail.
942
943 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
944
945         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
946         https://bugs.webkit.org/show_bug.cgi?id=126391
947
948         Reviewed by Dan Bernstein.
949
950         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
951         One can request credentials use via Initialization.js.
952
953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
954         (Trac):
955         (Trac.prototype.update):
956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
957         (loadXML):
958
959 2014-01-02  Commit Queue  <commit-queue@webkit.org>
960
961         Unreviewed, rolling out r160846.
962         http://trac.webkit.org/changeset/160846
963         https://bugs.webkit.org/show_bug.cgi?id=126395
964
965         Breaks build scripts for Windows when Visual Studio is not
966         installed in Program Files (Requested by rfong on #webkit).
967
968         * Scripts/webkitdirs.pm:
969         (visualStudioInstallDir):
970
971 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
972
973         [GTK] [CMake] run-gtk-tests should run with the cmake build
974         https://bugs.webkit.org/show_bug.cgi?id=126341
975
976         Reviewed by Carlos Garcia Campos.
977
978         * Scripts/run-gtk-tests:
979         (TestRunner.__init__): Use the new calling conventions for the common script.
980         (TestRunner._setup_testing_environment): Ditto.
981         * gtk/common.py:
982         (set_build_types): Added set_build_types, to avoid having build_type arguments
983         for all functions in common.
984         (binary_build_path): Added this function which gets the path to the built binaries.
985         (get_build_path): Removed the build_types argument.
986         (build_path): Removed the build_types argument and call get_build_path directly now.
987
988 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
989
990         https://bugs.webkit.org/show_bug.cgi?id=126391
991         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
992
993         Rubber-stamped by Dan Bernstein.
994
995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
996         (loadXML): Quick and dirty fix, with a FIXME.
997
998 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
999
1000         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
1001         https://bugs.webkit.org/show_bug.cgi?id=126349
1002
1003         Reviewed by Carlos Garcia Campos.
1004
1005         All CMake ports use "libTestNetscapePlugin," so choosing the same
1006         name in the autotools port will make the transition easier.
1007
1008         * GNUmakefile.am: Rename the plugin library.
1009
1010 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
1011
1012         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
1013         https://bugs.webkit.org/show_bug.cgi?id=126354
1014
1015         Reviewed by Carlos Garcia Campos.
1016
1017         The latest visited site for backward history should be placed on the top of a history stack
1018         as a common behavior. However currently its order is reverse.
1019
1020         * MiniBrowser/gtk/BrowserWindow.c:
1021         (browserWindowUpdateNavigationActions):
1022
1023 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
1024
1025         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
1026         https://bugs.webkit.org/show_bug.cgi?id=126297
1027
1028         Reviewed by Philippe Normand.
1029
1030         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
1031         (TestRunner): Ditto.
1032         (TestRunner._run_test): Ditto.
1033
1034 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
1035
1036         full_results.json should distinguish unexpected failures from expected ones
1037         https://bugs.webkit.org/show_bug.cgi?id=126300
1038
1039         Reviewed by Timothy Hatcher.
1040
1041         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1042         (summarize_results): Add "report" element to JSON, which tells the consumer how
1043         this result was counted for summary.
1044
1045         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1046         Updated results to include the new element.
1047
1048         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1049         (print_unexpected_results): Added a comment pointing to another place that
1050         summarizes results, and should stay in sync.
1051
1052 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
1053
1054         Replace remaning CoreIPC namespace to IPC
1055         https://bugs.webkit.org/show_bug.cgi?id=126305
1056
1057         Reviewed by Anders Carlsson.
1058
1059         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
1060         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
1061         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
1062         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
1063
1064 2013-12-30  Brendan Long  <self@brendanlong.com>
1065
1066         Add myself to the committers list.
1067
1068         Unreviewed.
1069
1070         * Scripts/webkitpy/common/config/contributors.json:
1071
1072 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1073
1074         [GTK] Split WebKit2APITests/TestWebKitWebView
1075         https://bugs.webkit.org/show_bug.cgi?id=126284
1076
1077         Reviewed by Philippe Normand.
1078
1079         Skip only WebKitWebView/mouse-target and all TestAuthentication
1080         tests that are timing out when running under xvfb.
1081
1082         * Scripts/run-gtk-tests:
1083         (TestRunner):
1084
1085 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1086
1087         [EFL][WK2] Disable geolocation API test
1088         https://bugs.webkit.org/show_bug.cgi?id=125851
1089
1090         Reviewed by Gyuyoung Kim.
1091
1092         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
1093
1094         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
1095
1096 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
1097
1098         [EFL] Remove ewk_view_tiled
1099         https://bugs.webkit.org/show_bug.cgi?id=125961
1100
1101         Reviewed by Gyuyoung Kim.
1102
1103         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1104         (shouldUseTiledBackingStore):
1105         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
1106         instead of switching ewk_view_tiled.
1107         (DumpRenderTreeChrome::createView):
1108         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1109         (drtViewAdd):
1110         * EWebLauncher/main.c: Removed ewk_view_tiled option.
1111         (windowCreate):
1112         (parseUserArguments):
1113
1114 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1115
1116         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
1117         https://bugs.webkit.org/show_bug.cgi?id=126278
1118
1119         Reviewed by Timothy Hatcher.
1120
1121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1122         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
1123         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
1124         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
1125
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1127         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
1128
1129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1130         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
1131
1132 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1133
1134         Interrupted test runs should not count at build.webkit.org/dashboard
1135         https://bugs.webkit.org/show_bug.cgi?id=126279
1136
1137         Reviewed by Timothy Hatcher.
1138
1139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1140         (BuildbotIteration.prototype.get productive):
1141         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
1142         this accessor to skips iterations that don't have relevant data. We still want to
1143         display them, but revision ranges should not be affected.
1144         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
1145
1146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1147         Use latest productive iteration instead of latest iteration for pending revision
1148         count and popovers.
1149
1150 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1151
1152         Please display (and link to) revision ranges at build.webkit.org/dashboard
1153         https://bugs.webkit.org/show_bug.cgi?id=122187
1154
1155         Reviewed by Timothy Hatcher.
1156
1157         Added popovers for revision numbers. Removed direct links, because they were misleading -
1158         a test run covers a revision range, not just the latest revision. This also makes
1159         selecting a revision for copy easier.
1160
1161         All revision numbers have the popovers for consistency, although they are most useful
1162         for iterations that are not the last ones in a view, because the content is a delta
1163         from previous iteration.
1164
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1166         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1167         revisionLinksForIteration() is now named revisionContentForIteration().
1168
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1170         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1171         Ditto.
1172
1173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1174         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
1175
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1177         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
1178         with a function that builds an element with popover.
1179
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1181         Changed to take a function for popover presentation instead of delegate object.
1182         We only need one delegate function, and it's easier to have multiple popovers per view class
1183         this way.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1186         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
1187
1188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1189         Renamed pending-commits-popover class to commit-history-popover.
1190
1191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1192         (.status-line .message .revision-number): Added a rule for revision numbers.
1193
1194 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1195
1196         Please display information about pending runs in build.webkit.org/dashboard
1197         https://bugs.webkit.org/show_bug.cgi?id=122180
1198
1199         Reviewed by Timothy Hatcher.
1200
1201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1202         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1205         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
1206         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
1207         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
1208         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
1209         asks us to.
1210
1211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
1212         Taken from WebInspector with minimal changes:
1213         - Changed root name from WebInspector to Dashboard.
1214         - Removed some unused functionality.
1215         - Added Rect.containsPoint.
1216
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
1218         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
1219         - Fixed to work in scrollable pages - WebInspector version assumes that window
1220         and document coordinates are the same, and also erroneously dismisses a scrollable
1221         popover if scrolling cascades out of it after reaching a bound.
1222         - Simplified API and implementation to Dashboard needs, it is no longer possible to
1223         change content of an existing popover.
1224         - Rewrote visibility tracking to be more complete, and not rely on external tracker
1225         object so much.
1226         - Added code to flash scroll bars when showing a scrollable popover.
1227
1228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
1229         Objects of this class show and hide popovers as appropriate for registered active elements.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1232         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
1233         install a popover on message element. It's the only visible element in pending commit
1234         line, but the line has different bounds, so we can't install a popover on it (it
1235         would be incorrectly positioned if we did).
1236
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1238         (Trac.prototype._convertCommitInfoElementToObject):
1239         - Some trac installations report author in a different element, updated to support that.
1240         - Changed to parse title out of description, because trac titles are ugly. Also,
1241         we get a nice HTML with links from the description.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1244         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
1245         consistency with the rest of this file (add a property on prototype with assignment
1246         instead of using Object.defineProperty).
1247         (Node.prototype.isDescendant): Ditto.
1248         (Node.prototype.isSelfOrAncestor): Ditto.
1249         (Node.prototype.isSelfOrDescendant): Ditto.
1250         (DOMTokenList.prototype.contains): Ditto.
1251
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
1253         Like JS counterpart, mostly lifted from Web Inspector.
1254
1255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1256         Added style rules for pending commits popover.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1259         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
1260         to content, and we can show the popover in a correct place.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
1263
1264 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
1265
1266         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
1267         https://bugs.webkit.org/show_bug.cgi?id=126214
1268
1269         Reviewed by Alexey Proskuryakov.
1270
1271         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
1272         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
1273         state also tracks the prerender state - so split this out and handle it separately (a change
1274         we should make in WebCore, too).
1275
1276         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
1277         visibility mechanisms we should actually be changing characteristics of the view that will
1278         be detected by WebKit2 as a visibility change. This affects three things:
1279             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
1280             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
1281                that page visibility has been broken in WebKit2 for a couple of months, and didn't
1282                catch this fact). Removed in favour of:
1283             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
1284                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
1285             state, b) document.hidden, and c) too many state change notifications (it already looks
1286             for too few).
1287
1288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1289         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
1290             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
1291               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
1292         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1293         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1294         (runJavaScriptAlert):
1295             - Add checking for too many calls to the alert.
1296         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
1297             - Added methods to set visibility to prerender.
1298         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1299             - Added checking of 'document.hidden'.
1300         * WebKitTestRunner/TestController.cpp:
1301         (WTR::TestController::setVisibilityState):
1302         * WebKitTestRunner/TestController.h:
1303         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1304         (WTR::TestController::setHidden):
1305         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1306         (WTR::TestController::setHidden):
1307         * WebKitTestRunner/mac/TestControllerMac.mm:
1308         (WTR::TestController::setHidden):
1309             - Add setHidden method; call this from setVisibilityState.
1310
1311 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
1312
1313         Display EWS status on bot watcher's dashboard
1314         https://bugs.webkit.org/show_bug.cgi?id=126224
1315
1316         Silence spurious exceptions, no visible behavior change.
1317
1318         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1319         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
1320         feature that wasn't landed.
1321
1322 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
1323
1324         Display EWS status on bot watcher's dashboard
1325         https://bugs.webkit.org/show_bug.cgi?id=126224
1326
1327         Reviewed by Timothy Hatcher.
1328
1329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
1331         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
1332
1333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
1335         (QueueView):
1336         (QueueView.prototype.updateSoon):
1337         (QueueView.prototype.update):
1338         (QueueView.prototype._updateHiddenState):
1339         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
1340
1341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
1342         This is a peer to Buildbot.js and WebKitBuildbot.js.
1343
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
1346         Quite simple for now, only keeping track of queue size.
1347         
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1349         Initialize EWS.
1350
1351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1352         Create EWS views.
1353
1354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1355         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
1356
1357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
1359         These were empty, no reason to waste the time loading them.
1360
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
1362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
1363         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
1364
1365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1366             - Changed page title, as it no longer displays just buildbot status.
1367             - Updated subresource lists for the new, renamed and removed files.
1368
1369 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
1370
1371         EWS status JSON should include Access-Control-Allow-Origin
1372         https://bugs.webkit.org/show_bug.cgi?id=126246
1373
1374         Reviewed by Ryosuke Niwa.
1375
1376         * QueueStatusServer/app.yaml: Update version.
1377         * QueueStatusServer/handlers/queuestatusjson.py:
1378         (QueueStatusJSON.get): Add the header field.
1379
1380 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
1381
1382         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
1383         https://bugs.webkit.org/show_bug.cgi?id=126234
1384
1385         Reviewed by Timothy Hatcher.
1386
1387         Changed elements that are semantically links from <div> to <a>.
1388
1389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1390         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
1391         Don't try simulate a link with CSS/JS, it's not needed any more.
1392         (StatusLineView.prototype._clicked): Removed.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
1395         Removed text-decoration rules, default ones in Main.css now work for queue elements.
1396
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1398         Simplified cursor rules.
1399         Added a universal rule for links to only show underline on hover, as this is what
1400         we want almost everywhere.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1403         (.status-line .bubble): Added text-decoration: none, as this is the one place where
1404         we don't want it even on hover.
1405         (.status-line .label): Force display: block for consistent layout between <a>
1406         and <div>.
1407
1408 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
1409
1410         Please clarify "pending" reporting at build.webkit.org/dashboard
1411         https://bugs.webkit.org/show_bug.cgi?id=122191
1412
1413         Reviewed by Timothy Hatcher.
1414
1415         Reporting the count of pending runs didn't make a lot of sense - first, runs are
1416         coalesced and sometimes even out of order, and second, buildbot's notion of pending
1417         run was confusingly different from dashboard's.
1418
1419         Let's display how many SVN revisions are pending. This can be somewhat misleading
1420         too, because some revisions (like those for other platforms) don't trigger builds,
1421         but it's better than what we had.
1422
1423         This patch also lays the groundwork for displaying detailed information about
1424         pending revisions.
1425
1426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1427         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
1428         building pending status line directly, call newly added base class method.
1429
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1431         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1434         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
1435         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
1436         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
1437         information is secondary, and doesn't need as much attention.
1438         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
1439         Trac, not through Buildbot.
1440         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
1441         iterations are updated.
1442
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1444         Initialize a global webkitTrac object.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1448         Added a new style for messages without a bubble.
1449
1450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1451         Added a model class for Trac, which keeps track of SVN timeline, and notifies
1452         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1455         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
1456
1457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1458         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
1459         more sense to build trac URLs through it.
1460
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1462         Load Trac.js.
1463
1464 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
1465
1466         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
1467         https://bugs.webkit.org/show_bug.cgi?id=124636
1468
1469         Reviewed by Gyuyoung Kim.
1470
1471         * MiniBrowser/efl/main.c: Added.
1472         (on_key_down): Add a homepage shortcut using Alt + Home key. 
1473
1474 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
1475
1476         Revision selection behavior at build.webkit.org/dashboard is annoying
1477         https://bugs.webkit.org/show_bug.cgi?id=126235
1478
1479         Reviewed by Tim Horton.
1480
1481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1482         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
1483         selectable, not just the numbers in it.
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1485         (.selectable): Make selectable enable default behavior, not user-select:all.
1486
1487 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
1488
1489         [GTK] [CMake] Clean up generated sources directories
1490         https://bugs.webkit.org/show_bug.cgi?id=126216
1491
1492         Reviewed by Gustavo Noronha Silva.
1493
1494         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
1495         * GtkLauncher/CMakeLists.txt: Ditto.
1496         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
1497         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
1498         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
1499         header generation into on target.
1500         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
1501         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
1502         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
1503         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1504         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1505         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
1506         the cmake build.
1507
1508 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
1509
1510         Add a JSON interface for getting EWS queue status
1511         https://bugs.webkit.org/show_bug.cgi?id=126182
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         The current goal is to add an indicator of how many patches are in the queue, and
1516         the JSON also includes some other information that was easy to add.
1517
1518         * QueueStatusServer/app.yaml: Updated version for deployment.
1519
1520         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
1521         bot and patch queue information.
1522
1523         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
1524         bot ids.
1525
1526         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
1527         handler.
1528
1529         * QueueStatusServer/config: Added property svn:ignore.
1530         * QueueStatusServer/filters: Added property svn:ignore.
1531         * QueueStatusServer/loggers: Added property svn:ignore.
1532         * QueueStatusServer/handlers: Added property svn:ignore.
1533         * QueueStatusServer/model: Added property svn:ignore.
1534         Ignore compiled *.pyc files in all directories they appear in when running locally.
1535
1536 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
1537
1538         Try to fix the build after r161017
1539
1540         * gtk/common.py:
1541         (is_cmake_build): Instead of checking whether the return value of build_path
1542         of the CMakeCache.txt file is None, check if a file actually exists at that path.
1543
1544 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
1545
1546         [GTK] [CMake] Add support for generating gtkdoc
1547         https://bugs.webkit.org/show_bug.cgi?id=116376
1548
1549         Reviewed by Martin Robinson.
1550
1551         * gtk/common.py: look for files in the directories used by the cmake build as well.
1552
1553 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1554
1555         [GTK] Build with network process unconditionally
1556         https://bugs.webkit.org/show_bug.cgi?id=126128
1557
1558         Reviewed by Martin Robinson.
1559
1560         * Scripts/webkitperl/FeatureList.pm: Remove network-process
1561         feature command line option.
1562
1563 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1564
1565         [GTK] run-gtk-tests should always run glib tests with -k option
1566         https://bugs.webkit.org/show_bug.cgi?id=126132
1567
1568         Reviewed by Philippe Normand.
1569
1570         With -k command line option, gtester continues running all other
1571         test cases after a failure.
1572
1573         * Scripts/run-gtk-tests:
1574         (TestRunner._run_test_glib): Use -k option when runing glib tests
1575         to not stop on failure.
1576
1577 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
1578
1579         [GTK][CMake] Integrate GResource for inspector files (and others?)
1580         https://bugs.webkit.org/show_bug.cgi?id=125569
1581
1582         Reviewed by Gustavo Noronha Silva.
1583
1584         * gtk/generate-inspector-gresource-manifest.py: Added.
1585
1586 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1587
1588         Last URTBF after r160971 to make EFL build happy.
1589
1590         * TestWebKitAPI/efl/PlatformWebView.cpp:
1591         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1592
1593 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1594
1595         Unreviewed. Add myself to some more watch lists.
1596
1597         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
1598         and binding scripts patches.
1599
1600 2013-12-20  Commit Queue  <commit-queue@webkit.org>
1601
1602         Unreviewed, rolling out r160941.
1603         http://trac.webkit.org/changeset/160941
1604         https://bugs.webkit.org/show_bug.cgi?id=126095
1605
1606         Doesn't handle subpixel layout being disabled (Requested by
1607         smfr on #webkit).
1608
1609         * gdb/webkit.py:
1610         (JSCJSStringPrinter.to_string):
1611         (add_pretty_printers):
1612         * lldb/lldb_webkit.py:
1613         (WTFMediaTime_SummaryProvider):
1614         (WTFStringProvider.to_string):
1615
1616 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
1617
1618         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
1619         https://bugs.webkit.org/show_bug.cgi?id=126080
1620
1621         Reviewed by Anders Carlsson.
1622
1623         This changes the output of printing LayoutUnits to be in px, removing
1624         the need to divide by 64 manually.
1625
1626         This will lead to gdb output like:
1627
1628         m_frameRect = {
1629             m_location = LayoutPoint(0px, 0px),
1630             m_size = LayoutSize(800px, 585px)
1631         }
1632
1633         And lldb output like:
1634
1635         (const WebCore::LayoutRect) $0 = {
1636           m_location = { x = 744px, y = 1px }
1637           m_size = { width = 236px, height = 40px }
1638         }
1639
1640         This patch is based on patch for Blink by cbiesinger@chromium.org.
1641
1642         * gdb/webkit.py:
1643         (WebCoreLayoutUnitPrinter):
1644         (WebCoreLayoutUnitPrinter.__init__):
1645         (WebCoreLayoutUnitPrinter.to_string):
1646         (WebCoreLayoutSizePrinter):
1647         (WebCoreLayoutSizePrinter.__init__):
1648         (WebCoreLayoutSizePrinter.to_string):
1649         (WebCoreLayoutPointPrinter):
1650         (WebCoreLayoutPointPrinter.__init__):
1651         (WebCoreLayoutPointPrinter.to_string):
1652         (add_pretty_printers):
1653         * lldb/lldb_webkit.py:
1654         (__lldb_init_module):
1655         (WebCoreLayoutUnit_SummaryProvider):
1656         (WebCoreLayoutSize_SummaryProvider):
1657         (WebCoreLayoutPoint_SummaryProvider):
1658         (WebCoreLayoutUnitProvider):
1659         (WebCoreLayoutUnitProvider.__init__):
1660         (WebCoreLayoutUnitProvider.to_string):
1661         (WebCoreLayoutSizeProvider):
1662         (WebCoreLayoutSizeProvider.__init__):
1663         (WebCoreLayoutSizeProvider.get_width):
1664         (WebCoreLayoutSizeProvider.get_height):
1665         (WebCoreLayoutPointProvider):
1666         (WebCoreLayoutPointProvider.__init__):
1667         (WebCoreLayoutPointProvider.get_x):
1668         (WebCoreLayoutPointProvider.get_y):
1669
1670 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
1671
1672         [GTK] [CMake] Add support for building ImageDiff
1673         https://bugs.webkit.org/show_bug.cgi?id=125960
1674
1675         Reviewed by Gustavo Noronha Silva.
1676
1677         * CMakeLists.txt: Build ImageDiff for GTK+.
1678         * ImageDiff/PlatformGTK.cmake: Added.
1679
1680 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
1681
1682         [GTK] [CMake] Add support for building DumpRenderTree
1683         https://bugs.webkit.org/show_bug.cgi?id=125767
1684
1685         Reviewed by Gustavo Noronha Silva.
1686
1687         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
1688         * DumpRenderTree/PlatformGTK.cmake: Added.
1689
1690 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
1691
1692         [GTK] [CMake] Add support for building WebKitTestRunner
1693         https://bugs.webkit.org/show_bug.cgi?id=125768
1694
1695         Reviewed by Gustavo Noronha Silva.
1696
1697         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
1698         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
1699         build file.
1700         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
1701         * WebKitTestRunner/PlatformGTK.cmake: Added.
1702
1703 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
1704
1705         Myles C. Maxfield is a committer now
1706
1707         Unreviewed.
1708
1709         * Scripts/webkitpy/common/config/contributors.json:
1710
1711 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1712
1713         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
1714         https://bugs.webkit.org/show_bug.cgi?id=125854
1715
1716         Reviewed by Chris Fleizach.
1717
1718         Ensure we don't ever create instances of AccessibilityUIElement
1719         wrapping invalid platform-specific accessibility objects in DRT,
1720         both for consistency with what WKTR does (so we avoid situations
1721         where some tests fail in WK2 and not in WK1) and also to avoid
1722         overlooking tests that might not be checking the right thing.
1723
1724         * DumpRenderTree/AccessibilityUIElement.cpp:
1725         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
1726         nullPtr if the platformUIElement() is not a valid one.
1727         * DumpRenderTree/AccessibilityUIElement.h:
1728         (AccessibilityUIElement::platformUIElement): Added const modifier.
1729
1730 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1731
1732         Programmatically-inserted children lack accessibility events
1733         https://bugs.webkit.org/show_bug.cgi?id=100275
1734
1735         Reviewed by Chris Fleizach.
1736
1737         Update DRT and WebKitTestRunner to handle the children-changed
1738         signal properly, considering the detail and optional parameters.
1739
1740         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1741         (axObjectEventListener):
1742         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1743
1744 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1745
1746         Removed unused BUILDER_BASE_URL.
1747         https://bugs.webkit.org/show_bug.cgi?id=125442
1748
1749         Reviewed by Csaba Osztrogonác.
1750
1751         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1752         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
1753
1754 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1755
1756         Removed unused BUILDER_BASE_URL.
1757         https://bugs.webkit.org/show_bug.cgi?id=125442
1758
1759         Reviewed by Csaba Osztrogonác.
1760
1761         The string constant BUILDER_BASE_URL is passed around several times,
1762         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
1763
1764         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1765         (Manager._upload_json_files):
1766         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1767         (JSONLayoutResultsGenerator.__init__):
1768         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1769         (JSONResultsGenerator.__init__):
1770
1771 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
1772
1773         check-webkit-style mistakenly flags assigning to a dereferenced pointer
1774         https://bugs.webkit.org/show_bug.cgi?id=126041
1775
1776         Reviewed by Ryosuke Niwa.
1777
1778         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
1779         sure that there is a declaration. This patch makes sure that there is a
1780         declaration in order to flag spacing around asterisks.
1781
1782         * Scripts/webkitpy/style/checkers/cpp.py:
1783         (check_spacing):
1784         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1785         (CppStyleTest.test_pointer_reference_marker_location):
1786
1787 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
1788
1789         check-webkit-style marks rvalue references as violations
1790         https://bugs.webkit.org/show_bug.cgi?id=126000
1791
1792         Reviewed by Ryosuke Niwa.
1793
1794         Previously, check-webkit-style was making sure that any line with "&&" had
1795         spaces around it. However, we can now legitimately use "&&" without a previous
1796         space when declaring an rvalue reference. This patch relaxes this check.
1797
1798         * Scripts/webkitpy/style/checkers/cpp.py:
1799         (check_spacing):
1800         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1801         (CppStyleTest.test_spacing_for_binary_ops):
1802
1803 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
1804
1805         check-webkit-style marks auto return types for functions as violations
1806         https://bugs.webkit.org/show_bug.cgi?id=125999
1807
1808         Reviewed by Ryosuke Niwa.
1809
1810         If a function declaration ends with a "->" followed by a non whitespace
1811         string, don't mark as an invalid "{" on its own line
1812
1813         * Scripts/webkitpy/style/checkers/cpp.py:
1814         (check_braces):
1815         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1816         (CppStyleTest.test_brace_at_begin_of_line):
1817
1818 2013-12-19  Alex Christensen  <achristensen@webkit.org>
1819
1820         [WinCairo] More GStreamer preparations.
1821
1822         Unreviewed.
1823
1824         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
1825         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
1826
1827 2013-12-19  Lucas Forschler  <lforschler@apple.com>
1828
1829         Add Apple Mavericks perf bot.
1830         
1831         Unreviewed.
1832
1833         * BuildSlaveSupport/build.webkit.org-config/config.json:
1834
1835 2013-12-19  Commit Queue  <commit-queue@webkit.org>
1836
1837         Unreviewed, rolling out r160842.
1838         http://trac.webkit.org/changeset/160842
1839         https://bugs.webkit.org/show_bug.cgi?id=126003
1840
1841         broke accessibility/loading-iframe-updates-axtree.html
1842         (Requested by ap on #webkit).
1843
1844         * DumpRenderTree/AccessibilityUIElement.cpp:
1845         (AccessibilityUIElement::makeJSAccessibilityUIElement):
1846         * DumpRenderTree/AccessibilityUIElement.h:
1847         (AccessibilityUIElement::platformUIElement):
1848
1849 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1850
1851         get_test_baseline should get Host from test_config
1852         https://bugs.webkit.org/show_bug.cgi?id=125989
1853
1854         Reviewed by Ryosuke Niwa.
1855
1856         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1857         (TestConfig.__init__):
1858         (RebaselineServer._prepare_config):
1859         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1860         (get_test_baselines):
1861         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1862         (get_test_config):
1863
1864 2013-12-19  Roger Fong  <roger_fong@apple.com>
1865
1866         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
1867         https://bugs.webkit.org/show_bug.cgi?id=125998.
1868
1869         Reviewed by Alexey Proskuryakov.
1870
1871         * Scripts/webkitdirs.pm:
1872         (visualStudioInstallDir):
1873         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
1874
1875 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
1876
1877         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
1878         https://bugs.webkit.org/show_bug.cgi?id=125854
1879
1880         Reviewed by Chris Fleizach.
1881
1882         Ensure we don't ever create instances of AccessibilityUIElement
1883         wrapping invalid platform-specific accessibility objects in DRT,
1884         both for consistency with what WKTR does (so we avoid situations
1885         where some tests fail in WK2 and not in WK1) and also to avoid
1886         overlooking tests that might not be checking the right thing.
1887
1888         * DumpRenderTree/AccessibilityUIElement.cpp:
1889         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
1890         nullPtr if the platformUIElement() is not a valid one.
1891         * DumpRenderTree/AccessibilityUIElement.h:
1892         (AccessibilityUIElement::platformUIElement): Added const modifier.
1893
1894 2013-12-18  Anders Carlsson  <andersca@apple.com>
1895
1896         Deprecate some WKMutableDictionary functions
1897         https://bugs.webkit.org/show_bug.cgi?id=125962
1898
1899         Reviewed by Tim Horton.
1900
1901         * TestWebKitAPI/PlatformUtilities.cpp:
1902         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1903         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1904         (TestWebKitAPI::didAssociateFormControls):
1905         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1906         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
1907         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
1908         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1909         (WTR::createMouseMessageBody):
1910         (WTR::EventSendingController::mouseMoveTo):
1911         (WTR::EventSendingController::leapForward):
1912         (WTR::createKeyDownMessageBody):
1913         (WTR::EventSendingController::mouseScrollBy):
1914         (WTR::EventSendingController::continuousMouseScrollBy):
1915         (WTR::EventSendingController::addTouchPoint):
1916         (WTR::EventSendingController::updateTouchPoint):
1917         (WTR::EventSendingController::setTouchModifier):
1918         (WTR::EventSendingController::setTouchPointRadius):
1919         (WTR::EventSendingController::touchStart):
1920         (WTR::EventSendingController::touchMove):
1921         (WTR::EventSendingController::touchEnd):
1922         (WTR::EventSendingController::touchCancel):
1923         (WTR::EventSendingController::clearTouchPoints):
1924         (WTR::EventSendingController::releaseTouchPoint):
1925         (WTR::EventSendingController::cancelTouchPoint):
1926         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1927         (WTR::InjectedBundle::done):
1928         (WTR::InjectedBundle::setMockGeolocationPosition):
1929         (WTR::InjectedBundle::setCustomPolicyDelegate):
1930         (WTR::InjectedBundle::setVisibilityState):
1931         (WTR::InjectedBundle::queueLoad):
1932         (WTR::InjectedBundle::queueLoadHTMLString):
1933         * WebKitTestRunner/TestController.cpp:
1934         (WTR::TestController::initialize):
1935         (WTR::TestController::resetStateToConsistentValues):
1936         * WebKitTestRunner/TestInvocation.cpp:
1937         (WTR::updateThreadedScrollingForCurrentTest):
1938         (WTR::updateLayoutType):
1939         (WTR::TestInvocation::invoke):
1940
1941 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
1942
1943         [GTK] [CMake] Add support for building GtkLauncher
1944         https://bugs.webkit.org/show_bug.cgi?id=125766
1945
1946         Reviewed by Gustavo Noronha Silva.
1947
1948         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
1949         * GtkLauncher/CMakeLists.txt: Added.
1950         * GtkLauncher/main.c: Support including the CMake config file.
1951
1952 2013-12-18  Alex Christensen  <achristensen@webkit.org>
1953
1954         [WinCairo] Preparation for GStreamer on Windows.
1955         https://bugs.webkit.org/show_bug.cgi?id=125946
1956
1957         Reviewed by Brent Fulgham.
1958
1959         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1960         Use new GStreamer property sheets for WinCairo.
1961         * win/DLLLauncher/DLLLauncherMain.cpp:
1962         (modifyPath):
1963         (wWinMain):
1964         Prepend GStreamer bin directory to path if it exists.
1965
1966 2013-12-18  Anders Carlsson  <andersca@apple.com>
1967
1968         Remove now useless test.
1969
1970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1971         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
1972         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
1973         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
1974
1975 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
1976
1977         Fix page visibility api test, initialization in WebKit2
1978         https://bugs.webkit.org/show_bug.cgi?id=125933
1979
1980         Reviewed by Anders Carlsson.
1981
1982         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
1983         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
1984
1985         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1986         (TestWebKitAPI::TEST_F):
1987             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
1988
1989 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1990
1991         Should not have identifiers with underscores in them, especially not leading underscores.
1992         https://bugs.webkit.org/show_bug.cgi?id=125847
1993
1994         Reviewed by Darin Adler.
1995
1996         * Scripts/webkitpy/style/checkers/cpp.py:
1997         (check_identifier_name_in_declaration):
1998         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1999         (CppStyleTest.test_runtime_selfinit):
2000         (WebKitStyleTest.test_names):
2001
2002 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2003
2004         False webkit-check-style warnings on *.
2005         https://bugs.webkit.org/show_bug.cgi?id=125915
2006
2007         Reviewed by Darin Adler.
2008
2009         * Scripts/webkitpy/style/checkers/cpp.py:
2010         (check_spacing):
2011         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2012         (CppStyleTest.test_pointer_reference_marker_location):
2013
2014 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2015
2016         prepare-ChangeLog doesn't handle templates properly
2017         https://bugs.webkit.org/show_bug.cgi?id=125853
2018
2019         Reviewed by Daniel Bates.
2020
2021         * Scripts/prepare-ChangeLog:
2022         (get_function_line_ranges_for_cpp):
2023         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2024         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2025         (Class110<TemplateClass>::func36):
2026
2027 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2028
2029         Move expectation parsing out of the constructor of TestExpectations
2030         https://bugs.webkit.org/show_bug.cgi?id=125439
2031
2032         Reviewed by Csaba Osztrogonác.
2033
2034         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2035         (LayoutTestRunnerTests._run_tests):
2036         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
2037         (LayoutTestRunnerTests.test_update_summary_with_result):
2038         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2039         (Manager.run):
2040         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2041         (ManagerTest.test_look_for_new_crash_logs):
2042         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
2043         (lint):
2044         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2045         (TestExpectations.suffixes_for_expectations):
2046         (TestExpectations.__init__):
2047         (TestExpectations):
2048         (TestExpectations.parse_generic_expectations):
2049         (TestExpectations.parse_default_port_expectations):
2050         (TestExpectations.parse_override_expectations):
2051         (TestExpectations.parse_all_expectations):
2052         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2053         (parse_exp):
2054         (SkippedTests.check):
2055         (SkippedTests.test_skipped_entry_dont_exist):
2056         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2057         (run_results):
2058         * Scripts/webkitpy/tool/commands/queries.py:
2059         (PrintExpectations._model):
2060         * Scripts/webkitpy/tool/commands/rebaseline.py:
2061         (RebaselineTest._update_expectations_file):
2062         (RebaselineExpectations._update_expectations_files):
2063         (RebaselineExpectations._tests_to_rebaseline):
2064
2065 2013-12-17  Jer Noble  <jer.noble@apple.com>
2066
2067         Fix TimeRanges::intersectWith
2068         https://bugs.webkit.org/show_bug.cgi?id=118802
2069
2070         Reviewed by Eric Carlson.
2071
2072         Add unit tests for WebCore/TimeRanges.
2073
2074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2075         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
2076         (TestWebKitAPI::ToString):
2077         (TestWebKitAPI::TEST):
2078
2079 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
2080
2081         Botwatcher's dashboard ceases to update itself after a while
2082         https://bugs.webkit.org/show_bug.cgi?id=125885
2083
2084         Reviewed by Timothy Hatcher.
2085
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2087         Removed code that checked for the view being hidden. It's none of model's business.
2088
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2090         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
2091         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
2092         We now stop the timer for hidden views.
2093         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
2094
2095 2013-12-17  Anders Carlsson  <andersca@apple.com>
2096
2097         Fix the 32-bit build.
2098
2099         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
2100         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
2101
2102 2013-12-17  Anders Carlsson  <andersca@apple.com>
2103
2104         Give the MiniBrowser a bundle
2105         https://bugs.webkit.org/show_bug.cgi?id=125882
2106
2107         Reviewed by Sam Weinig.
2108
2109         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
2110         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2111         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
2112         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
2113         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
2114         * MiniBrowser/mac/AppDelegate.m:
2115         (-[BrowserAppDelegate init]):
2116         * MiniBrowser/mac/Bundle/Info.plist: Added.
2117         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
2118
2119 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
2120
2121         Remove PageVisibilityStateUnloaded
2122         https://bugs.webkit.org/show_bug.cgi?id=125869
2123
2124         Reviewed by Anders Carlsson.
2125
2126         This is not currently supported by WebKit, remove this enum value.
2127         We can always add this back later if/when we add support for this state.
2128
2129         * DumpRenderTree/mac/TestRunnerMac.mm:
2130         (TestRunner::setPageVisibility):
2131         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
2132         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
2133         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2134         (WTR::TestRunner::setPageVisibility):
2135             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
2136
2137 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
2138
2139         [GTK] [CMake] Build the plugin process against GTK+ 2
2140         https://bugs.webkit.org/show_bug.cgi?id=116374
2141
2142         Reviewed by Gustavo Noronha Silva.
2143
2144         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
2145         libraries required for WebCore unit tests.
2146
2147 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
2148
2149         [Win] Revise filter-build-webkit to deal with Windows build logs
2150         https://bugs.webkit.org/show_bug.cgi?id=125866
2151
2152         Reviewed by David Kilzer.
2153
2154         Enhance the script to accept a 'platform' argument. When platform
2155         'win' is provided, use processing for the Windows build file format.
2156         Otherwise, process the files as normal.
2157
2158         * Scripts/filter-build-webkit:
2159         (usageAndExit): Add a 'platform' argument
2160         (shouldIgnoreLine): When platform == 'win' use the new Windows
2161         rules for processing the build file.
2162
2163 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
2164
2165         Update style checker now that ENUM_CLASS is gone
2166         https://bugs.webkit.org/show_bug.cgi?id=125864
2167
2168         Reviewed by Anders Carlsson.
2169
2170         * Scripts/webkitpy/style/checkers/cpp.py:
2171         (_EnumState.process_clean_line):
2172         (check_braces):
2173         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2174         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
2175         (NoNonVirtualDestructorsTest.test_enum_casing):
2176         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
2177         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
2178         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
2179         (WebKitStyleTest.test_braces.CPP11EnumClass):
2180
2181 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
2182
2183         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
2184         https://bugs.webkit.org/show_bug.cgi?id=125857
2185
2186         Reviewed by Chris Fleizach.
2187
2188         Add mappings to DRT & WKTR for the newly exposed roles, and
2189         increase the version of ATK used by the internal jhbuild.
2190
2191         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2192         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2193         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
2194
2195 2013-12-17  Alex Christensen  <achristensen@webkit.org>
2196
2197         [WinCairo] Adding support for GStreamer and GLib.
2198         https://bugs.webkit.org/show_bug.cgi?id=124867
2199
2200         Reviewed by Philippe Normand.
2201
2202         * WinLauncher/WinLauncher.cpp:
2203         (wWinMain):
2204         Added g_main_context_iteration in main event loop.
2205
2206 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2207
2208         Fix for C++ should have the & or * beside the type not the variable name check.
2209         https://bugs.webkit.org/show_bug.cgi?id=125846
2210
2211         Reviewed by Darin Adler.
2212
2213         * Scripts/webkitpy/style/checkers/cpp.py:
2214         (check_spacing):
2215         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2216         (CppStyleTest.test_pointer_reference_marker_location):
2217
2218 2013-12-16  Rob Buis  <rob.buis@samsung.com>
2219
2220         Add my Samsung email address.
2221
2222         Unreviewed.
2223
2224         * Scripts/webkitpy/common/config/contributors.json:
2225
2226 2013-12-16  Oliver Hunt  <oliver@apple.com>
2227
2228         Cache getters and custom accessors on the prototype chain
2229         https://bugs.webkit.org/show_bug.cgi?id=125602
2230
2231         Reviewed by Michael Saboff.
2232
2233         Make sure bencher scripts also make noInline exist
2234
2235         * Scripts/bencher:
2236
2237 2013-12-16  Anders Carlsson  <andersca@apple.com>
2238
2239         Fix crash when trying to load a null HTML string
2240         https://bugs.webkit.org/show_bug.cgi?id=125801
2241
2242         Reviewed by Dan Bernstein.
2243
2244         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2245         (TestWebKitAPI::TEST_F):
2246         Update test results.
2247
2248 2013-12-16  Alex Christensen  <achristensen@webkit.org>
2249
2250         Fixed Win64 build on VS2013.
2251         https://bugs.webkit.org/show_bug.cgi?id=125753
2252
2253         Reviewed by Brent Fulgham.
2254
2255         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2256         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2257         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2258         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2259         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2260         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2261         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2262         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2263         * win/record-memory/record-memory.vcxproj:
2264         Added correct PlatformToolset for 64-bit builds.
2265
2266 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
2267
2268         Add a menu option to MiniBrowser to enable UI-side compositing
2269         https://bugs.webkit.org/show_bug.cgi?id=125793
2270
2271         Reviewed by Anders Carlsson.
2272         
2273         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
2274
2275         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
2276         to toggle UI-side compositing.
2277         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
2278         * MiniBrowser/mac/WK2BrowserWindowController.m:
2279         (-[WK2BrowserWindowController validateMenuItem:]):
2280         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
2281         (-[WK2BrowserWindowController toggleUISideCompositing:]):
2282         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2283         Adjust the window title to indicate whether the window is using UI-side compositing.
2284
2285 2013-12-16  Commit Queue  <commit-queue@webkit.org>
2286
2287         Unreviewed, rolling out r160645.
2288         http://trac.webkit.org/changeset/160645
2289         https://bugs.webkit.org/show_bug.cgi?id=125787
2290
2291         Change breaks test-webkitpy (Requested by bfulgham on
2292         #webkit).
2293
2294         * Scripts/prepare-ChangeLog:
2295         (get_selector_line_ranges_for_css):
2296
2297 2013-12-16  David Farler  <dfarler@apple.com>
2298
2299         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
2300         https://bugs.webkit.org/show_bug.cgi?id=124610
2301
2302         Reviewed by Mark Rowe.
2303
2304         * WebKitLauncher/WebKitNightlyEnabler.m:
2305         (enableWebKitNightlyBehaviour):
2306         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
2307         * WebKitLauncher/main.m:
2308         (main):
2309         Include both libasancrashreporter and the nightly enabler to
2310         the list of libraries to insert.
2311
2312 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2313
2314         Resolve inconsistant style warning caused by r160319.
2315         https://bugs.webkit.org/show_bug.cgi?id=125772
2316
2317         Reviewed by Darin Adler.
2318
2319         * Scripts/webkitpy/style/checkers/cpp.py:
2320         (check_for_extra_new_line_at_eof):
2321         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2322         (CppStyleTest.test_newline_at_eof):
2323         (CppStyleTest.test_extra_newlines_at_eof):
2324
2325 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2326
2327         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
2328         https://bugs.webkit.org/show_bug.cgi?id=125780
2329
2330         Reviewed by Darin Adler.
2331
2332         * Scripts/webkitpy/port/mock_drt.py:
2333         (main):
2334         (parse_options):
2335         (MockDRT.write_test_output):
2336         * Scripts/webkitpy/port/mock_drt_unittest.py:
2337         (MockDRTTest.assertTest):
2338         (MockDRTTest.test_reftest_mismatch):
2339
2340 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2341
2342         prepare-Changelog treats CSS keyframes as mismatched parentheses.
2343         https://bugs.webkit.org/show_bug.cgi?id=125435
2344
2345         Reviewed by Darin Adler.
2346
2347         * Scripts/prepare-ChangeLog:
2348         (get_selector_line_ranges_for_css):
2349
2350 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2351
2352         [ATK] Expose accessibility objects for more WAI-ARIA roles
2353         https://bugs.webkit.org/show_bug.cgi?id=125596
2354
2355         Reviewed by Chris Fleizach.
2356
2357         Add mappings to DRT & WKTR for the newly exposed roles.
2358
2359         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2360         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2361
2362 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2363
2364         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
2365         https://bugs.webkit.org/show_bug.cgi?id=125594
2366
2367         Reviewed by Chris Fleizach.
2368
2369         Add mappings to DRT & WKTR for checkmenuitem role.
2370
2371         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2372         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2373
2374 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2375
2376         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
2377         https://bugs.webkit.org/show_bug.cgi?id=125587
2378
2379         Reviewed by Chris Fleizach.
2380
2381         Add mappings to DRT & WKTR for article roles.
2382
2383         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2384         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2385
2386 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2387
2388         [FTL] Allow EFL to build FTL with the build-jsc script.
2389         https://bugs.webkit.org/show_bug.cgi?id=125774
2390
2391         Reviewed by Zoltan Herczeg.
2392
2393         * Scripts/build-jsc:
2394
2395 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
2396
2397         Add myself as a committer
2398
2399         Unreviewed.
2400
2401         * Scripts/webkitpy/common/config/contributors.json:
2402
2403 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2404
2405         Refactor option handling in WebKitTestRunner.
2406         https://bugs.webkit.org/show_bug.cgi?id=123185
2407
2408         Reviewed by Darin Adler.
2409
2410         Option handling is refactored (according to the FIXME) that allows
2411         to automatically generate the help message.
2412
2413         * WebKitTestRunner/CMakeLists.txt:
2414         * WebKitTestRunner/GNUmakefile.am:
2415         * WebKitTestRunner/Options.cpp: Added.
2416         (WTR::Options::Options):
2417         (WTR::handleOptionTimeout):
2418         (WTR::handleOptionNoTimeout):
2419         (WTR::handleOptionNoTimeoutAtAll):
2420         (WTR::handleOptionVerbose):
2421         (WTR::handleOptionGcBetweenTests):
2422         (WTR::handleOptionPixelTests):
2423         (WTR::handleOptionPrintSupportedFeatures):
2424         (WTR::handleOptionComplexText):
2425         (WTR::handleOptionAcceleratedDrawing):
2426         (WTR::handleOptionRemoteLayerTree):
2427         (WTR::handleOptionUnmatched):
2428         (WTR::OptionsHandler::OptionsHandler):
2429         (WTR::Option::Option):
2430         (WTR::Option::matches):
2431         (WTR::OptionsHandler::parse):
2432         (WTR::OptionsHandler::printHelp):
2433         * WebKitTestRunner/Options.h: Added.
2434         * WebKitTestRunner/TestController.cpp:
2435         (WTR::TestController::initialize):
2436         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2437
2438 2013-12-15  Dan Bernstein  <mitz@apple.com>
2439
2440         32-bit build fix.
2441
2442         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2443         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
2444
2445 2013-12-14  Tim Horton  <timothy_horton@apple.com>
2446
2447         stylebot should warn when FeatureDefines differ
2448         https://bugs.webkit.org/show_bug.cgi?id=125748
2449
2450         Reviewed by Dan Bernstein.
2451
2452         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
2453         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
2454         an unlikely occurrance, to add them to the list).
2455
2456         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
2457         but that is the most straightforward way to implement it (and we're at zero diffs right now).
2458
2459         * Scripts/webkitpy/style/checker.py:
2460         (_all_categories):
2461         (FileType):
2462         (CheckerDispatcher._file_type):
2463         (CheckerDispatcher._create_checker):
2464         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
2465         (FeatureDefinesChecker):
2466         (FeatureDefinesChecker.__init__):
2467         (FeatureDefinesChecker.check):
2468
2469 2013-12-13  Sam Weinig  <sam@webkit.org>
2470
2471         Fix API tests.
2472
2473         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2474         (TestWebKitAPI::TEST_F):
2475
2476 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2477
2478         [Win] Remove Pre-VS2013 support code.
2479         https://bugs.webkit.org/show_bug.cgi?id=125693
2480
2481         Reviewed by Darin Adler.
2482
2483         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
2484         the math library.
2485         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2486
2487 2013-12-13  Lucas Forschler  <lforschler@apple.com>
2488
2489         Update Webkit bots.
2490         
2491         Unreviewed.
2492         
2493         * BuildSlaveSupport/build.webkit.org-config/config.json:
2494
2495 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2496
2497         [Win] Unreviewed build fix after r160548
2498
2499         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
2500         we are using vs12_xp target for Makefile-based projects.
2501
2502 2013-12-13  Lucas Forschler  <lforschler@apple.com>
2503
2504         Update Apple Webkit Bots
2505         
2506         Unreviewed.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/config.json:
2509
2510 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2511
2512         Unreviewed build fix after r160548.
2513
2514         * Scripts/webkitdirs.pm:
2515         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
2516
2517 2013-12-13  Lucas Forschler  <lforschler@apple.com>
2518
2519         Update Apple bots.
2520         
2521         Unreviewed.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/config.json:
2524
2525 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2526
2527         [Win] Switch WebKit solution to Visual Studio 2013
2528         https://bugs.webkit.org/show_bug.cgi?id=125192
2529
2530         Reviewed by Anders Carlsson.
2531
2532         Project files must reference vs12_xp for 32-bit builds. 
2533
2534         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2535         Update for VS2013
2536         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2537         Ditto
2538         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2539         Ditto
2540         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2541         Ditto
2542         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2543         Ditto
2544         * Scripts/webkitdirs.pm:
2545         (visualStudioInstallDir): Specify VS2013
2546         (visualStudioVersion): Ditto.
2547         (setupAppleWinEnv): Use VS2013 in messages
2548         (setupCygwinEnv): Ditto
2549         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2550         Update for VS2013
2551         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2552         Ditto
2553         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2554         Ditto
2555         * win/record-memory/record-memory.vcxproj:
2556         Ditto
2557
2558 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
2559
2560         Adding a .ycm_extra_conf file for webkitGtk
2561         https://bugs.webkit.org/show_bug.cgi?id=119618
2562
2563         Reviewed by Gustavo Noronha Silva.
2564
2565         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
2566         read the GTK+ build files to determine dynamically what flags to compile a source
2567         file with. This allows Vim to provide auto-complete for C++/C language. See
2568         https://github.com/Valloric/YouCompleteMe for how to use this file.
2569
2570         * gtk/common.py:
2571         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
2572         * gtk/ycm_extra_conf.py: Added.
2573
2574 2013-12-12  Tim Horton  <timothy_horton@apple.com>
2575
2576         [wk2] Handle pinch-to-zoom gesture
2577         https://bugs.webkit.org/show_bug.cgi?id=125604
2578
2579         Reviewed by Simon Fraser.
2580
2581         * MiniBrowser/mac/WK2BrowserWindowController.m:
2582         (-[WK2BrowserWindowController awakeFromNib]):
2583         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
2584
2585 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
2586
2587         Unreviewed. Add myself as a committer.
2588
2589         * Scripts/webkitpy/common/config/contributors.json:
2590
2591 2013-12-12  Lucas Forschler  <lforschler@apple.com>
2592
2593         Update hardware for Apple bots.
2594         
2595         Unreviewed.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/config.json:
2598
2599 2013-12-12  Lucas Forschler  <lforschler@apple.com>
2600
2601         Remove unused Apple Bots.
2602         
2603         Unreviewed.
2604
2605         * BuildSlaveSupport/build.webkit.org-config/config.json:
2606
2607 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
2608
2609         Unreviewed. Add myself as a committer.
2610
2611         * Scripts/webkitpy/common/config/contributors.json:
2612
2613 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
2614
2615         Test new JSContext name APIs
2616         https://bugs.webkit.org/show_bug.cgi?id=125607
2617
2618         Reviewed by Darin Adler.
2619
2620         * Scripts/run-javascriptcore-tests:
2621         Remove trailing whitespace.
2622
2623 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
2624
2625         [Autotools] Prepend the WebCore layer archives' names with 'lib'
2626         https://bugs.webkit.org/show_bug.cgi?id=125627
2627
2628         Reviewed by Martin Robinson.
2629
2630         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
2631         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
2632
2633 2013-12-12  Commit Queue  <commit-queue@webkit.org>
2634
2635         Unreviewed, rolling out r160446.
2636         http://trac.webkit.org/changeset/160446
2637         https://bugs.webkit.org/show_bug.cgi?id=125630
2638
2639         The upower-glib-based implementation is using API that was
2640         recently removed (Requested by zdobersek1 on #webkit).
2641
2642         * Scripts/webkitperl/FeatureList.pm:
2643
2644 2013-12-12  Commit Queue  <commit-queue@webkit.org>
2645
2646         Unreviewed, rolling out r160417.
2647         http://trac.webkit.org/changeset/160417
2648         https://bugs.webkit.org/show_bug.cgi?id=125629
2649
2650         The patch is causing crashes (Requested by zdobersek1 on
2651         #webkit).
2652
2653         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2654         (axObjectEventListener):
2655         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2656
2657 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
2658
2659         Use of ar T option not supported by older binutils
2660         https://bugs.webkit.org/show_bug.cgi?id=118732
2661
2662         Reviewed by Gustavo Noronha Silva.
2663
2664         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
2665         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
2666         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
2667         of the member's object file, and not the full path to it. To work around that, all the object files
2668         under the build directory are listed by their relative paths. The members of various archives then have
2669         the basenames of their paths grepped against that list, with the found path correlating to the member
2670         finally added as the new member of the WebCoreLayer archive.
2671
2672 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
2673
2674         check-webkit-style shouldn't check spacing in #if preprocessor lines
2675         https://bugs.webkit.org/show_bug.cgi?id=125534
2676
2677         Reviewed by Ryosuke Niwa.
2678
2679         Preprocessor lines that start with #if shouldn't have to adhere to
2680         the same spacing requirements that regular code does
2681
2682         * Scripts/webkitpy/style/checkers/cpp.py:
2683         (check_spacing):
2684         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2685         (CppStyleTest.test_spacing_for_binary_ops):
2686         (WebKitStyleTest.test_line_breaking):
2687
2688 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
2689
2690         check-webkit-style can't determine if a comma is part of an initialization list
2691         https://bugs.webkit.org/show_bug.cgi?id=125537
2692
2693         Reviewed by Darin Adler.
2694
2695         The original check to make sure that initialization list lines start with
2696         a comma didn't distinguish between commas that belong to the initialization
2697         list and commas that are part of function calls. Because we don't want to
2698         match parentheses with regular expressions, we should weaken this check to
2699         only check for commas at the end of initialization list lines.
2700
2701         * Scripts/webkitpy/style/checkers/cpp.py:
2702         (check_member_initialization_list):
2703         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2704         (WebKitStyleTest.test_member_initialization_list):
2705
2706 2013-12-11  Tim Horton  <timothy_horton@apple.com>
2707
2708         Make it possible to compare layout test results between various configurations of WebKit
2709         https://bugs.webkit.org/show_bug.cgi?id=125212
2710         <rdar://problem/15199108>
2711
2712         Reviewed by Darin Adler.
2713
2714         * Scripts/compare-webkit-configurations: Added.
2715         Add a script that allows comparison between the "normal" WebKit configuration
2716         used for testing and a different configuration (e.g. with accelerated drawing
2717         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
2718
2719         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
2720
2721         This script runs the tests once in the default configuration, ignoring
2722         all test expectations, writing the results out to a temporary directory.
2723
2724         It then runs the tests again in the modified configuration, against the
2725         just-written temporary results.
2726
2727         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
2728
2729         * DumpRenderTree/mac/DumpRenderTree.mm:
2730         (resetWebPreferencesToConsistentValues):
2731         (initializeGlobalsFromCommandLineOptions):
2732         Enable accelerated drawing if requested.
2733
2734         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2735         (parse_args):
2736         Add --accelerated-drawing and --remote-layer-tree feature switches, which
2737         are forwarded on to the test drivers.
2738         Move those two and --complex-text into their own "feature switches" section.
2739         Drive-by change "Mac OS X" to "OS X".
2740         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
2741         as traditional pixel tests (with PNGs dumped on disk), and
2742         ignores e.g. -expected.html files.
2743
2744         * Scripts/webkitpy/port/base.py:
2745         (Port.reference_files):
2746         Pretend that there are no ref tests.
2747         Since is_reference_html_file is intact, our mechanism to ignore
2748         the expected files will continue working in this case.
2749
2750         * Scripts/webkitpy/port/driver.py:
2751         (Driver.cmd_line):
2752         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
2753
2754         * WebKitTestRunner/TestController.cpp:
2755         (WTR::TestController::TestController):
2756         (WTR::TestController::initialize):
2757         (WTR::TestController::resetPreferencesToConsistentValues):
2758         * WebKitTestRunner/TestController.h:
2759         (WTR::TestController::shouldUseRemoteLayerTree):
2760         * WebKitTestRunner/TestInvocation.cpp:
2761         (WTR::updateThreadedScrollingForCurrentTest):
2762         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2763         (WTR::PlatformWebView::PlatformWebView):
2764         Parse and implement the three feature switches.
2765
2766 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2767
2768         [ATK] Expose accessibility objects WAI-ARIA landmark roles
2769         https://bugs.webkit.org/show_bug.cgi?id=125584
2770
2771         Reviewed by Chris Fleizach.
2772
2773         Add mappings to DRT & WKTR for landmark roles.
2774
2775         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2776         (AccessibilityUIElement::role):
2777         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2778         (WTR::AccessibilityUIElement::role):
2779         * gtk/jhbuild.modules:
2780
2781 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
2782
2783         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
2784         https://bugs.webkit.org/show_bug.cgi?id=125441
2785
2786         Reviewed by Martin Robinson.
2787
2788         Just avoid the double quotations when building the parameter
2789         because some versions of valgrind are not handling it correctly.
2790
2791         * Scripts/webkitpy/port/gtk.py:
2792         (GtkPort.setup_environ_for_server):
2793
2794 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
2795
2796         [GTK] Enable Battery Status API
2797         https://bugs.webkit.org/show_bug.cgi?id=125453
2798
2799         Reviewed by Martin Robinson.
2800
2801         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
2802
2803 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
2804
2805         [GTK][WK2] Add the WebKitBatteryProvider class
2806         https://bugs.webkit.org/show_bug.cgi?id=115720
2807
2808         Reviewed by Martin Robinson.
2809
2810         * gtk/generate-gtkdoc:
2811         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
2812
2813 2013-12-11  Mark Rowe  <mrowe@apple.com>
2814
2815         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
2816
2817         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
2818         to build and maintain this custom Perl module.
2819
2820         Reviewed by Anders Carlsson.
2821
2822         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
2823         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
2824         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
2825         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
2826         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
2827         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
2828         build DumpRenderTree.
2829         (dumpToolDidCrash): Stop importing and using the module.
2830         * Scripts/webkitpy/port/base.py:
2831         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
2832
2833 2013-12-11  Brendan Long  <b.long@cablelabs.com>
2834
2835         [GTK] Add "enable-mediasource" property to WebKitWebSettings
2836         https://bugs.webkit.org/show_bug.cgi?id=125566
2837
2838         Reviewed by Philippe Normand.
2839
2840         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2841         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
2842         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2843         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
2844
2845 2013-12-11  Dan Bernstein  <mitz@apple.com>
2846
2847         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
2848         https://bugs.webkit.org/show_bug.cgi?id=125579
2849
2850         Reviewed by Anders Carlsson.
2851
2852         * MiniBrowser/mac/WK2BrowserWindowController.m:
2853         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
2854         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
2855         activeURL property changes, update the URL field with its value.
2856         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
2857         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
2858         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
2859         Ditto.
2860         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
2861         Ditto.
2862         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
2863         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
2864
2865 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2866
2867         Fixed test-wepkitpy logging for buildslaves
2868         https://bugs.webkit.org/show_bug.cgi?id=125445
2869
2870         Reviewed by Csaba Osztrogonác.
2871
2872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2873         (RunPythonTests):
2874
2875 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2876
2877         Programmatically-inserted children lack accessibility events
2878         https://bugs.webkit.org/show_bug.cgi?id=100275
2879
2880         Reviewed by Chris Fleizach.
2881
2882         Update DRT and WebKitTestRunner to handle the children-changed
2883         signal properly, considering the detail and optional parameters.
2884
2885         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
2886         (axObjectEventListener):
2887         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
2888
2889 2013-12-03  Mark Rowe  <mrowe@apple.com>
2890
2891         <https://webkit.org/b/125139> Modernize the WebKit API headers
2892         <rdar://problem/15540175>
2893
2894         Reviewed by Anders Carlsson.
2895
2896         * DumpRenderTree/mac/TestRunnerMac.mm:
2897         (TestRunner::setCacheModel): Cast to the enum type.
2898
2899 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
2900
2901         Get rid of forward exit on DoubleAsInt32
2902         https://bugs.webkit.org/show_bug.cgi?id=125552
2903
2904         Reviewed by Oliver Hunt.
2905         
2906         Add some support for testing the generic (non-X86) paths on X86 by disabling
2907         architecture-specific optimizations (ASO's).
2908
2909         * Scripts/run-javascriptcore-tests:
2910         * Scripts/run-jsc-stress-tests:
2911
2912 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
2913
2914         Unreviewed EFL build fix attempt
2915
2916         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
2917         * WebKitTestRunner/CMakeLists.txt: Ditto.
2918
2919 2013-12-10  Anders Carlsson  <andersca@apple.com>
2920
2921         Add a HashMap constructor that takes an initializer list
2922         https://bugs.webkit.org/show_bug.cgi?id=125551
2923
2924         Reviewed by Dan Bernstein.
2925
2926         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2927         (TestWebKitAPI::TEST):
2928
2929 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
2930
2931         Use std::array when computing MD5 checksum
2932         https://bugs.webkit.org/show_bug.cgi?id=125509
2933
2934         Reviewed by Anders Carlsson.
2935
2936         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
2937
2938         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2939         (computeMD5HashStringForBitmapContext):
2940         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2941         (computeMD5HashStringForBitmapContext):
2942         * TestWebKitAPI/Tests/WTF/MD5.cpp:
2943         (TestWebKitAPI::expectMD5):
2944         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2945         (WTR::computeMD5HashStringForCairoSurface):
2946         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2947         (WTR::computeMD5HashStringForContext):
2948
2949 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2950
2951         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
2952         https://bugs.webkit.org/show_bug.cgi?id=125522
2953
2954         Reviewed by Chris Fleizach.
2955
2956         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
2957
2958         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2959         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2960
2961 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
2962
2963         Add --makeargs option to build-jsc
2964         https://bugs.webkit.org/show_bug.cgi?id=125344
2965
2966         Reviewed by Filip Pizlo.
2967
2968         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
2969
2970 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
2971
2972         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
2973         https://bugs.webkit.org/show_bug.cgi?id=125497
2974
2975         Reviewed by Mario Sanchez Prada.
2976
2977         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2978         (AccessibilityUIElement::stringForRange): Implemented.
2979         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2980         (WTR::AccessibilityUIElement::stringForRange): Implemented.
2981
2982 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
2983
2984         Various fixes for the CMake GTK+ build
2985
2986         Reviewed by Gustavo Noronha.
2987
2988         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
2989         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
2990
2991 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
2992
2993         --cloop option does not work in Tools/Scripts/build-jsc.
2994         https://bugs.webkit.org/show_bug.cgi?id=125214
2995
2996         Reviewed by Csaba Osztrogonác.
2997
2998         * Scripts/build-jsc:
2999
3000 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3001
3002         Merge mark_for_landing and mark_for_commit_queue into one argument
3003         https://bugs.webkit.org/show_bug.cgi?id=125448
3004
3005         Reviewed by Ryosuke Niwa.
3006
3007         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3008         (CommitQueueFlag):
3009         (Bugzilla._commit_queue_flag):
3010         (Bugzilla._fill_attachment_form):
3011         (Bugzilla.add_patch_to_bug):
3012         (Bugzilla.create_bug):
3013         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3014         (test_commit_queue_flag.assert_commit_queue_flag):
3015         (test_commit_queue_flag):
3016
3017 2013-12-09  Tim Horton  <timothy_horton@apple.com>
3018
3019         Remove dead extract_reference_link.py (and the reftests module)
3020         https://bugs.webkit.org/show_bug.cgi?id=125116
3021
3022         Reviewed by Ryosuke Niwa.
3023
3024         This code doesn't seem to have ever been used.
3025
3026         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
3027         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
3028         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
3029
3030 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3031
3032         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
3033         https://bugs.webkit.org/show_bug.cgi?id=125456
3034
3035         Reviewed by Chris Fleizach.
3036
3037         Return 'AXSection' for section roles instead of 'AXDiv'.
3038
3039         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3040         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3041
3042 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
3043
3044         check-webkit-style should check for extra newlines at EOF
3045         https://bugs.webkit.org/show_bug.cgi?id=125424
3046
3047         Reviewed by Darin Adler.
3048
3049         Report a style violation if extraneous newlines are added
3050         to the end of a C++ file. There should only be one newline at EOF.
3051
3052         * Scripts/webkitpy/style/checkers/cpp.py:
3053         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
3054         (check_for_extra_new_line_at_eof): Added.
3055         (_process_lines): Added new check and renamed existing EOF check.
3056         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3057         (CppStyleTest.test_extra_newlines_at_eof): Added.
3058         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
3059
3060 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
3061
3062         check-webkit-style: ternary operator in macro call identified as initialization list
3063         https://bugs.webkit.org/show_bug.cgi?id=125443
3064
3065         Reviewed by Ryosuke Niwa.
3066
3067         Do not match initialization list when questionmark is placed before :
3068
3069         * Scripts/webkitpy/style/checkers/cpp.py:
3070         (check_member_initialization_list):
3071
3072 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
3073
3074         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
3075         https://bugs.webkit.org/show_bug.cgi?id=125451
3076
3077         Reviewed by Mario Sanchez Prada.
3078
3079         Create the needed callbacks for DRT and WKTR.
3080
3081         * DumpRenderTree/AccessibilityUIElement.cpp:
3082         (characterAtOffsetCallback): added
3083         (wordAtOffsetCallback): added
3084         (lineAtOffsetCallback): added
3085         (sentenceAtOffsetCallback): added
3086         (AccessibilityUIElement::getJSClass):
3087         * DumpRenderTree/AccessibilityUIElement.h:
3088         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3089         (stringAtOffset): added
3090         (AccessibilityUIElement::characterAtOffset): added
3091         (AccessibilityUIElement::wordAtOffset): added
3092         (AccessibilityUIElement::lineAtOffset): added
3093         (AccessibilityUIElement::sentenceAtOffset): added
3094         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3095         (WTR::AccessibilityUIElement::characterAtOffset): added
3096         (WTR::AccessibilityUIElement::wordAtOffset): added
3097         (WTR::AccessibilityUIElement::lineAtOffset): added
3098         (WTR::AccessibilityUIElement::sentenceAtOffset): added
3099         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3100         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3101         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3102         (WTR::stringAtOffset): added
3103         (WTR::AccessibilityUIElement::characterAtOffset): added
3104         (WTR::AccessibilityUIElement::wordAtOffset): added
3105         (WTR::AccessibilityUIElement::lineAtOffset): added
3106         (WTR::AccessibilityUIElement::sentenceAtOffset): added
3107
3108 2013-12-08  Sam Weinig  <sam@webkit.org>
3109
3110         32-bit MiniBrowser doesn't build
3111         https://bugs.webkit.org/show_bug.cgi?id=125420
3112
3113         Reviewed by Dan Bernstein.
3114
3115         * MiniBrowser/mac/AppDelegate.h:
3116         * MiniBrowser/mac/AppDelegate.m:
3117         (-[BrowserAppDelegate init]):
3118         (-[BrowserAppDelegate applicationWillTerminate:]):
3119
3120 2013-12-08  Brian Holt  <brian.holt@samsung.com>
3121
3122         [WK2] Add ENABLE_NETWORK_PROCESS flag
3123         https://bugs.webkit.org/show_bug.cgi?id=125421
3124
3125         Add support to build with the Network Process enabled.
3126
3127         Reviewed by Martin Robinson.
3128
3129         * Scripts/webkitperl/FeatureList.pm:
3130
3131 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
3132
3133         Fold typedArray.length if typedArray is constant
3134         https://bugs.webkit.org/show_bug.cgi?id=125252
3135
3136         Reviewed by Sam Weinig.
3137         
3138         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
3139         should put tests that run just like JSRegress but don't run as part of LayoutTests.
3140         Currently I'm using it for tests that require some surgical support from jsc.cpp.
3141
3142         * Scripts/run-javascriptcore-tests:
3143
3144 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
3145
3146         [gdb] Update printers for WTF::CString, JSC::JSString
3147         https://bugs.webkit.org/show_bug.cgi?id=124600
3148
3149         Reviewed by Gustavo Noronha Silva.
3150
3151         Update the two printers after they fell behind the changes in implementation.
3152
3153         * gdb/webkit.py:
3154         (WTFCStringPrinter.to_string):
3155         (JSCJSStringPrinter.to_string):
3156
3157 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
3158
3159         [webkitpy] Add a WestonDriver unit test
3160         https://bugs.webkit.org/show_bug.cgi?id=125408
3161
3162         Reviewed by Gustavo Noronha Silva.
3163
3164         Add a webkitpy unit test for the Weston driver.
3165
3166         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
3167         (WestonDriverTest):
3168         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
3169         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
3170         the server environment contains proper WAYLAND and GDK_BACKEND entries.
3171         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
3172         the driver cleans up the temporary directory.
3173         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
3174         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
3175
3176 2013-12-08  Brendan Long  <b.long@cablelabs.com>
3177
3178         [Gtk] install-dependencies doesn't install libgtk-3-dev
3179         https://bugs.webkit.org/show_bug.cgi?id=125320
3180
3181         Reviewed by Gustavo Noronha Silva.
3182
3183         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
3184
3185 2013-12-07  Sam Weinig  <sam@webkit.org>
3186
3187         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
3188         https://bugs.webkit.org/show_bug.cgi?id=125401
3189
3190         Reviewed by Dan Bernstein.
3191
3192         * MiniBrowser/mac/WK2BrowserWindowController.m:
3193         (-[WK2BrowserWindowController fetch:]):
3194         (-[WK2BrowserWindowController reload:]):
3195         (-[WK2BrowserWindowController goBack:]):
3196         (-[WK2BrowserWindowController goForward:]):
3197         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3198         (-[WK2BrowserWindowController currentZoomFactor]):
3199         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3200         (-[WK2BrowserWindowController zoomIn:]):
3201         (-[WK2BrowserWindowController zoomOut:]):
3202         (-[WK2BrowserWindowController canResetZoom]):
3203         (-[WK2BrowserWindowController resetZoom:]):
3204         (-[WK2BrowserWindowController toggleZoomMode:]):
3205         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
3206
3207 2013-12-07  Sam Weinig  <sam@webkit.org>
3208
3209         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
3210         https://bugs.webkit.org/show_bug.cgi?id=125400
3211
3212         Reviewed by Dan Bernstein.
3213
3214         * MiniBrowser/mac/AppDelegate.h:
3215         * MiniBrowser/mac/AppDelegate.m:
3216         * MiniBrowser/mac/WK2BrowserWindowController.h:
3217         * MiniBrowser/mac/WK2BrowserWindowController.m:
3218         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
3219         (-[WK2BrowserWindowController dealloc]):
3220         (createNewPage):
3221         (-[WK2BrowserWindowController awakeFromNib]):
3222         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
3223         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
3224         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
3225         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
3226         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
3227         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
3228
3229 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
3230
3231         [GTK] Run each gtest subtest separately instead of in one go
3232         https://bugs.webkit.org/show_bug.cgi?id=125386
3233
3234         Reviewed by Martin Robinson.
3235
3236         This is what other ports are doing (except they build each test as a separate binary)
3237         and will help with the timeouts we sometimes hit because it applies to the full test
3238         run.
3239
3240         * Scripts/run-gtk-tests:
3241         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
3242         (TestRunner._run_google_test): run a single subtest from a gtest binary.
3243         (TestRunner._run_google_test_suite): call the binary once per subtest.
3244
3245 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3246
3247         Move PrettyPatch related code to prettypatch.py
3248         https://bugs.webkit.org/show_bug.cgi?id=124937
3249
3250         Reviewed by Ryosuke Niwa.
3251
3252         This code seems to have a better place here than in Port, since PrettyPatch already knows
3253         pretty_patch_path, and this also unifies the usage of PrettyPatch
3254
3255         * Scripts/webkitpy/common/prettypatch.py:
3256         (PrettyPatch.__init__):
3257         (PrettyPatch.pretty_diff):
3258         (PrettyPatch):
3259         (PrettyPatch.pretty_patch_available):
3260         (PrettyPatch.check_pretty_patch):
3261         (PrettyPatch.pretty_patch_text):
3262         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3263         (TestResultWriter.create_text_diff_and_write_result):
3264         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3265         (summarize_results):
3266         * Scripts/webkitpy/port/base.py:
3267         (Port.__init__):
3268         (Port.wdiff_available):
3269         (Port.check_image_diff):
3270         (Port.wdiff_text):
3271         * Scripts/webkitpy/port/base_unittest.py:
3272         (PortTest.test_pretty_patch_os_error):
3273         (PortTest.test_pretty_patch_script_error):
3274
3275 2013-12-06  Dan Bernstein  <mitz@apple.com>
3276
3277         [Mac] MiniBrowser Debug builds are compiled with -Os
3278         https://bugs.webkit.org/show_bug.cgi?id=125376
3279
3280         Reviewed by Tim Horton.
3281
3282         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
3283         the Debug configuration at the project level.
3284
3285 2013-12-06  Jer Noble  <jer.noble@apple.com>
3286
3287         [MSE] Add a runtime-setting for the MediaSource constructor.
3288         https://bugs.webkit.org/show_bug.cgi?id=125336
3289
3290         Reviewed by Eric Carlson.
3291
3292         Enable MediaSource in DRT and WKTR.
3293
3294         * DumpRenderTree/mac/DumpRenderTree.mm:
3295         (resetWebPreferencesToConsistentValues):
3296         * WebKitTestRunner/TestController.cpp:
3297         (WTR::TestController::resetPreferencesToConsistentValues):
3298
3299 2013-12-06  Jer Noble  <jer.noble@apple.com>
3300
3301         Strip out extraneous logging from AppleGVA in media tests.
3302         https://bugs.webkit.org/show_bug.cgi?id=125357
3303
3304         Reviewed by Simon Fraser.
3305
3306         Add a mechanism for stripping out abritrary regular expressions from test input and output.
3307
3308         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3309         (SingleTestRunner._run_compare_test): Strip out logging
3310         * Scripts/webkitpy/port/base.py:
3311         (Port.logging_patterns_to_strip): Return an empty list by default.
3312         * Scripts/webkitpy/port/driver.py:
3313         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
3314         * Scripts/webkitpy/port/mac.py:
3315         (MacPort.logging_patterns_to_strip): Return a complete list.
3316
3317 2013-12-06  Dean Jackson  <dino@apple.com>
3318
3319         Updating ANGLE should point to instructions
3320         https://bugs.webkit.org/show_bug.cgi?id=125361
3321
3322         Reviewed by Eric Carlson.
3323
3324         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
3325         someone wants to patch ANGLE.
3326
3327         * Scripts/webkitpy/common/config/watchlist:
3328
3329 2013-12-06  Dan Bernstein  <mitz@apple.com>
3330
3331         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
3332         https://bugs.webkit.org/show_bug.cgi?id=125334
3333
3334         Reviewed by Darin Adler.
3335
3336         * MiniBrowser/mac/WK2BrowserWindowController.m:
3337         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
3338         title property.
3339         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
3340         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
3341         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
3342         window title with the title property changes.
3343         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
3344         set the load delegate instead of the load client.
3345         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
3346         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
3347         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
3348         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
3349         Implemented this load delegate method.
3350         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
3351         Ditto.
3352         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
3353         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
3354         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
3355         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
3356         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
3357         Ditto.
3358         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
3359         Ditto.
3360         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
3361
3362 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3363
3364         Remove function from style/checkers/cpp.py.
3365         https://bugs.webkit.org/show_bug.cgi?id=125341
3366
3367         Reviewed by Darin Adler.
3368
3369         Corrects a FIXME: by removing a function from cpp.py.
3370
3371         * Scripts/webkitpy/style/checkers/cpp.py:
3372         (CppChecker.__init__):
3373         (CppChecker.check):
3374         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3375         (CppStyleTestBase.process_file_data):
3376
3377 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3378
3379         check-webkit-style: false positive warning for indentation of #ifdef code.
3380         https://bugs.webkit.org/show_bug.cgi?id=125254
3381
3382         Reviewed by Darin Adler.
3383
3384         * Scripts/webkitpy/style/checkers/cpp.py:
3385         (check_member_initialization_list):
3386         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3387         (WebKitStyleTest.test_member_initialization_list):
3388
3389 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
3390
3391         Fix spelling error in style checker: beggining
3392         https://bugs.webkit.org/show_bug.cgi?id=125347
3393
3394         Reviewed by Anders Carlsson.
3395
3396         * Scripts/webkitpy/style/checkers/cpp.py:
3397         (check_member_initialization_list):
3398         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3399         (WebKitStyleTest.test_member_initialization_list):
3400
3401 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
3402
3403         [ATK] Missing aria roles mappings
3404         https://bugs.webkit.org/show_bug.cgi?id=117729
3405
3406         Reviewed by Mario Sanchez Prada.
3407
3408         Added new mappings to AccessibilityUIElementAtk.cpp.
3409
3410         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3411         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3412
3413 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
3414
3415         Typo fix after r160218.
3416
3417         * Scripts/webkitpy/test/main.py:
3418         (main):
3419
3420 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
3421
3422         Unreviewed fix after r160206.
3423
3424         * Scripts/webkitpy/test/main.py:
3425         (main): sys.platform can be win32 or cygwin too on Windows.
3426
3427 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
3428
3429         Disable WebKit2 webkitpy unittests on Windows
3430         https://bugs.webkit.org/show_bug.cgi?id=125318
3431
3432         Reviewed by Ryosuke Niwa.
3433
3434         * Scripts/webkitpy/test/main.py:
3435         (main):
3436
3437 2013-12-05  Anders Carlsson  <andersca@apple.com>
3438
3439         Tweak WeakObjCPtr
3440         https://bugs.webkit.org/show_bug.cgi?id=125311
3441
3442         Reviewed by Darin Adler.
3443
3444         Split up tests into more logical groups. Add new tests for new functionality.
3445
3446         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
3447
3448 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3449
3450         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
3451         https://bugs.webkit.org/show_bug.cgi?id=125302
3452
3453         Reviewed by Philippe Normand.
3454
3455         * gtk/generate-webkitdom-doc-files:
3456         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
3457         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
3458         and WEBKIT_DEPRECATED_FOR macros.
3459
3460 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
3461
3462         Fix cross compilation on x86
3463         https://bugs.webkit.org/show_bug.cgi?id=125295
3464
3465         Reviewed by Zoltan Herczeg.
3466
3467         Certain compiler flags should not be added when cross compilation is enabled.
3468
3469         * Scripts/webkitdirs.pm:
3470         (runAutogenForAutotoolsProjectIfNecessary):
3471         (generateBuildSystemFromCMakeProject):
3472
3473 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3474
3475         Remove duplicated/dead code from cpp style checker unit tests.
3476         https://bugs.webkit.org/show_bug.cgi?id=125226
3477
3478         Reviewed by Ryosuke Niwa.
3479
3480         Remove the first definition of OrderOfIncludesTest class as it is
3481         overwritten by the second. Remove a duplicated assert statement
3482         from the second class.
3483
3484         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3485         (OrderOfIncludesTest.setUp):
3486         (OrderOfIncludesTest.test_try_drop_common_suffixes):
3487           The last assert was duplicated.
3488
3489 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
3490
3491         Remove Scripts/generate-qt-inspector-resource.
3492         https://bugs.webkit.org/show_bug.cgi?id=125288
3493
3494         Reviewed by Andreas Kling.
3495
3496         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
3497         We don't need this file.
3498
3499 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3500
3501         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
3502         https://bugs.webkit.org/show_bug.cgi?id=125218
3503
3504         Reviewed by Ryosuke Niwa.
3505
3506         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3507         (LayoutTestFinder.skip_tests):
3508         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3509         (LayoutTestRunner.run_tests):
3510         (LayoutTestRunner._update_summary_with_result):
3511         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3512         (Manager._test_is_slow):
3513         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3514         (JSONLayoutResultsGenerator._insert_failure_summaries):
3515         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3516         (TestExpectations.get_rebaselining_failures):
3517         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3518         (assert_exp):
3519         (MiscTests.test_multiple_results):
3520         (MiscTests.test_category_expectations):
3521         (MiscTests.test_get_modifiers):
3522         (MiscTests.test_get_expectations_string):
3523         (MiscTests.test_expectation_to_string):
3524         (MiscTests.test_get_test_set):
3525         (MiscTests.test_more_specific_override_resets_skip):
3526         (SkippedTests.check):
3527         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3528         (TestRunResults.__init__):
3529         (summarize_results):
3530         * Scripts/webkitpy/tool/commands/rebaseline.py:
3531         (RebaselineExpectations._tests_to_rebaseline):
3532
3533 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
3534
3535         Enable HTMLTemplateElement by default
3536         https://bugs.webkit.org/show_bug.cgi?id=123851
3537
3538         Reviewed by Antti Koivisto.
3539
3540         * Scripts/webkitperl/FeatureList.pm:
3541
3542 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
3543
3544         [EFL] Bumping GStreamer version to 1.2.1
3545         https://bugs.webkit.org/show_bug.cgi?id=125155
3546
3547         Reviewed by Gyuyoung Kim.
3548
3549         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
3550
3551
3552 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3553
3554         Update jhbuild revision.
3555         https://bugs.webkit.org/show_bug.cgi?id=124966
3556         
3557         Reviewed by Gyuyoung Kim.
3558
3559         Used version of Jhbuild failed to create directories and caused
3560         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
3561
3562         * jhbuild/jhbuild-wrapper:
3563
3564 2013-12-04  Anders Carlsson  <andersca@apple.com>
3565
3566         Add a WeakObjCPtr class
3567         https://bugs.webkit.org/show_bug.cgi?id=125267
3568
3569         Reviewed by Geoffrey Garen.
3570
3571         Add API tests for WeakObjCPtr.
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
3575         (TEST):
3576
3577 2013-12-04  Anders Carlsson  <andersca@apple.com>
3578
3579         Make the estimatedProgress property observable using KVO
3580         https://bugs.webkit.org/show_bug.cgi?id=125259
3581
3582         Reviewed by Dan Bernstein.
3583
3584         Bind the progress indicator value to the "estimatedProgress" property.
3585
3586         * MiniBrowser/mac/WK2BrowserWindowController.m:
3587         (-[WK2BrowserWindowController dealloc]):
3588         (-[WK2BrowserWindowController awakeFromNib]):
3589
3590 2013-12-04  Anders Carlsson  <andersca@apple.com>
3591
3592         Add a loading property to WKBrowsingContextController
3593         https://bugs.webkit.org/show_bug.cgi?id=125256
3594
3595         Reviewed by Dan Bernstein.
3596
3597         Bind the progress indicator visibility to the "loading" property.
3598
3599         * MiniBrowser/mac/WK2BrowserWindowController.m:
3600         (-[WK2BrowserWindowController dealloc]):
3601         (-[WK2BrowserWindowController awakeFromNib]):
3602         (-[WK2BrowserWindowController didStartProgress]):
3603         (-[WK2BrowserWindowController didFinishProgress]):
3604
3605 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
3606
3607         [EFL][WK2] Buildfix after r160104
3608         https://bugs.webkit.org/show_bug.cgi?id=125231
3609
3610         Reviewed by Anders Carlsson.
3611
3612         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
3613         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
3614         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3615         (TestWebKitAPI::setViewClient): Ditto.
3616
3617 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
3618
3619         check-webkit-style detected some ternary statements as initialization lists
3620         https://bugs.webkit.org/show_bug.cgi?id=125246
3621
3622         Reviewed by Dean Jackson.
3623
3624         The regular expression that check-webkit-tests uses to detect initialization
3625         lists was too broad, resulting in false positives. This patch makes the
3626         regex more specific
3627
3628         * Scripts/webkitpy/style/checkers/cpp.py:
3629         (check_member_initialization_list):
3630         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3631         (WebKitStyleTest.test_member_initialization_list):
3632
3633 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
3634
3635         run-jsc-stress-tests can only run locally
3636         https://bugs.webkit.org/show_bug.cgi?id=124551
3637
3638         Reviewed by Filip Pizlo.
3639
3640         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
3641         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
3642         added a couple more signals to handle gracefully at shutdown. 
3643         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
3644         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
3645         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
3646         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
3647         toward the end of the script to make it easier to tell which of the various modes do what.
3648
3649 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
3650
3651         [EFL][WK2] Buildfix after r160104
3652         https://bugs.webkit.org/show_bug.cgi?id=125233
3653
3654         Reviewed by Anders Carlsson.
3655
3656         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
3657         (TestWebKitAPI::TEST):
3658         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3659         (TestWebKitAPI::setPageLoaderClient):
3660
3661 2013-12-03  Anders Carlsson  <andersca@apple.com>
3662
3663         Deprecate all unversioned client structs in favor of having explicit versioned structs
3664         https://bugs.webkit.org/show_bug.cgi?id=125203
3665
3666         Reviewed by Dan Bernstein.
3667
3668         Update for WebKit2 API changes.
3669
3670         * MiniBrowser/mac/AppDelegate.m:
3671         (-[BrowserAppDelegate init]):
3672         * MiniBrowser/mac/WK2BrowserWindowController.m:
3673         (-[WK2BrowserWindowController awakeFromNib]):
3674         * TestWebKitAPI/InjectedBundleController.cpp:
3675         (TestWebKitAPI::InjectedBundleController::initialize):
3676         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3677         (TestWebKitAPI::TEST):
3678         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3679         (TestWebKitAPI::setInjectedBundleClient):
3680         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
3681         (TestWebKitAPI::TEST):
3682         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3683         (TestWebKitAPI::TEST):
3684         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3685         (TestWebKitAPI::TEST):
3686         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3687         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
3688         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
3689         (TestWebKitAPI::TEST):
3690         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3691         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
3692         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
3693         (TestWebKitAPI::setInjectedBundleClient):
3694         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
3695         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
3696         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
3697         (TestWebKitAPI::TEST):
3698         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3699         (TestWebKitAPI::TEST):
3700         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3701         (TestWebKitAPI::setContextDownloadClient):
3702         (TestWebKitAPI::setPagePolicyClient):
3703         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3704         (TestWebKitAPI::TEST):
3705         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3706         (TestWebKitAPI::TEST):
3707         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3708         (TestWebKitAPI::TEST):
3709         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3710         (TestWebKitAPI::TEST):
3711         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3712         (TestWebKitAPI::TEST):
3713         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3714         (TestWebKitAPI::TEST):
3715         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3716         (TestWebKitAPI::setupGeolocationProvider):
3717         (TestWebKitAPI::setupView):
3718         (TestWebKitAPI::TEST):
3719         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
3720         (TestWebKitAPI::TEST):
3721         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3722         (TestWebKitAPI::setPageLoaderClient):
3723         (TestWebKitAPI::setInjectedBundleClient):
3724         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3725         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3726         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3727         (TestWebKitAPI::TEST):
3728         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
3729         (TestWebKitAPI::setInjectedBundleClient):
3730         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
3731         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
3732         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
3733         (TestWebKitAPI::TEST):
3734         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
3735         (TestWebKitAPI::TEST):
3736         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3737         (TestWebKitAPI::TEST):
3738         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
3739         (TestWebKitAPI::TEST):
3740         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
3741         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
3742         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
3743         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3744         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3745         (TestWebKitAPI::setPageLoaderClient):
3746         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3747         (TestWebKitAPI::setPageLoaderClient):
3748         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3749         (TestWebKitAPI::setPageLoaderClient):
3750         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3751         (TestWebKitAPI::setPageLoaderClient):
3752         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3753         (TestWebKitAPI::setPageLoaderClient):
3754         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3755         (TestWebKitAPI::TEST):
3756         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3757         (TestWebKitAPI::TEST):
3758         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
3759         (TestWebKitAPI::setInjectedBundleClient):
3760         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
3761         (TestWebKitAPI::ParentFrameTest::didCreatePage):
3762         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
3763         (TestWebKitAPI::setInjectedBundleClient):
3764         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
3765         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
3766         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3767         (TestWebKitAPI::TEST):
3768         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
3769         (TestWebKitAPI::TEST):
3770         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3771         (TestWebKitAPI::TEST):
3772         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
3773         (TestWebKitAPI::TEST):
3774         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3775         (TestWebKitAPI::setInjectedBundleClient):
3776         (TestWebKitAPI::setPageLoaderClient):
3777         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3778         (TestWebKitAPI::setPageLoaderClient):
3779         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3780         (TestWebKitAPI::TEST):
3781         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
3782         (TestWebKitAPI::setPageLoaderClient):
3783         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
3784         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
3785         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3786         (TestWebKitAPI::TEST):
3787         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
3788         (TestWebKitAPI::TEST):
3789         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
3790         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
3791         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3792         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
3793         (TestWebKitAPI::TEST):
3794         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
3795         (TestWebKitAPI::WKConnectionTest::initialize):
3796         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
3797         (TestWebKitAPI::setPageLoaderClient):
3798         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3799         (TestWebKitAPI::setInjectedBundleClient):
3800         (TestWebKitAPI::TEST):
3801         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
3802         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
3803         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3804         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
3805         (TestWebKitAPI::setInjectedBundleClient):
3806         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
3807         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
3808         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
3809         (TestWebKitAPI::TEST):
3810         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3811         (TestWebKitAPI::setInjectedBundleClient):
3812         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3813         (TestWebKitAPI::TEST):
3814         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
3815         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
3816         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
3817         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3818         (TestWebKitAPI::didCreateConnection):
3819         (TestWebKitAPI::TEST):
3820         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3821         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3822         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
3823         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3824         (TestWebKitAPI::setPageLoaderClient):
3825         * WebKitTestRunner/GeolocationProviderMock.cpp:
3826         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3827         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3828         (WTR::InjectedBundle::initialize):
3829         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3830         (WTR::InjectedBundlePage::InjectedBundlePage):
3831         * WebKitTestRunner/TestController.cpp:
3832         (WTR::TestController::createOtherPage):
3833         (WTR::TestController::initialize):
3834         (WTR::TestController::createWebViewWithOptions):
3835
3836 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3837
3838         Style checker for .messages.in files (WTF:: prefix)
3839         https://bugs.webkit.org/show_bug.cgi?id=125142
3840
3841         Reviewed by Anders Carlsson.
3842
3843         A new style checker for .messages.in files, that checks for the use of WTF::
3844         prefix in these files. (Also checks for tabs as these files were previously
3845         handled as text files.)
3846
3847         * Scripts/webkitpy/style/checker.py:
3848         (CheckerDispatcher._create_checker):
3849           New checker is returned for .messages.in files.
3850         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
3851           The new style checker class.
3852         (MessagesInChecker):
3853         (MessagesInChecker.__init__):
3854         (MessagesInChecker.check):
3855         (MessagesInChecker.check_WTF_prefix):
3856         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
3857           Unit test for the new style  checker class.
3858         (MessagesInCheckerStyleTestCase):
3859         (test_checker):
3860         (test_checker.error_handler_for_test):
3861         (MessagesInCheckerTestCase):
3862         (MessagesInCheckerTestCase.test_init):
3863         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
3864
3865 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3866
3867         Style checker requires alphabetical ordering in cmake lists even it contains variable.
3868         https://bugs.webkit.org/show_bug.cgi?id=124918
3869
3870         Reviewed by Csaba Osztrogonác.
3871
3872         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3873         (CMakeCheckerTest.test_check):
3874         * Scripts/webkitpy/style/checkers/cmake.py:
3875         (CMakeChecker._check_list_order):
3876         This will ignore lines with variable substitution.
3877
3878 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
3879
3880         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
3881         https://bugs.webkit.org/show_bug.cgi?id=124731
3882
3883         Reviewed by Zoltan Herczeg.
3884
3885         * Scripts/webkitpy/style/checkers/cpp.py:
3886         (check_spacing):
3887         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3888         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
3889
3890 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
3891
3892         Remove codecs and os dependencies from filereader.py in webkitpy/style.
3893         https://bugs.webkit.org/show_bug.cgi?id=124719
3894
3895         Although TextFileReader requires a FileSystem it circumvents it in two places!
3896         We should use the FileSystem only and remove codecs and os imports.
3897
3898         Reviewed by Zoltan Herczeg.
3899
3900         * Scripts/webkitpy/common/system/filesystem.py:
3901         (FileSystem.open_stdin): Moved from TextFileReader
3902         * Scripts/webkitpy/style/filereader.py:
3903         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
3904         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
3905
3906 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
3907
3908         check-webkit-style should check member initialization indentation.
3909         https://bugs.webkit.org/show_bug.cgi?id=124820
3910
3911         Reviewed by Zoltan Herczeg.
3912
3913         check-webkit-style should check member initialization indentation
3914         belongs to webkit coding style:
3915         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
3916
3917         * Scripts/webkitpy/style/checkers/cpp.py:
3918         (check_member_initialization_list): Add new method to check member
3919         initialization list.
3920         (check_style): Add the call of the new method.
3921         (check_language): Move self initialization checking into the new method.
3922         (CppChecker): Add a new category for initialization list.
3923         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3924         (CppStyleTest.test_runtime_selfinit):
3925         (CppStyleTest.test_deprecated_cast):
3926         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
3927         the new feature.
3928
3929 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
3930
3931         style-bot should reject Committer additions to committers.py
3932         https://bugs.webkit.org/show_bug.cgi?id=107574
3933
3934         Reviewed by Zoltan Herczeg.
3935
3936         The style check when executed in non-interactive mode (probably by a
3937         bot) will raise an additional error if the contributors.json file is
3938         modified. Non-interactive mode information is propagated to the
3939         Dispatcher, which creates a special JSON checker for the
3940         contributors.json file.
3941
3942         * Scripts/webkitpy/style/checker.py:
3943         (check_webkit_style_configuration):
3944         (CheckerDispatcher._create_checker):
3945         (CheckerDispatcher.dispatch):
3946         (StyleProcessorConfiguration.__init__):
3947         (StyleProcessor.process):
3948         * Scripts/webkitpy/style/checker_unittest.py:
3949         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
3950         (CheckerDispatcherDispatchTest.dispatch):
3951         (StyleProcessorConfigurationTest._style_checker_configuration):
3952         (StyleProcessor_EndToEndTest.test_init):
3953         (StyleProcessor_EndToEndTest.test_process):
3954         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
3955         (StyleProcessor_CodeCoverageTest.setUp):
3956         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3957         (JSONChecker.line_number_from_json_exception):
3958         (JSONContributorsChecker):
3959         (JSONContributorsChecker.check):
3960         * Scripts/webkitpy/style/error_handlers_unittest.py:
3961         (DefaultStyleErrorHandlerTest._style_checker_configuration):
3962         * Scripts/webkitpy/style/optparser.py:
3963         (CommandOptionValues.__init__):
3964         (ArgumentParser._create_option_parser):
3965         (ArgumentParser.parse):
3966         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3967         (test_post):
3968         (test_upload):
3969         * Scripts/webkitpy/tool/steps/checkstyle.py:
3970         (CheckStyle.run):
3971
3972 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
3973
3974         [EFL][WK2] Fix build after API::Client changes
3975         https://bugs.webkit.org/show_bug.cgi?id=125206
3976
3977         Reviewed by Csaba Osztrogonác.
3978
3979         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
3980         (TestWebKitAPI::TEST):
3981         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3982         (TestWebKitAPI::setViewClient):
3983
3984 2013-12-03  Dan Bernstein  <mitz@apple.com>
3985
3986         Fixed a test timing out after r160040.
3987
3988         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3989         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
3990         Updated for the delegate method rename.
3991
3992 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
3993
3994         REGRESSION: repro scripts disappear when you rerun tests
3995         https://bugs.webkit.org/show_bug.cgi?id=125184
3996
3997         Reviewed by Mark Hahnenberg.
3998         
3999         This bug made it difficult to quickly see if a test that recently failed is still
4000         failing while also running a new batch of tests.
4001
4002         Repro scripts are supposed to stay around until you delete them explicitly. This
4003         patch accomplishes that.
4004
4005         * Scripts/run-jsc-stress-tests:
4006
4007 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
4008
4009         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
4010         https://bugs.webkit.org/show_bug.cgi?id=125111
4011
4012         Reviewed by Filip Pizlo.
4013
4014         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
4015
4016         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
4017         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
4018
4019 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
4020
4021         Add a script to automatically configure a git clone
4022         https://bugs.webkit.org/show_bug.cgi?id=110073
4023
4024         Revert the change to use https for now since git.webkit.org is setup with http.
4025
4026         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4027         (SetupGitClone.execute):
4028
4029 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
4030
4031         Add a script to automatically configure a git clone
4032         https://bugs.webkit.org/show_bug.cgi?id=110073
4033
4034         Reviewed by Benjamin Poulain.
4035
4036         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
4037
4038         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
4039
4040         * Scripts/webkitpy/tool/commands/__init__.py:
4041         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
4042         (SetupGitClone):
4043         (SetupGitClone.execute):
4044
4045 2013-12-03  Anders Carlsson  <andersca@apple.com>
4046
4047         Deprecate WKNotificationProvider
4048         https://bugs.webkit.org/show_bug.cgi?id=125178
4049
4050         Reviewed by Sam Weinig.
4051
4052         Update for WebKit2 changes.
4053
4054         * WebKitTestRunner/TestController.cpp:
4055         (WTR::TestController::initialize):
4056         * WebKitTestRunner/WebNotificationProvider.cpp:
4057         (WTR::WebNotificationProvider::provider):
4058         * WebKitTestRunner/WebNotificationProvider.h:
4059
4060 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
4061
4062         [Win] Support 64-bit Application Support Libraries Location 
4063         https://bugs.webkit.org/show_bug.cgi?id=125179
4064
4065         Reviewed by Tim Horton.
4066
4067         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
4068         on Windows until an official distribution is available that properly creates registry settings
4069         to specify these locations.
4070
4071         * Scripts/webkitdirs.pm:
4072         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
4073         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
4074         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
4075         running 64-bit builds.
4076
4077 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
4078
4079         run-jsc-stress-tests only supports host environments that have make installed
4080         https://bugs.webkit.org/show_bug.cgi?id=124550
4081
4082         Reviewed by Darin Adler.
4083
4084         This might not be the case for all hosts, so this patch implements an alternate "backend" 
4085         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
4086         least somewhat competitive with the make-based test runner, the shell backend uses subshells
4087         run in the background to allow tests to run in parallel. Since the concurrency primitives 
4088         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
4089         of the make-based runner.
4090
4091         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
4092         the bundle and controls all of the parallel aspects of the shell-based test runner.
4093         * Scripts/run-jsc-stress-tests:
4094
4095 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
4096
4097         Remove function from TextChecker
4098         https://bugs.webkit.org/show_bug.cgi?id=125148
4099
4100         Reviewed by Darin Adler.
4101
4102         The process_file_data is used only from the unit tests, so it is simply moved there.
4103
4104         * Scripts/webkitpy/style/checkers/text.py:
4105         (TextChecker.check):
4106         * Scripts/webkitpy/style/checkers/text_unittest.py:
4107         (TextStyleTestCase.process_file_data):
4108         (TextStyleTestCase.assertNoError):
4109         (TextStyleTestCase.assertError):
4110
4111 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
4112
4113         Remove get_test() and reference test names directly instead.
4114         https://bugs.webkit.org/show_bug.cgi?id=124962
4115
4116         Reviewed by Csaba Osztrogonác.
4117
4118         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4119         (Base.__init__):
4120         (Base.get_basic_tests):
4121         (assert_exp):
4122         (MiscTests.test_multiple_results):
4123         (MiscTests.test_category_expectations):
4124         (MiscTests.test_get_modifiers):
4125         (MiscTests.test_get_expectations_string):
4126         (MiscTests.test_get_test_set):
4127         (MiscTests.test_parse_warning):
4128         (MiscTests.test_pixel_tests_flag.match):
4129
4130 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
4131
4132         Style Checker false pass.
4133         https://bugs.webkit.org/show_bug.cgi?id=112456
4134
4135         Reviewed by Csaba Osztrogonác.
4136
4137         * Scripts/webkitpy/style/checkers/changelog.py:
4138         (ChangeLogChecker.check_entry):
4139         simple regex fix to check "No new tests (...)."
4140         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
4141         (ChangeLogCheckerTest.test_no_new_tests):
4142
4143 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
4144
4145         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
4146         https://bugs.webkit.org/show_bug.cgi?id=125130
4147
4148         Reviewed by Geoffrey Garen.
4149
4150         * Scripts/run-jsc-stress-tests:
4151
4152 2013-12-02  Samuel White  <samuel_white@apple.com>
4153
4154         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
4155         https://bugs.webkit.org/show_bug.cgi?id=124561
4156
4157         Reviewed by Chris Fleizach.
4158
4159         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
4160
4161         * DumpRenderTree/AccessibilityUIElement.cpp:
4162         (uiElementCountForSearchPredicateCallback):
4163         (uiElementForSearchPredicateCallback):
4164         (AccessibilityUIElement::getJSClass):
4165         * DumpRenderTree/AccessibilityUIElement.h:
4166         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4167         (AccessibilityUIElement::uiElementCountForSearchPredicate):
4168         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4169         (AccessibilityUIElement::uiElementCountForSearchPredicate):
4170         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4171         (searchPredicateParameterizedAttributeForSearchCriteria):
4172         (AccessibilityUIElement::uiElementCountForSearchPredicate):
4173         (AccessibilityUIElement::uiElementForSearchPredicate):
4174         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4175         (AccessibilityUIElement::uiElementCountForSearchPredicate):
4176         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4177         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
4178         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4179         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4180         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4181         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
4182         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4183         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
4184         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
4185         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4186
4187 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
4188
4189         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
4190         https://bugs.webkit.org/show_bug.cgi?id=124714
4191
4192         Reviewed by Ryosuke Niwa.
4193
4194         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4195         (write_test_result):
4196         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4197         (TestFailure.write_failure):
4198         (FailureText):
4199         (FailureText.write_failure):
4200         (FailureAudio):
4201         (FailureAudio.write_failure):
4202         (FailureCrash.write_failure):
4203         (FailureMissingResult):
4204         (FailureTextMismatch):
4205         (FailureMissingImageHash.write_failure):
4206         (FailureMissingImage.write_failure):
4207         (FailureImageHashMismatch.write_failure):
4208         (FailureReftestMismatch.write_failure):
4209         (FailureReftestMismatchDidNotOccur.write_failure):
4210         (FailureMissingAudio):
4211         (FailureAudioMismatch):
4212
4213 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
4214
4215         Remove the stderr_write attribute from StyleProcessorConfiguration
4216         https://bugs.webkit.org/show_bug.cgi?id=124703
4217
4218         Reviewed by Ryosuke Niwa.
4219
4220         Remove the stderr_write attribute from this class in checker and
4221         replace its use with calls to a logging module logger. We Should 
4222         use logging module instead of writing to stderr directly.
4223
4224         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
4225         (check_webkit_style_configuration):
4226         (CheckerDispatcher.dispatch): Remove FIXME comment.
4227         (StyleProcessorConfiguration):
4228         (StyleProcessorConfiguration.__init__):
4229         (StyleProcessorConfiguration.write_style_error):
4230         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
4231         There is an "ERROR" prefix in log messiges from now.
4232         (StyleProcessorConfigurationTest):
4233         (StyleProcessorConfigurationTest._style_checker_configuration):
4234         (StyleProcessorConfigurationTest.test_init):
4235         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
4236         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
4237         (StyleProcessor_EndToEndTest.with):
4238         (StyleProcessor_EndToEndTest.test_init):
4239         (StyleProcessor_EndToEndTest.test_process):
4240         (StyleProcessor_CodeCoverageTest.setUp):
4241         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
4242         (DefaultStyleErrorHandler.__call__):