b99de12065aeffb3cf1ba1bb8fca9b7392802874
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
2
3         Remove uses of deprecated unittest.TestCase aliases
4         https://bugs.webkit.org/show_bug.cgi?id=102252
5
6         Reviewed by Adam Barth.
7
8         Replace the deprecated assertEquals method of the TestCase interface
9         used in some webkitpy unittests with the assertEqual method.
10
11         * Scripts/webkitpy/common/system/profiler_unittest.py:
12         (ProfilerFactoryTest._assert_default_profiler_name):
13         (ProfilerFactoryTest.test_default_profiler_output):
14         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
15         (GtkPortTest.test_expectations_files):
16         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
17         (TestHttpServer.test_win32_start_and_stop):
18
19 2013-01-22  Jer Noble  <jer.noble@apple.com>
20
21         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
22         https://bugs.webkit.org/show_bug.cgi?id=107562
23
24         Rubber-stamped by Alexy Proskuryakov.
25
26         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
27
28         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
29         (WTR::PlatformWebView::PlatformWebView):
30         (WTR::PlatformWebView::viewSupportsOptions):
31
32 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
33
34         One is not allowed to use commit-queue to make oneself a committer.
35
36         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
37
38 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
39
40         Add myself to commiters.py
41         https://bugs.webkit.org/show_bug.cgi?id=107546
42
43         Reviewed by Kentaro Hara.
44
45         * Scripts/webkitpy/common/config/committers.py:
46
47 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
48
49         [GTK] Implement TestRunner::setTextDirection
50         https://bugs.webkit.org/show_bug.cgi?id=107131
51
52         Reviewed by Philippe Normand.
53
54         * DumpRenderTree/gtk/DumpRenderTree.cpp:
55         (resetDefaultsToConsistentValues): Reset direction to default value.
56         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
57         (TestRunner::setTextDirection): Implement method using
58         gtk_widget_set_direction.
59
60 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
61
62         [chromium] move spell checking mocks to TestRunner library
63         https://bugs.webkit.org/show_bug.cgi?id=107455
64
65         Reviewed by Kent Tamura.
66
67         The content module doesn't provide its own WebSpellCheckClient.
68
69         * DumpRenderTree/DumpRenderTree.gypi:
70         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
71         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
72         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
73         (WebKit):
74         (WebTestRunner):
75         (WebTestProxyBase):
76         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
77         (WebTestRunner):
78         (WebTestRunner::makeMenuItemStringsFor):
79         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
80         (MockGrammarCheck::checkGrammarOfString):
81         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
82         (WebKit):
83         (MockGrammarCheck):
84         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
85         (MockSpellCheck::MockSpellCheck):
86         (MockSpellCheck::~MockSpellCheck):
87         (isNotASCIIAlpha):
88         (MockSpellCheck::spellCheckWord):
89         (MockSpellCheck::fillSuggestionList):
90         (MockSpellCheck::initializeIfNeeded):
91         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
92         (MockSpellCheck):
93         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
94         (WebTestRunner::SpellCheckClient::SpellCheckClient):
95         (WebTestRunner):
96         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
97         (WebTestRunner::SpellCheckClient::setDelegate):
98         (WebTestRunner::SpellCheckClient::spellCheck):
99         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
100         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
101         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
102         (WebTestRunner::SpellCheckClient::autoCorrectWord):
103         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
104         (WebTestRunner):
105         (SpellCheckClient):
106         (WebTestRunner::SpellCheckClient::taskList):
107         (WebTestRunner::SpellCheckClient::mockSpellCheck):
108         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
109         (TestDelegate):
110         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
111         (WebTestInterfaces::Internal):
112         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
113         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
114         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
115         (WebTestRunner::WebTestProxyBase::setDelegate):
116         (WebTestRunner::WebTestProxyBase::spellCheckClient):
117         (WebTestRunner):
118         * DumpRenderTree/chromium/WebViewHost.cpp:
119         (WebViewHost::WebViewHost):
120         (WebViewHost::setWebWidget):
121         * DumpRenderTree/chromium/WebViewHost.h:
122         (WebViewHost):
123
124 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
125
126         [EFL] Adds Accessibility support to wk1
127         https://bugs.webkit.org/show_bug.cgi?id=107440
128
129         Reviewed by Gyuyoung Kim.
130
131         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
132
133 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
134
135         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
136         https://bugs.webkit.org/show_bug.cgi?id=107506
137
138         Reviewed by Dan Bernstein.
139
140         * MiniBrowser/mac/WK1BrowserWindowController.m:
141         (-[WK1BrowserWindowController dealloc]):
142
143 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
144
145         Add build flag for Canvas's Path object (disabled by default)
146         https://bugs.webkit.org/show_bug.cgi?id=107473
147
148         Reviewed by Dean Jackson.
149
150         Add CANVAS_PATH build flag to build systems.
151
152         * Scripts/webkitperl/FeatureList.pm:
153
154 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
155
156         [EFL][WK2] Add APIs to set/get view source mode
157         https://bugs.webkit.org/show_bug.cgi?id=106633
158
159         Reviewed by Gyuyoung Kim.
160
161         Added a shotcut 'F8' in Minibrowser to display a source code
162         of the web page in a new window.
163
164        * MiniBrowser/efl/main.c:
165         (on_key_down):
166         (on_window_create):
167         (window_create):
168         (elm_main):
169
170 2013-01-21  Nico Weber  <thakis@chromium.org>
171
172         [chromium] Don't archive generated source files.
173         https://bugs.webkit.org/show_bug.cgi?id=106736
174
175         Reviewed by Eric Seidel.
176
177         They shouldn't be needed to run tests. They don't need a lot of space,
178         but add many lines to the "extracting" stdout. This attempts to reduce
179         that noise a bit.
180
181         * BuildSlaveSupport/built-product-archive:
182         (archiveBuiltProduct):
183
184 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
185
186         Mac DumpRenderTree's installSignalHandlers() is unreachable code
187         https://bugs.webkit.org/show_bug.cgi?id=107383
188
189         Reviewed by Sam Weinig.
190
191         The CrashHandler of DumpRenderTree were originally used for restoring
192         the color profile of the main display even if DRT crashes.
193
194         That feature was later limited to pixel tests only in r29999.
195
196         In r104351, the DRT was changed to use device color space. Making the crash
197         handlers useless, but they were left in the code since the error reporting
198         code was still reachable.
199
200         Later, r124581 refactored the code and dumpPixelsForCurrentTest
201         is being used before being assigned its value.
202         This did cause any regression because the code had become useless with the previous change.
203
204         * DumpRenderTree/mac/DumpRenderTree.mm:
205         Remove crashHandler() and installSignalHandlers() as they have become useless and
206         have been unreachable code for 6 months.
207         (dumpRenderTree):
208         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
209         at those points.
210
211 2013-01-21  Nico Weber  <thakis@chromium.org>
212
213         Make ninja the default build system for build-webkit --chromium on mac
214         https://bugs.webkit.org/show_bug.cgi?id=106737
215
216         Reviewed by Eric Seidel.
217
218         * Scripts/update-webkit-chromium:
219
220 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
221
222         Regression(r140262): Causes a lot of flakiness
223         https://bugs.webkit.org/show_bug.cgi?id=107454
224
225         Reviewed by Alexey Proskuryakov.
226
227         r140262 introduced a lot of flakiness due to fixed layout mode
228         not getting disabled on the view after being enabled for
229         specific test cases. This patch makes sure fixed layout mode
230         properly gets reset in WebKitTestRunner to avoid flakiness.
231
232         * WebKitTestRunner/TestInvocation.cpp:
233         (WTR::updateLayoutType):
234
235 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
236
237         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
238         https://bugs.webkit.org/show_bug.cgi?id=107421
239
240         Unreviewed build fix.
241
242         * Scripts/run-gtk-tests:
243         (TestRunner): skip Resource tests.
244
245 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
246
247         [EFL][WKTR] platformRunUntil() should keep the main loop running
248         https://bugs.webkit.org/show_bug.cgi?id=107442
249
250         Reviewed by Noam Rosenthal.
251
252         EFL's implementation of platformRunUntil() should keep the main loop
253         running and avoid calling sleep() between calls to
254         ecore_main_loop_iterate(). This call to sleep seems to be a source
255         of deadlocks (see Bug 106884).
256
257         * WebKitTestRunner/efl/TestControllerEfl.cpp:
258         (WTR::TestController::platformRunUntil):
259
260 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
261
262         QtTestBrowser should provide way to clear selected elements
263         https://bugs.webkit.org/show_bug.cgi?id=107437
264
265         Reviewed by Simon Hausmann.
266
267         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
268         Invoke the clearSelection prior to highlighting new elements.
269
270         * QtTestBrowser/launcherwindow.cpp:
271         (ElementHighlight):
272         (LauncherWindow::createChrome):
273         (LauncherWindow::selectElements):
274         (LauncherWindow::clearSelection):
275         * QtTestBrowser/launcherwindow.h:
276         (LauncherWindow):
277
278 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
279
280         [chromium] move methods interacting with willSendRequest to TestRunner
281         https://bugs.webkit.org/show_bug.cgi?id=107270
282
283         Reviewed by Kent Tamura.
284
285         * DumpRenderTree/chromium/DRTTestRunner.cpp:
286         (DRTTestRunner::DRTTestRunner):
287         (DRTTestRunner::waitForPolicyDelegate):
288         * DumpRenderTree/chromium/DRTTestRunner.h:
289         (DRTTestRunner):
290         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
291         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
292         (WebTestRunner::WebTestRunner::httpHeadersToClear):
293         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
294         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
295         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
296         (WebTestRunner::TestRunner::TestRunner):
297         (WebTestRunner::TestRunner::reset):
298         (WebTestRunner::TestRunner::httpHeadersToClear):
299         (WebTestRunner):
300         (WebTestRunner::TestRunner::shouldBlockRedirects):
301         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
302         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
303         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
304         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
305         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
306         (TestRunner):
307         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
308         (WebTestRunner::WebTestProxyBase::willSendRequest):
309         * DumpRenderTree/chromium/WebViewHost.cpp:
310         (WebViewHost::willSendRequest):
311         (WebViewHost::reset):
312         * DumpRenderTree/chromium/WebViewHost.h:
313         (WebViewHost):
314
315 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
316
317         [GTK] Stop building WebKit2 on GTK EWSs
318         https://bugs.webkit.org/show_bug.cgi?id=107435
319
320         Reviewed by Philippe Normand.
321
322         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
323         so stop building it on GTK EWSs.
324
325         * Scripts/webkitpy/common/config/ports.py:
326         (GtkPort.build_webkit_command):
327         * Scripts/webkitpy/common/config/ports_unittest.py:
328         (DeprecatedPortTest.test_gtk_port):
329
330 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
331
332         MediaStream API: Update the RTCPeerConnection states to match the latest specification
333         https://bugs.webkit.org/show_bug.cgi?id=107120
334
335         Reviewed by Adam Barth.
336
337         Updating mock to use the new states.
338
339         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
340         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
341         (MockWebRTCPeerConnectionHandler::initialize):
342         (MockWebRTCPeerConnectionHandler::updateICE):
343
344 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
345
346         Extend diff_parser to support the --full-index output.
347         https://bugs.webkit.org/show_bug.cgi?id=107408
348
349         Reviewed by Maciej Stachowiak.
350
351         * Scripts/webkitpy/common/checkout/diff_parser.py:
352         (git_diff_to_svn_diff):
353         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
354         (DiffParserTest):
355         (DiffParserTest.test_git_diff_to_svn_diff):
356         (git_diff_to_svn_diff):
357
358 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
359
360         Dragging over an element with scrollbars should scroll the element when dragging near edges
361         https://bugs.webkit.org/show_bug.cgi?id=39725
362
363         Reviewed by Hajime Morita.
364
365         This patch introduces canceling drag-and-drop by escape key for testing
366         behavior after cancellation drag-and-drop.
367
368         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
369         (WebTestRunner):
370         (WebTestRunner::EventSender::doMouseUp):
371         (WebTestRunner::EventSender::finishDragAndDrop):
372         (WebTestRunner::EventSender::keyDown):
373         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
374         (EventSender):
375         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
376
377 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
378
379         [chromium] move frame generation related methods to TestRunner
380         https://bugs.webkit.org/show_bug.cgi?id=107268
381
382         Reviewed by Adam Barth.
383
384         * DumpRenderTree/chromium/DRTTestRunner.cpp:
385         (DRTTestRunner::DRTTestRunner):
386         (DRTTestRunner::setWillSendRequestReturnsNull):
387         * DumpRenderTree/chromium/DRTTestRunner.h:
388         (DRTTestRunner):
389         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
390         (WebTestRunner::WebTestDelegate::display):
391         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
392         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
393         (WebTestRunner::TestRunner::TestRunner):
394         (WebTestRunner::TestRunner::display):
395         (WebTestRunner):
396         (WebTestRunner::TestRunner::displayInvalidatedRegion):
397         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
398         (TestRunner):
399         * DumpRenderTree/chromium/WebViewHost.cpp:
400         (WebViewHost::display):
401         (WebViewHost::displayInvalidatedRegion):
402         * DumpRenderTree/chromium/WebViewHost.h:
403
404 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
405
406         [chromium] move speech related methods to TestRunner library
407         https://bugs.webkit.org/show_bug.cgi?id=107266
408
409         Reviewed by Adam Barth.
410
411         * DumpRenderTree/chromium/DRTTestRunner.cpp:
412         (DRTTestRunner::DRTTestRunner):
413         (DRTTestRunner::displayInvalidatedRegion):
414         * DumpRenderTree/chromium/DRTTestRunner.h:
415         (DRTTestRunner):
416         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
417         (WebTestDelegate):
418         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
419         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
420         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
421         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
422         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
424         (WebTestRunner::TestRunner::TestRunner):
425         (WebTestRunner):
426         (WebTestRunner::TestRunner::addMockSpeechInputResult):
427         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
428         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
429         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
430         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
431         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
432         (TestRunner):
433         * DumpRenderTree/chromium/WebViewHost.cpp:
434         (WebViewHost::addMockSpeechInputResult):
435         (WebViewHost::setMockSpeechInputDumpRect):
436         (WebViewHost::addMockSpeechRecognitionResult):
437         (WebViewHost::setMockSpeechRecognitionError):
438         (WebViewHost::wasMockSpeechRecognitionAborted):
439         * DumpRenderTree/chromium/WebViewHost.h:
440
441 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
442
443         [chromium] move notification related methods to TestRunner
444         https://bugs.webkit.org/show_bug.cgi?id=107269
445
446         Reviewed by Adam Barth.
447
448         * DumpRenderTree/chromium/DRTTestRunner.cpp:
449         (DRTTestRunner::DRTTestRunner):
450         * DumpRenderTree/chromium/DRTTestRunner.h:
451         (DRTTestRunner):
452         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
453         (WebTestDelegate):
454         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
455         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
456         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
457         (WebTestRunner::TestRunner::TestRunner):
458         (WebTestRunner):
459         (WebTestRunner::TestRunner::grantWebNotificationPermission):
460         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
461         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
462         (TestRunner):
463         * DumpRenderTree/chromium/WebViewHost.cpp:
464         (WebViewHost::grantWebNotificationPermission):
465         (WebViewHost::simulateLegacyWebNotificationClick):
466         * DumpRenderTree/chromium/WebViewHost.h:
467
468 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
469
470         [chromium] move geolocation related methods to TestRunner
471         https://bugs.webkit.org/show_bug.cgi?id=107267
472
473         Reviewed by Adam Barth.
474
475         * DumpRenderTree/chromium/DRTTestRunner.cpp:
476         (DRTTestRunner::DRTTestRunner):
477         * DumpRenderTree/chromium/DRTTestRunner.h:
478         (DRTTestRunner):
479         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
480         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
481         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
482         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
483         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
484         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
485         (WebTestRunner::TestRunner::TestRunner):
486         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
487         (WebTestRunner):
488         (WebTestRunner::TestRunner::setGeolocationPermission):
489         (WebTestRunner::TestRunner::setMockGeolocationPosition):
490         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
491         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
492         (TestRunner):
493         * DumpRenderTree/chromium/WebViewHost.cpp:
494         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
495         (WebViewHost::setGeolocationPermission):
496         (WebViewHost::setMockGeolocationPosition):
497         (WebViewHost::setMockGeolocationPositionUnavailableError):
498         * DumpRenderTree/chromium/WebViewHost.h:
499
500 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
501
502         Unreviewed build fix for Qt WK2 after r140258.
503         Use the size_t type instead of unsigned for the variable
504         which holds the position of the first null character in the
505         console message.
506
507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
508         (WTR::InjectedBundlePage::willAddMessageToConsole):
509
510 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
511
512         Unreviewed, rolling out r140260.
513         http://trac.webkit.org/changeset/140260
514         https://bugs.webkit.org/show_bug.cgi?id=107387
515
516         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
517         nothing else) (Requested by thakis__ on #webkit).
518
519         * Scripts/update-webkit-chromium:
520
521 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
522
523         Delegated scrolling: Assertion on attempt to show a CSS sticky element
524         https://bugs.webkit.org/show_bug.cgi?id=106890
525
526         Reviewed by Kenneth Rohde Christiansen.
527
528         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
529
530         * WebKitTestRunner/TestInvocation.cpp:
531         (WTR::shouldUseFixedLayout):
532         (WTR):
533         (WTR::updateLayoutType):
534
535 2013-01-19  Nico Weber  <thakis@chromium.org>
536
537         Make ninja the default build system for build-webkit --chromium on mac
538         https://bugs.webkit.org/show_bug.cgi?id=106737
539
540         Reviewed by Eric Seidel.
541
542         * Scripts/update-webkit-chromium:
543
544 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
545
546         [WK2] svg/dom/fuzz-path-parser.html is failing
547         https://bugs.webkit.org/show_bug.cgi?id=107133
548
549         Reviewed by Alexey Proskuryakov.
550
551         Console messages can contain null characters before the end of string.
552         Appending such message to the StringBuilder as a WTFString appends the
553         complete string, including the null character. This later cuts off everything
554         after the null character when the string is being printed out to the test
555         output.
556
557         To avoid this, truncate the string up to the first null character. This
558         preserves the newline character appended immediately after this and
559         stops giving incorrect output.
560
561         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
562         (WTR::InjectedBundlePage::willAddMessageToConsole):
563
564 2013-01-19  Eric Seidel  <eric@webkit.org>
565
566         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
567         https://bugs.webkit.org/show_bug.cgi?id=107367
568
569         Reviewed by Ryosuke Niwa.
570
571         Using srcdoc instead of document.write changes the error output
572         ever so slightly.  Clearly we were already trying to ignore these
573         messages, just not succeeding.  This change makes this new test "pass" correctly.
574
575         * Scripts/webkitpy/performance_tests/perftest.py:
576         (PerfTest):
577
578 2013-01-18  Dan Winship  <danw@gnome.org>
579
580         REGRESSION (r139071): run-webkit-httpd complains at launch
581         https://bugs.webkit.org/show_bug.cgi?id=107310
582
583         Reviewed by Alexey Proskuryakov.
584
585         * Scripts/webkitperl/httpd.pm:
586         (getApacheVersion): use preferred perl syntax
587
588 2013-01-18  Julie Parent  <jparent@chromium.org>
589
590         Add back 'group' as a default cross dashboard parameter, but with null as its value.
591         https://bugs.webkit.org/show_bug.cgi?id=107336
592
593         We need to have 'group' listed as a parameter, else we never parse it,
594         as we only parse parameters with defaults.
595         
596         Reviewed by Ojan Vafai.
597
598         * TestResultServer/static-dashboards/dashboard_base.js:
599
600 2013-01-18  Emil A Eklund  <eae@chromium.org>
601
602         Update LayoutUnit rounding unit test
603         https://bugs.webkit.org/show_bug.cgi?id=107322
604
605         Reviewed by Levi Weintraub.
606         
607         Update the LayoutUnitRounding test to use fromFloatRound for
608         values that cannot accurately be represented as a LayoutUnit
609         (the default behavior is to floor the value to the nearest
610         LayoutUnit).
611
612         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
613         (TestWebKitAPI::TEST):
614
615 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
616
617         VCSUtils.pm: Stop calling git repo-config.
618         https://bugs.webkit.org/show_bug.cgi?id=107294
619
620         Reviewed by Dirk Pranke.
621
622         The `repo-config' git command has been deprecated since early
623         2008, and recent versions have started warning it is deprecated.
624
625         Basically revert r27870 and use the `config' command all the time.
626
627         * Scripts/VCSUtils.pm:
628         (gitConfig):
629
630 2013-01-18  Levi Weintraub  <leviw@chromium.org>
631
632         LayoutUnit should round half consistently, not away from zero
633         https://bugs.webkit.org/show_bug.cgi?id=107208
634
635         Reviewed by Eric Seidel.
636
637         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
638         cover this change in rounding behavior.
639
640 2013-01-18  Tim Horton  <timothy_horton@apple.com>
641
642         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
643         https://bugs.webkit.org/show_bug.cgi?id=107234
644
645         Reviewed by Simon Fraser.
646
647         * DumpRenderTree/mac/DumpRenderTree.mm:
648         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
649         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
650         (WTR::PlatformWebView::PlatformWebView): Ditto.
651
652 2013-01-18  Tim Horton  <timothy_horton@apple.com>
653
654         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
655         https://bugs.webkit.org/show_bug.cgi?id=107251
656
657         Reviewed by Simon Fraser.
658
659         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
660
661         * DumpRenderTree/mac/DumpRenderTree.mm:
662         (dumpRenderTree):
663         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
664         (WTR::InjectedBundle::platformInitialize):
665
666 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
667
668         [GTK] Enable indexed database for development builds
669         https://bugs.webkit.org/show_bug.cgi?id=107299
670
671         Reviewed by Gustavo Noronha Silva.
672
673         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
674         for GTK+ development builds.
675
676 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
677
678         AX: Improve table-guessing heuristics
679         https://bugs.webkit.org/show_bug.cgi?id=107042
680
681         Reviewed by Chris Fleizach.
682
683         Implement parentElementCallback on Chromium to make testing easier.
684
685         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
686         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
687
688 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
689
690         [GTK] Add property for IndexedDB database path to WebKitGTK+
691         https://bugs.webkit.org/show_bug.cgi?id=106136
692
693         Reviewed by Gustavo Noronha Silva.
694
695         During testing, set the web database directory to DUMPRENDERTREE_TEMP
696         before falling back to the old default. This is necessary because
697         indexed database tests require that each DRT shard is using a different
698         IDB database location.
699
700         * DumpRenderTree/gtk/DumpRenderTree.cpp:
701         (temporaryDatabaseDirectory): Added this helper for getting the
702         database directory.
703         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
704
705 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
706
707         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
708         https://bugs.webkit.org/show_bug.cgi?id=107264
709
710         Reviewed by Laszlo Gombos.
711
712         Enable API test InjectedBundleFrameHitTest for hit-testing,
713         since it is now passing on both Debug and Release builds.
714
715         * TestWebKitAPI/CMakeLists.txt:
716         * TestWebKitAPI/PlatformEfl.cmake:
717
718 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
719
720         [GTK] Implement TestRunner::addUserScript
721         https://bugs.webkit.org/show_bug.cgi?id=107275
722
723         Reviewed by Philippe Normand.
724
725         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
726         (TestRunner::addUserScript): Implement method using
727         DumpRenderTreeSupportGtk::addUserScript.
728
729 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
730
731         Unreviewed, add my secondary email address to the list.
732
733         * Scripts/webkitpy/common/config/committers.py:
734
735 2013-01-18  Dan Carney  <dcarney@google.com>
736
737         [chromium] move pointerlock functions to TestRunner library
738         https://bugs.webkit.org/show_bug.cgi?id=107241
739
740         Reviewed by Jochen Eisinger.
741
742         * DumpRenderTree/chromium/DRTTestRunner.cpp:
743         (DRTTestRunner::DRTTestRunner):
744         * DumpRenderTree/chromium/DRTTestRunner.h:
745         (DRTTestRunner):
746         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
747         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
748         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
749         (WebTestRunner::WebTestDelegate::didLosePointerLock):
750         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
751         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
752         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
753         (WebTestRunner::TestRunner::TestRunner):
754         (WebTestRunner):
755         (WebTestRunner::TestRunner::didAcquirePointerLock):
756         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
757         (WebTestRunner::TestRunner::didLosePointerLock):
758         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
759         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
760         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
761         (TestRunner):
762         * DumpRenderTree/chromium/WebViewHost.h:
763         (WebViewHost):
764
765 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
766
767         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
768         https://bugs.webkit.org/show_bug.cgi?id=106774
769
770         Reviewed by Martin Robinson.
771
772         In order to fix a long standing linespacing/font ascent & descent issue
773         we found that FreeType commit b0962ac34e660 solves that problem.
774         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
775         maintainer recommending several security updates after that said commit.
776
777         Also, in order to avoid extra rebaselining, let's activate subpixel
778         layout at the same time.
779
780         * efl/jhbuild.modules: New freetype 2.4.11
781
782 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
783
784         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
785         https://bugs.webkit.org/show_bug.cgi?id=107107
786         PR 282192
787
788         Reviewed by Rob Buis.
789
790         The DRT application will convert relative/absolute file path to
791         file://<real-file-path> format, so we only check for http/file prefix.
792
793         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
794         (BlackBerry::WebKit::isFullUrl):
795         (WebKit):
796         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
797
798 2013-01-17  Frank Farzan  <frankf@chromium.org>
799
800         Flakiness dashboard: Add ChromiumFYI master
801         https://bugs.webkit.org/show_bug.cgi?id=107180
802
803         Reviewed by Ojan Vafai.
804
805         This is needed to enable Chrome Android bots
806         to upload results for instrumentation tests.
807
808         * TestResultServer/generate_builders_json.py:
809         (main):
810         * TestResultServer/static-dashboards/builders.jsonp:
811
812 2013-01-17  Frank Farzan  <frankf@chromium.org>
813
814         Add Chrome on Android instrumentation test types to flakiness dashboard
815         https://bugs.webkit.org/show_bug.cgi?id=106964
816
817         Reviewed by Ojan Vafai.
818
819         Specifically, add these test types:
820         
821          androidwebview_instrumentation_tests
822          chromiumtestshell_instrumentation_tests
823          contentshell_instrumentation_tests
824         
825         Also, add ChromiumFYI to the list of masters.
826
827         * TestResultServer/static-dashboards/builders.js:
828         (loadBuildersList):
829         * TestResultServer/static-dashboards/dashboard_base.js:
830         (currentBuilderGroupCategory):
831
832 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
833
834         Fixing webkitpy's SCM unit tests.
835         https://bugs.webkit.org/show_bug.cgi?id=106429
836
837         Reviewed by Eric Seidel.
838
839         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
840         (SCMDetectorTest.test_detect_scm_system):
841         * Scripts/webkitpy/common/checkout/scm/git.py:
842         (Git.in_working_directory):
843         (Git.read_git_config):
844         (Git._assert_can_squash):
845         (Git.remote_branch_ref):
846         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
847         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
848         (GitTestWithMock):
849         (GitTestWithMock.make_scm):
850         (GitTestWithMock.test_create_patch):
851         * Scripts/webkitpy/common/system/outputcapture.py:
852         (OutputCapture.assert_outputs):
853         (OutputCaptureTestCaseBase):
854         * Scripts/webkitpy/test/printer.py:
855         (Printer.configure):
856
857 2013-01-17  Julie Parent  <jparent@chromium.org>
858
859         Flakiness dashboard assumes there must be ToT tests
860         https://bugs.webkit.org/show_bug.cgi?id=107155
861
862         Remove group as a default parameter, since we can't actually know
863         the name of a group initially.  Instead, introduces 
864         currentBuilderGroupName which returns the current builder group
865         if it has been explicitly set, or picks the first one available
866         as a default. Allows us to remove some extra code tracking this
867         stuff as well.
868         
869         Reviewed by Ojan Vafai.
870
871         * TestResultServer/static-dashboards/dashboard_base.js:
872         (parseCrossDashboardParameters):
873         (currentBuilderGroupName):
874         (currentBuilderGroup):
875         * TestResultServer/static-dashboards/flakiness_dashboard.js:
876         (platformAndBuildType):
877         * TestResultServer/static-dashboards/loader.js:
878         (.):
879
880 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
881
882         Remove NodeListsNodeData when it's no longer needed
883         https://bugs.webkit.org/show_bug.cgi?id=107074
884
885         Reviewed by Darin Adler.
886
887         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
888
889         * Scripts/webkitpy/performance_tests/perftest.py:
890         (PerfTest):
891
892 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
893
894         Ref test images are upside-down in WebKit2
895         https://bugs.webkit.org/show_bug.cgi?id=105457
896
897         Reviewed by Sam "Speedy" Weinig.
898         
899         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
900         from the window snapshot contained a flipped copy of the image, causing all ref
901         and pixel images to be upside-down.
902
903         * WebKitTestRunner/cg/TestInvocationCG.cpp:
904         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
905
906 2013-01-17  Timothy Loh  <timloh@google.com>
907
908         Replaced specifiers variable with is_debug in builders.py
909         https://bugs.webkit.org/show_bug.cgi?id=107057
910
911         Reviewed by Dirk Pranke.
912
913         Replaced specifiers variable with is_debug in builders.py to simplify
914         Bug 106259. The other specifiers are not used elsewhere in the code.
915         Fixed builder_name_for_port_name to return a debug builder if we don't
916         have a release builder.
917
918         * Scripts/webkitpy/layout_tests/port/builders.py:
919         (all_port_names):
920         (builder_name_for_port_name):
921         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
922         (TestRebaselineExpectations.test_rebaseline_expectations):
923
924 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
925
926         [GTK] Build with LevelDB when IndexedDB is enabled
927         https://bugs.webkit.org/show_bug.cgi?id=103220
928
929         Reviewed by Gustavo Noronha Silva.
930
931         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
932         as it does not conform to WebKit style.
933
934 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
935
936         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
937         https://bugs.webkit.org/show_bug.cgi?id=107119
938
939         Reviewed by Laszlo Gombos.
940
941         Do not use ASSERT on ecore_evas_init(), since the expression inside
942         the macro compiles out of release builds.
943
944         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
945         * TestWebKitAPI/efl/PlatformWebView.cpp:
946         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
947
948 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
949
950         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
951         https://bugs.webkit.org/show_bug.cgi?id=104545
952
953         Reviewed by Yury Semikhatsky.
954
955         Adopt signature changes.
956
957         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
958         (ProfilerAgent.getCPUProfile): Renamed.
959         (ProfilerAgent.getHeapSnapshot): Added.
960
961 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
962
963         [GTK][EFL] NWRT should check that Xvfb is installed
964         https://bugs.webkit.org/show_bug.cgi?id=71767
965
966         Reviewed by Dirk Pranke.
967
968         EFL and GTK ports now check that Xvfb is installed before running
969         layout tests. The command line used to check whether Xvfb is present
970         is a simple `which Xvfb` that should return 0 as the exit code upon
971         success.
972
973         * Scripts/webkitpy/layout_tests/port/efl.py:
974         (EflPort.show_results_html_file):
975         (EflPort):
976         (EflPort.check_sys_deps):
977         * Scripts/webkitpy/layout_tests/port/gtk.py:
978         (GtkPort.check_sys_deps):
979         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
980         (XvfbDriver):
981         (XvfbDriver.check_xvfb):
982
983 2013-01-16  Alan Cutter  <alancutter@chromium.org>
984
985         sheriffbot can't tell me who "kov" is
986         https://bugs.webkit.org/show_bug.cgi?id=106184
987
988         Reviewed by Eric Seidel.
989
990         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
991
992         * Scripts/webkitpy/common/config/committers.py:
993         (Account.matches_glob):
994         (CommitterList.contributors_by_search_string):
995         * Scripts/webkitpy/common/config/committers_unittest.py:
996         (CommittersTest.test_committer_lookup):
997         * Scripts/webkitpy/tool/bot/irc_command.py:
998         (Whois):
999
1000 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1001
1002         Use xcrun to find path to make for Mac port
1003         <http://webkit.org/b/107091>
1004
1005         Reviewed by Dan Bernstein.
1006
1007         * Scripts/webkitpy/layout_tests/port/mac.py:
1008         (MacPort._build_java_test_support): Call self.make_command().
1009         (MacPort.make_command): Add.  Call xcrun_find().
1010         (MacPort.nm_command): Use self.xcrun_find().
1011         (MacPort.xcrun_find): Add.  Extract from nm_command().
1012
1013 2013-01-16  Sam Weinig  <sam@webkit.org>
1014
1015         Make debug-safari --target-web-process work again
1016         https://bugs.webkit.org/show_bug.cgi?id=107088
1017
1018         Reviewed by Anders Carlsson.
1019
1020         * Scripts/webkitdirs.pm:
1021         (execMacWebKitAppForDebugging):
1022         The shim is now called SecItemShim.
1023
1024 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1025
1026         GCE build scripts don't take working directory into account when calling findzone.sh
1027         https://bugs.webkit.org/show_bug.cgi?id=106962
1028
1029         Reviewed by Adam Barth.
1030
1031         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1032         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1033         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1034
1035 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1036
1037         start-queue.sh does not pass remaining parameters correctly
1038         https://bugs.webkit.org/show_bug.cgi?id=107054
1039
1040         Reviewed by Adam Barth.
1041
1042         start-queue.sh now passes all remaining params to the webkit-patch command.
1043         Previously only one additional queue parameter could be sent.
1044
1045         * EWSTools/start-queue.sh:
1046
1047 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1048
1049         check-webkit-style script cannot running in Chinese windows.
1050         https://bugs.webkit.org/show_bug.cgi?id=87548
1051
1052         Reviewed by Darin Adler.
1053
1054         * Scripts/webkitpy/common/system/platforminfo.py:
1055         (PlatformInfo._win_version_tuple_from_cmd):
1056
1057 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1058
1059         Delete an extraneous print statement.
1060         https://bugs.webkit.org/show_bug.cgi?id=106562
1061
1062         Delete the extraneous print statement introduced in r139841.
1063
1064         * Scripts/webkitpy/layout_tests/views/printing.py:
1065         (Printer.print_found):
1066
1067 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1068
1069         Please reinstate --pixel
1070         https://bugs.webkit.org/show_bug.cgi?id=101995
1071
1072         Reviewed by Dirk Pranke.
1073
1074         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1075         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1076         Some developers are still used to these options that were available in the ORWT.
1077
1078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1079         (parse_args):
1080
1081 2013-01-16  Eric Seidel  <eric@webkit.org>
1082
1083         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1084         https://bugs.webkit.org/show_bug.cgi?id=99512
1085
1086         Reviewed by Darin Adler.
1087
1088         * Scripts/run-sunspider:
1089
1090 2013-01-16  Eric Seidel  <eric@webkit.org>
1091
1092         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1093         https://bugs.webkit.org/show_bug.cgi?id=106036
1094
1095         Reviewed by Darin Adler.
1096
1097         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1098         * Scripts/webkitpy/webkitpy.sln: Removed.
1099
1100 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1101
1102         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1103         https://bugs.webkit.org/show_bug.cgi?id=104049
1104
1105         Reviewed by Eric Seidel.
1106
1107         Targets with dependencies (direct/indirect) on a java target receive
1108         the chromium_*.jar paths in the variable input_jars_paths. Targets
1109         should use that rather than hardcoding where they think the jar will
1110         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1111         than as --jars to generate_native_test.py.
1112
1113         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1114         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1115
1116 2013-01-16  Dan Carney  <dcarney@google.com>
1117
1118         [chromium] move setMockDeviceOrientation to TestRunner library
1119         https://bugs.webkit.org/show_bug.cgi?id=106895
1120
1121         Reviewed by Jochen Eisinger.
1122
1123         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1124         (DRTTestRunner::DRTTestRunner):
1125         * DumpRenderTree/chromium/DRTTestRunner.h:
1126         (DRTTestRunner):
1127         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1128         (WebKit):
1129         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1130         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1131         (WebTestRunner::TestRunner::TestRunner):
1132         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1133         (WebTestRunner):
1134         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1135         (TestRunner):
1136         * DumpRenderTree/chromium/WebViewHost.cpp:
1137         (WebViewHost::setDeviceOrientation):
1138         * DumpRenderTree/chromium/WebViewHost.h:
1139         (WebViewHost):
1140
1141 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1142
1143         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1144         https://bugs.webkit.org/show_bug.cgi?id=106904
1145
1146         Reviewed by Adam Barth.
1147
1148         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1149         (DRTTestRunner::DRTTestRunner):
1150         (DRTTestRunner::notifyDone):
1151         (DRTTestRunner::reset):
1152         * DumpRenderTree/chromium/DRTTestRunner.h:
1153         (DRTTestRunner):
1154         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1155         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1156         (WebTestRunner::WebTestDelegate::setFocus):
1157         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1158         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1159         (WebTestRunner::WebTestDelegate::setLocale):
1160         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1161         (WebTestRunner::TestRunner::TestRunner):
1162         (WebTestRunner::TestRunner::reset):
1163         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1164         (WebTestRunner):
1165         (WebTestRunner::TestRunner::setWindowIsKey):
1166         (WebTestRunner::TestRunner::pathToLocalResource):
1167         (WebTestRunner::TestRunner::setBackingScaleFactor):
1168         (WebTestRunner::TestRunner::setPOSIXLocale):
1169         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1170         (WebTestRunner::TestRunner::taskList):
1171         (TestRunner):
1172         * DumpRenderTree/chromium/WebViewHost.cpp:
1173         (WebViewHost::setDeviceScaleFactor):
1174         (WebViewHost::setFocus):
1175         (WebViewHost::setAcceptAllCookies):
1176         (WebViewHost::pathToLocalResource):
1177         (WebViewHost::setLocale):
1178         * DumpRenderTree/chromium/WebViewHost.h:
1179         (WebViewHost):
1180
1181 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1182
1183         [GTK] build-webkit fails if the jhbuild wrapper is not used
1184         https://bugs.webkit.org/show_bug.cgi?id=106769
1185
1186         Reviewed by Martin Robinson.
1187
1188         Return an empty array instead of "" in
1189         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1190         will not be recognized as a valid command when the returned array
1191         is directly passed to perl's system() call.
1192
1193         * Scripts/webkitdirs.pm:
1194         (jhbuildWrapperPrefixIfNeeded):
1195
1196 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1197
1198         [chromium] add title text direction attribute to TestRunner
1199         https://bugs.webkit.org/show_bug.cgi?id=106907
1200
1201         Reviewed by Adam Barth.
1202
1203         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1204         (DRTTestRunner::DRTTestRunner):
1205         (DRTTestRunner::reset):
1206         * DumpRenderTree/chromium/DRTTestRunner.h:
1207         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1208         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1209         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1210         (WebTestRunner::TestRunner::TestRunner):
1211         (WebTestRunner::TestRunner::reset):
1212         (WebTestRunner::TestRunner::setTitleTextDirection):
1213         (WebTestRunner):
1214         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1215         (TestRunner):
1216         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1217         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1218         * DumpRenderTree/chromium/WebViewHost.cpp:
1219         (WebViewHost::didReceiveTitle):
1220
1221 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1222
1223         NRWT still confused about test count with --repeat-each and --iterations
1224         https://bugs.webkit.org/show_bug.cgi?id=106562
1225
1226         Reviewed by Dirk Pranke.
1227
1228         Fix the printed unique test count and skipped count. This
1229         seems to have broken in r127688 ("NRWT lies about the number
1230         of tests that it's skipping when used with --repeat-each").
1231
1232         Also add a test for print_found()
1233
1234         * Scripts/webkitpy/layout_tests/views/printing.py:
1235         (Printer.print_found):
1236         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1237         (Testprinter.test_details):
1238         (Testprinter):
1239         (Testprinter.test_found):
1240
1241 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1242
1243         Unreviewed follow-up to r139769.
1244
1245         Note that omitting the WebKit1 code from the build now
1246         works for GTK as well.
1247
1248         * Scripts/build-webkit:
1249
1250 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1251
1252         test-webkitpy: truncate output to the terminal width when necessary
1253         https://bugs.webkit.org/show_bug.cgi?id=106973
1254
1255         Reviewed by Ojan Vafai.
1256
1257         this implements the same logic for test-webkitpy that we have
1258         for run-webkit-tests (and ninja).
1259
1260         No tests written as this is exercised by running test-webkitpy itself.
1261
1262         * Scripts/webkitpy/test/printer.py:
1263         (Printer.configure):
1264         (Printer._test_line):
1265
1266 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1267
1268         remove extraneous output in test-webkitpy
1269         https://bugs.webkit.org/show_bug.cgi?id=106971
1270
1271         Reviewed by Ojan Vafai.
1272
1273         We weren't ignoring or capturing the echoed output from
1274         these two tests, and getting noise in the logs as a result.
1275
1276         * Scripts/webkitpy/common/system/executive_unittest.py:
1277         (ExecutiveTest.test_auto_stringify_args):
1278         (ExecutiveTest.test_popen_args):
1279
1280 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1281
1282         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1283         https://bugs.webkit.org/show_bug.cgi?id=106974
1284
1285         Reviewed by Ryosuke Niwa.
1286
1287         I forgot to stub out the call to check to ensure that the ports were
1288         available, so this test could fail if something was listening on 8000 or
1289         8443 on the machine.
1290
1291         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1292         (TestHttpServer.test_win32_start_and_stop):
1293
1294 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1295
1296         Unreviewed, rolling out r139792.
1297         http://trac.webkit.org/changeset/139792
1298         https://bugs.webkit.org/show_bug.cgi?id=106970
1299
1300         Broke the windows build.
1301
1302         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1303         (DRTTestRunner::DRTTestRunner):
1304         (DRTTestRunner::notifyDone):
1305         (DRTTestRunner::reset):
1306         (DRTTestRunner::setAlwaysAcceptCookies):
1307         (DRTTestRunner::setWindowIsKey):
1308         (DRTTestRunner::pathToLocalResource):
1309         (DRTTestRunner::setPOSIXLocale):
1310         (InvokeCallbackTask):
1311         (InvokeCallbackTask::InvokeCallbackTask):
1312         (InvokeCallbackTask::runIfValid):
1313         (DRTTestRunner::setBackingScaleFactor):
1314         * DumpRenderTree/chromium/DRTTestRunner.h:
1315         (DRTTestRunner):
1316         (DRTTestRunner::taskList):
1317         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1318         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1319         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1320         (WebTestRunner::TestRunner::TestRunner):
1321         (WebTestRunner::TestRunner::reset):
1322         (WebTestRunner::TestRunner::setDatabaseQuota):
1323         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1324         (TestRunner):
1325         * DumpRenderTree/chromium/WebViewHost.cpp:
1326         (WebViewHost::setPendingExtraData):
1327         (WebViewHost::setDeviceScaleFactor):
1328         * DumpRenderTree/chromium/WebViewHost.h:
1329         (WebViewHost):
1330
1331 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1332
1333         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1334
1335         * Scripts/webkitpy/common/config/ports.py:
1336         (MacWK2Port):
1337
1338 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1339
1340         Extend sheriffbot's "help" command to be able to get help on individual commands
1341         https://bugs.webkit.org/show_bug.cgi?id=106629
1342
1343         Reviewed by Eric Seidel.
1344
1345         Added a help command to sheriffbot.
1346         Fixed some style issues and ordered the commands alphabetically.
1347
1348         * Scripts/webkitpy/tool/bot/irc_command.py:
1349         (IRCCommand):
1350         (IRCCommand.execute):
1351         (IRCCommand.usage):
1352         (IRCCommand.help):
1353         (CreateBug):
1354         (CreateBug.execute):
1355         (Help):
1356         (Help.execute):
1357         (Help._post_command_help):
1358         (Hi):
1359         (Hi.execute):
1360         (Restart):
1361         (RollChromiumDEPS):
1362         (RollChromiumDEPS._parse_args):
1363         (RollChromiumDEPS._expand_irc_nickname):
1364         (RollChromiumDEPS.execute):
1365         (Rollout):
1366         (Rollout._extract_revisions):
1367         (Rollout.execute):
1368         (Sheriffs):
1369         (Sheriffs.execute):
1370         (Whois):
1371         (Whois.execute):
1372         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1373         (IRCBotTest.test_help):
1374
1375 2013-01-15  Enrica Casucci  <enrica@apple.com>
1376
1377         Add a new set of WebKit2 APIs for text search and
1378         search results management.
1379         https://bugs.webkit.org/show_bug.cgi?id=106834.
1380         <rdar://problem/12597159>
1381
1382         Added new test for the new WebKit2 API for
1383         text search.
1384         
1385         Reviewed by Simon Fraser.
1386
1387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1388         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1389
1390 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1391
1392         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1393         https://bugs.webkit.org/show_bug.cgi?id=106904
1394
1395         Reverting 139794. It broke the build. It appears that a header file,
1396         WebTextDirection.h, was left out.
1397
1398         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1399         (DRTTestRunner::DRTTestRunner):
1400         (DRTTestRunner::reset):
1401         * DumpRenderTree/chromium/DRTTestRunner.h:
1402         (DRTTestRunner::setTitleTextDirection):
1403         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1404         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1405         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1406         (WebTestRunner::TestRunner::TestRunner):
1407         (WebTestRunner::TestRunner::reset):
1408         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1409         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1410         (TestRunner):
1411         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1412         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1413         * DumpRenderTree/chromium/WebViewHost.cpp:
1414         (WebViewHost::didReceiveTitle):
1415
1416 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1417
1418         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1419         https://bugs.webkit.org/show_bug.cgi?id=106904
1420
1421         Reviewed by Adam Barth.
1422
1423         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1424         (DRTTestRunner::DRTTestRunner):
1425         (DRTTestRunner::notifyDone):
1426         (DRTTestRunner::reset):
1427         * DumpRenderTree/chromium/DRTTestRunner.h:
1428         (DRTTestRunner):
1429         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1430         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1431         (WebTestRunner::WebTestDelegate::setFocus):
1432         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1433         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1434         (WebTestRunner::WebTestDelegate::setLocale):
1435         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1436         (WebTestRunner::TestRunner::TestRunner):
1437         (WebTestRunner::TestRunner::reset):
1438         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1439         (WebTestRunner):
1440         (WebTestRunner::TestRunner::setWindowIsKey):
1441         (WebTestRunner::TestRunner::pathToLocalResource):
1442         (WebTestRunner::TestRunner::setBackingScaleFactor):
1443         (WebTestRunner::TestRunner::setPOSIXLocale):
1444         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1445         (WebTestRunner::TestRunner::taskList):
1446         (TestRunner):
1447         * DumpRenderTree/chromium/WebViewHost.cpp:
1448         (WebViewHost::setDeviceScaleFactor):
1449         (WebViewHost::setFocus):
1450         (WebViewHost::setAcceptAllCookies):
1451         (WebViewHost::pathToLocalResource):
1452         (WebViewHost::setLocale):
1453         * DumpRenderTree/chromium/WebViewHost.h:
1454         (WebViewHost):
1455
1456 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1457
1458         Tests with WontFix expectation are (indirectly) skipped
1459         https://bugs.webkit.org/show_bug.cgi?id=105860
1460
1461         Reviewed by Dirk Pranke.
1462
1463         Only skip the WontFix expectation if there are no other layout test
1464         expectations (like Failure, ImageOnlyFailure) listed for the test.
1465         This makes it possible to run an expected failure for which there
1466         is no reason or interest to fix. There are some ports that would like
1467         to exercise this behavior as well as specific test cases that should use
1468         such expectations.
1469
1470         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1471         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
1472         WONTFIX test if there are no expectations listed. The warning is adjusted
1473         to reflect the new behavior.
1474         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
1475         and adjust test cases for these changes.
1476         (ExpectationSyntaxTests.test_wontfix):
1477         (SemanticTests.test_skip_and_wontfix):
1478
1479 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1480
1481         [chromium] add title text direction attribute to TestRunner
1482         https://bugs.webkit.org/show_bug.cgi?id=106907
1483
1484         Reviewed by Adam Barth.
1485
1486         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1487         (DRTTestRunner::DRTTestRunner):
1488         (DRTTestRunner::reset):
1489         * DumpRenderTree/chromium/DRTTestRunner.h:
1490         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1491         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1492         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1493         (WebTestRunner::TestRunner::TestRunner):
1494         (WebTestRunner::TestRunner::reset):
1495         (WebTestRunner::TestRunner::setTitleTextDirection):
1496         (WebTestRunner):
1497         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1498         (TestRunner):
1499         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1500         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1501         * DumpRenderTree/chromium/WebViewHost.cpp:
1502         (WebViewHost::didReceiveTitle):
1503
1504 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1505
1506         nrwt: change the default # of locked shards on chromium_win to 1
1507         https://bugs.webkit.org/show_bug.cgi?id=106938
1508
1509         Reviewed by Eric Seidel.
1510
1511         It looks like LigHTTPd might be buggy or unstable if we are
1512         running multiple http tests in parallel; see
1513         http://code.google.com/p/chromium/issues/detail?id=169530 for more
1514         context as well. This change will stop running http tests in parallel
1515         and we can see if this fixes things.
1516
1517         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1518         (ChromiumWinPort.default_max_locked_shards):
1519         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1520         (ChromiumWinTest.test_path_to_image_diff):
1521         (ChromiumWinTest):
1522         (ChromiumWinTest.test_default_max_locked_shards):
1523
1524 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1525
1526         [chromium] move WebDatabase related methods to TestRunner library
1527         https://bugs.webkit.org/show_bug.cgi?id=106905
1528
1529         Reviewed by Adam Barth.
1530
1531         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1532         (DRTTestRunner::DRTTestRunner):
1533         (DRTTestRunner::reset):
1534         * DumpRenderTree/chromium/DRTTestRunner.h:
1535         (DRTTestRunner):
1536         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1537         (WebTestRunner::WebTestDelegate::clearAllDatabases):
1538         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1539         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1540         (WebTestRunner::TestRunner::TestRunner):
1541         (WebTestRunner::TestRunner::reset):
1542         (WebTestRunner::TestRunner::clearAllDatabases):
1543         (WebTestRunner):
1544         (WebTestRunner::TestRunner::setDatabaseQuota):
1545         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1546         (TestRunner):
1547         * DumpRenderTree/chromium/WebViewHost.cpp:
1548         (WebViewHost::clearAllDatabases):
1549         (WebViewHost::setDatabaseQuota):
1550         * DumpRenderTree/chromium/WebViewHost.h:
1551         (WebViewHost):
1552
1553 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
1554
1555         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
1556         functionality match the name.
1557         https://bugs.webkit.org/show_bug.cgi?id=106870
1558
1559         Reviewed by Adam Barth.
1560
1561         * Scripts/webkitpy/tool/commands/download.py:
1562         (Clean):
1563         (Update):
1564         (Build):
1565         (BuildAndTest):
1566         (CheckStyle):
1567         (BuildAttachment):
1568         (BuildAndTestAttachment):
1569         (AbstractPatchApplyingCommand):
1570         (ApplyWatchList):
1571         (AbstractPatchLandingCommand):
1572         (CreateRollout):
1573         * Scripts/webkitpy/tool/steps/__init__.py:
1574         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1575         (CleanWorkingDirectory.options):
1576         (CleanWorkingDirectory.run):
1577         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1578         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1579         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
1580
1581 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1582
1583         [Autotools] Add support for WebKit2-only builds
1584         https://bugs.webkit.org/show_bug.cgi?id=106889
1585
1586         Reviewed by Gustavo Noronha Silva.
1587
1588         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
1589         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
1590         building the GTK port through build-webkit.
1591         * Scripts/webkitdirs.pm:
1592         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
1593         arguments when not building WebKit1.
1594         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
1595         through the Autotools build system.
1596
1597 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1598
1599         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
1600         https://bugs.webkit.org/show_bug.cgi?id=106197
1601
1602         Reviewed by Martin Robinson.
1603
1604         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
1605         features. Enable them on GTK, meaning they will be enabled in development builds
1606         (i.e. when building with build-webkit).
1607
1608 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1609
1610         [GTK] Enable CSS Image Resolution feature
1611         https://bugs.webkit.org/show_bug.cgi?id=99038
1612
1613         Reviewed by Gustavo Noronha Silva.
1614
1615         Enable the CSS Image Resolution feature for the development
1616         builds of the GTK port.
1617
1618         * Scripts/webkitperl/FeatureList.pm:
1619
1620 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1621
1622         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
1623         https://bugs.webkit.org/show_bug.cgi?id=106579
1624
1625         Reviewed by Gustavo Noronha Silva.
1626
1627         The --enable-unstable-features flag is not required to be passed anymore
1628         to the configure script as it was removed in r138252.
1629
1630         * Scripts/webkitdirs.pm:
1631         (buildAutotoolsProject):
1632
1633 2013-01-15  Tony Chang  <tony@chromium.org>
1634
1635         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
1636
1637         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1638         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
1639         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1640         (TestHttpServer.test_win32_start_and_stop):
1641
1642 2013-01-15  Joshua Bell  <jsbell@chromium.org>
1643
1644         Unreviewed. Adding Michael Pruett as contributor.
1645
1646         * Scripts/webkitpy/common/config/committers.py:
1647
1648 2013-01-15  Victor Carbune  <victor@rosedu.org>
1649
1650         Unreviewed. Update my email addresses.
1651
1652         * Scripts/webkitpy/common/config/committers.py:
1653
1654 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1655
1656         [GTK] Waiting on the gdb process will lead to deadlock
1657         https://bugs.webkit.org/show_bug.cgi?id=106906
1658
1659         Reviewed by Philippe Normand.
1660
1661         Use communicate() rather than wait() on the Popen object that's running the gdb
1662         command. This avoids the deadlock that occurs on the GTK builders.
1663
1664         * Scripts/webkitpy/layout_tests/port/gtk.py:
1665         (GtkPort._get_gdb_output):
1666
1667 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1668
1669         [GTK] Limit the number of frames printed out when backtracing with gdb
1670         https://bugs.webkit.org/show_bug.cgi?id=106901
1671
1672         Reviewed by Philippe Normand.
1673
1674         Printing an unlimited number of frames when dumping the gdb backtracing
1675         output can cause timeouts in the builders. This patch limits the number
1676         of frames that are printed out to 1024.
1677
1678         * Scripts/webkitpy/layout_tests/port/gtk.py:
1679         (GtkPort._get_gdb_output):
1680
1681 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
1682
1683         [Qt] Fix ImageDiff's image format conversion
1684         https://bugs.webkit.org/show_bug.cgi?id=106880
1685
1686         Reviewed by Csaba Osztrogonác.
1687
1688         Besides actually doing the conversion this also silences the suspicious warning:
1689         "ignoring return value of function declared with warn_unused_result attribute".
1690
1691         * ImageDiff/qt/ImageDiff.cpp:
1692         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
1693         copy of the image in the given format and does not alter the image itself.
1694
1695 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1696
1697         [chromium] move remaining methods that just set a boolean flag to TestRunner library
1698         https://bugs.webkit.org/show_bug.cgi?id=106823
1699
1700         Reviewed by Darin Fisher.
1701
1702         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1703         (DRTTestRunner::DRTTestRunner):
1704         (DRTTestRunner::reset):
1705         * DumpRenderTree/chromium/DRTTestRunner.h:
1706         (DRTTestRunner):
1707         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1708         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
1709         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
1710         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
1711         (WebTestRunner::WebTestRunner::testRepaint):
1712         (WebTestRunner::WebTestRunner::sweepHorizontally):
1713         (WebTestRunner::WebTestRunner::isPrinting):
1714         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1715         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1716         (WebTestRunner::TestRunner::TestRunner):
1717         (WebTestRunner::TestRunner::reset):
1718         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
1719         (WebTestRunner):
1720         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
1721         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
1722         (WebTestRunner::TestRunner::testRepaint):
1723         (WebTestRunner::TestRunner::sweepHorizontally):
1724         (WebTestRunner::TestRunner::isPrinting):
1725         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1726         (WebTestRunner::TestRunner::dumpBackForwardList):
1727         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
1728         (WebTestRunner::TestRunner::dumpSelectionRect):
1729         (WebTestRunner::TestRunner::repaintSweepHorizontally):
1730         (WebTestRunner::TestRunner::setPrinting):
1731         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
1732         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1733         (TestRunner):
1734
1735 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1736
1737         nrwt: stub out show_results_html for mock ports
1738         https://bugs.webkit.org/show_bug.cgi?id=106848
1739
1740         Reviewed by Ojan Vafai.
1741
1742         We were accidentally using the underlying ports'
1743         show_results_html_file() implementation, which would, unsurprisingly,
1744         fail in many cases (e.g., running mock-efl on the mac).
1745
1746         No test added since we don't generally add tests for the mock
1747         implementation.
1748
1749         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1750         (MockDRTPort.show_results_html_file):
1751
1752 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1753
1754         Changing clean_working_directory/clean_local_commits and related
1755         functions to have consistent naming.
1756
1757         https://bugs.webkit.org/show_bug.cgi?id=104198
1758
1759         Reviewed by Adam Barth.
1760
1761         * Scripts/webkitpy/common/checkout/scm/git.py:
1762         * Scripts/webkitpy/common/checkout/scm/scm.py:
1763         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1764         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1765         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1766         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1767
1768 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1769
1770         Fix EWS GCE build scripts to detect which zone is available
1771         https://bugs.webkit.org/show_bug.cgi?id=106524
1772
1773         Reviewed by Adam Barth.
1774
1775         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1776         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1777         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1778         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
1779
1780 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1781
1782         Adding an error string to AmbiguousCommitError.
1783         https://bugs.webkit.org/show_bug.cgi?id=106846
1784
1785         Reviewed by Adam Barth.
1786
1787         * Scripts/webkitpy/common/checkout/scm/git.py:
1788         (AmbiguousCommitError.__init__):
1789
1790 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1791
1792         kill whole lighttpd process tree for chromium win
1793         https://bugs.webkit.org/show_bug.cgi?id=106838
1794
1795         Reviewed by Tony Chang.
1796
1797         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
1798         I think a test is causing a httpd server child process to wedge and
1799         killing the parent httpd server process isn't sufficient to ensure
1800         that the children are also killed.
1801
1802         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1803         (Lighttpd._check_and_kill):
1804         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1805         (TestHttpServer.test_start_cmd):
1806         (TestHttpServer):
1807         (TestHttpServer.test_win32_start_and_stop):
1808         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
1809         (TestHttpServer.test_win32_start_and_stop.mock_returns):
1810         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
1811
1812 2013-01-14  Nico Weber  <thakis@chromium.org>
1813
1814         [chromium] Enable `update-webkit --chromium --ninja` on windows
1815         https://bugs.webkit.org/show_bug.cgi?id=106836
1816
1817         Reviewed by Eric Seidel.
1818
1819         After running this, build-webkit --chromium will use ninja to build.
1820         Apparently there are some minor issues with that still, so it's
1821         not quite ready for use yet.
1822
1823         * Scripts/webkitdirs.pm:
1824         (determineIsChromiumNinja):
1825         (buildChromium):
1826
1827 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1828
1829         nrwt: use the same search path for baselines and TestExpectations on apple mac
1830         https://bugs.webkit.org/show_bug.cgi?id=105599
1831
1832         Reviewed by Ryosuke Niwa.
1833
1834         Bug 105583 revealed some confusion due to the fact that the Apple
1835         Mac port used a different list of directories to search for baselines
1836         and TestExpectations files (actually, pretty much every port does).
1837
1838         It seems like a good idea to use the same list for both by default, but
1839         making this happen will affect every port in slightly different ways, so
1840         we'll try this on the Apple Mac port first.
1841
1842         Note that the effective changes for this are that:
1843         1) The apple mac port will look in platform/wk2 for baselines where
1844         it didn't before (it will look after looking in mac-wk2 but before
1845         the non-wk2 dirs)
1846         2) The apple mac-snowleopard port will use the expectations in
1847         mac-lion as well as the expectations in mac-snowleopard, although
1848         I'm not even sure if mac-snowleopard is still supported ...
1849
1850         * Scripts/webkitpy/layout_tests/port/mac.py:
1851         (MacPort.default_baseline_search_path):
1852         (MacPort.expectations_files):
1853         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1854         (test_baseline_search_path):
1855
1856 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1857
1858         AX: Need to implement ColorWellRole
1859         https://bugs.webkit.org/show_bug.cgi?id=106756
1860
1861         Reviewed by Chris Fleizach.
1862
1863         Returns a string representation of the value of a color
1864         when the role is Color Well, to make it easy to write layout
1865         tests for color controls.
1866
1867         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1868
1869 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1870
1871         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
1872         https://bugs.webkit.org/show_bug.cgi?id=106682
1873
1874         Reviewed by Chris Fleizach.
1875
1876         Modify Chromium's DRT implementation of intValue to return a
1877         different value depending on the role.
1878
1879         There are actually platform-specific differences in what should
1880         be returned in the "value" of an object, so Chromium normally keeps
1881         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
1882         but this is a fine simplification to make cross-platform tests easier.
1883
1884         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1885         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
1886
1887 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
1888
1889         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
1890         https://bugs.webkit.org/show_bug.cgi?id=106785
1891
1892         Reviewed by Adam Barth.
1893
1894         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1895         (DRTTestRunner::DRTTestRunner):
1896         (DRTTestRunner::reset):
1897         * DumpRenderTree/chromium/DRTTestRunner.h:
1898         (DRTTestRunner):
1899         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1900         (WebTestProxyBase):
1901         (WebTestRunner::WebTestProxy::setStatusText):
1902         (WebTestRunner::WebTestProxy::didStopLoading):
1903         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1904         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
1905         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
1906         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1907         (WebTestRunner::TestRunner::TestRunner):
1908         (WebTestRunner::TestRunner::reset):
1909         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
1910         (WebTestRunner):
1911         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
1912         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
1913         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
1914         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1915         (TestRunner):
1916         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1917         (WebTestRunner::WebTestProxyBase::setStatusText):
1918         (WebTestRunner):
1919         (WebTestRunner::WebTestProxyBase::didStopLoading):
1920         * DumpRenderTree/chromium/WebViewHost.cpp:
1921         (WebViewHost::didStopLoading):
1922         * DumpRenderTree/chromium/WebViewHost.h:
1923         (WebViewHost):
1924
1925 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1926
1927         Web Inspector: devtools front-end doesn't have focus in TestShell
1928         https://bugs.webkit.org/show_bug.cgi?id=106778
1929
1930         Reviewed by Pavel Feldman.
1931
1932         Focus devTools window after loadURL method.
1933
1934         * DumpRenderTree/chromium/TestShell.cpp:
1935         (TestShell::runFileTest):
1936
1937 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1938
1939         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
1940         https://bugs.webkit.org/show_bug.cgi?id=106573
1941
1942         Reviewed by Philippe Normand.
1943
1944         Similarly to what's been described in bug 106569, we're building
1945         from release tarballs, so there's no reason to regenerate the
1946         autoconf-related stuff with autogen.sh, especially since we might
1947         run into trouble with automake 1.13 and deprecated macros.
1948
1949         * efl/jhbuild.modules:
1950
1951 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1952
1953         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
1954         https://bugs.webkit.org/show_bug.cgi?id=104909
1955
1956         Reviewed by Simon Hausmann.
1957
1958         To be able to build redistribuable binary packages, Qt's configure switches
1959         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
1960         dynamically link to optional system libraries.
1961         QtWebKit is doing its own configure checks for those libraries, thus adding a
1962         runtime dependency that might not be fulfilled if the packager's machine had
1963         those libraries while the user's machine won't.
1964
1965         Since in most cases where WebKit will want to use those system libraries, Qt will
1966         also be using them, remove these configure tests from WebKit.
1967
1968         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
1969         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
1970         * qmake/config.tests/libpng/libpng.cpp: Removed.
1971         * qmake/config.tests/libpng/libpng.pro: Removed.
1972         * qmake/mkspecs/features/features.prf:
1973
1974 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1975
1976         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
1977         https://bugs.webkit.org/show_bug.cgi?id=106574
1978
1979         Reviewed by Laszlo Gombos.
1980
1981         Rely on a more recent stable release, which includes support for
1982         Lua 5.2 in Edje and other assorted minor fixes.
1983
1984         While here, also use the "configure" script to build the libraries
1985         instead of relying on autogen.sh, which is not really needed with
1986         a release tarball and may have problems with automake 1.13.
1987
1988         * efl/jhbuild.modules:
1989
1990 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1991
1992         Web Inspector: fix DRT to deliver simulated events to devtools front-end
1993         https://bugs.webkit.org/show_bug.cgi?id=106650
1994
1995         Reviewed by Pavel Feldman.
1996
1997         Add separated m_devToolsTestInterfaces object to testShell which is
1998         bind to devTools webview.
1999
2000         * DumpRenderTree/chromium/TestShell.cpp:
2001         (TestShell::initialize):
2002         (TestShell::createMainWindow):
2003         (TestShell::~TestShell):
2004         (TestShell::showDevTools):
2005         (TestShell::resetTestController):
2006         (TestShell::bindJSObjectsToWindow):
2007         (TestShell::createNewWindow):
2008         * DumpRenderTree/chromium/TestShell.h:
2009         (TestShell):
2010
2011 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2012
2013         Sheriffbot command aliases need test cases
2014         https://bugs.webkit.org/show_bug.cgi?id=106754
2015
2016         Reviewed by Eric Seidel.
2017
2018         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2019         (SheriffBotTest.test_command_aliases):
2020
2021 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2022
2023         Allow users to misspell the "sheriffs" command in sheriffbot
2024         https://bugs.webkit.org/show_bug.cgi?id=106628
2025
2026         Reviewed by Steve Block.
2027
2028         * Scripts/webkitpy/tool/bot/irc_command.py:
2029
2030 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2031
2032         Make "gardeners" an alias for "sheriffs" in sherrifbot
2033         https://bugs.webkit.org/show_bug.cgi?id=106627
2034
2035         Reviewed by Eric Seidel.
2036
2037         * Scripts/webkitpy/tool/bot/irc_command.py:
2038
2039 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2040
2041         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2042         https://bugs.webkit.org/show_bug.cgi?id=105380
2043
2044         Reviewed by Eric Seidel.
2045
2046         Fix a regression introduced in r137692 where we were double-encoding
2047         the arguments to popen(); this was only an issue on windows, where
2048         we would try to encode something to mbcs, then try to encode it
2049         to unicode as if the input as ascii.
2050
2051         * Scripts/webkitpy/common/system/executive.py:
2052         (Executive.run_command):
2053
2054 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2055
2056         State who told sheriffbot to roll the Chromium deps and to what revision
2057         https://bugs.webkit.org/show_bug.cgi?id=106626
2058
2059         Reviewed by Eric Seidel.
2060
2061         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2062
2063         * Scripts/webkitpy/tool/bot/irc_command.py:
2064         (RollChromiumDEPS._expand_irc_nickname):
2065         (RollChromiumDEPS.execute):
2066         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2067         (IRCCommandTest.test_roll_chromium_deps):
2068         * Scripts/webkitpy/tool/bot/sheriff.py:
2069         (Sheriff.post_chromium_deps_roll):
2070         * Scripts/webkitpy/tool/commands/roll.py:
2071         (RollChromiumDEPS._prepare_state):
2072         (PostChromiumDEPSRoll):
2073         (PostChromiumDEPSRoll._prepare_state):
2074         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2075         (PostRollCommandsTest.test_prepare_state):
2076         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2077         (PrepareChangeLogForDEPSRoll.run):
2078
2079 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2080
2081         Add Alan Cutter as contributor
2082         https://bugs.webkit.org/show_bug.cgi?id=106747
2083
2084         Reviewed by Eric Seidel.
2085
2086         * Scripts/webkitpy/common/config/committers.py:
2087
2088 2013-01-13  Jonathan Liu  <net147@gmail.com>
2089
2090         Fix CONFIG missing link_pkgconfig on Windows
2091         https://bugs.webkit.org/show_bug.cgi?id=106647
2092
2093         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2094         properly on Windows because they are added to PKGCONFIG but
2095         CONFIG does not contain link_pkgconfig.
2096
2097         This is because link_pkgconfig is added in unix/default_pre.prf
2098         which is only used for UNIX platforms. To fix this, move it to
2099         the general default_pre.prf.
2100
2101         Reviewed by Simon Hausmann.
2102
2103         * qmake/mkspecs/features/default_pre.prf:
2104         * qmake/mkspecs/features/unix/default_pre.prf:
2105
2106 2013-01-12  Nico Weber  <thakis@chromium.org>
2107
2108         nrwt/chromium: Don't prefer chromium over webkit build directories
2109         https://bugs.webkit.org/show_bug.cgi?id=105597
2110
2111         Reviewed by Dirk Pranke.
2112
2113         Rely on the new timestamp logic instead. Requested by dpranke in
2114         https://bugs.webkit.org/show_bug.cgi?id=105498
2115
2116         * Scripts/webkitpy/layout_tests/port/chromium.py:
2117         (ChromiumPort._static_build_path):
2118         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2119         (ChromiumLinuxPortTest.test_build_path):
2120         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2121         (ChromiumMacPortTest.test_build_path):
2122         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2123         (ChromiumWinTest.test_build_path):
2124
2125 2013-01-12  Nico Weber  <thakis@chromium.org>
2126
2127         Use ninja by default on Linux for build-webkit --chromium, bot edition
2128         https://bugs.webkit.org/show_bug.cgi?id=104434
2129
2130         Reviewed by Eric Seidel.
2131
2132         r139557 changed update-webkit to pick ninja by default on linux, but
2133         the bots run update-webkit-chromium directly so they didn't see this.
2134         Move the default for ninja into update-webkit-chromium so that it's
2135         picked up by the bots, and let update-webkit forward non-default
2136         options to there.
2137
2138         This way, the default is in one place only and both developers (who
2139         usually use update-webkit which then shells out to
2140         updat-webkit-chromium) and bots (which use update-webkit-chromium
2141         directly) see the same behavior.
2142
2143         * Scripts/update-webkit:
2144         * Scripts/update-webkit-chromium:
2145
2146 2013-01-12  Nico Weber  <thakis@chromium.org>
2147
2148         Make ninja the default build system on Linux for build-webkit --chromium
2149         https://bugs.webkit.org/show_bug.cgi?id=104434
2150
2151         Reviewed by Eric Seidel.
2152
2153         * Scripts/update-webkit:
2154
2155 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2156
2157         Migrate the remaining bots in EC2 to Google Compute Engine
2158         https://bugs.webkit.org/show_bug.cgi?id=106005
2159
2160         Reviewed by Eric Seidel.
2161
2162         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2163
2164         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2165         * EWSTools/boot.sh:
2166         * EWSTools/build-repo.sh:
2167         * EWSTools/start-queue.sh:
2168
2169 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2170
2171         [chromium] move inspector related methods to TestRunner library
2172         https://bugs.webkit.org/show_bug.cgi?id=106654
2173
2174         Reviewed by Adam Barth.
2175
2176         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2177         (DRTTestRunner::DRTTestRunner):
2178         * DumpRenderTree/chromium/DRTTestRunner.h:
2179         (DRTTestRunner):
2180         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2181         (WebTestRunner::WebTestDelegate::showDevTools):
2182         (WebTestRunner::WebTestDelegate::closeDevTools):
2183         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2184         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2185         (WebTestRunner::TestRunner::TestRunner):
2186         (WebTestRunner::TestRunner::showWebInspector):
2187         (WebTestRunner):
2188         (WebTestRunner::TestRunner::closeWebInspector):
2189         (WebTestRunner::TestRunner::evaluateInWebInspector):
2190         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2191         (TestRunner):
2192         * DumpRenderTree/chromium/WebViewHost.cpp:
2193         (WebViewHost::showDevTools):
2194         (WebViewHost::closeDevTools):
2195         (WebViewHost::evaluateInWebInspector):
2196         * DumpRenderTree/chromium/WebViewHost.h:
2197         (WebViewHost):
2198
2199 2013-01-11  Julie Parent  <jparent@chromium.org>
2200
2201         Builder should not be a valid parameter for stats dashboard
2202         https://bugs.webkit.org/show_bug.cgi?id=106698
2203
2204         Reviewed by Dirk Pranke.
2205         
2206         Since builder is a dashboard specific parameter, dashboard_base
2207         should not be handling it in handleValidHashParameterWrapper, rather,
2208         each specific dashboard should in its handleValidHashParameter function.
2209     
2210         Note that the FIXME in dashboard_base about this was actually wrong -
2211         we don't want to move it to g_crossDashboardState, because it isn't
2212         actually cross dashboard state.
2213         
2214         In fact, flakiness and treemap have the code in 
2215         handleValidHashParameter, but it is currently dead code because 
2216         dashboard_base gets to it first.
2217         
2218         Added the proper handling to timeline_explorer, since builder is
2219         valid there.
2220
2221         * TestResultServer/static-dashboards/dashboard_base.js:
2222         * TestResultServer/static-dashboards/timeline_explorer.html:
2223
2224 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2225
2226         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2227         https://bugs.webkit.org/show_bug.cgi?id=106688
2228
2229         Reviewed by Eric Seidel.
2230
2231         Update the regular expression used to strip the garbage at the beginning.
2232
2233         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2234         (RunWebKitTests.nrwt_log_message_regexp):
2235
2236 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2237
2238         TestRunner leaks when running tests
2239         https://bugs.webkit.org/show_bug.cgi?id=106683
2240
2241         Reviewed by Simon Fraser.
2242
2243         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2244         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2245         tests.
2246
2247         * DumpRenderTree/TestRunner.cpp:
2248         (TestRunner::makeWindowObject):
2249
2250 2013-01-11  Julie Parent  <jparent@chromium.org>
2251
2252         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2253         https://bugs.webkit.org/show_bug.cgi?id=106247
2254
2255         Old code nulled out the loader instance when it completed loading and
2256         then later used the fact that it was null to determine if it had loaded
2257         or not.  This is not only unintuitive, but it also prevents using the
2258         loader object later on.
2259         
2260         Added new method, used it, added unit test for it.
2261         
2262         Reviewed by Dirk Pranke.
2263
2264         * TestResultServer/static-dashboards/dashboard_base.js:
2265         (resourceLoadingComplete):
2266         (handleLocationChange):
2267         * TestResultServer/static-dashboards/loader.js:
2268         (.):
2269         * TestResultServer/static-dashboards/loader_unittests.js:
2270
2271 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2272
2273         Try CRLF to LF change in r139407 again.
2274
2275         * BuildSlaveSupport/delete-stale-build-files:
2276         (main):
2277         (webkitBuildDirectory):
2278         * BuildSlaveSupport/kill-old-processes:
2279         (main):
2280
2281 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2282
2283         [GTK] Disable the unit tests timeout when running from make check
2284         https://bugs.webkit.org/show_bug.cgi?id=106670
2285
2286         Reviewed by Philippe Normand.
2287
2288         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2289
2290 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2291
2292         Yet another unreviewed fix after r139431.
2293
2294         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2295         the correct order.
2296
2297 2013-01-11  Dan Carney  <dcarney@google.com>
2298
2299         [chromium] move some whitespace and resize related methods to TestRunner library
2300         https://bugs.webkit.org/show_bug.cgi?id=106655
2301
2302         Reviewed by Jochen Eisinger.
2303
2304         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2305         (DRTTestRunner::DRTTestRunner):
2306         * DumpRenderTree/chromium/DRTTestRunner.h:
2307         (DRTTestRunner):
2308         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2309         (WebKit):
2310         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2311         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2312         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2313         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2314         (WebTestRunner::TestRunner::TestRunner):
2315         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2316         (WebTestRunner):
2317         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2318         (WebTestRunner::TestRunner::enableAutoResizeMode):
2319         (WebTestRunner::TestRunner::disableAutoResizeMode):
2320         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2321         (TestRunner):
2322         * DumpRenderTree/chromium/WebViewHost.cpp:
2323         (WebViewHost::setClientWindowRect):
2324         * DumpRenderTree/chromium/WebViewHost.h:
2325         (WebViewHost):
2326
2327 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2328
2329         Unreviewed. Update my e-mail addresses.
2330
2331         * Scripts/webkitpy/common/config/committers.py:
2332
2333 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2334
2335         Another unreviewed fix after r139431.
2336
2337         In a way, this is also a generic bug fix, since previously isEfl()
2338         would fail when called from run-efl-tests and we thus did not use
2339         jhbuild to run our tests. This now resulted in us calling
2340         "jhbuild-wrapper run" without specifying a platform.
2341
2342         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2343         to work.
2344
2345 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2346
2347         [Qt][WK1] Web Audio support
2348         https://bugs.webkit.org/show_bug.cgi?id=106651
2349
2350         Reviewed by Jocelyn Turcotte.
2351
2352         Implements support for dumping audio data in DumpRenderTree.
2353
2354         Adds WebAudio to toggleable features in QtTestBrowser.
2355
2356         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2357         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2358
2359         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2360         (WebCore::DumpRenderTree::dump):
2361         * DumpRenderTree/qt/TestRunnerQt.cpp:
2362         (TestRunner::reset):
2363         (TestRunner::overridePreference):
2364         (TestRunner::setAudioData):
2365         * DumpRenderTree/qt/TestRunnerQt.h:
2366         (TestRunner::shouldDumpAsAudio):
2367         (TestRunner::audioData):
2368         (TestRunner):
2369         * QtTestBrowser/launcherwindow.cpp:
2370         (LauncherWindow::applyPrefs):
2371         (LauncherWindow::createChrome):
2372         (LauncherWindow::toggleWebAudio):
2373         * QtTestBrowser/launcherwindow.h:
2374         (WindowOptions::WindowOptions):
2375         (WindowOptions):
2376         (LauncherWindow):
2377         * qmake/mkspecs/features/features.prf:
2378         * qmake/mkspecs/features/features.pri:
2379
2380 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2381
2382         Unreviewed jhbuild-related fix after r139431.
2383
2384         * Scripts/webkitpy/layout_tests/port/efl.py:
2385         (EflPort.__init__): Pass a string to set_option_default(), since
2386         shlex.split() will be called on it later.
2387
2388 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2389
2390         Unreviewed typo fixes after r139431.
2391
2392         * Scripts/run-javascriptcore-tests:
2393
2394 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2395
2396         [jhbuild] Remove the "run-with-jhbuild" scripts.
2397         https://bugs.webkit.org/show_bug.cgi?id=106572
2398
2399         Reviewed by Martin Robinson.
2400
2401         Both ports which use jhbuild were mostly duplicating the
2402         `run-with-jhbuild' script in their own directories for no clear reason.
2403
2404         The script itself was just a thin wrapper around the `jhbuild-wrapper',
2405         so just start using that directly and get rid of a useless middle man.
2406
2407         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
2408         instead.
2409
2410         * Scripts/run-javascriptcore-tests:
2411         * Scripts/run-launcher:
2412         * Scripts/webkitdirs.pm:
2413         (runAutogenForAutotoolsProjectIfNecessary):
2414         (buildAutotoolsProject):
2415         (jhbuildWrapperPrefixIfNeeded):
2416         (generateBuildSystemFromCMakeProject):
2417         (buildCMakeGeneratedProject):
2418         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2419         (run):
2420         * Scripts/webkitpy/layout_tests/port/efl.py:
2421         (EflPort.__init__):
2422         (EflPort._image_diff_command):
2423         * efl/run-with-jhbuild: Removed.
2424         * gtk/run-with-jhbuild: Removed.
2425
2426 2013-01-11  Alan Cutter  <alancutter@chromium.org>
2427
2428         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
2429         https://bugs.webkit.org/show_bug.cgi?id=106636
2430
2431         Reviewed by Adam Barth.
2432
2433         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
2434
2435         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2436         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2437         * EWSTools/screen-config:
2438         * EWSTools/start-queue.sh:
2439
2440 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         kill-old-processes and delete-stale-build-files use CRLF linebreaks
2443         https://bugs.webkit.org/show_bug.cgi?id=106622
2444
2445         Reviewed by Simon Fraser.
2446
2447         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
2448         Also escape clang\+\+ correctly in kill-old-processes.
2449
2450         * BuildSlaveSupport/delete-stale-build-files:
2451         * BuildSlaveSupport/kill-old-processes:
2452
2453 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2454
2455         Build fix after r139357. It was missing a comma.
2456
2457         * QueueStatusServer/model/queues.py:
2458         (Queue):
2459
2460 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2461
2462         Fixing AuthenticationError when running test-webkitpy as a non-committer.
2463         https://bugs.webkit.org/show_bug.cgi?id=106420
2464
2465         Reviewed by Eric Seidel.
2466
2467         * Scripts/webkitpy/common/checkout/scm/git.py:
2468         (Git.push_local_commits_to_server):
2469         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2470         * Scripts/webkitpy/common/checkout/scm/svn.py:
2471         (SVNRepository):
2472         (SVNRepository.has_authorization_for_realm):
2473
2474 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2475
2476         [EFL][jhbuild] Use tarballs for gstreamer instead of git
2477         https://bugs.webkit.org/show_bug.cgi?id=106552
2478
2479         Reviewed by Laszlo Gombos.
2480
2481         Use tarballs for gstreamer instead of git in EFL's jhbuild
2482         to work around intermittent network issues on our build
2483         bots. Tarballs are fully cached and require no network
2484         operation if their checksum matches.
2485
2486         * efl/jhbuild.modules:
2487
2488 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2489
2490         Add Mac WK2 EWS bots
2491         https://bugs.webkit.org/show_bug.cgi?id=106590
2492
2493         Reviewed by Adam Barth.
2494
2495         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
2496         Also add a deprecated MacWK2Port class.
2497
2498         * QueueStatusServer/model/queues.py:
2499         (Queue):
2500         * Scripts/webkitpy/common/config/ports.py:
2501         (DeprecatedPort.port):
2502         (MacWK2Port):
2503         (MacWK2Port.run_webkit_tests_command):
2504         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2505         (MacEWS):
2506         (MacWK2EWS):
2507         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2508         (_test_ewses):
2509
2510 2013-01-10  Dan Carney  <dcarney@google.com>
2511
2512         [chromium] move webpermissionclient related methods to TestRunner library
2513         https://bugs.webkit.org/show_bug.cgi?id=106548
2514
2515         Reviewed by Jochen Eisinger.
2516
2517         * DumpRenderTree/DumpRenderTree.gypi:
2518         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2519         (DRTTestRunner::DRTTestRunner):
2520         (DRTTestRunner::reset):
2521         * DumpRenderTree/chromium/DRTTestRunner.h:
2522         (DRTTestRunner):
2523         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2524         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
2525         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2526         (WebKit):
2527         (WebTestRunner::WebTestRunner::webPermissions):
2528         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2529         (WebTestRunner::TestRunner::TestRunner):
2530         (WebTestRunner::TestRunner::setDelegate):
2531         (WebTestRunner):
2532         (WebTestRunner::TestRunner::reset):
2533         (WebTestRunner::TestRunner::webPermissions):
2534         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
2535         (WebTestRunner::TestRunner::setImagesAllowed):
2536         (WebTestRunner::TestRunner::setScriptsAllowed):
2537         (WebTestRunner::TestRunner::setStorageAllowed):
2538         (WebTestRunner::TestRunner::setPluginsAllowed):
2539         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
2540         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
2541         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2542         (WebTestRunner):
2543         (TestRunner):
2544         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
2545         (WebTestRunner):
2546         (WebTestRunner::WebPermissions::WebPermissions):
2547         (WebTestRunner::WebPermissions::~WebPermissions):
2548         (WebTestRunner::WebPermissions::allowImage):
2549         (WebTestRunner::WebPermissions::allowScriptFromSource):
2550         (WebTestRunner::WebPermissions::allowStorage):
2551         (WebTestRunner::WebPermissions::allowPlugins):
2552         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
2553         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
2554         (WebTestRunner::WebPermissions::setImagesAllowed):
2555         (WebTestRunner::WebPermissions::setScriptsAllowed):
2556         (WebTestRunner::WebPermissions::setStorageAllowed):
2557         (WebTestRunner::WebPermissions::setPluginsAllowed):
2558         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
2559         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
2560         (WebTestRunner::WebPermissions::setDelegate):
2561         (WebTestRunner::WebPermissions::setDumpCallbacks):
2562         (WebTestRunner::WebPermissions::reset):
2563         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
2564         (WebTestRunner):
2565         (WebPermissions):
2566         * DumpRenderTree/chromium/TestShell.cpp:
2567         (TestShell::initialize):
2568         (TestShell::resetTestController):
2569         (TestShell::createNewWindow):
2570         * DumpRenderTree/chromium/TestShell.h:
2571         (TestShell):
2572         * DumpRenderTree/chromium/WebViewHost.cpp:
2573         (WebViewHost::normalizeLayoutTestURL):
2574         * DumpRenderTree/chromium/WebViewHost.h:
2575         (WebViewHost):
2576
2577 2013-01-10  Alan Cutter  <alancutter@chromium.org>
2578
2579         Split EWS tool cold-boot.sh into modular components
2580         https://bugs.webkit.org/show_bug.cgi?id=106527
2581
2582         Reviewed by Adam Barth.
2583
2584         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
2585         Updated GCE bot build scripts to match.
2586         Unable to test scripts directly as they depend on being in the repository to work!
2587
2588         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2589         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2590         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
2591         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
2592         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
2593
2594 2013-01-10  Julie Parent  <jparent@chromium.org>
2595
2596         Dashboard Cleanup: Do not generate the page if we are about to reload.
2597         https://bugs.webkit.org/show_bug.cgi?id=106584
2598
2599         Reviewed by Dirk Pranke.
2600
2601         Move the logic to determine if we should generate the page into
2602         parseParameters() since that is where we have the knowledge to
2603         determine it, and return that value to handleLocationChange, 
2604         rather than passing the changed parameters back to handleLocationChange
2605         and having it make the decision.
2606         
2607         This is logically equivalent, save one case: when we are about to do
2608         a reload, we know that there is no reason to generate the page.  Old
2609         code was causing an extra page generation in this case.
2610         
2611         * TestResultServer/static-dashboards/dashboard_base.js:
2612         (parseParameters):
2613         (handleLocationChange):
2614
2615 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2616
2617         [jhbuild] Use the "configure" script to build glib
2618         https://bugs.webkit.org/show_bug.cgi?id=106569
2619
2620         Reviewed by Martin Robinson.
2621
2622         So far both EFL and GTK have been using autogen.sh to build glib.
2623         While that does work most of the time, it's not really needed since
2624         we are downloading and building stable releases from tarballs.
2625         Additionally, autogen.sh fails to work with automake 1.13 due to the
2626         usage of some macros that have been removed (this has already been
2627         fixed in glib master).
2628
2629         * efl/jhbuild.modules:
2630         * gtk/jhbuild.modules:
2631
2632 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2633
2634         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2635         (Missed a couple)
2636         https://bugs.webkit.org/show_bug.cgi?id=106536
2637
2638         Reviewed by Eric Seidel.
2639
2640         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2641
2642 2013-01-10  Tony Chang  <tony@chromium.org>
2643
2644         Speed up supplemental dependency computation
2645         https://bugs.webkit.org/show_bug.cgi?id=106503
2646
2647         Reviewed by Adam Barth.
2648
2649         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
2650
2651         * WebKitTestRunner/CMakeLists.txt:
2652
2653 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
2654
2655         Remove the ENABLE_ANIMATION_API feature define occurences
2656         https://bugs.webkit.org/show_bug.cgi?id=106544
2657
2658         Reviewed by Simon Fraser.
2659
2660         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
2661         feature define handling still lingers in various build systems and configurations
2662         but is of no use, so it should be removed.
2663
2664         * Scripts/webkitperl/FeatureList.pm:
2665         * qmake/mkspecs/features/features.pri:
2666
2667 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2668
2669         [GTK] Add support for loading web process extensions
2670         https://bugs.webkit.org/show_bug.cgi?id=105631
2671
2672         Reviewed by Gustavo Noronha Silva.
2673
2674         * MiniBrowser/gtk/GNUmakefile.am:
2675         * MiniBrowser/gtk/main.c:
2676         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
2677         bundle lib from build dir.
2678         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
2679         located in WebProcess/InjectedBundle/API/gtk.
2680         * gtk/generate-gtkdoc:
2681         (get_webkit2_options): Scan also files in
2682         WebProcess/InjectedBundle/API/gtk to generate API docs.
2683         (get_webkit2_options.injected_bundle_src_path): Helper function to
2684         build paths in WebProcess/InjectedBundle/API/gtk.
2685
2686 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2687
2688         [EFL][WK2] Writing immediately to created windows (open) fails
2689         https://bugs.webkit.org/show_bug.cgi?id=105276
2690
2691         Reviewed by Kenneth Rohde Christiansen.
2692
2693         Do not reset 'about:blank' url for the new pages in mini browser.
2694
2695         * MiniBrowser/efl/main.c:
2696         (window_create):
2697
2698 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2699
2700         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2701         https://bugs.webkit.org/show_bug.cgi?id=106536
2702
2703         Reviewed by Eric Seidel.
2704
2705         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2706
2707 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2708
2709         Converting to unittest2 so we can use assertItemsEqual, making tests
2710         not dependent on order of items.
2711         https://bugs.webkit.org/show_bug.cgi?id=106532
2712
2713         Before:
2714         Ran 1733 tests in 38.385s
2715         FAILED (failures=1, errors=22)
2716
2717         After:
2718         Ran 1733 tests in 32.298s
2719         FAILED (failures=0, errors=22)
2720
2721         Reviewed by Eric Seidel.
2722
2723         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2724         * Scripts/webkitpy/thirdparty/__init__.py:
2725         (AutoinstallImportHook._install_unittest2):
2726
2727 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2728
2729         [EFL] Add gstreamer 1.0.5 to jhbuild
2730         https://bugs.webkit.org/show_bug.cgi?id=106178
2731
2732         Reviewed by Laszlo Gombos.
2733
2734         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
2735
2736         * efl/jhbuild.modules:
2737
2738 2013-01-09  Alan Cutter  <alancutter@chromium.org>
2739
2740         Updated parameters in GCE build scripts so they now work.
2741         https://bugs.webkit.org/show_bug.cgi?id=106523
2742
2743         Reviewed by Adam Barth.
2744
2745         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2746         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2747         * EWSTools/cold-boot.sh:
2748
2749 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
2750
2751         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
2752         https://bugs.webkit.org/show_bug.cgi?id=106520
2753
2754         Reviewed by James Robinson.
2755
2756         Part of a larger refactoring series. See tracking bug 82948.
2757
2758         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2759         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2760
2761 2013-01-09  Julie Parent  <jparent@chromium.org>
2762
2763         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
2764         https://bugs.webkit.org/show_bug.cgi?id=106514
2765
2766         This is old code, as these can no longer get out of sync.
2767         permmaLinkURLHash is generated from currentState, which is set only
2768         from the location.  The commment about how these can get out of sync
2769         refers to a function that no longer exists.
2770         
2771         Reviewed by Dirk Pranke.
2772
2773         * TestResultServer/static-dashboards/dashboard_base.js:
2774         (handleLocationChange):
2775
2776 2013-01-09  Julie Parent  <jparent@chromium.org>
2777
2778         Dashboard Cleanup: Reload the page as soon as we know we need to.
2779         https://bugs.webkit.org/show_bug.cgi?id=106515
2780
2781         No need to continue parsing all of the data once we know that
2782         we need to do a reload.
2783         
2784         Reviewed by Dirk Pranke.
2785
2786         * TestResultServer/static-dashboards/dashboard_base.js:
2787         (parseParameters):
2788
2789 2013-01-09  Eric Seidel  <eric@webkit.org>
2790
2791         run-perf-tests --chromium-android --profile should show symbols for the kernel
2792         https://bugs.webkit.org/show_bug.cgi?id=106498
2793
2794         Reviewed by Adam Barth.
2795
2796         Turns out this was easy, once I finally read the output from "perf report".
2797         It appears there may be a bug in "perf record" on android, as it complains
2798         about not being able to read from /proc/kallsyms even when
2799         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
2800         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
2801         but rather just flip it to 0 long enough to grab the /proc/kallsyms
2802         and then flip it back to whatever the device had.
2803
2804         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
2805         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
2806         to symbol names.  Its world-readable, but will return all 0s if you
2807         don't have permission to see the kernel symbols.  kptr_restrict
2808         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
2809         1 is only a specific group, and 2 is "no one, not even root".
2810         By default kptr_restrict is 2 on Android it seems.
2811         More kptr_restrict docs: http://lwn.net/Articles/420403/
2812
2813         I also took this opportunity to clean up how the perf record command
2814         was built for use/display in AndroidPerf.profile_after_exit and
2815         change to always using long-form names for the arguments (to hopefully help readability).
2816
2817         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2818         (AndroidPerf.__init__):
2819         (profile_after_exit):
2820         (ChromiumAndroidDriver.__init__):
2821         (ChromiumAndroidDriver._update_kallsyms_cache):
2822         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2823
2824 2013-01-09  Julie Parent  <jparent@chromium.org>
2825
2826         Dashboard cleanup: remove dead code.
2827         https://bugs.webkit.org/show_bug.cgi?id=106509
2828
2829         Reviewed by Dirk Pranke.
2830
2831         * TestResultServer/static-dashboards/dashboard_base.js:
2832         (parseParameters):
2833
2834 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
2835
2836         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
2837         https://bugs.webkit.org/show_bug.cgi?id=105638
2838
2839         Reviewed by Martin Robinson.
2840
2841         The test was failing for two reasons:
2842         - AccessibilityRenderObject::correspondingLabelForControlElement() was
2843           not ignoring the ARIA labelled-by property
2844         - AccessibilityController::accessibleElementById() was not implemented
2845
2846         Because getting an element by ID cannot be done in the UIProcess, the
2847         decision was made to expose the element's ID as an accessible attribute
2848         of the object.
2849
2850         In addition, fixing the bug in AccessibilityRenderObject made it possible
2851         to eliminate the Gtk platform-specific expectations for another test.
2852
2853         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2854         (childElementById): Added. Walks the tree looking for the AtkObject
2855         Attribute which exposes the HTML element's ID.
2856         (AccessibilityController::accessibleElementById): Implemented.
2857         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2858         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
2859         when there is no title, as is done with the Mac port.
2860         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2861         (WTR):
2862         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2863         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
2864         Attribute which exposes the HTML element's ID.
2865         (WTR):
2866         (WTR::AccessibilityController::accessibleElementById): Implemented.
2867         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2868         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
2869         even when there is no title, as is done with the Mac port.
2870
2871 2013-01-09  Gregg Tavares  <gman@google.com>
2872
2873         Add Gregg Tavares as a committer
2874         https://bugs.webkit.org/show_bug.cgi?id=106492
2875
2876         Unreviewed.
2877
2878         * Scripts/webkitpy/common/config/committers.py:
2879
2880 2013-01-09  Roger Fong  <roger_fong@apple.com>
2881
2882         Enable seamless iFrames for Windows DRT.
2883         https://bugs.webkit.org/show_bug.cgi?id=106468.
2884
2885         Rubberstamped by Timothy Horton.
2886
2887         * DumpRenderTree/win/DumpRenderTree.cpp:
2888         (resetDefaultsToConsistentValues):
2889
2890 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
2891
2892         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
2893         https://bugs.webkit.org/show_bug.cgi?id=93979
2894
2895         Reviewed by Benjamin Poulain.
2896
2897         Implement eventSender.scheduleAsynchronousKeyDown() in
2898         WebKitTestRunner.
2899
2900         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2901         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2902         (WTR::createKeyDownMessageBody):
2903         (WTR::EventSendingController::keyDown):
2904         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2905         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2906         (EventSendingController):
2907         * WebKitTestRunner/TestController.cpp:
2908         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2909         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2910         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2911         * WebKitTestRunner/TestController.h:
2912         (TestController):
2913
2914 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
2915
2916         [chromium] move resource load callback dumping to TestRunner library
2917         https://bugs.webkit.org/show_bug.cgi?id=106449
2918
2919         Reviewed by Adam Barth.
2920
2921         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2922         (DRTTestRunner::DRTTestRunner):
2923         (DRTTestRunner::reset):
2924         * DumpRenderTree/chromium/DRTTestRunner.h:
2925         (DRTTestRunner):
2926         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2927         (WebKit):
2928         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
2929         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2930         (WebKit):
2931         (WebTestProxyBase):
2932         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
2933         (WebTestRunner::WebTestProxy::willRequestResource):
2934         (WebTestRunner::WebTestProxy::willSendRequest):
2935         (WebTestRunner::WebTestProxy::didReceiveResponse):
2936         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
2937         (WebTestRunner::WebTestProxy::didFailResourceLoad):
2938         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2939         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
2940         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
2941         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
2942         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2943         (WebTestRunner::TestRunner::TestRunner):
2944         (WebTestRunner::TestRunner::reset):
2945         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
2946         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
2947         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
2948         (WebTestRunner):
2949         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
2950         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
2951         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
2952         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2953         (TestRunner):
2954         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2955         (WebTestRunner::WebTestProxyBase::reset):
2956         (WebTestRunner):
2957         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2958         (WebTestRunner::WebTestProxyBase::willRequestResource):
2959         (WebTestRunner::WebTestProxyBase::willSendRequest):
2960         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
2961         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
2962         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
2963         * DumpRenderTree/chromium/WebViewHost.cpp:
2964         (WebViewHost::willSendRequest):
2965         (WebViewHost::makeURLErrorDescription):
2966         (WebViewHost::reset):
2967         * DumpRenderTree/chromium/WebViewHost.h:
2968         (WebViewHost):
2969
2970 2013-01-09  Dan Carney  <dcarney@google.com>
2971
2972         [chromium] move dumpcreateview methods to testrunner library
2973         https://bugs.webkit.org/show_bug.cgi?id=106434
2974
2975         Reviewed by Adam Barth.
2976
2977         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2978         (DRTTestRunner::DRTTestRunner):
2979         (DRTTestRunner::reset):
2980         * DumpRenderTree/chromium/DRTTestRunner.h:
2981         (DRTTestRunner):
2982         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2983         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
2984         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2985         (WebTestRunner::TestRunner::TestRunner):
2986         (WebTestRunner::TestRunner::reset):
2987         (WebTestRunner::TestRunner::shouldDumpCreateView):
2988         (WebTestRunner):
2989         (WebTestRunner::TestRunner::dumpCreateView):
2990         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2991         (TestRunner):
2992
2993 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
2994
2995         webkitpy cleanup: Merge additional_comment_text into comment_text
2996         https://bugs.webkit.org/show_bug.cgi?id=106421
2997
2998         Reviewed by Adam Barth.
2999
3000         * Scripts/webkitpy/common/config/committervalidator.py:
3001         (CommitterValidator.reject_patch_from_commit_queue):
3002         (CommitterValidator.reject_patch_from_review_queue):
3003         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3004         (Bugzilla.set_flag_on_attachment):
3005         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3006         (MockBugzilla.set_flag_on_attachment):
3007         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3008         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3009         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3010         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3011
3012 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3013
3014         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3015         https://bugs.webkit.org/show_bug.cgi?id=106464
3016
3017         Reviewed by Martin Robinson.
3018
3019         Current version in jhbuild.modules (2.26.0) is giving trouble to
3020         when trying to build WebKitGTK from scratch, due to a segmentation
3021         fault error in gdk-pixbuf-query-loader during the 'make'
3022         phase. Raising the version to 2.26.5 fixes this issue.
3023
3024         * gtk/jhbuild.modules: Version raised, checksums updated.
3025
3026 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3027
3028         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3029         https://bugs.webkit.org/show_bug.cgi?id=90968.
3030
3031         Reviewed by Csaba Osztrogonác.
3032
3033         Added functionality in DRT and WTR to use any timeout value while running
3034         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3035         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3036         to indicate whether the current port supports setting timeout value
3037         per test (it's False by default; I enabled it only on Qt).
3038         Also corrected a typo in driver.py
3039
3040         * DumpRenderTree/DumpRenderTree.h:
3041         (TestCommand::TestCommand):
3042         (TestCommand):
3043         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3044         (parseInputLine):
3045         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3046         (WebCore::DumpRenderTree::processLine):
3047         * Scripts/webkitpy/layout_tests/port/base.py:
3048         (Port.supports_per_test_timeout):
3049         * Scripts/webkitpy/layout_tests/port/driver.py:
3050         (Driver.run_test):
3051         (Driver._command_from_driver_input):
3052         * Scripts/webkitpy/layout_tests/port/qt.py:
3053         (QtPort.supports_per_test_timeout):
3054         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3055         (WTR::InjectedBundle::InjectedBundle):
3056         (WTR::InjectedBundle::didReceiveMessage):
3057         (WTR::InjectedBundle::beginTesting):
3058         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3059         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3060         (WTR::TestRunner::setCustomTimeout):
3061         (WTR):
3062         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3063         (TestRunner):
3064         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3065         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3066         * WebKitTestRunner/TestController.cpp:
3067         (WTR::TestController::TestController):
3068         (WTR::TestController::getCustomTimeout):
3069         (WTR):
3070         (WTR::TestCommand::TestCommand):
3071         (TestCommand):
3072         (WTR::parseInputLine):
3073         (WTR::TestController::runTest):
3074         (WTR::TestController::runUntil):
3075         * WebKitTestRunner/TestController.h:
3076         (TestController):
3077         * WebKitTestRunner/TestInvocation.cpp:
3078         (WTR::TestInvocation::TestInvocation):
3079         (WTR::TestInvocation::setCustomTimeout):
3080         (WTR):
3081         (WTR::TestInvocation::invoke):
3082         * WebKitTestRunner/TestInvocation.h:
3083         (TestInvocation):
3084
3085 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3086
3087         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3088         https://bugs.webkit.org/show_bug.cgi?id=106290
3089
3090         Reviewed by Martin Robinson.
3091
3092         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3093         the macro isn't enabled.
3094
3095         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3096
3097 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3098
3099         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3100         https://bugs.webkit.org/show_bug.cgi?id=103653
3101
3102         Reviewed by Anders Carlsson.
3103
3104         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3105         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3106         client callback.
3107
3108         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3109         methods to the JavaScript API.
3110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3111         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3112         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3113         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3115         (TestRunner): Added new declarations for the above.
3116         * WebKitTestRunner/TestController.cpp:
3117         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3118         callback.
3119         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3120         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3121         the authentication information passed from the InjectedBundle.
3122         * WebKitTestRunner/TestController.h:
3123         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3124         to communicate with the TestController.
3125         (WTR::TestController::setAuthenticationUsername): Ditto.
3126         (WTR::TestController::setAuthenticationPassword): Ditto.
3127         (TestController):
3128         * WebKitTestRunner/TestInvocation.cpp:
3129         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3130         information from the InjectedBundle.
3131         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3132         text to the TestInvocation text output.
3133         * WebKitTestRunner/TestInvocation.h:
3134         (TestInvocation): Added declaration for new method.
3135
3136 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3137
3138         Add myself as a watcher for Web Geolocation
3139
3140         Unreviewed.
3141
3142         * Scripts/webkitpy/common/config/watchlist:
3143
3144 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3145
3146         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3147         https://bugs.webkit.org/show_bug.cgi?id=106364
3148
3149         Reviewed by Eric Seidel.
3150
3151         When the setup_test_run method is called on the subclasses of the base Port
3152         interface, the parent method should also be called via super(), despite the
3153         parent method not doing anything at the moment.
3154
3155         The according calls to super() are required in the ChromiumPort, EflPort
3156         and GtkPort implementations.
3157
3158         * Scripts/webkitpy/layout_tests/port/chromium.py:
3159         (ChromiumPort.setup_test_run):
3160         * Scripts/webkitpy/layout_tests/port/efl.py:
3161         (EflPort.setup_test_run):
3162         * Scripts/webkitpy/layout_tests/port/gtk.py:
3163         (GtkPort.setup_test_run):
3164
3165 2013-01-08  Julie Parent  <jparent@chromium.org>
3166
3167         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3168         https://bugs.webkit.org/show_bug.cgi?id=106356
3169
3170         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3171         dashboard_base, assigned by Loader, and used only by dashboard_base to
3172         create error messages.  Moved the variables to be privates on the Loader
3173         object, moved error message creation to _getLoadingErrorMessages on the
3174         Loader object, and now pass the errors back to dashboard base via the
3175         resourceLoadingComplete callback.
3176         
3177         Also removed the now unused clearError function, it was only being used
3178         by unit tests to clean up global state.
3179         
3180         Reviewed by Dirk Pranke.
3181
3182         * TestResultServer/static-dashboards/dashboard_base.js:
3183         (resourceLoadingComplete):
3184         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3185         * TestResultServer/static-dashboards/loader.js:
3186         (.):
3187         * TestResultServer/static-dashboards/loader_unittests.js:
3188
3189 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3190
3191         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3192         https://bugs.webkit.org/show_bug.cgi?id=106354
3193
3194         Reviewed by Eric Seidel.
3195
3196         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3197         instead of those two inheriting from it. Also add a mock object of the
3198         sanitizer that's used in unit tests.
3199
3200         * Scripts/webkitpy/layout_tests/port/efl.py:
3201         (EflPort):
3202         (EflPort.__init__):
3203         (EflPort.setup_test_run):
3204         (EflPort.clean_up_test_run):
3205         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3206         importing order.
3207         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3208         * Scripts/webkitpy/layout_tests/port/gtk.py:
3209         (GtkPort):
3210         (GtkPort.__init__):
3211         (GtkPort.setup_test_run):
3212         (GtkPort.clean_up_test_run):
3213         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3214         importing order.
3215         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3216         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3217         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3218         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3219         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3220         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3221         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3222         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3223
3224 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3225
3226         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3227         https://bugs.webkit.org/show_bug.cgi?id=106324
3228
3229         Reviewed by Adam Barth.
3230
3231         Since the frame load callbacks are part of the WebFrameClient, the
3232         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3233         methods.
3234
3235         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3236         (DRTTestRunner::DRTTestRunner):
3237         (DRTTestRunner::reset):
3238         * DumpRenderTree/chromium/DRTTestRunner.h:
3239         (DRTTestRunner):
3240         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3241         (WebTestInterfaces):
3242         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3243         (WebKit):
3244         (WebTestProxyBase):
3245         (WebTestRunner):
3246         (WebTestRunner::WebTestProxy::WebTestProxy):
3247         (WebTestProxy):
3248         (WebTestRunner::WebTestProxy::didInvalidateRect):
3249         (WebTestRunner::WebTestProxy::didScrollRect):
3250         (WebTestRunner::WebTestProxy::scheduleComposite):
3251         (WebTestRunner::WebTestProxy::scheduleAnimation):
3252         (WebTestRunner::WebTestProxy::setWindowRect):
3253         (WebTestRunner::WebTestProxy::show):
3254         (WebTestRunner::WebTestProxy::didAutoResize):
3255         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3256         (WebTestRunner::WebTestProxy::startDragging):
3257         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3258         (WebTestRunner::WebTestProxy::shouldEndEditing):
3259         (WebTestRunner::WebTestProxy::shouldInsertNode):
3260         (WebTestRunner::WebTestProxy::shouldInsertText):
3261         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3262         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3263         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3264         (WebTestRunner::WebTestProxy::didBeginEditing):
3265         (WebTestRunner::WebTestProxy::didChangeSelection):
3266         (WebTestRunner::WebTestProxy::didChangeContents):
3267         (WebTestRunner::WebTestProxy::didEndEditing):
3268         (WebTestRunner::WebTestProxy::registerIntentService):
3269         (WebTestRunner::WebTestProxy::dispatchIntent):
3270         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3271         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3272         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3273         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3274         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3275         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3276         (WebTestRunner::WebTestProxy::didReceiveTitle):
3277         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3278         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3279         (WebTestRunner::WebTestProxy::didFailLoad):
3280         (WebTestRunner::WebTestProxy::didFinishLoad):
3281         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3282         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3283         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3284         (WebTestRunner::WebTestProxy::didDetectXSS):
3285         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3286         (WebTestRunner::WebTestRunner::setTestIsRunning):
3287         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3288         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3289         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3290         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3291         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3292         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3293         (WebTestRunner::TestRunner::TestRunner):
3294         (WebTestRunner::TestRunner::reset):
3295         (WebTestRunner::TestRunner::setTestIsRunning):
3296         (WebTestRunner):
3297         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3298         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3299         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3300         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3301         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3302         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3303         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3304         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3305         (WebTestRunner::TestRunner::dumpTitleChanges):
3306         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3307         (TestRunner):
3308         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3309         (WebTestInterfaces::Internal):
3310         (WebTestRunner::WebTestInterfaces::Internal::webView):
3311         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3312         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3313         (WebTestRunner):
3314         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3315         (WebTestRunner::WebTestInterfaces::setWebView):
3316         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3317         (WebTestRunner::WebTestInterfaces::webView):
3318         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3319         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3320         (WebTestRunner):
3321         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3322         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3323         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3324         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3325         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3326         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3327         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3328         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3329         (WebTestRunner::WebTestProxyBase::didFailLoad):
3330         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3331         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3332         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
3333         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
3334         (WebTestRunner::WebTestProxyBase::didDetectXSS):
3335         * DumpRenderTree/chromium/TestShell.cpp:
3336         (TestShell::runFileTest):
3337         (TestShell::testFinished):
3338         * DumpRenderTree/chromium/TestShell.h:
3339         (TestShell):
3340         * DumpRenderTree/chromium/WebViewHost.cpp:
3341         (WebViewHost::didStartProvisionalLoad):
3342         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3343         (WebViewHost::didFailProvisionalLoad):
3344         (WebViewHost::didCommitProvisionalLoad):
3345         (WebViewHost::didReceiveTitle):
3346         (WebViewHost::didFailLoad):
3347         (WebViewHost::didFinishLoad):
3348         * DumpRenderTree/chromium/WebViewHost.h:
3349         (WebViewHost):
3350
3351 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3352
3353         [GTK] Lower the default timeout value for WebKitTestRunner
3354         https://bugs.webkit.org/show_bug.cgi?id=106353
3355
3356         Reviewed by Dirk Pranke.
3357
3358         The default timeout value for WebKitTestRunner should be lowered.
3359         The current value (80 seconds) is irrational and just leads to producing
3360         text failures for layout tests that genuinely time out. This just leads
3361         to more deviation from the GTK WK1 port in terms of test expectations.
3362
3363         The value used is the same as when running the DumpRenderTree, that's
3364         6 seconds in release builds and 12 seconds in debug builds.
3365
3366         * Scripts/webkitpy/layout_tests/port/gtk.py:
3367         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3368         (GtkPortTest.test_default_timeout_ms):
3369
3370 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3371
3372         test-webkitpy shows failure output on my linux box
3373         https://bugs.webkit.org/show_bug.cgi?id=101261
3374
3375         Reviewed by Eric Seidel.
3376
3377         Mock out the PulseAudioSanitizer methods when creating testing instances
3378         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
3379         PulseAudio output when the sanitizer was trying to unload modules which
3380         were already unloaded by another unit test that was being run in parallel.
3381
3382         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3383         (EflPortTest):
3384         (EflPortTest.make_port):
3385         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3386         (GtkPortTest):
3387         (GtkPortTest.make_port):
3388
3389 2013-01-08  Julie Parent  <jparent@chromium.org>
3390
3391         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
3392         https://bugs.webkit.org/show_bug.cgi?id=106254
3393
3394         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
3395         only to figure out if we should call addBuilderLoadErrors during
3396         handleLocationChange, which was called when the loader completed and on
3397         any hash change, but we only ever wanted to call addBuilderLoadErrors
3398         on the initial loader load.  Moved the call of addBuilderLoadErrors to
3399         resourceLoadingComplete rather than handleLocationChange, so now we
3400         only call it when we want to, and the check can go away completely.
3401
3402         Reviewed by Dirk Pranke.
3403
3404         * TestResultServer/static-dashboards/dashboard_base.js:
3405         (addBuilderLoadErrors):
3406         (resourceLoadingComplete):
3407         (handleLocationChange):
3408         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3409
3410 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
3411
3412         Add aboxhall@chromium.org to accessibility watchlist.
3413
3414         Unreviewed.
3415
3416         * Scripts/webkitpy/common/config/watchlist:
3417
3418 2013-01-08  Dan Winship  <danw@gnome.org>
3419
3420         Add Apache 2.4 support for Fedora 18
3421         https://bugs.webkit.org/show_bug.cgi?id=104478
3422
3423         Reviewed by Martin Robinson.
3424
3425         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
3426         need a separate config.
3427
3428         * Scripts/webkitpy/layout_tests/port/base.py:
3429         (Port._apache_version):
3430         (Port._apache_config_file_name_for_platform):
3431         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3432         * Scripts/run-webkit-httpd:
3433         * Scripts/webkitperl/httpd.pm:
3434         (getApacheVersion):
3435         (getDefaultConfigForTestDirectory):
3436         (getHTTPDConfigPathForTestDirectory):
3437
3438 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3439
3440         Make the override-feature-defines script compatible with Python v3
3441         https://bugs.webkit.org/show_bug.cgi?id=105742
3442
3443         Reviewed by Martin Robinson.
3444
3445         Instead of printing output through a statement, use the print function and format
3446         the output using the str.format method. This makes the script runnable with Python v3.
3447
3448         * gtk/override-feature-defines:
3449         (adjust_feature_defines_makefile):
3450
3451 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
3452
3453         [Qt] Fix libxml2 config test
3454         https://bugs.webkit.org/show_bug.cgi?id=106317
3455
3456         Reviewed by Simon Hausmann.
3457
3458         Don't assume standard include/libxml2, libxml-2.0.pc should know
3459         where it's headers are.
3460
3461         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
3462
3463 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3464
3465         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
3466         https://bugs.webkit.org/show_bug.cgi?id=106195
3467
3468         Reviewed by Philippe Normand.
3469
3470         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
3471         to make the Python code compatible with Python 3. This includes modifying
3472         print statements, exception handling, dictionary iteration and
3473         byte-sequence-to-string conversion.
3474
3475         * gtk/common.py:
3476         (get_build_path):
3477         (pkg_config_file_variable):
3478         (gtk_version_of_pkg_config_file):
3479         * gtk/generate-gtkdoc:
3480         (print_missing_api):
3481         * gtk/gtkdoc.py:
3482         (GTKDoc.__init__):
3483         (GTKDoc._run_command):
3484
3485 2013-01-02  Steve Block  <steveblock@chromium.org>
3486
3487         Add chromium.org email address for Steve Block.
3488
3489         Unreviewed.
3490
3491         * Scripts/webkitpy/common/config/committers.py:
3492
3493 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
3494
3495         Rationalize closure call heuristics and profiling
3496         https://bugs.webkit.org/show_bug.cgi?id=106270
3497
3498         Reviewed by Oliver Hunt.
3499         
3500         Add ability to use display-profiler-output via a pipe, and add the ability to dump
3501         all generated code ('display *' or 'd *').
3502
3503         * Scripts/display-profiler-output:
3504
3505 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3506
3507         Sorted more xcodeproj files.
3508
3509         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3511         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3512
3513 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3514
3515         Sorted xcodeproj files.
3516
3517         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3518         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3519
3520 2013-01-07  Dan Bernstein  <mitz@apple.com>
3521
3522         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
3523         https://bugs.webkit.org/show_bug.cgi?id=106261
3524
3525         Reviewed by Simon Fraser.
3526
3527         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
3528
3529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3530         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
3531         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
3532         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
3533         (TestWebKitAPI):
3534         (TestWebKitAPI::TEST):
3535
3536 2013-01-07  Ojan Vafai  <ojan@chromium.org>
3537
3538         Add the Apple MountainLion bots to garden-o-matic.
3539         Eventually, we really should move away from hardcoding
3540         the list of bots.
3541
3542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3543
3544 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3545
3546         [chromium] move web audio related methods to testrunner library
3547         https://bugs.webkit.org/show_bug.cgi?id=106211
3548
3549         Reviewed by Adam Barth.
3550
3551         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3552         (DRTTestRunner::DRTTestRunner):
3553         (DRTTestRunner::reset):
3554         * DumpRenderTree/chromium/DRTTestRunner.h:
3555         (DRTTestRunner):
3556         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3557         (WebKit):
3558         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
3559         (WebTestRunner::WebTestRunner::audioData):
3560         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3561         (WebTestRunner::TestRunner::TestRunner):
3562         (WebTestRunner::TestRunner::reset):
3563         (WebTestRunner::TestRunner::shouldDumpAsAudio):
3564         (WebTestRunner):
3565         (WebTestRunner::TestRunner::audioData):
3566         (WebTestRunner::TestRunner::setAudioData):
3567         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3568         (TestRunner):
3569         * DumpRenderTree/chromium/TestShell.cpp:
3570         (TestShell::dump):
3571
3572 2013-01-07  Mike West  <mkwst@chromium.org>
3573
3574         Make the IFRAME_SEAMLESS flag runtime-enabled.
3575         https://bugs.webkit.org/show_bug.cgi?id=106213
3576
3577         Reviewed by Ojan Vafai.
3578
3579         * DumpRenderTree/chromium/TestShell.cpp:
3580         (TestShell::TestShell):
3581         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3582         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3583         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3584         (resetDefaultsToConsistentValues):
3585         * DumpRenderTree/mac/DumpRenderTree.mm:
3586         (resetDefaultsToConsistentValues):
3587         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3588         (WebCore::WebPage::resetSettings):
3589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3590         (WTR::InjectedBundle::beginTesting):
3591             Ensure that seamless IFrames are enabled for layout tests in each of
3592             the ports that support seamless IFrames.
3593
3594 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3595
3596         [chromium] move dumpAsText and friends to the TestRunner library
3597         https://bugs.webkit.org/show_bug.cgi?id=106222
3598
3599         Reviewed by Adam Barth.
3600
3601         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
3602
3603         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3604         (DRTTestRunner::DRTTestRunner):
3605         (DRTTestRunner::reset):
3606         * DumpRenderTree/chromium/DRTTestRunner.h:
3607         (DRTTestRunner):
3608         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3609         (WebTestRunner::WebTestRunner::shouldDumpAsText):
3610         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
3611         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
3612         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
3613         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
3614         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
3615         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3616         (WebTestRunner::TestRunner::TestRunner):
3617         (WebTestRunner::TestRunner::reset):
3618         (WebTestRunner::TestRunner::shouldDumpAsText):
3619         (WebTestRunner):
3620         (WebTestRunner::TestRunner::setShouldDumpAsText):
3621         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
3622         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
3623         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
3624         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
3625         (WebTestRunner::TestRunner::dumpAsText):
3626         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
3627         (WebTestRunner::TestRunner::dumpChildFramesAsText):
3628         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3629         (TestRunner):
3630
3631 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3632
3633         Build fix attempt after r138810.
3634
3635         Apparently python 2.6 is really bad at floating point computation.
3636
3637         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3638         (MainTest.test_run_memory_test):
3639
3640 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3641
3642         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
3643         https://bugs.webkit.org/show_bug.cgi?id=106172
3644
3645         Reviewed by Tony Chang.
3646
3647         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
3648         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
3649         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
3650         test on perf-o-matic and perf. test's results page.
3651
3652         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
3653
3654         * Scripts/webkitpy/performance_tests/perftest.py:
3655         (PerfTestMetric): Added.
3656         (PerfTestMetric.__init__): Added.
3657         (PerfTestMetric.metric): Added.
3658         (PerfTestMetric.has_values): Added.
3659         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
3660         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
3661         conversions to be done on the client side (perf-o-matic and results page).
3662         (PerfTestMetric.append): Added.
3663         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
3664         a result for this metric.
3665         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
3666         (PerfTestMetric.compute_statistics): Moved from PerfTest.
3667
3668         (PerfTest._create_driver): Extracted from PerfTest.run.
3669         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
3670         as needed.
3671         (PerfTest._run_with_driver):
3672         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
3673         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
3674         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
3675
3676         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
3677         from other perf tests, there isn't much point in sharing the code here.
3678
3679         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
3680         statistics for the measured values.
3681
3682         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3683         (TestPerfTestMetric): Added.
3684         (TestPerfTestMetric.test_init_set_missing_unit): Added.
3685         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
3686         (TestPerfTestMetric.test_has_values): Added.
3687         (TestPerfTestMetric.test_append): Added.
3688         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
3689         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
3690
3691         (TestPerfTest._assert_results_are_correct): Updated as needed.
3692         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
3693         in PerfTest.run now after generating the results dictionary.
3694         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
3695
3696 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
3697
3698         Support size_t multiplication and division operators on LayoutUnit
3699         https://bugs.webkit.org/show_bug.cgi?id=83848
3700
3701         Reviewed by Emil A Eklund.
3702
3703         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3704         Added some simple tests for the new operators using size_t.
3705
3706 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3707
3708         [Qt] run-webkit-tests cleanup for parallel NRWT
3709         https://bugs.webkit.org/show_bug.cgi?id=106220
3710
3711         Reviewed by Dirk Pranke.
3712
3713         * Scripts/run-webkit-tests:
3714         (useNewRunWebKitTests):
3715         * Scripts/webkitpy/layout_tests/port/qt.py:
3716         (QtPort):
3717         (QtPort.default_child_processes):
3718
3719 2013-01-07  Philippe Normand  <pnormand@igalia.com>
3720
3721         Create a GStreamerAudio watchlist and add myself to it.
3722
3723         Unreviewed.
3724
3725         * Scripts/webkitpy/common/config/watchlist:
3726
3727 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
3728
3729         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
3730         Also removed the empty mac directory.
3731
3732         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
3733         * BuildSlaveSupport/download-built-product: Added property svn:executable.
3734         * BuildSlaveSupport/mac: Removed.
3735         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
3736
3737 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
3738
3739         Add a script to delete stale zero-byte build files
3740         https://bugs.webkit.org/show_bug.cgi?id=106131
3741
3742         Reviewed by Tony Chang.
3743
3744         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
3745
3746         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3747         (DeleteStaleBuildFiles): Added.
3748         (Factory.__init__): Add DeleteStaleBuildFiles step.
3749         * BuildSlaveSupport/delete-stale-build-files: Added.
3750         (main): Delete zero-byte files except ones intentionally generated by our build process.
3751         (webkitBuildDirectory): Copied from build-product-archive.
3752
3753 2013-01-04  Michael Pruett  <michael@68k.org>
3754
3755         [GTK] Fix build error on GTK due to r138836
3756         https://bugs.webkit.org/show_bug.cgi?id=106154
3757
3758         Reviewed by Kentaro Hara.
3759
3760         * GNUmakefile.am:
3761
3762 2013-01-04  Dan Bernstein  <mitz@apple.com>
3763
3764         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
3765         https://bugs.webkit.org/show_bug.cgi?id=106121
3766
3767         Reviewed by Adele Peterson.
3768
3769         Added test for -[DOMTHMLTableCellElement _cellAbove].
3770
3771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3772         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
3773         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
3774         (TestWebKitAPI):
3775         (TestWebKitAPI::expectCellAboveCell):
3776         (TestWebKitAPI::TEST):
3777         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
3778
3779 2013-01-04  Eric Seidel  <eric@webkit.org>
3780
3781         FlakyTestReporter should be re-enabled and taught how to post patches
3782         https://bugs.webkit.org/show_bug.cgi?id=103839
3783
3784         Reviewed by Adam Barth.
3785
3786         This moves LayoutTestResultsReader off of the DeprecatedPort object.
3787         It also adds a real Port object to the EWS and CommitQueue objects
3788         using a new PatchProcessingQueue superclass.
3789         PatchProcessingQueue doesn't seem to be the cleanest insertion point
3790         but works for this purpose.
3791         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
3792         to resolve a FIXME.
3793
3794         This required some hacks/shiming between the non-specific "old"
3795         port names which the EWS system is currently using, and the new
3796         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
3797
3798         Hopefully this will fix the flaky test reporter and results uploading.
3799         Certainly it's another small step towards getting rid of the old ports.py
3800         infrastructure and making the NRWT Port class common webkitpy infrastructure.
3801
3802         Now that DeprecatedPort is no longer used for the results directory
3803         I removed all the explicit results-dir code which webkit-patch was using
3804         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
3805
3806         * Scripts/webkitpy/common/config/ports.py:
3807         (DeprecatedPort.run_perl_unittests_command):
3808         * Scripts/webkitpy/common/config/ports_mock.py:
3809         (MockPort.name):
3810         * Scripts/webkitpy/common/system/outputcapture.py:
3811         (OutputCapture.assert_outputs):
3812         * Scripts/webkitpy/layout_tests/port/apple.py:
3813         (ApplePort.determine_full_port_name):
3814         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3815         (LayoutTestResultsReader.__init__):
3816         (LayoutTestResultsReader):
3817         (LayoutTestResultsReader._read_file_contents):
3818         (LayoutTestResultsReader._create_layout_test_results):
3819         (LayoutTestResultsReader._create_unit_test_results):
3820         (LayoutTestResultsReader.results):
3821         (LayoutTestResultsReader.archive):
3822         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3823         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3824         (LayoutTestResultsReaderTest.test_create_unit_test_results):
3825         (test_missing_unit_test_results_path):
3826         (test_layout_test_results):
3827         (test_archive_last_layout_test_results):
3828         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3829         (AbstractEarlyWarningSystem):
3830         (AbstractEarlyWarningSystem.__init__):
3831         (AbstractEarlyWarningSystem.begin_work_queue):
3832         (AbstractEarlyWarningSystem.run_command):
3833         * Scripts/webkitpy/tool/commands/queues.py:
3834         (AbstractPatchQueue.work_item_log_path):
3835         (PatchProcessingQueue):
3836         (PatchProcessingQueue._new_port_name_from_old):
3837         (PatchProcessingQueue.begin_work_queue):
3838         (PatchProcessingQueue._upload_results_archive_for_patch):
3839         (CommitQueue):
3840         (CommitQueue.begin_work_queue):
3841         (CommitQueue.run_command):
3842         (AbstractReviewQueue):
3843         (AbstractReviewQueue.__init__):
3844         (AbstractReviewQueue.begin_work_queue):
3845         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3846         (AbstractPatchQueueTest.test_next_patch):
3847         (PatchProcessingQueueTest):
3848         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
3849         * Scripts/webkitpy/tool/steps/runtests.py:
3850         (RunTests.run):
3851         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3852
3853 2013-01-04  Dana Jansens  <danakj@chromium.org>
3854
3855         [chromium] Remove lost-compositor-context layout tests
3856         https://bugs.webkit.org/show_bug.cgi?id=106089
3857
3858         Reviewed by James Robinson.
3859
3860         Remove the loseCompositorContext() test function.
3861
3862         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3863         (WebTestRunner::TestRunner::TestRunner):
3864         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3865         (TestRunner):
3866
3867 2013-01-04  Adam Klein  <adamk@chromium.org>
3868
3869         Remove ENABLE_MUTATION_OBSERVERS #define
3870         https://bugs.webkit.org/show_bug.cgi?id=105459
3871
3872         Reviewed by Ryosuke Niwa.
3873
3874         * Scripts/webkitperl/FeatureList.pm:
3875         * qmake/mkspecs/features/features.pri:
3876
3877 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
3878
3879         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
3880         https://bugs.webkit.org/show_bug.cgi?id=106078
3881
3882         Reviewed by Tony Chang.
3883
3884         This patch updates values for individual iterations in dummy performance tests used in
3885         perftest_unittest.py and perftest_integrationtest.py so that they match up with
3886         statistics such as stdev and median reported in those tests. This change is required
3887         to resolve the bug 97510.
3888
3889         This patch also refactors integration tests by extracting *TestData classes that
3890         centralizes the definitions of each dummy performance test's text (DRT output),
3891         runner output, and parsed results (JSON) so that we may share more data between
3892         python tests.
3893
3894         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3895         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
3896         Use self.assertAlmostEqual when comparing the standard deviation.
3897         (MainTest.test_parse_output):
3898         (test_parse_output_with_failing_line):
3899         (test_parse_output_with_description): Use _assert_results_are_correct.
3900         (test_parse_output_with_subtests): Ditto.
3901
3902         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3903         (InspectorPassTestData): Extracted from tests below.
3904         (EventTargetWrapperTestData): Ditto.
3905         (SomeParserTestData): Ditto.
3906         (MemoryTestData): Ditto.
3907         (TestDriver.run_test): Moved test definitions out of the method.
3908         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
3909         (MainTest._load_output_json): Extracted from create_runner.
3910         (MainTest.create_runner):
3911         (MainTest.test_run_test_set_for_parser_tests):
3912         (MainTest.test_run_memory_test):
3913         (MainTest._test_run_with_json_output):
3914         (MainTest.test_run_with_json_output):
3915         (MainTest.test_run_with_description):
3916         (MainTest.test_run_generates_json_by_default):
3917         (MainTest.test_run_merges_output_by_default):
3918         (MainTest.test_run_respects_reset_results):
3919         (MainTest.test_run_generates_and_show_results_page):
3920         (MainTest.test_run_with_slave_config_json):
3921         (MainTest.test_run_with_multiple_repositories):
3922
3923 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
3924
3925         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
3926         https://bugs.webkit.org/show_bug.cgi?id=106045
3927
3928         Reviewed by Carlos Garcia Campos.
3929
3930         Update test results to confirm that compositions without preedits do not trigger
3931         a composition confirmation.
3932
3933         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3934         (TestWebKitAPI::verifyCanceledComposition):
3935
3936 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
3937
3938         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
3939         https://bugs.webkit.org/show_bug.cgi?id=105958
3940
3941         Reviewed by Alexey Proskuryakov.
3942
3943         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
3944
3945         * WebKitTestRunner/mac/EventSenderProxy.mm:
3946         (KeyMappingEntry):
3947         (WTR):
3948         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
3949
3950 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
3951
3952         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
3953         https://bugs.webkit.org/show_bug.cgi?id=106073
3954
3955         Reviewed by Ryosuke Niwa.
3956
3957         Check that the element being compared to is not nil. 
3958         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
3959         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
3960         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
3961         sometimes before on parallel WebKitTestRunner runs.
3962
3963         * DumpRenderTree/AccessibilityUIElement.cpp:
3964         (AccessibilityUIElement::isEqual):
3965         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3966         (WTR::AccessibilityUIElement::isEqual):
3967
3968 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3969
3970         Downloads can be flaky, so try downloading multiple times.
3971         https://bugs.webkit.org/show_bug.cgi?id=105976
3972
3973         Reviewed by Eric Seidel.
3974
3975         * Scripts/webkitpy/common/system/autoinstall.py:
3976         (AutoInstaller._download_to_stream):
3977
3978 2013-01-03  Eric Seidel  <eric@webkit.org>
3979
3980         Rename Tool.port to deprecated_port in preparation for removing more callers
3981         https://bugs.webkit.org/show_bug.cgi?id=106076
3982
3983         Reviewed by Ryosuke Niwa.
3984
3985         This resolves a long-standing FIXME to rename this method. :)
3986
3987         * Scripts/webkitpy/tool/bot/botinfo.py:
3988         (BotInfo.summary_text):
3989         * Scripts/webkitpy/tool/bot/irc_command.py:
3990         (Rollout._update_working_copy):
3991         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3992         (LayoutTestResultsReader._create_layout_test_results):
3993         (LayoutTestResultsReader._create_unit_test_results):
3994         (LayoutTestResultsReader._results_directory):
3995         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3996         (test_missing_unit_test_results_path):
3997         * Scripts/webkitpy/tool/main.py:
3998         (WebKitPatch.deprecated_port):
3999         * Scripts/webkitpy/tool/mocktool.py:
4000         (MockTool.deprecated_port):
4001         * Scripts/webkitpy/tool/steps/build.py:
4002         (Build.build):
4003         * Scripts/webkitpy/tool/steps/checkstyle.py:
4004         (CheckStyle.run):
4005         * Scripts/webkitpy/tool/steps/commit.py:
4006         (Commit._check_test_expectations):
4007         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4008         (PrepareChangeLog.run):
4009         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
4010         (PrepareChangeLogForDEPSRoll.run):
4011         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4012         (PrepareChangeLogForRevert.run):
4013         * Scripts/webkitpy/tool/steps/runtests.py:
4014         (RunTests.run):
4015         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4016         (StepsTest.test_runtests_args):
4017         * Scripts/webkitpy/tool/steps/update.py:
4018         (Update._update_command):
4019
4020 2013-01-03  Eric Seidel  <eric@webkit.org>
4021
4022         Add myself to the webkitpy watchlist.
4023
4024         Unreviewed.
4025
4026         * Scripts/webkitpy/common/config/watchlist:
4027
4028 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
4029
4030         Cleanup perftest* tests and add a test for computing statistics
4031         https://bugs.webkit.org/show_bug.cgi?id=105685
4032
4033         Reviewed by Eric Seidel.
4034
4035         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
4036         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
4037
4038         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
4039
4040         * Scripts/webkitpy/performance_tests/perftest.py:
4041         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
4042         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
4043         accurate result for the mean.
4044         (PageLoadingPerfTest.run_single):
4045         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4046         (MainTest.test_compute_statistics):
4047         (MainTest.test_compute_statistics.compute_statistics): Added.
4048         (TestPageLoadingPerfTest.test_run): floatify values.
4049         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
4050         correctly recognizes them as integers.
4051
4052         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
4053         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
4054         (TestDriver): Moved out of MainTest.
4055         (MainTest): Got rid of assertWritten and all unit tests.
4056         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
4057         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
4058         (MainTest.test_run_test_set_for_parser_tests):
4059         (MainTest.test_run_memory_test):
4060         (MainTest._test_run_with_json_output):
4061         (MainTest.test_run_generates_json_by_default):
4062         (MainTest.test_run_merges_output_by_default):
4063         (MainTest.test_run_respects_reset_results):
4064         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
4065         parsing output JSON files. Just verify that the output path is correct instead.
4066         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4067         (MainTest): Removed all integration tests.
4068         (MainTest.create_runner): Simplified.
4069
4070 2013-01-03  Julie Parent  <jparent@chromium.org>
4071
4072         Dashboard cleanup: remove usage of global g_defaultBuilderName
4073         https://bugs.webkit.org/show_bug.cgi?id=106043
4074
4075         Use now public defaultBuilder() from the BuilderGroup, rather
4076         than global variable.
4077
4078         Also eliminates the setup() and initBuilders() functions since we
4079         no longer need to track the global.
4080
4081         Reviewed by Adam Barth.
4082
4083         * TestResultServer/static-dashboards/builders.js:
4084         (BuilderGroup.prototype.defaultBuilder):
4085         (BuilderGroup.prototype.master):
4086         * TestResultServer/static-dashboards/dashboard_base.js:
4087         (parseParameters):
4088         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4089         (updateDefaultBuilderState):
4090         * TestResultServer/static-dashboards/loader.js:
4091         (.):
4092         * TestResultServer/static-dashboards/loader_unittests.js:
4093
4094 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
4095
4096         Disable an intermittently failing unit test for now.
4097         The failure is tracked by the bug 106051.
4098
4099         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
4100         (TestWebKitAPI::TEST):
4101
4102 2013-01-03  Dan Bernstein  <mitz@apple.com>
4103
4104         No way to obtain a DOMNode given a JS wrapper for a Node
4105         https://bugs.webkit.org/show_bug.cgi?id=106033
4106
4107         Added a test for +[DOMNode _nodeFromJSWrapper:].
4108
4109         Reviewed by Sam Weinig.
4110
4111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4112         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
4113         (TestWebKitAPI):
4114         (TestWebKitAPI::TEST):
4115
4116 2013-01-03  Emil A Eklund  <eae@chromium.org>
4117
4118         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
4119         https://bugs.webkit.org/show_bug.cgi?id=105961
4120
4121         Reviewed by Levi Weintraub.
4122         
4123         Add tests for LayoutUnit::ceil and floor.
4124
4125         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
4126         (TestWebKitAPI::TEST):
4127         (TestWebKitAPI):
4128
4129 2013-01-03  Julie Parent  <jparent@chromium.org>
4130
4131         Add unit test for default builder for the dashboards.
4132         https://bugs.webkit.org/show_bug.cgi?id=105972
4133
4134         Reviewed by Dirk Pranke.
4135
4136         * TestResultServer/static-dashboards/loader_unittests.js:
4137
4138 2013-01-03  Tony Chang  <tony@chromium.org>
4139
4140         Generate internal.settings from Settings.in
4141         https://bugs.webkit.org/show_bug.cgi?id=104740
4142
4143         Reviewed by Adam Barth.
4144
4145         * GNUmakefile.am: Compile new generated files on GTK+.
4146         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
4147         with both extra_sources and add_output_to_sources=false will still
4148         compile the files in extra_sources. This makes it possible to compile
4149         InternalSettingsGenerated.cpp and not be confused by
4150         InternalSettingsGenerated.idl.
4151
4152 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
4153
4154         [style] WebIDL-reflecting uppercase enums reported as style violation
4155         https://bugs.webkit.org/show_bug.cgi?id=105832
4156
4157         Reviewed by Tony Chang.
4158
4159         Recognize the enum as WebIDL-reflecting one if there's a comment present that
4160         indicates this. In enums spanning over multiple lines, the comment is expected
4161         on the first line. In enums placed in one line, the comment is expected at the
4162         end of that line.
4163
4164         WebIDL-reflecting enum values are required to be written in uppercase and as such
4165         violate the common rule of these values being written in InterCaps. Annotating
4166         enums this way makes it possible to avoid false style violation reports.
4167
4168         The comment is of form '// Web(?:Kit)?IDL enum'.
4169
4170         * Scripts/webkitpy/style/checkers/cpp.py:
4171         (_EnumState.__init__):
4172         (_EnumState.process_clean_line):
4173         (check_enum_casing):
4174         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4175         (NoNonVirtualDestructorsTest.test_enum_casing):
4176
4177 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
4178
4179         Adding favicon.ico to the garden-o-matic.
4180         https://bugs.webkit.org/show_bug.cgi?id=105982
4181
4182         Reviewed by Adam Barth.
4183
4184         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
4186
4187 2013-01-03  Jonathan Liu  <net147@gmail.com>
4188
4189         [Qt] Fix library linking order
4190         https://bugs.webkit.org/show_bug.cgi?id=105818
4191
4192         Some Qt libraries are linked before the private static libraries
4193         that depend on them which results in QtWebKit failing to link.
4194
4195         Copy Qt module dependencies from QT to QT_PRIVATE when creating
4196         module to ensure the Qt libraries are linked after the private
4197         static libraries that depend on them.
4198
4199         Reviewed by Tor Arne Vestbø.
4200
4201         * qmake/mkspecs/features/default_post.prf:
4202
4203 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
4204
4205         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
4206         https://bugs.webkit.org/show_bug.cgi?id=102209
4207
4208         Reviewed by Gyuyoung Kim.
4209
4210         Set tooltip on the elm_window instead of ewk_view, and add delay to
4211         show the tooltip window.
4212
4213         Setting tooltip on the ewk_view makes elementary error message because
4214         ewk_view is not an elementary widget. To remove the error message,
4215         tooltip should be set on the elm_window.
4216
4217         Most browsers show the tooltip after a mouse pointer stays on an
4218         element object that has tooltip text.
4219         But elm_tooltip widget itself doesn't have delay or handle mouse
4220         events to show/hide.
4221
4222         So additional codes are added to show/hide tooltip widget along with
4223         mouse events.
4224           1) When a mouse pointer stays for a second on an element which has
4225              tooltip text, then tooltip widget is displayed.
4226           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
4227              widget.
4228
4229         * MiniBrowser/efl/main.c:
4230         (_Tooltip_Information):
4231         (_Browser_Window):
4232         (on_tooltip_show):
4233         (window_tooltip_hide):
4234         (window_tooltip_update):
4235         (on_mouse_in):
4236         (on_mouse_move):
4237         (on_mouse_out):
4238         (window_free):
4239         (on_tooltip_text_set):
4240         (on_tooltip_text_unset):
4241         (window_create):
4242
4243 2013-01-02  Tony Chang  <tony@chromium.org>
4244
4245         Unreviewed, rolling out r138661.
4246         http://trac.webkit.org/changeset/138661
4247         https://bugs.webkit.org/show_bug.cgi?id=104740
4248
4249         Compile problems on EFL
4250
4251         * GNUmakefile.am:
4252         * qmake/mkspecs/features/default_post.prf:
4253
4254 2013-01-02  Tony Chang  <tony@chromium.org>
4255
4256         Generate internal.settings from Settings.in
4257         https://bugs.webkit.org/show_bug.cgi?id=104740
4258
4259         Reviewed by Adam Barth.
4260
4261         * GNUmakefile.am: Compile new generated files on GTK+.
4262         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
4263         with both extra_sources and add_output_to_sources=false will still
4264         compile the files in extra_sources. This makes it possible to compile
4265         InternalSettingsGenerated.cpp and not be confused by
4266         InternalSettingsGenerated.idl.
4267
4268 2013-01-02  Adam Barth  <abarth@webkit.org>
4269
4270         Remove old-run-webkit-tests support from webkitpy
4271         https://bugs.webkit.org/show_bug.cgi?id=105619
4272
4273         Reviewed by Eric Seidel.
4274
4275         This patch removes support for webkitpy parsing the
4276         old-run-webkit-tests results format. There doesn't seem to be any
4277         reason to keep this code around anymore now that most bots have
4278         switched to new-run-webkit-tests.
4279
4280         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4281         (Builder.fetch_layout_test_results):
4282         * Scripts/webkitpy/common/net/layouttestresults.py:
4283         (path_for_layout_test):
4284         (LayoutTestResults.results_from_string):
4285         (LayoutTestResults):
4286         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4287         (LayoutTestResultsTest.test_results_from_string):
4288         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4289         (test_flaky_test_failure):
4290         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4291         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
4292         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4293         (PatchAnalysisTask._test_patch):
4294         * Scripts/webkitpy/tool/commands/queuestest.py:
4295         (QueuesTest.assert_queue_outputs):
4296
4297 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
4298
4299         [Qt][WK2] Add simple UI to find text from page
4300         https://bugs.webkit.org/show_bug.cgi?id=96481
4301
4302         Reviewed by Jocelyn Turcotte.
4303
4304         Find bar that slides between navigation bar and WebView.
4305
4306         * MiniBrowser/qt/BrowserWindow.cpp:
4307         (BrowserWindow::toggleFind):
4308         * MiniBrowser/qt/BrowserWindow.h:
4309         (BrowserWindow):
4310         * MiniBrowser/qt/MiniBrowser.qrc:
4311         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4312         (MiniBrowserApplication::notify):
4313         * MiniBrowser/qt/icons/find.png: Added.
4314         * MiniBrowser/qt/qml/BrowserWindow.qml:
4315