[Qt] Re-generate QtWebKit API forwarding headers when API changes
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         [Qt] Re-generate QtWebKit API forwarding headers when API changes
4
5         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
6         so we need sync.profile to live in the same directory as the project file
7         that will be touched when adding/removing API (api.pri in our case).
8
9         Since the WebKit2 APIs live in a separate static library, we have to
10         add the project file for WebKit2 as a dependency of the api.pri file
11         as well, so that any changes to the WebKit2 API will still trigger a
12         run of qmake (and then syncqt).
13
14         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
15         that the forwarding headers are still generated in the root build dir,
16         not in the Source dir along with the internal forwarding headers.
17
18         Reviewed by Andreas Kling.
19
20         * qmake/mkspecs/features/default_pre.prf:
21         * qmake/mkspecs/features/functions.prf:
22
23 2011-11-23  Johnny Ding  <jnd@chromium.org>
24
25         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
26         https://bugs.webkit.org/show_bug.cgi?id=72950
27
28         Reviewed by Tony Chang.
29
30         * DumpRenderTree/chromium/LayoutTestController.cpp:
31         (LayoutTestController::queueLoadHTMLString):
32
33 2011-11-23  Adam Barth  <abarth@webkit.org>
34
35         garden-o-matic should display a message if it can't find results to display
36         https://bugs.webkit.org/show_bug.cgi?id=72991
37
38         Reviewed by Dimitri Glazkov.
39
40         Not all failures (e.g., TIMEOUT) have results that we can display.
41         This patch adds a short message so that the user can see that we're
42         done trying to load the results.
43
44         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
45         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
46         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
47
48 2011-11-23  Adam Barth  <abarth@webkit.org>
49
50         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
51         https://bugs.webkit.org/show_bug.cgi?id=72992
52
53         Reviewed by Dimitri Glazkov.
54
55         This patch also prepares us to list other sorts of failures, like
56         performance and unit test.
57
58         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
59         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
60         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
61         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
62
63 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
64
65         Add new Chromium tests to the flakiness dashboard
66         https://bugs.webkit.org/show_bug.cgi?id=72997
67
68         Reviewed by Ojan Vafai.
69
70         * TestResultServer/static-dashboards/dashboard_base.js:
71         ():
72
73 2011-11-23  Adam Barth  <abarth@webkit.org>
74
75         garden-o-matic should support AUDIO failures
76         https://bugs.webkit.org/show_bug.cgi?id=69477
77
78         Reviewed by Dimitri Glazkov.
79
80         This is a first iteration at supporting AUDIO failures in
81         garden-o-matic.  We'll probably need to iterate a bit when we have a
82         real audio failure in the tree to play with.  For example, we'll
83         probably want to add and <audio> element to the "Examine" view to hear
84         the differences, but that all can be done in a subsequent patch.
85
86         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
87
88 2011-11-23  Scott Graham  <scottmg@chromium.org>
89
90         Adding gamepad support
91         https://bugs.webkit.org/show_bug.cgi?id=69451
92
93         Reviewed by Darin Fisher.
94
95         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
96         gamepad data that will be retrieved when JS code pulls via API access.
97
98         * DumpRenderTree/DumpRenderTree.gypi:
99         * DumpRenderTree/chromium/GamepadController.cpp: Added.
100         (GamepadController::GamepadController):
101         (GamepadController::bindToJavascript):
102         (GamepadController::reset):
103         (GamepadController::connect):
104         (GamepadController::disconnect):
105         (GamepadController::setId):
106         (GamepadController::setButtonCount):
107         (GamepadController::setButtonData):
108         (GamepadController::setAxisCount):
109         (GamepadController::setAxisData):
110         (GamepadController::fallbackCallback):
111         * DumpRenderTree/chromium/GamepadController.h: Added.
112         * DumpRenderTree/chromium/TestShell.cpp:
113         (TestShell::TestShell):
114         (TestShell::resetTestController):
115         (TestShell::bindJSObjectsToWindow):
116         * DumpRenderTree/chromium/TestShell.h:
117         (TestShell::gamepadController):
118
119 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
120
121         [CMake] Move the top-level logic to the top-level directory.
122         https://bugs.webkit.org/show_bug.cgi?id=72685
123
124         Reviewed by Brent Fulgham.
125
126         * CMakeLists.txt: Added.
127         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
128         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
129         * Scripts/webkitdirs.pm:
130         (generateBuildSystemFromCMakeProject):
131         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
132
133 2011-11-17  Vincent Scheib  <scheib@chromium.org>
134
135         Pointer Lock: Initial Tests for navigator.webkitPonter
136         https://bugs.webkit.org/show_bug.cgi?id=72659
137
138         Reviewed by Darin Fisher.
139
140         * DumpRenderTree/chromium/TestShell.cpp:
141         (TestShell::TestShell):
142             Enabling PointerLock in TestShell
143
144 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
145
146         Update flakiness dashboard for new Chromium builders and tests
147         https://bugs.webkit.org/show_bug.cgi?id=72931
148
149         Reviewed by Ojan Vafai.
150
151         * TestResultServer/static-dashboards/builders.js:
152         * TestResultServer/static-dashboards/dashboard_base.js:
153
154 2011-11-22  Adam Roben  <aroben@apple.com>
155
156         Remove some debugging code I accidentally left in r101005
157
158         * Scripts/prepare-ChangeLog:
159         (get_function_line_ranges_for_python):
160
161 2011-11-22  Adam Roben  <aroben@apple.com>
162
163         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
164
165         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
166         classes/methods in Python source files
167
168         Reviewed by Dan Bates.
169
170         * Scripts/prepare-ChangeLog:
171         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
172         or that use python as their interpreter. Modified the code that extracts the interpreter to
173         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
174         scripts.
175         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
176         for class/def lines and generate ranges based on them.
177
178 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
179
180         [GTK] Enable WebSocket hybi tests
181         https://bugs.webkit.org/show_bug.cgi?id=72870
182
183         Reviewed by Xan Lopez.
184
185         * DumpRenderTree/gtk/DumpRenderTree.cpp:
186         (resetDefaultsToConsistentValues):
187         Reset the setting value to the default value (true).
188         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
189         (LayoutTestController::overridePreference):
190         Change the setting value through a function in DumpRenderTreeSupportGtk.
191
192 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
193
194         ChangeLogEntry should be able to parse entries with multiple authors
195         https://bugs.webkit.org/show_bug.cgi?id=72690
196
197         Reviewed by Eric Seidel.
198
199         Support multi-author change log entries in ChangeLogEntry. Split author names using
200         the same logic as splitting reviewer names. _authors now stores list of dictionaries
201         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
202         accounts because some contributors are never listed in committers.py. 
203
204         * Scripts/webkitpy/common/checkout/changelog.py:
205         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
206         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
207         throws an exception when the argument is None.
208
209 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
210
211         [Qt] Speed up debug builds.
212         https://bugs.webkit.org/show_bug.cgi?id=72882
213
214         Reviewed by Tor Arne Vestbø.
215
216         Introduce a special type of build that replaces the static jsc/wc/wk2
217         static libraries with shared libraries, that individually are much faster
218         to link and don't require relinking into the big library when changing just
219         one file in one module. It can be enabled with
220         --qmakearg="CONFIG+=force_static_libs_as_shared"
221
222         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
223         disable symbol visibility, static linkage and enable rpath.
224         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
225         we need to link the convenience libraries together or not and renamed linkStaticLibrary
226         to just linkLibrary (because linkage is not necessarily static).
227         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
228         link against jsc/wc/wk2 when linking app code against QtWebKit.
229         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
230         function.
231         * qmake/mkspecs/features/webcore.prf: Ditto.
232         * qmake/mkspecs/features/webkit2.prf: Ditto.
233
234 2011-11-21  Adam Klein  <adamk@chromium.org>
235
236         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
237         https://bugs.webkit.org/show_bug.cgi?id=72898
238
239         Reviewed by Ojan Vafai.
240
241         Also removed a comment that was going to be more trouble to keep up to
242         date than seemed worthwhile (the code is now the documentation).
243
244         * TestResultServer/static-dashboards/flakiness_dashboard.html:
245
246 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
247
248         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
249         https://bugs.webkit.org/show_bug.cgi?id=72895
250
251         Reviewed by Chris Fleizach.
252
253         * DumpRenderTree/chromium/WebViewHost.cpp:
254         (WebViewHost::postAccessibilityNotification):
255
256 2011-11-21  Philippe Normand  <pnormand@igalia.com>
257
258         Unreviewed, run-gtk-tests temporary workaround after r98500.
259
260         * Scripts/run-gtk-tests: Try to find the build directory like in
261         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
262
263 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
264
265         [GTK] Add a way to skip unit tests in the bots
266         https://bugs.webkit.org/show_bug.cgi?id=72879
267
268         Reviewed by Philippe Normand.
269
270         Rewrite the script in python to make it easier for everybody to
271         change it and add support for skipping tests.
272
273         * Scripts/run-gtk-tests:
274
275 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
276
277         [EFL] Add more appcache functions to ewk_settings.
278         https://bugs.webkit.org/show_bug.cgi?id=72143
279
280         Reviewed by Kenneth Rohde Christiansen.
281
282         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
283         (LayoutTestController::clearAllApplicationCaches):
284         (LayoutTestController::setAppCacheMaximumSize): Use the right
285         function, this is not related to the memory cache, but rather to the
286         appcache.
287
288 2011-11-18  Adam Roben  <aroben@apple.com>
289
290         Make NRWT consider all lines of output from parse-malloc-history, not just the first
291
292         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
293         found" even when there are more than 1 unique leaks
294
295         Reviewed by Darin Adler.
296
297         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
298         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
299         "^" will be considered to match the beginning of any line, not only the beginning of the
300         string.
301
302         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
303         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
304         fake output and updated expectations to match.
305
306 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
307
308         [Qt] Clean up MiniBrowser project file after recent changes
309         https://bugs.webkit.org/show_bug.cgi?id=72869
310
311         Reviewed by Simon Hausmann.
312
313         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
314
315         * MiniBrowser/qt/MiniBrowser.pro:
316
317 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
318
319         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
320         https://bugs.webkit.org/show_bug.cgi?id=72479
321
322         Reviewed by Chris Fleizach.
323
324         * DumpRenderTree/AccessibilityUIElement.cpp:
325         (getIsSelectedOptionActiveCallback):
326         (AccessibilityUIElement::getJSClass):
327         * DumpRenderTree/AccessibilityUIElement.h:
328         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
329         (AccessibilityUIElement::AccessibilityUIElement):
330         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
331         * DumpRenderTree/chromium/AccessibilityUIElement.h:
332         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
333         (AccessibilityUIElement::isSelectedOptionActive):
334         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
335         (AccessibilityUIElement::isSelectedOptionActive):
336         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
337         (AccessibilityUIElement::isSelectedOptionActive):
338
339 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
340
341         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
342         https://bugs.webkit.org/show_bug.cgi?id=72859
343
344         Reviewed by Eric Seidel.
345         
346         * Scripts/new-run-webkit-websocketserver:
347
348 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
349
350         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
351         https://bugs.webkit.org/show_bug.cgi?id=72655
352
353         Reviewed by Hajime Morita.
354
355         Fixed the calculation of offset.
356
357         * DumpRenderTree/chromium/WebViewHost.cpp:
358         (WebViewHost::finishLastTextCheck):
359
360 2011-11-20  Ojan Vafai  <ojan@chromium.org>
361
362         Change the final place where we use version 3 of the results json output
363         https://bugs.webkit.org/show_bug.cgi?id=72838
364
365         Reviewed by Adam Barth.
366
367         This converts the json from being a flat map of test name --> results
368         to being hierarchical by directory. This will make the json files 
369         considerably smaller.
370
371         Also cleaned up some functions that were returning/checking boolean values
372         that were always True.
373
374         * TestResultServer/model/jsonresults.py:
375         * TestResultServer/model/jsonresults_unittest.py:
376
377 2011-11-20  Ojan Vafai  <ojan@chromium.org>
378
379         Include the master name when querying the test results server.
380         This will soon be required since leaving the master name out mean
381         that multiple files could match the query.
382
383         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
384
385 2011-11-19  Ojan Vafai  <ojan@chromium.org>
386
387         Fix jsonp callback code to add the callback if json content
388         is not jsonp.
389         * TestResultServer/handlers/testfilehandler.py:
390
391 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
392
393         Modify dashboard_base.js to optionally accept version 4 results json.
394
395         Reviewed by Ojan Vafai.
396
397         * TestResultServer/static-dashboards/dashboard_base.js:
398         (ADD_RESULTS):
399         (flattenTrie):
400         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
401         (testFlattenTrie):
402
403 2011-11-19  Ojan Vafai  <ojan@chromium.org>
404
405         Stop storing results files as jsonp in the test results server
406         https://bugs.webkit.org/show_bug.cgi?id=72814
407
408         Reviewed by Adam Barth.
409
410         * TestResultServer/model/jsonresults.py:
411         * TestResultServer/model/jsonresults_unittest.py:
412
413 2011-11-19  Ojan Vafai  <ojan@chromium.org>
414
415         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
416         https://bugs.webkit.org/show_bug.cgi?id=72813
417
418         Reviewed by Adam Barth.
419
420         Once this lands, we can start storing pure json in the test results server and then
421         we can delete the code with all the FIXMEs added here.
422
423         * Scripts/webkitpy/layout_tests/controllers/manager.py:
424         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
425         Only add jsonp for full_results.json.
426         * TestResultServer/model/jsonresults.py:
427         * TestResultServer/model/jsonresults_unittest.py:
428         Accept pure json uploads.
429         * TestResultServer/static-dashboards/dashboard_base.js:
430         (appendJSONScriptElementFor):
431         Use the callback parameter so that the server can start returning pure json if it's left out.
432
433 2011-11-19  Ojan Vafai  <ojan@chromium.org>
434
435         Allow json NRWT downloads to be pure json and not jsonp
436         https://bugs.webkit.org/show_bug.cgi?id=72809
437
438         Reviewed by Adam Barth.
439
440         I'm moving the server to storing and serving up raw json instead of jsonp.
441         You can still get the jsonp by passing a "callback" parameter, but there's no
442         need for run-webkit-tests to get jsonp when all it wants is the raw json.
443
444         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
445         Make the wrapper stripping only happen if the json is actually wrapped.
446         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
447
448 2011-11-18  Daniel Bates  <dbates@rim.com>
449
450         Add CMake build infrastructure for the BlackBerry port
451         https://bugs.webkit.org/show_bug.cgi?id=72768
452
453         Reviewed by Antonio Gomes.
454
455         Add optional --blackberry command line argument to build-webkit to build the
456         BlackBerry port.
457
458         * Scripts/build-webkit:
459         * Scripts/webkitdirs.pm:
460         (determineBaseProductDir):
461         (argumentsForConfiguration):
462         (builtDylibPathForName):
463         (determineIsQt):
464         (isBlackBerry): Added.
465         (determineIsBlackBerry): Added.
466         (blackberryTargetArchitecture): Added.
467         (isAppleWebKit):
468
469 2011-11-18  James Robinson  <jamesr@chromium.org>
470
471         Unreviewed, rolling out r100835.
472         http://trac.webkit.org/changeset/100835
473         https://bugs.webkit.org/show_bug.cgi?id=72778
474
475         Broke some page scale tests
476
477         * DumpRenderTree/chromium/EventSender.cpp:
478         (EventSender::scalePageBy):
479
480 2011-11-18  Adam Barth  <abarth@webkit.org>
481
482         Prepare to move manual-tests out of WebCore
483         https://bugs.webkit.org/show_bug.cgi?id=72782
484
485         Reviewed by Eric Seidel.
486
487         Update this file to refer to the new location of ManualTests.
488
489         * Scripts/webkitpy/common/config/build.py:
490
491 2011-11-18  James Robinson  <jamesr@chromium.org>
492
493         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
494         https://bugs.webkit.org/show_bug.cgi?id=72778
495
496         Reviewed by Kenneth Russell.
497
498         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
499
500         * DumpRenderTree/chromium/EventSender.cpp:
501         (EventSender::scalePageBy):
502
503 2011-11-18  Scott Graham  <scottmg@chromium.org>
504
505         IDL changes for gamepad support
506         https://bugs.webkit.org/show_bug.cgi?id=71753
507
508         Reviewed by Adam Barth.
509
510         Runtime enable gamepad in chromium test shell.
511
512         * DumpRenderTree/chromium/TestShell.cpp:
513         (TestShell::TestShell):
514
515 2011-10-27  Darin Fisher  <darin@chromium.org>
516
517         [chromium] Improve fullscreen API
518         https://bugs.webkit.org/show_bug.cgi?id=70477
519
520         Reviewed by Adam Barth.
521
522         Implement enter/exitFullScreen.  The implementation is asynchronous,
523         via postDelayedTask, to simulate how the browser actually behaves.
524
525         * DumpRenderTree/chromium/WebViewHost.cpp:
526         (WebViewHost::enterFullScreen):
527         (WebViewHost::exitFullScreen):
528         (WebViewHost::setAddressBarURL):
529         (WebViewHost::enterFullScreenNow):
530         (WebViewHost::exitFullScreenNow):
531         * DumpRenderTree/chromium/WebViewHost.h:
532
533 2011-11-18  Adam Roben  <aroben@apple.com>
534
535         Ignore an ANGLE leak that is not WebKit's fault
536
537         * Scripts/old-run-webkit-tests:
538         (countAndPrintLeaks):
539         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
540         (LeakDetector._callstacks_to_exclude_from_leaks):
541         Added ScanFromString to the call stacks to exclude on all OS versions.
542
543 2011-11-18  Adam Roben  <aroben@apple.com>
544
545         Ignore another Lion-specific leak that is not WebKit's fault
546
547         * Scripts/old-run-webkit-tests:
548         (countAndPrintLeaks):
549         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
550         (LeakDetector._callstacks_to_exclude_from_leaks):
551         Added SecTransformExecute to the call stacks to exclude.
552
553 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
554
555         [Qt] Enable WebSocket hybi tests
556         https://bugs.webkit.org/show_bug.cgi?id=72687
557
558         Reviewed by Simon Hausmann.
559
560         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
561
562         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
563         (WebCore::WebPage::resetSettings):
564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
565         (LayoutTestController::overridePreference):
566
567 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
568
569         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
570         https://bugs.webkit.org/show_bug.cgi?id=72707
571
572         Reviewed by Philippe Normand.
573
574         Make new-run-webkit-tests use the right path to locate the test
575         plugin used by WebKitTestRunner.
576
577         * Scripts/webkitpy/layout_tests/port/gtk.py:
578
579 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
580
581         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
582         https://bugs.webkit.org/show_bug.cgi?id=72697
583
584         Reviewed by Kenneth Rohde Christiansen.
585
586         * Tools.pro: Make WTR linux only for the moment.
587         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
588         * WebKitTestRunner/Target.pri: Ditto.
589         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
590         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
591
592 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
593
594         [Qt] Change default size of the MiniBrowser
595
596         Reviewed by Simon Hausmann.
597
598         As we lay out desktop pages using the width of 980, change our default
599         size to 980x735 so that we are not scaling down by default.
600
601         * MiniBrowser/qt/MiniBrowserApplication.h:
602         (WindowOptions::WindowOptions):
603
604 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
605
606         [EFL] Clean up the use of DATA_DIR in the buildsystem
607         https://bugs.webkit.org/show_bug.cgi?id=72681
608
609         Reviewed by Daniel Bates.
610
611         Instead of adding -DDATA_DIR in all scopes, only define it in
612         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
613         it.
614
615         We can then define DATA_DIR to the generated theme directory for
616         EWebLauncher, since it's what we want here.
617
618         * CMakeListsEfl.txt:
619
620 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
621
622         [EFL] Move platform includes last in DRT's include directories.
623         https://bugs.webkit.org/show_bug.cgi?id=72684
624
625         Reviewed by Daniel Bates.
626
627         This is the first step in fixing the build when a platform include (in
628         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
629         is included instead of WebKit's.
630
631         * DumpRenderTree/efl/CMakeLists.txt:
632
633 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
634
635         fuzzy_match doesn't recognize "Dan B" or "hyatt"
636         https://bugs.webkit.org/show_bug.cgi?id=72636
637
638         Reviewed by Eric Seidel.
639
640         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
641         and user names of email addreses such as rniwa in rniwa@webkit.org.
642
643         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
644
645         * Scripts/webkitpy/common/config/committers.py:
646         * Scripts/webkitpy/common/config/committers_unittest.py:
647
648 2011-11-17  Eric Seidel  <eric@webkit.org>
649
650         Remove support for running check-webkit-style w/o a webkit checkout
651         https://bugs.webkit.org/show_bug.cgi?id=72678
652
653         Reviewed by Adam Barth.
654
655         After talking to Dave Levin we've decided to remove this
656         code.  I know of no users of check-webkit-style w/o a webkit checkout
657         and this needlessly adds complexity.
658
659         * Scripts/webkitpy/style/main.py:
660
661 2011-11-17  Eric Seidel  <eric@webkit.org>
662
663         Remove more direct uses of os.path
664         https://bugs.webkit.org/show_bug.cgi?id=72677
665
666         Reviewed by Adam Barth.
667
668         Remove more uses of os.path, including refactoring
669         CommitterValidator to use a Host object instead of
670         manual hacks to emulate what SCM and FileSystem provide.
671
672         * Scripts/webkitpy/common/checkout/changelog.py:
673         * Scripts/webkitpy/common/config/committervalidator.py:
674         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
675         * Scripts/webkitpy/common/system/filesystem_mock.py:
676          - Turns out none of our unittests actually looked at this path.
677            now I've made it be a valid path.
678         * Scripts/webkitpy/tool/bot/feeders.py:
679         * Scripts/webkitpy/tool/commands/queues.py:
680
681 2011-11-17  Eric Seidel  <eric@webkit.org>
682
683         Teach TextFileReader about FileSystem
684         https://bugs.webkit.org/show_bug.cgi?id=72673
685
686         Reviewed by Adam Barth.
687
688         Unfortunately TextFileReader doesn't use FileSystem
689         everywhere yet, so we can't move the unittests to
690         using MockFileSystem, but we're close.
691
692         * Scripts/webkitpy/style/filereader.py:
693         * Scripts/webkitpy/style/filereader_unittest.py:
694         * Scripts/webkitpy/style/main.py:
695
696 2011-11-17  Eric Seidel  <eric@webkit.org>
697
698         Give check-webkit-style a Host
699         https://bugs.webkit.org/show_bug.cgi?id=72670
700
701         Reviewed by Adam Barth.
702
703         * Scripts/webkitpy/common/checkout/scm/detection.py:
704         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
705          - We don't run these unittests, but this one was looking for the wrong exception.
706         * Scripts/webkitpy/style/main.py:
707         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
708          - This was create a new scm object even though it already had one?
709
710 2011-11-17  Eric Seidel  <eric@webkit.org>
711
712         Move check-webkit-style change_directory code to more modern mocks
713         https://bugs.webkit.org/show_bug.cgi?id=72664
714
715         Reviewed by Adam Barth.
716
717         * Scripts/check-webkit-style:
718         * Scripts/webkitpy/style/main.py:
719         * Scripts/webkitpy/style/main_unittest.py:
720
721 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
722
723         [GTK] enable ref tests
724         https://bugs.webkit.org/show_bug.cgi?id=72601
725
726         Re-enable ref tests. Run the driver under evenly numbered display if performing
727         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
728         being run in an already used Xvfb instance if pixel tests are disabled.
729
730         Reviewed by Tony Chang.
731
732         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
733         after the process is killed
734
735 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
736
737         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
738         https://bugs.webkit.org/show_bug.cgi?id=72620
739
740         Reviewed by David Levin.
741
742         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
743         adding the suffix the cpp file. One example of false positive
744         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
745
746         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
747         basename contains the cpp's basename.
748         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
749
750 2011-11-17  Eric Seidel  <eric@webkit.org>
751
752         Move check-webkit-style's guts into webkitpy/style/main.py
753         https://bugs.webkit.org/show_bug.cgi?id=72657
754
755         Reviewed by Adam Barth.
756
757         * Scripts/check-webkit-style:
758         * Scripts/webkitpy/style/main.py:
759
760 2011-11-17  Eric Seidel  <eric@webkit.org>
761
762         new-run-webkit-tests is locale dependent
763         https://bugs.webkit.org/show_bug.cgi?id=68691
764
765         Reviewed by Adam Barth.
766
767         Make NRWT use a clean environment, just like ORWT did.
768
769         * Scripts/webkitpy/layout_tests/port/base.py:
770         * Scripts/webkitpy/layout_tests/port/chromium.py:
771         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
772         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
773         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
774         * Scripts/webkitpy/layout_tests/port/efl.py:
775         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
776         * Scripts/webkitpy/layout_tests/port/mac.py:
777         * Scripts/webkitpy/layout_tests/port/qt.py:
778         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
779         * Scripts/webkitpy/layout_tests/port/webkit.py:
780         * Scripts/webkitpy/layout_tests/port/win.py:
781
782 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
783
784         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
785         https://bugs.webkit.org/show_bug.cgi?id=72615
786
787         Reviewed by James Robinson.
788
789         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
790
791 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
792
793         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
794         https://bugs.webkit.org/show_bug.cgi?id=72595
795
796         Reviewed by Noam Rosenthal.
797
798         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
799         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
800         ensure the registration of the DRTNode JS bindings.
801         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
802         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
803         registration of QWebElement (now done implicitly through QWebPage ->
804         QtWebElementRunTime::initialize code path)
805
806 2011-11-17  Adam Roben  <aroben@apple.com>
807
808         Fix a crash-inducing typo I introduced in r100648
809
810         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
811         handling a crashing test
812
813         Reviewed by Adam Barth.
814
815         * Scripts/webkitpy/layout_tests/port/chromium.py:
816         (ChromiumDriver.run_test): Get the driver name from the port.
817
818         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
819         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
820         right crashed process name.
821
822 2011-11-17  Adam Roben  <aroben@apple.com>
823
824         Fix NRWT's parsing of the number of excluded leaks
825
826         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
827         leaks were excluded
828
829         Reviewed by Adam Barth.
830
831         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
832         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
833         regular expression match, not the entire matched string.
834
835         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
836         (LeakDetectorTest): Added some example output that shows how things look when leaks are
837         excluded.
838         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
839         correctly.
840
841 2011-11-17  Adam Roben  <aroben@apple.com>
842
843         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
844
845         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
846         when web process crashes, but WebProcess crash log should get saved instead
847
848         Reviewed by Eric Seidel.
849
850         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
851         (write_test_result): Simplified a little to share more code between the case where we
852         crashed when running the test and where we crashed when checking the expected rendering for
853         a reftest. Changed to pass the crashed process name down to write_crash_report.
854         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
855         along to CrashLogs.find_newest_log rather than always using the driver name.
856
857         * Scripts/webkitpy/layout_tests/port/chromium.py:
858         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
859         crashed.
860
861         * Scripts/webkitpy/layout_tests/port/test.py:
862         (TestInstance.__init__): Initialize new web_process_crash attribute.
863         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
864         test this patch adds.
865         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
866         specifies that the driver crashed or the web process crashed.
867
868         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
869         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
870         which we pretend the web process crashed rather than the driver process.
871
872         (MainTest.test_run_singly_actually_runs_tests):
873         (MainTest.test_unexpected_failures):
874         (EndToEndTest.test_end_to_end):
875         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
876
877 2011-11-17  Tony Chang  <tony@chromium.org>
878
879         [chromium] stop spamming features warning on every build
880         https://bugs.webkit.org/show_bug.cgi?id=72629
881
882         Reviewed by Ojan Vafai.
883
884         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
885         $mediaStreamSupport is on by default for chromium, make the default
886         for $blobSupport also on.
887
888         * Scripts/build-webkit:
889
890 2011-11-17  Adam Roben  <aroben@apple.com>
891
892         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
893
894         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
895         that are supposed to be ignored
896
897         Reviewed by Adam Barth.
898
899         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
900         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
901         required when passing arguments via the shell (which we aren't doing here). It is not
902         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
903
904         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
905         (LeakDetectorTest.test_leaks_args): Updated expectations.
906
907 2011-11-17  Philippe Normand  <pnormand@igalia.com>
908
909         Unreviewed, run-bindings-tests fix after r91028.
910
911         * Scripts/run-bindings-tests: Use scm.detection module.
912
913 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
914
915         Silence a warning about control reaching the end of a non-void function
916         https://bugs.webkit.org/show_bug.cgi?id=72616
917
918         Reviewed by Tony Gentilcore.
919
920         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
921         (AccessibilityUIElement::verticalScrollbar):
922
923 2011-11-17  Adam Roben  <aroben@apple.com>
924
925         Ignore some leaks in frameworks we link against on Lion
926
927         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
928         aren't WebKit's fault
929
930         Reviewed by Antti Koivisto.
931
932         * Scripts/old-run-webkit-tests:
933         (countAndPrintLeaks):
934         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
935         (LeakDetector._callstacks_to_exclude_from_leaks):
936         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
937
938         * Scripts/webkitpy/layout_tests/port/mac.py:
939         (MacPort.is_lion): Added.
940
941         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
942         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
943         methods.
944
945 2011-11-17  Philippe Normand  <pnormand@igalia.com>
946
947         [GTK] Disable ref tests
948         https://bugs.webkit.org/show_bug.cgi?id=72599
949
950         Reviewed by Xan Lopez.
951
952         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
953         tests to avoid massive flakiness.
954
955 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
956
957         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
958
959         A new extension object has been added to QQuickWebView (the same approach should be used
960         for other API classes that need experimental APIs). The QML extension mechanism is then
961         built on top of the experimental object.
962
963         https://bugs.webkit.org/show_bug.cgi?id=72522
964
965         Reviewed by Simon Hausmann.
966
967         * MiniBrowser/qt/BrowserWindow.cpp:
968         (BrowserWindow::BrowserWindow):
969         (BrowserWindow::webView):
970         * MiniBrowser/qt/BrowserWindow.h:
971         * MiniBrowser/qt/UrlLoader.cpp:
972         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
973         * qmake/mkspecs/features/default_post.prf:
974         * qmake/mkspecs/features/default_pre.prf:
975         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
976         * qmake/mkspecs/features/qtwebkit.prf:
977
978 2011-11-17  Adam Barth  <abarth@webkit.org>
979
980         Move test_results_uploader.py out of layout_package
981         https://bugs.webkit.org/show_bug.cgi?id=72590
982
983         Reviewed by Eric Seidel.
984
985         Most of the lines of code in this file are wrong, but I've restrained
986         myself and only changed a few of them to generalized this class to the
987         common package.
988
989         This is part of a series of patches to remove layout_package.
990
991         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
992         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
993         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
994
995 2011-11-17  Adam Barth  <abarth@webkit.org>
996
997         Unreviewed. Fix style nits in printing.py.
998
999         * Scripts/webkitpy/layout_tests/views/printing.py:
1000
1001 2011-11-17  Adam Barth  <abarth@webkit.org>
1002
1003         Minor style nits in run_webkit_tests.py
1004         https://bugs.webkit.org/show_bug.cgi?id=72583
1005
1006         Reviewed by Eric Seidel.
1007
1008         This patch just fixes some minor style issues as I work my way back
1009         into this code.
1010
1011         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1012
1013 2011-11-17  Adam Barth  <abarth@webkit.org>
1014
1015         Move test_result_writer out of layout_package
1016         https://bugs.webkit.org/show_bug.cgi?id=72586
1017
1018         Rubber-stamped by Eric Seidel.
1019
1020         This is part of a series of patches to remove layout_package.
1021
1022         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1023         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1024         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1025         * Scripts/webkitpy/tool/commands/rebaseline.py:
1026
1027 2011-11-17  Adam Barth  <abarth@webkit.org>
1028
1029         svn-apply shouldn't magically move files into Source anymore
1030         https://bugs.webkit.org/show_bug.cgi?id=72579
1031
1032         Reviewed by Eric Seidel.
1033
1034         The Source directory has existed for long enough that we don't need
1035         svn-apply to magically re-write old-style patches anymore.
1036
1037         * Scripts/VCSUtils.pm:
1038         (parseGitDiffHeader):
1039         (parseSvnDiffHeader):
1040
1041 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1042
1043         Add a list of contribution areas
1044         https://bugs.webkit.org/show_bug.cgi?id=72566
1045
1046         Reviewed by Eric Seidel.
1047
1048         Added ContributionAreas class.
1049
1050         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1051         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1052
1053 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1054
1055         Refactor ChangeLogTest.test_parse_reviewer_text
1056         https://bugs.webkit.org/show_bug.cgi?id=72572
1057
1058         Reviewed by Eric Seidel.
1059
1060         Refactored the test code by introduing two helper functions.
1061
1062         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1063
1064 2011-11-16  Eric Seidel  <eric@webkit.org>
1065
1066         Add SCMDetector object to make scm detection mockable
1067         https://bugs.webkit.org/show_bug.cgi?id=72247
1068
1069         Reviewed by Adam Barth.
1070
1071         I think SCM detection may eventually be rolled into Checkout,
1072         but this patch at least makes it possible to mock code-paths
1073         which rely on scm detection.
1074         In the process of replacing callers of these free-functions
1075         I found that one of the functions was no longer used,
1076         and that one of the callers could instead just use the SCM
1077         object it already had access to through port.host.scm().
1078         I also discovered that I was not calling Host._initialize_scm()
1079         and thus host.scm() was always returning None!
1080
1081         * Scripts/check-webkit-style:
1082         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1083         * Scripts/webkitpy/common/checkout/deps.py:
1084         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1085         * Scripts/webkitpy/common/checkout/scm/detection.py:
1086         * Scripts/webkitpy/common/checkout/scm/git.py:
1087         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1088         * Scripts/webkitpy/common/checkout/scm/svn.py:
1089         * Scripts/webkitpy/common/host.py:
1090         * Scripts/webkitpy/common/host_mock.py:
1091         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1092         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1093         * Scripts/webkitpy/layout_tests/port/base.py:
1094         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1095         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1096         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1097         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1098
1099 2011-11-16  Mark Rowe  <mrowe@apple.com>
1100
1101         Fix the build.
1102
1103         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1104         Apply the workaround that we use in other projects to WebKitTestRunner.
1105
1106         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1107         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1108         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1109
1110 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1111
1112         [Qt] Fix build after WTR AX support
1113         https://bugs.webkit.org/show_bug.cgi?id=72560
1114
1115         Reviewed by Geoffrey Garen.
1116
1117         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1118         * WebKitTestRunner/InjectedBundle/Target.pri:
1119
1120 2011-11-16  Tony Chang  <tony@chromium.org>
1121
1122         repurpose the flexbox bot for grid layout
1123         https://bugs.webkit.org/show_bug.cgi?id=72557
1124
1125         Reviewed by Ryosuke Niwa.
1126
1127         Since new flexbox is enabled everywhere, we don't need this bot
1128         anymore.  However, work on grid layout has begun, so we can use this
1129         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1132         the bot on the waterfall, I will change the slave config to enable
1133         the compile flag and tests.
1134
1135 2011-11-11  Adrienne Walker  <enne@google.com>
1136
1137         [chromium] Expose mock scrollbars to window.internals
1138         https://bugs.webkit.org/show_bug.cgi?id=72195
1139
1140         Reviewed by James Robinson.
1141
1142         Because mock scrollbars are a global setting, reset between runs.
1143
1144         * DumpRenderTree/chromium/WebPreferences.cpp:
1145         (WebPreferences::applyTo):
1146
1147 2011-11-16  James Robinson  <jamesr@chromium.org>
1148
1149         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1150         https://bugs.webkit.org/show_bug.cgi?id=72562
1151
1152         Reviewed by Dirk Pranke.
1153
1154         * DumpRenderTree/chromium/TestShell.cpp:
1155         (TestShell::runFileTest):
1156
1157 2011-11-16  Tony Chang  <tony@chromium.org>
1158
1159         [NRWT] speculative fix for multiple subprocess test on cygwin
1160         https://bugs.webkit.org/show_bug.cgi?id=72518
1161
1162         Reviewed by Adam Barth.
1163
1164         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1165             tries to emulate posix fd behavior.
1166         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1167
1168 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1169
1170         Revert r100509; change was committed twice (first time as r100491).
1171         Unreviewed, build fix.
1172
1173         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1174
1175 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1176
1177         Run a dummy test in the gpu configurations if there's nothing to do.
1178         https://bugs.webkit.org/show_bug.cgi?id=72498
1179
1180         Reviewed by James Robinson.
1181
1182         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1183
1184 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1185
1186         contributors_by_fuzzy_match is super slow
1187         https://bugs.webkit.org/show_bug.cgi?id=72540
1188
1189         Reviewed by Eric Seidel.
1190
1191         Make contributors_by_name do case insensitive search using a dictionary.
1192
1193         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1194         because that's the most common case.
1195
1196         * Scripts/webkitpy/common/config/committers.py:
1197         * Scripts/webkitpy/common/config/committers_unittest.py:
1198
1199 2011-11-16  David Levin  <levin@chromium.org>
1200
1201         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1202         https://bugs.webkit.org/show_bug.cgi?id=72515
1203
1204         Reviewed by Adam Barth.
1205
1206         * Scripts/webkitpy/style/checkers/cpp.py:
1207         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1208
1209 2011-11-16  Tony Chang  <tony@chromium.org>
1210
1211         [NRWT] refactor drivers to require pixel_tests param
1212         https://bugs.webkit.org/show_bug.cgi?id=72517
1213
1214         Reviewed by Ojan Vafai.
1215
1216         No tests, just a refactoring.
1217
1218         * Scripts/webkitpy/layout_tests/port/chromium.py:
1219         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1220         * Scripts/webkitpy/layout_tests/port/webkit.py:
1221         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1222
1223 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1224
1225         Run a dummy test in the gpu configurations if there's nothing to do.
1226         https://bugs.webkit.org/show_bug.cgi?id=72498
1227
1228         Reviewed by James Robinson.
1229
1230         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1231
1232 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1233
1234         WebKitTestRunner needs to support accessibility-related DRT APIs
1235         https://bugs.webkit.org/show_bug.cgi?id=42131
1236
1237         Reviewed by Beth Dakin.
1238
1239         Port the AX code in DRT to WKTestRunner by using IDL.
1240
1241         * DumpRenderTree/AccessibilityUIElement.cpp:
1242         (horizontalScrollbarCallback):
1243         (verticalScrollbarCallback):
1244         (AccessibilityUIElement::horizontalScrollbar):
1245         (AccessibilityUIElement::verticalScrollbar):
1246         (AccessibilityUIElement::getJSClass):
1247         * DumpRenderTree/AccessibilityUIElement.h:
1248         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1249         (AccessibilityUIElement::horizontalScrollbar):
1250         (AccessibilityUIElement::verticalScrollbar):
1251         * WebKitTestRunner/DerivedSources.make:
1252         * WebKitTestRunner/GNUmakefile.am:
1253         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1254         (WTR::AccessibilityController::create):
1255         (WTR::AccessibilityController::AccessibilityController):
1256         (WTR::AccessibilityController::~AccessibilityController):
1257         (WTR::AccessibilityController::makeWindowObject):
1258         (WTR::AccessibilityController::wrapperClass):
1259         (WTR::AccessibilityController::rootElement):
1260         (WTR::AccessibilityController::focusedElement):
1261         (WTR::AccessibilityController::elementAtPoint):
1262         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
1263         (WTR::AccessibilityController::logFocusEvents):
1264         (WTR::AccessibilityController::logValueChangeEvents):
1265         (WTR::AccessibilityController::logScrollingStartEvents):
1266         (WTR::AccessibilityController::logAccessibilityEvents):
1267         (WTR::AccessibilityController::addNotificationListener):
1268         (WTR::AccessibilityController::notificationReceived):
1269         (WTR::AccessibilityController::resetToConsistentState):
1270         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
1271         (WTR::AccessibilityTextMarker::create):
1272         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1273         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
1274         (WTR::AccessibilityTextMarker::platformTextMarker):
1275         (WTR::AccessibilityTextMarker::wrapperClass):
1276         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
1277         (WTR::AccessibilityTextMarker::isEqual):
1278         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
1279         (WTR::AccessibilityTextMarkerRange::create):
1280         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1281         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1282         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
1283         (WTR::AccessibilityTextMarkerRange::wrapperClass):
1284         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
1285         (WTR::AccessibilityTextMarkerRange::isEqual):
1286         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
1287         (WTR::AccessibilityUIElement::create):
1288         (WTR::AccessibilityUIElement::wrapperClass):
1289         (WTR::AccessibilityUIElement::isValid):
1290         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1291         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1292         (WTR::AccessibilityUIElement::isEqual):
1293         (WTR::AccessibilityUIElement::elementAtPoint):
1294         (WTR::AccessibilityUIElement::childAtIndex):
1295         (WTR::AccessibilityUIElement::indexOfChild):
1296         (WTR::AccessibilityUIElement::childrenCount):
1297         (WTR::AccessibilityUIElement::titleUIElement):
1298         (WTR::AccessibilityUIElement::parentElement):
1299         (WTR::AccessibilityUIElement::takeFocus):
1300         (WTR::AccessibilityUIElement::takeSelection):
1301         (WTR::AccessibilityUIElement::addSelection):
1302         (WTR::AccessibilityUIElement::removeSelection):
1303         (WTR::AccessibilityUIElement::allAttributes):
1304         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1305         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1306         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1307         (WTR::AccessibilityUIElement::attributesOfChildren):
1308         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1309         (WTR::AccessibilityUIElement::increment):
1310         (WTR::AccessibilityUIElement::decrement):
1311         (WTR::AccessibilityUIElement::showMenu):
1312         (WTR::AccessibilityUIElement::press):
1313         (WTR::AccessibilityUIElement::stringAttributeValue):
1314         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1315         (WTR::AccessibilityUIElement::numberAttributeValue):
1316         (WTR::AccessibilityUIElement::boolAttributeValue):
1317         (WTR::AccessibilityUIElement::isAttributeSupported):
1318         (WTR::AccessibilityUIElement::isAttributeSettable):
1319         (WTR::AccessibilityUIElement::isActionSupported):
1320         (WTR::AccessibilityUIElement::role):
1321         (WTR::AccessibilityUIElement::subrole):
1322         (WTR::AccessibilityUIElement::roleDescription):
1323         (WTR::AccessibilityUIElement::title):
1324         (WTR::AccessibilityUIElement::description):
1325         (WTR::AccessibilityUIElement::language):
1326         (WTR::AccessibilityUIElement::stringValue):
1327         (WTR::AccessibilityUIElement::accessibilityValue):
1328         (WTR::AccessibilityUIElement::helpText):
1329         (WTR::AccessibilityUIElement::orientation):
1330         (WTR::AccessibilityUIElement::x):
1331         (WTR::AccessibilityUIElement::y):
1332         (WTR::AccessibilityUIElement::width):
1333         (WTR::AccessibilityUIElement::height):
1334         (WTR::AccessibilityUIElement::intValue):
1335         (WTR::AccessibilityUIElement::minValue):
1336         (WTR::AccessibilityUIElement::maxValue):
1337         (WTR::AccessibilityUIElement::valueDescription):
1338         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1339         (WTR::AccessibilityUIElement::selectedTextRange):
1340         (WTR::AccessibilityUIElement::isEnabled):
1341         (WTR::AccessibilityUIElement::isRequired):
1342         (WTR::AccessibilityUIElement::isFocused):
1343         (WTR::AccessibilityUIElement::isFocusable):
1344         (WTR::AccessibilityUIElement::isSelected):
1345         (WTR::AccessibilityUIElement::isSelectable):
1346         (WTR::AccessibilityUIElement::isMultiSelectable):
1347         (WTR::AccessibilityUIElement::setSelectedChild):
1348         (WTR::AccessibilityUIElement::selectedChildrenCount):
1349         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1350         (WTR::AccessibilityUIElement::isExpanded):
1351         (WTR::AccessibilityUIElement::isChecked):
1352         (WTR::AccessibilityUIElement::isVisible):
1353         (WTR::AccessibilityUIElement::isOffScreen):
1354         (WTR::AccessibilityUIElement::isCollapsed):
1355         (WTR::AccessibilityUIElement::isIgnored):
1356         (WTR::AccessibilityUIElement::hasPopup):
1357         (WTR::AccessibilityUIElement::hierarchicalLevel):
1358         (WTR::AccessibilityUIElement::clickPointX):
1359         (WTR::AccessibilityUIElement::clickPointY):
1360         (WTR::AccessibilityUIElement::documentEncoding):
1361         (WTR::AccessibilityUIElement::documentURI):
1362         (WTR::AccessibilityUIElement::url):
1363         (WTR::AccessibilityUIElement::speak):
1364         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1365         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1366         (WTR::AccessibilityUIElement::attributesOfColumns):
1367         (WTR::AccessibilityUIElement::attributesOfRows):
1368         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1369         (WTR::AccessibilityUIElement::attributesOfHeader):
1370         (WTR::AccessibilityUIElement::indexInTable):
1371         (WTR::AccessibilityUIElement::rowIndexRange):
1372         (WTR::AccessibilityUIElement::columnIndexRange):
1373         (WTR::AccessibilityUIElement::rowCount):
1374         (WTR::AccessibilityUIElement::columnCount):
1375         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1376         (WTR::AccessibilityUIElement::disclosedByRow):
1377         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1378         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1379         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1380         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1381         (WTR::AccessibilityUIElement::ariaDropEffects):
1382         (WTR::AccessibilityUIElement::lineForIndex):
1383         (WTR::AccessibilityUIElement::rangeForLine):
1384         (WTR::AccessibilityUIElement::boundsForRange):
1385         (WTR::AccessibilityUIElement::setSelectedTextRange):
1386         (WTR::AccessibilityUIElement::stringForRange):
1387         (WTR::AccessibilityUIElement::attributedStringForRange):
1388         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1389         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1390         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1391         (WTR::AccessibilityUIElement::horizontalScrollbar):
1392         (WTR::AccessibilityUIElement::verticalScrollbar):
1393         (WTR::AccessibilityUIElement::addNotificationListener):
1394         (WTR::AccessibilityUIElement::removeNotificationListener):
1395         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1396         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1397         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1398         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1399         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1400         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1401         (WTR::AccessibilityUIElement::textMarkerForPoint):
1402         (WTR::AccessibilityUIElement::previousTextMarker):
1403         (WTR::AccessibilityUIElement::nextTextMarker):
1404         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1405         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1406         (WTR::AccessibilityUIElement::platformUIElement):
1407         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1408         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1409         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1410         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1411         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1412         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1413         (WTR::InjectedBundle::beginTesting):
1414         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1415         (WTR::InjectedBundle::accessibilityController):
1416         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1417         (WTR::InjectedBundlePage::didClearWindowForFrame):
1418         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1419         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1420         (WTR::LayoutTestController::platformName):
1421         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1422         (WTR::AccessibilityTextMarker::isEqual):
1423         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1424         (WTR::AccessibilityTextMarkerRange::isEqual):
1425         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1426         (+[NSString stringWithJSStringRef:]):
1427         (-[NSString createJSStringRef]):
1428         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1429         (-[AccessibilityNotificationHandler dealloc]):
1430         (-[AccessibilityNotificationHandler _notificationReceived:]):
1431         (-[AccessibilityNotificationHandler setCallback:]):
1432         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1433         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1434         (WTR::AccessibilityUIElement::isEqual):
1435         (WTR::descriptionOfValue):
1436         (WTR::attributesOfElement):
1437         (WTR::concatenateAttributeAndValue):
1438         (WTR::convertNSArrayToVector):
1439         (WTR::descriptionOfElements):
1440         (WTR::AccessibilityUIElement::getLinkedUIElements):
1441         (WTR::AccessibilityUIElement::getDocumentLinks):
1442         (WTR::AccessibilityUIElement::getChildren):
1443         (WTR::AccessibilityUIElement::getChildrenWithRange):
1444         (WTR::AccessibilityUIElement::childrenCount):
1445         (WTR::AccessibilityUIElement::elementAtPoint):
1446         (WTR::AccessibilityUIElement::indexOfChild):
1447         (WTR::AccessibilityUIElement::childAtIndex):
1448         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1449         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1450         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1451         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1452         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1453         (WTR::AccessibilityUIElement::selectedChildrenCount):
1454         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1455         (WTR::AccessibilityUIElement::titleUIElement):
1456         (WTR::AccessibilityUIElement::parentElement):
1457         (WTR::AccessibilityUIElement::disclosedByRow):
1458         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1459         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1460         (WTR::AccessibilityUIElement::attributesOfChildren):
1461         (WTR::AccessibilityUIElement::allAttributes):
1462         (WTR::AccessibilityUIElement::stringAttributeValue):
1463         (WTR::AccessibilityUIElement::numberAttributeValue):
1464         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1465         (WTR::AccessibilityUIElement::boolAttributeValue):
1466         (WTR::AccessibilityUIElement::isAttributeSettable):
1467         (WTR::AccessibilityUIElement::isAttributeSupported):
1468         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1469         (WTR::AccessibilityUIElement::role):
1470         (WTR::AccessibilityUIElement::subrole):
1471         (WTR::AccessibilityUIElement::roleDescription):
1472         (WTR::AccessibilityUIElement::title):
1473         (WTR::AccessibilityUIElement::description):
1474         (WTR::AccessibilityUIElement::orientation):
1475         (WTR::AccessibilityUIElement::stringValue):
1476         (WTR::AccessibilityUIElement::language):
1477         (WTR::AccessibilityUIElement::helpText):
1478         (WTR::AccessibilityUIElement::x):
1479         (WTR::AccessibilityUIElement::y):
1480         (WTR::AccessibilityUIElement::width):
1481         (WTR::AccessibilityUIElement::height):
1482         (WTR::AccessibilityUIElement::clickPointX):
1483         (WTR::AccessibilityUIElement::clickPointY):
1484         (WTR::AccessibilityUIElement::intValue):
1485         (WTR::AccessibilityUIElement::minValue):
1486         (WTR::AccessibilityUIElement::maxValue):
1487         (WTR::AccessibilityUIElement::valueDescription):
1488         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1489         (WTR::AccessibilityUIElement::isActionSupported):
1490         (WTR::AccessibilityUIElement::isEnabled):
1491         (WTR::AccessibilityUIElement::isRequired):
1492         (WTR::AccessibilityUIElement::isFocused):
1493         (WTR::AccessibilityUIElement::isSelected):
1494         (WTR::AccessibilityUIElement::isExpanded):
1495         (WTR::AccessibilityUIElement::isChecked):
1496         (WTR::AccessibilityUIElement::hierarchicalLevel):
1497         (WTR::AccessibilityUIElement::speak):
1498         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1499         (WTR::AccessibilityUIElement::ariaDropEffects):
1500         (WTR::AccessibilityUIElement::lineForIndex):
1501         (WTR::AccessibilityUIElement::rangeForLine):
1502         (WTR::AccessibilityUIElement::boundsForRange):
1503         (WTR::AccessibilityUIElement::stringForRange):
1504         (WTR::AccessibilityUIElement::attributedStringForRange):
1505         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1506         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1507         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1508         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1509         (WTR::AccessibilityUIElement::attributesOfColumns):
1510         (WTR::AccessibilityUIElement::attributesOfRows):
1511         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1512         (WTR::AccessibilityUIElement::attributesOfHeader):
1513         (WTR::AccessibilityUIElement::rowCount):
1514         (WTR::AccessibilityUIElement::columnCount):
1515         (WTR::AccessibilityUIElement::indexInTable):
1516         (WTR::AccessibilityUIElement::rowIndexRange):
1517         (WTR::AccessibilityUIElement::columnIndexRange):
1518         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1519         (WTR::AccessibilityUIElement::horizontalScrollbar):
1520         (WTR::AccessibilityUIElement::verticalScrollbar):
1521         (WTR::AccessibilityUIElement::selectedTextRange):
1522         (WTR::AccessibilityUIElement::setSelectedTextRange):
1523         (WTR::AccessibilityUIElement::increment):
1524         (WTR::AccessibilityUIElement::decrement):
1525         (WTR::AccessibilityUIElement::showMenu):
1526         (WTR::AccessibilityUIElement::press):
1527         (WTR::AccessibilityUIElement::setSelectedChild):
1528         (WTR::AccessibilityUIElement::accessibilityValue):
1529         (WTR::AccessibilityUIElement::documentEncoding):
1530         (WTR::AccessibilityUIElement::documentURI):
1531         (WTR::AccessibilityUIElement::url):
1532         (WTR::AccessibilityUIElement::addNotificationListener):
1533         (WTR::AccessibilityUIElement::removeNotificationListener):
1534         (WTR::AccessibilityUIElement::isFocusable):
1535         (WTR::AccessibilityUIElement::isSelectable):
1536         (WTR::AccessibilityUIElement::isMultiSelectable):
1537         (WTR::AccessibilityUIElement::isVisible):
1538         (WTR::AccessibilityUIElement::isOffScreen):
1539         (WTR::AccessibilityUIElement::isCollapsed):
1540         (WTR::AccessibilityUIElement::isIgnored):
1541         (WTR::AccessibilityUIElement::hasPopup):
1542         (WTR::AccessibilityUIElement::takeFocus):
1543         (WTR::AccessibilityUIElement::takeSelection):
1544         (WTR::AccessibilityUIElement::addSelection):
1545         (WTR::AccessibilityUIElement::removeSelection):
1546         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1547         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1548         (WTR::AccessibilityUIElement::previousTextMarker):
1549         (WTR::AccessibilityUIElement::nextTextMarker):
1550         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1551         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1552         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1553         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1554         (WTR::AccessibilityUIElement::textMarkerForPoint):
1555         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1556         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1557         (WTR::LayoutTestController::platformName):
1558         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1559         (WTR::LayoutTestController::platformName):
1560         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1561         (WTR::LayoutTestController::platformName):
1562         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1563         * WebKitTestRunner/win/InjectedBundle.vcproj:
1564
1565 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1566
1567         [Qt] Fix use of config.tests
1568
1569         We were checking @buildArgs to determine if the optional argument was
1570         passed or not, but this is not the right way to do that in Perl. The
1571         right way is to not use a prototype for the function, and to pass
1572         the list as a reference (to avoid list expansion). That way we can
1573         check the number of arguments, and choose the right code path based
1574         on that.
1575
1576         We were also missing a default-value of 0 for any feature that's not
1577         set in features.prf.
1578
1579         Reviewed by Kenneth Rohde Christiansen.
1580
1581         * Scripts/build-webkit:
1582         * Scripts/webkitdirs.pm:
1583         (qtFeatureDefaults):
1584         (buildQMakeProject):
1585
1586 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1587
1588         [Qt] Prospective fix for broken plugin tests
1589
1590         Don't hide symbols for the NPAPI test plugin
1591
1592         Rubber-stamped by Andreas Kling.
1593
1594         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1595
1596 2011-11-16  Adam Roben  <aroben@apple.com>
1597
1598         Move filenames/line numbers off to the right edge in Leaks Viewer
1599
1600         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1601         because filenames/line numbers are right next to function names
1602
1603         Reviewed by Andreas Kling.
1604
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1606         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1607         function name. Use the filename as the profile node's URL (we don't have enough info to
1608         compute a real URL currently) and the line number as the profile node's line number so the
1609         Inspector code will put them on the right side of the callstack graph.
1610
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1612         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1613         passed here, just filenames.
1614
1615         (WebInspector.linkifyURLAsNode):
1616         (WebInspector.linkifyResourceAsNode):
1617         Copied and slightly modified from inspector.js.
1618
1619 2011-11-16  Adam Roben  <aroben@apple.com>
1620
1621         Make Leaks Viewer load builds from the new Lion Leaks bot
1622
1623         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1624
1625         Reviewed by Andreas Kling.
1626
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1628         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1629         SnowLeopard one.
1630
1631 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1632
1633         [EFL] Clean up the offline apps-related functions in ewk_settings.
1634         https://bugs.webkit.org/show_bug.cgi?id=72132
1635
1636         Reviewed by Kenneth Rohde Christiansen.
1637
1638         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1639         prefixes for code that is related only to the HTML5 app cache
1640         features.
1641
1642         Use `ewk_settings_application_cache' and
1643         `ewk_view_setting_application_cache' instead.
1644
1645         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1646         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1647
1648 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1649
1650         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1651
1652         Reviewed by Tor Arne Vestbø.
1653
1654         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1655         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1656         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1657         removes the .so.0.0.0 and just produces .so.
1658
1659 2011-11-16  Peter Beverloo  <peter@chromium.org>
1660
1661         Explicitly include unistd.h in TestNetscapePlugIn
1662         https://bugs.webkit.org/show_bug.cgi?id=72385
1663
1664         This is needed for the sleep() call in the indicateTestFailure method,
1665         which seems to be implicitly available for other platforms. This is not
1666         the case on Android.
1667
1668         Reviewed by Steve Block.
1669
1670         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1671
1672 2011-11-16  Peter Beverloo  <peter@chromium.org>
1673
1674         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1675         https://bugs.webkit.org/show_bug.cgi?id=72384
1676
1677         Update to Android NDK r7, which was released last Friday. This adds
1678         support for RTTI and the -mimplicit-it gcc flag, which are required to
1679         respectively build ICU and Skia.
1680
1681         Reviewed by Steve Block.
1682
1683         * Scripts/update-webkit-chromium:
1684         * Scripts/webkitdirs.pm:
1685         (buildChromiumMakefile):
1686
1687 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1688
1689         Unreviewed, rolling out r100266.
1690         http://trac.webkit.org/changeset/100266
1691
1692         Broke WTR.
1693
1694         * qmake/mkspecs/features/default_post.prf:
1695
1696 2011-11-16  Eric Seidel  <eric@webkit.org>
1697
1698         check-webkit-style broken by r99773: "Could not determine the port"
1699         https://bugs.webkit.org/show_bug.cgi?id=72275
1700
1701         Reviewed by Adam Barth.
1702
1703         I will continue engaging hacks, until windows improves.
1704
1705         * Scripts/webkitpy/common/host.py:
1706          - Host uses self.executive instead of self._executive like Port does.
1707          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1708
1709 2011-11-16  Eric Seidel  <eric@webkit.org>
1710
1711         check-webkit-style broken by r99773: "Could not determine the port"
1712         https://bugs.webkit.org/show_bug.cgi?id=72275
1713
1714         Reviewed by Adam Barth.
1715
1716         Engage windows hacks harder.
1717
1718         This is a speculative fix for ChromiumWin.  We're now
1719         creating an SCM object much earlier, so we need to
1720         engage our "awesome" windows hacks earlier.
1721
1722         * Scripts/webkitpy/common/host.py:
1723         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1724
1725 2011-11-15  Darin Adler  <darin@apple.com>
1726
1727         DRT's uiElementAttributeValueCallback function is leaky
1728         https://bugs.webkit.org/show_bug.cgi?id=72453
1729
1730         Reviewed by Dan Bernstein.
1731
1732         * DumpRenderTree/AccessibilityUIElement.cpp:
1733         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1734
1735 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1736
1737         Implement edit-distance based reviewer recognition algorithm
1738         https://bugs.webkit.org/show_bug.cgi?id=72351
1739
1740         Reviewed by Eric Seidel.
1741
1742         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1743         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1744         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1745         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1746
1747         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1748         the edit distance is implemented in edit_distance.py.
1749
1750         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1751         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1752
1753         * Scripts/webkitpy/common/checkout/changelog.py:
1754         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1755         * Scripts/webkitpy/common/config/committers.py:
1756         * Scripts/webkitpy/common/config/committers_unittest.py:
1757         * Scripts/webkitpy/common/editdistance.py: Added.
1758         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1759         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1760         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1761
1762 2011-11-15  Tony Chang  <tony@chromium.org>
1763
1764         Skip a failing webkitpy test on cygwin.
1765
1766         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1767
1768 2011-11-15  Sam Weinig  <sam@webkit.org>
1769
1770         TestWebKitAPI should not put its resources in the root products directory
1771         https://bugs.webkit.org/show_bug.cgi?id=72446
1772
1773         Reviewed by Anders Carlsson.
1774
1775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1776         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1777         directory.
1778
1779         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1780         (TEST_F):
1781         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1782         (TestWebKitAPI::TEST):
1783         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1784         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1785         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1786         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1787         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1788         (TestWebKitAPI::Util::createURLForResource):
1789         Update calls to retrieve files from the bundle to look in the newly
1790         created subdirectory.
1791
1792 2011-11-15  Tony Chang  <tony@chromium.org>
1793
1794         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1795
1796         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1797
1798 2011-11-15  Tony Chang  <tony@chromium.org>
1799
1800         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1801         earlier.
1802
1803         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1804         * Scripts/webkitpy/layout_tests/port/webkit.py:
1805
1806 2011-11-15  James Robinson  <jamesr@chromium.org>
1807
1808         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1809         https://bugs.webkit.org/show_bug.cgi?id=72444
1810
1811         Reviewed by Adam Barth.
1812
1813         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1814
1815 2011-11-15  Tony Chang  <tony@chromium.org>
1816
1817         Unreviewed, better fix for ref tests failures on SL Intel bot.
1818         Revert the previous change and return None if pixel results from
1819         either the test page or the expected page is missing.
1820
1821         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1822         * Scripts/webkitpy/layout_tests/port/webkit.py:
1823
1824 2011-11-15  James Robinson  <jamesr@chromium.org>
1825
1826         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1827         https://bugs.webkit.org/show_bug.cgi?id=72402
1828
1829         Reviewed by Dirk Pranke.
1830
1831         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1832         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1833         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1834         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1835         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1836         compositing enabled.
1837
1838         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1839         patch should not impact any tests.
1840
1841         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1842         (main):
1843         * DumpRenderTree/chromium/TestShell.cpp:
1844         (TestShell::TestShell):
1845         (TestShell::resetWebSettings):
1846         * DumpRenderTree/chromium/TestShell.h:
1847         (TestShell::setAcceleratedCompositingForVideoEnabled):
1848         * DumpRenderTree/chromium/WebPreferences.cpp:
1849         (WebPreferences::reset):
1850         (WebPreferences::applyTo):
1851         * DumpRenderTree/chromium/WebPreferences.h:
1852         * Scripts/webkitpy/layout_tests/port/chromium.py:
1853         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1854         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1855
1856 2011-11-15  Tony Chang  <tony@chromium.org>
1857
1858         Unreviewed, try to fix ref tests failures on SL Intel bot.
1859         It looks like ImageDiff isn't returning an image diff.
1860
1861         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1862
1863 2011-11-15  Tony Chang  <tony@chromium.org>
1864
1865         Unreviewed fix of ref-tests on GTK+.
1866         If a driver is never started, _xvfb_process is never set.
1867
1868         * Scripts/webkitpy/layout_tests/port/gtk.py:
1869
1870 2011-11-14  Tony Chang  <tony@chromium.org>
1871
1872         [NRWT] Reftests should run even when pixel tests are disabled.
1873         https://bugs.webkit.org/show_bug.cgi?id=60605
1874
1875         Reviewed by Dirk Pranke.
1876
1877         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1878             Also add an assert to make sure we get image hashes back when running ref tests.
1879         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1880         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1881         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1882         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1883             of starting a pixel driver if needed.  It handles the logic of sending the test
1884             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1885         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1886         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1887         * Scripts/webkitpy/layout_tests/port/webkit.py:
1888         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1889         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1890
1891 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1892
1893         Don't use File::Slurp for run-leaks unit tests
1894         <http://webkit.org/b/72356>
1895
1896         Reviewed by Daniel Bates.
1897
1898         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1899         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1900         Extracted common package logic into RunLeaks.pm.  Fixed call to
1901         RunLeaks::parseLeaksOutput().
1902         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1903         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1904
1905 2011-11-15  Peter Kasting  <pkasting@google.com>
1906
1907         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1908         https://bugs.webkit.org/show_bug.cgi?id=72349
1909
1910         Reviewed by Adam Roben.
1911
1912         * Scripts/VCSUtils.pm:
1913         (isSVNDirectory):
1914
1915 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1916
1917         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1918
1919         Reviewed by Tor Arne Vestbø.
1920
1921         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1922         magic here where we handle all TEMPLATE = lib .pro files.
1923
1924 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1925
1926         [Qt] Unreviewed prospective --minimal build fix.
1927
1928         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1929         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1930
1931 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1932
1933         [Qt] Unreviewed --minimal build fix.
1934
1935         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1936         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1937         to make moc's preprocessor abort.
1938
1939 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1940
1941         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1942         https://bugs.webkit.org/show_bug.cgi?id=72156
1943
1944         Reviewed by Daniel Bates.
1945
1946         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1947         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1948
1949         * Scripts/build-webkit:
1950         * Scripts/webkitdirs.pm:
1951         (generateBuildSystemFromCMakeProject):
1952
1953 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1954
1955         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1956         https://bugs.webkit.org/show_bug.cgi?id=72340
1957
1958         Reviewed by Eric Seidel.
1959
1960         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1961         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1962
1963         * Scripts/webkitpy/common/checkout/changelog.py:
1964         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1965
1966 2011-11-14  Eric Seidel  <eric@webkit.org>
1967
1968         check-webkit-style broken by r99773: "Could not determine the port"
1969         https://bugs.webkit.org/show_bug.cgi?id=72275
1970
1971         Reviewed by Adam Barth.
1972
1973         The TestExpectationsChecker was using a generic try/except block
1974         which caught all exceptions, so we didn't notice that failing
1975         to pass a Host to PortFactory was causing an exception in port instantiation.
1976         I've factored out the "lookup the port" logic into a separate function
1977         which I've now unittested.  This should fix the bug and prevent
1978         others like it from occuring the the future.
1979
1980         * Scripts/webkitpy/style/checkers/test_expectations.py:
1981         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1982
1983 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1984
1985         Add --css-grid-layout to build-webkit and the build systems
1986         https://bugs.webkit.org/show_bug.cgi?id=72320
1987
1988         Reviewed by Ojan Vafai.
1989
1990         * Scripts/build-webkit:
1991         Added the option.
1992
1993 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1994
1995         Unreviewed, rolling out r100192.
1996         http://trac.webkit.org/changeset/100192
1997         https://bugs.webkit.org/show_bug.cgi?id=72328
1998
1999         Caused infinite tests to fail (Requested by abarth on
2000         #webkit).
2001
2002         * Scripts/webkitpy/layout_tests/port/base.py:
2003         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2004
2005 2011-11-14  Tony Chang  <tony@chromium.org>
2006
2007         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2008         https://bugs.webkit.org/show_bug.cgi?id=72196
2009
2010         Reviewed by Ojan Vafai.
2011
2012         * Scripts/build-webkit:
2013
2014 2011-11-14  John Yani  <vanuan@gmail.com>
2015
2016         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
2017         Override LOCALE to en_US.
2018
2019         Reviewed by Eric Seidel.
2020
2021         * Scripts/webkitpy/layout_tests/port/base.py:
2022
2023 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2024
2025         [Chromium] build-webkit silently drops the features flags
2026         https://bugs.webkit.org/show_bug.cgi?id=72293
2027
2028         Reviewed by Tony Chang.
2029
2030         Chromium still ignores @features but now we give a warning!
2031
2032         * Scripts/build-webkit: Check if one of the features is different
2033         from the default and print a warning in this case.
2034
2035 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2036
2037         run-leaks does not work on Lion?
2038         <http://webkit.org/b/71059>
2039         <rdar://problem/10428527>
2040
2041         Reviewed by Adam Roben.
2042
2043         The output of leaks(1) changed again in Lion to move the
2044         "leaks Report Version: 2.0" line from the first line of the
2045         output to just above the "Process " lines that run-leaks is
2046         interested in parsing.  This required using a more generic
2047         algorithm to find the start of the "Process " lines.
2048
2049         * Scripts/run-leaks:
2050         (parseLeaksOutput): Make the code to skip headers more generic.
2051         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2052         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2053         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2054
2055 2011-11-14  Lei Zhang  <thestig@chromium.org>
2056
2057         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2058         https://bugs.webkit.org/show_bug.cgi?id=72088
2059
2060         Reviewed by Tony Chang.
2061
2062         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2063
2064 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2065
2066         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2067         https://bugs.webkit.org/show_bug.cgi?id=72147
2068
2069         Reviewed by Adam Barth.
2070
2071         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2072
2073 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2074
2075         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2076
2077         Reviewed by Simon Hausmann.
2078
2079         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2080
2081 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2082
2083         [Qt] Disable plugins on X11 for WK2
2084
2085         Reviewed by Kenneth Rohde Christiansen.
2086
2087         Currently plugins are in-process and they crash in the likely case of
2088         a plugin installation that uses Qt 4, which beautifully clashes with the
2089         Qt 5 based QtWebProcess.
2090
2091         * qmake/mkspecs/features/features.prf:
2092
2093 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2094
2095         [Qt] Add support for config tests for Qt 5
2096
2097         This allows us to build and run configure-tests at build
2098         time to determine if a given platform feature is available.
2099
2100         Reviewed by Simon Hausmann.
2101
2102         * Scripts/build-webkit:
2103         * Scripts/webkitdirs.pm:
2104         (qtFeatureDefaults):
2105         * qmake/configure.pro: Added.
2106         * qmake/mkspecs/features/features.prf:
2107         * qmake/sync.profile: Added.
2108
2109 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2110
2111         [Qt] Remove the QStyle dependency in Qt's mobile theme
2112         https://bugs.webkit.org/show_bug.cgi?id=67773
2113
2114         This refactoring splits up RenderThemeQt with two
2115         subclasses, a QStyle-backed one, and a Mobile version
2116         that uses the old mobile theme for now.
2117
2118         QStyle availability is detected at compile time, and
2119         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2120         environment variable.
2121
2122         Reviewed by Simon Hausmann.
2123
2124         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2125         (WTR::activateFonts):
2126         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2127         based on availability of QtWidgets.
2128         * qmake/mkspecs/features/webcore.prf: cleanup.
2129
2130 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2131
2132         Unreviewed, rolling out r100116.
2133         http://trac.webkit.org/changeset/100116
2134
2135         r100104 was rolled out, so no longer needed
2136
2137         * Scripts/run-bindings-tests:
2138
2139 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2140
2141         Unreviewed, rolling out r100104.
2142         http://trac.webkit.org/changeset/100104
2143         https://bugs.webkit.org/show_bug.cgi?id=72247
2144
2145         broke windows builds
2146
2147         * Scripts/check-webkit-style:
2148         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2149         * Scripts/webkitpy/common/checkout/deps.py:
2150         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2151         * Scripts/webkitpy/common/checkout/scm/detection.py:
2152         * Scripts/webkitpy/common/checkout/scm/git.py:
2153         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2154         * Scripts/webkitpy/common/checkout/scm/svn.py:
2155         * Scripts/webkitpy/common/host.py:
2156         * Scripts/webkitpy/common/host_mock.py:
2157         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2158         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2159         * Scripts/webkitpy/layout_tests/port/base.py:
2160         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2161         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2162         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2163         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2164
2165 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2166
2167         Unreviewed, build fix after r100104. run-binding-tests broke.
2168
2169         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2170
2171 2011-11-13  Eric Seidel  <eric@webkit.org>
2172
2173         Add SCMDetector object to make scm detection mockable
2174         https://bugs.webkit.org/show_bug.cgi?id=72247
2175
2176         Reviewed by Adam Barth.
2177
2178         I think SCM detection may eventually be rolled into Checkout,
2179         but this patch at least makes it possible to mock code-paths
2180         which rely on scm detection.
2181         In the process of replacing callers of these free-functions
2182         I found that one of the functions was no longer used,
2183         and that one of the callers could instead just use the SCM
2184         object it already had access to through port.host.scm().
2185         I also discovered that I was not calling Host._initialize_scm()
2186         and thus host.scm() was always returning None!
2187
2188         * Scripts/check-webkit-style:
2189         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2190         * Scripts/webkitpy/common/checkout/deps.py:
2191         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2192         * Scripts/webkitpy/common/checkout/scm/detection.py:
2193         * Scripts/webkitpy/common/checkout/scm/git.py:
2194         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2195         * Scripts/webkitpy/common/checkout/scm/svn.py:
2196         * Scripts/webkitpy/common/host.py:
2197         * Scripts/webkitpy/common/host_mock.py:
2198         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2199         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2200         * Scripts/webkitpy/layout_tests/port/base.py:
2201         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2203         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2204         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2205
2206 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2207
2208         command line control of webcore log channels in chromium DumpRenderTree
2209         https://bugs.webkit.org/show_bug.cgi?id=72126
2210         
2211         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2212         what chromium takes.
2213
2214         Reviewed by Kent Tamura.
2215
2216         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2217         (main):
2218
2219 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2220
2221         [Qt] Fix minor config typo in the build tool documentation
2222         https://bugs.webkit.org/show_bug.cgi?id=72194
2223
2224         Reviewed by Andreas Kling.
2225
2226         * qmake/README:
2227
2228 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2229
2230         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2231         https://bugs.webkit.org/show_bug.cgi?id=49257
2232
2233         Adds the remaining missing layout test functionality for printing.
2234
2235         Reviewed by Darin Fisher.
2236
2237         * DumpRenderTree/chromium/LayoutTestController.cpp:
2238         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2239         (parsePageNumber): Method to parse JS arguments for a page number
2240         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2241         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2242         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2243         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2244         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2245
2246 2011-11-11  Darin Adler  <darin@apple.com>
2247
2248         Remove all releaseRef implementations except for RetainPtr
2249         https://bugs.webkit.org/show_bug.cgi?id=71423
2250
2251         Reviewed by Julien Chaffraix.
2252
2253         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2254         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2255
2256 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2257
2258         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2259         https://bugs.webkit.org/show_bug.cgi?id=72090
2260
2261         Reviewed by Eric Seidel.
2262
2263         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
2264         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
2265
2266         yay! r100002.
2267
2268         * Scripts/webkitpy/common/checkout/changelog.py:
2269         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2270
2271 2011-11-11  Tony Chang  <tony@chromium.org>
2272
2273         Remove --force from gclient sync.  The bots seem to have made it past
2274         the update step.
2275
2276         * Scripts/update-webkit:
2277
2278 2011-11-11  Tony Chang  <tony@chromium.org>
2279
2280         Add --force to gclient sync. Once the cq bots cycle, we can remove
2281         this since it slows down the normal sync.
2282
2283         * Scripts/update-webkit:
2284
2285 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
2286
2287         When --force is used, also use --reset
2288         https://bugs.webkit.org/show_bug.cgi?id=72129
2289
2290         Reviewed by Dimitri Glazkov.
2291
2292         * Scripts/update-webkit-chromium:
2293
2294 2011-11-11  Tony Chang  <tony@chromium.org>
2295
2296         allow two chromium drivers to run at the same time in NRWT
2297         https://bugs.webkit.org/show_bug.cgi?id=72067
2298
2299         Reviewed by Dirk Pranke.
2300
2301         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
2302             posix prevents the subprocesses from sharing the same fd for stdin.
2303             Sharing the same fd prevents us from closing the files unless all references
2304             to the fd are closed.
2305         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
2306             to adding a test for this, speed up a test (from 3sec to 0) by fixing
2307             the timeout override. It looks like it regressed in r95875.
2308
2309 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2310
2311         Unreviewed, rolling out r99964.
2312         http://trac.webkit.org/changeset/99964
2313         https://bugs.webkit.org/show_bug.cgi?id=72124
2314
2315         Broke too many Qt tests (Requested by tronical_ on #webkit).
2316
2317         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2318         (WTR::activateFonts):
2319         * qmake/mkspecs/features/features.prf:
2320         * qmake/mkspecs/features/webcore.prf:
2321
2322 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2323
2324         [Qt] Remove the QStyle dependency in Qt's mobile theme
2325         https://bugs.webkit.org/show_bug.cgi?id=67773
2326
2327         This refactoring splits up RenderThemeQt with two
2328         subclasses, a QStyle-backed one, and a Mobile version
2329         that uses the old mobile theme for now.
2330
2331         QStyle availability is detected at compile time, and
2332         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2333         environment variable.
2334
2335         Reviewed by Simon Hausmann.
2336
2337         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2338         (WTR::activateFonts):
2339         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2340         based on availability of QtWidgets.
2341         * qmake/mkspecs/features/webcore.prf: cleanup.
2342
2343 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2344
2345         [Qt] Add missing include to PlatformWebViewQt
2346
2347         Reviewed by Simon Hausmann.
2348
2349         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2350
2351 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2352
2353         [Qt] Fix incremental builds on Windows after buildsystem refactor
2354
2355         The qmake rules to ensure that we run make on the derived sources
2356         before running qmake on the target were inside a unix-scope, which
2357         resulted in flakey builds on Windows.
2358
2359         We now generate a rule on all platforms that ensures that "make qmake"
2360         will always run make on the derived sources. In addition, on platforms
2361         that have GNU make (where "make incremental" does not run "make qmake",
2362         but only "make"), we add a similar rule that ensures that any time the
2363         target makefile is regenerated we first run qmake and make on the derived
2364         sources. This rule relies on GNU make's order-only-prerequisites to
2365         not trigger a qmake-run of the target every time we run make.
2366
2367         https://bugs.webkit.org/show_bug.cgi?id=71778
2368
2369         Reviewed by Simon Hausmann.
2370
2371         * qmake/mkspecs/features/functions.prf:
2372
2373 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2374
2375         [Qt][WK2] Remove QWebNavigationController
2376         https://bugs.webkit.org/show_bug.cgi?id=72113
2377
2378         Reviewed by Andreas Kling.
2379
2380         Adapt to the move of the QWebNavigationController functions/properties to
2381         QQuickWebView.
2382
2383         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2384         * MiniBrowser/qt/qml/BrowserWindow.qml:
2385
2386 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2387
2388         [Qt] Build system tweak
2389
2390         Reviewed by Tor Arne Vestbø.
2391
2392         Be a good qmake citizen, return true from our linkStaticLibrary
2393         "test" function.
2394
2395         * qmake/mkspecs/features/functions.prf:
2396
2397 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2398
2399         [Qt] Add support for QT += webkit-private
2400
2401         Reviewed by Tor Arne Vestbø.
2402
2403         * qmake/qt_webkit.pri: Declare private headers.
2404
2405 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2406
2407         Unreviewed, build fix attempt after r99907. Since that revision
2408         GTK layout tests were not running at all...
2409
2410         * Scripts/webkitpy/layout_tests/port/gtk.py:
2411
2412 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2413
2414         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2415         https://bugs.webkit.org/show_bug.cgi?id=72001
2416
2417         Reviewed by Dirk Pranke.
2418
2419         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2420
2421 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2422
2423         bencher script should support remote benchmarking
2424         https://bugs.webkit.org/show_bug.cgi?id=71618
2425
2426         Rubber-stamped by Geoff Garen.
2427         
2428         Added the following features:
2429         
2430         - Benchmark report tells you the hostname and machine model (according to
2431           'sysctl hw.model') of the machine you did the run on, and svn revision number
2432           (according to 'svn info') of the VMs you're testing.
2433         
2434         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2435           acceptable, in addition to just host, in which case your username is used)
2436           and it automatically packages the build directories of the VMs you're testing,
2437           sends them to the remote machine along with your copy of the bencher script
2438           and all of the options you passed.  This pretty much seamlessly allows you
2439           to run a set of benchmarks on any machine that is sufficiently compatible with
2440           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2441           must now include a tempPath setting that tells bencher where to put files
2442           when that machine is used as a slave in a remote benchmarking run.
2443           
2444         - Added yet another way of specifying which benchmarks to run. This was sort of
2445           necessary for --remote to work as expected. Previously, you either said what
2446           suites to exclude (for example --exclude-sunspider) or that you only wanted
2447           to run one suite to the exclusion of others (--sunspider-only). But it's
2448           often better to just be able to specify the list of suites you want. This is
2449           now supported. You can say, for example, --v8 --sunspider, which means, just
2450           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2451           still supported.
2452
2453         * Scripts/bencher:
2454
2455 2011-11-10  Tony Chang  <tony@chromium.org>
2456
2457         Lazily start DRT instances in NRWT
2458         https://bugs.webkit.org/show_bug.cgi?id=72038
2459
2460         Reviewed by Eric Seidel.
2461
2462         Just a refactoring, no new tests.
2463
2464         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2465         * Scripts/webkitpy/layout_tests/port/chromium.py:
2466         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2467         * Scripts/webkitpy/layout_tests/port/test.py:
2468         * Scripts/webkitpy/layout_tests/port/webkit.py:
2469
2470 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2471
2472         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2473         https://bugs.webkit.org/show_bug.cgi?id=72057
2474
2475         Reviewed by Eric Seidel.
2476
2477         Make the regular expression more explicit.
2478
2479         * Scripts/webkitpy/common/checkout/changelog.py:
2480         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2481
2482 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2483
2484         [Qt] X11 plugins need to be reworked for Qt5
2485         https://bugs.webkit.org/show_bug.cgi?id=70023
2486
2487         Reviewed by Simon Hausmann.
2488
2489         Rework our basic plugin support in a way that does
2490         not need a bridge between Qt and X. The solution is
2491         based on getting the content drawed by the plugin
2492         from the server as an image and creating a QImage
2493         from it.
2494
2495         * qmake/mkspecs/features/features.prf: Enable X11
2496         plugins if Qt is built with the xcb-xlib backend.
2497
2498 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2499
2500         [Qt] Fix keyboard related layout tests after API refactoring
2501
2502         Reviewed by Tor Arne Vestbø.
2503
2504         Send key events to the handling page item, not the view.
2505
2506         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2507         (WTR::PlatformWebView::sendEvent):
2508         (WTR::PlatformWebView::postEvent):
2509
2510 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2511
2512         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2513         https://bugs.webkit.org/show_bug.cgi?id=71940
2514
2515         Reviewed by Philippe Normand.
2516
2517         * GNUmakefile.am:
2518         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2519         ENABLE_* variables are part of the environment.
2520
2521 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2522
2523         [Qt] Fix focus related layout tests after API refactoring
2524
2525         Reviewed by Tor Arne Vestbø.
2526
2527         Make sure the focus is set on the page now, not on the view
2528         (which doesn't actually handle the focus).
2529
2530         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2531         (WTR::WrapperWindow::WrapperWindow):
2532         (WTR::WrapperWindow::handleStatusChanged):
2533
2534 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2535
2536         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2537         https://bugs.webkit.org/show_bug.cgi?id=71355
2538
2539         Reviewed by Kenneth Rohde Christiansen.
2540
2541         Make MiniBrowser and WebKitTestRunner work again after the
2542         merge.
2543
2544         * MiniBrowser/qt/BrowserWindow.cpp:
2545         (BrowserWindow::BrowserWindow):
2546         (BrowserWindow::webView):
2547         * MiniBrowser/qt/MiniBrowser.pro:
2548         * MiniBrowser/qt/MiniBrowser.qrc:
2549         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2550         * MiniBrowser/qt/main.cpp:
2551         * MiniBrowser/qt/qml/BrowserWindow.qml:
2552         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2553         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2554         * WebKitTestRunner/PlatformWebView.h:
2555         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2556         (WTR::PlatformWebView::PlatformWebView):
2557
2558 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2559
2560         [Qt] Change semantics of the haveQt() function to match API promises
2561
2562         Having Qt 5 does not imply that we have Qt 4, from an API point of
2563         view, as a major version can in theory break BC/SC. Our minimum
2564         version of Qt 4 will always be the latest released version of Qt 4,
2565         so the only place we should use haveQt(4, x) is when checking for
2566         the minimum requirements.
2567
2568         Reviewed by Simon Hausmann.
2569
2570         * qmake/mkspecs/features/default_pre.prf:
2571         * qmake/mkspecs/features/features.prf:
2572         * qmake/mkspecs/features/functions.prf:
2573
2574 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2575
2576         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2577         https://bugs.webkit.org/show_bug.cgi?id=69411
2578
2579         Reviewed by Martin Robinson.
2580
2581         * WebKitTestRunner/EventSenderProxy.h:
2582         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2583         * WebKitTestRunner/TestController.cpp:
2584         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2585         use the EventSender instead of WebProcess Event Simulation.
2586         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2587         (WTR::WTREventQueueItem::WTREventQueueItem):
2588         (WTR::EventSenderProxy::EventSenderProxy):
2589         (WTR::getMouseButtonModifiers):
2590         (WTR::eventSenderButtonToGDKButton):
2591         (WTR::EventSenderProxy::createMouseButtonEvent):
2592         (WTR::EventSenderProxy::updateClickCountForButton):
2593         (WTR::EventSenderProxy::replaySavedEvents):
2594         (WTR::EventSenderProxy::sendOrQueueEvent):
2595         (WTR::webkitModifiersToGDKModifiers):
2596         (WTR::getGDKKeySymForKeyRef):
2597         (WTR::EventSenderProxy::keyDown):
2598         (WTR::EventSenderProxy::mouseDown):
2599         (WTR::EventSenderProxy::mouseUp):
2600         (WTR::EventSenderProxy::mouseMoveTo):
2601         (WTR::EventSenderProxy::mouseScrollBy):
2602         (WTR::EventSenderProxy::leapForward):
2603
2604 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2605
2606         [Qt] Enable exports and constructor functions in static libs
2607
2608         Reviewed by Tor Arne Vestbø.
2609
2610         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2611         mac/win32-msvc equivalents when linking static libraries into a shared
2612         library or executable.
2613
2614 2011-11-09  Hayato Ito  <hayato@chromium.org>
2615
2616         [NRWT] Make results.html aware of reference filename in reftests.
2617         https://bugs.webkit.org/show_bug.cgi?id=71574
2618
2619         Reviewed by Ryosuke Niwa.
2620
2621         If a reference filename is different from the default one, include that in result summary
2622         so results.html can link to the correct reference file.
2623
2624         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2625         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2626
2627 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2628
2629         [wx] Unreviewed build fix. Update project files and
2630         add LTC stubs for new methods.
2631
2632         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2633         (LayoutTestController::addChromeInputField):
2634         (LayoutTestController::removeChromeInputField):
2635         (LayoutTestController::focusWebView):
2636         (LayoutTestController::setBackingScaleFactor):
2637         * waf/build/settings.py:
2638
2639 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2640
2641         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2642
2643         * wx/install-unix-extras:
2644
2645 2011-11-09  Eric Seidel  <eric@webkit.org>
2646
2647         Remove the concept of platform-dependent unittests
2648         https://bugs.webkit.org/show_bug.cgi?id=71963
2649
2650         Unreviewed.  Fix test-webkitpy on cygwin.
2651
2652         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2653
2654 2011-11-09  Dana Jansens  <danakj@chromium.org>
2655
2656         Add cc-bugs group to watch changes in chromium graphics
2657         https://bugs.webkit.org/show_bug.cgi?id=71690
2658
2659         Reviewed by David Levin.
2660
2661         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2662         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2663         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2664         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2665
2666 2011-11-09  Eric Seidel  <eric@webkit.org>
2667
2668         Remove more platform-dependent unittests
2669         https://bugs.webkit.org/show_bug.cgi?id=71971
2670
2671         Reviewed by Adam Barth.
2672
2673         Tests which only run on a couple platforms will break.
2674         All tests should run on all platforms where possible.
2675
2676         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2677         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2678         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2679         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2680
2681 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2682
2683         Merge in results to the test results server even if build numbers conflict
2684         https://bugs.webkit.org/show_bug.cgi?id=71967
2685
2686         Reviewed by Tony Chang.
2687
2688         This was initially meant to be a sanity check that we don't
2689         enter duplicate runs, but it turns out that we can reasonably get
2690         in these situations when a builder is clobbered (e.g. the build
2691         numbers start over again from 0).
2692
2693         * TestResultServer/model/jsonresults.py:
2694         * TestResultServer/model/jsonresults_unittest.py:
2695
2696 2011-11-09  Eric Seidel  <eric@webkit.org>
2697
2698         Remove the concept of platform-dependent unittests
2699         https://bugs.webkit.org/show_bug.cgi?id=71963
2700
2701         Reviewed by Adam Barth.
2702
2703         These have been the source of never-ending sadness.
2704         We'd change behavior and forget to update results in
2705         some unittests because they were only run on certain platforms.
2706         This change removes a large source of these platform-dependent
2707         unittests, which was caused by the port_maker stuff.
2708
2709         It's possible that this change will break test-webkitpy
2710         on some platforms, but that will be a one-time cost.
2711         I will fix the breakage by removing the platform-dependantness
2712         of any such broken tests.
2713
2714         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2715         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2716         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2717         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2718         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2719         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2720         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2721         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2722         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2723         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2724         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2725         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2726         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2727
2728 2011-11-09  Eric Seidel  <eric@webkit.org>
2729
2730         Make the Port object have a Host
2731         https://bugs.webkit.org/show_bug.cgi?id=71961
2732
2733         Reviewed by Adam Barth.
2734
2735         This has been a long time coming.
2736         Now that Port has a Host object, it's very easy
2737         to write unittests which use a properly mocked Port.
2738         Soon we will remove the executive, filesystem and user
2739         members of Port and get everything through the Host.
2740
2741         Note how in many callsites we're actually removing
2742         explicit mocks, since we're now always going to get the
2743         correct Executive/User/FileSystem from the
2744         Host and callsites don't need to be careful to pass each one.
2745
2746         This is prep-work for adding a new Environment member to
2747         Host and needing to be able to access the Environment
2748         member from Port functions w/o needing to pass an Environment
2749         object (or appropriate Mock) every place we create a Port object.
2750         Now that we have a single Host object to reach out through, its
2751         simple to add additional functionality (like Environment) while
2752         keeping our unittests properly mocked.
2753
2754         * Scripts/webkitpy/common/host.py:
2755         * Scripts/webkitpy/common/net/credentials_unittest.py:
2756         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2757         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2758         * Scripts/webkitpy/layout_tests/port/apple.py:
2759         * Scripts/webkitpy/layout_tests/port/base.py:
2760         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2761         * Scripts/webkitpy/layout_tests/port/chromium.py:
2762         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2763         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2764         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2765         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2766         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2767         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2768         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2769         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2770         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2771         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2772         * Scripts/webkitpy/layout_tests/port/efl.py:
2773         * Scripts/webkitpy/layout_tests/port/factory.py:
2774         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2775         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2776         * Scripts/webkitpy/layout_tests/port/gtk.py:
2777         * Scripts/webkitpy/layout_tests/port/mac.py:
2778         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2779         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2780         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2781         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2782         * Scripts/webkitpy/layout_tests/port/qt.py:
2783         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2784         * Scripts/webkitpy/layout_tests/port/test.py:
2785         * Scripts/webkitpy/layout_tests/port/webkit.py:
2786         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2787         * Scripts/webkitpy/layout_tests/port/win.py:
2788         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2789         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2790         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2791         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2792         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2793
2794 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2795
2796         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2797         https://bugs.webkit.org/show_bug.cgi?id=71561
2798
2799         Reviewed by Dimitri Glazkov.
2800
2801         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2802         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2803
2804 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2805
2806         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2807         https://bugs.webkit.org/show_bug.cgi?id=66772
2808
2809         Reviewed by Simon Fraser.
2810
2811         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2812         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2813
2814         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2815         in the FrameLoadDelegate and print the output in response to the notification.
2816
2817         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2818         (-[FrameLoadDelegate init]):
2819         (-[FrameLoadDelegate dealloc]):
2820         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2821
2822 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2823
2824         [GTK][DRT] window internals object is not reset after each test
2825         https://bugs.webkit.org/show_bug.cgi?id=71890
2826
2827         Reviewed by Martin Robinson.
2828
2829         Call WebCoreTestSupport::resetInternalsObject without going
2830         through DumpRenderTreeSupport.
2831
2832         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2833         (runTest):
2834
2835 2011-11-09  Beth Dakin  <bdakin@apple.com>
2836
2837         Build fix.
2838
2839         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2840         (AccessibilityUIElement::uiElementAttributeValue):
2841
2842 2011-11-09  Beth Dakin  <bdakin@apple.com>
2843
2844         Speculative build fix.
2845
2846         * DumpRenderTree/AccessibilityUIElement.h:
2847
2848 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2849
2850         Unreviewed build fix.
2851
2852         * DumpRenderTree/AccessibilityUIElement.cpp:
2853         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2854         A bad merge added this check that is making the bots sad.
2855
2856 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2857
2858         AX: crash when accessing selectedTab in a tab list
2859         https://bugs.webkit.org/show_bug.cgi?id=70938
2860
2861         Reviewed by Beth Dakin.
2862
2863         Add the ability to retrieve an element through an arbitrary attribute.
2864
2865         * DumpRenderTree/AccessibilityUIElement.cpp:
2866         (uiElementAttributeValueCallback):
2867         (AccessibilityUIElement::uiElementAttributeValue):
2868         (AccessibilityUIElement::getJSClass):
2869         * DumpRenderTree/AccessibilityUIElement.h:
2870         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2871         (AccessibilityUIElement::uiElementAttributeValue):
2872
2873 2011-11-09  Andy Wingo  <wingo@igalia.com>
2874
2875         Add webkitdirs.pm:getArchitecture implementation for GTK
2876         https://bugs.webkit.org/show_bug.cgi?id=71370
2877
2878         Reviewed by Xan Lopez.
2879
2880         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2881         implementation for ports using autotools, so that a vanilla
2882         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2883         to build-jsc on x86-64 machines.
2884
2885 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2886
2887         Unreviewed, rolling out r99707.
2888         http://trac.webkit.org/changeset/99707
2889
2890         Re-enable until we can disable it together with tests in one
2891         shot.
2892
2893         * qmake/mkspecs/features/features.prf:
2894
2895 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2896
2897         [Qt] Disable use of QtUiTools if the library/module is not found
2898
2899         We rely on the lookup order of prf files to inject our own uitools.prf
2900         that will verify that QtUiTools is in fact present before allowing the
2901         CONFIG += uitools to have any effect.
2902
2903         Reviewed by Simon Hausmann.
2904
2905         * DumpRenderTree/qt/DumpRenderTree.pro:
2906         * QtTestBrowser/QtTestBrowser.pro:
2907         * qmake/mkspecs/features/uitools.prf: Added.
2908
2909 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2910
2911         Unreviewed, rolling out r99701.
2912         http://trac.webkit.org/changeset/99701
2913
2914         Breaks Qt mac build
2915
2916         * qmake/mkspecs/features/functions.prf:
2917
2918 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2919
2920         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2921
2922         Reviewed by Tor Arne Vestbø.
2923
2924         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2925         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2926         is not up to the task of full XSLT support, so we should disable it.
2927
2928 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2929
2930         [Qt] Enable exports and constructor functions in static libs
2931
2932         Reviewed by Tor Arne Vestbø.
2933
2934         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2935         mac/win32-msvc equivalents when linking static libraries into a shared
2936         library or executable.
2937
2938 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2939
2940         [GTK][DRT] window internals object is not reset after each test
2941         https://bugs.webkit.org/show_bug.cgi?id=71890
2942
2943         Reviewed by Xan Lopez.
2944
2945         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2946         (runTest): reset the Internals object after each test.
2947
2948 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2949
2950         [Qt] Detect presence of QtUiTools and enable it only when available
2951
2952         The disable_uitools option was a workaround for missing detection.
2953
2954         Reviewed by Simon Hausmann.
2955
2956         * QtTestBrowser/QtTestBrowser.pro:
2957         * qmake/mkspecs/features/default_post.prf:
2958         * qmake/mkspecs/features/default_pre.prf:
2959
2960 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2961
2962         [Qt] Don't override config for the build_pass of debug_and_release
2963
2964         Qmake will parse the profile once for each configuration (debug and
2965         release), with the build_pass option set. In that situation we don't
2966         want to override what qmake is setting explicitly, otherwise the
2967         debug-step will end up hitting all the release-scopes.
2968
2969         Reviewed by Simon Hausmann.
2970
2971         * qmake/mkspecs/features/default_pre.prf:
2972
2973 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2974
2975         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2976
2977         * qmake/mkspecs/features/functions.prf:
2978
2979 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2980
2981         [Qt] Centralize duplicated code for linking the static libs
2982
2983         Reviewed by Tor Arne Vestbø.
2984
2985         * qmake/mkspecs/features/functions.prf:
2986         * qmake/mkspecs/features/javascriptcore.prf:
2987         * qmake/mkspecs/features/webcore.prf:
2988         * qmake/mkspecs/features/webkit2.prf:
2989
2990 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2991
2992         [Qt] Build system cleanup
2993         https://bugs.webkit.org/show_bug.cgi?id=71815
2994
2995         Reviewed by Kenneth Rohde Christiansen.
2996
2997         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2998         static library.
2999         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
3000         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
3001
3002 2011-11-08  Hayato Ito  <hayato@chromium.org>
3003
3004         [NRWT] Make single_test_runner aware of reference filename of test_input.
3005         https://bugs.webkit.org/show_bug.cgi?id=71567
3006
3007         Reviewed by Ryosuke Niwa.
3008
3009         Make single_test_runner honor a reference filename of given test_input so that
3010         we can use any file as reference html, instead of depending on implicit naming convention.
3011         The typical use case is to support w3c reftests.
3012
3013         No tests since no functional changes until there is a client.
3014         Test should be easily written with future clients.
3015
3016         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3017         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3018         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3019         * Scripts/webkitpy/layout_tests/models/test_input.py:
3020
3021 2011-11-08  Lucas Forschler  <lforschler@apple.com>
3022
3023         https://bugs.webkit.org/show_bug.cgi?id=71839
3024         Update the leaks bot OS to Lion.
3025         Update the config.json to reflect the update.
3026
3027         Reviewed by Stephanie Lewis.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/config.json:
3030
3031 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3032
3033         Unreviewed, rolling out r99626.
3034         http://trac.webkit.org/changeset/99626
3035         https://bugs.webkit.org/show_bug.cgi?id=71866
3036
3037         "C++ exceptions cannot be disabled without influencing the
3038         Objective-C exceptions" (Requested by benjaminp on #webkit).
3039
3040         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3041
3042 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
3043
3044         [Mac] Disable C++ exceptions from DumpRenderTree
3045         https://bugs.webkit.org/show_bug.cgi?id=71834
3046
3047         Reviewed by Darin Adler.
3048
3049         DumpRenderTree Mac does not handle C++ exceptions. When such exception
3050         happens, it tends to cause the AutoReleasePool stack to be corrupted,
3051         which leads to crashes long after the exception was raised.
3052
3053         This patch disabled C++ exceptions in order to catch the problems where
3054         they happen when a C++ exception is raised.
3055
3056         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3057
3058 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
3059
3060         Moved myself to the reviewer list (yay!).
3061
3062         * Scripts/webkitpy/common/config/committers.py:
3063
3064 2011-11-08  Zeno Albisser  <zeno@webkit.org>
3065
3066         Added myself as a committer.
3067
3068         * Scripts/webkitpy/common/config/committers.py:
3069
3070 2011-11-08  Andy Wingo  <wingo@igalia.com>
3071
3072         Skip some ECMAScript tests that fail on Linux in some time zones.
3073         https://bugs.webkit.org/show_bug.cgi?id=71371
3074
3075         Reviewed by Martin Robinson.
3076
3077         * Scripts/run-javascriptcore-tests: Skip some more tests.
3078
3079 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3080
3081         [Qt] Unreviewed trivial fix after build system refactoring.
3082
3083         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
3084
3085 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3086
3087         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
3088
3089         If a pro file needs to access the OBJECTS_DIR it should use the
3090         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
3091         after defaults_post has been processed.
3092
3093         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
3094         the command line will override whatever we set in defaults_pre.
3095
3096         Reviewed by Simon Hausmann.
3097
3098         * qmake/mkspecs/features/default_post.prf:
3099         * qmake/mkspecs/features/default_pre.prf:
3100
3101 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3102
3103         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
3104
3105         Reviewed by Simon Hausmann.
3106
3107         * qmake/mkspecs/features/default_post.prf:
3108
3109 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
3110
3111         [Qt][WK2] MiniBrowser should use urlFromUserInput()
3112         https://bugs.webkit.org/show_bug.cgi?id=71680
3113
3114         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
3115         complete urls in MiniBrowser.
3116
3117         Reviewed by Tor Arne Vestbø.
3118
3119         * MiniBrowser/qt/BrowserWindow.cpp:
3120         (BrowserWindow::BrowserWindow):
3121         (BrowserWindow::load):
3122         * MiniBrowser/qt/qml/BrowserWindow.qml:
3123         * MiniBrowser/qt/utils.cpp:
3124         (Utils::urlFromUserInput):
3125         * MiniBrowser/qt/utils.h:
3126         (Utils::Utils):
3127
3128 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
3129
3130         Added myself as a committer.
3131
3132         * Scripts/webkitpy/common/config/committers.py:
3133
3134 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3135
3136         Unreviewed webkitpy test fix after r99512.
3137
3138         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3139         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
3140
3141 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3142
3143         Added myself as a committer.
3144
3145         * Scripts/webkitpy/common/config/committers.py:
3146
3147 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3148
3149         Unreviewed, rolling out r99470.
3150         http://trac.webkit.org/changeset/99470
3151         https://bugs.webkit.org/show_bug.cgi?id=71740
3152
3153         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
3154
3155         * Scripts/webkitpy/common/config/watchlist:
3156
3157 2011-11-07  Tony Chang  <tony@chromium.org>
3158
3159         [chromium] update flakiness dashboard to reflect current bots
3160
3161         Reviewed by Ojan Vafai.
3162
3163         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
3164             bots and merged linux debug bots into a single bot.
3165         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3166         (setupExpectationsTest):
3167
3168 2011-11-07  Dana Jansens  <danakj@chromium.org>
3169
3170         Add cc-bugs group to watch changes in chromium graphics
3171         https://bugs.webkit.org/show_bug.cgi?id=71690
3172
3173         Reviewed by James Robinson.
3174
3175         * Scripts/webkitpy/common/config/watchlist:
3176
3177 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3178
3179         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
3180         https://bugs.webkit.org/show_bug.cgi?id=70912
3181
3182         Reviewed by Ojan Vafai.
3183
3184         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
3185         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
3186
3187 2011-11-07  Eric Seidel  <eric@webkit.org>
3188
3189         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
3190         https://bugs.webkit.org/show_bug.cgi?id=62199
3191
3192         Reviewed by Dirk Pranke.
3193
3194         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3195         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3196         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3197
3198 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
3199
3200         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
3201         https://bugs.webkit.org/show_bug.cgi?id=71485
3202
3203         Reviewed by Darin Fisher.
3204
3205         * DumpRenderTree/chromium/EventSender.cpp:
3206         (EventSender::scalePageBy):
3207         * DumpRenderTree/chromium/TestShell.cpp:
3208         (TestShell::resetTestController):
3209
3210 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3211
3212         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
3213
3214         Allows us to not package up the whole Source/JavaScriptCore directory for the
3215         buildbots.
3216
3217         Reviewed-by Simon Hausmann.
3218
3219         * BuildSlaveSupport/built-product-archive:
3220         * Scripts/webkitdirs.pm:
3221         (jscProductDir):
3222
3223 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3224
3225         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
3226
3227         Reviewed-by Simon Hausmann.
3228
3229         * qmake/mkspecs/features/default_post.prf:
3230
3231 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3232
3233         [Qt] Sanitize qmake paths correctly before comparing
3234
3235         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
3236         which caused us to always generate derived webcore sources, but never build
3237         them. The bug has been fixed, and we now also sanitize paths for the injected
3238         bundle derived sources.
3239
3240         Reviewed by Simon Hausmann.
3241
3242         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3243         * qmake/mkspecs/features/functions.prf:
3244
3245 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3246
3247         [Qt] Print right order for changing feature defines
3248
3249         Reviewed by Simon Hausmann.
3250
3251         * Scripts/webkitdirs.pm:
3252         (buildQMakeProject):
3253
3254 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
3255
3256         [Qt] Unreviewed trivial fix after build system refactoring.
3257
3258         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
3259
3260 2011-11-06  Eric Seidel  <eric@webkit.org>
3261
3262         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3263         https://bugs.webkit.org/show_bug.cgi?id=66078
3264
3265         Unreviewed.  Add an assert about the type of "args"
3266         to our Executive Mocks and fix a piece of code
3267         from this patch which was hitting that assert
3268         when executing for real.
3269
3270         * Scripts/webkitpy/common/system/executive_mock.py:
3271         * Scripts/webkitpy/layout_tests/port/webkit.py:
3272
3273 2011-11-06  Eric Seidel  <eric@webkit.org>
3274
3275         Split chunk handling out of prepare_lists_and_print_output to make it more readable
3276         https://bugs.webkit.org/show_bug.cgi?id=71629
3277
3278         Reviewed by Adam Barth.
3279
3280         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3281
3282 2011-11-06  Eric Seidel  <eric@webkit.org>
3283
3284         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3285         https://bugs.webkit.org/show_bug.cgi?id=66078
3286
3287         Reviewed by Adam Barth.
3288
3289         The runtime feature detection was fixed to work in bug 64472.
3290         In this bug I moved the symbol-based feature detection from
3291         popen() to Executive.run_command and cleaned up the callers
3292         and unittests to make sure that we're correctly parsing the
3293         nm output correctly.  The old code happened to work even though
3294         the runtime-features path was using "str in list" and the
3295         symbol features path was using "str in str" and it just happened
3296         to do what we wanted to.  Now runtime features and symbol feature
3297         blacklists are computed separately (and with better documentation).
3298
3299         This system remains confusing, partially because these are black-lists
3300         which are amended to whatever static blacklist may exist for the
3301         port as part of a Skipped list file.
3302
3303         For example, notice how the runtime feature list only has directory
3304         blacklists for a couple features.  If all features are off,
3305         how do we skip enough tests with only 2 entries in the blacklist map?
3306         The answer is that Windows is the only port to use runtime feature
3307         detection, and the win/Skipped file turns off all the other features
3308         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
3309         which use symbol-based feature detection turn of mathml, wcss, etc
3310         using the blacklists found in _missing_symbol_to_skipped_tests.
3311
3312         I also noticed a couple places where we still referenced xhtmlmp
3313         even though support for such has been removed from WebKit.  Removed those.
3314
3315         This should result in no functional change.
3316
3317         * Scripts/webkitpy/layout_tests/port/gtk.py:
3318          - Use self._filesystem instead of os.path
3319         * Scripts/webkitpy/layout_tests/port/webkit.py:
3320         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3321
3322 2011-11-06  Dan Bernstein  <mitz@apple.com>
3323
3324         Made show-pretty-diff work when the input path contains spaces.
3325
3326         Reviewed by Anders Carlsson.
3327
3328         * Scripts/show-pretty-diff:
3329
3330 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
3331
3332         [chromium] Use the security origin instead of the URL when checking notification permissions
3333         https://bugs.webkit.org/show_bug.cgi?id=71590
3334
3335         Reviewed by Adam Barth.
3336
3337         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3338         (NotificationPresenter::checkPermission):
3339         * DumpRenderTree/chromium/NotificationPresenter.h:
3340
3341 2011-11-05  Darin Adler  <darin@apple.com>
3342
3343         Fix a small leak in Mac version of LayoutTestController
3344         https://bugs.webkit.org/show_bug.cgi?id=71615
3345
3346         Reviewed by Mark Rowe.
3347
3348         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3349         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
3350         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
3351
3352 2011-11-04  Eric Seidel  <eric@webkit.org>
3353
3354         Upgrade to the latest Mechanize
3355         https://bugs.webkit.org/show_bug.cgi?id=71594
3356
3357         Reviewed by Adam Barth.
3358
3359         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
3360         Mechanize is no longer two separate libraries, so importing it is much simpler.
3361
3362         * Scripts/webkitpy/thirdparty/__init__.py:
3363
3364 2011-11-04  Stephen Chenney  <schenney@chromium.org>
3365
3366         Crash in ScrollAnimator.cpp
3367         https://bugs.webkit.org/show_bug.cgi?id=69865
3368
3369         The code in ScrollAnimator assumes that horizontal per-page mouse
3370         wheel events cannot happen, which is not true. This patch adds layout
3371         tests for all paging wheel event situations and fixes the broken
3372         horizontal case.
3373
3374         Reviewed by Anders Carlsson
3375
3376         * DumpRenderTree/chromium/EventSender.cpp:
3377         (EventSender::handleMouseWheel): Added the ability to specify that a
3378         mouse wheel event should be paging.
3379
3380 2011-11-04  Eric Seidel  <eric@webkit.org>
3381
3382         Remove deprecated free functions in port.factory
3383         https://bugs.webkit.org/show_bug.cgi?id=71494
3384
3385         Unreviewed.  Fix exception when running new-run-webkit-httpd.
3386
3387         * Scripts/new-run-webkit-httpd:
3388
3389 2011-11-04  Adam Roben  <aroben@apple.com>
3390
3391         Remove Leopard-specific code from build.webkit.org
3392
3393         We don't have any Leopard bots anymore.
3394
3395         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
3396
3397         Reviewed by Mark Rowe.
3398
3399         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
3400         and StopATSServer steps.
3401         (unitTestsSupported): Removed check for mac-leopard.
3402         (TestFactory.__init__): Removed Leopard-specific steps.
3403
3404 2011-11-04  Eric Seidel  <eric@webkit.org>
3405
3406         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
3407         https://bugs.webkit.org/show_bug.cgi?id=71549
3408
3409         Reviewed by Adam Barth.
3410
3411         Several members of Host didn't really belong there
3412         and were instead specific to WebKitPatch, so I've moved
3413         them up onto that class.
3414
3415         * Scripts/webkitpy/common/host.py:
3416         * Scripts/webkitpy/common/host_mock.py:
3417         * Scripts/webkitpy/tool/main.py:
3418         * Scripts/webkitpy/tool/mocktool.py:
3419         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3420
3421 2011-11-04  Tony Chang  <tony@chromium.org>
3422
3423         garden-o-matic: bring back party time!
3424         https://bugs.webkit.org/show_bug.cgi?id=71582
3425
3426         Reviewed by Adam Barth.
3427
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
3429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3434
3435 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3436
3437         [EFL] DRT: Fix the order of the items in the dumped history list.
3438         https://bugs.webkit.org/show_bug.cgi?id=71562
3439
3440         It did not make much sense to hold the history list in a map, as we do not need
3441         the keys. And the printed items must be sorted by target, which is more easily
3442         done with a vector.
3443
3444         Should make tests such as http/tests/navigation/error404-frames.html pass.
3445
3446         Reviewed by Antonio Gomes.
3447
3448         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3449         (compareHistoryItemsByTarget):
3450         (dumpHistoryItem):
3451
3452 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3453
3454         [Qt] Remove ENABLE_SQLITE from qmake files
3455         https://bugs.webkit.org/show_bug.cgi?id=71546
3456
3457         Reviewed by Simon Hausmann.
3458
3459         * qmake/mkspecs/features/features.prf:
3460         * qmake/mkspecs/features/webcore.prf:
3461
3462 2011-11-04  Adam Barth  <abarth@webkit.org>
3463
3464         watchlist for WebIDL shouldn't trigger on Internals.idl
3465         https://bugs.webkit.org/show_bug.cgi?id=70657
3466
3467         Reviewed by David Levin.
3468
3469         Internals.idl isn't part of the Web-facing IDL in the project.
3470
3471         * Scripts/webkitpy/common/config/watchlist:
3472
3473 2011-11-04  Anders Carlsson  <andersca@apple.com>
3474
3475         Fix WKTR crash when running NPN_ConvertPoint test.
3476
3477         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3478
3479         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3480         (ConvertPoint::NPP_SetWindow):
3481
3482 2011-11-04  Anders Carlsson  <andersca@apple.com>
3483
3484         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3485         https://bugs.webkit.org/show_bug.cgi?id=71570
3486
3487         Reviewed by Simon Fraser.
3488
3489         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3490         (PluginTest::NPP_SetWindow):
3491         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3492         Remove the NPP parameter from NPP_SetWindow.
3493
3494         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3495         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3496         Remove the NPP parameter from NPP_SetWindow.
3497
3498         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3499         (PassDifferentNPPStruct::NPP_SetWindow):
3500         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3501
3502         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3503         (ConvertPoint::NPP_SetWindow):
3504         Run the test from NPP_SetWindow and call notifyDone() when done.
3505
3506         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3507         (NPP_SetWindow):
3508         Remove unnecessary parameter.
3509
3510 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3511
3512         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3513
3514         Rubber-stamped by Tor Arne Vestbø.
3515
3516         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3517         changed slightly after the refactoring.
3518
3519 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3520
3521         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3522
3523         Reviewed by Simon Hausmann.
3524
3525         * qmake/mkspecs/features/default_pre.prf:
3526
3527 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3528
3529         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3530
3531         Reviewed by Simmon Hausmann.
3532
3533         * qmake/mkspecs/features/default_pre.prf:
3534
3535 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3536
3537         [Qt] Disable STDIN check before cleaning build dir
3538
3539         It didn't work on the bots.
3540
3541         Reviewed by Ossy.
3542
3543         * Scripts/webkitdirs.pm:
3544
3545 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3546
3547         [Qt] Don't build all of webkit when running build-jsc
3548
3549         In case the whole webkit project was built, but we then subsequently
3550         want to build only JSC, we need to run make in the proper subdirectory.
3551
3552         This also means the incremental target needs to be added to all
3553         makefiles.
3554
3555         Reviewed by Simmon Hausmann.
3556
3557         * Scripts/webkitdirs.pm:
3558         (buildQMakeProject):
3559         * qmake/mkspecs/features/default_post.prf:
3560
3561 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3562
3563         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3564
3565         Reviewed by Tor Arne Vestbø.
3566
3567         * Scripts/webkitdirs.pm:
3568         (jscProductDir): jsc path changed.
3569
3570 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3571
3572         [Qt] Error out early if trying to build against Qt < 4.8
3573
3574         Reviewed by Simon Hausmann.
3575
3576         * qmake/mkspecs/features/default_pre.prf:
3577
3578 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3579
3580         Fix run-launcher for Qt and Gtk.
3581
3582         Rubber-stamped by Tor Arne Vestbø.
3583
3584         * Scripts/webkitdirs.pm:
3585         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3586
3587 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3588
3589         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3590
3591         Reviewed by Simon Hausmann.
3592
3593         * Scripts/build-webkit:
3594
3595 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3596
3597         [GTK] Use web view title as window title in MiniBrowser
3598         https://bugs.webkit.org/show_bug.cgi?id=71544
3599
3600         Reviewed by Philippe Normand.
3601
3602         * MiniBrowser/gtk/BrowserWindow.c:
3603         (webViewURIChanged): Removed extra space.
3604         (webViewTitleChanged): Set window title using
3605         webkit_web_view_get_title().
3606         (browser_window_init): Set initial default window title.
3607         (browserWindowConstructed): Connect to WebView notify::title
3608         signal.
3609
3610 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3611
3612         [Qt] Refactor and clean up the qmake build system
3613
3614         The qmake build system has accumulated a bit of cruft and redundancy
3615         over time. There's also a fairly tight coupling between how to build
3616         the various targets, and _what_ to build, making it harder to add new
3617         rules or sources. This patch aims to elevate these issues somewhat.
3618
3619         This is a short-list of the changes:
3620
3621           * The rules for how to build targets are now mostly contained as
3622             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3623             allows us to do pre- and post-processing of each project file,
3624             which helps to clean up the actual project files.
3625
3626           * Derived sources are no longer generated as a separate make-step
3627             but is part of each target's project file as a subdir. Makefile
3628             rules are used to ensure that we run make on the derived sources
3629             before running qmake on the actual target makefile. This makes
3630             it easier to keep a proper dependency between derived sources
3631             and the target.
3632
3633           * We use GNU make and the compiler to generate dependencies on
3634             UNIX-based systems running Qt 5. This allows us to lessen the
3635             need to run qmake, which should reduce compile time.
3636
3637           * WebKit2 is now build by default if building with Qt 5. It can
3638             be disabled by passing --no-webkit2 to build-webkit.
3639
3640         The result of these changes are hopefully a cleaner and easier
3641         build system to modify, and faster build times due to no longer
3642         running qmake on every single build. It's also a first step
3643         towards possibly generating the list of sources using another
3644         build system.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=71222
3647
3648         Reviewed by Simon Hausmann.
3649
3650         * DerivedSources.pro: Removed.
3651         * DumpRen