b95a8fb6db6643453489097d999bf08d4fb09b25
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-26  Doug Russell  <d_russell@apple.com>
2
3         AX: richer text change notifications (142719)
4         https://bugs.webkit.org/show_bug.cgi?id=142719
5
6         Reviewed by Darin Adler.
7
8         Richer accessibility value change notifications. Introduce AXTextEditType,
9         postTextStateChangeNotification and postTextReplacementNotification to give assistive
10         tech apps more reliable context for responding to changes in web content. Also implement
11         a mechanism to post value changes in password form fields in coalesced ticks to thwart
12         analyzing the cadence of changes.
13
14         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
15         and an overload of postTextReplacementNotification to give assistive tech apps more
16         reliable context for responding to changes in web content selection. Also block posting
17         selection changes on password fields.
18
19         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
20         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
21         (-[AccessibilityNotificationHandler stopObserving]):
22         (-[AccessibilityNotificationHandler _notificationReceived:]):
23         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
24         (AccessibilityUIElement::removeNotificationListener):
25         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
26         (-[AccessibilityNotificationHandler _notificationReceived:]):
27         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
28         (WTR::AccessibilityUIElement::removeNotificationListener):
29
30 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
31
32         Add myself to contributors.json
33         https://bugs.webkit.org/show_bug.cgi?id=144204
34
35         Reviewed by Darin Adler.
36
37         * Scripts/webkitpy/common/config/contributors.json:
38
39 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
40
41         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
42         https://bugs.webkit.org/show_bug.cgi?id=144182
43
44         Reviewed by Simon Fraser.
45
46         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
47
48 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
49
50         https://bugs.webkit.org/show_bug.cgi?id=144038
51
52         Reviewed by Ryosuke Niwa
53
54         Add a script to run Speedometer and JetStream on a browser.
55
56         * Scripts/run-benchmark: Wrapper script to run benchmark.
57         (main):
58         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
59         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
60         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
61         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
62         (BenchmarkBuilderFactory):
63         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
64         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
65         (GenericBenchmarkBuilder):
66         (GenericBenchmarkBuilder.prepare):
67         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
68         (GenericBenchmarkBuilder._applyPatch):
69         (GenericBenchmarkBuilder.clean):
70         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
71         (JetStreamBenchmarkBuilder):
72         (JetStreamBenchmarkBuilder.prepare):
73         (JetStreamBenchmarkBuilder._runCreateScript):
74         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
75         (BenchmarkRunner):
76         (BenchmarkRunner.__init__):
77         (BenchmarkRunner.execute):
78         (BenchmarkRunner.dump):
79         (BenchmarkRunner.wrap):
80         (BenchmarkRunner.merge):
81         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
82         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
83         (BrowserDriver):
84         (BrowserDriver.prepareEnv):
85         (BrowserDriver.launchUrl):
86         (BrowserDriver.closeBrowser):
87         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
88         (BrowserDriverFactory):
89         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
90         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
91         (OSXChromeDriver):
92         (OSXChromeDriver.prepareEnv):
93         (OSXChromeDriver.launchUrl):
94         (OSXChromeDriver.closeBrowsers):
95         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
96         (OSXSafariDriver):
97         (OSXSafariDriver.prepareEnv):
98         (OSXSafariDriver.launchUrl):
99         (OSXSafariDriver.closeBrowsers):
100         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
101         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
102         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
103         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
104         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
105         (GenericFactory):
106         (GenericFactory.iterateGetItem):
107         (GenericFactory.create):
108         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
109         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
110         (ServerControl):
111         (ServerControl.render_GET):
112         (ServerControl.render_POST):
113         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
114         (HTTPServerDriver):
115         (HTTPServerDriver.serve):
116         (HTTPServerDriver.fetchResult):
117         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
118         (HTTPServerDriverFactory):
119         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
120         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
121         (SimpleHTTPServerDriver):
122         (SimpleHTTPServerDriver.depends):
123         (SimpleHTTPServerDriver.__init__):
124         (SimpleHTTPServerDriver.serve):
125         (SimpleHTTPServerDriver.baseUrl):
126         (SimpleHTTPServerDriver.fetchResult):
127         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
128         (ModuleNotFoundError):
129         (loadModule):
130         (getPathFromProjectRoot):
131         (loadJSONFromFile):
132         (TimeoutError):
133         (timeout):
134         (timeout.__init__):
135         (timeout.handle_timeout):
136         (timeout.__enter__):
137         (timeout.__exit__):
138
139 2015-04-24  Commit Queue  <commit-queue@webkit.org>
140
141         Unreviewed, rolling out r183303.
142         https://bugs.webkit.org/show_bug.cgi?id=144181
143
144         Change was incorrect, broke builds (Requested by smfr on
145         #webkit).
146
147         Reverted changeset:
148
149         "Fix the build."
150         http://trac.webkit.org/changeset/183303
151
152 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
153
154         Fix the build.
155
156         * MiniBrowser/mac/WK2BrowserWindowController.m:
157         (-[WK2BrowserWindowController initWithConfiguration:]):
158
159 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
160
161         Disable ActionMenusPDFTest due to timeout on test bot
162
163         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
164         (TestWebKitAPI::TEST):
165
166 2015-04-24  Commit Queue  <commit-queue@webkit.org>
167
168         Unreviewed, rolling out r183266.
169         https://bugs.webkit.org/show_bug.cgi?id=144164
170
171         Broke 32-bit build and a test. (Requested by ap on #webkit).
172
173         Reverted changeset:
174
175         "AX: richer text change notifications (142719)"
176         https://bugs.webkit.org/show_bug.cgi?id=142719
177         http://trac.webkit.org/changeset/183266
178
179 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
180
181         REGRESSION: WebKit2.ActionMenusTest API test fails
182         https://bugs.webkit.org/show_bug.cgi?id=144149
183         <rdar://problem/20677770>
184
185         Reviewed by Tim Horton.
186
187         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
188         as the 'ActionMenusPDFTest'.
189         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
190         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
191         to match the hit test on the 'action-menu-target.pdf' test file.
192
193 2015-04-24  Daniel Bates  <dabates@apple.com>
194
195         Cleanup: Use @memoized for property IOSSimulator.testing_device
196         https://bugs.webkit.org/show_bug.cgi?id=141715
197
198         Reviewed by Darin Adler.
199
200         Simplify the caching of the result of IOSSimulator.testing_device
201         and make the code more readable by making use of the @memoized declarator
202         instead of explicitly managing a private instance variable,
203         IOSSimulator._testing_device, for the cached result.
204
205         * Scripts/webkitpy/port/ios.py:
206         (IOSPort.determine_full_port_name):
207         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
208         (IOSSimulatorPort):
209         (IOSSimulatorPort.testing_device): No need to cache the created device object in
210         IOSSimulatorPort._testing_device since we are marking this function @memoized.
211         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
212         of caching in local variable since we only make use of this value exactly once in this function.
213         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
214         been used since being added in r178622. So, we can remove this constructor since
215         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
216
217 2015-04-24  Anders Carlsson  <andersca@apple.com>
218
219         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
220         https://bugs.webkit.org/show_bug.cgi?id=144158
221
222         Reviewed by Beth Dakin.
223
224         * MiniBrowser/mac/WK2BrowserWindowController.m:
225         (-[WK2BrowserWindowController initWithConfiguration:]):
226
227 2015-04-24  Doug Russell  <d_russell@apple.com>
228
229         AX: richer text change notifications (142719)
230         https://bugs.webkit.org/show_bug.cgi?id=142719
231
232         Reviewed by Darin Adler.
233
234         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
235
236         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
237
238         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
239         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
240         (-[AccessibilityNotificationHandler stopObserving]):
241         (-[AccessibilityNotificationHandler _notificationReceived:]):
242         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
243         (AccessibilityUIElement::removeNotificationListener):
244         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
245         (-[AccessibilityNotificationHandler _notificationReceived:]):
246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
247         (WTR::AccessibilityUIElement::removeNotificationListener):
248
249 2015-04-24  Darin Adler  <darin@apple.com>
250
251         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
252         https://bugs.webkit.org/show_bug.cgi?id=128007
253
254         Reviewed by Anders Carlsson.
255
256         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
257         * DumpRenderTree/win/UIDelegate.h: Ditto.
258
259         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
260         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
261
262         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
263
264         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
265         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
266         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
267         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
268         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
269         (WebKitDOMDOMWindowTest::create): Ditto.
270         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
271         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
272         of smart pointers to DelayedSIgnal objects.
273         (uriChangedCallback): Ditto.
274
275 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
276
277         [Mac] Unreviewed test fix.
278         https://bugs.webkit.org/show_bug.cgi?id=144149
279
280         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
281         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
282         test.
283
284 2015-04-23  Darin Adler  <darin@apple.com>
285
286         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
287         https://bugs.webkit.org/show_bug.cgi?id=144090
288
289         Reviewed by Anders Carlsson.
290
291         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
292
293 2015-04-23  Michael Saboff  <msaboff@apple.com>
294
295         lldb macro btjs sometimes can't get a frame description
296         https://bugs.webkit.org/show_bug.cgi?id=144130
297
298         Reviewed by Filip Pizlo.
299
300         We look to execute ExecState::describeFrame().  It appears that in some contexts the
301         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
302         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
303
304         * lldb/lldb_webkit.py:
305         (btjs):
306
307 2015-04-23  Alex Christensen  <achristensen@webkit.org>
308
309         Use less memory when compiling content extensions.
310         https://bugs.webkit.org/show_bug.cgi?id=144051
311
312         Reviewed by Darin Adler and Benjamin Poulain.
313
314         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
315         (TestWebKitAPI::TEST_F):
316         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
317         (TestWebKitAPI::countLiveNodes):
318
319 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
320
321         [CMake] Clean up JSC JIT options
322         https://bugs.webkit.org/show_bug.cgi?id=143998
323
324         Reviewed by Filip Pizlo.
325
326         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
327         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
328
329 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
330
331         [Mac] Extend action menus to support PDF
332         https://bugs.webkit.org/show_bug.cgi?id=143895
333         <rdar://problem/19003333>
334
335         Reviewed by Tim Horton.
336
337         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
338         of PDF content works.
339
340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
341         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
342         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
343         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
344         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
345         Update to support PDF tests.
346         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
347         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
348
349 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
350
351         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
352
353         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
354         (beforeAll):
355         (testWebViewAudioOnlyUserMediaPermissionRequests):
356
357 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
358
359         Add myself to watchlist
360         https://bugs.webkit.org/show_bug.cgi?id=144041
361
362         Reviewed by Alex Christensen.
363
364         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
365
366         * Scripts/webkitpy/common/config/watchlist:
367
368 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
369
370         [GTK] MiniBrowser should use NetworkProcess by default
371         https://bugs.webkit.org/show_bug.cgi?id=143948
372
373         Reviewed by Sergio Villar Senin.
374
375         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
376         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
377
378         * MiniBrowser/gtk/main.c:
379         (main):
380
381 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
382
383         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
384
385         Unreviewed build fix.
386
387         * Scripts/prepare-ChangeLog:
388         (get_function_line_ranges_for_cpp):
389         Use grep instead of any to determine if a string is an element of an array.
390
391 2015-04-21  Anders Carlsson  <andersca@apple.com>
392
393         Fix block signatures
394         https://bugs.webkit.org/show_bug.cgi?id=144002
395
396         Reviewed by Andreas Kling.
397
398         * MiniBrowser/mac/WK2BrowserWindowController.m:
399         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
400
401 2015-04-21  Philippe Normand  <pnormand@igalia.com>
402
403         [GTK] jhbuild should not use a branch for openwebrtc
404         https://bugs.webkit.org/show_bug.cgi?id=143981
405
406         Reviewed by Carlos Garcia Campos.
407
408         * gtk/jhbuild.modules:
409
410 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
411
412         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
413
414         Unreviewed build fix.
415
416         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
417         However, it has been exposed by List::MoreUtils since its inception. This patch uses
418         the any function exposed by List::MoreUtils for greater compatibility.
419
420         * Scripts/prepare-ChangeLog:
421         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
422         the any function in all of versions of Perl used by our infrastructure.
423
424 2015-04-20  Alex Christensen  <achristensen@webkit.org>
425
426         Remove unnecessary logs when resetting tests.
427
428         * WebKitTestRunner/mac/TestControllerMac.mm:
429         (WTR::TestController::platformResetPreferencesToConsistentValues):
430         In r183020 I added some logs when compiling or removing content extensions fails.
431         We often try to remove a content extension that does not exist, and that is not a problem.
432
433 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
434
435         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
436         https://bugs.webkit.org/show_bug.cgi?id=143897
437
438         Reviewed by David Kilzer.
439
440         This is a speculative fix that addresses two issues:
441
442         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
443         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
444
445         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
446         Before: (723, 729)
447         After: (721, 720)
448
449         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
450         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
451
452         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
453         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
454
455         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
456
457         2. Creating git diffs from HEAD and not origin/master by default.
458
459         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
460         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
461
462         * Scripts/prepare-ChangeLog:
463         (originalFile):
464         Use HEAD instead of origin/master in default Git case.
465
466         (generateFunctionLists):
467         Ensure that the end line is not less than the start line.
468
469         (extractLineRangeAfterChange):
470         Set the end line to the start line if the end line is less than the start line.
471
472         (extractLineRangeBeforeChange):
473         Ditto.
474
475 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
476
477         Suppress warning in prepare-ChangeLog.
478         https://bugs.webkit.org/show_bug.cgi?id=143882
479
480         Reviewed by David Kilzer.
481
482         Prune noisy prepare-ChangeLog output by using the List::Util::any function
483         instead of the deprecated smartmatch operator.
484
485         * Scripts/prepare-ChangeLog:
486         Import the List::Util::any function.
487
488         (get_function_line_ranges_for_cpp):
489         Use the any function instead of smartmatch.
490
491 2015-04-20  Anders Carlsson  <andersca@apple.com>
492
493         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
494         https://bugs.webkit.org/show_bug.cgi?id=143966
495
496         Reviewed by Dan Bernstein.
497
498         * MiniBrowser/mac/WK2BrowserWindowController.m:
499         (dataTypes):
500         (-[WK2BrowserWindowController fetchWebsiteData:]):
501         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
502         (-[WK2BrowserWindowController clearWebsiteData:]):
503
504 2015-04-20  Alex Christensen  <achristensen@webkit.org>
505
506         Fix content extension test flakiness.
507         https://bugs.webkit.org/show_bug.cgi?id=143950
508
509         Reviewed by Brady Eidson.
510
511         * WebKitTestRunner/mac/TestControllerMac.mm:
512         (WTR::TestController::platformResetPreferencesToConsistentValues):
513         Remove the TestContentExtensions if it exists.
514         (WTR::TestController::platformConfigureViewForTest):
515         Log errors in case there are any.
516
517 2015-04-20  Alex Christensen  <achristensen@webkit.org>
518
519         Properly report errors from _WKUserContentExtensionStore.
520         https://bugs.webkit.org/show_bug.cgi?id=143808
521
522         Reviewed by Darin Adler.
523
524         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
525         (TEST_F):
526
527 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
528
529         Add a rule for NetworkCache to watchlist file
530         https://bugs.webkit.org/show_bug.cgi?id=143945
531
532         Reviewed by Sergio Villar Senin.
533
534         And add myself to the list of watchers.
535
536         * Scripts/webkitpy/common/config/watchlist:
537
538 2015-04-19  Darin Adler  <darin@apple.com>
539
540         Update RefPtr documentation and deprecation
541         https://bugs.webkit.org/show_bug.cgi?id=143936
542
543         Reviewed by Andreas Kling.
544
545         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
546
547 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
548
549         Introduce bytecode intrinsics
550         https://bugs.webkit.org/show_bug.cgi?id=143926
551
552         Reviewed by Filip Pizlo.
553
554         Change cpplint to accept emit_intrinsic_XXX.
555
556         * Scripts/webkitpy/style/checkers/cpp.py:
557         (check_identifier_name_in_declaration):
558
559 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
560
561         Fix lldb_webkit.py to show StringImpls correctly
562         https://bugs.webkit.org/show_bug.cgi?id=143920
563
564         Reviewed by Andreas Kling.
565         
566         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
567
568         * lldb/lldb_webkit.py:
569         (WTFStringImplProvider.is_8bit):
570
571 2015-04-17  Daniel Bates  <dabates@apple.com>
572
573         Not able to build WebKit against iOS Simulator 8.3 SDK
574         https://bugs.webkit.org/show_bug.cgi?id=143883
575
576         Reviewed by David Kilzer.
577
578         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
579         so that Xcode uses them.
580
581         * Scripts/copy-webkitlibraries-to-product-directory:
582
583 2015-04-17  Beth Dakin  <bdakin@apple.com>
584
585         Force mouse events should go through normal mouse event handling code paths
586         https://bugs.webkit.org/show_bug.cgi?id=143749
587         -and corresponding-
588         rdar://problem/20472895
589
590         Reviewed by Dean Jackson.
591
592         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
593         Since there is not a way to create an NSEventTypePressure from scratch, we 
594         subclass NSEvent and override all of the critical methods.
595
596         * WebKitTestRunner/EventSenderProxy.h:
597         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
598         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
599         (WTR::EventSendingController::mouseForceDown):
600         (WTR::EventSendingController::mouseForceUp):
601         (WTR::EventSendingController::mouseForceChanged):
602         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
605         * WebKitTestRunner/mac/EventSenderProxy.mm:
606         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
607         (-[EventSenderPressureEvent timestamp]):
608         (-[EventSenderPressureEvent type]):
609         (-[EventSenderPressureEvent locationInWindow]):
610         (-[EventSenderPressureEvent location]):
611         (-[EventSenderPressureEvent stage]):
612         (-[EventSenderPressureEvent pressure]):
613         (-[EventSenderPressureEvent phase]):
614         (-[EventSenderPressureEvent eventNumber]):
615         (WTR::EventSenderProxy::mouseForceDown):
616         (WTR::EventSenderProxy::mouseForceUp):
617         (WTR::EventSenderProxy::mouseForceChanged):
618
619 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
620
621         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
622         https://bugs.webkit.org/show_bug.cgi?id=143885
623
624         Reviewed by Tim Horton.
625
626         Fixed a case where we have two builds with the same revision(s). An in order build
627         is one for which the revision is strictly higher.
628
629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
630         (BuildbotQueue.prototype._checkForInOrderResult):
631         (BuildbotQueue.prototype.compareIterationsByRevisions):
632
633 2015-04-17  Commit Queue  <commit-queue@webkit.org>
634
635         Unreviewed, rolling out r182912 and r182920.
636         https://bugs.webkit.org/show_bug.cgi?id=143881
637
638         Build breakage in some configurations (Requested by ap on
639         #webkit).
640
641         Reverted changesets:
642
643         "Force mouse events should go through normal mouse event
644         handling code paths"
645         https://bugs.webkit.org/show_bug.cgi?id=143749
646         http://trac.webkit.org/changeset/182912
647
648         http://trac.webkit.org/changeset/182920
649
650 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
651
652         [GTK] One more unreviewed fix after r182882.
653
654         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
655
656 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
657
658         [GTK] Unreviewed speculative clean build fix after r182882.
659
660         TestWebKitAPI's forwarding header generator depended on WeKit2's
661         which generated SOUP related forwarding headers too.
662
663         This dependency isn't necessary and was removed by r182882 to make
664         forwarding header generators parallelizable. But in this case
665         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
666         should generate SOUP related forwarding headers too similar to EFL.
667
668         * TestWebKitAPI/PlatformGTK.cmake:
669         * WebKitTestRunner/PlatformGTK.cmake:
670
671 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
672
673         [SOUP] Redirect to non HTTP destination is broken
674         https://bugs.webkit.org/show_bug.cgi?id=143866
675
676         Reviewed by Sergio Villar Senin.
677
678         Add a unit test to check that redirect to a data URI works.
679
680         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
681         (testRedirectToDataURI):
682         (serverCallback):
683         (beforeAll):
684
685 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
686
687         Changes method of quitting iOS Simulator to be more correct.
688         https://bugs.webkit.org/show_bug.cgi?id=143847
689         <rdar://problem/20530344>
690
691         Reviewed by Darin Adler.
692
693         Fixes by addressing the app by ID rather than by name.
694
695         * Scripts/webkitdirs.pm:
696         (quitIOSSimulator):
697         * Scripts/webkitpy/port/ios.py:
698         (IOSSimulatorPort.check_sys_deps):
699
700 2015-04-16  Anders Carlsson  <andersca@apple.com>
701
702         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
703         https://bugs.webkit.org/show_bug.cgi?id=143844
704
705         Reviewed by Dan Bernstein.
706
707         * MiniBrowser/mac/AppDelegate.m:
708         (-[BrowserAppDelegate newPrivateWindow:]):
709         * MiniBrowser/mac/WK2BrowserWindowController.m:
710         (-[WK2BrowserWindowController initWithConfiguration:]):
711         (-[WK2BrowserWindowController fetchWebsiteData:]):
712         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
713         (-[WK2BrowserWindowController clearWebsiteData:]):
714
715 2015-04-16  Alex Christensen  <achristensen@webkit.org>
716
717         32-bit build fix.
718
719         * WebKitTestRunner/mac/TestControllerMac.mm:
720         (WTR::TestController::platformResetPreferencesToConsistentValues):
721         (WTR::TestController::platformConfigureViewForTest):
722         Added WK_API_ENABLED.
723
724 2015-04-16  Alex Christensen  <achristensen@webkit.org>
725
726         Removed unused WKUserContentFilterRef.
727         https://bugs.webkit.org/show_bug.cgi?id=143852
728
729         Reviewed by Sam Weinig.
730
731         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
732         * WebKitTestRunner/mac/TestControllerMac.mm:
733         (WTR::TestController::platformResetPreferencesToConsistentValues):
734         (WTR::TestController::platformConfigureViewForTest):
735
736 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
737
738         Unreviewed. Adding myself as a commiter in contributers.json.
739
740         * Scripts/webkitpy/common/config/contributors.json:
741
742 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
743
744         It is very hard to attach a debugger to WebProcess to debug tests
745         https://bugs.webkit.org/show_bug.cgi?id=143837
746
747         Reviewed by Chris Dumez.
748
749         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
750         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
751
752         Now it disables all timeouts in tools, as is best for debugging tests.
753
754         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
755         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
756
757         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
758         now has the same functionality.
759
760 2015-04-16  Beth Dakin  <bdakin@apple.com>
761
762         Force mouse events should go through normal mouse event handling code paths
763         https://bugs.webkit.org/show_bug.cgi?id=143749
764         -and corresponding-
765         rdar://problem/20472895
766
767         Reviewed by Dean Jackson.
768
769         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
770         Since there is not a way to create an NSEventTypePressure from scratch, we 
771         subclass NSEvent and override all of the critical methods.
772
773         * WebKitTestRunner/EventSenderProxy.h:
774         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
775         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
776         (WTR::EventSendingController::mouseForceDown):
777         (WTR::EventSendingController::mouseForceUp):
778         (WTR::EventSendingController::mouseForceChanged):
779         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
780         * WebKitTestRunner/TestController.cpp:
781         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
782         * WebKitTestRunner/mac/EventSenderProxy.mm:
783         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
784         (-[EventSenderPressureEvent timestamp]):
785         (-[EventSenderPressureEvent type]):
786         (-[EventSenderPressureEvent locationInWindow]):
787         (-[EventSenderPressureEvent location]):
788         (-[EventSenderPressureEvent stage]):
789         (-[EventSenderPressureEvent pressure]):
790         (-[EventSenderPressureEvent phase]):
791         (-[EventSenderPressureEvent eventNumber]):
792         (WTR::EventSenderProxy::mouseForceDown):
793         (WTR::EventSenderProxy::mouseForceUp):
794         (WTR::EventSenderProxy::mouseForceChanged):
795
796 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
797
798         [EFL] Bump LLVM to version 3.6.0 on X86_64
799         https://bugs.webkit.org/show_bug.cgi?id=143604
800
801         Reviewed by Gyuyoung Kim.
802
803         * efl/jhbuild.modules:
804         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
805         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
806         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
807         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
808
809 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
810
811         [EFL] Remove an unnecessary workaround from jhbuildrc
812         https://bugs.webkit.org/show_bug.cgi?id=143823
813
814         Reviewed by Gyuyoung Kim.
815
816         * efl/jhbuildrc:
817
818 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
819
820         [GTK] Run forwarding headers generator unconditionally
821         https://bugs.webkit.org/show_bug.cgi?id=143819
822
823         Reviewed by Carlos Garcia Campos.
824
825         * TestWebKitAPI/PlatformGTK.cmake:
826         * WebKitTestRunner/PlatformGTK.cmake:
827
828 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
829
830         [EFL] Add gnutls to jhbuild.module
831         https://bugs.webkit.org/show_bug.cgi?id=143777
832
833         Reviewed by Csaba Osztrogonác.
834
835         EFL port has required at least 3.0.0 version of gnutls since r176712.
836         However some old linux distributions don't support 3.0.0 version. Besides
837         other projects sometimes need to use lower version of gnutls.
838
839         This patch supports to download gnutls through jhbuild, and use it.
840
841         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
842         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
843
844 2015-04-15  Mark Lam  <mark.lam@apple.com>
845
846         Remove obsolete VMInspector debugging tool.
847         https://bugs.webkit.org/show_bug.cgi?id=143798
848
849         Reviewed by Michael Saboff.
850
851         * TestWebKitAPI/CMakeLists.txt:
852         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
853         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
855         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
856
857 2015-04-15  Jer Noble  <jer.noble@apple.com>
858
859         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
860
861         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
862
863 2015-04-15  Jer Noble  <jer.noble@apple.com>
864
865         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
866
867         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
868         (TestWebKitAPI::TEST_F):
869
870 2015-04-15  Chris Dumez  <cdumez@apple.com>
871
872         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
873         https://bugs.webkit.org/show_bug.cgi?id=143779
874
875         Reviewed by Brent Fulgham.
876
877         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
878         similarly to what is done on Mac / WK1. Without this, PageCache could
879         stay enabled after page cache tests and cause weird behaviors.
880
881         * DumpRenderTree/win/DumpRenderTree.cpp:
882         (resetWebPreferencesToConsistentValues):
883
884 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
885
886         Re-enable custom dilation for antialiased fonts
887         https://bugs.webkit.org/show_bug.cgi?id=143738
888
889         Reviewed by Tim Horton.
890         
891         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
892         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
893         a private WebKit pref. This pref defaults to YES, enabling the feature by default
894         in WK1 as we do for WK2.
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (resetWebPreferencesToConsistentValues):
898         * WebKitTestRunner/TestController.cpp:
899         (WTR::TestController::resetPreferencesToConsistentValues):
900
901 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
902
903         Correct layering violation in DumpRenderTree Build
904         https://bugs.webkit.org/show_bug.cgi?id=143732
905
906         Reviewed by Simon Fraser.
907
908         Correct a layering violation in DumpRenderTree by calling functions on the
909         WebCoreTestSupport library, rather than attempting to work with WebCore
910         types directly.
911
912         * DumpRenderTree/mac/EventSendingController.mm:
913         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
914         than WebCore itself.,
915         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
916
917 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
918
919         Add a conservative DFA minimizer for the content extension matcher
920         https://bugs.webkit.org/show_bug.cgi?id=143501
921
922         Reviewed by Alex Christensen.
923
924         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
925         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
926
927 2015-04-14  Daniel Bates  <dabates@apple.com>
928
929         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
930         https://bugs.webkit.org/show_bug.cgi?id=143693
931         <rdar://problem/20530316>
932
933         Reviewed by Tim Horton.
934
935         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
936         to use the fixed layout code on iOS at this time.
937
938         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
939
940 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
941
942         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
943         https://bugs.webkit.org/show_bug.cgi?id=143705
944
945         Unreviewed change to watchlist file.
946
947         * Scripts/webkitpy/common/config/watchlist:
948
949 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
950
951         [EFL] favicon wasn't updated for google.com sometimes.
952         https://bugs.webkit.org/show_bug.cgi?id=141940
953
954         Reviewed by Gyuyoung Kim.
955
956         As elm_entry_utf8_to_markup can include additional characters, parameter for the
957         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
958
959         * MiniBrowser/efl/main.c:
960         (on_url_changed):
961
962 2015-04-13  Tim Horton  <timothy_horton@apple.com>
963
964         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
965         https://bugs.webkit.org/show_bug.cgi?id=143560
966         <rdar://problem/16302047>
967
968         Reviewed by Darin Adler.
969
970         * MiniBrowser/mac/BrowserWindowController.h:
971         * MiniBrowser/mac/MainMenu.xib:
972         * MiniBrowser/mac/WK1BrowserWindowController.m:
973         (-[WK1BrowserWindowController setScale:]):
974         * MiniBrowser/mac/WK2BrowserWindowController.m:
975         (viewScaleForMenuItemTag):
976         (-[WK2BrowserWindowController setScale:]):
977         (-[WK2BrowserWindowController validateMenuItem:]):
978         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
979         When in use, we resize the window so that the view fits correctly, and
980         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
981         layout size will not change when scaling down (but will update appropriately
982         when the view is resized).
983
984 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
985
986         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
987         https://bugs.webkit.org/show_bug.cgi?id=138630
988
989         Reviewed by Tim Horton.
990
991         Make sure that we always load at least one in order productive iteration.
992
993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
994         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
995         is done loading at least one iteration that wasn't an out of order build.
996         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
997         when that's needed to check for out of order builds.
998         (BuildbotQueue.prototype.update): Ditto.
999         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1000         result, and if it does not, load more iterations.
1001         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1002         an in order iteration loaded too.
1003         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1004         corrected to always sort loaded iterations before unloaded ones.
1005
1006 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
1007
1008         Expand test infrastructure to support scrolling tests
1009         https://bugs.webkit.org/show_bug.cgi?id=143286
1010         <rdar://problem/20375516>
1011
1012         Reviewed by Simon Fraser.
1013
1014         Extend the WK1 and WK2 test programs to support two new EventSender commands:
1015         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1016         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1017         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1018         relevant rubberband, scroll, and scroll-snap animations are finished.
1019
1020         * DumpRenderTree/mac/EventSendingController.mm:
1021         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1022         and 'monitorWheelEvents'.
1023         (+[EventSendingController webScriptNameForSelector:]): Ditto.
1024         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1025         debugging test failures.
1026         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1027         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1028         function, then passes it to WebCore to be called once the test deferrals have been cleared.
1029         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1030         'callAfterScrollingCompletes' method.
1031         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1032         and 'monitorWheelEvents'.
1033         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1034         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1035         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1036         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1037         'callAfterScrollingComplates' method.
1038         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1039
1040 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1041
1042         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1043         https://bugs.webkit.org/show_bug.cgi?id=143656
1044
1045         Reviewed by Darin Adler.
1046
1047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1048         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1049
1050 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
1051
1052         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1053         https://bugs.webkit.org/show_bug.cgi?id=142387
1054
1055         Reviewed by Carlos Garcia Campos.
1056
1057         Running mixed content is blocked by default since r181134. Updated
1058         the test case to reflect the new default settings.
1059
1060         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1061         (testInsecureContent):
1062
1063 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1064
1065         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1066         https://bugs.webkit.org/show_bug.cgi?id=143667
1067
1068         Reviewed by Csaba Osztrogonác.
1069
1070         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1071         since r169017. Added $hardwareConcurrencySupport for it.
1072
1073         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1074
1075         * Scripts/webkitperl/FeatureList.pm:
1076
1077 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
1078
1079         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1080         https://bugs.webkit.org/show_bug.cgi?id=143664
1081
1082         Reviewed by Gyuyoung Kim.
1083
1084         * Scripts/webkitperl/FeatureList.pm:
1085
1086 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1087
1088         [EFL] Enable Media Source
1089         https://bugs.webkit.org/show_bug.cgi?id=143635
1090
1091         Reviewed by Csaba Osztrogonác.
1092
1093         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1094
1095 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
1096
1097         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1098         https://bugs.webkit.org/show_bug.cgi?id=143646
1099
1100         Reviewed by David Kilzer.
1101
1102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1103         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1104
1105 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
1106
1107         Use en_US spell checker for tests on Mac instead of Multilingual
1108         https://bugs.webkit.org/show_bug.cgi?id=143641
1109
1110         Reviewed by Dan Bernstein.
1111
1112         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1113         While at it, override NSUserDictionaryReplacementItems, so that user replacements
1114         cannot affect tests.
1115
1116         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1117         Made this more like WebKit1 version.
1118
1119 2015-04-10  Tim Horton  <timothy_horton@apple.com>
1120
1121         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1122         https://bugs.webkit.org/show_bug.cgi?id=143576
1123
1124         Reviewed by Simon Fraser.
1125
1126         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1127         (TEST):
1128         Adopt.
1129
1130 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1131
1132         Update my email address and expertise.
1133         https://bugs.webkit.org/show_bug.cgi?id=143586
1134
1135         Unreviewed, just update my info.
1136
1137         * Scripts/webkitpy/common/config/contributors.json:
1138
1139 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
1140
1141         Flakiness Dashboard not loading insecure content if loaded with https URL
1142         https://bugs.webkit.org/show_bug.cgi?id=143570
1143
1144         Reviewed by Alexey Proskuryakov.
1145
1146         * TestResultServer/app.yaml:
1147         * TestResultServer/static-dashboards/loader.js:
1148         Switch to https scheme.
1149
1150 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
1151
1152         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1153         https://bugs.webkit.org/show_bug.cgi?id=142907
1154
1155         Reviewed by Carlos Garcia Campos.
1156
1157         * TestWebKitAPI/PlatformEfl.cmake:
1158         * TestWebKitAPI/PlatformGTK.cmake:
1159         * WebKitTestRunner/PlatformEfl.cmake:
1160         * WebKitTestRunner/PlatformGTK.cmake:
1161
1162 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1163
1164         [Mac] Unreviewed test fix after r182584
1165         https://bugs.webkit.org/show_bug.cgi?id=143452
1166
1167         Put both of these tests back to their original state now that the underlying
1168         problem is fixed.
1169
1170         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1171         (TestWebKitAPI::TEST):
1172         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1173         (TestWebKitAPI::TEST):
1174
1175 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
1176
1177         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1178         https://bugs.webkit.org/show_bug.cgi?id=143553
1179
1180         Reviewed by Ryosuke Niwa.
1181         
1182         Remove the spurious printVMs left over from an earlier change.
1183
1184         * Scripts/run-jsc-benchmarks:
1185
1186 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1187
1188         [Mac] Unreviewed test fix after r182581
1189
1190         The behavior of control-left-click is controlled by a system preference.
1191         Our test bots have this turned off.
1192
1193         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1194         (TestWebKitAPI::TEST):
1195         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1196         (TestWebKitAPI::TEST):
1197
1198 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1199
1200         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1201         https://bugs.webkit.org/show_bug.cgi?id=143452
1202         <rdar://problem/20437483>
1203
1204         Reviewed by Tim Horton.
1205
1206         Add a new API test to confirm that Cocoa mouse button press events are properly
1207         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1208
1209         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1210         some registered event handlers that the expected button press and context menu
1211         events are received.
1212
1213         The WK1 unit test creates an NSEvent with the desired button press state, and then
1214         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1215         We check the resulting PlatformMouseEvent for proper state.
1216
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1218         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1219         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1220         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1221         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1222         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1223         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1224         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1225         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1226         mouse down events.
1227         * TestWebKitAPI/mac/PlatformWebViewMac.h:
1228
1229 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1230
1231         [GTK] Add pango to jhbuild-optional.modules
1232         https://bugs.webkit.org/show_bug.cgi?id=143537
1233
1234         Reviewed by Martin Robinson.
1235
1236         * gtk/jhbuild-optional.modules: Add pango.
1237
1238 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1239
1240         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1241         https://bugs.webkit.org/show_bug.cgi?id=143530
1242
1243         Reviewed by Žan Doberšek.
1244
1245         Assume that the default value for display (:0) is reserved and start checking on :1
1246         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1247         and for X server named Xorg.bin (previous bug 1376599)
1248
1249         * Scripts/webkitpy/port/xvfbdriver.py:
1250         (XvfbDriver._next_free_display)
1251         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1252         (XvfbDriverTest.test_start_no_pixel_tests):
1253         (XvfbDriverTest.test_start_pixel_tests):
1254         (XvfbDriverTest.test_start_arbitrary_worker_number):
1255         (XvfbDriverTest.test_next_free_display):
1256         (XvfbDriverTest.test_start_next_worker):
1257 2015-04-08  Alex Christensen  <achristensen@webkit.org>
1258
1259         Block popups from content extensions.
1260         https://bugs.webkit.org/show_bug.cgi?id=143497
1261
1262         Reviewed by Brady Eidson.
1263
1264         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1265         (TestWebKitAPI::TEST_F):
1266         Added popup test.
1267
1268 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
1269
1270         Add CMake build system for WinCairo port.
1271         https://bugs.webkit.org/show_bug.cgi?id=115944
1272
1273         Reviewed by Chris Dumez.
1274
1275         * CMakeLists.txt:
1276         * WinLauncher/CMakeLists.txt: Added.
1277
1278 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1279
1280         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
1281         https://bugs.webkit.org/show_bug.cgi?id=143521
1282
1283         Reviewed by Martin Robinson.
1284
1285         Add a way to detect unexpected web process crashes to WebViewTest,
1286         and a test case to testDOMCache to trigger the crash.
1287
1288         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1289         (WebKitDOMNodeTest::testDOMCache):
1290         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1291         (testWebKitWebViewProcessCrashed):
1292         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1293         (WebViewTest::WebViewTest):
1294         (WebViewTest::webProcessCrashed):
1295         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1296
1297 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
1298
1299         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
1300         rdar://problem/20461342
1301
1302         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1303
1304 2015-04-07  Commit Queue  <commit-queue@webkit.org>
1305
1306         Unreviewed, rolling out r182511.
1307         https://bugs.webkit.org/show_bug.cgi?id=143507
1308
1309         caused debug test failures (Requested by alexchristensen on
1310         #webkit).
1311
1312         Reverted changeset:
1313
1314         "Block popups from content extensions."
1315         https://bugs.webkit.org/show_bug.cgi?id=143497
1316         http://trac.webkit.org/changeset/182511
1317
1318 2015-04-07  Alex Christensen  <achristensen@webkit.org>
1319
1320         Block popups from content extensions.
1321         https://bugs.webkit.org/show_bug.cgi?id=143497
1322
1323         Reviewed by Brady Eidson.
1324
1325         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1326         (TestWebKitAPI::TEST_F):
1327         Added popup test.
1328
1329 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
1330
1331         Get the features.json files ready for open contributions
1332         https://bugs.webkit.org/show_bug.cgi?id=143436
1333
1334         Reviewed by Darin Adler.
1335
1336         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1337         (JSONFeaturesChecker.check):
1338         Extend the syntax checking a bit, but leave everything non-mandatory
1339         very loose until we figure what fields are important.
1340
1341 2015-04-07  Tim Horton  <timothy_horton@apple.com>
1342
1343         Expose and test fixedLayoutSize via modern WebKit SPI
1344         https://bugs.webkit.org/show_bug.cgi?id=143500
1345
1346         Reviewed by Simon Fraser.
1347
1348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1349         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
1350         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
1351         (TEST):
1352         Add a test that verifies that fixedLayoutSize works at all, that
1353         it persists through a navigation, and that turning it back off reverts to
1354         laying out at the size of the view.
1355
1356 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1357
1358         Unreviewed. Add myself as a committer.
1359
1360         * Scripts/webkitpy/common/config/contributors.json:
1361
1362 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
1363
1364         [Win] Bots complain about missing /etc/catalog
1365         https://bugs.webkit.org/show_bug.cgi?id=143484
1366
1367         Reviewed by Chris Dumez.
1368
1369         The libxml2 build on Mac, iOS, and Windows does not provide the set
1370         of default catalog files. We do not actually need these for our
1371         purposes, but we get warnings and some bot flakiness because they
1372         are not present.
1373
1374         We can avoid both problems the same way the Mac and iOS ports do,
1375         by setting the XML_CATALOG_FILES environment variable to 'empty string',
1376         which avoid the warnings and bot problems.
1377
1378         * Scripts/webkitpy/port/win.py:
1379         (WinPort.setup_environ_for_server): Added.
1380
1381 2015-04-06  Sam Weinig  <sam@webkit.org>
1382
1383         Use content extensions in MiniBrowser.
1384         https://bugs.webkit.org/show_bug.cgi?id=143446
1385
1386         Reviewed by Alex Christensen.
1387
1388         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1389         * MiniBrowser/mac/AppDelegate.h:
1390         * MiniBrowser/mac/AppDelegate.m:
1391         (-[BrowserAppDelegate init]):
1392         (-[BrowserAppDelegate showExtensionsManager:]):
1393         (-[BrowserAppDelegate userContentContoller]):
1394         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1395         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1396         (-[ExtensionManagerWindowController init]):
1397         (-[ExtensionManagerWindowController windowDidLoad]):
1398         (-[ExtensionManagerWindowController add:]):
1399         (-[ExtensionManagerWindowController remove:]):
1400         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1401         * MiniBrowser/mac/MainMenu.xib:
1402
1403 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1404
1405         web-platform-tests server should retrieve the modules file relatively to its docroot path
1406         https://bugs.webkit.org/show_bug.cgi?id=142742
1407
1408         Reviewed by Darin Adler.
1409
1410         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1411         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1412
1413 2015-04-06  Commit Queue  <commit-queue@webkit.org>
1414
1415         Unreviewed, rolling out r182445.
1416         https://bugs.webkit.org/show_bug.cgi?id=143459
1417
1418         broke 32 bit build (Requested by alexchristensen on #webkit).
1419
1420         Reverted changeset:
1421
1422         "Use content extensions in MiniBrowser."
1423         https://bugs.webkit.org/show_bug.cgi?id=143446
1424         http://trac.webkit.org/changeset/182445
1425
1426 2015-04-06  Sam Weinig  <sam@webkit.org>
1427
1428         Use content extensions in MiniBrowser.
1429         https://bugs.webkit.org/show_bug.cgi?id=143446
1430
1431         Reviewed by Alex Christensen.
1432
1433         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1434         * MiniBrowser/mac/AppDelegate.h:
1435         * MiniBrowser/mac/AppDelegate.m:
1436         (-[BrowserAppDelegate init]):
1437         (-[BrowserAppDelegate showExtensionsManager:]):
1438         (-[BrowserAppDelegate userContentContoller]):
1439         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1440         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1441         (-[ExtensionManagerWindowController init]):
1442         (-[ExtensionManagerWindowController windowDidLoad]):
1443         (-[ExtensionManagerWindowController add:]):
1444         (-[ExtensionManagerWindowController remove:]):
1445         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1446         * MiniBrowser/mac/MainMenu.xib:
1447
1448 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1449
1450         [GTK] install-dependencies should prefer dnf to yum
1451         https://bugs.webkit.org/show_bug.cgi?id=143441
1452
1453         Reviewed by Martin Robinson.
1454
1455         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1456
1457         * gtk/install-dependencies:
1458
1459 2015-04-06  Andy Estes  <aestes@apple.com>
1460
1461         [iOS] 'make clean' fails in Tools/WebKitTestRunner
1462         https://bugs.webkit.org/show_bug.cgi?id=143455
1463
1464         Reviewed by Dan Bernstein.
1465
1466         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1467         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
1468
1469         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
1470
1471 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
1472
1473         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
1474         https://bugs.webkit.org/show_bug.cgi?id=143450
1475
1476         Reviewed by Anders Carlsson.
1477
1478         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
1479         Make sure that the view is actually closed, regardless of anything else that happens beneath.
1480         Also, removed unnecessary get() calls.
1481
1482 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
1483
1484         Reduce the dependency on Flash in regression tests
1485         https://bugs.webkit.org/show_bug.cgi?id=143391
1486
1487         Reviewed by Anders Carlsson.
1488
1489         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
1490         Only allow QuickTime and the test plug-in.
1491
1492 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1493
1494         W3C test importer should generate the modules installed dynamically to run wpt tests
1495         https://bugs.webkit.org/show_bug.cgi?id=142738
1496
1497         Reviewed by Ryosuke Niwa.
1498
1499         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
1500         The implementation is done within TestDownloader and it is activated for the WPT repository.
1501         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
1502
1503         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1504         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
1505         * Scripts/webkitpy/w3c/test_downloader.py:
1506         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
1507         (TestDownloader):
1508         (TestDownloader._git_submodules_description): Computes submodule description.
1509         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
1510         * Scripts/webkitpy/w3c/test_importer.py:
1511         (TestImporter.do_import): Added the possibility to post process the tests.
1512         (TestImporter):
1513         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
1514         (TestImporter.should_convert_test_harness_links): Updated according new options format.
1515         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1516         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
1517         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
1518         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
1519         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
1520         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
1521
1522 2015-04-05  Antti Koivisto  <antti@apple.com>
1523
1524         Bloom filter should support longer hashes
1525         https://bugs.webkit.org/show_bug.cgi?id=143419
1526
1527         Reviewed by Dan Bernstein.
1528
1529         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
1530         (TestWebKitAPI::generateRandomDigests):
1531         (TestWebKitAPI::TEST):
1532
1533 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1534
1535         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
1536         https://bugs.webkit.org/show_bug.cgi?id=143372
1537
1538         Reviewed by Darin Adler.
1539
1540         * Scripts/run-jsc-stress-tests:
1541
1542 2015-04-03  Antti Koivisto  <antti@apple.com>
1543
1544         Add non-counting bloom filter class
1545         https://bugs.webkit.org/show_bug.cgi?id=143366
1546
1547         Reviewed by Sam Weinig.
1548
1549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1550         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
1551         (TestWebKitAPI::generateRandomHashes):
1552         (TestWebKitAPI::TEST):
1553
1554 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1555
1556         FTL JIT tests should fail if LLVM library isn't available
1557         https://bugs.webkit.org/show_bug.cgi?id=143374
1558
1559         Reviewed by Mark Lam.
1560
1561         * Scripts/run-jsc-stress-tests:
1562
1563 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1564
1565         [EFL] Speedup jhbuild with disable running autogen.sh
1566         https://bugs.webkit.org/show_bug.cgi?id=143369
1567
1568         Reviewed by Gyuyoung Kim.
1569
1570         * efl/jhbuild.modules:
1571
1572 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1573
1574         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
1575         https://bugs.webkit.org/show_bug.cgi?id=143282
1576
1577         Reviewed by Daniel Bates.
1578
1579         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
1580
1581 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1582
1583         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
1584         https://bugs.webkit.org/show_bug.cgi?id=143240
1585         rdar://problem/19990425
1586
1587         Reviewed by Tim Horton.
1588
1589         * DumpRenderTree/mac/LayoutTestHelper.m:
1590         (colorProfileURLForDisplay):
1591         (saveDisplayColorProfiles):
1592         Gracefully handle it when the current profile cannot be retrieved, fixing at
1593         least one case when LayoutTestHelper couldn't start.
1594
1595         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1596         (Manager._set_up_run):
1597         (Manager._force_pixel_tests_if_needed):
1598         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
1599         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
1600         Return and check an error from start_helper().
1601
1602 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
1603
1604         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
1605         https://bugs.webkit.org/show_bug.cgi?id=143321
1606
1607         Reviewed by Alexey Proskuryakov.
1608
1609         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
1610
1611 2015-04-01  Enrica Casucci  <enrica@apple.com>
1612
1613         Injected bundle messages should be at the page level.
1614         https://bugs.webkit.org/show_bug.cgi?id=143283
1615
1616         Reviewed by Alexey Proskuryakov.
1617
1618         Updating WebKitTestRunner to use the new page level messaging.
1619         The author of this patch is Tim Horton, I just finished it.
1620
1621         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1622         (WTR::EventSendingController::mouseDown):
1623         (WTR::EventSendingController::mouseUp):
1624         (WTR::EventSendingController::mouseMoveTo):
1625         (WTR::EventSendingController::leapForward):
1626         (WTR::EventSendingController::scheduleAsynchronousClick):
1627         (WTR::EventSendingController::keyDown):
1628         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1629         (WTR::EventSendingController::mouseScrollBy):
1630         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1631         (WTR::EventSendingController::continuousMouseScrollBy):
1632         (WTR::EventSendingController::addTouchPoint):
1633         (WTR::EventSendingController::updateTouchPoint):
1634         (WTR::EventSendingController::setTouchModifier):
1635         (WTR::EventSendingController::setTouchPointRadius):
1636         (WTR::EventSendingController::touchStart):
1637         (WTR::EventSendingController::touchMove):
1638         (WTR::EventSendingController::touchEnd):
1639         (WTR::EventSendingController::touchCancel):
1640         (WTR::EventSendingController::clearTouchPoints):
1641         (WTR::EventSendingController::releaseTouchPoint):
1642         (WTR::EventSendingController::cancelTouchPoint):
1643         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1644         (WTR::InjectedBundle::didReceiveMessage):
1645         (WTR::InjectedBundle::didReceiveMessageToPage):
1646         (WTR::InjectedBundle::done):
1647         (WTR::InjectedBundle::outputText):
1648         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1649         (WTR::InjectedBundle::postAddChromeInputField):
1650         (WTR::InjectedBundle::postRemoveChromeInputField):
1651         (WTR::InjectedBundle::postFocusWebView):
1652         (WTR::InjectedBundle::postSetBackingScaleFactor):
1653         (WTR::InjectedBundle::postSetWindowIsKey):
1654         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1655         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1656         (WTR::InjectedBundle::setGeolocationPermission):
1657         (WTR::InjectedBundle::setMockGeolocationPosition):
1658         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1659         (WTR::InjectedBundle::setUserMediaPermission):
1660         (WTR::InjectedBundle::setCustomPolicyDelegate):
1661         (WTR::InjectedBundle::setHidden):
1662         (WTR::InjectedBundle::setCacheModel):
1663         (WTR::InjectedBundle::shouldProcessWorkQueue):
1664         (WTR::InjectedBundle::processWorkQueue):
1665         (WTR::InjectedBundle::queueBackNavigation):
1666         (WTR::InjectedBundle::queueForwardNavigation):
1667         (WTR::InjectedBundle::queueLoad):
1668         (WTR::InjectedBundle::queueLoadHTMLString):
1669         (WTR::InjectedBundle::queueReload):
1670         (WTR::InjectedBundle::queueLoadingScript):
1671         (WTR::InjectedBundle::queueNonLoadingScript):
1672         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1673         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1674         (WTR::TestRunner::setAuthenticationUsername):
1675         (WTR::TestRunner::setAuthenticationPassword):
1676         (WTR::TestRunner::secureEventInputIsEnabled):
1677         (WTR::TestRunner::setBlockAllPlugins):
1678         * WebKitTestRunner/TestController.cpp:
1679         (WTR::TestController::createWebViewWithOptions):
1680         (WTR::TestController::resetStateToConsistentValues):
1681         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
1682         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
1683         * WebKitTestRunner/TestController.h:
1684         * WebKitTestRunner/TestInvocation.cpp:
1685         (WTR::TestInvocation::invoke):
1686         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1687
1688 2015-04-01  Commit Queue  <commit-queue@webkit.org>
1689
1690         Unreviewed, rolling out r182174 and r182177.
1691         https://bugs.webkit.org/show_bug.cgi?id=143314
1692
1693         Try to correct EWS failures (Requested by bfulgham on
1694         #webkit).
1695
1696         Reverted changesets:
1697
1698         "Python SCM should be able to retrieve untracked files"
1699         https://bugs.webkit.org/show_bug.cgi?id=143135
1700         http://trac.webkit.org/changeset/182174
1701
1702         "[buildbot] clean-build script should remove untracked files
1703         and revert local changes too"
1704         https://bugs.webkit.org/show_bug.cgi?id=142400
1705         http://trac.webkit.org/changeset/182177
1706
1707 2015-04-01  Alex Christensen  <achristensen@webkit.org>
1708
1709         [Content Extensions] Properly handle regexes that match everything.
1710         https://bugs.webkit.org/show_bug.cgi?id=143281
1711
1712         Reviewed by Benjamin Poulain.
1713
1714         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1715         (TestWebKitAPI::testRequest):
1716         (TestWebKitAPI::makeBackend):
1717         (TestWebKitAPI::TEST_F):
1718         Removed duplicate code and added test.
1719
1720 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
1721
1722         Content Extensions: split the state machines to minimize prefix states
1723         https://bugs.webkit.org/show_bug.cgi?id=143253
1724
1725         Reviewed by Alex Christensen.
1726
1727         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1728         (TestWebKitAPI::TEST_F):
1729         (TestWebKitAPI::testPatternStatus):
1730
1731 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1732
1733         Clean up Identifier factories to clarify the meaning of StringImpl*
1734         https://bugs.webkit.org/show_bug.cgi?id=143146
1735
1736         Reviewed by Filip Pizlo.
1737
1738         Simple API tests for StringImpl are added.
1739
1740         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1741         (TestWebKitAPI::TEST):
1742
1743 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
1744
1745         [EFL] Add AArch64 builder and tester bot to build.webkit.org
1746         https://bugs.webkit.org/show_bug.cgi?id=143092
1747
1748         Reviewed by Gyuyoung Kim.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/config.json:
1751         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1752         (Factory.__init__):
1753         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1754
1755 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1756
1757         [buildbot] clean-build script should remove untracked files and revert local changes too
1758         https://bugs.webkit.org/show_bug.cgi?id=142400
1759
1760         Reviewed by Ryosuke Niwa.
1761
1762         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1763         A helper routine SCM.discard_untracked_files is added for that purpose.
1764
1765         * BuildSlaveSupport/clean-build:
1766         (main): Making call to Scripts/clean-webkit
1767         * Scripts/clean-webkit: Added.
1768         (main): Revert changes and delete untracked files.
1769         * Scripts/webkitpy/common/checkout/scm/scm.py:
1770         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1771         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1772         (SCMTest._shared_test_discard_untracked_files):
1773         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1774
1775 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1776
1777         Python SCM should be able to retrieve untracked files
1778         https://bugs.webkit.org/show_bug.cgi?id=143135
1779
1780         Reviewed by Ryosuke Niwa.
1781
1782         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1783         Ignored files may be included or not in this list according boolean passed to the function.
1784
1785         * Scripts/webkitpy/common/checkout/scm/git.py:
1786         (Git.untracked_files):
1787         * Scripts/webkitpy/common/checkout/scm/scm.py:
1788         (SCM.untracked_files):
1789         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1790         (SCMTest._shared_test_untracked_files):
1791         (test_untracked_files):
1792         (GitSVNTest.test_untracked_files):
1793         * Scripts/webkitpy/common/checkout/scm/svn.py:
1794         (SVN.untracked_files):
1795
1796 2015-03-30  Alex Christensen  <achristensen@webkit.org>
1797
1798         [Content Extensions] Correctly handle regular expressions matching everything
1799         https://bugs.webkit.org/show_bug.cgi?id=143235
1800
1801         Reviewed by Benjamin Poulain.
1802
1803         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1804         (TestWebKitAPI::checkCompilerError):
1805         (TestWebKitAPI::TEST_F):
1806         Test ContentExtensionErrors.
1807
1808 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
1809
1810         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1811         https://bugs.webkit.org/show_bug.cgi?id=143241
1812         rdar://problem/20351297
1813
1814         Reviewed by Mark Lam.
1815
1816         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1817
1818 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1819
1820         [CMake][EFL] Remove redundant library link and include path
1821         https://bugs.webkit.org/show_bug.cgi?id=143221
1822
1823         Reviewed by Csaba Osztrogonác.
1824
1825         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1826
1827 2015-03-30  Sam Weinig  <sam@webkit.org>
1828
1829         [Content Extensions] Flesh out the UserContentExtensionStore
1830         https://bugs.webkit.org/show_bug.cgi?id=143123
1831
1832         Reviewed by Benjamin Poulain.
1833
1834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1835         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1836         Add tests for _WKUserContentExtensionStore.
1837
1838 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1839
1840         Update install-dependencies Fedora packages after r181624
1841         https://bugs.webkit.org/show_bug.cgi?id=143215
1842
1843         Add json-glib, libv4l, openssl and pulseaudio development packages to
1844         the Fedora list providing we need them to build WebKit dependencies
1845         for this distribution.
1846
1847         Reviewed by Philippe Normand.
1848
1849         * gtk/install-dependencies:
1850
1851 2015-03-30  Commit Queue  <commit-queue@webkit.org>
1852
1853         Unreviewed, rolling out r182119.
1854         https://bugs.webkit.org/show_bug.cgi?id=143196
1855
1856         problem with syntax (Requested by youenn on #webkit).
1857
1858         Reverted changeset:
1859
1860         "[buildbot] clean-build script should remove untracked files
1861         and revert local changes too"
1862         https://bugs.webkit.org/show_bug.cgi?id=142400
1863         http://trac.webkit.org/changeset/182119
1864
1865 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
1866
1867         Start the features.json files
1868         https://bugs.webkit.org/show_bug.cgi?id=143207
1869
1870         Reviewed by Darin Adler.
1871
1872         I kept the style checking light. We'll have to figure
1873         what is the best format for each field.
1874
1875         * Scripts/webkitpy/style/checker.py:
1876         (CheckerDispatcher._create_checker):
1877         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1878         (JSONContributorsChecker.check):
1879         (JSONFeaturesChecker):
1880         (JSONFeaturesChecker.check):
1881
1882 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1883
1884         [buildbot] clean-build script should remove untracked files and revert local changes too
1885         https://bugs.webkit.org/show_bug.cgi?id=142400
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1890
1891         * BuildSlaveSupport/clean-build:
1892         (main): Adding call to Tools/Scripts/clean-webkit.
1893         * Scripts/clean-webkit: Added.
1894         (main): Removes untracked and changed files.
1895         * Scripts/webkitpy/common/checkout/scm/git.py:
1896         (Git.untracked_files): Retrieves GIT untracked files.
1897         * Scripts/webkitpy/common/checkout/scm/scm.py:
1898         (SCM.untracked_files): Retrieves SVN untracked files.
1899         (SCM):
1900         (SCM.discard_untracked_files): Deletes untracked files/folders.
1901         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1902         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
1903         (test_untracked_files):
1904         (GitSVNTest.test_untracked_files):
1905         * Scripts/webkitpy/common/checkout/scm/svn.py:
1906         (SVN.untracked_files):
1907
1908 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1909
1910         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
1911         https://bugs.webkit.org/show_bug.cgi?id=143138
1912
1913         Reviewed by Csaba Osztrogonác.
1914
1915         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
1916         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
1917
1918         * ImageDiff/CMakeLists.txt:
1919         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
1920         * WebKitTestRunner/CMakeLists.txt: ditto.
1921
1922 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1923
1924         Support building WTF on Windows without Cygwin
1925         https://bugs.webkit.org/show_bug.cgi?id=143084
1926
1927         Reviewed by Brent Fulgham.
1928
1929         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
1930         This patch also migrates to using File::Spec->catfile() for directory separators.
1931
1932         * Scripts/update-webkit-dependency:
1933         (wanted):
1934         * Scripts/update-webkit-support-libs:
1935         (wanted):
1936         (downloadExpectedVersionNumber):
1937         (zipFileVersion):
1938         (toUnixPath): Deleted.
1939         * Scripts/webkitdirs.pm:
1940         (determineSourceDir):
1941         (windowsSourceSourceDir):
1942         (windowsLibrariesDir):
1943         (windowsOutputDir):
1944         (checkInstalledTools):
1945         (buildVisualStudioProject):
1946
1947 2015-03-27  Alex Christensen  <achristensen@webkit.org>
1948
1949         Fix WinCairo bot.
1950         https://bugs.webkit.org/show_bug.cgi?id=143086
1951
1952         Reviewed by Brent Fulgham.
1953
1954         * Scripts/webkitdirs.pm:
1955         (buildVisualStudioProject):
1956         (runSvnUpdateAndResolveChangeLogs):
1957         Use ActivePerl-friendly perl.
1958
1959 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1960
1961         URTBF after r182059 to fix the EFL build.
1962
1963         * TestWebKitAPI/CMakeLists.txt:
1964
1965 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
1966
1967         Layout test results URL loads in WK1 but not WK2 minibrowser
1968         https://bugs.webkit.org/show_bug.cgi?id=143117
1969
1970         Reviewed by Tim Horton.
1971
1972         * MiniBrowser/mac/WK2BrowserWindowController.m:
1973         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
1974         everything.
1975         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
1976
1977 2015-03-26  Jer Noble  <jer.noble@apple.com>
1978
1979         Add --allowed-host support to run-webkit-tests
1980         https://bugs.webkit.org/show_bug.cgi?id=142938
1981
1982         Reviewed by Brent Fulgham.
1983
1984         Accept --allowed-host arguments from run-webkit-tests and pass them through to
1985         DumpRenderTree and WebKitTestRunner.
1986
1987         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
1988         are placed in the wrong location. The argument is compared with each tests's path, and if a
1989         relative path or a path with '..' was used, results are placed alongside the test. Take the
1990         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
1991
1992         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1993         (parse_args):
1994         * Scripts/webkitpy/port/base.py:
1995         (Port.__init__):
1996         (Port.allowed_hosts):
1997         * Scripts/webkitpy/port/driver.py:
1998         (Driver.cmd_line):
1999
2000 2015-03-26  Jer Noble  <jer.noble@apple.com>
2001
2002         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2003         https://bugs.webkit.org/show_bug.cgi?id=142931
2004
2005         Reviewed by Brent Fulgham.
2006
2007         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2008         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2009         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2010         runtime.
2011
2012         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2013         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2014
2015         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2016         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2017         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2018         the top loading frame from the page, as we do elsewhere in this class.
2019
2020         * DumpRenderTree/TestRunner.h:
2021         (TestRunner::allowedHosts):
2022         (TestRunner::setAllowedHosts):
2023         * DumpRenderTree/mac/DumpRenderTree.mm:
2024         (initializeGlobalsFromCommandLineOptions):
2025         (runTest):
2026         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2027         (isAllowedHost):
2028         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2029         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2030         (WTR::InjectedBundle::didReceiveMessage):
2031         (WTR::InjectedBundle::isAllowedHost):
2032         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2034         (WTR::isAllowedHost):
2035         (WTR::InjectedBundlePage::willSendRequestForFrame):
2036         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2037         * WebKitTestRunner/Options.cpp:
2038         (WTR::handleOptionAllowedHost):
2039         (WTR::OptionsHandler::OptionsHandler):
2040         * WebKitTestRunner/Options.h:
2041         * WebKitTestRunner/TestController.cpp:
2042         (WTR::TestController::initialize):
2043         (WTR::TestController::resetStateToConsistentValues):
2044         * WebKitTestRunner/TestController.h:
2045
2046 2015-03-26  Brady Eidson  <beidson@apple.com>
2047
2048         Apply ContentExtension actions after redirects.
2049         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2050
2051         Reviewed by Alex Christensen.
2052
2053         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2054         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2055           which is specifically interesting to a new test.
2056
2057 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2058
2059         [EFL] Disable building libseccomp on AArch64
2060         https://bugs.webkit.org/show_bug.cgi?id=143094
2061
2062         Reviewed by Gyuyoung Kim.
2063
2064         * efl/jhbuildrc:
2065
2066 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2067
2068         [jhbuild] git should use only 1 thread for cloning jhbuild
2069         https://bugs.webkit.org/show_bug.cgi?id=143095
2070
2071         Reviewed by Gyuyoung Kim.
2072
2073         * jhbuild/jhbuild-wrapper:
2074         (clone_jhbuild):
2075
2076 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2077
2078         Update prepare-ChangeLog to work with ES6 Class syntax
2079         https://bugs.webkit.org/show_bug.cgi?id=143069
2080
2081         Reviewed by Timothy Hatcher.
2082
2083         * Scripts/prepare-ChangeLog:
2084         (get_function_line_ranges_for_javascript):
2085         Better handle ES6 Class syntax.
2086
2087         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2088         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2089         (BaseClass):
2090         (DerivedClass):
2091         (DerivedClass.staticMethod):
2092         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2093         (DerivedClass.prototype.method):
2094         (DerivedClass.prototype.get getter):
2095         (namespace.MyClass):
2096         (namespace.MyClass.staticMethod):
2097         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2098         (namespace.MyClass.prototype.method):
2099         (namespace.MyClass.prototype.get getter):
2100         Proof!
2101
2102 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
2103
2104         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2105         https://bugs.webkit.org/show_bug.cgi?id=142993
2106
2107         Reviewed by Mark Lam.
2108         
2109         Bunch of support for testing executable allocation failure.
2110
2111         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2112         (fail):
2113         * Scripts/run-javascriptcore-tests:
2114         (runJSCStressTests):
2115         * Scripts/run-jsc-stress-tests:
2116
2117 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2118
2119         Fix Windows build from r181977.
2120
2121         Unreviewed.
2122
2123         * Scripts/update-webkit-dependency:
2124
2125 2015-03-25  Sam Weinig  <sam@webkit.org>
2126
2127         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2128
2129         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2130         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2131
2132 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2133
2134         Migrate update-webkit for Windows to not require Cygwin
2135         https://bugs.webkit.org/show_bug.cgi?id=143040
2136
2137         Reviewed by Brent Fulgham.
2138
2139         * Scripts/update-webkit-dependency:
2140         (wanted):
2141         (toUnixPath): Deleted.
2142         * Scripts/webkitdirs.pm:
2143         (fontExists):
2144         (checkInstalledTools):
2145         (setupAppleWinEnv):
2146
2147 2015-03-25  Sam Weinig  <sam@webkit.org>
2148
2149         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2150         https://bugs.webkit.org/show_bug.cgi?id=143059
2151
2152         Reviewed by Alex Christensen.
2153
2154         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2155         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2156         Update for new interface of compileRuleList().
2157
2158 2015-03-25  Alex Christensen  <achristensen@webkit.org>
2159
2160         [Content Extensions] Add multi-DFA compiling and interpreting.
2161         https://bugs.webkit.org/show_bug.cgi?id=143010
2162
2163         Reviewed by Benjamin Poulain.
2164
2165         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2166         (TestWebKitAPI::testRequest):
2167         (TestWebKitAPI::TEST_F):
2168         Add some tests for ignore-previous-rules and large rulesets.
2169
2170 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
2171
2172         Mavericks WK1 still runs JSC tests
2173         https://bugs.webkit.org/show_bug.cgi?id=143035
2174
2175         Reviewed by Csaba Osztrogonác.
2176
2177         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2178         with other bots.
2179
2180         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2181         accordingly.
2182
2183 2015-03-25  Commit Queue  <commit-queue@webkit.org>
2184
2185         Unreviewed, rolling out r181932.
2186         https://bugs.webkit.org/show_bug.cgi?id=143041
2187
2188         The test fails most of the time on bots (Requested by ap on
2189         #webkit).
2190
2191         Reverted changeset:
2192
2193         "[Content Extensions] Add multi-DFA compiling and
2194         interpreting."
2195         https://bugs.webkit.org/show_bug.cgi?id=143010
2196         http://trac.webkit.org/changeset/181932
2197
2198 2015-03-24  Alex Christensen  <achristensen@webkit.org>
2199
2200         [Content Extensions] Add multi-DFA compiling and interpreting.
2201         https://bugs.webkit.org/show_bug.cgi?id=143010
2202
2203         Reviewed by Benjamin Poulain.
2204
2205         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2206         (TestWebKitAPI::testRequest):
2207         (TestWebKitAPI::TEST_F):
2208         Add some tests for ignore-previous-rules and large rulesets.
2209
2210 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
2211
2212         Make URL filter patterns matching consistent and add a simple canonicalization step
2213         https://bugs.webkit.org/show_bug.cgi?id=142998
2214
2215         Reviewed by Alex Christensen.
2216
2217         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2218
2219 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
2220
2221         [EFL] Add OpenWebRTC in jhbuild
2222         https://bugs.webkit.org/show_bug.cgi?id=142778
2223
2224         Reviewed by Gyuyoung Kim.
2225
2226         Original patch by Philippe Normand <pnormand@igalia.com>
2227
2228         * efl/install-dependencies: Dependencies for OpenWebRTC.
2229         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2230         the openwebrtc gst plugins.
2231
2232 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
2233
2234         Regression(r181257): WTF_WorkQueue.Simple is flaky
2235         https://bugs.webkit.org/show_bug.cgi?id=142560
2236
2237         Remove the check that the refCount has returned to one after the
2238         individual tasks have completed. It's too nondeterministic when
2239         the reference count will be reduced.
2240
2241         Reviewed by Alexey Proskuryakov
2242
2243         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2244         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2245
2246 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2247
2248         [CMake][EFL] Put failure API test excutables into failure directory
2249         https://bugs.webkit.org/show_bug.cgi?id=142965
2250
2251         Reviewed by Csaba Osztrogonác.
2252
2253         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2254
2255         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2256         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2257
2258 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
2259
2260         CSS Selectors: fix attribute case-insensitive matching of Contain and List
2261         https://bugs.webkit.org/show_bug.cgi?id=142932
2262
2263         Reviewed by Darin Adler.
2264
2265         Add tests for the new features and fix some existing tests using the 
2266         stringFromUTF8() utility recently added by Dhi.
2267
2268         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2269         (TestWebKitAPI::stringFromUTF8):
2270         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2271
2272 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2273
2274         [GTK] install-dependencies should install orc
2275         https://bugs.webkit.org/show_bug.cgi?id=142955
2276
2277         Reviewed by Martin Robinson.
2278
2279         Install orc, needed by openwebrtc
2280
2281         * gtk/install-dependencies:
2282
2283 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
2284
2285         Detect when url filter pattern with groups match the empty string
2286         https://bugs.webkit.org/show_bug.cgi?id=142930
2287
2288         Reviewed by Sam Weinig.
2289
2290         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2291
2292 2015-03-22  Anders Carlsson  <andersca@apple.com>
2293
2294         _WKWebsiteDataStore should clear WebSQL databases
2295         https://bugs.webkit.org/show_bug.cgi?id=142947
2296
2297         Reviewed by Sam Weinig.
2298
2299         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
2300
2301         * MiniBrowser/mac/WK2BrowserWindowController.m:
2302         (-[WK2BrowserWindowController fetchWebsiteData:]):
2303         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2304         (-[WK2BrowserWindowController clearWebsiteData:]):
2305
2306 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
2307
2308         GCTimer should know keep track of nested GC phases
2309         https://bugs.webkit.org/show_bug.cgi?id=142675
2310
2311         Reviewed by Darin Adler.
2312
2313         Adds a tool to aid in parsing the GC phase timing output into a
2314         tree-like structure based on the parent-child relationships
2315         of nested GC phases.
2316
2317         * Scripts/parse-gc-phase-timings: Added.
2318         (Timing):
2319         (Timing.__init__):
2320         (Timing.__unicode__):
2321         (Timing.__str__):
2322         (Timing.__repr__):
2323         (parse_input):
2324         (print_timing_node):
2325         (print_timing_tree):
2326         (link_parents):
2327         (main):
2328
2329 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
2330
2331         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
2332
2333         * Scripts/webkitpy/common/config/ews.json:
2334
2335 2015-03-20  Philippe Normand  <pnormand@igalia.com>
2336
2337         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
2338         https://bugs.webkit.org/show_bug.cgi?id=142867
2339
2340         Rubber-stamped by Csaba Osztrogon.
2341
2342         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
2343         a fixed revision for the openwebrtc-gst-plugins.
2344
2345 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2346
2347         Unreviewed build fix. Don't try to report stats for all benchmarks.
2348         Just report the geometric mean of preferred means.
2349
2350         * Scripts/run-jsc-benchmarks:
2351
2352 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2353
2354         run-jsc-benchmarks should only report preferred mean
2355         https://bugs.webkit.org/show_bug.cgi?id=142874
2356
2357         Reviewed by Geoffrey Garen.
2358
2359         Just collect statistics for the preferred mean.
2360
2361         * Scripts/run-jsc-benchmarks:
2362
2363 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2364
2365         [Content Extensions] Test regular expression parse failures.
2366         https://bugs.webkit.org/show_bug.cgi?id=142872
2367
2368         Reviewed by Benjamin Poulain.
2369
2370         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2371         (TestWebKitAPI::testPatternStatus):
2372         (TestWebKitAPI::TEST_F):
2373         Added tests for each parsing status.
2374
2375 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2376
2377         Fix API tests after r181754.
2378
2379         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2380         (TestWebKitAPI::testRequest):
2381
2382 2015-03-19  Brady Eidson  <beidson@apple.com>
2383
2384         Part of content extensions should apply css selectors
2385         https://bugs.webkit.org/show_bug.cgi?id=142604
2386
2387         Reviewed by Alex Christensen.
2388
2389         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2390         (WebCore::ContentExtensions::operator<<):
2391
2392 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
2393
2394         [Win] Activate tests on EWS
2395         https://bugs.webkit.org/show_bug.cgi?id=142850
2396
2397         Reviewed by Alexey Proskuryakov.
2398
2399         * Scripts/webkitpy/common/config/ews.json: Add me as
2400         the EWS bot watcher, and activate tests.
2401
2402 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
2403
2404         [GTK] Fix inspector userinterface related incremental build issue
2405         https://bugs.webkit.org/show_bug.cgi?id=142849
2406
2407         Reviewed by Carlos Garcia Campos.
2408
2409         * Scripts/webkitdirs.pm:
2410         (shouldRemoveCMakeCache):
2411
2412 2015-03-18  Alex Christensen  <achristensen@webkit.org>
2413
2414         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2415         https://bugs.webkit.org/show_bug.cgi?id=142799
2416
2417         Reviewed by Brady Eidson.
2418
2419         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2420         (TestWebKitAPI::testPattern):
2421         (TestWebKitAPI::TEST_F):
2422         Start testing regex failures.
2423
2424 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
2425
2426         Fix StringView typos after r181525 and r181558
2427         https://bugs.webkit.org/show_bug.cgi?id=142772
2428
2429         Reviewed by Darin Adler.
2430
2431         Add some tests in [1] to cover the StringView::startsWith, 
2432         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
2433         StringView::endsWithIgnoringASCIICase implementations.
2434
2435         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2436         (TestWebKitAPI::TEST):
2437
2438 2015-03-18  Dana Burkart  <dburkart@apple.com>
2439
2440         Remove extraneous import to fix the build.
2441
2442         Unreviewed.
2443
2444         * Scripts/webkitpy/port/driver.py:
2445
2446 2015-03-18  Dana Burkart  <dburkart@apple.com>
2447
2448         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
2449         https://bugs.webkit.org/show_bug.cgi?id=142547
2450
2451         Reviewed by Alexey Proskuryakov.
2452
2453         * Scripts/webkitpy/port/driver.py:
2454         (Driver._setup_environ_for_driver):
2455
2456 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
2457
2458         Tweak how AppleSystemFontOSSubversion default is added
2459         https://bugs.webkit.org/show_bug.cgi?id=142835
2460
2461         Reviewed by Dan Bernstein.
2462
2463         * DumpRenderTree/mac/DumpRenderTree.mm:
2464         (setDefaultsToConsistentValuesForTesting):
2465
2466 2015-03-18  Dan Bernstein  <mitz@apple.com>
2467
2468         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
2469         https://bugs.webkit.org/show_bug.cgi?id=142815
2470
2471         Reviewed by Darin Adler.
2472
2473         * Scripts/prepare-ChangeLog:
2474         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
2475         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
2476         keep consuming the quoted text until the matching quotation mark is reached. Emit the
2477         warning only if a line ends without a backslash before the matching quotation mark was found.
2478
2479 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2480
2481         Remove unused "preprocessor" parameter to sub-CodeGenerators
2482         https://bugs.webkit.org/show_bug.cgi?id=142793
2483
2484         Reviewed by Darin Adler.
2485
2486         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2487         (new):
2488
2489 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
2490
2491         [EFL] Bump gstreamer version to 1.4.4
2492         https://bugs.webkit.org/show_bug.cgi?id=142782
2493
2494         Reviewed by Philippe Normand.
2495
2496         * efl/jhbuild.modules:
2497         * efl/patches/gst-libav.patch:
2498         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2499         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2500
2501 2015-03-17  Tim Horton  <timothy_horton@apple.com>
2502
2503         Fix the iOS build.
2504
2505         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2506         (WTR::InjectedBundle::platformInitialize):
2507
2508 2015-03-17  Dean Jackson  <dino@apple.com>
2509
2510         check-webkit-style should allow "bool a : 1"
2511         https://bugs.webkit.org/show_bug.cgi?id=142794
2512
2513         Reviewed by Brent Fulgham.
2514
2515         We should allow member bitfields of the form:
2516
2517         bool m_var : 1;
2518
2519         It seems that Visual Studio 8 was the last compiler that
2520         wasn't happy about not using unsigned here. We already have
2521         about 500 cases (in WebCore) where people were ignoring this rule.
2522
2523         * Scripts/webkitpy/style/checkers/cpp.py:
2524         (check_language): Allow "bool".
2525         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
2526         (CppStyleTest.test_enum_bitfields):
2527         (CppStyleTest.test_plain_integral_bitfields):
2528
2529 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
2530
2531         Compile character ranges targeting the same state as range check in the bytecode
2532         https://bugs.webkit.org/show_bug.cgi?id=142759
2533
2534         Reviewed by Alex Christensen.
2535
2536         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2537         (TestWebKitAPI::TEST_F):
2538
2539 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2540
2541         W3C test parser and converter should use test importer host
2542         https://bugs.webkit.org/show_bug.cgi?id=142729
2543
2544         Reviewed by Bem Jones-Bey.
2545
2546         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
2547         This enables adding more TestImporter unit testing.
2548         This patch also ensures that the git object instantiated by TestDownloader is using the
2549         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
2550
2551         * Scripts/webkitpy/common/system/filesystem_mock.py:
2552         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
2553         * Scripts/webkitpy/w3c/test_downloader.py:
2554         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
2555         (TestDownloader.checkout_test_repository): Making use of the new git function.
2556         * Scripts/webkitpy/w3c/test_importer.py:
2557         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
2558         (TestImporter.import_tests): Adding host as parameter to the converter.
2559         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2560         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
2561         (TestImporterTest):
2562         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
2563         * Scripts/webkitpy/w3c/test_parser.py:
2564         (TestParser.__init__): Adding host as parameter constructor.
2565
2566 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2567
2568         [GTK] WebKitDOM objects leaking
2569         https://bugs.webkit.org/show_bug.cgi?id=118788
2570
2571         Reviewed by Darin Adler and Sergio Villar Senin.
2572
2573         Update DOMObjectCache unit test to check that DOM objects are also
2574         released when new contents are loaded in the web view, and the old
2575         document is detached from the frame.
2576
2577         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2578         (testWebKitDOMObjectCache):
2579         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2580         (runTest):
2581
2582 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2583
2584         W3C test importer default import folder should be LayoutTests/imported/w3c
2585         https://bugs.webkit.org/show_bug.cgi?id=142728
2586
2587         Reviewed by Bem Jones-Bey.
2588
2589         * Scripts/webkitpy/w3c/test_importer.py:
2590         (parse_args): Updating the default destination option value to 'imported/w3c'.
2591
2592 2015-03-17  Philippe Normand  <pnormand@igalia.com>
2593
2594         [GTK] basic OpenWebRTC build support
2595         https://bugs.webkit.org/show_bug.cgi?id=142393
2596
2597         Reviewed by Carlos Garcia Campos.
2598
2599         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
2600         is not the upstream OpenWebRTC repository. This temporary fork
2601         contains a few patches needed by WebKit for audio/video rendering.
2602
2603 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2604
2605         [CMake][EFL] Build test tools only for developer mode
2606         https://bugs.webkit.org/show_bug.cgi?id=142761
2607
2608         Reviewed by Csaba Osztrogonác.
2609
2610         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
2611
2612         * CMakeLists.txt:
2613
2614 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
2615
2616         Remove never used "useLayerOnTop" bindings generator argument
2617         https://bugs.webkit.org/show_bug.cgi?id=142773
2618
2619         Reviewed by Darin Adler.
2620
2621         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2622         (new):
2623
2624 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
2625
2626         Enable ES6 classes by default
2627         https://bugs.webkit.org/show_bug.cgi?id=142774
2628
2629         Reviewed by Gavin Barraclough.
2630
2631         * Scripts/webkitperl/FeatureList.pm:
2632
2633 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2634
2635         Fix webkitpy tests after r181585.
2636
2637         Looks like "me" cannot be anyone's email, it's a special case.
2638
2639         * Scripts/webkitpy/common/config/contributors.json:
2640
2641 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2642
2643         Add tolerance to WebAudio tests
2644         https://bugs.webkit.org/show_bug.cgi?id=142676
2645
2646         Reviewed by Tim Horton.
2647
2648         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
2649
2650         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2651         (TestResultWriter.create_audio_diff_and_write_result):
2652         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2653         (FailureAudio.write_failure):
2654         * Scripts/webkitpy/port/base.py:
2655         (Port.do_audio_results_differ):
2656         Diff audio failures.
2657
2658         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
2659         tests to use real parseable WAV data, and got rid of base64, which there didn't
2660         seem to have been any reason for.
2661
2662 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2663
2664         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
2665         https://bugs.webkit.org/show_bug.cgi?id=142720
2666
2667         Reviewed by Myles C. Maxfield.
2668
2669         Activate system copies of Microsoft fonts for the current process, thus overriding
2670         any other ones that could be preferred by the system otherwise.
2671
2672         * DumpRenderTree/mac/DumpRenderTree.mm:
2673         (activateSystemCoreWebFonts):
2674         (adjustFonts):
2675         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2676         (WTR::activateSystemCoreWebFonts):
2677         (WTR::activateFonts):
2678
2679 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2680
2681         Created Streams API watchlist
2682         https://bugs.webkit.org/show_bug.cgi?id=142684
2683
2684         Reviewed by Benjamin Poulain.
2685
2686         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
2687         watchlist and added Benjamin, Youenn and me to it.
2688
2689 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
2690
2691         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
2692         https://bugs.webkit.org/show_bug.cgi?id=142715
2693
2694         Reviewed by Brent Fulgham.
2695
2696         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2697         (TestWebKitAPI::TEST):
2698
2699 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
2700
2701         Change the exact attribute matching to be ASCII case-insensitive
2702         https://bugs.webkit.org/show_bug.cgi?id=142609
2703
2704         Reviewed by Darin Adler.
2705
2706         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2707         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2708
2709 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2710
2711         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
2712         https://bugs.webkit.org/show_bug.cgi?id=134764
2713
2714         Reviewed by Ryosuke Niwa.
2715
2716         TestDownloader is introduced to download W3C tests from the official
2717         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
2718         and https://github.com/w3c/csswg-test.git).
2719         TestDownloader clones the repositories and checkouts revisions of the tests
2720         defined in LayoutTests/imported/w3c/resources/TestRepositories.
2721
2722         Similarly to https://codereview.chromium.org/148173016,
2723         TestDownloader copies part of the files based on the rules
2724         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
2725
2726         TestDownloader is used by TestImporter when no source directory is provided.
2727
2728         * Scripts/webkitpy/w3c/test_downloader.py: Added.
2729         (TestDownloader):
2730         (TestDownloader.default_options):
2731         (TestDownloader.load_test_repositories):
2732         (TestDownloader.__init__):
2733         (TestDownloader.checkout_test_repository):
2734         (TestDownloader._init_paths_from_expectations):
2735         (TestDownloader._add_test_suite_paths):
2736         (TestDownloader._empty_directory):
2737         (TestDownloader.copy_tests):
2738         (TestDownloader.download_tests):
2739         * Scripts/webkitpy/w3c/test_importer.py:
2740         (main):
2741         (parse_args):
2742         (TestImporter.__init__):
2743         (TestImporter.do_import):
2744         (TestImporter.test_downloader):
2745         (TestImporter.find_importable_tests.should_keep_subdir):
2746         (TestImporter.should_convert_test_harness_links):
2747         (TestImporter.import_tests):
2748         (TestImporter.write_import_log):
2749
2750 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2751
2752         [Mavericks] Test snapshots are 1600x1200 on Retina devices
2753         https://bugs.webkit.org/show_bug.cgi?id=142630
2754
2755         Reviewed by Tim Horton.
2756
2757         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2758         Removed an ifdef that disabled the fix on Mavericks.
2759
2760 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2761
2762         Remove isWK2 cruft from webkitdirs.pm after r170426
2763         https://bugs.webkit.org/show_bug.cgi?id=142618
2764
2765         Reviewed by Daniel Bates.
2766
2767         * Scripts/webkitdirs.pm:
2768         (isWK2): Deleted.
2769
2770 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2771
2772         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2773         https://bugs.webkit.org/show_bug.cgi?id=138687
2774
2775         Reviewed by Carlos Garcia Campos.
2776
2777         Always change cookie policy from UI process, as changing it from WebProcess doesn't
2778         affect other processes.
2779
2780         The implementation is imperfect, because the change happens asynchronously, but I
2781         don't expect it to be a problem in practice.
2782
2783         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2784         (WTR::InjectedBundle::beginTesting):
2785         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2786         (WTR::TestRunner::setAlwaysAcceptCookies):
2787         * WebKitTestRunner/TestInvocation.cpp:
2788         (WTR::TestInvocation::invoke):
2789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2790
2791 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2792
2793         [EFL] Enable building EFL 1.13 with NEON support
2794         https://bugs.webkit.org/show_bug.cgi?id=142619
2795
2796         Reviewed by Gyuyoung Kim.
2797
2798         * efl/jhbuild.modules:
2799
2800 2015-03-11  Alex Christensen  <achristensen@webkit.org>
2801
2802         [Content Extensions] Add resource type and load type triggers.
2803         https://bugs.webkit.org/show_bug.cgi?id=142422
2804
2805         Reviewed by Benjamin Poulain.
2806
2807         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2808         (TestWebKitAPI::testRequest):
2809         (TestWebKitAPI::mainDocumentRequest):
2810         (TestWebKitAPI::TEST_F):
2811         (TestWebKitAPI::testURL): Deleted.
2812
2813 2015-03-10  Sam Weinig  <sam@webkit.org>
2814
2815         Allow adding a button in input elements for auto fill related functionality
2816         <rdar://problem/19782066>
2817         https://bugs.webkit.org/show_bug.cgi?id=142564
2818
2819         Reviewed by Anders Carlsson.
2820
2821         * WebKitTestRunner/TestController.cpp:
2822         (WTR::TestController::createOtherPage):
2823         (WTR::TestController::createWebViewWithOptions):
2824         Update for new callback.
2825
2826 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
2827
2828         Add basic support for BOL and EOL assertions to the URL Filter parser
2829         https://bugs.webkit.org/show_bug.cgi?id=142568
2830
2831         Reviewed by Alex Christensen.
2832
2833         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2834         (TestWebKitAPI::TEST_F):
2835
2836 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2837
2838         [GTK] Add support for handling TLS errors to MiniBrowser
2839         https://bugs.webkit.org/show_bug.cgi?id=142576
2840
2841         Reviewed by Sergio Villar Senin.
2842
2843         It's useful for testing TLS errors handling itself, but also to
2844         allow ignoring TLS errors when testing.
2845
2846         * MiniBrowser/gtk/BrowserWindow.c:
2847         (webViewLoadFailedWithTLSerrors):
2848         (browserWindowConstructed):
2849
2850 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2851
2852         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2853         https://bugs.webkit.org/show_bug.cgi?id=142569
2854
2855         Reviewed by David Hyatt.
2856
2857         Test Optional::valueOrCompute().
2858
2859         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2860         (TestWebKitAPI::TEST):
2861
2862 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2863
2864         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2865         https://bugs.webkit.org/show_bug.cgi?id=126688
2866
2867         Reviewed by Gustavo Noronha Silva.
2868
2869         * CMakeLists.txt: Build testing tools only for developer builds,
2870         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2871         * MiniBrowser/gtk/CMakeLists.txt: Only add
2872         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2873         and add a rule to install the MiniBrowser.
2874         * MiniBrowser/gtk/main.c:
2875         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2876         builds.
2877
2878 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
2879
2880         Add some DateMath tests to TestWebKitAPI
2881         https://bugs.webkit.org/show_bug.cgi?id=142565
2882
2883         Reviewed by Alexey Proskuryakov.
2884
2885         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2886         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2887         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2889         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2890
2891 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
2892
2893         Regression(r181257): WTF_WorkQueue.Simple is flaky
2894         https://bugs.webkit.org/show_bug.cgi?id=142560
2895
2896         Unreviewed attempt to improve test stability.
2897
2898         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
2899         the WorkQueue a little later to redue flakiness.
2900
2901 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2902
2903         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
2904         https://bugs.webkit.org/show_bug.cgi?id=142555
2905
2906         Reviewed by Simon Fraser.
2907
2908         * DumpRenderTree/mac/DumpRenderTree.mm:
2909         (setDefaultsToConsistentValuesForTesting):
2910         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2911         (WTR::InjectedBundle::platformInitialize):
2912
2913 2015-03-10  Alex Christensen  <achristensen@webkit.org>
2914
2915         Use unsigned for HashSet size.
2916         https://bugs.webkit.org/show_bug.cgi?id=142518
2917
2918         Reviewed by Benjamin Poulain.
2919
2920         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2921         (TestWebKitAPI::TEST):
2922         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2923         (TestWebKitAPI::testInitialCapacity):
2924         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2925         (TestWebKitAPI::TEST):
2926
2927 2015-03-10  Daniel Bates  <dabates@apple.com>
2928
2929         [iOS] Add WebKitSystemInterface for iOS 8.2
2930         https://bugs.webkit.org/show_bug.cgi?id=142505
2931
2932         Rubber-stamped by Anders Carlsson.
2933
2934         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
2935         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
2936         copy-webkitlibraries-to-product-directory in r181286.
2937
2938         * Scripts/copy-webkitlibraries-to-product-directory:
2939
2940 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
2941
2942         Extend URL filter's Term definition to support groups/subpatterns
2943         https://bugs.webkit.org/show_bug.cgi?id=142519
2944
2945         Reviewed by Alex Christensen.
2946
2947         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2948         (TestWebKitAPI::testURL):
2949
2950 2015-03-06  Jer Noble  <jer.noble@apple.com>
2951
2952         Add an option to run-webkit-tests to override the LayoutTests/ directory
2953         https://bugs.webkit.org/show_bug.cgi?id=142418
2954
2955         Reviewed by David Kilzer.
2956
2957         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
2958         directory. The base port will parse the options during initialization and store the override
2959         location if present. layout_tests_dir() will return this overridden location if set.
2960
2961         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2962         (parse_args):
2963         * Scripts/webkitpy/port/base.py:
2964         (Port.__init__):
2965         (Port.layout_tests_dir):
2966
2967 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
2968
2969         [CMake] Enable WorkQueue tests for CMake ports
2970         https://bugs.webkit.org/show_bug.cgi?id=142473
2971
2972         Reviewed by Darin Adler.
2973
2974         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
2975         the list of source files.
2976         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
2977         to the list of include directories for EFL.
2978
2979 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2980
2981         Attempt to fix timeouts on iOS Simulator layout tests
2982
2983         * Scripts/webkitpy/port/ios.py:
2984         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
2985         Simulator end after the first 50 tests time out.  Some analysis
2986         this past weekend shows that the 'Booted' status in the output
2987         of `xcrun simctl list` is not sufficient (and watching the test
2988         run shows that SpringBoard hasn't fully started to the point
2989         where it's displaying icons on the home screen).  The workaround
2990         until we have a better fix is to add an arbitrary timeout to let
2991         SpringBoard finish launching.  In practice, 15 seconds is
2992         probably enough, but 30 seconds should nearly always work.
2993
2994 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
2995
2996         Unreviewed. Add myself as a committer.
2997
2998         * Scripts/webkitpy/common/config/contributors.json:
2999
3000 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3001
3002         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3003
3004         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3005         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3006         an expectation that will fail if we hit the race condition.
3007         This test is inherently racy and will deadlock if the first job
3008         for queue2 takes the mutex lock before the second job for
3009         queue1.
3010
3011 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3012
3013         [Win] WTF::WorkQueue does not balance ref/deref properly
3014         https://bugs.webkit.org/show_bug.cgi?id=142471
3015
3016         Reviewed by Antti Koivisto.
3017
3018         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3019         (TestWebKitAPI::TEST): Check that the refcount is correct.
3020
3021 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3022
3023         Do not show passing test result on output of EFL layout test
3024         https://bugs.webkit.org/show_bug.cgi?id=142380
3025
3026         Reviewed by Darin Adler.
3027
3028         To show passing tests has caused inconvenience when we detect problem tests
3029         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3030         in order not to show passing tests in the output of EFL layout test.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3033         (RunWebKitTests.start):
3034
3035 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3036
3037         Unreviewed build fix.
3038
3039         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3040         (TestWebKitAPI::TEST): Remove two unused variables.
3041
3042 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3043
3044         Add some WorkQueue tests to TestWebKitAPI
3045         https://bugs.webkit.org/show_bug.cgi?id=142447
3046
3047         Reviewed by Sam Weinig.
3048
3049         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3050         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3052         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3053         (TestWebKitAPI::simpleTest):
3054         (TestWebKitAPI::longTest):
3055         (TestWebKitAPI::thirdTest):
3056         (TestWebKitAPI::finishedTests):
3057         (TestWebKitAPI::TEST):
3058         (TestWebKitAPI::longTest2):
3059
3060 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3061
3062         Remove willDestroyFrame in WKBundlePageLoaderClient
3063         https://bugs.webkit.org/show_bug.cgi?id=142389
3064
3065         Reviewed by Anders Carlsson.
3066
3067         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3068         (WTR::InjectedBundlePage::InjectedBundlePage):
3069
3070 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
3071
3072         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3073         https://bugs.webkit.org/show_bug.cgi?id=142433
3074
3075         Reviewed by Darin Adler.
3076
3077         Include more TestWebKitAPI tests when building for Windows. Also
3078         fix a build error in MetaAllocator.cpp caused by one of the
3079         Microsoft headers #defining 'small'.
3080
3081         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3082         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3083         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3084
3085 2015-03-06  Sam Weinig  <sam@webkit.org>
3086
3087         [Content Extensions] Move compiling of content extensions to the UIProcess
3088         https://bugs.webkit.org/show_bug.cgi?id=142402
3089
3090         Reviewed by Benjamin Poulain.
3091
3092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3093         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3094         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3095         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3096         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3097         (TestWebKitAPI::TEST_F):
3098         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3099         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3100         is now abstract).
3101
3102 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
3103
3104         [Win] Correct Windows build.
3105
3106         Rubberstamped by Michael Saboff
3107
3108         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3109         in the GOTO labels.
3110
3111 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3112
3113         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3114         https://bugs.webkit.org/show_bug.cgi?id=142385
3115
3116         Reviewed by Sergio Villar Senin.
3117
3118         Use stack allocated GMainLoopSources to make sure they are
3119         cancelled automatically if the test finishes before they have
3120         been processed.
3121
3122         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3123         (testWebViewSyncRequestOnMaxConns):
3124
3125 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3126
3127         Remove Mountain Lion libraries since ML isn't supported
3128         https://bugs.webkit.org/show_bug.cgi?id=142332
3129
3130         Reviewed by Darin Adler.
3131
3132         * Scripts/copy-webkitlibraries-to-product-directory:
3133
3134 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
3135
3136         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3137         https://bugs.webkit.org/show_bug.cgi?id=142083
3138
3139         Reviewed by Simon Fraser.
3140
3141         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3142
3143         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3144         (WebPlatformTestServer._copy_webkit_test_files):
3145
3146 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3147
3148         setup-git-clone fails due to the failure to download python-irclib-0.4.8
3149         https://bugs.webkit.org/show_bug.cgi?id=141946
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         Check in ircbot.py and irclib.py to avoid network problems in the future.
3154
3155         * Scripts/webkitpy/common/net/irc/ircbot.py:
3156         * Scripts/webkitpy/thirdparty/__init__.py:
3157         (AutoinstallImportHook.find_module):
3158         (AutoinstallImportHook._install_irc): Deleted.
3159         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3160         (ThirdpartyTest.test_imports):
3161         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
3162         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
3163         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
3164
3165 2015-03-06  David Kilzer  <ddkilzer@apple.com>
3166
3167         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
3168
3169         See also fix to config.json in r181097.
3170
3171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3172         (WebKitBuildbot): Add missing "WK2" to the names of the perf
3173         bots.
3174
3175 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3176
3177         run-jsc-stress-tests should determine the architecture from ELF binaries
3178         https://bugs.webkit.org/show_bug.cgi?id=142335
3179
3180         Reviewed by Darin Adler.
3181
3182         * Scripts/run-jsc-stress-tests:
3183
3184 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3185
3186         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
3187         <http://webkit.org/b/142226>
3188
3189         Reviewed by Darin Adler.
3190
3191         * Scripts/webkitpy/port/ios.py:
3192         (IOSSimulatorPort.default_baseline_search_path): Switch the
3193         TestExpectations order of ios-simulator-wk2 from this:
3194           ios-simulator-wk2, wk2, ios-simulator
3195         To this:
3196           ios-simulator-wk2, ios-simualtor, wk2
3197
3198 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3199
3200         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
3201         https://bugs.webkit.org/show_bug.cgi?id=142370
3202
3203         Reviewed by Dean Jackson.
3204
3205         * Scripts/webkitdirs.pm:
3206         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
3207         logs, one for warnings, the other for errors.
3208         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
3209         into the standard BuildOutput.htm document.
3210
3211 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3212
3213         Dashboard has trouble parsing iOS test output
3214         <http://webkit.org/b/142364>
3215
3216         Reviewed by Alex Christensen.
3217
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3219         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3220         Add fallback path to build a regex using 'matchString' so that
3221         it matches anywhere in the line.  In practice, 'matchString' is
3222         a prefix for the label following the number.
3223
3224 2015-03-05  Alex Christensen  <achristensen@webkit.org>
3225
3226         Fix linker warnings in TestWebKitAPI.
3227         https://bugs.webkit.org/show_bug.cgi?id=141912
3228
3229         Reviewed by David Kilzer.
3230
3231         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3232         Do not export TearDownTestCase or SetUpTestCase symbols.
3233
3234 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3235
3236         [Win] Unreviewed EWS fix.
3237
3238         * Scripts/webkitdirs.pm:
3239         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
3240         the EWS output more usable.
3241
3242 2015-03-05  Chris Dumez  <cdumez@apple.com>
3243
3244         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
3245         https://bugs.webkit.org/show_bug.cgi?id=142350
3246
3247         Reviewed by Michael Saboff and Benjamin Poulain.
3248
3249         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
3250         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
3251
3252         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3253         (TestWebKitAPI::TEST):
3254
3255 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3256
3257         [Win] Ensure build target directory exists when launching MSBuild
3258         https://bugs.webkit.org/show_bug.cgi?id=142360
3259
3260         Reviewed by Dean Jackson.
3261
3262         Create the build output directory (if it doesn't exist) before
3263         launching MSBuild so that it can immediately begin writing logs.
3264
3265         * Scripts/webkitdirs.pm:
3266         (buildVisualStudioProject):
3267
3268 2015-03-05  Chris Dumez  <cdumez@apple.com>
3269
3270         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
3271         https://bugs.webkit.org/show_bug.cgi?id=142325
3272
3273         Reviewed by Csaba Osztrogonác.
3274
3275         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
3276         As a result, "--webkit-test-runner / -2" parameters are replaced by
3277         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
3278         than WebKitTestRunner.
3279
3280         * BuildSlaveSupport/build.webkit.org-config/config.json:
3281         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3282         (RunWebKit1Tests):
3283         (RunWebKit1Tests.start):
3284         (RunWebKit1LeakTests):
3285         (RunWebKit1LeakTests.start):
3286         (RunAndUploadPerfTestsWebKit1):
3287         (RunAndUploadPerfTestsWebKit1.start):
3288         (TestFactory):
3289         (TestWebKit1LeaksFactory):
3290         (TestWebKit1LeaksFactory.__init__):
3291         (TestWebKit1Factory):
3292         (TestWebKit1AllButJSCFactory):
3293         (TestAllButJSCFactory):
3294         (BuildAndPerfTestWebKit1Factory):
3295         (BuildAndPerfTestWebKit1Factory.__init__):
3296         (BuildAndPerfTestFactory):
3297         (BuildAndPerfTestFactory.__init__):
3298         (DownloadAndPerfTestWebKit1Factory):
3299         (DownloadAndPerfTestWebKit1Factory.__init__):
3300         (DownloadAndPerfTestFactory):
3301         (DownloadAndPerfTestFactory.__init__):
3302         (RunWebKitLeakTests): Deleted.
3303         (RunWebKitLeakTests.start): Deleted.
3304         (RunWebKit2Tests): Deleted.
3305         (RunWebKit2Tests.start): Deleted.
3306         (RunAndUploadPerfTestsWebKit2): Deleted.
3307         (RunAndUploadPerfTestsWebKit2.start): Deleted.
3308         (TestLeaksFactory): Deleted.
3309         (TestLeaksFactory.__init__): Deleted.
3310         (TestWebKit2Factory): Deleted.
3311         (TestWebKit2AndJSCFactory): Deleted.
3312         (BuildAndPerfTestWebKit2Factory): Deleted.
3313         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
3314         (DownloadAndPerfTestWebKit2Factory): Deleted.
3315         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
3316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3317         (parse_args):
3318         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3319         (PerfTestsRunner._parse_args):
3320         * Scripts/webkitpy/port/port_testcase.py:
3321         (PortTestCase.test_build_driver):
3322
3323 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3324
3325         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
3326         https://bugs.webkit.org/show_bug.cgi?id=140845
3327
3328         Reviewed by David Kilzer.
3329
3330         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
3331         and generate suitable build commands to drive a full build from our
3332         existing solution files.
3333
3334         * Scripts/webkitdirs.pm:
3335         (msBuildInstallDir): Added.
3336         (determineConfigurationForVisualStudio): Revise to use MSBuild command
3337         line arguments to drive the build.
3338         (setupCygwinEnv): Warn user if MSBuild cannot be located.
3339         (buildVisualStudioProject): Revise to use MSBuild command line arguments
3340         to specify build architecture.
3341         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
3342         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
3343         bother looking for CoreUI or SafariTheme build logs.
3344
3345 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3346
3347         [buildbot] mastercfg_unittest.py should be runnable easily
3348         https://bugs.webkit.org/show_bug.cgi?id=142219
3349
3350         Reviewed by Chris Dumez.
3351
3352         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
3353         the last Twisted version works together with this buildbot version.
3354
3355         * Scripts/webkitpy/common/system/autoinstall.py:
3356         (AutoInstaller): Added prepend_to_search_path argument to be able
3357         to prefer autoinstalled package to system package.
3358         (AutoInstaller.__init__):
3359         (AutoInstaller._set_up_target_dir):
3360         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
3361         (AutoInstaller._prepare_package):
3362         (AutoInstaller._extract_targz): Renamed to _extract_tar.
3363         * Scripts/webkitpy/thirdparty/__init__.py:
3364         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
3365
3366 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
3367
3368         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
3369         https://bugs.webkit.org/show_bug.cgi?id=131162
3370
3371         Reviewed by Gyuyoung Kim.
3372
3373         * MiniBrowser/efl/main.c:
3374         (on_download_request):
3375         (on_download_finished):
3376         (on_download_failed):
3377         (window_create):
3378         Adapt download callbacks to new callback mechanism
3379
3380 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3381
3382         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
3383
3384         In r180927 we updated the libsoup version used by the jhbuild. In
3385         this new version the sniffer uses image/x-icon instead of
3386         image/vnd.microsoft.icon for blank.ico resource.
3387
3388         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3389         (testWebResourceMimeType):
3390
3391 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3392
3393         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
3394         https://bugs.webkit.org/show_bug.cgi?id=142244
3395
3396         Reviewed by Sergio Villar Senin.
3397
3398         Check that the SSL server doesn't process any request in case of
3399         TLS errors when the policy is set to FAIL.
3400
3401         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3402         (testTLSErrorsPolicy):
3403         (testTLSErrorsRedirect):
3404         (testTLSErrorsHTTPAuth):
3405         (testLoadFailedWithTLSErrors):
3406         (testSubresourceLoadFailedWithTLSErrors):
3407         (httpsServerCallback):
3408
3409 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
3410
3411         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
3412         https://bugs.webkit.org/show_bug.cgi?id=141154
3413
3414         Reviewed by Jer Noble.
3415
3416         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
3417
3418         For the sake of completeness WebKitTestRunner should specify temporary
3419         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
3420
3421         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
3422         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3423         to get data storage paths. Only Mac port has an actual implementation of it.
3424         However, WebKitTestRunner overrides them in favour of unique temporary dir
3425         which is taken from libraryPathForTesting().
3426
3427         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3428         is not implemented for EFL and GTK ports it returns an empty string.
3429         All default data folders besides MediaKeys are overridden in TestRunner
3430         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
3431         env variable.
3432
3433         GTK port does not enable encrypted keys by default so
3434         WebMediaKeyStorageManager::initialize() code path is never triggered.
3435
3436         * WebKitTestRunner/TestController.cpp:
3437         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
3438         WebKit ports.
3439
3440 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3441
3442         [buildbot] Add regression test to check which builder runs which tests
3443         https://bugs.webkit.org/show_bug.cgi?id=142166
3444
3445         Reviewed by Alexey Proskuryakov.
3446
3447         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3448         (BuildStepsConstructorTest.createTest):
3449         (BuildStepsTest):
3450         (BuildStepsTest.generateTests):
3451         (BuildStepsTest.createTest):
3452         (BuildStepsTest.createTest.doTest):
3453         (BuildStepsTest.test_unnecessary_expected_results):
3454
3455 2015-03-04  Commit Queue  <commit-queue@webkit.org>
3456
3457         Unreviewed, rolling out r181054.
3458         https://bugs.webkit.org/show_bug.cgi?id=142320
3459
3460         Broke the api tests (Requested by sundiamonde on #webkit).
3461
3462         Reverted changeset:
3463
3464         "Fix linker warnings in TestWebKitAPI."
3465         https://bugs.webkit.org/show_bug.cgi?id=141912
3466         http://trac.webkit.org/changeset/181054
3467
3468 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3469
3470         Fix linker warnings in TestWebKitAPI.
3471         https://bugs.webkit.org/show_bug.cgi?id=141912
3472
3473         Reviewed by David Kilzer.
3474
3475         * TestWebKitAPI/Configurations/Base.xcconfig:
3476         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
3477
3478 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
3479
3480         [Mac] Set SystemUIFontSelect in DRT and WKTR
3481         https://bugs.webkit.org/show_bug.cgi?id=142303
3482
3483         Reviewed by Myles C. Maxfield.
3484
3485         * DumpRenderTree/mac/DumpRenderTree.mm:
3486         (setDefaultsToConsistentValuesForTesting):
3487         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3488         (WTR::InjectedBundle::platformInitialize):
3489
3490 2015-03-04  Chris Dumez  <cdumez@apple.com>
3491
3492         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3493         https://bugs.webkit.org/show_bug.cgi?id=142314
3494         <rdar://problem/20046835>
3495
3496         Reviewed by Ryosuke Niwa.
3497
3498         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3499         to get WK2 code coverage.
3500
3501         * BuildSlaveSupport/build.webkit.org-config/config.json:
3502
3503 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3504
3505         Move content extensions test to properly named directory.
3506         https://bugs.webkit.org/show_bug.cgi?id=142299
3507
3508         Reviewed by Tim Horton.
3509
3510         * WebKitTestRunner/mac/TestControllerMac.mm:
3511         (WTR::TestController::platformConfigureViewForTest):
3512
3513 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3514
3515         W3C test importer should use filesystem instead of os.walk
3516         https://bugs.webkit.org/show_bug.cgi?id=142085
3517
3518         Reviewed by Bem Jones-Bey.
3519
3520         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
3521         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
3522         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
3523
3524         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
3525         Added a unit test to check that test importer is now black-box testable using a Mock system.
3526
3527         * Scripts/webkitpy/common/system/filesystem.py:
3528         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
3529         (FileSystem.dirs_under.filter_all):
3530         * Scripts/webkitpy/common/system/filesystem_mock.py:
3531         (MockFileSystem.dirs_under):
3532         (MockFileSystem.dirs_under.filter_all):
3533         (MockFileSystem.getsize):
3534         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3535         (MockFileSystemTest.test_dirs_under):
3536         (MockFileSystemTest.test_dirs_under.filter_dir):
3537         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3538         (RealFileSystemTest.test_sep):
3539         (RealFileSystemTest):
3540         (RealFileSystemTest.test_dirs_under):
3541         (RealFileSystemTest.test_dirs_under.filter_this_dir):
3542         * Scripts/webkitpy/w3c/test_importer.py:
3543         (TestImporter.do_import):
3544         (TestImporter.find_importable_tests.should_keep_subdir):
3545         (TestImporter.find_importable_tests):
3546         (TestImporter.should_keep_subdir): Deleted.
3547         (TestImporter.should_skip_file): Deleted.
3548         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3549         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
3550
3551 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
3552
3553         [WebEditingTester] Add support for the find and replace bar
3554         https://bugs.webkit.org/show_bug.cgi?id=142247
3555
3556         Reviewed by Enrica Casucci.
3557
3558         While it's not hooked up yet in WKWebView, adding support for the
3559         find bar to WebEditingTester will help us implement that functionality.
3560
3561         * WebEditingTester/AppDelegate.h:
3562         * WebEditingTester/AppDelegate.m:
3563         (-[WebEditingAppDelegate performTextFinderAction:]):
3564         * WebEditingTester/MainMenu.xib:
3565         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
3566
3567         * WebEditingTester/WK2WebDocumentController.m:
3568         (-[WK2WebDocumentController awakeFromNib]):
3569         (-[WK2WebDocumentController performTextFinderAction:]):
3570         (-[WK2WebDocumentController findBarView]):
3571         (-[WK2WebDocumentController setFindBarView:]):
3572         (-[WK2WebDocumentController isFindBarVisible]):
3573         (-[WK2WebDocumentController setFindBarVisible:]):
3574         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
3575         (-[WK2WebDocumentController layout]):
3576         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
3577         pointing at the WKWebView (currently nothing will work, but the bar will
3578         show up). Install and uninstall the bar as needed.
3579
3580         * WebEditingTester/WebDocument.xib:
3581         Don't use a full-size content view. There's no need, and it makes find
3582         bar layout harder.
3583
3584         * WebEditingTester/WebDocumentController.h:
3585         * WebEditingTester/WebDocumentController.m:
3586         (-[WebDocumentController performTextFinderAction:]):
3587
3588 2015-03-03  Sam Weinig  <sam@webkit.org>
3589
3590         [Content Extensions] Split parsing and compiling of content extensions into their own files
3591         https://bugs.webkit.org/show_bug.cgi?id=142259
3592
3593         Reviewed by Anders Carlsson.
3594
3595         Add basic unit test for the content filter compiler.
3596
3597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3598         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
3599         (WebCore::ContentExtensions::operator<<):
3600         (TestWebKitAPI::ContentFilterTest::SetUp):
3601         (TestWebKitAPI::TEST_F):
3602
3603 2015-03-04  Matthew Mirman  <mmirman@apple.com>
3604
3605         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
3606         https://bugs.webkit.org/show_bug.cgi?id=142230
3607
3608         Reviewed by Csaba Osztrogonác.
3609
3610         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3611         (TestFactory):
3612         (TestFactory.getProduct): Added
3613         (TestFactory.__init__): moved downloader to getProduct
3614         (BuildAndTestFactory):        
3615         (BuildAndTestFactory.getProduct): Added
3616         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
3617         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
3618
3619 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
3620
3621         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
3622         https://bugs.webkit.org/show_bug.cgi?id=142225
3623
3624         Reviewed by Carlos Garcia Campos.
3625
3626         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3627         (testWebViewWebContextLifetime):
3628         (beforeAll):
3629
3630 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3631
3632         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
3633         <http://webkit.org/b/142243>
3634
3635         Reviewed by Alexey Proskuryakov.
3636
3637         * WebKitTestRunner/TestController.cpp:
3638         (WTR::TestController::webProcessName):
3639         (WTR::TestController::networkProcessName):
3640         - Return the same process name on iOS and Mac because they both
3641           use the same process name for local engineering builds.
3642
3643 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3644
3645         check-webkit-style: Add exception for FrameworkSoftLink.h header order
3646         <http://webkit.org/b/141872>
3647
3648         Reviewed by Alex Christensen.
3649
3650         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
3651         semi-colons in various places and fix whitespace.
3652         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
3653         constants.
3654         (_IncludeState.__init__): Add self._visited_soft_link_section
3655         boolean state variable.
3656         (_IncludeState.visited_soft_link_section): Getter for
3657         self._visited_soft_link_section.
3658         (_IncludeState.check_next_include_order): Update state machine
3659         for soft-link headers.  Add check that soft-link headers always
3660         appear last.
3661         (_classify_include): Add check for soft-link header type.
3662         (check_include_line): Return early if there is a soft-link
3663         header error.
3664
3665         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3666         (OrderOfIncludesTest.test_public_primary_header): Add tests for
3667         including soft-link headers.
3668         (OrderOfIncludesTest.test_classify_include): Add test for
3669         _SOFT_LINK_HEADER type.
3670
3671 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
3672
3673         build.webkit.org/dashboard: Don't repeatedly handle each test type
3674         https://bugs.webkit.org/show_bug.cgi?id=142211
3675
3676         Reviewed by Tim Horton and Matt Hanson.
3677
3678         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3679         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
3680         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
3681         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
3682         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
3683         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
3684         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
3685         Removed functions that build a link&