[Qt] Replace GNU linker script for exports with export macros in WTF/JSC
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
2
3         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
4         https://bugs.webkit.org/show_bug.cgi?id=77723
5
6         Reviewed by Tor Arne Vestbø.
7
8         * Tools.pro: Compile WTR again on all platforms with WK2.
9
10 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
11
12         Ensure that inspector disabled build works
13         https://bugs.webkit.org/show_bug.cgi?id=77604
14
15         Reviewed by Tor Arne Vestbø.
16
17         * qmake/mkspecs/features/features.prf:
18
19 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
20
21         [chromium] add support for --makeargs to the ninja-based build
22         https://bugs.webkit.org/show_bug.cgi?id=77688
23
24         Reviewed by Adam Barth.
25
26         * Scripts/webkitdirs.pm:
27         (buildChromiumNinja):
28
29 2012-02-02  Eric Seidel  <eric@webkit.org>
30
31         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
32         https://bugs.webkit.org/show_bug.cgi?id=75145
33
34         Reviewed by Dirk Pranke.
35
36         * Scripts/webkitpy/layout_tests/port/mac.py:
37         (MacPort.default_child_processes):
38         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
39         (test_operating_system):
40         (test_default_child_processes):
41
42 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
43
44        nrwt shouldn't blow up when there are errors in test_expectations.txt
45        https://bugs.webkit.org/show_bug.cgi?id=73603
46
47        Reviewed by Ojan Vafai.
48
49        This change removes the distinction between 'errors' and 'warnings'
50        in the test expectations parser. Now, any problem is a
51        'warning', and if we are linting the file, warnings become fatal (errors).
52
53         This will allow a normal run-webkit-tests run to proceed even if
54         there are bad lines.
55
56         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
57         (ParseError.__init__):
58         (ParseError.__str__):
59         (ParseError.__repr__):
60         (TestExpectationSerializer.to_string):
61         (TestExpectationParser._parse_modifiers):
62         (TestExpectationParser._parse_expectations):
63         (TestExpectationParser._check_modifiers_against_expectations):
64         (TestExpectationParser._tokenize):
65         (TestExpectationLine.__init__):
66         (TestExpectationLine.is_invalid):
67         (TestExpectationsModel.add_expectation_line):
68         (TestExpectationsModel._already_seen_better_match):
69         (TestExpectations.__init__):
70         (TestExpectations._report_warnings):
71         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
72         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
73         (assert_bad_expectations):
74         (test_parse_warning):
75         (test_overrides__duplicate):
76         (ExpectationSyntaxTests.test_missing_expectation):
77         (ExpectationSyntaxTests.test_missing_colon):
78         (ExpectationSyntaxTests.test_too_many_colons):
79         (ExpectationSyntaxTests.test_too_many_equals_signs):
80         (ExpectationSyntaxTests.test_unrecognized_expectation):
81         (SemanticTests.test_bug_format):
82         (SemanticTests.test_bad_bugid):
83         (SemanticTests.test_slow_and_timeout):
84         (test_ambiguous):
85         (test_more_modifiers):
86         (test_order_in_file):
87         (test_macro_overrides):
88         (RebaseliningTest.assertRemove):
89         (TestExpectationParserTests.test_tokenize_blank):
90         (TestExpectationParserTests.test_tokenize_missing_colon):
91         (TestExpectationParserTests.test_tokenize_extra_colon):
92         (TestExpectationParserTests.test_tokenize_empty_comment):
93         (TestExpectationParserTests.test_tokenize_comment):
94         (TestExpectationParserTests.test_tokenize_missing_equal):
95         (TestExpectationParserTests.test_tokenize_extra_equal):
96         (TestExpectationParserTests.test_tokenize_valid):
97         (TestExpectationParserTests.test_tokenize_valid_with_comment):
98         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
99         (TestExpectationSerializerTests.test_unparsed_to_string):
100         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
101         (lint):
102         * Scripts/webkitpy/style/checkers/test_expectations.py:
103         (TestExpectationsChecker.check_test_expectations):
104
105 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
106
107         Unreviewed, rolling out r106543.
108         http://trac.webkit.org/changeset/106543
109         https://bugs.webkit.org/show_bug.cgi?id=77671
110
111         Made tests less stable (Requested by rniwa on #webkit).
112
113         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
114         (PerfTestsRunner):
115         (PerfTestsRunner.__init__):
116         (PerfTestsRunner._run_tests_set):
117         (PerfTestsRunner._run_single_test):
118         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
119         (MainTest.TestDriver.run_test):
120         (run_test):
121
122 2012-02-02  Beth Dakin  <bdakin@apple.com>
123
124         https://bugs.webkit.org/show_bug.cgi?id=77664
125         Add API tests for didNewFirstVisuallyNonEmptyLayout
126
127         Reviewed by Darin Adler.
128
129         Two new tests.
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
131         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
132         (TestWebKitAPI):
133         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
134         (TestWebKitAPI::setPageLoaderClient):
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
137         (TestWebKitAPI):
138         (TestWebKitAPI::didForceRepaint):
139         (TestWebKitAPI::didFinishLoadForFrame):
140         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
141         (TestWebKitAPI::setPageLoaderClient):
142         (TestWebKitAPI::TEST):
143         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
144         (TestWebKitAPI):
145         (NewFirstVisuallyNonEmptyLayoutFailsTest):
146         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
147         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
148         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
149         (TestWebKitAPI):
150         (NewFirstVisuallyNonEmptyLayoutTest):
151         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
152         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
153
154 2012-02-02  Michael Saboff  <msaboff@apple.com>
155
156         Add Michael Saboff to reviewers list.
157
158         Rubber-stamped by Gavin Barraclough.
159
160         * Scripts/webkitpy/common/config/committers.py:
161
162 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
163
164         Add myself as a committer
165
166         Unreviewed
167
168         * Scripts/webkitpy/common/config/committers.py:
169
170 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
171
172         [PerformanceTests] tests have dependencies
173         https://bugs.webkit.org/show_bug.cgi?id=77506
174
175         Reviewed by Hajime Morita.
176
177         Load an initialization page before each test after starting a DRT so that
178         warming up DRT won't affect the performance test results.
179
180         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
181         (PerfTestsRunner):
182         (PerfTestsRunner.__init__):
183         (PerfTestsRunner._run_tests_set):
184         (PerfTestsRunner._run_single_test):
185         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
186         (MainTest.TestDriver.run_test):
187         (test_initial_page_loaded):
188         (test_initial_page_loaded.run_test):
189
190 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
191
192         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
193
194         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
195         (PerfTestsRunner._run_tests_set):
196         (PerfTestsRunner._run_single_test):
197         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
198         (create_runner):
199         (test_run_passing_test):
200         (test_run_silent_test):
201         (test_run_failed_test):
202         (test_run_tonguey_test):
203         (test_run_timeout_test):
204         (test_run_crash_test):
205         (test_run_test_set_kills_drt_per_run):
206         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
207         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
208         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
209
210 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
211
212         Webkit generate-coverage-data script needs update to use new test script
213         https://bugs.webkit.org/show_bug.cgi?id=77597
214
215         Reviewed by Dirk Schulze.
216
217         * Scripts/generate-coverage-data:
218
219 2012-02-01  Adam Barth  <abarth@webkit.org>
220
221         Update the tests to show that the mac-ews processes patches from
222         non-committers.
223
224         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
225         (EarlyWarningSytemTest.test_committer_only_ewses):
226         (EarlyWarningSytemTest.test_builder_ewses):
227
228 2012-02-01  Adam Barth  <abarth@webkit.org>
229
230         Mac-ews logs are huge
231         https://bugs.webkit.org/show_bug.cgi?id=77045
232
233         Reviewed by Eric Seidel.
234
235         In order to get the cr-linux-ews bot to run tests on EC2, we created
236         the chromium-xvfb port, which contained a number of tweaks to the
237         Chromium port's behavior.  This patch refactors those tweaks so they
238         can be shared with the mac-ews, mostly by moving them into the
239         non-interactive mode of RunTests.
240
241         * Scripts/webkitpy/common/config/ports.py:
242         (WebKitPort):
243         (WebKitPort.layout_tests_results_path):
244         (ChromiumPort.run_javascriptcore_tests_command):
245         (ChromiumXVFBPort):
246         (ChromiumXVFBPort.run_webkit_tests_command):
247         * Scripts/webkitpy/common/config/ports_mock.py:
248         (MockPort):
249         (MockPort.layout_tests_results_path):
250         * Scripts/webkitpy/common/config/ports_unittest.py:
251         (WebKitPortTest.test_chromium_xvfb_port):
252         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
253         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
254         * Scripts/webkitpy/tool/commands/queues_unittest.py:
255         (CommitQueueTest.test_commit_queue):
256         (test_rollout):
257         (test_manual_reject_during_processing):
258         * Scripts/webkitpy/tool/steps/runtests.py:
259         (RunTests.run):
260         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
261         (RunTestsTest.test_no_unit_tests):
262         * Scripts/webkitpy/tool/steps/steps_unittest.py:
263         (StepsTest.test_runtests_args):
264
265 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
266
267         Roll out r106442. It made some tests more stable but others less stable.
268
269         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
270         (PerfTestsRunner._run_tests_set):
271         (PerfTestsRunner._run_single_test):
272         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
273         (create_runner):
274         (test_run_passing_test):
275         (test_run_silent_test):
276         (test_run_failed_test):
277         (test_run_tonguey_test):
278         (test_run_timeout_test):
279         (test_run_crash_test):
280         (test_run_test_set):
281
282 2012-02-01  Lucas Forschler  <lforschler@apple.com>
283
284         Enable EWS for non-contributers.
285         https://bugs.webkit.org/show_bug.cgi?id=77576
286         
287         Reviewed by Adam Barth.
288
289         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
290         (MacEWS):
291
292 2012-02-01  Beth Dakin  <bdakin@apple.com>
293
294         https://bugs.webkit.org/show_bug.cgi?id=77383
295         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
296         -and corresponding-
297         <rdar://problem/10709560>
298
299         Reviewed by Sam Weinig.
300
301         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
302         for.
303         * MiniBrowser/mac/BrowserWindowController.m:
304         (-[BrowserWindowController awakeFromNib]):
305         * WebKitTestRunner/TestController.cpp:
306         (WTR::TestController::initialize):
307
308 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
309
310         TestWebKitAPI isn't being built on chromium bots any more
311         https://bugs.webkit.org/show_bug.cgi?id=77563
312
313         Reviewed by Dimitri Glazkov.
314
315         I accidentally dropped it in the refactoring in r105449.
316
317         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
318
319 2012-02-01  Hans Wennborg  <hans@chromium.org>
320
321         Rename WebSpeechInputResult::set() to assign()
322         https://bugs.webkit.org/show_bug.cgi?id=77540
323
324         Reviewed by Darin Fisher.
325
326         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
327         (MockWebSpeechInputController::addMockRecognitionResult):
328         (MockWebSpeechInputController::speechTaskFired):
329
330 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
331
332         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
333         https://bugs.webkit.org/show_bug.cgi?id=77542
334
335         Reviewed by Martin Robinson.
336
337         * gtk/generate-gtkdoc: Check first whether there's
338         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
339         instead.
340         (get_webkit2_options): Return just the options since the
341         pkg_config_path doesn't depend on options
342         (get_webkit1_options): Ditto.
343         (generate_doc): Helper function to create a generator and generate
344         documentation for the given pkg-config file with the given options.
345         * gtk/gtkdoc.py:
346         (GTKDoc.__init__): Don't use ** for args parameter, since it's
347         used as a dict and never expanded.
348         (PkgConfigGTKDoc.__init__): Ditto.
349
350 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
351
352         [GTK] API documentation is not installed even when building with --enable-gtk-doc
353         https://bugs.webkit.org/show_bug.cgi?id=77094
354
355         Reviewed by Martin Robinson.
356
357         * GNUmakefile.am: Add install-data-local and uninstall-local rules
358         to install/uninstall WebKit1 and WebKit2 API documentation.
359
360 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
361
362         Unreviewed, rolling out r106460.
363         http://trac.webkit.org/changeset/106460
364         https://bugs.webkit.org/show_bug.cgi?id=77552
365
366         It break unit tests if WEBKIT_TESTFONTS isn't defined.
367         (Requested by Ossy on #webkit).
368
369         * Scripts/webkitpy/layout_tests/port/qt.py:
370
371 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
372
373         [Qt] Automatic clean build feature always do clean build with --no-webkit2
374         https://bugs.webkit.org/show_bug.cgi?id=74519
375
376         Reviewed by Tor Arne Vestbø.
377
378         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
379
380         * qmake/mkspecs/features/features.prf:
381
382 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
383
384         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
385         https://bugs.webkit.org/show_bug.cgi?id=77466
386
387         Reviewed by Kenneth Rohde Christiansen.
388
389         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
390         is set or if we should raise an error.
391
392         * Scripts/webkitpy/layout_tests/port/qt.py:
393         (QtPort.setup_environ_for_server):
394
395 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
396
397         Reviewed by Martin Robinson.
398
399         [GTK] Improve FrameLoader signals. Resource loading
400         https://bugs.webkit.org/show_bug.cgi?id=49543
401
402         Support for the new loader signals in DRT.
403
404         * DumpRenderTree/gtk/DumpRenderTree.cpp:
405         (urlPath):
406         (willSendRequestCallback):
407         (urlSuitableForTestResult):
408         (descriptionSuitableForTestResult):
409         (didReceiveResponse):
410         (didFinishLoading):
411         (didFailLoadingWithError):
412         (createWebView):
413
414 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
415
416         run-perf-tests should restart DRT for each test
417         https://bugs.webkit.org/show_bug.cgi?id=77506
418
419         Reviewed by Adam Barth.
420
421         Always restart DRT when running performance tests in order to minimize the dependency between tests.
422
423         * Scripts/webkitpy/layout_tests/port/chromium.py:
424         (ChromiumDriver.stop):
425         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
426         (PerfTestsRunner._run_tests_set):
427         (PerfTestsRunner._run_single_test):
428         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
429         (create_runner):
430         (test_run_passing_test):
431         (test_run_silent_test):
432         (test_run_failed_test):
433         (test_run_tonguey_test):
434         (test_run_timeout_test):
435         (test_run_crash_test):
436         (test_run_test_set_kills_drt_per_run):
437         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
438         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
439         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
440
441 2012-01-31  Hans Wennborg  <hans@chromium.org>
442
443         Speech Input: Report speech element rect relative to window rather than frame
444         https://bugs.webkit.org/show_bug.cgi?id=76443
445
446         Reviewed by Darin Fisher.
447
448         Update LayoutTestController to allow for retrieving the speech
449         element's position used in a request.
450
451         In Chromium this is handled by the MockWebSpeechInputController;
452         adding stubs for the other implementations.
453
454         * DumpRenderTree/LayoutTestController.cpp:
455         (setMockSpeechInputDumpRectCallback):
456         (LayoutTestController::staticFunctions):
457         * DumpRenderTree/LayoutTestController.h:
458         (LayoutTestController):
459         * DumpRenderTree/chromium/LayoutTestController.cpp:
460         (LayoutTestController::LayoutTestController):
461         (LayoutTestController::setMockSpeechInputDumpRect):
462         * DumpRenderTree/chromium/LayoutTestController.h:
463         (LayoutTestController):
464         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
465         (MockWebSpeechInputController::setDumpRect):
466         (MockWebSpeechInputController::clearResults):
467         (MockWebSpeechInputController::startRecognition):
468         (MockWebSpeechInputController::MockWebSpeechInputController):
469         (makeRectResult):
470         (MockWebSpeechInputController::speechTaskFired):
471         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
472         (MockWebSpeechInputController):
473         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
474         (LayoutTestController::setMockSpeechInputDumpRect):
475         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
476         (LayoutTestController::setMockSpeechInputDumpRect):
477         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
478         (LayoutTestController::setMockSpeechInputDumpRect):
479         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
480         (LayoutTestController::setMockSpeechInputDumpRect):
481         * DumpRenderTree/qt/LayoutTestControllerQt.h:
482         (LayoutTestController):
483         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
484         (LayoutTestController::setMockSpeechInputDumpRect):
485         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
486         (LayoutTestController::setMockSpeechInputDumpRect):
487
488 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
489
490         [EFL] Add basic DRT/Efl implementation to support viewport test.
491         https://bugs.webkit.org/show_bug.cgi?id=77320
492
493         Reviewed by Andreas Kling.
494
495         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
496         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
497
498 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
499
500         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
501         https://bugs.webkit.org/show_bug.cgi?id=77473
502         <rdar://problem/10751357>
503
504         Reviewed by Darin Adler.
505
506         * DumpRenderTree/mac/EventSendingController.mm:
507         (-[EventSendingController keyDown:withModifiers:withLocation:]):
508         * WebKitTestRunner/mac/EventSenderProxy.mm:
509         (WTR::EventSenderProxy::keyDown):
510         Added a new special keyDown value to test this.
511
512 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
513
514         nrwt: fix the mock port to work with DriverProxy, reftests
515         https://bugs.webkit.org/show_bug.cgi?id=77170
516
517         Reviewed by Eric Seidel.
518
519         The DryrunPort used for benchmarking and testing NRWT has been
520         broken since we added the DriverProxy code. It isn't really
521         needed any more, so I've removed it.
522
523         The MockDRT port was also broken by DriverProxy, and moreover,
524         never worked w/ reftests. Since we don't exercise this module in
525         the unit tests, the code had also bitrotted some. I have cleaned
526         it up and made it use DriverInput and DriverOutput for
527         consistency.
528
529         * Scripts/webkitpy/layout_tests/port/dryrun.py:
530         (DryRunPort.__init__):
531         (DryRunPort):
532         (DryRunPort.real_name):
533         (DryRunPort.create_driver):
534         (DryRunPort.driver_cmd_line):
535         (DryRunPort._driver_class):
536         (DryrunDriver):
537         (DryrunDriver.run_test):
538         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
539         (MockDRTPort.create_driver):
540         (MockChromiumDRT.run_one_test):
541
542 2012-01-31  Ojan Vafai  <ojan@chromium.org>
543
544         run-webkit-tests calls out to webkit-build-directory twice
545         https://bugs.webkit.org/show_bug.cgi?id=77248
546
547         Reviewed by Dirk Pranke.
548
549         * Scripts/webkit-build-directory:
550         If called with no arguments, print out both the top-level directory and the 
551         configuration directory
552
553         * Scripts/webkitpy/layout_tests/port/config.py:
554         (Config.build_directory):
555         When called with no arguments, get and cache both the top-level and configuration directories.
556
557         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
558         (main):
559         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
560         (ConfigTest.assert_configuration):
561         (ConfigTest.test_build_directory.mock_webkit_build_directory):
562         (ConfigTest.test_build_directory):
563         (ConfigTest.test_default_configuration__notfound):
564         * Scripts/webkitpy/layout_tests/port/webkit.py:
565         (WebKitPort._build_path):
566         Cache the build directory in the options object so that other users
567         of the options object don't need to call out to webkit-build-directory.
568         Also, properly support the existing --build-directory argument.
569
570 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
571
572         Bump up the timeout for performance tests since DOM/DOMTable.html
573         and Parser/html5-full-render.html are timing out on the bot.
574
575         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
576         (PerfTestsRunner._parse_args):
577
578 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
579
580         Fix the update_webgl_conformance_tests.py script in order to enable it
581         to detect the SCM being used correctly.
582         https://bugs.webkit.org/show_bug.cgi?id=77462
583
584         Reviewed by Kenneth Russell.
585
586         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
587         (default_out_dir):
588
589 2012-01-31  Eric Seidel  <eric@webkit.org>
590
591         webkit-patch apply-from-bug should work regardless of your CWD
592         https://bugs.webkit.org/show_bug.cgi?id=77482
593
594         Reviewed by Adam Barth.
595
596         webkit-patch only ever works with patches made from the root
597         directory.  We should pass the CWD to svn-apply in the case
598         where we're running not from the webkit root.  I believe
599         this used to work in the past and regressed.
600
601         * Scripts/webkitpy/common/checkout/checkout.py:
602         (Checkout.apply_patch):
603         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
604         (CheckoutTest.test_apply_patch):
605
606 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
607
608         Unreviewed, rolling out r106302.
609         http://trac.webkit.org/changeset/106302
610         https://bugs.webkit.org/show_bug.cgi?id=77472
611
612         Broke building DRT before running the tests (Requested by ojan
613         on #webkit).
614
615         * Scripts/webkit-build-directory:
616         * Scripts/webkitpy/layout_tests/port/config.py:
617         (Config.build_directory):
618         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
619         (main):
620         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
621         (ConfigTest.assert_configuration):
622         (ConfigTest.test_build_directory.mock_webkit_build_directory):
623         (ConfigTest.test_build_directory):
624         (ConfigTest.test_default_configuration__notfound):
625         * Scripts/webkitpy/layout_tests/port/webkit.py:
626         (WebKitPort._build_path):
627
628 2012-01-31  Antoine Labour  <piman@chromium.org>
629
630         Merge WebGraphicsContext3D creation and initialization, and move it to
631         WebViewClient.
632         https://bugs.webkit.org/show_bug.cgi?id=76593
633
634         Reviewed by Darin Fisher.
635
636         * DumpRenderTree/chromium/TestWebPlugin.cpp:
637         (TestWebPlugin::TestWebPlugin):
638         (TestWebPlugin::initialize):
639         * DumpRenderTree/chromium/TestWebPlugin.h:
640         * DumpRenderTree/chromium/WebViewHost.cpp:
641         (WebViewHost::createGraphicsContext3D):
642         (WebViewHost::createPlugin):
643         * DumpRenderTree/chromium/WebViewHost.h:
644
645 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
646
647         [GTK] build-webkit warning.
648         https://bugs.webkit.org/show_bug.cgi?id=77411
649
650         Reviewed by Philippe Normand.
651
652         * Scripts/webkitdirs.pm:
653         (isCrossCompilation):
654
655 2012-01-31  Dan Bernstein  <mitz@apple.com>
656
657         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
658
659         Reviewed by Anders Carlsson.
660
661         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
662
663 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
664
665         If the QTDIR environment variable is set, the build system fails to compile WinCairo
666         https://bugs.webkit.org/show_bug.cgi?id=77112
667
668         Reviewed by Daniel Bates.
669
670         * Scripts/webkitdirs.pm:
671         (determineIsQt):
672
673 2012-01-31  Adam Roben  <aroben@apple.com>
674
675         Only call -typingAttributes on WebViews, not WebHTMLViews
676
677         Looks like this case was just missed in r105908.
678
679         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
680
681         Reviewed by Antti Koivisto.
682
683         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
684         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
685         earlier.
686
687 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
688
689         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
690         https://bugs.webkit.org/show_bug.cgi?id=77221
691
692         Reviewed by Kenneth Rohde Christiansen.
693
694         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
695
696         * MiniBrowser/qt/MiniBrowserApplication.cpp:
697         (MiniBrowserApplication::sendTouchEvent):
698
699 2012-01-26  Hans Wennborg  <hans@chromium.org>
700
701         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
702         https://bugs.webkit.org/show_bug.cgi?id=77083
703
704         Reviewed by Darin Fisher.
705
706         Add MockWebSpeechInputController which provides a mock implementation
707         of the WebSpeechInputController interface, and use that in
708         DumpRenderTree.
709
710         * DumpRenderTree/DumpRenderTree.gypi:
711         * DumpRenderTree/chromium/LayoutTestController.cpp:
712         (LayoutTestController::addMockSpeechInputResult):
713         * DumpRenderTree/chromium/LayoutTestController.h:
714         ():
715         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
716         (MockWebSpeechInputController::create):
717         (MockWebSpeechInputController::addMockRecognitionResult):
718         (MockWebSpeechInputController::clearResults):
719         (MockWebSpeechInputController::startRecognition):
720         (MockWebSpeechInputController::cancelRecognition):
721         (MockWebSpeechInputController::stopRecording):
722         (MockWebSpeechInputController::MockWebSpeechInputController):
723         (MockWebSpeechInputController::speechTaskFired):
724         (MockWebSpeechInputController::SpeechTask::SpeechTask):
725         (MockWebSpeechInputController::SpeechTask::stop):
726         (MockWebSpeechInputController::SpeechTask::runIfValid):
727         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
728         (WebKit):
729         (MockWebSpeechInputController):
730         (MockWebSpeechInputController::taskList):
731         (SpeechTask):
732         * DumpRenderTree/chromium/TestShell.cpp:
733         * DumpRenderTree/chromium/WebViewHost.cpp:
734         (WebViewHost::speechInputController):
735         * DumpRenderTree/chromium/WebViewHost.h:
736         (WebKit):
737         (WebViewHost::speechInputControllerMock):
738         (WebViewHost):
739         ():
740
741 2012-01-31  Hajime Morrita  <morrita@chromium.org>
742
743         [PerformanceTests] Add landing html for Dromaeo dom-query test
744         https://bugs.webkit.org/show_bug.cgi?id=77329
745
746         Reviewed by Ryosuke Niwa.
747
748         Added some more ignorable output patterns to allow warnings
749         from a third party test suite.
750
751         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
752         (PerfTestsRunner):
753         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
754
755 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
756
757         [wx] Unreviewed. Update download URLs to new domain.
758         
759         * waf/build/build_utils.py:
760         (update_wx_deps):
761
762 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
763
764         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
765         to the list of build directories.
766         
767         * waf/build/settings.py:
768
769 2012-01-30  Kentaro Hara  <haraken@chromium.org>
770
771         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
772         output an empty method name (i.e. "()")
773         https://bugs.webkit.org/show_bug.cgi?id=77336
774
775         Reviewed by Darin Adler.
776
777         r105797 tried to detect a change outside methods, but it causes a bug that
778         prepare-ChangeLog can output an empty method name, like this:
779
780             * foo/bar/baz.cpp:
781             (method1):
782             ():
783             (method2):
784
785         This is because the cpp parser in prepare-ChangeLog cannot distinguish
786         '{' as the beginning of a method with '{' as the beginning of an array definition
787         at the top level.
788
789             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
790
791             void func() { // This '{' is the beginning of a method.
792                 ...;
793             }
794
795         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
796
797         * Scripts/prepare-ChangeLog:
798         (get_function_line_ranges_for_cpp): Modified as described above.
799         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
800         an empty method name. Ideally this should not happen but may happen, since the
801         parsers are not perfect.
802         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
803         (NameSpace7):
804         (NameSpace8):
805         (Class109):
806         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
807
808 2012-01-30  Ojan Vafai  <ojan@chromium.org>
809
810         run-webkit-tests calls out to webkit-build-directory twice
811         https://bugs.webkit.org/show_bug.cgi?id=77248
812
813         Reviewed by Dirk Pranke.
814
815         This reduces to calls to webkit-build-directory to one call and
816         saves 500ms for run-webkit-tests over a single file.
817
818         * Scripts/webkit-build-directory:
819         If called with no arguments, print out both the top-level directory and the 
820         configuration directory.
821
822         * Scripts/webkit-build-directory:
823         * Scripts/webkitpy/layout_tests/port/config.py:
824         (Config.build_directory):
825         When called with no arguments, get and cache both the top-level and configuration directories.
826
827         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
828         (main):
829         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
830         (ConfigTest.assert_configuration):
831         (ConfigTest.test_build_directory.mock_webkit_build_directory):
832         (ConfigTest.test_build_directory):
833         (ConfigTest.test_default_configuration__notfound):
834         * Scripts/webkitpy/layout_tests/port/webkit.py:
835         (WebKitPort._build_path):
836         Cache the root directory in the options object so that other users
837         of the options object don't need to call out to webkit-build-directory.
838
839 2012-01-30  Ojan Vafai  <ojan@chromium.org>
840
841         Parsing test_expecations.txt + Skipped lists takes too long
842         https://bugs.webkit.org/show_bug.cgi?id=77059
843
844         Reviewed by Dirk Pranke.
845
846         This saves ~100ms on the Apple Mac port.
847         -memoize a bunch of path methods.
848         -Avoid doing multiple disk accesses per line.
849         -Parse the skipped list directly instead of turning it into a test_expecations.txt
850         formatting string and parsing that.
851
852         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
853         (TestExpectationParser):
854         (TestExpectationParser.expectation_for_skipped_test):
855         (TestExpectationParser._parse_line):
856         (TestExpectationParser._collect_matching_tests):
857         (TestExpectations.__init__):
858         (TestExpectations._add_skipped_tests):
859         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
860         (test_add_skipped_tests):
861         (test_add_skipped_tests_duplicate):
862         * Scripts/webkitpy/layout_tests/port/base.py:
863         (Port):
864         (Port.test_isfile):
865         (Port.normalize_test_name):
866         (Port.layout_tests_dir):
867         (Port.abspath_for_test):
868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
869
870 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
871
872         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
873         
874         * Scripts/webkitpy/common/config/watchlist:
875
876 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
877
878         Unreviewed build fix following bug#76855
879
880         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
881         ():
882         (TestWebKitAPI::TEST_F):
883
884 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
885
886         [Qt] WKTR: Use a software rendering pipiline when running tests.
887         https://bugs.webkit.org/show_bug.cgi?id=76708
888
889         Reviewed by Kenneth Rohde Christiansen.
890
891         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
892         (WTR::WrapperWindow::WrapperWindow):
893         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
894
895 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
896
897         [Qt] Store build config immediately instead of waiting for a successfull build
898
899         Otherwise we will not pick up changes to the config if the build is aborted,
900         for example due to build errors or if the user pressed Ctrl+Z. We now write
901         the new config before starting a build, but still defer to write the SVN
902         revision once the build completes successfully.
903
904         Reviewed by Ossy.
905
906         * Scripts/webkitdirs.pm:
907         (buildQMakeProjects):
908
909 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
910
911         [Qt] Add "New Window" button to the Qt MiniBrowser
912         https://bugs.webkit.org/show_bug.cgi?id=77281
913
914         Reviewed by Tor Arne Vestbø.
915
916         * MiniBrowser/qt/BrowserWindow.cpp:
917         (BrowserWindow::BrowserWindow):
918         * MiniBrowser/qt/MiniBrowser.qrc:
919         * MiniBrowser/qt/icons/plus.png: Added.
920         * MiniBrowser/qt/qml/BrowserWindow.qml:
921
922 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
923
924         Unreviewed rolling out r106222.
925
926         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
927         (SingleTestRunner.__init__):
928         * Scripts/webkitpy/layout_tests/controllers/worker.py:
929         (Worker.handle_test_list):
930         * Scripts/webkitpy/layout_tests/models/test_input.py:
931         (TestInput.__init__):
932         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
933         (_set_up_derived_options):
934         (parse_args):
935         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
936         (MainTest.test_repeat_each):
937         * WebKitTestRunner/TestInvocation.cpp:
938         (WTR::TestInvocation::setIsPixelTest):
939
940 2012-01-30  Hans Wennborg  <hans@chromium.org>
941
942         Unreviewed, rolling out r106219.
943         http://trac.webkit.org/changeset/106219
944         https://bugs.webkit.org/show_bug.cgi?id=77083
945
946         This broke Chromium's test_shell.
947
948         * DumpRenderTree/DumpRenderTree.gypi:
949         * DumpRenderTree/chromium/LayoutTestController.cpp:
950         (LayoutTestController::addMockSpeechInputResult):
951         * DumpRenderTree/chromium/LayoutTestController.h:
952         (WebKit):
953         (LayoutTestController):
954         ():
955         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
956         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
957         * DumpRenderTree/chromium/TestShell.cpp:
958         * DumpRenderTree/chromium/WebViewHost.cpp:
959         (WebViewHost::speechInputController):
960         * DumpRenderTree/chromium/WebViewHost.h:
961         (WebKit):
962         (WebViewHost::speechInputControllerMock):
963         (WebViewHost):
964         ():
965
966 2012-01-26  Hans Wennborg  <hans@chromium.org>
967
968         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
969         https://bugs.webkit.org/show_bug.cgi?id=77083
970
971         Reviewed by Darin Fisher.
972
973         Add MockWebSpeechInputController which provides a mock implementation
974         of the WebSpeechInputController interface, and use that in
975         DumpRenderTree.
976
977         * DumpRenderTree/DumpRenderTree.gypi:
978         * DumpRenderTree/chromium/LayoutTestController.cpp:
979         (LayoutTestController::addMockSpeechInputResult):
980         * DumpRenderTree/chromium/LayoutTestController.h:
981         ():
982         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
983         (MockWebSpeechInputController::create):
984         (MockWebSpeechInputController::addMockRecognitionResult):
985         (MockWebSpeechInputController::clearResults):
986         (MockWebSpeechInputController::startRecognition):
987         (MockWebSpeechInputController::cancelRecognition):
988         (MockWebSpeechInputController::stopRecording):
989         (MockWebSpeechInputController::MockWebSpeechInputController):
990         (MockWebSpeechInputController::speechTaskFired):
991         (MockWebSpeechInputController::SpeechTask::SpeechTask):
992         (MockWebSpeechInputController::SpeechTask::stop):
993         (MockWebSpeechInputController::SpeechTask::runIfValid):
994         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
995         (WebKit):
996         (MockWebSpeechInputController):
997         (MockWebSpeechInputController::taskList):
998         (SpeechTask):
999         * DumpRenderTree/chromium/TestShell.cpp:
1000         * DumpRenderTree/chromium/WebViewHost.cpp:
1001         (WebViewHost::speechInputController):
1002         * DumpRenderTree/chromium/WebViewHost.h:
1003         (WebKit):
1004         (WebViewHost::speechInputControllerMock):
1005         (WebViewHost):
1006         ():
1007
1008 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1009
1010         Unreviewed, rolling out r106109.
1011         http://trac.webkit.org/changeset/106109
1012         https://bugs.webkit.org/show_bug.cgi?id=77302
1013
1014         It made tests crash (Requested by Ossy_weekend on #webkit).
1015
1016         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1017         (WTR::WrapperWindow::WrapperWindow):
1018         (WTR::PlatformWebView::PlatformWebView):
1019
1020 2012-01-28  Nico Weber  <thakis@chromium.org>
1021
1022         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1023         https://bugs.webkit.org/show_bug.cgi?id=77243
1024
1025         Reviewed by Adam Barth.
1026
1027         * Scripts/update-webkit:
1028         * Scripts/webkitdirs.pm:
1029         (isChromiumNinja):
1030         (determineIsChromiumNinja):
1031         (buildChromiumNinja):
1032         (buildChromium):
1033
1034 2012-01-27  Kentaro Hara  <haraken@chromium.org>
1035
1036         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1037         https://bugs.webkit.org/show_bug.cgi?id=77241
1038
1039         Reviewed by Ryosuke Niwa.
1040
1041         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1042         in a method in some namespace or class is treated as a method.
1043         This patch fixes the bug.
1044
1045             class C {
1046                 void func()
1047                 {
1048                     if (1) {    // This should not be treated as a method.
1049                     }
1050                 }
1051             };
1052
1053         * Scripts/prepare-ChangeLog:
1054         (get_function_line_ranges_for_cpp):
1055         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1056         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1057         (Class108):
1058         (Class108::func35):
1059
1060 2012-01-27  Enrica Casucci  <enrica@apple.com>
1061
1062         Followup to http://trac.webkit.org/changeset/106171.
1063         Dan Bernstein pointed out correctly that I should
1064         have used copy instead of initWithString.
1065
1066         Reviewed by Dan Bernstein.
1067
1068         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1069         (-[LocalPasteboard initWithName:]):
1070
1071 2012-01-27  Enrica Casucci  <enrica@apple.com>
1072
1073         DRT pasteboard object should return the correct pasteboard name.
1074         https://bugs.webkit.org/show_bug.cgi?id=77260
1075         
1076         Currently the name property always returns nil.
1077         Adding a memeber variable to store the pasteboard name and return its
1078         value from the name method instead of returning nil always.
1079
1080         Reviewed by Dan Bernstein.
1081
1082         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1083         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1084         (-[LocalPasteboard initWithName:]):
1085         (-[LocalPasteboard name]):
1086
1087 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
1088
1089         [GTK] [WK2] Implement the policy client
1090         https://bugs.webkit.org/show_bug.cgi?id=76343
1091
1092         Reviewed by Gustavo Noronha Silva.
1093
1094         * gtk/generate-gtkdoc:
1095         (get_webkit2_options): Update the list of skipped source files to include all clients.
1096
1097 2012-01-27  Ada Chan  <adachan@apple.com>
1098
1099         Add test for WKBundleFrameGetParentFrame().
1100         https://bugs.webkit.org/show_bug.cgi?id=77161
1101
1102         Reviewed by Anders Carlsson.
1103
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1105         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1106         (TestWebKitAPI):
1107         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1108         (TestWebKitAPI::setInjectedBundleClient):
1109         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1110         Make sure the check is successful.
1111         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1112         (TestWebKitAPI):
1113         (ParentFrameTest):
1114         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1115         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1116         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1117         to the test controller.
1118         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1119
1120 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
1121
1122         [Gtk] DumpRenderTree lacks --no-timeout command line option
1123         https://bugs.webkit.org/show_bug.cgi?id=77196
1124
1125         Reviewed by Martin Robinson.
1126
1127         Add the --no-timeout command line option and reorganize
1128         watchdog code to make running DumpRenderTree without
1129         timeout possible.
1130
1131         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1132         (setWaitToDumpWatchdog):
1133         (shouldSetWaitToDumpWatchdog):
1134         (initializeGlobalsFromCommandLineOptions):
1135         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1136         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1137         (waitToDumpWatchdogFired):
1138         (LayoutTestController::setWaitToDump):
1139
1140 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
1141
1142         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1143         https://bugs.webkit.org/show_bug.cgi?id=77122
1144
1145         Reviewed by Kenneth Rohde Christiansen.
1146
1147         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1148         (MiniBrowserApplication::MiniBrowserApplication):
1149
1150 2012-01-27  Zeno Albisser  <zeno@webkit.org>
1151
1152         [Qt][Mac] Build fails after adding ICU support (r105997).
1153         https://bugs.webkit.org/show_bug.cgi?id=77118
1154
1155         Define WTF_USE_ICU_UNICODE if we are on mac.
1156
1157         Reviewed by Tor Arne Vestbø.
1158
1159         * qmake/mkspecs/features/features.prf:
1160
1161 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
1162
1163         Update committers.py with new contributors.
1164         https://bugs.webkit.org/show_bug.cgi?id=77207
1165
1166         I added six new contributors into committers.py:
1167
1168         - Adam Kallai
1169         - Balazs Ankes
1170         - Janos Badics
1171         - Nandor Huszka
1172         - Roland Takacs
1173         - Szilard Ledan-Muntean
1174
1175         * Scripts/webkitpy/common/config/committers.py:
1176
1177 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1178
1179         Add Vsevolod Vlasov to reviewers list.
1180
1181         Reviewed by Pavel Feldman.
1182
1183         * Scripts/webkitpy/common/config/committers.py:
1184
1185 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1186
1187         [Qt] WKTR: Use a software rendering pipiline when running tests.
1188         https://bugs.webkit.org/show_bug.cgi?id=76708
1189
1190         Reviewed by Kenneth Rohde Christiansen.
1191
1192         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1193         (WTR::WrapperWindow::WrapperWindow):
1194         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1195
1196 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1197
1198         [wx] Unreviewed. Build fix, add WebCore/testing/js
1199         to the list of source directories we build.
1200
1201         * waf/build/settings.py:
1202
1203 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1204
1205         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1206         https://bugs.webkit.org/show_bug.cgi?id=77177
1207
1208         Reviewed by Jon Honeycutt.
1209
1210         * Scripts/commit-log-editor:
1211
1212 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1213
1214         Decrease sleep time when killing server_process on Mac.
1215         https://bugs.webkit.org/show_bug.cgi?id=77169
1216
1217         Reviewed by Eric Seidel.
1218
1219         This shaves another ~70ms off single test runtime.
1220
1221         * Scripts/webkitpy/layout_tests/port/server_process.py:
1222         (ServerProcess.stop):
1223
1224 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1225
1226         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1227         https://bugs.webkit.org/show_bug.cgi?id=77164
1228
1229         Reviewed by Dirk Pranke.
1230
1231         http://trac.webkit.org/changeset/106035 depends on builder_name being
1232         falsey by default. There's other code that requires it to be iterable
1233         by default. So, make it be the empty string.
1234
1235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1236         (parse_args):
1237
1238 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1239
1240         run-perf-test should include relative file paths in test names
1241         https://bugs.webkit.org/show_bug.cgi?id=77144
1242
1243         Reviewed by Adam Birth.
1244
1245         Include all directory names in the test name separated by "/".
1246         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1247
1248         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1249         (PerfTestsRunner):
1250         (PerfTestsRunner._process_parser_test_result):
1251         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1252         (test_run_test_set_with_json_output):
1253         (test_run_test_set_with_json_source):
1254
1255 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1256
1257         webkitpy: re-land cleanup of test scaffolding
1258         https://bugs.webkit.org/show_bug.cgi?id=77153
1259
1260         Reviewed by Eric Seidel.
1261
1262         This is an attempt to reland the change in bug 76973 / 
1263         r105935. My earlier attempt to manipulate PYTHONPATH
1264         seems to only work some of the time, for reasons that
1265         elude me. Directly adding Tools/Scripts to sys.path from
1266         inside the test script appears to work (more?) reliably.
1267
1268         Also, it seemed like the files didn't actually get deleted
1269         the last time; I don't know why.
1270
1271         * Scripts/test-webkitpy:
1272         * Scripts/webkitpy/common/system/executive_unittest.py:
1273         (command_line):
1274         (ExecutiveTest):
1275         (ExecutiveTest.test_run_command_args_type):
1276         (ExecutiveTest.test_run_command_with_unicode):
1277         (ExecutiveTest.test_running_pids):
1278         (main):
1279         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1280         * Scripts/webkitpy/test/cat.py: Removed.
1281         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1282         * Scripts/webkitpy/test/echo.py: Removed.
1283         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1284
1285 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1286
1287         run-webkit-tests calls "nm" when it doesn't need to
1288         https://bugs.webkit.org/show_bug.cgi?id=77143
1289
1290         Reviewed by Dirk Pranke.
1291
1292         If we are not running any test that can be skipped by checking
1293         the DRT feature list or looking at the list of symbols, avoid calling
1294         out to DRT or calling "nm".
1295
1296         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1297         to "nm" it's only a couple ms slower.
1298
1299         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1300         (TestExpectations.__init__):
1301         * Scripts/webkitpy/layout_tests/port/base.py:
1302         (Port.skipped_tests):
1303         * Scripts/webkitpy/layout_tests/port/webkit.py:
1304         (WebKitPort._should_check_for_missing_features):
1305         (WebKitPort):
1306         (WebKitPort._should_check_for_missing_symbols):
1307         (WebKitPort._skipped_tests_for_unsupported_features):
1308         (WebKitPort.skipped_layout_tests):
1309         (WebKitPort.skipped_tests):
1310         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1311         (WebKitPortTest.test_skipped_directories_for_symbols):
1312         (test_skipped_directories_for_features):
1313         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1314         (test_skipped_layout_tests):
1315
1316 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1317
1318         Support a suffix on ChangeLog filenames based on a configuration file
1319         https://bugs.webkit.org/show_bug.cgi?id=76956
1320
1321         Reviewed by Kentaro Hara.
1322
1323         Modify the tools used to generate, edit and resolve ChangeLogs to support
1324         the addition of a suffix to the ChangeLog filename.
1325
1326         This patch makes it easier to support alternate ChangeLog files in branches.
1327
1328         * Scripts/VCSUtils.pm:
1329         (changeLogSuffix):
1330         (changeLogFileName):
1331         * Scripts/commit-log-editor:
1332         * Scripts/prepare-ChangeLog:
1333         (getLatestChangeLogs):
1334         (generateNewChangeLogs):
1335         (generateFileList):
1336         * Scripts/resolve-ChangeLogs:
1337         (findChangeLog):
1338
1339 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1340
1341         Unreviewed, rolling out r106038.
1342         http://trac.webkit.org/changeset/106038
1343         https://bugs.webkit.org/show_bug.cgi?id=77142
1344
1345         Caused a bunch of skipped tests to not be skipped. (Requested
1346         by ojan on #webkit).
1347
1348         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1349         (TestExpectationParser):
1350         (TestExpectationParser.parse):
1351         (TestExpectationParser._parse_line):
1352         (TestExpectationParser._collect_matching_tests):
1353         (TestExpectations.__init__):
1354         (TestExpectations._add_skipped_tests):
1355         * Scripts/webkitpy/layout_tests/port/base.py:
1356         (Port.test_dirs):
1357         (Port.normalize_test_name):
1358         (Port.update_baseline):
1359         (Port.layout_tests_dir):
1360         (Port.relative_perf_test_filename):
1361         (Port.abspath_for_test):
1362
1363 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1364
1365         Parsing test_expecations.txt + Skipped lists takes too long
1366         https://bugs.webkit.org/show_bug.cgi?id=77059
1367
1368         Reviewed by Dirk Pranke.
1369
1370         This saves ~100ms on the Apple Mac port.
1371         -memoize a bunch of path methods.
1372         -Avoid doing multiple disk accesses per line.
1373         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1374         formatting string and parsing that.
1375
1376         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1377         (TestExpectationParser):
1378         (TestExpectationParser.parse_skipped_tests):
1379         (TestExpectationParser._parse_line):
1380         (TestExpectationParser._collect_matching_tests):
1381         (TestExpectations.__init__):
1382         (TestExpectations._add_skipped_tests):
1383         * Scripts/webkitpy/layout_tests/port/base.py:
1384         (Port):
1385         (Port.test_isfile):
1386         (Port.normalize_test_name):
1387         (Port.layout_tests_dir):
1388         (Port.abspath_for_test):
1389
1390 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1391
1392         Only store the SVN revision in the summarized results if we're on a builder
1393         https://bugs.webkit.org/show_bug.cgi?id=76976
1394
1395         Reviewed by Dirk Pranke.
1396
1397         This shaves another ~130ms off the single test run-webkit-tests runtime.
1398
1399         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1400         (summarize_results):
1401         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1402         (ResultSummaryTest.get_result):
1403         (ResultSummaryTest):
1404         (ResultSummaryTest.get_result_summary):
1405         (ResultSummaryTest.get_unexpected_results):
1406         (ResultSummaryTest.test_no_svn_revision):
1407         (ResultSummaryTest.test_svn_revision):
1408         * Scripts/webkitpy/layout_tests/port/base.py:
1409         (Port.use_trac_links_in_results_html):
1410
1411 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1412
1413         [Qt][WK2] fast/loader tests failed after r94178
1414         https://bugs.webkit.org/show_bug.cgi?id=67388
1415
1416         Reviewed by Simon Hausmann.
1417
1418         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1419         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1420         https://bugs.webkit.org/show_bug.cgi?id=67254
1421         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1422         derived from the running location of DumpRenderTree binary.
1423
1424         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1425         (WTR::LayoutTestController::pathToLocalResource):
1426
1427 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1428
1429         Implement overridePreference for boolean preferences in WebKitTestRunner
1430         https://bugs.webkit.org/show_bug.cgi?id=77033
1431
1432         Reviewed by Alexey Proskuryakov.
1433
1434         For now overridePreference supports boolean values.
1435
1436         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1437         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1438         (WTR::LayoutTestController::setXSSAuditorEnabled):
1439         (WTR::LayoutTestController::overridePreference):
1440         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1441         * WebKitTestRunner/TestController.cpp:
1442         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1443         explicitly and properly disable the use of PageCache when resetting the
1444         state. Tests that use PageCache can now enable it via overridePreference.
1445
1446 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1447
1448         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1449         https://bugs.webkit.org/show_bug.cgi?id=77100
1450
1451         Reviewed by Simon Hausmann.
1452
1453         This patch makes the MiniBrowser read multiple URL's from the command
1454         line such that there will be one browser window opened for each URL.
1455
1456         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1457         (MiniBrowserApplication::handleUserOptions):
1458
1459 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1460
1461         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1462         https://bugs.webkit.org/show_bug.cgi?id=77009
1463
1464         Reviewed by Simon Hausmann.
1465
1466         This patch fixes a crash in BrowserWindow::newWindow() where a
1467         BrowserWindow-object is constructed with a 0 pointer as the
1468         WindowOptions parameter which leads to a crash.
1469
1470         * MiniBrowser/qt/BrowserWindow.cpp:
1471         (BrowserWindow::BrowserWindow):
1472         (BrowserWindow::newWindow):
1473         * MiniBrowser/qt/BrowserWindow.h:
1474
1475 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1476
1477         [Qt] Use ICU if available
1478         https://bugs.webkit.org/show_bug.cgi?id=76821
1479
1480         Reviewed by Simon Hausmann.
1481
1482         Adding unicode defines for a Qt 5 based build.
1483
1484         * qmake/mkspecs/features/features.prf:
1485
1486 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1487
1488         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1489         https://bugs.webkit.org/show_bug.cgi?id=42545
1490
1491         Reviewed by Zoltan Herczeg.
1492
1493         Implement the setGeolocationPermission method.
1494
1495         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1496         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1497         (WTR::LayoutTestController::setGeolocationPermission):
1498         (WTR):
1499         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1500         (LayoutTestController):
1501
1502 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1503
1504         [NRWT] Support --ignore-metrics
1505         https://bugs.webkit.org/show_bug.cgi?id=76278
1506
1507         Reviewed by Tony Chang.
1508
1509         Port the feature from ORWT.
1510
1511         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1512         (SingleTestRunner._run_compare_test):
1513         * Scripts/webkitpy/layout_tests/port/driver.py:
1514         (DriverOutput):
1515         (DriverOutput.strip_metrics):
1516         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1517         (DriverOutputTest):
1518         (DriverOutputTest.test_strip_metrics):
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1520         (_set_up_derived_options):
1521         (parse_args):
1522
1523 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1524
1525         Unreviewed, rolling out r105935 and r105954.
1526         http://trac.webkit.org/changeset/105935
1527         http://trac.webkit.org/changeset/105954
1528         https://bugs.webkit.org/show_bug.cgi?id=77080
1529
1530         test-webkitpy is still broken (Requested by abarth on
1531         #webkit).
1532
1533         * Scripts/test-webkitpy:
1534         * Scripts/webkitpy/common/system/executive_unittest.py:
1535         (never_ending_command):
1536         (ExecutiveTest.test_run_command_args_type):
1537         (ExecutiveTest.test_run_command_with_unicode):
1538         (ExecutiveTest.test_running_pids):
1539         * Scripts/webkitpy/common/system/fileutils.py:
1540         (make_stdout_binary):
1541         * Scripts/webkitpy/test/cat.py:
1542         (command_arguments):
1543         (main):
1544         * Scripts/webkitpy/test/cat_unittest.py:
1545         (CatTest):
1546         (CatTest.assert_cat):
1547         (CatTest.test_basic):
1548         (CatTest.test_no_newline):
1549         (CatTest.test_unicode):
1550         (CatTest.test_as_command):
1551         * Scripts/webkitpy/test/echo.py:
1552         (command_arguments):
1553         (main):
1554         * Scripts/webkitpy/test/echo_unittest.py:
1555         (EchoTest):
1556         (EchoTest.test_basic):
1557         (EchoTest.test_no_newline):
1558         (EchoTest.test_unicode):
1559         (EchoTest.test_argument_order):
1560         (EchoTest.test_empty_arguments):
1561         (EchoTest.test_no_arguments):
1562         (EchoTest.test_as_command):
1563
1564 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1565
1566         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1567         https://bugs.webkit.org/show_bug.cgi?id=76138
1568
1569         Reviewed by Martin Robinson.
1570
1571         * Scripts/webkitdirs.pm:
1572         (isCrossCompilation):
1573         (buildAutotoolsProject):
1574
1575 2012-01-25  Adam Barth  <abarth@webkit.org>
1576
1577         Kentaro is a reviewer now.  Yay!
1578
1579         * Scripts/webkitpy/common/config/committers.py:
1580
1581 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1582
1583         nrwt: running w/ no arguments fails
1584         https://bugs.webkit.org/show_bug.cgi?id=77064
1585
1586         Unreviewed, build fix.
1587
1588         This change fixes a regression introduced in r105944
1589         where running without --platform <foo> or one of the other
1590         platform switches would cause a null deref :(.
1591
1592         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1593         (main):
1594
1595 2012-01-25  Eric Seidel  <eric@webkit.org>
1596
1597         Automatically CC someone from Apple on any changes to Obj-C public API
1598         https://bugs.webkit.org/show_bug.cgi?id=77053
1599
1600         Reviewed by Timothy Hatcher.
1601
1602         This has long been de-facto practice, seems now that we have
1603         fancy watchlist support, we should just make the tools
1604         do this automatically.
1605
1606         * Scripts/webkitpy/common/config/watchlist:
1607
1608 2012-01-25  Antoine Labour  <piman@chromium.org>
1609
1610         Updating status in committers.py.
1611
1612         Unreviewed.
1613
1614         * Scripts/webkitpy/common/config/committers.py:
1615
1616 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1617
1618         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1619         https://bugs.webkit.org/show_bug.cgi?id=77058
1620
1621         Reviewed by Eric Seidel.
1622
1623         r105935 broke executive_unittest by changing which script we
1624         were running and not ensuring that the PYTHONPATH was set up
1625         properly.
1626
1627         This change also fixes a regression introduced recently where
1628         test-webkitpy wasn't figuring out the path to Tools/Scripts
1629         right, either (so running ./test-webkitpy would fail).
1630
1631         * Scripts/test-webkitpy:
1632         * Scripts/webkitpy/common/system/executive_unittest.py:
1633         (script_dir):
1634         (ExecutiveTest.setUp):
1635         (ExecutiveTest):
1636         (ExecutiveTest.tearDown):
1637
1638 2012-01-25  Adam Barth  <abarth@webkit.org>
1639
1640         Disable tests on the mac-ews while we sort out hte stability issues.
1641
1642         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1643         (MacEWS):
1644
1645 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1646
1647         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1648         https://bugs.webkit.org/show_bug.cgi?id=76475
1649
1650         Reviewed by Eric Seidel.
1651
1652         This patch cleans up the internal usage of port names for the
1653         Apple mac and Apple win ports so that 'mac' and 'win are never
1654         considered "fully specified" port names: they are still legal
1655         input to the PortFactory.get() routine, but only if run on the given
1656         platform (i.e. trying to PortFactory.get('mac') on windows or
1657         linux will return an error, since we don't know which version of
1658         the port is desired.
1659
1660         This also cleans up handling of the webkit2 variants, so that
1661         the full port names consistently follow the
1662         <operating_system>-<version>[-<wk2>] convention.
1663
1664         Lastly this patch adds some assertions and removes some
1665         try/catch logic to catch more programming and usage errors;
1666         previously mac-tiger might've been allowed -- and it would've
1667         translated into using just the baselines in platform/mac -- but
1668         now it should fail.
1669
1670         * Scripts/webkitpy/layout_tests/port/apple.py:
1671         (ApplePort.determine_full_port_name):
1672         (ApplePort.__init__):
1673         (ApplePort):
1674         (ApplePort._port_name_with_version):
1675         * Scripts/webkitpy/layout_tests/port/builders.py:
1676         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1677         (FactoryTest.test_mac):
1678         (FactoryTest.test_win):
1679         * Scripts/webkitpy/layout_tests/port/mac.py:
1680         (MacPort.baseline_search_path):
1681         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1682         (MacTest.test_versions):
1683         * Scripts/webkitpy/layout_tests/port/win.py:
1684         (WinPort.baseline_search_path):
1685         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1686         (WinTest.test_versions):
1687
1688 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1689
1690         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1691         https://bugs.webkit.org/show_bug.cgi?id=76955
1692
1693         Reviewed by Adam Barth.
1694
1695         This change cleans up the errors that are printed so that the
1696         are more "quickfix" compatible (path:lineno).
1697
1698         Also, there were a bunch of redundant tests between
1699         layout_tests.models.test_expectations_unittest and
1700         style.checkers.test_expectations_unittest. The latter should
1701         just expect the former to do most of the testing.
1702
1703         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1704         (TestExpectationParser._parse_modifiers):
1705         (TestExpectations._report_errors):
1706         (TestExpectations._add_skipped_tests):
1707         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1708         (test_parse_error_nonfatal):
1709         (SemanticTests.test_bad_bugid):
1710         * Scripts/webkitpy/style/checkers/test_expectations.py:
1711         (TestExpectationsChecker.__init__):
1712         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1713         (TestExpectationsTestCase.assert_lines_lint):
1714         (TestExpectationsTestCase.test_valid_expectations):
1715         (TestExpectationsTestCase.test_invalid_expectations):
1716         (TestExpectationsTestCase.test_tab):
1717
1718 2012-01-25  Eric Seidel  <eric@webkit.org>
1719
1720         webkit-patch apply-* should always continue after failures
1721         https://bugs.webkit.org/show_bug.cgi?id=77057
1722
1723         Reviewed by Adam Barth.
1724
1725         As far as I can tell there is only one potential drawback to always
1726         forcing: that if you're somehow in the wrong directory it will create new
1727         directories for new files.  Since webkit-patch always cd's to the root
1728         it seems that's not a drawback.  The drawback of not using --force for
1729         svn-apply, is that it will stop after the first failure, which is rarely
1730         (if ever) the desired behavior.  This just removes the force option
1731         (which was strangely hidden behind --non-interactive).  This should
1732         make for a better user experiance.
1733
1734         * Scripts/webkitpy/common/checkout/checkout.py:
1735         (Checkout.apply_patch):
1736         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1737         (MockCheckout.apply_patch):
1738         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1739         (CheckoutTest.test_chromium_deps):
1740         (CheckoutTest):
1741         (CheckoutTest.test_apply_patch):
1742         * Scripts/webkitpy/tool/commands/download_unittest.py:
1743         (DownloadCommandsTest._default_options):
1744         * Scripts/webkitpy/tool/steps/applypatch.py:
1745         (ApplyPatch.options):
1746         (ApplyPatch.run):
1747         * Scripts/webkitpy/tool/steps/options.py:
1748         (Options):
1749
1750 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1751
1752         nrwt: should be able to run --platform test interactively
1753         https://bugs.webkit.org/show_bug.cgi?id=76959
1754
1755         Reviewed by Adam Barth.
1756
1757         As part of refactoring the Port interfaces, in r103254 I made
1758         passing a Host object to the Port mandatory; previously TestPort
1759         objects would create their own (mock) hosts. However,
1760         new-run-webkit-tests always passed a real Host, not a MockHost,
1761         and so you couldn't run new-run-webkit-tests --platform test
1762         interactively to debug test failures.
1763
1764         This change fixes that by creating a MockHost instead of a real
1765         host if you say --platform test*.
1766
1767         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1768         (main):
1769
1770 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1771
1772         run-webkit-tests --lint-test-files should lint all the ports by default
1773         https://bugs.webkit.org/show_bug.cgi?id=76749
1774
1775         Reviewed by Ojan Vafai.
1776
1777         Currently run-webkit-tests --lint-test-files will only lint the
1778         test_expectations for the single port determined by the command
1779         line options. This is not obvious and can produce unintended results
1780         if you want to lint the chromium port (probably the normal case
1781         for using --lint-test-files) but don't specify a port name or
1782         --chromium.
1783
1784         I think we should probably lint *all* of the ports if no port
1785         name is supplied. This change implements that, and also moves
1786         the linting logic out of the Manager class, since this really
1787         has nothing to do with Managers. It has little to do with
1788         run-webkit-tests, but splitting it into a different script would
1789         introduce compatibility issues. It might make sense to do that
1790         anyway, in a separate patch and combining that with cleaning up
1791         the style checker to share more code.
1792
1793         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1794         (Manager._strip_test_dir_prefix):
1795         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1796         (lint):
1797         (run):
1798         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1799         (LintTest.test_all_configurations): added.
1800         (LintTest.test_lint_test_files): added.
1801         (LintTest.test_lint_test_files__errors): added.
1802         (MainTest.test_lint_test_files): removed.
1803         (MainTest.test_lint_test_files__errors): removed.
1804
1805 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1806
1807         webkitpy: clean up a bunch of test scaffolding
1808         https://bugs.webkit.org/show_bug.cgi?id=76973
1809
1810         Reviewed by Eric Seidel.
1811
1812         There were several helper modules in the webkitpy.test package
1813         that appear to only be used by executive_unittest.py. I am
1814         rolling them all into that file to make that clearer.
1815
1816         * Scripts/webkitpy/common/system/executive_unittest.py:
1817         (ExecutiveTest.test_run_command_args_type):
1818         (ExecutiveTest.test_run_command_with_unicode):
1819         (ExecutiveTest.test_running_pids):
1820         (command_line):
1821         (main):
1822         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1823         * Scripts/webkitpy/test/cat.py: Removed.
1824         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1825         * Scripts/webkitpy/test/echo.py: Removed.
1826         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1827
1828 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1829
1830         webkitpy: clean up a bunch of test scaffolding
1831         https://bugs.webkit.org/show_bug.cgi?id=76973
1832
1833         Reviewed by Eric Seidel.
1834
1835         There were several helper modules in the webkitpy.test package
1836         that appear to only be used by executive_unittest.py. I am
1837         rolling them all into that file to make that clearer.
1838
1839         * Scripts/webkitpy/common/system/executive_unittest.py:
1840         (ExecutiveTest.test_run_command_args_type):
1841         (ExecutiveTest.test_run_command_with_unicode):
1842         (ExecutiveTest.test_running_pids):
1843         (command_line):
1844         (main):
1845         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1846         * Scripts/webkitpy/test/cat.py: Removed.
1847         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1848         * Scripts/webkitpy/test/echo.py: Removed.
1849         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1850
1851 2012-01-25  Eric Seidel  <eric@webkit.org>
1852
1853         Remove Python 2.5 support from WebKit
1854         https://bugs.webkit.org/show_bug.cgi?id=71593
1855
1856         Reviewed by Adam Barth.
1857
1858         Just removing support from this one core file.
1859         I'll commit the rest of the (large) change once we've
1860         gone 24 hours and seen that no bots have exploded.
1861         We can roll out this one change if we break bots
1862         and then roll in the rest once those bots are fixed.
1863
1864         * Scripts/webkitpy/common/system/executive.py:
1865         (Executive.cpu_count):
1866
1867 2012-01-25  Hajime Morita  <morrita@google.com>
1868
1869         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1870         https://bugs.webkit.org/show_bug.cgi?id=76863
1871
1872         Reviewed by Dimitri Glazkov.
1873
1874         Added a feature flag.
1875
1876         * Scripts/build-webkit:
1877         * qmake/mkspecs/features/features.prf:
1878
1879 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1880
1881         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1882         https://bugs.webkit.org/show_bug.cgi?id=76344
1883
1884         Reviewed by Sam Weinig.
1885
1886         Add a test verifying that the mouse button during policy decisions for
1887         events not triggered by mouse events is NoButton.
1888
1889         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1890         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1891         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1892
1893 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1894
1895         run-perf-tests should timeout sooner
1896         https://bugs.webkit.org/show_bug.cgi?id=77026
1897
1898         Reviewed by Adam Barth.
1899
1900         Bump off the timeout from 10 minutes to 4 minutes.
1901
1902         Also use float instead of str in test result values to compress the size of json files bots upload.
1903
1904         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1905         (PerfTestsRunner._parse_args):
1906         (PerfTestsRunner._process_chromium_style_test_result):
1907         (PerfTestsRunner._process_parser_test_result):
1908         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1909         (test_run_test_set_for_parser_tests):
1910         (test_run_test_set_with_json_output):
1911         (test_run_test_set_with_json_source):
1912
1913 2012-01-25  Enrica Casucci  <enrica@apple.com>
1914
1915         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1916         https://bugs.webkit.org/show_bug.cgi?id=76951
1917         <rdar://problem/9325158>
1918
1919         Reviewed by Alexey Proskuryakov.
1920
1921         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
1922         and WebHTMLView.
1923         (TestWebKitAPI::TEST):
1924
1925 2012-01-23  MORITA Hajime  <morrita@google.com>
1926
1927         [Refactoring][Internals] Should have InternalSettings
1928         https://bugs.webkit.org/show_bug.cgi?id=76424
1929
1930         Reviewed by Kent Tamura.
1931
1932         * GNUmakefile.am: Added so new files.
1933
1934 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
1935
1936         webkitpy: new-run-webkit-websocket is broken
1937         https://bugs.webkit.org/show_bug.cgi?id=76999
1938
1939         Reviewed by Dirk Pranke.
1940
1941         r105674 broke new-run-webkit-websocket, since options.chromium
1942         doesn't exist any more. new-run-webkit-httpd was also broken
1943         and already fixed at r105835.
1944         * Scripts/new-run-webkit-websocketserver:
1945         (main):
1946
1947 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1948
1949         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
1950         https://bugs.webkit.org/show_bug.cgi?id=63458
1951
1952         Reviewed by Adam Roben.
1953
1954         Implement the setPopupBlockingEnabled method.
1955
1956         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1957         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1958         (WTR::LayoutTestController::setPopupBlockingEnabled):
1959         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1960
1961 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
1962
1963         [Qt] Cleanup testfonts handling
1964         https://bugs.webkit.org/show_bug.cgi?id=76068
1965
1966         Reviewed by Simon Hausmann.
1967
1968         Factor test font initialization into it's own file  so test
1969         font users can share the implementation by adding the file
1970         to their build.
1971         Use fonts.conf from the test font directory to not require the
1972         current directory to be the WebKit root.
1973         Fix the -use-test-fonts option of QtTestBrowser by initializing
1974         the fonts earlier, before it is too late (namely before calling
1975         show on the main window).
1976
1977         * DumpRenderTree/qt/DumpRenderTree.pro:
1978         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1979         (WebCore::DumpRenderTree::open):
1980         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1981         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
1982         (WebKit::initializeTestFonts):
1983         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
1984         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
1985         we will use the one from the test fonts directory.
1986         * DumpRenderTree/qt/main.cpp:
1987         (main): Fix the ifdefs to make it clear that the code to
1988         set up the Dpi has not been ported to Qt5 yet.
1989         * QtTestBrowser/QtTestBrowser.pro:
1990         * QtTestBrowser/launcherwindow.h:
1991         (WindowOptions::WindowOptions):
1992         * QtTestBrowser/main.cpp:
1993         (launcherMain):
1994         (LauncherApplication::handleUserOptions):
1995         * WebKitTestRunner/InjectedBundle/Target.pri:
1996         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1997         (WTR::activateFonts): Remove the code to set up the Dpi
1998         because it does not work with Qt5.
1999
2000 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
2001
2002         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
2003
2004         Reviewed by Tor Arne Vestø.
2005
2006         Don't require it by making svnRevisionForDirectory return "unknown"
2007         instead of bailing out with an error.
2008
2009         * Scripts/VCSUtils.pm:
2010         (svnRevisionForDirectory):
2011
2012 2012-01-25  Adam Barth  <abarth@webkit.org>
2013
2014         Temporarily disable running the unit tests on the Chromium EWS.  These
2015         tests don't work properly (see
2016         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2017         blocking the EWS.
2018
2019         * Scripts/webkitpy/common/config/ports.py:
2020         (ChromiumPort):
2021
2022 2012-01-25  Adam Barth  <abarth@webkit.org>
2023
2024         Update results.html version of PixelZoomer
2025         https://bugs.webkit.org/show_bug.cgi?id=76965
2026
2027         Reviewed by Ojan Vafai.
2028
2029         Improve readability as suggested by Ojan.
2030
2031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2032
2033 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2034
2035         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2036         https://bugs.webkit.org/show_bug.cgi?id=76899
2037
2038         Reviewed by Martin Robinson.
2039
2040         * gtk/generate-gtkdoc:
2041         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2042         WebKitLoaderClient.
2043
2044 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2045
2046         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/config.json:
2049
2050 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2051
2052         WebKit needs public performance tests running on public bots
2053         https://bugs.webkit.org/show_bug.cgi?id=10266
2054
2055         Reviewed by Adam Barth.
2056
2057         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2058         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/config.json:
2061         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2062         (RunAndUploadPerfTests):
2063         (RunAndUploadPerfTests.start):
2064         (UploadPerfTestResults):
2065         (BuildAndPerfTestFactory):
2066         (BuildAndPerfTestFactory.__init__):
2067
2068 2012-01-24  Ojan Vafai  <ojan@chromium.org>
2069
2070         Initializing the browser property of the Bugzilla class takes too long
2071         https://bugs.webkit.org/show_bug.cgi?id=76960
2072
2073         Reviewed by Adam Barth.
2074
2075         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2076         on my Mac Pro.
2077
2078         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2079         (Bugzilla.__init__):
2080         (Bugzilla._get_browser):
2081         (Bugzilla):
2082         (Bugzilla._set_browser):
2083
2084 2012-01-24  Mark Rowe  <mrowe@apple.com>
2085
2086         Death to JavaScriptGlue.
2087
2088         Rubber-stamped by Geoffrey Garen.
2089
2090         * BuildSlaveSupport/build-launcher-app:
2091         (copyNightlyLauncher):
2092         * Scripts/build-webkit:
2093         * Scripts/do-file-rename:
2094         * Scripts/do-webcore-rename:
2095         * Scripts/webkitpy/common/config/build.py:
2096         (_should_file_trigger_build):
2097         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2098         path in conjunction with a cross-platform path.
2099         (ShouldBuildTest):
2100
2101 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2102
2103         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2104         https://bugs.webkit.org/show_bug.cgi?id=75836
2105
2106         Reviewed by David Kilzer.
2107
2108         Previously parser_unittests.pl can just test the returned value of
2109         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2110         parser_unittests.pl so that it also tests the stdout and stderr of
2111         get_function_line_ranges().
2112
2113         This patch adds css_unittests_warning.css, which contains test cases
2114         for warning messages of the CSS parser of prepare-ChangeLog.
2115
2116         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2117         (captureOutput): Captures the stdout and stderr of a given method.
2118         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2119         string to relative paths.
2120
2121         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2122         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2123         (element1):
2124         (element2):
2125         (element3):
2126         (element4):
2127         ():
2128         (element5):
2129         (element6):
2130
2131         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2132         Just updated the test results, i.e. added stdout and stderr results.
2133         No essential changes in the test results.
2134         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2135         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2136         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2137         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2138         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2139
2140 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2141
2142         webkitpy: new-run-webkit-httpd is broken
2143         https://bugs.webkit.org/show_bug.cgi?id=76963
2144
2145         Reviewed by Adam Barth.
2146
2147         r105674 broke new-run-webkit-httpd, since options.chromium
2148         doesn't exist any more. We didn't catch this because we don't
2149         run the integration tests by default anywhere :(.
2150
2151         * Scripts/new-run-webkit-httpd:
2152         (run):
2153         (main):
2154
2155 2012-01-24  Adam Barth  <abarth@webkit.org>
2156
2157         garden-o-matic pixel zoomer should let you look at every pixel of the image
2158         https://bugs.webkit.org/show_bug.cgi?id=76962
2159
2160         Reviewed by Ojan Vafai.
2161
2162         Previously, you couldn't get up to the right and bottom pixels.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2165
2166 2012-01-24  Enrica Casucci  <enrica@apple.com>
2167
2168         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2169         https://bugs.webkit.org/show_bug.cgi?id=76951
2170         <rdar://problem/9325158>
2171
2172         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2173         works as expected.
2174         
2175         Reviewed by Alexey Proskuryakov.
2176
2177         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2178         (TestWebKitAPI::TEST):
2179
2180 2012-01-24  James Robinson  <jamesr@chromium.org>
2181
2182         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2183         https://bugs.webkit.org/show_bug.cgi?id=76884
2184
2185         Reviewed by Adam Barth.
2186
2187         * Scripts/webkitpy/tool/bot/irc_command.py:
2188         (Rollout.execute):
2189         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2190         (SheriffIRCBotTest.test_rollout):
2191         (SheriffIRCBotTest.test_revert):
2192         (SheriffIRCBotTest.test_multi_rollout):
2193         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2194         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2195         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2196         (test_multi_rollout_invalidate_reason):
2197
2198 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2199
2200         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2201         https://bugs.webkit.org/show_bug.cgi?id=75531
2202
2203         Reviewed by David Kilzer.
2204
2205         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2206         outside methods. Consider the following cpp file.
2207
2208             namespace N {
2209             int a;     // this change does not appear on ChangeLog.
2210             class C {
2211                 int b;     // this change does not appear on ChangeLog.
2212                 void f()
2213                 {
2214                     int c;     // this change appears on ChangeLog.
2215                 }
2216                 int d;     // this change does not appear on ChangeLog.
2217             };
2218             int e;     // this change does not appear on ChangeLog.
2219             };
2220
2221         The previous prepare-ChangeLog outputs just methods in which a change is found:
2222             (N::C::f):
2223
2224         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2225         and methods in which a change is found:
2226             (N):
2227             (N::C):
2228             (N::C::f):
2229
2230         * Scripts/prepare-ChangeLog:
2231         (get_function_line_ranges_for_cpp): Modified as described above.
2232
2233         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2234         (Class104):
2235         (Class105):
2236         (Class106):
2237         (Class106::func32):
2238         (Class106::func33):
2239         (NameSpace3):
2240         (NameSpace4):
2241         (NameSpace5):
2242         (NameSpace6):
2243         (Class107):
2244         (NameSpace5::NameSpace6::Class107::func34):
2245         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2246
2247 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2248
2249         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2250         https://bugs.webkit.org/show_bug.cgi?id=75943
2251
2252         Reviewed by David Kilzer.
2253
2254         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2255         because it does not distinguish '}' at the end of a subroutine
2256         with '}' at the end of a if or for statement.
2257
2258         foo.pl:
2259             if (1) {
2260             }
2261             for (@v) {
2262             }
2263
2264         output:
2265             nested functions found at top-level at foo.pl:2
2266             nested functions found at top-level at foo.pl:4
2267
2268         This patch fixes the bug.
2269
2270         * Scripts/prepare-ChangeLog:
2271         (get_function_line_ranges_for_perl):
2272         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2273         Added test cases. No change in the test results.
2274
2275 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2276
2277         r105674 broke check-webkit-style for chromium's test_expectations.
2278
2279         Unreviewed, build fix.
2280         
2281         We now need to pass in a platform name of 'chromium' if we want
2282         the chromium port; options.chromium is no longer recognized. I
2283         will follow this patch up with a separate patch that has a test,
2284         but this at least fixes the build.
2285
2286         * Scripts/webkitpy/style/checkers/test_expectations.py:
2287         (TestExpectationsChecker._determine_port_from_exepectations_path):
2288
2289 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2290
2291         check-webkit-style of the chromium test_expectations.txt file takes too long
2292         https://bugs.webkit.org/show_bug.cgi?id=76745
2293
2294         Reviewed by Dimitri Glazkov.
2295
2296         When in lint mode, have TestExpectations test all configurations instead
2297         of looping over each configuration. This also has the benefit of making
2298         the error output considerably more concise.
2299
2300         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2301
2302         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2303         (Manager.lint):
2304         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2305         (TestExpectations._report_errors):
2306         (TestExpectations._add_expectations):
2307         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2308         (test_parse_error_nonfatal):
2309         (test_error_on_different_platform):
2310         * Scripts/webkitpy/style/checkers/test_expectations.py:
2311         (TestExpectationsChecker.check_test_expectations):
2312         (TestExpectationsChecker.check):
2313         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2314         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2315         (TestExpectationsTestCase.assert_lines_lint):
2316
2317 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2318
2319         Another build fix attempt after r105543.
2320
2321         * Scripts/webkitpy/common/net/file_uploader.py:
2322         (FileUploader.upload_as_multipart_form_data):
2323
2324 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2325
2326         Build fix attempt after r105543.
2327
2328         * Scripts/webkitpy/common/net/file_uploader.py:
2329         (FileUploader.upload_as_multipart_form_data):
2330
2331 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2332
2333         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2334         https://bugs.webkit.org/show_bug.cgi?id=76411
2335
2336         Reviewed by Adam Barth.
2337
2338         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2339         into a series of patches, this change adds a trivial
2340         pointer lock implementation to the Chromium port's DumpRenderTree
2341         and exposes LayoutTestController hooks to force failure conditions.
2342
2343         * DumpRenderTree/chromium/LayoutTestController.cpp:
2344         (LayoutTestController::LayoutTestController):
2345         (LayoutTestController::didLosePointerLock):
2346         (LayoutTestController::setPointerLockWillFailAsynchronously):
2347         (LayoutTestController::setPointerLockWillFailSynchronously):
2348         * DumpRenderTree/chromium/LayoutTestController.h:
2349         * DumpRenderTree/chromium/WebViewHost.cpp:
2350         (WebViewHost::requestPointerLock):
2351         (WebViewHost::requestPointerUnlock):
2352         (WebViewHost::isPointerLocked):
2353         (WebViewHost::didCompletePointerLock):
2354         (WebViewHost::didNotCompletePointerLock):
2355         (WebViewHost::didLosePointerLock):
2356         (WebViewHost::reset):
2357         * DumpRenderTree/chromium/WebViewHost.h:
2358         (WebViewHost::setPointerLockWillFailAsynchronously):
2359         (WebViewHost::setPointerLockWillFailSynchronously):
2360
2361 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2362
2363         Unreviewed, skip WK2 API test timing out on some GTK bots.
2364
2365         WebKit2APITests/TestDownloads is consistently timing out on the
2366         32bit release and 64bit debug bots.
2367
2368         * Scripts/run-gtk-tests:
2369         (TestRunner): Skip WebKit2APITests/TestDownloads.
2370
2371 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2372
2373         [Qt] Fix the build with the newes Qt5 hashes
2374         https://bugs.webkit.org/show_bug.cgi?id=76657
2375
2376         Reviewed by Simon Hausmann.
2377
2378         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2379         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2380         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2381
2382 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2383
2384         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2385
2386         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2387         building with MinGW inside cmd.exe will require the same construct. Instead
2388         we assume that when the first character in PWD is a '/' we're running under
2389         Cygwin, and use the normal unix way of setting environment variables.
2390
2391         Reviewed by Simon Hausmann.
2392
2393         * qmake/mkspecs/features/default_pre.prf:
2394
2395 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2396
2397         Some qmake build files must include Qt5's "quick" module.
2398         https://bugs.webkit.org/show_bug.cgi?id=76671
2399
2400         Unreviewed build fix.
2401
2402         * MiniBrowser/qt/MiniBrowser.pro:
2403         * WebKitTestRunner/Target.pri:
2404
2405 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2406
2407         [Qt] Fix the event timestamps for touch mocking
2408
2409         Reviewed by Simon Hausmann.
2410
2411         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2412         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2413         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2414
2415 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2416
2417         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2418         https://bugs.webkit.org/show_bug.cgi?id=72952
2419
2420         Reviewed by Martin Robinson.
2421
2422         * gtk/generate-gtkdoc:
2423         (get_webkit2_options): Ignore WebKitDownloadClient.
2424
2425 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2426
2427         [GTK] editing/deleting/5408255.html results are incorrect
2428         https://bugs.webkit.org/show_bug.cgi?id=53644
2429
2430         Reviewed by Martin Robinson.
2431
2432         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2433         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2434         macro. This way both tools can be run outside the test harness without
2435         the need to manually set the environment variable.
2436
2437         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2438         (getTopLevelPath):
2439         * GNUmakefile.am:
2440         * Scripts/webkitpy/layout_tests/port/gtk.py:
2441         (GtkPort.setup_environ_for_server):
2442         * WebKitTestRunner/GNUmakefile.am:
2443         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2444         (WTR::InjectedBundle::platformInitialize):
2445
2446 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2447
2448         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2449         https://bugs.webkit.org/show_bug.cgi?id=74653.
2450
2451         Reviewed by Darin Fisher.
2452
2453         * DumpRenderTree/chromium/LayoutTestController.cpp:
2454         (LayoutTestController::LayoutTestController):
2455         (LayoutTestController::workerThreadCount):
2456         * DumpRenderTree/chromium/LayoutTestController.h:
2457
2458 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2459
2460         nrwt: make --chromium work like --qt
2461         https://bugs.webkit.org/show_bug.cgi?id=76875
2462
2463         Reviewed by Adam Barth.
2464
2465         --chromium used to have to be handled differently from --qt
2466         due to the way the PortFactory was implemented; there's not
2467         really a good reason for that any more so this patch makes
2468         things slightly more consistent and eliminates the
2469         options.chromium flag (--chromium is now truly a synonym for
2470         --platform chromium).
2471
2472         * Scripts/webkitpy/layout_tests/port/factory.py:
2473         (PortFactory._default_port):
2474         (PortFactory.get):
2475         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2476         (FactoryTest.setUp):
2477         (FactoryTest.test_chromium_mac):
2478         (FactoryTest.test_chromium_linux):
2479         (FactoryTest.test_chromium_win):
2480         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2481         (parse_args):
2482
2483 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2484
2485         run-webkit-tests needs to propagate --chromium
2486         https://bugs.webkit.org/show_bug.cgi?id=76870
2487
2488         Reviewed by Eric Seidel.
2489
2490         run-webkit-tests removes '--chromium' argument from @ARGV when
2491         determining which port to run, which means that that doesn't
2492         propagate to new-run-webkit-tests. That's bad (and is handled
2493         for the other ports by re-adding the flag, but apparently we're
2494         just now noticing for Chromium).
2495
2496         * Scripts/run-webkit-tests:
2497
2498 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2499
2500         More build fixing after r105646.
2501
2502         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2503         (TestWebKitAPI::TestNode::key):
2504
2505 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2506
2507         Unreviewed build fix - r105646 broke this.
2508
2509         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2510         (TestWebKitAPI::TestNode::TestNode):
2511         (TestWebKitAPI::TestNode::key):
2512         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2513         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2514         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2515
2516 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2517
2518         Unreviewed, rolling out r105658.
2519         http://trac.webkit.org/changeset/105658
2520         https://bugs.webkit.org/show_bug.cgi?id=76883
2521
2522         We want this eventually, but not right at this moment
2523         (Requested by abarth on #webkit).
2524
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2526
2527 2012-01-23  Adam Barth  <abarth@webkit.org>
2528
2529         garden-o-matic should support Chromium Mac Lion
2530         https://bugs.webkit.org/show_bug.cgi?id=76880
2531
2532         Reviewed by Eric Seidel.
2533
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2535
2536 2012-01-23  Emil A Eklund  <eae@chromium.org>
2537
2538         check-webkit-style whitespace/operators triggers on overloaded division operator
2539         https://bugs.webkit.org/show_bug.cgi?id=76650
2540
2541         Reviewed by Darin Adler.
2542
2543         * Scripts/webkitpy/style/checkers/cpp.py:
2544         (check_spacing):
2545         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2546         (CppStyleTest.test_operator_methods):
2547
2548 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2549
2550         run-perf-tests should report server-side errors
2551         https://bugs.webkit.org/show_bug.cgi?id=76802
2552
2553         Reviewed by Tony Chang.
2554
2555         Report errors whenever server's response doesn't match "OK".
2556
2557         * Scripts/webkitpy/common/net/file_uploader.py:
2558         (FileUploader.upload_single_text_file):
2559         (FileUploader.upload_as_multipart_form_data):
2560         (FileUploader._upload_data.callback):
2561         (FileUploader):
2562         (FileUploader._upload_data):
2563         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2564         (PerfTestsRunner._upload_json):
2565         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2566         (test_upload_json):
2567         (test_upload_json.MockFileUploader.upload_single_text_file):
2568
2569 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2570
2571         run-perf-tests ignore Skipped list on chromium
2572         https://bugs.webkit.org/show_bug.cgi?id=76764
2573
2574         Reviewed by Dirk Pranke.
2575
2576         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2577         can also find skipped list. Chromium port only uses test_expectations.txt for
2578         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2579         also needs to use Skipped list.
2580
2581         * Scripts/webkitpy/layout_tests/port/base.py:
2582         (Port._tests_from_skipped_file_contents):
2583         (Port):
2584         (Port._expectations_from_skipped_files):
2585         (Port.skipped_perf_tests):
2586         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2587         (PortTest.test_skipped_perf_tests):
2588         (PortTest.test_skipped_perf_tests.add_text_file):
2589         * Scripts/webkitpy/layout_tests/port/webkit.py:
2590         (WebKitPort._skipped_tests_for_unsupported_features):
2591         (WebKitPort._skipped_file_search_paths):
2592         (WebKitPort.skipped_layout_tests):
2593
2594 2012-01-23  Andy Estes  <aestes@apple.com>
2595
2596         Fix the build after r105635.
2597
2598         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2599         (TestWebKitAPI::TEST):
2600
2601 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2602
2603         Basic enhancements to StringBuilder
2604         https://bugs.webkit.org/show_bug.cgi?id=67081
2605
2606         Reviewed by Darin Adler.
2607
2608         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2609         (TestWebKitAPI::TEST):
2610
2611 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2612
2613         [GTK] run-gtk-tests randomly fails while running the xprop comand
2614         https://bugs.webkit.org/show_bug.cgi?id=76817
2615
2616         Reviewed by Gustavo Noronha Silva.
2617
2618         No need to use xprop to remove the AT_SPI_BUS property since
2619         run-gtk-tests will always run new instances of Xvfb.
2620
2621         * Scripts/run-gtk-tests:
2622         (TestRunner): Unskip TestWebKitAccessibility.
2623         (TestRunner.run): Uncomment lines for launching the accessibility
2624         bus and registry daemon, and remove lines for running xprop.
2625
2626 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2627
2628         [Qt] Don't warn about override and final being C++11 extensions
2629
2630         Clang will emit a warning when these extensions are used without passing
2631         --std=c++11, but we use feature checking to decide if we have the right
2632         extensions, so we can safely ignore these warnings. The XCode and Windows
2633         project files have the same workaround.
2634
2635         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2636         we only have one extra compiler for Objective-C, which is also used for
2637         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2638         make sense for Objective-C.
2639
2640         Reviewed by Simon Hausmann.
2641
2642         * qmake/mkspecs/features/unix/default_post.prf:
2643
2644 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2645
2646         [Qt] Change how build-webkit decides when to do full incremental builds
2647
2648         Instead of relying on update-webkit (which isn't run on the bots) to
2649         decide when to do a full incremental build (make qmake), we let the
2650         build-webkit script itself check the current SVN revision against the
2651         previous build (by storing it in .webkit.config).
2652
2653         If the two differ we assume a full incremental build is needed, since
2654         the new revisions might have introduced problematic things like new
2655         Q_OBJECT macros. If not, we assume the developer is doing changes
2656         locally, and revert to doing a plain 'make'.
2657
2658         In addition, when the build fails in the latter case, we inform the
2659         developer of possible pitfalls and how to manually run 'make qmake'.
2660
2661         Reviewed by Ossy.
2662
2663         * Scripts/update-webkit:
2664         * Scripts/webkitdirs.pm:
2665         (buildQMakeProjects):
2666
2667 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2668
2669         [GTK] run-gtk-tests randomly fails while running the xprop comand
2670         https://bugs.webkit.org/show_bug.cgi?id=76817
2671
2672         Reviewed by Philippe Normand.
2673
2674         Temporarily comment the lines related to launching the ATSPI bus
2675         and registry daemon, which are making the bots to fail randomly.
2676
2677         * Scripts/run-gtk-tests:
2678         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2679         properly if the ATSPI infrastructure is not properly initialized.
2680         (TestRunner.run): Comment lines related to initialization of ATSPI.
2681
2682 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2683
2684         Windows python test build fix.
2685
2686         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2687         (PerfTestsRunner.__init__):
2688
2689 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2690
2691         [GTK] DumpRenderTree converts "file:///" to a path differently
2692         https://bugs.webkit.org/show_bug.cgi?id=76631
2693
2694         Reviewed by Martin Robinson.
2695
2696         DumpRenderTree should print "/" as the last path component if the
2697         path is a lone slash instead of empty output.
2698
2699         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2700         (webViewConsoleMessage):
2701
2702 2012-01-20  David Levin  <levin@chromium.org>
2703
2704         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2705         https://bugs.webkit.org/show_bug.cgi?id=76752
2706
2707         Reviewed by Eric Seidel.
2708
2709         * Scripts/webkitpy/style/checkers/cpp.py:
2710         (check_for_leaky_patterns):
2711         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2712         (LeakyPatternTest.test_create_dc):
2713         (LeakyPatternTest.test_create_compatible_dc):
2714
2715 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2716
2717         Changed my status in commiters.py
2718
2719         Unreviewed.
2720
2721         * Scripts/webkitpy/common/config/committers.py:
2722
2723 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2724
2725         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2726         https://bugs.webkit.org/show_bug.cgi?id=76748
2727
2728         Reviewed by Ryosuke Niwa.
2729
2730         It crawls the whole subtree and then doesn't use the data. Cutting this out
2731         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2732
2733         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2734         (run):
2735
2736 2012-01-20  Adam Barth  <abarth@webkit.org>
2737
2738         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2739         up slightly nicer when there aren't any failures.
2740
2741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2742         (#summary):
2743
2744 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2745
2746         run-perf-tests should support --test-results-server option
2747         https://bugs.webkit.org/show_bug.cgi?id=76680
2748
2749         Reviewed by Adam Barth.
2750
2751         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2752         to be used by perf bots. Also refactor file_uploader as needed.
2753
2754         * Scripts/webkitpy/common/net/file_uploader.py:
2755         (FileUploader.__init__):
2756         (FileUploader.upload_single_file):
2757         (FileUploader.upload_as_multipart_form_data):
2758         (FileUploader):
2759         (FileUploader._upload_data):
2760         (FileUploader._upload_data.callback):
2761         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2762         (JSONResultsGeneratorBase.upload_json_files):
2763         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2764         (PerfTestsRunner):
2765         (PerfTestsRunner._parse_args):
2766         (PerfTestsRunner.run):
2767         (PerfTestsRunner._generate_json):
2768         (PerfTestsRunner._upload_json):
2769         (PerfTestsRunner._run_tests_set):
2770         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2771         (create_runner):
2772         (test_run_with_upload_json):
2773         (test_run_with_upload_json.mock_upload_json):
2774         (test_upload_json):
2775         (test_upload_json.MockFileUploader):
2776         (test_upload_json.MockFileUploader.__init__):
2777         (test_upload_json.MockFileUploader.upload_single_file):
2778         (test_parse_args):
2779
2780 2012-01-20  Adam Barth  <abarth@webkit.org>
2781
2782         The party time image overlaps real content!  This patch makes the
2783         image centered vertically.
2784
2785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2786         (#onebar.partytime #summary):
2787
2788 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2789
2790         Refactor TestExpectationsParser in preparation for caching the results
2791         https://bugs.webkit.org/show_bug.cgi?id=76669
2792
2793         Reviewed by Dimitri Glazkov.
2794
2795         Make everything private expect for the parse method. 
2796         Eventually, we'll need the expectations lines to not be modified
2797         outside of TestExpectationsParser so we can cache the results.
2798         This makes check-webkit-style of the chromium test_expectations.txt file
2799         go from ~17 seconds to ~12 seconds on my Mac Pro.
2800
2801         This patch is just a refactor in preparation, so no new tests.
2802
2803         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2804         (TestExpectationEditorTests.make_parsed_expectation_lines):
2805         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2806         (TestExpectationParser.parse):
2807         (TestExpectationParser):
2808         (TestExpectationParser._parse_line):
2809         (TestExpectationParser._tokenize):
2810         (TestExpectationParser._tokenize_list):
2811         (TestExpectationsModel._clear_expectations_for_test):
2812         (TestExpectations.__init__):
2813         (TestExpectations._add_expectations):
2814         (TestExpectations._add_skipped_tests):
2815         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2816         (TestExpectationParserTests.test_tokenize_blank):
2817         (TestExpectationParserTests.test_tokenize_missing_colon):
2818         (TestExpectationParserTests.test_tokenize_extra_colon):
2819         (TestExpectationParserTests.test_tokenize_empty_comment):
2820         (TestExpectationParserTests.test_tokenize_comment):
2821         (TestExpectationParserTests.test_tokenize_missing_equal):
2822         (TestExpectationParserTests.test_tokenize_extra_equal):
2823         (TestExpectationParserTests.test_tokenize_valid):
2824         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2825         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2826         (TestExpectationParserTests.test_parse_empty_string):
2827         (TestExpectationSerializerTests.assert_round_trip):
2828         (TestExpectationSerializerTests.assert_list_round_trip):
2829         * Scripts/webkitpy/tool/commands/expectations.py:
2830         (OptimizeExpectations.execute):
2831         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2832         (GardeningExpectationsUpdater.update_expectations):
2833
2834 2012-01-20  Adam Barth  <abarth@webkit.org>
2835
2836         Follow-up to previous patch: don't produce NaN when the revision number
2837         is missing.
2838
2839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2841
2842 2012-01-20  Adam Barth  <abarth@webkit.org>
2843
2844         Garden-o-matic should tell me which revisions have been checked by all the bots
2845         https://bugs.webkit.org/show_bug.cgi?id=76722
2846
2847         Reviewed by Dimitri Glazkov.
2848
2849         This information helps me know when it's safe for me to roll a
2850         candidate revision.
2851
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2855
2856 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2857
2858         build-webkit: Don't spit out congratulations message on Ctrl+C
2859
2860         Reviewed by Andreas Kling.
2861
2862         * Scripts/build-webkit:
2863
2864 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2865
2866         [GTK] Allow extra jhbuild modulesets
2867         https://bugs.webkit.org/show_bug.cgi?id=76691
2868
2869         Reviewed by Gustavo Noronha Silva.
2870
2871         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2872         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2873         env variables respectively. Use comma-separated values. Example:
2874         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2875
2876 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2877
2878         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2879         https://bugs.webkit.org/show_bug.cgi?id=72589
2880
2881         Reviewed by Martin Robinson.
2882
2883         Ensure the accessibility infrastructure is available when running
2884         the unit tests, otherwise WK2's accessibility tests won't work.
2885
2886         * Scripts/run-gtk-tests:
2887         (TestRunner):
2888         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2889         where at-spi2's stuff is located (like at-spi-bus-launcher and
2890         at-spi2-registryd).
2891         (TestRunner.run): Initialize the accessibility infrastructure.
2892
2893         * gtk/generate-gtkdoc:
2894         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
2895
2896         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
2897
2898 2012-01-20  Hayato Ito  <hayato@chromium.org>
2899
2900         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
2901         https://bugs.webkit.org/show_bug.cgi?id=76353
2902
2903         Reviewed by Hajime Morita.
2904
2905         Add ShadowRoot.idl, which is enabled only on chromium port since this is
2906         under development feature.
2907         ShadowRoot.idl contains minimum API so that we can test it.
2908         Other APIs should be added on other changes so that we can isolate issues.
2909
2910         * DumpRenderTree/chromium/TestShell.cpp:
2911         (TestShell::TestShell):
2912
2913 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2914
2915         [GTK] GTK's DRT not to log events for already defunct objects
2916         https://bugs.webkit.org/show_bug.cgi?id=76620
2917
2918         Reviewed by Martin Robinson.
2919
2920         Do not log 'state-change:defunct' events.
2921
2922         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2923         (printAccessibilityEvent): Early return if a
2924         'state-change:defunct' signal is passed.
2925         (axObjectEventListener): Pass the signal name and value in
2926         separate parameters to printAccessibilityEvent.
2927
2928 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2929
2930         Unreviewed build fix. Wrong variable being used as the cwd for git
2931         remote update command.
2932
2933         * gtk/run-with-jhbuild:
2934         (update_jhbuild):
2935
2936 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2937
2938         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
2939         https://bugs.webkit.org/show_bug.cgi?id=76585
2940
2941         Reviewed by Martin Robinson.
2942
2943         This allows us to specify a minimum version of jhbuild required,
2944         while also providing stability against changes done to the master
2945         branch, by letting us choose what is the exact version that will
2946         be used.
2947
2948         * gtk/run-with-jhbuild: refactored for more hackability and easier
2949         reading
2950         (jhbuild_installed): checks whether jhbuild is installed
2951         (jhbuild_cloned): checks whether jhbuild has been cloned
2952         (jhbuild_at_expected_revision): checks whether jhbuild is at the
2953         expected revision
2954         (update_jhbuild): brings jhbuild to the expected revision
2955         (clone_jhbuild): clones jhbuild
2956         (install_jhbuild): build and installs jhbuild
2957         (update_webkitgtk_libs): runs update-webkitgtk-libs
2958         (ensure_jhbuild): high-level logic to decide whether and which of
2959         the steps above are executed
2960
2961 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2962
2963         [WK2] DumpRenderTree converts "file:///" to a path differently
2964         https://bugs.webkit.org/show_bug.cgi?id=76653
2965
2966         Reviewed by John Sullivan.
2967
2968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
2969         Do print a slash if there are no path components.
2970
2971 2012-01-19  Eric Seidel  <eric@webkit.org>
2972
2973         webkit-patch cannot rollout patches without changelog/bug number
2974         https://bugs.webkit.org/show_bug.cgi?id=75962
2975
2976         Reviewed by Adam Barth.
2977
2978         * Scripts/webkitpy/tool/commands/download.py:
2979         (AbstractRolloutPrepCommand._prepare_state):
2980         * Scripts/webkitpy/tool/commands/download_unittest.py:
2981         (AbstractRolloutPrepCommandTest.test_prepare_state):
2982
2983 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2984
2985         [WK2] fast/url/degenerate-file-base.html fails
2986         https://bugs.webkit.org/show_bug.cgi?id=76619
2987
2988         Reviewed by Adam Roben.
2989
2990         A URL generated form local path for loading had an extra slash, making document.URL
2991         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
2992
2993         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
2994
2995 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2996
2997         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
2998         https://bugs.webkit.org/show_bug.cgi?id=76510
2999
3000         Reviewed by Adam Barth.
3001
3002         Unlike other style rules, if you get the syntax of the test_expectations.txt
3003         file wrong, the layout tests won't run. Also, this check is simple and only
3004         slows down committing if you actually modify one of the test_expectations.txt files.
3005
3006         * Scripts/webkitpy/style/checkers/test_expectations.py:
3007         (TestExpectationsChecker.check_test_expectations):
3008         (TestExpectationsChecker.check):
3009         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3010         (TestExpectationsTestCase.test_check_covers_all_configurations):
3011         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3012         (TestExpectationsTestCase):
3013         (assert_lines_lint):
3014
3015 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3016
3017         Build fix. Revert an unintentional change to WebKitDriver in r105443.
3018
3019         * Scripts/webkitpy/layout_tests/port/driver.py:
3020         (DriverProxy.__init__):
3021
3022 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
3023
3024         remove the duplicated build rules from WebKit.gyp, Tools.gyp
3025         https://bugs.webkit.org/show_bug.cgi?id=73384
3026
3027         Reviewed by Tony Chang.
3028
3029         This patch removes the no-longer-necessary conditional logic for
3030         build_webkit_exes_from_webkit_gyp; we now always build the exes
3031         from their own dedicated gyp files.
3032
3033         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3034
3035 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3036
3037         make-new-script-test should work with HTTP tests
3038         https://bugs.webkit.org/show_bug.cgi?id=76603
3039
3040         Reviewed by Adam Roben.
3041
3042         * Scripts/make-new-script-test:
3043         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3044         now also creates absolute paths for HTTP.
3045
3046 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3047
3048         Some perf tests time out when ran by run-perf-tests
3049         https://bugs.webkit.org/show_bug.cgi?id=76612
3050
3051         Reviewed by Dirk Pranke and Eric Seidel.
3052
3053         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3054         Otherwise some tests such as Parser/xml-parser.html will timeout.
3055
3056         --no-timeout option is currently supported by Chromium and Mac ports.
3057
3058         * Scripts/webkitpy/layout_tests/port/base.py:
3059         (Port.to.create_driver):
3060         * Scripts/webkitpy/layout_tests/port/chromium.py:
3061         (ChromiumDriver.__init__):
3062         (ChromiumDriver._wrapper_options):
3063         * Scripts/webkitpy/layout_tests/port/driver.py:
3064         (Driver.__init__):
3065         (DriverProxy.__init__):
3066         * Scripts/webkitpy/layout_tests/port/webkit.py:
3067         (WebKitDriver.__init__):
3068         (WebKitDriver.cmd_line):
3069         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3070         (WebKitDriverTest.test_read_binary_block):
3071         (WebKitDriverTest):
3072         (WebKitDriverTest.test_no_timeout):
3073         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3074         (get_tests_run.RecordingTestDriver.__init__):
3075         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3076         (PerfTestsRunner._parse_args):
3077         (PerfTestsRunner._run_tests_set):
3078         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3079         (create_runner):
3080
3081 2012-01-19  Ben Wells  <benwells@chromium.org>
3082
3083         Add support for window.print to chromium DRT
3084         https://bugs.webkit.org/show_bug.cgi?id=76479
3085
3086         When used in a test window.print goes into print mode and then
3087         straight out again. This will allow the afterprint event to be
3088         tested by having the afterprint event happen before the dump
3089         happens.
3090
3091         Reviewed by Mihai Parparita.
3092
3093         * DumpRenderTree/chromium/WebViewHost.cpp:
3094         (WebViewHost::printPage):
3095         * DumpRenderTree/chromium/WebViewHost.h:
3096
3097 2012-01-18  Enrica Casucci  <enrica@apple.com>
3098
3099         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
3100         https://bugs.webkit.org/show_bug.cgi?id=76588
3101         <rdar://problem/9325183>
3102
3103         Added test.
3104         
3105         Reviewed by Dan Bernstein.
3106
3107         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3108         (TestWebKitAPI::TEST):
3109
3110 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3111
3112         [Qt] Do full incremental builds until bots use update-webkit
3113
3114         Rubber-stamped by Simon Hausmann.
3115
3116         * Scripts/webkitdirs.pm:
3117         (buildQMakeProjects):
3118
3119 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3120
3121         Fix the Qt build
3122
3123         Unreviewed build fix.
3124
3125         * Scripts/webkitdirs.pm:
3126         (buildQMakeProjects):
3127
3128 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3129
3130         [Qt] Make build-webkit always do safe incremental builds after update-webkit
3131
3132         When building against Qt5 with GCC we would just run 'make' in the build dir,
3133         and rely on the dependency files output by GCC (-MD) to handle dependency
3134         tracking, but that fails for special-cases like adding a Q_OBJECT macro
3135         to a header.
3136
3137         To guarantee that an incrmental build will work, we have to run 'make qmake',
3138         which we now do on every build-webkit that's followed by a successful run
3139         of update-webkit. The reasoning is that update-webkit can result in such
3140         potential corner-cases being applied, and since we can't know for sure
3141         unless we inspect the diff and account for all the corner cases we assume
3142         the worst and always run 'make qmake'.
3143
3144         After a succesful run of build-webkit we proceed to do just 'make' for any
3145         subsequent runs, since we assume that the developer knows what kind of
3146         changes he/she is doing, and when a 'make qmake' is needed.
3147
3148         Reviewed by Simon Hausmann.
3149
3150         * Scripts/update-webkit:
3151         * Scripts/webkitdirs.pm:
3152         (determineCurrentSVNRevision):
3153         (currentSVNRevision):
3154         (buildQMakeProjects):
3155         * qmake/mkspecs/features/default_post.prf:
3156
3157 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3158
3159         run-perf-tests should support Skipped list
3160         https://bugs.webkit.org/show_bug.cgi?id=76594
3161
3162         Reviewed by Adam Barth.
3163
3164         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
3165
3166         * Scripts/webkitpy/layout_tests/port/base.py:
3167         (Port.perf_tests_dir):
3168         (Port.skipped_perf_tests):
3169         (Port.skips_perf_test):
3170         (Port.relative_perf_test_filename):
3171         * Scripts/webkitpy/layout_tests/port/test.py:
3172         (TestPort.perf_tests_dir):
3173         * Scripts/webkitpy/layout_tests/port/webkit.py:
3174         (WebKitPort._expectations_from_skipped_files):
3175         (WebKitPort):
3176         (WebKitPort.skipped_layout_tests):
3177         (WebKitPort.skipped_perf_tests):
3178         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3179         (PerfTestsRunner._collect_tests):
3180         (PerfTestsRunner.run):
3181         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3182         (test_run_test_set_with_json_output):
3183         (test_run_test_set_with_json_source):
3184         (test_collect_tests_with_skipped_list):
3185         (test_collect_tests_with_skipped_list.add_file):
3186
3187 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3188
3189         Fix path to chromium_src_dir introduced in previous change.
3190
3191         Unreviewed, build fix.
3192
3193         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3194
3195 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3196
3197         Need infrastructure to test Content-Disposition filename encoding support
3198         https://bugs.webkit.org/show_bug.cgi?id=76572
3199         <rdar://problem/6421825>
3200
3201         Reviewed by Sam Weinig.
3202
3203         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3204
3205         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3206
3207         * DumpRenderTree/mac/PolicyDelegate.mm:
3208         (dispositionTypeFromContentDispositionHeader):
3209         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3210
3211 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3212
3213         Fix tests from http://trac.webkit.org/changeset/105332.
3214
3215         The code assumed that if you passed an options object with a configuration
3216         attribute that it would have a valid value. A bunch of the testing mocks
3217         do things like having a configuration value of None.
3218
3219         * Scripts/webkitpy/layout_tests/port/base.py:
3220         (Port.__init__):
3221
3222 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3223
3224         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3225         https://bugs.webkit.org/show_bug.cgi?id=76576
3226
3227         Reviewed by Adam Barth.
3228
3229         Avoid calling default_configuration in base.py. We don't need it for
3230         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3231         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3232         from common.executive.
3233
3234         At some point someone should probably look into why that call is so slow
3235         since it's on the critical path for run-webkit-tests and build-webkit startup.
3236
3237         * Scripts/webkitpy/layout_tests/port/base.py:
3238         (Port.__init__):
3239         * Scripts/webkitpy/style/checkers/test_expectations.py:
3240         (TestExpectationsChecker._determine_port_from_exepectations_path):
3241
3242 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3243
3244         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3245         https://bugs.webkit.org/show_bug.cgi?id=76505
3246
3247         Reviewed by Tony Chang.
3248
3249         Update chromium build script to use All.gyp instead of WebKit.gyp
3250
3251         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3252         * Scripts/webkitdirs.pm:
3253
3254 2012-01-18  Sam Weinig  <sam@webkit.org>
3255
3256         Don’t hardcode the path to ‘make‘.
3257
3258         Reviewed by Dan Bernstein.
3259
3260         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3261
3262 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3263
3264         Adding myself to committers.py
3265         https://bugs.webkit.org/show_bug.cgi?id=76569
3266
3267         Unreviewed.
3268
3269         * Scripts/webkitpy/common/config/committers.py:
3270
3271 2012-01-18  Adam Barth  <abarth@webkit.org>
3272
3273         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3274         https://bugs.webkit.org/show_bug.cgi?id=76567
3275
3276         Reviewed by Eric Seidel.
3277
3278         Current the AppleMac port has slightly more failures than we allow on
3279         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3280         which should hopefully let the mac-ews run to completion.  Once
3281         AppleMac has fewer failures, we can lower the cap again.
3282
3283         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3284         (LayoutTestResultsReaderTest.test_layout_test_results):
3285         * Scripts/webkitpy/tool/steps/runtests.py:
3286         (RunTests):
3287         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3288
3289 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3290
3291         Provide access to user's list of preferred languages
3292         https://bugs.webkit.org/show_bug.cgi?id=76138
3293
3294         Reviewed by Alexey Proskuryakov.
3295
3296         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3297
3298 2012-01-18  Adam Barth  <abarth@webkit.org>
3299
3300         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3301         configurations.
3302
3303         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3304         (ChromiumLinuxPort.__init__):
3305
3306 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3307
3308         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3309         https://bugs.webkit.org/show_bug.cgi?id=73460
3310
3311         Reviewed by Chris Fleizach.
3312
3313         * DumpRenderTree/AccessibilityUIElement.h:
3314         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3315         (AccessibilityUIElement::AccessibilityUIElement):
3316         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3317         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3318         (AccessibilityUIElement::scrollToGlobalPointCallback):
3319         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3320         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3321         (AccessibilityUIElement::scrollToMakeVisible):
3322         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3323         (AccessibilityUIElement::scrollToGlobalPoint):
3324         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3325         (AccessibilityUIElement::scrollToMakeVisible):
3326         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3327         (AccessibilityUIElement::scrollToGlobalPoint):
3328         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3329         (AccessibilityUIElement::scrollToMakeVisible):
3330         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3331         (AccessibilityUIElement::scrollToGlobalPoint):
3332
3333 2012-01-17  Enrica Casucci  <enrica@apple.com>
3334
3335         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3336         https://bugs.webkit.org/show_bug.cgi?id=76490
3337         <rdar://problem/9460733>
3338
3339         Added TestWebKitAPI test.
3340         
3341         Reviewed by Dan Bernstein.
3342
3343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3344         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3345         changeAttributes to the WebView.
3346         
3347 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3348
3349         [Qt] Consolidate layout test crash logging
3350         https://bugs.webkit.org/show_bug.cgi?id=75088
3351
3352         Reviewed by Simon Hausmann.
3353
3354         Move backtrace generating logic into WTFReportBacktrace
3355         and add a way to deinstall signal handlers if we know
3356         that we have already printed the backtrace.
3357
3358         * DumpRenderTree/qt/main.cpp:
3359         (crashHandler):
3360         (setupSignalHandlers):
3361         (WTFCrashHook):
3362         (main):
3363         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3364         (WTR::crashHandler):
3365         (WTR::setupSignalHandlers):
3366         (WTR::crashHook):
3367         (WTR::InjectedBundle::platformInitialize):
3368
3369 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3370
3371         Unreviewed build fix after r105256.
3372
3373         There was a cyclic dependency between self._port and self._host assigments.
3374
3375         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3376         (PerfTestsRunner.__init__):
3377
3378 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3379
3380         Add new watchlist rule for the Qt build system
3381
3382         Reviewed by Simon Hausmann.
3383
3384         * Scripts/webkitpy/common/config/watchlist:
3385
3386 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3387
3388         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3389
3390         Reviewed by Simon Hausmann.
3391
3392         * Tools.pro:
3393
3394 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3395
3396         [Qt] Allow building only a subset of the WebKit sub-projects
3397
3398         Fixes build-jsc, broken in r104825.
3399
3400         We no longer need the intermediate buildQMakeQtProject(), as we're the
3401         only port using qmake, and buildQMakeProject is now highly Qt specific.
3402
3403         <http://webkit.org/b/76179>
3404
3405         Reviewed by Simon Hausmann.
3406
3407         * Scripts/build-jsc:
3408         * Scripts/build-webkit:
3409         * Scripts/webkitdirs.pm:
3410         (buildQMakeProjects):
3411
3412 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3413
3414         run-perf-tests should generate a json file that summaries the result
3415         https://bugs.webkit.org/show_bug.cgi?id=76504
3416
3417         Reviewed by Adam Barth.
3418
3419         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
3420         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
3421         another json file to be merged into the generated json file.
3422
3423         Also fixed a bug that --build wasn't set by default.
3424
3425         * Scripts/webkitpy/layout_tests/port/test.py:
3426         (TestPort.webkit_base):
3427         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3428         (PerfTestsRunner.__init__):
3429         (PerfTestsRunner):
3430         (PerfTestsRunner._parse_args):
3431         (PerfTestsRunner.run):
3432         (PerfTestsRunner._generate_json_if_specified):
3433         (PerfTestsRunner._process_chromium_style_test_result):
3434         (PerfTestsRunner._process_parser_test_result):
3435         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3436         (MainTest):
3437         (create_runner):
3438         (test_run_test_set):
3439         (test_run_test_set_for_parser_tests):
3440         (test_run_test_set_with_summary_json):
3441         (test_collect_tests):
3442         (test_parse_args):
3443
3444 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3445
3446         Unreviewed, rolling out r105244.
3447         http://trac.webkit.org/changeset/105244
3448         https://bugs.webkit.org/show_bug.cgi?id=76518
3449
3450         broke Chromium Mac (Requested by rolandsteiner on #webkit).
3451
3452         * DumpRenderTree/AccessibilityUIElement.h:
3453         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3454         (AccessibilityUIElement::AccessibilityUIElement):
3455         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3456         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3457         (AccessibilityUIElement::removeSelection):
3458         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3459         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3460         (AccessibilityUIElement::removeSelection):
3461
3462 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
3463
3464         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3465         https://bugs.webkit.org/show_bug.cgi?id=73460
3466
3467         Reviewed by Chris Fleizach.
3468
3469         * DumpRenderTree/AccessibilityUIElement.h:
3470         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3471         (AccessibilityUIElement::AccessibilityUIElement):
3472         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3473         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3474         (AccessibilityUIElement::scrollToGlobalPointCallback):
3475         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3476         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3477         (AccessibilityUIElement::scrollToMakeVisible):
3478         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3479         (AccessibilityUIElement::scrollToGlobalPoint):
3480         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3481         (AccessibilityUIElement::scrollToMakeVisible):
3482         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3483         (AccessibilityUIElement::scrollToGlobalPoint):
3484         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3485         (AccessibilityUIElement::scrollToMakeVisible):
3486         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3487         (AccessibilityUIElement::scrollToGlobalPoint):
3488
3489 2012-01-17  Adam Barth  <abarth@webkit.org>
3490
3491         Enable tests on the mac-ews
3492         https://bugs.webkit.org/show_bug.cgi?id=76502
3493
3494         Reviewed by Simon Fraser.
3495
3496         Apple now has five machines running the mac-ews.  Lucas Forschler has
3497         asked that we try enabling tests to see if we have enough bandwidth.
3498
3499         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3500         (MacEWS):
3501
3502 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
3503
3504         Add a check-webkit-style exception for GDBInterface.cpp
3505         https://bugs.webkit.org/show_bug.cgi?id=76187
3506
3507         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
3508         that it does not fail the style check.
3509
3510         Reviewed by Martin Robinson.
3511
3512         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
3513         readability/naming tests on
3514         Source/JavaScriptCore/jit/GDBInterface.cpp.
3515         * Scripts/webkitpy/style/checker_unittest.py:
3516         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
3517         the above exception.
3518
3519 2012-01-17  Hajime Morrita  <morrita@chromium.org>
3520
3521         https://bugs.webkit.org/show_bug.cgi?id=76245
3522         [Mac][DRT] should allow query string for the file URL.
3523
3524         Reviewed by Tony Chang.
3525
3526         Taught DRT about file:// as a url instead of a file path.
3527         We are now able to use a path file:///foo/bar.html?baz as a url
3528         with which DRT opens "/foo/bar.html" with "baz" as a query string.
3529
3530         * DumpRenderTree/mac/DumpRenderTree.mm:
3531         (runTest):
3532
3533 2012-01-17  Ojan Vafai  <ojan@chromium.org>
3534
3535         Check style on test_expectations.txt files before commit
3536         https://bugs.webkit.org/show_bug.cgi?id=76484
3537
3538         Reviewed by Adam Barth.
3539
3540         Unlike other style rules, if you get the syntax of the test_expectations.txt
3541         file wrong, the layout tests won't run. Also, this check is simple and only
3542         slows down committing if you actually modify one of the test_expectations.txt files.
3543
3544         * Scripts/webkitpy/tool/steps/commit.py:
3545         (Commit._check_test_expectations):
3546         (Commit.run):
3547         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
3548         (CommitTest):
3549         (CommitTest.test_check_test_expectations):
3550
3551 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3552
3553         [Qt] Debug build fails with debug qt5
3554         https://bugs.webkit.org/show_bug.cgi?id=76463
3555
3556         Reviewed by Simon Hausmann.
3557
3558         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
3559
3560         * QtTestBrowser/cookiejar.h:
3561
3562 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3563
3564         webkitpy: fix json import on linux
3565         https://bugs.webkit.org/show_bug.cgi?id=76481
3566
3567         Reviewed by Adam Barth.
3568
3569         For some reason, the version of simplejson autoinstalled on my linux
3570         box seems to be broken. We should really only be using
3571         simplejson if json isn't available anyway, so this change looks
3572         for json first.
3573
3574         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3575         (JSONGeneratorTest.test_test_timings_trie):
3576
3577 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3578
3579         Fix failures in test-webkitpy caused by r105177.
3580
3581         Unreviewed, build fix.
3582
3583         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3584         (ChromiumLinuxPort._determine_driver_path_statically):
3585         (ChromiumLinuxPort._static_build_path):
3586
3587 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3588
3589         webkitpy: make PortFactory.get() be fully data-driven
3590         https://bugs.webkit.org/show_bug.cgi?id=76360
3591
3592         Reviewed by Eric Seidel.
3593
3594         Refactor PortFactory.get() to be fully data-driven.
3595
3596         * Scripts/webkitpy/layout_tests/port/factory.py:
3597         (PortFactory):
3598         (PortFactory._default_port):
3599         (PortFactory.get):
3600         (PortFactory.get.in):
3601         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3602         (FactoryTest.assert_port):
3603
3604 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3605
3606         webkitpy: add determine_full_port_name(), clean up port.__init__()
3607         https://bugs.webkit.org/show_bug.cgi?id=76357
3608
3609         Reviewed by Adam Barth.
3610
3611         Each Port class is now required to implement a 'port_name' field
3612         that will match the start of all ports constructed by this class and
3613         a 'determine_full_port_name' field that will make the port
3614         fully-qualified.
3615
3616         * Scripts/webkitpy/layout_tests/port/apple.py:
3617         (ApplePort.__init__):
3618         * Scripts/webkitpy/layout_tests/port/base.py:
3619         (Port):
3620         (Port.determine_port_name):
3621         (Port.__init__):
3622         * Scripts/webkitpy/layout_tests/port/chromium.py:
3623         (ChromiumPort.for):
3624         (ChromiumPort.__init__):
3625         (ChromiumPort):
3626         (ChromiumPort._chromium_base_dir):
3627         (ChromiumPort.path_from_chromium_base):
3628         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3629         (ChromiumGpuLinuxPort):
3630         (ChromiumGpuLinuxPort.__init__):
3631         (ChromiumGpuMacPort):
3632         (ChromiumGpuMacPort.__init__):
3633         (ChromiumGpuWinPort):
3634         (ChromiumGpuWinPort.__init__):
3635         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3636         (ChromiumLinuxPort):
3637         (ChromiumLinuxPort.determine_port_name):
3638         (ChromiumLinuxPort.__init__):
3639         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3640         (ChromiumMacPort):
3641         (ChromiumMacPort.determine_port_name):
3642         (ChromiumMacPort.__init__):
3643         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3644         (ChromiumWinPort):
3645         (ChromiumWinPort.determine_port_name):
3646         (ChromiumWinPort.__init__):
3647         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3648         (DryRunPort):
3649         (DryRunPort.determine_port_name):
3650         (DryRunPort.__init__):
3651         * Scripts/webkitpy/layout_tests/port/efl.py:
3652         (EflPort):
3653         * Scripts/webkitpy/layout_tests/port/factory.py:
3654         (PortFactory):
3655         (PortFactory._default_port):
3656         (PortFactory.get):
3657         (PortFactory.get.in):
3658         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3659         (FactoryTest.assert_port):
3660         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3661         (GoogleChromeLinux32Port):
3662         (GoogleChromeLinux32Port.determine_port_name):
3663         (GoogleChromeLinux64Port):
3664         (GoogleChromeLinux64Port.determine_port_name):
3665         (GoogleChromeMacPort):
3666         (GoogleChromeMacPort.determine_port_name):
3667         (GoogleChromeWinPort):
3668         (GoogleChromeWinPort.determine_port_name):
3669         * Scripts/webkitpy/layout_tests/port/gtk.py:
3670         (GtkPort):
3671         * Scripts/webkitpy/layout_tests/port/mac.py:
3672         (MacPort):
3673         (MacPort.determine_port_name):
3674         (MacPort.__init__):
3675         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3676         (test_versions):
3677         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3678         (MockDRTPort):
3679         (MockDRTPort.determine_port_name):
3680         (MockDRTPort.__init__):
3681         (MockDRT):
3682         (MockDRT.determine_port_name):
3683         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3684         (PortTestCase.make_port):