run-bindings-tests is timing out in some WinCairo bots
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         run-bindings-tests is timing out in some WinCairo bots
4         https://bugs.webkit.org/show_bug.cgi?id=191348
5
6         Reviewed by Alex Christensen.
7
8         BuildBot kills run-bindings-tests if it outputs nothing for 20
9         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
10         and it takes more than 30 minutes to finish. And, Windows Python
11         buffers the progress output.
12
13         * Scripts/webkitpy/bindings/main.py:
14         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
15         test case result is output.
16
17 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
18
19         Implement a new edit command to change the enclosing list type
20         https://bugs.webkit.org/show_bug.cgi?id=191487
21         <rdar://problem/45955922>
22
23         Reviewed by Ryosuke Niwa.
24
25         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
26         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
27
28         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
30         (-[TestWKWebView setPosition:offset:]):
31         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
32         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
33         (TestWebKitAPI::TEST):
34         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
35
36 2018-11-11  Dan Bernstein  <mitz@apple.com>
37
38         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
39         https://bugs.webkit.org/show_bug.cgi?id=191514
40
41         Reviewed by Geoffrey Garen.
42
43         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
44         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
45         (TEST):
46
47 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
48
49         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
50         https://bugs.webkit.org/show_bug.cgi?id=191492
51
52         Reviewed by Alex Christensen.
53
54         Update file name.
55
56         * DumpRenderTree/mac/DumpRenderTree.mm:
57         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
58         * WebKitTestRunner/mac/TestControllerMac.mm:
59
60 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
61
62         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
63         https://bugs.webkit.org/show_bug.cgi?id=191492
64
65         Reviewed by Alex Christensen.
66
67         * DumpRenderTree/mac/DumpRenderTree.mm:
68         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
69         * WebKitTestRunner/mac/TestControllerMac.mm:
70
71 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
72
73         Unreviewed, rolling out r238065.
74
75         Breaks internal builds.
76
77         Reverted changeset:
78
79         "Make it possible to edit images inline"
80         https://bugs.webkit.org/show_bug.cgi?id=191352
81         https://trac.webkit.org/changeset/238065
82
83 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
84
85         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
86         https://bugs.webkit.org/show_bug.cgi?id=191221
87
88         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
89         that it is disabled, but we're testing that it is enabled, because I failed to update this
90         line.
91
92         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
93         (testWebKitSettings):
94
95 2018-11-10  Tim Horton  <timothy_horton@apple.com>
96
97         Make it possible to edit images inline
98         https://bugs.webkit.org/show_bug.cgi?id=191352
99         <rdar://problem/30107985>
100
101         Reviewed by Dean Jackson.
102
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::updateTestOptionsFromTestHeader):
105         * WebKitTestRunner/TestOptions.h:
106         (WTR::TestOptions::hasSameInitializationOptions const):
107         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
108         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
109         (WTR::TestController::platformCreateWebView):
110         Add a test option to enable editable images.
111
112         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
113         (WTR::UIScriptController::drawSquareInEditableImage):
114         (WTR::UIScriptController::numberOfStrokesInEditableImage):
115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
117         (WTR::UIScriptController::drawSquareInEditableImage):
118         (WTR::UIScriptController::numberOfStrokesInEditableImage):
119         * TestRunnerShared/UIScriptContext/UIScriptController.h:
120         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
121         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
122         (WTR::findEditableImageCanvas):
123         (WTR::UIScriptController::drawSquareInEditableImage):
124         (WTR::UIScriptController::numberOfStrokesInEditableImage):
125         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
126         and also to retrieve the number of strokes currently on the PKCanvasView.
127         Currently this just takes the first canvas; we might need to make it
128         take an identifier or something in the future if we need tests with multiple
129         canvases. The indirect testing mechanism is required because PKCanvasView
130         can currently not actually paint its strokes in the Simulator.
131
132 2018-11-09  Chris Dumez  <cdumez@apple.com>
133
134         Suspended page persists even after back/forward list item is gone
135         https://bugs.webkit.org/show_bug.cgi?id=191488
136         <rdar://problem/45953006>
137
138         Reviewed by Geoffrey Garen.
139
140         Add API test coverage.
141
142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
143
144 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
145
146         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
147         https://bugs.webkit.org/show_bug.cgi?id=191471
148         <rdar://problem/45952472>
149
150         Reviewed by Tim Horton.
151
152         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
155         (TestWebKitAPI::webViewForEditActionTesting):
156         (TestWebKitAPI::TEST):
157
158 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
159
160         [Curl][WebKit] Implement Proxy configuration API.
161         https://bugs.webkit.org/show_bug.cgi?id=189053
162
163         Reviewed by Youenn Fablet.
164
165         Added Proxy Settings dialog to call newly added API.
166
167         * MiniBrowser/win/BrowserWindow.h:
168         * MiniBrowser/win/Common.cpp:
169         (askProxySettings):
170         (askCredential):
171         (authDialogProc): Deleted.
172         * MiniBrowser/win/Common.h:
173         * MiniBrowser/win/DialogHelper.h: Added.
174         (Dialog::run):
175         (Dialog::doalogProc):
176         (Dialog::handle):
177         (Dialog::setup):
178         (Dialog::update):
179         (Dialog::validate):
180         (Dialog::updateOkButton):
181         (Dialog::command):
182         (Dialog::ok):
183         (Dialog::cancel):
184         (Dialog::close):
185         (Dialog::hDlg):
186         (Dialog::item):
187         (Dialog::setEnabled):
188         (Dialog::setText):
189         (Dialog::getText):
190         (Dialog::getTextLength):
191         (Dialog::RadioGroup::RadioGroup):
192         (Dialog::RadioGroup::set):
193         (Dialog::RadioGroup::get):
194         (Dialog::radioGroup):
195         * MiniBrowser/win/MainWindow.cpp:
196         (MainWindow::WndProc):
197         * MiniBrowser/win/MiniBrowserLib.rc:
198         * MiniBrowser/win/MiniBrowserLibResource.h:
199         * MiniBrowser/win/WebKitBrowserWindow.cpp:
200         (createWKURL):
201         (WebKitBrowserWindow::WebKitBrowserWindow):
202         (WebKitBrowserWindow::updateProxySettings):
203         (WebKitBrowserWindow::loadURL):
204         (WebKitBrowserWindow::loadHTMLString):
205         (WebKitBrowserWindow::openProxySettings):
206         * MiniBrowser/win/WebKitBrowserWindow.h:
207         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
208         (WebKitLegacyBrowserWindow::openProxySettings):
209         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
210
211 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
212
213         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
214         https://bugs.webkit.org/show_bug.cgi?id=191410
215         <rdar://problem/45898610>
216
217         Reviewed by Dean Jackson.
218
219         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
220         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
221         hooked up to their respective editing commands.
222
223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
224         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
225         (-[TestWKWebView querySelectorExists:]):
226         (-[TestWKWebView insertString:]):
227
228         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
229         invoking the WKWebView directly on macOS and calling on the content view on iOS.
230
231         (TestWebKitAPI::webViewForEditActionTesting):
232         (TestWebKitAPI::TEST):
233
234 2018-11-09  Philippe Normand  <pnormand@igalia.com>
235
236         [Flatpak] Refactoring and drive-by fixes
237         https://bugs.webkit.org/show_bug.cgi?id=191421
238
239         Reviewed by Michael Catanzaro.
240
241         * Scripts/webkitdirs.pm:
242         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
243         the sandbox, so rely on this.
244         * flatpak/flatpakutils.py:
245         (expand_manifest): Pass explicit keywords to load_manifest() and
246         remove unused local variable.
247         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
248         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
249         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
250         build_type handling a bit.
251         * flatpak/org.webkit.CommonModules.yaml: Added.
252         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
253         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
254         declaration to CommonModules, so it can be reused later when we
255         add support for building extra libraries depending on WPE.
256
257 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
258
259 onal supported image formats
260         https://bugs.webkit.org/show_bug.cgi?id=190454
261
262         Reviewed by Simon Fraser.
263
264         Test opening a TGA image in WebView which is not allowed by default. The
265         TGA format will be allowed through WKWebViewConfiguration.
266
267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
268         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
269         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
270         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
271         (runTest):
272         (TEST):
273
274 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
275
276         Unreviewed, a proper build fix for r237983
277
278         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
279
280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
281         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
282         (TestWebKitAPI::TEST):
283         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
284         (TestWebKitAPI::getTestCorruptedSignResponse):
285         (TestWebKitAPI::getTestCredentialRawIdBytes):
286         (TestWebKitAPI::convertToVector):
287         (TestWebKitAPI::TEST):
288
289 2018-11-08  Keith Rollin  <krollin@apple.com>
290
291         Create .xcfilelist files
292         https://bugs.webkit.org/show_bug.cgi?id=191324
293         <rdar://problem/45852819>
294
295         Reviewed by Alex Christensen.
296
297         As part of preparing for enabling XCBuild, create and use .xcfilelist
298         files. These files are using during Run Script build phases in an
299         Xcode project. If a Run Script build phase produces new files that are
300         used later as inputs to subsequent build phases, XCBuild needs to know
301         about these files. These files can be either specified in an "output
302         files" section of the Run Script phase editor, or in .xcfilelist files
303         that are associated with the Run Script build phase.
304
305         This patch takes the second approach. It consists of three sets of changes:
306
307         - Modify the DerivedSources.make files to have a
308           'print_all_generated_files" target that produces a list of the files
309           they create.
310
311         - Create a shell script that produces .xcfilelist files from the
312           output of the previous step, as well as for the files created in the
313           Generate Unified Sources build steps.
314
315         - Add the new .xcfilelist files to the associated projects.
316
317         Note that, with these changes, the Xcode workspace and projects can no
318         longer be fully loaded into Xcode 9. Xcode will attempt to load the
319         projects that have .xcfilelist files associated with them, but will
320         fail and display a placeholder for those projects instead. It's
321         expected that all developers are using Xcode 10 by now and that not
322         being able to load into Xcode 9 is not a practical issue. Keep in mind
323         that this is strictly an IDE issue, and that the projects can still be
324         built with `xcodebuild`.
325
326         Also note that the shell script that creates the .xcfilelist files can
327         also be used to verify that the set of files that's currently checked
328         in is up-to-date. This checking can be used as part of a check-in hook
329         or part of check-webkit-style to sooner catch cases where the
330         .xcfilelist files need to be regenerated.
331
332         * DumpRenderTree/DerivedSources.make:
333         * DumpRenderTree/DerivedSources.xcfilelist: Added.
334         * Scripts/generate-xcfilelists: Added.
335         * WebKitTestRunner/DerivedSources.make:
336         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
337
338 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
339
340         Unreviewed, a quick build fix for r237983
341
342         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
343
344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
345         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
346         (TestWebKitAPI::TEST):
347         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
348         (TestWebKitAPI::getTestCorruptedSignResponse):
349         (TestWebKitAPI::getTestCredentialRawIdBytes):
350         (TestWebKitAPI::convertToVector):
351         (TestWebKitAPI::TEST):
352
353 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
354
355         Fix steps_unittest.py failures related to recent Win10/Win7 changes
356         https://bugs.webkit.org/show_bug.cgi?id=191290
357
358         Reviewed by Alexey Proskuryakov.
359
360         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
361
362 2018-11-08  Dean Jackson  <dino@apple.com>
363
364         Add a String literal that returns a String
365         https://bugs.webkit.org/show_bug.cgi?id=191425
366         <rdar://problem/45914556>
367
368         Reviewed by Sam Weinig.
369
370         Test _str.
371
372         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
373         (TestWebKitAPI::TEST):
374
375 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
376
377         webkitpy: Generalize trailing SDK specifier (Part 2)
378         https://bugs.webkit.org/show_bug.cgi?id=191275
379         <rdar://problem/45703660>
380
381         Rubber-stamped by Aakash Jain.
382
383         Re-landing this change, configuration issues have been resolved.
384
385         * Scripts/webkitpy/port/ios_device.py:
386         (IOSDevicePort): Use normalized SDK.
387         * Scripts/webkitpy/port/ios_simulator.py:
388         (IOSSimulatorPort): Use normalized SDK.
389         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
390
391 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
392
393         [WebAuthN] Import CTAP device request/response converters from Chromium
394         https://bugs.webkit.org/show_bug.cgi?id=190784
395         <rdar://problem/45460333>
396
397         Reviewed by Brent Fulgham.
398
399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
400         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
405         (TestWebKitAPI::getTestCorruptedSignResponse):
406         (TestWebKitAPI::getTestCredentialRawIdBytes):
407         (TestWebKitAPI::convertToVector):
408         (TestWebKitAPI::TEST):
409         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
410
411 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
412
413         [BigInt] Add support to BigInt into ValueAdd
414         https://bugs.webkit.org/show_bug.cgi?id=186177
415
416         Reviewed by Keith Miller.
417
418         * Scripts/run-jsc-benchmarks:
419
420 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
421
422         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
423         https://bugs.webkit.org/show_bug.cgi?id=191326
424         <rdar://problem/45769269>
425
426         Reviewed by Geoffrey Garen.
427
428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
429         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
430         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
431         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
432         (TEST):
433
434 2018-11-07  Daniel Bates  <dabates@apple.com>
435
436         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
437         https://bugs.webkit.org/show_bug.cgi?id=190141
438
439         Reviewed by Darin Adler.
440
441         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
442         runs deterministic regardless of whether a hardware keyboard is attached.
443
444         * DumpRenderTree/mac/DumpRenderTree.mm:
445         (overrideIsInHardwareKeyboardMode): Added.
446         (prepareConsistentTestingEnvironment):
447         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
448         * WebKitTestRunner/ios/TestControllerIOS.mm:
449         (overrideIsInHardwareKeyboardMode): Added.
450         (WTR::TestController::platformInitialize):
451
452 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
453
454         Unreviewed, rolling out r237913.
455
456         Breaks running tests on Mac without iOS SDK installed
457
458         Reverted changeset:
459
460         "webkitpy: Generalize trailing SDK specifier (Part 2)"
461         https://bugs.webkit.org/show_bug.cgi?id=191275
462         https://trac.webkit.org/changeset/237913
463
464 2018-11-07  Zamiul Haque  <zhaque@apple.com>
465
466         Force a gregorian calendar to show for credit card expiration date inputs
467         (autocomplete='cc-exp'*) regardless of default system settings.
468         https://bugs.webkit.org/show_bug.cgi?id=191096
469         rdar://problem/42640256
470
471         Reviewed by Tim Horton.
472
473         Implemented simulateForeignDefaultCalendar and calendarType to be used
474         for changing the default calendar returned by the system (ie. [NSCalendar
475         currentCalendar]) and getting the calendar type identifier of a presented date
476         picker.
477
478         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
479         (WTR::UIScriptController::isShowingDataListSuggestions const):
480         (WTR::UIScriptController::calendarType const):
481         (WTR::UIScriptController::setDefaultCalendarType):
482         * DumpRenderTree/mac/UIScriptControllerMac.mm:
483         (WTR::UIScriptController::calendarType const):
484         (WTR::UIScriptController::setDefaultCalendarType):
485         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
486         (WTR::UIScriptController::selectionEndGrabberViewRect const):
487         (WTR::UIScriptController::calendarType const): Deleted.
488         * WebKitTestRunner/TestController.cpp:
489         * WebKitTestRunner/TestController.h:
490         * WebKitTestRunner/UIScriptControllerCocoa.mm:
491         (WTR::UIScriptController::calendarType const):
492         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
493         (WTR::swizzledCalendar):
494         (WTR::TestController::getOverriddenCalendarIdentifier const):
495         (WTR::TestController::setDefaultCalendarType):
496         (WTR::TestController::cocoaResetStateToConsistentValues):
497         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
498         (WTR::UIScriptController::selectionEndGrabberViewRect const):
499         (WTR::UIScriptController::calendarType const): Deleted.
500
501 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
502
503         webkitpy: Boot a single worker for custom devices
504         https://bugs.webkit.org/show_bug.cgi?id=191312
505         <rdar://problem/45848717>
506
507         Rubber-stamped by Aakash Jain.
508
509         * Scripts/webkitpy/layout_tests/controllers/manager.py:
510         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
511         simulators is expensive and unneeded for these tests.
512         * Scripts/webkitpy/port/ios.py:
513         (IOSPort. child_processes): No reason to memoize this call, and it prevents
514         overriding the number of child processes when booting custom devices.
515
516 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
517
518         webkitpy: Generalize trailing SDK specifier (Part 2)
519         https://bugs.webkit.org/show_bug.cgi?id=191275
520         <rdar://problem/45703660>
521
522         Reviewed by Aakash Jain.
523
524         * Scripts/webkitpy/port/ios_device.py:
525         (IOSDevicePort): Use normalized SDK.
526         * Scripts/webkitpy/port/ios_simulator.py:
527         (IOSSimulatorPort): Use normalized SDK.
528         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
529
530 2018-11-06  Justin Fan  <justin_fan@apple.com>
531
532         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
533         https://bugs.webkit.org/show_bug.cgi?id=191291
534
535         Reviewed by Myles Maxfield.
536
537         Properly disable WEBGPU on all non-Metal platforms for now.
538
539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
540
541 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
542
543         [ews-app] Add URL configuration for OpenSource EWS Django app
544         https://bugs.webkit.org/show_bug.cgi?id=191132
545
546         Rubber-stamped by Lucas Forschler.
547
548         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
549         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
550
551 2018-11-06  Youenn Fablet  <youenn@apple.com>
552
553         Make mDNS ICE Candidate an experimental flag again
554         https://bugs.webkit.org/show_bug.cgi?id=191262
555
556         Reviewed by Dean Jackson.
557
558         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
560         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
561         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
563
564 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews-app] Add views for OpenSource EWS Django app
567         https://bugs.webkit.org/show_bug.cgi?id=191131
568
569         Rubber-stamped by Lucas Forschler.
570
571         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
572         * BuildSlaveSupport/ews-app/ews/views/patch.py:
573         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
574         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
575
576 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
577
578         [ews-app] Add models for OpenSource EWS Django app
579         https://bugs.webkit.org/show_bug.cgi?id=191123
580
581         Reviewed by Lucas Forschler.
582
583         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
584         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
585         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
586         * BuildSlaveSupport/ews-app/ews/models/patch.py:
587         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
588
589 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
590
591         [ews-app] Fix Invalid HTTP_HOST header
592         https://bugs.webkit.org/show_bug.cgi?id=191325
593
594         Reviewed by Lucas Forschler.
595
596         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
597
598         * BuildSlaveSupport/ews-app/ews-app/settings.py:
599
600 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
601
602         [ews-app] Rename EWS_app to ews-app - part 2
603         https://bugs.webkit.org/show_bug.cgi?id=191317
604
605         Reviewed by Lucas Forschler.
606
607         * BuildSlaveSupport/ews-app/EWS_app: Removed.
608         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
609         * BuildSlaveSupport/ews-app/ews-app/settings.py:
610         * BuildSlaveSupport/ews-app/ews-app/urls.py:
611         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
612         * BuildSlaveSupport/ews-app/manage.py:
613
614 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
615
616         [ews-app] Rename EWS_app to ews-app - part 1
617         https://bugs.webkit.org/show_bug.cgi?id=191317
618
619         Reviewed by Lucas Forschler.
620
621         * BuildSlaveSupport/EWS_app: Removed.
622         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
623
624 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
625
626         Spelling dots are drawn in the wrong place
627         https://bugs.webkit.org/show_bug.cgi?id=190764
628
629         Reviewed by Dean Jackson.
630
631         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
632         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
633         dots to be drawn.
634
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::TestController::resetStateToConsistentValues):
637         (WTR::updateTestOptionsFromTestHeader):
638         (WTR::TestController::platformResetStateToConsistentValues):
639         * WebKitTestRunner/TestController.h:
640         * WebKitTestRunner/TestOptions.h:
641         (WTR::TestOptions::hasSameInitializationOptions const):
642         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
643         (WTR::TestController::cocoaResetStateToConsistentValues):
644         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
645         * WebKitTestRunner/ios/TestControllerIOS.mm:
646         (WTR::TestController::platformResetStateToConsistentValues):
647         * WebKitTestRunner/mac/TestControllerMac.mm:
648         (WTR::TestController::platformResetStateToConsistentValues):
649
650 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
651
652         Feature flags not present for Visual Studio when using build-webkit
653         https://bugs.webkit.org/show_bug.cgi?id=191288
654
655         Reviewed by Fujii Hironori.
656
657         Passes feature flags to Visual studio builds within build-webkit.
658         Removes cmakeBasedPortArguments as it is no longer in use.
659
660         * Scripts/build-jsc:
661         * Scripts/build-webkit:
662         * Scripts/webkitdirs.pm:
663         (cmakeBasedPortArguments): Deleted.
664
665 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
666
667         REGRESSION (r230523): Caps lock indicator not shown in password field
668         https://bugs.webkit.org/show_bug.cgi?id=190056
669
670         Reviewed by Ryosuke Niwa.
671
672         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
674         (WTR::TestRunner::toggleCapsLock):
675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
676         * WebKitTestRunner/TestController.h:
677         * WebKitTestRunner/TestInvocation.cpp:
678         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
679         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
680         (WTR::TestController::toggleCapsLock):
681
682 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
683
684         IndexedDB: WAL file keeps growing
685         https://bugs.webkit.org/show_bug.cgi?id=191294
686         <rdar://problem/41333493>
687
688         Reviewed by Chris Dumez.
689
690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
691         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
692         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
693         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
694         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
695         (TEST):
696
697 2018-11-06  Alex Christensen  <achristensen@webkit.org>
698
699         Fix tests after r237863
700         https://bugs.webkit.org/show_bug.cgi?id=191315
701
702         Reviewed by Chris Dumez.
703
704         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
705         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
706         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
707         to verify that main2.html eventually loads, making this test less timing dependent.
708
709 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
710
711         Unreviewed, rolling out r237834.
712
713         Tests for this change crash on iOS Simulator
714
715         Reverted changeset:
716
717         "Spelling dots are drawn in the wrong place"
718         https://bugs.webkit.org/show_bug.cgi?id=190764
719         https://trac.webkit.org/changeset/237834
720
721 2018-11-05  Alex Christensen  <achristensen@webkit.org>
722
723         [Mac] Implement safe browsing in WebKit
724         https://bugs.webkit.org/show_bug.cgi?id=188871
725
726         Reviewed by Tim Horton.
727
728         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
729         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
730         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
731         (-[TestLookupContext lookUpURL:completionHandler:]):
732         (simpleURL):
733         (safeBrowsingView):
734         (TEST):
735         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
736         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
737         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
738         * TestWebKitAPI/Utilities.h:
739
740 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
741
742         webkitpy: Generalize trailing SDK specifier (Part 1)
743         https://bugs.webkit.org/show_bug.cgi?id=191275
744         <rdar://problem/45703660>
745
746         Reviewed by Lucas Forschler.
747
748         * Scripts/webkitpy/common/system/platforminfo.py:
749         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
750         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
751         (TestPlatformInfo):
752         (TestPlatformInfo.test_available_sdks):
753
754 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
755
756         Spelling dots are drawn in the wrong place
757         https://bugs.webkit.org/show_bug.cgi?id=190764
758
759         Reviewed by Dean Jackson.
760
761         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
762         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
763         dots to be drawn.
764
765         * WebKitTestRunner/TestController.cpp:
766         (WTR::TestController::resetStateToConsistentValues):
767         (WTR::updateTestOptionsFromTestHeader):
768         (WTR::TestController::platformResetStateToConsistentValues):
769         * WebKitTestRunner/TestController.h:
770         * WebKitTestRunner/TestOptions.h:
771         (WTR::TestOptions::hasSameInitializationOptions const):
772         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
773         (WTR::TestController::cocoaResetStateToConsistentValues):
774         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
775         * WebKitTestRunner/ios/TestControllerIOS.mm:
776         (WTR::TestController::platformResetStateToConsistentValues):
777         * WebKitTestRunner/mac/TestControllerMac.mm:
778         (WTR::TestController::platformResetStateToConsistentValues):
779
780 2018-11-05  Chris Dumez  <cdumez@apple.com>
781
782         Use same limit for page cache and suspended pages
783         https://bugs.webkit.org/show_bug.cgi?id=191266
784
785         Reviewed by Geoffrey Garen.
786
787         Update API tests accordingly.
788
789         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
790
791 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
792
793         [style] Exclude style check for auto generated files.
794         https://bugs.webkit.org/show_bug.cgi?id=191118
795
796         Reviewed by Eric Carlson.
797
798         Some files checked in to the repository are generated by other tools. In this patch,
799         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
800         VisualStudio.
801
802         There's no need to check these files because it's not practical to fix the style errors
803         or it's hard to maintain those fixes.
804
805         * Scripts/webkitpy/style/checkers/cpp.py:
806         (is_generated_file):
807         (CppChecker.check):
808
809 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
810
811         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
812         https://bugs.webkit.org/show_bug.cgi?id=190680
813
814         Reviewed by Philippe Normand.
815
816         * flatpak/org.webkit.WebKit.yaml:
817
818 2018-11-05  Daniel Bates  <dabates@apple.com>
819
820         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
821         https://bugs.webkit.org/show_bug.cgi?id=191094
822
823         Reviewed by Andy Estes.
824
825         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
826         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
827         Document summary and add closing brace '}' to both Frame and Document summary strings to make
828         them look pretty.
829
830         * lldb/lldb_webkit.py:
831         (WebCoreFrame_SummaryProvider):
832         (WebCoreDocument_SummaryProvider):
833
834 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
835
836         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
837         https://bugs.webkit.org/show_bug.cgi?id=191240
838         <rdar://problem/44872806>
839
840         Reviewed by Tim Horton.
841
842         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
843         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
844         overriding `-[WKWebView inputAssistantItem]`.
845
846         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
847         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
848         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
849         (+[InputAssistantItemTestingWebView barButtonIcon]):
850         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
851         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
852         (-[InputAssistantItemTestingWebView inputAssistantItem]):
853         (TestWebKitAPI::TEST):
854
855 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
856
857         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
858         https://bugs.webkit.org/show_bug.cgi?id=191226
859         <rdar://problem/45781765>
860
861         Reviewed by Tim Horton.
862
863         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
864         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
865
866         * WebKitTestRunner/TestOptions.h:
867         (WTR::TestOptions::hasSameInitializationOptions const):
868
869 2018-11-05  Commit Queue  <commit-queue@webkit.org>
870
871         Unreviewed, rolling out r237784 and r237788.
872         https://bugs.webkit.org/show_bug.cgi?id=191270
873
874         Caused mediastream layout test failures (Requested by
875         ryanhaddad on #webkit).
876
877         Reverted changesets:
878
879         "[MediaStream] User should not be prompted again after denying
880         getDisplayMedia request"
881         https://bugs.webkit.org/show_bug.cgi?id=191227
882         https://trac.webkit.org/changeset/237784
883
884         "[MediaStream] User should not be prompted again after denying
885         getDisplayMedia request"
886         https://bugs.webkit.org/show_bug.cgi?id=191227
887         https://trac.webkit.org/changeset/237788
888
889 2018-11-05  Lucas Forschler  <lforschler@apple.com>
890
891         https://bugs.webkit.org/show_bug.cgi?id=191268
892         Remove unused bots.
893
894         rubber-stamped by Alexey Proskuryakov.
895
896         * BuildSlaveSupport/build.webkit.org-config/config.json:
897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
898         (WebKitBuildbot):
899
900 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
901
902         [WPE][GTK] API test runner fails to respect default build type
903         https://bugs.webkit.org/show_bug.cgi?id=190247
904
905         Reviewed by Carlos Garcia Campos.
906
907         Problem is it's looking for a release build, even though I've run set-webkit-configuration
908         --debug. It should look for a debug build unless I explicitly pass --release.
909
910         * glib/api_test_runner.py:
911         (TestRunner.__init__):
912
913 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
914
915         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
916         https://bugs.webkit.org/show_bug.cgi?id=190674
917
918         Reviewed by Philippe Normand.
919
920         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
921         it can use to implement encoding for different formats exposing a trimmed down unified API.
922
923         It also adds proper handling of H264 profiles.
924
925         The added files follow GStreamer coding style as we aim at upstreaming the element
926         in the future.
927
928         Reviewed by Philippe Normand.
929
930         * Scripts/webkitpy/style/checker.py:
931
932 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
933
934         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
935         https://bugs.webkit.org/show_bug.cgi?id=191221
936
937         Reviewed by Carlos Garcia Campos.
938
939         This test ensures that MSE is disabled by default, but we now enable it by default, so
940         reverse the semantics of the test.
941
942         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
943         (testWebKitSettings):
944
945 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
946
947         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
948         https://bugs.webkit.org/show_bug.cgi?id=191225
949
950         Reviewed by Alejandro G. Castro.
951
952         Fix a memory leak causing this test to fail.
953
954         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
955         (WebViewTest::initializeWebView):
956
957 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
958
959         [webkitpy] Support WPE in the run-web-platform-tests script
960         https://bugs.webkit.org/show_bug.cgi?id=191183
961
962         Reviewed by Alex Christensen.
963
964         * Scripts/webkitpy/w3c/wpt_runner.py:
965         (parse_args): Support `--wpe` as an argument that specifies WPE as the
966         target port. Additionally, the `--display-server` flag now accepts
967         `headless` as a valid value, enabling the WPE WebDriver to run in
968         headless mode.
969
970 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
971
972         [Win] Use C++14, not C++17
973         https://bugs.webkit.org/show_bug.cgi?id=191101
974
975         Reviewed by Alex Christensen.
976
977         std::basic_string::data() returns a read-only const buffer in
978         C++14.
979
980         * MiniBrowser/win/WebKitBrowserWindow.cpp:
981         (createString): Use std::vector instead of std::wstring.
982         (createUTF8String): Use std::vector instead of std::string.
983
984 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
985
986         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
987         https://bugs.webkit.org/show_bug.cgi?id=191231
988
989         Reviewed by Simon Fraser.
990
991         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
992         it can be shared between iOS-family and macOS platforms. See below for more details.
993
994         No change in behavior.
995
996         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
997         (WTR::UIScriptController::overridePreference):
998
999         Add a method stub for DumpRenderTree.
1000
1001         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1002         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1003         (WTR::UIScriptController::doAsyncTask):
1004         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1005
1006         Unify these method implementations.
1007
1008         (WTR::UIScriptController::removeViewFromWindow):
1009         (WTR::UIScriptController::addViewToWindow):
1010
1011         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1012         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1013         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1014         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1015
1016         (WTR::UIScriptController::overridePreference):
1017         (WTR::UIScriptController::findString):
1018         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1019
1020         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1021
1022         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1023         (WTR::UIScriptController::doAsyncTask): Deleted.
1024         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1025         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1026         (WTR::UIScriptController::findString): Deleted.
1027         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1028         (WTR::UIScriptController::addViewToWindow): Deleted.
1029         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1030         (WTR::UIScriptController::doAsyncTask): Deleted.
1031         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1032         (WTR::UIScriptController::overridePreference): Deleted.
1033         (WTR::UIScriptController::findString): Deleted.
1034         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1035         (WTR::UIScriptController::addViewToWindow): Deleted.
1036         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1037
1038 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1039
1040         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1041         https://bugs.webkit.org/show_bug.cgi?id=191227
1042         <rdar://problem/45784512>
1043
1044         Reviewed by Youenn Fablet.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1047         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1048         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1049         (TestWebKitAPI::TEST_F):
1050
1051 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1052
1053         [LFC][BFC] Add support for percentage height in quirks mode.
1054         https://bugs.webkit.org/show_bug.cgi?id=191232
1055
1056         Reviewed by Antti Koivisto.
1057
1058         * LayoutReloaded/misc/LFC-passing-tests.txt:
1059
1060 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1061
1062         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1063         https://bugs.webkit.org/show_bug.cgi?id=191229
1064
1065         Reviewed by Antti Koivisto.
1066
1067         * LayoutReloaded/misc/LFC-passing-tests.txt:
1068
1069 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1070
1071         [LFC][BFC] Resolve percentage height values.
1072         https://bugs.webkit.org/show_bug.cgi?id=191224
1073
1074         Reviewed by Antti Koivisto.
1075
1076         * LayoutReloaded/misc/LFC-passing-tests.txt:
1077
1078 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1079
1080         Mac production builds should sign the network process xpc service with entitlements
1081         https://bugs.webkit.org/show_bug.cgi?id=191209
1082         <rdar://problem/45377609>
1083
1084         Reviewed by Geoff Garen.
1085
1086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1087         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1088         (TEST):
1089
1090 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1091
1092         Unreviewed, rolling out r237761.
1093
1094         Makes most API tests timeout and WK2 tests crash
1095
1096         Reverted changeset:
1097
1098         "Mac production builds should sign the network process xpc
1099         service with entitlements"
1100         https://bugs.webkit.org/show_bug.cgi?id=191209
1101         https://trac.webkit.org/changeset/237761
1102
1103 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1104
1105         Unreviewed API test gardening
1106
1107         * TestWebKitAPI/glib/TestExpectations.json:
1108
1109 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1110
1111         Add new global object and preliminary Worklets support for CSS painting api
1112         https://bugs.webkit.org/show_bug.cgi?id=190979
1113
1114         Reviewed by Chris Dumez.
1115
1116         * Scripts/webkitpy/bindings/main.py:
1117         (BindingsTests.generate_supplemental_dependency):
1118         (BindingsTests.main):
1119
1120 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1121
1122         Mac production builds should sign the network process xpc service with entitlements
1123         https://bugs.webkit.org/show_bug.cgi?id=191209
1124         <rdar://problem/45377609>
1125
1126         Reviewed by Geoff Garen.
1127
1128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1129         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1130         (TEST):
1131
1132 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1133
1134         Add Windows 10 archive bots
1135         https://bugs.webkit.org/show_bug.cgi?id=190964
1136         
1137         This Change updates the Apple Windows Buildbot configuration.
1138         - Add Windows 10 specific builders and testers for release and debug.
1139         - Refactor Windows -> Windows 7.
1140         - Remove Windows 7 Debug.
1141
1142         Reviewed by Aakash Jain.
1143
1144         * BuildSlaveSupport/build.webkit.org-config/config.json:
1145
1146 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1147
1148         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1149
1150         Rubber-stamped by Michael Catanzaro.
1151
1152         This variable is useful to get rid of shell color escapes in tests stderr files.
1153
1154         * Scripts/webkitpy/port/gtk.py:
1155         (GtkPort.setup_environ_for_server):
1156         * Scripts/webkitpy/port/wpe.py:
1157         (WPEPort.setup_environ_for_server):
1158
1159 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1160
1161         Add Basic Django web app for OpenSource EWS
1162         https://bugs.webkit.org/show_bug.cgi?id=191091
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1167         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1168         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1169         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1170         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1171         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1172         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1173         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1174         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1175         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1176         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1177         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1178         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1179         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1180
1181 2018-11-02  Daniel Bates  <dabates@apple.com>
1182
1183         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1184         https://bugs.webkit.org/show_bug.cgi?id=190487
1185
1186         Reviewed by Tim Horton.
1187
1188         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1189         match my observations when using the simulator to simulate iOS 12 and add support for testing
1190         right-hand side modifiers.
1191
1192         * DumpRenderTree/mac/EventSendingController.mm:
1193         (modifierFlags):
1194         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1195         (-[EventSendingController setTouchModifier:value:]):
1196         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1197         (hidUsageCodeForCharacter):
1198
1199 2018-11-02  Chris Dumez  <cdumez@apple.com>
1200
1201         [PSON] Reuse SuspendedPages' process when possible, for performance
1202         https://bugs.webkit.org/show_bug.cgi?id=191166
1203
1204         Reviewed by Geoffrey Garen.
1205
1206         Add API test coverage.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1209
1210 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1211
1212         [LFC][IFC] Add support for intrinsic width calculation
1213         https://bugs.webkit.org/show_bug.cgi?id=191144
1214
1215         Reviewed by Antti Koivisto.
1216
1217         * LayoutReloaded/misc/LFC-passing-tests.txt:
1218
1219 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1220
1221         [Apache] Self-signed SSL certificate RSA key is considered too weak
1222         https://bugs.webkit.org/show_bug.cgi?id=191156
1223
1224         Reviewed by Michael Catanzaro.
1225
1226         * Scripts/webkitpy/common/system/pemfile.py:
1227
1228 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1229
1230         Unreviewed follow-up to r237678.
1231
1232         * wpe/jhbuild.modules: The patch element apparently has to be a child
1233         of the branch in order for Jhbuild to properly detect and apply the
1234         patch file.
1235
1236 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1237
1238         build-jsc --wincairo should update WinCairo libraries
1239         https://bugs.webkit.org/show_bug.cgi?id=191170
1240
1241         Reviewed by Fujii Hironori.
1242
1243         * Scripts/build-jsc:
1244
1245 2018-11-01  John Wilander  <wilander@apple.com>
1246
1247         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1248         https://bugs.webkit.org/show_bug.cgi?id=191119
1249         <rdar://problem/44176965>
1250
1251         Reviewed by Chris Dumez.
1252
1253         This is an API test for a WebKitLegacy WebView that is first closed and then
1254         JavaScript is handed a keyboard event.
1255
1256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1257         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1258         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1259         (-[KeyboardEventListener handleEvent:]):
1260         (TestWebKitAPI::TEST):
1261
1262 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1263
1264         Add a storage limit for IndexedDB
1265         https://bugs.webkit.org/show_bug.cgi?id=190598
1266         <rdar://problem/44654715>
1267
1268         Reviewed by Chris Dumez.
1269
1270         Add API for testing.
1271
1272         * DumpRenderTree/TestRunner.cpp:
1273         (setIDBPerOriginQuotaCallback):
1274         (TestRunner::staticFunctions):
1275         * DumpRenderTree/TestRunner.h:
1276         * DumpRenderTree/mac/TestRunnerMac.mm:
1277         (TestRunner::setIDBPerOriginQuota):
1278         * DumpRenderTree/win/TestRunnerWin.cpp:
1279         (TestRunner::setIDBPerOriginQuota):
1280         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1282         (WTR::TestRunner::setIDBPerOriginQuota):
1283         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1284         * WebKitTestRunner/TestController.cpp:
1285         (WTR::TestController::setIDBPerOriginQuota):
1286         * WebKitTestRunner/TestController.h:
1287         * WebKitTestRunner/TestInvocation.cpp:
1288         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1289
1290 2018-11-01  Chris Dumez  <cdumez@apple.com>
1291
1292         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
1293         https://bugs.webkit.org/show_bug.cgi?id=191076
1294
1295         Reviewed by Geoffrey Garen.
1296
1297         Add API test coverage.
1298
1299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1300         (-[PSONNavigationDelegate init]):
1301         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1302
1303 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
1304
1305         Fix build with VIDEO and WEB_AUDIO disabled
1306         https://bugs.webkit.org/show_bug.cgi?id=191147
1307         <rdar://problem/45726710>
1308
1309         Unreviewed build fix.
1310
1311         This adds the missing compilation guards in the WPE MiniBrowser.
1312
1313         * MiniBrowser/wpe/main.cpp:
1314         (main): Condition GST includes and calls.
1315
1316 2018-10-31  Zalan Bujtas  <zalan@apple.com>
1317
1318         [LFC][IFC] Add support for inline-block elements.
1319         https://bugs.webkit.org/show_bug.cgi?id=191143
1320
1321         Reviewed by Antti Koivisto.
1322
1323         * LayoutReloaded/misc/LFC-passing-tests.txt:
1324
1325 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1326
1327         [WPE] Add missing libsoup patch to jhbuild
1328         https://bugs.webkit.org/show_bug.cgi?id=191149
1329
1330         Reviewed by Žan Doberšek.
1331
1332         * wpe/jhbuild.modules:
1333         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1334
1335 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1336
1337         Fix build with VIDEO and WEB_AUDIO disabled
1338         https://bugs.webkit.org/show_bug.cgi?id=191147
1339
1340         Reviewed by Philippe Normand.
1341
1342         * MiniBrowser/gtk/main.c:
1343         (main): Condition GST includes and calls
1344
1345 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
1346
1347         Add Justin Michaud to the list of WebKit Committers
1348         https://bugs.webkit.org/show_bug.cgi?id=191142
1349
1350         * Scripts/webkitpy/common/config/contributors.json:
1351
1352 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
1353
1354         Don't run JIT tests on 32-bit platforms
1355         https://bugs.webkit.org/show_bug.cgi?id=191074
1356
1357         Reviewed by Michael Catanzaro.
1358
1359         * Scripts/run-jsc-stress-tests:
1360
1361 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1362
1363         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
1364         https://bugs.webkit.org/show_bug.cgi?id=190530
1365         <rdar://problem/45232149>
1366
1367         Reviewed by Tim Horton.
1368
1369         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
1370         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
1371         is equivalent to the original file wrappers used to insert attachments in the first web view.
1372
1373         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
1374         is still backed by the same NSFileWrapper instance.
1375
1376         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1377         (TestWebKitAPI::TEST):
1378
1379 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1380
1381         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
1382         https://bugs.webkit.org/show_bug.cgi?id=190949
1383
1384         Reviewed by Alex Christensen.
1385
1386         Visual Studio 2017 Community is the alternative.
1387
1388         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
1389         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
1390         (buildVisualStudioProject): Ditto.
1391         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
1392         (usingVisualStudioExpress): Deleted.
1393
1394 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1395
1396         [Win][Direct2D] Support building DumpRenderTree for Direct2D
1397         https://bugs.webkit.org/show_bug.cgi?id=191093
1398         <rdar://problem/45685706>
1399
1400         Unreviewed build fix.
1401
1402         error C2065: 'renderTarget': undeclared identifier
1403
1404         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1405         (createBitmapContextFromWebView): Restored the previous implementation.
1406
1407 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
1408
1409         [PlayStation] Enable JavaScriptCore
1410         https://bugs.webkit.org/show_bug.cgi?id=191072
1411
1412         Reviewed by Brent Fulgham.
1413
1414         Add platform scripts for building the PlayStation port.
1415         perl Tools/Scripts/build-webkit --playstation
1416
1417         * Scripts/build-webkit:
1418         * Scripts/build-webkittestrunner:
1419         * Scripts/webkitdirs.pm:
1420         (argumentsForConfiguration):
1421         (determineConfigurationProductDir):
1422         (isPlayStation): Added.
1423         (getMSBuildPlatformArgument): Added.
1424         (buildVisualStudioProject):
1425         (wrapperPrefixIfNeeded):
1426         (generateBuildSystemFromCMakeProject):
1427         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
1428
1429 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
1430
1431         [Win][Direct2D] Support building DumpRenderTree for Direct2D
1432         https://bugs.webkit.org/show_bug.cgi?id=191093
1433         <rdar://problem/45685706>
1434
1435         Reviewed by Alex Christensen.
1436
1437         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
1438         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
1439         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
1440         (pixelDumpSystemFactory): Added.
1441         (printPNG): Create stub.
1442         (computeMD5HashStringForBitmapContext): Ditto.
1443         (dumpBitmap): Ditto.
1444         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
1445         (BitmapContext::createByAdoptingBitmapAndContext):
1446         (BitmapContext::~BitmapContext):
1447         (BitmapContext::platformContext const):
1448         (BitmapContext::BitmapContext):
1449         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1450         (createBitmapContextFromWebView): Update to support Direct2D.
1451         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
1452         logo is no longer available at this location. Switch to the new logo.
1453
1454 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
1455
1456         webkitpy: Support alternate simctl list outputs
1457         https://bugs.webkit.org/show_bug.cgi?id=191090
1458         <rdar://problem/45684255>
1459
1460         Rubber-stamped by Aakash Jain.
1461
1462         * Scripts/webkitpy/xcode/simulated_device.py:
1463         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
1464         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
1465         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1466         (test_available_devices): Add iOS 12 with alternative availability format.
1467
1468 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1469
1470         Clean up some obsolete MAX_ALLOWED macros
1471         https://bugs.webkit.org/show_bug.cgi?id=190916
1472
1473         Reviewed by Tim Horton.
1474
1475         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
1476         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1477         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1478
1479 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
1480
1481         [GTK][WPE] Fixes to the PublicSuffix implementation
1482         https://bugs.webkit.org/show_bug.cgi?id=191031
1483
1484         Reviewed by Michael Catanzaro.
1485
1486         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
1487         (TestWebKitAPI::TEST_F): Remove a test for a domain
1488         that is not registrable and shouldn't be tested there.
1489
1490 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1491
1492         Modernize WebKit nibs and lprojs for localization's sake
1493         https://bugs.webkit.org/show_bug.cgi?id=190911
1494         <rdar://problem/45349466>
1495
1496         Reviewed by Dan Bernstein.
1497
1498         * Scripts/check-inspector-strings:
1499         * Scripts/update-webkit-localizable-strings:
1500         * gtk/manifest.txt.in:
1501         * wpe/manifest.txt.in:
1502         English->en
1503
1504 2018-10-29  Daniel Bates  <dabates@apple.com>
1505
1506         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
1507         https://bugs.webkit.org/show_bug.cgi?id=191036
1508
1509         Reviewed by Andy Estes.
1510
1511         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
1512         by an enum that contains two or more enumerators with the same value. For example, suppose
1513         you have the following enum:
1514
1515         enum Flag {
1516             A = 1 << 0,
1517             AAlias = A,
1518         };
1519
1520         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
1521         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
1522         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
1523         tend to be used in bounds checks as opposed to code that adds to a set.
1524
1525         * lldb/lldbWebKitTester/main.cpp:
1526         (testSummaryProviders):
1527         * lldb/lldb_webkit.py:
1528         (WTFOptionSetProvider.update):
1529         * lldb/lldb_webkit_unittest.py:
1530         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
1531         (TestSummaryProviders):
1532         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
1533
1534 2018-10-29  Daniel Bates  <dabates@apple.com>
1535
1536         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
1537         https://bugs.webkit.org/show_bug.cgi?id=191033
1538
1539         Reviewed by Andy Estes.
1540
1541         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
1542         We display the same details in the summary for a Frame because its Document tends to be the most
1543         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
1544         and whether the origin has universal access.
1545
1546         * lldb/lldb_webkit.py:
1547         (__lldb_init_module):
1548         Register new summary providers.
1549
1550         (WebCoreSecurityOrigin_SummaryProvider):
1551         (WebCoreFrame_SummaryProvider):
1552         (WebCoreDocument_SummaryProvider):
1553         Add new summary providers.
1554
1555         (StdOptionalWrapper):
1556         (StdOptionalWrapper.__init__):
1557         (StdOptionalWrapper.has_value):
1558         (StdOptionalWrapper.value):
1559         Convenience data type that provides access to the fields of a std::optional<>.
1560         
1561         (WebCoreSecurityOriginProvider):
1562         (WebCoreSecurityOriginProvider.__init__):
1563         (WebCoreSecurityOriginProvider.is_unique):
1564         (WebCoreSecurityOriginProvider.scheme):
1565         (WebCoreSecurityOriginProvider.host):
1566         (WebCoreSecurityOriginProvider.port):
1567         (WebCoreSecurityOriginProvider.domain):
1568         (WebCoreSecurityOriginProvider.has_universal_access):
1569         (WebCoreSecurityOriginProvider.to_string):
1570         (WebCoreFrameProvider):
1571         (WebCoreFrameProvider.__init__):
1572         (WebCoreFrameProvider.is_main_frame):
1573         (WebCoreFrameProvider.document):
1574         (WebCoreDocumentProvider):
1575         (WebCoreDocumentProvider.__init__):
1576         (WebCoreDocumentProvider.url):
1577         (WebCoreDocumentProvider.origin):
1578         (WebCoreDocumentProvider.page_cache_state):
1579         (WebCoreDocumentProvider.frame):
1580
1581 2018-10-29  Chris Dumez  <cdumez@apple.com>
1582
1583         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
1584         https://bugs.webkit.org/show_bug.cgi?id=190975
1585         <rdar://problem/45059256>
1586
1587         Reviewed by Antti Koivisto.
1588
1589         Add API test coverage.
1590
1591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1592
1593 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1594
1595         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
1596         https://bugs.webkit.org/show_bug.cgi?id=191018
1597
1598         Reviewed by Antti Koivisto.
1599
1600         * LayoutReloaded/misc/LFC-passing-tests.txt:
1601
1602 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1603
1604         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
1605         https://bugs.webkit.org/show_bug.cgi?id=191011
1606
1607         Reviewed by Antti Koivisto.
1608
1609         * LayoutReloaded/misc/LFC-passing-tests.txt:
1610
1611 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1612
1613         Missing from r237549
1614
1615         Reviewed by Antti Koivisto.
1616
1617         * LayoutReloaded/misc/LFC-passing-tests.txt:
1618
1619 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1620
1621         [LFC][IFC] Add support for simple intruding floats.
1622         https://bugs.webkit.org/show_bug.cgi?id=190998
1623
1624         Reviewed by Antti Koivisto.
1625
1626         * LayoutReloaded/misc/LFC-passing-tests.txt:
1627
1628 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1629
1630         [LFC][IFC] Inline layout produces separate runs when float is present.
1631         https://bugs.webkit.org/show_bug.cgi?id=190980
1632
1633         Reviewed by Antti Koivisto.
1634
1635         * LayoutReloaded/misc/LFC-passing-tests.txt:
1636
1637 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
1638
1639         New bytecode format for JSC
1640         https://bugs.webkit.org/show_bug.cgi?id=187373
1641         <rdar://problem/44186758>
1642
1643         Reviewed by Filip Pizlo.
1644
1645         Do not force ENABLE_JIT=true when $forceCLoop is false.
1646
1647         * Scripts/build-jsc:
1648
1649 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
1650
1651         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
1652
1653         Unreviewed build fix
1654
1655         The build fails because of some array-bound check related
1656         to strcmp() macro optimizations. Disabling selective Werrors
1657         when building xserver-xorg might get past this.
1658
1659         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
1660         configuration.
1661
1662 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
1663
1664         [GTK] Update API test expectations after r237383
1665         https://bugs.webkit.org/show_bug.cgi?id=186913
1666
1667         Unreviewed gardening.
1668
1669         * TestWebKitAPI/glib/TestExpectations.json: Remove
1670         passing TestSSL tests.
1671
1672 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
1673
1674         [WPE] Add the WebKitVersion.h header
1675         https://bugs.webkit.org/show_bug.cgi?id=191015
1676
1677         Reviewed by Michael Catanzaro.
1678
1679         * MiniBrowser/wpe/main.cpp:
1680         (automationStartedCallback): Remove the FIXME and finally enable the
1681         webkit_application_info_set_version() call.
1682         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
1683         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
1684
1685 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1686
1687         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
1688         https://bugs.webkit.org/show_bug.cgi?id=190948
1689
1690         Reviewed by Brent Fulgham.
1691
1692         vcxproj files have been removed in Bug 154388.
1693
1694         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
1695         * Scripts/build-jsc:
1696         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
1697         which is not used because Windows ports are using CMake.
1698
1699 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
1700
1701         HashMap should support selecting a random entry
1702         https://bugs.webkit.org/show_bug.cgi?id=190814
1703
1704         Reviewed by Ryosuke Niwa.
1705
1706         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
1707         IsEvenlyDistributed to reflect the fact that we're only testing the
1708         distribution. Added a test case that covers more table densities and
1709         the remove() operation.
1710
1711 2018-10-27  Charlie Turner  <cturner@igalia.com>
1712
1713         [GTK] Add bubblewrap feature option
1714         https://bugs.webkit.org/show_bug.cgi?id=190981
1715
1716         Reviewed by Xabier Rodriguez-Calvar.
1717
1718         Without this, it was not possible to disable the bubblewrap sandbox
1719         from the webkit build scripts.
1720
1721         * Scripts/webkitperl/FeatureList.pm:
1722
1723 2018-10-26  Commit Queue  <commit-queue@webkit.org>
1724
1725         Unreviewed, rolling out r237479 and r237484.
1726         https://bugs.webkit.org/show_bug.cgi?id=190978
1727
1728         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
1729
1730         Reverted changesets:
1731
1732         "New bytecode format for JSC"
1733         https://bugs.webkit.org/show_bug.cgi?id=187373
1734         https://trac.webkit.org/changeset/237479
1735
1736         "Gardening: Build fix after r237479."
1737         https://bugs.webkit.org/show_bug.cgi?id=187373
1738         https://trac.webkit.org/changeset/237484
1739
1740 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
1741
1742         New bytecode format for JSC
1743         https://bugs.webkit.org/show_bug.cgi?id=187373
1744         <rdar://problem/44186758>
1745
1746         Reviewed by Filip Pizlo.
1747
1748         Do not force ENABLE_JIT=true when $forceCLoop is false.
1749
1750         * Scripts/build-jsc:
1751
1752 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
1753
1754         HashMap should support selecting a random entry
1755         https://bugs.webkit.org/show_bug.cgi?id=190814
1756
1757         Reviewed by Antti Koivisto.
1758
1759         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
1760         more thoroughly test for randomness.
1761
1762 2018-10-26  Antti Koivisto  <antti@apple.com>
1763
1764         hashSet.remove(hashSet.random()) doesn't build
1765         https://bugs.webkit.org/show_bug.cgi?id=190953
1766
1767         Reviewed by Chris Dumez.
1768
1769         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1770         (TestWebKitAPI::TEST):
1771
1772 2018-10-26  Zalan Bujtas  <zalan@apple.com>
1773
1774         [LFC][IFC] Layout floats as part of the inline content
1775         https://bugs.webkit.org/show_bug.cgi?id=190942
1776
1777         Reviewed by Antti Koivisto.
1778
1779         * LayoutReloaded/misc/LFC-passing-tests.txt:
1780
1781 2018-10-26  Alicia Boya García  <aboya@igalia.com>
1782
1783         [MSE][WTF][Media] Invalid MediaTime should be falsy
1784         https://bugs.webkit.org/show_bug.cgi?id=190893
1785
1786         Reviewed by Jer Noble.
1787
1788         This patch adds additional API tests for the conversions from
1789         MediaTime to boolean.
1790
1791         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1792         (TestWebKitAPI::TEST):
1793
1794 2018-10-25  Chris Dumez  <cdumez@apple.com>
1795
1796         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
1797         https://bugs.webkit.org/show_bug.cgi?id=190915
1798         <rdar://problem/45059069>
1799
1800         Reviewed by Geoffrey Garen.
1801
1802         Add API test coverage.
1803
1804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1805
1806 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
1807
1808         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
1809         https://bugs.webkit.org/show_bug.cgi?id=190896
1810
1811         Reviewed by Matt Baker.
1812
1813         * Scripts/webkitpy/common/config/watchlist:
1814
1815 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
1816
1817         HashMap should support selecting a random entry
1818         https://bugs.webkit.org/show_bug.cgi?id=190814
1819
1820         Reviewed by Antti Koivisto.
1821
1822         Unit testing is fun and easy!
1823
1824         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1825         (TestWebKitAPI::ZeroHash::hash):
1826         (TestWebKitAPI::TEST):
1827
1828 2018-10-24  Tim Horton  <timothy_horton@apple.com>
1829
1830         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
1831         https://bugs.webkit.org/show_bug.cgi?id=190897
1832
1833         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1834         (TestWebKitAPI::TEST):
1835         Disable the test for now.
1836
1837 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1838
1839         Clean up some obsolete macOS version guards
1840         https://bugs.webkit.org/show_bug.cgi?id=190887
1841
1842         Reviewed by Dan Bernstein.
1843
1844         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1845         (__simulated_forceClickAssociatedEventsMask):
1846         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
1847         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1848         (WTR::initializeWebViewConfiguration):
1849         * WebKitTestRunner/mac/EventSenderProxy.mm:
1850         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1851
1852 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1853
1854         Turn on Conic Gradients
1855         https://bugs.webkit.org/show_bug.cgi?id=190810
1856
1857         Reviewed by Tim Horton.
1858
1859         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1860
1861 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
1862
1863         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
1864         https://bugs.webkit.org/show_bug.cgi?id=190328
1865
1866         Reviewed by Michael Catanzaro.
1867
1868         * TestWebKitAPI/CMakeLists.txt:
1869         * TestWebKitAPI/PlatformWPE.cmake:
1870
1871 2018-10-24  Chris Dumez  <cdumez@apple.com>
1872
1873         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
1874         https://bugs.webkit.org/show_bug.cgi?id=190846
1875         <rdar://problem/45058938>
1876
1877         Reviewed by Antti Koivisto.
1878
1879         Add API test coverage.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1882
1883 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
1884
1885         [GTK] TestSSL failing because of missing libsoup patch
1886         https://bugs.webkit.org/show_bug.cgi?id=190869
1887
1888         Reviewed by Michael Catanzaro.
1889
1890         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
1891         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1892
1893 2018-10-23  Justin Fan  <justin_fan@apple.com>
1894
1895         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
1896         https://bugs.webkit.org/show_bug.cgi?id=190817
1897
1898         Reviewed by Dean Jackson.
1899
1900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1901         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
1902         (TestWebKitAPI::TEST_F):
1903         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1904         (TestWebKitAPI::TEST_F):
1905         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
1906         (TestWebKitAPI::TEST_F):
1907         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1908         (TestWebKitAPI::TEST_F):
1909         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
1910         (TestWebKitAPI::TEST_F):
1911         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
1912
1913 2018-10-23  Chris Dumez  <cdumez@apple.com>
1914
1915         [PSON] Add support for cross-site client-side redirects
1916         https://bugs.webkit.org/show_bug.cgi?id=190806
1917         <rdar://problem/45047344>
1918
1919         Reviewed by Geoffrey Garen.
1920
1921         Add API test coverage.
1922
1923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1924         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
1925         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
1926
1927 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
1928
1929         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
1930         https://bugs.webkit.org/show_bug.cgi?id=190789
1931
1932         Reviewed by Michael Catanzaro.
1933
1934         When the network process serializes certificate data to other
1935         processes through the argument coders, the certificate chain, if
1936         present, is lost. In practice this means that applications using
1937         the public API to process certificate info have no details on the
1938         certificate chain, other than the very basics included in the
1939         certificate. Serialize the entire chain if available in the
1940         certificate.
1941
1942         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1943         (testSSL): Test that the self-signed certificate has no bogus
1944         issuer certificate.
1945
1946 2018-10-22  Tim Horton  <timothy_horton@apple.com>
1947
1948         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
1949         https://bugs.webkit.org/show_bug.cgi?id=190801
1950         <rdar://problem/43674361>
1951
1952         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1953         (TEST):
1954         Use a parented WKWebView for this test, otherwise none of the assertions
1955         about gesture recognizers work anymore.
1956
1957 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
1958
1959         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
1960         https://bugs.webkit.org/show_bug.cgi?id=187972
1961
1962         Unreviewed test gardening.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1965         (TestWebKitAPI::TEST): Disable the flaky test.
1966
1967 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1968
1969         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
1970         https://bugs.webkit.org/show_bug.cgi?id=190777
1971
1972         Reviewed by Tim Horton.
1973
1974         Implement isShowingDataListSuggestions on iOS. See below for more details.
1975
1976         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1977         (WTR::UIScriptController::isShowingDataListSuggestions const):
1978
1979         Add a stub implementation for DumpRenderTree.
1980
1981         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1982         (WTR::UIScriptController::isShowingDataListSuggestions const):
1983
1984         Move this stub implementation to !PLATFORM(COCOA).
1985
1986         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1987         (WTR::forEachViewInHierarchy):
1988
1989         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
1990
1991         (WTR::UIScriptController::isShowingDataListSuggestions const):
1992
1993         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
1994
1995 2018-10-19  Dan Bernstein  <mitz@apple.com>
1996
1997         [macOS] MiniBrowser has an unused injected bundle
1998         https://bugs.webkit.org/show_bug.cgi?id=190770
1999
2000         Reviewed by Tim Horton.
2001
2002         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2003         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2004           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2005         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2006         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2007         * MiniBrowser/mac/Bundle: Removed.
2008
2009 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2010
2011         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2012         https://bugs.webkit.org/show_bug.cgi?id=190621
2013         <rdar://problem/45310649>
2014
2015         Reviewed by Tim Horton.
2016
2017         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2018
2019         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2020         (WTR::UIScriptController::resignFirstResponder):
2021         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2022         (WTR::UIScriptController::resignFirstResponder):
2023         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2024         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2025         (WTR::UIScriptController::resignFirstResponder):
2026         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2027         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2028         (WTR::UIScriptController::resignFirstResponder):
2029         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2030         (WTR::PlatformWebView::makeWebViewFirstResponder):
2031
2032         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2033         responder on the WKWebView when running iOS layout tests.
2034
2035         * WebKitTestRunner/ios/TestControllerIOS.mm:
2036         (WTR::TestController::platformResetStateToConsistentValues):
2037
2038         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2039
2040 2018-10-19  Dean Jackson  <dino@apple.com>
2041
2042         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2043         https://bugs.webkit.org/show_bug.cgi?id=186946
2044         <rdar://problem/41724248>
2045
2046         Reviewed by Antoine Quint.
2047
2048         If the incoming test has different enableWebAnimationsCSSIntegration options,
2049         then we need to create a new WebView.
2050
2051         * DumpRenderTree/TestOptions.cpp:
2052         (TestOptions::webViewIsCompatibleWithOptions const):
2053
2054 2018-10-19  Charlie Turner  <cturner@igalia.com>
2055
2056         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2057         https://bugs.webkit.org/show_bug.cgi?id=190738
2058
2059         Reviewed by Xabier Rodriguez-Calvar.
2060
2061         Add a GStreamer patch to avoid crashing when the run-time logging
2062         level is TRACE. There was a missing null check which caused many
2063         tests to crash.
2064
2065         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2066
2067 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2068
2069         [Media] Use nanoseconds as MaximumTimeScale
2070         https://bugs.webkit.org/show_bug.cgi?id=190631
2071
2072         Rebased MediaTime tests covering timescales over the maximum.
2073
2074         Reviewed by Jer Noble.
2075
2076         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2077         (TestWebKitAPI::TEST):
2078
2079 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2080
2081         clean-webkit pulls in many unnecessary dependencies in webkitpy
2082         https://bugs.webkit.org/show_bug.cgi?id=190732
2083
2084         Reviewed by Alexey Proskuryakov.
2085
2086         * Scripts/webkitpy/common/host.py:
2087         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2088         (Host):
2089         (Host.bugs):
2090         (Host.bugzilla):
2091         (Host.web):
2092
2093 2018-10-18  Chris Dumez  <cdumez@apple.com>
2094
2095         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2096         https://bugs.webkit.org/show_bug.cgi?id=190721
2097         <rdar://problem/45059699>
2098
2099         Reviewed by Alex Christensen.
2100
2101         Add API test coverage.
2102
2103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2104
2105 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2106
2107         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2108         https://bugs.webkit.org/show_bug.cgi?id=190729
2109
2110         Reviewed by Tim Horton.
2111
2112         * DumpRenderTree/AccessibilityController.h:
2113         * DumpRenderTree/AccessibilityTextMarker.h:
2114         * DumpRenderTree/AccessibilityUIElement.cpp:
2115         (AccessibilityUIElement::getJSClass):
2116         * DumpRenderTree/AccessibilityUIElement.h:
2117         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2118         * DumpRenderTree/TestRunner.cpp:
2119         (getSecureEventInputIsEnabledCallback):
2120         (TestRunner::staticFunctions):
2121         (TestRunner::callUIScriptCallback):
2122         * DumpRenderTree/TestRunner.h:
2123         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2124         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2125         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2126         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2127         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2128         * DumpRenderTree/ios/TextInputControllerIOS.m:
2129         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2130         * DumpRenderTree/mac/AppleScriptController.m:
2131         * DumpRenderTree/mac/DumpRenderTree.mm:
2132         (createWebViewAndOffscreenWindow):
2133         (destroyWebViewAndOffscreenWindow):
2134         (resetWebPreferencesToConsistentValues):
2135         (setDefaultsToConsistentValuesForTesting):
2136         (allocateGlobalControllers):
2137         (releaseGlobalControllers):
2138         (addTestPluginsToPluginSearchPath):
2139         (prepareConsistentTestingEnvironment):
2140         (dumpRenderTree):
2141         (DumpRenderTreeMain):
2142         (dumpFrameAsPDF):
2143         (dumpBackForwardListForAllWindows):
2144         (updateDisplay):
2145         (dump):
2146         (resetWebViewToConsistentStateBeforeTesting):
2147         (runTest):
2148         (displayWebView):
2149         (displayAndTrackRepaintsWebView):
2150         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2151         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2152         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2153         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2154         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2155         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2156         (-[DumpRenderTreeWindow close]):
2157         (-[DumpRenderTreeWindow webView]):
2158         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2159         * DumpRenderTree/mac/EventSendingController.h:
2160         * DumpRenderTree/mac/EventSendingController.mm:
2161         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2162         (+[EventSendingController webScriptNameForSelector:]):
2163         (-[EventSendingController dealloc]):
2164         (-[EventSendingController currentEventTime]):
2165         (-[EventSendingController clearKillRing]):
2166         (modifierFlags):
2167         (-[EventSendingController mouseDown:withModifiers:]):
2168         (-[EventSendingController scalePageBy:atX:andY:]):
2169         (-[EventSendingController mouseUp:withModifiers:]):
2170         (-[EventSendingController mouseMoveToX:Y:]):
2171         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2172         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2173         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2174         (-[FrameLoadDelegate init]):
2175         (-[FrameLoadDelegate dealloc]):
2176         (-[FrameLoadDelegate processWork:]):
2177         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2178         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2179         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2180         * DumpRenderTree/mac/LayoutTestHelper.m:
2181         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2182         (-[MockGeolocationProvider timerFired]):
2183         * DumpRenderTree/mac/TestRunnerMac.mm:
2184         (TestRunner::setMainFrameIsFirstResponder):
2185         (TestRunner::setAutomaticLinkDetectionEnabled):
2186         (TestRunner::setUseDashboardCompatibilityMode):
2187         (TestRunner::isCommandEnabled):
2188         (TestRunner::inspectorTestStubURL):
2189         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2190         (TestRunner::abortModal):
2191         (TestRunner::setTextDirection):
2192         (TestRunner::addChromeInputField):
2193         (TestRunner::removeChromeInputField):
2194         (TestRunner::focusWebView):
2195         (TestRunner::setBackingScaleFactor):
2196         (TestRunner::imageCountInGeneralPasteboard const):
2197         * DumpRenderTree/mac/UIDelegate.h:
2198         * DumpRenderTree/mac/UIDelegate.mm:
2199         (-[UIDelegate modalWindowWillClose:]):
2200         (-[UIDelegate webViewRunModal:]):
2201         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2202         (-[UIDelegate dealloc]):
2203         * Scripts/check-for-inappropriate-objc-class-names:
2204         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2205         * TestRunnerShared/spi/UIKitTestSPI.h:
2206         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2207         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2208         (WebCore::operator<<):
2209         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2210         (TestWebKitAPI::TEST):
2211         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2212         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2213         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2214         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2215         (TestWebKitAPI::TEST):
2216         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2217         (TestWebKitAPI::TEST):
2218         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2219         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2220         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2221         (TEST):
2222         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2223         (TEST):
2224         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2225         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2226         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2227         (TEST):
2228         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2229         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2230         (createWebViewWithCustomPasteboardDataEnabled):
2231         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2232         (TEST):
2233         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2234         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2235         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2236         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2237         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2238         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2239         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2240         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2241         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2242         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2243         (defaultWebsiteCacheDirectory):
2244         (defaultApplicationCacheDirectory):
2245         (TEST):
2246         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2247         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2248         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2249         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2250         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2251         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2252         (TestWebKitAPI::TEST):
2253         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2254         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2255         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2256         (runTestWithWidth):
2257         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2258         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2259         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2260         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2261         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2262         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2263         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2264         (platformCopyRichTextWithMultipleAttachments):
2265         (platformCopyRichTextWithImage):
2266         (platformCopyPNG):
2267         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2268         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2269         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2270         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2271         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2272         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2273         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2274         (TEST):
2275         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2276         (TEST):
2277         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2278         (TEST):
2279         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2280         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2281         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2282         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2283         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2284         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2285         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2286         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2287         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2288         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2289         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2290         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2291         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
2292         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2293         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2294         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2295         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2296         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
2297         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
2298         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2299         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
2300         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2301         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2302         (-[WKWebView _test_waitForDidFinishNavigation]):
2303         * TestWebKitAPI/cocoa/TestWKWebView.h:
2304         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2305         * TestWebKitAPI/config.h:
2306         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2307         * TestWebKitAPI/ios/TestWKWebViewController.h:
2308         * TestWebKitAPI/ios/TestWKWebViewController.mm:
2309         * TestWebKitAPI/ios/UIKitSPI.h:
2310         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2312         (WTR::InjectedBundle::beginTesting):
2313         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2314         (WTR::TestRunner::inspectorTestStubURL):
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::TestController::webProcessName):
2317         (WTR::TestController::networkProcessName):
2318         * WebKitTestRunner/TestInvocation.cpp:
2319         (WTR::TestInvocation::invoke):
2320         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2321         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2322         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2323         (WTR::initializeWebViewConfiguration):
2324         (WTR::TestController::platformCreateWebView):
2325         (WTR::TestController::imageCountInGeneralPasteboard const):
2326         (WTR::TestController::addTestKeyToKeychain):
2327         (WTR::TestController::cleanUpKeychain):
2328         (WTR::TestController::keyExistsInKeychain):
2329         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2330         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2331         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2332
2333 2018-10-18  Chris Dumez  <cdumez@apple.com>
2334
2335         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
2336         https://bugs.webkit.org/show_bug.cgi?id=190688
2337         <rdar://problem/45354095>
2338
2339         Reviewed by Antti Koivisto.
2340
2341         Extended API test coverage to confirm that:
2342         - We do not accumulate more than 3 suspended processes.
2343         - We can navigate back 3 times and use the page cache for each of these loads.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2346
2347 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2348
2349         Enable the datalist element by default on iOS and macOS
2350         https://bugs.webkit.org/show_bug.cgi?id=190594
2351         <rdar://problem/45281159>
2352
2353         Reviewed by Ryosuke Niwa and Tim Horton.
2354
2355         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2356
2357 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
2358
2359         AX: Certain tags should identify their context to iOS API
2360         https://bugs.webkit.org/show_bug.cgi?id=190622
2361         <rdar://problem/45308194>
2362
2363         Reviewed by Zalan Bujtas.
2364
2365         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2366         (AccessibilityUIElement::stringAttributeValue):
2367         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2368         (WTR::AccessibilityUIElement::stringAttributeValue):
2369
2370 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
2371
2372         Add a switch for Web SQL
2373         https://bugs.webkit.org/show_bug.cgi?id=190271
2374
2375         Reviewed by Ryosuke Niwa.
2376
2377         * WebKitTestRunner/TestController.cpp:
2378         (WTR::TestController::resetPreferencesToConsistentValues):
2379
2380 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2381
2382         Remove InjectedBundleBackForwardList
2383         https://bugs.webkit.org/show_bug.cgi?id=190640
2384
2385         Reviewed by Chris Dumez.
2386
2387         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2388         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
2389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2390         (WTR::InjectedBundlePage::prepare):
2391         (WTR::InjectedBundlePage::dumpHistory):
2392         (WTR::hasPrefix): Deleted.
2393         (WTR::compareByTargetName): Deleted.
2394         (WTR::dumpBackForwardListItem): Deleted.
2395         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
2396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2398         (WTR::TestRunner::clearBackForwardList):
2399
2400 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
2401
2402         Unreviewed, added myself to contributors.json.
2403
2404         * Scripts/webkitpy/common/config/contributors.json:
2405
2406 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2407
2408         Implement feature flag and bindings for CSS Painting API
2409         https://bugs.webkit.org/show_bug.cgi?id=190237
2410
2411         Reviewed by Ryosuke Niwa.
2412
2413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2414
2415 2018-10-16  Philippe Normand  <pnormand@igalia.com>
2416
2417         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
2418
2419         * gstreamer/jhbuild.modules:
2420
2421 2018-10-16  Philippe Normand  <pnormand@igalia.com>
2422
2423         [GTK][JHBuild] Disable libmount support in glib
2424
2425         Rubber-stamped by Alejandro G. Castro.
2426
2427         This feature doesn't seem required for our setup.
2428
2429         * gtk/jhbuild.modules:
2430
2431 2018-10-15  Justin Fan  <justin_fan@apple.com>
2432
2433         Add WebGPU 2018 feature flag and experimental feature flag
2434         https://bugs.webkit.org/show_bug.cgi?id=190509
2435
2436         Reviewed by Dean Jackson.
2437
2438         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2439         for the 2018 WebGPU prototype.
2440
2441         * DumpRenderTree/TestOptions.cpp:
2442         (TestOptions::TestOptions):
2443         * DumpRenderTree/TestOptions.h:
2444         * DumpRenderTree/mac/DumpRenderTree.mm:
2445         (setWebPreferencesForTestOptions):
2446         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2447
2448 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2449
2450         Update bot configuration for Sierra archive queues
2451         https://bugs.webkit.org/show_bug.cgi?id=190605
2452
2453         Reviewed by Aakash Jain.
2454
2455         * BuildSlaveSupport/build.webkit.org-config/config.json:
2456
2457 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2458
2459         Add support for prefers-color-scheme media query
2460         https://bugs.webkit.org/show_bug.cgi?id=190499
2461         rdar://problem/45212025
2462
2463         Reviewed by Dean Jackson.
2464
2465         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
2466         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2467
2468 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
2469
2470         [JHBuild] Add xdg-dbus-proxy module
2471         https://bugs.webkit.org/show_bug.cgi?id=190589
2472
2473         Reviewed by Michael Catanzaro.
2474
2475         * gtk/jhbuild.modules:
2476
2477 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
2478
2479         [GTK] Add new sandboxing dependencies to install-dependencies
2480         https://bugs.webkit.org/show_bug.cgi?id=190588
2481
2482         Reviewed by Michael Catanzaro.
2483
2484         * gtk/install-dependencies:
2485
2486 2018-10-15  Chris Dumez  <cdumez@apple.com>
2487
2488         Experiment: target=_blank on anchors should imply rel=noopener
2489         https://bugs.webkit.org/show_bug.cgi?id=190481
2490
2491         Reviewed by Alex Christensen.
2492
2493         Add API test coverage to make sure we can now swap process when target=_blank
2494         is specified on an anchor but rel=noopener is not.
2495
2496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2497
2498 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2499
2500         [iOS] Can't select text after dismissing the keyboard when changing focus
2501         https://bugs.webkit.org/show_bug.cgi?id=190563
2502         <rdar://problem/44613559>
2503
2504         Reviewed by Tim Horton.
2505
2506         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2507         (WTR::UIScriptController::isShowingKeyboard const):
2508
2509         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
2510         details.
2511
2512         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2513         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2514         (WTR::UIScriptController::isShowingKeyboard const):
2515         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2516         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2517         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2518
2519         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
2520         `isShowingKeyboard` as the getter method.
2521
2522         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2523         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2524         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2525         (WTR::UIScriptController::isShowingKeyboard const):
2526
2527 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2528
2529         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
2530
2531         * Scripts/run-javascriptcore-tests:
2532         (runJSCStressTests): Remove wsl-tests.yaml.
2533
2534 2018-10-15  Christopher Reid  <chris.reid@sony.com>
2535
2536         [Curl][WinCairo] Add Public Suffix support to WinCairo
2537         https://bugs.webkit.org/show_bug.cgi?id=183060
2538
2539         Reviewed by Alex Christensen.
2540
2541         Share mac's PublicSuffix tests with all ports.
2542
2543         * TestWebKitAPI/PlatformWin.cmake:
2544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2545         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2546         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
2547
2548 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
2549
2550         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
2551         https://bugs.webkit.org/show_bug.cgi?id=190555
2552
2553         Unreviewed.
2554
2555         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
2556
2557         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
2558         * WebGPUShadingLanguageRI/All.js: Removed.
2559         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
2560         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
2561         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
2562         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
2563         * WebGPUShadingLanguageRI/Assignment.js: Removed.
2564         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
2565         * WebGPUShadingLanguageRI/Block.js: Removed.
2566         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
2567         * WebGPUShadingLanguageRI/Break.js: Removed.
2568         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
2569         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
2570         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
2571         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
2572         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
2573         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
2574         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
2575         * WebGPUShadingLanguageRI/Casts.js: Removed.
2576         * WebGPUShadingLanguageRI/Check.js: Removed.
2577         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
2578         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
2579         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
2580         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
2581         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
2582         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
2583         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
2584         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
2585         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
2586         * WebGPUShadingLanguageRI/Checker.js: Removed.
2587         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
2588         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
2589         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
2590         * WebGPUShadingLanguageRI/Continue.js: Removed.
2591         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
2592         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
2593         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
2594         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
2595         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
2596         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
2597         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
2598         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
2599         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
2600         * WebGPUShadingLanguageRI/EPtr.js: Removed.
2601         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
2602         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
2603         * WebGPUShadingLanguageRI/EnumType.js: Removed.
2604         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
2605         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
2606         * WebGPUShadingLanguageRI/Expression.js: Removed.
2607         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
2608         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
2609         * WebGPUShadingLanguageRI/Field.js: Removed.
2610         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
2611         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
2612         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
2613         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
2614         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
2615         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
2616         * WebGPUShadingLanguageRI/Func.js: Removed.
2617         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
2618         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
2619         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
2620         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
2621         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
2622         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
2623         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
2624         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
2625         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
2626         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
2627         * WebGPUShadingLanguageRI/Inline.js: Removed.
2628         * WebGPUShadingLanguageRI/Inliner.js: Removed.
2629         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
2630         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
2631         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
2632         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
2633         * WebGPUShadingLanguageRI/Lexer.js: Removed.
2634         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
2635         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
2636         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
2637         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
2638         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
2639         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
2640         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
2641         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
2642         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
2643         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
2644         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
2645         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
2646         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
2647         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
2648         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
2649         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
2650         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
2651         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
2652         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
2653         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
2654         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
2655         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
2656         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
2657         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
2658         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
2659         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
2660         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
2661         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
2662         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
2663         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
2664         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
2665         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
2666         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
2667         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
2668         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
2669         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
2670         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
2671         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
2672         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
2673         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
2674         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
2675         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
2676         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
2677         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
2678         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
2679         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
2680         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
2681         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
2682         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
2683         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
2684         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
2685         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
2686         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
2687         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
2688         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
2689         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
2690         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
2691         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
2692         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
2693         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
2694         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
2695         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
2696         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
2697         * WebGPUShadingLanguageRI/NameContext.js: Removed.
2698         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
2699         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
2700         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
2701         * WebGPUShadingLanguageRI/NativeType.js: Removed.
2702         * WebGPUShadingLanguageRI/Node.js: Removed.
2703         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
2704         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
2705         * WebGPUShadingLanguageRI/NullType.js: Removed.
2706         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
2707         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
2708         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
2709         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
2710         * WebGPUShadingLanguageRI/Parse.js: Removed.
2711         * WebGPUShadingLanguageRI/Prepare.js: Removed.
2712         * WebGPUShadingLanguageRI/Program.js: Removed.
2713         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
2714         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
2715         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
2716         * WebGPUShadingLanguageRI/PtrType.js: Removed.
2717         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
2718         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
2719         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
2720         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
2721         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
2722         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
2723         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
2724         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
2725         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
2726         * WebGPUShadingLanguageRI/Return.js: Removed.
2727         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
2728         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
2729         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
2730         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
2731         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
2732         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
2733         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
2734         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
2735         * WebGPUShadingLanguageRI/Sampler.js: Removed.
2736         * WebGPUShadingLanguageRI/Semantic.js: Removed.
2737         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
2738         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
2739         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
2740         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
2741         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
2742         * WebGPUShadingLanguageRI/StructType.js: Removed.
2743         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
2744         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
2745         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
2746         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
2747         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
2748         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
2749         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
2750         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
2751         * WebGPUShadingLanguageRI/Test.html: Removed.
2752         * WebGPUShadingLanguageRI/Test.js: Removed.
2753         * WebGPUShadingLanguageRI/Texture.js: Removed.
2754         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
2755         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
2756         * WebGPUShadingLanguageRI/Type.js: Removed.
2757         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
2758         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
2759         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
2760         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
2761         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
2762         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
2763         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
2764         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
2765         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
2766         * WebGPUShadingLanguageRI/Value.js: Removed.
2767         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
2768         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
2769         * WebGPUShadingLanguageRI/VectorType.js: Removed.
2770         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
2771         * WebGPUShadingLanguageRI/Visitor.js: Removed.
2772         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
2773         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
2774         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
2775         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
2776         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
2777         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
2778         * WebGPUShadingLanguageRI/index.html: Removed.
2779         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
2780         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
2781
2782 2018-10-15  Philippe Normand  <pnormand@igalia.com>
2783
2784         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
2785         https://bugs.webkit.org/show_bug.cgi?id=190581
2786
2787         Reviewed by Michael Catanzaro.
2788
2789         These bots don't use JHBuild and their host GStreamer version is
2790         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
2791
2792         * BuildSlaveSupport/build.webkit.org-config/config.json:
2793
2794 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2795
2796         Use pragma once in WTF
2797         https://bugs.webkit.org/show_bug.cgi?id=190527
2798
2799         Reviewed by Chris Dumez.
2800
2801         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
2802
2803         * DumpRenderTree/TestRunner.cpp:
2804         (TestRunner::queueLoadHTMLString):
2805         (TestRunner::queueLoadAlternateHTMLString):
2806         (TestRunner::queueBackNavigation):
2807         (TestRunner::queueForwardNavigation):
2808         (TestRunner::queueLoadingScript):
2809         (TestRunner::queueNonLoadingScript):
2810         (TestRunner::queueReload):
2811         * DumpRenderTree/WorkQueue.cpp:
2812         (WorkQueue::singleton): Deleted.
2813         (WorkQueue::WorkQueue): Deleted.
2814         (WorkQueue::queue): Deleted.
2815         (WorkQueue::dequeue): Deleted.
2816         (WorkQueue::count): Deleted.
2817         (WorkQueue::clear): Deleted.
2818         (WorkQueue::processWork): Deleted.
2819         * DumpRenderTree/WorkQueue.h:
2820         (WorkQueue::setFrozen): Deleted.
2821         * DumpRenderTree/WorkQueueItem.h:
2822         * DumpRenderTree/mac/DumpRenderTree.mm:
2823         (runTest):
2824         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2825         (-[FrameLoadDelegate processWork:]):
2826         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2827         * DumpRenderTree/mac/TestRunnerMac.mm:
2828         (TestRunner::notifyDone):
2829         (TestRunner::forceImmediateCompletion):
2830         (TestRunner::queueLoad):
2831         * DumpRenderTree/win/DumpRenderTree.cpp:
2832         (runTest):
2833         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2834         (FrameLoadDelegate::processWork):
2835         (FrameLoadDelegate::locationChangeDone):
2836         * DumpRenderTree/win/TestRunnerWin.cpp:
2837         (TestRunner::notifyDone):
2838         (TestRunner::forceImmediateCompletion):
2839         (TestRunner::queueLoad):
2840
2841 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2842
2843         [JSC] Remove Option::useAsyncIterator
2844         https://bugs.webkit.org/show_bug.cgi?id=190567
2845
2846         Reviewed by Saam Barati.
2847
2848         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2849
2850 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
2851
2852         [WPE] Silence a unused-parameter warning
2853
2854         Unreviewed.
2855         * MiniBrowser/wpe/main.cpp:
2856         (decidePermissionRequest):
2857
2858 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
2859
2860         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
2861         https://bugs.webkit.org/show_bug.cgi?id=190537
2862
2863         Reviewed by Alexey Proskuryakov.
2864
2865         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
2866         needs to be split before adding it to the command since it is treated
2867         as a list of args.
2868
2869         * Scripts/webkitpy/common/config/ports.py:
2870         (DeprecatedPort.run_javascriptcore_tests_command):
2871
2872 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2873
2874         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
2875         https://bugs.webkit.org/show_bug.cgi?id=190504
2876         <rdar://problem/45117760>
2877
2878         Reviewed by Tim Horton.
2879
2880         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
2881         macOS and iOS.
2882
2883         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2884         (WTR::UIScriptController::setViewScale):
2885         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2886         (WTR::UIScriptController::setViewScale):
2887         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2888         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2889         (WTR::UIScriptController::setViewScale):
2890         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2891         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
2892
2893         Add a new file for UIScriptController methods on Cocoa platforms.
2894
2895         (WTR::UIScriptController::setViewScale):
2896         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2897         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2898         (WTR::TestController::cocoaResetStateToConsistentValues):
2899
2900         Ensure that _viewScale is reset to 1 after running a layout test.
2901
2902 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
2905         https://bugs.webkit.org/show_bug.cgi?id=190536
2906
2907         Reviewed by Alexey Proskuryakov.
2908
2909         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
2910
2911 2018-10-11  Youenn Fablet  <youenn@apple.com>
2912
2913         IOS 12 - Service worker cache not shared when added to homescreen
2914         https://bugs.webkit.org/show_bug.cgi?id=190269
2915         <rdar://problem/45009961>
2916
2917         Reviewed by Alex Christensen.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2920         Add test to ensure that CacheStorage use the default website data store parameters.
2921
2922 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2923
2924         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
2925         https://bugs.webkit.org/show_bug.cgi?id=190476
2926         <rdar://problem/32757191>
2927
2928         Reviewed by Megan Gardner.
2929
2930         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
2931         (TEST):
2932         Add a test that we don't crash.
2933
2934 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2935
2936         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
2937
2938         * Scripts/webkitpy/tool/steps/options.py:
2939         (Options):
2940         Fix the name of the variable that the --cc-radar option writes into.
2941
2942 2018-10-10  Dean Jackson  <dino@apple.com>
2943
2944         Add --cc-radar option to webkit-patch bug creation
2945         https://bugs.webkit.org/show_bug.cgi?id=190451
2946         <rdar://problem/45176671>
2947
2948         Reviewed by Antoine Quint.
2949
2950         Add a new command line option to automatically
2951         CC radar to new or updated bugs.
2952
2953         * Scripts/webkitpy/tool/commands/commandtest.py:
2954         (CommandsTest.assert_execute_outputs):
2955         * Scripts/webkitpy/tool/commands/upload.py:
2956         (CreateBug.__init__):
2957         (CreateBug.execute):
2958         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2959         (test_prepare_with_cc):
2960         (test_prepare_with_radar):
2961         (test_prepare_with_cc_and_radar):
2962         * Scripts/webkitpy/tool/steps/createbug.py:
2963         (CreateBug.options):
2964         (CreateBug.run):
2965         * Scripts/webkitpy/tool/steps/options.py:
2966         (Options):
2967
2968 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
2969
2970         [GStreamer] Do not build gstgtk plugins
2971         https://bugs.webkit.org/show_bug.cgi?id=190463
2972
2973         Reviewed by Xabier Rodriguez-Calvar.
2974
2975         These plugins pull a GTK+ dependency that, at least in WPE,
2976         is unnecessary. The GTK+ port doesn't need it either, as far
2977         as I can tell.
2978
2979         * gstreamer/jhbuild.modules: Disable gstgtk plugins
2980
2981 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
2982
2983         [GTK][WPE] Add mediaDevices.enumerateDevices support
2984         https://bugs.webkit.org/show_bug.cgi?id=185761
2985
2986         Reviewed by Youenn Fablet.
2987
2988         Added new API test for the mediaDevices.enumerateDevices:
2989         usermedia-enumeratedevices-permission-check. And a new API test
2990         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
2991
2992         * MiniBrowser/gtk/main.c:
2993         (gotWebsiteDataCallback): Added a new section to the about:data
2994         webpage to include the information about the hash salt.
2995         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2996         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
2997         new test checking the enumerateDevices API when permission is
2998         denied and when permission is allowed for the origin.
2999         (beforeAll): Defined the new test.
3000         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3001         (serverCallback): Register a new URI for the enumerateDevices.
3002         (testWebsiteDataConfiguration): Remove the hash salts from the
3003         directories.
3004         (testWebsiteDataDeviceIdHashSalt): New test cheking the
3005         enumerateDevices API.
3006         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
3007         the init structure.
3008         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3009         (WebViewTest::initializeWebView): Make sure the media-stream is
3010         activated in the webView.
3011
3012 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3013
3014         Add WinCairo to the flakiness dashboard
3015         https://bugs.webkit.org/show_bug.cgi?id=188345
3016
3017         Reviewed by Lucas Forschler.
3018
3019         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
3020         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
3021
3022 2018-10-10  Dean Jackson  <dino@apple.com>
3023
3024         [WHSL -> MSL] Annotate semantics correctly in generated MSL
3025         https://bugs.webkit.org/show_bug.cgi?id=190452
3026         <rdar://problem/45178272>
3027
3028         Reviewed by Myles Maxfield.
3029
3030         Correctly label the appropriate semantics as [[position]]
3031         and [[color(N)]].
3032
3033         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
3034         and color attributes. Also use the semantic's index rather than
3035         a counter.
3036         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
3037         output, and only include the actual shader code.
3038
3039 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
3040
3041         build-webkit --inspector-frontend shouldn't have a nonzero exit code
3042         https://bugs.webkit.org/show_bug.cgi?id=190430
3043
3044         Reviewed by Brian Burg.
3045
3046         * Scripts/webkitdirs.pm:
3047         (argumentsForConfiguration):
3048         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
3049         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
3050
3051 2018-10-10  Tim Horton  <timothy_horton@apple.com>
3052
3053         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
3054         https://bugs.webkit.org/show_bug.cgi?id=190420
3055
3056         Reviewed by Simon Fraser.
3057
3058         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3059         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3060         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3061         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3062         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3063         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3064         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3065         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3066         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3067         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3068         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3069         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3070         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3071         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3072         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3073         Change the testing mechanism for the share sheet such that we up-front
3074         set that it should immediately return with a particular state, instead
3075         of programmatically dismissing the sheet.
3076
3077         Otherwise, running the tests on macOS doesn't work, because we pop
3078         a context menu, which spins the runloop and prevents dismissal from
3079         going through.
3080
3081 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3082
3083         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3084         https://bugs.webkit.org/show_bug.cgi?id=190429
3085
3086         Reviewed by Saam Barati.
3087
3088         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3089         (TestWebKitAPI::TEST_F):
3090
3091 2018-10-10  Chris Dumez  <cdumez@apple.com>
3092
3093         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
3094         https://bugs.webkit.org/show_bug.cgi?id=190418
3095         <rdar://problem/45059769>
3096
3097         Reviewed by Geoffrey Garen.
3098
3099         Add API test coverage.
3100
3101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3102
3103 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
3104
3105         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
3106         https://bugs.webkit.org/show_bug.cgi?id=190191
3107
3108         Reviewed by Michael Catanzaro.
3109
3110         * QueueStatusServer/config/queues.py:
3111         * Scripts/webkitpy/common/config/ews.json:
3112         * Scripts/webkitpy/common/config/ports.py:
3113         (DeprecatedPort.run_javascriptcore_tests_command):
3114         Add the possibility to pass arguments to run-javascriptcore-tests with
3115         the JSCTESTS_OPTIONS environment variable
3116         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3117         (test_ews_name):
3118
3119
3120 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
3121
3122         Allow run-javascriptcore-tests to distribute tests between devices
3123         https://bugs.webkit.org/show_bug.cgi?id=190190
3124
3125         Reviewed by Michael Catanzaro.
3126
3127         * Scripts/run-jsc-stress-tests:
3128         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3129         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3130
3131 2018-10-09  Dean Jackson  <dino@apple.com>
3132
3133         Update WHLSL to Metal tester with semantics
3134         https://bugs.webkit.org/show_bug.cgi?id=190416
3135         <rdar://problem/45145139>
3136
3137         Reviewed by Myles Maxfield.
3138
3139         A few small changes to the WHLSL to Metal tools:
3140         - Make it compile by adding some missing JS files :)
3141         - Add semantics to the default shader
3142         - Add FIXMEs to the other shaders
3143         - Create an in-browser test for the WHLSLToMetal codepath
3144         - Fix typos in the semantics checker
3145
3146         * WebGPUShadingLanguageRI/Checker.js:
3147         (Checker.prototype._checkSemantics.checkSemanticTypes):
3148         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3149         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
3150         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
3151         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
3152         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
3153         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3154         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
3155
3156 2018-10-09  Jer Noble  <jer.noble@apple.com>
3157
3158         Crash when closing WKWebView during enter fullscreen animation
3159         https://bugs.webkit.org/show_bug.cgi?id=190412
3160
3161         Reviewed by Brian Burg.
3162
3163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3164         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
3165         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
3166         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
3167         (TestWebKitAPI::TEST):
3168
3169 2018-10-09  Chris Dumez  <cdumez@apple.com>
3170
3171         Anchor target should be ignored on activation when the download attribute is set
3172         https://bugs.webkit.org/show_bug.cgi?id=190408
3173
3174         Reviewed by Geoffrey Garen.
3175
3176         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
3177         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
3178         popup blocking.
3179
3180         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3181         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3182         (WTR::TestRunner::setCanOpenWindows):
3183         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3184         * WebKitTestRunner/TestController.cpp:
3185         (WTR::TestController::createOtherPage):
3186         * WebKitTestRunner/TestController.h:
3187         * WebKitTestRunner/TestInvocation.cpp:
3188         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3189         * WebKitTestRunner/TestInvocation.h:
3190
3191 2018-10-09  Jer Noble  <jer.noble@apple.com>
3192
3193         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
3194         https://bugs.webkit.org/show_bug.cgi?id=190098
3195         <rdar://problem/42822671>
3196
3197         Reviewed by Brian Burg.
3198
3199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3200         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
3201         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
3202         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
3203         (TestWebKitAPI::TEST):
3204
3205 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
3206
3207         [WebAuthN] Import CTAP HID message and packet structure from Chromium
3208         https://bugs.webkit.org/show_bug.cgi?id=189289
3209         <rdar://problem/44120310>
3210
3211         Reviewed by Brent Fulgham.
3212
3213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3214         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
3215         (TestWebKitAPI::TEST):
3216
3217 2018-10-09  Chris Dumez  <cdumez@apple.com>
3218
3219         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
3220         https://bugs.webkit.org/show_bug.cgi?id=190378
3221         <rdar://problem/45059466>
3222
3223         Reviewed by Geoffrey Garen.
3224
3225         Add API test coverage.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3228
3229 2018-10-09  Jer Noble  <jer.noble@apple.com>
3230
3231         ISOTrackEncryptionBox returns incorrect defaultKeyID
3232         https://bugs.webkit.org/show_bug.cgi?id=190368
3233
3234         Reviewed by Eric Carlson.
3235
3236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3237         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3238         (TestWebKitAPI::TEST):
3239
3240 2018-10-09  Philippe Normand  <pnormand@igalia.com>
3241
3242         [JHBuild] Update to GStreamer 1.14.4
3243         https://bugs.webkit.org/show_bug.cgi?id=190395
3244
3245         Reviewed by Xabier Rodriguez-Calvar.
3246
3247         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
3248         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
3249         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
3250         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
3251         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
3252
3253 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3254
3255         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
3256         https://bugs.webkit.org/show_bug.cgi?id=190386
3257
3258         Reviewed by Ryosuke Niwa.
3259
3260         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
3261         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
3262         of macOS.
3263
3264         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3265         (TEST):
3266
3267 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3268
3269         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
3270         https://bugs.webkit.org/show_bug.cgi?id=190342
3271         <rdar://problem/44767118>
3272
3273         Reviewed by Tim Horton.
3274
3275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3276         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3277
3278         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
3279         moving the selection around text inside nested list elements.
3280
3281         (TestWebKitAPI::checkParagraphStyles):
3282
3283         Add a new helper to check an NSParagraphStyle against expected results.
3284
3285         (TestWebKitAPI::webViewForTestingFontAttributes):
3286
3287         Allow each test to pass in the name of the test page to load.
3288
3289         (TestWebKitAPI::TEST):
3290         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
3291
3292         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
3293
3294         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
3295
3296         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
3297
3298 2018-10-08  Justin Fan  <justin_fan@apple.com>
3299
3300         WebGPU: Rename old WebGPU prototype to WebMetal
3301         https://bugs.webkit.org/show_bug.cgi?id=190325
3302         <rdar://problem/44990443>
3303
3304         Reviewed by Dean Jackson.
3305
3306         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3307
3308         * DumpRenderTree/mac/DumpRenderTree.mm:
3309         (enableExperimentalFeatures):
3310         (resetWebPreferencesToConsistentValues):
3311         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3312         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3313         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
3314         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
3315         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3316         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3317         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3318         (WTR::InjectedBundle::beginTesting):
3319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3320         (WTR::TestRunner::setWebMetalEnabled):
3321         (WTR::TestRunner::setWebGPUEnabled): Deleted.
3322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3323
3324 2018-10-08  Commit Queue  <commit-queue@webkit.org>
3325
3326         Unreviewed, rolling out r236941.
3327         https://bugs.webkit.org/show_bug.cgi?id=190374
3328
3329         Causing API test failures in new test (Requested by jernoble
3330         on #webkit).
3331
3332         Reverted changeset:
3333
3334         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
3335         https://bugs.webkit.org/show_bug.cgi?id=190368
3336         https://trac.webkit.org/changeset/236941
3337
3338 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3339
3340         Make <input type=color> a runtime enabled (on-by-default) feature
3341         https://bugs.webkit.org/show_bug.cgi?id=189162
3342
3343         Reviewed by Wenson Hsieh and Tim Horton.
3344
3345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3346
3347 2018-10-08  Jer Noble  <jer.noble@apple.com>
3348
3349         ISOTrackEncryptionBox returns incorrect defaultKeyID
3350         https://bugs.webkit.org/show_bug.cgi?id=190368
3351
3352         Reviewed by Eric Carlson.
3353
3354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3355         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3356         (TestWebKitAPI::TEST):
3357
3358 2018-10-08  Alex Christensen  <achristensen@webkit.org>
3359
3360         Remove WKBundleFileHandleRef
3361         https://bugs.webkit.org/show_bug.cgi?id=190360
3362
3363         Reviewed by Tim Horton.
3364
3365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3366         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
3367         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
3368
3369 2018-10-08  Dan Bernstein  <mitz@apple.com>
3370
3371         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
3372         https://bugs.webkit.org/show_bug.cgi?id=190250
3373
3374         Reviewed by Anders Carlsson.
3375
3376         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3377
3378         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3379           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3380           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3381
3382         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
3383
3384         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
3385           around deprecated methods or categories on deprecated classes.
3386         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
3387         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3388         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
3389         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3390
3391         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3392           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3393           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3394
3395         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3396
3397         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
3398         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
3399           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
3400
3401         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3402           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
3403           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
3404
3405         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
3406           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
3407
3408         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3409           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3410           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3411           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
3412           many C SPI headers trigger the strict prototypes warning.
3413
3414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3415
3416         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3417         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3418         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3419         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
3420         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3421         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3422         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3423         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3424         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3425         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3426         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
3427         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3428         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3429         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3430         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
3431         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
3432         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3433         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
3434         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
3435         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3436         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3437         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
3438         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
3439         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
3440         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3441         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
3442
3443         In all of the above, suppressed the deprecated implementations warning where needed.
3444
3445         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
3446           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
3447           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3448           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
3449           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3450           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3451           and GCC_NO_COMMON_BLOCKS.
3452
3453         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3454
3455         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3456         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
3457           the deprecated implementations warning.
3458
3459         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3460         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
3461
3462 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
3463
3464         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
3465         https://bugs.webkit.org/show_bug.cgi?id=189238
3466
3467         Reviewed by Xabier Rodriguez-Calvar.
3468
3469         Modifications on GStreamer, tracked in GStreamer bugzilla:
3470         https://bugzilla.gnome.org/show_bug.cgi?id=797231
3471         https://bugzilla.gnome.org/show_bug.cgi?id=765275
3472
3473         * gstreamer/jhbuild.modules: Add new patches.
3474         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
3475         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
3476         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
3477         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
3478
3479 2018-10-06  Dan Bernstein  <mitz@apple.com>
3480
3481         [Xcode] Never build yasm with ASAN
3482         https://bugs.webkit.org/show_bug.cgi?id=190327
3483
3484         Reviewed by Youenn Fablet.
3485
3486         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
3487           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
3488
3489 2018-10-05  Chris Dumez  <cdumez@apple.com>
3490
3491         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
3492         https://bugs.webkit.org/show_bug.cgi?id=190320
3493         <rdar://problem/45044814>
3494
3495         Reviewed by Geoffrey Garen.
3496
3497         Add API test coverage.
3498
3499         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3500         (TestWebKitAPI::TEST):
3501         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3502         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
3503
3504 2018-10-03  Jer Noble  <jer.noble@apple.com>
3505
3506         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
3507         https://bugs.webkit.org/show_bug.cgi?id=190266
3508
3509         Reviewed by Eric Carlson.
3510
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
3513         (TestWebKitAPI::TEST):
3514
3515 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
3516
3517         Unreviewed, rolling out r236866.
3518
3519         Breaks internal builds.
3520
3521         Reverted changeset:
3522
3523         "Add support for reporting "display composited video frames"
3524         through the VideoPlaybackQuality object."
3525         https://bugs.webkit.org/show_bug.cgi?id=190266
3526         https://trac.webkit.org/changeset/236866
3527
3528 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3529
3530         [WPE][JSC] Use Unified Sources for Platform-specific sources
3531         https://bugs.webkit.org/show_bug.cgi?id=190300
3532
3533         Reviewed by Yusuke Suzuki.
3534
3535         Currently the GTK port already used Unified Sources with the same source files.
3536         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
3537         to the list of libraries to link with.
3538
3539         * TestWebKitAPI/PlatformWPE.cmake:
3540
3541 2018-10-05  Zach Li  <zachli@apple.com>
3542
3543         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
3544         https://bugs.webkit.org/show_bug.cgi?id=190302
3545         <rdar://problem/45031469>
3546
3547         Reviewed by Tim Horton.
3548
3549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3550         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
3551         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
3552         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
3553         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3554         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3555         (TEST):
3556
3557 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3558
3559         [iOS] [WK2] Expose some more editing SPI on WKWebView
3560         https://bugs.webkit.org/show_bug.cgi?id=190232
3561         <rdar://problem/44963368>
3562
3563         Reviewed by Tim Horton.
3564
3565         Adds new API tests to exercise the new SPIs.
3566
3567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3568         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
3569         (-[TestWKWebView querySelectorExists:]):
3570         (TestWebKitAPI::webViewForEditActionTesting):
3571         (TestWebKitAPI::TEST):
3572         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3573         (-[TestWKWebView collapseToStart]): Deleted.
3574         (-[TestWKWebView collapseToEnd]): Deleted.
3575         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
3576         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
3577         * TestWebKitAPI/cocoa/TestWKWebView.h:
3578         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3579         (-[TestWKWebView stylePropertyAtSelectionStart:]):
3580         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
3581         (-[TestWKWebView collapseToStart]):
3582         (-[TestWKWebView collapseToEnd]):
3583
3584         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
3585
3586 2018-10-04  Jer Noble  <jer.noble@apple.com>
3587
3588         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
3589         https://bugs.webkit.org/show_bug.cgi?id=190266
3590
3591         Reviewed by Eric Carlson.
3592
3593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3594         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
3595         (TestWebKitAPI::TEST):
3596
3597 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3598
3599         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
3600         https://bugs.webkit.org/show_bug.cgi?id=190119
3601         <rdar://problem/44767062>
3602
3603         Reviewed by Tim Horton.
3604
3605         Add a new API test that loads a document containing various rich text styles. This test moves the selection
3606         around the document and checks the last set of font attributes received via the new UI delegate hook.
3607
3608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3609         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
3610         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
3611         (-[FontAttributesListener lastFontAttributes]):
3612         (-[TestWKWebView selectElementWithIdentifier:]):
3613         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
3614         (ColorExpectation::ColorExpectation):
3615         (ShadowExpectation::ShadowExpectation):
3616         (checkColor):
3617         (checkShadow):
3618         (checkFont):
3619         (webViewForTestingFontAttributes):
3620         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
3621
3622 2018-10-04  Alan Coon  <alancoon@apple.com>
3623
3624         Unreviewed, add self as contributor.
3625
3626         * Scripts/webkitpy/common/config/contributors.json:
3627
3628 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3629
3630         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
3631         https://bugs.webkit.org/show_bug.cgi?id=190289
3632         <rdar://problem/45020806>
3633
3634         Reviewed by Ryosuke Niwa.
3635
3636         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
3637         attributes at the current selection.
3638
3639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3640         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
3641         * TestWebKitAPI/Tests/mac/FontManagerTests.mm: