b58f2b0423dce359129691f090777054c6713375
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-07  Adam Klein  <adamk@chromium.org>
2
3         Add JSC support for delivering mutations when the outermost script context exits
4         https://bugs.webkit.org/show_bug.cgi?id=70289
5
6         Reviewed by Eric Seidel.
7
8         * DumpRenderTree/mac/EventSendingController.mm: Add support for
9         eventSender.scheduleAsynchronousKeyDown.
10         (+[EventSendingController isSelectorExcludedFromWebScript:]):
11         (+[EventSendingController webScriptNameForSelector:]):
12         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
13         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
14         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
15
16 2012-02-07  Chris Rogers  <crogers@google.com>
17
18         Add Chris Rogers to reviewers section
19         https://bugs.webkit.org/show_bug.cgi?id=78016
20
21         Reviewed by Adam Barth.
22
23         * Scripts/webkitpy/common/config/committers.py:
24
25 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
26
27         layoutTestController.display() is flaky for SVG tests
28         https://bugs.webkit.org/show_bug.cgi?id=78021
29
30         Reviewed by Dan Bernstein.
31
32         Fix race condition in repaint rect tracking. When running a test using the repaint.js
33         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
34         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
35         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
36         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
37         the repaint test already run, thus invalidating the previously tracked repaint rects.
38
39         * DumpRenderTree/mac/DumpRenderTree.mm:
40         (dump):
41         (runTest):
42
43 2012-02-07  Hans Wennborg  <hans@chromium.org>
44
45         Chromium: remove WebSpeechInputResult::set
46         https://bugs.webkit.org/show_bug.cgi?id=77977
47
48         Reviewed by Darin Fisher.
49
50         It was renamed to assign() in r106475.
51
52         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
53         (makeRectResult):
54
55 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
56
57         [Qt] Give emulated touch-point a radius
58         https://bugs.webkit.org/show_bug.cgi?id=77985
59         
60         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
61
62         Reviewed by Kenneth Rohde Christiansen.
63
64         * MiniBrowser/qt/BrowserWindow.cpp:
65         (BrowserWindow::updateVisualMockTouchPoints):
66         * MiniBrowser/qt/MiniBrowserApplication.cpp:
67         (MiniBrowserApplication::notify):
68         * MiniBrowser/qt/qml/MockTouchPoint.qml:
69
70 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
71
72         [GTK] Include gdk-pixbuf in the jhbuild modules
73         https://bugs.webkit.org/show_bug.cgi?id=77980
74
75         Reviewed by Gustavo Noronha Silva.
76
77         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
78
79 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
80
81         [Qt] Prevent early test termination with newer Qt 5
82         https://bugs.webkit.org/show_bug.cgi?id=77945
83
84         Reviewed by Csaba Osztrogonác.
85
86         QTBUG-24120 tracks a regression in Qt that would make layout tests
87         terminate early. This patch works around it in a Qt 4 + 5 safe manner
88         by disabling the quitOnLastWindowClosed feature, which we don't want/need
89         for DRT anyway.
90
91         * DumpRenderTree/qt/main.cpp:
92         (main): Don't quit on last window closed.
93
94 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
95
96         Fix some miscellaneous 'make dist' error for WebKitGTK+.
97
98         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
99         files should not be distributed.
100
101 2012-02-02  Hajime Morrita  <morrita@chromium.org>
102
103         [PerformanceTests] Each Dromaeo test needs its landing html.
104         https://bugs.webkit.org/show_bug.cgi?id=77504
105
106         Reviewed by Ryosuke Niwa.
107
108         Added an ignorable pattern which happens in some Dromaeo tests.
109
110         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
111         (PerfTestsRunner):
112
113 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
114
115         [GTK] Add missing pango include dir to fix build
116         https://bugs.webkit.org/show_bug.cgi?id=77832
117
118         Reviewed by Martin Robinson.
119
120         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
121
122 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
123
124         [GTK] Fix remaining errors in GTK+ WebKit2 API
125         https://bugs.webkit.org/show_bug.cgi?id=77890
126
127         Reviewed by Gustavo Noronha Silva.
128
129         Verify that WebKit2 GTK+ test files are not skipped during style checks.
130         Skip soup_server_new when checking for NULL versus 0 usage.
131
132         * Scripts/webkitpy/style/checker_unittest.py:
133         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
134         * Scripts/webkitpy/style/checkers/cpp.py:
135         (check_for_null):
136
137 2012-02-06  Eric Seidel  <eric@webkit.org>
138
139         webkit-patch apply-from-bug should be able to apply non-reviewed patches
140         https://bugs.webkit.org/show_bug.cgi?id=77883
141
142         Reviewed by Adam Barth.
143
144         This is very helpful if you use bugzilla as a replacement for git-stash.
145         Makes it simpler to re-apply the patch w/o having to look up the patch id.
146
147         * Scripts/webkitpy/tool/commands/download.py:
148         (ProcessBugsMixin._fetch_list_of_patches_to_process):
149         * Scripts/webkitpy/tool/commands/download_unittest.py:
150         (DownloadCommandsTest.test_apply_from_bug):
151
152 2012-02-06  Philippe Normand  <pnormand@igalia.com>
153
154         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
155         https://bugs.webkit.org/show_bug.cgi?id=77866
156
157         Reviewed by Martin Robinson.
158
159         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
160         errors in some gstreamer source code files defining new GStreamer elements.
161         * Scripts/webkitpy/style/checker_unittest.py:
162         (GlobalVariablesTest.test_path_rules_specifier):
163
164 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
165
166         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
167         https://bugs.webkit.org/show_bug.cgi?id=77869
168
169         Reviewed by Philippe Normand.
170
171         * gtk/gtkdoc.py:
172         (GTKDoc.rebase_installed_docs): Check html_dir exists.
173
174 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
175
176         [Qt] Don't version QtWebKit.experimental.
177         https://bugs.webkit.org/show_bug.cgi?id=77739
178
179         Reviewed by Tor Arne Vestbø.
180
181         * MiniBrowser/qt/qml/BrowserWindow.qml:
182
183 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
184
185         [GTK] Fix several gtkdoc-fixxref warnings
186         https://bugs.webkit.org/show_bug.cgi?id=77613
187
188         Reviewed by Martin Robinson.
189
190         * gtk/generate-gtkdoc:
191         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
192         of ignored files, since it's private.
193         * gtk/gtkdoc.py:
194         (GTKDoc._ignored_files_basenames): Helper function that returns a
195         string with the list of ignored files basenames separated by a
196         spaces, as expected by several gtkdoc commands.
197         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
198         --ignore-headers option.
199         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
200         --ignore-files option.
201
202 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
203
204         [GTK] Fix xrefs after installing API documentation
205         https://bugs.webkit.org/show_bug.cgi?id=77551
206
207         Reviewed by Martin Robinson.
208
209         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
210         api docs.
211         * gtk/common.py:
212         (prefix_of_pkg_config_file): Get the prefix variable of the given
213         pkg-config file.
214         (gtk_version_of_pkg_config_file): Get the gtk version required by
215         the given pkg-config file.
216         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
217         installed documentation.
218         (get_gtkdoc_module_paths): Get paths where API doc is installed
219         for the dependencies of the given pkg-config file.
220         (get_common_xref_deps): Get API doc directories of dependencies
221         common to WebKit1 and WebKit2.
222         (get_webkit2_options): Add cross_reference_deps option.
223         (get_webkit1_options): Ditto
224         (rebase_installed_docs): Helper function to create a generator for
225         the given pkg-config file and options and call rebase_installed_docs.
226         * gtk/gtkdoc.py:
227         (GTKDoc.__init__): Initialize cross_reference_deps.
228         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
229         dependencies.
230         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
231         links of installed documentation.
232         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
233         file.
234
235 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
236
237         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
238         https://bugs.webkit.org/show_bug.cgi?id=77672
239
240         Reviewed by Dirk Pranke.
241
242         Test repetitions must be taken into account when working out
243         the statistics shown by run-webkit-tests.
244
245         * Scripts/webkitpy/layout_tests/controllers/manager.py:
246         (Manager.prepare_lists_and_print_output):
247         (Manager._print_result_summary):
248         * Scripts/webkitpy/layout_tests/models/result_summary.py:
249         (ResultSummary.__init__):
250         (ResultSummary.add):
251         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
252         (MainTest.test_repeat_each_iterations_num_tests):
253
254 2012-02-05  Dan Bernstein  <mitz@apple.com>
255
256         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
257         https://bugs.webkit.org/show_bug.cgi?id=77823
258
259         Reviewed by Anders Carlsson.
260
261         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
262         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
263
264 2012-02-04  Dan Bernstein  <mitz@apple.com>
265
266         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
267         https://bugs.webkit.org/show_bug.cgi?id=77822
268
269         Reviewed by Sam Weinig.
270
271         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
272         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
273
274 2012-02-04  Sam Weinig  <sam@webkit.org>
275
276         Add ability to send WKURLRequests in WebKit2 API user messages
277         https://bugs.webkit.org/show_bug.cgi?id=77819
278
279         Reviewed by Anders Carlsson.
280
281         Add testing for round-tripping WKTypes from the UIProcess,
282         to the WebProcess, and back.
283
284         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
285           More can easily be added.
286
287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
288         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
289         (TestWebKitAPI):
290         (WebKit2UserMessageRoundTripTest):
291         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
292         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
293         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
294         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
295         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
296         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
297         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
298         (TestWebKitAPI::TEST_F):
299         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
300         (TestWebKitAPI):
301         (UserMessageTest):
302         (TestWebKitAPI::UserMessageTest::UserMessageTest):
303         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
304         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
305         (TestWebKitAPI::PlatformWebView::resizeTo):
306         (TestWebKitAPI):
307         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
308         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
309
310 2012-02-04  Dan Bernstein  <mitz@apple.com>
311
312         <rdar://problem/10772406> WKPreferences instances cannot be copied
313         https://bugs.webkit.org/show_bug.cgi?id=77816
314
315         Reviewed by Sam Weinig.
316
317         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
318         (TestWebKitAPI::TEST):
319
320 2012-02-04  Adam Barth  <abarth@webkit.org>
321
322         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
323         https://bugs.webkit.org/show_bug.cgi?id=77802
324
325         Reviewed by Eric Seidel.
326
327         This patch refactors our directory grouping code into base.js where it
328         can be shared between failures.js and notifications.js.  It then adds
329         an Examine action to each group of failures that triggers the "results"
330         view.
331
332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
338
339 2012-02-04  Ojan Vafai  <ojan@chromium.org>
340
341         check-webkit-style is throwing an exception
342         https://bugs.webkit.org/show_bug.cgi?id=77744
343
344         Reviewed by David Levin.
345
346         If the test_list is None, then we don't need to check for unsupported
347         feature tests to skip.
348
349         * Scripts/webkitpy/layout_tests/port/webkit.py:
350         (WebKitPort._has_test_in_directories):
351         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
352         (test_skipped_tests_for_unsupported_features_empty_test_list):
353
354 2012-02-03  Adam Barth  <abarth@webkit.org>
355
356         List of all failures in garden-o-matic should actually list all the failures
357         https://bugs.webkit.org/show_bug.cgi?id=77796
358
359         Reviewed by Eric Seidel.
360
361         This patch wires a bit more data into the new "All Failures" tab.  I've
362         also iterated on how we enable this experimental feature.  The tab is
363         still just a dumb list, but we'll make it smarter.
364
365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
369
370 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
371
372         Windows build fix after r106692.
373
374         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
375         (PortTest.test_reference_files):
376
377 2012-02-03  Beth Dakin  <bdakin@apple.com>
378
379         https://bugs.webkit.org/show_bug.cgi?id=77782
380         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
381         once on some pages with frames
382         -and corresponding-
383         <rdar://problem/10798474>
384
385         Reviewed by Sam Weinig.
386
387         One new test.
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
390         (TestWebKitAPI):
391         (TestWebKitAPI::didForceRepaint):
392         (TestWebKitAPI::didFinishLoadForFrame):
393         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
394         (TestWebKitAPI::setPageLoaderClient):
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
397         (TestWebKitAPI):
398         (NewFirstVisuallyNonEmptyLayoutFramesTest):
399         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
400         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
401         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
402
403 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
404
405         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
406         https://bugs.webkit.org/show_bug.cgi?id=77781
407
408         Reviewed by Eric Seidel.
409
410         This change fixes a couple of issues discovered while debugging
411         test-webkitpy; both calling exit() instead of sys.exit() --
412         which is discouraged in program code instead of the interpreter
413         -- and a particular usage of outputcapture were stdin to get whacked
414         and preventing debugging.
415        
416         This change introduces a couple of common _exit() methods that
417         will standardize how webkit-patch exit's, in case we need to do
418         something different in the future.
419
420         * Scripts/webkitpy/common/system/deprecated_logging.py:
421         (error):
422         * Scripts/webkitpy/common/system/outputcapture.py:
423         (OutputCapture.assert_outputs):
424         * Scripts/webkitpy/tool/bot/queueengine.py:
425         (QueueEngine.exit_after_handled_error):
426         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
427         (AbstractSequencedCommand.execute):
428         * Scripts/webkitpy/tool/commands/queues.py:
429         (StyleQueue.handle_script_error):
430         * Scripts/webkitpy/tool/commands/upload.py:
431         (MarkBugFixed.execute):
432         * Scripts/webkitpy/tool/multicommandtool.py:
433         (Command._exit):
434         * Scripts/webkitpy/tool/steps/abstractstep.py:
435         (AbstractStep._exit):
436         * Scripts/webkitpy/tool/steps/checkstyle.py:
437         (CheckStyle.run):
438         * Scripts/webkitpy/tool/steps/commit.py:
439         (Commit._check_test_expectations):
440         * Scripts/webkitpy/tool/steps/confirmdiff.py:
441         (ConfirmDiff.run):
442
443 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
444
445         Perf bot build fix.
446
447         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
448         (PerfTestsRunner._generate_json):
449
450 2012-02-03  Adam Barth  <abarth@webkit.org>
451
452         Add a blank "Expected Failures" tab to garden-o-matic
453         https://bugs.webkit.org/show_bug.cgi?id=77793
454
455         Reviewed by Eric Seidel.
456
457         This tab will help us explore and manage our expected failures.  The
458         tab is hidden by default via a new "experimental features" flag.
459
460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
465         (#unexpected):
466         (#onebar.partytime #unexpected):
467
468 2012-02-03  Lucas Forschler  <lforschler@apple.com>
469
470         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
471         https://bugs.webkit.org/show_bug.cgi?id=77785
472
473         Fix the build bots.
474         
475         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
476
477         * Scripts/update-webkit-support-libs:
478         (downloadExpectedVersionNumber):
479
480 2012-02-03  Lucas Forschler  <lforschler@apple.com>
481
482         Add a Mac Lion Performance bot.
483         https://bugs.webkit.org/show_bug.cgi?id=77765
484
485         Reviewed by Adam Roben.
486
487         This will update the master configuration in the following ways:
488             Add a new performance slave (apple-xseve-11)
489             Add a new Factory to download a build and run perf tests.
490             
491         * BuildSlaveSupport/build.webkit.org-config/config.json:
492         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
493         (DownloadAndPerfTestFactory):
494         (DownloadAndPerfTestFactory.__init__):
495
496 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
497
498         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
499         https://bugs.webkit.org/show_bug.cgi?id=77752
500
501         Reviewed by James Robinson.
502
503         Delete unneeded file accidentally checked in in r106481.
504
505         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
506
507 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
508
509         Ref Tests should support plain SVG files
510         https://bugs.webkit.org/show_bug.cgi?id=77685
511
512         Reviewed by Tony Chang.
513
514         Don't assume reference files always use .html as the extension.
515         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
516
517         Also fix various bugs in MockFileSystem and TestPort.
518
519         * Scripts/webkitpy/common/system/filesystem_mock.py:
520         (MockFileSystem.isdir):
521         * Scripts/webkitpy/layout_tests/port/base.py:
522         (Port.reference_files):
523         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
524         (PortTest.test_is_test_file):
525         (PortTest.test_reference_files):
526         * Scripts/webkitpy/layout_tests/port/test.py:
527         (TestInstance.__init__):
528
529 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
530
531         perf-o-matic should store chromium svn revision
532         https://bugs.webkit.org/show_bug.cgi?id=77725
533
534         Reviewed by Dirk Pranke.
535
536         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
537         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
538         is implemented in terms of newly added svn_revision.
539
540         * Scripts/webkitpy/common/checkout/scm/git.py:
541         (Git.svn_revision):
542         * Scripts/webkitpy/common/checkout/scm/scm.py:
543         (SCM.head_svn_revision):
544         (SCM):
545         (SCM.svn_revision):
546         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
547         (MockSCM.svn_revision):
548         * Scripts/webkitpy/common/checkout/scm/svn.py:
549         (SVN.svn_revision):
550         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
551         (JSONLayoutResultsGenerator.__init__):
552         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
553         (JSONResultsGeneratorBase._insert_generic_metadata):
554         * Scripts/webkitpy/layout_tests/port/base.py:
555         (Port.repository_paths):
556         * Scripts/webkitpy/layout_tests/port/chromium.py:
557         (ChromiumPort.repository_paths):
558         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
559         (PerfTestsRunner._generate_json):
560         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
561         (test_run_test_set_with_json_output):
562         (test_run_test_set_with_json_source):
563         (test_run_test_set_with_multiple_repositories):
564
565 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
566
567         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
568         https://bugs.webkit.org/show_bug.cgi?id=77632
569
570         Reviewed by Kenneth Rohde Christiansen.
571
572         * MiniBrowser/qt/BrowserWindow.cpp:
573         (BrowserWindow::BrowserWindow):
574         * MiniBrowser/qt/MiniBrowserApplication.cpp:
575         (MiniBrowserApplication::sendTouchEvent):
576         (MiniBrowserApplication::handleUserOptions):
577         * MiniBrowser/qt/MiniBrowserApplication.h:
578         (WindowOptions):
579         (WindowOptions::WindowOptions):
580         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
581         (WTR::PlatformWebView::PlatformWebView):
582         * WebKitTestRunner/qt/main.cpp:
583         (main):
584         * qmake/mkspecs/features/default_post.prf:
585
586 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
587
588         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
589         https://bugs.webkit.org/show_bug.cgi?id=77723
590
591         Reviewed by Tor Arne Vestbø.
592
593         * Tools.pro: Compile WTR again on all platforms with WK2.
594
595 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
596
597         Ensure that inspector disabled build works
598         https://bugs.webkit.org/show_bug.cgi?id=77604
599
600         Reviewed by Tor Arne Vestbø.
601
602         * qmake/mkspecs/features/features.prf:
603
604 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
605
606         [chromium] add support for --makeargs to the ninja-based build
607         https://bugs.webkit.org/show_bug.cgi?id=77688
608
609         Reviewed by Adam Barth.
610
611         * Scripts/webkitdirs.pm:
612         (buildChromiumNinja):
613
614 2012-02-02  Eric Seidel  <eric@webkit.org>
615
616         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
617         https://bugs.webkit.org/show_bug.cgi?id=75145
618
619         Reviewed by Dirk Pranke.
620
621         * Scripts/webkitpy/layout_tests/port/mac.py:
622         (MacPort.default_child_processes):
623         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
624         (test_operating_system):
625         (test_default_child_processes):
626
627 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
628
629        nrwt shouldn't blow up when there are errors in test_expectations.txt
630        https://bugs.webkit.org/show_bug.cgi?id=73603
631
632        Reviewed by Ojan Vafai.
633
634        This change removes the distinction between 'errors' and 'warnings'
635        in the test expectations parser. Now, any problem is a
636        'warning', and if we are linting the file, warnings become fatal (errors).
637
638         This will allow a normal run-webkit-tests run to proceed even if
639         there are bad lines.
640
641         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
642         (ParseError.__init__):
643         (ParseError.__str__):
644         (ParseError.__repr__):
645         (TestExpectationSerializer.to_string):
646         (TestExpectationParser._parse_modifiers):
647         (TestExpectationParser._parse_expectations):
648         (TestExpectationParser._check_modifiers_against_expectations):
649         (TestExpectationParser._tokenize):
650         (TestExpectationLine.__init__):
651         (TestExpectationLine.is_invalid):
652         (TestExpectationsModel.add_expectation_line):
653         (TestExpectationsModel._already_seen_better_match):
654         (TestExpectations.__init__):
655         (TestExpectations._report_warnings):
656         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
657         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
658         (assert_bad_expectations):
659         (test_parse_warning):
660         (test_overrides__duplicate):
661         (ExpectationSyntaxTests.test_missing_expectation):
662         (ExpectationSyntaxTests.test_missing_colon):
663         (ExpectationSyntaxTests.test_too_many_colons):
664         (ExpectationSyntaxTests.test_too_many_equals_signs):
665         (ExpectationSyntaxTests.test_unrecognized_expectation):
666         (SemanticTests.test_bug_format):
667         (SemanticTests.test_bad_bugid):
668         (SemanticTests.test_slow_and_timeout):
669         (test_ambiguous):
670         (test_more_modifiers):
671         (test_order_in_file):
672         (test_macro_overrides):
673         (RebaseliningTest.assertRemove):
674         (TestExpectationParserTests.test_tokenize_blank):
675         (TestExpectationParserTests.test_tokenize_missing_colon):
676         (TestExpectationParserTests.test_tokenize_extra_colon):
677         (TestExpectationParserTests.test_tokenize_empty_comment):
678         (TestExpectationParserTests.test_tokenize_comment):
679         (TestExpectationParserTests.test_tokenize_missing_equal):
680         (TestExpectationParserTests.test_tokenize_extra_equal):
681         (TestExpectationParserTests.test_tokenize_valid):
682         (TestExpectationParserTests.test_tokenize_valid_with_comment):
683         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
684         (TestExpectationSerializerTests.test_unparsed_to_string):
685         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
686         (lint):
687         * Scripts/webkitpy/style/checkers/test_expectations.py:
688         (TestExpectationsChecker.check_test_expectations):
689
690 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
691
692         Unreviewed, rolling out r106543.
693         http://trac.webkit.org/changeset/106543
694         https://bugs.webkit.org/show_bug.cgi?id=77671
695
696         Made tests less stable (Requested by rniwa on #webkit).
697
698         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
699         (PerfTestsRunner):
700         (PerfTestsRunner.__init__):
701         (PerfTestsRunner._run_tests_set):
702         (PerfTestsRunner._run_single_test):
703         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
704         (MainTest.TestDriver.run_test):
705         (run_test):
706
707 2012-02-02  Beth Dakin  <bdakin@apple.com>
708
709         https://bugs.webkit.org/show_bug.cgi?id=77664
710         Add API tests for didNewFirstVisuallyNonEmptyLayout
711
712         Reviewed by Darin Adler.
713
714         Two new tests.
715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
716         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
717         (TestWebKitAPI):
718         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
719         (TestWebKitAPI::setPageLoaderClient):
720         (TestWebKitAPI::TEST):
721         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
722         (TestWebKitAPI):
723         (TestWebKitAPI::didForceRepaint):
724         (TestWebKitAPI::didFinishLoadForFrame):
725         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
726         (TestWebKitAPI::setPageLoaderClient):
727         (TestWebKitAPI::TEST):
728         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
729         (TestWebKitAPI):
730         (NewFirstVisuallyNonEmptyLayoutFailsTest):
731         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
732         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
733         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
734         (TestWebKitAPI):
735         (NewFirstVisuallyNonEmptyLayoutTest):
736         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
737         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
738
739 2012-02-02  Michael Saboff  <msaboff@apple.com>
740
741         Add Michael Saboff to reviewers list.
742
743         Rubber-stamped by Gavin Barraclough.
744
745         * Scripts/webkitpy/common/config/committers.py:
746
747 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
748
749         Add myself as a committer
750
751         Unreviewed
752
753         * Scripts/webkitpy/common/config/committers.py:
754
755 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
756
757         [PerformanceTests] tests have dependencies
758         https://bugs.webkit.org/show_bug.cgi?id=77506
759
760         Reviewed by Hajime Morita.
761
762         Load an initialization page before each test after starting a DRT so that
763         warming up DRT won't affect the performance test results.
764
765         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
766         (PerfTestsRunner):
767         (PerfTestsRunner.__init__):
768         (PerfTestsRunner._run_tests_set):
769         (PerfTestsRunner._run_single_test):
770         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
771         (MainTest.TestDriver.run_test):
772         (test_initial_page_loaded):
773         (test_initial_page_loaded.run_test):
774
775 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
776
777         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
778
779         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
780         (PerfTestsRunner._run_tests_set):
781         (PerfTestsRunner._run_single_test):
782         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
783         (create_runner):
784         (test_run_passing_test):
785         (test_run_silent_test):
786         (test_run_failed_test):
787         (test_run_tonguey_test):
788         (test_run_timeout_test):
789         (test_run_crash_test):
790         (test_run_test_set_kills_drt_per_run):
791         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
792         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
793         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
794
795 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
796
797         Webkit generate-coverage-data script needs update to use new test script
798         https://bugs.webkit.org/show_bug.cgi?id=77597
799
800         Reviewed by Dirk Schulze.
801
802         * Scripts/generate-coverage-data:
803
804 2012-02-01  Adam Barth  <abarth@webkit.org>
805
806         Update the tests to show that the mac-ews processes patches from
807         non-committers.
808
809         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
810         (EarlyWarningSytemTest.test_committer_only_ewses):
811         (EarlyWarningSytemTest.test_builder_ewses):
812
813 2012-02-01  Adam Barth  <abarth@webkit.org>
814
815         Mac-ews logs are huge
816         https://bugs.webkit.org/show_bug.cgi?id=77045
817
818         Reviewed by Eric Seidel.
819
820         In order to get the cr-linux-ews bot to run tests on EC2, we created
821         the chromium-xvfb port, which contained a number of tweaks to the
822         Chromium port's behavior.  This patch refactors those tweaks so they
823         can be shared with the mac-ews, mostly by moving them into the
824         non-interactive mode of RunTests.
825
826         * Scripts/webkitpy/common/config/ports.py:
827         (WebKitPort):
828         (WebKitPort.layout_tests_results_path):
829         (ChromiumPort.run_javascriptcore_tests_command):
830         (ChromiumXVFBPort):
831         (ChromiumXVFBPort.run_webkit_tests_command):
832         * Scripts/webkitpy/common/config/ports_mock.py:
833         (MockPort):
834         (MockPort.layout_tests_results_path):
835         * Scripts/webkitpy/common/config/ports_unittest.py:
836         (WebKitPortTest.test_chromium_xvfb_port):
837         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
838         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
839         * Scripts/webkitpy/tool/commands/queues_unittest.py:
840         (CommitQueueTest.test_commit_queue):
841         (test_rollout):
842         (test_manual_reject_during_processing):
843         * Scripts/webkitpy/tool/steps/runtests.py:
844         (RunTests.run):
845         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
846         (RunTestsTest.test_no_unit_tests):
847         * Scripts/webkitpy/tool/steps/steps_unittest.py:
848         (StepsTest.test_runtests_args):
849
850 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
851
852         Roll out r106442. It made some tests more stable but others less stable.
853
854         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
855         (PerfTestsRunner._run_tests_set):
856         (PerfTestsRunner._run_single_test):
857         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
858         (create_runner):
859         (test_run_passing_test):
860         (test_run_silent_test):
861         (test_run_failed_test):
862         (test_run_tonguey_test):
863         (test_run_timeout_test):
864         (test_run_crash_test):
865         (test_run_test_set):
866
867 2012-02-01  Lucas Forschler  <lforschler@apple.com>
868
869         Enable EWS for non-contributers.
870         https://bugs.webkit.org/show_bug.cgi?id=77576
871         
872         Reviewed by Adam Barth.
873
874         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
875         (MacEWS):
876
877 2012-02-01  Beth Dakin  <bdakin@apple.com>
878
879         https://bugs.webkit.org/show_bug.cgi?id=77383
880         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
881         -and corresponding-
882         <rdar://problem/10709560>
883
884         Reviewed by Sam Weinig.
885
886         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
887         for.
888         * MiniBrowser/mac/BrowserWindowController.m:
889         (-[BrowserWindowController awakeFromNib]):
890         * WebKitTestRunner/TestController.cpp:
891         (WTR::TestController::initialize):
892
893 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
894
895         TestWebKitAPI isn't being built on chromium bots any more
896         https://bugs.webkit.org/show_bug.cgi?id=77563
897
898         Reviewed by Dimitri Glazkov.
899
900         I accidentally dropped it in the refactoring in r105449.
901
902         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
903
904 2012-02-01  Hans Wennborg  <hans@chromium.org>
905
906         Rename WebSpeechInputResult::set() to assign()
907         https://bugs.webkit.org/show_bug.cgi?id=77540
908
909         Reviewed by Darin Fisher.
910
911         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
912         (MockWebSpeechInputController::addMockRecognitionResult):
913         (MockWebSpeechInputController::speechTaskFired):
914
915 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
916
917         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
918         https://bugs.webkit.org/show_bug.cgi?id=77542
919
920         Reviewed by Martin Robinson.
921
922         * gtk/generate-gtkdoc: Check first whether there's
923         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
924         instead.
925         (get_webkit2_options): Return just the options since the
926         pkg_config_path doesn't depend on options
927         (get_webkit1_options): Ditto.
928         (generate_doc): Helper function to create a generator and generate
929         documentation for the given pkg-config file with the given options.
930         * gtk/gtkdoc.py:
931         (GTKDoc.__init__): Don't use ** for args parameter, since it's
932         used as a dict and never expanded.
933         (PkgConfigGTKDoc.__init__): Ditto.
934
935 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
936
937         [GTK] API documentation is not installed even when building with --enable-gtk-doc
938         https://bugs.webkit.org/show_bug.cgi?id=77094
939
940         Reviewed by Martin Robinson.
941
942         * GNUmakefile.am: Add install-data-local and uninstall-local rules
943         to install/uninstall WebKit1 and WebKit2 API documentation.
944
945 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
946
947         Unreviewed, rolling out r106460.
948         http://trac.webkit.org/changeset/106460
949         https://bugs.webkit.org/show_bug.cgi?id=77552
950
951         It break unit tests if WEBKIT_TESTFONTS isn't defined.
952         (Requested by Ossy on #webkit).
953
954         * Scripts/webkitpy/layout_tests/port/qt.py:
955
956 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
957
958         [Qt] Automatic clean build feature always do clean build with --no-webkit2
959         https://bugs.webkit.org/show_bug.cgi?id=74519
960
961         Reviewed by Tor Arne Vestbø.
962
963         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
964
965         * qmake/mkspecs/features/features.prf:
966
967 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
968
969         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
970         https://bugs.webkit.org/show_bug.cgi?id=77466
971
972         Reviewed by Kenneth Rohde Christiansen.
973
974         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
975         is set or if we should raise an error.
976
977         * Scripts/webkitpy/layout_tests/port/qt.py:
978         (QtPort.setup_environ_for_server):
979
980 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
981
982         Reviewed by Martin Robinson.
983
984         [GTK] Improve FrameLoader signals. Resource loading
985         https://bugs.webkit.org/show_bug.cgi?id=49543
986
987         Support for the new loader signals in DRT.
988
989         * DumpRenderTree/gtk/DumpRenderTree.cpp:
990         (urlPath):
991         (willSendRequestCallback):
992         (urlSuitableForTestResult):
993         (descriptionSuitableForTestResult):
994         (didReceiveResponse):
995         (didFinishLoading):
996         (didFailLoadingWithError):
997         (createWebView):
998
999 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
1000
1001         run-perf-tests should restart DRT for each test
1002         https://bugs.webkit.org/show_bug.cgi?id=77506
1003
1004         Reviewed by Adam Barth.
1005
1006         Always restart DRT when running performance tests in order to minimize the dependency between tests.
1007
1008         * Scripts/webkitpy/layout_tests/port/chromium.py:
1009         (ChromiumDriver.stop):
1010         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1011         (PerfTestsRunner._run_tests_set):
1012         (PerfTestsRunner._run_single_test):
1013         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1014         (create_runner):
1015         (test_run_passing_test):
1016         (test_run_silent_test):
1017         (test_run_failed_test):
1018         (test_run_tonguey_test):
1019         (test_run_timeout_test):
1020         (test_run_crash_test):
1021         (test_run_test_set_kills_drt_per_run):
1022         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1023         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
1024         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
1025
1026 2012-01-31  Hans Wennborg  <hans@chromium.org>
1027
1028         Speech Input: Report speech element rect relative to window rather than frame
1029         https://bugs.webkit.org/show_bug.cgi?id=76443
1030
1031         Reviewed by Darin Fisher.
1032
1033         Update LayoutTestController to allow for retrieving the speech
1034         element's position used in a request.
1035
1036         In Chromium this is handled by the MockWebSpeechInputController;
1037         adding stubs for the other implementations.
1038
1039         * DumpRenderTree/LayoutTestController.cpp:
1040         (setMockSpeechInputDumpRectCallback):
1041         (LayoutTestController::staticFunctions):
1042         * DumpRenderTree/LayoutTestController.h:
1043         (LayoutTestController):
1044         * DumpRenderTree/chromium/LayoutTestController.cpp:
1045         (LayoutTestController::LayoutTestController):
1046         (LayoutTestController::setMockSpeechInputDumpRect):
1047         * DumpRenderTree/chromium/LayoutTestController.h:
1048         (LayoutTestController):
1049         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1050         (MockWebSpeechInputController::setDumpRect):
1051         (MockWebSpeechInputController::clearResults):
1052         (MockWebSpeechInputController::startRecognition):
1053         (MockWebSpeechInputController::MockWebSpeechInputController):
1054         (makeRectResult):
1055         (MockWebSpeechInputController::speechTaskFired):
1056         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
1057         (MockWebSpeechInputController):
1058         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1059         (LayoutTestController::setMockSpeechInputDumpRect):
1060         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1061         (LayoutTestController::setMockSpeechInputDumpRect):
1062         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1063         (LayoutTestController::setMockSpeechInputDumpRect):
1064         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1065         (LayoutTestController::setMockSpeechInputDumpRect):
1066         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1067         (LayoutTestController):
1068         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1069         (LayoutTestController::setMockSpeechInputDumpRect):
1070         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1071         (LayoutTestController::setMockSpeechInputDumpRect):
1072
1073 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
1074
1075         [EFL] Add basic DRT/Efl implementation to support viewport test.
1076         https://bugs.webkit.org/show_bug.cgi?id=77320
1077
1078         Reviewed by Andreas Kling.
1079
1080         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1081         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
1082
1083 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
1084
1085         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
1086         https://bugs.webkit.org/show_bug.cgi?id=77473
1087         <rdar://problem/10751357>
1088
1089         Reviewed by Darin Adler.
1090
1091         * DumpRenderTree/mac/EventSendingController.mm:
1092         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1093         * WebKitTestRunner/mac/EventSenderProxy.mm:
1094         (WTR::EventSenderProxy::keyDown):
1095         Added a new special keyDown value to test this.
1096
1097 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
1098
1099         nrwt: fix the mock port to work with DriverProxy, reftests
1100         https://bugs.webkit.org/show_bug.cgi?id=77170
1101
1102         Reviewed by Eric Seidel.
1103
1104         The DryrunPort used for benchmarking and testing NRWT has been
1105         broken since we added the DriverProxy code. It isn't really
1106         needed any more, so I've removed it.
1107
1108         The MockDRT port was also broken by DriverProxy, and moreover,
1109         never worked w/ reftests. Since we don't exercise this module in
1110         the unit tests, the code had also bitrotted some. I have cleaned
1111         it up and made it use DriverInput and DriverOutput for
1112         consistency.
1113
1114         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1115         (DryRunPort.__init__):
1116         (DryRunPort):
1117         (DryRunPort.real_name):
1118         (DryRunPort.create_driver):
1119         (DryRunPort.driver_cmd_line):
1120         (DryRunPort._driver_class):
1121         (DryrunDriver):
1122         (DryrunDriver.run_test):
1123         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1124         (MockDRTPort.create_driver):
1125         (MockChromiumDRT.run_one_test):
1126
1127 2012-01-31  Ojan Vafai  <ojan@chromium.org>
1128
1129         run-webkit-tests calls out to webkit-build-directory twice
1130         https://bugs.webkit.org/show_bug.cgi?id=77248
1131
1132         Reviewed by Dirk Pranke.
1133
1134         * Scripts/webkit-build-directory:
1135         If called with no arguments, print out both the top-level directory and the 
1136         configuration directory
1137
1138         * Scripts/webkitpy/layout_tests/port/config.py:
1139         (Config.build_directory):
1140         When called with no arguments, get and cache both the top-level and configuration directories.
1141
1142         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1143         (main):
1144         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1145         (ConfigTest.assert_configuration):
1146         (ConfigTest.test_build_directory.mock_webkit_build_directory):
1147         (ConfigTest.test_build_directory):
1148         (ConfigTest.test_default_configuration__notfound):
1149         * Scripts/webkitpy/layout_tests/port/webkit.py:
1150         (WebKitPort._build_path):
1151         Cache the build directory in the options object so that other users
1152         of the options object don't need to call out to webkit-build-directory.
1153         Also, properly support the existing --build-directory argument.
1154
1155 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1156
1157         Bump up the timeout for performance tests since DOM/DOMTable.html
1158         and Parser/html5-full-render.html are timing out on the bot.
1159
1160         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1161         (PerfTestsRunner._parse_args):
1162
1163 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
1164
1165         Fix the update_webgl_conformance_tests.py script in order to enable it
1166         to detect the SCM being used correctly.
1167         https://bugs.webkit.org/show_bug.cgi?id=77462
1168
1169         Reviewed by Kenneth Russell.
1170
1171         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1172         (default_out_dir):
1173
1174 2012-01-31  Eric Seidel  <eric@webkit.org>
1175
1176         webkit-patch apply-from-bug should work regardless of your CWD
1177         https://bugs.webkit.org/show_bug.cgi?id=77482
1178
1179         Reviewed by Adam Barth.
1180
1181         webkit-patch only ever works with patches made from the root
1182         directory.  We should pass the CWD to svn-apply in the case
1183         where we're running not from the webkit root.  I believe
1184         this used to work in the past and regressed.
1185
1186         * Scripts/webkitpy/common/checkout/checkout.py:
1187         (Checkout.apply_patch):
1188         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1189         (CheckoutTest.test_apply_patch):
1190
1191 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1192
1193         Unreviewed, rolling out r106302.
1194         http://trac.webkit.org/changeset/106302
1195         https://bugs.webkit.org/show_bug.cgi?id=77472
1196
1197         Broke building DRT before running the tests (Requested by ojan
1198         on #webkit).
1199
1200         * Scripts/webkit-build-directory:
1201         * Scripts/webkitpy/layout_tests/port/config.py:
1202         (Config.build_directory):
1203         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1204         (main):
1205         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1206         (ConfigTest.assert_configuration):
1207         (ConfigTest.test_build_directory.mock_webkit_build_directory):
1208         (ConfigTest.test_build_directory):
1209         (ConfigTest.test_default_configuration__notfound):
1210         * Scripts/webkitpy/layout_tests/port/webkit.py:
1211         (WebKitPort._build_path):
1212
1213 2012-01-31  Antoine Labour  <piman@chromium.org>
1214
1215         Merge WebGraphicsContext3D creation and initialization, and move it to
1216         WebViewClient.
1217         https://bugs.webkit.org/show_bug.cgi?id=76593
1218
1219         Reviewed by Darin Fisher.
1220
1221         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1222         (TestWebPlugin::TestWebPlugin):
1223         (TestWebPlugin::initialize):
1224         * DumpRenderTree/chromium/TestWebPlugin.h:
1225         * DumpRenderTree/chromium/WebViewHost.cpp:
1226         (WebViewHost::createGraphicsContext3D):
1227         (WebViewHost::createPlugin):
1228         * DumpRenderTree/chromium/WebViewHost.h:
1229
1230 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
1231
1232         [GTK] build-webkit warning.
1233         https://bugs.webkit.org/show_bug.cgi?id=77411
1234
1235         Reviewed by Philippe Normand.
1236
1237         * Scripts/webkitdirs.pm:
1238         (isCrossCompilation):
1239
1240 2012-01-31  Dan Bernstein  <mitz@apple.com>
1241
1242         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
1243
1244         Reviewed by Anders Carlsson.
1245
1246         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1247
1248 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
1249
1250         If the QTDIR environment variable is set, the build system fails to compile WinCairo
1251         https://bugs.webkit.org/show_bug.cgi?id=77112
1252
1253         Reviewed by Daniel Bates.
1254
1255         * Scripts/webkitdirs.pm:
1256         (determineIsQt):
1257
1258 2012-01-31  Adam Roben  <aroben@apple.com>
1259
1260         Only call -typingAttributes on WebViews, not WebHTMLViews
1261
1262         Looks like this case was just missed in r105908.
1263
1264         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
1265
1266         Reviewed by Antti Koivisto.
1267
1268         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1269         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
1270         earlier.
1271
1272 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1273
1274         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
1275         https://bugs.webkit.org/show_bug.cgi?id=77221
1276
1277         Reviewed by Kenneth Rohde Christiansen.
1278
1279         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
1280
1281         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1282         (MiniBrowserApplication::sendTouchEvent):
1283
1284 2012-01-26  Hans Wennborg  <hans@chromium.org>
1285
1286         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1287         https://bugs.webkit.org/show_bug.cgi?id=77083
1288
1289         Reviewed by Darin Fisher.
1290
1291         Add MockWebSpeechInputController which provides a mock implementation
1292         of the WebSpeechInputController interface, and use that in
1293         DumpRenderTree.
1294
1295         * DumpRenderTree/DumpRenderTree.gypi:
1296         * DumpRenderTree/chromium/LayoutTestController.cpp:
1297         (LayoutTestController::addMockSpeechInputResult):
1298         * DumpRenderTree/chromium/LayoutTestController.h:
1299         ():
1300         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1301         (MockWebSpeechInputController::create):
1302         (MockWebSpeechInputController::addMockRecognitionResult):
1303         (MockWebSpeechInputController::clearResults):
1304         (MockWebSpeechInputController::startRecognition):
1305         (MockWebSpeechInputController::cancelRecognition):
1306         (MockWebSpeechInputController::stopRecording):
1307         (MockWebSpeechInputController::MockWebSpeechInputController):
1308         (MockWebSpeechInputController::speechTaskFired):
1309         (MockWebSpeechInputController::SpeechTask::SpeechTask):
1310         (MockWebSpeechInputController::SpeechTask::stop):
1311         (MockWebSpeechInputController::SpeechTask::runIfValid):
1312         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1313         (WebKit):
1314         (MockWebSpeechInputController):
1315         (MockWebSpeechInputController::taskList):
1316         (SpeechTask):
1317         * DumpRenderTree/chromium/TestShell.cpp:
1318         * DumpRenderTree/chromium/WebViewHost.cpp:
1319         (WebViewHost::speechInputController):
1320         * DumpRenderTree/chromium/WebViewHost.h:
1321         (WebKit):
1322         (WebViewHost::speechInputControllerMock):
1323         (WebViewHost):
1324         ():
1325
1326 2012-01-31  Hajime Morrita  <morrita@chromium.org>
1327
1328         [PerformanceTests] Add landing html for Dromaeo dom-query test
1329         https://bugs.webkit.org/show_bug.cgi?id=77329
1330
1331         Reviewed by Ryosuke Niwa.
1332
1333         Added some more ignorable output patterns to allow warnings
1334         from a third party test suite.
1335
1336         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1337         (PerfTestsRunner):
1338         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1339
1340 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
1341
1342         [wx] Unreviewed. Update download URLs to new domain.
1343         
1344         * waf/build/build_utils.py:
1345         (update_wx_deps):
1346
1347 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
1348
1349         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
1350         to the list of build directories.
1351         
1352         * waf/build/settings.py:
1353
1354 2012-01-30  Kentaro Hara  <haraken@chromium.org>
1355
1356         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
1357         output an empty method name (i.e. "()")
1358         https://bugs.webkit.org/show_bug.cgi?id=77336
1359
1360         Reviewed by Darin Adler.
1361
1362         r105797 tried to detect a change outside methods, but it causes a bug that
1363         prepare-ChangeLog can output an empty method name, like this:
1364
1365             * foo/bar/baz.cpp:
1366             (method1):
1367             ():
1368             (method2):
1369
1370         This is because the cpp parser in prepare-ChangeLog cannot distinguish
1371         '{' as the beginning of a method with '{' as the beginning of an array definition
1372         at the top level.
1373
1374             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
1375
1376             void func() { // This '{' is the beginning of a method.
1377                 ...;
1378             }
1379
1380         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
1381
1382         * Scripts/prepare-ChangeLog:
1383         (get_function_line_ranges_for_cpp): Modified as described above.
1384         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
1385         an empty method name. Ideally this should not happen but may happen, since the
1386         parsers are not perfect.
1387         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
1388         (NameSpace7):
1389         (NameSpace8):
1390         (Class109):
1391         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1392
1393 2012-01-30  Ojan Vafai  <ojan@chromium.org>
1394
1395         run-webkit-tests calls out to webkit-build-directory twice
1396         https://bugs.webkit.org/show_bug.cgi?id=77248
1397
1398         Reviewed by Dirk Pranke.
1399
1400         This reduces to calls to webkit-build-directory to one call and
1401         saves 500ms for run-webkit-tests over a single file.
1402
1403         * Scripts/webkit-build-directory:
1404         If called with no arguments, print out both the top-level directory and the 
1405         configuration directory.
1406
1407         * Scripts/webkit-build-directory:
1408         * Scripts/webkitpy/layout_tests/port/config.py:
1409         (Config.build_directory):
1410         When called with no arguments, get and cache both the top-level and configuration directories.
1411
1412         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1413         (main):
1414         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1415         (ConfigTest.assert_configuration):
1416         (ConfigTest.test_build_directory.mock_webkit_build_directory):
1417         (ConfigTest.test_build_directory):
1418         (ConfigTest.test_default_configuration__notfound):
1419         * Scripts/webkitpy/layout_tests/port/webkit.py:
1420         (WebKitPort._build_path):
1421         Cache the root directory in the options object so that other users
1422         of the options object don't need to call out to webkit-build-directory.
1423
1424 2012-01-30  Ojan Vafai  <ojan@chromium.org>
1425
1426         Parsing test_expecations.txt + Skipped lists takes too long
1427         https://bugs.webkit.org/show_bug.cgi?id=77059
1428
1429         Reviewed by Dirk Pranke.
1430
1431         This saves ~100ms on the Apple Mac port.
1432         -memoize a bunch of path methods.
1433         -Avoid doing multiple disk accesses per line.
1434         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1435         formatting string and parsing that.
1436
1437         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1438         (TestExpectationParser):
1439         (TestExpectationParser.expectation_for_skipped_test):
1440         (TestExpectationParser._parse_line):
1441         (TestExpectationParser._collect_matching_tests):
1442         (TestExpectations.__init__):
1443         (TestExpectations._add_skipped_tests):
1444         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1445         (test_add_skipped_tests):
1446         (test_add_skipped_tests_duplicate):
1447         * Scripts/webkitpy/layout_tests/port/base.py:
1448         (Port):
1449         (Port.test_isfile):
1450         (Port.normalize_test_name):
1451         (Port.layout_tests_dir):
1452         (Port.abspath_for_test):
1453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1454
1455 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
1456
1457         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
1458         
1459         * Scripts/webkitpy/common/config/watchlist:
1460
1461 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
1462
1463         Unreviewed build fix following bug#76855
1464
1465         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1466         ():
1467         (TestWebKitAPI::TEST_F):
1468
1469 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1470
1471         [Qt] WKTR: Use a software rendering pipiline when running tests.
1472         https://bugs.webkit.org/show_bug.cgi?id=76708
1473
1474         Reviewed by Kenneth Rohde Christiansen.
1475
1476         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1477         (WTR::WrapperWindow::WrapperWindow):
1478         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1479
1480 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1481
1482         [Qt] Store build config immediately instead of waiting for a successfull build
1483
1484         Otherwise we will not pick up changes to the config if the build is aborted,
1485         for example due to build errors or if the user pressed Ctrl+Z. We now write
1486         the new config before starting a build, but still defer to write the SVN
1487         revision once the build completes successfully.
1488
1489         Reviewed by Ossy.
1490
1491         * Scripts/webkitdirs.pm:
1492         (buildQMakeProjects):
1493
1494 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
1495
1496         [Qt] Add "New Window" button to the Qt MiniBrowser
1497         https://bugs.webkit.org/show_bug.cgi?id=77281
1498
1499         Reviewed by Tor Arne Vestbø.
1500
1501         * MiniBrowser/qt/BrowserWindow.cpp:
1502         (BrowserWindow::BrowserWindow):
1503         * MiniBrowser/qt/MiniBrowser.qrc:
1504         * MiniBrowser/qt/icons/plus.png: Added.
1505         * MiniBrowser/qt/qml/BrowserWindow.qml:
1506
1507 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1508
1509         Unreviewed rolling out r106222.
1510
1511         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1512         (SingleTestRunner.__init__):
1513         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1514         (Worker.handle_test_list):
1515         * Scripts/webkitpy/layout_tests/models/test_input.py:
1516         (TestInput.__init__):
1517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1518         (_set_up_derived_options):
1519         (parse_args):
1520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1521         (MainTest.test_repeat_each):
1522         * WebKitTestRunner/TestInvocation.cpp:
1523         (WTR::TestInvocation::setIsPixelTest):
1524
1525 2012-01-30  Hans Wennborg  <hans@chromium.org>
1526
1527         Unreviewed, rolling out r106219.
1528         http://trac.webkit.org/changeset/106219
1529         https://bugs.webkit.org/show_bug.cgi?id=77083
1530
1531         This broke Chromium's test_shell.
1532
1533         * DumpRenderTree/DumpRenderTree.gypi:
1534         * DumpRenderTree/chromium/LayoutTestController.cpp:
1535         (LayoutTestController::addMockSpeechInputResult):
1536         * DumpRenderTree/chromium/LayoutTestController.h:
1537         (WebKit):
1538         (LayoutTestController):
1539         ():
1540         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
1541         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
1542         * DumpRenderTree/chromium/TestShell.cpp:
1543         * DumpRenderTree/chromium/WebViewHost.cpp:
1544         (WebViewHost::speechInputController):
1545         * DumpRenderTree/chromium/WebViewHost.h:
1546         (WebKit):
1547         (WebViewHost::speechInputControllerMock):
1548         (WebViewHost):
1549         ():
1550
1551 2012-01-26  Hans Wennborg  <hans@chromium.org>
1552
1553         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1554         https://bugs.webkit.org/show_bug.cgi?id=77083
1555
1556         Reviewed by Darin Fisher.
1557
1558         Add MockWebSpeechInputController which provides a mock implementation
1559         of the WebSpeechInputController interface, and use that in
1560         DumpRenderTree.
1561
1562         * DumpRenderTree/DumpRenderTree.gypi:
1563         * DumpRenderTree/chromium/LayoutTestController.cpp:
1564         (LayoutTestController::addMockSpeechInputResult):
1565         * DumpRenderTree/chromium/LayoutTestController.h:
1566         ():
1567         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1568         (MockWebSpeechInputController::create):
1569         (MockWebSpeechInputController::addMockRecognitionResult):
1570         (MockWebSpeechInputController::clearResults):
1571         (MockWebSpeechInputController::startRecognition):
1572         (MockWebSpeechInputController::cancelRecognition):
1573         (MockWebSpeechInputController::stopRecording):
1574         (MockWebSpeechInputController::MockWebSpeechInputController):
1575         (MockWebSpeechInputController::speechTaskFired):
1576         (MockWebSpeechInputController::SpeechTask::SpeechTask):
1577         (MockWebSpeechInputController::SpeechTask::stop):
1578         (MockWebSpeechInputController::SpeechTask::runIfValid):
1579         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1580         (WebKit):
1581         (MockWebSpeechInputController):
1582         (MockWebSpeechInputController::taskList):
1583         (SpeechTask):
1584         * DumpRenderTree/chromium/TestShell.cpp:
1585         * DumpRenderTree/chromium/WebViewHost.cpp:
1586         (WebViewHost::speechInputController):
1587         * DumpRenderTree/chromium/WebViewHost.h:
1588         (WebKit):
1589         (WebViewHost::speechInputControllerMock):
1590         (WebViewHost):
1591         ():
1592
1593 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1594
1595         Unreviewed, rolling out r106109.
1596         http://trac.webkit.org/changeset/106109
1597         https://bugs.webkit.org/show_bug.cgi?id=77302
1598
1599         It made tests crash (Requested by Ossy_weekend on #webkit).
1600
1601         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1602         (WTR::WrapperWindow::WrapperWindow):
1603         (WTR::PlatformWebView::PlatformWebView):
1604
1605 2012-01-28  Nico Weber  <thakis@chromium.org>
1606
1607         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1608         https://bugs.webkit.org/show_bug.cgi?id=77243
1609
1610         Reviewed by Adam Barth.
1611
1612         * Scripts/update-webkit:
1613         * Scripts/webkitdirs.pm:
1614         (isChromiumNinja):
1615         (determineIsChromiumNinja):
1616         (buildChromiumNinja):
1617         (buildChromium):
1618
1619 2012-01-27  Kentaro Hara  <haraken@chromium.org>
1620
1621         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1622         https://bugs.webkit.org/show_bug.cgi?id=77241
1623
1624         Reviewed by Ryosuke Niwa.
1625
1626         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1627         in a method in some namespace or class is treated as a method.
1628         This patch fixes the bug.
1629
1630             class C {
1631                 void func()
1632                 {
1633                     if (1) {    // This should not be treated as a method.
1634                     }
1635                 }
1636             };
1637
1638         * Scripts/prepare-ChangeLog:
1639         (get_function_line_ranges_for_cpp):
1640         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1641         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1642         (Class108):
1643         (Class108::func35):
1644
1645 2012-01-27  Enrica Casucci  <enrica@apple.com>
1646
1647         Followup to http://trac.webkit.org/changeset/106171.
1648         Dan Bernstein pointed out correctly that I should
1649         have used copy instead of initWithString.
1650
1651         Reviewed by Dan Bernstein.
1652
1653         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1654         (-[LocalPasteboard initWithName:]):
1655
1656 2012-01-27  Enrica Casucci  <enrica@apple.com>
1657
1658         DRT pasteboard object should return the correct pasteboard name.
1659         https://bugs.webkit.org/show_bug.cgi?id=77260
1660         
1661         Currently the name property always returns nil.
1662         Adding a memeber variable to store the pasteboard name and return its
1663         value from the name method instead of returning nil always.
1664
1665         Reviewed by Dan Bernstein.
1666
1667         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1668         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1669         (-[LocalPasteboard initWithName:]):
1670         (-[LocalPasteboard name]):
1671
1672 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
1673
1674         [GTK] [WK2] Implement the policy client
1675         https://bugs.webkit.org/show_bug.cgi?id=76343
1676
1677         Reviewed by Gustavo Noronha Silva.
1678
1679         * gtk/generate-gtkdoc:
1680         (get_webkit2_options): Update the list of skipped source files to include all clients.
1681
1682 2012-01-27  Ada Chan  <adachan@apple.com>
1683
1684         Add test for WKBundleFrameGetParentFrame().
1685         https://bugs.webkit.org/show_bug.cgi?id=77161
1686
1687         Reviewed by Anders Carlsson.
1688
1689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1690         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1691         (TestWebKitAPI):
1692         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1693         (TestWebKitAPI::setInjectedBundleClient):
1694         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1695         Make sure the check is successful.
1696         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1697         (TestWebKitAPI):
1698         (ParentFrameTest):
1699         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1700         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1701         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1702         to the test controller.
1703         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1704
1705 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
1706
1707         [Gtk] DumpRenderTree lacks --no-timeout command line option
1708         https://bugs.webkit.org/show_bug.cgi?id=77196
1709
1710         Reviewed by Martin Robinson.
1711
1712         Add the --no-timeout command line option and reorganize
1713         watchdog code to make running DumpRenderTree without
1714         timeout possible.
1715
1716         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1717         (setWaitToDumpWatchdog):
1718         (shouldSetWaitToDumpWatchdog):
1719         (initializeGlobalsFromCommandLineOptions):
1720         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1721         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1722         (waitToDumpWatchdogFired):
1723         (LayoutTestController::setWaitToDump):
1724
1725 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
1726
1727         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1728         https://bugs.webkit.org/show_bug.cgi?id=77122
1729
1730         Reviewed by Kenneth Rohde Christiansen.
1731
1732         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1733         (MiniBrowserApplication::MiniBrowserApplication):
1734
1735 2012-01-27  Zeno Albisser  <zeno@webkit.org>
1736
1737         [Qt][Mac] Build fails after adding ICU support (r105997).
1738         https://bugs.webkit.org/show_bug.cgi?id=77118
1739
1740         Define WTF_USE_ICU_UNICODE if we are on mac.
1741
1742         Reviewed by Tor Arne Vestbø.
1743
1744         * qmake/mkspecs/features/features.prf:
1745
1746 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
1747
1748         Update committers.py with new contributors.
1749         https://bugs.webkit.org/show_bug.cgi?id=77207
1750
1751         I added six new contributors into committers.py:
1752
1753         - Adam Kallai
1754         - Balazs Ankes
1755         - Janos Badics
1756         - Nandor Huszka
1757         - Roland Takacs
1758         - Szilard Ledan-Muntean
1759
1760         * Scripts/webkitpy/common/config/committers.py:
1761
1762 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1763
1764         Add Vsevolod Vlasov to reviewers list.
1765
1766         Reviewed by Pavel Feldman.
1767
1768         * Scripts/webkitpy/common/config/committers.py:
1769
1770 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1771
1772         [Qt] WKTR: Use a software rendering pipiline when running tests.
1773         https://bugs.webkit.org/show_bug.cgi?id=76708
1774
1775         Reviewed by Kenneth Rohde Christiansen.
1776
1777         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1778         (WTR::WrapperWindow::WrapperWindow):
1779         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1780
1781 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1782
1783         [wx] Unreviewed. Build fix, add WebCore/testing/js
1784         to the list of source directories we build.
1785
1786         * waf/build/settings.py:
1787
1788 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1789
1790         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1791         https://bugs.webkit.org/show_bug.cgi?id=77177
1792
1793         Reviewed by Jon Honeycutt.
1794
1795         * Scripts/commit-log-editor:
1796
1797 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1798
1799         Decrease sleep time when killing server_process on Mac.
1800         https://bugs.webkit.org/show_bug.cgi?id=77169
1801
1802         Reviewed by Eric Seidel.
1803
1804         This shaves another ~70ms off single test runtime.
1805
1806         * Scripts/webkitpy/layout_tests/port/server_process.py:
1807         (ServerProcess.stop):
1808
1809 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1810
1811         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1812         https://bugs.webkit.org/show_bug.cgi?id=77164
1813
1814         Reviewed by Dirk Pranke.
1815
1816         http://trac.webkit.org/changeset/106035 depends on builder_name being
1817         falsey by default. There's other code that requires it to be iterable
1818         by default. So, make it be the empty string.
1819
1820         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1821         (parse_args):
1822
1823 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1824
1825         run-perf-test should include relative file paths in test names
1826         https://bugs.webkit.org/show_bug.cgi?id=77144
1827
1828         Reviewed by Adam Birth.
1829
1830         Include all directory names in the test name separated by "/".
1831         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1832
1833         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1834         (PerfTestsRunner):
1835         (PerfTestsRunner._process_parser_test_result):
1836         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1837         (test_run_test_set_with_json_output):
1838         (test_run_test_set_with_json_source):
1839
1840 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1841
1842         webkitpy: re-land cleanup of test scaffolding
1843         https://bugs.webkit.org/show_bug.cgi?id=77153
1844
1845         Reviewed by Eric Seidel.
1846
1847         This is an attempt to reland the change in bug 76973 / 
1848         r105935. My earlier attempt to manipulate PYTHONPATH
1849         seems to only work some of the time, for reasons that
1850         elude me. Directly adding Tools/Scripts to sys.path from
1851         inside the test script appears to work (more?) reliably.
1852
1853         Also, it seemed like the files didn't actually get deleted
1854         the last time; I don't know why.
1855
1856         * Scripts/test-webkitpy:
1857         * Scripts/webkitpy/common/system/executive_unittest.py:
1858         (command_line):
1859         (ExecutiveTest):
1860         (ExecutiveTest.test_run_command_args_type):
1861         (ExecutiveTest.test_run_command_with_unicode):
1862         (ExecutiveTest.test_running_pids):
1863         (main):
1864         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1865         * Scripts/webkitpy/test/cat.py: Removed.
1866         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1867         * Scripts/webkitpy/test/echo.py: Removed.
1868         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1869
1870 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1871
1872         run-webkit-tests calls "nm" when it doesn't need to
1873         https://bugs.webkit.org/show_bug.cgi?id=77143
1874
1875         Reviewed by Dirk Pranke.
1876
1877         If we are not running any test that can be skipped by checking
1878         the DRT feature list or looking at the list of symbols, avoid calling
1879         out to DRT or calling "nm".
1880
1881         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1882         to "nm" it's only a couple ms slower.
1883
1884         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1885         (TestExpectations.__init__):
1886         * Scripts/webkitpy/layout_tests/port/base.py:
1887         (Port.skipped_tests):
1888         * Scripts/webkitpy/layout_tests/port/webkit.py:
1889         (WebKitPort._should_check_for_missing_features):
1890         (WebKitPort):
1891         (WebKitPort._should_check_for_missing_symbols):
1892         (WebKitPort._skipped_tests_for_unsupported_features):
1893         (WebKitPort.skipped_layout_tests):
1894         (WebKitPort.skipped_tests):
1895         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1896         (WebKitPortTest.test_skipped_directories_for_symbols):
1897         (test_skipped_directories_for_features):
1898         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1899         (test_skipped_layout_tests):
1900
1901 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1902
1903         Support a suffix on ChangeLog filenames based on a configuration file
1904         https://bugs.webkit.org/show_bug.cgi?id=76956
1905
1906         Reviewed by Kentaro Hara.
1907
1908         Modify the tools used to generate, edit and resolve ChangeLogs to support
1909         the addition of a suffix to the ChangeLog filename.
1910
1911         This patch makes it easier to support alternate ChangeLog files in branches.
1912
1913         * Scripts/VCSUtils.pm:
1914         (changeLogSuffix):
1915         (changeLogFileName):
1916         * Scripts/commit-log-editor:
1917         * Scripts/prepare-ChangeLog:
1918         (getLatestChangeLogs):
1919         (generateNewChangeLogs):
1920         (generateFileList):
1921         * Scripts/resolve-ChangeLogs:
1922         (findChangeLog):
1923
1924 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1925
1926         Unreviewed, rolling out r106038.
1927         http://trac.webkit.org/changeset/106038
1928         https://bugs.webkit.org/show_bug.cgi?id=77142
1929
1930         Caused a bunch of skipped tests to not be skipped. (Requested
1931         by ojan on #webkit).
1932
1933         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1934         (TestExpectationParser):
1935         (TestExpectationParser.parse):
1936         (TestExpectationParser._parse_line):
1937         (TestExpectationParser._collect_matching_tests):
1938         (TestExpectations.__init__):
1939         (TestExpectations._add_skipped_tests):
1940         * Scripts/webkitpy/layout_tests/port/base.py:
1941         (Port.test_dirs):
1942         (Port.normalize_test_name):
1943         (Port.update_baseline):
1944         (Port.layout_tests_dir):
1945         (Port.relative_perf_test_filename):
1946         (Port.abspath_for_test):
1947
1948 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1949
1950         Parsing test_expecations.txt + Skipped lists takes too long
1951         https://bugs.webkit.org/show_bug.cgi?id=77059
1952
1953         Reviewed by Dirk Pranke.
1954
1955         This saves ~100ms on the Apple Mac port.
1956         -memoize a bunch of path methods.
1957         -Avoid doing multiple disk accesses per line.
1958         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1959         formatting string and parsing that.
1960
1961         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1962         (TestExpectationParser):
1963         (TestExpectationParser.parse_skipped_tests):
1964         (TestExpectationParser._parse_line):
1965         (TestExpectationParser._collect_matching_tests):
1966         (TestExpectations.__init__):
1967         (TestExpectations._add_skipped_tests):
1968         * Scripts/webkitpy/layout_tests/port/base.py:
1969         (Port):
1970         (Port.test_isfile):
1971         (Port.normalize_test_name):
1972         (Port.layout_tests_dir):
1973         (Port.abspath_for_test):
1974
1975 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1976
1977         Only store the SVN revision in the summarized results if we're on a builder
1978         https://bugs.webkit.org/show_bug.cgi?id=76976
1979
1980         Reviewed by Dirk Pranke.
1981
1982         This shaves another ~130ms off the single test run-webkit-tests runtime.
1983
1984         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1985         (summarize_results):
1986         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1987         (ResultSummaryTest.get_result):
1988         (ResultSummaryTest):
1989         (ResultSummaryTest.get_result_summary):
1990         (ResultSummaryTest.get_unexpected_results):
1991         (ResultSummaryTest.test_no_svn_revision):
1992         (ResultSummaryTest.test_svn_revision):
1993         * Scripts/webkitpy/layout_tests/port/base.py:
1994         (Port.use_trac_links_in_results_html):
1995
1996 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1997
1998         [Qt][WK2] fast/loader tests failed after r94178
1999         https://bugs.webkit.org/show_bug.cgi?id=67388
2000
2001         Reviewed by Simon Hausmann.
2002
2003         Applying the same fix used for Qt-WebKit1 from bug #67254 -
2004         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2005         https://bugs.webkit.org/show_bug.cgi?id=67254
2006         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2007         derived from the running location of DumpRenderTree binary.
2008
2009         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2010         (WTR::LayoutTestController::pathToLocalResource):
2011
2012 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2013
2014         Implement overridePreference for boolean preferences in WebKitTestRunner
2015         https://bugs.webkit.org/show_bug.cgi?id=77033
2016
2017         Reviewed by Alexey Proskuryakov.
2018
2019         For now overridePreference supports boolean values.
2020
2021         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2022         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2023         (WTR::LayoutTestController::setXSSAuditorEnabled):
2024         (WTR::LayoutTestController::overridePreference):
2025         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2026         * WebKitTestRunner/TestController.cpp:
2027         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
2028         explicitly and properly disable the use of PageCache when resetting the
2029         state. Tests that use PageCache can now enable it via overridePreference.
2030
2031 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
2032
2033         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
2034         https://bugs.webkit.org/show_bug.cgi?id=77100
2035
2036         Reviewed by Simon Hausmann.
2037
2038         This patch makes the MiniBrowser read multiple URL's from the command
2039         line such that there will be one browser window opened for each URL.
2040
2041         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2042         (MiniBrowserApplication::handleUserOptions):
2043
2044 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
2045
2046         [Qt] The Qt MiniBrowser crashes when given multiple URL's
2047         https://bugs.webkit.org/show_bug.cgi?id=77009
2048
2049         Reviewed by Simon Hausmann.
2050
2051         This patch fixes a crash in BrowserWindow::newWindow() where a
2052         BrowserWindow-object is constructed with a 0 pointer as the
2053         WindowOptions parameter which leads to a crash.
2054
2055         * MiniBrowser/qt/BrowserWindow.cpp:
2056         (BrowserWindow::BrowserWindow):
2057         (BrowserWindow::newWindow):
2058         * MiniBrowser/qt/BrowserWindow.h:
2059
2060 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2061
2062         [Qt] Use ICU if available
2063         https://bugs.webkit.org/show_bug.cgi?id=76821
2064
2065         Reviewed by Simon Hausmann.
2066
2067         Adding unicode defines for a Qt 5 based build.
2068
2069         * qmake/mkspecs/features/features.prf:
2070
2071 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2072
2073         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
2074         https://bugs.webkit.org/show_bug.cgi?id=42545
2075
2076         Reviewed by Zoltan Herczeg.
2077
2078         Implement the setGeolocationPermission method.
2079
2080         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2081         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2082         (WTR::LayoutTestController::setGeolocationPermission):
2083         (WTR):
2084         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2085         (LayoutTestController):
2086
2087 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
2088
2089         [NRWT] Support --ignore-metrics
2090         https://bugs.webkit.org/show_bug.cgi?id=76278
2091
2092         Reviewed by Tony Chang.
2093
2094         Port the feature from ORWT.
2095
2096         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2097         (SingleTestRunner._run_compare_test):
2098         * Scripts/webkitpy/layout_tests/port/driver.py:
2099         (DriverOutput):
2100         (DriverOutput.strip_metrics):
2101         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2102         (DriverOutputTest):
2103         (DriverOutputTest.test_strip_metrics):
2104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2105         (_set_up_derived_options):
2106         (parse_args):
2107
2108 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2109
2110         Unreviewed, rolling out r105935 and r105954.
2111         http://trac.webkit.org/changeset/105935
2112         http://trac.webkit.org/changeset/105954
2113         https://bugs.webkit.org/show_bug.cgi?id=77080
2114
2115         test-webkitpy is still broken (Requested by abarth on
2116         #webkit).
2117
2118         * Scripts/test-webkitpy:
2119         * Scripts/webkitpy/common/system/executive_unittest.py:
2120         (never_ending_command):
2121         (ExecutiveTest.test_run_command_args_type):
2122         (ExecutiveTest.test_run_command_with_unicode):
2123         (ExecutiveTest.test_running_pids):
2124         * Scripts/webkitpy/common/system/fileutils.py:
2125         (make_stdout_binary):
2126         * Scripts/webkitpy/test/cat.py:
2127         (command_arguments):
2128         (main):
2129         * Scripts/webkitpy/test/cat_unittest.py:
2130         (CatTest):
2131         (CatTest.assert_cat):
2132         (CatTest.test_basic):
2133         (CatTest.test_no_newline):
2134         (CatTest.test_unicode):
2135         (CatTest.test_as_command):
2136         * Scripts/webkitpy/test/echo.py:
2137         (command_arguments):
2138         (main):
2139         * Scripts/webkitpy/test/echo_unittest.py:
2140         (EchoTest):
2141         (EchoTest.test_basic):
2142         (EchoTest.test_no_newline):
2143         (EchoTest.test_unicode):
2144         (EchoTest.test_argument_order):
2145         (EchoTest.test_empty_arguments):
2146         (EchoTest.test_no_arguments):
2147         (EchoTest.test_as_command):
2148
2149 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
2150
2151         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
2152         https://bugs.webkit.org/show_bug.cgi?id=76138
2153
2154         Reviewed by Martin Robinson.
2155
2156         * Scripts/webkitdirs.pm:
2157         (isCrossCompilation):
2158         (buildAutotoolsProject):
2159
2160 2012-01-25  Adam Barth  <abarth@webkit.org>
2161
2162         Kentaro is a reviewer now.  Yay!
2163
2164         * Scripts/webkitpy/common/config/committers.py:
2165
2166 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2167
2168         nrwt: running w/ no arguments fails
2169         https://bugs.webkit.org/show_bug.cgi?id=77064
2170
2171         Unreviewed, build fix.
2172
2173         This change fixes a regression introduced in r105944
2174         where running without --platform <foo> or one of the other
2175         platform switches would cause a null deref :(.
2176
2177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2178         (main):
2179
2180 2012-01-25  Eric Seidel  <eric@webkit.org>
2181
2182         Automatically CC someone from Apple on any changes to Obj-C public API
2183         https://bugs.webkit.org/show_bug.cgi?id=77053
2184
2185         Reviewed by Timothy Hatcher.
2186
2187         This has long been de-facto practice, seems now that we have
2188         fancy watchlist support, we should just make the tools
2189         do this automatically.
2190
2191         * Scripts/webkitpy/common/config/watchlist:
2192
2193 2012-01-25  Antoine Labour  <piman@chromium.org>
2194
2195         Updating status in committers.py.
2196
2197         Unreviewed.
2198
2199         * Scripts/webkitpy/common/config/committers.py:
2200
2201 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2202
2203         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
2204         https://bugs.webkit.org/show_bug.cgi?id=77058
2205
2206         Reviewed by Eric Seidel.
2207
2208         r105935 broke executive_unittest by changing which script we
2209         were running and not ensuring that the PYTHONPATH was set up
2210         properly.
2211
2212         This change also fixes a regression introduced recently where
2213         test-webkitpy wasn't figuring out the path to Tools/Scripts
2214         right, either (so running ./test-webkitpy would fail).
2215
2216         * Scripts/test-webkitpy:
2217         * Scripts/webkitpy/common/system/executive_unittest.py:
2218         (script_dir):
2219         (ExecutiveTest.setUp):
2220         (ExecutiveTest):
2221         (ExecutiveTest.tearDown):
2222
2223 2012-01-25  Adam Barth  <abarth@webkit.org>
2224
2225         Disable tests on the mac-ews while we sort out hte stability issues.
2226
2227         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2228         (MacEWS):
2229
2230 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2231
2232         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
2233         https://bugs.webkit.org/show_bug.cgi?id=76475
2234
2235         Reviewed by Eric Seidel.
2236
2237         This patch cleans up the internal usage of port names for the
2238         Apple mac and Apple win ports so that 'mac' and 'win are never
2239         considered "fully specified" port names: they are still legal
2240         input to the PortFactory.get() routine, but only if run on the given
2241         platform (i.e. trying to PortFactory.get('mac') on windows or
2242         linux will return an error, since we don't know which version of
2243         the port is desired.
2244
2245         This also cleans up handling of the webkit2 variants, so that
2246         the full port names consistently follow the
2247         <operating_system>-<version>[-<wk2>] convention.
2248
2249         Lastly this patch adds some assertions and removes some
2250         try/catch logic to catch more programming and usage errors;
2251         previously mac-tiger might've been allowed -- and it would've
2252         translated into using just the baselines in platform/mac -- but
2253         now it should fail.
2254
2255         * Scripts/webkitpy/layout_tests/port/apple.py:
2256         (ApplePort.determine_full_port_name):
2257         (ApplePort.__init__):
2258         (ApplePort):
2259         (ApplePort._port_name_with_version):
2260         * Scripts/webkitpy/layout_tests/port/builders.py:
2261         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2262         (FactoryTest.test_mac):
2263         (FactoryTest.test_win):
2264         * Scripts/webkitpy/layout_tests/port/mac.py:
2265         (MacPort.baseline_search_path):
2266         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2267         (MacTest.test_versions):
2268         * Scripts/webkitpy/layout_tests/port/win.py:
2269         (WinPort.baseline_search_path):
2270         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2271         (WinTest.test_versions):
2272
2273 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2274
2275         webkitpy: print nicer errors while linting expectations files, remove redundant tests
2276         https://bugs.webkit.org/show_bug.cgi?id=76955
2277
2278         Reviewed by Adam Barth.
2279
2280         This change cleans up the errors that are printed so that the
2281         are more "quickfix" compatible (path:lineno).
2282
2283         Also, there were a bunch of redundant tests between
2284         layout_tests.models.test_expectations_unittest and
2285         style.checkers.test_expectations_unittest. The latter should
2286         just expect the former to do most of the testing.
2287
2288         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2289         (TestExpectationParser._parse_modifiers):
2290         (TestExpectations._report_errors):
2291         (TestExpectations._add_skipped_tests):
2292         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2293         (test_parse_error_nonfatal):
2294         (SemanticTests.test_bad_bugid):
2295         * Scripts/webkitpy/style/checkers/test_expectations.py:
2296         (TestExpectationsChecker.__init__):
2297         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2298         (TestExpectationsTestCase.assert_lines_lint):
2299         (TestExpectationsTestCase.test_valid_expectations):
2300         (TestExpectationsTestCase.test_invalid_expectations):
2301         (TestExpectationsTestCase.test_tab):
2302
2303 2012-01-25  Eric Seidel  <eric@webkit.org>
2304
2305         webkit-patch apply-* should always continue after failures
2306         https://bugs.webkit.org/show_bug.cgi?id=77057
2307
2308         Reviewed by Adam Barth.
2309
2310         As far as I can tell there is only one potential drawback to always
2311         forcing: that if you're somehow in the wrong directory it will create new
2312         directories for new files.  Since webkit-patch always cd's to the root
2313         it seems that's not a drawback.  The drawback of not using --force for
2314         svn-apply, is that it will stop after the first failure, which is rarely
2315         (if ever) the desired behavior.  This just removes the force option
2316         (which was strangely hidden behind --non-interactive).  This should
2317         make for a better user experiance.
2318
2319         * Scripts/webkitpy/common/checkout/checkout.py:
2320         (Checkout.apply_patch):
2321         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2322         (MockCheckout.apply_patch):
2323         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2324         (CheckoutTest.test_chromium_deps):
2325         (CheckoutTest):
2326         (CheckoutTest.test_apply_patch):
2327         * Scripts/webkitpy/tool/commands/download_unittest.py:
2328         (DownloadCommandsTest._default_options):
2329         * Scripts/webkitpy/tool/steps/applypatch.py:
2330         (ApplyPatch.options):
2331         (ApplyPatch.run):
2332         * Scripts/webkitpy/tool/steps/options.py:
2333         (Options):
2334
2335 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2336
2337         nrwt: should be able to run --platform test interactively
2338         https://bugs.webkit.org/show_bug.cgi?id=76959
2339
2340         Reviewed by Adam Barth.
2341
2342         As part of refactoring the Port interfaces, in r103254 I made
2343         passing a Host object to the Port mandatory; previously TestPort
2344         objects would create their own (mock) hosts. However,
2345         new-run-webkit-tests always passed a real Host, not a MockHost,
2346         and so you couldn't run new-run-webkit-tests --platform test
2347         interactively to debug test failures.
2348
2349         This change fixes that by creating a MockHost instead of a real
2350         host if you say --platform test*.
2351
2352         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2353         (main):
2354
2355 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2356
2357         run-webkit-tests --lint-test-files should lint all the ports by default
2358         https://bugs.webkit.org/show_bug.cgi?id=76749
2359
2360         Reviewed by Ojan Vafai.
2361
2362         Currently run-webkit-tests --lint-test-files will only lint the
2363         test_expectations for the single port determined by the command
2364         line options. This is not obvious and can produce unintended results
2365         if you want to lint the chromium port (probably the normal case
2366         for using --lint-test-files) but don't specify a port name or
2367         --chromium.
2368
2369         I think we should probably lint *all* of the ports if no port
2370         name is supplied. This change implements that, and also moves
2371         the linting logic out of the Manager class, since this really
2372         has nothing to do with Managers. It has little to do with
2373         run-webkit-tests, but splitting it into a different script would
2374         introduce compatibility issues. It might make sense to do that
2375         anyway, in a separate patch and combining that with cleaning up
2376         the style checker to share more code.
2377
2378         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2379         (Manager._strip_test_dir_prefix):
2380         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2381         (lint):
2382         (run):
2383         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2384         (LintTest.test_all_configurations): added.
2385         (LintTest.test_lint_test_files): added.
2386         (LintTest.test_lint_test_files__errors): added.
2387         (MainTest.test_lint_test_files): removed.
2388         (MainTest.test_lint_test_files__errors): removed.
2389
2390 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2391
2392         webkitpy: clean up a bunch of test scaffolding
2393         https://bugs.webkit.org/show_bug.cgi?id=76973
2394
2395         Reviewed by Eric Seidel.
2396
2397         There were several helper modules in the webkitpy.test package
2398         that appear to only be used by executive_unittest.py. I am
2399         rolling them all into that file to make that clearer.
2400
2401         * Scripts/webkitpy/common/system/executive_unittest.py:
2402         (ExecutiveTest.test_run_command_args_type):
2403         (ExecutiveTest.test_run_command_with_unicode):
2404         (ExecutiveTest.test_running_pids):
2405         (command_line):
2406         (main):
2407         * Scripts/webkitpy/common/system/fileutils.py: Removed.
2408         * Scripts/webkitpy/test/cat.py: Removed.
2409         * Scripts/webkitpy/test/cat_unittest.py: Removed.
2410         * Scripts/webkitpy/test/echo.py: Removed.
2411         * Scripts/webkitpy/test/echo_unittest.py: Removed.
2412
2413 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2414
2415         webkitpy: clean up a bunch of test scaffolding
2416         https://bugs.webkit.org/show_bug.cgi?id=76973
2417
2418         Reviewed by Eric Seidel.
2419
2420         There were several helper modules in the webkitpy.test package
2421         that appear to only be used by executive_unittest.py. I am
2422         rolling them all into that file to make that clearer.
2423
2424         * Scripts/webkitpy/common/system/executive_unittest.py:
2425         (ExecutiveTest.test_run_command_args_type):
2426         (ExecutiveTest.test_run_command_with_unicode):
2427         (ExecutiveTest.test_running_pids):
2428         (command_line):
2429         (main):
2430         * Scripts/webkitpy/common/system/fileutils.py: Removed.
2431         * Scripts/webkitpy/test/cat.py: Removed.
2432         * Scripts/webkitpy/test/cat_unittest.py: Removed.
2433         * Scripts/webkitpy/test/echo.py: Removed.
2434         * Scripts/webkitpy/test/echo_unittest.py: Removed.
2435
2436 2012-01-25  Eric Seidel  <eric@webkit.org>
2437
2438         Remove Python 2.5 support from WebKit
2439         https://bugs.webkit.org/show_bug.cgi?id=71593
2440
2441         Reviewed by Adam Barth.
2442
2443         Just removing support from this one core file.
2444         I'll commit the rest of the (large) change once we've
2445         gone 24 hours and seen that no bots have exploded.
2446         We can roll out this one change if we break bots
2447         and then roll in the rest once those bots are fixed.
2448
2449         * Scripts/webkitpy/common/system/executive.py:
2450         (Executive.cpu_count):
2451
2452 2012-01-25  Hajime Morita  <morrita@google.com>
2453
2454         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
2455         https://bugs.webkit.org/show_bug.cgi?id=76863
2456
2457         Reviewed by Dimitri Glazkov.
2458
2459         Added a feature flag.
2460
2461         * Scripts/build-webkit:
2462         * qmake/mkspecs/features/features.prf:
2463
2464 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
2465
2466         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
2467         https://bugs.webkit.org/show_bug.cgi?id=76344
2468
2469         Reviewed by Sam Weinig.
2470
2471         Add a test verifying that the mouse button during policy decisions for
2472         events not triggered by mouse events is NoButton.
2473
2474         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2475         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
2476         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
2477
2478 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2479
2480         run-perf-tests should timeout sooner
2481         https://bugs.webkit.org/show_bug.cgi?id=77026
2482
2483         Reviewed by Adam Barth.
2484
2485         Bump off the timeout from 10 minutes to 4 minutes.
2486
2487         Also use float instead of str in test result values to compress the size of json files bots upload.
2488
2489         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2490         (PerfTestsRunner._parse_args):
2491         (PerfTestsRunner._process_chromium_style_test_result):
2492         (PerfTestsRunner._process_parser_test_result):
2493         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2494         (test_run_test_set_for_parser_tests):
2495         (test_run_test_set_with_json_output):
2496         (test_run_test_set_with_json_source):
2497
2498 2012-01-25  Enrica Casucci  <enrica@apple.com>
2499
2500         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2501         https://bugs.webkit.org/show_bug.cgi?id=76951
2502         <rdar://problem/9325158>
2503
2504         Reviewed by Alexey Proskuryakov.
2505
2506         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
2507         and WebHTMLView.
2508         (TestWebKitAPI::TEST):
2509
2510 2012-01-23  MORITA Hajime  <morrita@google.com>
2511
2512         [Refactoring][Internals] Should have InternalSettings
2513         https://bugs.webkit.org/show_bug.cgi?id=76424
2514
2515         Reviewed by Kent Tamura.
2516
2517         * GNUmakefile.am: Added so new files.
2518
2519 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
2520
2521         webkitpy: new-run-webkit-websocket is broken
2522         https://bugs.webkit.org/show_bug.cgi?id=76999
2523
2524         Reviewed by Dirk Pranke.
2525
2526         r105674 broke new-run-webkit-websocket, since options.chromium
2527         doesn't exist any more. new-run-webkit-httpd was also broken
2528         and already fixed at r105835.
2529         * Scripts/new-run-webkit-websocketserver:
2530         (main):
2531
2532 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2533
2534         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
2535         https://bugs.webkit.org/show_bug.cgi?id=63458
2536
2537         Reviewed by Adam Roben.
2538
2539         Implement the setPopupBlockingEnabled method.
2540
2541         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2542         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2543         (WTR::LayoutTestController::setPopupBlockingEnabled):
2544         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2545
2546 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
2547
2548         [Qt] Cleanup testfonts handling
2549         https://bugs.webkit.org/show_bug.cgi?id=76068
2550
2551         Reviewed by Simon Hausmann.
2552
2553         Factor test font initialization into it's own file  so test
2554         font users can share the implementation by adding the file
2555         to their build.
2556         Use fonts.conf from the test font directory to not require the
2557         current directory to be the WebKit root.
2558         Fix the -use-test-fonts option of QtTestBrowser by initializing
2559         the fonts earlier, before it is too late (namely before calling
2560         show on the main window).
2561
2562         * DumpRenderTree/qt/DumpRenderTree.pro:
2563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2564         (WebCore::DumpRenderTree::open):
2565         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2566         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
2567         (WebKit::initializeTestFonts):
2568         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
2569         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
2570         we will use the one from the test fonts directory.
2571         * DumpRenderTree/qt/main.cpp:
2572         (main): Fix the ifdefs to make it clear that the code to
2573         set up the Dpi has not been ported to Qt5 yet.
2574         * QtTestBrowser/QtTestBrowser.pro:
2575         * QtTestBrowser/launcherwindow.h:
2576         (WindowOptions::WindowOptions):
2577         * QtTestBrowser/main.cpp:
2578         (launcherMain):
2579         (LauncherApplication::handleUserOptions):
2580         * WebKitTestRunner/InjectedBundle/Target.pri:
2581         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2582         (WTR::activateFonts): Remove the code to set up the Dpi
2583         because it does not work with Qt5.
2584
2585 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
2586
2587         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
2588
2589         Reviewed by Tor Arne Vestø.
2590
2591         Don't require it by making svnRevisionForDirectory return "unknown"
2592         instead of bailing out with an error.
2593
2594         * Scripts/VCSUtils.pm:
2595         (svnRevisionForDirectory):
2596
2597 2012-01-25  Adam Barth  <abarth@webkit.org>
2598
2599         Temporarily disable running the unit tests on the Chromium EWS.  These
2600         tests don't work properly (see
2601         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2602         blocking the EWS.
2603
2604         * Scripts/webkitpy/common/config/ports.py:
2605         (ChromiumPort):
2606
2607 2012-01-25  Adam Barth  <abarth@webkit.org>
2608
2609         Update results.html version of PixelZoomer
2610         https://bugs.webkit.org/show_bug.cgi?id=76965
2611
2612         Reviewed by Ojan Vafai.
2613
2614         Improve readability as suggested by Ojan.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2617
2618 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2619
2620         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2621         https://bugs.webkit.org/show_bug.cgi?id=76899
2622
2623         Reviewed by Martin Robinson.
2624
2625         * gtk/generate-gtkdoc:
2626         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2627         WebKitLoaderClient.
2628
2629 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2630
2631         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2632
2633         * BuildSlaveSupport/build.webkit.org-config/config.json:
2634
2635 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2636
2637         WebKit needs public performance tests running on public bots
2638         https://bugs.webkit.org/show_bug.cgi?id=10266
2639
2640         Reviewed by Adam Barth.
2641
2642         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2643         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2644
2645         * BuildSlaveSupport/build.webkit.org-config/config.json:
2646         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2647         (RunAndUploadPerfTests):
2648         (RunAndUploadPerfTests.start):
2649         (UploadPerfTestResults):
2650         (BuildAndPerfTestFactory):
2651         (BuildAndPerfTestFactory.__init__):
2652
2653 2012-01-24  Ojan Vafai  <ojan@chromium.org>
2654
2655         Initializing the browser property of the Bugzilla class takes too long
2656         https://bugs.webkit.org/show_bug.cgi?id=76960
2657
2658         Reviewed by Adam Barth.
2659
2660         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2661         on my Mac Pro.
2662
2663         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2664         (Bugzilla.__init__):
2665         (Bugzilla._get_browser):
2666         (Bugzilla):
2667         (Bugzilla._set_browser):
2668
2669 2012-01-24  Mark Rowe  <mrowe@apple.com>
2670
2671         Death to JavaScriptGlue.
2672
2673         Rubber-stamped by Geoffrey Garen.
2674
2675         * BuildSlaveSupport/build-launcher-app:
2676         (copyNightlyLauncher):
2677         * Scripts/build-webkit:
2678         * Scripts/do-file-rename:
2679         * Scripts/do-webcore-rename:
2680         * Scripts/webkitpy/common/config/build.py:
2681         (_should_file_trigger_build):
2682         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2683         path in conjunction with a cross-platform path.
2684         (ShouldBuildTest):
2685
2686 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2687
2688         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2689         https://bugs.webkit.org/show_bug.cgi?id=75836
2690
2691         Reviewed by David Kilzer.
2692
2693         Previously parser_unittests.pl can just test the returned value of
2694         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2695         parser_unittests.pl so that it also tests the stdout and stderr of
2696         get_function_line_ranges().
2697
2698         This patch adds css_unittests_warning.css, which contains test cases
2699         for warning messages of the CSS parser of prepare-ChangeLog.
2700
2701         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2702         (captureOutput): Captures the stdout and stderr of a given method.
2703         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2704         string to relative paths.
2705
2706         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2707         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2708         (element1):
2709         (element2):
2710         (element3):
2711         (element4):
2712         ():
2713         (element5):
2714         (element6):
2715
2716         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2717         Just updated the test results, i.e. added stdout and stderr results.
2718         No essential changes in the test results.
2719         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2720         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2721         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2722         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2723         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2724
2725 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2726
2727         webkitpy: new-run-webkit-httpd is broken
2728         https://bugs.webkit.org/show_bug.cgi?id=76963
2729
2730         Reviewed by Adam Barth.
2731
2732         r105674 broke new-run-webkit-httpd, since options.chromium
2733         doesn't exist any more. We didn't catch this because we don't
2734         run the integration tests by default anywhere :(.
2735
2736         * Scripts/new-run-webkit-httpd:
2737         (run):
2738         (main):
2739
2740 2012-01-24  Adam Barth  <abarth@webkit.org>
2741
2742         garden-o-matic pixel zoomer should let you look at every pixel of the image
2743         https://bugs.webkit.org/show_bug.cgi?id=76962
2744
2745         Reviewed by Ojan Vafai.
2746
2747         Previously, you couldn't get up to the right and bottom pixels.
2748
2749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2750
2751 2012-01-24  Enrica Casucci  <enrica@apple.com>
2752
2753         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2754         https://bugs.webkit.org/show_bug.cgi?id=76951
2755         <rdar://problem/9325158>
2756
2757         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2758         works as expected.
2759         
2760         Reviewed by Alexey Proskuryakov.
2761
2762         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2763         (TestWebKitAPI::TEST):
2764
2765 2012-01-24  James Robinson  <jamesr@chromium.org>
2766
2767         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2768         https://bugs.webkit.org/show_bug.cgi?id=76884
2769
2770         Reviewed by Adam Barth.
2771
2772         * Scripts/webkitpy/tool/bot/irc_command.py:
2773         (Rollout.execute):
2774         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2775         (SheriffIRCBotTest.test_rollout):
2776         (SheriffIRCBotTest.test_revert):
2777         (SheriffIRCBotTest.test_multi_rollout):
2778         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2779         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2780         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2781         (test_multi_rollout_invalidate_reason):
2782
2783 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2784
2785         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2786         https://bugs.webkit.org/show_bug.cgi?id=75531
2787
2788         Reviewed by David Kilzer.
2789
2790         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2791         outside methods. Consider the following cpp file.
2792
2793             namespace N {
2794             int a;     // this change does not appear on ChangeLog.
2795             class C {
2796                 int b;     // this change does not appear on ChangeLog.
2797                 void f()
2798                 {
2799                     int c;     // this change appears on ChangeLog.
2800                 }
2801                 int d;     // this change does not appear on ChangeLog.
2802             };
2803             int e;     // this change does not appear on ChangeLog.
2804             };
2805
2806         The previous prepare-ChangeLog outputs just methods in which a change is found:
2807             (N::C::f):
2808
2809         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2810         and methods in which a change is found:
2811             (N):
2812             (N::C):
2813             (N::C::f):
2814
2815         * Scripts/prepare-ChangeLog:
2816         (get_function_line_ranges_for_cpp): Modified as described above.
2817
2818         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2819         (Class104):
2820         (Class105):
2821         (Class106):
2822         (Class106::func32):
2823         (Class106::func33):
2824         (NameSpace3):
2825         (NameSpace4):
2826         (NameSpace5):
2827         (NameSpace6):
2828         (Class107):
2829         (NameSpace5::NameSpace6::Class107::func34):
2830         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2831
2832 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2833
2834         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2835         https://bugs.webkit.org/show_bug.cgi?id=75943
2836
2837         Reviewed by David Kilzer.
2838
2839         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2840         because it does not distinguish '}' at the end of a subroutine
2841         with '}' at the end of a if or for statement.
2842
2843         foo.pl:
2844             if (1) {
2845             }
2846             for (@v) {
2847             }
2848
2849         output:
2850             nested functions found at top-level at foo.pl:2
2851             nested functions found at top-level at foo.pl:4
2852
2853         This patch fixes the bug.
2854
2855         * Scripts/prepare-ChangeLog:
2856         (get_function_line_ranges_for_perl):
2857         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2858         Added test cases. No change in the test results.
2859
2860 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2861
2862         r105674 broke check-webkit-style for chromium's test_expectations.
2863
2864         Unreviewed, build fix.
2865         
2866         We now need to pass in a platform name of 'chromium' if we want
2867         the chromium port; options.chromium is no longer recognized. I
2868         will follow this patch up with a separate patch that has a test,
2869         but this at least fixes the build.
2870
2871         * Scripts/webkitpy/style/checkers/test_expectations.py:
2872         (TestExpectationsChecker._determine_port_from_exepectations_path):
2873
2874 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2875
2876         check-webkit-style of the chromium test_expectations.txt file takes too long
2877         https://bugs.webkit.org/show_bug.cgi?id=76745
2878
2879         Reviewed by Dimitri Glazkov.
2880
2881         When in lint mode, have TestExpectations test all configurations instead
2882         of looping over each configuration. This also has the benefit of making
2883         the error output considerably more concise.
2884
2885         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2886
2887         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2888         (Manager.lint):
2889         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2890         (TestExpectations._report_errors):
2891         (TestExpectations._add_expectations):
2892         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2893         (test_parse_error_nonfatal):
2894         (test_error_on_different_platform):
2895         * Scripts/webkitpy/style/checkers/test_expectations.py:
2896         (TestExpectationsChecker.check_test_expectations):
2897         (TestExpectationsChecker.check):
2898         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2899         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2900         (TestExpectationsTestCase.assert_lines_lint):
2901
2902 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2903
2904         Another build fix attempt after r105543.
2905
2906         * Scripts/webkitpy/common/net/file_uploader.py:
2907         (FileUploader.upload_as_multipart_form_data):
2908
2909 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2910
2911         Build fix attempt after r105543.
2912
2913         * Scripts/webkitpy/common/net/file_uploader.py:
2914         (FileUploader.upload_as_multipart_form_data):
2915
2916 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2917
2918         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2919         https://bugs.webkit.org/show_bug.cgi?id=76411
2920
2921         Reviewed by Adam Barth.
2922
2923         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2924         into a series of patches, this change adds a trivial
2925         pointer lock implementation to the Chromium port's DumpRenderTree
2926         and exposes LayoutTestController hooks to force failure conditions.
2927
2928         * DumpRenderTree/chromium/LayoutTestController.cpp:
2929         (LayoutTestController::LayoutTestController):
2930         (LayoutTestController::didLosePointerLock):
2931         (LayoutTestController::setPointerLockWillFailAsynchronously):
2932         (LayoutTestController::setPointerLockWillFailSynchronously):
2933         * DumpRenderTree/chromium/LayoutTestController.h:
2934         * DumpRenderTree/chromium/WebViewHost.cpp:
2935         (WebViewHost::requestPointerLock):
2936         (WebViewHost::requestPointerUnlock):
2937         (WebViewHost::isPointerLocked):
2938         (WebViewHost::didCompletePointerLock):
2939         (WebViewHost::didNotCompletePointerLock):
2940         (WebViewHost::didLosePointerLock):
2941         (WebViewHost::reset):
2942         * DumpRenderTree/chromium/WebViewHost.h:
2943         (WebViewHost::setPointerLockWillFailAsynchronously):
2944         (WebViewHost::setPointerLockWillFailSynchronously):
2945
2946 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2947
2948         Unreviewed, skip WK2 API test timing out on some GTK bots.
2949
2950         WebKit2APITests/TestDownloads is consistently timing out on the
2951         32bit release and 64bit debug bots.
2952
2953         * Scripts/run-gtk-tests:
2954         (TestRunner): Skip WebKit2APITests/TestDownloads.
2955
2956 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2957
2958         [Qt] Fix the build with the newes Qt5 hashes
2959         https://bugs.webkit.org/show_bug.cgi?id=76657
2960
2961         Reviewed by Simon Hausmann.
2962
2963         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2964         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2965         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2966
2967 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2968
2969         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2970
2971         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2972         building with MinGW inside cmd.exe will require the same construct. Instead
2973         we assume that when the first character in PWD is a '/' we're running under
2974         Cygwin, and use the normal unix way of setting environment variables.
2975
2976         Reviewed by Simon Hausmann.
2977
2978         * qmake/mkspecs/features/default_pre.prf:
2979
2980 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2981
2982         Some qmake build files must include Qt5's "quick" module.
2983         https://bugs.webkit.org/show_bug.cgi?id=76671
2984
2985         Unreviewed build fix.
2986
2987         * MiniBrowser/qt/MiniBrowser.pro:
2988         * WebKitTestRunner/Target.pri:
2989
2990 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2991
2992         [Qt] Fix the event timestamps for touch mocking
2993
2994         Reviewed by Simon Hausmann.
2995
2996         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2997         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2998         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2999
3000 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3001
3002         [GTK] Implement DownloadClient in WebKit2 GTK+ API
3003         https://bugs.webkit.org/show_bug.cgi?id=72952
3004
3005         Reviewed by Martin Robinson.
3006
3007         * gtk/generate-gtkdoc:
3008         (get_webkit2_options): Ignore WebKitDownloadClient.
3009
3010 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
3011
3012         [GTK] editing/deleting/5408255.html results are incorrect
3013         https://bugs.webkit.org/show_bug.cgi?id=53644
3014
3015         Reviewed by Martin Robinson.
3016
3017         WEBKIT_TOP_LEVEL environment variable is now set directly in either
3018         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
3019         macro. This way both tools can be run outside the test harness without
3020         the need to manually set the environment variable.
3021
3022         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3023         (getTopLevelPath):
3024         * GNUmakefile.am:
3025         * Scripts/webkitpy/layout_tests/port/gtk.py:
3026         (GtkPort.setup_environ_for_server):
3027         * WebKitTestRunner/GNUmakefile.am:
3028         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3029         (WTR::InjectedBundle::platformInitialize):
3030
3031 2012-01-23  Dmitry Lomov  <dslomov@google.com>
3032
3033         [Chromium] Implement layoutTestController.workerThreadCount in DRT
3034         https://bugs.webkit.org/show_bug.cgi?id=74653.
3035
3036         Reviewed by Darin Fisher.
3037
3038         * DumpRenderTree/chromium/LayoutTestController.cpp:
3039         (LayoutTestController::LayoutTestController):
3040         (LayoutTestController::workerThreadCount):
3041         * DumpRenderTree/chromium/LayoutTestController.h:
3042
3043 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
3044
3045         nrwt: make --chromium work like --qt
3046         https://bugs.webkit.org/show_bug.cgi?id=76875
3047
3048         Reviewed by Adam Barth.
3049
3050         --chromium used to have to be handled differently from --qt
3051         due to the way the PortFactory was implemented; there's not
3052         really a good reason for that any more so this patch makes
3053         things slightly more consistent and eliminates the
3054         options.chromium flag (--chromium is now truly a synonym for
3055         --platform chromium).
3056
3057         * Scripts/webkitpy/layout_tests/port/factory.py:
3058         (PortFactory._default_port):
3059         (PortFactory.get):
3060         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3061         (FactoryTest.setUp):
3062         (FactoryTest.test_chromium_mac):
3063         (FactoryTest.test_chromium_linux):
3064         (FactoryTest.test_chromium_win):
3065         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3066         (parse_args):
3067
3068 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
3069
3070         run-webkit-tests needs to propagate --chromium
3071         https://bugs.webkit.org/show_bug.cgi?id=76870
3072
3073         Reviewed by Eric Seidel.
3074
3075         run-webkit-tests removes '--chromium' argument from @ARGV when
3076         determining which port to run, which means that that doesn't
3077         propagate to new-run-webkit-tests. That's bad (and is handled
3078         for the other ports by re-adding the flag, but apparently we're
3079         just now noticing for Chromium).
3080
3081         * Scripts/run-webkit-tests:
3082
3083 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
3084
3085         More build fixing after r105646.
3086
3087         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3088         (TestWebKitAPI::TestNode::key):
3089
3090 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
3091
3092         Unreviewed build fix - r105646 broke this.
3093
3094         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3095         (TestWebKitAPI::TestNode::TestNode):
3096         (TestWebKitAPI::TestNode::key):
3097         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
3098         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
3099         (TestWebKitAPI::RedBlackTreeTest::testDriver):
3100
3101 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3102
3103         Unreviewed, rolling out r105658.
3104         http://trac.webkit.org/changeset/105658
3105         https://bugs.webkit.org/show_bug.cgi?id=76883
3106
3107         We want this eventually, but not right at this moment
3108         (Requested by abarth on #webkit).
3109
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3111
3112 2012-01-23  Adam Barth  <abarth@webkit.org>
3113
3114         garden-o-matic should support Chromium Mac Lion
3115         https://bugs.webkit.org/show_bug.cgi?id=76880
3116
3117         Reviewed by Eric Seidel.
3118
3119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3120
3121 2012-01-23  Emil A Eklund  <eae@chromium.org>
3122
3123         check-webkit-style whitespace/operators triggers on overloaded division operator
3124         https://bugs.webkit.org/show_bug.cgi?id=76650
3125
3126         Reviewed by Darin Adler.
3127
3128         * Scripts/webkitpy/style/checkers/cpp.py:
3129         (check_spacing):
3130         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3131         (CppStyleTest.test_operator_methods):
3132
3133 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
3134
3135         run-perf-tests should report server-side errors
3136         https://bugs.webkit.org/show_bug.cgi?id=76802
3137
3138         Reviewed by Tony Chang.
3139
3140         Report errors whenever server's response doesn't match "OK".
3141
3142         * Scripts/webkitpy/common/net/file_uploader.py:
3143         (FileUploader.upload_single_text_file):
3144         (FileUploader.upload_as_multipart_form_data):
3145         (FileUploader._upload_data.callback):
3146         (FileUploader):
3147         (FileUploader._upload_data):
3148         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3149         (PerfTestsRunner._upload_json):
3150         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3151         (test_upload_json):
3152         (test_upload_json.MockFileUploader.upload_single_text_file):
3153
3154 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
3155
3156         run-perf-tests ignore Skipped list on chromium
3157         https://bugs.webkit.org/show_bug.cgi?id=76764
3158
3159         Reviewed by Dirk Pranke.
3160
3161         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
3162         can also find skipped list. Chromium port only uses test_expectations.txt for
3163         layout tests but performacne tests don't use test_expectations.txt so Chromium port
3164         also needs to use Skipped list.
3165
3166         * Scripts/webkitpy/layout_tests/port/base.py:
3167         (Port._tests_from_skipped_file_contents):
3168         (Port):
3169         (Port._expectations_from_skipped_files):
3170         (Port.skipped_perf_tests):
3171         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3172         (PortTest.test_skipped_perf_tests):
3173         (PortTest.test_skipped_perf_tests.add_text_file):
3174         * Scripts/webkitpy/layout_tests/port/webkit.py:
3175         (WebKitPort._skipped_tests_for_unsupported_features):
3176         (WebKitPort._skipped_file_search_paths):
3177         (WebKitPort.skipped_layout_tests):
3178
3179 2012-01-23  Andy Estes  <aestes@apple.com>
3180
3181         Fix the build after r105635.
3182
3183         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3184         (TestWebKitAPI::TEST):
3185
3186 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
3187
3188         Basic enhancements to StringBuilder
3189         https://bugs.webkit.org/show_bug.cgi?id=67081
3190
3191         Reviewed by Darin Adler.
3192
3193         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3194         (TestWebKitAPI::TEST):
3195
3196 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
3197
3198         [GTK] run-gtk-tests randomly fails while running the xprop comand
3199         https://bugs.webkit.org/show_bug.cgi?id=76817
3200
3201         Reviewed by Gustavo Noronha Silva.
3202
3203         No need to use xprop to remove the AT_SPI_BUS property since
3204         run-gtk-tests will always run new instances of Xvfb.
3205
3206         * Scripts/run-gtk-tests:
3207         (TestRunner): Unskip TestWebKitAccessibility.
3208         (TestRunner.run): Uncomment lines for launching the accessibility
3209         bus and registry daemon, and remove lines for running xprop.
3210
3211 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3212
3213         [Qt] Don't warn about override and final being C++11 extensions
3214
3215         Clang will emit a warning when these extensions are used without passing
3216         --std=c++11, but we use feature checking to decide if we have the right
3217         extensions, so we can safely ignore these warnings. The XCode and Windows
3218         project files have the same workaround.
3219
3220         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
3221         we only have one extra compiler for Objective-C, which is also used for
3222         Objective-C++ sources, so we have to pass the flag, even if it doesn't
3223         make sense for Objective-C.
3224
3225         Reviewed by Simon Hausmann.
3226
3227         * qmake/mkspecs/features/unix/default_post.prf:
3228
3229 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3230
3231         [Qt] Change how build-webkit decides when to do full incremental builds
3232
3233         Instead of relying on update-webkit (which isn't run on the bots) to
3234         decide when to do a full incremental build (make qmake), we let the
3235         build-webkit script itself check the current SVN revision against the
3236         previous build (by storing it in .webkit.config).
3237
3238         If the two differ we assume a full incremental build is needed, since
3239         the new revisions might have introduced problematic things like new
3240         Q_OBJECT macros. If not, we assume the developer is doing changes
3241         locally, and revert to doing a plain 'make'.
3242
3243         In addition, when the build fails in the latter case, we inform the
3244         developer of possible pitfalls and how to manually run 'make qmake'.
3245
3246         Reviewed by Ossy.
3247
3248         * Scripts/update-webkit:
3249         * Scripts/webkitdirs.pm:
3250         (buildQMakeProjects):
3251
3252 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
3253
3254         [GTK] run-gtk-tests randomly fails while running the xprop comand
3255         https://bugs.webkit.org/show_bug.cgi?id=76817
3256
3257         Reviewed by Philippe Normand.
3258
3259         Temporarily comment the lines related to launching the ATSPI bus
3260         and registry daemon, which are making the bots to fail randomly.
3261
3262         * Scripts/run-gtk-tests:
3263         (TestRunner): Skip TestWebKitAccessibility, as it won't run
3264         properly if the ATSPI infrastructure is not properly initialized.
3265         (TestRunner.run): Comment lines related to initialization of ATSPI.
3266
3267 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
3268
3269         Windows python test build fix.
3270
3271         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3272         (PerfTestsRunner.__init__):
3273
3274 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
3275
3276         [GTK] DumpRenderTree converts "file:///" to a path differently
3277         https://bugs.webkit.org/show_bug.cgi?id=76631
3278
3279         Reviewed by Martin Robinson.
3280
3281         DumpRenderTree should print "/" as the last path component if the
3282         path is a lone slash instead of empty output.
3283
3284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3285         (webViewConsoleMessage):
3286
3287 2012-01-20  David Levin  <levin@chromium.org>
3288
3289         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
3290         https://bugs.webkit.org/show_bug.cgi?id=76752
3291
3292         Reviewed by Eric Seidel.
3293
3294         * Scripts/webkitpy/style/checkers/cpp.py:
3295         (check_for_leaky_patterns):
3296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3297         (LeakyPatternTest.test_create_dc):
3298         (LeakyPatternTest.test_create_compatible_dc):
3299
3300 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
3301
3302         Changed my status in commiters.py
3303
3304         Unreviewed.
3305
3306         * Scripts/webkitpy/common/config/committers.py:
3307
3308 2012-01-20  Ojan Vafai  <ojan@chromium.org>
3309
3310         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
3311         https://bugs.webkit.org/show_bug.cgi?id=76748
3312
3313         Reviewed by Ryosuke Niwa.
3314
3315         It crawls the whole subtree and then doesn't use the data. Cutting this out
3316         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
3317
3318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3319         (run):
3320
3321 2012-01-20  Adam Barth  <abarth@webkit.org>
3322
3323         Another tiny tweak to the garden-o-matic CSS.  This makes things line
3324         up slightly nicer when there aren't any failures.
3325
3326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3327         (#summary):
3328
3329 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3330
3331         run-perf-tests should support --test-results-server option
3332         https://bugs.webkit.org/show_bug.cgi?id=76680
3333
3334         Reviewed by Adam Barth.
3335
3336         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
3337         to be used by perf bots. Also refactor file_uploader as needed.
3338
3339         * Scripts/webkitpy/common/net/file_uploader.py:
3340         (FileUploader.__init__):
3341         (FileUploader.upload_single_file):
3342         (FileUploader.upload_as_multipart_form_data):
3343         (FileUploader):
3344         (FileUploader._upload_data):
3345         (FileUploader._upload_data.callback):
3346         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3347         (JSONResultsGeneratorBase.upload_json_files):
3348         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3349         (PerfTestsRunner):
3350         (PerfTestsRunner._parse_args):
3351         (PerfTestsRunner.run):
3352         (PerfTestsRunner._generate_json):
3353         (PerfTestsRunner._upload_json):
3354         (PerfTestsRunner._run_tests_set):
3355         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3356         (create_runner):
3357         (test_run_with_upload_json):
3358         (test_run_with_upload_json.mock_upload_json):
3359         (test_upload_json):
3360         (test_upload_json.MockFileUploader):
3361         (test_upload_json.MockFileUploader.__init__):
3362         (test_upload_json.MockFileUploader.upload_single_file):
3363         (test_parse_args):
3364
3365 2012-01-20  Adam Barth  <abarth@webkit.org>
3366
3367         The party time image overlaps real content!  This patch makes the
3368         image centered vertically.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3371         (#onebar.partytime #summary):
3372
3373 2012-01-19  Ojan Vafai  <ojan@chromium.org>
3374
3375         Refactor TestExpectationsParser in preparation for caching the results
3376         https://bugs.webkit.org/show_bug.cgi?id=76669
3377
3378         Reviewed by Dimitri Glazkov.
3379
3380         Make everything private expect for the parse method. 
3381         Eventually, we'll need the expectations lines to not be modified
3382         outside of TestExpectationsParser so we can cache the results.
3383         This makes check-webkit-style of the chromium test_expectations.txt file
3384         go from ~17 seconds to ~12 seconds on my Mac Pro.
3385
3386         This patch is just a refactor in preparation, so no new tests.
3387
3388         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3389         (TestExpectationEditorTests.make_parsed_expectation_lines):
3390         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3391         (TestExpectationParser.parse):
3392         (TestExpectationParser):
3393         (TestExpectationParser._parse_line):
3394         (TestExpectationParser._tokenize):
3395         (TestExpectationParser._tokenize_list):
3396         (TestExpectationsModel._clear_expectations_for_test):
3397         (TestExpectations.__init__):
3398         (TestExpectations._add_expectations):
3399         (TestExpectations._add_skipped_tests):
3400         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3401         (TestExpectationParserTests.test_tokenize_blank):
3402         (TestExpectationParserTests.test_tokenize_missing_colon):
3403         (TestExpectationParserTests.test_tokenize_extra_colon):
3404         (TestExpectationParserTests.test_tokenize_empty_comment):
3405         (TestExpectationParserTests.test_tokenize_comment):
3406         (TestExpectationParserTests.test_tokenize_missing_equal):
3407         (TestExpectationParserTests.test_tokenize_extra_equal):
3408         (TestExpectationParserTests.test_tokenize_valid):
3409         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3410         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3411         (TestExpectationParserTests.test_parse_empty_string):
3412         (TestExpectationSerializerTests.assert_round_trip):
3413         (TestExpectationSerializerTests.assert_list_round_trip):
3414         * Scripts/webkitpy/tool/commands/expectations.py:
3415         (OptimizeExpectations.execute):
3416         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3417         (GardeningExpectationsUpdater.update_expectations):
3418
3419 2012-01-20  Adam Barth  <abarth@webkit.org>
3420
3421         Follow-up to previous patch: don't produce NaN when the revision number
3422         is missing.
3423
3424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3426
3427 2012-01-20  Adam Barth  <abarth@webkit.org>
3428
3429         Garden-o-matic should tell me which revisions have been checked by all the bots
3430         https://bugs.webkit.org/show_bug.cgi?id=76722
3431
3432         Reviewed by Dimitri Glazkov.
3433
3434         This information helps me know when it's safe for me to roll a
3435         candidate revision.
3436
3437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3440
3441 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3442
3443         build-webkit: Don't spit out congratulations message on Ctrl+C
3444
3445         Reviewed by Andreas Kling.
3446
3447         * Scripts/build-webkit:
3448
3449 2012-01-20  Philippe Normand  <pnormand@igalia.com>
3450
3451         [GTK] Allow extra jhbuild modulesets
3452         https://bugs.webkit.org/show_bug.cgi?id=76691
3453
3454         Reviewed by Gustavo Noronha Silva.
3455
3456         * gtk/jhbuildrc: Extra modulesets and modules can be added in
3457         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
3458         env variables respectively. Use comma-separated values. Example:
3459         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
3460
3461 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
3462
3463         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
3464         https://bugs.webkit.org/show_bug.cgi?id=72589
3465
3466         Reviewed by Martin Robinson.
3467
3468         Ensure the accessibility infrastructure is available when running
3469         the unit tests, otherwise WK2's accessibility tests won't work.
3470
3471         * Scripts/run-gtk-tests:
3472         (TestRunner):
3473         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
3474         where at-spi2's stuff is located (like at-spi-bus-launcher and
3475         at-spi2-registryd).
3476         (TestRunner.run): Initialize the accessibility infrastructure.
3477
3478         * gtk/generate-gtkdoc:
3479         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
3480
3481         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
3482
3483 2012-01-20  Hayato Ito  <hayato@chromium.org>
3484
3485         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
3486         https://bugs.webkit.org/show_bug.cgi?id=76353
3487
3488         Reviewed by Hajime Morita.
3489
3490         Add ShadowRoot.idl, which is enabled only on chromium port since this is
3491         under development feature.
3492         ShadowRoot.idl contains minimum API so that we can test it.
3493         Other APIs should be added on other changes so that we can isolate issues.
3494
3495         * DumpRenderTree/chromium/TestShell.cpp:
3496         (TestShell::TestShell):
3497
3498 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
3499
3500         [GTK] GTK's DRT not to log events for already defunct objects
3501         https://bugs.webkit.org/show_bug.cgi?id=76620
3502
3503         Reviewed by Martin Robinson.
3504
3505         Do not log 'state-change:defunct' events.
3506
3507         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3508         (printAccessibilityEvent): Early return if a
3509         'state-change:defunct' signal is passed.
3510         (axObjectEventListener): Pass the signal name and value in
3511         separate parameters to printAccessibilityEvent.
3512
3513 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3514
3515         Unreviewed build fix. Wrong variable being used as the cwd for git
3516         remote update command.
3517
3518         * gtk/run-with-jhbuild:
3519         (update_jhbuild):
3520
3521 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3522
3523         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
3524         https://bugs.webkit.org/show_bug.cgi?id=76585
3525
3526         Reviewed by Martin Robinson.
3527
3528         This allows us to specify a minimum version of jhbuild required,
3529         while also providing stability against changes done to the master
3530         branch, by letting us choose what is the exact version that will
3531         be used.
3532
3533         * gtk/run-with-jhbuild: refactored for more hackability and easier
3534         reading
3535         (jhbuild_installed): checks whether jhbuild is installed
3536         (jhbuild_cloned): checks whether jhbuild has been cloned
3537         (jhbuild_at_expected_revision): checks whether jhbuild is at the
3538         expected revision
3539         (update_jhbuild): brings jhbuild to the expected revision
3540         (clone_jhbuild): clones jhbuild
3541         (install_jhbuild): build and installs jhbuild
3542         (update_webkitgtk_libs): runs update-webkitgtk-libs
3543         (ensure_jhbuild): high-level logic to decide whether and which of
3544         the steps above are executed
3545
3546 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3547
3548         [WK2] DumpRenderTree converts "file:///" to a path differently
3549         https://bugs.webkit.org/show_bug.cgi?id=76653
3550
3551         Reviewed by John Sullivan.
3552
3553         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
3554         Do print a slash if there are no path components.
3555
3556 2012-01-19  Eric Seidel  <eric@webkit.org>
3557
3558         webkit-patch cannot rollout patches without changelog/bug number
3559         https://bugs.webkit.org/show_bug.cgi?id=75962
3560
3561         Reviewed by Adam Barth.
3562
3563         * Scripts/webkitpy/tool/commands/download.py:
3564         (AbstractRolloutPrepCommand._prepare_state):
3565         * Scripts/webkitpy/tool/commands/download_unittest.py:
3566         (AbstractRolloutPrepCommandTest.test_prepare_state):
3567
3568 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3569
3570         [WK2] fast/url/degenerate-file-base.html fails
3571         https://bugs.webkit.org/show_bug.cgi?id=76619
3572
3573         Reviewed by Adam Roben.
3574
3575         A URL generated form local path for loading had an extra slash, making document.URL
3576         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
3577
3578         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
3579
3580 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3581
3582         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
3583         https://bugs.webkit.org/show_bug.cgi?id=76510
3584
3585         Reviewed by Adam Barth.
3586
3587         Unlike other style rules, if you get the syntax of the test_expectations.txt
3588         file wrong, the layout tests won't run. Also, this check is simple and only
3589         slows down committing if you actually modify one of the test_expectations.txt files.
3590
3591         * Scripts/webkitpy/style/checkers/test_expectations.py:
3592         (TestExpectationsChecker.check_test_expectations):
3593         (TestExpectationsChecker.check):
3594         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3595         (TestExpectationsTestCase.test_check_covers_all_configurations):
3596         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3597         (TestExpectationsTestCase):
3598         (assert_lines_lint):
3599
3600 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3601
3602         Build fix. Revert an unintentional change to WebKitDriver in r105443.
3603
3604         * Scripts/webkitpy/layout_tests/port/driver.py:
3605         (DriverProxy.__init__):
3606
3607 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
3608
3609         remove the duplicated build rules from WebKit.gyp, Tools.gyp
3610         https://bugs.webkit.org/show_bug.cgi?id=73384
3611
3612         Reviewed by Tony Chang.
3613
3614         This patch removes the no-longer-necessary conditional logic for
3615         build_webkit_exes_from_webkit_gyp; we now always build the exes
3616         from their own dedicated gyp files.
3617
3618         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3619
3620 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3621
3622         make-new-script-test should work with HTTP tests
3623         https://bugs.webkit.org/show_bug.cgi?id=76603
3624
3625         Reviewed by Adam Roben.
3626
3627         * Scripts/make-new-script-test:
3628         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3629         now also creates absolute paths for HTTP.
3630
3631 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3632
3633         Some perf tests time out when ran by run-perf-tests
3634         https://bugs.webkit.org/show_bug.cgi?id=76612
3635
3636         Reviewed by Dirk Pranke and Eric Seidel.
3637
3638         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3639         Otherwise some tests such as Parser/xml-parser.html will timeout.
3640
3641         --no-timeout option is currently supported by Chromium and Mac ports.
3642
3643         * Scripts/webkitpy/layout_tests/port/base.py:
3644         (Port.to.create_driver):
3645         * Scripts/webkitpy/layout_tests/port/chromium.py:
3646         (ChromiumDriver.__init__):
3647         (ChromiumDriver._wrapper_options):
3648         * Scripts/webkitpy/layout_tests/port/driver.py:
3649         (Driver.__init__):
3650         (DriverProxy.__init__):
3651         * Scripts/webkitpy/layout_tests/port/webkit.py:
3652         (WebKitDriver.__init__):
3653         (WebKitDriver.cmd_line):
3654         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3655         (WebKitDriverTest.test_read_binary_block):
3656         (WebKitDriverTest):
3657         (WebKitDriverTest.test_no_timeout):
3658         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3659         (get_tests_run.RecordingTestDriver.__init__):
3660         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3661         (PerfTestsRunner._parse_args):
3662         (PerfTestsRunner._run_tests_set):
3663         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3664         (create_runner):
3665
3666 2012-01-19  Ben Wells  <benwells@chromium.org>
3667
3668         Add support for window.print to chromium DRT
3669         https://bugs.webkit.org/show_bug.cgi?id=76479
3670
3671         When used in a test window.print goes into print mode and then
3672         straight out again. This will allow the afterprint event to be
3673         tested by having the afterprint event happen before the dump
3674         happens.
3675
3676         Reviewed by Mihai Parparita.
3677
3678         * DumpRenderTree/chromium/WebViewHost.cpp:
3679         (WebViewHost::printPage):
3680         * DumpRenderTree/chromium/WebViewHost.h:
3681
3682 2012-01-18  Enrica Casucci  <enrica@apple.com>
3683
3684         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
3685         https://bugs.webkit.org/show_bug.cgi?id=76588
3686         <rdar://problem/9325183>
3687
3688         Added test.
3689         
3690         Reviewed by Dan Bernstein.
3691
3692         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3693         (TestWebKitAPI::TEST):
3694
3695 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3696
3697         [Qt] Do full incremental builds until bots use update-webkit
3698
3699         Rubber-stamped by Simon Hausmann.
3700
3701         * Scripts/webkitdirs.pm:
3702         (buildQMakeProjects):
3703
3704 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3705
3706         Fix the Qt build
3707
3708         Unreviewed build fix.
3709
3710         * Scripts/webkitdirs.pm:
3711         (buildQMakeProjects):
3712
3713 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3714
3715         [Qt] Make build-webkit always do safe incremental builds after update-webkit
3716
3717         When building against Qt5 with GCC we would just run 'make' in the build dir,
3718         and rely on the dependency files output by GCC (-MD) to handle dependency
3719         tracking, but that fails for special-cases like adding a Q_OBJECT macro
3720         to a header.
3721
3722         To guarantee that an incrmental build will work, we have to run 'make qmake',
3723         which we now do on every build-webkit that's followed by a successful run
3724         of update-webkit. The reasoning is that update-webkit can result in such
3725         potential corner-cases being applied, and since we can't know for sure
3726         unless we inspect the diff and account for all the corner cases we assume
3727         the worst and always run 'make qmake'.
3728
3729         After a succesful run of build-webkit we proceed to do just 'make' for any
3730         subsequent runs, since we assume that the developer knows what kind of
3731         changes he/she is doing, and when a 'make qmake' is needed.
3732
3733         Reviewed by Simon Hausmann.
3734
3735         * Scripts/update-webkit:
3736         * Scripts/webkitdirs.pm:
3737         (determineCurrentSVNRevision):
3738         (currentSVNRevision):
3739         (buildQMakeProjects):
3740         * qmake/mkspecs/features/default_post.prf:
3741
3742 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3743
3744         run-perf-tests should support Skipped list
3745         https://bugs.webkit.org/show_bug.cgi?id=76594
3746
3747         Reviewed by Adam Barth.
3748
3749         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
3750
3751         * Scripts/webkitpy/layout_tests/port/base.py:
3752         (Port.perf_tests_dir):
3753         (Port.skipped_perf_tests):
3754         (Port.skips_perf_test):
3755         (Port.relative_perf_test_filename):
3756         * Scripts/webkitpy/layout_tests/port/test.py:
3757         (TestPort.perf_tests_dir):
3758         * Scripts/webkitpy/layout_tests/port/webkit.py:
3759         (WebKitPort._expectations_from_skipped_files):
3760         (WebKitPort):
3761         (WebKitPort.skipped_layout_tests):
3762         (WebKitPort.skipped_perf_tests):
3763         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3764         (PerfTestsRunner._collect_tests):
3765         (PerfTestsRunner.run):
3766         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3767         (test_run_test_set_with_json_output):
3768         (test_run_test_set_with_json_source):
3769         (test_collect_tests_with_skipped_list):
3770         (test_collect_tests_with_skipped_list.add_file):
3771
3772 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3773
3774         Fix path to chromium_src_dir introduced in previous change.
3775
3776         Unreviewed, build fix.
3777
3778         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3779
3780 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3781
3782         Need infrastructure to test Content-Disposition filename encoding support
3783         https://bugs.webkit.org/show_bug.cgi?id=76572
3784         <rdar://problem/6421825>
3785
3786         Reviewed by Sam Weinig.
3787
3788         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3789
3790         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3791
3792         * DumpRenderTree/mac/PolicyDelegate.mm:
3793         (dispositionTypeFromContentDispositionHeader):
3794         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3795
3796 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3797
3798         Fix tests from http://trac.webkit.org/changeset/105332.
3799
3800         The code assumed that if you passed an options object with a configuration
3801         attribute that it would have a valid value. A bunch of the testing mocks
3802         do things like having a configuration value of None.
3803
3804         * Scripts/webkitpy/layout_tests/port/base.py:
3805         (Port.__init__):
3806
3807 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3808
3809         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3810         https://bugs.webkit.org/show_bug.cgi?id=76576
3811
3812         Reviewed by Adam Barth.
3813
3814         Avoid calling default_configuration in base.py. We don't need it for
3815         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3816         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3817         from common.executive.
3818
3819         At some point someone should probably look into why that call is so slow
3820         since it's on the critical path for run-webkit-tests and build-webkit startup.
3821
3822         * Scripts/webkitpy/layout_tests/port/base.py:
3823         (Port.__init__):
3824         * Scripts/webkitpy/style/checkers/test_expectations.py:
3825         (TestExpectationsChecker._determine_port_from_exepectations_path):
3826
3827 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3828
3829         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3830         https://bugs.webkit.org/show_bug.cgi?id=76505
3831
3832         Reviewed by Tony Chang.
3833
3834         Update chromium build script to use All.gyp instead of WebKit.gyp
3835
3836         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3837         * Scripts/webkitdirs.pm:
3838
3839 2012-01-18  Sam Weinig  <sam@webkit.org>
3840
3841         Don’t hardcode the path to ‘make‘.
3842
3843         Reviewed by Dan Bernstein.
3844
3845         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3846
3847 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3848
3849         Adding myself to committers.py
3850         https://bugs.webkit.org/show_bug.cgi?id=76569
3851
3852         Unreviewed.
3853
3854         * Scripts/webkitpy/common/config/committers.py:
3855
3856 2012-01-18  Adam Barth  <abarth@webkit.org>
3857
3858         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3859         https://bugs.webkit.org/show_bug.cgi?id=76567
3860
3861         Reviewed by Eric Seidel.
3862
3863         Current the AppleMac port has slightly more failures than we allow on
3864         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3865         which should hopefully let the mac-ews run to completion.  Once
3866         AppleMac has fewer failures, we can lower the cap again.
3867
3868         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3869         (LayoutTestResultsReaderTest.test_layout_test_results):
3870         * Scripts/webkitpy/tool/steps/runtests.py:
3871         (RunTests):
3872         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3873
3874 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3875
3876         Provide access to user's list of preferred languages
3877         https://bugs.webkit.org/show_bug.cgi?id=76138
3878
3879         Reviewed by Alexey Proskuryakov.
3880
3881         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3882
3883 2012-01-18  Adam Barth  <abarth@webkit.org>
3884
3885         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3886         configurations.
3887
3888         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3889         (ChromiumLinuxPort.__init__):
3890
3891 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3892
3893         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3894         https://bugs.webkit.org/show_bug.cgi?id=73460
3895
3896         Reviewed by Chris Fleizach.
3897
3898         * DumpRenderTree/AccessibilityUIElement.h:
3899         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3900         (AccessibilityUIElement::AccessibilityUIElement):
3901         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3902         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3903         (AccessibilityUIElement::scrollToGlobalPointCallback):
3904         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3905         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3906         (AccessibilityUIElement::scrollToMakeVisible):
3907         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3908         (AccessibilityUIElement::scrollToGlobalPoint):
3909         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3910         (AccessibilityUIElement::scrollToMakeVisible):
3911         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3912         (AccessibilityUIElement::scrollToGlobalPoint):
3913         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3914         (AccessibilityUIElement::scrollToMakeVisible):
3915         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3916         (AccessibilityUIElement::scrollToGlobalPoint):
3917
3918 2012-01-17  Enrica Casucci  <enrica@apple.com>
3919
3920         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3921         https://bugs.webkit.org/show_bug.cgi?id=76490
3922         <rdar://problem/9460733>
3923
3924         Added TestWebKitAPI test.
3925         
3926         Reviewed by Dan Bernstein.
3927
3928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3929         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3930         changeAttributes to the WebView.
3931         
3932 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3933
3934         [Qt] Consolidate layout test crash logging
3935         https://bugs.webkit.org/show_bug.cgi?id=75088
3936
3937         Reviewed by Simon Hausmann.
3938
3939         Move backtrace generating logic into WTFReportBacktrace
3940         and add a way to deinstall signal handlers if we know
3941         that we have already printed the backtrace.
3942
3943         * DumpRenderTree/qt/main.cpp:
3944         (crashHandler):
3945         (setupSignalHandlers):
3946         (WTFCrashHook):
3947         (main):
3948         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3949         (WTR::crashHandler):
3950         (WTR::setupSignalHandlers):
3951         (WTR::crashHook):
3952         (WTR::InjectedBundle::platformInitialize):
3953
3954 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3955
3956         Unreviewed build fix after r105256.
3957
3958         There was a cyclic dependency between self._port and self._host assigments.
3959
3960         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3961         (PerfTestsRunner.__init__):
3962
3963 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3964
3965         Add new watchlist rule for the Qt build system
3966
3967         Reviewed by Simon Hausmann.
3968
3969         * Scripts/webkitpy/common/config/watchlist:
3970
3971 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3972
3973         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3974
3975         Reviewed by Simon Hausmann.
3976
3977         * Tools.pro:
3978
3979 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3980
3981         [Qt] Allow building only a subset of the WebKit sub-projects
3982
3983         Fixes build-jsc, broken in r104825.
3984
3985         We no longer need the intermediate buildQMakeQtProject(), as we're the
3986         only port using qmake, and buildQMakeProject is now highly Qt specific.
3987
3988         <http://webkit.org/b/76179>
3989
3990         Reviewed by Simon Hausmann.
3991
3992         * Scripts/build-jsc:
3993         * Scripts/build-webkit:
3994         * Scripts/webkitdirs.pm:
3995         (buildQMakeProjects):
3996
3997 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3998
3999         run-perf-tests should generate a json file that summaries the result
4000         https://bugs.webkit.org/show_bug.cgi?id=76504
4001
4002         Reviewed by Adam Barth.
4003
4004         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
4005         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
4006         another json file to be merged into the generated json file.
4007
4008         Also fixed a bug that --build wasn't set by default.
4009
4010         * Scripts/webkitpy/layout_tests/port/test.py:
4011         (TestPort.webkit_base):
4012         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4013         (PerfTestsRunner.__init__):
4014         (PerfTestsRunner):
4015         (PerfTestsRunner._parse_args):
4016         (PerfTestsRunner.run):
4017         (PerfTestsRunner._generate_json_if_specified):
4018         (PerfTestsRunner._process_chromium_style_test_result):
4019         (PerfTestsRunner._process_parser_test_result):
4020         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4021         (MainTest):
4022         (create_runner):
4023         (test_run_test_set):
4024         (test_run_test_set_for_parser_tests):
4025         (test_run_test_set_with_summary_json):
4026         (test_collect_tests):
4027         (test_parse_args):
4028
4029 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
4030
4031         Unreviewed, rolling out r105244.
4032         http://trac.webkit.org/changeset/105244
4033         https://bugs.webkit.org/show_bug.cgi?id=76518
4034
4035         broke Chromium Mac (Requested by rolandsteiner on #webkit).
4036
4037         * DumpRenderTree/AccessibilityUIElement.h:
4038         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4039         (AccessibilityUIElement::AccessibilityUIElement):
4040         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4041         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4042         (AccessibilityUIElement::removeSelection):
4043         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4044         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4045         (AccessibilityUIElement::removeSelection):
4046
4047 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
4048
4049         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
4050         https://bugs.webkit.org/show_bug.cgi?id=73460
4051
4052         Reviewed by Chris Fleizach.
4053
4054         * DumpRenderTree/AccessibilityUIElement.h:
4055         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4056         (AccessibilityUIElement::AccessibilityUIElement):
4057         (AccessibilityUIElement::scrollToMakeVisibleCallback):
4058         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
4059         (AccessibilityUIElement::scrollToGlobalPointCallback):
4060         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4061         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4062         (AccessibilityUIElement::scrollToMakeVisible):
4063         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
4064         (AccessibilityUIElement::scrollToGlobalPoint):
4065         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4066         (AccessibilityUIElement::scrollToMakeVisible):
4067         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
4068         (AccessibilityUIElement::scrollToGlobalPoint):
4069         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4070         (AccessibilityUIElement::scrollToMakeVisible):
4071         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
4072         (AccessibilityUIElement::scrollToGlobalPoint):
4073
4074 2012-01-17  Adam Barth  <abarth@webkit.org>
4075
4076         Enable tests on the mac-ews
4077         https://bugs.webkit.org/show_bug.cgi?id=76502
4078
4079         Reviewed by Simon Fraser.
4080
4081         Apple now has five machines running the mac-ews.  Lucas Forschler has
4082         asked that we try enabling tests to see if we have enough bandwidth.
4083
4084         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4085         (MacEWS):
4086
4087 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
4088
4089         Add a check-webkit-style exception for GDBInterface.cpp
4090         https://bugs.webkit.org/show_bug.cgi?id=76187
4091
4092         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
4093         that it does not fail the style check.
4094
4095         Reviewed by Martin Robinson.
4096
4097         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
4098         readability/naming tests on
4099         Source/JavaScriptCore/jit/GDBInterface.cpp.
4100         * Scripts/webkitpy/style/checker_unittest.py:
4101         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
4102         the above exception.
4103
4104 2012-01-17  Hajime Morrita  <morrita@chromium.org>
4105
4106         https://bugs.webkit.org/show_bug.cgi?id=76245
4107         [Mac][DRT] should allow query string for the file URL.
4108
4109         Reviewed by Tony Chang.
4110
4111         Taught DRT about file:// as a url instead of a file path.
4112         We are now able to use a path file:///foo/bar.html?baz as a url
4113         with which DRT opens "/foo/bar.html" with "baz" as a query string.
4114
4115         * DumpRenderTree/mac/DumpRenderTree.mm:
4116         (runTest):
4117
4118 2012-01-17  Ojan Vafai  <ojan@chromium.org>
4119
4120         Check style on test_expectations.txt files before commit
4121         https://bugs.webkit.org/show_bug.cgi?id=76484
4122
4123         Reviewed by Adam Barth.
4124
4125         Unlike other style rules, if you get the syntax of the test_expectations.txt
4126         file wrong, the layout tests won't run. Also, this check is simple and only
4127         slows down committing if you actually modify one of the test_expectations.txt files.
4128
4129         * Scripts/webkitpy/tool/steps/commit.py:
4130         (Commit._check_test_expectations):
4131         (Commit.run):
4132         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
4133         (CommitTest):
4134         (CommitTest.test_check_test_expectations):
4135
4136 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
4137
4138         [Qt] Debug build fails with debug qt5
4139         https://bugs.webkit.org/show_bug.cgi?id=76463
4140
4141         Reviewed by Simon Hausmann.
4142
4143         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
4144
4145         * QtTestBrowser/cookiejar.h:
4146
4147 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
4148
4149         webkitpy: fix json import on linux
4150         https://bugs.webkit.org/show_bug.cgi?id=76481
4151
4152         Reviewed by Adam Barth.
4153
4154         For some reason, the version of simplejson autoinstalled on my linux
4155         box seems to be broken. We should really only be using
4156         simplejson if json isn't available anyway, so this change looks
4157         for json first.
4158
4159         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4160         (JSONGeneratorTest.test_test_timings_trie):
4161
4162 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
4163
4164         Fix failures in test-webkitpy caused by r105177.
4165
4166         Unreviewed, build fix.
4167
4168         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4169         (ChromiumLinuxPort._determine_driver_path_statically):
4170         (ChromiumLinuxPort._static_build_path):
4171
4172 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
4173
4174         webkitpy: make PortFactory.get() be fully data-driven
4175         https://bugs.webkit.org/show_bug.cgi?id=76360
4176
4177         Reviewed by Eric Seidel.
4178
4179         Refactor PortFactory.get() to be fully data-driven.
4180
4181         * Scripts/webkitpy/layout_tests/port/factory.py:
4182         (PortFactory):
4183         (PortFactory._default_port):
4184         (PortFactory.get):
4185         (PortFactory.get.in):
4186         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4187         (FactoryTest.assert_port):
4188
4189 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
4190
4191         webkitpy: add determine_full_port_name(), clean up port.__init__()
4192         https://bugs.webkit.org/show_bug.cgi?id=76357
4193
4194         Reviewed by Adam Barth.
4195
4196         Each Port class is now required to implement a 'port_name' field
4197         that will match the start of all ports constructed by this class and
4198         a 'determine_full_port_name' field that will make the port
4199         fully-qualified.
4200
4201         * Scripts/webkitpy/layout_tests/port/apple.py:
4202         (ApplePort.__init__):
4203         * Scripts/webkitpy/layout_tests/port/base.py:
4204         (Port):
4205         (Port.determine_port_name):
4206         (Port.__init__):
4207         * Scripts/webkitpy/layout_tests/port/chromium.py:
4208         (ChromiumPort.for):
4209         (ChromiumPort.__init__):
4210         (ChromiumPort):
4211         (ChromiumPort._chromium_base_dir):
4212         (ChromiumPort.path_from_chromium_base):
4213         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4214         (ChromiumGpuLinuxPort):
4215         (ChromiumGpuLinuxPort.__init__):
4216         (ChromiumGpuMacPort):
4217         (ChromiumGpuMacPort.__init__):
4218         (ChromiumGpuWinPort):
4219         (ChromiumGpuWinPort.__init__):
4220         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4221         (ChromiumLinuxPort):
4222         (ChromiumLinuxPort.determine_port_name):
4223         (ChromiumLinuxPort.__init__):
4224         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4225         (ChromiumMacPort):
4226         (ChromiumMacPort.determine_port_name):
4227         (ChromiumMacPort.__init__):
4228         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4229         (ChromiumWinPort):
4230         (ChromiumWinPort.determine_port_name):
4231         (ChromiumWinPort.__init__):
4232         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4233         (DryRunPort):
4234         (DryRunPort.determine_port_name):
4235         (DryRunPort.__init__):
4236         * Scripts/webkitpy/layout_tests/port/efl.py:
4237         (EflPort):
4238         * Scripts/webkitpy/layout_tests/port/factory.py:
4239         (PortFactory):
4240         (PortFactory._default_port):
4241         (PortFactory.get):
4242         (PortFactory.get.in):
4243         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4244         (FactoryTest.assert_port):
4245         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
4246         (GoogleChromeLinux32Port):
4247         (GoogleChromeLinux32Port.determine_port_name):
4248         (GoogleChromeLinux64Port):
4249         (GoogleChromeLinux64Port.determine_port_name):
4250         (GoogleChromeMacPort):
4251         (GoogleChromeMacPort.determine_port_name):
4252         (GoogleChromeWinPort):
4253         (GoogleChromeWinPort.determine_port_name):
4254         * Scripts/webkitpy/layout_tests/port/gtk.py:
4255         (GtkPort):
4256         * Scripts/webkitpy/layout_tests/port/mac.py:
4257         (MacPort):
4258         (MacPort.determine_port_name):
4259         (MacPort.__init__):
4260         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4261         (test_versions):
4262         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
4263         (MockDRTPort):
4264         (MockDRTPort.determine_port_name):
4265         (MockDRTPort.__init__):
4266         (MockDRT):
4267         (MockDRT.determine_port_name):
4268         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4269         (PortTestCase.make_port):
4270         * Scripts/webkitpy/layout_tests/port/qt.py:
4271         (QtPort):
4272         (QtPort.determine_port_name):
4273         (QtPort.__init__):
4274         * Scripts/webkitpy/layout_tests/port/test.py:
4275         (TestPort):
4276         (TestPort.determine_port_name):
4277         (TestPort.__init__):
4278         * Scripts/webkitpy/layout_tests/port/webkit.py:
4279         (WebKitPort.__init__):
4280         * Scripts/webkitpy/layout_tests/port/win.py:
4281         (WinPort):
4282         (WinPort.determine_port_name):
4283         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4284         (get_test_baselines.AllPlatformsPort.__init__):
4285         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4286         (get_test_config.TestMacPort):
4287         (get_test_config):
4288
4289 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
4290
4291         webkitpy: clean up port code in preparation for static port names
4292         https://bugs.webkit.org/show_bug.cgi?id=76356
4293
4294         Reviewed by Adam Barth.
4295
4296         To fix bug 76215 and be able to determine appropriate port names
4297         in webkitpy without actually constructing Port objects, we need
4298         to shuffle some logic in the chromium ports to be able to figure
4299         out whether we built DRT in 32 or 64-bit mode.
4300
4301         * Scripts/webkitpy/layout_tests/port/chromium.py:
4302         (ChromiumPort):
4303         (ChromiumPort._chromium_base_dir):
4304         (ChromiumPort.__init__):
4305         (ChromiumPort.path_from_chromium_base):
4306         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4307         (ChromiumLinuxPort):
4308         (ChromiumLinuxPort._determine_driver_path_statically):
4309         (ChromiumLinuxPort._static_build_path):
4310         (ChromiumLinuxPort._determine_architecture):
4311         (ChromiumLinuxPort.__init__):
4312         (ChromiumLinuxPort._build_path):
4313
4314 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
4315
4316         Do not remove pixel failures for ref tests.
4317         https://bugs.webkit.org/show_bug.cgi?id=76243
4318
4319         Reviewed by Tony Chang.
4320
4321         'NRWT --no-pixel-tests' complains when reftests are expected to
4322         be image mismatch.
4323
4324         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4325         (Manager._update_summary_with_result):
4326         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4327         (is_reftest_failure):
4328         (determine_result_type):
4329
4330 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
4331
4332         REGRESSION(r81225): ORWT should ignore reftests
4333         https://bugs.webkit.org/show_bug.cgi?id=67936
4334
4335         Reviewed by Csaba Osztrogonác.
4336
4337         * Scripts/old-run-webkit-tests:
4338         (isUsedInReftest): $filename should be the first parameter
4339         (findTestsToRun): run test if it isn't reftest
4340
4341 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
4342
4343         Unreviewed. Fix python unit test I broke with r105142
4344
4345         * Scripts/webkitpy/common/config/ports_unittest.py:
4346         (WebKitPortTest.test_gtk_port):
4347
4348 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4349
4350         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
4351
4352         Qt 5 no longer has that flag.
4353
4354         Reviewed by Simon Hausmann.
4355
4356         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4357         (MiniBrowserApplication::notify):
4358
4359 2012-01-16  Gustavo Noronha Silva&n