Teach TestFailures to detect possibly flaky tests and list them separately
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-29  Adam Roben  <aroben@apple.com>
2
3         Teach TestFailures to detect possibly flaky tests and list them separately
4
5         Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
6         arbitrary revisions for breaking flaky tests
7
8         Reviewed by Dan Bates.
9
10         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.
11         (FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
12         from various builds (in reverse-chronological order).
13         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
14         monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
15         (FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
16         given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
17         and puts them in an array in reverse-chronological order.
18         (FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
19         to be possibly flaky.
20
21         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
22         (LayoutTestHistoryAnalyzer): Initialize new members.
23         (LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
24         properties: history and possiblyFlaky. history holds the data this function used to pass to
25         the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
26         flakiness. Updated documentation comment to match.
27         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
28         FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
29         removed from the failure history, since when they started failing is no longer meaningful.
30         We tell our caller to keep calling until all current failures have been explained and we've
31         gone through 5 builds without any new flaky tests being identified.
32
33         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
34         (sorted): New helper function to return a sorted copy of an array.
35         (Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
36         that matches the predicate.
37
38         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
39         (ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
40         the analyzer. Now puts the list of possibly flaky tests after the failure history.
41         (ViewController.prototype._domForFailedTest): Moved some code from here...
42         (ViewController.prototype._domForFailureDiagnosis): ...to here.
43         (ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
44         possibly flaky tests and examples of their flakiness and returns it.
45
46         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
47         FlakyLayoutTestDetector.js.
48
49 2011-06-29  Eric Seidel  <eric@webkit.org>
50
51         Adam says cowboys don't review (or unit test).
52
53         * Scripts/webkitpy/tool/commands/download.py:
54
55 2011-06-29  Eric Seidel  <eric@webkit.org>
56
57         Reviewed by Adam Barth.
58
59         Make port/config.py mockable for easier unit testing
60         https://bugs.webkit.org/show_bug.cgi?id=63661
61
62         Fix an exception from the unit tests.
63
64         * Scripts/webkitpy/layout_tests/port/config.py:
65
66 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
67
68         Unreviewed build correction.
69
70         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
71         Link against zlib1.dll, not the static zlib.lib.
72
73 2011-06-29  Eric Seidel  <eric@webkit.org>
74
75         Reviewed by Adam Barth.
76
77         Make port/config.py mockable for easier unit testing
78         https://bugs.webkit.org/show_bug.cgi?id=63661
79
80         Right now config.py leaks real system paths for
81         webkit_base_dir due to using __file__.  This patch
82         adds a filsystem.py wrapper around __file__ so that
83         we don't have to jump through hoops in webkit_unittest.py
84         to avoid leaking local paths to the unit test results.
85
86         There are probably many more places where we should now
87         use filesystem.path_for_module, but starting with just this one.
88
89         * Scripts/webkitpy/common/system/filesystem.py:
90         * Scripts/webkitpy/common/system/filesystem_mock.py:
91         * Scripts/webkitpy/layout_tests/port/config.py:
92         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
93         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
94
95 2011-06-29  Eric Seidel  <eric@webkit.org>
96
97         Reviewed by Adam Barth.
98
99         Remove duplicate methods in filesystem.py
100         https://bugs.webkit.org/show_bug.cgi?id=63658
101
102         Looks like there was a bad merge at some point.
103
104         I also removed a bunch of redundant docstrings.
105
106         * Scripts/webkitpy/common/system/filesystem.py:
107
108 2011-06-29  Adam Barth  <abarth@webkit.org>
109
110         Reviewed by Eric Seidel.
111
112         Pass --no-new-test-results to NRWT on build.webkit.org
113         https://bugs.webkit.org/show_bug.cgi?id=63653
114
115         This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
116
117         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
118
119 2011-06-29  Xan Lopez  <xlopez@igalia.com>
120
121         Reviewed by Adam Barth.
122
123         [GTK] overlapping drag&drop tests fail on NRWT
124         https://bugs.webkit.org/show_bug.cgi?id=57640
125
126         Make a GTK test driver that spawns one Xvfb instance per
127         thread. This avoids bad interactions in DnD tests between threads.
128
129         * Scripts/webkitpy/layout_tests/port/gtk.py:
130
131 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
132
133         Unreviewed, rolling out r89888.
134         http://trac.webkit.org/changeset/89888
135         https://bugs.webkit.org/show_bug.cgi?id=63609
136
137          "Seems to be causing merging issues on the dashboard, e.g.
138         http://test-
139         results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
140         (Requested by aboxhall on #webkit).
141
142         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
143         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
144         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
145
146 2011-06-29  Philippe Normand  <pnormand@igalia.com>
147
148         Reviewed by Martin Robinson.
149
150         [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
151         https://bugs.webkit.org/show_bug.cgi?id=63624
152
153         * Scripts/webkitpy/common/system/executive.py: In some cases the
154         ps output lines can contain one or more leading white-spaces, so
155         strip it before splitting the pid and command name.
156
157 2011-06-29  Noel Gordon  <noel.gordon@gmail.com>
158
159         Reviewed by Kent Tamura.
160
161         [Chromium] [DRT] ImageDiff should compile in VS2010
162         https://bugs.webkit.org/show_bug.cgi?id=63614
163
164         * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
165
166 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
167
168         Reviewed by Kenneth Rohde Christiansen.
169
170         [Qt] DRT support for setInteractiveFormValidationEnabled
171         https://bugs.webkit.org/show_bug.cgi?id=63496
172
173         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
174         (WebCore::DumpRenderTree::DumpRenderTree):
175
176 2011-06-28  Eric Seidel  <eric@webkit.org>
177
178         Reviewed by Adam Barth.
179
180         Make new-run-webkit-tests -2 actually use WebKitTestRunner
181         https://bugs.webkit.org/show_bug.cgi?id=63572
182
183         new-run-webkit-tests -2 works with this change.  However a zillion
184         tests fail since it can't find the right skipped lists for wk2.
185         The Skipped-list fixing is covered in bug 63501.
186
187         * Scripts/webkitpy/layout_tests/port/gtk.py:
188         * Scripts/webkitpy/layout_tests/port/qt.py:
189         * Scripts/webkitpy/layout_tests/port/webkit.py:
190
191 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
192
193         Reviewed by Adam Roben.
194
195         Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
196         https://bugs.webkit.org/show_bug.cgi?id=63500
197
198         Added google-mac-3 and google-mac-4.
199
200         * BuildSlaveSupport/build.webkit.org-config/config.json:
201
202 2011-06-28  Eric Seidel  <eric@webkit.org>
203
204         Reviewed by Dirk Pranke.
205
206         Remove webkitpy's tiger support now that WebKit no longer supports tiger
207         https://bugs.webkit.org/show_bug.cgi?id=63568
208
209         I don't think our support actually fully worked anyway.  Regardless
210         tiger is dead now (thankfully)!
211
212         I also unwrapped some short lines and added a couple FIXMEs while
213         touring the code.
214
215         No new tests, only removing old ones which tested our Tiger support.
216
217         * Scripts/webkitpy/layout_tests/port/base.py:
218         * Scripts/webkitpy/layout_tests/port/builders.py:
219         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
220         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
221         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
222         * Scripts/webkitpy/layout_tests/port/mac.py:
223         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
224         * Scripts/webkitpy/tool/commands/rebaseline.py:
225         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
226
227 2011-06-28  Eric Seidel  <eric@webkit.org>
228
229         Unreviewed, just fixing a typo.
230
231         Fix misspellings of "thead" to "thread".
232
233         * Scripts/webkitpy/common/checkout/scm/git.py:
234         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
235
236 2011-06-28  Eric Seidel  <eric@webkit.org>
237
238         Reviewed by Tony Chang.
239
240         new-run-webkit-tests needs a --webkit-test-runner option
241         https://bugs.webkit.org/show_bug.cgi?id=63439
242
243         This was accidentally fixed in bug 63501 as well.
244         The root problem here was that the webkit unit tests were not using
245         enough mocks.  I've fixed them here to use more mocks
246         which should unbreak windows.
247
248         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
249
250 2011-06-28  Eric Seidel  <eric@webkit.org>
251
252         Reviewed by Tony Chang.
253
254         new-run-webkit-tests should not run mthml tests when MHTML support is disabled
255         https://bugs.webkit.org/show_bug.cgi?id=63549
256
257         This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
258         I happen to go looking for what code was deciding that .mht was a supported
259         extension, found test_files.py and then removed some redundant doc-strings and
260         if branching.
261
262         * Scripts/webkitpy/layout_tests/port/test_files.py:
263         * Scripts/webkitpy/layout_tests/port/webkit.py:
264         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
265
266 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
267
268         Reviewed by Tony Chang.
269
270         Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
271         https://bugs.webkit.org/show_bug.cgi?id=63514
272
273         - change write_text_file to write_binary_file
274         - check that text_path and binary_path are actually existant files
275         - change cleanup block from 'except' to 'finally'
276
277         * Scripts/webkitpy/common/system/filesystem_unittest.py:
278
279 2011-06-28  Adam Roben  <aroben@apple.com>
280
281         Roll out r89924 and r89925
282
283         I didn't mean to commit them!
284
285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
288
289 2011-06-27  Adam Barth  <abarth@webkit.org>
290
291         Reviewed by Eric Seidel.
292
293         NRWT should wait for ReportCrash
294         https://bugs.webkit.org/show_bug.cgi?id=63495
295
296         When a test crashes on Mac, ReportCrash confuses us into thinking the
297         test times out.
298
299         I'm not sure how to test this in a meaningful way in our current test
300         harness...
301
302         * Scripts/webkitpy/common/system/crashlogs.py:
303         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
304         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
305         * Scripts/webkitpy/layout_tests/port/base.py:
306         * Scripts/webkitpy/layout_tests/port/mac.py:
307         * Scripts/webkitpy/layout_tests/port/server_process.py:
308         * Scripts/webkitpy/tool/commands/queries.py:
309
310 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
311
312         Unreviewed, rolling out r89881.
313         http://trac.webkit.org/changeset/89881
314         https://bugs.webkit.org/show_bug.cgi?id=63513
315
316         Makes Qt massively slow (Requested by abarth on #webkit).
317
318         * Scripts/webkitpy/common/system/crashlogs.py:
319         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
320         * Scripts/webkitpy/common/system/executive.py:
321         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
322         * Scripts/webkitpy/layout_tests/port/base.py:
323         * Scripts/webkitpy/layout_tests/port/mac.py:
324         * Scripts/webkitpy/layout_tests/port/server_process.py:
325         * Scripts/webkitpy/tool/commands/queries.py:
326
327 2011-06-27  Alice Boxhall  <aboxhall@chromium.org>
328
329         Reviewed by Ojan Vafai.
330
331         Convert json_results_generator.py to output version 4 JSON.
332         https://bugs.webkit.org/show_bug.cgi?id=60869
333
334         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
335         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
336         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
337
338 2011-06-27  Adam Barth  <abarth@webkit.org>
339
340         Reviewed by Eric Seidel.
341
342         NRWT should wait for ReportCrash
343         https://bugs.webkit.org/show_bug.cgi?id=63495
344
345         When a test crashes on Mac, ReportCrash confuses us into thinking the
346         test times out.
347
348         I'm not sure how to test this in a meaningful way in our current test
349         harness...
350
351         * Scripts/webkitpy/common/system/crashlogs.py:
352         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
353         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
354         * Scripts/webkitpy/layout_tests/port/base.py:
355         * Scripts/webkitpy/layout_tests/port/mac.py:
356         * Scripts/webkitpy/layout_tests/port/server_process.py:
357         * Scripts/webkitpy/tool/commands/queries.py:
358
359 2011-06-27  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Eric Seidel.
362
363         new-run-webkit-tests should upload crash logs
364         https://bugs.webkit.org/show_bug.cgi?id=55907
365
366         NRWT used to have a different name for crash logs.  I've changed the
367         name to patch ORWT.
368
369         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
370         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
371
372 2011-06-27  Eric Seidel  <eric@webkit.org>
373
374         Reviewed by Adam Barth.
375
376         new-run-webkit-tests needs a --webkit-test-runner option
377         https://bugs.webkit.org/show_bug.cgi?id=63439
378
379         NRWT doesn't actually know how to run with the WebKitTestRunner yet
380         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
381
382         There is a bunch of other little cleanup in this patch which I added as I
383         took a tour through all of our hard-coded DumpRenderTree strings.
384
385         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
386         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
387         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
388         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
389         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
390         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
391         * Scripts/webkitpy/layout_tests/port/config.py:
392          - build_dumprendertree had no business in this class, removed it.
393          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
394          - Exposed _script_path as script_path() (this probably belongs elsewhere).
395         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
396          - Moved these tests to webkit_unittests.
397         * Scripts/webkitpy/layout_tests/port/webkit.py:
398          - Now respects the --webkit-test-runner option.
399          - setup_test_run is empty in base.py too, no need to override it.
400         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
401          - Test the new hotness.
402          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
403            I think this code is still hitting disk during the unit tests. :(
404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
405          - Add the option.
406         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
407          - Remove optional args option.
408         * Scripts/webkitpy/tool/commands/commandtest.py:
409          - Remove optional args option.
410         * Scripts/webkitpy/tool/commands/queues_unittest.py:
411          - Remove optional args option.
412
413 2011-06-27  Adam Barth  <abarth@webkit.org>
414
415         Reviewed by Dirk Pranke.
416
417         new-run-webkit-tests does not report stderr output
418         https://bugs.webkit.org/show_bug.cgi?id=37739
419
420         Almost all the infrastructure appears to be in place to report stderr
421         in results.html.  We just need to wire up a bool to tell results.html
422         to create the hyperlink.
423
424         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
425         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
426         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
427         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
428         * Scripts/webkitpy/layout_tests/port/base.py:
429
430 2011-06-27  Adam Barth  <abarth@webkit.org>
431
432         Reviewed by Dirk Pranke.
433
434         webkitpy unit tests should have more descriptive names than just "Test"
435         https://bugs.webkit.org/show_bug.cgi?id=63479
436
437         Luckily we kept these classes in separate namespaces in the harness so
438         we were actually running them all even though they had the same name.
439
440         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
441         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
442         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
443
444 2011-06-27  Greg Simon  <gregsimon@chromium.org>
445
446         No review necessary.
447
448         Add email addr to contributor list
449         https://bugs.webkit.org/show_bug.cgi?id=63478
450
451         * Scripts/webkitpy/common/config/committers.py:
452
453 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
454
455         Unreviewed, rolling out r89834.
456         http://trac.webkit.org/changeset/89834
457         https://bugs.webkit.org/show_bug.cgi?id=63476
458
459         Broke test-webkitpy (Requested by abarth on #webkit).
460
461         * Scripts/webkitpy/common/net/layouttestresults.py:
462         * Scripts/webkitpy/common/system/outputcapture.py:
463         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
464         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
465         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
466         * Scripts/webkitpy/layout_tests/port/base.py:
467         * Scripts/webkitpy/layout_tests/port/config.py:
468         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
469         * Scripts/webkitpy/layout_tests/port/webkit.py:
470         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
471         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
472         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
473         * Scripts/webkitpy/tool/commands/commandtest.py:
474         * Scripts/webkitpy/tool/commands/queues_unittest.py:
475
476 2011-06-27  Jeff Miller  <jeffm@apple.com>
477
478         Reviewed by Adam Roben.
479
480         Stop copying obsolete WebKit libraries on Windows
481         https://bugs.webkit.org/show_bug.cgi?id=63474
482         
483         Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
484
485         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
486         * MiniBrowser/MiniBrowserPostBuild.cmd:
487         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
488
489 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
490
491         Add Wyatt Carss to the list of non-committer contributors.
492
493         * Scripts/webkitpy/common/config/committers.py:
494
495 2011-06-27  Adam Barth  <abarth@webkit.org>
496
497         Reviewed by Eric Seidel.
498
499         webkitpy should understand crash logs
500         https://bugs.webkit.org/show_bug.cgi?id=63468
501
502         We're planning to use this functionality to upload crash logs along
503         with test results for new-run-webkit-tests.
504
505         * Scripts/webkitpy/common/system/crashlog.py: Added.
506         * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
507         * Scripts/webkitpy/common/system/executive.py:
508         * Scripts/webkitpy/common/system/executive_unittest.py:
509         * Scripts/webkitpy/common/system/filesystem.py:
510         * Scripts/webkitpy/common/system/filesystem_mock.py:
511         * Scripts/webkitpy/tool/commands/queries.py:
512
513 2011-06-27  Adam Roben  <aroben@apple.com>
514
515         Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
516         failures
517
518         Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
519         old-run-webkit-tests exited early after reload
520
521         Reviewed by Anders Carlsson.
522
523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
524         (LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
525         old-run-webkit-tests exited early due to too many failures in PersistentCache.
526
527 2011-06-27  Adam Roben  <aroben@apple.com>
528
529         Make TestFailures load build names from build.webkit.org/old-results too
530
531         Build results are periodically moved from results to old-results. This change makes those
532         builds still visible to TestFailures.
533
534         Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
535         have been moved to build.webkit.org/old-results
536
537         Reviewed by Anders Carlsson.
538
539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
540         (Builder.prototype.getBuildNames): Extracted code to parse build names from a
541         build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
542         we now only include directory entries whose names are parseable as build names (since
543         old-results sometimes contains other random files/directories from who knows what). We now
544         fetch both results and old-results (with a FIXME about loading old-results on demand),
545         extract build names from each, and concatenate the two sets of names.
546
547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:
548         (WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
549         parseable, rather than throwing an exception.
550
551 2011-06-26  Adam Roben  <aroben@apple.com>
552
553         Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache
554
555         It seems silly to have a whole generic cache just to store a single object.
556
557         Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
558         need one
559
560         Reviewed by Anders Carlsson.
561
562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
563         (LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
564         (LayoutTestHistoryAnalyzer.prototype.start): Ditto.
565         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
566         no-longer-needed history argument.
567
568 2011-06-26  Adam Roben  <aroben@apple.com>
569
570         Move some inappropriate code out of Builder
571
572         Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
573         isn't really about a builder
574
575         Reviewed by Anders Carlsson.
576
577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
578         (Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
579         called by other objects.
580
581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
582         Added. Code came from Builder.
583         (LayoutTestHistoryAnalyzer):
584         (LayoutTestHistoryAnalyzer.prototype.start):
585         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):
586
587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
588         Added. Code came from Builder.
589         (LayoutTestResultsLoader):
590         (LayoutTestResultsLoader.prototype.start):
591
592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
593         (ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.
594
595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new
596         scripts.
597
598 2011-05-17  Nat Duca  <nduca@chromium.org>
599
600         Reviewed by James Robinson.
601
602         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
603         https://bugs.webkit.org/show_bug.cgi?id=58408
604
605         * DumpRenderTree/chromium/WebViewHost.cpp:
606         (WebViewHost::paintInvalidatedRegion):
607
608 2011-06-27  Eric Seidel  <eric@webkit.org>
609
610         Reviewed by Adam Barth.
611
612         new-run-webkit-tests needs a --webkit-test-runner option
613         https://bugs.webkit.org/show_bug.cgi?id=63439
614
615         NRWT doesn't actually know how to run with the WebKitTestRunner yet
616         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
617
618         There is a bunch of other little cleanup in this patch which I added as I
619         took a tour through all of our hard-coded DumpRenderTree strings.
620
621         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
622         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
623         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
624         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
625         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
626         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
627         * Scripts/webkitpy/layout_tests/port/config.py:
628          - build_dumprendertree had no business in this class, removed it.
629          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
630          - Exposed _script_path as script_path() (this probably belongs elsewhere).
631         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
632          - Moved these tests to webkit_unittests.
633         * Scripts/webkitpy/layout_tests/port/webkit.py:
634          - Now respects the --webkit-test-runner option.
635          - setup_test_run is empty in base.py too, no need to override it.
636         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
637          - Test the new hotness.
638          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
639            I think this code is still hitting disk during the unit tests. :(
640         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
641          - Add the option.
642         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
643          - Remove optional args option.
644         * Scripts/webkitpy/tool/commands/commandtest.py:
645          - Remove optional args option.
646         * Scripts/webkitpy/tool/commands/queues_unittest.py:
647          - Remove optional args option.
648
649 2011-06-27  Chang Shu  <cshu@webkit.org>
650
651         Reviewed by Darin Adler.
652
653         [WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
654         https://bugs.webkit.org/show_bug.cgi?id=63457
655
656         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
657         (WTR::InjectedBundle::beginTesting):
658
659 2011-06-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
660
661         Reviewed by Kent Tamura.
662
663         [EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
664         It will be plugged into the build system as soon as the rest of the
665         DRT code is fully upstreamed.
666         https://bugs.webkit.org/show_bug.cgi?id=63086
667
668         * DumpRenderTree/efl/DumpRenderTreeView.cpp: Added.
669         (onConsoleMessage):
670         (onJavaScriptAlert):
671         (onJavaScriptConfirm):
672         (onJavaScriptPrompt):
673         (drtViewTiledAdd):
674         * DumpRenderTree/efl/DumpRenderTreeView.h: Added.
675
676 2011-06-27  Leandro Pereira  <leandro@profusion.mobi>
677
678         Reviewed by Kent Tamura.
679
680         [EFL] Add an EventSender implementation to EFL's DumpRenderTree along
681         with support files.
682         Build system changes will be made as soon as the whole DumpRenderTree
683         is upstreamed.
684         https://bugs.webkit.org/show_bug.cgi?id=61962
685
686         * DumpRenderTree/efl/EventSender.cpp: Added.
687         (setEvasModifiers):
688         (translateMouseButtonNumber):
689         (sendMouseEvent):
690         (sendClick):
691         (scheduleAsynchronousClickCallback):
692         (updateClickCount):
693         (modifierFromJSValue):
694         (modifiersFromJSValue):
695         (mouseDownCallback):
696         (mouseUpCallback):
697         (mouseMoveToCallback):
698         (evasMouseEventFromHorizontalAndVerticalOffsets):
699         (mouseScrollByCallback):
700         (continuousMouseScrollByCallback):
701         (keyPadNameFromJSValue):
702         (keyNameFromJSValue):
703         (keyDownCallback):
704         (scalePageByCallback):
705         (getClass):
706         (makeEventSender):
707         * DumpRenderTree/efl/EventSender.h: Added.
708
709 2011-06-27  Eric Seidel  <eric@webkit.org>
710
711         Reviewed by Adam Barth.
712
713         Remove evil uses of hasattr
714         https://bugs.webkit.org/show_bug.cgi?id=63430
715
716         For some reason these classes believe that they may be called with
717         various flavors of "option" elements and so carefully check to make
718         sure that the options element has their option before checking it.
719
720         We had a set_option_default method which was never called, so I made it
721         do what callsites seemed to want it to do and replaced 3 callers
722         who previously used hasattr manually to use set_option_default instead.
723
724         * Scripts/webkitpy/layout_tests/port/base.py:
725         * Scripts/webkitpy/layout_tests/port/webkit.py:
726
727 2011-06-27  Kent Tamura  <tkent@chromium.org>
728
729         Reviewed by Hajime Morita.
730
731         [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
732         https://bugs.webkit.org/show_bug.cgi?id=63427
733
734         ~WebViewHost() navigates to about:blank, so it calls some
735         callbacks and LayoutTestController functions.
736
737         * DumpRenderTree/chromium/TestShell.h:
738          Move m_printer upper and move m_webViewHost lower.
739
740 2011-06-27  Adam Barth  <abarth@webkit.org>
741
742         Reviewed by Eric Seidel.
743
744         Move server config files to webkitpy.layout_tests.servers
745         https://bugs.webkit.org/show_bug.cgi?id=63436
746
747         The config files belong with the servers.
748
749         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
750         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
751         * Scripts/webkitpy/layout_tests/servers/http_server.py:
752         * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
753         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
754
755 2011-06-27  Adam Barth  <abarth@webkit.org>
756
757         Reviewed by Eric Seidel.
758
759         Move websocket_server and http_server to webkitpy.layout_package.servers
760         https://bugs.webkit.org/show_bug.cgi?id=63434
761
762         These classes do not represent ports.  They represent servers.
763
764         * Scripts/new-run-webkit-httpd:
765         * Scripts/new-run-webkit-websocketserver:
766         * Scripts/webkitpy/layout_tests/port/base.py:
767         * Scripts/webkitpy/layout_tests/port/chromium.py:
768         * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
769         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
770         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
771         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
772         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
773         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
774         * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
775         * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
776         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
777         * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
778
779 2011-06-27  Eric Seidel  <eric@webkit.org>
780
781         Reviewed by Adam Barth.
782
783         Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
784         https://bugs.webkit.org/show_bug.cgi?id=63428
785
786         * Scripts/webkitpy/layout_tests/port/chromium.py:
787         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
788
789 2011-06-27  Adam Barth  <abarth@webkit.org>
790
791         Reviewed by Eric Seidel.
792
793         Move apache_http_server.py to webkitpy.layout_package.servers
794         https://bugs.webkit.org/show_bug.cgi?id=63433
795
796         The apache_http_server.py is a server, not a port.
797
798         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
799         * Scripts/webkitpy/layout_tests/port/base.py:
800         * Scripts/webkitpy/layout_tests/servers: Added.
801         * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
802         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
803
804 2011-06-27  Adam Barth  <abarth@webkit.org>
805
806         Reviewed by Eric Seidel.
807
808         Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
809         https://bugs.webkit.org/show_bug.cgi?id=63432
810
811         This code isn't in the dependency cone of new-run-webkit-tests. It's
812         unclear what it's final home should be, but this patch moves it out of
813         layout_tests to simply the package.
814
815         * Scripts/rebaseline-chromium-webkit-tests:
816         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
817         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
818         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
819         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
820
821 2011-06-27  Adam Barth  <abarth@webkit.org>
822
823         Reviewed by Eric Seidel.
824
825         Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
826         https://bugs.webkit.org/show_bug.cgi?id=63429
827
828         This package as nothing to do with the layout_tests package.
829
830         * Scripts/update-webgl-conformance-tests:
831         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
832         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
833         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
834         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
835
836 2011-06-27  Adam Barth  <abarth@webkit.org>
837
838         Reviewed by Eric Seidel.
839
840         Move deduplicate_tests.py into webkitpy.to_be_moved
841         https://bugs.webkit.org/show_bug.cgi?id=63426
842
843         deduplicate_tests.py doesn't haven anything to do with layout tests.
844         It's really a separate script.  This patch moves it to the (new)
845         to_be_moved package so that it doesn't distract us when working on NRWT.
846
847         * Scripts/deduplicate-tests:
848         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
849         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
850         * Scripts/webkitpy/test/main.py:
851         * Scripts/webkitpy/to_be_moved: Added.
852         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
853         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
854         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
855
856 2011-06-26  Adam Barth  <abarth@webkit.org>
857
858         Rubber-stamped by Eric Seidel.
859
860         Remove empty directory.
861
862         * Scripts/webkitpy/layout_tests/test_types: Removed.
863
864 2011-06-25  Naoki Takano  <honten@chromium.org>
865
866         Reviewed by Eric Seidel.
867
868         Change my entry from contributors to committers.
869         https://bugs.webkit.org/show_bug.cgi?id=63043
870
871         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
872
873 2011-06-25  Adam Barth  <abarth@webkit.org>
874
875         Reviewed by Eric Seidel.
876
877         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
878         https://bugs.webkit.org/show_bug.cgi?id=63394
879
880         * DumpRenderTree/chromium/LayoutTestController.cpp:
881         (LayoutTestController::queueLoad):
882
883 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
884
885         Unreviewed build correction after r89426.
886
887         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
888           Link with Cairo DLL for new functionality.
889         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
890           code for snprintf.
891
892 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
893
894         Reviewed by Adam Barth.
895
896         run-bindings-tests does not work on Chromium Windows.
897         https://bugs.webkit.org/show_bug.cgi?id=63382
898
899         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
900
901 2011-06-25  Dan Bernstein  <mitz@apple.com>
902
903         Try to fix the Qt and Chromium builds.
904
905         * DumpRenderTree/chromium/LayoutTestController.cpp:
906         (LayoutTestController::setEncodedAudioData):
907         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
908
909 2011-06-24  Dan Bernstein  <mitz@apple.com>
910
911         Reviewed by Anders Carlsson.
912
913         Add an option to enable legacy rounding hacks
914         https://bugs.webkit.org/show_bug.cgi?id=63363
915
916         Added layoutTestController.allowRoundingHacks() and implemented it
917         on OS X.
918
919         * DumpRenderTree/LayoutTestController.cpp:
920         (allowRoundingHacksCallback):
921         (LayoutTestController::staticFunctions):
922         * DumpRenderTree/LayoutTestController.h:
923         * DumpRenderTree/chromium/LayoutTestController.cpp:
924         (LayoutTestController::allowRoundingHacks):
925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
926         (LayoutTestController::allowRoundingHacks):
927         * DumpRenderTree/mac/DumpRenderTree.mm:
928         (resetWebViewToConsistentStateBeforeTesting):
929         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
930         (LayoutTestController::allowRoundingHacks):
931         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
932         (LayoutTestController::allowRoundingHacks):
933         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
934         (LayoutTestController::allowRoundingHacks):
935         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
936         (LayoutTestController::allowRoundingHacks):
937
938 2011-06-24  Adam Roben  <aroben@apple.com>
939
940         Include the directory containing the failing tests in titles of bugs filed from TestFailures
941         when all the tests won't fit
942
943         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
944         which tests are failing
945
946         Reviewed by David Kilzer.
947
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
949         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
950         that ends in a path separator.
951
952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
953         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
954         in the title, first try to include the longest common prefix of the test names, then, if
955         that's still too long or there's no common prefix, fall back to not including any
956         information about which tests are failing.
957
958 2011-06-24  Adam Roben  <aroben@apple.com>
959
960         Include links to Trac in bugs filed from TestFailures
961
962         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
963         Trac for suspect revisions
964
965         Reviewed by David Kilzer.
966
967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
968         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
969         Trac.
970
971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
972         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
973         include a link to Trac for it in the first sentence of the description. Otherwise include a
974         link to the suspect range after the list of failing tests.
975
976 2011-06-24  Nat Duca  <nduca@chromium.org>
977
978         Unreviewed, rolling out r89694.
979         http://trac.webkit.org/changeset/89694
980         https://bugs.webkit.org/show_bug.cgi?id=58408
981
982         Test shell still not ready for animate changes.
983
984         * DumpRenderTree/chromium/WebViewHost.cpp:
985         (WebViewHost::paintInvalidatedRegion):
986
987 2011-06-24  Adam Roben  <aroben@apple.com>
988
989         Fix typos introduced in r89696
990
991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
992         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
993         callback, since that's what it expects.
994
995 2011-06-24  Adam Roben  <aroben@apple.com>
996
997         Make TestFailures correctly remember whether old-run-webkit-tests exited early
998
999         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
1000         completion after reload
1001
1002         Reviewed by David Kilzer.
1003
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1005         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
1006         in the PeristentCache, store an object that contains both the number of failures and whether
1007         old-run-webkit-tests exited early.
1008
1009 2011-06-24  Adam Roben  <aroben@apple.com>
1010
1011         Add links to regression ranges in Trac to the TestFailures page
1012
1013         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
1014         links to regression ranges in Trac
1015
1016         Reviewed by David Kilzer.
1017
1018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
1019         (Trac): This new class represents a particular instance of Trac for a single project.
1020         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
1021         repository path between the two specified revisions
1022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1023         (ViewController): Added new trac argument.
1024         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
1025         passed/failed builds from here...
1026         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
1027         Trac if there are multiple suspect revisions.
1028
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1030         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
1031
1032 2011-05-17  Nat Duca  <nduca@chromium.org>
1033
1034         Reviewed by James Robinson.
1035
1036         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
1037         https://bugs.webkit.org/show_bug.cgi?id=58408
1038
1039         * DumpRenderTree/chromium/WebViewHost.cpp:
1040         (WebViewHost::paintInvalidatedRegion):
1041
1042 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
1043
1044         Reviewed by Dimitri Glazkov.
1045
1046         Convert shadow DOM-related tests to use window.internals
1047         https://bugs.webkit.org/show_bug.cgi?id=61671
1048
1049         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
1050         removeShadowRoot from layoutTestController; these have been
1051         replaced by equivalents in window.internals instead.
1052
1053         * DumpRenderTree/LayoutTestController.cpp:
1054         (LayoutTestController::staticFunctions):
1055         * DumpRenderTree/LayoutTestController.h:
1056         * DumpRenderTree/chromium/LayoutTestController.cpp:
1057         (LayoutTestController::LayoutTestController):
1058         * DumpRenderTree/chromium/LayoutTestController.h:
1059         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1060         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1061         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1062         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1063         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1064         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1065         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1066         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1067         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1068
1069 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
1070
1071         Reviewed by Dirk Schulze.
1072
1073         Make run-bindings-tests remove its temporary directories.
1074         https://bugs.webkit.org/show_bug.cgi?id=63320
1075
1076         * Scripts/run-bindings-tests:
1077
1078 2011-06-23  MORITA Hajime  <morrita@google.com>
1079
1080         Reviewed by Kent Tamura.
1081
1082         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
1083         https://bugs.webkit.org/show_bug.cgi?id=63216
1084
1085         Deleted m_webViewHost which looks leaked.
1086         
1087         * DumpRenderTree/chromium/TestShell.h:
1088         * DumpRenderTree/chromium/TestShell.cpp:
1089         (TestShell::~TestShell):
1090
1091 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1092
1093         Unreviewed. Fix WebKit2 GTK build.
1094
1095         * WebKitTestRunner/GNUmakefile.am:
1096
1097 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
1098
1099         Unreviewed, add myself as committer.
1100
1101         * Scripts/webkitpy/common/config/committers.py:
1102
1103 2011-06-23  Nat Duca  <nduca@chromium.org>
1104
1105         Unreviewed, add myself as committer.
1106
1107         * Scripts/webkitpy/common/config/committers.py:
1108
1109 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1110
1111         Reviewed by Tony Chang.
1112
1113         nrwt: move http locking code into manager
1114         https://bugs.webkit.org/show_bug.cgi?id=63103
1115
1116         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1117         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1118
1119 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
1120
1121         Reviewed by James Robinson.
1122
1123         [chromium] Add support for running layout tests with accelerated rendering
1124         https://bugs.webkit.org/show_bug.cgi?id=63274
1125
1126         * Scripts/webkitpy/layout_tests/port/chromium.py:
1127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1128
1129 2011-06-23  Adam Roben  <aroben@apple.com>
1130
1131         Avoid fetching JSON data when possible on TestFailures page to determine if
1132         old-run-webkit-tests exited early
1133
1134         As of r89610, results.html includes information about whether old-run-webkit-tests exited
1135         early, so we don't need to look at JSON data to get this information for builds newer than
1136         that.
1137
1138         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
1139         which is slow and limits history to the last build master restart
1140
1141         Reviewed by David Kilzer.
1142
1143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1144         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
1145         function. If we're dealing with a build that has early-exit information in results.html,
1146         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
1147         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
1148         (as before).
1149
1150 2011-06-23  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         sheriffbot can no longer restart
1155         https://bugs.webkit.org/show_bug.cgi?id=63221
1156
1157         Fixed and unit tested.
1158
1159         * Scripts/webkitpy/tool/bot/queueengine.py:
1160         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1161         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1162
1163 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
1164
1165         Reviewed by Xan Lopez.
1166
1167         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
1168         https://bugs.webkit.org/show_bug.cgi?id=63287
1169
1170         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
1171         so that the plugin loads properly.
1172
1173         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
1174         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1175         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
1176         of the work for getting an environment variable and converting it to UTF-8.
1177         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
1178         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
1179
1180 2011-06-23  Adam Roben  <aroben@apple.com>
1181
1182         Record whether old-run-webkit-tests aborted early in results.html
1183
1184         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
1185         old-run-webkit-tests stopped running tests early
1186
1187         Reviewed by David Kilzer.
1188
1189         * Scripts/old-run-webkit-tests:
1190         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
1191         Added a <style> element with some styles for the new message. If we stopped running early,
1192         put the reason why at the top of results.html.
1193         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
1194         $stoppedRunningEarlyMessage global.
1195
1196 2011-06-23  Adam Roben  <aroben@apple.com>
1197
1198         Cache some of the TestFailures page's data in localStorage
1199
1200         This makes reloading TestFailures much faster. Right now we only store the number of failing
1201         tests and the list of failing tests for each build. We may choose to store more later, but
1202         it's easy to run up against quota limits.
1203
1204         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
1205         APIs (or similar) to improve loading performance
1206
1207         Reviewed by David Kilzer.
1208
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1210         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
1211         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
1212         fetching data to the callback.
1213         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
1214         store the tests in the cache just before calling the callback. (The previous code in this
1215         function relied on being able to modify the tests object after storing it in the cache and
1216         having the cached version be updated. This worked while it was a non-serialized cache, but
1217         PersistentCache uses serialization.)
1218
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
1220         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
1221         values, and stores the date that each value was initially stored along with it. This is
1222         later used for pruning the cache.
1223         (PersistentCache.contains): Checks whether the key exists in localStorage.
1224         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
1225         value out of it.
1226         (PersistentCache.set): Serialize the value, add the date to it, and store it in
1227         localStorage. If this fails due to quota limits, empty the whole cache and try again.
1228         (PersistentCache.prune): Delete any cached data that is deemed old enough.
1229         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
1230         (PersistentCache._emptyCache): Delete everything from localStorage.
1231         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
1232         return them.
1233
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1235         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
1236         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
1237         where we'd never show the new bug link for tests for which we couldn't determine a passing
1238         revision.
1239
1240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1241         PersistentCache.js.
1242
1243 2011-06-23  Adam Roben  <aroben@apple.com>
1244
1245         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
1246
1247         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
1248         contain titles that are so long they are rejected by Bugzilla
1249
1250         Reviewed by David Kilzer.
1251
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1253         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
1254         using a query string on the URL. If the search query is very long, using a query string can
1255         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
1256         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1259         (.new-bug-form): Hide the form that we secretly use to file a new bug.
1260
1261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1262         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
1263         query parameters to the URL. Otherwise, send them as the body of the request along with the
1264         appropriate headers.
1265         (getResource): Now just calls through to fetchResource.
1266         (urlEncodedQueryParameters): Added. Moved some code here...
1267         (addQueryParametersToURL): ...from here.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1270         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
1271         number of failing tests if mentioning all the tests would make the title too long. Improved
1272         the description for large numbers of failures by listing the tests one-per-line instead of
1273         just having them be comma-separated, which was hard to read. Use a form to file the new bug
1274         instead of a link so that we can POST the form data. (Using a URL with a query string can
1275         result in the URL being too long.) The new bug link now just submits the form.
1276
1277 2011-06-23  Adam Roben  <aroben@apple.com>
1278
1279         Show closed bugs on the TestFailures page in addition to open ones
1280
1281         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
1282
1283         Reviewed by David Kilzer.
1284
1285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1286         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
1287         returned data.
1288         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
1289         the associated bug is still open.
1290
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1292         (addQueryParametersToURL): Add a missing semicolon.
1293         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
1294         object and appends each of the values stored within.
1295
1296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1297         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
1298         bugs will be included in the results. Split the returned bugs into two sets: those which are
1299         open, and those which are closed. Put the open bugs at the top level of the list, and the
1300         closed bugs in a second level.
1301
1302 2011-06-23  Adam Roben  <aroben@apple.com>
1303
1304         Don't count new tests as failures on the TestFailures page
1305
1306         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
1307         they aren't
1308
1309         Reviewed by Anders Carlsson.
1310
1311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1312         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
1313         of failures.
1314
1315 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1316
1317         Reviewed by Eric Seidel.
1318
1319         nrwt: make TestInput objects printable
1320         https://bugs.webkit.org/show_bug.cgi?id=63225
1321
1322         This makes debugging slighlty easier.
1323
1324         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1325
1326 2011-06-22  Daniel Bates  <dbates@webkit.org>
1327
1328         Reviewed by Adam Barth.
1329
1330         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
1331         https://bugs.webkit.org/show_bug.cgi?id=62943
1332
1333         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
1334         by Scripts/webkitpy/common/checkout/__init__.py.
1335
1336         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1337
1338 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
1339
1340         Reviewed by Mark Rowe.
1341
1342         Add window.internals to WebKit2's WebKitTestRunner.
1343         https://bugs.webkit.org/show_bug.cgi?id=61073
1344
1345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
1346         * WebKitTestRunner/Configurations/Base.xcconfig:
1347         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1348         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1349         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1351         (WTR::InjectedBundlePage::didClearWindowForFrame):
1352         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1353         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1354
1355 2011-06-22  Eric Seidel  <eric@webkit.org>
1356
1357         Reviewed by Adam Barth.
1358
1359         Make sheriff-bot rollout messages a little nicer
1360         https://bugs.webkit.org/show_bug.cgi?id=63107
1361
1362         itertools.chain.from_iterable is new in 2.6,
1363         use itertools.chain(*list) for 2.5 compat.
1364
1365         * Scripts/webkitpy/tool/bot/irc_command.py:
1366
1367 2011-06-22  Eric Seidel  <eric@webkit.org>
1368
1369         Reviewed by Adam Barth.
1370
1371         Make sheriff-bot robust against exceptions from commands
1372         https://bugs.webkit.org/show_bug.cgi?id=63211
1373
1374         sheriff-bot was acting strange this afternoon.
1375         We don't know if this will fix the cause, but
1376         at least it adds some unit tests and catches
1377         one possible cause.
1378
1379         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1380         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1381
1382 2011-06-22  Mark Rowe  <mrowe@apple.com>
1383
1384         Reviewed by David Levin.
1385
1386         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
1387
1388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
1389         be relative to the built products directory rather than using a hard-coded path. Remove the
1390         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
1391         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
1392         rather than in the .xcodeproj directly.
1393
1394 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1395
1396         Reviewed by Ojan Vafai.
1397
1398         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
1399         https://bugs.webkit.org/show_bug.cgi?id=59993
1400
1401         * Scripts/webkitpy/layout_tests/port/base.py:
1402         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1403         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1404         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1405         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1406         * Scripts/webkitpy/layout_tests/port/gtk.py:
1407         * Scripts/webkitpy/layout_tests/port/mac.py:
1408         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1409         * Scripts/webkitpy/layout_tests/port/qt.py:
1410         * Scripts/webkitpy/layout_tests/port/win.py:
1411
1412 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
1413
1414         Reviewed by Andreas Kling.
1415
1416         Move macpherson from contributor list to committer list.
1417         https://bugs.webkit.org/show_bug.cgi?id=63179
1418
1419         * Scripts/webkitpy/common/config/committers.py:
1420         Move macpherson from contributor list to committer list.
1421
1422 2011-06-22  David Levin  <levin@chromium.org>
1423
1424         Reviewed by Adam Barth.
1425
1426         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
1427         https://bugs.webkit.org/show_bug.cgi?id=63204
1428
1429         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
1430           with similar code for the parameter checking.
1431         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
1432           those done for single lines since they don't make sense in that case (variable decls look like function decls).
1433           Removed some redundant comments (one of which was slightly wrong).
1434           Added checks for the new functionality and minor other test changes.
1435
1436 2011-06-22  Nate Chapin  <japhet@chromium.org>
1437
1438         Reviewed by Adam Barth.
1439
1440         Add libsoup to libWebCoreInternals build.
1441         https://bugs.webkit.org/show_bug.cgi?id=62066
1442
1443         * GNUmakefile.am:
1444
1445 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1446
1447         Reviewed by Tony Chang.
1448
1449         nrwt: handle missing httpd cleanly
1450         https://bugs.webkit.org/show_bug.cgi?id=62027
1451
1452         We had reverted the change in r89414, so this adds it back in
1453         (modifying check_sys_deps() in port/base.py to check for an
1454         installed web server).
1455
1456         This change then fixes the change in r89414 to stub out the
1457         check_sys_deps() in the test port so that the unit tests run correctly.
1458
1459         * Scripts/webkitpy/layout_tests/port/base.py:
1460         * Scripts/webkitpy/layout_tests/port/test.py:
1461
1462 2011-06-22  David Levin  <levin@chromium.org>
1463
1464         Reviewed by Adam Barth.
1465
1466         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
1467         https://bugs.webkit.org/show_bug.cgi?id=63188
1468
1469         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
1470         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1471
1472 2011-06-22  Tony Chang  <tony@chromium.org>
1473
1474         Reviewed by Ojan Vafai.
1475
1476         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
1477         https://bugs.webkit.org/show_bug.cgi?id=62891
1478
1479         * BuildSlaveSupport/build.webkit.org-config/config.json:
1480
1481 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1482
1483         Reviewed by Ojan Vafai.
1484
1485         nrwt: don't look for http lock when running the test port
1486         https://bugs.webkit.org/show_bug.cgi?id=63158
1487
1488         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1489         * Scripts/webkitpy/layout_tests/port/test.py:
1490
1491 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
1492
1493         Reviewed by Andreas Kling.
1494
1495         [Qt][WK2] Set up plugin tests
1496         https://bugs.webkit.org/show_bug.cgi?id=63066
1497
1498         * WebKitTestRunner/qt/TestControllerQt.cpp:
1499         (WTR::TestController::initializeTestPluginDirectory):
1500         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
1501         of the test plugin like DRT does.
1502
1503 2011-06-22  Eric Seidel  <eric@webkit.org>
1504
1505         Reviewed by Ojan Vafai.
1506
1507         Make sheriff-bot rollout messages a little nicer
1508         https://bugs.webkit.org/show_bug.cgi?id=63107
1509
1510         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
1511         into urls myself.  So I have now fixed its "preparing" message to include a url.
1512
1513         I also figured that I should make the messages mention all of the responsible parties
1514         so that rollouts are never surprises.  If you're in the channel and were involved
1515         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
1516
1517         As part of doing this I also changed (and tested) _parse_args to fail-fast
1518         when given invalid args.
1519
1520         * Scripts/webkitpy/tool/bot/irc_command.py:
1521         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1522         * Scripts/webkitpy/tool/bot/sheriff.py:
1523         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1524
1525 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1526
1527         Reviewed by Tony Chang.
1528
1529         run-webkit-websocketserver fails to stop websocket server
1530         https://bugs.webkit.org/show_bug.cgi?id=63123
1531
1532         There's a ten-character change in new-run-webkit-websocketserver
1533         that fixes the actual bug, and then we update the code in
1534         new-run-webkit-httpd to do the actual stop call, and add more tests
1535         (refactoring the existing test code so that it is shared).
1536
1537         * Scripts/new-run-webkit-httpd:
1538         * Scripts/new-run-webkit-websocketserver:
1539         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
1540
1541 2011-06-22  Adam Roben  <aroben@apple.com>
1542
1543         Add links to existing bugs related to failing tests on TestFailures page
1544
1545         I changed the layout of the page a little to make it easier to read with all the new
1546         information. Passing/failing revisions have been moved down below the list of tests to be
1547         closer to the existing bugs and the new bug link. And each set of tests and its relevant
1548         information is in a light gray box.
1549
1550         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
1551         possible
1552
1553         Reviewed by Darin Adler.
1554
1555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
1556         (Bugzilla): This new class represents a single Bugzilla instance.
1557         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
1558         passing the resulting bug titles and URLs to the callback when complete. If called multiple
1559         times with the same query before the query returns, caches the callbacks so that only one
1560         query is sent over the wire. When the query completes, all pending callbacks are called.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1563         (#failure-history): Reduce the margin/padding on the top-level list a bit.
1564         (#failure-history > li): Put each set of tests in a gray box, and indent most information
1565         inside the box.
1566         (.test-list): Unindent the list of failing tests so it is visually at the top level.
1567         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
1568         each box isn't a big empty space.
1569         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
1570         quite long.
1571
1572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1573         (addQueryParametersToURL): New function extracted from
1574         ViewController.prototype._domForNewAndExistingBugs.
1575
1576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1577         (ViewController): Take and store an optional Bugzilla instance.
1578         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
1579         purposes and move the list of failing tests above all other information. Only show bug
1580         information once we've determined the most-recent passing revision for a set of tests. It's
1581         not that useful to file a new bug before this information has been determined, and searching
1582         for existing bugs before we've figured out which tests started failing at the same time
1583         would end up giving you information about a bunch of unrelated tests.
1584         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
1585         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
1586         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
1587         failing tests, and adds links to the bugs when the search completes.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
1590         Bugzilla instance for bugs.webkit.org to the ViewController.
1591
1592 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         Reviewed by Martin Robinson.
1595
1596         [GTK] Apply current view settings to newly created views in GtkLauncher
1597         https://bugs.webkit.org/show_bug.cgi?id=63142
1598
1599         * GtkLauncher/main.c:
1600         (createWebViewCb):
1601
1602 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1603
1604         Reviewed by Martin Robinson.
1605
1606         [GTK] Use GOption to parse main arguments in GtkLauncher
1607         https://bugs.webkit.org/show_bug.cgi?id=63060
1608
1609         Instead of getting the settings from the view, create a new
1610         settings object not associated with any view so that we can parse
1611         the command line arguments before creating the view. It will also
1612         allows to use the same settings for more than one view if we
1613         eventually support passing more than one uri from the command
1614         line.
1615
1616         * GtkLauncher/main.c:
1617         (parseOptionEntryCallback): Make this function static. Also use
1618         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
1619         of atoi/atof to provide better error messages. And always fill the
1620         error struct when the function fails.
1621         (getOptionEntriesFromWebKitWebSettings): Use an array of
1622         GOptionEntry structs instead of a GArray, since that is what
1623         g_option_group_add_entries() expects and the array size doesn't
1624         change.
1625         (addWebSettingsGroupToContext): Helper function to add the
1626         websettings group to the option context.
1627         (main): Create the option context to parse command line arguments.
1628
1629 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
1630
1631         Reviewed by Adam Roben.
1632
1633         [GTK] Implement pixel dump support for WebKitTestRunner
1634         https://bugs.webkit.org/show_bug.cgi?id=58242
1635
1636         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
1637         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
1638         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
1639         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
1640         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
1641         file so that we can share it across platforms.
1642         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
1643         * WebKitTestRunner/TestInvocation.h: Updated method list.
1644         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
1645         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1646         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
1647
1648 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
1649
1650         Unreviewed, rolling out r89414.
1651         http://trac.webkit.org/changeset/89414
1652         https://bugs.webkit.org/show_bug.cgi?id=63130
1653
1654         It broke webkitpy tests (Requested by Ossy on #webkit).
1655
1656         * Scripts/webkitpy/layout_tests/port/base.py:
1657
1658 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1659
1660         Reviewed by Dirk Pranke.
1661
1662         [NRWT] Print error message when there is no httpd present on the system
1663         https://bugs.webkit.org/show_bug.cgi?id=62027
1664
1665         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1666
1667 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
1668
1669         Unreviewed, build fix.
1670         Fix crashes in new-run-webkit-tests resulting from the
1671         change to the http_server logic in r89400. Python 2.5
1672         on Mac 10.5 has some weird error paths.
1673
1674         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1675         * Scripts/webkitpy/common/system/executive.py:
1676
1677 2011-06-21  MORITA Hajime  <morrita@google.com>
1678
1679         Unreviewed, rolling out r89401 and r89403.
1680         http://trac.webkit.org/changeset/89401
1681         http://trac.webkit.org/changeset/89403
1682         https://bugs.webkit.org/show_bug.cgi?id=62970
1683
1684         Breaks mac build and mistakenly enables the spellcheck API
1685
1686         * Scripts/build-webkit:
1687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1688
1689 2011-06-21  Kent Tamura  <tkent@chromium.org>
1690
1691         [Mac] Sort Xcode project files.
1692
1693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1694
1695 2011-06-20  MORITA Hajime  <morrita@google.com>
1696
1697         Reviewed by Kent Tamura.
1698
1699         Spellcheck API should be build-able.
1700         https://bugs.webkit.org/show_bug.cgi?id=62970
1701
1702         * Scripts/build-webkit:
1703
1704 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
1705
1706         Reviewed by Tony Chang.
1707
1708         nrwt: attempt #3 at fixing server startup/shutdown
1709         https://bugs.webkit.org/show_bug.cgi?id=62829
1710
1711         Attempt yet again to make starting and stopping servers
1712         reliable. It turns out that apache has races between when the
1713         ctl process exists and when it writes/removes the pid file.
1714         This change accounts for the races.
1715
1716         * Scripts/new-run-webkit-httpd:
1717         * Scripts/webkitpy/common/system/executive.py:
1718         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1719         * Scripts/webkitpy/layout_tests/port/base.py:
1720         * Scripts/webkitpy/layout_tests/port/http_server.py:
1721         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1722         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1723         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1724         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1725
1726 2011-06-21  Dmitry Lomov  <dslomov@google.com>
1727
1728         Reviewed by Adam Roben.
1729
1730         https://bugs.webkit.org/show_bug.cgi?id=63080
1731         Unit-tests step on test-only bot is broken.
1732         Removing the step until run-api-tests is fixed.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1735
1736 2011-06-20  Dmitry Lomov  <dslomov@google.com>
1737
1738         Reviewed by David Levin.
1739
1740         https://bugs.webkit.org/show_bug.cgi?id=63017
1741         "Unit tests" step on bots should provide more information in case of failure.
1742
1743         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
1744
1745 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1746
1747         Reviewed by Ojan Vafai.
1748
1749         new-run-webkit-tests: order shards by name, not number of tests
1750         https://bugs.webkit.org/show_bug.cgi?id=62753
1751
1752         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1753
1754 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1755
1756         Reviewed by Ojan Vafai.
1757
1758         we should only log the test names to the tests_run.txt files during layout_tests
1759         https://bugs.webkit.org/show_bug.cgi?id=62751
1760
1761         * Scripts/old-run-webkit-tests:
1762         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1763
1764 2011-06-20  Eric Seidel  <eric@webkit.org>
1765
1766         Reviewed by Adam Barth.
1767
1768         commit-queue/ews-bots should run run-bindings-tests for every patch
1769         https://bugs.webkit.org/show_bug.cgi?id=63010
1770
1771         * Scripts/webkitpy/common/config/ports.py:
1772         * Scripts/webkitpy/tool/commands/download_unittest.py:
1773         * Scripts/webkitpy/tool/steps/runtests.py:
1774         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1775         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1776
1777 2011-06-20  Chang Shu  <cshu@webkit.org>
1778
1779         Reviewed by Adam Barth.
1780
1781         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
1782         https://bugs.webkit.org/show_bug.cgi?id=53676
1783
1784         * WebKitTestRunner/TestController.cpp:
1785         (WTR::TestController::initialize):
1786
1787 2011-06-20  Eric Seidel  <eric@webkit.org>
1788
1789         Reviewed by Adam Barth.
1790
1791         buildbots should run run-bindings-tests
1792         https://bugs.webkit.org/show_bug.cgi?id=63001
1793
1794         run-bindings-tests takes 2.4 seconds on my machine, so
1795         I expect this will not be noticeable on the bots.
1796
1797         I also removed tiger-specific checks since Tiger is no
1798         longer a supported platform for webkit.
1799
1800         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1801
1802 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         Unreviewed. Fix WebKit2 GTK build after r89249.
1805
1806         * GtkLauncher/main.c:
1807         (main):
1808
1809 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
1810
1811         Reviewed by Yury Semikhatsky.
1812
1813         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
1814         https://bugs.webkit.org/show_bug.cgi?id=62994
1815
1816         * DumpRenderTree/LayoutTestController.cpp:
1817         (closeWebInspectorCallback):
1818         (LayoutTestController::staticFunctions):
1819         * DumpRenderTree/LayoutTestController.h:
1820         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1821         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1822         * DumpRenderTree/chromium/LayoutTestController.cpp:
1823         (LayoutTestController::LayoutTestController):
1824         * DumpRenderTree/chromium/LayoutTestController.h:
1825         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1826         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1827         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1828         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1829         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1830         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1831         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1832         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1833         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1834
1835 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
1836
1837         Reviewed by Martin Robinson.
1838
1839         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
1840         https://bugs.webkit.org/show_bug.cgi?id=55308
1841
1842         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
1843         (parseOptionEntryCallback): Callback for parsing option entry.
1844         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
1845         list of option entries.
1846         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
1847         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
1848         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
1849         (parseAdditionalOptions): Help function parsing additional commandline options.
1850         (main): Added call to parseAdditionalOptions.
1851
1852 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1853
1854         Reviewed by Andreas Kling.
1855
1856         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
1857         https://bugs.webkit.org/show_bug.cgi?id=62869
1858
1859         Add QFont include to fix "incomlete type QFont" error.
1860
1861         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1862
1863 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1864
1865         Reviewed by Martin Robinson.
1866
1867         [GTK] Enable Media Stream feature and make it default on
1868         https://bugs.webkit.org/show_bug.cgi?id=60394
1869
1870         * Scripts/build-webkit:
1871
1872 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1873
1874         Unreviewed, rolling out r89198.
1875         http://trac.webkit.org/changeset/89198
1876         https://bugs.webkit.org/show_bug.cgi?id=62953
1877
1878         Chromium breakage on "Linux Tests" (Requested by senorblanco
1879         on #webkit).
1880
1881         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1882         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1883         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1884
1885 2011-06-18  Daniel Bates  <dbates@webkit.org>
1886
1887         Reviewed by Eric Seidel.
1888
1889         Git.push_local_commits_to_server() should use passed username and
1890         password when we don't have cached credentials
1891         https://bugs.webkit.org/show_bug.cgi?id=62941
1892
1893         Fixes a issue where Git.push_local_commits_to_server() would always look
1894         for cached credentials regardless of whether a username and password
1895         were passed as arguments. Instead, if given both a username and password
1896         then we shouldn't look for cached credentials (since we were explicitly given
1897         credentials).
1898
1899         * Scripts/webkitpy/common/checkout/scm/git.py:
1900         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
1901
1902 2011-06-18  Daniel Bates  <dbates@rim.com>
1903
1904         Rubber-stamped by Eric Seidel.
1905
1906         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1907         https://bugs.webkit.org/show_bug.cgi?id=62767
1908
1909         Part 3 of 3
1910
1911         Remove the command-line option --skip-build now that the master BuildBot has been restarted
1912         following <http://trac.webkit.org/changeset/89138>.
1913
1914         Instead, specify --no-build to get analogous functionality.
1915
1916         * Scripts/run-javascriptcore-tests:
1917
1918 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
1919
1920         Reviewed by Tony Chang.
1921
1922         new-run-webkit-tests: fix test sorting
1923         https://bugs.webkit.org/show_bug.cgi?id=58691
1924
1925         This changes the sorting to use a "natural" sort order such that
1926         foo2.html sorts before foo13.html, and sorts the tests so
1927         that all the tests in a directory are run before any test in a
1928         subdirectory.
1929
1930         This change also adds a split() method to the filesystem since
1931         that is needed to cluster files into a directory otherwise.
1932
1933         * Scripts/webkitpy/common/system/filesystem.py:
1934         * Scripts/webkitpy/common/system/filesystem_mock.py:
1935         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1936         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1937
1938 2011-06-18  Evan Martin  <evan@chromium.org>
1939
1940         Reviewed by Darin Adler.
1941
1942         Compiler warning in double->int conversion in TestNetscapePlugIn
1943         https://bugs.webkit.org/show_bug.cgi?id=51554
1944
1945         This code is providing a JS API for removing a property by numeric ID.
1946         We get it from JS as a double, and must convert it to an int before using it.
1947
1948         Test: LayoutTests/plugins/npruntime/remove-property.html
1949
1950         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1951         (NPRuntimeRemoveProperty::TestObject::invoke):
1952
1953 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
1954
1955         Reviewed by Eric Seidel.
1956
1957         Don't exit webkit-patch when running on Win32 python
1958         https://bugs.webkit.org/show_bug.cgi?id=55811
1959
1960         Most of the basic actions work in the meantime,
1961         so let people play with in on Win32 now.
1962
1963         * Scripts/webkit-patch:
1964
1965 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
1966
1967         Reviewed by Ojan Vafai.
1968
1969         Convert json_results_generator.py to output version 4 JSON.
1970         https://bugs.webkit.org/show_bug.cgi?id=60869
1971
1972         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1973         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1974         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1975
1976 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
1977
1978         Reviewed by Eric Seidel.
1979
1980         Some names with spaces are incorrectly reported as not containing spaces
1981         while running prepare-ChangeLog
1982         https://bugs.webkit.org/show_bug.cgi?id=55572
1983
1984         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
1985           non-alphanumeric characters in names.
1986
1987 2011-06-18  Michael Saboff  <msaboff@apple.com>
1988
1989         Reviewed by Eric Seidel.
1990
1991         Enhancement: New Script to Format malloc_history output as tree
1992         https://bugs.webkit.org/show_bug.cgi?id=56378
1993
1994         New script to process malloc_history output to tree format.
1995
1996         * Scripts/malloc-tree: Added.
1997
1998 2011-06-17  Dmitry Lomov  <dslomov@google.com>
1999
2000         Reviewed by Daniel Bates.
2001
2002         https://bugs.webkit.org/show_bug.cgi?id=62918 
2003         Pass configuration to UnitTests step in master.cfg
2004
2005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2006
2007 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
2008
2009         Reviewed by Eric Seidel.
2010
2011         [EFL] Add Evas-based ImageDiff implementation.
2012         https://bugs.webkit.org/show_bug.cgi?id=61942
2013
2014         Build system changes will be performed as soon as the complete
2015         DumpRenderTree implementation is upstreamed.
2016
2017         * DumpRenderTree/efl/ImageDiff.cpp: Added.
2018         (pixelFromImageData):
2019         (differenceImageFromDifferenceBuffer):
2020         (computeDistanceBetweenPixelComponents):
2021         (calculatePixelDifference):
2022         (calculateDifference):
2023         (getTemporaryFile):
2024         (printImage):
2025         (printImageDifferences):
2026         (resizeEcoreEvasIfNeeded):
2027         (readImageFromStdin):
2028         (parseCommandLineOptions):
2029         (shutdownEfl):
2030         (abortWithErrorMessage):
2031         (initEfl):
2032         (main):
2033
2034 2011-06-17  Tony Chang  <tony@chromium.org>
2035
2036         Reviewed by Dirk Pranke.
2037
2038         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
2039         https://bugs.webkit.org/show_bug.cgi?id=62907
2040
2041         This fixes a bug where the ImageDiff on the user's machine doesn't
2042         match the logic used on the Chromium buildbots.  This has the downside
2043         of requiring that the Chromium ImageDiff is built, but it turns out
2044         that even with --tolerance 0, the CG ImageDiff will allow small pixel
2045         differences through.
2046
2047         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2048
2049 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2050
2051         [WinCairo] Unreviewed build correction.
2052
2053         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
2054         Update WinCairo property sheet to link against the Cairo DLL,
2055         now that we are using a more recent Cairo build. 
2056
2057 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2058
2059         Reviewed by Brian Weinstein.
2060
2061         Create a simple example of using the COM-based C++ listeners.
2062         A new onclick event is attached (via C++) to the WebKit logo
2063         in the default test pattern displayed on startup.  Clicking on
2064         the logo causes a message box to be displayed.
2065         https://bugs.webkit.org/show_bug.cgi?id=61885
2066
2067         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
2068           the WebScriptObject and DOMEventListener.
2069         * WinLauncher/WinLauncher.cpp:
2070         (SimpleEventListener::SimpleEventListener): Example implementation
2071           of a simple DOM event listener.
2072         (SimpleEventListener::handleEvent): 
2073         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
2074          to bind a C++ method to the 'onclick' event for the WebKit logo.
2075         (_tWinMain):
2076         * WinLauncher/WinLauncher.h:
2077         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
2078
2079 2011-06-17  Chang Shu  <cshu@webkit.org>
2080
2081         Reviewed by Andreas Kling.
2082
2083         [Qt] [WK2] Support undo/redo in MiniBrowser
2084         https://bugs.webkit.org/show_bug.cgi?id=62809
2085
2086         * MiniBrowser/qt/BrowserWindow.cpp:
2087         (BrowserWindow::BrowserWindow):
2088
2089 2011-06-17  Daniel Bates  <dbates@rim.com>
2090
2091         Rubber-stamped by Eric Seidel.
2092
2093         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2094         https://bugs.webkit.org/show_bug.cgi?id=62767
2095
2096         Part 2 of 3
2097
2098         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
2099         command line option instead of --skip-build.
2100
2101         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
2102         master buildbot picks up the change.
2103
2104         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2105
2106 2011-06-17  Daniel Bates  <dbates@rim.com>
2107
2108         Rubber-stamped by Eric Seidel.
2109
2110         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2111         https://bugs.webkit.org/show_bug.cgi?id=62767
2112
2113         Part 1 of 3
2114
2115         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
2116         run-javascriptcore-tests. Also, add a remark about these options to the usage message
2117         printed by run-javascriptcore-tests.
2118
2119         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
2120
2121         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
2122           of $showHelp.
2123
2124 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
2125
2126         Reviewed by Martin Robinson.
2127
2128         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
2129         https://bugs.webkit.org/show_bug.cgi?id=60687
2130
2131         Replace GdkRectangle by cairo_rectangle_int_t.
2132
2133         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
2134         (createBitmapContextFromWebView):
2135         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
2136         (firstRectForCharacterRangeCallback):
2137
2138 2011-06-16  Dmitry Lomov  <dslomov@google.com>
2139
2140         Reviewed by David Levin.
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=62603
2143         Run run-api-tests on bots in debug mode.
2144         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
2145
2146         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2147
2148 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
2149
2150         Reviewed by Eric Seidel.
2151
2152         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
2153         WorkQueueItem.
2154         They will be plugged into the build system once the EFL's DRT is
2155         fully upstreamed.
2156         https://bugs.webkit.org/show_bug.cgi?id=61958
2157
2158         * DumpRenderTree/efl: Added.
2159         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
2160         (GCController::collect):
2161         (GCController::collectOnAlternateThread):
2162         (GCController::getJSObjectCount):
2163         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
2164         (createBitmapContextFromWebView):
2165         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
2166         (LoadItem::invoke):
2167         (LoadHTMLStringItem::invoke):
2168         (ReloadItem::invoke):
2169         (ScriptItem::invoke):
2170         (BackForwardItem::invoke):
2171         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
2172         (WorkQueueItem::~WorkQueueItem):
2173         (LoadItem::LoadItem):
2174         (LoadHTMLStringItem::LoadHTMLStringItem):
2175         (ScriptItem::ScriptItem):
2176         (LoadingScriptItem::LoadingScriptItem):
2177         (LoadingScriptItem::invoke):
2178         (NonLoadingScriptItem::NonLoadingScriptItem):
2179         (NonLoadingScriptItem::invoke):
2180         (BackForwardItem::BackForwardItem):
2181         (BackItem::BackItem):
2182         (ForwardItem::ForwardItem):
2183
2184 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2185
2186         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
2187         preference like the perl scripts do.
2188
2189         * waf/build/build_utils.py:
2190         * waf/build/settings.py:
2191
2192 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
2193
2194         Reviewed by Tony Gentilcore.
2195
2196         MediaStream API: Runtime enabled features
2197         https://bugs.webkit.org/show_bug.cgi?id=62798
2198
2199         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
2200
2201         * DumpRenderTree/chromium/TestShell.cpp:
2202         (TestShell::TestShell):
2203
2204 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
2205
2206         Reviewed by Eric Seidel.
2207
2208         Add support for sys.platform == 'linux3' by relaxing
2209         conditional statements and/or extending lookup dicts.
2210         This way, Linux kernels >=3.0-rc1 get supported in the
2211         build process.
2212         https://bugs.webkit.org/show_bug.cgi?id=62730
2213
2214         * Scripts/webkitpy/common/system/executive.py:
2215         * Scripts/webkitpy/common/system/file_lock.py:
2216         * Scripts/webkitpy/common/system/path_unittest.py:
2217         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2218         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2219         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2220         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2221         * Scripts/webkitpy/layout_tests/port/factory.py:
2222         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2223         * Scripts/webkitpy/layout_tests/port/qt.py:
2224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2225
2226 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2227
2228         Unreviewed, rolling out r88796.
2229         http://trac.webkit.org/changeset/88796
2230         https://bugs.webkit.org/show_bug.cgi?id=62790
2231
2232         It made fast/dom/nodesFromRect-basic.html time out on Qt,
2233         64-bit, debug mode (Requested by Ossy on #webkit).
2234
2235         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2236         (LayoutTestController::nodesFromRect):
2237         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2238         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2239         (PlainTextController::plainText):
2240         * DumpRenderTree/qt/PlainTextControllerQt.h:
2241
2242 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2243
2244         Unreviewed, build fix.
2245
2246         Revert the patches in r88995 and r88999; the http servers don't
2247         seem to be shutting down reliably.
2248
2249         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2250         * Scripts/webkitpy/layout_tests/port/base.py:
2251         * Scripts/webkitpy/layout_tests/port/http_server.py:
2252         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2253         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2254         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2255         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2256
2257 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2258
2259         Unreviewed, build fix.
2260
2261         Add some debugging messages to triage problems introduced in
2262         r88995.
2263
2264         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2265
2266 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2267
2268         Reviewed by Tony Chang.
2269
2270         nrwt: should clean up stale server processes from a previous run
2271         https://bugs.webkit.org/show_bug.cgi?id=62615
2272
2273         This change fixes cases where NRWT might start a server and then
2274         exit, leaving the server still running. Now NRWT should detect
2275         this case and clean up on the next run, without shutting down
2276         any processes it didn't start.
2277
2278         This change also fixes a bug in executive.kill_process on UNIX
2279         where zombies weren't being handled properly.
2280
2281         * Scripts/webkitpy/common/system/executive.py:
2282         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2283         * Scripts/webkitpy/layout_tests/port/base.py:
2284         * Scripts/webkitpy/layout_tests/port/http_server.py:
2285         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2286         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2287         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2288
2289 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2290
2291         Reviewed by Tony Chang.
2292
2293         nrwt: fix http, websocket server startup, shutdown
2294         https://bugs.webkit.org/show_bug.cgi?id=62180
2295
2296         This change refactors all of the server-related code to
2297         have consistent semantics. It pushes the start()/stop()
2298         logic into the base class and adds four much smaller routines
2299         for specialization:
2300         _prepare_config() - for optionally writing config files etc.
2301             to disk prior to starting the server
2302         _remove_stale_log_files()
2303         _spawn_process() - the actual launch of the subprocess
2304         _cleanup_after_stop() - and custom cleanup code
2305
2306         Prior to this change the three server implementations were
2307         fairly inconsistent, leading to lots of weirdness on the bots
2308         with servers being left around, etc.
2309
2310         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2311         * Scripts/webkitpy/layout_tests/port/http_server.py:
2312         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2313         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2314
2315 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2316
2317         Reviewed by Tony Chang.
2318
2319         webkitpy: clean up code prior to functional changes for server startup/shutdown
2320         https://bugs.webkit.org/show_bug.cgi?id=62256
2321
2322         This patch does a bunch of minor cleanup of the code, but there
2323         should be no functional changes except that all of the modules
2324         will now use the same exception type. Other changes include
2325         removing unused code paths and functions, pushing 'name' and
2326         'pid_file' into the base class of the server objects, and using
2327         the Filesystem object instead of the codecs, tempfile, and
2328         shutils modules.
2329
2330         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2331         * Scripts/webkitpy/layout_tests/port/http_server.py:
2332         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2333         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2334
2335 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2336
2337         Reviewed by Tony Chang.
2338
2339         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2340         https://bugs.webkit.org/show_bug.cgi?id=62251
2341
2342         shut_down_http_server() was a total hack that was only used by
2343         new-run-webkit-httpd, so I've moved the code there and switched
2344         to using executive.kill_process() for the common case. The
2345         method itself will be removed in the patch on bug 59993.
2346
2347         * Scripts/new-run-webkit-httpd:
2348         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2349         * Scripts/webkitpy/layout_tests/port/http_server.py:
2350         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2351         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2352
2353 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2354
2355         Unreviewed, build fix.
2356
2357         Fix test-webkitpy failure introduced in r88986.
2358
2359         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2360
2361 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2362
2363         Reviewed by Eric Seidel.
2364
2365         NRWT: doesn't support webarchives, has stale skipping logic.
2366         https://bugs.webkit.org/show_bug.cgi?id=58293
2367
2368         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2369         * Scripts/webkitpy/layout_tests/port/base.py:
2370         * Scripts/webkitpy/layout_tests/port/webkit.py:
2371
2372 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
2373
2374         Change my email to @webkit.org
2375
2376         * Scripts/webkitpy/common/config/committers.py:
2377
2378 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
2379
2380         Reviewed by David Hyatt.
2381
2382         CSS 2.1: Support replaced elements with relative intrinsic sizes
2383         https://bugs.webkit.org/show_bug.cgi?id=15849
2384
2385         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
2386         https://bugs.webkit.org/show_bug.cgi?id=53099
2387
2388         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
2389
2390         * Scripts/old-run-webkit-tests:
2391         * Scripts/webkitpy/layout_tests/port/test_files.py:
2392
2393 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2394
2395         Reviewed by Martin Robinson.
2396
2397         [GTK] Add a statusbar to MiniBrowser
2398         https://bugs.webkit.org/show_bug.cgi?id=62634
2399
2400         It shows the url of the current hovered link.
2401
2402         * MiniBrowser/gtk/BrowserWindow.c:
2403         (browserWindowConstructed): Create the GtkSatusbar.
2404         (mouseDidMoveOverElement): Update statusbar text.
2405         (browserWindowUIClientInit): Add implementation for
2406         mouseDidMoveOverElement().
2407         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
2408         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
2409         (mouseDidMoveOverElement): Pass the url of the current hovered
2410         link to the UI process.
2411         (didCreatePage): Set the UI client adding an implementation for
2412         mouseDidMoveOverElement().
2413         (WKBundleInitialize):
2414         * MiniBrowser/gtk/main.c:
2415         (createWKContextWithInjectedBundle): Create a global context with
2416         the injected bundle.
2417         (loadURI): Use the global context.
2418         (main):
2419
2420 2011-06-14  Lucas Forschler  <lforschler@apple.com>
2421
2422         Reviewed by Stephanie Lewis.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=62495
2425         Bug 62495 - combine windows and mac kill-old-processes script
2426         Add a platform agnostic script.  Remove the recently added mac flavor.
2427         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
2428         
2429         * BuildSlaveSupport/kill-old-processes: Added.
2430         * BuildSlaveSupport/mac: Removed.
2431         * BuildSlaveSupport/mac/kill-old-processes: Removed.
2432
2433 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
2434
2435         Reviewed by Tony Chang.
2436
2437         nrwt: handle worker exceptions cleanly
2438         https://bugs.webkit.org/show_bug.cgi?id=62614
2439
2440         This change modifiers new-run-webkit-tests to handle exceptions
2441         raised by worker threads better, by:
2442         - capturing the worker's stack and logging it in the manager
2443         - propagating the worker's exception in the caller correctly
2444         - attempting to cancel the workers and clean up even when
2445           we get an unexpected exception
2446
2447         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2448         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2450         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2451
2452 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2453
2454         Reviewed by Laszlo Gombos.
2455
2456         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
2457         https://bugs.webkit.org/show_bug.cgi?id=62227
2458
2459         QtWebkit does not yet support different CacheModels. This change will 
2460         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
2461
2462         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2463         (LayoutTestController::setCacheModel):
2464         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2465
2466 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2467
2468         Reviewed by Andreas Kling.
2469
2470         [Qt] tst_QWebFrame::overloadedSlots() fails
2471         https://bugs.webkit.org/show_bug.cgi?id=37319
2472
2473         Since we don't implictly convert 'document' object to QWebElement
2474         in metacalls anymore, change the controller to expect QVariantMap instead.
2475
2476         The method plainText() was updated to use QVariantMap as well to let the bridge
2477         do the conversion directly for us.
2478
2479         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2480         (LayoutTestController::nodesFromRect):
2481         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2482         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2483         (PlainTextController::plainText):
2484         * DumpRenderTree/qt/PlainTextControllerQt.h:
2485
2486 2011-06-14  Andras Becsi  <abecsi@webkit.org>
2487
2488         Reviewed by Csaba Osztrogonác.
2489
2490         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
2491         https://bugs.webkit.org/show_bug.cgi?id=62630
2492
2493         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2494         (NPP_New): remove dead variable 'forceCarbon'
2495
2496 2011-06-13  Hayato Ito  <hayato@chromium.org>
2497
2498         Reviewed by Ojan Vafai.
2499
2500         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
2501         https://bugs.webkit.org/show_bug.cgi?id=59188
2502
2503         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
2504         WebKitDriver should always return an actual hash value if DRT returns that.
2505
2506         No tests since I'll add sample reftests to make sure mismatch reftests work later,
2507         which should be in a separate patch.
2508
2509         * Scripts/webkitpy/layout_tests/port/webkit.py:
2510
2511 2011-06-13  Kent Tamura  <tkent@chromium.org>
2512
2513         [Chromium-win] Fix two wrong assertions exposed by r88757.
2514
2515         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2516         (WebThemeEngineDRTWin::paintTrackbar):
2517
2518 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
2519
2520         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
2521         and commit queue happy.
2522
2523         * Scripts/webkitpy/common/config/committers.py:
2524
2525 2011-06-13  Chris Rogers  <crogers@google.com>
2526
2527         Unreviewed build fix.
2528
2529         Build fix to chromium DRT until we can rebaseline some tests
2530         https://bugs.webkit.org/show_bug.cgi?id=62608
2531
2532         * DumpRenderTree/chromium/TestShell.cpp:
2533         (TestShell::TestShell):
2534
2535 2011-06-13  Chris Rogers  <crogers@google.com>
2536
2537         Reviewed by Dirk Pranke.
2538
2539         Add Web Audio support to chromium DRT
2540         https://bugs.webkit.org/show_bug.cgi?id=62306
2541
2542         * DumpRenderTree/chromium/LayoutTestController.cpp:
2543         (LayoutTestController::LayoutTestController):
2544         (LayoutTestController::reset):
2545         (LayoutTestController::setEncodedAudioData):
2546         * DumpRenderTree/chromium/LayoutTestController.h:
2547         (LayoutTestController::encodedAudioData):
2548         (LayoutTestController::shouldDumpAsAudio):
2549         (LayoutTestController::setShouldDumpAsAudio):
2550         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2551         (DRTPrinter::handleAudioHeader):
2552         (TestShellPrinter::handleAudioHeader):
2553         * DumpRenderTree/chromium/TestEventPrinter.h:
2554         * DumpRenderTree/chromium/TestShell.cpp:
2555         (TestShell::TestShell):
2556         (TestShell::dump):
2557
2558 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2559
2560         Reviewed by Eric Seidel.
2561
2562         [EFL] Add load error handler to EWebLauncher
2563         https://bugs.webkit.org/show_bug.cgi?id=62347
2564
2565         Add a handler function of "load,error" to EWebLauncher.
2566         EWebLauncher now displays a simple error page on load errors.
2567
2568         * EWebLauncher/main.c:
2569         (on_load_error):
2570         (browserCreate):
2571
2572 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
2573
2574         Reviewed by Eric Seidel.
2575
2576         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2577         https://bugs.webkit.org/show_bug.cgi?id=62385
2578
2579         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2580         of this code makes keeping it in sync much more difficult. The files are
2581         almost identical and this change ports the X11 changes to main.cpp.
2582
2583         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2584         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
2585         some results on Qt and this seems to be unnecessary for the moment.
2586         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2587         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2588         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2589         it should not be in the results.
2590         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
2591         XP_UNIX block is first by guarding against using a null instance.
2592         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
2593         the XP_UNIX define for Linux.
2594         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2595         * GNUmakefile.am: Update source list.
2596
2597 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2598
2599         Unreviewed, rolling out r88671.
2600         http://trac.webkit.org/changeset/88671
2601         https://bugs.webkit.org/show_bug.cgi?id=62591
2602
2603         "didn't work" (Requested by dpranke on #webkit).
2604
2605         * Scripts/new-run-webkit-httpd:
2606         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2607         * Scripts/webkitpy/layout_tests/port/http_server.py:
2608         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2609         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2610         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2611         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2612
2613 2011-06-13  Nate Chapin  <japhet@chromium.org>
2614
2615         Reviewed by Darin Fisher.
2616
2617         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
2618
2619         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2620
2621 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
2622
2623         Reviewed by Tony Chang.
2624
2625         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2626         https://bugs.webkit.org/show_bug.cgi?id=62251
2627
2628         shut_down_http_server() was a total hack that was only used by
2629         new-run-webkit-httpd, so I've moved the code there and switched
2630         to using executive.kill_process() for the common case. The
2631         method itself will be removed in the patch on bug 59993.
2632
2633         * Scripts/new-run-webkit-httpd:
2634         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2635         * Scripts/webkitpy/layout_tests/port/http_server.py:
2636         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2637         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2638
2639 2011-06-13  Tony Chang  <tony@chromium.org>
2640
2641         Reviewed by Dimitri Glazkov.
2642
2643         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
2644         https://bugs.webkit.org/show_bug.cgi?id=62578
2645
2646         * Scripts/build-webkit:
2647
2648 2011-06-13  Tony Chang  <tony@chromium.org>
2649
2650         Reviewed by Adam Barth.
2651
2652         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
2653         https://bugs.webkit.org/show_bug.cgi?id=62545
2654
2655         * Scripts/build-webkit:
2656
2657 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2658
2659         Reviewed by Martin Robinson.
2660
2661         [GTK] Export an API similar to WebKit1
2662         https://bugs.webkit.org/show_bug.cgi?id=57820
2663
2664         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
2665         code, but linking to libwebkit2gtk.
2666
2667         * GNUmakefile.am:
2668         * GtkLauncher/main.c:
2669         (createBrowser):
2670         (main):
2671
2672 2011-06-12  MORITA Hajime  <morrita@google.com>
2673
2674         Unreviewed, rolling out r88625.
2675         http://trac.webkit.org/changeset/88625
2676         https://bugs.webkit.org/show_bug.cgi?id=61073
2677
2678         Breaks SL Webkit2 Tests
2679
2680         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
2681         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2682         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
2683         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2684         (WTR::InjectedBundlePage::didClearWindowForFrame):
2685         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2686
2687 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2688
2689         Reviewed by Antonio Gomes.
2690
2691         [Qt] LayoutTestController needs setTextDirection implementation
2692         https://bugs.webkit.org/show_bug.cgi?id=62442
2693
2694         Implements LayoutController.setTextDirection.
2695
2696         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2697         (LayoutTestController::setTextDirection):
2698         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2699
2700 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
2701
2702         Reviewed by Hajime Morita.
2703
2704         Add window.internals to WebKit2's WebKitTestRunner.
2705         https://bugs.webkit.org/show_bug.cgi?id=61073
2706
2707         Test: fast/harness/internals-object.html
2708
2709         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
2710         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2711         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
2712         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2713         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
2714         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2715
2716 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2717
2718         Unreviewed, rolling out r88616.
2719         http://trac.webkit.org/changeset/88616
2720         https://bugs.webkit.org/show_bug.cgi?id=62517
2721
2722         It broke editing/text-iterator/findString.html (Requested by
2723         tonikitoo on #webkit).
2724
2725         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2726         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2727
2728 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2729
2730         Reviewed by Antonio Gomes.
2731
2732         [Qt] LayoutTestController needs setTextDirection implementation
2733         https://bugs.webkit.org/show_bug.cgi?id=62442
2734
2735         Implements LayoutController.setTextDirection.
2736
2737         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2738         (LayoutTestController::setTextDirection):
2739         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2740
2741 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2742
2743         Reviewed by Ojan Vafai.
2744
2745         new-run-webkit-tests: 'images' links on results.html don't work
2746         https://bugs.webkit.org/show_bug.cgi?id=62194
2747
2748         Use relative path when generating images-diffs.html
2749
2750         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2751         Added _output_testname.
2752
2753 2011-06-10  Lucas Forschler  <lforschler@apple.com>
2754
2755         Reviewed by Stephanie Lewis.
2756
2757         Script to kill old processes on Mac.
2758         This matches the windows version.
2759         https://bugs.webkit.org/show_bug.cgi?id=62479  
2760         
2761         * BuildSlaveSupport/mac: Added.
2762         * BuildSlaveSupport/mac/kill-old-processes: Added.
2763
2764 2011-06-10  Adam Barth  <abarth@webkit.org>
2765
2766         Reviewed by James Robinson.
2767
2768         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
2769         https://bugs.webkit.org/show_bug.cgi?id=62489
2770
2771         * Scripts/webkitpy/tool/bot/sheriff.py:
2772         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2773
2774 2011-06-10  Tony Chang  <tony@chromium.org>
2775
2776         Reviewed by Ojan Vafai.
2777
2778         add a compile guard ENABLE(FLEXBOX)
2779         https://bugs.webkit.org/show_bug.cgi?id=62049
2780
2781         * Scripts/build-webkit:
2782
2783 2011-06-10  Mark Rowe  <mrowe@apple.com>
2784
2785         Reviewed by Dimitri Glazkov.
2786
2787         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
2788
2789         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
2790         header file.
2791
2792         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2793         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2794
2795 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
2796
2797         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
2798
2799         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2800         (handleEventX11):
2801         (NPP_GetValue):
2802         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2803         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
2804         (webkit_test_plugin_new_instance):
2805         (webkit_test_plugin_destroy_instance):
2806         (webkit_test_plugin_set_window):
2807         (executeScript):
2808         (webkit_test_plugin_new_stream):
2809         (webkit_test_plugin_destroy_stream):
2810         (webkit_test_plugin_stream_as_file):
2811         (webkit_test_plugin_write_ready):
2812         (webkit_test_plugin_write):
2813         (webkit_test_plugin_print):
2814         (keyEventToChar):
2815         (webkit_test_plugin_handle_event):
2816         (webkit_test_plugin_url_notify):
2817         (webkit_test_plugin_get_value):
2818         (webkit_test_plugin_set_value):
2819         (NP_GetMIMEDescription):
2820         (NP_Initialize):
2821         (NP_Shutdown):
2822         (NP_GetValue):
2823         * GNUmakefile.am:
2824
2825 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2826
2827         Reviewed by Eric Seidel.
2828
2829         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
2830         https://bugs.webkit.org/show_bug.cgi?id=55603
2831
2832         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
2833         TextInputController support.
2834
2835         * DumpRenderTree/gtk/TextInputController.cpp:
2836         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
2837         of start and end. This matches the other ports. Do not use GLib style early returns.
2838         (hasMarkedTextCallback): Added.
2839         (markedRangeCallback): Added.
2840         (insertTextCallback): Cleanup as described above.
2841         (unmarkTextCallback): Cleanup as described above.
2842         (firstRectForCharacterRangeCallback): Cleanup as described above.
2843         (selectedRangeCallback): Cleanup as described above.
2844
2845 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
2846
2847         Reviewed by Tony Chang.
2848
2849         nrwt: support webaudio in chromium driver
2850         https://bugs.webkit.org/show_bug.cgi?id=62226
2851
2852         * Scripts/webkitpy/layout_tests/port/chromium.py:
2853
2854 2011-06-09  Dan Bernstein  <mitz@apple.com>
2855
2856         Reviewed by Anders Carlsson.
2857
2858         Added a test for Vector::reverse()
2859         https://bugs.webkit.org/show_bug.cgi?id=62393
2860
2861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2862         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
2863         (TestWebKitAPI::TEST):
2864         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2865
2866 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2867
2868         Reviewed by Andreas Kling.
2869
2870         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2871         https://bugs.webkit.org/show_bug.cgi?id=62385
2872
2873         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2874         of this code makes keeping it in sync much more difficult. The files are
2875         almost identical and this change ports the X11 changes to main.cpp.
2876
2877         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2878         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2879         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2880         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2881         it should not be in the results.
2882         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
2883         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
2884         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2885         * GNUmakefile.am: Update source list.
2886
2887 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
2888
2889         Reviewed by Tony Chang.
2890
2891         Test plugin should support event logging on the windows port.
2892         https://bugs.webkit.org/show_bug.cgi?id=61721
2893
2894         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
2895         calls to mean the plugin handled the event.
2896
2897         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2898         (handleEventWin): Return 0 for each event on windows.
2899
2900 2011-06-09  Chang Shu  <cshu@webkit.org>
2901
2902         Reviewed by Andreas Kling.
2903
2904         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
2905         https://bugs.webkit.org/show_bug.cgi?id=62381
2906
2907         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
2908         QWKPagePrivate::isViewFocused() will check it later.
2909
2910         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2911         (WTR::PlatformWebView::PlatformWebView):
2912
2913 2011-06-09  Robert Hogan  <robert@webkit.org>
2914
2915         Reviewed by Andreas Kling.
2916
2917         Teach Qt about window.internals
2918         https://bugs.webkit.org/show_bug.cgi?id=61074
2919
2920         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2921         (WebCore::DumpRenderTree::initJSObjects):
2922
2923 2011-06-09  Eric Seidel  <eric@webkit.org>
2924
2925         Reviewed by Adam Barth.
2926
2927         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
2928         https://bugs.webkit.org/show_bug.cgi?id=62362
2929
2930         The mac bots are failing inspector tests.  We don't know why yet.
2931         So for now, turning run-webkit-tests off for the mac-ews.
2932
2933         Also noticed that due to the wrong variable name the cr-linux
2934         bots weren't running tests!
2935
2936         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2937
2938 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
2939
2940         Reviewed by Csaba Osztrogonac.
2941
2942         [Qt][WK2] Canvas tests make css2.1 ones failing
2943         https://bugs.webkit.org/show_bug.cgi?id=53427
2944
2945         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
2946         Since the Qt port should eventually go to QRawFont, this issue will be resolved
2947         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
2948         needed for the workaround.
2949
2950         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2951         (WTR::LayoutTestController::platformInitialize):
2952
2953 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
2954
2955         Reviewed by Chris Fleizach.
2956
2957         [GTK] Provide a way in DRT to check the platform name
2958         https://bugs.webkit.org/show_bug.cgi?id=56855
2959
2960         Patch for adding 'platformName' static property to DRT's
2961         LayoutController and provide platform specific implementations.
2962
2963         In principle, this feature will be only of interest for writing
2964         accessibility tests, so that's why it's only implemented in the
2965         Mac, Gtk and Win platforms.
2966
2967         * DumpRenderTree/LayoutTestController.h: New method platformName().
2968         * DumpRenderTree/LayoutTestController.cpp:
2969         (getPlatformNameCallback): New callback for 'platformName'.
2970         (LayoutTestController::staticValues): New static property.
2971
2972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2973         (LayoutTestController::platformName): Implemented.
2974
2975         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2976         (LayoutTestController::platformName): Implemented.
2977
2978         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2979         (LayoutTestController::platformName): Implemented.
2980
2981 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
2982
2983         Reviewed by James Robinson.
2984
2985         Add mikelawther to committers.py
2986         https://bugs.webkit.org/show_bug.cgi?id=62354
2987
2988         * Scripts/webkitpy/common/config/committers.py:
2989
2990 2011-06-08  Kent Tamura  <tkent@chromium.org>
2991
2992         [Chromium] Fix a typo.
2993
2994         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2995         (WebThemeControlDRTWin::draw):
2996
2997 2011-06-08  Kent Tamura  <tkent@chromium.org>
2998
2999         Reviewed by Hajime Morita.
3000
3001         [Chromium] Support vertical sliders in Windows DRT
3002         https://bugs.webkit.org/show_bug.cgi?id=62352
3003
3004         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3005         (WebThemeControlDRTWin::draw):
3006           Paint VerticalSliderThumbType and VerticalSliderTrackType.
3007         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3008           Add VerticalSliderTrackType and VerticalSliderThumbType.
3009         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3010         (WebThemeEngineDRTWin::paintTrackbar):
3011           Convert Windows identifiers to the internal identifiers for vertical sliders.
3012
3013 2011-06-08  Ojan Vafai  <ojan@chromium.org>
3014
3015         Reviewed by Tony Chang.
3016
3017         add a short-flag for --experimental-fully-parallel
3018         https://bugs.webkit.org/show_bug.cgi?id=62321
3019
3020         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3021
3022 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3023
3024         Reviewed by Tony Chang.
3025
3026         new-run-webkit-tests: don't turn the tree red when there are new passes
3027         https://bugs.webkit.org/show_bug.cgi?id=62311
3028
3029         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
3030         to match commandComplete.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3033
3034 2011-06-08  Tom Hudson  <tomhudson@google.com>
3035
3036         Reviewed by Mihai Parparita.
3037
3038         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
3039         https://bugs.webkit.org/show_bug.cgi?id=60964
3040
3041         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3042         Add 'Sort tests by metric' link.
3043         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3044         (disableSorting): Activate 'Sort tests by metric' link.
3045         (enableSorting): Deactivate 'Sort tests by metric' link.
3046         (selectDirectory): Call enableSorting()/disableSorting() depending
3047         on currently selected failure type, and sort tests if requested.
3048         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3049         New .disabled-control class for deactivated links.
3050
3051 2011-06-08  Tom Sepez  <tsepez@chromium.org>
3052
3053         Reviewed by Adam Barth.
3054
3055         Add web permissions callbacks for mixed content blocking.
3056         https://bugs.webkit.org/show_bug.cgi?id=61946
3057
3058         * DumpRenderTree/chromium/LayoutTestController.cpp:
3059         (LayoutTestController::setAllowDisplayOfInsecureContent):
3060         (LayoutTestController::setAllowRunningOfInsecureContent):
3061         (LayoutTestController::overridePreference):
3062         * DumpRenderTree/chromium/WebPermissions.cpp:
3063         (WebPermissions::allowDisplayingInsecureContent):
3064         (WebPermissions::allowRunningInsecureContent):
3065         (WebPermissions::setDisplayingInsecureContentAllowed):
3066         (WebPermissions::setRunningInsecureContentAllowed):
3067         (WebPermissions::reset):
3068         * DumpRenderTree/chromium/WebPermissions.h:
3069
3070 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
3071
3072         Reviewed by Tony Chang.
3073
3074         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
3075         https://bugs.webkit.org/show_bug.cgi?id=62259
3076
3077         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3078
3079 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3080
3081         Reviewed by Tony Chang.
3082
3083         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
3084         https://bugs.webkit.org/show_bug.cgi?id=62303
3085
3086         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
3087
3088         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3089
3090 2011-06-08  Greg Simon  <gregsimon@chromium.org>
3091
3092         Reviewed by Dimitri Glazkov.
3093
3094         Control Indexeddb backends from LayoutTestController
3095         https://bugs.webkit.org/show_bug.cgi?id=61000
3096
3097         * DumpRenderTree/chromium/LayoutTestController.cpp:
3098         (LayoutTestController::LayoutTestController):
3099         (LayoutTestController::setOverrideIndexedDBBackingStore):
3100         (LayoutTestController::clearAllDatabases):
3101         * DumpRenderTree/chromium/LayoutTestController.h:
3102
3103 2011-06-08  Andreas Kling  <kling@webkit.org>
3104
3105         Add Pierre Rossi to contributors list for EZ-CC.
3106
3107         * Scripts/webkitpy/common/config/committers.py:
3108
3109 2011-06-08  Ilya Sherman  <isherman@chromium.org>
3110
3111         Reviewed by Andreas Kling.
3112
3113         Add Ilya Sherman to list of committers
3114         https://bugs.webkit.org/show_bug.cgi?id=62270
3115
3116         * Scripts/webkitpy/common/config/committers.py:
3117
3118 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
3119
3120         Reviewed by Tony Chang.
3121
3122         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
3123         https://bugs.webkit.org/show_bug.cgi?id=62178
3124
3125         Added commandComplete and evaluateCommand for NewRunWebKitTests class
3126         to parse new-run-webkit-tests' results.
3127
3128         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3129
3130 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3131
3132         Reviewed by Eric Seidel.
3133
3134         webkitpy: add a popen() call to executive
3135         https://bugs.webkit.org/show_bug.cgi?id=62179
3136
3137         This change adds a popen() wrapper call to the Executive object.
3138         This will allow other webkitpy scripts that currently call
3139         subprocess directly to use Executive, instead.
3140
3141         No additional tests are necessary (the existing tests cover the code).
3142
3143         * Scripts/webkitpy/common/system/executive.py:
3144
3145 2011-06-07  Sam Weinig  <sam@webkit.org>
3146
3147         Reviewed by Anders Carlsson.
3148
3149         Remove repeated IPC traffic from SetRenderTreeSize message
3150         https://bugs.webkit.org/show_bug.cgi?id=62244
3151
3152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3153         (WTR::InjectedBundlePage::InjectedBundlePage):
3154         Add stub for didLayoutForFrame.
3155
3156 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3157
3158         Reviewed by Tony Chang.
3159
3160         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
3161         https://bugs.webkit.org/show_bug.cgi?id=62241
3162
3163         * Scripts/webkitpy/layout_tests/port/chromium.py:
3164
3165 2011-06-07  Adam Barth  <abarth@webkit.org>
3166
3167         Rubber-stamped by Eric Seidel.
3168
3169         Enable tests on the mac-ews
3170
3171         When we bring the mac-ews back up, we're going to try running tests!
3172
3173         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3174
3175 2011-06-07  Dmitry Lomov  <dslomov@google.com>
3176
3177         Reviewed by David Levin.
3178
3179         https://bugs.webkit.org/show_bug.cgi?id=62215
3180         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
3181
3182         * Scripts/webkitpy/style/checkers/cpp.py:
3183         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3184
3185 2011-06-07  Nico Weber  <thakis@chromium.org>
3186
3187         Reviewed by Dimitri Glazkov.
3188
3189         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
3190         https://bugs.webkit.org/show_bug.cgi?id=62210
3191
3192         The change to TestEventPrinter fixes a latent bug, because
3193         objects are deleted through the TestEventPrinter type, but none
3194         of the subclasses have destructors or non-POD members.
3195
3196         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
3197         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
3198         discussed at http://codereview.chromium.org/7094005/, we prefer making
3199         leaf class destructors virtual over making the leaf classes final.
3200
3201         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3202         (NotificationPresenter::~NotificationPresenter):
3203         * DumpRenderTree/chromium/NotificationPresenter.h:
3204         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3205         (TestEventPrinter::~TestEventPrinter):
3206         * DumpRenderTree/chromium/TestEventPrinter.h:
3207         * DumpRenderTree/chromium/WebViewHost.h:
3208
3209 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3210
3211         Reviewed by Dirk Pranke.
3212
3213         [chromium] Chromium bots on build.webkit.org don't upload results.html
3214         https://bugs.webkit.org/show_bug.cgi?id=61961
3215
3216         Don't fix the path on chromium port erroneously.
3217
3218         * BuildSlaveSupport/test-result-archive:
3219
3220 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
3221
3222         Fix the GTK+ build by ensuring that the autogenerated sources
3223         necessary for libWebCoreInternals are recorded in a predeclared
3224         variable before assigning to BUILT_SOURCES.
3225
3226         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
3227
3228 2011-06-06  Yong Li  <yoli@rim.com>
3229
3230         Reviewed by Eric Seidel.
3231
3232         https://bugs.webkit.org/show_bug.cgi?id=62097
3233         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
3234
3235         * Scripts/webkitpy/style/checkers/cpp.py:
3236         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3237
3238 2011-06-06  Xan Lopez  <xlopez@igalia.com>
3239
3240         Reviewed by Martin Robinson.
3241
3242         [GTK] Enable feature/symbol detection in NWRT/GTK
3243         https://bugs.webkit.org/show_bug.cgi?id=62136
3244
3245         Disable feature detection through DRT, since we don't support it,
3246         and set the libwebcore patch correctly so that symbol detection
3247         through 'nm' works.
3248
3249         * Scripts/webkitpy/layout_tests/port/gtk.py:
3250
3251 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
3252
3253         Reviewed by Tony Gentilcore.
3254
3255         Add a "prerender" state for page visibility.
3256         https://bugs.webkit.org/show_bug.cgi?id=62062
3257
3258         * DumpRenderTree/chromium/LayoutTestController.cpp:
3259         (LayoutTestController::setPageVisibility):
3260
3261 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
3262
3263         [Qt] Implement download feature for QtTestBrowser
3264         https://bugs.webkit.org/show_bug.cgi?id=61865
3265
3266         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
3267
3268         * QtTestBrowser/launcherwindow.cpp:
3269         (LauncherWindow::LauncherWindow):
3270         * QtTestBrowser/launcherwindow.h:
3271
3272 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
3273
3274         Reviewed by Csaba Osztrogonác.
3275
3276         [Qt] Implement download feature for QtTestBrowser
3277         https://bugs.webkit.org/show_bug.cgi?id=61865
3278
3279         * QtTestBrowser/launcherwindow.cpp:
3280         (LauncherWindow::LauncherWindow):
3281         (LauncherWindow::downloadRequest):
3282         (LauncherWindow::fileDownloadFinished):
3283         * QtTestBrowser/launcherwindow.h:
3284
3285 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
3286
3287         Reviewed by Dimitri Glazkov.
3288
3289         Make DumpRenderTree initialize window.internals.
3290         https://bugs.webkit.org/show_bug.cgi?id=61076
3291
3292         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
3293         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3294         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3295
3296 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
3297
3298         Reviewed by Kent Tamura.
3299
3300         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
3301         https://bugs.webkit.org/show_bug.cgi?id=61628
3302
3303         * Scripts/build-webkit:
3304
3305 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
3306
3307         Reviewed by Kent Tamura.
3308
3309         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
3310         https://bugs.webkit.org/show_bug.cgi?id=61631
3311
3312         * Scripts/build-webkit:
3313
3314 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3315
3316         Unreviewed. Fix the GTK+ build.
3317
3318         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
3319
3320 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
3321
3322         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
3323         works properly).
3324
3325         * Scripts/webkitpy/common/config/committers.py:
3326
3327 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3328
3329         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
3330         WebKit scripts expect, so other scripts work properly with wx.
3331
3332         * waf/build/build_utils.py:
3333         * waf/build/settings.py:
3334
3335 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3336
3337         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
3338         to build on Mac.
3339
3340         * waf/build/settings.py:
3341         * wx/install-unix-extras:
3342
3343 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3344
3345         [wx] Unreviewed build fixes for recent trunk changes.
3346
3347         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3348         (LayoutTestController::setTextDirection):
3349         * waf/build/settings.py:
3350
3351 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
3352
3353         Fix the GTK+ build.
3354
3355         * GNUmakefile.am: Add some missing newline escape.
3356
3357 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3358
3359         Try to fix the GTK+ bulid.
3360
3361         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
3362         source list.
3363
3364 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3365
3366         Reviewed by Adam Barth.
3367
3368         nrwt: should skip chromium test expectation overrides on upstream bots
3369         https://bugs.webkit.org/show_bug.cgi?id=61888
3370
3371         * Scripts/webkitpy/layout_tests/port/chromium.py:
3372         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3373
3374 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3375
3376         Reviewed by Ojan Vafai.
3377
3378         new-run-webkit-tests: minor logging, code cleanup
3379         https://bugs.webkit.org/show_bug.cgi?id=62055
3380
3381         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3382         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3383
3384 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3385
3386         Try to fix the build failure on the GTK+ 32-bit Release bot.
3387
3388         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
3389
3390 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
3391
3392         Reviewed by Ryosuke Niwa.
3393
3394         [GTK] Support smart replace for the pasteboard
3395         https://bugs.webkit.org/show_bug.cgi?id=61734
3396
3397         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
3398         This is required to produce consistent test results.
3399
3400         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3401         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
3402         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3403         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
3404         methods which calls into DumpRenderTreeSupportGtk.
3405
3406 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3407
3408         Reviewed by Dimitri Glazkov.
3409
3410         Teach Gtk build about window.internals
3411         https://bugs.webkit.org/show_bug.cgi?id=61071
3412
3413         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3414         (webViewWindowObjectCleared): Inject the new internals object when the
3415         window object clears.
3416         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
3417         Also do a little bit of cleanup.
3418
3419 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3420
3421         Reviewed by Tony Chang.
3422
3423         Worker may not be stopped after LT.
3424         https://bugs.webkit.org/show_bug.cgi?id=61847
3425
3426         Re-submit a variant of the first fix for this bug. It's possible
3427         that actually calling cleanup() in the worker threads was taking
3428         too long and we triggered the assertions in the manager thread.
3429
3430         I've bumped up the timeout in the manager and added better
3431         diagnostics. I also cleaned up the cleanup() code a bit because
3432         there was some unnecessary if-checks.
3433
3434         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3435         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3436
3437 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3438
3439         Reviewed by Tony Chang.
3440
3441         nrwt: fix duplicate logging regression
3442         https://bugs.webkit.org/show_bug.cgi?id=61981
3443
3444         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3445
3446 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
3447
3448         Reviewed by Adam Barth.
3449
3450         Modified addTouchPoint to correctly re-use touchPoint id values starting
3451         from the lowest not-un-use touchPoint id as is done by the embedder
3452         APIs. (Fixes BUGCR36415)
3453
3454         https://bugs.webkit.org/show_bug.cgi?id=62016
3455
3456         * DumpRenderTree/chromium/EventSender.cpp:
3457         (EventSender::addTouchPoint):
3458
3459 2011-06-03  Cary Clark  <caryclark@google.com>
3460
3461         Reviewed by Eric Seidel.
3462
3463         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
3464         https://bugs.webkit.org/show_bug.cgi?id=61534
3465
3466         Skia on Mac uses Skia to render WebKit, and CG
3467         to render UI elements. The CG elements need a
3468         transcribed graphics context that preserves the
3469         canvas matrix, and the canvas clip.
3470
3471         The SkiaBitLocker utility class sets up a CGContext
3472         from the SkCanvas, locks the bitmap's bits, and
3473         releases the lock when the class goes out of scope.
3474
3475         The SkiaBitLocker implementation is described by
3476         this patch:
3477         http://codereview.chromium.org/7031006/
3478
3479         When WebKit uses Skia for rendering, the WebCanvas
3480         is an SkCanvas. Create an equivalent CGContext to
3481         draw the scrollbar thumb.
3482
3483         As the Chrome Mac port does not yet use Skia, this
3484         patch has no effect and requires no tests.
3485
3486         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3487         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3488
3489 2011-06-03  Andras Becsi  <abecsi@webkit.org>
3490
3491         Unreviewed build fix.
3492
3493         Fix typo.
3494
3495         * Scripts/old-run-webkit-tests:
3496
3497 2011-06-03  Andras Becsi  <abecsi@webkit.org>
3498
3499         Reviewed by Csaba Osztrogonác.
3500
3501         Print error message when there is no httpd present on the system
3502         https://bugs.webkit.org/show_bug.cgi?id=61939
3503
3504         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
3505         * Scripts/webkitperl/httpd.pm:
3506
3507 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
3508
3509         Reviewed by Yury Semikhatsky.
3510
3511         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
3512         https://bugs.webkit.org/show_bug.cgi?id=61533
3513
3514         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
3515
3516         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3517         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
3518         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3519         * DumpRenderTree/chromium/LayoutTestController.cpp:
3520         (LayoutTestController::LayoutTestController):
3521         (LayoutTestController::setJavaScriptProfilingEnabled):
3522         * DumpRenderTree/chromium/LayoutTestController.h:
3523         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3524         (LayoutTestController::setJavaScriptProfilingEnabled):
3525         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3526         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
3527         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3528
3529 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
3530
3531         Reviewed by Tony Chang.
3532
3533         NRWT needs a way to log to a file without including backspaces without needing --verbose
3534         https://bugs.webkit.org/show_bug.cgi?id=60328
3535
3536         This change modifies NRWT so that if it can tell if it is
3537         writing to a terminal, it will overwrite any messages printed
3538         in the 'one-line-progress' and 'updates' print options, and if
3539         not (or if --verbose was specified) the messages will be printed
3540         without backspaces.
3541
3542         If the overwriting updates are disabled, one-line-progress will
3543         only print every 10 seconds instead of on every update. This
3544         ensures that we still get updates once in a while while the
3545         tests are running, even if we're not in --verbose mode. Note
3546         that one-line-progress will now still be printed in --verbose,
3547         since it's useful as long as you're not flooded with the
3548         updates.
3549
3550         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3551         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3552         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3553
3554 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
3555
3556         Reviewed by Gustavo Noronha Silva.
3557
3558         [GTK] autogen.sh is run twice for each buld on the bots
3559         https://bugs.webkit.org/show_bug.cgi?id=61951
3560
3561         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
3562         for the WebKit project. This prevents build-jsc runs from forcing subsequent
3563         build-webkit runs to re-rerun autogen.sh.
3564
3565 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3566
3567         Unreviewed, rolling out r87946.
3568         http://trac.webkit.org/changeset/87946
3569         https://bugs.webkit.org/show_bug.cgi?id=61965
3570
3571         Cause NRWT to break (Requested by abarth|gardener on #webkit).
3572
3573         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3574
3575 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
3576
3577         Reviewed by Darin Adler.
3578
3579         Add build logistics and plumbing for window.internals object.
3580         https://bugs.webkit.org/show_bug.cgi?id=60313
3581
3582         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3583         * DumpRenderTree/chromium/TestShell.cpp:
3584         (TestShell::bindJSObjectsToWindow): Added injection code.
3585         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3586         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3587
3588 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
3589
3590         Reviewed by Dirk Pranke.
3591
3592         Call cleanup() explicitly at the end of worker.run().
3593         https://bugs.webkit.org/show_bug.cgi?id=61847
3594
3595         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3596
3597 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
3598
3599         Unreviewed, rolling out r87926.
3600         http://trac.webkit.org/changeset/87926
3601         https://bugs.webkit.org/show_bug.cgi?id=60313
3602
3603         Fails to find WebCoreTestSupport.dylib on bots.
3604
3605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3606         * DumpRenderTree/chromium/TestShell.cpp:
3607         (TestShell::bindJSObjectsToWindow):
3608         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3609         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3610
3611 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
3612
3613         Reviewed by Darin Adler.
3614
3615         Add build logistics and plumbing for window.internals object.
3616         https://bugs.webkit.org/show_bug.cgi?id=60313
3617
3618         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3619         * DumpRenderTree/chromium/TestShell.cpp:
3620         (TestShell::bindJSObjectsToWindow): Added injection code.
3621         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3622         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3623
3624 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3625
3626         Reviewed by Eric Seidel.
3627
3628         Adjust efl coding style to more efl directories
3629         https://bugs.webkit.org/show_bug.cgi?id=61903
3630
3631         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
3632
3633 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
3634
3635         Reviewed by Tony Chang.
3636
3637         old-run-webkit-tests: add support for audio files
3638         https://bugs.webkit.org/show_bug.cgi?id=57992
3639
3640         * Scripts/old-run-webkit-tests:
3641
3642 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
3643
3644         Reviewed by Adam Barth.
3645
3646         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
3647         https://bugs.webkit.org/show_bug.cgi?id=34314
3648
3649         * DumpRenderTree/DumpRenderTree.gypi:
3650         * DumpRenderTree/chromium/LayoutTestController.cpp:
3651         (LayoutTestController::LayoutTestController):
3652         (LayoutTestController::setImagesAllowed):
3653         (LayoutTestController::setStorageAllowed):