b3709f54b9d869bab7003aa43b1d74647fde62c6
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
2
3         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
4         https://bugs.webkit.org/show_bug.cgi?id=132599
5
6         Reviewed by Michael Catanzaro.
7
8         Check if cmake Ninja generators are installed.
9
10         * Scripts/webkitdirs.pm:
11         (canUseNinjaGenerator):
12         (canUseEclipseNinjaGenerator):
13         (generateBuildSystemFromCMakeProject):
14         (canUseEclipse): Deleted.
15
16 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
17
18         [Cocoa] Testing with font family name "System Font" is unused
19         https://bugs.webkit.org/show_bug.cgi?id=153073
20         <rdar://problem/24091683>
21
22         Reviewed by Brent Fulgham.
23
24         * DumpRenderTree/mac/DumpRenderTree.mm:
25         (allowedFontFamilySet): Deleted.
26         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
27         (WTR::allowedFontFamilySet): Deleted.
28         * WebKitTestRunner/mac/TestControllerMac.mm:
29         (WTR::allowedFontFamilySet): Deleted.
30
31 2016-01-13  Daniel Bates  <dabates@apple.com>
32
33         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
34         https://bugs.webkit.org/show_bug.cgi?id=152871
35
36         Reviewed by Brent Fulgham.
37
38         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
39         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
40
41         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
42
43 2016-01-08  Andy Estes  <aestes@apple.com>
44
45         [Content Filtering] Lazily load platform frameworks
46         https://bugs.webkit.org/show_bug.cgi?id=152881
47         rdar://problem/23270886
48
49         Reviewed by Brady Eidson.
50
51         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
52         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
53         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
54         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
55         is loaded after an HTTPS request.
56
57         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
58         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
59         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
60         also re-enabled on iOS after mistakenly being disabled by r188892.
61
62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
63         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
64         (TestWebKitAPI::TEST):
65         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
66         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
67         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
68         (TEST):
69         (downloadTest):
70         (-[LazilyLoadPlatformFrameworksController init]):
71         (-[LazilyLoadPlatformFrameworksController webView]):
72         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
73         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
74         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
75         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
76         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
77         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
78         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
79         (TestWebKitAPI::TEST):
80         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
81         (TestWebKitAPI::TEST): Deleted.
82         * TestWebKitAPI/cocoa/TestProtocol.h:
83         * TestWebKitAPI/cocoa/TestProtocol.mm:
84         (+[TestProtocol registerWithScheme:]):
85         (+[TestProtocol unregister]):
86
87 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
88
89         Fix the Sunpider converage in slow device.
90         https://bugs.webkit.org/show_bug.cgi?id=152938
91         <rdar://problem/22511411>
92
93         Reviewed by Ryosuke Niwa.
94
95         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
96
97         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
98
99 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
100
101         Add a build flag for custom element
102         https://bugs.webkit.org/show_bug.cgi?id=153005
103
104         Reviewed by Alex Christensen.
105
106         Added --custom-elements option to enable custom elements support.
107
108         * Scripts/webkitperl/FeatureList.pm:
109
110 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
111
112         [JSC] Add a help message when run-jsc-stress-tests fails
113         https://bugs.webkit.org/show_bug.cgi?id=153014
114
115         Reviewed by Csaba Osztrogonác.
116
117         * Scripts/run-jsc-stress-tests:
118
119 2016-01-11  Saam barati  <sbarati@apple.com>
120
121         run-jsc-stress-tests should try to figure out a JSC path
122         https://bugs.webkit.org/show_bug.cgi?id=152971
123
124         Reviewed by Yusuke Suzuki.
125
126         This patch now allows run-jsc-stress-tests to be run
127         without a "--jsc <jsc-path>" argument. It tries
128         to take its best guess at a <jsc-path> automagically.
129         
130         This makes it much easier to just run run-jsc-stress-tests
131         with a directory or a yaml file as an argument.
132         You now just do this:
133         `run-jsc-stress-tests <path-to-yaml>`
134         or
135         `run-jsc-stress-tests <path-to-directory-of-js-files>`
136         
137         I wrote this patch because I'd often find myself hacking the 
138         run-javascriptcore-tests file just to run a particular subset of tests.
139         Because I always forget the arguments to run-jsc-stress-tests (which means
140         I always forgot to provide a --jsc argument), I always found it easier to 
141         just hack on that file instead of calling run-jsc-stress-tests directly.
142         No longer is this true!
143
144         * Scripts/run-jsc-stress-tests:
145
146 2016-01-09  Andy Estes  <aestes@apple.com>
147
148         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
149         https://bugs.webkit.org/show_bug.cgi?id=152950
150         rdar://problem/24066652
151
152         Reviewed by Tim Horton.
153
154         Added an API test.
155
156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
157         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
158         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
159         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
160         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
161         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
162         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
163         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
164         (TEST):
165
166 2016-01-11  Commit Queue  <commit-queue@webkit.org>
167
168         Unreviewed, rolling out r194866.
169         https://bugs.webkit.org/show_bug.cgi?id=152986
170
171         This change broke the mac build (Requested by ryanhaddad on
172         #webkit).
173
174         Reverted changeset:
175
176         "[Cocoa] Add SPI to opt out a URL scheme from the memory
177         cache"
178         https://bugs.webkit.org/show_bug.cgi?id=152950
179         http://trac.webkit.org/changeset/194866
180
181 2016-01-11  Andy Estes  <aestes@apple.com>
182
183         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
184         https://bugs.webkit.org/show_bug.cgi?id=152950
185         rdar://problem/24066652
186
187         Reviewed by Tim Horton.
188
189         Added an API test.
190
191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
192         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
193         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
194         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
195         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
196         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
197         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
198         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
199         (TEST):
200
201 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
202
203         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
204         https://bugs.webkit.org/show_bug.cgi?id=152959
205
206         Reviewed by Brent Fulgham.
207
208         * Scripts/webkitdirs.pm:
209         (determineArchitecture):
210
211 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
212
213         [GTK] W3C CSS2.1 anonymous table tests are failing
214         https://bugs.webkit.org/show_bug.cgi?id=152455
215
216         Reviewed by Mario Sanchez Prada.
217
218         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
219         tests. Add upstream patches to fix detection of XHTML files.
220
221         * gtk/jhbuild.modules:
222         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
223         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
224
225 2016-01-10  Saam barati  <sbarati@apple.com>
226
227         Implement a sampling profiler
228         https://bugs.webkit.org/show_bug.cgi?id=151713
229
230         Reviewed by Filip Pizlo.
231
232         * Scripts/run-jsc-stress-tests:
233
234 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
235
236         [webkitdirs] Try arch and uname commands on non-windows OS
237         https://bugs.webkit.org/show_bug.cgi?id=152958
238
239         Reviewed by Michael Catanzaro.
240
241         Right now, determineArchitecture()  uses `arch` and `uname -m`
242         commands to determine architecture in case of condition (isGtk() ||
243         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
244         instead, because this code is applicable to any non-windows OS WebKit
245         supports (even Haiku which once was supported is moderately
246         POSIX-compliant and has uname command).
247
248         * Scripts/webkitdirs.pm:
249         (determineArchitecture):
250
251 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
252
253         run-webkit-tests mis-counts totals when there are other crashes
254         https://bugs.webkit.org/show_bug.cgi?id=152894
255         <rdar://problem/24098697>
256
257         Reviewed by Alexey Proskuryakov.
258
259         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
260         (TestRunResults.add): Do not update result counters for other crashes.
261
262 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
263
264         webkit-patch build-and-test should have an option to iterate over new tests
265         https://bugs.webkit.org/show_bug.cgi?id=143093
266
267         Reviewed by Michael Catanzaro.
268
269         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
270         It allows running run-webkit-tests on modified or new paths in LayoutTests.
271         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
272         It implements the translation of -expected.* paths to their related tests.
273         It also implements the removal of skipped tests.
274
275         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
276         (LayoutTestFinder.find_touched_tests):
277         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
278         (MockPort):
279         (MockPort.__init__):
280         (MockPort.tests):
281         (LayoutTestFinderTests):
282         (LayoutTestFinderTests.touched_files):
283         (LayoutTestFinderTests.test_touched_test):
284         (LayoutTestFinderTests.test_expected_touched_test):
285         (LayoutTestFinderTests.test_platform_expected_touched_test):
286         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
287         (LayoutTestFinderTests.test_touched_but_skipped_test):
288         * Scripts/webkitpy/port/base.py:
289         (Port.potential_test_names_from_expected_file):
290         * Scripts/webkitpy/tool/commands/download_unittest.py:
291         (DownloadCommandsTest._default_options):
292         * Scripts/webkitpy/tool/steps/options.py:
293         (Options):
294         * Scripts/webkitpy/tool/steps/runtests.py:
295         (RunTests.options):
296         (RunTests.run):
297         (RunTests):
298         (RunTests._new_or_modified_tests):
299         (RunTests._run_webkit_tests):
300         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
301         (RunTestsTest.test_webkit_run_unit_tests):
302         * Scripts/webkitpy/tool/steps/steps_unittest.py:
303         (StepsTest._step_options):
304
305 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
306
307         prepare-ChangeLog should include radar number
308         https://bugs.webkit.org/show_bug.cgi?id=152839
309         <rdar://problem/24093563>
310
311         Reviewed by Daniel Bates.
312
313         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
314         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
315         in the ChangeLog description after the bug URL.
316
317         * Scripts/prepare-ChangeLog:
318         (main): Update signatures.
319         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
320         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
321         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
322         (generateNewChangeLogs): Include radar URL if we found one.
323
324         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
325         Tests for the radar URL extraction.
326
327 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
328
329         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
330         https://bugs.webkit.org/show_bug.cgi?id=152390
331         <rdar://problem/23948321>
332
333         Reviewed by Simon Fraser.
334
335         Fix two use-after-frees.
336
337         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
338         but we may have already progressed to another test by the time the callback fires,
339         having destroyed the TestInvocation.
340         2. UIScriptController is a RefCounted object, but it has a raw pointer to
341         UIScriptContext which has the same lifetime as a TestInvocation.
342         As a result, completion blocks of UIScriptController actions would use a destroyed
343         TestInvocation.
344
345         * WebKitTestRunner/TestInvocation.cpp:
346         (WTR::TestInvocation::~TestInvocation):
347         (WTR::TestInvocation::url):
348         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
349         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
350         (WTR::TestInvocation::runUISideScript):
351         * WebKitTestRunner/TestInvocation.h:
352         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
353         (UIScriptContext::UIScriptContext):
354         (UIScriptContext::~UIScriptContext):
355         (UIScriptContext::runUIScript):
356         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
357         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
358         (WTR::UIScriptController::UIScriptController):
359         (WTR::UIScriptController::contextDestroyed):
360         (WTR::UIScriptController::makeWindowObject):
361         (WTR::UIScriptController::setWillBeginZoomingCallback):
362         (WTR::UIScriptController::willBeginZoomingCallback):
363         (WTR::UIScriptController::setDidEndZoomingCallback):
364         (WTR::UIScriptController::didEndZoomingCallback):
365         (WTR::UIScriptController::setDidEndScrollingCallback):
366         (WTR::UIScriptController::didEndScrollingCallback):
367         (WTR::UIScriptController::setDidShowKeyboardCallback):
368         (WTR::UIScriptController::didShowKeyboardCallback):
369         (WTR::UIScriptController::setDidHideKeyboardCallback):
370         (WTR::UIScriptController::didHideKeyboardCallback):
371         (WTR::UIScriptController::uiScriptComplete):
372         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
373         (WTR::UIScriptController::create):
374         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
375         (WTR::UIScriptController::doAsyncTask):
376         (WTR::UIScriptController::zoomToScale):
377         (WTR::UIScriptController::singleTapAtPoint):
378         (WTR::UIScriptController::doubleTapAtPoint):
379         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
380         (WTR::UIScriptController::contentVisibleRect):
381         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
382         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
383         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
384         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
385         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
386         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
387         (WTR::UIScriptController::doAsyncTask):
388
389 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
390
391         [buildbot] clean-build script should remove untracked files and revert local changes too
392         https://bugs.webkit.org/show_bug.cgi?id=142400
393
394         Reviewed by Ryosuke Niwa.
395
396         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
397         A helper routine SCM.discard_untracked_files is added for that purpose.
398
399         * BuildSlaveSupport/clean-build:
400         (main): Making call to Scripts/clean-webkit
401         * Scripts/clean-webkit: Added.
402         (main): Revert changes and delete untracked files.
403         * Scripts/webkitpy/common/checkout/scm/scm.py:
404         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
405         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
406         (SCMTest._shared_test_discard_untracked_files):
407         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
408
409 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
410
411         Add a setting and preferences to enable display-list drawing. Does nothing yet.
412         https://bugs.webkit.org/show_bug.cgi?id=152807
413
414         Reviewed by Zalan Bujtas.
415         
416         Add an item to the Settings menu to toggle display-list drawing.
417
418         * MiniBrowser/mac/SettingsController.h:
419         * MiniBrowser/mac/SettingsController.m:
420         (-[SettingsController _populateMenu]):
421         (-[SettingsController validateMenuItem:]):
422         (-[SettingsController toggleDisplayListDrawingEnabled:]):
423         (-[SettingsController displayListDrawingEnabled]):
424         * MiniBrowser/mac/WK2BrowserWindowController.m:
425         (-[WK2BrowserWindowController didChangeSettings]):
426
427 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
428
429         Python SCM should be able to retrieve untracked files - Add GIT support
430         https://bugs.webkit.org/show_bug.cgi?id=143135
431
432         Reviewed by Michael Catanzaro.
433
434         * Scripts/webkitpy/common/checkout/scm/git.py:
435         (Git.untracked_files): Adding support for git.
436         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
437         (GitTest.setUp):
438         (GitTest.test_untracked_files): Adding test.
439
440 2016-01-05  Mark Lam  <mark.lam@apple.com>
441
442         Rename badly named JSC_timeout env var to JSCTEST_timeout.
443         https://bugs.webkit.org/show_bug.cgi?id=152748
444
445         Reviewed by Geoffrey Garen.
446
447         Now that we validate JSC options, the badly named JSC_timeout env var causes the
448         bots to have a bad time.
449
450         * Scripts/run-javascriptcore-tests:
451         * Scripts/run-jsc-stress-tests:
452
453 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
454
455         [GTK] Allow to save and restore session
456         https://bugs.webkit.org/show_bug.cgi?id=115600
457
458         Reviewed by Michael Catanzaro.
459
460         Add test case to check the new session API.
461
462         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
463         (testWebKitWebViewSessionState):
464         (testWebKitWebViewSessionStateWithFormData):
465         (beforeAll):
466
467 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
468
469         [EFL] Bump EFL version to 1.16.1
470         https://bugs.webkit.org/show_bug.cgi?id=152688
471
472         Reviewed by Gyuyoung Kim.
473
474         * efl/jhbuild.modules:
475
476 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
477
478         error running layout tests on iOS simulator on latest build
479         https://bugs.webkit.org/show_bug.cgi?id=152719
480         <rdar://problem/24009549>
481
482         Reviewed by Alexey Proskuryakov.
483
484         * Scripts/webkitpy/xcode/simulator.py:
485         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
486           before running simctl spawn command.
487
488 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
489
490         Unreviewed, move Frédéric Wang to committers list
491
492         He seems to be on the contributors list by accident. He has been landing his own commits for
493         about two years now.
494
495         * Scripts/webkitpy/common/config/contributors.json:
496
497 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
498
499         Unreviewed, move Sebastian Dröge to committers list harder
500
501         He accidentally added himself to the reviewers list because the file is confusing. Then I
502         accidentially moved him to the contributors list because the file is confusing, even though
503         I knew the contributors list existed in this file and was attempting to add him to the
504         committers list. Really move him to the committers list now.
505
506         * Scripts/webkitpy/common/config/contributors.json:
507
508 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
509
510         Python SCM should be able to retrieve untracked files - Add SVN support
511         https://bugs.webkit.org/show_bug.cgi?id=152546
512
513         Reviewed by Michael Catanzaro.
514
515         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
516         (test_untracked_files): Activating test for SVN.
517         * Scripts/webkitpy/common/checkout/scm/svn.py:
518         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
519
520 2015-12-31  Andy Estes  <aestes@apple.com>
521
522         Replace WTF::move with WTFMove
523         https://bugs.webkit.org/show_bug.cgi?id=152601
524
525         Reviewed by Brady Eidson.
526
527         * DumpRenderTree/TestRunner.h:
528         (TestRunner::setAllowedHosts):
529         * DumpRenderTree/win/DRTDataObject.cpp:
530         (DRTDataObject::SetData):
531         * TestWebKitAPI/Tests/WTF/Deque.cpp:
532         (TestWebKitAPI::TEST):
533         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
534         (TestWebKitAPI::TEST):
535         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
536         (TestWebKitAPI::TEST):
537         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
538         (TestWebKitAPI::TEST):
539         * TestWebKitAPI/Tests/WTF/Ref.cpp:
540         (TestWebKitAPI::passWithRef):
541         (TestWebKitAPI::TEST):
542         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
543         (TestWebKitAPI::TEST):
544         * TestWebKitAPI/Tests/WTF/Vector.cpp:
545         (TestWebKitAPI::TEST):
546         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
547         (TestWebKitAPI::TEST):
548         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
549         (TestWebKitAPI::TEST):
550         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
551         (TestWebKitAPI::createTestValue):
552         (TestWebKitAPI::TEST):
553         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
554         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
555         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
556         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
557         (TestWebKitAPI::createNFAs):
558         (TestWebKitAPI::TEST_F):
559         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
560         (TestWebKitAPI::combine):
561         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
562         (TestWebKitAPI::createNFAs):
563         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
564         (TEST):
565         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
566         (WebProcessTest::add):
567
568 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
569
570         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
571         https://bugs.webkit.org/show_bug.cgi?id=152634
572
573         Reviewed by Carlos Garcia Campos.
574
575         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
576         (testLoadFromGResource): Added test.
577         (beforeAll):
578         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
579         (registerGResource): Added.
580         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
581         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
582         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
583
584 2015-12-31  David Kilzer  <ddkilzer@apple.com>
585
586         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
587         <https://bugs.webkit.org/show_bug.cgi?id=152601>
588
589         Ignore unknown pragmas on older clangs.  Fixes the following
590         build failure:
591
592             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
593             #pragma clang diagnostic ignored "-Wself-move"
594                                              ^
595             1 error generated.
596
597         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
598         (TestWebKitAPI::TEST):
599         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
600         (TestWebKitAPI::TEST):
601
602 2015-12-31  Andy Estes  <aestes@apple.com>
603
604         Update the style checker to advise using WTFMove() instead of WTF::move()
605         https://bugs.webkit.org/show_bug.cgi?id=152601
606
607         Reviewed by Daniel Bates.
608
609         * Scripts/webkitpy/style/checkers/cpp.py:
610         (check_wtf_move):
611         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
612         (WebKitStyleTest.test_wtf_move):
613
614 2015-12-31  Andy Estes  <aestes@apple.com>
615
616         Fix warnings uncovered by migrating to WTF_MOVE
617         https://bugs.webkit.org/show_bug.cgi?id=152601
618
619         Reviewed by Daniel Bates.
620
621         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
622         self-move, even if doing so would trigger a warning.
623
624         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
625         (TestWebKitAPI::TEST):
626         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
627         (TestWebKitAPI::TEST):
628
629 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
630
631         [GTK] The install-dependencies script has a syntax error
632         https://bugs.webkit.org/show_bug.cgi?id=152613
633
634         Reviewed by Michael Catanzaro.
635
636         * gtk/install-dependencies: Add the missing 'then.'
637
638 2015-12-30  Philippe Normand  <pnormand@igalia.com>
639
640         [Mac][GTK] Jhbuild support for OSX
641         https://bugs.webkit.org/show_bug.cgi?id=150799
642
643         Reviewed by Michael Catanzaro.
644
645         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
646         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
647         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
648         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
649
650 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
651
652         Unreviewed, move Sebastian Dröge to committers list
653
654         He accidentally added himself to the reviewers list because the file is confusing.
655
656         * Scripts/webkitpy/common/config/contributors.json:
657
658 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
659
660         Remove the unused #define _USE_MATH_DEFINES
661         https://bugs.webkit.org/show_bug.cgi?id=152034
662
663         Reviewed by Tim Horton.
664         
665         Update this test to use piDouble from MathExtras.h, and
666         std::numeric_limits<>.
667
668         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
669
670 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
671
672         Python SCM should be able to retrieve untracked files - Generic changes
673         https://bugs.webkit.org/show_bug.cgi?id=152536
674
675         Reviewed by Brent Fulgham.
676
677         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
678         No support is yet added to GIT and SVN specific implementations.
679
680         * Scripts/webkitpy/common/checkout/scm/scm.py:
681         (SCM.untracked_files):
682         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
683         (SCMTest._shared_test_untracked_files):
684
685 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
686
687         SVN checkout used by RunBenchmark should be non-interactive
688         https://bugs.webkit.org/show_bug.cgi?id=152542
689
690         Reviewed by Ryosuke Niwa.
691
692         RunBenchmark should not require user interaction while running.
693
694         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
695         (BenchmarkBuilder._checkout_with_subversion):
696
697 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
698
699         Web Inspector: add support for running protocol-test.js tests on Windows
700         https://bugs.webkit.org/show_bug.cgi?id=148037
701         <rdar://problem/22292237>
702
703         Reviewed by Simon Fraser.
704
705         * DumpRenderTree/win/TestRunnerWin.cpp:
706         (TestRunner::inspectorTestStubURL): Provide implementation.
707
708 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
709
710         [MediaStream] MediaDeviceInfo.label must be empty in some situations
711         https://bugs.webkit.org/show_bug.cgi?id=152000
712
713         Reviewed by Brent Fulgham.
714
715         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
716         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
717         (WTR::InjectedBundle::setUserMediaPermission):
718         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
719         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
720
721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
722         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
724
725         * WebKitTestRunner/TestController.cpp:
726         (WTR::TestController::setUserMediaPermissionForOrigin):
727         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
728         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
729           persistent permission for origin, that can be done from script now.
730         * WebKitTestRunner/TestController.h:
731
732         * WebKitTestRunner/TestInvocation.cpp:
733         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
734           SetUserMediaPermissionForOrigin.
735
736 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
737
738         [Win] Unreviewed build fix: Recognize Windows 10 variants.
739
740         * Scripts/webkitpy/common/system/platforminfo.py:
741         (PlatformInfo._determine_win_version):
742
743 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
744
745         Content blockers should be able to promote http to https
746         https://bugs.webkit.org/show_bug.cgi?id=148966
747
748         Reviewed by Benjamin Poulain.
749
750         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
751         (WebCore::ContentExtensions::operator<<):
752         (TestWebKitAPI::TEST_F):
753
754 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
755
756         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
757         https://bugs.webkit.org/show_bug.cgi?id=152516
758
759         Reviewed by Gyuyoung Kim.
760
761         * MiniBrowser/efl/main.c:
762
763 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
764
765         Unreviewed: Add John Wilander as a contributor.
766
767         * Scripts/webkitpy/common/config/contributors.json:
768
769 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
770
771         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
772         https://bugs.webkit.org/show_bug.cgi?id=152482
773
774         Reviewed by Brent Fulgham.
775
776         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
777         for the same property. On WK2, the element returned will not be valid, but is still present and
778         that can lead to looping.
779
780         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
781         (AccessibilityUIElement::horizontalScrollbar):
782         (AccessibilityUIElement::verticalScrollbar):
783         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
784         (WTR::AccessibilityUIElement::horizontalScrollbar):
785         (WTR::AccessibilityUIElement::verticalScrollbar):
786
787 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
788
789         Unreviewed.
790
791         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
792
793 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
794
795         [EFL] test_ewk2_context failed after r192808
796         https://bugs.webkit.org/show_bug.cgi?id=151846
797
798         Reviewed by Gyuyoung Kim.
799
800         Used the added ewk_context_web_process_count_limit_set api
801         instead of the deprecated ewk_context_process_model_set.
802
803         * MiniBrowser/efl/main.c:
804         (elm_main):
805
806 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
807
808         Unreviewed, move myself to reviewer list.
809
810         * Scripts/webkitpy/common/config/contributors.json:
811
812 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
813
814         Unreviewed, add myself to the committers list.
815
816         * Scripts/webkitpy/common/config/contributors.json:
817
818 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
819
820         [GTK] jquery.min.js violates DFSG
821         https://bugs.webkit.org/show_bug.cgi?id=152428
822
823         Reviewed by Joseph Pecoraro.
824
825         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
826         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
827
828         * gtk/manifest.txt.in:
829
830 2015-12-19  Dan Bernstein  <mitz@apple.com>
831
832         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
833         https://bugs.webkit.org/show_bug.cgi?id=152462
834
835         Reviewed by Alexey Proskuryakov.
836
837         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
838           OS X 10.9:
839
840         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
841         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
842         * MiniBrowser/Configurations/DebugRelease.xcconfig:
843         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
844         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
845
846         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
847           never getting compiled:
848
849         * DumpRenderTree/mac/TextInputController.m:
850         * MiniBrowser/mac/BrowserWindowController.m:
851         * TestWebKitAPI/Tests/mac/AttributedString.mm:
852         * WebKitTestRunner/mac/EventSenderProxy.mm:
853
854 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
855
856         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
857
858         This is to make it easy to CC it on Bugzilla.
859
860         * Scripts/webkitpy/common/config/contributors.json:
861
862 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
863
864         Pasteboard get messed up after running kill-old-processes
865         https://bugs.webkit.org/show_bug.cgi?id=152426
866
867         Reviewed by Alexey Proskuryakov.
868
869         * BuildSlaveSupport/kill-old-processes:
870         (main): Do not kill pasteboard anymore.
871
872 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
873
874         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
875         https://bugs.webkit.org/show_bug.cgi?id=152157
876         <rdar://problem/23851817>
877
878         Reviewed by Alexey Proskuryakov.
879
880         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
881         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
882         * Scripts/webkitpy/layout_tests/controllers/manager.py:
883         (Manager._get_test_inputs): Common method to calculate test_inputs.
884         (Manager._update_worker_count): Calculate and update required number of workers.
885
886 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
887
888         run-webkit-tests fails to delete Simulator device during cleanup
889         https://bugs.webkit.org/show_bug.cgi?id=152363
890
891         Reviewed by Alexey Proskuryakov.
892
893         * Scripts/webkitpy/xcode/simulator.py:
894         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
895
896 2015-12-16  Tim Horton  <timothy_horton@apple.com>
897
898         [mac-wk2] fast/events force click tests crashing
899         https://bugs.webkit.org/show_bug.cgi?id=152339
900
901         Reviewed by Beth Dakin.
902
903         * WebKitTestRunner/mac/EventSenderProxy.mm:
904         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
905         Set the NSEvent's _type member in addition to overriding -type,
906         because there are assertions in touch event handling code that depend on it.
907
908 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
909
910         Enforce temporarily bots to sync WebKit and WPT testharness.js
911         https://bugs.webkit.org/show_bug.cgi?id=152334
912
913         Reviewed by Darin Adler.
914
915         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
916         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
917
918 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
919
920         [Fetch API] Add fetch API compile time flag
921         https://bugs.webkit.org/show_bug.cgi?id=152254
922
923         Reviewed by Darin Adler.
924
925         * Scripts/webkitperl/FeatureList.pm:
926
927 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
928
929         Unreviewed.
930
931         Added files that have impact in building Streams API to the watchlist.
932
933         * Scripts/webkitpy/common/config/watchlist:
934
935 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
936
937         Unreviewed.
938
939         Added imported tests to Streams API watchlist.
940
941         * Scripts/webkitpy/common/config/watchlist:
942
943 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
944
945         Remove default copy of wpt testharness.js when launching wpt server
946         https://bugs.webkit.org/show_bug.cgi?id=152298
947
948         Reviewed by Darin Adler.
949
950         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
951         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
952
953 2015-12-15  David Kilzer  <ddkilzer@apple.com>
954
955         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
956         <http://webkit.org/b/152314>
957
958         Reviewed by Daniel Bates.
959
960         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
961         code path to exit immediately when calling main().
962         Unfortunately, DumpRenderTreeMain.mm was used for both
963         DumpRenderTree command-line binary and DumpRenderTree.app, which
964         meant that the app would exit immediately with no error code
965         when run!
966
967         The workaround is to introduce a separate source file called
968         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
969         already does.
970
971         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
972         DumpRenderTreeAppMain.mm to the project.  Make it the only
973         compiled source for the DumpRenderTree.app target.
974         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
975         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
976         case someone tries mistakenly to use the app.
977         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
978         Link to JavaScriptCore.framework on iOS for the assert.
979         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
980         Link to JavaScriptCore.framework on OS X for the assert.  Remove
981         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
982         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
983         (main): Add assert for iOS so that a crash occurs if someone
984         tries to run the wrong command.
985
986 2015-12-14  Tim Horton  <timothy_horton@apple.com>
987
988         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
989         https://bugs.webkit.org/show_bug.cgi?id=152266
990         <rdar://problem/22092676>
991
992         Reviewed by Simon Fraser.
993
994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
995         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
996         Add a test that crashed before this change, and doesn't crash after.
997
998 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
999
1000         AX: iOS: Text field variations do not have the correct traits
1001         https://bugs.webkit.org/show_bug.cgi?id=152237
1002
1003         Reviewed by Mario Sanchez Prada.
1004
1005         Add iOS calls for determing if an object is a search field or a text area.
1006
1007         * DumpRenderTree/AccessibilityUIElement.cpp:
1008         (getIsSearchFieldCallback):
1009         (getIsTextAreaCallback):
1010         (stringForSelectionCallback):
1011         (AccessibilityUIElement::getJSClass):
1012         * DumpRenderTree/AccessibilityUIElement.h:
1013         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1014         (AccessibilityUIElement::identifier):
1015         (AccessibilityUIElement::isTextArea):
1016         (AccessibilityUIElement::isSearchField):
1017         (AccessibilityUIElement::traits):
1018         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1019         (WTR::AccessibilityUIElement::scrollPageRight):
1020         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1021         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1022         (WTR::AccessibilityUIElement::isSearchField):
1023         (WTR::AccessibilityUIElement::isTextArea):
1024         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1025         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1026         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1027         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1028         (WTR::AccessibilityUIElement::isTextArea):
1029         (WTR::AccessibilityUIElement::isSearchField):
1030         (WTR::AccessibilityUIElement::rowCount):
1031
1032 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1033
1034         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1035         https://bugs.webkit.org/show_bug.cgi?id=152252
1036
1037         Reviewed by Sergio Villar Senin.
1038
1039         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1040         for building the JHBuild on Debian systems.
1041
1042 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1043
1044         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1045         https://bugs.webkit.org/show_bug.cgi?id=152156
1046
1047         Reviewed by Dan Bernstein.
1048
1049         Our frameworks should appropriately prefix all ObjC classes,
1050         not just external symbols.
1051
1052         * Scripts/check-for-inappropriate-objc-class-names:
1053         Remove the -g switch to check all ObjC class names.
1054
1055 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1056
1057         [MediaStream] Expose media capture devices persistent permissions to WebCore
1058         https://bugs.webkit.org/show_bug.cgi?id=152087
1059
1060         Add support for the new user media permission checker page UI client method.
1061
1062         Reviewed by Chris Dumez.
1063
1064         * WebKitTestRunner/TestController.cpp:
1065         (WTR::decidePolicyForUserMediaPermissionRequest):
1066         (WTR::checkUserMediaPermissionForOrigin):
1067         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1068         (WTR::TestController::createWebViewWithOptions): Ditto.
1069         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1070         (WTR::originUserVisibleName): New, create a string for the origin.
1071         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1072           according to the state of the origin permission map.
1073         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1074           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1075         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1076           origin permission map.
1077         * WebKitTestRunner/TestController.h:
1078
1079 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1080
1081         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1082         https://bugs.webkit.org/show_bug.cgi?id=152022
1083         rdar://problem/23763584
1084
1085         Reviewed by Darin Adler.
1086
1087         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1088         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1089         (WTR::InjectedBundlePage::willSendRequestForFrame):
1090         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1091         (WTR::TestRunner::setWillSendRequestReturnsNull):
1092         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1093         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1094         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1095         (WTR::TestRunner::willSendRequestHTTPBody):
1096         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1097
1098 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1099
1100         Remove additional simulator checks before running layout-tests
1101         https://bugs.webkit.org/show_bug.cgi?id=152146
1102
1103         Reviewed by Darin Adler.
1104
1105         * Scripts/webkitpy/port/ios.py:
1106         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1107         * Scripts/webkitpy/xcode/simulator.py:
1108         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1109         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1110
1111 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1112
1113         Run atleast one simulator even if max process limit is low
1114         https://bugs.webkit.org/show_bug.cgi?id=152081
1115         <rdar://problem/23819694>
1116
1117         Reviewed by Alexey Proskuryakov.
1118
1119 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1120
1121         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1122         https://bugs.webkit.org/show_bug.cgi?id=144262
1123
1124         Reviewed by Carlos Garcia Campos.
1125
1126         Added new unit test to check the additional scenarios we now
1127         handle for custom URI schemes.
1128
1129         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1130         (generateHTMLContent): New helper function to generate big enough content.
1131         (testWebContextURIScheme): New unit test.
1132
1133 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1134
1135         [EFL] Fix unhandled web process message when launching MiniBrowser
1136         https://bugs.webkit.org/show_bug.cgi?id=152048
1137
1138         Reviewed by Gyuyoung Kim.
1139
1140         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1141         (TestWebKitAPI::TEST):
1142
1143 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         [GTK] Add API to handle beforeunload events
1146         https://bugs.webkit.org/show_bug.cgi?id=139090
1147
1148         Reviewed by Gustavo Noronha Silva.
1149
1150         * MiniBrowser/gtk/BrowserWindow.c:
1151         (browserWindowConstructed):
1152         (browserWindowDeleteEvent):
1153         (browser_window_class_init):
1154         Handle delete-event to prevent the window from being closed when
1155         the page has beforeunload handlers. Use
1156         webkit_web_view_try_close() when the window is requested to be
1157         closed.
1158         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1159         (testWebViewJavaScriptDialogs):
1160         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1161         script dialog type.
1162
1163 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1164
1165         Refactored initialization code in LoadTrackingTest.
1166
1167         Rubber-stamped by Carlos Garcia Campos.
1168
1169         Small refactoring to make sure that the state of a LoadTrackingTest
1170         gets properly reset before loading new web content.
1171
1172         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1173         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1174         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1175         functions and reset the remaining local variables.
1176         (LoadTrackingTest::loadURI): Call reset();
1177         (LoadTrackingTest::loadHtml): Ditto.
1178         (LoadTrackingTest::loadPlainText): Ditto.
1179         (LoadTrackingTest::loadBytes): Ditto.
1180         (LoadTrackingTest::loadRequest): Ditto.
1181         (LoadTrackingTest::reload): Ditto.
1182         (LoadTrackingTest::goBack): Ditto.
1183         (LoadTrackingTest::goForward): Ditto.
1184
1185 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1186
1187         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1188         https://bugs.webkit.org/show_bug.cgi?id=151942
1189
1190         Reviewed by Darin Adler.
1191
1192         * MiniBrowser/efl/main.c:
1193         (window_create): Enable offline web application cache feature on MiniBrowser.
1194         (elm_main):
1195
1196 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1197
1198         https://bugs.webkit.org/show_bug.cgi?id=151243
1199         <rdar://problem/22955197>
1200
1201         Reviewed by Alexey Proskuryakov.
1202
1203         * LayoutTestRelay/LayoutTestRelay/main.m:
1204         (getTestingSimDevice): Use separate testing device for each worker.
1205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1206         (Manager.run): Perform cleanup even if setup fails.
1207         * Scripts/webkitpy/port/ios.py:
1208         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1209         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1210         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1211         (IOSSimulatorPort._quit_ios_simulator): Same
1212         (IOSSimulatorPort.clean_up_test_run): Same
1213         (IOSSimulatorPort.check_sys_deps): Same
1214         (IOSSimulatorPort.testing_device): Same
1215         (IOSSimulatorPort.reset_preferences): Same
1216         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1217         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1218         * Scripts/webkitpy/xcode/simulator.py:
1219         (Device.delete): Delete the simulator device.
1220         (Simulator.delete_device): Same
1221         (Simulator.wait_until_device_is_booted): Wait for device booting.
1222
1223 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1224
1225         [EFL] Add API to provide preferences before creating ewk_view
1226         https://bugs.webkit.org/show_bug.cgi?id=151587
1227
1228         Reviewed by Gyuyoung Kim.
1229
1230         * MiniBrowser/efl/main.c:
1231         (on_key_down):
1232         (quit):
1233         (window_create):
1234         Moved settings related code to configuration() not to update settings
1235         whenever ewk_view is created.
1236         (configuration):
1237         (elm_main):
1238
1239 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1240
1241         Unreviewed. Fix GTK+ API tests after r193639.
1242
1243         The new jhbuild version needs some more variables ot be present in
1244         the builtin dict, even if they are set to None.
1245
1246         * jhbuild/jhbuildutils.py:
1247         (enter_jhbuild_environment_if_available):
1248
1249 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1250
1251         [GTK] Notify WebCore when notification is clicked
1252         https://bugs.webkit.org/show_bug.cgi?id=151951
1253
1254         Reviewed by Carlos Garcia Campos.
1255
1256         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1257         (testWebViewNotification): test the new API.
1258
1259 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1260
1261         'jhbuild build' should fail immediately when building any module fails
1262         https://bugs.webkit.org/show_bug.cgi?id=145697
1263
1264         Reviewed by Carlos Garcia Campos.
1265
1266         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1267         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1268         Everything is placed under lib instead of lib64 now.
1269         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1270         --exit-on-error when running 'jhbuild build'.
1271         * jhbuild/jhbuildrc_common.py:
1272         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1273         jhbuild should be able to handle these for us without breaking things....
1274
1275 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1276
1277         Add support to import w3c tests from a repository with a different root that the main repo dir
1278         https://bugs.webkit.org/show_bug.cgi?id=151751
1279
1280         Reviewed by Ryosuke Niwa and Youenn Fablet.
1281
1282         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1283         in a different directory than the repository root.
1284
1285         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1286         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1287         requires having the copy_path lists including tuples of origin and destination directories.
1288
1289         * Scripts/webkitpy/w3c/test_downloader.py:
1290         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1291         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1292         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1293         (TestImporterTest.test_tests_directory): Test.
1294
1295 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1296
1297         Mock TestRepositories in W3C importer tests
1298         https://bugs.webkit.org/show_bug.cgi?id=151938
1299
1300         Reviewed by Youenn Fablet.
1301
1302         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1303         is because the test repository method reading the file was using the filesystem directly instead of taking the
1304         host one. This patch changes that.
1305
1306         * Scripts/webkitpy/w3c/test_downloader.py:
1307         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1308         default one.
1309         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1310         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1311         (TestImporterTest.test_harnesslinks_conversion):
1312         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1313
1314 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1315
1316         TestNetscapePlugIn: Address review comment on 193607
1317         <http://webkit.org/b/151881>
1318
1319         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1320         (testSetStatus): Initializing std::unique_ptr<char[]> with
1321         nullptr is redundant.
1322
1323 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1324
1325         [GTK] Add webkit_uri_request_get_http_method
1326         https://bugs.webkit.org/show_bug.cgi?id=151601
1327
1328         Reviewed by Martin Robinson.
1329
1330         Add test case to check HTTP method of WebKitURIRequest.
1331
1332         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1333         (testURIRequestHTTPMethod):
1334         (serverCallback):
1335         (beforeAll):
1336         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1337         (sendRequestCallback):
1338
1339 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1342         https://bugs.webkit.org/show_bug.cgi?id=79918
1343
1344         Reviewed by Gustavo Noronha Silva.
1345
1346         Add unit tests to check the different console messages.
1347
1348         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1349         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1350         (ConsoleMessageTest::ConsoleMessage::operator==):
1351         (ConsoleMessageTest::consoleMessageReceivedCallback):
1352         (ConsoleMessageTest::ConsoleMessageTest):
1353         (ConsoleMessageTest::~ConsoleMessageTest):
1354         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1355         (testWebKitConsoleMessageConsoleAPI):
1356         (testWebKitConsoleMessageJavaScriptException):
1357         (testWebKitConsoleMessageNetworkError):
1358         (testWebKitConsoleMessageSecurityError):
1359         (beforeAll):
1360         (afterAll):
1361         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1362         (consoleMessageSentCallback):
1363         (pageCreatedCallback):
1364
1365 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1366
1367         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1368         https://bugs.webkit.org/show_bug.cgi?id=151934
1369
1370         Reviewed by Csaba Osztrogonác.
1371
1372         * MiniBrowser/efl/main.c:
1373         (on_window_deletion): Revert the changes of r192767.
1374
1375 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1376
1377         [GTK] update-webkitgtk-libs cannot build mesa
1378         https://bugs.webkit.org/show_bug.cgi?id=151535
1379
1380         Reviewed by Martin Robinson.
1381
1382         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1383         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1384         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1385         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1386         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1387         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1388
1389         * gtk/jhbuild.modules:
1390
1391 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1392
1393         [GTK][Mac] libWebExtensionTest link error
1394         https://bugs.webkit.org/show_bug.cgi?id=150802
1395
1396         Reviewed by Carlos Garcia Campos.
1397
1398         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1399
1400 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1401
1402         TestNetscapePlugIn: Fix leaks found by static analyzer
1403         <http://webkit.org/b/151881>
1404
1405         Reviewed by Darin Adler.
1406
1407         Fixes the following leaks found by the static analyzer:
1408             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1409                     return false;
1410                            ^~~~~
1411             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1412                     return false;
1413                            ^~~~~
1414             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1415                     return false;
1416                            ^~~~~
1417
1418         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1419         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1420         early return if allocation fails.
1421         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1422         Make sure to call fclose() on filehandle, even for an early
1423         return.
1424         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1425
1426 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1427
1428         prepare-ChangeLog: Fix some warning messages when using svn
1429         <http://webkit.org/b/151914>
1430
1431         Reviewed by Daniel Bates.
1432
1433         * Scripts/prepare-ChangeLog:
1434         (generateFunctionLists): Simplify logic so that we never call
1435         normalizePath() with an undefined value.
1436         (attributeCommand): Quote $subPath for the shell so that we
1437         don't try to run "svn propget" on invalid paths.
1438
1439 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1440
1441         TestNetscapePlugIn: Fix remaining static analyzer warnings
1442         <http://webkit.org/b/151888>
1443
1444         Reviewed by Alexey Proskuryakov.
1445
1446         Fixes the following static analyzer warnings:
1447             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1448                     CRASH();
1449                     ^~~~~~~
1450             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1451                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1452                 ^~~~~~~~~~~~~~~~
1453             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1454                 return obj->pluginTest->NPP_SetWindow(window);
1455                        ^~~~~~~~~~~~~~~
1456             2 warnings generated.
1457
1458         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1459         (CRASH): Use __builtin_trap() for gcc/clang.
1460         (NPP_SetWindow): Add early return if obj is nullptr.
1461
1462 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1463
1464         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1465         https://bugs.webkit.org/show_bug.cgi?id=151797
1466
1467         Reviewed by Martin Robinson.
1468
1469         Since we switched to use the network process to run the unit tests
1470         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1471         sometimes passes. We are now also getting the notification for the
1472         css image. Since we wait for 3 resources, sometimes the css image
1473         is loaded before and then checkResourceData is called for it, but
1474         not handled. When the css image is the last one loaded the test
1475         passes. So, we just need to wait for the 4 resources.
1476
1477         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1478         (testWebResourceGetData):
1479
1480 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1481
1482         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1483         <http://webkit.org/b/151845>
1484
1485         Reviewed by Simon Fraser.
1486
1487         Fixes the following static analyzer warning:
1488             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1489                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1490                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1491
1492         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1493         (createBitmapContext): Free 'buffer' after using it in logging
1494         to fix the use-after-free.  Assign a value of nullptr to buffer
1495         so we don't return with it set to a freed address.
1496
1497 2015-12-03  Jer Noble  <jer.noble@apple.com>
1498
1499         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1500         https://bugs.webkit.org/show_bug.cgi?id=151830
1501
1502         Reviewed by Anders Carlsson.
1503
1504         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1505
1506         * DumpRenderTree/mac/DumpRenderTree.mm:
1507         (resetWebPreferencesToConsistentValues):
1508         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1509         (WTR::initializeWebViewConfiguration):
1510
1511 2015-12-03  Anders Carlsson  <andersca@apple.com>
1512
1513         Remove Objective-C GC support
1514         https://bugs.webkit.org/show_bug.cgi?id=151819
1515         rdar://problem/23746991
1516
1517         Reviewed by Dan Bernstein.
1518
1519         * asan/asan.xcconfig:
1520
1521 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1522
1523         Allow nil for unspecified benchmark pathes
1524         https://bugs.webkit.org/show_bug.cgi?id=151784
1525
1526         Reviewed by Filip Pizlo.
1527
1528         `Pathname.new(nil)` will raise an error.
1529         Only generate Pathname if the benchmark path is specified.
1530
1531         * Scripts/run-jsc-benchmarks:
1532
1533 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1534
1535         [Win] Run non-http tests without Cygwin
1536         https://bugs.webkit.org/show_bug.cgi?id=151721
1537
1538         Reviewed by Andy Estes.
1539
1540         Support native 32-bit and 64-bit Python (and Perl) builds
1541         for running tests:
1542
1543         1. Use "startswith('win')", rather than "== 'win32'" to support
1544         various Windows build types.
1545         2. Supply full path for some native Windows utilities, since the
1546         path environment does not always have the specified, and they are
1547         guaranteed to exist in those specific locations.
1548         3. Make sure native Windows Python test runs pass proper environment
1549         variables to run programs.
1550         4. Append 'exe' suffix when running Windows executables.
1551         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1552         command doesn't exist.
1553         
1554         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1555         the current Perl executable, rather than requiring a new path search.
1556         * Scripts/webkitpy/common/find_files_unittest.py:
1557         (TestWinNormalize.test_win): Use startswith('win').
1558         * Scripts/webkitpy/common/prettypatch_unittest.py:
1559         (test_pretty_diff_encodings): Ditto.
1560         * Scripts/webkitpy/common/system/executive.py:
1561         (Executive._should_close_fds): Ditto.
1562         (Executive.shell_command_for_script): Use startswith('win').
1563         (Executive.kill_process): Use full path to killall executable.
1564         (Executive.check_running_pid): Use startswith('win').
1565         (Executive.running_pids): Ditto.
1566         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1567         running under native Windows Python.
1568         (Executive._child_process_encoding): Use startswith('win').
1569         (Executive._should_encode_child_process_arguments): Ditto.
1570         (Executive.popen): Recognize proper script engine on Windows, since it
1571         does not support the shebang syntax.
1572         (Executive.run_in_parallel): Use startswith('win').
1573         * Scripts/webkitpy/common/system/executive_unittest.py:
1574         (never_ending_command): Ditto.
1575         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1576         (ExecutiveTest.serial_test_kill_process): Ditto.
1577         (ExecutiveTest.serial_test_kill_all): Ditto.
1578         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1579         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1580         (main): Ditto.
1581         * Scripts/webkitpy/common/system/file_lock.py:
1582         (FileLock._create_lock): Ditto.
1583         (FileLock._remove_lock): Ditto.
1584         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1585         (RealFileSystemTest.test_chdir): Ditto.
1586         (RealFileSystemTest.test_chdir__notexists): Ditto.
1587         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1588         * Scripts/webkitpy/common/system/path_unittest.py:
1589         (AbspathTest.test_abspath_to_uri_win): Ditto.
1590         * Scripts/webkitpy/common/system/platforminfo.py:
1591         (PlatformInfo._determine_os_name): Ditto.
1592         * Scripts/webkitpy/common/system/user.py: Ditto.
1593         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1594         (ManagerTest.integration_test_needs_servers): Ditto.
1595         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1596         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1597         driver letters.
1598         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1599         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1600         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1601         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1602         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1603         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1604         (TestHttpServer.test_start_cmd): Ditto.
1605         * Scripts/webkitpy/port/base.py:
1606         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1607         and 'SYSTEMROOT' in environment passed to test runners.
1608         (Port._apache_config_file_name_for_platform): Use startswith('win').
1609         (Port._build_path): Ditto.
1610         (Port._path_to_driver): Include 'exe' suffix when running under native
1611         Windows.
1612         * Scripts/webkitpy/port/driver.py:
1613         (Driver._setup_environ_for_driver): Explicitly make some environment
1614         variables strings.
1615         * Scripts/webkitpy/port/server_process.py:
1616         (ServerProcess.__init__): Use startswith('win').
1617         * Scripts/webkitpy/port/win.py:
1618         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1619         registry key formats.
1620         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1621         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1622         and regtool on Cygwin.
1623         (WinPort.write_registry_value): Ditto.
1624         (WinPort.setup_crash_log_saving): Ditto.
1625         (WinPort.restore_crash_log_saving): Ditto.
1626         (WinPort.prevent_error_dialogs): Ditto.
1627         (WinPort.allow_error_dialogs): Ditto.
1628         (WinPort.find_system_pid): Revise to use Windows management
1629         infrastructure on native Windows, continue using 'ps' on Cygwin.
1630         (WinPort.read_registry_string): Deleted.
1631         (WinPort.write_registry_string): Deleted.
1632         * Scripts/webkitpy/test/main.py:
1633         (main): Use startswith('win').
1634         (Tester._parse_args): Ditto.
1635
1636 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1637
1638         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1639         https://bugs.webkit.org/show_bug.cgi?id=150792
1640
1641         Reviewed by Saam Barati.
1642
1643         * Scripts/webkitperl/FeatureList.pm:
1644
1645 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1646
1647         Unreviewed, rolling out r192914.
1648         https://bugs.webkit.org/show_bug.cgi?id=151734
1649
1650         JSC tests for this change are failing on 32 and 64-bit bots
1651         (Requested by ryanhaddad on #webkit).
1652
1653         Reverted changeset:
1654
1655         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1656         enable this feature"
1657         https://bugs.webkit.org/show_bug.cgi?id=150792
1658         http://trac.webkit.org/changeset/192914
1659
1660 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1661
1662         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1663         <http://webkit.org/b/151726>
1664
1665         Reviewed by Simon Fraser.
1666
1667         * WebKitTestRunner/mac/EventSenderProxy.mm:
1668         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1669         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1670
1671 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1672
1673         Give String and AtomicString an existingHash() function
1674         https://bugs.webkit.org/show_bug.cgi?id=151717
1675
1676         Reviewed by Andreas Kling.
1677
1678         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1679         (TestWebKitAPI::TEST):
1680         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1681         (TestWebKitAPI::TEST):
1682
1683 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1684
1685         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1686         https://bugs.webkit.org/show_bug.cgi?id=150792
1687
1688         Reviewed by Saam Barati.
1689
1690         * Scripts/webkitperl/FeatureList.pm:
1691
1692 2015-12-01  Sam Weinig  <sam@webkit.org>
1693
1694         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1695         <rdar://problem/23320863>
1696         https://bugs.webkit.org/show_bug.cgi?id=151708
1697
1698         Reviewed by Anders Carlsson.
1699
1700         * WebKitTestRunner/TestController.cpp:
1701         (WTR::TestController::createOtherPage):
1702         (WTR::TestController::createWebViewWithOptions):
1703         Update for new WKPageUIClient.
1704
1705 2015-12-01  Anders Carlsson  <andersca@apple.com>
1706
1707         Remove WebKit2.framework
1708         https://bugs.webkit.org/show_bug.cgi?id=151715
1709
1710         Reviewed by Dan Bernstein.
1711
1712         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1713         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1714         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1715         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1716         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1717         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1718         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1719
1720 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1721
1722         Unreviewed common typo fix "occurance" => "occurrence".
1723
1724         * Scripts/webkitpy/tool/commands/queries.py:
1725         (FindFlakyTests._print_statistics):
1726
1727 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1728
1729         Make ProcessModel always MultipleSecondaryProcesses
1730         https://bugs.webkit.org/show_bug.cgi?id=151662
1731
1732         Reviewed by Antti Koivisto.
1733
1734         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1735         (TestWebKitAPI::TEST):
1736         * WebKitTestRunner/TestController.cpp:
1737         (WTR::TestController::generatePageConfiguration):
1738
1739 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1740
1741         Make usesNetworkProcess always true
1742         https://bugs.webkit.org/show_bug.cgi?id=151580
1743
1744         Reviewed by Darin Adler.
1745
1746         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1747         (TestWebKitAPI::TEST):
1748         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1749         (TestWebKitAPI::TEST):
1750         * WebKitTestRunner/TestController.cpp:
1751         (WTR::TestController::generatePageConfiguration):
1752
1753 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1754
1755         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1756
1757         Add a way to skip unit tests only for Debug or Release builds and
1758         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1759
1760         * Scripts/run-gtk-tests:
1761         (SkippedTest):
1762         (SkippedTest.__init__):
1763         (SkippedTest.__str__):
1764         (SkippedTest.skip_entire_suite):
1765         (SkippedTest.skip_for_build_type):
1766         (TestRunner):
1767         (TestRunner.__init__):
1768
1769 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1770
1771         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1772
1773         It's an assert hit because we are reloading a view loaded with
1774         HTML data which is not supported. Use loadURI instead.
1775
1776         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1777         (testWebViewCustomCharset):
1778
1779 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1780
1781         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1782         https://bugs.webkit.org/show_bug.cgi?id=151633
1783
1784         Reviewed by Csaba Osztrogonác.
1785
1786         * TestWebKitAPI/PlatformGTK.cmake:
1787         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1788
1789 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1790
1791         [GTK] Remove the remaining uses of GMainLoopSource
1792         https://bugs.webkit.org/show_bug.cgi?id=151632
1793
1794         Reviewed by Žan Doberšek.
1795
1796         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1797         (testWebViewSyncRequestOnMaxConns):
1798         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1800         (WTR::TestRunner::TestRunner):
1801         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1802         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1803         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1804         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1805         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1806         (WTR::timeoutSource):
1807         (WTR::TestController::notifyDone):
1808         (WTR::TestController::platformRunUntil):
1809
1810 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1811
1812         [cmake] Add testb3 to the build system
1813         https://bugs.webkit.org/show_bug.cgi?id=151619
1814
1815         Reviewed by Gyuyoung Kim.
1816
1817         * Scripts/build-jsc:
1818
1819 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1820
1821         [jhbuild] Fix pixman build with clang
1822         https://bugs.webkit.org/show_bug.cgi?id=151441
1823
1824         Reviewed by Carlos Garcia Campos.
1825
1826         * efl/jhbuild.modules:
1827         * gtk/jhbuild.modules:
1828
1829 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1830
1831         Extract prependToEnvironmentVariableList
1832         <http://webkit.org/b/151536>
1833
1834         Reviewed by Daniel Bates.
1835
1836         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1837                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1838
1839         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1840         and prependToEnvironmentVariableList.
1841         (appendToEnvironmentVariableList): Simplify variable name.
1842         Switch to use $Config{path_sep}.
1843         (prependToEnvironmentVariableList): Add new method.
1844         (setupMacWebKitEnvironment): Switch to use
1845         prependToEnvironmentVariableList().
1846         (setupIOSWebKitEnvironment): Ditto.
1847
1848         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1849         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1850
1851 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1852
1853         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1854         https://bugs.webkit.org/show_bug.cgi?id=151567
1855
1856         Reviewed by Darin Adler.
1857
1858         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1859         (on_window_deletion):
1860
1861 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1862
1863         [GTK] Use the network process unconditionally
1864         https://bugs.webkit.org/show_bug.cgi?id=151541
1865
1866         Reviewed by Alex Christensen.
1867
1868         Fix TestInspectorServer test. Do not assume we already have the
1869         title we want when the page has been loaded, since the title is
1870         changed afterwards. So, check if the title has already been set,
1871         and if not wait for it.
1872
1873         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1874         (openRemoteDebuggingSession):
1875
1876 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1877
1878         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1879         https://bugs.webkit.org/show_bug.cgi?id=151532
1880
1881         Reviewed by Benjamin Poulain.
1882
1883         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1884         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1885         (TestWebKitAPI::TEST):
1886         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1887         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1888         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1889         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1890         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1891         so it was calling a function on a test object that had gone out of scope.
1892         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1893         but that will become the default soon and that call will be removed.
1894
1895 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1896
1897         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1898         <http://webkit.org/b/151542>
1899
1900         Reviewed by Daniel Bates.
1901
1902         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1903         (base_url): Use the Port object (already passed in) to give us
1904         the path to the LayoutTests directory, which already checks for a
1905         --layout-tests-directory command-line switch.
1906         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1907         argument since we can get this from the Port object already
1908         passed in via Port.results_directory().  Also switch to use
1909         Port.layout_tests_dir() to get the LayoutTests directory.
1910
1911         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1912         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1913         Add test case for custom LayoutTests directory.
1914         (TestWebPlatformTestServer.test_previously_spawned_instance):
1915         Update Port object to set mock results directory as if it was
1916         set on the command-line.  Remove unneeded argument from
1917         WebPlatformTestServer constructor.
1918         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1919
1920         * Scripts/webkitpy/port/base.py:
1921         (Port.to.start_web_platform_test_server): Remove unneeded
1922         argument from WebPlatformTestServer constuctor.
1923
1924 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1925
1926         [GTK] Some unit tests fail when using the network process
1927         https://bugs.webkit.org/show_bug.cgi?id=151490
1928
1929         Reviewed by Martin Robinson.
1930
1931         Run the soup server in a separate thread in TestResources test to
1932         avoid deadlocks.
1933
1934         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1935         /webkit2/WebKitWebResource/get-data when using the network process.
1936
1937         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1938         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1939         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1940         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1941         present, create a WorkQueue to run the server.
1942         (WebKitTestServer::run): Run the server in the work queue if it
1943         has been created.
1944         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1945         type into server options as flags.
1946
1947 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1948
1949         [GTK] ImageDiff should normalize the diff image
1950         https://bugs.webkit.org/show_bug.cgi?id=151261
1951
1952         Reviewed by Sergio Villar Senin.
1953
1954         * ImageDiff/gtk/ImageDiff.cpp:
1955         (readPixbufFromStdin): Fix memory leak.
1956         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1957         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1958
1959 == Rolled over to ChangeLog-2015-11-21 ==