b1ff849b0c3696d4ef0ed85994428e94414347be
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-27  John Wilander  <wilander@apple.com>
2
3         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4         https://bugs.webkit.org/show_bug.cgi?id=195071
5         <rdar://problem/48417690>
6
7         Reviewed by Alex Christensen and Brent Fulgham.
8
9         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
10         (TestWebKitAPI::createURL):
11             Convenience function.
12         (TestWebKitAPI::TEST):
13             WebCore::AdClickAttribution now takes a URL when creating Source and
14             Destination.
15         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
16         (TestWebKitAPI::TEST):
17             WebCore::AdClickAttribution now takes a URL when creating Source and
18             Destination.
19
20 2019-02-27  Antoine Quint  <graouts@apple.com>
21
22         Support Pointer Events on macOS
23         https://bugs.webkit.org/show_bug.cgi?id=195008
24         <rdar://problem/47454419>
25
26         Reviewed by Dean Jackson.
27
28         * DumpRenderTree/mac/DumpRenderTree.mm:
29         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
30         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
31
32 2019-02-26  Mark Lam  <mark.lam@apple.com>
33
34         Remove remaining poisoning code.
35         https://bugs.webkit.org/show_bug.cgi?id=194138
36
37         Reviewed by Saam Barati.
38
39         * TestWebKitAPI/CMakeLists.txt:
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
42         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
43         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
44         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
45         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
46         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
47
48 2019-02-26  Alex Christensen  <achristensen@webkit.org>
49
50         Move ephemeral local storage from WebProcess to UIProcess
51         https://bugs.webkit.org/show_bug.cgi?id=195074
52         <rdar://problem/47937975>
53
54         Reviewed by Geoff Garen.
55
56         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
57
58 2019-02-20  Jer Noble  <jer.noble@apple.com>
59
60         [Cocoa] Media elements will restart network buffering just before suspending
61         https://bugs.webkit.org/show_bug.cgi?id=193691
62
63         Reviewed by Eric Carlson.
64
65         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
66         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
67         (TEST):
68
69 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
70
71         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
72         https://bugs.webkit.org/show_bug.cgi?id=191652
73
74         Reviewed by Alex Christensen.
75
76         Fix WinCairo MiniBrowser behavior of authentication dialog.
77
78         * MiniBrowser/win/WebKitBrowserWindow.cpp:
79         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
80
81 2019-02-26  Youenn Fablet  <youenn@apple.com>
82
83         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
84         https://bugs.webkit.org/show_bug.cgi?id=195028
85         <rdar://problem/48243733>
86
87         Reviewed by Eric Carlson.
88
89         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
90
91 2019-02-26  Philippe Normand  <pnormand@igalia.com>
92
93         [WPE] Add API for webview background color configuration
94         https://bugs.webkit.org/show_bug.cgi?id=192305
95
96         Reviewed by Michael Catanzaro.
97
98         * MiniBrowser/wpe/main.cpp:
99         (main): Add a new option to configure the webview background
100         color. Example: --bg-color=transparent.
101         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
102         (testWebViewBackgroundColor): Enable background color API tests for WPE.
103         (beforeAll): Ditto.
104
105 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
106
107         scalableNativeWebpageParameters() is not preserved on new page navigation.
108         https://bugs.webkit.org/show_bug.cgi?id=194892
109         <rdar://problem/47538280>
110
111         Reviewed by Wenson Hsieh.
112         
113         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
114
115         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
116         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
117         * DumpRenderTree/mac/UIScriptControllerMac.mm:
118         (WTR::UIScriptController::allowsViewportShrinkToFit):
119         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
120         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
121         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
122         * TestRunnerShared/UIScriptContext/UIScriptController.h:
123         * WebKitTestRunner/UIScriptControllerCocoa.mm:
124         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
125
126 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
127
128         [ews-app] Add model for handling multiple Buildbot instances
129         https://bugs.webkit.org/show_bug.cgi?id=194863
130
131         Reviewed by Stephanie Lewis.
132
133         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
134
135 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
136
137         [ews-app] Remove BuilderMapping table
138         https://bugs.webkit.org/show_bug.cgi?id=194961
139
140         Reviewed by Stephanie Lewis.
141
142         Store builder name directly in build table, instead of having a separate
143         table for it.
144
145         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
146         * BuildSlaveSupport/ews-app/ews/models/build.py:
147         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
148         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
149
150 2019-02-25  John Wilander  <wilander@apple.com>
151
152         Introduce and adopt new class RegistrableDomain for eTLD+1
153         https://bugs.webkit.org/show_bug.cgi?id=194791
154         <rdar://problem/48179240>
155
156         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
157
158         This patch adds an API test and replaces two instances of
159         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
160
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
163         (TestWebKitAPI::TEST):
164             Changed two strings to make sure the registrable domains are still considered
165             invalid and pass the test.
166         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
167         (TestWebKitAPI::TEST):
168         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
169         (WTR::InjectedBundle::didReceiveMessageToPage):
170
171 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
172
173         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
174         https://bugs.webkit.org/show_bug.cgi?id=195001
175
176         Reviewed by Carlos Garcia Campos.
177
178         API version 1.0 always includes the functionality previously guarded with
179         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
180         unconditionally.
181
182         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
183         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
184         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
185         (WebViewTest::showInWindow): Ditto.
186         (WebViewTest::hideView): Ditto.
187         * wpe/backends/HeadlessViewBackend.cpp:
188         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
189         * wpe/backends/ViewBackend.cpp:
190         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
191         * wpe/backends/WindowViewBackend.cpp:
192         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
193         WPE_BACKEND_CHECK_VERSION().
194         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
195
196 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
197
198         [Flatpak] Add support for flatpak > 1.1.2
199         https://bugs.webkit.org/show_bug.cgi?id=194088
200
201         Flatpak 1.2 is now out so we need to support that
202         version now.
203
204         Reviewed by Michael Catanzaro.
205
206         * flatpak/flatpakutils.py:
207         (check_flatpak):
208         (FlatpakPackages.__init__):
209         (FlatpakPackages.__detect_packages):
210         (FlatpakPackages.__detect_packages.in):
211         (FlatpakRepos.update):
212
213 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
214
215         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
216         https://bugs.webkit.org/show_bug.cgi?id=194998
217
218         Reviewed by Carlos Garcia Campos.
219
220         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
221         to a Git checkout and using the latest commit containing various fixes
222         and improvements.
223
224 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
225
226         [WPE][GTK] Remove user agent quirk for washingtonpost.com
227         https://bugs.webkit.org/show_bug.cgi?id=194981
228
229         Reviewed by Žan Doberšek.
230
231         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
232         (TestWebKitAPI::TEST):
233
234 2019-02-23  Keith Miller  <keith_miller@apple.com>
235
236         Add new mac target numbers
237         https://bugs.webkit.org/show_bug.cgi?id=194955
238
239         Reviewed by Tim Horton.
240
241         * DumpRenderTree/mac/Configurations/Base.xcconfig:
242         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
243         * MiniBrowser/Configurations/Base.xcconfig:
244         * TestWebKitAPI/Configurations/Base.xcconfig:
245         * WebKitTestRunner/Configurations/Base.xcconfig:
246
247 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
248
249         [WinCairo] Enable wk1/wk2 suffix for platform search path.
250         https://bugs.webkit.org/show_bug.cgi?id=194846
251
252         Reviewed by Don Olmstead.
253
254         Added _search_paths() and _port_specific_expectations_files() for
255         WinCairoPort.
256
257         * Scripts/webkitpy/port/win.py:
258         (WinCairoPort.default_baseline_search_path):
259         (WinCairoPort):
260         (WinCairoPort._port_specific_expectations_files):
261         (WinCairoPort._search_paths):
262
263 2019-02-22  Tim Horton  <timothy_horton@apple.com>
264
265         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
266         https://bugs.webkit.org/show_bug.cgi?id=194963
267
268         Reviewed by Dean Jackson.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
271         Do a `contains` check instead of `equals`, because in debug builds we
272         put the GraphicsLayer pointer in a prefix.
273
274 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
275
276         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
277         https://bugs.webkit.org/show_bug.cgi?id=194873
278         <rdar://problem/46701974>
279
280         Reviewed by Tim Horton.
281
282         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
283
284         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
285         (WTR::UIScriptController::menuRect const):
286         (WTR::UIScriptController::isShowingMenu const):
287         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
288         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
289         (WTR::UIScriptController::menuRect const):
290
291         Add a function to query the bounds of the callout menu in content coordinates.
292
293         (WTR::UIScriptController::isShowingMenu const):
294
295         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
296
297         * TestRunnerShared/UIScriptContext/UIScriptController.h:
298         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
299         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
300         (WTR::UIScriptController::rectForMenuAction const):
301         (WTR::UIScriptController::menuRect const):
302         (WTR::UIScriptController::isShowingMenu const):
303         (WTR::findViewInHierarchyOfType): Deleted.
304
305 2019-02-22  Chris Dumez  <cdumez@apple.com>
306
307         Regression(PSON) Unable to preview password-protected documents on iCloud.com
308         https://bugs.webkit.org/show_bug.cgi?id=194954
309         <rdar://problem/48127957>
310
311         Reviewed by Alex Christensen.
312
313         Add API test coverage.
314
315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
316         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
317         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
318         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
319
320 2019-02-22  Chris Dumez  <cdumez@apple.com>
321
322         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
323         https://bugs.webkit.org/show_bug.cgi?id=194924
324         <rdar://problem/48216125>
325
326         Reviewed by Geoffrey Garen.
327
328         Add API test coverage.
329
330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
331
332 2019-02-22  Chris Dumez  <cdumez@apple.com>
333
334         Unreviewed, disable API test added in r241928 on iOS.
335
336         The cache is not enabled on devices with less than 3GB of RAM.
337
338         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
339
340 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
341
342         Hardcode Visual Viewports on everywhere except iOS WK1
343         https://bugs.webkit.org/show_bug.cgi?id=194928
344
345         Reviewed by Zalan Bujtas.
346
347         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
348         change the default value of the Setting to 'true', and hardcode WebView on iOS to
349         set it to false. The setting has shipped for several years and there's no need to turn
350         it off now.
351
352         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
353         Visual Viewports are not enabled.
354         
355         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
356         that only runs in WK2
357
358         * MiniBrowser/mac/SettingsController.h:
359         * MiniBrowser/mac/SettingsController.m:
360         (-[SettingsController init]):
361         (-[SettingsController _populateMenu]):
362         (-[SettingsController validateMenuItem:]):
363         (-[SettingsController visualViewportEnabled]): Deleted.
364         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
365         * MiniBrowser/mac/WK1BrowserWindowController.m:
366         (-[WK1BrowserWindowController didChangeSettings]):
367         * MiniBrowser/mac/WK2BrowserWindowController.m:
368         (-[WK2BrowserWindowController didChangeSettings]):
369
370 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
371
372         Discard cached processes when clearing website data store
373         https://bugs.webkit.org/show_bug.cgi?id=194894
374
375         Reviewed by Chris Dumez.
376
377         Added a test case.
378
379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
380         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
381
382 2019-02-21  Alex Christensen  <achristensen@webkit.org>
383
384         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
385         https://bugs.webkit.org/show_bug.cgi?id=194914
386         <rdar://problem/47586889>
387
388         Reviewed by Geoffrey Garen.
389
390         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
391         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
392         (TEST):
393         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
394
395 2019-02-21  David Kilzer  <ddkilzer@apple.com>
396
397         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
398         <https://webkit.org/b/194761>
399
400         Reviewed by Myles Maxfield.
401
402         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
403         (WTR::activateSystemCoreWebFonts): Log `error` to console if
404         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
405         to use ARC-compliant cast.
406         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
407         ARC-compliant cast.
408         (WTR::installFakeHelvetica): Log `error` to console if
409         CTFontManagerRegisterFontsForURL() fails, but only on supported
410         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
411         Call CFRelease() on `error` to fix the leak.  Update to use
412         ARC-compliant cast.
413         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
414         cast.
415
416 2019-02-21  Chris Dumez  <cdumez@apple.com>
417
418         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
419         https://bugs.webkit.org/show_bug.cgi?id=194481
420
421         Reviewed by Alex Christensen.
422
423         Give the processes a chance to shutdown and wait until we reached the expected number
424         of processes.
425
426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
427
428 2019-02-21  Tim Horton  <timothy_horton@apple.com>
429
430         Fix the macOS build
431
432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
433
434 2019-02-21  Tim Horton  <timothy_horton@apple.com>
435
436         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
437
438         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
439         I am a backwards.
440
441 2019-02-21  Tim Horton  <timothy_horton@apple.com>
442
443         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
444
445         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
446         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
447         We could force on UI-side compositing, but I feel like the test might be more
448         valuable exercising the normal path on each platform (though the original
449         bug was also UI-side specific). Though we can't validate that the overlay
450         layer was installed successfully, there are layout tests that do that.
451
452 2019-02-21  Tim Horton  <timothy_horton@apple.com>
453
454         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
455         https://bugs.webkit.org/show_bug.cgi?id=194845
456         <rdar://problem/47944579>
457
458         Reviewed by Antti Koivisto.
459
460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
461         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
462
463 2019-02-21  Zalan Bujtas  <zalan@apple.com>
464
465         [LFC][Floats] Add support for placing formatting roots in-between floats.
466         https://bugs.webkit.org/show_bug.cgi?id=194902
467
468         Reviewed by Antti Koivisto.
469
470         * LayoutReloaded/misc/LFC-passing-tests.txt:
471
472 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
473
474         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
475         https://bugs.webkit.org/show_bug.cgi?id=194901
476
477         Unreviewed build fix.
478
479         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
480         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
481         WPEBackend-fdo-0.1 as library name.
482
483 2019-02-21  Rob Buis  <rbuis@igalia.com>
484
485         Update MIME type parser
486         https://bugs.webkit.org/show_bug.cgi?id=180526
487
488         Reviewed by Darin Adler.
489
490         Add tests involving leading and trailing whitespace, non-token
491         characters and quoted strings.
492
493         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
494         (TestWebKitAPI::TEST):
495
496 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
497
498         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
499         https://bugs.webkit.org/show_bug.cgi?id=194884
500
501         Reviewed by Michael Catanzaro.
502
503         * PlatformWin.cmake:
504
505 2019-02-20  Chris Dumez  <cdumez@apple.com>
506
507         Add API test for <rdar://problem/47471222>
508         https://bugs.webkit.org/show_bug.cgi?id=194847
509
510         Reviewed by Alex Christensen.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
513
514 2019-02-20  Chris Dumez  <cdumez@apple.com>
515
516         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
517         https://bugs.webkit.org/show_bug.cgi?id=194872
518         <rdar://problem/47924500>
519
520         Reviewed by Alex Christensen.
521
522         Add API test coverage.
523
524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
525
526 2019-02-20  Jer Noble  <jer.noble@apple.com>
527
528         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
529         https://bugs.webkit.org/show_bug.cgi?id=191332
530
531         Reviewed by Dean Jackson.
532
533         * Scripts/git-is-in-range: Added.
534
535 2019-02-20  Andy Estes  <aestes@apple.com>
536
537         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
538         https://bugs.webkit.org/show_bug.cgi?id=194869
539
540         Rubber-stamped by Jer Noble.
541
542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
543         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
544         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
545         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
547         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
548
549 2019-02-20  Chris Dumez  <cdumez@apple.com>
550
551         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
552         https://bugs.webkit.org/show_bug.cgi?id=194857
553         <rdar://problem/47759323>
554
555         Reviewed by Alex Christensen.
556
557         Add API test coverage.
558
559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
560
561 2019-02-20  Chris Dumez  <cdumez@apple.com>
562
563         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
564         https://bugs.webkit.org/show_bug.cgi?id=194829
565         <rdar://problem/47889906>
566
567         Reviewed by Alexey Proskuryakov.
568
569         Every time the TestOptions were changing we were creating both a new Web view and
570         a new WKContext, which would start a new Network process. In most cases, we only
571         need to contruct a new Web view and we do can keep reusing the same WKContext.
572         This patch implements this optimization and thus avoids spinning a lot of new
573         Network processes while running the layout tests.
574
575         * WebKitTestRunner/TestController.cpp:
576         (WTR::TestController::generateContextConfiguration const):
577         (WTR::TestController::generatePageConfiguration):
578         (WTR::TestController::createWebViewWithOptions):
579         (WTR::TestController::resetPreferencesToConsistentValues):
580         (WTR::updateTestOptionsFromTestHeader):
581         * WebKitTestRunner/TestController.h:
582         * WebKitTestRunner/TestOptions.h:
583         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
584         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
585         (WTR::TestOptions::hasSameInitializationOptions const):
586         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
587         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
588         (WTR::TestController::platformAddTestOptions const):
589
590 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
591
592         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
593         https://bugs.webkit.org/show_bug.cgi?id=167941
594
595         Reviewed by Carlos Garcia Campos.
596
597         * MiniBrowser/gtk/main.c:
598         (filterSavedCallback): Added.
599         (main): Support loading a JSON rule set file for content filtering.
600         * MiniBrowser/wpe/main.cpp:
601         (filterSavedCallback): Added.
602         (main): Support loading a JSON rule set file for content filtering.
603         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
604         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
605         (WTF::derefGPtr): Ditto.
606         (testEmptyStore):
607         (testSaveInvalidFilter):
608         (testSaveLoadFilter):
609         (testSavedFilterIdentifierMatch):
610         (testRemoveFilter):
611         (testSaveMultipleFilters):
612         (testSaveFilterFromFile):
613         (testFilterPersistence):
614         (beforeAll):
615         (afterAll):
616         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
617         (removeOldInjectedContentAndResetLists): Also reset content filters.
618         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
619         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
620         the element affected by the style sheet.
621         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
622         and returns it to be used by tests.
623         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
624         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
625         (serverCallback): Add support for serving a CSS style sheet for testing.
626         (beforeAll): Add call to testUserContentManagerContentFilter().
627         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
628
629 2019-02-19  Keith Rollin  <krollin@apple.com>
630
631         Add timing information to build output
632         https://bugs.webkit.org/show_bug.cgi?id=194839
633         <rdar://problem/48219609>
634
635         Reviewed by Alexey Proskuryakov.
636
637         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
638         emit each project's build time to its output. E.g.,
639
640             ** BUILD SUCCEEDED ** [0.132 sec]
641
642         * Scripts/webkitdirs.pm:
643         (XcodeOptions):
644
645 2019-02-19  Truitt Savell  <tsavell@apple.com>
646
647         Unreviewed, rolling out r241784.
648
649         Broke all OpenSource builds.
650
651         Reverted changeset:
652
653         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
654         instances view"
655         https://bugs.webkit.org/show_bug.cgi?id=172848
656         https://trac.webkit.org/changeset/241784
657
658 2019-02-19  Zalan Bujtas  <zalan@apple.com>
659
660         [LFC][Floats] Remove redundant intersecting logic
661         https://bugs.webkit.org/show_bug.cgi?id=194804
662
663         Reviewed by Antti Koivisto.
664
665         * LayoutReloaded/misc/LFC-passing-tests.txt:
666
667 2019-02-19  Dean Jackson  <dino@apple.com>
668
669         Clean-up output from generate-xcfilelists so it can be filtered
670         https://bugs.webkit.org/show_bug.cgi?id=194795
671
672         Reviewed by Joseph Pecoraro (and Keith Rollin).
673
674         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
675         make a slight tweak to filter-build-webkit so such lines are marked
676         as plain.
677
678         * Scripts/filter-build-webkit:
679         * Scripts/generate-xcfilelists:
680
681 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
682
683         pytest is not correctly auto-installed
684         https://bugs.webkit.org/show_bug.cgi?id=194707
685
686         Reviewed by Carlos Garcia Campos.
687
688         * Scripts/webkitpy/thirdparty/__init__.py:
689         (AutoinstallImportHook._install_pytest):
690
691 2019-02-18  Chris Dumez  <cdumez@apple.com>
692
693         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
694         https://bugs.webkit.org/show_bug.cgi?id=194797
695         <rdar://problem/48055151>
696
697         Reviewed by Geoffrey Garen.
698
699         Add API test coverage.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
702
703 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
704
705         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
706         https://bugs.webkit.org/show_bug.cgi?id=194670
707         <rdar://problem/39066529>
708
709         Reviewed by Tim Horton.
710
711         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
712         pasted in an editable area as attachment elements.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
715         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
716         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
717         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
718         (TestWebKitAPI::TEST):
719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
720         (WTR::InjectedBundlePage::InjectedBundlePage):
721
722 2019-02-18  Alex Christensen  <achristensen@webkit.org>
723
724         Fix API test after r241728
725        ​https://bugs.webkit.org/show_bug.cgi?id=194723
726
727         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
728         (TEST):
729         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
730
731 2019-02-18  Daniel Bates  <dabates@apple.com>
732
733         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
734         https://bugs.webkit.org/show_bug.cgi?id=192824
735         <rdar://problem/47100332>
736
737         Reviewed by Wenson Hsieh.
738
739         Fix a bug where the wrong usage code was used for F13 thru F24.
740
741         * WebKitTestRunner/ios/HIDEventGenerator.mm:
742         (keyCodeForDOMFunctionKey):
743
744 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
745
746         Bytecode cache should a have a boot-specific validation
747         https://bugs.webkit.org/show_bug.cgi?id=194769
748         <rdar://problem/48149509>
749
750         Reviewed by Keith Miller.
751
752         Add test for WTF::bootSessionUUIDString()
753
754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
755         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
756         (TEST):
757
758 2019-02-18  Alex Christensen  <achristensen@webkit.org>
759
760         Disable safe browsing in WKWebView and remove its WKPreferences API
761         https://bugs.webkit.org/show_bug.cgi?id=194723
762         <rdar://problem/48122993>
763
764         Reviewed by Geoffrey Garen.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
767         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
768         (TEST):
769         (safeBrowsingView):
770         Make tests use SPI instead of API.
771
772 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
773
774         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
775         https://bugs.webkit.org/show_bug.cgi?id=194586
776
777         Reviewed by Ross Kirsling.
778
779         * DumpRenderTree/win/DumpRenderTree.cpp:
780         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
781         * Scripts/webkitpy/port/driver.py:
782         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
783
784 2019-02-17  David Kilzer  <ddkilzer@apple.com>
785
786         Unreviewed, rolling out r241620.
787
788         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
789         (Requested by ddkilzer on #webkit.)
790
791         Reverted changeset:
792
793         "[WTF] Add environment variable helpers"
794         https://bugs.webkit.org/show_bug.cgi?id=192405
795         https://trac.webkit.org/changeset/241620
796
797 2019-02-16  Zalan Bujtas  <zalan@apple.com>
798
799         [LFC] RenderImage's default intrinsic size is 0.
800         https://bugs.webkit.org/show_bug.cgi?id=194745
801
802         Reviewed by Antti Koivisto.
803
804         * LayoutReloaded/misc/LFC-passing-tests.txt:
805
806 2019-02-16  Zalan Bujtas  <zalan@apple.com>
807
808         [LFC][BFC] Add support for block replaced intrinsic width.
809         https://bugs.webkit.org/show_bug.cgi?id=194705
810
811         Reviewed by Simon Fraser.
812
813         * LayoutReloaded/misc/LFC-passing-tests.txt:
814
815 2019-02-16  Zalan Bujtas  <zalan@apple.com>
816
817         [LFC] Apply min/max width constraints to preferred width computation
818         https://bugs.webkit.org/show_bug.cgi?id=194739
819
820         Reviewed by Simon Fraser.
821
822         * LayoutReloaded/misc/LFC-passing-tests.txt:
823
824 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
825
826         [WTF] Add environment variable helpers
827         https://bugs.webkit.org/show_bug.cgi?id=192405
828
829         Reviewed by Michael Catanzaro.
830
831         * DumpRenderTree/mac/DumpRenderTree.mm:
832         (libraryPathForDumpRenderTree):
833         * DumpRenderTree/win/DumpRenderTree.cpp:
834         (libraryPathForDumpRenderTree):
835         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
836         (setUpIOSLayoutTestCommunication):
837         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
838         (beforeAll):
839         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
840         (main):
841         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
842         (WebKitTestBus::run):
843         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
844         (WTR::getOutputDir):
845         (WTR::initializeFontConfigSetting):
846         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
847         (WTR::InjectedBundle::platformInitialize):
848         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
849         (WTR::topLevelPath):
850         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
851         (WTR::topLevelPath):
852         (WTR::getOutputDir):
853         (WTR::activateFonts):
854         * WebKitTestRunner/TestController.cpp:
855         (WTR::TestController::libraryPathForTesting):
856         (WTR::TestController::generateContextConfiguration const):
857         (WTR::TestController::generatePageConfiguration):
858         (WTR::TestController::decideDestinationWithSuggestedFilename):
859         (WTR::TestController::platformAdjustContext):
860         * WebKitTestRunner/TestController.h:
861         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
862         (WTR::TestController::cocoaPlatformInitialize):
863         (WTR::TestController::platformAdjustContext):
864         * WebKitTestRunner/gtk/main.cpp:
865         (main):
866         * WebKitTestRunner/mac/TestControllerMac.mm:
867         (WTR::TestController::configureContentExtensionForTest):
868         * WebKitTestRunner/wpe/main.cpp:
869         (main):
870         Utilize WTF::Environment where possible.
871
872 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
873
874         [iOS] WKWebView callout bar is missing Change Writing Direction item
875         https://bugs.webkit.org/show_bug.cgi?id=190015
876         <rdar://problem/44810366>
877
878         Reviewed by Tim Horton.
879
880         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
881         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
882
883         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
884         (TestWebKitAPI::TEST):
885
886 2019-02-15  Chris Dumez  <cdumez@apple.com>
887
888         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
889         https://bugs.webkit.org/show_bug.cgi?id=194717
890         <rdar://problem/47884404>
891
892         Reviewed by Brady Eidson.
893
894         Add API test coverage.
895
896         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
897
898 2019-02-15  Youenn Fablet  <youenn@apple.com>
899
900         Make navigator.mediaDevices SecureContext
901         https://bugs.webkit.org/show_bug.cgi?id=194666
902
903         Reviewed by Eric Carlson.
904
905         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
906         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
907         (TEST_F):
908
909 2019-02-15  Brian Burg  <bburg@apple.com>
910
911         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
912         https://bugs.webkit.org/show_bug.cgi?id=194411
913         <rdar://problem/47787614>
914
915         Reviewed by Joseph Pecoraro.
916
917         Remove unnecessary soft linking macro usage.
918
919         * DumpRenderTree/mac/TestRunnerMac.mm:
920         (TestRunner::inspectorTestStubURL):
921         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
922         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
923         (WTR::TestRunner::inspectorTestStubURL):
924
925 2019-02-15  Commit Queue  <commit-queue@webkit.org>
926
927         Unreviewed, rolling out r241559 and r241566.
928         https://bugs.webkit.org/show_bug.cgi?id=194710
929
930         Causes layout test crashes under GuardMalloc (Requested by
931         ryanhaddad on #webkit).
932
933         Reverted changesets:
934
935         "[WTF] Add environment variable helpers"
936         https://bugs.webkit.org/show_bug.cgi?id=192405
937         https://trac.webkit.org/changeset/241559
938
939         "Unreviewed build fix for WinCairo Debug after r241559."
940         https://trac.webkit.org/changeset/241566
941
942 2019-02-15  Zalan Bujtas  <zalan@apple.com>
943
944         [LFC] Out-of-flow box is never a float box
945         https://bugs.webkit.org/show_bug.cgi?id=194704
946
947         Reviewed by Antti Koivisto.
948
949         * LayoutReloaded/misc/LFC-passing-tests.txt:
950
951 2019-02-10  Darin Adler  <darin@apple.com>
952
953         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
954         https://bugs.webkit.org/show_bug.cgi?id=194487
955
956         Reviewed by Daniel Bates.
957
958         * DumpRenderTree/win/DumpRenderTree.cpp:
959         (applicationId): Use makeString instead of String::format.
960         (main): Ditto.
961         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
962         (TestWebKitAPI::Util::createURLForResource): Ditto.
963         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
964         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
965
966         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
967         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
968         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
969         (WTR::createStringWithAttributes): Use appendLiteral.
970         (WTR::AccessibilityUIElement::helpText const): Ditto.
971         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
972         directly instead of using String::format.
973         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
974         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
975
976 2019-02-15  Truitt Savell  <tsavell@apple.com>
977
978         Unreviewed, rolling out r241564.
979
980         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
981
982         Reverted changeset:
983
984         "[Mac] WebInspectorUI.framework does not need to be soft-
985         linked anymore"
986         https://bugs.webkit.org/show_bug.cgi?id=194411
987         https://trac.webkit.org/changeset/241564
988
989 2019-02-15  Saam barati  <sbarati@apple.com>
990
991         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
992         https://bugs.webkit.org/show_bug.cgi?id=194036
993
994         Reviewed by Yusuke Suzuki.
995
996         * Scripts/run-jsc-stress-tests:
997
998 2019-02-14  Tim Horton  <timothy_horton@apple.com>
999
1000         Fix the build.
1001
1002         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1003         (WTR::UIScriptController::drawSquareInEditableImage):
1004         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1005         (TestWebKitAPI::drawSquareInEditableImage):
1006
1007 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1008
1009         Fix the build.
1010
1011         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1012         (WTR::UIScriptController::drawSquareInEditableImage):
1013         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1014         (TestWebKitAPI::drawSquareInEditableImage):
1015
1016 2019-02-14  Brian Burg  <bburg@apple.com>
1017
1018         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1019         https://bugs.webkit.org/show_bug.cgi?id=194411
1020         <rdar://problem/47787614>
1021
1022         Reviewed by Joseph Pecoraro.
1023
1024         Remove unnecessary soft linking macro usage.
1025
1026         * DumpRenderTree/mac/TestRunnerMac.mm:
1027         (TestRunner::inspectorTestStubURL):
1028         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1029         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1030         (WTR::TestRunner::inspectorTestStubURL):
1031
1032 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1033
1034         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1035         https://bugs.webkit.org/show_bug.cgi?id=194599
1036
1037         Reviewed by Lucas Forschler.
1038
1039         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1040         (StatusBubble._build_bubble):
1041
1042 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1043
1044         [ews-app] Set Foreign Key in Django build model
1045         https://bugs.webkit.org/show_bug.cgi?id=194667
1046
1047         Reviewed by Lucas Forschler.
1048
1049         * BuildSlaveSupport/ews-app/ews/models/build.py:
1050         (Build):
1051
1052 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1053
1054         [WTF] Add environment variable helpers
1055         https://bugs.webkit.org/show_bug.cgi?id=192405
1056
1057         Reviewed by Michael Catanzaro.
1058
1059         * DumpRenderTree/mac/DumpRenderTree.mm:
1060         (libraryPathForDumpRenderTree):
1061         * DumpRenderTree/win/DumpRenderTree.cpp:
1062         (libraryPathForDumpRenderTree):
1063         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1064         (setUpIOSLayoutTestCommunication):
1065         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1066         (TestWebKitAPI::strip):
1067         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1068         (beforeAll):
1069         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1070         (main):
1071         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1072         (WebKitTestBus::run):
1073         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1074         (WTR::getOutputDir):
1075         (WTR::initializeFontConfigSetting):
1076         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1077         (WTR::InjectedBundle::platformInitialize):
1078         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1079         (WTR::topLevelPath):
1080         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1081         (WTR::topLevelPath):
1082         (WTR::getOutputDir):
1083         (WTR::activateFonts):
1084         * WebKitTestRunner/TestController.cpp:
1085         (WTR::TestController::libraryPathForTesting):
1086         (WTR::TestController::generateContextConfiguration const):
1087         (WTR::TestController::generatePageConfiguration):
1088         (WTR::TestController::decideDestinationWithSuggestedFilename):
1089         (WTR::TestController::platformAdjustContext):
1090         * WebKitTestRunner/TestController.h:
1091         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1092         (WTR::TestController::cocoaPlatformInitialize):
1093         (WTR::TestController::platformAdjustContext):
1094         * WebKitTestRunner/gtk/main.cpp:
1095         (main):
1096         * WebKitTestRunner/mac/TestControllerMac.mm:
1097         (WTR::TestController::configureContentExtensionForTest):
1098         * WebKitTestRunner/wpe/main.cpp:
1099         (main):
1100         Utilize WTF::Environment where possible.
1101
1102 2019-02-14  Chris Dumez  <cdumez@apple.com>
1103
1104         [PSON] Introduce a WebContent Process cache
1105         https://bugs.webkit.org/show_bug.cgi?id=194594
1106         <rdar://problem/46793397>
1107
1108         Reviewed by Geoff Garen.
1109
1110         Update API tests to turn on the WebContent Process cache.
1111
1112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1113
1114 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1115
1116         Unreviewed, build fix after r241480
1117
1118         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1119         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1120         (-[DragAndDropSimulator initWithWebView:]):
1121
1122 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1123
1124         AX: ARIA Reflection was disabled in error
1125         https://bugs.webkit.org/show_bug.cgi?id=194647
1126         <rdar://problem/48068336>
1127
1128         Reviewed by Ryosuke Niwa.
1129
1130         Remove test override now that this feature should be enabled by default.
1131
1132         * WebKitTestRunner/TestController.cpp:
1133         (WTR::TestController::resetPreferencesToConsistentValues):
1134
1135 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1136
1137         Unreviewed, rolling out r241486.
1138         https://bugs.webkit.org/show_bug.cgi?id=194655
1139
1140         causing API failures in builds (Requested by ShawnRoberts on
1141         #webkit).
1142
1143         Reverted changeset:
1144
1145         "[Cocoa] Media elements will restart network buffering just
1146         before suspending"
1147         https://bugs.webkit.org/show_bug.cgi?id=193691
1148         https://trac.webkit.org/changeset/241486
1149
1150 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1151
1152         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1153         https://bugs.webkit.org/show_bug.cgi?id=194622
1154
1155         Reviewed by Antti Koivisto.
1156
1157         * LayoutReloaded/misc/LFC-passing-tests.txt:
1158
1159 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1160
1161         [LFC] Shrink-to-fit-width should be constrained by min/max width
1162         https://bugs.webkit.org/show_bug.cgi?id=194653
1163
1164         Reviewed by Antti Koivisto.
1165
1166         * LayoutReloaded/misc/LFC-passing-tests.txt:
1167
1168 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1169
1170         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1171         https://bugs.webkit.org/show_bug.cgi?id=194641
1172
1173         Reviewed by Geoffrey Garen.
1174
1175         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1176         so that the test would fail without this fix.
1177
1178         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1179         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1180
1181 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1182
1183         [ews-app] Change log level for a log statement
1184
1185         Unreviewed minor fix.
1186
1187         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1188         (Patch.save_patch):
1189
1190 2019-02-13  Jer Noble  <jer.noble@apple.com>
1191
1192         [Cocoa] Media elements will restart network buffering just before suspending
1193         https://bugs.webkit.org/show_bug.cgi?id=193691
1194
1195         Reviewed by Eric Carlson.
1196
1197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1199         (TEST):
1200
1201 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1202
1203         [ews-app] Fetch builder id to name mapping
1204         https://bugs.webkit.org/show_bug.cgi?id=194355
1205
1206         Reviewed by Lucas Forschler.
1207
1208         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1209         (Buildbot.get_builder_id_to_name_mapping):
1210         (Buildbot._get_display_name_from_builder_name):
1211
1212 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1213
1214         Further restricting webarchive loads
1215         https://bugs.webkit.org/show_bug.cgi?id=194567
1216         <rdar://problem/47610130>
1217
1218         Reviewed by Youenn Fablet.
1219
1220         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1221         navigations on drop.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1225         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1226         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1227         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1228         (TestWebKitAPI::TEST):
1229         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1230         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1231         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1232         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1233         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1234         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1235         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1236
1237 2019-02-13  John Wilander  <wilander@apple.com>
1238
1239         Store Ad Click Attribution requests in the network process
1240         https://bugs.webkit.org/show_bug.cgi?id=194510
1241         <rdar://problem/47650118>
1242
1243         Reviewed by Alex Christensen and Daniel Bates.
1244
1245         This patch adds two TestRunner functions:
1246         - dumpAdClickAttribution()
1247         - clearAdClickAttribution()
1248
1249         They call into the network process to dump and clear Ad Click
1250         Attribution state, respectively.
1251
1252         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1253         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1254         (WTR::TestRunner::dumpAdClickAttribution):
1255         (WTR::TestRunner::clearAdClickAttribution):
1256         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1257         * WebKitTestRunner/TestController.cpp:
1258         (WTR::TestController::resetStateToConsistentValues):
1259         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1260         (WTR::adClickAttributionStringResultCallback):
1261         (WTR::TestController::dumpAdClickAttribution):
1262         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1263         (WTR::adClickAttributionVoidCallback):
1264         (WTR::TestController::clearAdClickAttribution):
1265         * WebKitTestRunner/TestController.h:
1266         * WebKitTestRunner/TestInvocation.cpp:
1267         (WTR::TestInvocation::dumpResults):
1268         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1269         (WTR::TestInvocation::dumpAdClickAttribution):
1270         * WebKitTestRunner/TestInvocation.h:
1271
1272 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1273
1274         [ews-app] Generate status-bubble
1275         https://bugs.webkit.org/show_bug.cgi?id=194572
1276
1277         Reviewed by Lucas Forschler.
1278
1279         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1280         (StatusBubble._build_bubble):
1281         (StatusBubble._should_show_bubble_for):
1282         (StatusBubble._build_bubbles_for_patch):
1283
1284 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1285
1286         [ews-app] Add status bubble html template
1287         https://bugs.webkit.org/show_bug.cgi?id=194571
1288
1289         Reviewed by Lucas Forschler.
1290
1291         * BuildSlaveSupport/ews-app/ews/templates: Added.
1292         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1293
1294 2019-02-12  Chris Dumez  <cdumez@apple.com>
1295
1296         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1297         https://bugs.webkit.org/show_bug.cgi?id=194568
1298         <rdar://problem/47944490>
1299
1300         Reviewed by Ryosuke Niwa.
1301
1302         Add API test coverage.
1303
1304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1305         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1306
1307 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1308
1309         webkitpy: Remove bug_dummy from parsed test expectations
1310         https://bugs.webkit.org/show_bug.cgi?id=194562
1311         <rdar://problem/47853999>
1312
1313         Reviewed by Lucas Forschler.
1314
1315         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1316         (TestExpectationParser):
1317         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1318         skipped tests.
1319         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1320
1321 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1322
1323         [ews-app] Add method to fetch patch
1324         https://bugs.webkit.org/show_bug.cgi?id=194518
1325
1326         Reviewed by Lucas Forschler.
1327
1328         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1329         (Patch.get_patch):
1330
1331 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1332
1333         [LFC] Expand tests coverage (60 new tests -> 860)
1334
1335         Unreviewed test gardening (run-singly, --child-processes=1).
1336
1337         * LayoutReloaded/misc/LFC-passing-tests.txt:
1338
1339 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1340
1341         Allow pages to trigger programmatic paste from script on iOS
1342         https://bugs.webkit.org/show_bug.cgi?id=194271
1343         <rdar://problem/47808810>
1344
1345         Reviewed by Tim Horton.
1346
1347         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1348
1349         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1350         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1351         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1352         (WTR::UIScriptController::rectForMenuAction const):
1353
1354         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1355         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1356         for when the menu is shown or hidden.
1357
1358         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1359         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1360         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1361         (WTR::UIScriptController::setDidShowMenuCallback):
1362         (WTR::UIScriptController::didShowMenuCallback const):
1363         (WTR::UIScriptController::setDidHideMenuCallback):
1364         (WTR::UIScriptController::didHideMenuCallback const):
1365         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1366         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1367         (WTR::UIScriptController::rectForMenuAction const):
1368         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1369         * WebKitTestRunner/TestController.cpp:
1370         (WTR::TestController::resetPreferencesToConsistentValues):
1371         (WTR::updateTestOptionsFromTestHeader):
1372         * WebKitTestRunner/TestOptions.h:
1373
1374         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1375         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1376
1377         (WTR::TestOptions::hasSameInitializationOptions const):
1378         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1379         (WTR::UIScriptController::calendarType const):
1380         (WTR::UIScriptController::platformUndoManager const):
1381         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1382         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1383         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1384         (-[TestRunnerWKWebView dealloc]):
1385         (-[TestRunnerWKWebView _didShowMenu]):
1386         (-[TestRunnerWKWebView _didHideMenu]):
1387
1388         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1389
1390         * WebKitTestRunner/ios/TestControllerIOS.mm:
1391         (WTR::handleMenuWillHideNotification):
1392         (WTR::handleMenuDidHideNotification):
1393         (WTR::TestController::platformInitialize):
1394         (WTR::TestController::platformDestroy):
1395         (WTR::TestController::platformResetStateToConsistentValues):
1396
1397         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1398         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1399
1400         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1401         (WTR::forEachViewInHierarchy):
1402         (WTR::findViewInHierarchyOfType):
1403
1404         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1405         functions that dig through a given view's hierarchy in search of a view of a given class.
1406
1407         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1408         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1409         (WTR::UIScriptController::selectionCaretViewRect const):
1410         (WTR::UIScriptController::selectionRangeViewRects const):
1411         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1412         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1413
1414         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1415
1416         (WTR::UIScriptController::rectForMenuAction const):
1417
1418         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1419         callout bar) whose label matches the given string.
1420
1421         (WTR::UIScriptController::platformContentView const):
1422
1423         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1424         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1425         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1426
1427         (WTR::UIScriptController::platformUndoManager const): Deleted.
1428         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1429         (WTR::UIScriptController::platformContentView const):
1430         (WTR::UIScriptController::platformUndoManager const): Deleted.
1431
1432 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1433
1434         webkitpy: No option to only show unexpected failures in results.html for iPad
1435         https://bugs.webkit.org/show_bug.cgi?id=194554
1436         <rdar://problem/47922442>
1437
1438         Rubber-stamped by Aakash Jain.
1439
1440         Just because a TestExpecations file does not exist for a specific platform does not mean that
1441         TestExpecations are not being used, given that platforms inherit test expectations.
1442
1443         * Scripts/webkitpy/port/base.py:
1444         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1445         * Scripts/webkitpy/port/base_unittest.py:
1446         (PortTest.test_uses_test_expectations_file):
1447
1448 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1449
1450         Remove setDefersLoading infrastructure from WebKit2
1451         https://bugs.webkit.org/show_bug.cgi?id=194506
1452
1453         Reviewed by Brady Eidson.
1454
1455         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1457         (WTR::TestRunner::setDefersLoading): Deleted.
1458         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1459
1460 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1461
1462         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1463         https://bugs.webkit.org/show_bug.cgi?id=194522
1464         <rdar://problem/47789393>
1465
1466         Reviewed by Chris Dumez.
1467
1468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1469         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1470         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1471         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1472
1473 2019-02-12  Andy Estes  <aestes@apple.com>
1474
1475         [iOSMac] Enable Parental Controls Content Filtering
1476         https://bugs.webkit.org/show_bug.cgi?id=194521
1477         <rdar://39732376>
1478
1479         Reviewed by Tim Horton.
1480
1481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1482
1483 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1484
1485         [LFC][IFC] Add intrinsic width support for float boxes.
1486         https://bugs.webkit.org/show_bug.cgi?id=194528
1487
1488         Reviewed by Antti Koivisto.
1489
1490         Expand tests coverage (2 new tests -> 800).
1491         (This is the correct test ordering --runs-singly --child-processes=1)
1492
1493         * LayoutReloaded/misc/LFC-passing-tests.txt:
1494
1495 2019-02-12  Rob Buis  <rbuis@igalia.com>
1496
1497         Implement serializing in MIME type parser
1498         https://bugs.webkit.org/show_bug.cgi?id=193909
1499
1500         Reviewed by Darin Adler.
1501
1502         Add various tests involving upper case, non-ASCII, control/null characters,
1503         various HTTP whitespace, single quotes and an unpaired surrogate.
1504
1505         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1506         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1507         (TestWebKitAPI::serializeIfValid):
1508         (TestWebKitAPI::TEST):
1509
1510 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1511
1512         [Cocoa] Ask platform for generic font family mappings
1513         https://bugs.webkit.org/show_bug.cgi?id=187723
1514         <rdar://problem/41892438>
1515
1516         Reviewed by Brent Fulgham.
1517
1518         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1519
1520         * DumpRenderTree/mac/DumpRenderTree.mm:
1521         (allowedFontFamilySet):
1522         * WebKitTestRunner/mac/TestControllerMac.mm:
1523         (WTR::allowedFontFamilySet):
1524
1525 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1526
1527         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1528         https://bugs.webkit.org/show_bug.cgi?id=193622
1529
1530         Reviewed by Michael Catanzaro.
1531
1532         This adds support for loading content extension rule sets from the JSON files which
1533         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1534         of WKTR for this could be removed, but that is left for a follow-up patch with
1535         cleanups.
1536
1537         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1538         * WebKitTestRunner/TestController.cpp:
1539         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1540         avoid having the null-terminator copied into the result.
1541         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1542         part of the preparations to run a test.
1543         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1544         (WTR::contentExtensionStoreCallback): Added.
1545         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1546         used for content extensions test.
1547         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1548         extensions and compiling the JSON rule set for tests involving content extensions.
1549         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1550         testing and disables content extensions.
1551         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1552         resetContentExtensions().
1553         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1554         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1555         configureContentExtensionForTest(), and userContentController().
1556
1557 2019-02-11  Daniel Bates  <dabates@apple.com>
1558
1559         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1560         https://bugs.webkit.org/show_bug.cgi?id=191446
1561         <rdar://problem/45929460>
1562
1563         Reviewed by Tim Horton.
1564
1565         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1566
1567         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1568         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1569         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1570         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1571         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1572         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1573         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1574         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1575         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1576         (WTR::arrayLength):
1577         (WTR::parseModifierArray):
1578         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1579         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1580         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1581         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1582
1583 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1584
1585         Unreviewed, rolling out r241272 and r241276.
1586         https://bugs.webkit.org/show_bug.cgi?id=194514
1587
1588         Broke the Apple Internal build and the fix requires human
1589         intervention :( (Requested by dydz on #webkit).
1590
1591         Reverted changesets:
1592
1593         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1594         https://bugs.webkit.org/show_bug.cgi?id=191446
1595         https://trac.webkit.org/changeset/241272
1596
1597         "Fix internal iOS build after r241272"
1598         https://bugs.webkit.org/show_bug.cgi?id=191446
1599         https://trac.webkit.org/changeset/241276
1600
1601 2019-02-11  Truitt Savell  <tsavell@apple.com>
1602
1603         Unreviewed, rolling out r241269.
1604
1605         Caused 5 layout tests crashes on Mac WK1
1606
1607         Reverted changeset:
1608
1609         "DumpRenderTree should report unknown options"
1610         https://bugs.webkit.org/show_bug.cgi?id=191303
1611         https://trac.webkit.org/changeset/241269
1612
1613 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1614
1615         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1616         https://bugs.webkit.org/show_bug.cgi?id=194313
1617
1618         Reviewed by Tim Horton.
1619
1620         Add a helper to determine whether the web view is presenting modal UI.
1621
1622         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1623         (WTR::UIScriptController::isPresentingModally const):
1624         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1625         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1626         (WTR::UIScriptController::isPresentingModally const):
1627         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1628         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1629         (WTR::UIScriptController::calendarType const): Deleted.
1630         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1631         (WTR::UIScriptController::isPresentingModally const):
1632         (WTR::UIScriptController::calendarType const):
1633         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1634         (WTR::UIScriptController::calendarType const):
1635
1636 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1637
1638         GCHeapInspector: Show the retained sizes in more places
1639         https://bugs.webkit.org/show_bug.cgi?id=194464
1640
1641         Reviewed by Simon Fraser.
1642
1643         * GCHeapInspector/gc-heap-inspector.html:
1644         * GCHeapInspector/script/interface.js:
1645         (HeapInspectorUtils.humanReadableSize):
1646         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1647         (HeapInspectorUtils.spanForNode.span.span):
1648         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1649         (HeapSnapshotInspector.prototype.buildRoots):
1650
1651 2019-02-11  Daniel Bates  <dabates@apple.com>
1652
1653         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1654         https://bugs.webkit.org/show_bug.cgi?id=191446
1655         <rdar://problem/45929460>
1656
1657         Reviewed by Tim Horton.
1658
1659         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1660
1661         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1662         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1663         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1664         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1665         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1666         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1667         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1668         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1669         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1670         (WTR::arrayLength):
1671         (WTR::parseModifierArray):
1672         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1673         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1674         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1675         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1676
1677 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1678
1679         DumpRenderTree should report unknown options
1680         https://bugs.webkit.org/show_bug.cgi?id=191303
1681
1682         Reviewed by Frédéric Wang.
1683
1684         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1685         to report unknown options.
1686         Added and assigned test options which are currently used in tests.
1687
1688         * DumpRenderTree/TestOptions.cpp:
1689         (TestOptions::TestOptions):
1690
1691 2019-02-11  Truitt Savell  <tsavell@apple.com>
1692
1693         Unreviewed, rolling out r241229.
1694
1695         Revision broke internal builds for watchOS.
1696
1697         Reverted changeset:
1698
1699         "[Cocoa] Ask platform for generic font family mappings"
1700         https://bugs.webkit.org/show_bug.cgi?id=187723
1701         https://trac.webkit.org/changeset/241229
1702
1703 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1704
1705         [WinCairo][MiniBrowser] Basic authentication always fails.
1706         https://bugs.webkit.org/show_bug.cgi?id=194496
1707
1708         Reviewed by Don Olmstead.
1709
1710         * MiniBrowser/win/DialogHelper.h:
1711         (Dialog::getText):
1712
1713 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1714
1715         [GStreamer] GstMappedBuffer testsuite build fails
1716         https://bugs.webkit.org/show_bug.cgi?id=194495
1717
1718         Reviewed by Carlos Garcia Campos.
1719
1720         Fix the build by explicitely adding the gstreamer1.0-audio include
1721         directories to the include path.
1722
1723         * TestWebKitAPI/PlatformGTK.cmake:
1724         * TestWebKitAPI/PlatformWPE.cmake:
1725
1726 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1727
1728         [GTK][WPE] Add enable-javascript-markup setting
1729         https://bugs.webkit.org/show_bug.cgi?id=193439
1730
1731         Reviewed by Michael Catanzaro.
1732
1733         Add test cases to check the new setting.
1734
1735         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1736         (testWebKitSettings):
1737         (testWebKitSettingsJavaScriptMarkup):
1738         (beforeAll):
1739
1740 2019-02-10  Darin Adler  <darin@apple.com>
1741
1742         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1743         https://bugs.webkit.org/show_bug.cgi?id=194485
1744
1745         Reviewed by Daniel Bates.
1746
1747         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1748
1749 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1750
1751         Add more tests for clampTo<>()
1752         https://bugs.webkit.org/show_bug.cgi?id=194462
1753
1754         Reviewed by Geoffrey Garen.
1755
1756         Darin suggested to test the very last floating point number
1757         at the boundaries when truncating to integer.
1758         I added test for max/min and max-1/min-1.
1759
1760         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1761         (TestWebKitAPI::TEST):
1762
1763 2019-02-09  Darin Adler  <darin@apple.com>
1764
1765         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1766         https://bugs.webkit.org/show_bug.cgi?id=194021
1767
1768         Reviewed by Geoffrey Garen.
1769
1770         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1771         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1772         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1773
1774 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1775
1776         [LFC][IFC] Add intrinsic width support for basic inline containers
1777         https://bugs.webkit.org/show_bug.cgi?id=194473
1778
1779         Reviewed by Antti Koivisto.
1780
1781         Expand tests coverage (11 new tests -> 798)
1782
1783         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1784
1785 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1786
1787         Fix MiniBrowser's entitlements
1788         https://bugs.webkit.org/show_bug.cgi?id=192431
1789
1790         Reviewed by Joseph Pecoraro.
1791
1792         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1793         files, making it impossible to load any extension.
1794
1795         * MiniBrowser/MiniBrowser.entitlements:
1796
1797 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1798
1799         [Cocoa] Ask platform for generic font family mappings
1800         https://bugs.webkit.org/show_bug.cgi?id=187723
1801         <rdar://problem/41892438>
1802
1803         Reviewed by Brent Fulgham.
1804
1805         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1806
1807         * DumpRenderTree/mac/DumpRenderTree.mm:
1808         (allowedFontFamilySet):
1809         * WebKitTestRunner/mac/TestControllerMac.mm:
1810         (WTR::allowedFontFamilySet):
1811
1812 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1813
1814         [GTK] Implement back/forward touchpad gesture
1815         https://bugs.webkit.org/show_bug.cgi?id=193919
1816
1817         Reviewed by Michael Catanzaro.
1818
1819         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1820         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1821
1822 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1823
1824         Add SPI to use networking daemon instead of XPC service
1825         https://bugs.webkit.org/show_bug.cgi?id=194427
1826
1827         Reviewed by Geoffrey Garen
1828
1829         * MiniBrowser/MiniBrowser.entitlements:
1830
1831 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1832
1833         [ews-build] Ensure that every builder in config.json has short name
1834         https://bugs.webkit.org/show_bug.cgi?id=194461
1835
1836         Reviewed by Lucas Forschler.
1837
1838         * BuildSlaveSupport/ews-build/loadConfig.py:
1839         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1840
1841 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1842
1843         [ews-build] Add short name to config.json
1844         https://bugs.webkit.org/show_bug.cgi?id=194456
1845
1846         Reviewed by Lucas Forschler.
1847
1848         * BuildSlaveSupport/ews-build/config.json: Added short name.
1849         * BuildSlaveSupport/ews-build/loadConfig.py:
1850         (loadBuilderConfig): Set the short name as the builder description.
1851
1852 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1853
1854         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1855         https://bugs.webkit.org/show_bug.cgi?id=194418
1856
1857         Reviewed by Lucas Forschler.
1858
1859         Do not include errors trying when finding crashlogs at the end of
1860         a run-webkit-tests run since we don't process those errors.
1861
1862         * Scripts/webkitpy/port/darwin.py:
1863         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1864         * Scripts/webkitpy/port/ios_device.py:
1865         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1866         * Scripts/webkitpy/port/watch_device.py:
1867         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1868
1869 2019-02-08  Beth Dakin  <bdakin@apple.com>
1870
1871         Add afterScreenUpdates to WKSnapshotConfiguration
1872         https://bugs.webkit.org/show_bug.cgi?id=194362
1873         -and corresponding-
1874         <rdar://problem/40655528> Please add an "after screen updates" property to 
1875         WKSnapshotConfiguration (to solve blank snapshots)
1876
1877         Reviewed by Tim Horton.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1880         (TEST):
1881
1882 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1883
1884         clampTo(): do not convert the input to double when dealing with integers
1885         https://bugs.webkit.org/show_bug.cgi?id=194263
1886         <rdar://problem/47692312>
1887
1888         Reviewed by Darin Adler.
1889
1890         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1891         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1892         (TestWebKitAPI::testClampFloatingPointToInteger):
1893         (TestWebKitAPI::testClampSameSignIntegers):
1894         (TestWebKitAPI::testClampUnsignedToSigned):
1895         (TestWebKitAPI::testClampSignedToUnsigned):
1896
1897 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1898
1899         webkitpy: Respect --dedicated-simulators flag
1900         https://bugs.webkit.org/show_bug.cgi?id=194416
1901         <rdar://problem/47894722>
1902
1903         Reviewed by Lucas Forschler.
1904
1905         * Scripts/webkitpy/port/device_port.py:
1906         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1907         available devices can be safely ignored.
1908
1909 2019-02-07  Keith Rollin  <krollin@apple.com>
1910
1911         Remove extra copy of 100x100-red.tga
1912         https://bugs.webkit.org/show_bug.cgi?id=194371
1913         <rdar://problem/47873465>
1914
1915         Reviewed by Said Abou-Hallawa.
1916
1917         In order to help it pass its tests, Bug 194190 added a second copy of
1918         the file 100x100-red.tga. However, it turns out that this additional
1919         file wasn't actually needed, and that that sole previous copy was
1920         sufficient. At the same time, this second copy -- which was copied to
1921         the same location in the build output as the first copy -- now caused
1922         XCBuild to complain because there were two production rules for the
1923         same output file. Address this by removing the newly-added extra copy.
1924
1925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1926         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1927
1928 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1929
1930         Deprecate WKBundlePageSetDefersLoading
1931         https://bugs.webkit.org/show_bug.cgi?id=191394
1932
1933         Reviewed by Dean Jackson.
1934
1935         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1936         (WTR::TestRunner::setDefersLoading):
1937
1938 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1939
1940         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1941         https://bugs.webkit.org/show_bug.cgi?id=194391
1942
1943         Reviewed by Antti Koivisto.
1944
1945         * LayoutReloaded/misc/LFC-passing-tests.txt:
1946
1947 2019-02-06  Keith Rollin  <krollin@apple.com>
1948
1949         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1950         https://bugs.webkit.org/show_bug.cgi?id=193975
1951         <rdar://problem/47643306>
1952
1953         Reviewed by Tim Horton.
1954
1955         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1956         the Info.plist file into the bundle. This step is not necessary as the
1957         implicit "bundle up all the build products into a framework" build
1958         phase does this already. Having the Copy Bundle Resources phase do
1959         this causes a conflict under XCBuild, which objects to two build
1960         phases producing the same file (Info.plist). Address this by removing
1961         Info.plist from the Copy Bundle Resources phase.
1962
1963         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1964
1965 2019-02-06  Keith Rollin  <krollin@apple.com>
1966
1967         Really enable the automatic checking and regenerations of .xcfilelists during builds
1968         https://bugs.webkit.org/show_bug.cgi?id=194357
1969         <rdar://problem/47861231>
1970
1971         Reviewed by Chris Dumez.
1972
1973         Bug 194124 was supposed to enable the automatic checking and
1974         regenerating of .xcfilelist files during the build. While related
1975         changes were included in that patch, the change to actually enable the
1976         operation somehow was omitted. This patch actually enables the
1977         operation. The check-xcfilelist.sh scripts now check
1978         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1979         from the checking.
1980
1981         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1982         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1983
1984 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1985
1986         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1987         <https://webkit.org/b/194286>
1988         <rdar://problem/47815558>
1989
1990         Reviewed by Alexey Proskuryakov.
1991
1992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1993         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1994         WKRetainPtr<> to avoid leaking the WKDataRef.
1995
1996 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1997
1998         Unreviewed, fix a typo
1999
2000         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2001
2002 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2003
2004         [GTK][WPE] force libpsl build to use ICU in jhbuild
2005         https://bugs.webkit.org/show_bug.cgi?id=194288
2006
2007         Reviewed by Carlos Garcia Campos.
2008
2009         * gtk/jhbuild.modules:
2010         Require ICU for libpsl build in jhbuild, like done in WPE.
2011
2012 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2013
2014         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2015         https://bugs.webkit.org/show_bug.cgi?id=194209
2016
2017         Reviewed by Carlos Garcia Campos.
2018
2019         Enhance TestCookieManager to ensure this doesn't happen again.
2020
2021         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2022         (testCookieManagerPersistentStorage):
2023         (beforeAll):
2024
2025 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2026
2027         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2028         https://bugs.webkit.org/show_bug.cgi?id=194324
2029
2030         Reviewed by Andy Estes.
2031
2032         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2033         part of the name is already implicit, since this is in testing code in TestOptions.
2034
2035         * WebKitTestRunner/TestController.cpp:
2036         (WTR::TestController::generateContextConfiguration const):
2037         (WTR::updateTestOptionsFromTestHeader):
2038         * WebKitTestRunner/TestOptions.h:
2039         (WTR::TestOptions::hasSameInitializationOptions const):
2040
2041 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2042
2043         [ews-build] Allow * as platform for builders and workers
2044         https://bugs.webkit.org/show_bug.cgi?id=188533
2045
2046         Reviewed by Lucas Forschler.
2047
2048         * BuildSlaveSupport/ews-build/loadConfig.py:
2049         (checkWorkersAndBuildersForConsistency):
2050
2051 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2052
2053         [ews-build] Add few bots to config.json
2054         https://bugs.webkit.org/show_bug.cgi?id=194304
2055
2056         Reviewed by Lucas Forschler.
2057
2058         * BuildSlaveSupport/ews-build/config.json:
2059
2060 2019-02-05  Keith Rollin  <krollin@apple.com>
2061
2062         Enable the automatic checking and regenerations of .xcfilelists during builds
2063         https://bugs.webkit.org/show_bug.cgi?id=194124
2064         <rdar://problem/47721277>
2065
2066         Reviewed by Tim Horton.
2067
2068         Bug 193790 add a facility for checking -- during build time -- that
2069         any needed .xcfilelist files are up-to-date and for updating them if
2070         they are not. This facility was initially opt-in by setting
2071         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2072         the process seemed robust. Its now time to enable this facility and
2073         make it opt-out. If there is a need to disable this facility, set and
2074         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2075         running `make` or `build-webkit`, or before running Xcode from the
2076         command line.
2077
2078         Additionally, remove the step that generates a list of source files
2079         going into the UnifiedSources build step. It's only necessarily to
2080         specify Sources.txt and SourcesCocoa.txt as inputs.
2081
2082         * Scripts/generate-xcfilelists:
2083
2084 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2085
2086         [GTK][WPE] force libpsl build to use ICU in jhbuild
2087         https://bugs.webkit.org/show_bug.cgi?id=194288
2088
2089         Reviewed by Philippe Normand.
2090
2091         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2092         This can cause build failures if libidn is detected but libunistring is not available.
2093
2094         Make sure that ICU is used for runtime and builtin PSL data.
2095
2096         * gtk/jhbuild.modules:
2097         * wpe/jhbuild.modules:
2098
2099 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2100
2101         [ews-app] Modified timestamp should be updated on updating data
2102         https://bugs.webkit.org/show_bug.cgi?id=194295
2103
2104         Reviewed by Lucas Forschler.
2105
2106         * BuildSlaveSupport/ews-app/ews/models/build.py:
2107         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2108         * BuildSlaveSupport/ews-app/ews/models/step.py:
2109
2110 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2111
2112         Unreviewed, rolling out r240742.
2113
2114         Causes crashes on iOS simulator.
2115
2116         Reverted changeset:
2117
2118         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2119         not focused in a content-editable element"
2120         https://bugs.webkit.org/show_bug.cgi?id=192824
2121         https://trac.webkit.org/changeset/240742
2122
2123 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2124
2125         run-webkit-tests emits message "...running None" when running tests
2126         https://bugs.webkit.org/show_bug.cgi?id=194133
2127         <rdar://problem/47724738>
2128
2129         Reviewed by Lucas Forschler.
2130
2131         * Scripts/webkitpy/xcode/device_type.py:
2132         (DeviceType.__str__): Use both version mapping tables and use just the variant
2133         name if no version name is available.
2134         * Scripts/webkitpy/xcode/device_type_unittest.py:
2135         (DeviceTypeTest):
2136         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2137         an associated named.
2138
2139 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2140
2141         [WPE] require python3-setuptools for meson build in jhbuild
2142         https://bugs.webkit.org/show_bug.cgi?id=194287
2143
2144         Reviewed by Philippe Normand.
2145
2146         python3-setuptools is needed to build meson in jhbuild.
2147         It is already required by the GTK port.
2148
2149         * wpe/install-dependencies:
2150
2151 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2152
2153         [ews-app] Add method to save BuilderMapping to database
2154         https://bugs.webkit.org/show_bug.cgi?id=194264
2155
2156         Reviewed by Lucas Forschler.
2157
2158         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2159         (BuilderMapping.__str__):
2160         (BuilderMapping):
2161         (BuilderMapping.save_mapping):
2162         (BuilderMapping.update_mapping):
2163         (BuilderMapping.get_existing_mapping):
2164         (BuilderMapping.is_valid_mapping):
2165
2166 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-app] Add timestamp fields for BuilderMappings
2169         https://bugs.webkit.org/show_bug.cgi?id=194266
2170
2171         Reviewed by Lucas Forschler.
2172
2173         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2174         (BuilderMapping):
2175
2176 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2177
2178         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2179         https://bugs.webkit.org/show_bug.cgi?id=174816
2180
2181         Reviewed by Michael Catanzaro.
2182
2183         Add tests for webkit_uri_for_display().
2184
2185         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2186         (testURIForDisplayUnaffected):
2187         (testURIForDisplayAffected):
2188         (beforeAll):
2189         (afterAll):
2190         * TestWebKitAPI/glib/CMakeLists.txt:
2191
2192 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2193
2194         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2195         https://bugs.webkit.org/show_bug.cgi?id=194158
2196         <rdar://problem/47737268>
2197
2198         Rubber-stamped by Aakash Jain.
2199
2200         * Scripts/webkitpy/port/device_port.py:
2201         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2202
2203 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2204
2205         [CG] Enable setAdditionalSupportedImageTypes for WK1
2206         https://bugs.webkit.org/show_bug.cgi?id=194190
2207
2208         Reviewed by Tim Horton.
2209
2210         Add a test similar to the one under WebKit Cocoa but make it create a
2211         WebView instead of a WKWebView.
2212
2213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2214         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2215         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2216         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2217         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2218         (TestWebKitAPI::runTest):
2219         (TestWebKitAPI::TEST):
2220
2221 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2222
2223         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2224         https://bugs.webkit.org/show_bug.cgi?id=194168
2225
2226         Reviewed by Simon Fraser.
2227
2228         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2229
2230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2231         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2232         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2233         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2234         (TEST):
2235         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2236         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2237
2238 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2239
2240         REGRESSION (r237269): webkit-patch what-broke is broken 
2241         https://bugs.webkit.org/show_bug.cgi?id=193025
2242
2243         Reviewed by Aakash Jain.
2244
2245         * Scripts/webkitpy/common/host.py:
2246         (Host.buildbot):
2247         (Host.bugzilla): Renamed to 'buildbot'.
2248
2249 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2250
2251         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2252         https://bugs.webkit.org/show_bug.cgi?id=194207
2253
2254         Reviewed by Tim Horton.
2255
2256         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2257         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2258         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2259         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2260         start and delete forwards to remove the original attachment.
2261
2262         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2263         (TestWebKitAPI::TEST):
2264
2265 2019-02-04  Youenn Fablet  <youenn@apple.com>
2266
2267         Capture state should be managed consistently when doing process swapping
2268         https://bugs.webkit.org/show_bug.cgi?id=194122
2269         <rdar://problem/47609293>
2270
2271         Reviewed by Eric Carlson.
2272
2273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2274         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2275         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2276         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2279         (WTR::TestRunner::isDoingMediaCapture const):
2280         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2281         * WebKitTestRunner/TestController.cpp:
2282         (WTR::TestController::isDoingMediaCapture const):
2283         * WebKitTestRunner/TestController.h:
2284         * WebKitTestRunner/TestInvocation.cpp:
2285         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2286         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2287         (WTR::TestController::isDoingMediaCapture const):
2288
2289 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2290
2291         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2292         https://bugs.webkit.org/show_bug.cgi?id=194142
2293
2294         Reviewed by Ross Kirsling.
2295
2296         There three 'separator' variables in TestController.cpp. Renamed
2297         it 'pathSeparator', and unified them.
2298
2299         * WebKitTestRunner/TestController.cpp:
2300         (WTR::TestController::generateContextConfiguration const):
2301         (WTR::createTestURL):
2302         (WTR::TestController::platformAdjustContext):
2303
2304 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2305
2306         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2307         https://bugs.webkit.org/show_bug.cgi?id=194198
2308
2309         Reviewed by Antti Koivisto.
2310
2311         No need to set the banner heights on navigation now, since Page stores them.
2312
2313         * MiniBrowser/mac/WK2BrowserWindowController.m:
2314         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2315
2316 2019-02-03  John Wilander  <wilander@apple.com>
2317
2318         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2319         https://bugs.webkit.org/show_bug.cgi?id=194104
2320         <rdar://problem/47649991>
2321
2322         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2323
2324         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2325         (TestWebKitAPI::TEST):
2326             Changed numeric types from unsigned short to uint32_t.
2327
2328 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2329
2330         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2331         <https://webkit.org/b/194178>
2332         <rdar://problem/47753473>
2333
2334         Reviewed by Alexey Proskuryakov.
2335
2336         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2337         (WTR::uninstallFakeHelvetica): Pass nullptr into
2338         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2339
2340 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2341
2342         [LFC] Initialize ICB's style with fixed width/height.
2343         https://bugs.webkit.org/show_bug.cgi?id=194188
2344
2345         Reviewed by Antti Koivisto.
2346
2347         * LayoutReloaded/misc/LFC-passing-tests.txt:
2348
2349 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2350
2351         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2352         https://bugs.webkit.org/show_bug.cgi?id=194185
2353
2354         Reviewed by Antti Koivisto.
2355
2356         * LayoutReloaded/misc/LFC-passing-tests.txt:
2357
2358 2018-12-16  Darin Adler  <darin@apple.com>
2359
2360         Convert additional String::format clients to alternative approaches
2361         https://bugs.webkit.org/show_bug.cgi?id=192746
2362
2363         Reviewed by Alexey Proskuryakov.
2364
2365         * WebKitTestRunner/TestController.cpp:
2366         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2367         as an intermediate in code that ultimately constructs a WTF::String.
2368         (WTR::userMediaOriginHash): Use makeString.
2369         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2370         (WTR::TestController::didPerformClientRedirect): Ditto.
2371         (WTR::TestController::didPerformServerRedirect): Ditto.
2372         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2373
2374 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2375
2376         [ews-build] Add unit test to verify builder keys
2377         https://bugs.webkit.org/show_bug.cgi?id=194152
2378
2379         Reviewed by Lucas Forschler.
2380
2381         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2382         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2383
2384 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2385
2386         [LFC] Expand tests coverage (12 new tests -> 787)
2387
2388         Unreviewed test gardening.
2389
2390         * LayoutReloaded/misc/LFC-passing-tests.txt:
2391
2392 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2393
2394         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2395         https://bugs.webkit.org/show_bug.cgi?id=194163
2396
2397         Reviewed by Simon Fraser.
2398
2399         775
2400
2401         * LayoutReloaded/misc/LFC-passing-tests.txt:
2402
2403 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2404
2405         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2406         https://bugs.webkit.org/show_bug.cgi?id=194140
2407         <rdar://problem/47728098>
2408
2409         Reviewed by Tim Horton.
2410
2411         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2412         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2413         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2414
2415         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2416         test to induce an IPC deadlock when presenting a modal alert during touch start.
2417
2418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2419         * WebKitTestRunner/TestController.cpp:
2420         (WTR::runJavaScriptAlert):
2421
2422         Add a client callback function for running JavaScript alerts.
2423
2424         (WTR::TestController::createOtherPage):
2425         (WTR::TestController::generateContextConfiguration const):
2426
2427         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2428         the fix in this patch.
2429
2430         (WTR::TestController::createWebViewWithOptions):
2431
2432         Plumb TestOptions to generateContextConfiguration.
2433
2434         (WTR::TestController::resetPreferencesToConsistentValues):
2435         (WTR::TestController::resetStateToConsistentValues):
2436         (WTR::updateTestOptionsFromTestHeader):
2437         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2438         (WTR::TestController::handleJavaScriptAlert):
2439         * WebKitTestRunner/TestController.h:
2440         * WebKitTestRunner/TestInvocation.cpp:
2441         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2442         * WebKitTestRunner/TestOptions.h:
2443         (WTR::TestOptions::hasSameInitializationOptions const):
2444
2445 2019-02-01  Chris Dumez  <cdumez@apple.com>
2446
2447         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2448         https://bugs.webkit.org/show_bug.cgi?id=193740
2449         <rdar://problem/47527267>
2450
2451         Reviewed by Alex Christensen.
2452
2453         Add API test coverage.
2454
2455         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2456
2457 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2458
2459         [ews-app] Add display name field to BuilderMapping model
2460         https://bugs.webkit.org/show_bug.cgi?id=194153
2461
2462         Reviewed by Lucas Forschler.
2463
2464         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2465         (BuilderMapping):
2466
2467 2019-02-01  Youenn Fablet  <youenn@apple.com>
2468
2469         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2470         https://bugs.webkit.org/show_bug.cgi?id=194155
2471
2472         Reviewed by Eric Carlson.
2473
2474         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2475         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2476         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2477
2478 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2479
2480         [LFC] Adjust replaced element's intrinsic ratio
2481         https://bugs.webkit.org/show_bug.cgi?id=194154
2482
2483         Reviewed by Antti Koivisto.
2484
2485         761
2486
2487         * LayoutReloaded/misc/LFC-passing-tests.txt:
2488
2489 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2490
2491         [WPE] Show test results in minibrowser
2492         https://bugs.webkit.org/show_bug.cgi?id=194150
2493
2494         Reviewed by Žan Doberšek.
2495
2496         * Scripts/webkitpy/port/wpe.py:
2497         (WPEPort.show_results_html_file):
2498
2499 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2500
2501         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2502         https://bugs.webkit.org/show_bug.cgi?id=194151
2503
2504         Reviewed by Žan Doberšek.
2505
2506         ALT + <- go back
2507         ALT + -> go forward
2508
2509         * MiniBrowser/wpe/main.cpp:
2510         (main):
2511
2512 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2513
2514         [LFC] Set intrinsic size on Layout::Replaced
2515         https://bugs.webkit.org/show_bug.cgi?id=194139
2516
2517         Reviewed by Antti Koivisto.
2518
2519         744
2520
2521         * LayoutReloaded/misc/LFC-passing-tests.txt:
2522
2523 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2524
2525         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2526         https://bugs.webkit.org/show_bug.cgi?id=194146
2527
2528         Reviewed by Xabier Rodriguez-Calvar.
2529
2530         It allows to open relative paths.
2531
2532         * MiniBrowser/wpe/main.cpp:
2533         (main):
2534
2535 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2536
2537         Update flakiness dashboard configuration after recent queue changes
2538         https://bugs.webkit.org/show_bug.cgi?id=194127
2539
2540         Rubber-stamped by Aakash Jain.
2541
2542         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2543
2544         * TestResultServer/static-dashboards/builders.jsonp:
2545
2546 2019-01-31  Youenn Fablet  <youenn@apple.com>
2547
2548         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2549         https://bugs.webkit.org/show_bug.cgi?id=194106
2550         <rdar://problem/47676333>
2551
2552         Reviewed by Ryosuke Niwa.
2553
2554         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2555         (TestWebKitAPI::didFinishNavigation):
2556         (TestWebKitAPI::TEST):
2557         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2558
2559 2019-01-31  Chris Dumez  <cdumez@apple.com>
2560
2561         Page zoom level is lost after a process swap or a crash
2562         https://bugs.webkit.org/show_bug.cgi?id=194105
2563         <rdar://problem/47610781>
2564
2565         Reviewed by Alex Christensen.
2566
2567         Add API test coverage.
2568
2569         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2570         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2571
2572 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2573
2574         Revert r238819 which is unneeded and caused a performance regression.
2575         https://bugs.webkit.org/show_bug.cgi?id=192272
2576         <rdar://problem/46664625>
2577
2578         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2579         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2580         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2581
2582 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2583
2584         Formalize WebKitAdditions mechanism of LoadOptimizer
2585         https://bugs.webkit.org/show_bug.cgi?id=193886
2586         <rdar://problem/47696809>
2587
2588         Reviewed by Brent Fulgham.
2589
2590         * MiniBrowser/MiniBrowser.entitlements:
2591         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2592
2593 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2594
2595         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2596         https://bugs.webkit.org/show_bug.cgi?id=194090
2597
2598         Reviewed by Antti Koivisto.
2599
2600         * LayoutReloaded/misc/LFC-passing-tests.txt:
2601
2602 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2603
2604         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2605         https://bugs.webkit.org/show_bug.cgi?id=194074
2606
2607         Reviewed by Antti Koivisto.
2608
2609         * LayoutReloaded/misc/LFC-passing-tests.txt:
2610
2611 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2612
2613         [LFC][BFC] Add support for block level replaced box.
2614         https://bugs.webkit.org/show_bug.cgi?id=194071
2615
2616         Reviewed by Antti Koivisto.
2617
2618         * LayoutReloaded/misc/LFC-passing-tests.txt:
2619
2620 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2621
2622         Fix WebKitTestRunner's testPath with Windows full paths
2623         https://bugs.webkit.org/show_bug.cgi?id=194012
2624
2625         Reviewed by Alex Christensen.
2626
2627         updateTestOptionsFromTestHeader failed to open test files because
2628         testPath returned wrong file paths. It returned a path "/C:/..."
2629         if a URL "file:///C:/..." was given.
2630
2631         * WebKitTestRunner/TestController.cpp:
2632         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2633
2634 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2635
2636         [WPE] Bump font related dependencies to match the GTK+ port
2637         https://bugs.webkit.org/show_bug.cgi?id=194017
2638
2639         Reviewed by Žan Doberšek.
2640
2641         * wpe/jhbuild.modules:
2642         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2643         * wpe/patches/icudata-stdlibs.patch: Added.
2644
2645 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2646
2647         Enable swipe tests on iOS
2648         https://bugs.webkit.org/show_bug.cgi?id=194076
2649
2650         Reviewed by Geoffrey Garen.
2651
2652         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2653         it causes a debug assertion failure in runUIScript.
2654
2655         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2656         (WTR::UIScriptController::beginBackSwipe):
2657         (WTR::UIScriptController::completeBackSwipe):
2658
2659 2019-01-30  Keith Rollin  <krollin@apple.com>
2660
2661         Use correct printf format specifier
2662         https://bugs.webkit.org/show_bug.cgi?id=194062
2663         <rdar://problem/47686167>
2664
2665         Reviewed by Alexey Proskuryakov.
2666
2667         LayoutTestSpellChecker.mm is trying to format a variable of type
2668         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2669         actually an unsigned long long. Fix this by formatting with %llu.
2670
2671         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2672         (-[LayoutTestTextCheckingResult description]):
2673
2674 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2675
2676         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2677         https://bugs.webkit.org/show_bug.cgi?id=193979
2678
2679         Reviewed by Wenson Hsieh.
2680
2681         Fix the test for iOS. Make the test work with iOS UA string.
2682
2683         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2684
2685 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2686
2687         Replace High Sierra LLINT CLoop bot due to hardware failure
2688         https://bugs.webkit.org/show_bug.cgi?id=194066
2689
2690         Reviewed by Aakash Jain.
2691
2692         * BuildSlaveSupport/build.webkit.org-config/config.json:
2693
2694 2019-01-30  Keith Rollin  <krollin@apple.com>
2695
2696         [NSDragItem init] is unavailable
2697         https://bugs.webkit.org/show_bug.cgi?id=194059
2698         <rdar://problem/47685715>
2699
2700         Reviewed by Wenson Hsieh.
2701
2702         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2703         DumpRenderTree and TestWebKitAPI, which both try to create an
2704         NSDragItem in a manner that invokes this method. Address this by using
2705         -initWithPasteboardWriter instead.
2706
2707         Note that the parameter passed to initWithPasteboardWriter is likely
2708         incorrect. In both cases, the object passed does not conform to
2709         NSPasteboardWriting. However, with this fix, we're no worse off than
2710         before, and can now perform builds with newer compilers and SDKs until
2711         a real fix can be crafted. That work is tracked in
2712         https://bugs.webkit.org/show_bug.cgi?id=194060
2713
2714         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2715         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2716         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2717         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2718
2719 2019-01-30  Daniel Bates  <dabates@apple.com>
2720
2721         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2722         https://bugs.webkit.org/show_bug.cgi?id=192824
2723         <rdar://problem/47100332>
2724
2725         Reviewed by Wenson Hsieh.
2726
2727         Fix a bug where the wrong usage code was used for F13 thru F24.
2728
2729         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2730         (keyCodeForDOMFunctionKey):
2731
2732 2019-01-30  Chris Dumez  <cdumez@apple.com>
2733
2734         Regression(PSON) Load hang can occur on history navigation
2735         https://bugs.webkit.org/show_bug.cgi?id=194030
2736         <rdar://problem/47656939>
2737
2738         Reviewed by Antti Koivisto.
2739
2740         Add API test coverage.
2741
2742         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2743
2744 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2745
2746         [LFC] Expand tests coverage.
2747
2748         Unreviewed test gardening.
2749
2750         * LayoutReloaded/misc/LFC-passing-tests.txt:
2751
2752 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2753
2754         [Flatpak] Add openjpeg support
2755         https://bugs.webkit.org/show_bug.cgi?id=194019
2756
2757         Reviewed by Michael Catanzaro.
2758
2759         * flatpak/org.webkit.CommonModules.yaml:
2760
2761 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2762
2763         Unreviewed, rolling out r240708.
2764         https://bugs.webkit.org/show_bug.cgi?id=194022
2765
2766         It broke WPE build (Requested by KaL on #webkit).
2767
2768         Reverted changeset:
2769
2770         "[WPE] Bump font related dependencies to match the GTK+ port"
2771         https://bugs.webkit.org/show_bug.cgi?id=194017
2772         https://trac.webkit.org/changeset/240708
2773
2774 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2775
2776         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2777         https://bugs.webkit.org/show_bug.cgi?id=194001
2778
2779         Reviewed by Antti Koivisto.
2780
2781         * LayoutReloaded/misc/LFC-passing-tests.txt:
2782
2783 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2784
2785         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2786         https://bugs.webkit.org/show_bug.cgi?id=194020
2787
2788         Reviewed by Antti Koivisto.
2789
2790         * LayoutReloaded/misc/LFC-passing-tests.txt:
2791
2792 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2793
2794         AX: Support color well on iOS
2795         https://bugs.webkit.org/show_bug.cgi?id=194010
2796
2797         Reviewed by Joanmarie Diggs.
2798
2799         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2800         (WTR::AccessibilityUIElement::stringAttributeValue):
2801
2802 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2803
2804         [WPE] Bump font related dependencies to match the GTK+ port
2805         https://bugs.webkit.org/show_bug.cgi?id=194017
2806
2807         Reviewed by Žan Doberšek.
2808
2809         * wpe/jhbuild.modules:
2810         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2811         * wpe/patches/icudata-stdlibs.patch: Added.
2812
2813 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2814
2815         [Mac] Update window scale API usage
2816         https://bugs.webkit.org/show_bug.cgi?id=193991
2817         rdar://problem/47614795
2818
2819         Reviewed by Tim Horton.
2820
2821         * DumpRenderTree/mac/DumpRenderTree.mm:
2822         (changeWindowScaleIfNeeded):
2823         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2824         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2825         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2826
2827 2019-01-29  Chris Dumez  <cdumez@apple.com>
2828
2829         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2830         https://bugs.webkit.org/show_bug.cgi?id=193977
2831         <rdar://problem/47643716>
2832
2833         Reviewed by Geoff Garen.
2834
2835         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2836         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2837         to the previous provisional committing *before* we make the last load. 
2838
2839         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2840
2841 2019-01-29  Youenn Fablet  <youenn@apple.com>
2842
2843         Adopt new SPI to evaluate server certificate trust
2844         https://bugs.webkit.org/show_bug.cgi?id=193355
2845
2846         Reviewed by Alex Christensen.
2847
2848         Add infrastructure to handle HTTPS server trust evaluation testing.
2849
2850         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2851         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2852         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2853         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2854         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2855         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2856         * WebKitTestRunner/TestController.cpp:
2857         (WTR::TestController::resetPreferencesToConsistentValues):
2858         (WTR::TestController::didReceiveAuthenticationChallenge):
2859         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2860         * WebKitTestRunner/TestController.h:
2861         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2862         * WebKitTestRunner/TestInvocation.cpp:
2863         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2864         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2865         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2866
2867 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2868
2869         [ews-build] Add build step to print bot Configuration
2870         https://bugs.webkit.org/show_bug.cgi?id=193887
2871
2872         Reviewed by Lucas Forschler.
2873
2874         * BuildSlaveSupport/ews-build/steps.py:
2875         (PrintConfiguration): Build step to print configuration.
2876         * BuildSlaveSupport/ews-build/factories.py:
2877
2878 2019-01-29  Chris Dumez  <cdumez@apple.com>
2879
2880         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2881         https://bugs.webkit.org/show_bug.cgi?id=193967
2882         <rdar://problem/47635348>
2883
2884         Reviewed by Alex Christensen.
2885
2886         Add API test coverage.
2887
2888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2889         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2890
2891 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2892
2893         [ews-app] Handle incoming results data
2894         https://bugs.webkit.org/show_bug.cgi?id=193973
2895
2896         Reviewed by Lucas Forschler.
2897
2898         * BuildSlaveSupport/ews-app/ews/views/results.py:
2899
2900 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2901
2902         [ews-app] Make the results url generic
2903         https://bugs.webkit.org/show_bug.cgi?id=193928
2904
2905         Reviewed by Lucas Forschler.
2906
2907         * BuildSlaveSupport/ews-app/ews/urls.py:
2908
2909 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2910
2911         [ews-build] Configure buildbot to send events to ews-app
2912         https://bugs.webkit.org/show_bug.cgi?id=193968
2913
2914         Reviewed by Lucas Forschler.
2915
2916         * BuildSlaveSupport/ews-build/events.py: Added.
2917         * BuildSlaveSupport/ews-build/master.cfg:
2918
2919 2019-01-29  Keith Rollin  <krollin@apple.com>
2920
2921         Add .xcfilelists to Run Script build phases
2922         https://bugs.webkit.org/show_bug.cgi?id=193792
2923         <rdar://problem/47201785>
2924
2925         Reviewed by Alex Christensen.
2926
2927         As part of supporting XCBuild, update the necessary Run Script build
2928         phases in their Xcode projects to refer to their associated
2929         .xcfilelist files.
2930
2931         Note that the addition of these files bumps the Xcode project version
2932         number to something that's Xcode 10 compatible. This change means that
2933         older versions of the Xcode IDE can't read these projects. Nor can it
2934         fully load workspaces that refer to these projects (the updated
2935         projects are shown as non-expandable placeholders). `xcodebuild` can
2936         still build these projects; it's just that the IDE can't open them.
2937
2938         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2939         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2940
2941 2019-01-29  John Wilander  <wilander@apple.com>
2942
2943         Add data abstraction and validation for Ad Click Attribution
2944         https://bugs.webkit.org/show_bug.cgi?id=193916
2945         <rdar://problem/47603481>
2946
2947         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2948
2949         Ad click attribution has two steps. First, the storage of an ad
2950         campaign ID for a click that takes the user to a destination
2951         site. Second, a conversion on the destination site that can be
2952         attributed to the ad click.
2953
2954         This patch adds a class that represents a request for ad click
2955         attribution. Validation makes sure that the bits of entropy
2956         reported through this mechanism is limited.
2957
2958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2959         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2960         (TestWebKitAPI::TEST):
2961
2962 2019-01-29  Chris Dumez  <cdumez@apple.com>
2963
2964         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2965         https://bugs.webkit.org/show_bug.cgi?id=193932
2966         <rdar://problem/47598947>
2967
2968         Reviewed by Brady Eidson.
2969
2970         Add API test coverage.
2971
2972         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2973
2974 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2975
2976         Adding new passing LFC tests.
2977
2978         Unreviewed test gardening.
2979
2980         * LayoutReloaded/misc/LFC-passing-tests.txt:
2981
2982 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2983
2984         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2985         https://bugs.webkit.org/show_bug.cgi?id=193964
2986
2987         Reviewed by Antti Koivisto.
2988
2989         * LayoutReloaded/misc/LFC-passing-tests.txt:
2990
2991 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2992
2993         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2994         https://bugs.webkit.org/show_bug.cgi?id=193954
2995
2996         Reviewed by Antti Koivisto.
2997
2998         * LayoutReloaded/misc/LFC-passing-tests.txt:
2999
3000 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3001
3002         WebDriver: add support for running subtests
3003         https://bugs.webkit.org/show_bug.cgi?id=193904
3004
3005         Reviewed by Michael Catanzaro.
3006
3007         pytest already supports it by passing test.py::subtest, so we can do the same.
3008
3009         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3010         (get_item_name): Made this global.
3011         (CollectRecorder.__init__): Receive the parameter to ignore.
3012         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3013         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3014         (collect): Add parameter to ignore.
3015         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3016         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3017         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3018         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3019         (WebDriverTestRunnerSelenium.run): Ditto.
3020         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3021         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3022         (WebDriverTestRunnerW3C.run): Ditto.
3023
3024 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3025
3026         User agent string override for navigator.userAgent should be site specific quirks
3027         https://bugs.webkit.org/show_bug.cgi?id=193950
3028
3029         Reviewed by Brent Fulgham.
3030
3031         Updated per the _WKWebsitePolicies rename.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3034         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3035
3036 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3037
3038         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3039         https://bugs.webkit.org/show_bug.cgi?id=193941
3040
3041         Reviewed by Alex Christensen.
3042
3043         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3044         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3045         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3046         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3047         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3048         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3049         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3050         * TestWebKitAPI/Tests/WTF/Time.cpp:
3051         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3052         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3053         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3054         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3055
3056 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3057
3058         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3059
3060         * Scripts/webkitpy/common/config/contributors.json:
3061
3062 2019-01-28  Andy Estes  <aestes@apple.com>
3063
3064         [watchOS] Enable Parental Controls content filtering
3065         https://bugs.webkit.org/show_bug.cgi?id=193939
3066         <rdar://problem/46641912>
3067
3068         Reviewed by Ryosuke Niwa.
3069
3070         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3071
3072 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3073
3074         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3075         <https://webkit.org/b/193884>
3076
3077         Reviewed by Jiewen Tan.
3078
3079         * Scripts/webkitpy/style/checkers/cpp.py:
3080         (check_language): Add LocalAuthentication to
3081         `frameworks_with_soft_links`.
3082
3083 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3084
3085         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3086         https://bugs.webkit.org/show_bug.cgi?id=193891
3087
3088         Reviewed by Ross Kirsling.
3089
3090         There were three problems in window sizes of WebView and the host window.
3091         1. The sizes of pixel image output were incorrect.
3092         2. The host window is going to appear after window.resize was invoked.
3093         3. window.resize resized only the host window, not WebView.
3094
3095         This change solves them with a following approach.
3096         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3097         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3098            as well as DumpRenderTree in order to match the client area and the window area.
3099         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3100         d. PlatformWebView::setWindowFrame changes both window sizes.
3101         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3102
3103         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3104         (WTR::PlatformWebView::PlatformWebView): Create the host window
3105         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3106         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3107         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3108
3109 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3110
3111         [ews-app] Add method to save Step data to database
3112         https://bugs.webkit.org/show_bug.cgi?id=193890
3113
3114         Reviewed by Lucas Forschler.
3115
3116         * BuildSlaveSupport/ews-app/ews/models/step.py:
3117         (Step.save_step): Method to save step data.
3118         (Step.update_step): Method to update step data.
3119         (Step.get_existing_step): Method to fetch existing step from database.
3120         (Step.is_valid_result): Method to validate valid step result.
3121
3122 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3123
3124         [ews-app] Add method to save Build data to database
3125         https://bugs.webkit.org/show_bug.cgi?id=193735
3126
3127         Reviewed by Lucas Forschler.
3128
3129         * BuildSlaveSupport/ews-app/ews/models/build.py:
3130         (Build.save_build): Method to save build information to database.
3131         (Build.get_existing_build): Method to fetch existing build from database.
3132         (Build.is_valid_result): Method to validate build result.
3133         * BuildSlaveSupport/ews-app/ews/common/util.py:
3134         (is_valid_int_id): Method to validate valid id.
3135
3136 2019-01-28  Chris Dumez  <cdumez@apple.com>
3137
3138         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3139         https://bugs.webkit.org/show_bug.cgi?id=193915
3140         <rdar://problem/47560907>
3141
3142         Reviewed by Alex Christensen.
3143
3144         Add API test coverage.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3147
3148 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3149
3150         [ews-app] Rename id variables
3151         https://bugs.webkit.org/show_bug.cgi?id=193883
3152
3153         Reviewed by Lucas Forschler.
3154
3155         * BuildSlaveSupport/ews-app/ews/models/build.py:
3156         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3157         * BuildSlaveSupport/ews-app/ews/models/step.py:
3158         * BuildSlaveSupport/ews-app/ews/urls.py:
3159         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3160         * BuildSlaveSupport/ews-app/ews/views/results.py:
3161         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3162
3163 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3164
3165         [ews-app] Allow certain fields to be empty
3166         https://bugs.webkit.org/show_bug.cgi?id=193892
3167
3168         Reviewed by Lucas Forschler.
3169
3170         * BuildSlaveSupport/ews-app/ews/models/build.py:
3171         * BuildSlaveSupport/ews-app/ews/models/step.py:
3172
3173 2019-01-28  Rob Buis  <rbuis@igalia.com>
3174
3175         Update MIME type parser
3176         https://bugs.webkit.org/show_bug.cgi?id=180526
3177
3178         Reviewed by Frédéric Wang.
3179
3180         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3181         (TestWebKitAPI::TEST):
3182
3183 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3184
3185         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3186         https://bugs.webkit.org/show_bug.cgi?id=193896
3187
3188         Reviewed by Antti Koivisto.
3189
3190         * LayoutReloaded/misc/LFC-passing-tests.txt:
3191
3192 2018-12-15  Darin Adler  <darin@apple.com>
3193
3194         Replace many uses of String::format with more type-safe alternatives
3195         https://bugs.webkit.org/show_bug.cgi?id=192742
3196
3197         Reviewed by Mark Lam.
3198
3199         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3200         (WTR::cacheTestRunnerCallback): Use makeString.
3201         * WebKitTestRunner/TestController.cpp:
3202         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3203         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3204
3205 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3206
3207         Use a load optimizer for some sites
3208         https://bugs.webkit.org/show_bug.cgi?id=193881
3209         <rdar://problem/46325455>
3210
3211         Reviewed by Brent Fulgham.
3212
3213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3214         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3215
3216 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3217
3218         AX: Introduce a static accessibility tree
3219         https://bugs.webkit.org/show_bug.cgi?id=193348
3220         <rdar://problem/47203295>
3221
3222         Reviewed by Ryosuke Niwa.
3223
3224         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3225
3226 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3227
3228         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3229         https://bugs.webkit.org/show_bug.cgi?id=193867
3230
3231         Reviewed by Antti Koivisto.
3232
3233         * LayoutReloaded/misc/LFC-passing-tests.txt:
3234
3235 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3236
3237         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3238         https://bugs.webkit.org/show_bug.cgi?id=193865
3239
3240         Reviewed by Antti Koivisto.
3241
3242         * LayoutReloaded/misc/LFC-passing-tests.txt:
3243
3244 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3245
3246         Need a mechanism to override navigator.userAgent
3247         https://bugs.webkit.org/show_bug.cgi?id=193762
3248         <rdar://problem/47504939>
3249
3250         Reviewed by Brent Fulgham.
3251
3252         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3253
3254         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3255         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3256         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3257
3258 2019-01-25  Dean Jackson  <dino@apple.com>
3259
3260         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3261         https://bugs.webkit.org/show_bug.cgi?id=193831
3262         <rdar://problem/47399263>
3263
3264         Reviewed by Chris Dumez.
3265
3266         Two new tests that exercise cross-origin and same-origin System
3267         Previews.
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3270
3271 2019-01-25  Keith Rollin  <krollin@apple.com>
3272
3273         Update Xcode projects with "Check .xcfilelists" build phase
3274         https://bugs.webkit.org/show_bug.cgi?id=193790
3275         <rdar://problem/47201374>
3276
3277         Reviewed by Alex Christensen.
3278
3279         Support for XCBuild includes specifying inputs and outputs to various
3280         Run Script build phases. These inputs and outputs are specified as
3281         .xcfilelist files. Once created, these .xcfilelist files need to be
3282         kept up-to-date. In order to check that they are up-to-date or not,
3283         add an Xcode build step that invokes an external script that performs
3284         the checking. If the .xcfilelists are found to be out-of-date, update
3285         them, halt the build, and instruct the developer to restart the build
3286         with up-to-date files.
3287
3288         At this time, the checking and regenerating is performed only if the
3289         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3290         who want to use this facility can set this variable and test out the
3291         checking/regenerating. Once it seems like there are no egregious
3292         issues that upset a developer's workflow, we'll unconditionally enable
3293         this facility.
3294
3295         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3296         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3297         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3298         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3299
3300 2019-01-25  Keith Rollin  <krollin@apple.com>
3301
3302         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3303         https://bugs.webkit.org/show_bug.cgi?id=193781
3304         <rdar://problem/47201153>
3305
3306         Reviewed by Alex Christensen.
3307
3308         Part of generating the .xcfilelists used as part of adopting XCBuild
3309         includes running `make DerivedSources.make` from a standalone script.
3310         It’s important for this invocation to have the same environment as
3311         when the actual build invokes `make DerivedSources.make`. If the
3312         environments are different, then the two invocations will provide
3313         different results. In order to get the same environment in the
3314         standalone script, have the script launch xcodebuild targeting the
3315         "Apply Configuration to XCFileLists" build target, which will then
3316         re-invoke our standalone script. The script is now running again, this
3317         time in an environment with all workspace, project, target, xcconfig
3318         and other environment variables established.
3319
3320         The "Apply Configuration to XCFileLists" build target accomplishes
3321         this task via a small embedded shell script that consists only of:
3322
3323             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3324
3325         The process that invokes "Apply Configuration to XCFileLists" first
3326         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3327         evaluated and exports it into the shell environment. When xcodebuild
3328         is invoked, it inherits the value of this variable and can `eval` the
3329         contents of that variable. Our external standalone script can then set
3330         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3331         of command-line parameters needed to restart itself in the appropriate
3332         state.
3333
3334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3335         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3336
3337 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3338
3339         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3340         https://bugs.webkit.org/show_bug.cgi?id=193802
3341         <rdar://problem/46010580>
3342
3343         Reviewed by Andy Estes.
3344
3345         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3346         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3347         (TEST):
3348
3349 2019-01-25  Daniel Bates  <dabates@apple.com>
3350
3351         [iOS] uiController.keyDown() does not translate Control modified key
3352         https://bugs.webkit.org/show_bug.cgi?id=192898
3353
3354         Reviewed by Wenson Hsieh.
3355
3356         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3357         key translation, as applicable. Among other cases, key translation occurs when performing
3358         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3359         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3360         human pressing down and releasing key(s) using a hardware keyboard.
3361
3362         * WebKitTestRunner/ios/HIDEventGenerator.h:
3363         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3364         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3365
3366         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3367         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3368         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3369         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3370         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3371         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3372         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3373         (-[HIDEventGenerator longPress:completionBlock:]):
3374         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3375         Update code for above renaming.
3376
3377         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3378         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3379
3380         (-[HIDEventGenerator keyDown:]): Added.
3381         (-[HIDEventGenerator keyUp:]): Added.
3382         (-[HIDEventGenerator keyPress:completionBlock:]):
3383         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3384         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3385         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3386         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3387         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3388         (WTR::parseModifier): Deleted.
3389
3390 2019-01-25  Keith Rollin  <krollin@apple.com>
3391
3392         Complete the implementation of generate-xcfilelists
3393         https://bugs.webkit.org/show_bug.cgi?id=193782
3394
3395         Reviewed by Alex Christensen.
3396
3397         A preliminary version of generate-xcfilelists was added in r238008.
3398         This patch updates that script in order to:
3399
3400         - Support checking of .xcfilelists
3401         - Perform better execution of `make DerivedSources.make` by
3402           relaunching generate-xcfilelists under xcodebuild
3403         - Support incremental generation and checking of .xcfilelists
3404         - Support supplementary .xcfilelists files from WebKitAdditions
3405         - Support being wrapped by parallel version of generate-xcfilelists in
3406           Internal that adds support for (re)generating WebKit projects in
3407           that repo.
3408         - Support builds that have been performed in WebKitBuild as well as
3409           ~/Library/Developer/code/DerivedData
3410         - Increase robustness and debugging facilities.
3411
3412         * Scripts/generate-xcfilelists:
3413
3414 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3415
3416         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3417         https://bugs.webkit.org/show_bug.cgi?id=193297
3418         <rdar://problem/47158841>
3419
3420         Unreviewed test case fix.
3421
3422         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3423         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3424
3425         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3426         (TEST):
3427
3428 2019-01-25  Keith Rollin  <krollin@apple.com>
3429
3430         Update existing .xcfilelists
3431         https://bugs.webkit.org/show_bug.cgi?id=193791
3432         <rdar://problem/47201706>
3433
3434         Reviewed by Alex Christensen.
3435
3436         Many .xcfilelist files were added in r238824 in order to support
3437         XCBuild. Update these with recent changes to the set of build files
3438         and with the current generate-xcfilelist script.
3439
3440         * DumpRenderTree/DerivedSources-input.xcfilelist:
3441         * DumpRenderTree/DerivedSources-output.xcfilelist:
3442         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3443         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3444
3445 2019-01-25  Keith Rollin  <krollin@apple.com>
3446
3447         Fix missing dependencies in extract-dependencies-from-makefile
3448         https://bugs.webkit.org/show_bug.cgi?id=193783
3449         <rdar://problem/47201571>
3450
3451         Reviewed by Alex Christensen.
3452
3453         The extract-dependencies-from-makefile script generates .xcfilelists
3454         for XCBuild by invoking a makefile in --debug mode, parsing the
3455         dependency information in the output, and extracting information
3456         regarding targets and dependents. However, the way `make` emits this
3457         dependency information is not rigorous, and so we need to determine
3458         what lines to look for and parse by trial and error. This approach
3459         didn't coriginally atch all the information we needed to collect, so
3460         update the script to look for the additional lines we now know to look
3461         for.
3462
3463         * Scripts/extract-dependencies-from-makefile:
3464         (Parser):
3465         (Parser.addTarget):
3466         (Parser.addPrereq):
3467         (Parser.doParse):
3468
3469 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3470
3471         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3472         https://bugs.webkit.org/show_bug.cgi?id=193297
3473         <rdar://problem/47158841>
3474
3475         Reviewed by Alex Christensen.
3476
3477         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3478             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3480         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3481         activating the message used to trigger the callback when it is set.
3482
3483 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3484
3485         WKWebView.goBack should reload if there is a safe browsing warning
3486         https://bugs.webkit.org/show_bug.cgi?id=193805
3487         <rdar://problem/46908216>
3488
3489         Reviewed by Geoff Garen.
3490
3491         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3492         (+[Simple3LookupContext sharedLookupContext]):
3493         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3494         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3495         (TEST):
3496
3497 2019-01-25  Chris Dumez  <cdumez@apple.com>
3498
3499         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3500         https://bugs.webkit.org/show_bug.cgi?id=193788
3501         <rdar://problem/47531231>
3502
3503         Reviewed by Alex Christensen.
3504
3505         Add API test coverage.
3506
3507         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3508         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3509
3510 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3511
3512         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3513         https://bugs.webkit.org/show_bug.cgi?id=193771
3514
3515         Unreviewed infrastructure fix.
3516
3517         * Scripts/webkitpy/port/darwin.py:
3518         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3519
3520 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3521
3522         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3523
3524 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3525
3526         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3527
3528         * Scripts/webkitpy/common/config/contributors.json:
3529
3530 2019-01-25  Chris Dumez  <cdumez@apple.com>
3531
3532         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3533         https://bugs.webkit.org/show_bug.cgi?id=193779
3534         <rdar://problem/46170903>
3535
3536         Reviewed by Antti Koivisto.
3537
3538         Add API test that quickly navigates forward to a previous process without waiting for it to
3539         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3540         the process' previous page when reconnecting the it for the forward navigation.
3541
3542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3543
3544 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3545
3546         Need a way for JavaScript (or bundle) code to participate in undo
3547         https://bugs.webkit.org/show_bug.cgi?id=190009
3548         <rdar://problem/44807048>
3549
3550         Reviewed by Ryosuke Niwa.
3551
3552         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3553         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3554
3555         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3556         (WTR::UIScriptController::lastUndoLabel const):
3557         (WTR::UIScriptController::firstRedoLabel const):
3558         (WTR::UIScriptController::platformUndoManager const):
3559         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3560         (WTR::UIScriptController::lastUndoLabel const):
3561         (WTR::UIScriptController::firstRedoLabel const):
3562         (WTR::UIScriptController::platformUndoManager const):
3563         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3564         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3565         (WTR::UIScriptController::lastUndoLabel const):
3566         (WTR::UIScriptController::firstRedoLabel const):
3567         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3568         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3569         (WTR::UIScriptController::lastUndoLabel const):
3570         (WTR::UIScriptController::firstRedoLabel const):
3571         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3572         (WTR::UIScriptController::platformUndoManager const):
3573         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3574         (WTR::UIScriptController::platformUndoManager const):
3575
3576 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3577
3578         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3579         https://bugs.webkit.org/show_bug.cgi?id=193824
3580
3581         Reviewed by Antti Koivisto.
3582
3583         * LayoutReloaded/misc/LFC-passing-tests.txt:
3584
3585 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3586
3587         Update macOS JSC bot configurations
3588         https://bugs.webkit.org/show_bug.cgi?id=193739
3589
3590         Reviewed by Alexey Proskuryakov.
3591
3592         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3594         (BubbleQueueServer): Move JSC EWS to Mojave section.
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3596         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3597         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3598
3599 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3600
3601         [Win][WebKitTestRunner] Implement EventSenderProxy
3602         https://bugs.webkit.org/show_bug.cgi?id=193755
3603
3604         Reviewed by Don Olmstead.
3605
3606         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3607         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3608         (WTR::EventSenderProxy::dispatchMessage):
3609         (WTR::EventSenderProxy::EventSenderProxy):
3610         (WTR::EventSenderProxy::mouseDown):
3611         (WTR::EventSenderProxy::mouseUp):
3612         (WTR::EventSenderProxy::mouseMoveTo):
3613         (WTR::EventSenderProxy::mouseScrollBy):
3614         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3615
3616 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3617
3618         Unreviewed fix for API test failure after r240437.
3619
3620         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3621
3622         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3623
3624 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3625
3626         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3627         https://bugs.webkit.org/show_bug.cgi?id=193787
3628         <rdar://problem/47497634>
3629
3630         Reviewed by Alexey Proskuryakov.
3631
3632         * Scripts/webkitdirs.pm:
3633         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3634
3635 2019-01-24  Truitt Savell  <tsavell@apple.com>
3636
3637         Unreviewed, rolling out r240446.
3638
3639         Casued 5 API failures
3640
3641         Reverted changeset:
3642
3643         "Activate the WebResourceLoadStatisticsStore in the
3644         NetworkProcess and deactivate it in the UIProcess."
3645         https://bugs.webkit.org/show_bug.cgi?id=193297
3646         https://trac.webkit.org/changeset/240446
3647
3648 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3649
3650         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3651         https://bugs.webkit.org/show_bug.cgi?id=193741
3652         <rdar://problem/47135030>
3653
3654         Reviewed by Antti Koivisto and Simon Fraser.
3655
3656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3657         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3658         (TestWebKitAPI::TEST):
3659
3660 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3661
3662         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3663         https://bugs.webkit.org/show_bug.cgi?id=193297
3664         <rdar://problem/47158841>
3665
3666         Reviewed by Alex Christensen.
3667
3668         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3669         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3670         activating the message used to trigger the callback when it is set.
3671
3672 2019-01-24  John Wilander  <wilander@apple.com>
3673
3674         Add Ad Click Attribution as an internal/experimental feature
3675         https://bugs.webkit.org/show_bug.cgi?id=193685
3676         <rdar://problem/47450399>
3677
3678         Reviewed by Brent Fulgham.
3679
3680         Added test option adClickAttributionEnabled.
3681
3682         * DumpRenderTree/TestOptions.cpp:
3683         (TestOptions::TestOptions):
3684         * DumpRenderTree/TestOptions.h:
3685         * DumpRenderTree/mac/DumpRenderTree.mm:
3686         (setWebPreferencesForTestOptions):
3687
3688 2019-01-24  Antti Koivisto  <antti@apple.com>
3689
3690         [PSON] Flash on back navigation on Mac
3691         https://bugs.webkit.org/show_bug.cgi?id=193716
3692         <rdar://problem/47148458>
3693
3694         Reviewed by Chris Dumez.
3695
3696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3697
3698         Closing of the previous page is delayed so waiting for didFinishNavigation is
3699         not sufficient to guarantee we have received all the messages. Wait for them.
3700
3701 2019-01-24  Chris Dumez  <cdumez@apple.com>
3702
3703         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3704         https://bugs.webkit.org/show_bug.cgi?id=193761
3705         <rdar://problem/47456405>
3706
3707         Reviewed by Alex Christensen.
3708
3709         Add API test coverage.
3710
3711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3712
3713 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3714
3715         webkitpy: Missing PID in crashlog name should not be fatal
3716         https://bugs.webkit.org/show_bug.cgi?id=193771
3717
3718         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3719         of raising an exception.
3720
3721         Reviewed by Lucas Forschler.
3722
3723         * Scripts/webkitpy/port/darwin.py:
3724         (DarwinPort._merge_crash_logs):
3725
3726 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3727
3728         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3729         https://bugs.webkit.org/show_bug.cgi?id=193746
3730
3731         Reviewed by Youenn Fablet.
3732
3733         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3734         so we'd best just not call it.
3735
3736         * Scripts/webkitpy/w3c/test_exporter.py:
3737         (WebPlatformTestExporter.create_branch_with_patch):
3738
3739 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3740
3741         Move FileSystem to WTF
3742         https://bugs.webkit.org/show_bug.cgi?id=193602
3743
3744         Reviewed by Yusuke Suzuki.
3745
3746         * DumpRenderTree/win/DumpRenderTree.cpp:
3747         * TestWebKitAPI/CMakeLists.txt:
3748         * TestWebKitAPI/PlatformGTK.cmake:
3749         * TestWebKitAPI/PlatformJSCOnly.cmake:
3750         * TestWebKitAPI/PlatformPlayStation.cmake:
3751         * TestWebKitAPI/PlatformWPE.cmake:
3752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3753         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3754         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3755         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3756         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3757         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3758         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3759         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3760         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3761         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3762
3763 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3764
3765         [WPE] Remove hard dependency on subprocess32 for the API tests
3766
3767         Rubber-stamped by Carlos Garcia Campos.
3768
3769         * glib/api_test_runner.py:
3770         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3771         its presence only when running WPEQt tests.
3772
3773 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3774
3775         [GLIB] Expose JavaScriptCore options in GLib public API
3776         https://bugs.webkit.org/show_bug.cgi?id=188742
3777
3778         Reviewed by Michael Catanzaro.
3779
3780         Add a test for the new API.
3781
3782         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3783         (testsJSCOptions):
3784         (main):
3785
3786 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3787
3788         [GTK][WPE] Support JPEG 2000 images
3789         https://bugs.webkit.org/show_bug.cgi?id=186272
3790
3791         Reviewed by Žan Doberšek.
3792
3793         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3794
3795         * gtk/jhbuild.modules:
3796         * wpe/jhbuild.modules:
3797
3798 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3799
3800         check-webkit-style should warn when using soft-linking macros in a header
3801         <https://webkit.org/b/193750>
3802
3803         Reviewed by Darin Adler.
3804
3805         * Scripts/webkitpy/style/checkers/cpp.py:
3806         (check_language): Add softlink/header check by refactoring the
3807         softlink/framework check.
3808         (CppChecker): Enable softlink/header check by default.
3809         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3810         (CppStyleTest.test_softlink_framework): Rename from
3811         CppStyleTest.test_softlink() and change test framework name in
3812         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3813         files. Set file_name for macros that only appear in headers.
3814         (CppStyleTest.test_softlink_header): Add tests for using
3815         soft-link macros in headers.
3816
3817 2019-01-23  Chris Dumez  <cdumez@apple.com>
3818
3819         Deprecate API to limit the maximum number of WebProcesses
3820         https://bugs.webkit.org/show_bug.cgi?id=193725
3821         <rdar://problem/47464879>
3822
3823         Reviewed by Geoff Garen.
3824
3825         Update existing API tests to stop using deprecated API.
3826
3827         * MiniBrowser/mac/AppDelegate.m:
3828         (defaultConfiguration):
3829         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3830         (TestWebKitAPI::TEST):
3831         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3832         (TestWebKitAPI::TEST):
3833         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3834         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3835         (TEST):
3836         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3837         (TEST):
3838
3839 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3840
3841         [ews-app] Rename ews model buildermappings to buildermapping
3842         https://bugs.webkit.org/show_bug.cgi?id=193729
3843
3844         Reviewed by Lucas Forschler.
3845
3846         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3847         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3848         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3849
3850 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3851
3852         [ews-app] Rename ews model steps to step
3853         https://bugs.webkit.org/show_bug.cgi?id=193697
3854
3855         Reviewed by Lucas Forschler.
3856
3857         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3858         (Step): Renamed Steps to Step.
3859
3860 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3861
3862         Clean up IndexedDB files between tests
3863         https://bugs.webkit.org/show_bug.cgi?id=192796
3864         <rdar://problem/46824999>
3865
3866         Reviewed by Geoffrey Garen.
3867
3868         * DumpRenderTree/mac/DumpRenderTree.mm:
3869         (runTest):
3870         * WebKitTestRunner/TestController.cpp:
3871         (WTR::TestController::resetStateToConsistentValues):
3872         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3873         (WTR::RemoveAllIndexedDatabasesCallback):
3874         (WTR::TestController::ClearIndexedDatabases):
3875         * WebKitTestRunner/TestController.h:
3876         * WebKitTestRunner/TestInvocation.cpp:
3877         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3878
3879 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3880
3881         [ews-app] Rename ews model Builds to Build
3882         https://bugs.webkit.org/show_bug.cgi?id=193695
3883
3884         Reviewed by Lucas Forschler.
3885
3886         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3887         (Build): Renamed Builds to Build.
3888
3889 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3890
3891         webkitpy: Wait longer when launching WebKitTestRunner
3892         https://bugs.webkit.org/show_bug.cgi?id=193734
3893
3894         Reviewed by Aakash Jain.
3895
3896         * Scripts/webkitpy/port/simulator_process.py:
3897         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3898
3899 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3900
3901         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3902         https://bugs.webkit.org/show_bug.cgi?id=193182
3903         <rdar://problem/47452154>
3904
3905         Reviewed by Tim Horton.
3906
3907         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3908         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3909         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3910
3911         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3912         preventing later tests from recognizing gestures.
3913
3914         * WebKitTestRunner/ios/TestControllerIOS.mm:
3915         (WTR::TestController::platformResetStateToConsistentValues):
3916
3917         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3918
3919 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3920
3921         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3922         https://bugs.webkit.org/show_bug.cgi?id=193722
3923         <rdar://problem/47481475>
3924
3925         Reviewed by Lucas Forschler.
3926
3927         iPhone and iPad ports should both use the iOS config.
3928
3929         * Scripts/webkitpy/port/ios_simulator.py:
3930         (IPhoneSimulatorPort.__init__):
3931         (IPadSimulatorPort.__init__):
3932
3933 2019-01-23  Rob Buis  <rbuis@igalia.com>
3934
3935         Update MIME type parser
3936         https://bugs.webkit.org/show_bug.cgi?id=180526
3937
3938         Reviewed by Frédéric Wang.
3939
3940         Add unit tests for both parse modes of ParsedContentType.
3941
3942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3943         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3944         (TestWebKitAPI::TEST):
3945
3946 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3947
3948         [ews-app] fetch loop should not stop on network issues
3949         https://bugs.webkit.org/show_bug.cgi?id=193666
3950
3951         Reviewed by Lucas Forschler.
3952
3953         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3954         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3955
3956 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3957
3958         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3959         https://bugs.webkit.org/show_bug.cgi?id=189165
3960         <rdar://problem/47433765>
3961
3962         Reviewed by Tim Horton.
3963
3964         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3965         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3966         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3967         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3968         would make its way to the UI process by the time the layer tree commit is finished.
3969
3970         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3971         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3972         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3973         will fail because it asks for -_autofillContext too early.
3974
3975         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3976         is handled in the UI process.
3977
3978         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3979
3980         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3981         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3982         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3983         input session.
3984
3985         (-[AutofillTestView textInputHasAutofillContext]):
3986
3987         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3988
3989         * TestWebKitAPI/cocoa/TestWKWebView.h:
3990         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3991         (nextInputSessionChangeCount):
3992
3993         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3994         This includes changing the focused element from one to another.
3995
3996         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3997         (-[TestWKWebView didStartFormControlInteraction]):
3998         (-[TestWKWebView didEndFormControlInteraction]):
3999         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
4000
4001         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
4002         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
4003         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
4004         that doesn't require an input session to one that doesn't.
4005
4006 2019-01-22  David Kilzer  <ddkilzer@apple.com>
4007
4008         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
4009         <https://webkit.org/b/193676>
4010
4011         Reviewed by Alexey Proskuryakov.
4012
4013         * Scripts/webkitpy/style/checkers/cpp.py:
4014         (check_member_initialization_list):
4015         - Don't report missing whitespace around colon if the colon at
4016           the start of the line is formatted correctly.
4017         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4018         (WebKitStyleTest.test_member_initialization_list):
4019         - Add a test for a missing permutation of existing tests.
4020         - Add a test this false-positive.
4021         - Add blank lines between subtests to make them easier to read.
4022
4023 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4024
4025         [build.webkit.org] Unit-test failure after r237113
4026         https://bugs.webkit.org/show_bug.cgi?id=193669
4027
4028         Reviewed by Michael Catanzaro.
4029
4030         * BuildSlaveSupport/build.webkit.org-config/factories.py:
4031         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
4032         multiple or zero flags.
4033
4034 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
4035
4036         Cache bytecode to disk
4037         https://bugs.webkit.org/show_bug.cgi?id=192782
4038         <rdar://problem/46084932>
4039
4040         Reviewed by Keith Miller.
4041
4042         Add test helper to execute bytecode-cache tests: it executes each test
4043         twice, the first with JSC_diskCachePath set to a temporary directory
4044         and second with JSC_forceDiskCache=true (in addition to the cache path)
4045         to guarantee that only the disk cache is being used and no new
4046         UnlinkedCodeBlocks are being created.
4047
4048         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
4049         * Scripts/run-jsc-stress-tests:
4050
4051 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
4052
4053         [css-logical] Implement flow-relative margin, padding and border shorthands
4054         https://bugs.webkit.org/show_bug.cgi?id=188697
4055
4056         Reviewed by Simon Fraser and Antti Koivisto.
4057
4058         * DumpRenderTree/TestOptions.cpp:
4059         (TestOptions::TestOptions):
4060         * DumpRenderTree/TestOptions.h:
4061         * DumpRenderTree/mac/DumpRenderTree.mm:
4062         (setWebPreferencesForTestOptions):
4063         Allow tests to enable the CSSLogicalEnabled flag in WK1.
4064
4065         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4066         (JSONCSSPropertiesChecker.check_codegen_properties):
4067         Allow CSS property definitions to have a 'runtime-flag' parameter which
4068         disables the property when the specified runtime flag is disabled.
4069
4070 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
4071
4072         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
4073         https://bugs.webkit.org/show_bug.cgi?id=193643
4074
4075         Reviewed by Michael Catanzaro.
4076
4077         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
4078         * wpe/jhbuild.modules: Ditto.
4079
4080 2019-01-21  Zalan Bujtas  <zalan@apple.com>
4081
4082         [LFC][Floats] Take float top position into account when computing containing block height.
4083         https://bugs.webkit.org/show_bug.cgi?id=193655
4084
4085         Reviewed by Antti Koivisto.
4086
4087         * LayoutReloaded/misc/LFC-passing-tests.txt:
4088
4089 2019-01-21  David Kilzer  <ddkilzer@apple.com>
4090
4091         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
4092         <https://webkit.org/b/193645>
4093         <rdar://problem/47421574>
4094
4095         Reviewed by Alex Christensen.
4096
4097         - Now checks for local soft-linking of all frameworks that have
4098           their own *SoftLinking.{cpp,h,mm} files.
4099         - Changes softlink/uikit warning to softlink/framework.
4100
4101         * Scripts/webkitpy/style/checkers/cpp.py:
4102         (check_language):
4103         (CppChecker):
4104         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4105         (CppStyleTest):
4106
4107 2019-01-20  Saam Barati  <sbarati@apple.com>
4108
4109         Rollout r240210: It broke tests on iOS
4110         https://bugs.webkit.org/show_bug.cgi?id=193640
4111
4112         Unreviewed.
4113
4114         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
4115         * Scripts/run-jsc-stress-tests:
4116
4117 2019-01-20  chris fleizach  <cfleizach@apple.com>
4118
4119         AX: Support returning relative frames for accessibility
4120         https://bugs.webkit.org/show_bug.cgi?id=193414
4121         <rdar://problem/47268501>
4122
4123         Reviewed by Zalan Bujtas.
4124
4125         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4126         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4127         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4128         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4129         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4130         (WTR::attributesOfElement):
4131         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4132
4133 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4134
4135         Unreviewed, add my new email address
4136
4137         * Scripts/webkitpy/common/config/contributors.json:
4138
4139 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4140
4141         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4142         https://bugs.webkit.org/show_bug.cgi?id=193617
4143
4144         Reviewed by Antti Koivisto.
4145
4146         * LayoutReloaded/misc/LFC-passing-tests.txt:
4147
4148 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4149
4150         Unreviewed, rolling out r240209.
4151
4152         Broke GTK/WPE injected bundle
4153
4154         Reverted changeset:
4155
4156         "AX: Support returning relative frames for accessibility"
4157         https://bugs.webkit.org/show_bug.cgi?id=193414
4158         https://trac.webkit.org/changeset/240209
4159
4160 2019-01-12  Dan Bernstein  <mitz@apple.com>
4161
4162         [Cocoa] Avoid importing directly from subumbrella frameworks
4163         https://bugs.webkit.org/show_bug.cgi?id=186016
4164         <rdar://problem/40591038>
4165
4166         Reviewed by Sam Weinig.
4167
4168         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4169           LaunchServices header.
4170         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4171           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4172         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4173           when using SDKs earlier than 10.13.
4174         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4175           and OTHER_CPLUSPLUSFLAGS.
4176         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4177           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4178         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4179           LaunchServices header.
4180
4181 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4182
4183         Cache bytecode to disk
4184         https://bugs.webkit.org/show_bug.cgi?id=192782
4185         <rdar://problem/46084932>
4186
4187         Reviewed by Keith Miller.
4188
4189         Add test helper to execute bytecode-cache tests: it executes each test
4190         twice, the first with JSC_diskCachePath set to a temporary directory
4191         and second with JSC_forceDiskCache=true (in addition to the cache path)
4192         to guarantee that only the disk cache is being used and no new
4193         UnlinkedCodeBlocks are being created.
4194
4195         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4196         * Scripts/run-jsc-stress-tests:
4197
4198 2019-01-20  chris fleizach  <cfleizach@apple.com>
4199
4200         AX: Support returning relative frames for accessibility
4201         https://bugs.webkit.org/show_bug.cgi?id=193414
4202         <rdar://problem/47268501>
4203
4204         Reviewed by Zalan Bujtas.
4205
4206         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4207         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4208         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4209         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4210         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4211         (WTR::attributesOfElement):
4212         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4213
4214 2019-01-20  Antoine Quint  <graouts@apple.com>
4215
4216         Add a POINTER_EVENTS feature flag
4217         https://bugs.webkit.org/show_bug.cgi?id=193577
4218         <rdar://problem/47408511>
4219
4220         Unreviewed. Also enable Pointer Events for iosmac.
4221
4222         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4223
4224 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4225
4226         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4227         https://bugs.webkit.org/show_bug.cgi?id=193613
4228
4229         Reviewed by Antti Koivisto.
4230
4231         * LayoutReloaded/misc/LFC-passing-tests.txt:
4232
4233 2019-01-19  Antoine Quint  <graouts@apple.com>
4234
4235         Add a POINTER_EVENTS feature flag
4236         https://bugs.webkit.org/show_bug.cgi?id=193577
4237
4238         Reviewed by Dean Jackson.
4239
4240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4241
4242 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
4243
4244         Disable the run-jsc-stress-test remote host key check [second round].
4245         https://bugs.webkit.org/show_bug.cgi?id=192988
4246
4247         Reviewed by Dewei Zhu.
4248
4249         * Scripts/run-jsc-stress-tests:
4250
4251 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4252
4253         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
4254         https://bugs.webkit.org/show_bug.cgi?id=193597
4255
4256         Reviewed by Lucas Forschler.
4257
4258         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4259
4260 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4261
4262         [build.webkit.org] api tests failures are incorrectly named as unit test failures
4263         https://bugs.webkit.org/show_bug.cgi?id=193595
4264
4265         Reviewed by Lucas Forschler.
4266
4267         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
4268         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
4269         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
4270
4271 2019-01-18  Chris Dumez  <cdumez@apple.com>
4272
4273         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
4274         https://bugs.webkit.org/show_bug.cgi?id=193588
4275         <rdar://problem/47131566>
4276
4277         Reviewed by Alex Christensen.
4278
4279         Add layout test coverage.
4280
4281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4282
4283 2019-01-18  Jer Noble  <jer.noble@apple.com>
4284
4285         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4286         https://bugs.webkit.org/show_bug.cgi?id=189553
4287
4288         Reviewed by Tim Horton.
4289
4290         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4291
4292         * ContentExtensionTester/Configurations/Base.xcconfig:
4293         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4294         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4295         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4296         * ImageDiff/cg/Configurations/Base.xcconfig:
4297         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4298         * MiniBrowser/Configurations/Base.xcconfig:
4299         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4300         * MobileMiniBrowser/Configurations/Base.xcconfig:
4301         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4302         * Scripts/webkitpy/style/checker.py:
4303         (_all_categories):
4304         (FileType):
4305         (CheckerDispatcher._file_type):
4306         (CheckerDispatcher._create_checker):
4307         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4308         (SDKVariantChecker):
4309         (SDKVariantChecker.__init__):
4310         (SDKVariantChecker.check):
4311         * TestWebKitAPI/Configurations/Base.xcconfig:
4312         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4313         * WebEditingTester/Configurations/Base.xcconfig:
4314         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4315         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4316         * WebKitTestRunner/Configurations/Base.xcconfig:
4317         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4318         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4319         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4320
4321 2019-01-18  David Kilzer  <ddkilzer@apple.com>
4322
4323         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4324         <https://webkit.org/b/193568>
4325         <rdar://problem/47381130>
4326
4327         Reviewed by Alex Christensen.
4328
4329         Make sure no one re-introduces UIKit soft-linking by adding a
4330         style rule.
4331
4332         * Scripts/webkitpy/style/checkers/cpp.py:
4333         (check_language): Add softlink/uikit check.
4334         (CppChecker): Enable softlink/uikit check.
4335         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4336         (CppStyleTest): Add test for softlink/uikit.
4337
4338 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
4339
4340         [GTK] install-dependencies tool looks for libunistring-dev for dnf
4341         https://bugs.webkit.org/show_bug.cgi?id=193584
4342
4343         Change "-dev" to "-devel".
4344
4345         Reviewed by Michael Catanzaro.
4346
4347         * gtk/install-dependencies:
4348
4349 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4350
4351         webkitpy: Add iPhone and iPad ports
4352         https://bugs.webkit.org/show_bug.cgi?id=193537
4353         <rdar://problem/47353390>
4354
4355         Reviewed by Lucas Forschler.
4356
4357         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
4358         ports. Note that this separation is optional, the --ios-simulator command remains.
4359
4360         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4361         (RunTest.test_device_type_test_division): Drive-by fix.
4362         (RunTest.test_device_type_specific_listing): Ditto.
4363         (RunTest.test_ipad_test_division):
4364         (RunTest):
4365         (RunTest.test_ipad_listing):
4366         * Scripts/webkitpy/port/factory.py:
4367         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
4368         (PortFactory):
4369         * Scripts/webkitpy/port/ios_simulator.py:
4370         (IPhoneSimulatorPort):
4371         (IPadSimulatorPort):
4372
4373 2019-01-18  Chris Dumez  <cdumez@apple.com>
4374
4375         Regression(PSON) Scroll position is not always restored properly when navigating back
4376         https://bugs.webkit.org/show_bug.cgi?id=193578
4377         <rdar://problem/47386331>
4378
4379         Reviewed by