b0e69d5ada2715e61911675eeb65dd125e13a382
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2
3         test-webkitpy: add --timing
4         https://bugs.webkit.org/show_bug.cgi?id=82550
5
6         Reviewed by Eric Seidel.
7
8         This patch adds a --timing option that will display the time
9         each test takes. It also removes the --silent option, since
10         probably no one ever used it, and cleans up the logging
11         option parsing code to be easier to follow.
12
13         * Scripts/webkitpy/test/main.py:
14         (Tester._parse_args):
15         (Tester._configure):
16         * Scripts/webkitpy/test/runner.py:
17         (TestRunner.write_result):
18         * Scripts/webkitpy/test/runner_unittest.py:
19         (RunnerTest.test_regular):
20         (RunnerTest.test_verbose):
21         (RunnerTest):
22         (RunnerTest.test_timing):
23
24 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
25
26         HashMap<>::add should return a more descriptive object
27         https://bugs.webkit.org/show_bug.cgi?id=71063
28
29         Reviewed by Ryosuke Niwa.
30
31         Update code to use AddResult instead of a pair.
32
33         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
34         (LayoutTestController::evaluateScriptInIsolatedWorld):
35         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
36         (LayoutTestController::evaluateScriptInIsolatedWorld):
37         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
38         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
39
40 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
41
42         Web Inspector: chromium: DRT --no-timeout option doesn't work.
43         https://bugs.webkit.org/show_bug.cgi?id=82608
44
45         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
46         This was broken by r112354 and the sequence became opposite.
47
48         Reviewed by Yury Semikhatsky.
49
50         * DumpRenderTree/chromium/TestShell.cpp:
51         (TestShell::TestShell):
52         (TestShell::initialize):
53
54 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
55
56         Remove custom bindings form Internals.idl of attribute type Array.
57         https://bugs.webkit.org/show_bug.cgi?id=82319
58
59         Reviewed by Kentaro Hara.
60
61         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
62
63         * GNUmakefile.am:
64
65 2012-03-28  Mark Rowe  <mrowe@apple.com>
66
67         Fix --no-saved-state.
68
69         Ignore the flag before Lion, rather than making it specific to Lion.
70
71         Rubber-stamped by Dan Bernstein.
72
73         * Scripts/webkitdirs.pm:
74         (argumentsForRunAndDebugMacWebKitApp):
75
76 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
77
78         Add dtharp to contributors list
79         https://bugs.webkit.org/show_bug.cgi?id=82545
80
81         Reviewed by Adam Barth.
82
83         Adding dtharp as Contributor.
84
85         * Scripts/webkitpy/common/config/committers.py:
86
87 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
88
89         build-webkit : the word "pass" is spelled incorrectly as "passs"
90         https://bugs.webkit.org/show_bug.cgi?id=82532
91
92         Reviewed by Julien Chaffraix.
93
94         Corrected spelling of the word "pass" in build-webkit.
95
96         * Scripts/build-webkit:
97
98 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
99
100         new-run-webkit-tests doesn't log correctly after retrying failures
101         https://bugs.webkit.org/show_bug.cgi?id=82541
102
103         Unreviewed, build fix.
104
105         r112189 introduced a regression where we would accidentally
106         delete the log handler after we retried any failing tests - that
107         meant that any log messages around uploading the results got
108         dropped.
109
110         * Scripts/webkitpy/layout_tests/controllers/manager.py:
111         (Manager._run_tests):
112
113 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
114
115         [wx] Unreviewed. Build fix, move WTF back into JSCore target
116         until issues with JSCore not linking in all WTF symbols are resolved.
117
118         * waf/build/settings.py:
119
120 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
121
122         download-built-product build step should detect 404 errors
123         https://bugs.webkit.org/show_bug.cgi?id=82491
124
125         Reviewed by Ryosuke Niwa.
126         
127         Pass --fail to curl so that it reports 404 errors.
128
129         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
130         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
131         * BuildSlaveSupport/built-product-archive:
132         (extractBuiltProduct): Remove trailing whitespace.
133
134 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
135
136         flakiness dashboard should only keep the last 500 runs
137         https://bugs.webkit.org/show_bug.cgi?id=82530
138
139         Reviewed by Ojan Vafai.
140
141         If a bot has an overly large amount of failing tests, then
142         storing 750 runs' worth takes a lot of memory and CPU time to
143         process and we end up getting killed by AppEngine; this cases
144         data corruption and confusion down the road when we have to
145         retry the upload of the data and the tests show up as multiple
146         runs.
147
148         * TestResultServer/model/jsonresults.py:
149         (JsonResults.update_file):
150
151 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
152
153         extract-built-product build step should fail if unzipping fails
154         https://bugs.webkit.org/show_bug.cgi?id=82493
155
156         Reviewed by Simon Fraser.
157
158         Forward non-zero exit code from subprocesses so that the master can detect any failures
159         and bail out early.
160
161         * BuildSlaveSupport/built-product-archive:
162         (main):
163
164 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
165
166         test-webkitpy should support files, directories, and packages as command line args
167         https://bugs.webkit.org/show_bug.cgi?id=76765
168
169         Reviewed by Adam Barth.
170
171         This patch adds support for specifying files, directories, and
172         packages to test-webkitpy along with the already existing
173         support for modules, test classes, and individual test names.
174
175         Also, fix a bug in filesystem_mock where we wouldn't normalize a
176         path containing a reference to the current directory properly,
177         for example, '/foo/./bar.py'.
178
179         * Scripts/webkitpy/common/system/filesystem_mock.py:
180         (MockFileSystem.normpath):
181         * Scripts/webkitpy/test/main.py:
182         (Tester._configure_logging):
183         (Tester._run_tests):
184         * Scripts/webkitpy/test/test_finder.py:
185         (TestDirectoryTree.find_modules):
186         (TestDirectoryTree.subpath):
187         (TestFinder.is_dotted_name):
188         (TestFinder.find_names):
189         (TestFinder):
190         (TestFinder._find_names_for_arg):
191         (TestFinder._find_in_trees):
192         (TestFinder._default_names):
193         * Scripts/webkitpy/test/test_finder_unittest.py:
194         (TestFinderTest.setUp):
195         (TestFinderTest.tearDown):
196         (TestFinderTest.check_names):
197         (TestFinderTest.test_default_names):
198         (TestFinderTest):
199         (TestFinderTest.test_paths):
200
201 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
202
203         Fix inspector tests when running in internal builds.
204
205         <rdar://problem/11050694>
206
207         Reviewed by Tim Hatcher.
208
209         * DumpRenderTree/mac/DumpRenderTree.mm:
210         (resetDefaultsToConsistentValues):
211         * WebKitTestRunner/TestController.cpp:
212         (WTR::TestController::resetStateToConsistentValues):
213
214 2012-03-28  David Kilzer  <ddkilzer@apple.com>
215
216         Use xcrun to find nm and ranlib on OS X builds
217         <http://webkit.org/b/82466>
218
219         Reviewed by Dan Bernstein.
220
221         * Scripts/build-webkit: Use xcrun to find ranlib.
222         * Scripts/webkitdirs.pm:
223         (determineNmPath): Added.  Use xcrun to find nm on OS X.
224         (nmPath): Added.
225         * Scripts/webkitperl/features.pm:
226         (libraryContainsSymbol): Use nmPath().
227
228 2012-03-28  Ojan Vafai  <ojan@chromium.org>
229
230         Add history navigation to garden-o-matic
231         https://bugs.webkit.org/show_bug.cgi?id=82495
232
233         Reviewed by Dimitri Glazkov.
234
235         Also, maintain scroll offsets when returning to a tab. This makes addressing
236         expected failures considerably easier when dealing with below-the-fold tests.
237
238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
239         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
240         switching.
241         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
242         from a file URL and Chrome puts each different file URL in it's own origin.
243
244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
245         Remove the href so that clicking on the accordion item does not modify window.location.hash.
246
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
249
250 2012-03-28  Philippe Normand  <pnormand@igalia.com>
251
252         [GTK] generate-gtk-doc doesn't cope with custom build directory
253         https://bugs.webkit.org/show_bug.cgi?id=82448
254
255         Reviewed by Martin Robinson.
256
257         Pass the product directory in generate-gtkdoc arguments from
258         build-webkit.
259
260         * Scripts/webkitdirs.pm:
261         (buildAutotoolsProject):
262         * gtk/common.py:
263         (get_build_path):
264
265 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
266
267         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
268         https://bugs.webkit.org/show_bug.cgi?id=82341
269
270         Reviewed by Martin Robinson.
271
272         Add --skipped=skip|ignore|only command line option.
273
274         * Scripts/run-gtk-tests:
275         (TestRunner._test_cases_to_skip): Return the list of test cases
276         to skip for the given test depending on the skipped action.
277         (TestRunner._should_run_test): Decide whether to run the test or
278         not depending on the skipped action.
279         (TestRunner.run_tests): Only show the list of skipped tests when
280         skipped action is 'skip'.
281
282 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
283
284         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
285         https://bugs.webkit.org/show_bug.cgi?id=82333
286
287         Reviewed by Martin Robinson.
288
289         * Scripts/run-gtk-tests:
290         (TestRunner.SkippedTest): Add SkippedTest class to store more
291         information about skipped tests.
292         (TestRunner._setup_testing_environment): Use SkippedTest to add
293         TestWebKitAccessibility to the skipped list.
294         (TestRunner._find_skipped_test): Return the SkippedTest object for
295         a given test path.
296         (TestRunner._test_cases_to_skip): Returns the list of test cases
297         that should be skipped for a given test path.
298         (TestRunner._should_run_test): Helper funtion to decide whether
299         the given test path should be run or not. Tests in the skipped
300         list that don't have a list of failing test cases are not run at
301         all. Tests in the skipped list that contain a list of test cases
302         are run with gtester -s to skip the individual test cases.
303         (TestRunner._run_test): Helper funtion to run a given test.
304         (TestRunner.run_tests): Build the list of tests to run based on
305         _should_run_test() and use helper function _run_test() to run
306         every test.
307
308 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
309
310         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
311         https://bugs.webkit.org/show_bug.cgi?id=52810
312
313         Reviewed by Simon Hausmann.
314
315         Use SSE2 floating point math on 32 bit instead of the default
316         387 to make layout test result same on 32 and on 64 bit builds.
317
318         * qmake/mkspecs/features/unix/default_post.prf:
319
320 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
321
322         [Soup] DNS prefetching spams resolver, shoots self in the foot
323         https://bugs.webkit.org/show_bug.cgi?id=41630
324
325         Reviewed by Martin Robinson.
326
327         Bump libsoup and glib dependencies.
328
329         * efl/jhbuild.modules:
330         * gtk/jhbuild.modules:
331
332 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
333
334         [GTK] Disable introspection for jhbuild modules
335         https://bugs.webkit.org/show_bug.cgi?id=82395
336
337         Reviewed by Philippe Normand.
338
339         * efl/jhbuild.modules: add --disable-introspection to all modules
340         that support it
341         * gtk/jhbuild.modules: ditto.
342
343 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
344
345         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
346
347         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
348         (BuildAndTestFactory.__init__):
349
350 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
351
352         [Qt] Unreviewed typo fix after r112383.
353
354         * Scripts/run-qtwebkit-tests:
355         (Main.check_crash_occurences):
356
357 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
358
359         [Qt] run-qtwebkit-tests should report crashes
360         https://bugs.webkit.org/show_bug.cgi?id=76905
361
362         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
363         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
364
365         Reviewed by Csaba Osztrogonác.
366
367         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
368         (RunQtAPITests.commandComplete):
369         (RunQtAPITests.evaluateCommand):
370         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
371         (RunQtAPITestsTest):
372         (test_failure):
373         (test_crash):
374         * Scripts/run-qtwebkit-tests:
375         (Main.announce_results_html):
376         (Main):
377         (Main.check_crash_occurences):
378         (Main.convert_to_stdout):
379         (Main.convert_to_html):
380
381 2012-03-28  Kwonjin Jeong  <gram@company100.net>
382
383         Add support for Intel compiler on Linux QT port.
384         https://bugs.webkit.org/show_bug.cgi?id=81077
385
386         Reviewed by Tor Arne Vestbø.
387
388         * qmake/mkspecs/features/default_post.prf:
389         Don't hide symbols when building with Intel compiler.
390         The symbols are needed when building QtWebKit tests.
391
392         * qmake/mkspecs/features/unix/icc.prf:
393         Added to ignore icc-specific warnings.
394         This feature is used with command-line arguments for build-webkit script.
395
396 2012-03-28  Philippe Normand  <pnormand@igalia.com>
397
398         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
399
400         * Scripts/update-webkitgtk-libs: This script is written in
401         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
402
403 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
404
405         kill-old-processes doesn't do anything on linux
406         https://bugs.webkit.org/show_bug.cgi?id=82388
407
408         Reviewed by Tony Chang.
409
410         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
411         This should help stabilizing Chromium linux bots.
412
413         * BuildSlaveSupport/kill-old-processes:
414
415 2012-03-28  Philippe Normand  <pnormand@igalia.com>
416
417         [GTK] jhbuild wrongly tricked into clean-up
418         https://bugs.webkit.org/show_bug.cgi?id=82216
419
420         Reviewed by Gustavo Noronha Silva.
421
422         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
423         build tree. Also when checking if the jhbuild configuration
424         changed use absolute md5sum paths.
425
426         * Scripts/webkitdirs.pm:
427         (runAutogenForAutotoolsProjectIfNecessary):
428         (jhbuildConfigurationChanged):
429         (buildAutotoolsProject):
430
431 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
432
433         kill-old-processes doesn't do anything on linux
434         https://bugs.webkit.org/show_bug.cgi?id=82388
435
436         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
437
438         The platform in Factory comes from config.json, accordingly platform is fullplatform,
439         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
440
441         Reviewed by Ryosuke Niwa.
442
443         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
444         (Factory.__init__):
445
446 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
447
448         Make Chromium port for Android use hardware gpu path default.
449         https://bugs.webkit.org/show_bug.cgi?id=82033
450
451         Reviewed by Dirk Pranke.
452
453         Skip canvas tests, which are run in virtual gpu test suites.
454
455         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
456         (ChromiumAndroidPort.__init__):
457         (ChromiumAndroidPort.skipped_tests):
458
459 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
460
461         kill-old-processes doesn't do anything on linux
462         https://bugs.webkit.org/show_bug.cgi?id=82388
463
464         Disable kill-old-processes on the Qt bots not to kill each others.
465
466         Reviewed by Ryosuke Niwa.
467
468         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
469         (Factory.__init__):
470
471 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
472
473         Handle DRT crash caused by Android OOM.
474         https://bugs.webkit.org/show_bug.cgi?id=82310
475
476         Reviewed by Tony Chang.
477
478         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
479         is stopped silently and regarded as crashed. Re-run the test for
480         such crash.
481
482         Add some debug log to NRWT.
483
484         * Scripts/webkitpy/layout_tests/port/chromium.py:
485         (ChromiumDriver.run_test):
486         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
487         (ChromiumAndroidPort.__init__):
488         (ChromiumAndroidPort.get_last_stacktrace):
489         (ChromiumAndroidDriver.__init__):
490         (ChromiumAndroidDriver._start):
491         (ChromiumAndroidDriver.run_test):
492         (ChromiumAndroidDriver._get_drt_return_value):
493
494 2012-03-27  Ojan Vafai  <ojan@chromium.org>
495
496         Fix expected results for some unittest failures.
497
498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
499
500 2012-03-27  Adrienne Walker  <enne@google.com>
501
502         [chromium] Fix --enabled-threaded-compositing flag in DRT
503         https://bugs.webkit.org/show_bug.cgi?id=82405
504
505         Reviewed by James Robinson.
506
507         --enable-threaded-compositing wasn't working because there was no way
508         to set the value before it was used in the TestShell constructor.
509
510         To avoid adding yet another boolean parameter to TestShell's
511         constructor, add an explicit initialize function that can operate on
512         any boolean settings that are set post-constructor.
513
514         * DumpRenderTree/chromium/DumpRenderTree.cpp:
515         (main):
516         * DumpRenderTree/chromium/TestShell.cpp:
517         (TestShell::TestShell):
518         (TestShell::initialize):
519         * DumpRenderTree/chromium/TestShell.h:
520         (TestShell):
521         (TestShell::setTestShellMode):
522
523 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
524
525         new-run-webkit-tests: suppress debug output from run-safari on results file
526         https://bugs.webkit.org/show_bug.cgi?id=82400
527
528         Reviewed by Ryosuke Niwa.
529
530         Send the run-safari output to /dev/null rather than the console.
531
532         * Scripts/webkitpy/layout_tests/port/mac.py:
533         (MacPort.show_results_html_file):
534
535 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
536
537         Improve error reporting in run-javascriptcore-tests
538         https://bugs.webkit.org/show_bug.cgi?id=82379
539
540         Reviewed by Jessie Berlin.
541         
542         When the script dies, have it print out the reason for dying.
543
544         * Scripts/run-javascriptcore-tests:
545
546 2012-03-27  Eric Seidel  <eric@webkit.org>
547
548         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
549         https://bugs.webkit.org/show_bug.cgi?id=82373
550
551         Reviewed by Ryosuke Niwa.
552
553         Dave's committer-status in in-progress, so until then
554         list him as a Contributor so at least I can more easily CC him on bugs.
555
556         * Scripts/webkitpy/common/config/committers.py:
557
558 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
559
560         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
561         https://bugs.webkit.org/show_bug.cgi?id=82252
562
563         Reviewed by Gustavo Noronha Silva.
564
565         Appending the directory containing common.py may be problematic if
566         another path in sys.path also contains either a common.py or a
567         common/ module, so prepend to select our version instead. This is
568         the case with fail2ban, which has a common/ directory which may
569         end up being in Python's default path.
570
571         * efl/jhbuildrc:
572         * gtk/jhbuildrc:
573
574 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
575
576         test-webkitpy: prepare for better test run output
577         https://bugs.webkit.org/show_bug.cgi?id=82290
578
579         Reviewed by Adam Barth.
580
581         This code basically re-implements the output of the TextTestRunner default
582         runner code from unittest, although the implementation is quite
583         different, in preparation for changing the test output to be
584         metered and possibly running in parallel.
585
586         The output is almost identical to before, except that instead of
587         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
588         "webkitpy.main.RunnerTest.test_regular passed". It has always
589         annoyed me that they invert the names to be harder to read and
590         so that you can't copy & paste back to the input for
591         test-webkitpy.
592
593         This patch is provided to add a skeleton for unit tests and for
594         comparison to an upcoming patch that will actually add new
595         functionality.
596
597         * Scripts/webkitpy/test/main.py:
598         (Tester.__init__):
599         (Tester._configure_logging):
600         (Tester._run_tests):
601         * Scripts/webkitpy/test/runner.py: Added.
602         (TestRunner):
603         (TestRunner.__init__):
604         (TestRunner.test_name):
605         (TestRunner.all_test_names):
606         (TestRunner.run):
607         (TestRunner.write_result):
608         (TestRunner.write_summary):
609         * Scripts/webkitpy/test/runner_unittest.py: Added.
610         (FakeModuleSuite):
611         (FakeModuleSuite.__init__):
612         (FakeModuleSuite.__str__):
613         (FakeModuleSuite.run):
614         (FakeTopSuite):
615         (FakeTopSuite.__init__):
616         (FakeLoader):
617         (FakeLoader.__init__):
618         (FakeLoader.top_suite):
619         (FakeLoader.loadTestsFromName):
620         (RunnerTest):
621         (RunnerTest.test_regular):
622         (RunnerTest.test_verbose):
623
624 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
625
626         [GTK] Build gnutls without p11-kit support
627         https://bugs.webkit.org/show_bug.cgi?id=82212
628
629         Reviewed by Martin Robinson.
630
631         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
632         configure, to avoid requiring that dependency, which is not used
633         by libsoup and WebKit anyway
634
635 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
636
637         [Qt] Make debug build work on 32 bit
638         https://bugs.webkit.org/show_bug.cgi?id=82331
639
640         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
641         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
642
643         Reviewed by Tor Arne Vestbø.
644
645         * qmake/mkspecs/features/unix/default_post.prf:
646         * qmake/mkspecs/features/unix/default_pre.prf:
647
648 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
649
650         Add png checking to check-webkit-style
651         https://bugs.webkit.org/show_bug.cgi?id=75824
652
653         Reviewed by NOBODY Tony Chang.
654
655         * Scripts/webkitpy/style/checker.py:
656         (_all_categories):
657         (FileType):
658         (CheckerDispatcher._should_skip_file_path):
659         (CheckerDispatcher._file_type):
660         (CheckerDispatcher._create_checker):
661         * Scripts/webkitpy/style/checker_unittest.py:
662         (CheckerDispatcherDispatchTest.test_none_paths):
663         * Scripts/webkitpy/style/checkers/png.py: Added.
664         (PNGChecker):
665         (PNGChecker.__init__):
666         (PNGChecker.check):
667         (PNGChecker._config_file_path):
668         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
669         (MockSCMDetector):
670         (MockSCMDetector.__init__):
671         (MockSCMDetector.display_name):
672         (MockSCMDetector.propget):
673         (PNGCheckerTest):
674         (PNGCheckerTest.test_init):
675         (PNGCheckerTest.test_init.mock_handle_style_error):
676         (PNGCheckerTest.test_check):
677         (PNGCheckerTest.test_check.mock_handle_style_error):
678         * Scripts/webkitpy/style/patchreader.py:
679         (PatchReader.check):
680
681 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
682
683         Unreviewed. Skip GTK+ unit tests that fail in the bots
684
685         * Scripts/run-gtk-tests:
686         (TestRunner): Add failing tests to the skipped list.
687
688 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
689
690         Unreviewed. Unskip all GTK+ unit test.
691
692         Currently, skipped tests contains the list of unit tests that have
693         failed in one or more bots. In this moment it's not possible to
694         skip just the test cases that fail, so the complete unit test is
695         skipped when a single test case fails. For that reason, we don't
696         know which test cases are actually failing for every skipped
697         test. We are planning to land a patch to allow skipping individual
698         test cases, but first we need to know which test cases are
699         currently failing in the bots to skip them. So, this patch simply
700         unskips all unit tests in order to watch the bots and get the list
701         of test cases failing. Failing tests will be skipped again as soon
702         as we have the new list of failing test cases.
703
704         * Scripts/run-gtk-tests:
705         (TestRunner): Reset the list of skipped tests.
706
707 2012-03-26  Scott Byer  <scottbyer@chromium.org>
708
709         Enable layout testing of the scroll animator.
710         https://bugs.webkit.org/show_bug.cgi?id=81858
711         Add a call to the InternalSettings that layout tests can use to
712         turn on scroll animation. Enable animation updates for the
713         Chromium platform DRT when scroll animation has been turned on in
714         a test. This should be a no-op for all current layout tests.
715
716         Reviewed by James Robinson.
717
718         * DumpRenderTree/chromium/WebViewHost.cpp:
719         (WebViewHost::serviceAnimation):
720         (WebViewHost::scheduleAnimation):
721         * DumpRenderTree/chromium/WebViewHost.h:
722         (WebViewHost):
723
724 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
725
726         [Qt][WK2] Support multi-file upload
727         https://bugs.webkit.org/show_bug.cgi?id=81589
728
729         Reviewed by Simon Hausmann.
730
731         Modified filePicker to support multi-file upload.
732
733         * MiniBrowser/qt/MiniBrowser.qrc:
734         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
735         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
736         * MiniBrowser/qt/js/MultiSelect.js: Added.
737         (values):
738         (isSelected):
739         (removeValue):
740         * MiniBrowser/qt/qml/CheckBox.qml: Added.
741         * MiniBrowser/qt/qml/FilePicker.qml:
742
743 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
744
745         Retry crashing tests serially at the end of NRWT on Apple Mac
746         https://bugs.webkit.org/show_bug.cgi?id=82233
747
748         Reviewed by Dirk Pranke.
749
750         * Scripts/webkitpy/layout_tests/controllers/manager.py:
751         (Manager.run):
752         * Scripts/webkitpy/layout_tests/port/base.py:
753         (Port.should_retry_crashes):
754         * Scripts/webkitpy/layout_tests/port/mac.py:
755         (MacPort.should_retry_crashes):
756
757 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
758
759         NRWT should retry failures serially
760         https://bugs.webkit.org/show_bug.cgi?id=82241
761
762         Reviewed by Dirk Pranke.
763
764         * Scripts/webkitpy/layout_tests/controllers/manager.py:
765         (Manager._run_tests): Add another parameter to specify the number of workers to use.
766         (Manager.run): Run the failures serially.
767
768 2012-03-26  Adrienne Walker  <enne@google.com>
769
770         Allow expectations on directories in virtual test suites
771         https://bugs.webkit.org/show_bug.cgi?id=82250
772
773         Reviewed by Dirk Pranke.
774
775         lookup_virtual_test_base was only returning valid results for files
776         and not directories. Fix by falling back to the virtual test suite
777         mapping if possible.
778
779         * Scripts/webkitpy/layout_tests/port/base.py:
780         (Port.lookup_virtual_test_base):
781         * Scripts/webkitpy/layout_tests/port/test.py:
782         (TestPort.skipped_tests):
783         (TestPort.virtual_test_suites):
784
785 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
786
787         Fix duplicated ChangeLog entry from r112171.
788
789         Unreviewed, build fix.
790
791 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
792
793         nrwt: remove --worker-model flag
794         https://bugs.webkit.org/show_bug.cgi?id=82112
795
796         Reviewed by Adam Barth.
797
798         The --worker-model=inline flag is basically redundant with the
799         --child-processes=1 flag (technically, you could one run child
800         process, but this is only useful for testing); this patch
801         removes this flag, which simplifies things and enables more
802         cleanup down the road.
803
804         * Scripts/webkitpy/layout_tests/controllers/manager.py:
805         (Manager._run_tests):
806         (Manager.print_config):
807         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
808         (get):
809         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
810         (make_broker):
811         (FunctionTests.test_get__inline):
812         (FunctionTests.test_get__processes):
813         (_TestsMixin.setUp):
814         (_TestsMixin.make_broker):
815         (InlineBrokerTests.setUp):
816         (MultiProcessBrokerTests.setUp):
817         * Scripts/webkitpy/layout_tests/port/base.py:
818         (Port.default_child_processes):
819         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
820         (ChromiumAndroidPort.check_sys_deps):
821         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
822         (ChromiumAndroidPortTest):
823         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
824         (MockDRTPortTest.make_port):
825         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
826         (PortTestCase):
827         (PortTestCase.make_port):
828         * Scripts/webkitpy/layout_tests/port/test.py:
829         (TestPort.default_child_processes):
830         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
831         (_set_up_derived_options):
832         (parse_args):
833         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
834         (parse_args):
835         (MainTest.test_batch_size):
836         (MainTest.test_child_processes_2):
837         (MainTest.test_child_processes_min):
838         (MainTest.test_exception_raised):
839         (MainTest.test_keyboard_interrupt):
840         (MainTest.test_exit_after_n_crashes):
841         (MainTest.assert_run_order):
842         (MainTest.test_run_order__inline):
843         (MainTest.test_virtual):
844
845 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
846
847         test-webkitpy: split test-finding code into a different module
848         https://bugs.webkit.org/show_bug.cgi?id=82253
849
850         Reviewed by Adam Barth.
851
852         Per suggestion from abarth, this change splits all the
853         filesystem-crawling, test-finding code in test-webkitpy out into
854         a separate module and switches to using a FileSystem object.
855         This makes things much more testable, so we also add tests :).
856
857         We also add a realpath() method to the Filesystem object, since
858         test-webkitpy needs that in order to be able to resolve symlinks
859         properly to determine whether a file is under a particular tree
860         or not.
861
862         * Scripts/webkitpy/common/system/filesystem.py:
863         (FileSystem.realpath):
864         * Scripts/webkitpy/common/system/filesystem_mock.py:
865         (MockFileSystem.realpath):
866         * Scripts/webkitpy/test/main.py:
867         (Tester.__init__):
868         (Tester.add_tree):
869         (Tester.run):
870         (Tester._run_tests):
871         (Tester._log_exception):
872         * Scripts/webkitpy/test/test_finder.py: Added.
873         (TestDirectoryTree):
874         (TestDirectoryTree.__init__):
875         (TestDirectoryTree.find_modules):
876         (TestDirectoryTree.find_modules.file_filter):
877         (TestDirectoryTree.to_module):
878         (TestDirectoryTree.clean):
879         (TestFinder):
880         (TestFinder.__init__):
881         (TestFinder.add_tree):
882         (TestFinder.additional_paths):
883         (TestFinder.clean_trees):
884         (TestFinder.is_module):
885         (TestFinder.to_module):
886         (TestFinder.find_names):
887         (TestFinder._exclude):
888         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
889         (TestFinderTest):
890         (TestFinderTest.setUp):
891         (TestFinderTest.tearDown):
892         (TestFinderTest.test_additional_system_paths):
893         (TestFinderTest.test_is_module):
894         (TestFinderTest.test_to_module):
895         (TestFinderTest.test_clean):
896         (TestFinderTest.test_find_names):
897
898 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
899
900         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
901         https://bugs.webkit.org/show_bug.cgi?id=82209
902
903         Reviewed by Martin Robinson.
904
905         Respecting the $MAKE environment variable when it is defined makes
906         building jhbuild more portable, as some platforms may have GNU
907         make as gmake, for example.
908
909         * jhbuild/jhbuild-wrapper:
910         (install_jhbuild):
911
912 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
913
914         add a Tree abstraction to test-webkitpy to better encapsulate things
915         https://bugs.webkit.org/show_bug.cgi?id=82158
916
917         Reviewed by Adam Barth.
918
919         There are no functional changes in this patch, but adding a
920         basic abstraction for the trees we are looking in for python
921         tests will allow me to add some features later on more easily
922         (like ignoring certain directories like webkitpy/thirdparty),
923         and it makes things slightly less hard-coded.
924
925         * Scripts/test-webkitpy:
926         * Scripts/webkitpy/test/main.py:
927         (Tester.__init__):
928         (Tester):
929         (Tester.add_tree):
930         (Tester._parse_args):
931         (Tester._configure):
932         (Tester.run):
933         (Tester._find_modules):
934         (Tester._run_tests):
935         (Tester._is_module):
936         (Tester._log_exception):
937         (TestDirectoryTree):
938         (TestDirectoryTree.__init__):
939         (TestDirectoryTree.find_modules):
940         (TestDirectoryTree.clean):
941
942 2012-03-26  Ojan Vafai  <ojan@chromium.org>
943
944         garden-o-matic should special case reftests
945         https://bugs.webkit.org/show_bug.cgi?id=81812
946
947         Reviewed by Adam Barth.
948
949         On the examine page, don't show a rebaseline button for reftests.
950         We still show it on the failure summary page because tests are grouped
951         together. Long-term, we should make sure webkit-patch rebaseline-test
952         never tries to rebaseline reftests.
953
954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
957
958 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
959
960         clean up NRWT logging/metering, be less verbose
961         https://bugs.webkit.org/show_bug.cgi?id=73846
962
963         Reviewed by Ojan Vafai.
964
965         Re-land r112014 with a build fix for Python 2.6 compatibility.
966
967         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
968         (ManagerTest.test_http_locking):
969         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
970         (AbstractWorker.run):
971         * Scripts/webkitpy/layout_tests/controllers/worker.py:
972         (Worker.__init__):
973         (Worker._set_up_logging):
974         (Worker):
975         (Worker._set_up_host_and_port):
976         (Worker.run):
977         (Worker.cleanup):
978         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
979         (WorkerTest.test_default_platform_in_worker):
980         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
981         (run):
982         (main):
983         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
984         (MeteredStream):
985         (MeteredStream.implements):
986         (MeteredStream._erasure):
987         (MeteredStream._ensure_newline):
988         (MeteredStream.__init__):
989         (MeteredStream.__del__):
990         (MeteredStream.cleanup):
991         (MeteredStream.write_throttled_update):
992         (MeteredStream.write_update):
993         (MeteredStream.write):
994         (MeteredStream.writeln):
995         (MeteredStream._erase_last_partial_line):
996         (_LogHandler):
997         (_LogHandler.__init__):
998         (_LogHandler.emit):
999         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1000         (RegularTest):
1001         (RegularTest.setUp):
1002         (RegularTest.tearDown):
1003         (RegularTest.time_fn):
1004         (RegularTest.test_logging_not_included):
1005         (RegularTest._basic):
1006         (RegularTest.test_basic):
1007         (RegularTest._log_after_update):
1008         (RegularTest.test_log_after_update):
1009         (TtyTest):
1010         (TtyTest.test_basic):
1011         (TtyTest.test_log_after_update):
1012         (VerboseTest):
1013         (VerboseTest.test_basic):
1014         (VerboseTest.test_log_after_update):
1015         * Scripts/webkitpy/layout_tests/views/printing.py:
1016         (parse_print_options):
1017         (Printer.__init__):
1018         (Printer.cleanup):
1019         (Printer.print_progress):
1020         (Printer.print_update):
1021         (Printer._write):
1022         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1023         (Testprinter.get_printer):
1024         (Testprinter.test_print_progress):
1025         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1026         (PerfTestsRunner.__init__):
1027         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1028         (test_run_test_pause_before_testing):
1029
1030 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1031
1032         [jhbuild] Revert $MAKE environment hack introduced in r101929.
1033         https://bugs.webkit.org/show_bug.cgi?id=82234
1034
1035         Reviewed by Martin Robinson.
1036
1037         The problem it was supposedly fixing was fixed in jhbuild itself
1038         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
1039         can remove the workaround added to the script.
1040
1041         * jhbuild/jhbuild-wrapper:
1042         (install_jhbuild):
1043
1044 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
1045
1046         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
1047         https://bugs.webkit.org/show_bug.cgi?id=82157
1048
1049         Reviewed by Rob Buis.
1050
1051         * Scripts/build-webkit:
1052         Make ENABLE_FILE_SYSTEM default on for blackberry.
1053
1054 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1055
1056         [jhbuild] Explicitly disable DTrace when building glib.
1057         https://bugs.webkit.org/show_bug.cgi?id=82145
1058
1059         Reviewed by Gustavo Noronha Silva.
1060
1061         DTrace support is not really needed by WebKit, so disabling it
1062         helps avoid some build errors on more exotic platforms (such as
1063         FreeBSD).
1064
1065         * efl/jhbuild.modules:
1066         * gtk/jhbuild.modules:
1067
1068 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1069
1070         Unreviewed, rolling out r111993.
1071         http://trac.webkit.org/changeset/111993
1072         https://bugs.webkit.org/show_bug.cgi?id=82184
1073
1074         It broke layout and API tests and made WTR crash (Requested by
1075         Ossy on #webkit).
1076
1077         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1078         (WTR::PlatformWebView::PlatformWebView):
1079
1080 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
1081
1082         [wx] Unreviewed build fix. Move WTF to its own static lib build.
1083
1084         * waf/build/settings.py:
1085         (common_configure):
1086
1087 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
1088
1089         AX: Support solution to handle invalid ax text marker
1090         https://bugs.webkit.org/show_bug.cgi?id=82023
1091
1092         Reviewed by Oliver Hunt.
1093
1094         * DumpRenderTree/AccessibilityUIElement.cpp:
1095         (indexForTextMarkerCallback):
1096         (isTextMarkerValidCallback):
1097         (textMarkerForIndexCallback):
1098         (AccessibilityUIElement::indexForTextMarker):
1099         (AccessibilityUIElement::isTextMarkerValid):
1100         (AccessibilityUIElement::textMarkerForIndex):
1101         (AccessibilityUIElement::getJSClass):
1102         * DumpRenderTree/AccessibilityUIElement.h:
1103         (AccessibilityUIElement):
1104         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1105         (AccessibilityUIElement::indexForTextMarker):
1106         (AccessibilityUIElement::textMarkerForIndex):
1107         (AccessibilityUIElement::isTextMarkerValid):
1108         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1109         (WTR::AccessibilityUIElement::indexForTextMarker):
1110         (WTR::AccessibilityUIElement::isTextMarkerValid):
1111         (WTR::AccessibilityUIElement::textMarkerForIndex):
1112         (WTR):
1113         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1114         (AccessibilityUIElement):
1115         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1116         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1117         (WTR):
1118         (WTR::AccessibilityUIElement::indexForTextMarker):
1119         (WTR::AccessibilityUIElement::isTextMarkerValid):
1120         (WTR::AccessibilityUIElement::textMarkerForIndex):
1121
1122 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1123
1124         Unreviewed, rolling out r112014.
1125         http://trac.webkit.org/changeset/112014
1126         https://bugs.webkit.org/show_bug.cgi?id=82138
1127
1128         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
1129         #webkit).
1130
1131         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1132         (ManagerTest.test_http_locking):
1133         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1134         (AbstractWorker.run):
1135         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1136         (Worker.__init__):
1137         (Worker.safe_init):
1138         (Worker.run):
1139         (Worker.cleanup):
1140         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1141         (WorkerTest.test_default_platform_in_worker):
1142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1143         (run):
1144         (main):
1145         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1146         (MeteredStream):
1147         (MeteredStream.is):
1148         (MeteredStream.__init__):
1149         (MeteredStream.write):
1150         (MeteredStream.update):
1151         (MeteredStream._overwrite):
1152         (MeteredStream._reset):
1153         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1154         (TestMeteredStream):
1155         (TestMeteredStream.test_regular):
1156         * Scripts/webkitpy/layout_tests/views/printing.py:
1157         (_configure_logging):
1158         (_restore_logging):
1159         (Printer.__init__):
1160         (Printer.cleanup):
1161         (Printer.print_progress):
1162         (Printer.print_update):
1163         (Printer._write):
1164         (Printer):
1165         (Printer._update):
1166         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1167         (TestUtilityFunctions.assertEmpty):
1168         (TestUtilityFunctions):
1169         (TestUtilityFunctions.assertNotEmpty):
1170         (TestUtilityFunctions.assertWritten):
1171         (TestUtilityFunctions.test_configure_logging):
1172         (Testprinter.get_printer):
1173         (Testprinter.test_print_progress):
1174         (Testprinter.test_print_progress.mock_time):
1175         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1176         (PerfTestsRunner.__init__):
1177         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1178         (test_run_test_pause_before_testing):
1179
1180 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1181
1182         [wx] Unreviewed. Fix the build after WTF move.
1183
1184         * waf/build/build_utils.py:
1185         (get_excludes):
1186         (get_excludes_in_dirs):
1187         * waf/build/settings.py:
1188         (get_port_excludes):
1189         (common_configure):
1190
1191 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
1192
1193         clean up NRWT logging/metering, be less verbose
1194         https://bugs.webkit.org/show_bug.cgi?id=73846
1195
1196         Reviewed by Ojan Vafai.
1197
1198         This patch totally rewrites the metered_stream module and
1199         changes the way it and the printing module now interact with the
1200         logging subsystem.
1201
1202         The printing module becomes a dumb layout_tests-specific wrapper around
1203         the metered stream. All of the intelligence of how and when to
1204         actually write (or erase) lines and how things interact with
1205         logging moves into the metered stream.
1206
1207         As of now, anything written to the metered stream *bypasses the
1208         logging system*. If a logger is passed to the meter constructor,
1209         the metered stream will also attach a log handler so that all
1210         messages fed to the logger will also be written to the metered
1211         stream. This detangles the logic that used to exist where
1212         sometimes the meter would write to the logger and sometimes the
1213         logger would write to the meter.
1214
1215         All of this makes the logic generic and reusable for
1216         test-webkitpy (coming in another patch). It also helps clarify
1217         what the mysterious "configure_logging" parameter to the printer
1218         constructor used to do (that parameter itself is gone now, and
1219         by default the printer and metered_stream will not ever touch
1220         the logging system; this makes a bunch of tests less fragile).
1221
1222         All of the above should produce no user-visible changes.
1223
1224         However, to also fix the bug in question, we change the message
1225         format in --verbose mode to %H:%M:%S.%frac %pid %message,
1226         eliminating the date, file:lineno, and level parameters. I am
1227         making this change at the same time because it would be
1228         difficult to write things consistently between the logs and the
1229         metered stream if we were still logging the file:lineno.
1230
1231         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1232           Remove the configure_logging parameter
1233         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1234           Use metered stream to configure the logging (we don't need a printer)
1235           and be careful about when and how we manipulate the log level
1236           and handlers on the root logger.
1237         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1238           Pass in the root logger so that log messages are formatted
1239           properly, and set the log level outside of any routines called
1240           by unit tests so as to not interfere.
1241         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
1242           remove a duplicate log message.
1243         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1244           complete rewrite :).
1245         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1246           complete rewrite :).
1247         * Scripts/webkitpy/layout_tests/views/printing.py:
1248           move the logging configuration into metered_stream, and also
1249           move the "when should I log progress messages" into metered stream.
1250         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1251           remove tests that are no longer necessary.
1252         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1253           remove the configure_logging parameter.
1254         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1255           update the test; since the printer no longer writes to the log,
1256           we need to check what is written to the regular_output instead.
1257           (test_run_test_pause_before_testing):
1258
1259 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
1260
1261         Add myself and Martin Robinson to:
1262           * GStreamerGraphics
1263           * GtkWebKit2PublicAPI
1264           * SoupNetwork
1265         and to the newly created WebKitGTKTranslations.
1266
1267         Rubber-stamped by Martin Robinson.
1268
1269         * Scripts/webkitpy/common/config/watchlist:
1270
1271 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1272
1273         [Qt][WK2] Implement PageClient::isViewWindowActive()
1274         https://bugs.webkit.org/show_bug.cgi?id=81143
1275
1276         Reviewed by Kenneth Rohde Christiansen.
1277
1278         Fix the WrapperWindow from our PlatformWebView
1279         so it correctly creates the platform related
1280         stuff for QWindow, which is not created unless
1281         QWindow::setVisible() or QWindow::show() are called.
1282
1283         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1284         (WTR::PlatformWebView::PlatformWebView):
1285
1286 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
1287
1288         nrwt: don't wait for safari to exit before exiting after showing the results file
1289         https://bugs.webkit.org/show_bug.cgi?id=81845
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         Prior to this change, if you ran new-run-webkit-tests and
1294         displayed the HTML results file at the end, we would block
1295         waiting for the user to quit the browser. There doesn't seem to
1296         be a need for that, and the Chromium ports don't do this.
1297
1298         Also, update the mac tests to capture the output and be quiet :).
1299
1300         * Scripts/webkitpy/common/system/executive_mock.py:
1301           Make popen() testable, implement should_log for it.
1302         * Scripts/webkitpy/layout_tests/port/mac.py:
1303         (MacPort.show_results_html_file):
1304         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1305           Silence some of the tests via outputcapture.
1306
1307 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
1308
1309         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
1310         https://bugs.webkit.org/show_bug.cgi?id=82073
1311
1312         Reviewed by Martin Robinson.
1313
1314         * Scripts/webkitdirs.pm:
1315         (jhbuildConfigurationChanged): new function that isolates the
1316         jhbuild configuration change checking from the autogen logic.
1317         (mustReRunAutogen): code for the new function lived here.
1318         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
1319         itself, and cleans up the jhbuild root if configuration has
1320         changed; it also forces autogen to be run in that case, to
1321         make sure the new libraries are used.
1322         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
1323         * jhbuild/jhbuild-wrapper:
1324         (ensure_jhbuild): this might be run inside a jhbuild environment,
1325         in which case aclocal fails when trying to use the now deleted
1326         aclocal directory in the jhbuild prefix, so work around that.
1327
1328 2012-03-23  Ojan Vafai  <ojan@chromium.org>
1329
1330         garden-o-matic scrolls to the top of the page when you click an accordion item
1331         https://bugs.webkit.org/show_bug.cgi?id=82088
1332
1333         Reviewed by Adam Barth.
1334
1335         Check the scroll position and make sure that the clicked accordion item is visible.
1336
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1338
1339 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
1340
1341         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
1342         https://bugs.webkit.org/show_bug.cgi?id=80567
1343
1344         Reviewed by Ryosuke Niwa.
1345
1346         Move clean_up_run to occur right after we finish testing and
1347         before we start processing the results. Also makes set_up_run()
1348         and clean_up_run() private since there's no real need for
1349         callers to be aware of them.
1350
1351         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1352         (Manager._set_up_run):
1353         (Manager.run):
1354         (Manager._clean_up_run):
1355         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1356         (ManagerTest.test_http_locking):
1357         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1358         (run):
1359
1360 2012-03-23  Dean Jackson  <dino@apple.com>
1361
1362         Disable CSS_SHADERS in Apple builds
1363         https://bugs.webkit.org/show_bug.cgi?id=81996
1364
1365         Reviewed by Simon Fraser.
1366
1367         Default enableCSSShaders to be 0 on all builds that use
1368         this script. Use the flag to turn it back on.
1369
1370         * Scripts/build-webkit:
1371
1372 2012-03-23  Tony Chang  <tony@chromium.org>
1373
1374         [chromium] rename newwtf target back to wtf
1375         https://bugs.webkit.org/show_bug.cgi?id=82064
1376
1377         Reviewed by Adam Barth.
1378
1379         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1380
1381 2012-03-23  Jessie Berlin  <jberlin@apple.com>
1382
1383         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
1384         the Lion Intel WebKit2 Debug bots.
1385         https://bugs.webkit.org/show_bug.cgi?id=81012.
1386
1387         Rubber-stamped by Dan Bernstein.
1388
1389         Add a step to kill the pasteboard server while we investigate what is causing these
1390         assertion failures (to get the bots green).
1391
1392         * BuildSlaveSupport/kill-old-processes:
1393
1394 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
1395
1396         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
1397         https://bugs.webkit.org/show_bug.cgi?id=81986
1398
1399         Reviewed by David Levin.
1400
1401         Track whether or not errors are filtered in error handlers. If an
1402         alphabetical sorting error is reported for a header and filtered, try
1403         reporting it for the other potential source of the error. This ensures
1404         that the style bot can still find new sorting errors in both potential
1405         situations:
1406
1407             #include <foo.h> <-- 1. edited line
1408             #include <baz.h> <-- 2. edited line
1409
1410         * Scripts/webkitpy/style/checkers/cpp.py:
1411         (check_include_line): Potentially report the error for both lines,
1412         if the first error is filtered.
1413         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
1414         test that allows only reporting errors for certain lines. This verifies that
1415         when one line of an ordering error is filtered, the error is reported on the
1416         other line.
1417         (ErrorCollector.__init__):
1418         (ErrorCollector.__call__):
1419         (CppStyleTestBase.perform_lint):
1420         (CppStyleTestBase.perform_language_rules_check):
1421         (CppStyleTestBase.assert_language_rules_check):
1422         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
1423         Added a new test that verifies that when one line of the two lines of an ordering
1424         error occur, the error is reported on the other line.
1425         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1426         (MockErrorHandler.__call__): Report True because the error is handled.
1427         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1428         (ErrorCollector.__call__): Ditto.
1429         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1430         (MockErrorHandler.__call__): Ditto.
1431         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1432         (TestErrorHandler.__call__): Ditto.
1433         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1434         (MockErrorHandler.__call__): Ditto.
1435         * Scripts/webkitpy/style/error_handlers.py:
1436         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
1437         and False if it is filtered.
1438
1439 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
1440
1441         Build fix for WinCE after r111778.
1442
1443         * WinCELauncher/CMakeLists.txt:
1444
1445 2012-03-23  Peter Beverloo  <peter@chromium.org>
1446
1447         Unreviewed buildfix for the Chromium Android builder.
1448
1449         Disable the ImageDiff target for now. Android needs to build this for
1450         host rather than for target (as other configurations do), but since the
1451         WTF move the dependency chain got significantly more complicated.
1452
1453         I'll work out a proper fix in the following bug, but since several
1454         things are broken due to this, this buildfix should be landed first.
1455         https://bugs.webkit.org/show_bug.cgi?id=82039
1456
1457         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1458
1459 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1460
1461         [EFL][DRT] Implement LayoutTestController's methods related with editing.
1462         https://bugs.webkit.org/show_bug.cgi?id=80136
1463
1464         Reviewed by Ryosuke Niwa.
1465
1466         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
1467         setSelectTrailingWhitespaceEnabled.
1468
1469         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1470         (LayoutTestController::setSmartInsertDeleteEnabled):
1471         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1472
1473 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1474
1475         Convert hasGrammarMarker to use Internals interface
1476         https://bugs.webkit.org/show_bug.cgi?id=82004
1477
1478         Reviewed by Ryosuke Niwa.
1479
1480         Remove hasGrammarMarker functions, because it is able to work in the
1481         cross-port way through the Internals interface.
1482
1483         * DumpRenderTree/LayoutTestController.cpp:
1484         (LayoutTestController::staticFunctions):
1485         * DumpRenderTree/LayoutTestController.h:
1486         (LayoutTestController):
1487         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1488         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1489         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1490         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1491         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1492         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1493
1494 2012-03-22  Adam Barth  <abarth@webkit.org>
1495
1496         sync-master-with-upstream creates non-linear git history
1497         https://bugs.webkit.org/show_bug.cgi?id=82006
1498
1499         Reviewed by Julien Chaffraix.
1500
1501         Previously this script would create a merge commit at the HEAD of
1502         origin/master, causing your fork of WebKit to diverge from upstream.
1503         The new version of this script pushes directly from upstream to origin
1504         (without round-tripping through any local branches), avoiding this
1505         problem.
1506
1507         * Scripts/sync-master-with-upstream:
1508
1509 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
1510
1511         Unreviewed build fix. Add knowledge of the WTF project to
1512         the autotools build system scripts so that build-jsc works
1513         correctly for GTK+.
1514
1515         * Scripts/webkitdirs.pm:
1516         (buildAutotoolsProject): handle the WTF project, build the
1517         libWTF.la target.
1518         (buildGtkProject): add WTF to the list of supported projects.
1519
1520 2012-03-22  Eric Seidel  <eric@webkit.org>
1521
1522         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
1523         https://bugs.webkit.org/show_bug.cgi?id=81984
1524
1525         Reviewed by Adam Barth.
1526
1527         * Scripts/VCSUtils.pm:
1528         (adjustPathForRecentRenamings):
1529
1530 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1531
1532         [CMake] Fix build-jsc after r111778 and r111797.
1533         https://bugs.webkit.org/show_bug.cgi?id=82001
1534
1535         Reviewed by Filip Pizlo.
1536
1537         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
1538         does return if no error occurred, and build-jsc failed with
1539         "building not defined for this platform".
1540
1541         * Scripts/build-jsc: Always exit after caling
1542         buildCMakeProjectOrExit().
1543         * Scripts/webkitdirs.pm:
1544         (buildCMakeProjectOrExit): Return 0 if no error occurred.
1545
1546 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1547
1548         [CMake] Unreviewed build fix after r111778.
1549
1550         * DumpRenderTree/efl/CMakeLists.txt: Replace
1551         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
1552         paths.
1553         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
1554         wtf include.
1555         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
1556         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
1557         with ${WTF_DIR}/wtf in the include paths.
1558
1559 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
1560
1561         Tools/Scripts/build-jsc doesn't work after WTF move
1562         https://bugs.webkit.org/show_bug.cgi?id=81999
1563
1564         Reviewed by Eric Seidel.
1565         
1566         For ports that require WTF and JSC to be built as two projects and where
1567         the machinery to build both does not already exist, teach the tool to do
1568         so for us.
1569
1570         * Scripts/build-jsc:
1571         (buildMyProject):
1572
1573 2012-03-22  Ojan Vafai  <ojan@chromium.org>
1574
1575         Fix accidental missing line in r111793.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1579         Remove base.values. It was unused and duplicates the builtin Object.values.
1580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1581         Accidentally deleted this line before committing r111793.
1582
1583 2012-03-22  Ojan Vafai  <ojan@chromium.org>
1584
1585         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
1586         https://bugs.webkit.org/show_bug.cgi?id=81983
1587
1588         Reviewed by Adam Barth.
1589
1590         The dialogs get in the way if you are doing multiple rebaselines. Also,
1591         a number of people didn't realize that you could do multiple rebaselines
1592         in parallel. A non-modal dialog is just confusing.
1593
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1596         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
1597         show the number of tests being rebaselined.
1598
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1600         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
1601         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
1602         into a single area.
1603
1604         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
1605         also serves to clear all teh content in the StatusArea. 
1606
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1609
1610 2012-03-22  Tony Chang  <tony@chromium.org>
1611
1612         Unreviewed, fix chromium build after wtf move.
1613
1614         Only use newwtf, remove references to wtf.
1615
1616         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1617
1618 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1619
1620         Actually move WTF files to their new home
1621         https://bugs.webkit.org/show_bug.cgi?id=81844
1622
1623         [Qt] Unreviewed buildfix after r111778.
1624
1625         * DumpRenderTree/qt/DumpRenderTree.pro:
1626
1627 2012-03-22  Dan Bernstein  <mitz@apple.com>
1628
1629         Font fallback in WebKitTestRunner depends on user settings
1630         https://bugs.webkit.org/show_bug.cgi?id=81978
1631
1632         Reviewed by Jessie Berlin.
1633
1634         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1635         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
1636         with a value consisting of the array ("en") to the override defaults
1637         dictionary. This is the same value used in DumpRenderTree, and it
1638         ensures that font fallback follows a consistent path that is not
1639         affected by the language preferences of the user running the test.
1640
1641 2012-03-22  Andy Estes  <aestes@apple.com>
1642
1643         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
1644         https://bugs.webkit.org/show_bug.cgi?id=81971
1645
1646         Reviewed by Dan Bernstein.
1647
1648         Xcode will automatically link ObjC binaries against libarclite in some
1649         cases, which defines a class called __ARCLite__.
1650         check-for-inappropriate-objc-class-names shouldn't complain about this
1651         class name.
1652
1653         * Scripts/check-for-inappropriate-objc-class-names:
1654
1655 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
1656
1657         new-run-webkit-tests blames the wrong test for crashing
1658         https://bugs.webkit.org/show_bug.cgi?id=81951
1659
1660         Reviewed by Adam Barth.
1661
1662         NRWT wasn't extracting the WebProcess pid correct; should've
1663         used re.search instead of re.match :(. Add more tests!
1664
1665         * Scripts/webkitpy/layout_tests/port/mac.py:
1666         (MacPort._get_crash_log):
1667         * Scripts/webkitpy/layout_tests/port/webkit.py:
1668         (WebKitDriver.has_crashed):
1669         (WebKitDriver._check_for_driver_crash):
1670         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1671         (WebKitDriverTest.test_no_timeout):
1672         (WebKitDriverTest):
1673         (WebKitDriverTest.test_check_for_driver_crash):
1674         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
1675         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
1676         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
1677         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
1678         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
1679         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1680
1681 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1682
1683         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
1684         https://bugs.webkit.org/show_bug.cgi?id=81512
1685
1686         Adding missing implementation markerTextForListItem to EFL's
1687         LayoutTestController so that we can unskip related tests from
1688         the skip list.
1689
1690         Reviewed by Antonio Gomes.
1691
1692         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1693         (LayoutTestController::markerTextForListItem): Implemented.
1694
1695 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1696
1697         [EFL] Enable view mode media feature layout tests
1698         https://bugs.webkit.org/show_bug.cgi?id=81205
1699
1700         Adding missing implementation setViewModeMediaFeature to EFL's 
1701         LayoutTestController so that we can unskip view mode 
1702         media feature layout tests.
1703
1704         Reviewed by Antonio Gomes.
1705
1706         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1707         (LayoutTestController::setViewModeMediaFeature): Implemented.
1708
1709 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
1710
1711         nrwt: crash while stopping layout test helper on apple mac lion
1712         https://bugs.webkit.org/show_bug.cgi?id=81949
1713
1714         Reviewed by Eric Seidel.
1715
1716         stop_helper() didn't work right if the helper process wasn't
1717         still running or didn't respond properly to being shut down. Fix
1718         this and add some tests. Also add code to MockExecutive() to be
1719         able to mock executive.popen() properly.
1720
1721         * Scripts/webkitpy/common/system/executive_mock.py:
1722         (MockProcess.__init__):
1723         (MockProcess.wait):
1724         (MockExecutive.__init__):
1725         (MockExecutive.popen):
1726         * Scripts/webkitpy/common/system/systemhost_mock.py:
1727         (MockSystemHost.__init__):
1728         * Scripts/webkitpy/layout_tests/port/mac.py:
1729         (MacPort.start_helper):
1730         (MacPort.stop_helper):
1731         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1732         (test_get_crash_log):
1733         (test_helper_starts):
1734         (test_helper_fails_to_start):
1735         (test_helper_fails_to_stop):
1736         (test_helper_fails_to_stop.bad_waiter):
1737
1738 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
1739
1740         [GTK] Add make to the jhbuild moduleset
1741         https://bugs.webkit.org/show_bug.cgi?id=81769
1742
1743         Reviewed by Martin Robinson.
1744
1745         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
1746         Add GNU make with custom patches to fix several issues:
1747
1748         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
1749           fix the argument list limit of GNU make when running make
1750           distcheck.
1751         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
1752           and Jeremy Devenport to fix parallel build issues present in
1753           GNU make 3.82
1754
1755         * gtk/jhbuild.modules: Added make with patches.
1756         * gtk/patches/make-3.82-arg-list-length.patch: Added.
1757         * gtk/patches/make-3.82-parallel-build.patch: Added.
1758
1759 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
1760
1761         [wx] Unreviewed. Adding Source/WTF to the build and updating
1762         waf port list.
1763
1764         * DumpRenderTree/wscript:
1765         * waf/build/settings.py:
1766
1767 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
1768
1769         Re-land fix for r81603 yet again (!) with latest build fix.
1770         https://bugs.webkit.org/show_bug.cgi?id=81603
1771
1772         Unreviewed, build fix.
1773
1774         The latest problem was a bad sprintf() in
1775         BasePort._get_crash_log(). I've reworked that routine and added
1776         unit tests for coverage.
1777
1778         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1779         (SingleTestRunner._handle_error):
1780         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1781         (write_test_result):
1782         (TestResultWriter.write_crash_log):
1783         * Scripts/webkitpy/layout_tests/port/base.py:
1784         (Port.diff_text):
1785         (Port._get_crash_log):
1786         * Scripts/webkitpy/layout_tests/port/chromium.py:
1787         (ChromiumDriver.run_test):
1788         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1789         (ChromiumDriverTest.test_crash_log):
1790         * Scripts/webkitpy/layout_tests/port/driver.py:
1791         (DriverOutput.__init__):
1792         * Scripts/webkitpy/layout_tests/port/mac.py:
1793         (MacPort.is_lion):
1794         (MacPort._get_crash_log):
1795         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1796         (test_default_child_processes):
1797         (test_get_crash_log):
1798         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1799         (MockDRTPortTest.test_get_crash_log):
1800         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1801         (PortTestCase.test_get_crash_log):
1802         * Scripts/webkitpy/layout_tests/port/test.py:
1803         (TestDriver.run_test):
1804         * Scripts/webkitpy/layout_tests/port/webkit.py:
1805         (WebKitDriver.__init__):
1806         (WebKitDriver._start):
1807         (WebKitDriver.has_crashed):
1808         (WebKitDriver._check_for_driver_crash):
1809         (WebKitDriver.run_test):
1810
1811 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
1812
1813         [Qt] Enable support for handling database quota's in the MiniBrowser
1814         https://bugs.webkit.org/show_bug.cgi?id=81928
1815
1816         Reviewed by Simon Hausmann.
1817
1818         * MiniBrowser/qt/qml/BrowserWindow.qml:
1819
1820 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1821
1822         [EFL] Implement LayoutTestController::setEditingBehavior
1823         https://bugs.webkit.org/show_bug.cgi?id=81124
1824
1825         Adding missing implementation setEditingBehavior to EFL's
1826         LayoutTestController. This implementation allows us to
1827         unskip some tests from the skip list.
1828
1829         Reviewed by Martin Robinson.
1830
1831         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1832         (LayoutTestController::setEditingBehavior): Implemented.
1833
1834 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
1835
1836         [GTK] Use the angle-bracket form to include wtf headers
1837         https://bugs.webkit.org/show_bug.cgi?id=81884
1838
1839         Reviewed by Eric Seidel.
1840
1841         Use #include <wtf/foo> instead of #include "foo".
1842
1843         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1844         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1845         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1846         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1847         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1848         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1849
1850 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
1851
1852         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
1853
1854         * Scripts/webkitpy/common/config/committers.py:
1855
1856 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1857
1858         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
1859         https://bugs.webkit.org/show_bug.cgi?id=81889
1860
1861         Reviewed by Kenneth Rohde Christiansen.
1862
1863         Enable FAST_MOBILE_SCROLLING feature.
1864
1865         * qmake/mkspecs/features/features.prf:
1866
1867 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1868
1869         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
1870         https://bugs.webkit.org/show_bug.cgi?id=81900
1871
1872         Reviewed by Gustavo Noronha Silva.
1873
1874         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
1875         path which assumed a certain directory structure for the build
1876         directory which may noy be true.
1877
1878         Instead, hardcode the path to the downloaded fonts starting from the
1879         top-level source directory. While this solution is also far from
1880         perfect, it makes it more consistent and reliable, and easier to
1881         tackle at once with the rest of bug 81475.
1882
1883         * DumpRenderTree/efl/CMakeLists.txt:
1884
1885 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1886
1887         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
1888         https://bugs.webkit.org/show_bug.cgi?id=81888
1889
1890         Reviewed by Philippe Normand.
1891
1892         * Scripts/update-webkit-libs-jhbuild:
1893         (runJhbuild): Helper function to run jhbuild with a given command.
1894         Instead of running jhbuild directly, use the jhbuild-wrapper, so
1895         that we don't need to run it first to check whether jhbuild is
1896         installed or not.
1897         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
1898         * gtk/run-with-jhbuild: Ditto.
1899         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
1900         not only run.
1901
1902 2012-03-22  Philippe Normand  <pnormand@igalia.com>
1903
1904         Unreviewed, test-webkitpy fix after r111661.
1905
1906         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1907         (MainTest.test_crash_log):
1908         (MainTest.test_web_process_crash_log):
1909
1910 2012-03-22  Philippe Normand  <pnormand@igalia.com>
1911
1912         Unreviewed, test-webkitpy fix after r111642.
1913
1914         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1915         (ChromiumDriverTest.setUp):
1916         (ChromiumDriverTest.test_two_drivers):
1917
1918 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1919
1920         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
1921         https://bugs.webkit.org/show_bug.cgi?id=81603
1922
1923         Unreviewed rolling out r111609 and part of r111615,
1924         because it broke NRWT on Qt-WK2 platform.
1925
1926         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1927         (SingleTestRunner._handle_error):
1928         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1929         (write_test_result):
1930         (TestResultWriter.write_crash_report):
1931         * Scripts/webkitpy/layout_tests/port/base.py:
1932         (Port.is_crash_reporter):
1933         (Port._driver_class):
1934         * Scripts/webkitpy/layout_tests/port/chromium.py:
1935         (ChromiumDriver.run_test):
1936         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1937         (ChromiumDriverTest.test_crashed_process_name):
1938         * Scripts/webkitpy/layout_tests/port/driver.py:
1939         (DriverOutput.__init__):
1940         * Scripts/webkitpy/layout_tests/port/mac.py:
1941         (MacPort):
1942         (MacPort.is_crash_reporter):
1943         (MacPort.release_http_lock):
1944         * Scripts/webkitpy/layout_tests/port/test.py:
1945         (TestDriver.run_test):
1946         * Scripts/webkitpy/layout_tests/port/webkit.py:
1947         (WebKitDriver.__init__):
1948         (WebKitDriver._start):
1949         (WebKitDriver.has_crashed):
1950         (WebKitDriver._check_for_driver_crash):
1951         (WebKitDriver.run_test):
1952
1953 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1954
1955         [Qt] Add full platforms to Qt buildslaves
1956         https://bugs.webkit.org/show_bug.cgi?id=81877
1957
1958         Reviewed by Ryosuke Niwa.
1959
1960         * BuildSlaveSupport/build.webkit.org-config/config.json:
1961
1962 2012-03-21  Johnny Ding  <jnd@chromium.org>
1963
1964         Customize layout test timeout value for different ports.
1965         https://bugs.webkit.org/show_bug.cgi?id=79859
1966
1967         Reviewed by Ojan Vafai.
1968
1969         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1970         (Manager):
1971         * Scripts/webkitpy/layout_tests/port/base.py:
1972         (Port.default_test_timeout_ms):
1973         * Scripts/webkitpy/layout_tests/port/chromium.py:
1974         (ChromiumDriver.stop):
1975         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1976         (ChromiumAndroidPort.default_test_timeout_ms):
1977         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1978         (_set_up_derived_options):
1979
1980 2012-03-21  Mark Rowe  <mrowe@apple.com>
1981
1982         Fix the build.
1983
1984         Ensure that our test tools don't try and use RTTI unnecessarily.
1985
1986         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1987         * TestWebKitAPI/Configurations/Base.xcconfig:
1988         * WebKitTestRunner/Configurations/Base.xcconfig:
1989
1990 2012-03-21  Adam Barth  <abarth@webkit.org>
1991
1992         WebKit should have some scripts to smooth interactions with GitHub
1993         https://bugs.webkit.org/show_bug.cgi?id=81842
1994
1995         Reviewed by Eric Seidel.
1996
1997         These scripts support the workflow in
1998         https://trac.webkit.org/wiki/UsingGitHub by automating the
1999         configuration and syncing operations needed for a GitHub fork of WebKit
2000         to track the main WebKit repository.
2001
2002         * Scripts/configure-github-as-upstream: Added.
2003         * Scripts/sync-master-with-upstream: Added.
2004
2005 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2006
2007         WTR - log the pid of a crashing WebProcess
2008         https://bugs.webkit.org/show_bug.cgi?id=81575
2009
2010         Reviewed by Alexey Proskuryakov.
2011
2012         This allows run-webkit-tests to find the right crash log for a
2013         given crashed WebProcess in WebKit2.
2014
2015         * WebKitTestRunner/TestController.cpp:
2016         (WTR::exceededDatabaseQuota):
2017         (WTR::TestController::createOtherPage):
2018         (WTR::TestController::initialize):
2019         (WTR::TestController::resetStateToConsistentValues):
2020         (WTR::TestController::runTest):
2021         (WTR::TestController::processDidCrash):
2022
2023 2012-03-21  Enrica Casucci  <enrica@apple.com>
2024
2025         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
2026         https://bugs.webkit.org/show_bug.cgi?id=81835
2027         <rdar://problem/11082749>
2028
2029         Reviewed by Brady Eidson.
2030
2031         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2032         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2033         (TestWebKitAPI::contextMenuCopyLink):
2034
2035 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
2036
2037         [CSS Shaders] Make CSS Shaders compile on Chromium
2038         https://bugs.webkit.org/show_bug.cgi?id=81435
2039
2040         Reviewed by Stephen White.
2041         
2042         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
2043
2044         * DumpRenderTree/chromium/LayoutTestController.cpp:
2045         (LayoutTestController::overridePreference):
2046         * DumpRenderTree/chromium/WebPreferences.cpp:
2047         (WebPreferences::reset):
2048         (WebPreferences::applyTo):
2049         * DumpRenderTree/chromium/WebPreferences.h:
2050         (WebPreferences):
2051
2052 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2053
2054         fix regression on gtk port introduced by r111609
2055         https://bugs.webkit.org/show_bug.cgi?id=81839
2056
2057         Reviewed by Philippe Normand.
2058
2059         r111609 should've initialized a couple of missing fields in
2060         WebKitDriver, and also should've checked for method overrides
2061         in the other ports :(.
2062
2063         * Scripts/webkitpy/layout_tests/port/gtk.py:
2064         (GtkDriver._start):
2065         * Scripts/webkitpy/layout_tests/port/webkit.py:
2066         (WebKitDriver.__init__):
2067         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2068         (MainTest.test_crash_log):
2069         (MainTest.test_web_process_crash_log):
2070
2071 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2072
2073         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2074         https://bugs.webkit.org/show_bug.cgi?id=81603
2075
2076         Reviewed by Adam Barth.
2077
2078         Add a new _get_crash_log() overridable method on the Port
2079         object to customize how we fetch crash logs per port.
2080         Mac will now slow-spin with a timeout waiting for the crash log, rather
2081         than waiting for the ReportCrash process to exit (it appears
2082         that the mac will manage multiple crashes with a single
2083         ReportCrash process, the process waits around longer than
2084         necessary, presumably to avoid thrashing if processes are
2085         repeatedly crashing).
2086
2087         Also, add the DriverOutput should contain the crash log and other info,
2088         which is created in a port-specific manner but can then be
2089         treated generically. Previously single_test_runner would get
2090         told that something crashed and attempt to do something to get
2091         the crash log, but it didn't have the information it needed to
2092         od the right thing; better to make the driver hand back the
2093         right info.
2094
2095         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2096         (SingleTestRunner._handle_error):
2097         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2098         (write_test_result):
2099         (TestResultWriter.write_crash_log):
2100         * Scripts/webkitpy/layout_tests/port/base.py:
2101         (Port.diff_text):
2102         (Port._get_crash_log):
2103         * Scripts/webkitpy/layout_tests/port/chromium.py:
2104         (ChromiumDriver.run_test):
2105         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2106         (ChromiumDriverTest.test_crash_log):
2107         * Scripts/webkitpy/layout_tests/port/driver.py:
2108         (DriverOutput.__init__):
2109         * Scripts/webkitpy/layout_tests/port/mac.py:
2110         (MacPort.is_lion):
2111         (MacPort._get_crash_log):
2112         * Scripts/webkitpy/layout_tests/port/test.py:
2113         (TestDriver.run_test):
2114         * Scripts/webkitpy/layout_tests/port/webkit.py:
2115         (WebKitDriver.__init__):
2116         (WebKitDriver._start):
2117         (WebKitDriver.has_crashed):
2118         (WebKitDriver._check_for_driver_crash):
2119         (WebKitDriver.run_test):
2120
2121 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2122
2123         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
2124         https://bugs.webkit.org/show_bug.cgi?id=81507
2125
2126         Now that we're only loading from one directory, no need to
2127         iterate over a list of directories anymore.
2128
2129         Reviewed by Martin Robinson.
2130
2131         * DumpRenderTree/efl/CMakeLists.txt:
2132         * DumpRenderTree/efl/FontManagement.cpp:
2133         (addFontDirectory):
2134         (addFontsToEnvironment):
2135
2136 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2137
2138         webkitpy: get ServerProcess out of the reportcrash business
2139         https://bugs.webkit.org/show_bug.cgi?id=81600
2140
2141         Unreviewed, build fix.
2142
2143         Re-land r111307 and r111293 with another fix for a crash in NRWT;
2144         we need to check if the driver has crashed before attempting to
2145         read from it.
2146
2147
2148         * Scripts/webkitpy/layout_tests/port/server_process.py:
2149         (ServerProcess._reset):
2150         (ServerProcess._handle_possible_interrupt):
2151         (ServerProcess.write):
2152         (ServerProcess.read_stdout):
2153         (ServerProcess.has_crashed):
2154         (ServerProcess._read):
2155         (ServerProcess.stop):
2156         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2157         (TrivialMockPort.check_for_leaks):
2158         (TestServerProcess.test_broken_pipe):
2159         * Scripts/webkitpy/layout_tests/port/webkit.py:
2160         (WebKitPort._read_image_diff):
2161         (WebKitDriver.has_crashed):
2162         (WebKitDriver._check_for_driver_crash):
2163         (WebKitDriver.run_test):
2164         (WebKitDriver._read_block):
2165         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2166         (MockServerProcess.__init__):
2167         (MockServerProcess):
2168         (MockServerProcess.has_crashed):
2169
2170 2012-03-21  Zeno Albisser  <zeno@webkit.org>
2171
2172         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
2173         https://bugs.webkit.org/show_bug.cgi?id=81750
2174
2175         Building WebCore on mac currently creates an archive that is bigger than
2176         4GB. But ranlib fails to create a symbol table for such a big archive,
2177         even on 64bit machines.
2178         Therefore we start using SVGAllInOne.cpp when building debug
2179         on mac. This reduces the size of the archive by about 300MB.
2180
2181         Reviewed by Tor Arne Vestbø.
2182
2183         * qmake/mkspecs/features/mac/default_pre.prf:
2184
2185 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
2186
2187         Updated the address list of committers.py.
2188
2189         Reviewed by Csaba Osztrogonác.
2190
2191         * Scripts/webkitpy/common/config/committers.py:
2192
2193 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
2194
2195         Updating my nick in committers file.
2196
2197         Unreviewed.
2198
2199         * Scripts/webkitpy/common/config/committers.py:
2200
2201 2012-03-21  Peter Beverloo  <peter@chromium.org>
2202
2203         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
2204         https://bugs.webkit.org/show_bug.cgi?id=80861
2205
2206         Reviewed by Tony Chang.
2207
2208         Remove most Android-specific logic from webkitdirs.pm in favor of
2209         handling this during project generation time.
2210
2211         * Scripts/webkitdirs.pm:
2212         (buildChromiumMakefile):
2213
2214 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2215
2216         [GTK] Allow running javascript from location bar in MiniBrowser
2217         https://bugs.webkit.org/show_bug.cgi?id=81331
2218
2219         Reviewed by Martin Robinson.
2220
2221         * MiniBrowser/gtk/BrowserWindow.c:
2222         (activateUriEntryCallback): Use browser_window_load_uri().
2223         (browser_window_load_uri): Check whether uri starts with
2224         javascript: and run the given script, or just call
2225         webkit_web_view_load_uri() to load the given uri.
2226         * MiniBrowser/gtk/BrowserWindow.h:
2227         * MiniBrowser/gtk/main.c:
2228         (createBrowserWindow): Use browser_window_load_uri().
2229
2230 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
2233         https://bugs.webkit.org/show_bug.cgi?id=75543
2234
2235         Reviewed by Martin Robinson.
2236
2237         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
2238         MiniBrowser CPP flags.
2239
2240 2012-03-20  Eric Seidel  <eric@webkit.org>
2241
2242         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
2243         https://bugs.webkit.org/show_bug.cgi?id=80911
2244
2245         Reviewed by Adam Barth.
2246
2247         Update include paths for Source/WTF.
2248
2249         * DumpRenderTree/efl/CMakeLists.txt:
2250         * DumpRenderTree/qt/DumpRenderTree.pro:
2251         * QtTestBrowser/QtTestBrowser.pro:
2252         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
2253
2254 2012-03-20  Adam Barth  <abarth@webkit.org>
2255
2256         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
2257         https://bugs.webkit.org/show_bug.cgi?id=81567
2258
2259         Reviewed by Eric Seidel.
2260
2261         This temporary measure should help us avoid disrupting the folks
2262         working on WebAudio when we move the webaudio directory to Modules.
2263
2264         * Scripts/VCSUtils.pm:
2265         (adjustPathForRecentRenamings):
2266         (parseGitDiffHeader):
2267         (parseSvnDiffHeader):
2268
2269 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
2270
2271         Unreviewed, rolling out r111453.
2272         http://trac.webkit.org/changeset/111453
2273         https://bugs.webkit.org/show_bug.cgi?id=81600
2274
2275         still broken
2276
2277         * Scripts/webkitpy/layout_tests/port/server_process.py:
2278         (ServerProcess._reset):
2279         (ServerProcess.handle_interrupt):
2280         (ServerProcess.write):
2281         (ServerProcess._check_for_crash):
2282         (ServerProcess._handle_timeout):
2283         (ServerProcess._check_for_abort):
2284         (ServerProcess._read):
2285         (ServerProcess.stop):
2286         (ServerProcess):
2287         (ServerProcess.set_crashed):
2288         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2289         (TrivialMockPort.is_crash_reporter):
2290         (TestServerProcess.test_broken_pipe):
2291         * Scripts/webkitpy/layout_tests/port/webkit.py:
2292         (WebKitPort._read_image_diff):
2293         (WebKitDriver.has_crashed):
2294         (WebKitDriver._check_for_driver_crash):
2295         (WebKitDriver):
2296         (WebKitDriver._detected_crash):
2297         (WebKitDriver._subprocess_crashed):
2298         (WebKitDriver._crashed_process_name):
2299         (WebKitDriver.run_test):
2300         (WebKitDriver._read_block):
2301         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2302         (MockServerProcess.__init__):
2303
2304 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
2305
2306         webkitpy: get ServerProcess out of the reportcrash business
2307         https://bugs.webkit.org/show_bug.cgi?id=81600
2308
2309         Unreviewed, build fix.
2310
2311         Re-land r111307 and r111293 with fix for crash in NRWT; I
2312         was failing to set the crashing process name.
2313
2314         * Scripts/webkitpy/layout_tests/port/server_process.py:
2315         (ServerProcess._reset):
2316         (ServerProcess._handle_possible_interrupt):
2317         (ServerProcess.write):
2318         (ServerProcess.read_stdout):
2319         (ServerProcess.has_crashed):
2320         (ServerProcess._read):
2321         (ServerProcess.stop):
2322         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2323         (TrivialMockPort.check_for_leaks):
2324         (TestServerProcess.test_broken_pipe):
2325         * Scripts/webkitpy/layout_tests/port/webkit.py:
2326         (WebKitPort._read_image_diff):
2327         (WebKitDriver.has_crashed):
2328         (WebKitDriver._check_for_driver_crash):
2329         (WebKitDriver.run_test):
2330         (WebKitDriver._read_block):
2331         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2332         (MockServerProcess.__init__):
2333         (MockServerProcess):
2334         (MockServerProcess.has_crashed):
2335
2336 2012-03-20  Tim Horton  <timothy_horton@apple.com>
2337
2338         [mac] Restore color space switching code to run-webkit-tests
2339         https://bugs.webkit.org/show_bug.cgi?id=80571
2340         <rdar://problem/11008529>
2341
2342         Reviewed by Simon Fraser.
2343
2344         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
2345         
2346         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
2347         didn't exist until Lion.
2348
2349         * DumpRenderTree/mac/LayoutTestHelper.m:
2350         (installLayoutTestColorProfile):
2351         (restoreUserColorProfile):
2352
2353 2012-03-20  Adele Peterson  <adele@apple.com>
2354
2355         Update the last test to use EXPECT_WK_STREQ.
2356
2357         Reviewed by Dan Bernstein.
2358
2359         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
2360
2361 2012-03-20  Adele Peterson  <adele@apple.com>
2362
2363         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
2364         https://bugs.webkit.org/show_bug.cgi?id=81630
2365         <rdar://problem/10650660>
2366
2367         Reviewed by Alexey Proskuryakov.
2368
2369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2370         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
2371         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
2372         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
2373         (TestWebKitAPI):
2374         (TestWebKitAPI::didFinishLoadForFrame):
2375         (TestWebKitAPI::TEST):
2376         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
2377
2378 2012-03-20  Eric Seidel  <eric@webkit.org>
2379
2380         Add link on queues.webkit.org to kov's fancy queue-depth graph
2381         https://bugs.webkit.org/show_bug.cgi?id=81690
2382
2383         Reviewed by Adam Barth.
2384
2385         * QueueStatusServer/templates/recentstatus.html:
2386
2387 2012-03-20  Tim Horton  <timothy_horton@apple.com>
2388
2389         [mac] Restore color space switching code to run-webkit-tests
2390         https://bugs.webkit.org/show_bug.cgi?id=80571
2391         <rdar://problem/11008529>
2392
2393         Reviewed by Simon Fraser.
2394
2395         Make use of the layout test helper hooks to restore the Mac system-wide
2396         color profile switching code. This makes WkTR and DRT results match, and
2397         causes the main display's color profile to not affect results on Lion.
2398
2399         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2400         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
2401         (installLayoutTestColorProfile):
2402         (restoreUserColorProfile):
2403         (simpleSignalHandler):
2404         (main):
2405         * Scripts/webkitpy/layout_tests/port/mac.py:
2406         (MacPort.release_http_lock):
2407         (MacPort):
2408         (MacPort._path_to_helper):
2409         (MacPort.start_helper):
2410         (MacPort.stop_helper):
2411         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2412         (WTR::PlatformWebView::PlatformWebView):
2413         (WTR::PlatformWebView::windowSnapshotImage):
2414
2415 2012-02-24  Darin Fisher  <darin@chromium.org>
2416
2417         Add more Chromium WebKit API reviewers
2418         https://bugs.webkit.org/show_bug.cgi?id=81576
2419
2420         Reviewed by Adam Barth and David Levin.
2421
2422         Simplify watchlist to lump all WebKit API into one.
2423
2424         * Scripts/webkitpy/common/config/watchlist:
2425
2426 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2427
2428         Convert hasSpellingMarker to use Internals interface.
2429         https://bugs.webkit.org/show_bug.cgi?id=81300
2430
2431         Reviewed by Ryosuke Niwa.
2432
2433         Remove hasSpellingMarker functions, because it is able to work in the
2434         cross-port way through the Internals interface.
2435
2436         * DumpRenderTree/LayoutTestController.cpp:
2437         (LayoutTestController::staticFunctions):
2438         * DumpRenderTree/LayoutTestController.h:
2439         (LayoutTestController):
2440         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2441         * DumpRenderTree/chromium/LayoutTestController.cpp:
2442         (LayoutTestController::LayoutTestController):
2443         * DumpRenderTree/chromium/LayoutTestController.h:
2444         (LayoutTestController):
2445         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2446         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2447         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2448         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2449         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2451         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2452
2453 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2454
2455         Add new Qt-WK2 performance tester bot to build.webkit.org
2456         https://bugs.webkit.org/show_bug.cgi?id=80842
2457
2458         Reviewed by Ryosuke Niwa.
2459
2460         * BuildSlaveSupport/build.webkit.org-config/config.json:
2461         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2462         (RunAndUploadPerfTestsWebKit2):
2463         (RunAndUploadPerfTestsWebKit2.start):
2464         (BuildAndPerfTestWebKit2Factory):
2465         (BuildAndPerfTestWebKit2Factory.__init__):
2466         (DownloadAndPerfTestWebKit2Factory):
2467         (DownloadAndPerfTestWebKit2Factory.__init__):
2468
2469 2012-03-20  Peter Beverloo  <peter@chromium.org>
2470
2471         [Chromium] Update to Android NDK r7b
2472         https://bugs.webkit.org/show_bug.cgi?id=81005
2473
2474         Reviewed by Adam Barth.
2475
2476         Update to version r7b of the Android NDK, release notes of which are
2477         available on the following page:
2478         http://developer.android.com/sdk/ndk/index.html
2479
2480         * Scripts/update-webkit-chromium:
2481
2482 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2483
2484         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
2485         https://bugs.webkit.org/show_bug.cgi?id=81502
2486
2487         Unreviewed.
2488
2489         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
2490
2491 2012-03-19  Jessie Berlin  <jberlin@apple.com>
2492
2493         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
2494         because they broke running the layout tests on mac.
2495
2496         * Scripts/webkitpy/layout_tests/port/webkit.py:
2497         (WebKitDriver._check_for_driver_crash):
2498
2499 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
2500
2501         [GTK] Allow running run-gtk-tests during 'make distcheck'
2502         https://bugs.webkit.org/show_bug.cgi?id=81415
2503
2504         Reviewed by Philippe Normand.
2505
2506         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
2507
2508         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
2509         main command run during 'make check.'
2510         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
2511         a requirement to run it. If jhbuild isn't around it will simply not start the
2512         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
2513         main loop and simply use the main loop in a synchronous method to start SPI
2514         daemons. Did a bunch of general cleanup around these tasks.
2515
2516 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2517
2518         jhbuild: Use the multiprocessing module to get the number of CPUs.
2519         https://bugs.webkit.org/show_bug.cgi?id=81585
2520
2521         Reviewed by Martin Robinson.
2522
2523         Now that support for Python 2.5 has been dropped, we can safely
2524         use multiprocessing.cpu_count() to obtain the current number of
2525         CPUs in the system instead of running a webkitperl script for
2526         that.
2527
2528         * efl/common.py:
2529         (top_level_path):
2530         * efl/jhbuildrc:
2531         * gtk/common.py:
2532         (build_path):
2533         * gtk/jhbuildrc:
2534
2535 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2536
2537         We should only add a live event listener once, not once per TestSelector.
2538         Adding one per TestSelector would cause accordion('option', 'active') to
2539         incorrectly be "false" if you examine multiple sets of tests.
2540
2541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2542
2543 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2544
2545         Fix typo introduced in r111293.
2546
2547         Unreviewed, build fix.
2548
2549         * Scripts/webkitpy/layout_tests/port/webkit.py:
2550         (WebKitDriver._check_for_driver_crash):
2551
2552 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2553
2554         webkitpy: get ServerProcess out of the reportcrash business
2555         https://bugs.webkit.org/show_bug.cgi?id=81600
2556
2557         Reviewed by Adam Barth.
2558
2559         ServerProcess was half-aware that ReportCrash might run
2560         sometimes, and that the process ServerProcess was talking to
2561         might have its own crashing subprocesses; neither of these
2562         things really worked right and it made the logic convoluted, so
2563         this change makes handling crashes completely separate from the
2564         server_process code, so that it can focus on just I/O to the
2565         subprocess.
2566
2567         There should be no functional changes resulting from this patch.
2568
2569         * Scripts/webkitpy/layout_tests/port/server_process.py:
2570         (ServerProcess._reset):
2571         (ServerProcess._handle_possible_interrupt):
2572         (ServerProcess.write):
2573         (ServerProcess.read_stdout):
2574         (ServerProcess.has_crashed):
2575         (ServerProcess._read):
2576         (ServerProcess.stop):
2577         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2578         (TrivialMockPort.check_for_leaks):
2579         (TestServerProcess.test_broken_pipe):
2580         * Scripts/webkitpy/layout_tests/port/webkit.py:
2581         (WebKitPort._read_image_diff):
2582         (WebKitDriver.has_crashed):
2583         (WebKitDriver._check_for_driver_crash):
2584         (WebKitDriver.run_test):
2585         (WebKitDriver._read_block):
2586         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2587         (MockServerProcess.__init__):
2588         (MockServerProcess):
2589         (MockServerProcess.has_crashed):
2590
2591 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2592
2593         webkitpy: crashlog parsing is broken
2594         https://bugs.webkit.org/show_bug.cgi?id=81586
2595
2596         Reviewed by Adam Barth.
2597
2598         Seeking on a file opened through codecs() appears to not work
2599         correctly (at least on SL).
2600         
2601         The code was more complicated than it needed to be, so I have
2602         revamped it to just read a full crashlog at once and then look
2603         for matches. 
2604         
2605         I have also added the ability to optionally propagate
2606         errors back (which can be helpful to debug races when ReportCrash is
2607         still running and you need to see that you couldn't open some
2608         files, rather than just ignoring them).
2609
2610         * Scripts/webkitpy/common/system/crashlogs.py:
2611         (CrashLogs.find_newest_log):
2612         (CrashLogs._find_newest_log_darwin):
2613         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2614         (CrashLogsTest.test_find_log_darwin):
2615
2616 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2617
2618         webkitpy: clean up some port._filesystem references to not reference private members
2619         https://bugs.webkit.org/show_bug.cgi?id=81595
2620
2621         Reviewed by Eric Seidel.
2622
2623         There should be no functional changes in this patch, just some
2624         refactoring. Also, fixes a minor nit in write_image_diff_files(()
2625
2626         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2627         (SingleTestRunner.__init__):
2628         (SingleTestRunner._run_compare_test):
2629         (SingleTestRunner._run_rebaseline):
2630         (SingleTestRunner._save_baseline_data):
2631         (SingleTestRunner._handle_error):
2632         (SingleTestRunner._run_reftest):
2633         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2634         (write_test_result):
2635         (TestResultWriter.__init__):
2636         (TestResultWriter._make_output_directory):
2637         (TestResultWriter.output_filename):
2638         (TestResultWriter._output_testname):
2639         (TestResultWriter.write_output_files):
2640         (TestResultWriter.write_stderr):
2641         (TestResultWriter.write_crash_report):
2642         (TestResultWriter.create_text_diff_and_write_result):
2643         (TestResultWriter.write_image_diff_files):
2644         (copy_file):
2645         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2646         (TestResultWriterTest.test_reftest_diff_image):
2647
2648 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2649
2650         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
2651         https://bugs.webkit.org/show_bug.cgi?id=81598
2652
2653         Reviewed by Eric Seidel.
2654
2655         "DumpRenderTree" shouldn't be hard-coded here, since some other
2656         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
2657         
2658         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2659         (TestExpectations):
2660
2661 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2662
2663         webkitpy: allow instance data in TestFailure objects
2664         https://bugs.webkit.org/show_bug.cgi?id=81580
2665
2666         Reviewed by Tony Chang.
2667
2668         Current TestFailures are basically enums, but it would be nice,
2669         especially for crashes, if they contained the name and pid of
2670         the process that crashed.
2671
2672         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2673         (TestFailure.message):
2674         (FailureTimeout.message):
2675         (FailureCrash):
2676         (FailureCrash.__init__):
2677         (FailureCrash.message):
2678         (FailureMissingResult.message):
2679         (FailureTextMismatch.message):
2680         (FailureMissingImageHash.message):
2681         (FailureMissingImage.message):
2682         (FailureImageHashMismatch.message):
2683         (FailureImageHashIncorrect.message):
2684         (FailureReftestMismatch.message):
2685         (FailureReftestMismatchDidNotOccur.message):
2686         (FailureReftestNoImagesGenerated.message):
2687         (FailureMissingAudio.message):
2688         (FailureAudioMismatch.message):
2689         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2690         (TestFailuresTest.test_equals):
2691         (TestFailuresTest):
2692         (TestFailuresTest.test_crashes):
2693
2694 2012-03-19  Brady Eidson  <beidson@apple.com>
2695
2696         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
2697         Crash in 3rd party WebKit apps under XHR/Cache code
2698
2699         Reviewed by Antti Koivisto.
2700
2701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2702         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
2703         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
2704         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2705         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2706         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2707         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2708         (TestWebKitAPI):
2709         (TestWebKitAPI::TEST):
2710
2711 2012-03-19  Brady Eidson  <beidson@apple.com>
2712
2713         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
2714         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
2715
2716         Reviewed by Enrica Casucci.
2717
2718         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
2719         are in the correct format.
2720
2721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2722         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
2723         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
2724         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
2725         (TestWebKitAPI::contextMenuCopyLink):
2726         (TestWebKitAPI::TEST):
2727
2728 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2729
2730         Make the selected item in the accordion a link to the flakiness dashboard
2731         https://bugs.webkit.org/show_bug.cgi?id=81571
2732
2733         Reviewed by Dimitri Glazkov.
2734
2735         Also, make it so that you can select the text of the link, instead of the current behavior
2736         of acting as if you had clicked on the accordion header.
2737
2738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2740
2741 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2742
2743         NRWT runs some tests that are skipped with -i command line option
2744         https://bugs.webkit.org/show_bug.cgi?id=81535
2745
2746         Reviewed by Ojan Vafai.
2747
2748         This change modifies the interaction of Skipped files and
2749         test_expectations files so that entries in Skipped files (and
2750         the -i command line) override *everything* in the expectations
2751         file.
2752
2753         Specifically, a directory in a Skipped file will cause all of
2754         the tests in the dir to be skipped even if individual tests in
2755         the dir are listed in the test_expectations.txt.
2756
2757         Skipped files also override anything in an overrides files.
2758
2759         This seems to make more intuitive sense, since if you list
2760         something in the Skips file (and even more specify it on the
2761         command line) you probably want it to be universally applied.
2762
2763         Theoretically we could add more precedence levels and have full
2764         paths in an expectations file override dirs in a Skipped file
2765         (but not the command line), but I don't know yet that that level
2766         of complexity is justified.
2767         
2768         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2769         (TestExpectations.__init__):
2770         (TestExpectations._add_skipped_tests):
2771         (TestExpectations._add_test):
2772         (TestExpectations._add_expectations):
2773         (TestExpectations._add_expectation_line):
2774         (TestExpectations._already_seen_better_match):
2775         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2776         (test_more_specific_override_resets_skip):
2777         (SkippedTests):
2778         (SkippedTests.get_exp):
2779         (SkippedTests.assert_exp):
2780         (SkippedTests.test_skipped_tests_work):
2781         (SkippedTests.test_duplicate_skipped_test_fails_lint):
2782         (SkippedTests.test_skipped_file_overrides_expectations):
2783         (SkippedTests.test_skipped_dir_overrides_expectations):
2784         (SkippedTests.test_skipped_file_overrides_overrides):
2785         (SkippedTests.test_skipped_dir_overrides_overrides):
2786
2787 2012-03-19  Eric Seidel  <eric@webkit.org>
2788
2789         Fix WTF header include discipline in Chromium WebKit
2790         https://bugs.webkit.org/show_bug.cgi?id=81281
2791
2792         Reviewed by James Robinson.
2793
2794         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2795         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
2796
2797 2012-03-19  Andy Chen  <andchen@rim.com>
2798
2799         [BlackBerry] Add new layout test for text match marker
2800         https://bugs.webkit.org/show_bug.cgi?id=81531
2801
2802         Make the LayoutTestControllerBlackBerry::findString to test the
2803         BlackBerry port implementation.
2804
2805         Reviewed by Rob Buis.
2806
2807         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2808         (LayoutTestController::findString):
2809
2810 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2811
2812         Don't show WONTFIX tests in garden-o-matic
2813         https://bugs.webkit.org/show_bug.cgi?id=81554
2814
2815         Reviewed by Dimitri Glazkov.
2816
2817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2819
2820 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
2821
2822         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
2823         https://bugs.webkit.org/show_bug.cgi?id=81530
2824
2825         Reviewed by Jessie Berlin.
2826
2827         Add rowAtIndex to WebKitTestRunner.
2828
2829         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2830         (WTR::AccessibilityUIElement::rowAtIndex):
2831         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2832         (AccessibilityUIElement):
2833         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2834         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2835         (WTR):
2836         (WTR::AccessibilityUIElement::rowAtIndex):
2837
2838 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2839
2840         Change garden-o-matic All Failures tab to Expected Failures
2841         https://bugs.webkit.org/show_bug.cgi?id=81540
2842
2843         Reviewed by Dimitri Glazkov.
2844
2845         Also, fix some broken unittests that had just gotten stale.
2846
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2857
2858 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
2859
2860         [chromium] DRT crashes at shutdown.
2861         https://bugs.webkit.org/show_bug.cgi?id=81504
2862
2863         Reviewed by James Robinson.
2864
2865         WebCompositor must be destroyed after WebView is properly destroyed,
2866         or some compositor objects like CCLayerTreeHost may not be destroyed.
2867         However, it is really hard to make the destruction order correct
2868         explicitly in ~TestShell. So move it out to DumpRenderTree.
2869
2870         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2871         (main):
2872         * DumpRenderTree/chromium/TestShell.cpp:
2873         (TestShell::~TestShell):
2874
2875 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2876
2877         add dpranke to webkitpy watchlist
2878         https://bugs.webkit.org/show_bug.cgi?id=81433
2879
2880         Reviewed by Benjamin Poulain.
2881
2882         * Scripts/webkitpy/common/config/watchlist:
2883
2884 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2885
2886         test-webkitpy is failing on SL/Python 2.6.1
2887         https://bugs.webkit.org/show_bug.cgi?id=81533
2888
2889         Reviewed by Ojan Vafai.
2890
2891         It appears that itertools.combinations() is buggy in 2.6.1; this
2892         backports the implementation from 2.7.
2893
2894         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2895         (TestConfigurationConverter.collapse_macros):
2896         (TestConfigurationConverter):
2897         (TestConfigurationConverter.combinations):
2898
2899 2012-03-19  David Michael Barr  <davidbarr@google.com>
2900
2901         Optimize the cleanup sequence in the start-queue.sh script
2902         https://github.com/abarth/webkit/pull/1
2903
2904         Reviewed by Adam Barth.
2905
2906         Updating the working copy is an expensive operation
2907         for a repository the size of WebKit.
2908         Attempt to reset only to the target revision.
2909
2910         * EWSTools/start-queue.sh:
2911
2912 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
2913
2914         Adjust architecture type of the EFL build bot.
2915         https://bugs.webkit.org/show_bug.cgi?id=81452
2916
2917         Reviewed by Tony Chang.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/config.json: The
2920         buildslave is a 64-bit machine, therefore describe it as being
2921         x86_64, not i386.
2922
2923 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
2924
2925         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
2926         https://bugs.webkit.org/show_bug.cgi?id=81514
2927
2928         Reviewed by Simon Hausmann.
2929
2930         * MiniBrowser/qt/qml/BrowserWindow.qml:
2931
2932 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2933
2934         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
2935         https://bugs.webkit.org/show_bug.cgi?id=81491
2936
2937         Reviewed by Philippe Normand.
2938
2939         For the find_path(), find_library() etc CMake calls to find the
2940         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
2941         set, otherwise CMake cannot know the dependencies exist and will only
2942         look in the standard directories.
2943
2944         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
2945         the jhbuild Root directory.
2946
2947 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2948
2949         [EFL] Add XDG env vars to jhbuildrc
2950         https://bugs.webkit.org/show_bug.cgi?id=81510
2951
2952         Needed to ensure correct glib behaviour in jhbuild environment.
2953
2954         Reviewed by Philippe Normand.
2955
2956         * efl/jhbuildrc:
2957
2958 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2959
2960         Select best target for tap gesture.
2961         https://bugs.webkit.org/show_bug.cgi?id=78801
2962
2963         Reviewed by Kenneth Rohde Christiansen.
2964
2965         Add TOUCH_ADJUSTMENT to enabled features.
2966
2967         * qmake/mkspecs/features/features.prf:
2968
2969 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
2970
2971         [chromium] synthesize wheel events for fling on main thread
2972         https://bugs.webkit.org/show_bug.cgi?id=81458
2973
2974         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
2975
2976         Reviewed by James Robinson.
2977
2978         * DumpRenderTree/chromium/EventSender.cpp:
2979         (EventSender::EventSender):
2980         (EventSender::gestureFlingCancel):
2981         (EventSender::gestureFlingStart):
2982         * DumpRenderTree/chromium/EventSender.h:
2983         (EventSender):
2984
2985 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
2986
2987         [Qt] Add command line option to set the user agent in the MiniBrowser
2988         https://bugs.webkit.org/show_bug.cgi?id=81508
2989
2990         Reviewed by Simon Hausmann.
2991
2992         * MiniBrowser/qt/BrowserWindow.cpp:
2993         (BrowserWindow::BrowserWindow):
2994         (BrowserWindow::webViewExperimental):
2995         * MiniBrowser/qt/BrowserWindow.h:
2996         (BrowserWindow):
2997         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2998         (printHelp):
2999         (MiniBrowserApplication::handleUserOptions):
3000         * MiniBrowser/qt/MiniBrowserApplication.h:
3001         (WindowOptions::WindowOptions):
3002         (WindowOptions::setUserAgent):
3003         (WindowOptions::userAgent):
3004         (WindowOptions):
3005
3006 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3007
3008         [Qt] Remove dead user agent code from the MiniBrowser.
3009
3010         Reviewed by Simon Hausmann.
3011
3012         * MiniBrowser/qt/BrowserWindow.cpp:
3013         * MiniBrowser/qt/BrowserWindow.h:
3014         (BrowserWindow):
3015         * MiniBrowser/qt/MiniBrowser.qrc:
3016         * MiniBrowser/qt/useragentlist.txt: Removed.
3017
3018 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3019
3020         jhbuild: Call jhbuild's autogen.sh via bash.
3021         https://bugs.webkit.org/show_bug.cgi?id=81485
3022
3023         Reviewed by Philippe Normand.
3024
3025         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
3026         this is usually true only on Linux systems, and even then bash for
3027         some reason might not be available in that location. It is safer to
3028         call bash directly and pass autogen.sh to it instead.
3029
3030         * jhbuild/jhbuild-wrapper:
3031         (install_jhbuild):
3032
3033 2012-03-19  Philippe Normand  <pnormand@igalia.com>
3034
3035         [GTK] Prefix run-launcher with run-with-jhbuild
3036         https://bugs.webkit.org/show_bug.cgi?id=81503
3037
3038         Reviewed by Hajime Morita.
3039
3040         * Scripts/run-launcher:
3041
3042 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3043
3044         [EFL] Prefix run-launcher with run-with-jhbuild
3045         https://bugs.webkit.org/show_bug.cgi?id=80026
3046
3047         Reviewed by Hajime Morita.
3048
3049         * Scripts/run-launcher:
3050
3051 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3052
3053         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
3054         https://bugs.webkit.org/show_bug.cgi?id=81498
3055
3056         * qmake/mkspecs/features/unix/default_post.prf:
3057
3058 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3059
3060         Unreviewed; switch to using my FreeBSD.org email address, the
3061         other one is going to disappear soon.
3062
3063         * Scripts/webkitpy/common/config/committers.py:
3064         * Scripts/webkitpy/common/config/watchlist:
3065
3066 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
3067
3068         Unreviewed; fix webkitpy unit test failures after r111116.
3069
3070         It turns out that cmd_line in the patch in bug 80025 had the right
3071         signature when it was submitted, but r109242 added a few more
3072         required parameters, and since the method (and EflDriver) did not
3073         exist at the time we ended up committing a broken method.
3074
3075         * Scripts/webkitpy/layout_tests/port/efl.py:
3076         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
3077         arguments.
3078
3079 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3080
3081         [BlackBerry] Enable Web Timing for performance profiling and improvement.
3082         https://bugs.webkit.org/show_bug.cgi?id=81085
3083
3084         Reviewed by Rob Buis.
3085
3086         * Scripts/build-webkit:
3087
3088 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3089
3090         Add a dependencies installation step for EFL to buildbot master.cfg
3091         https://bugs.webkit.org/show_bug.cgi?id=81337
3092
3093         Reviewed by Gustavo Noronha Silva.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3096         (InstallEflDependencies):
3097         (Factory.__init__):
3098
3099 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3100
3101         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
3102         https://bugs.webkit.org/show_bug.cgi?id=80025
3103
3104         Reviewed by Gustavo Noronha Silva.
3105
3106         * Scripts/webkitpy/layout_tests/port/efl.py:
3107         (EflDriver):
3108         (EflDriver.cmd_line):
3109         (EflPort._driver_class):
3110
3111 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3112
3113         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
3114         https://bugs.webkit.org/show_bug.cgi?id=79904
3115
3116         build-webkit --efl will use jhbuild for fetching and building dependencies.
3117
3118         Reviewed by Gustavo Noronha Silva.
3119
3120         * Scripts/update-webkitefl-libs: Added.
3121         * Scripts/webkitdirs.pm:
3122         (jhbuildWrapperPrefixIfNeeded):
3123         (generateBuildSystemFromCMakeProject):
3124         (buildCMakeGeneratedProject):
3125         * efl/common.py: Added.
3126         (script_path):
3127         (top_level_path):
3128         (number_of_cpus):
3129         * efl/jhbuild.modules: Added.
3130         * efl/jhbuildrc: Added.
3131         * efl/run-with-jhbuild: Added.
3132
3133 2012-03-16  Stephanie Lewis  <slewis@apple.com>
3134
3135         https://bugs.webkit.org/show_bug.cgi?id=81065
3136         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
3137         Fix crash preventing WebKitTestRunner from working in Release.  
3138         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
3139         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
3140         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
3141
3142         I removed ostringstream in favor of StringBuilder.  
3143
3144         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
3145
3146         Reviewed by Geoff Garen.
3147
3148         Add DEBUG_DEFINES to set NDEBUG on release builds.
3149         * WebKitTestRunner/Configurations/Base.xcconfig:
3150         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3151
3152         Remove ostringstream member in favor of StringBuilder.
3153         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3154         (WTR::InjectedBundle::initialize):
3155         (WTR::InjectedBundle::beginTesting):
3156         (WTR::InjectedBundle::done):
3157         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3158         (WTF):
3159         (WTR::InjectedBundle::stringBuilder):
3160         (InjectedBundle):
3161
3162         Append output to StringBuilder.
3163         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3164         (WTR::hasPrefix):
3165         (WTR::dumpPath):
3166         (WTR::rangeToStr):
3167         (WTR::styleDecToStr):
3168         (WTR::frameToStr):
3169         (WTR::dumpFrameScrollPosition):
3170         (WTR::dumpFrameText):
3171         (WTR::dumpDescendantFramesText):
3172         (WTR::InjectedBundlePage::dump):
3173         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3174         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3175         (WTR::InjectedBundlePage::willSendRequestForFrame):
3176         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3177         (WTR::lastFileURLPathComponent):
3178         (WTR::InjectedBundlePage::willAddMessageToConsole):
3179         (WTR::InjectedBundlePage::willSetStatusbarText):
3180         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3181         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3182         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3183         (WTR::InjectedBundlePage::shouldBeginEditing):
3184         (WTR::InjectedBundlePage::shouldEndEditing):
3185         (WTR::InjectedBundlePage::shouldInsertNode):
3186         (WTR::InjectedBundlePage::shouldInsertText):
3187         (WTR::InjectedBundlePage::shouldDeleteRange):
3188         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3189         (WTR::InjectedBundlePage::shouldApplyStyle):
3190         (WTR::InjectedBundlePage::didBeginEditing):
3191         (WTR::InjectedBundlePage::didEndEditing):
3192         (WTR::InjectedBundlePage::didChange):
3193         (WTR::InjectedBundlePage::didChangeSelection):
3194         (WTR::InjectedBundlePage::supportsFullScreen):
3195         (WTR::InjectedBundlePage::enterFullScreenForElement):
3196         (WTR::InjectedBundlePage::exitFullScreenForElement):
3197         (WTR::InjectedBundlePage::beganEnterFullScreen):
3198         (WTR::InjectedBundlePage::beganExitFullScreen):
3199         (WTR::dumpBackForwardListItem):
3200         (WTR::InjectedBundlePage::dumpBackForwardList):
3201         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3202         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
3203         (WTR::LayoutTestController::dumpConfigurationForViewport):
3204         
3205         Convert between WTF::String and WKStringRef.
3206         * WebKitTestRunner/StringFunctions.h:
3207         (WTR::toWTFString):
3208         (WTR):
3209         * WebKitTestRunner/TestInvocation.cpp:
3210         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3211
3212 2012-03-16  Eric Seidel  <eric@webkit.org>
3213
3214         Add a land-from-url command
3215         https://bugs.webkit.org/show_bug.cgi?id=81411
3216
3217         Reviewed by Adam Barth.
3218
3219         Very basic so far.  The goal is to make it landing smarter
3220         so that users don't have to bother to parse out the ids out of the urls.
3221
3222         * Scripts/webkitpy/common/config/urls.py:
3223         (parse_bug_id):
3224         (parse_attachment_id):
3225         * Scripts/webkitpy/common/config/urls_unittest.py:
3226         (URLsTest.test_parse_bug_id):
3227         (URLsTest):
3228         (URLsTest.test_parse_attachment_id):
3229         * Scripts/webkitpy/tool/commands/download.py:
3230         (ProcessURLsMixin):
3231         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3232         (LandFromURL):
3233         * Scripts/webkitpy/tool/commands/download_unittest.py:
3234         (test_land_from_bug):
3235         (test_land_from_url):
3236
3237 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
3238
3239         build-webkit launcher instructions use wrong relative path for Qt
3240         https://bugs.webkit.org/show_bug.cgi?id=81357
3241
3242         Reviewed by Eric Seidel.
3243
3244         Ensure we are at the proper directory before generating run-launcher
3245         instructions.
3246
3247         * Scripts/build-webkit:
3248
3249 2012-03-16  Brady Eidson  <beidson@apple.com>
3250
3251         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
3252         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
3253
3254         Reviewed by Geoff Garen.
3255
3256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3257         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
3258
3259 2012-03-16  Ojan Vafai  <ojan@chromium.org>
3260
3261         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
3262         https://bugs.webkit.org/show_bug.cgi?id=81407
3263
3264         Reviewed by Adam Barth.
3265
3266         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3267         (summarize_results):
3268         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3269         (ResultSummaryTest.summarized_results):
3270         (ResultSummaryTest.test_no_svn_revision):
3271         (ResultSummaryTest.test_svn_revision):
3272         (ResultSummaryTest):
3273         (ResultSummaryTest.test_summarized_results_wontfix):
3274
3275 2012-03-16  Ojan Vafai  <ojan@chromium.org>
3276
3277         Have webkit-patch rebaseline-test update test_expectations.txt
3278         https://bugs.webkit.org/show_bug.cgi?id=81054
3279
3280         Recommit http://trac.webkit.org/changeset/110783 now that
3281         http://trac.webkit.org/changeset/111034 has landed.
3282
3283         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3284         (TestExpectations.remove_configuration_from_test):
3285         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3286         (RemoveConfigurationsTest):
3287         (RemoveConfigurationsTest.test_remove):
3288         (test_remove_line):
3289         * Scripts/webkitpy/tool/commands/rebaseline.py:
3290         (RebaselineTest._update_expectations_file):
3291         (RebaselineTest._rebaseline_test_and_update_expectations):
3292         (RebaselineTest):
3293         (RebaselineTest.execute):
3294         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3295         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
3296         (test_rebaseline_updates_expectations_file):
3297
3298 2012-03-15  Ojan Vafai  <ojan@chromium.org>
3299
3300         Specifier collapsing when writing test expectations lines gets a number of cases wrong
3301         https://bugs.webkit.org/show_bug.cgi?id=81309
3302
3303         Reviewed by Dimitri Glazkov.
3304
3305         I've run this over all the lines in the current Chromium test_expectations.txt file,
3306         so I'm relatively confident we now cover all the cases.
3307
3308         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3309         (TestConfigurationConverter.__init__):
3310         (TestConfigurationConverter.collapse_macros):
3311         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
3312         (TestConfigurationConverter):
3313         (TestConfigurationConverter.intersect_combination):
3314         (TestConfigurationConverter.symmetric_difference):
3315         (TestConfigurationConverter.to_specifiers_list):
3316         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3317         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3318         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3319         (make_mock_all_test_configurations_set):
3320         (TestConfigurationConverterTest.test_symmetric_difference):
3321         (TestConfigurationConverterTest.test_to_config_set):
3322         (TestConfigurationConverterTest.test_macro_expansion):
3323         (TestConfigurationConverterTest.test_to_specifier_lists):
3324         (TestConfigurationConverterTest.test_converter_macro_collapsing):
3325         * Scripts/webkitpy/layout_tests/port/chromium.py:
3326         (ChromiumPort):
3327         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3328         (ChromiumAndroidPort.__init__):
3329         The android port uses "arm" as it's architecture, which is technically correct,
3330         but considerably complicates making collapsing work. We probably should kill
3331         the concept of architecture entirely. The benefits are not worth the code
3332         complexity.
3333
3334         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3335         (ChromiumPortTest.test_all_test_configurations):
3336         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3337         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
3338         (test_rebaseline_updates_expectations_file):
3339
3340 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
3341
3342         [Qt][Wk2] Assertion Failure and crash on file upload
3343         https://bugs.webkit.org/show_bug.cgi?id=80854
3344
3345         Reviewed by Simon Hausmann.
3346
3347         Added filePicker to WebView using experimental API.
3348
3349         * MiniBrowser/qt/MiniBrowser.qrc:
3350         * MiniBrowser/qt/icons/folder.png: Added.
3351         * MiniBrowser/qt/icons/titlebar.png: Added.
3352         * MiniBrowser/qt/icons/up.png: Added.
3353         * MiniBrowser/qt/qml/BrowserWindow.qml:
3354         * MiniBrowser/qt/qml/FilePicker.qml: Added.
3355
3356 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3357
3358         Updating email for committer.py script.
3359
3360         * Scripts/webkitpy/common/config/committers.py:
3361
3362 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
3363
3364         [chromium] DRT: Add support for sending gesture scrolls without a begin
3365         https://bugs.webkit.org/show_bug.cgi?id=81292
3366
3367         Reviewed by Kent Tamura.
3368
3369         * DumpRenderTree/chromium/EventSender.cpp:
3370         (EventSender::EventSender):
3371         (EventSender::gestureScrollFirstPoint):
3372         * DumpRenderTree/chromium/EventSender.h:
3373         (EventSender):
3374
3375 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
3376
3377         [GTK] WebKitIconDatabase doesn't keep icons cached
3378         https://bugs.webkit.org/show_bug.cgi?id=56200
3379
3380         Reviewed by Martin Robinson.
3381
3382         Add support for favicons in GtkLauncher.
3383
3384         * GtkLauncher/main.c:
3385         (activateUriEntryCb):
3386         (iconLoadedCb):
3387         (createBrowser):
3388
3389 2012-03-16  Adam Barth  <abarth@webkit.org>
3390
3391         Remove sheriff-bot's last-green-revision command
3392         https://bugs.webkit.org/show_bug.cgi?id=81314
3393
3394         Reviewed by Eric Seidel.
3395
3396         This command is a cruel joke.  WebKit doesn't really ever have a
3397         last-green-revision.
3398
3399         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3400         (BuildBot._find_green_revision):
3401         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3402         (MockBuildBot.builder_statuses):
3403         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3404         (test_find_green_revision):
3405         * Scripts/webkitpy/tool/bot/irc_command.py:
3406         (IRCCommand.execute):
3407         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3408         (SheriffIRCBotTest.test_help):
3409         * Scripts/webkitpy/tool/commands/queries.py:
3410         (PatchesToReview.execute):
3411
3412 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3413
3414         [Qt] Make gccdepends test aware of broken icecream deps generation
3415
3416         Icecream seems to build the files without passing -o to gcc with
3417         the original destination path, which means the target name in the
3418         dependency file is wrong.
3419
3420         Also, echo something to the final file instead of just touching it,
3421         so it's not deleted on every build.
3422
3423         Reviewed by Simon Hausmann.
3424
3425         * qmake/config.tests/gccdepends/gccdepends.pro:
3426
3427 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
3428
3429         Support for Battery Status API
3430         https://bugs.webkit.org/show_bug.cgi?id=62698
3431
3432         Add include directory and file.
3433         http://www.w3.org/TR/battery-status/
3434
3435         Reviewed by Adam Barth.
3436
3437         * Scripts/build-webkit:
3438
3439 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
3440
3441         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
3442         https://bugs.webkit.org/show_bug.cgi?id=81007
3443
3444         Reviewed by Adam Barth.
3445
3446         A dedidcated build slave is available for efl on build.webkit.org. 
3447         This change add's an entry for the elf port in list of available port builders.
3448         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
3449
3450         * Scripts/webkitpy/layout_tests/port/builders.py:
3451
3452 2012-03-16  Adam Barth  <abarth@webkit.org>
3453
3454         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
3455         https://bugs.webkit.org/show_bug.cgi?id=81302
3456
3457         Reviewed by Eric Seidel.
3458
3459         This is a trivial patch, but the variable name turned up in a grep of
3460         webkitpy and looks like copy pasta.
3461
3462         * Scripts/webkitpy/common/net/statusserver.py:
3463         (StatusServer.next_work_item):
3464
3465 2012-03-16  Andrew Lo  <anlo@rim.com>
3466
3467         [BlackBerry] Enable PAGE_VISIBILITY_API
3468         https://bugs.webkit.org/show_bug.cgi?id=81257
3469
3470         Enable Page Visibility API for BlackBerry.
3471
3472         Reviewed by Rob Buis.
3473
3474         * Scripts/build-webkit:
3475
3476 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
3477
3478         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
3479         https://bugs.webkit.org/show_bug.cgi?id=81232
3480
3481         Reviewed by Philippe Normand.
3482
3483         Use the newly-added helper method in DumpRenderTreeSupportGtk.
3484
3485         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3486         (LayoutTestController::computedStyleIncludingVisitedInfo):
3487
3488 2012-03-15  Eric Seidel  <eric@webkit.org>
3489
3490         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
3491         https://bugs.webkit.org/show_bug.cgi?id=81313
3492
3493         Reviewed by Adam Barth.
3494
3495         * Scripts/webkitpy/common/checkout/changelog.py:
3496         (parse_bug_id_from_changelog):
3497         * Scripts/webkitpy/common/config/urls.py:
3498         (parse_bug_id):
3499         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
3500         (URLsTest):
3501         (URLsTest.test_parse_bug_id):
3502         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3503         (test_parse_bug_id):
3504         * Scripts/webkitpy/tool/bot/irc_command.py:
3505         (_post_error_and_check_for_bug_url):
3506         * Scripts/webkitpy/tool/bot/sheriff.py:
3507         (Sheriff.post_rollout_patch):
3508         (Sheriff.post_chromium_deps_roll):
3509
3510 2012-03-15  Adam Barth  <abarth@webkit.org>
3511
3512         The commit-queue should fast-track patches that have already passed the testing EWS bots
3513         https://bugs.webkit.org/show_bug.cgi?id=81305
3514
3515         Reviewed by Eric Seidel.
3516
3517         If a patch has already passed the testing EWS bots (currently only the
3518         chromium-ews bot), we should be able to land the patch without running
3519         the tests again.  This patch is somewhat risky in that the tests might
3520         have been broken between when the EWS bots ran and when the
3521         commit-queue is processing the patch.  If that turns out to be a
3522         problem in practice, we'll tighten up this fast-track in some way,
3523         likely by making sure that the pass status is recent.
3524
3525         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3526         (CommitQueueTaskDelegate.did_pass_testing_ews):
3527         (CommitQueueTask._did_pass_tests_recently):
3528         (CommitQueueTask.run):
3529         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3530         (MockCommitQueue.did_pass_testing_ews):
3531         (test_fast_success_case):
3532         * Scripts/webkitpy/tool/commands/queues.py:
3533         (CommitQueue.did_pass_testing_ews):
3534         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3535         (test_did_pass_testing_ews):
3536
3537 2012-03-15  Kentaro Hara  <haraken@chromium.org>
3538
3539         [PerformanceTests] run-perf-tests should output correct units
3540         https://bugs.webkit.org/show_bug.cgi?id=78303
3541
3542         Reviewed by Ryosuke Niwa.
3543
3544         Previously run-perf-tests just supported "ms" for units.
3545         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
3546         This patch fixes run-perf-tests so that they can support custom units.
3547         The default unit is "ms".
3548
3549         The test result looks like this:
3550
3551         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
3552         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
3553         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
3554
3555         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3556         (PerfTestsRunner._process_parser_test_result):
3557
3558 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
3559
3560         [WinCairo] Unreviewed build change after wtf path changes.
3561
3562         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
3563         directories to look at the private header directory to find 'wtf'.
3564
3565 2012-03-15  Kent Tamura  <tkent@chromium.org>
3566
3567         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
3568         https://bugs.webkit.org/show_bug.cgi?id=81293
3569
3570         Reviewed by Adam Barth.
3571
3572         r110595 introduced new format of the author field of ChangeLog entry:
3573         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
3574         Updte chanelog.py to support it.
3575
3576         * Scripts/webkitpy/common/checkout/changelog.py:
3577         (ChangeLogEntry._split_contributor_names):
3578         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3579         (test_parse_authors):
3580
3581 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
3582
3583         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
3584
3585         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
3586
3587         Reviewed by Jessie Berlin.
3588
3589         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3590         (LayoutTestController::setValueForUser):
3591         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3592         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3593         (WTR::LayoutTestController::setValueForUser):
3594         (WTR):
3595         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3596         (LayoutTestController):
3597
3598 2012-03-15  Adam Barth  <abarth@webkit.org>
3599
3600         Update the start-queue.sh script to match what we're using on the bots
3601         https://bugs.webkit.org/show_bug.cgi?id=81277
3602
3603         Reviewed by Eric Seidel.
3604
3605         Over time we've added more magic git commands to clean up the local repo after
3606         it has been borked in various ways. The idea behind this sequence is to clear
3607         out any changes in the working copy and then to rebuild the master branch from
3608         origin/master.
3609
3610         This patch also removes the watchdog timer that we've stopped using on the
3611         bots.
3612
3613         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
3614         Note: Eric and I are experimenting with GitHub to see if it might be
3615         useful for WebKit.  If you have thoughts on this topic, please feel
3616         free to grab Eric or me on #webkit to chat.  I assume that he and I are
3617         the only ones who care about this file so using this alternative
3618         process for this patch shouldn't cause any trouble.
3619
3620         * EWSTools/start-queue.sh:
3621
3622 2012-03-15  Adam Barth  <abarth@webkit.org>
3623
3624         The commit-queue can hang when the test_expectations.txt style check fails during commit
3625         https://bugs.webkit.org/show_bug.cgi?id=81251
3626
3627         Reviewed by Eric Seidel.
3628
3629         We forgot to check the --non-interactive flag, so we end up prompting
3630         the "user" who doesn't exist on the bot.  We might consider teaching
3631         the User class about non-interactive if we have this sort of bug again.
3632
3633         * Scripts/webkitpy/tool/steps/commit.py:
3634         (Commit.options):
3635         (Commit._check_test_expectations):
3636         (Commit.run):
3637         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3638         (CommitTest.test_check_test_expectations):
3639
3640 2012-03-15  Jessie Berlin  <jberlin@apple.com>
3641
3642         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
3643         Mac WK2 because WebAudio is not enabled
3644         https://bugs.webkit.org/show_bug.cgi?id=81259
3645
3646         Reviewed by Dan Bernstein.
3647
3648         Enable WebAudio so that it appears in the window object in the tests.
3649         The webaudio tests are all still skipped in the Mac Skipped list.
3650
3651         * WebKitTestRunner/TestController.cpp:
3652         (WTR::TestController::resetStateToConsistentValues):
3653
3654 2012-03-15  David Levin  <levin@chromium.org>
3655
3656         Various autoresize fixes.
3657         https://bugs.webkit.org/show_bug.cgi?id=81199
3658
3659         Reviewed by Darin Fisher.
3660
3661         * DumpRenderTree/chromium/LayoutTestController.cpp:
3662         (LayoutTestController::reset): Stop using the deprecated api that was removed.
3663
3664 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3665
3666         [GTK] Actually use --release and --debug command line options in run-gtk-test
3667         https://bugs.webkit.org/show_bug.cgi?id=81234
3668
3669         Reviewed by Philippe Normand.
3670
3671         Actually handle --release and --debug command line options to
3672         create the build directory, falling back to current hack to detect
3673         whether it's a Release or Debug build when both options are missed.
3674
3675         * Scripts/run-gtk-tests:
3676         (TestRunner.__init__): Receive options too.
3677         (TestRunner._get_top_level_directory): Helper function to get the
3678         top level directory.
3679         (TestRunner._get_build_directory): Helper function to get the
3680         build directory depending on --release/--debug command line
3681         options or gessing it if both options are missing.
3682         (TestRunner._ensure_accessibility_daemon_is_running): Use
3683         self-options now.
3684         (TestRunner.run): Ditto.
3685         (TestRunner.run.run_tests): Pass options to the constructor
3686         instead of run().
3687
3688 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3689
3690         [GTK] Run unit tests with --verbose in the bots
3691         https://bugs.webkit.org/show_bug.cgi?id=81230
3692
3693         Reviewed by Martin Robinson.
3694
3695         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3696         (RunGtkAPITests): Add --verbose to run-gtk-test command.
3697
3698 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3699
3700         Move wx port to using export macros
3701         https://bugs.webkit.org/show_bug.cgi?id=77279
3702
3703         Reviewed by Hajime Morita.
3704
3705         * waf/build/settings.py:
3706         (common_configure):
3707
3708 2012-03-15  Philippe Normand  <pnormand@igalia.com>
3709
3710         Unreviewed, GTK build fix attempt after r110845.
3711
3712         * Scripts/run-gtk-tests: Added --release and --debug options.
3713
3714 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3715
3716         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
3717         https://bugs.webkit.org/show_bug.cgi?id=79673
3718
3719         Preparatory work for bringing jhbuild enabled build to EFL port.
3720
3721         Reviewed by Philippe Normand.
3722
3723         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
3724         * Scripts/update-webkitgtk-libs:
3725         * gtk/run-with-jhbuild:
3726         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
3727         (top_level_path):
3728         (jhbuild_installed):
3729         (jhbuild_cloned):
3730         (jhbuild_at_expected_revision):
3731         (update_jhbuild):
3732         (clone_jhbuild):
3733         (install_jhbuild):
3734         (update_webkit_libs_jhbuild):
3735         (determine_platform):
3736         (ensure_jhbuild):
3737
3738 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3739
3740         [GTK] Add command line options to run-gtk-tests script
3741         https://bugs.webkit.org/show_bug.cgi?id=81218
3742
3743         Reviewed by Philippe Normand.
3744
3745         Following command line options have been added:
3746
3747         -v, --verbose: to run gtester with --verbose. That would be used
3748         by the bots to make it easier to know which test case it failing.
3749
3750         --display: to use a different display for Xvfb
3751
3752         It's also possible to pass one or more tests as arguments.
3753
3754         * Scripts/run-gtk-tests:
3755         (TestRunner.__init__): Receive command line arguments.
3756         (TestRunner._get_tests): Get all the tests or the ones passed by
3757         command line arguments.
3758         (TestRunner._ensure_accessibility_daemon_is_running): Use display
3759         command line argument.
3760         (TestRunner.run): Pas command line options.
3761         (TestRunner.run.run_tests): Pass command line arguments.
3762
3763 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3764
3765         [GTK] WebKit2APITests/TestPrinting timeout in the bots
3766         https://bugs.webkit.org/show_bug.cgi?id=81211
3767
3768         Reviewed by Philippe Normand.
3769
3770         Add gtk+ patch to fix timeout in the bots. A similar patch has
3771         already landed in updatream gtk+, see
3772         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
3773
3774         * gtk/jhbuild.modules:
3775         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
3776
3777 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
3778
3779         sheriffbot should also be addressable with a comma in addition to colon
3780         https://bugs.webkit.org/show_bug.cgi?id=81101
3781
3782         Reviewed by Adam Barth.
3783
3784         * Scripts/webkitpy/common/net/irc/ircbot.py:
3785         (IRCBot.on_pubmsg):
3786
3787 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
3788
3789         [Qt] MiniBrowser scroll indicators should not scroll out of view
3790         https://bugs.webkit.org/show_bug.cgi?id=81131
3791
3792         Reviewed by Kenneth Rohde Christiansen.
3793
3794         * MiniBrowser/qt/qml/ScrollIndicator.qml:
3795
3796 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
3797
3798         AX: ARIA tables need to support selected rows attribute/select rows changed notification
3799         https://bugs.webkit.org/show_bug.cgi?id=79821
3800
3801         Reviewed by Beth Dakin.
3802
3803         * DumpRenderTree/AccessibilityUIElement.cpp:
3804         (rowAtIndexCallback):
3805         (AccessibilityUIElement::getJSClass):
3806         * DumpRenderTree/AccessibilityUIElement.h:
3807         (AccessibilityUIElement):
3808         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3809         (AccessibilityUIElement::rowAtIndex):
3810         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3811         (AccessibilityUIElement::rowAtIndex):
3812         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3813         (AccessibilityUIElement::rowAtIndex):
3814         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3815         (AccessibilityUIElement::rowAtIndex):
3816
3817 2012-03-14  Tim Horton  <timothy_horton@apple.com>
3818
3819         NRWT should respect --additional-platform-directory's Skipped list
3820         https://bugs.webkit.org/show_bug.cgi?id=81172
3821
3822         Reviewed by Timothy Hatcher.
3823
3824         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
3825         from said path are already used, but the Skipped file is ignored.
3826
3827         * Scripts/webkitpy/layout_tests/port/webkit.py:
3828         (WebKitPort._skipped_file_search_paths):
3829         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3830         (test_skipped_file_search_paths):
3831
3832 2012-03-14  Ojan Vafai  <ojan@chromium.org>
3833
3834         Unreviewed, rolling out r110783.
3835         http://trac.webkit.org/changeset/110783
3836         https://bugs.webkit.org/show_bug.cgi?id=81054
3837
3838         Caused existing test expectation lines to expand to one for
3839         each test configuration.
3840
3841         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3842         (TestExpectations.has_warnings):
3843         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3844         (test_macro_overrides):
3845         * Scripts/webkitpy/tool/commands/rebaseline.py:
3846         (RebaselineTest._save_baseline):
3847         (RebaselineTest._rebaseline_test):
3848         (RebaselineTest.execute):
3849         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3850         (TestRebaseline.test_tests_to_update):
3851
3852 2012-03-13  Jon Lee  <jonlee@apple.com>
3853
3854         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
3855         https://bugs.webkit.org/show_bug.cgi?id=80922
3856         <rdar://problem/11035082>
3857
3858         Reviewed by Jian Li.
3859
3860         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
3861         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
3862         new API. Therefore, APIs that are common between the two will have:
3863         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
3864
3865         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
3866         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
3867
3868         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
3869         * DumpRenderTree/chromium/LayoutTestController.cpp:
3870         (LayoutTestController::grantDesktopNotificationPermission):
3871         (LayoutTestController::simulateDesktopNotificationClick):
3872         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3873         * DumpRenderTree/chromium/TestShell.cpp:
3874         (TestShell::TestShell):
3875         (TestShell::resetTestController):
3876         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3877         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3878
3879 2012-03-13  Ojan Vafai  <ojan@chromium.org>
3880
3881         Have webkit-patch rebaseline-test update test_expectations.txt
3882         https://bugs.webkit.org/show_bug.cgi?id=81054
3883
3884         Reviewed by Dirk Pranke.
3885
3886         This will allow us to use the All Failures tab in garden-o-matic
3887         to rebaseline tests without making test_expectations.txt stale.
3888
3889         It's conservative and only removes lines if the test is
3890         not flaky and fails in a way the rebaseline would fix (e.g.
3891         CRASH/TIMEOUT will not be touched).
3892
3893         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3894         (TestExpectations.remove_configuration_from_test):
3895         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3896         (RemoveConfigurationsTest):
3897         (RemoveConfigurationsTest.test_remove):
3898         (test_remove_line):
3899         * Scripts/webkitpy/tool/commands/rebaseline.py:
3900         (RebaselineTest._is_supported_port):
3901         (RebaselineTest):
3902         (RebaselineTest._update_expectations_file):
3903         (RebaselineTest._rebaseline_test_and_update_expectations):
3904         (RebaselineTest.execute):
3905         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3906         (TestRebaseline.test_rebaseline_updates_expectations_file):
3907
3908 2012-03-14  Jessie Berlin  <jberlin@apple.com>
3909
3910         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
3911         https://bugs.webkit.org/show_bug.cgi?id=81167
3912
3913         Reviewed by Sam Weinig.
3914
3915         Do not use 0 as a key in a HashMap.
3916
3917         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3918         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
3919
3920 2012-03-14  Ojan Vafai  <ojan@chromium.org>
3921
3922         Add the chromium lion bot to garden-o-matic and remove
3923         the platform_move_to in builders.py since the Chromium Lion
3924         port is now a normal port.
3925
3926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3927         * Scripts/webkitpy/layout_tests/port/builders.py:
3928
3929 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
3930
3931         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
3932
3933         Unreviewed, build fix.
3934
3935         * Scripts/webkitpy/layout_tests/port/base.py:
3936         (Port.skipped_tests):
3937
3938 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
3939
3940         Please add a way to manually skip some tests in NRWT
3941         https://bugs.webkit.org/show_bug.cgi?id=81019
3942
3943         Reviewed by Ojan Vafai.
3944
3945         This patch implements the -i / --ignore-tests flag from ORWT
3946         and refactors the test_expectations.py code slightly to handle
3947         it.
3948
3949         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3950         (Manager.parse_expectations):
3951         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3952         (TestExpectations.__init__):
3953         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3954         (test_add_skipped_tests):
3955         (test_add_skipped_tests_duplicate):
3956         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3957         (parse_args):
3958         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3959         (MainTest.test_ignore_tests):
3960         (MainTest.test_ignore_tests.assert_ignored):
3961
3962 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
3963
3964         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
3965         https://bugs.webkit.org/show_bug.cgi?id=81028
3966
3967         Reviewed by Ojan Vafai.
3968
3969         The mac port had incorrect lookups for 'mac-lion' and
3970         'mac-future' in some places. This patch fixes that and adds a
3971         bunch of tests.
3972
3973         * Scripts/webkitpy/layout_tests/port/mac.py:
3974         (MacPort.baseline_path):
3975         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3976         (MacTest.assert_skipped_file_search_paths):
3977         (MacTest.test_skipped_file_search_paths):
3978         (_assert_search_path):
3979         (test_baseline_search_path):
3980         * Scripts/webkitpy/layout_tests/port/webkit.py:
3981         (WebKitPort._skipped_file_search_paths):
3982
3983 2012-03-13  Jer Noble  <jer.noble@apple.com>
3984
3985         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
3986         https://bugs.webkit.org/show_bug.cgi?id=81056
3987
3988         Reviewed by Jessie Berlin.
3989
3990         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
3991
3992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3993         (WTR::InjectedBundlePage::InjectedBundlePage):
3994         (WTR::InjectedBundlePage::beganEnterFullScreen):
3995         (WTR::InjectedBundlePage::beganExitFullScreen):
3996
3997 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
3998
3999         The width and height of the scroll indicators in the MiniBrowser does
4000         not consider the offset margins.
4001         https://bugs.webkit.org/show_bug.cgi?id=81112
4002
4003         Reviewed by Kenneth Rohde Christiansen.
4004
4005         This patch fixes the issue by withdrawing two times the anchor
4006         margins.
4007
4008         * MiniBrowser/qt/qml/ScrollIndicator.qml:
4009
4010 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4011
4012         [EFL] Implement LayoutTestController::clearBackForwardList
4013         https://bugs.webkit.org/show_bug.cgi?id=80142
4014
4015         Adding missing implementation clearBackForwardList to EFL's
4016         LayoutTestController. This implementation allows us to unskip 
4017         tests connected with history.
4018
4019         Reviewed by Antonio Gomes.
4020
4021         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4022         (LayoutTestController::clearBackForwardList): Implemented.
4023
4024 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4025
4026         [EFL][DRT] Expose window.internals object
4027         https://bugs.webkit.org/show_bug.cgi?id=79900
4028
4029         Exposes window.internals for EFL's DRT. Makes possible to
4030         remove some tests from the skip list.
4031
4032         Reviewed by Antonio Gomes.
4033
4034         * DumpRenderTree/efl/CMakeLists.txt:
4035         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4036         (DumpRenderTreeChrome::onWindowObjectCleared):
4037
4038 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
4039
4040         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
4041         https://bugs.webkit.org/show_bug.cgi?id=78853
4042
4043         Reviewed by Adam Barth.
4044
4045         * Scripts/build-webkit:
4046         * qmake/mkspecs/features/features.prf:
4047
4048 2012-03-12  Antonio Gomes  <agomes@rim.com>
4049
4050         Convert nodesFromRect tests to use Internals interface
4051         https://bugs.webkit.org/show_bug.cgi?id=80886
4052
4053         Reviewed by Ryosuke Niwa.
4054
4055         This clean up allows to remove port specific bits of each
4056         DRT implementation that supports testing Document::nodesFromRect,
4057         in favor of making use of the 'Internals' interface to test it.
4058
4059         This makes its code conveniently more expansible and cleaner.
4060
4061         Also removed stubs from Win and EFL DRTs.
4062
4063         * DumpRenderTree/LayoutTestController.cpp:
4064         (LayoutTestController::staticFunctions):
4065         * DumpRenderTree/LayoutTestController.h:
4066         (LayoutTestController):
4067         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4068         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4069         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4070         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4071         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4072         (LayoutTestController):
4073         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4074
4075 2012-03-13  Ojan Vafai  <ojan@chromium.org>
4076
4077         Rebaselining for a new port doesn't work right with multiple fallback ports
4078         https://bugs.webkit.org/show_bug.cgi?id=80932
4079
4080         Reviewed by Adam Barth.
4081
4082         Since chromium-leopard also falls back to mac-leopard, we need to
4083         copy the existing result for both chromium-leopard and chromium-snowleopard
4084         before doing lion rebaselines.
4085
4086         * Scripts/webkitpy/layout_tests/port/builders.py:
4087         (fallback_port_names_for_new_port):
4088         * Scripts/webkitpy/tool/commands/rebaseline.py:
4089         (RebaselineTest):
4090         (RebaselineTest._copy_existing_baseline):
4091         (RebaselineTest._rebaseline_test):
4092         (RebaselineTest.execute):
4093         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4094         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4095         (GardeningHTTPRequestHandler.rebaseline):
4096         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4097         (GardeningServerTest.test_rebaseline_new_port):
4098
4099 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4100
4101         [Qt] Tweak minibrowser UI
4102
4103         Add some margins to the scroll indicators, and set a dark background
4104         color so you see the page dimensions.
4105
4106         Reviewed by Antonio Gomes.
4107
4108         * MiniBrowser/qt/qml/BrowserWindow.qml:
4109         * MiniBrowser/qt/qml/ScrollIndicator.qml:
4110
4111 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
4112
4113         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
4114         https://bugs.webkit.org/show_bug.cgi?id=79601
4115
4116         Reviewed by Gustavo Noronha Silva.
4117
4118         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
4119         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
4120         and is taken over to sendKeyDown.
4121         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
4122         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
4123
4124         * DumpRenderTree/efl/EventSender.cpp:
4125         (KeyEventInfo::KeyEventInfo):
4126         (KeyEventInfo):
4127         (createKeyEventInfo):
4128         (sendKeyDown):
4129         (keyDownCallback):
4130         (sendAsynchronousKeyDown):
4131         (scheduleAsynchronousKeyDownCallback):
4132
4133 2012-03-12  Ojan Vafai  <ojan@chromium.org>
4134
4135         webkit-patch optimize-baselines sometimes creates a mac-future result
4136         https://bugs.webkit.org/show_bug.cgi?id=80717
4137
4138         Reviewed by Adam Barth.
4139
4140         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4141         (_baseline_search_hypergraph):
4142         (BaselineOptimizer._find_optimal_result_placement):
4143         (BaselineOptimizer._filter_virtual_ports):
4144         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4145         (BaselineOptimizerTest.test_no_add_mac_future):
4146
4147 2012-03-12  Jessie Berlin  <jberlin@apple.com>
4148
4149         More Windows build fixing.
4150
4151         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4152
4153 2012-03-12  Jessie Berlin  <jberlin@apple.com>
4154
4155         More Windows build fixing.
4156
4157         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4158         * DumpRenderTree/win/EditingDelegate.cpp:
4159         * DumpRenderTree/win/EventSender.cpp:
4160         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4161         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4162         * DumpRenderTree/win/UIDelegate.cpp:
4163
4164 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
4165
4166         remove the 'gpu' group from the flakiness dashboard
4167         https://bugs.webkit.org/show_bug.cgi?id=80353
4168
4169         Reviewed by Adam Barth.
4170
4171         Since those bots are obsolete, we don't need this any more.
4172
4173         * TestResultServer/static-dashboards/builders.js:
4174         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
4175         (testPlatformAndBuildType):
4176         (testHtmlForTestTypeSwitcherGroup):
4177
4178 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
4179
4180         remove graphics_type from webkitpy.layout_tests.models.test_configuration
4181         https://bugs.webkit.org/show_bug.cgi?id=80643
4182
4183         Reviewed by Ojan Vafai.
4184
4185         Now that the chromium-gpu ports are gone, there's no need for
4186         the graphics_type CPU/GPU distinction. Most of this change is
4187         just updating tests accordingly.
4188
4189         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
4190         (TestExpectationEditorTests):
4191         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4192         (TestConfiguration.__init__):
4193         (TestConfiguration.category_order):
4194         (TestConfiguration.__str__):
4195         (TestConfiguration.__repr__):
4196         (TestConfiguration.__hash__):
4197         (TestConfigurationConverter.to_specifiers_list):
4198         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
4199         (make_mock_all_test_configurations_set):
4200         (TestConfigurationTest.test_items):
4201         (TestConfigurationTest.test_keys):
4202         (TestConfigurationTest.test_str):
4203         (TestConfigurationTest.test_repr):
4204         (TestConfigurationTest.test_hash):
4205         (TestConfigurationTest.test_hash.query_unknown_key):
4206         (TestConfigurationTest.test_eq):
4207         (TestConfigurationTest.test_values):
4208         (SpecifierSorterTest.test_specifier_priority):
4209         (SpecifierSorterTest.test_sort_specifiers):
4210         (TestConfigurationConverterTest.test_to_config_set):
4211         (TestConfigurationConverterTest.test_macro_expansion):
4212         (TestConfigurationConverterTest.test_to_specifier_lists):
4213         (TestConfigurationConverterTest.test_converter_macro_collapsing):
4214         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4215         (test_error_on_different_build_type):
4216         (TestExpectationSerializerTests.test_parsed_to_string):
4217         (TestExpectationSerializerTests.test_reconstitute_only_these):
4218         * Scripts/webkitpy/layout_tests/port/apple.py:
4219         (ApplePort._generate_all_test_configurations):
4220         * Scripts/webkitpy/layout_tests/port/base.py:
4221         (Port.__init__):
4222         (Port.name):
4223         (Port.version):
4224         (Port.test_configuration):
4225         * Scripts/webkitpy/layout_tests/port/builders.py:
4226         * Scripts/webkitpy/layout_tests/port/chromium.py:
4227         (ChromiumPort):
4228         (ChromiumPort._generate_all_test_configurations):
4229         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4230         (ChromiumLinuxPort.__init__):
4231         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4232         (ChromiumLinuxPortTest.test_check_illegal_port_names):
4233         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4234         (ChromiumMacPortTest.test_baseline_path):
4235         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4236         (ChromiumPortTest.test_all_test_configurations):
4237         * Scripts/webkitpy/layout_tests/port/efl.py:
4238         (EflPort._generate_all_test_configurations):
4239         * Scripts/webkitpy/layout_tests/port/gtk.py:
4240         (GtkPort._generate_all_test_configurations):
4241         * Scripts/webkitpy/layout_tests/port/qt.py:
4242         (QtPort._generate_all_test_configurations):
4243         * Scripts/webkitpy/layout_tests/port/test.py:
4244         (TestPort.all_test_configurations):
4245         (TestPort._all_build_types):
4246         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4247         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4248         (BuildCoverageExtrapolatorTest.test_extrapolate):
4249         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
4250         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
4251         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
4252         (GardeningExpectationsUpdaterTest.test_pass_expectation):
4253         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
4254         (GardeningExpectationsUpdaterTest.test_spurious_updates):
4255
4256 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
4257
4258         _runtime_feature_list isn't supported on Apple Mac DRT
4259         https://bugs.webkit.org/show_bug.cgi?id=80906
4260
4261         Reviewed by Eric Seidel.
4262
4263         It looks like this feature is actually only supported on the Win
4264         DRT port, so this patch reworks the code to make that clearer
4265         and reduce unnecessary overrides.
4266
4267         * Scripts/webkitpy/layout_tests/port/efl.py:
4268         (EflPort._path_to_webcore_library):
4269         * Scripts/webkitpy/layout_tests/port/gtk.py:
4270         (GtkPort._path_to_webcore_library):
4271         * Scripts/webkitpy/layout_tests/port/qt.py:
4272         (QtPort._skipped_file_search_paths):
4273         * Scripts/webkitpy/layout_tests/port/webkit.py:
4274         (WebKitPort._runtime_feature_list):
4275         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4276         (TestWebKitPort.__init__):
4277         (TestWebKitPort.all_test_configurations):
4278         (test_skipped_directories_for_features):
4279         * Scripts/webkitpy/layout_tests/port/win.py:
4280         (WinPort):
4281         (WinPort._runtime_feature_list):
4282         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4283         (WinPortTest.test_operating_system):
4284         (WinPortTest):
4285         (WinPortTest.test_runtime_feature_list):
4286
4287 2012-03-12  Peter Beverloo  <peter@chromium.org>
4288
4289         [Chromium] Temporary build-fix for the Android bot
4290         https://bugs.webkit.org/show_bug.cgi?id=80862
4291
4292         Reviewed by Adam Barth.
4293
4294         Manually set the environmental variables required to compile source
4295         files through the Android NDK instead of relying on the envsetup.sh
4296         script. A proper fix will be landed to Chromium ASAP, and following
4297         a Chromium roll into WebKit this code will be removed.
4298
4299         * Scripts/webkitdirs.pm:
4300         (buildChromiumMakefile):
4301
4302 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4303
4304         [Qt] Use right construct to detect config_test_gccdepends
4305
4306         Reviewed by Andreas Kling.
4307
4308         * qmake/mkspecs/features/default_pre.prf:
4309
4310 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4311
4312         [Qt] Expose location of WebKit's bin and imports dir through module file
4313
4314         Reviewed by Andreas Kling.
4315
4316         * qmake/qt_webkit.pri:
4317
4318 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
4319
4320         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
4321         https://bugs.webkit.org/show_bug.cgi?id=80832
4322
4323         Reviewed by Tor Arne Vestbø.
4324
4325         Add a basic scroll indicator component to MiniBrowser so that it
4326         behaves similar to the ScrollDecorator QML component.
4327
4328         * MiniBrowser/qt/MiniBrowser.qrc:
4329         * MiniBrowser/qt/qml/BrowserWindow.qml:
4330         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
4331
4332 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
4333
4334         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
4335         https://bugs.webkit.org/show_bug.cgi?id=80809
4336
4337         Reviewed by Philippe Normand.
4338
4339         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
4340
4341 2012-03-12  Ming Xie  <mxie@rim.com>
4342
4343         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
4344         https://bugs.webkit.org/show_bug.cgi?id=80812
4345
4346         Reviewed by Rob Buis.
4347
4348         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
4349         * Scripts/webkitdirs.pm:
4350         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define