Add myself to the watchlist for platform/graphics/chromium
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-03  James Robinson  <jamesr@chromium.org>
2
3         Add myself to the watchlist for platform/graphics/chromium
4         https://bugs.webkit.org/show_bug.cgi?id=69297
5
6         Reviewed by David Levin.
7
8         * Scripts/webkitpy/common/config/watchlist:
9
10 2011-10-03  Anders Carlsson  <andersca@apple.com>
11
12         Remove custom scrollbar painting hooks
13         https://bugs.webkit.org/show_bug.cgi?id=69163
14
15         Reviewed by Alexey Proskuryakov.
16
17         * DumpRenderTree/chromium/WebPreferences.cpp:
18         (WebPreferences::applyTo):
19         No need to enable custom scrollbar painting.
20
21 2011-10-03  David Levin  <levin@chromium.org>
22
23         watchlist: Make watchlist run on a bot.
24         https://bugs.webkit.org/show_bug.cgi?id=68974
25
26         Reviewed by Adam Barth.
27
28         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
29         * Scripts/webkitpy/tool/commands/queues_unittest.py:
30         Change to log what is run so that we can see the style command
31         and the watchlist command being run.
32
33 2011-10-03  David Levin  <levin@chromium.org>
34
35         watchlist: Allow specified a bug to attach the watchlist info to.
36         https://bugs.webkit.org/show_bug.cgi?id=69288
37
38         Reviewed by Eric Seidel.
39
40         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
41         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
42         Add tests and fix an existing test because the unit tests do not go through the
43         normal command line processing (so the -g argument remained when we determined bug ids).
44         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
45         get the assert raises regex method.
46         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
47
48 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
49
50         [EFL] DRT: Add JSStringUtils.{cpp,h}
51         https://bugs.webkit.org/show_bug.cgi?id=66397
52
53         Reviewed by Ryosuke Niwa.
54         
55         Adds helper functions to compare the equality of C-style strings and
56         JSStringRef objects.
57
58         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
59         (equals):
60         * DumpRenderTree/efl/JSStringUtils.h: Added.
61
62 2011-10-03  Adam Barth  <abarth@webkit.org>
63
64         garden-o-matic should work in Safari 5.1
65         https://bugs.webkit.org/show_bug.cgi?id=69290
66
67         Reviewed by Sam Weinig.
68
69         My old implementation of bind was too clever by half.  This one seems
70         to work better, at least according to this test.
71
72         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
73         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
74
75 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
76
77         Unreviewed: change my e-mail in commiters.py
78
79         (I'm leaving the company and my @openbossa.org will be no more)
80
81         * Scripts/webkitpy/common/config/committers.py:
82
83 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
84
85         [GTK] Fix memory leak when loading url
86         https://bugs.webkit.org/show_bug.cgi?id=69247
87
88         Reviewed by Martin Robinson.
89
90         Release URL created with WKURLCreateWithUTF8CString().
91
92         * MiniBrowser/gtk/BrowserWindow.c:
93         (activateUriEntryCallback):
94         * MiniBrowser/gtk/main.c:
95         (loadURI):
96
97 2011-10-03  Csaba Osztrogonác  <ossy@webkit.org>
98
99         Unreviewed. Add Zoltán Árvai as contributor.
100
101         * Scripts/webkitpy/common/config/committers.py:
102
103 2011-10-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
104
105         [EFL] DRT: Add DumpHistoryItem.{cpp,h}
106         https://bugs.webkit.org/show_bug.cgi?id=63992
107
108         Reviewed by Antonio Gomes.
109
110         This is the code responsible for dumping the back and forward history
111         list.
112
113         * DumpRenderTree/efl/DumpHistoryItem.cpp: Added.
114         (dumpHistoryItem):
115         (dumpBackForwardListForWebView):
116         (dumpBackForwardListForWebViews):
117         * DumpRenderTree/efl/DumpHistoryItem.h: Added.
118
119 2011-10-03  Zeno Albisser  <zeno.albisser@nokia.com>
120
121         [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
122         https://bugs.webkit.org/show_bug.cgi?id=69223
123
124         WebKitTestRunner must include Qt / qnamespace header
125         to get a definition of Qt::MouseButtons.
126
127         Reviewed by Andreas Kling.
128
129         * WebKitTestRunner/EventSenderProxy.h:
130
131 2011-10-03  Csaba Osztrogonác  <ossy@webkit.org>
132
133         Unreviewed. Add Zoltán Árvai as contributor.
134
135         * Scripts/webkitpy/common/config/committers.py:
136
137 2011-10-02  Adam Barth  <abarth@webkit.org>
138
139         Clean up obsolete code in gardeningserver.py related to
140         STATIC_FILE_NAMES.  Rather than serve the UI via the Python HTTP
141         server, we just serve it off the filesystem directly.
142
143         We had planned to serve the UI off build.webkit.org, but that server is
144         somewhat slow.  We'll probably serve the UI of some web server, but
145         we'll need to work that out later.
146
147         * Scripts/webkitpy/tool/commands/gardenomatic.py:
148         * Scripts/webkitpy/tool/servers/gardeningserver.py:
149
150 2011-10-02  Adam Barth  <abarth@webkit.org>
151
152         Rip out half-backed garden-o-matic features in preparation for wider use
153         https://bugs.webkit.org/show_bug.cgi?id=69226
154
155         This patch rips out a bunch of half-baked features and cleans up a
156         bunch of small nits with the core set of features.  We're going to ask
157         more folks to start using the tool, and having a bunch of half-baked
158         features around is distracting.  We can add these features back under a
159         flag and interate on them after we've got the core functionality
160         nailed.
161
162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
171
172 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
173
174         Correct post-build step for WinCairo test runs.
175         https://bugs.webkit.org/show_bug.cgi?id=69191 
176
177         Reviewed by Brian Weinstein.
178
179         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
180         shell case to handle the CFLite build.
181
182 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
183
184         Added myself to reviewers, because I'm now a reviewer.
185
186         * Scripts/webkitpy/common/config/committers.py:
187
188 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
189
190         Bencher script makes it difficult to do automated performance testing
191         https://bugs.webkit.org/show_bug.cgi?id=69207
192
193         Reviewed by Sam Weinig.
194         
195         This adds two new features:
196         
197         The ability to disable automatic VM detection, which is flaky if any
198         profiling features are enabled in jsc.
199         
200         The ability to compute, and report, a scaled result for all benchmark
201         suites. It is the geometric mean of three numbers: SunSpider's
202         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
203         It is also possible to turn off all other output from bencher and just
204         get this number with the --brief option.
205
206         * Scripts/bencher:
207
208 2011-10-01  Sam Weinig  <sam@webkit.org>
209
210         WTR is not successfully changing the NSUserDefaults
211         https://bugs.webkit.org/show_bug.cgi?id=69204
212
213         Reviewed by Dan Bernstein.
214
215         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
216         (WTR::InjectedBundle::platformInitialize):
217         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
218         get our overrides picked up.
219
220 2011-09-30  Daniel Bates  <dbates@rim.com>
221
222         Cleanup: Extract code to launch a Mac WebKit application into a common function
223         https://bugs.webkit.org/show_bug.cgi?id=68662
224
225         Reviewed by Adam Roben.
226
227         Extracts common code to launch a WebKit application on Mac OS X into a function
228         so that we can remove duplicate code.
229
230         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
231         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
232         (runMacWebKitApp): Added.
233         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
234         (runMiniBrowser): Ditto.
235         (runWebKitTestRunner): Ditto.
236         (runTestWebKitAPI): Ditto.
237
238 2011-09-29  David Levin  <levin@chromium.org>
239
240         watchlist: Add webkit-patch command to run watchlist.
241         https://bugs.webkit.org/show_bug.cgi?id=68973
242
243         Reviewed by Eric Seidel.
244
245         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
246         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
247         the cc and messages as sorted lists. To allow for deterministic ordering.
248         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
249         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
250         that it will be exposed as a command by webkit-patch.
251         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
252         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
253         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
254         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
255         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
256         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
257         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
258         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
259
260 2011-09-30  David Levin  <levin@chromium.org>
261
262         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
263         https://bugs.webkit.org/show_bug.cgi?id=69031
264
265         Reviewed by Adam Barth.
266
267         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
268         a comment to explain something important about the email addresses, and
269         a comment to let emacs know to treat the file as a python file.
270         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
271         Detects increases or decreases in a pattern.
272         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
273         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
274         Added unit tests for watchlist which has "more" or "less".
275         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
276         Added support for "more" or "less".
277
278 2011-09-30  Sam Weinig  <sam@webkit.org>
279
280         Add support for eventSender.mouseScrollBy in WTR
281         https://bugs.webkit.org/show_bug.cgi?id=69189
282
283         Add implementation of eventSender.mouseScrollBy for the mac.
284
285         Reviewed by Simon Fraser.
286
287         * WebKitTestRunner/EventSenderProxy.h:
288         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
289         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
290         (WTR::EventSendingController::keyDown):
291         (WTR::EventSendingController::mouseScrollBy):
292         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
293         * WebKitTestRunner/TestController.cpp:
294         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
295         * WebKitTestRunner/mac/EventSenderProxy.mm:
296         (WTR::EventSenderProxy::mouseScrollBy):
297
298 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
299
300         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
301         https://bugs.webkit.org/show_bug.cgi?id=35273
302
303         Reviewed by Dan Bernstein.
304         
305         There are two types of font issue that can cause layout test failure.
306         First, the user may have non-standard fonts installed that affect the layout
307         of some tests. For example, some tests use the MS Gothic font if installed.
308         
309         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
310         which override the system fonts (e.g. a copy of Arial from MS Office). For
311         some tests, this can affect font metrics or fallback behavior.
312         
313         This change addresses the first problem only. It limits the set of fonts
314         available through NSFontManager, by swizzling some methods to return
315         a list of fonts or font families which only include fonts from a hardcoded
316         whitelist.
317         
318         * DumpRenderTree/mac/DumpRenderTree.mm:
319         (allowedFontFamilySet):
320         (drt_NSFontManager_availableFontFamilies):
321         (drt_NSFontManager_availableFonts):
322         (swizzleNSFontManagerMethods):
323         (activateTestingFonts):
324         (adjustFonts):
325         (createWebViewAndOffscreenWindow):
326         (prepareConsistentTestingEnvironment):
327         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
328         (WTR::allowedFontFamilySet):
329         (WTR::drt_NSFontManager_availableFontFamilies):
330         (WTR::drt_NSFontManager_availableFonts):
331         (WTR::swizzleNSFontManagerMethods):
332         (WTR::InjectedBundle::platformInitialize):
333
334 2011-09-30  David Levin  <levin@chromium.org>
335
336         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
337         https://bugs.webkit.org/show_bug.cgi?id=69039
338
339         Reviewed by Adam Barth.
340
341         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
342         Actually skip only one specific test that is failing on Windows.
343
344 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
345
346         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
347
348         For DRT we didn't install the message handler early enough to
349         catch output while constructing the QApplication. For WTR we
350         didn't even install a message handler.
351
352         Since the UI process will forward any output from the web process
353         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
354         in WTR before the web process is started. This is picked up by the
355         web process which installs its own message handler.
356
357         The environment variable can be overriden on the command line if you
358         want to see output from the web process, or you can pass --verbose to
359         WTR to see output from both processes.
360
361         https://bugs.webkit.org/show_bug.cgi?id=69132
362
363         Reviewed by Andreas Kling.
364
365         * DumpRenderTree/qt/main.cpp:
366         * WebKitTestRunner/qt/main.cpp:
367
368 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
369
370         [Qt] Make sure WTR sizes the window and item correctly
371
372         Revision 96345 changed the logic for how the view and
373         window was created, but missed a vital part, setting
374         the size.
375
376         We now use a QSGView for the window, that has a simple
377         item as its root object that is always resized to fit
378         within the window. The webview is then parented to the
379         root object and set to anchors.fill: parent. That way
380         any window geometry changes will propagate to the web
381         view.
382
383         https://bugs.webkit.org/show_bug.cgi?id=69134
384
385         Reviewed by Andreas Kling.
386
387         * WebKitTestRunner/PlatformWebView.h:
388         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
389
390 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
391
392         [EFL] Only save the current viewport in PixelDumpSupportEfl.
393         https://bugs.webkit.org/show_bug.cgi?id=68450
394
395         Reviewed by Antonio Gomes.
396
397         The previous implementation saved the whole page contents in the final
398         PNG, however the baselines and expectations in the tree only want the
399         current viewport (with a scrollbar, if needed), so we now only save the
400         currently visible contents.
401
402         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
403         (createBitmapContextFromWebView): Use
404         ewk_frame_visible_content_geometry_get instead of
405         ewk_frame_contents_size_get.
406
407 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
408
409         [EFL] Support and keep track of extra windows (views).
410         https://bugs.webkit.org/show_bug.cgi?id=68454
411
412         Reviewed by Antonio Gomes.
413
414         So far, window.open and related JavaScript code would not work, as
415         DRTView did not implementation
416         Ewk_View_Smart_Class::window_{open,close}. The default implementation
417         in ewk just returns the current window/view, which broke any
418         layouttest which relied on window.open.
419
420         We now properly create and remove these new views. Unfortunately, the
421         current way ewk works (and due to the fact that we cannot pass class
422         methods as function pointers to the EFL functions), DRTView needs to
423         know that DRTChrome exists and call `browser' directly in some points.
424
425         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
426         (onWindowCreate):
427         (onWindowCloseDelayed):
428         (onWindowClose):
429         (drtViewTiledAdd):
430
431 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
432
433         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
434         https://bugs.webkit.org/show_bug.cgi?id=42698
435
436         Reviewed by Andreas Kling.
437
438         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
439         and call clearApplicationCache when layoutTest start up.
440
441         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
442         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
443         (WTR::InjectedBundle::beginTesting):
444         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
445         (WTR::LayoutTestController::clearAllApplicationCaches):
446         (WTR::LayoutTestController::setAppCacheMaximumSize):
447         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
448
449 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
450
451         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
452         https://bugs.webkit.org/show_bug.cgi?id=69145
453
454         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
455         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
456         and is perfectly suitable for SceneGraph as well. GraphicsScene events
457         will not be available in QtGui anymore in future. Therefore we also have to change
458         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
459
460         Reviewed by Chang Shu.
461
462         * WebKitTestRunner/EventSenderProxy.h:
463         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
464         (WTR::EventSenderProxy::createMouseEvent):
465         (WTR::EventSenderProxy::mouseDown):
466         (WTR::EventSenderProxy::mouseUp):
467         (WTR::EventSenderProxy::mouseMoveTo):
468
469 2011-09-30  James Robinson  <jamesr@chromium.org>
470
471         [chromium] Add WebKit API for sending input events to the compositor thread
472         https://bugs.webkit.org/show_bug.cgi?id=69117
473
474         Reviewed by Darin Fisher.
475
476         Adds support for creating and setting a compositor thread in DRT.
477
478         * DumpRenderTree/chromium/WebViewHost.cpp:
479         (WebViewHost::WebViewHost):
480         * DumpRenderTree/chromium/WebViewHost.h:
481
482 2011-09-29  David Levin  <levin@chromium.org>
483
484         watchlist: Add cross-checks for WatchList once it is filled.
485         https://bugs.webkit.org/show_bug.cgi?id=68975
486
487         Reviewed by Eric Seidel.
488
489         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
490         instead of having trivial getter and setters.
491         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
492         pass the validation checks.
493         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
494         and fix a few style nits.
495         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
496         validation checks.
497         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
498
499 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
500
501         run-api-tests fails on chromium-win bot
502         https://bugs.webkit.org/show_bug.cgi?id=69121
503
504         On Windows running a perl script needs the interpreter.
505
506         Reviewed by Adam Barth.
507
508         * Scripts/run-api-tests:
509         (buildTestTool):
510
511 2011-09-29  Adam Barth  <abarth@webkit.org>
512
513         Attempt to make this tool work on Windows.
514
515         * Scripts/run-api-tests:
516         (buildTestTool):
517
518 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
519
520         [Qt] Try to fix the minial build
521
522         * QtTestBrowser/launcherwindow.cpp:
523         * QtTestBrowser/webpage.cpp:
524
525 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
526
527         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
528
529         QWidget and friends now live in the QtWidgets library. We update
530         includes in implementation files and private headers to us the
531         non-module-prefixed path, and leave the lookup for the include
532         path. For public headers we have to ifdef the includes as the
533         user might now have the modules we need in his QT config.
534
535         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
536         have to update our code and use windowHandle() for setting the
537         parent relationships.
538
539         https://bugs.webkit.org/show_bug.cgi?id=68687
540
541         Reviewed by Andreas Kling.
542
543         * DumpRenderTree/qt/DumpRenderTree.pro:
544         * DumpRenderTree/qt/ImageDiff.pro:
545         * MiniBrowser/qt/BrowserView.cpp:
546         * MiniBrowser/qt/BrowserView.h:
547         * MiniBrowser/qt/BrowserWindow.cpp:
548         * MiniBrowser/qt/BrowserWindow.h:
549         * MiniBrowser/qt/MiniBrowser.pro:
550         * MiniBrowser/qt/MiniBrowserApplication.h:
551         * MiniBrowser/qt/main.cpp:
552         * QtTestBrowser/QtTestBrowser.pro:
553         * QtTestBrowser/launcherwindow.cpp:
554         * QtTestBrowser/launcherwindow.h:
555         * QtTestBrowser/locationedit.h:
556         * QtTestBrowser/main.cpp:
557         * QtTestBrowser/mainwindow.cpp:
558         * QtTestBrowser/mainwindow.h:
559         * QtTestBrowser/webinspector.h:
560         * QtTestBrowser/webpage.cpp:
561         * QtTestBrowser/webview.cpp:
562         * WebKitTestRunner/PlatformWebView.h:
563         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
564
565 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
566
567         Initial implementation of WebInspector for WebKit2 GTK port.
568         https://bugs.webkit.org/show_bug.cgi?id=68235
569
570         Reviewed by Martin Robinson.
571
572         * MiniBrowser/gtk/BrowserWindow.c:
573         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
574
575 2011-09-29  Adam Barth  <abarth@webkit.org>
576
577         Unbreak the "update expectatations" button by using the existing
578         machinery to create the failureInfo objects.
579
580         Unbreak the "close" button on the progress dialog by using |this|
581         instead of the old name of the object.
582
583         Teach the controllers unit test not to talk to the actual network.
584
585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
588
589 2011-09-29  Hans Wennborg  <hans@chromium.org>
590
591         IndexedDB: Use LevelDB also for in-memory databases
592         https://bugs.webkit.org/show_bug.cgi?id=68903
593
594         Reviewed by Steve Block.
595
596         Remove the temporary dir that was necessary before LevelDB supported
597         in-memory databases.
598
599         * DumpRenderTree/chromium/TestShell.cpp:
600         (TestShell::TestShell):
601         * DumpRenderTree/chromium/TestShell.h:
602
603 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
604
605         Run TestWebKitAPI on Chromium buildbots
606         https://bugs.webkit.org/show_bug.cgi?id=68678
607
608         Reviewed by Tony Chang.
609
610         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
611
612 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
613
614         garden-o-matic results should anticipate 0 unexpected failures.
615         https://bugs.webkit.org/show_bug.cgi?id=69036
616
617         Also fixes controllers: UnexpectedFailures test.
618
619         Reviewed by Adam Barth.
620
621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
622
623 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
624
625         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
626
627         https://bugs.webkit.org/show_bug.cgi?id=67253
628
629         Reviewed by Eric Seidel.
630
631         Nearly all of the work in this was done by Simon Fraser; I'm
632         just repackaging it and cleaning it up a bit. This change
633         modifies port.diff_image() to return a tuple of (pass/fail,
634         %age), adds the value to the FailureImageHashMismatch, and
635         writes the value into the full_results.json files to be
636         displayed in the results page.
637
638         * Scripts/webkitpy/layout_tests/controllers/manager.py:
639         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
640         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
641         * Scripts/webkitpy/layout_tests/models/test_failures.py:
642         * Scripts/webkitpy/layout_tests/port/base.py:
643         * Scripts/webkitpy/layout_tests/port/chromium.py:
644         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
645         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
646         * Scripts/webkitpy/layout_tests/port/test.py:
647         * Scripts/webkitpy/layout_tests/port/webkit.py:
648         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
649
650 2011-09-25  Kentaro Hara  <haraken@chromium.org>
651
652         Unreviewed. Adding myself to committers.py.
653
654         * Scripts/webkitpy/common/config/committers.py:
655
656 2011-09-28  Adam Barth  <abarth@webkit.org>
657
658         garden-o-matic shouldn't depend on test-results.appspot.com
659         https://bugs.webkit.org/show_bug.cgi?id=69019
660
661         Reviewed by Dimitri Glazkov.
662
663         This patch moves garden-o-matic from getting full_results.json from
664         test-results.appspot.com to getting that information directly from the
665         buildbot.  This patch improve the load time and accuracy of
666         garden-o-matic because test-results.appspot.com is slow and is dropping
667         a significant number of writes (see
668         https://bugs.webkit.org/show_bug.cgi?id=68748).
669
670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
673
674 2011-09-28  David Levin  <levin@chromium.org>
675
676         watchlist: Add a way to load the watchlist from config.
677         https://bugs.webkit.org/show_bug.cgi?id=68991
678
679         Reviewed by Eric Seidel.
680
681         * Scripts/webkitpy/common/config/watchlist: Added.
682         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
683         Support for loading the watch list.
684         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
685         Tests for the loading.
686         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
687         Adjusted to use the common base class.
688         * Scripts/webkitpy/common/webkitunittest.py: Added.
689         Made a common base class for functionality used in more than one.
690
691 2011-09-28  David Levin  <levin@chromium.org>
692
693         Attempt fix for Leopard python unit test run.
694
695         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
696
697 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
698
699         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
700         https://bugs.webkit.org/show_bug.cgi?id=68938
701
702         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
703
704         Reviewed by David Hyatt.
705
706         * DumpRenderTree/chromium/WebViewHost.cpp:
707         (WebViewHost::didUpdateLayout): Added width/height queries.
708         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
709
710 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
711
712         Get rebaseline server running again
713         https://bugs.webkit.org/show_bug.cgi?id=69020
714
715         Reviewed by Adam Barth.
716
717         Make rebaseline server run again after r90337 (missing format_date_time
718         import, results_json wasn't outputting anything).
719
720         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
721         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
722
723 2011-09-28  David Grogan  <dgrogan@chromium.org>
724
725         Move dgrogan from contributor to committer
726         https://bugs.webkit.org/show_bug.cgi?id=69021
727
728         * Scripts/webkitpy/common/config/committers.py:
729
730 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
731
732         Add Mac Skia GPU bots to builders.py
733         https://bugs.webkit.org/show_bug.cgi?id=69016
734
735         Reviewed by Eric Seidel.
736
737         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
738         GPU tests.
739
740         * Scripts/webkitpy/layout_tests/port/builders.py:
741         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
742
743 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
744
745         Second try at fixing the GTK+ build.
746
747         * GNUmakefile.am:
748
749 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
750
751         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
752         https://bugs.webkit.org/show_bug.cgi?id=68680
753
754         Reviewed by Tony Chang.
755
756         * Scripts/run-chromium-webkit-unit-tests:
757         * Scripts/webkitdirs.pm:
758         (determineBaseProductDir):
759
760 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
761
762         [Gtk] Implement textInputController.doCommand
763         https://bugs.webkit.org/show_bug.cgi?id=66496
764
765         Reviewed by Martin Robinson.
766
767         * DumpRenderTree/gtk/TextInputController.cpp:
768         (doCommandCallback): Callback function for textInputController.doCommand
769
770 2011-09-28  David Levin  <levin@chromium.org>
771
772         watchlist: Suggest corrections for typos and improve error message consistency.
773         https://bugs.webkit.org/show_bug.cgi?id=68976
774
775         Reviewed by Adam Barth.
776
777         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
778         for typos and improve consistency of the error messages.
779         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
780         and improve the regex that were already present.
781
782 2011-09-28  David Levin  <levin@chromium.org>
783
784         watchlist: Add support for matching added or deleted lines.
785         https://bugs.webkit.org/show_bug.cgi?id=68972
786
787         Reviewed by Adam Barth.
788
789         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
790         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
791         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
792         to the pattern match to only have the diff lines instead of the DiffFile.
793         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
794         Add tests for the new patterns and combinations of the patterns.
795         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
796         Sort imports. Add changeline support.
797
798 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
799
800         [GTK] Add WebKitError to GTK+ WebKit2 API
801         https://bugs.webkit.org/show_bug.cgi?id=68508
802
803         Reviewed by Martin Robinson.
804
805         * GNUmakefile.am: Add path to webkitgtk derived sources to the
806         include path.
807
808 2011-09-28  Philippe Normand  <pnormand@igalia.com>
809
810         [GTK] missing WebKit2 support in run-gtk-tests
811         https://bugs.webkit.org/show_bug.cgi?id=68992
812
813         Rubber-stamped by Andreas Kling.
814
815         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
816         webkit2 directory.
817
818 2011-09-27  Philippe Normand  <pnormand@igalia.com>
819
820         [GTK] build-webkit --no-webkit2 still builds WebKit2
821         https://bugs.webkit.org/show_bug.cgi?id=68892
822
823         Reviewed by Martin Robinson.
824
825         Take the --no-webkit2 option in account when building WebKitGTK+.
826
827         * Scripts/build-webkit:
828         * Scripts/webkitdirs.pm:
829         (buildAutotoolsProject):
830         (buildGtkProject):
831
832 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
833
834         Make Chromium Win Release (Tests) a core builder
835         https://bugs.webkit.org/show_bug.cgi?id=68906
836
837         Reviewed by Adam Barth.
838
839         Add Chromium Win Release (Tests) to the list of core builders.
840
841         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
842         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
843
844 2011-09-27  Adam Barth  <abarth@webkit.org>
845
846         garden-o-matic should load faster and inform the user what is happening
847         https://bugs.webkit.org/show_bug.cgi?id=68954
848
849         Reviewed by Dimitri Glazkov.
850
851         This test disables the expected failures tab.  The web inspector showed
852         that loading the data for this tab was slowing down the loading time
853         for the whole app.  We need to find a way to load that data lazily.
854
855         This patch also improves the update message to better describe the
856         progress the app is making analyzing data from the buildbot.
857
858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
861
862 2011-09-27  Adam Barth  <abarth@webkit.org>
863
864         garden-o-matic should show the first result when examining results
865         https://bugs.webkit.org/show_bug.cgi?id=68960
866
867         Reviewed by Dimitri Glazkov.
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
870
871 2011-09-27  David Levin  <levin@chromium.org>
872
873         watchlist: Add support for cc and message rules.
874         https://bugs.webkit.org/show_bug.cgi?id=68950
875
876         Reviewed by Adam Barth.
877
878         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
879         the cc's and messages for a patch.
880         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
881         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
882         for the rules.
883         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
884         A generic encapsulation of either a message list or a cc list.
885         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
886
887 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
888
889         webkit-patch doesn't like UTF-8 characters in reviewers names
890         https://bugs.webkit.org/show_bug.cgi?id=63452
891
892         Reviewed by Eric Seidel.
893
894         * Scripts/webkit-patch:
895
896 2011-09-27  Adam Barth  <abarth@webkit.org>
897
898         garden-o-matic examine buttons shows both expected and unexpected failures
899         https://bugs.webkit.org/show_bug.cgi?id=68918
900
901         Reviewed by Dimitri Glazkov.
902
903         This was a copy/paste error when I refactored this classes to share
904         more code.
905
906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
907
908 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
909
910         Add Kaustubh Atrawalkar to the list of contributors.
911
912         * Scripts/webkitpy/common/config/committers.py:
913
914 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
915
916         [Chromium] Fixed layout mode tests break subsequent tests
917         https://bugs.webkit.org/show_bug.cgi?id=68923
918         
919         Reviewed by Adam Barth.        
920
921         Reset fixed layout mode between tests, so that tests that run after
922         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
923         regular 800x600 non-fixed layout.
924
925         * DumpRenderTree/chromium/TestShell.cpp:
926         (TestShell::resetTestController):
927
928 2011-09-27  David Levin  <levin@chromium.org>
929
930         watchlist: Add the filename pattern for definitions.
931         https://bugs.webkit.org/show_bug.cgi?id=68917
932
933         Reviewed by Adam Barth.
934
935         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
936         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
937         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
938         for definitions.
939         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
940         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
941
942 2011-09-27  Adam Barth  <abarth@webkit.org>
943
944         garden-o-matic results view should sort test and builder names
945         https://bugs.webkit.org/show_bug.cgi?id=68488
946
947         Reviewed by Andy Estes.
948
949         Previously, the test and builder names were displayed in an arbitrary
950         order that changed from time to time.  That confused one user study
951         participant.  This patch sorts the lists so that they occur in a
952         predictable order.
953
954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
955
956 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
957
958         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
959         http://trac.webkit.org/changeset/96108
960         http://trac.webkit.org/changeset/96111
961         http://trac.webkit.org/changeset/96113
962         http://trac.webkit.org/changeset/96116
963         https://bugs.webkit.org/show_bug.cgi?id=68913
964
965         Wait for working Qt5 (Requested by ossy on #webkit).
966
967         * DumpRenderTree/qt/DumpRenderTree.pro:
968         * DumpRenderTree/qt/ImageDiff.pro:
969         * MiniBrowser/qt/BrowserView.cpp:
970         (BrowserView::BrowserView):
971         * MiniBrowser/qt/BrowserView.h:
972         * MiniBrowser/qt/BrowserWindow.cpp:
973         (BrowserWindow::BrowserWindow):
974         (BrowserWindow::urlChanged):
975         (BrowserWindow::~BrowserWindow):
976         * MiniBrowser/qt/BrowserWindow.h:
977         * MiniBrowser/qt/MiniBrowser.pro:
978         * MiniBrowser/qt/MiniBrowserApplication.h:
979         * MiniBrowser/qt/main.cpp:
980         * QtTestBrowser/QtTestBrowser.pro:
981         * QtTestBrowser/launcherwindow.cpp:
982         * QtTestBrowser/launcherwindow.h:
983         * QtTestBrowser/locationedit.h:
984         * QtTestBrowser/main.cpp:
985         * QtTestBrowser/mainwindow.cpp:
986         * QtTestBrowser/mainwindow.h:
987         * QtTestBrowser/webinspector.h:
988         * QtTestBrowser/webpage.cpp:
989         * QtTestBrowser/webview.cpp:
990         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
991         * WebKitTestRunner/PlatformWebView.h:
992         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
993         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
994         (WTR::WebView::wkView):
995         (WTR::WebView::pageRef):
996         (WTR::WebView::~WebView):
997         (WTR::WebView::WebView):
998         (WTR::PlatformWebView::PlatformWebView):
999         (WTR::PlatformWebView::sendEvent):
1000         (WTR::PlatformWebView::postEvent):
1001         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1002
1003 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1004
1005         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
1006         https://bugs.webkit.org/show_bug.cgi?id=65178
1007
1008         Reviewed by Martin Robinson.
1009
1010         * GNUmakefile.am:
1011         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
1012
1013 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
1014
1015         [Qt][WK2] Buildfix after r96108.
1016
1017         Rubber-stamped by Andreas Kling.
1018
1019         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1020         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1021         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1022
1023 2011-09-27  David Levin  <levin@chromium.org>
1024
1025         watchlist: Change watchlistparser.py to be class based.
1026         https://bugs.webkit.org/show_bug.cgi?id=68869
1027
1028         Reviewed by Eric Seidel.
1029
1030         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1031         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1032
1033 2011-09-27  David Levin  <levin@chromium.org>
1034
1035         watchlist: Break out the diff boilerplate to allow for re-use.
1036         https://bugs.webkit.org/show_bug.cgi?id=68871
1037
1038         Reviewed by Eric Seidel.
1039
1040         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1041         Break out the diff into a new file.
1042         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
1043
1044 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
1045
1046         Web Inspector: UI performance: introduce heap size tracking stats.
1047         https://bugs.webkit.org/show_bug.cgi?id=68901
1048
1049         It is interesting how much the heap memory is used by Inspector in order of running the test.
1050
1051         Reviewed by Yury Semikhatsky.
1052
1053         * DumpRenderTree/chromium/TestShell.cpp:
1054         (TestShell::showDevTools):
1055         (TestShell::closeDevTools):
1056
1057 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1058
1059         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1060
1061         QWidget and friends now live in the QtWidgets library. We update
1062         includes in implementation files and private headers to us the
1063         non-module-prefixed path, and leave the lookup for the include
1064         path. For public headers we have to ifdef the includes as the
1065         user might now have the modules we need in his QT config.
1066
1067         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1068         have to update our code and use windowHandle() for setting the
1069         parent relationships.
1070
1071         https://bugs.webkit.org/show_bug.cgi?id=68687
1072
1073         Reviewed by Andreas Kling.
1074
1075         * DumpRenderTree/qt/DumpRenderTree.pro:
1076         * DumpRenderTree/qt/ImageDiff.pro:
1077         * MiniBrowser/qt/BrowserView.cpp:
1078         * MiniBrowser/qt/BrowserView.h:
1079         * MiniBrowser/qt/BrowserWindow.cpp:
1080         * MiniBrowser/qt/BrowserWindow.h:
1081         * MiniBrowser/qt/MiniBrowser.pro:
1082         * MiniBrowser/qt/MiniBrowserApplication.h:
1083         * MiniBrowser/qt/main.cpp:
1084         * QtTestBrowser/QtTestBrowser.pro:
1085         * QtTestBrowser/launcherwindow.cpp:
1086         * QtTestBrowser/launcherwindow.h:
1087         * QtTestBrowser/locationedit.h:
1088         * QtTestBrowser/main.cpp:
1089         * QtTestBrowser/mainwindow.cpp:
1090         * QtTestBrowser/mainwindow.h:
1091         * QtTestBrowser/webinspector.h:
1092         * QtTestBrowser/webpage.cpp:
1093         * QtTestBrowser/webview.cpp:
1094         * WebKitTestRunner/PlatformWebView.h:
1095         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1096
1097 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1098
1099         [Qt][WK2] Add support for hover API in Qt WebKit2
1100         https://bugs.webkit.org/show_bug.cgi?id=68369
1101
1102         Reviewed by Andreas Kling.
1103
1104         Change the statusbar to show the link URL when hovering links in
1105         MiniBrowser using QDesktopWebView.
1106
1107         * MiniBrowser/qt/BrowserWindow.cpp:
1108         (BrowserWindow::BrowserWindow):
1109         (BrowserWindow::onLinkHovered):
1110         * MiniBrowser/qt/BrowserWindow.h:
1111
1112 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1113
1114         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
1115         https://bugs.webkit.org/show_bug.cgi?id=68864
1116
1117         Reviewed by Adam Barth.
1118
1119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
1120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
1121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
1123
1124 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1125
1126         [Qt][WK2] One more unreviewed buildfix after r96005.
1127
1128         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
1129
1130 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1131
1132         [Qt][WK2] Unreviewed buildfix after r96005.
1133
1134         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1135         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1136
1137 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1138
1139         garden-o-matic should be pretty in Open Sans.
1140         https://bugs.webkit.org/show_bug.cgi?id=68845
1141
1142         Reviewed by Adam Barth.
1143
1144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
1145
1146 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1147
1148         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
1149         https://bugs.webkit.org/show_bug.cgi?id=68841
1150
1151         Reviewed by Adam Barth.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
1154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
1156
1157 2011-09-26  David Levin  <levin@chromium.org>
1158
1159         watchlist: Add parsing for definition section.
1160         https://bugs.webkit.org/show_bug.cgi?id=68850
1161
1162         Reviewed by Adam Barth.
1163
1164         * Scripts/webkitpy/common/watchlist/watchlist.py:
1165         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1166         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1167
1168 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1169
1170         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
1171
1172         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1173         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1174         * WebKitTestRunner/win/TestInvocationWin.cpp:
1175         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1176
1177 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1178
1179         Repaint tests don't work in WebKit2
1180         https://bugs.webkit.org/show_bug.cgi?id=68453
1181
1182         Reviewed by Sam Weinig.
1183         
1184         Convert DumpRenderTree to use use the repaint rects
1185         exposed via WebKit API when generating the repaint test
1186         overlay.
1187         
1188         Fix WebKitTestRunner to work with repaint tests, again
1189         using the repaint rects exposed from WK2.
1190         
1191         In both cases, layoutTestController.display() now just
1192         forces a display of the web view, and turns on repaint
1193         rect tracking on the main FrameView.
1194         
1195         Later, when pixel results are requested, the alpha overlay
1196         that shows the repaint rects is generated using the list
1197         of rects supplied by WebCore.
1198
1199         * DumpRenderTree/mac/DumpRenderTree.mm:
1200         (resetDefaultsToConsistentValues):
1201         (resetWebViewToConsistentStateBeforeTesting):
1202         (displayWebView):
1203         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1204         (paintRepaintRectOverlay):
1205         (createBitmapContextFromWebView):
1206         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1207         (WTR::InjectedBundle::beginTesting):
1208         (WTR::InjectedBundle::done):
1209         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1210         (WTR::InjectedBundle::setRepaintRects):
1211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1212         (WTR::InjectedBundlePage::reset):
1213         (WTR::InjectedBundlePage::dump):
1214         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1215         (WTR::LayoutTestController::display):
1216         * WebKitTestRunner/TestInvocation.cpp:
1217         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1218         * WebKitTestRunner/TestInvocation.h:
1219         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1220         (WTR::paintRepaintRectOverlay):
1221         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1222
1223 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
1224
1225         Get hover'ed element URL from HitTest.
1226
1227         mouseDidMoveOverElement now gets the hover'ed element link using
1228         WKHitTestResult API's.
1229         https://bugs.webkit.org/show_bug.cgi?id=68426 
1230
1231         Reviewed by Anders Carlsson.
1232
1233         * MiniBrowser/gtk/BrowserWindow.c:
1234         (mouseDidMoveOverElement):
1235
1236 2011-09-26  David Levin  <levin@chromium.org>
1237
1238         Add skeleton parsing for a WatchList.
1239         https://bugs.webkit.org/show_bug.cgi?id=68823
1240
1241         Reviewed by Adam Barth.
1242
1243         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
1244         Parses the top level watch list sections -- none are defined yet -- and
1245         throws an exception if an invalid one is listed.
1246         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
1247         Verify the exception for an invalid section in a watch list.
1248         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
1249
1250 2011-09-26  Adam Roben  <aroben@apple.com>
1251
1252         Clean up code imported from WebKitAPITest
1253
1254         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
1255         TestWebKitAPI conventions
1256
1257         Reviewed by David Levin.
1258
1259         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
1260         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
1261         namespace name.
1262
1263         (TestWebKitAPI::WebViewDestruction::SetUp):
1264         (TestWebKitAPI::WebViewDestruction::webViewCount):
1265         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1266         (TestWebKitAPI::WebViewDestruction::runMessagePump):
1267         (TestWebKitAPI::WebViewDestruction::TearDown):
1268         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
1269         Moved functionality from free functions into these new test fixtures.
1270
1271         * TestWebKitAPI/win/HostWindow.cpp:
1272         * TestWebKitAPI/win/HostWindow.h:
1273         Prefixed Win32 API calls with ::. Updated namespace name.
1274
1275 2011-09-23  Adam Roben  <aroben@apple.com>
1276
1277         Merge WebKitAPITest into TestWebKitAPI
1278
1279         This also means that our formerly-WebKitAPITest tests will be run on the bots!
1280
1281         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
1282         them more idiomatic in a separate pass.
1283
1284         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1285         functionality (and names!)
1286
1287         Reviewed by Anders Carlsson.
1288
1289         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
1290         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
1291         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
1292
1293         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
1294
1295         * TestWebKitAPI/win/main.cpp:
1296         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
1297
1298         * WebKitAPITest: Removed this directory and its contents.
1299
1300 2011-09-23  Adam Roben  <aroben@apple.com>
1301
1302         Remove two failing WebKitAPITest tests
1303
1304         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
1305
1306         Reviewed by Anders Carlsson.
1307
1308         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
1309         MainFrameAfterClose tests.
1310
1311 2011-09-25  Adam Barth  <abarth@webkit.org>
1312
1313         Finish removing PLATFORM(BREWMP) by removing associated code
1314         https://bugs.webkit.org/show_bug.cgi?id=68779
1315
1316         Reviewed by Sam Weinig.
1317
1318         * Scripts/webkitpy/common/config/build.py:
1319         * waf/build/settings.py:
1320
1321 2011-09-21  Ai Makabi  <makabi@google.com>
1322
1323         Provides a simple LRU cache class in Python.
1324
1325         https://bugs.webkit.org/show_bug.cgi?id=67823
1326
1327         Reviewed by Tony Chang.
1328
1329         * Scripts/webkitpy/common/lru_cache.py:
1330         * Scripts/webkitpy/common/lru_cache_unittest.py:
1331
1332 2011-09-25  Adam Barth  <abarth@webkit.org>
1333
1334         Remove PLATFORM(HAIKU) and associated code
1335         https://bugs.webkit.org/show_bug.cgi?id=68774
1336
1337         Reviewed by Sam Weinig.
1338
1339         * Scripts/webkitpy/common/config/build.py:
1340         * waf/build/settings.py:
1341
1342 2011-09-24  Adam Barth  <abarth@webkit.org>
1343
1344         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1345         https://bugs.webkit.org/show_bug.cgi?id=68767
1346
1347         Reviewed by Eric Seidel.
1348
1349         * Scripts/build-webkit:
1350
1351 2011-09-24  Adam Barth  <abarth@webkit.org>
1352
1353         Remove ENABLE(WCSS) and associated code
1354         https://bugs.webkit.org/show_bug.cgi?id=68759
1355
1356         Reviewed by Darin Adler.
1357
1358         * Scripts/build-webkit:
1359         * Scripts/old-run-webkit-tests:
1360         * Scripts/webkitperl/features.pm:
1361         (hasFeature):
1362         * Scripts/webkitpy/layout_tests/port/webkit.py:
1363         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1364
1365 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1366
1367         Fixed GTK compilation after r95878, the operator== was defined
1368         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1369
1370         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1371
1372 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1373
1374         [DRT] Include the right config file for EFL's DRT.
1375         https://bugs.webkit.org/show_bug.cgi?id=67042
1376
1377         Reviewed by Martin Robinson.
1378
1379         Ports which use CMake as their buildsystem (such as the EFL one) also
1380         have config.h files, but they are named differently, so include the
1381         right one depending on the buildsystem being used.
1382
1383         * DumpRenderTree/config.h:
1384
1385 2011-09-23  Adam Klein  <adamk@chromium.org>
1386
1387         Add ENABLE_MUTATION_OBSERVERS feature flag
1388         https://bugs.webkit.org/show_bug.cgi?id=68732
1389
1390         Reviewed by Ojan Vafai.
1391
1392         This flag will guard an implementation of the "Mutation Observers" proposed in
1393         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1394
1395         * Scripts/build-webkit:
1396
1397 2011-09-23  Chang Shu  <cshu@webkit.org>
1398
1399         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1400         https://bugs.webkit.org/show_bug.cgi?id=68556
1401
1402         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1403
1404         Reviewed by Darin Adler.
1405
1406         * WebKitTestRunner/EventSenderProxy.h:
1407         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1408         * WebKitTestRunner/PlatformWebView.h:
1409         * WebKitTestRunner/mac/EventSenderProxy.mm:
1410         (WTR::EventSenderProxy::EventSenderProxy):
1411         (WTR::EventSenderProxy::leapForward):
1412         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1413         (WTR::EventSenderProxy::EventSenderProxy):
1414         (WTR::getMouseButton):
1415         (WTR::getModifiers):
1416         (WTR::EventSenderProxy::updateClickCountForButton):
1417         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1418         (WTR::EventSenderProxy::mouseDown):
1419         (WTR::EventSenderProxy::mouseUp):
1420         (WTR::EventSenderProxy::mouseMoveTo):
1421         (WTR::EventSenderProxy::leapForward):
1422         (WTR::EventSenderProxy::sendOrQueueEvent):
1423         (WTR::EventSenderProxy::replaySavedEvents):
1424         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1425         (WTR::PlatformWebView::postEvent):
1426         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1427
1428 2011-09-23  Lei Zhang  <thestig@chromium.org>
1429
1430         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1431         https://bugs.webkit.org/show_bug.cgi?id=68026
1432
1433         Reviewed by Dirk Pranke.
1434
1435         * Scripts/webkitpy/layout_tests/port/chromium.py:
1436
1437 2011-09-23  Elliot Poger  <epoger@google.com>
1438
1439         update layout_tests to account for new default of use_skia=1
1440         https://bugs.webkit.org/show_bug.cgi?id=68698
1441
1442         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1443         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1444         (Chromium-on-Mac now uses the Skia graphics library instead of
1445         Core Graphics).
1446
1447         Also updates layout_test code to work with that change.
1448
1449         Reviewed by Mihai Parparita.
1450
1451         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1452         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1453
1454 2011-09-23  Mark Rowe  <mrowe@apple.com>
1455
1456         Fix the build.
1457         
1458         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1459         the WTF namespace.
1460
1461 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1462
1463         enable NRWT for run-webkit-tests on Lion
1464         https://bugs.webkit.org/show_bug.cgi?id=68673
1465
1466         Reviewed by Eric Seidel.
1467
1468         * Scripts/run-webkit-tests:
1469         (useNewRunWebKitTests):
1470
1471 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1472
1473         Add unit test for existing StringBuilder
1474         https://bugs.webkit.org/show_bug.cgi?id=67080
1475
1476         Reviewed by Darin Adler.
1477
1478         * TestWebKitAPI/TestWebKitAPI.gypi:
1479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1480         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
1481         (operator<<):
1482         (TestWebKitAPI::expectBuilderContent):
1483         (TestWebKitAPI::expectEmpty):
1484         (TestWebKitAPI::TEST):
1485
1486 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
1487
1488         [EFL] Use ewk_view to navigate in history instead of ewk_history.
1489         https://bugs.webkit.org/show_bug.cgi?id=68455
1490
1491         Reviewed by Antonio Gomes.
1492
1493         BackForwardItem::invoke() was using ewk_history functions to navigate
1494         in history; however, this will only call WebCore::BackForwardListImpl
1495         and not move between pages at all. We now call ewk_view_navigate and
1496         its siblings to make sure the navigation actually happens.
1497
1498         This should make tests like fast/dom/navigation-type-back-forward.html
1499         stop timing out.
1500
1501         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1502         (BackForwardItem::invoke):
1503
1504 2011-09-22  Dean Jackson  <dino@apple.com>
1505
1506         Add ENABLE_CSS_FILTERS
1507         https://bugs.webkit.org/show_bug.cgi?id=68652
1508
1509         Reviewed by Simon Fraser.
1510
1511         * Scripts/build-webkit:
1512
1513 2011-09-22  Anders Carlsson  <andersca@apple.com>
1514
1515         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
1516         https://bugs.webkit.org/show_bug.cgi?id=68660
1517
1518         Reviewed by Adam Barth.
1519
1520         * WebKitTestRunner/mac/EventSenderProxy.mm:
1521         (WTR::EventSenderProxy::mouseUp):
1522
1523 2011-09-22  Adam Roben  <aroben@apple.com>
1524
1525         Remove FindSafari
1526
1527         It isn't used or built anymore.
1528
1529         Fixes <http://webkit.org/b/68628>
1530
1531         Reviewed by Darin Adler.
1532
1533         * FindSafari: Removed this directory and its contents.
1534
1535 2011-09-22  Adam Roben  <aroben@apple.com>
1536
1537         Remove FindSafari from all our .sln files
1538
1539         It isn't used anymore, so there's no point in building it.
1540
1541         Part of <http://webkit.org/b/68628> Remove FindSafari
1542
1543         Reviewed by Steve Falkenburg.
1544
1545         * DumpRenderTree/DumpRenderTree.sln:
1546         * WebKitTestRunner/WebKitTestRunner.sln:
1547
1548 2011-09-22  Adam Roben  <aroben@apple.com>
1549
1550         Remove all uses of FindSafari
1551
1552         It isn't really needed anymore.
1553
1554         Fixes <http://webkit.org/b/68626>.
1555
1556         Reviewed by Darin Adler.
1557
1558         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
1559
1560         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
1561         WebKit, but now we use WebKit.exe for that.
1562
1563         * Scripts/webkitdirs.pm:
1564         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
1565         do the same thing.
1566
1567         (readRegistryString):
1568         (writeRegistryString):
1569         Moved here from old-run-webkit-tests.
1570
1571 2011-09-22  Adam Roben  <aroben@apple.com>
1572
1573         Use the "direct object" form of system() to run WebKit.exe
1574
1575         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
1576         path to WebKit.exe.
1577
1578         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
1579         %WEBKITOUTPUTDIR%
1580
1581         Reviewed by Steve Falkenburg.
1582
1583         * Scripts/webkitdirs.pm:
1584         (runSafari):
1585
1586 2011-09-22  Adam Roben  <aroben@apple.com>
1587
1588         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
1589
1590         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
1591         spaces in the path to the WebKit source tree
1592
1593         Reviewed by John Sullivan.
1594
1595         * Scripts/webkitdirs.pm:
1596         (setupCygwinEnv):
1597
1598 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1599
1600         [Qt] Use same DPI for application font as rest of app in DRT and WTR
1601
1602         QApplication will initialize the default application font based
1603         on the application DPI at construction time, but we then override
1604         the application DPI using QX11Info (hard-coding it to 96 for
1605         consistency). This hard-coding is not reflected in the application
1606         font, so we explicitly have update the font ourselves.
1607
1608         The 6 test results that are updated were originally produced with
1609         a DPI of 75, as this is the default fallback DPI when a QFont is
1610         constructed before QApplication. This was wrong, and the results
1611         are updated to match a DPI of 96.
1612
1613         Reviewed by Csaba Osztrogonác.
1614
1615         * DumpRenderTree/qt/main.cpp:
1616         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1617
1618 2011-09-21  Anna Cavender  <annacc@chromium.org>
1619
1620         Update committers.py with a new contributor contact        
1621         https://bugs.webkit.org/show_bug.cgi?id=68565
1622
1623         Reviewed by Eric Carlson.
1624
1625         * Scripts/webkitpy/common/config/committers.py:
1626
1627 2011-09-21  Chang Shu  <cshu@webkit.org>
1628
1629         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1630         https://bugs.webkit.org/show_bug.cgi?id=68108
1631
1632         This patch implements the event sender mouse events through WebKit2 UIProcess which is
1633         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
1634         platform as the first step so the existing code is still kept for other platforms.
1635
1636         Reviewed by Darin Adler.
1637
1638         * WebKitTestRunner/EventSenderProxy.h:
1639         (WTR::EventSenderProxy::EventSenderProxy):
1640         (WTR::EventSenderProxy::leapForward):
1641         (WTR::EventSenderProxy::currentEventTime):
1642         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1643         (WTR::EventSendingController::EventSendingController):
1644         (WTR::EventSendingController::mouseDown):
1645         (WTR::EventSendingController::mouseUp):
1646         (WTR::EventSendingController::mouseMoveTo):
1647         (WTR::EventSendingController::leapForward):
1648         (WTR::EventSendingController::keyDown):
1649         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1650         * WebKitTestRunner/TestController.cpp:
1651         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1652         * WebKitTestRunner/mac/EventSenderProxy.mm:
1653         (WTR::eventTypeForMouseButtonAndAction):
1654         (WTR::operator==):
1655         (WTR::EventSenderProxy::updateClickCountForButton):
1656         (WTR::EventSenderProxy::mouseDown):
1657         (WTR::EventSenderProxy::mouseUp):
1658         (WTR::EventSenderProxy::mouseMoveTo):
1659         (WTR::EventSenderProxy::keyDown):
1660         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1661         (WTR::EventSenderProxy::keyDown):
1662         (WTR::EventSenderProxy::mouseDown):
1663         (WTR::EventSenderProxy::mouseUp):
1664         (WTR::EventSenderProxy::mouseMoveTo):
1665
1666 2011-09-21  Dan Bernstein  <mitz@apple.com>
1667
1668         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
1669         https://bugs.webkit.org/show_bug.cgi?id=68451
1670
1671         Reviewed by Darin Adler.
1672
1673         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
1674         Objective-C classes with names not having one of a list of prefixes
1675         passed on the command line.
1676
1677 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
1678
1679         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
1680         https://bugs.webkit.org/show_bug.cgi?id=68206
1681
1682         Reviewed by Tony Chang.
1683
1684         * Scripts/webkitdirs.pm:
1685         (determineBaseProductDir): add support for chromium-mac
1686         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1687         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1688
1689 2011-09-21  Adam Barth  <abarth@webkit.org>
1690
1691         garden-o-matic command should explain that it is starting a local server
1692         https://bugs.webkit.org/show_bug.cgi?id=68486
1693
1694         Reviewed by Dimitri Glazkov.
1695
1696         In the user study, both participants didn't understand why the
1697         garden-o-matic command appeared to hang.  This patch adds an
1698         explaination of what's going on.  It also adds a confirmation prompt
1699         before launching the browser to give the user a chance to read the
1700         text.  If that's too much of a speed bump, we can iterate.
1701
1702         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1703
1704 2011-09-21  Chang Shu  <cshu@webkit.org>
1705
1706         [Qt] Implement KeyDown function for WebKit2 EventSender.
1707         https://bugs.webkit.org/show_bug.cgi?id=56485
1708
1709         Implement the KeyDown function on Qt platform.
1710
1711         Reviewed by Andreas Kling.
1712
1713         * WebKitTestRunner/PlatformWebView.h:
1714         * WebKitTestRunner/TestController.cpp:
1715         (WTR::TestController::TestController):
1716         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1717         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
1718         (WTR::getModifiers):
1719         (WTR::EventSenderProxy::keyDown):
1720         (buildModifierFlags):
1721         (EventSenderProxy::keyDown):
1722         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1723         (WTR::PlatformWebView::sendEvent):
1724         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1725
1726 2011-09-20  Adam Barth  <abarth@webkit.org>
1727
1728         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
1729         https://bugs.webkit.org/show_bug.cgi?id=68496
1730
1731         Reviewed by Dimitri Glazkov.
1732
1733         This patch adds a bunch of sorting to make sure things happen in a
1734         predictable order in both JavaScriptCore and V8.  We've talked before
1735         about whether these two JavaScript engines should enumerate
1736         dictionaries in the same order, but the consensus has been that they
1737         shouldn't.  Personally, I disagree with that consensus, but such is life.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1743
1744 2011-09-20  Adam Barth  <abarth@webkit.org>
1745
1746         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
1747         https://bugs.webkit.org/show_bug.cgi?id=68495
1748
1749         Reviewed by Dimitri Glazkov.
1750
1751         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
1752
1753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1754
1755 2011-09-20  Eric Seidel  <eric@webkit.org>
1756
1757         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1758         https://bugs.webkit.org/show_bug.cgi?id=65781
1759
1760         Reviewed by Ryosuke Niwa.
1761
1762         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
1763         to resolve the passed in url relative to the absolute url for the test.
1764         For http tests, since the test url is an http url, we can't resolve relative
1765         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
1766         for resolving.
1767
1768         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1769         (which resolves the path relative to the built location of the DRT executable)
1770         and we should move this new code into a shared location in a follow-up patch.
1771
1772         It turns out that there was a second use for pathToLocalResource, used by one
1773         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
1774         To support this test I made the new pathToLocalResource smart enough to map
1775         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
1776
1777         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1778         (LayoutTestController::pathToLocalResource):
1779         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
1780
1781 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1782
1783         Need to specify a django version, instead of using default
1784         https://bugs.webkit.org/show_bug.cgi?id=68398
1785
1786         Reviewed by Eric Seidel.
1787
1788         * QueueStatusServer/__init__.py:
1789         * QueueStatusServer/main.py:
1790
1791 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1792
1793         Update committers.py with a few more contributor contacts
1794         https://bugs.webkit.org/show_bug.cgi?id=68487
1795
1796         Reviewed by Eric Seidel.
1797
1798         * Scripts/webkitpy/common/config/committers.py:
1799
1800 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1801
1802         Fix webkitpy unit tests after 95547 and 95549
1803         https://bugs.webkit.org/show_bug.cgi?id=68483
1804
1805         Reviewed by Adam Barth.
1806         
1807         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
1808
1809         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
1810         parse_entries_from_file(), use StringIO and entry.reviewer_text().
1811         While testing parse_latest_entry_from_file(), expect the correct
1812         touched_files() list.
1813
1814 2011-09-20  Adam Barth  <abarth@webkit.org>
1815
1816         garden-o-matic makes it hard to compare images when scroll bars appear
1817         https://bugs.webkit.org/show_bug.cgi?id=68482
1818
1819         Reviewed by Eric Seidel.
1820
1821         Because we autoscale image width, the images rescale if we overflow
1822         vertically and get a scrollbar.  That makes it hard to compare two sets
1823         of images.  This patch reserves space for the scrollbar so we won't
1824         have the layout change.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1827
1828 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1829
1830         Unreviewed, rolling out r95565.
1831         http://trac.webkit.org/changeset/95565
1832         https://bugs.webkit.org/show_bug.cgi?id=68470
1833
1834         Broke builds (Requested by andersca on #webkit).
1835
1836         * MiniBrowser/gtk/BrowserWindow.c:
1837         (mouseDidMoveOverElement):
1838
1839 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
1840
1841         Get hover'ed element URL from HitTest.
1842         
1843         mouseDidMoveOverElement now gets the hover'ed element link using
1844         WKHitTestResult API's.
1845         https://bugs.webkit.org/show_bug.cgi?id=68426
1846
1847         Reviewed by Anders Carlsson.
1848
1849         * MiniBrowser/gtk/BrowserWindow.c:
1850         (mouseDidMoveOverElement):
1851
1852 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1853
1854         Changelog class should have a method to return all entries
1855         https://bugs.webkit.org/show_bug.cgi?id=68399
1856         
1857         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
1858         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
1859
1860         Reviewed by Ryosuke Niwa.
1861
1862         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
1863         and adapt it to become a generator.
1864         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
1865
1866 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
1867
1868         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
1869         https://bugs.webkit.org/show_bug.cgi?id=51159
1870
1871         Permit any URL with a local scheme to set a user style sheet. Allow qrc
1872         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
1873         
1874         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
1875
1876         Reviewed by Kenneth Rohde Christiansen.
1877
1878         * DumpRenderTree/qt/DumpRenderTree.pro:
1879         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
1880         * DumpRenderTree/qt/resources/user.css: Added.
1881         (body):
1882         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1883         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
1884         * WebKitTestRunner/qt/resources/user.css: Added.
1885         (body):
1886
1887 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1888
1889         ChangeLogEntry class should contain a list of touched files
1890         https://bugs.webkit.org/show_bug.cgi?id=68115
1891
1892         Reviewed by Eric Seidel.
1893         
1894         Add method to return the list of files touched in a ChangeLog entry.
1895
1896         * Scripts/webkitpy/common/checkout/changelog.py: Add
1897         touched_files_regexp and touched_files() method.
1898         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
1899         unit tests for touched_files() method.
1900
1901 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1902
1903         Unreviewed, rolling out r95526 and r95541.
1904         http://trac.webkit.org/changeset/95526
1905         http://trac.webkit.org/changeset/95541
1906         https://bugs.webkit.org/show_bug.cgi?id=68443
1907
1908         It broke 6 tests (Requested by ossy_ on #webkit).
1909
1910         * DumpRenderTree/qt/main.cpp:
1911         (main):
1912         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1913         (WTR::activateFonts):
1914
1915 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1916
1917         Fix patch and bug numbering in the mocktool simulation code
1918         https://bugs.webkit.org/show_bug.cgi?id=68374
1919
1920         Reviewed by Adam Barth.
1921
1922         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1923         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1924         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1925         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1926         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1927         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1928         * Scripts/webkitpy/tool/commands/download_unittest.py:
1929         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1930         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1931         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1932         * Scripts/webkitpy/tool/commands/queuestest.py:
1933         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1934         * Scripts/webkitpy/tool/mocktool.py:
1935         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1936         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1937
1938 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1939
1940         [Qt] Don't override default QApplication font for DRT and WTR
1941
1942         Revision 95526 moved the relevant code below the QApplication
1943         constructor, to fix a potential crash, and that made the code
1944         take effect, breaking 6 tests.
1945
1946         We should rely on the QWebSettings to set default fonts, and
1947         this QApplication::setFont() is a relic from when we didn't
1948         have that option, so we remove the code.
1949
1950         Reviewed by Csaba Osztrogonác.
1951
1952         * DumpRenderTree/qt/main.cpp:
1953         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1954
1955 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1956
1957         WebKitTestRunner: Provide usage if run without arguments
1958
1959         If WTR is run without either one or more filenames, or
1960         a '-' to indicate server mode, we don't need to start
1961         up the test machinery. Doing so might actually crash,
1962         as we'll exit the application immedeatly after anyways.
1963
1964         Reviewed by Simon Hausmann.
1965
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::initialize):
1968
1969 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1970
1971         [Qt] Don't use QFont before initializing QApplication
1972
1973         Could potentially result in crash.
1974
1975         Reviewed by Simon Hausmann.
1976
1977         * DumpRenderTree/qt/main.cpp:
1978         (main):
1979
1980 2011-09-19  Adam Barth  <abarth@webkit.org>
1981
1982         Always enable ENABLE(EVENTSOURCE)
1983         https://bugs.webkit.org/show_bug.cgi?id=68414
1984
1985         Reviewed by Eric Seidel.
1986
1987         * Scripts/build-webkit:
1988
1989 2011-09-19  David Levin  <levin@chromium.org>
1990
1991         Sheriffbot rollout should be more intuitive.
1992         https://bugs.webkit.org/show_bug.cgi?id=68415
1993
1994         Reviewed by Adam Barth.
1995
1996         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
1997         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
1998           and a few others cases.
1999         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
2000
2001 2011-09-19  David Levin  <levin@chromium.org>
2002
2003         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
2004         https://bugs.webkit.org/show_bug.cgi?id=68391
2005
2006         Reviewed by Darin Adler.
2007
2008         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
2009         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
2010
2011 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
2012
2013         Style checker should not check public Qt WK2 API for parameter_name.
2014         https://bugs.webkit.org/show_bug.cgi?id=68359
2015
2016         Reviewed by Andreas Kling.
2017
2018         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
2019         Add an exception in the style checker to disable the check. Also added the test for it.
2020
2021         * Scripts/webkitpy/style/checker.py:
2022         * Scripts/webkitpy/style/checker_unittest.py:
2023
2024 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
2025
2026         GTK DRT leaks memory while comparing history items
2027         https://bugs.webkit.org/show_bug.cgi?id=68086
2028
2029         Reviewed by Martin Robinson.
2030         
2031         webkit_web_history_item_get_target() returns a g_strdup()'d string,
2032         so memory must be freed before compareHistoryItems() returns.
2033
2034         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2035         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
2036
2037 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2038
2039         Buildbot marks a nrwt bot red when tests are missing results
2040         https://bugs.webkit.org/show_bug.cgi?id=64812
2041
2042         Reviewed by Ryosuke Niwa.
2043
2044         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2045         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2046
2047 2011-09-19  Jessie Berlin  <jberlin@apple.com>
2048
2049         Sites that use history pushState or replaceState are recorded in history in Private Browsing
2050         mode.
2051         https://bugs.webkit.org/show_bug.cgi?id=68208
2052
2053         Reviewed by Brady Eidson.
2054
2055         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
2056         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
2057
2058         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
2059         (TestWebKitAPI::didNavigateWithNavigationData):
2060         This is a context history client callback, so it should not be called when in Private
2061         Browsing. Add a call to FAIL().
2062         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2063         This is a page load client callback that happens after the didNavigateWithNavigationData
2064         callback. End the test.
2065         (TestWebKitAPI::TEST):
2066         Enable Private Browsing and load a page that uses history.pushState.
2067
2068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2069         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
2070         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
2071         Ditto.
2072         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2073         Ditto.
2074         * TestWebKitAPI/win/copy-resources.cmd:
2075         Ditto.
2076
2077 2011-09-16  Elliot Poger  <epoger@google.com>
2078
2079         add non-CG Webkit-Mac builds to flakiness dashboard
2080         https://bugs.webkit.org/show_bug.cgi?id=68265
2081
2082         Reviewed by Adam Barth.
2083
2084         As Chromium-on-Mac approaches the switchover from Core Graphics to
2085         Skia, we need to add the Skia version to the flakiness dashboard.
2086
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2088         * TestResultServer/static-dashboards/builders.js:
2089         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2090
2091 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
2092
2093         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
2094         https://bugs.webkit.org/show_bug.cgi?id=68071
2095
2096         Reviewed by Adam Barth.
2097
2098         * DumpRenderTree/chromium/WebPermissions.cpp:
2099         (WebPermissions::allowImage):
2100         * DumpRenderTree/chromium/WebPermissions.h:
2101
2102 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
2103
2104         update-webkit-chromium should retry the gclient call if it fails once
2105         https://bugs.webkit.org/show_bug.cgi?id=68252
2106
2107         Reviewed by Adam Barth.
2108
2109         * Scripts/update-webkit-chromium:
2110
2111 2011-09-16  Rob Buis  <rbuis@rim.com>
2112
2113         Add Eli's rim address and change the nick.
2114
2115         * Scripts/webkitpy/common/config/committers.py:
2116
2117 2011-09-16  Anders Carlsson  <andersca@apple.com>
2118
2119         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
2120         https://bugs.webkit.org/show_bug.cgi?id=68269
2121
2122         Reviewed by Geoffrey Garen.
2123
2124         Update client function signatures.
2125
2126         * MiniBrowser/gtk/BrowserWindow.c:
2127         (browserWindowUIClientInit):
2128         * MiniBrowser/mac/BrowserWindowController.m:
2129         (mouseDidMoveOverElement):
2130         (-[BrowserWindowController awakeFromNib]):
2131         * MiniBrowser/win/BrowserView.cpp:
2132         (BrowserView::create):
2133         * WebKitTestRunner/TestController.cpp:
2134         (WTR::TestController::createOtherPage):
2135         (WTR::TestController::initialize):
2136
2137 2011-09-16  Anders Carlsson  <andersca@apple.com>
2138
2139         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
2140         https://bugs.webkit.org/show_bug.cgi?id=68266
2141
2142         Reviewed by John Sullivan.
2143
2144         * MiniBrowser/mac/BrowserWindowController.m:
2145         (mouseDidMoveOverElement):
2146
2147 2011-09-16  Vincent Scheib  <scheib@chromium.org>
2148
2149         Add Vincent Scheib to the committers list.
2150
2151         * Scripts/webkitpy/common/config/committers.py:
2152
2153 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2154
2155         Unreviewed, rolling out r95285.
2156         http://trac.webkit.org/changeset/95285
2157         https://bugs.webkit.org/show_bug.cgi?id=68247
2158
2159         It broke a webkitpy test (Requested by ossy on #webkit).
2160
2161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2162
2163 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2164
2165         Buildbot marks a nrwt bot red when tests are missing results
2166         https://bugs.webkit.org/show_bug.cgi?id=64812
2167
2168         Reviewed by Dirk Pranke.
2169
2170         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2171
2172 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
2173
2174         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
2175         https://bugs.webkit.org/show_bug.cgi?id=68178
2176
2177         Reviewed by Xan Lopez.
2178
2179         Add a work-around to enable WebKit2 when using build-webkit.
2180
2181         * Scripts/webkitdirs.pm:
2182         (buildAutotoolsProject): 
2183
2184 2011-09-15  James Robinson  <jamesr@chromium.org>
2185
2186         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
2187
2188         * Scripts/webkitpy/common/config/committers.py:
2189
2190 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2191
2192         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
2193         https://bugs.webkit.org/show_bug.cgi?id=68003
2194
2195         Reviewed by Adam Barth.
2196
2197         * Scripts/webkitpy/tool/mocktool.py:
2198         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2199         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2200
2201 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2202
2203         Python version check is confusing in test-webkitpy
2204         https://bugs.webkit.org/show_bug.cgi?id=68004
2205
2206         Reviewed by Adam Barth.
2207
2208         * Scripts/test-webkitpy:
2209
2210 2011-09-15  Eric Seidel  <eric@webkit.org>
2211
2212         Reviewed by Adam Barth.
2213
2214         webkit-patch should be able to find users and add them to bugzilla groups
2215         https://bugs.webkit.org/show_bug.cgi?id=63351
2216
2217         These are both very basic commands.  But it's now possible to find
2218         all users matching a regexp, as well as add all users matching a regexp
2219         to a set of groups.
2220
2221         bugzilla.py already knew how to find users (for validate-committer-lists)
2222         but now it has the ability to modify the user records.
2223
2224         I split some of the logic out into a new EditUsersParser class
2225         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
2226
2227         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2228         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2229         * Scripts/webkitpy/tool/commands/__init__.py:
2230         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
2231         * Scripts/webkitpy/tool/commands/findusers.py: Added.
2232
2233 2011-09-15  Eric Seidel  <eric@webkit.org>
2234
2235         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2236         https://bugs.webkit.org/show_bug.cgi?id=68182
2237
2238         Reviewed by Adam Barth.
2239
2240         * Scripts/build-webkit:
2241         * waf/build/settings.py:
2242
2243 2011-09-15  Eric Seidel  <eric@webkit.org>
2244
2245         Unreviewed.  Make contributor email look-up case-insensitive.
2246
2247         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
2248         was missing from committers.py due to case sensitivity.
2249
2250         This also includes a test expectations update to committers_unittest.py
2251         after my previous change.
2252
2253         * Scripts/webkitpy/common/config/committers.py:
2254         * Scripts/webkitpy/common/config/committers_unittest.py:
2255         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2256
2257 2011-09-15  Eric Seidel  <eric@webkit.org>
2258
2259         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
2260
2261         Add a bunch of email aliases to committers.py for regular contributors
2262         who are committing using other email addresses than they have listed in the file.
2263
2264         * Scripts/webkitpy/common/config/committers.py:
2265
2266 2011-09-15  Eric Seidel  <eric@webkit.org>
2267
2268         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2269         https://bugs.webkit.org/show_bug.cgi?id=68022
2270
2271         Reviewed by Ryosuke Niwa.
2272
2273         * Scripts/build-webkit:
2274         * waf/build/settings.py:
2275
2276 2011-09-15  Anders Carlsson  <andersca@apple.com>
2277
2278         Fix Mac build by including config.h where needed.
2279
2280         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2281         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2282         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2283         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2284         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2285         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2286         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2287         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2288         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2289         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2290         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2291         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2292         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2293         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2294         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2295         * TestWebKitAPI/mac/main.mm:
2296
2297 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
2298
2299         Let TestWebKitAPI work for chromium
2300         https://bugs.webkit.org/show_bug.cgi?id=67756
2301
2302         Reviewed by Sam Weinig.
2303
2304         * Scripts/build-api-tests:
2305         * Scripts/run-api-tests:
2306         (isSupportedPlatform):
2307         (runTest):
2308         (populateTests):
2309         * Scripts/webkitdirs.pm:
2310         (determineBaseProductDir):
2311         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2312         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2313         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2314         * TestWebKitAPI/InjectedBundleController.cpp:
2315         * TestWebKitAPI/InjectedBundleMain.cpp:
2316         * TestWebKitAPI/JavaScriptTest.cpp:
2317         * TestWebKitAPI/PlatformUtilities.cpp:
2318         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
2319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2320         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
2321         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2322         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2323         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2324         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2325         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2326         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2327         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2328         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2329         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2330         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2331         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2332         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2333         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2334         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2335         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2336         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2337         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2338         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2339         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2340         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2341         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2342         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2343         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2344         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2345         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2346         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2347         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2348         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2349         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2350         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2351         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2352         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2353         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2354         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2355         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2356         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2357         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2358         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2359         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2360         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2361         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2362         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2363         * TestWebKitAPI/TestsController.cpp:
2364         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2365         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2366         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2367         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2368         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2369         * TestWebKitAPI/win/main.cpp:
2370
2371 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2372
2373         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2374         https://bugs.webkit.org/show_bug.cgi?id=68145
2375
2376         This will allow for other classes in DumpRenderTree to reuse this functionality
2377
2378         Reviewed by David Levin.
2379
2380         * DumpRenderTree/chromium/TestShell.cpp:
2381         (normalizeLayoutTestURLInternal):
2382         (dumpHistoryItem):
2383         (TestShell::normalizeLayoutTestURL):
2384         * DumpRenderTree/chromium/TestShell.h:
2385
2386 2011-09-14  Ada Chan  <adachan@apple.com>
2387
2388         Add test for WKBundleFrameCopyWebArchive().
2389         https://bugs.webkit.org/show_bug.cgi?id=67857
2390
2391         Reviewed by Anders Carlsson.
2392
2393         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2394         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2395         the returned data is a valid webarchive.
2396         (TestWebKitAPI::setInjectedBundleClient):
2397         (TestWebKitAPI::didFinishLoadForFrame):
2398         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2399         injected bundle for the webarchive and check the returned webarchive.
2400         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2401         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2402         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2403         the web archive.
2404
2405         Add files to project.
2406         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2407         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2409
2410 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2411
2412         committers.py should support multiple IRC nicknames
2413         https://bugs.webkit.org/show_bug.cgi?id=68110
2414
2415         Reviewed by Eric Seidel.
2416
2417         Add multiple IRC nickname support to committers.py
2418
2419         * Scripts/webkitpy/common/config/committers.py:
2420         * Scripts/webkitpy/common/config/committers_unittest.py:
2421         * Scripts/webkitpy/tool/bot/irc_command.py:
2422         * Scripts/webkitpy/tool/bot/sheriff.py:
2423
2424 2011-09-14  Jon Lee  <jonlee@apple.com>
2425
2426         Implement globalFlag for WebKitTestRunner
2427         https://bugs.webkit.org/show_bug.cgi?id=68033
2428         <rdar://problem/10119204>
2429
2430         Reviewed by Sam Weinig.
2431
2432         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2433         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2434         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2435         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2436         (WTR::LayoutTestController::globalFlag): simple getter
2437         (WTR::LayoutTestController::setGlobalFlag): simple setter
2438
2439 2011-09-13  Eric Seidel  <eric@webkit.org>
2440
2441         Remove ENABLE_SVG_USE as <use> is required by HTML5
2442         https://bugs.webkit.org/show_bug.cgi?id=68019
2443
2444         Reviewed by Ryosuke Niwa.
2445
2446         * Scripts/build-webkit:
2447         * waf/build/settings.py:
2448
2449 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2450
2451         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2452         since I can't confirm acceptable his committership.
2453
2454         * Scripts/webkitpy/common/config/committers.py:
2455
2456 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2457
2458         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2459         https://bugs.webkit.org/show_bug.cgi?id=68066
2460
2461         Reviewed by Adam Barth.
2462
2463         * DumpRenderTree/chromium/WebViewHost.cpp:
2464         * DumpRenderTree/chromium/WebViewHost.h:
2465
2466 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2467
2468         committers.py is missing some contributors
2469         https://bugs.webkit.org/show_bug.cgi?id=68059
2470
2471         Reviewed by Adam Barth.
2472
2473         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
2474
2475         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
2476
2477         * Scripts/webkitpy/common/config/committers.py:
2478
2479 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2480
2481         Fix webkit python test after r95061.
2482
2483         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2484
2485 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
2486
2487         Add myself as a contributor. No review needed.
2488
2489         * Scripts/webkitpy/common/config/committers.py:
2490
2491 2011-09-13  Adam Barth  <abarth@webkit.org>
2492
2493         garden-o-matic has unfriendly error messages when the local server is not available
2494         https://bugs.webkit.org/show_bug.cgi?id=68042
2495
2496         Reviewed by Dimitri Glazkov.
2497
2498         This patch moves us from using alert to showing the error inline in the
2499         progress dialog.
2500
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2506
2507 2011-09-13  Adam Barth  <abarth@webkit.org>
2508
2509         FailureGrid in garden-o-matic should link to the builder's waterfall page
2510         https://bugs.webkit.org/show_bug.cgi?id=68036
2511
2512         Reviewed by Dimitri Glazkov.
2513
2514         One of the users in the user study thought the configurations names in
2515         the failure grid would link to the underlying bots.  That makes sense,
2516         so this patch adds the behavior.
2517
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2522
2523 2011-09-13  Adam Barth  <abarth@webkit.org>
2524
2525         garden-o-matic should be able to mark failures as expected
2526         https://bugs.webkit.org/show_bug.cgi?id=68027
2527
2528         Reviewed by Dimitri Glazkov.
2529
2530         All the back-end infrastructure exists for this operation.  This patch
2531         just adds some UI to the front-end and wires that UI up to the back
2532         end.  This exact UI will likely need some more polish, but this should
2533         be a reasonable first cut.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2540
2541 2011-09-13  Adam Barth  <abarth@webkit.org>
2542
2543         garden-o-matic should tell you about the progress of your rebaseline
2544         https://bugs.webkit.org/show_bug.cgi?id=67967
2545
2546         Reviewed by Dimitri Glazkov.
2547
2548         This patch adds ui.MessageBox, which is a light wrapper around jQuery
2549         UI's dialog widget.  We then use ui.MessageBox to show status messages
2550         about in-progress rebaselines.  As each baseline is downloaded, the
2551         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
2552
2553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2559
2560 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
2561
2562         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
2563         https://bugs.webkit.org/show_bug.cgi?id=68024
2564
2565         Reviewed by Gustavo Noronha Silva.
2566         
2567         Using g_list_count() and g_list_nth_data() together on a loop is
2568         inneficient since they're both O(n). Iterate over lists in a saner
2569         way.
2570
2571         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2572         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
2573         iterate on it using g_list_next(). Free the list after done with it.
2574         (dumpBackForwardListForWebView): Instead of appending (which is
2575         expensive in GLists) history items and then iterating from the tail
2576         of the itemsToPrint list, prepend items and walk forwards as usual.
2577         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
2578         remove the (unneeded) viewList variable.
2579
2580 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         Add Eric's IRC nick.
2583
2584         * Scripts/webkitpy/common/config/committers.py:
2585
2586 2011-09-13  Anders Carlsson  <andersca@apple.com>
2587
2588         Disable C++ exceptions when building with clang
2589         https://bugs.webkit.org/show_bug.cgi?id=68031
2590         <rdar://problem/9556880>
2591
2592         Reviewed by Mark Rowe.
2593
2594         * MiniBrowser/Configurations/Base.xcconfig:
2595         * TestWebKitAPI/Configurations/Base.xcconfig:
2596         * WebKitTestRunner/Configurations/Base.xcconfig:
2597
2598 2011-09-13  Ojan Vafai  <ojan@chromium.org>
2599
2600         [chromium] fix flakiness dashboard for chromium interactive tests
2601         https://bugs.webkit.org/show_bug.cgi?id=68029
2602
2603         Reviewed by Tony Chang.
2604
2605         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2606         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2607
2608 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2609
2610         Add Alice and Aryeh to the list of contributors.
2611
2612         * Scripts/webkitpy/common/config/committers.py:
2613
2614 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2615
2616         sheriffbot whois should also tell us email addresses
2617         https://bugs.webkit.org/show_bug.cgi?id=67975
2618
2619         Reviewed by Eric Seidel and David Levin.
2620
2621         Taught sheriffbot how to tell us contributor's email addresses.
2622
2623         * Scripts/webkitpy/tool/bot/irc_command.py:
2624         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2625
2626 2011-09-13  Eric Seidel  <eric@webkit.org>
2627
2628         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2629         https://bugs.webkit.org/show_bug.cgi?id=68018
2630
2631         Reviewed by Ryosuke Niwa.
2632
2633         * Scripts/build-webkit:
2634         * waf/build/settings.py:
2635
2636 2011-09-13  Chang Shu  <cshu@webkit.org>
2637
2638         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
2639         https://bugs.webkit.org/show_bug.cgi?id=57515
2640
2641         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
2642         TestController synchronously. The latter then sends simulated event to WebKit2 module,
2643         which is synchronous, too.
2644
2645         Reviewed by Darin Adler.
2646
2647         * WebKitTestRunner/EventSenderProxy.h: Added.
2648         (WTR::EventSenderProxy::EventSenderProxy):
2649         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2650         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2651         (WTR::EventSendingController::keyDown):
2652         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2653         * WebKitTestRunner/PlatformWebView.h:
2654         (WTR::PlatformWebView::platformWindow):
2655         * WebKitTestRunner/TestController.cpp:
2656         (WTR::TestController::TestController):
2657         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2658         * WebKitTestRunner/TestController.h:
2659         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2660         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
2661         (WTR::buildModifierFlags):
2662         (WTR::EventSenderProxy::keyDown):
2663
2664 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
2665
2666         [EFL] DRT: Add DumpRenderTreeEfl.h
2667         https://bugs.webkit.org/show_bug.cgi?id=63993
2668
2669         Reviewed by Eric Seidel.
2670         
2671         This header contains some global variables used by EFL's
2672         DumpRenderTree implementation.
2673
2674         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
2675         appropriate.
2676         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
2677
2678 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
2679
2680         [EFL] Send the right key names for PageUp and PageDown.
2681         https://bugs.webkit.org/show_bug.cgi?id=67044
2682
2683         Reviewed by Kenneth Rohde Christiansen.
2684
2685         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
2686         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
2687         However, EventSender was sending "Page_Up" and "Page_Down", so tests
2688         such as editing/input/page-up-down-scrolls.html were timing out due to
2689         the right key down events not being sent.
2690
2691         * DumpRenderTree/efl/EventSender.cpp:
2692         (keyPadNameFromJSValue):
2693         (keyNameFromJSValue):
2694
2695 2011-09-12  Eric Seidel  <eric@webkit.org>
2696
2697         sheriffbot whois is case sensitive
2698         https://bugs.webkit.org/show_bug.cgi?id=67972
2699
2700         Reviewed by Adam Barth.
2701
2702         I also fixed a typo in the "More than 5 contributors" message
2703         from my previous commit.
2704
2705         * Scripts/webkitpy/common/config/committers.py:
2706         * Scripts/webkitpy/common/config/committers_unittest.py:
2707         * Scripts/webkitpy/tool/bot/irc_command.py:
2708         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2709
2710 2011-09-12  Eric Seidel  <eric@webkit.org>
2711
2712         sheriffbot whois should be smarter
2713         https://bugs.webkit.org/show_bug.cgi?id=67971
2714
2715         Reviewed by Adam Barth.
2716
2717         This makes sheriffbot whois basically grep the committers list
2718         making it much easier to find a contributor by name.
2719
2720         Unfortunately the current unittests depend on the real committers.py
2721         file, so as we add more eric's to the project, this unittest result will
2722         change.  I think that's OK for now.  We'll fix it when it breaks.
2723
2724         * Scripts/webkitpy/common/config/committers.py:
2725         * Scripts/webkitpy/tool/bot/irc_command.py:
2726         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2727
2728 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2729
2730         Unreviewed, rolling out r94976.
2731         http://trac.webkit.org/changeset/94976
2732         https://bugs.webkit.org/show_bug.cgi?id=67953
2733
2734         Broke a bunch of security/load& tests (Requested by rniwa on
2735         #webkit).
2736
2737         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2738         (LayoutTestController::pathToLocalResource):
2739
2740 2011-09-12  Eric Seidel  <eric@webkit.org>
2741
2742         Rubber-stamped by Adam Barth.
2743
2744         Remove the "the tree is burning!" warning previously shown
2745         when landing patches.  It was a dream.  But it's just noise now.
2746
2747         Some bots will require a restart to notice the removal of the option
2748         so I've left the --ignore-builders option in for now.
2749
2750         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2751         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2752         * Scripts/webkitpy/tool/commands/download.py:
2753         * Scripts/webkitpy/tool/commands/download_unittest.py:
2754         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2755         * Scripts/webkitpy/tool/steps/__init__.py:
2756         * Scripts/webkitpy/tool/steps/commit.py:
2757         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
2758         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2759
2760 2011-09-12  Eric Seidel  <eric@webkit.org>
2761
2762         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2763         https://bugs.webkit.org/show_bug.cgi?id=65781
2764
2765         Reviewed by Ryosuke Niwa.
2766
2767         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
2768         to resolve the passed in url relative to the absolute url for the test.
2769
2770         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2771         (which resolves the path relative to the built location of the DRT executable)
2772         and we should move this new code into a shared location in a follow-up patch.
2773
2774         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2775         (LayoutTestController::pathToLocalResource):
2776
2777 2011-09-12  Eric Seidel  <eric@webkit.org>
2778
2779         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2780         https://bugs.webkit.org/show_bug.cgi?id=67530
2781
2782         Reviewed by Adam Barth.
2783
2784         I believe I've fixed the bug in the original patch which prompted the rollout.
2785         The previous patch was using the wrong deadline for the initial read,
2786         subtracting time.time() twice from the deadline value.
2787
2788         * Scripts/webkitpy/layout_tests/port/webkit.py:
2789         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2790
2791 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
2792
2793         [Qt][WK2] WebKitTestRunner does not produce crash logs
2794         https://bugs.webkit.org/show_bug.cgi?id=67714
2795
2796         Reviewed by Chang Shu.
2797
2798         Added a simple way of generating backtrace on crash
2799         to the web process. The implementation is similar what
2800         we have in DRT. It depends on GNU libc functionality
2801         so it is only enabled where we are running in such an environment.
2802
2803         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2804         (WTR::printBacktrace):
2805         (WTR::crashHandler):
2806         (WTR::InjectedBundle::platformInitialize):
2807
2808 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
2809
2810         Added my IRC nick to the committers file.
2811
2812         * Scripts/webkitpy/common/config/committers.py:
2813
2814 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
2815
2816         The executable allocator makes it difficult to free individual
2817         chunks of executable memory
2818         https://bugs.webkit.org/show_bug.cgi?id=66363
2819
2820         Reviewed by Oliver Hunt.
2821         
2822         Introduced a best-fit, balanced-tree based allocator. The allocator
2823         required a balanced tree that does not allocate memory and that
2824         permits the removal of individual nodes directly (as opposed to by
2825         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
2826         Changed all references to executable code to use a reference counted
2827         handle.
2828
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
2831         (TestWebKitAPI::TEST_F):
2832         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
2833         (TestWebKitAPI::Pair::findExact):
2834         (TestWebKitAPI::Pair::remove):
2835         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
2836         (TestWebKitAPI::Pair::assertFoundAndRemove):
2837         (TestWebKitAPI::Pair::assertEqual):
2838         (TestWebKitAPI::Pair::assertSameValuesForKey):
2839         (TestWebKitAPI::Pair::testDriver):
2840         (TestWebKitAPI::TEST_F):
2841
2842 2011-09-10  Andy Estes  <aestes@apple.com>
2843
2844         Move myself from committers_unable_to_review to reviewers_list.
2845
2846         * Scripts/webkitpy/common/config/committers.py:
2847
2848 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
2849
2850         [wx] Unreviewed build fix. MSW build fixes.
2851
2852         * DumpRenderTree/config.h:
2853         * waf/build/wxpresets.py:
2854
2855 2011-09-10  Andreas Kling  <kling@webkit.org>
2856
2857         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
2858         https://bugs.webkit.org/show_bug.cgi?id=59328
2859
2860         Reviewed by Kenneth Rohde Christiansen.
2861
2862         * MiniBrowser/mac/BrowserWindowController.m:
2863         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
2864
2865 2011-09-10  Adam Barth  <abarth@webkit.org>
2866
2867         Build fix for Android.  DumpRenderTree is a client of the WebKit API
2868         and does not have access to notImplemented().
2869
2870         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2871         (openStartupDialog):
2872
2873 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
2874
2875         Add a script to create a monolithic script-test
2876         https://bugs.webkit.org/show_bug.cgi?id=67747
2877
2878         Reviewed by Darin Adler.
2879
2880         * Scripts/make-new-script-test: Added.
2881
2882 2011-09-09  Luiz Agostini  <luiz@webkit.org>
2883
2884         Adding myself to the reviewers list.
2885
2886         * Scripts/webkitpy/common/config/committers.py:
2887
2888 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
2889
2890         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
2891         https://bugs.webkit.org/show_bug.cgi?id=67855
2892
2893         Reviewed by Dirk Pranke.
2894
2895         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
2896         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
2897
2898         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
2899
2900         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2901
2902 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
2903
2904         Add myself to committers.py
2905         https://bugs.webkit.org/show_bug.cgi?id=67853
2906
2907         Reviewed by Darin Adler.
2908
2909         * Scripts/webkitpy/common/config/committers.py:
2910
2911 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2912
2913         [Qt] Remove common.pri
2914         https://bugs.webkit.org/show_bug.cgi?id=67814
2915
2916         Reviewed by Andreas Kling.
2917
2918         * Tools.pro:
2919
2920 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2921
2922         [NRWT] the nrwt check httpd with --no-http option
2923         https://bugs.webkit.org/show_bug.cgi?id=67835
2924
2925         Reviewed by Tony Chang.
2926
2927         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2928         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2929
2930 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
2931
2932         [chromium] Implement DRT support for Android.
2933         https://bugs.webkit.org/show_bug.cgi?id=67590
2934
2935         Reviewed by Tony Chang.
2936
2937         Add 2 mechanism to make DRT interaction more robust on Android:
2938         - Send 'QUIT' to DRT to make it stop.
2939         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
2940         input commands before it starts.
2941         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
2942         and <clocale> for 'LC_ALL' to compile on Android.
2943
2944         Also change to use sigaction instead of signal for TestShellGtk.cpp,
2945         as signal() man page recommends using sigaction().
2946
2947         * DumpRenderTree/DumpRenderTree.gypi:
2948         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2949         (main):
2950         * DumpRenderTree/chromium/LayoutTestController.cpp:
2951         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
2952         (AlarmHandler):
2953         (TestShell::waitTestFinished):
2954         (platformInit):
2955         (openStartupDialog):
2956         (checkLayoutTestSystemDependencies):
2957         * DumpRenderTree/chromium/TestShellGtk.cpp:
2958         (AlarmHandler):
2959         (TestShell::waitTestFinished):
2960
2961 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
2962
2963         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
2964
2965         * waf/build/settings.py:
2966
2967 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2968
2969         Unreviewed, rolling out r94851.
2970         http://trac.webkit.org/changeset/94851
2971         https://bugs.webkit.org/show_bug.cgi?id=67847
2972
2973         It broke a webkitpy test (Requested by ossy on #webkit).
2974
2975         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2976
2977 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2978
2979         [NRWT] the nrwt check httpd with --no-http option
2980         https://bugs.webkit.org/show_bug.cgi?id=67835
2981
2982         Reviewed by Csaba Osztrogonác.
2983
2984         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2985
2986 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
2987
2988         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
2989         https://bugs.webkit.org/show_bug.cgi?id=67794
2990         <rdar://problem/9892024>
2991         
2992         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
2993
2994         Reviewed by Brady Eidson.
2995
2996         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
2997         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
2998         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
2999         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
3000             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
3001             didPerformServerRedirect.
3002
3003         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
3004         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
3005             our InjectedBundleTest.
3006         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
3007             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
3008             the request.
3009         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
3010
3011         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
3012         
3013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3014         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
3015         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
3016         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
3017
3018 2011-09-08  David Levin  <levin@chromium.org>
3019
3020         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
3021         https://bugs.webkit.org/show_bug.cgi?id=67797
3022
3023         Reviewed by Eric Seidel.
3024
3025         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
3026         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
3027
3028 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
3029
3030         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
3031         https://bugs.webkit.org/show_bug.cgi?id=67723
3032
3033         Reviewed by Adam Barth.
3034
3035         * DumpRenderTree/chromium/EventSender.h:
3036         * DumpRenderTree/chromium/LayoutTestController.cpp:
3037         (LayoutTestController::LayoutTestController):
3038         (LayoutTestController::enableFixedLayoutMode):
3039         (LayoutTestController::setFixedLayoutSize):
3040         * DumpRenderTree/chromium/LayoutTestController.h:
3041
3042 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
3043
3044         Add standalone script that filters the output of build-webkit to be more human-readable
3045         https://bugs.webkit.org/show_bug.cgi?id=44081
3046
3047         Reviewed by Daniel Bates.
3048
3049         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
3050         a build script (e.g. build-webkit) and it spits out a prettier version.
3051         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
3052         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
3053
3054 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
3055
3056         Add myself to committers.py                 
3057         https://bugs.webkit.org/show_bug.cgi?id=67696
3058
3059         Reviewed by Kent Tamura.
3060
3061         * Scripts/webkitpy/common/config/committers.py:
3062
3063 2011-09-07  Adam Barth  <abarth@webkit.org>
3064
3065         rebaseline button in garden-o-matic details view should work
3066         https://bugs.webkit.org/show_bug.cgi?id=67738
3067
3068         Reviewed by Dimitri Glazkov.
3069
3070         This patch wires up the rebaseline button in garden-o-matic results
3071         details view.  The button is current per-test, so there isn't a way to
3072         rebaseline individual bots.  This is a place to start.  If we decide we
3073         want per-bot rebaselining, we'll need to think of some better UI.
3074
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3079
3080 2011-09-07  Eric Seidel  <eric@webkit.org>
3081
3082         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
3083         https://bugs.webkit.org/show_bug.cgi?id=67737
3084
3085         Reviewed by Adam Barth.
3086
3087         I got a little over-eager when deprecating host.port_factory in the previous commit.
3088         Turns out that Host.port_factory was already the "modern" port/factory.py
3089         it was just the Module object.  I un-deprecated the variable, and changed it from
3090         being the module to being an actual PortFactory, passing it a host object.
3091         I also taught PortFactory how to set user/executive/filesystem in the kwargs
3092         when instantiating a new Port object.
3093         This magically fixed the test_rebaseline test, since its now no longer talking
3094         to the real filesystem.
3095
3096         * Scripts/webkitpy/common/host.py:
3097         * Scripts/webkitpy/layout_tests/port/factory.py:
3098         * Scripts/webkitpy/tool/commands/queries.py:
3099         * Scripts/webkitpy/tool/mocktool.py:
3100
3101 2011-09-07  Eric Seidel  <eric@webkit.org>
3102
3103         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
3104         https://bugs.webkit.org/show_bug.cgi?id=67734
3105
3106         Reviewed by Adam Barth.
3107
3108         Right now every place that creates a Port object has to be very careful
3109         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
3110         The correct fix is for port/factory.py (which creates most port objects)
3111         to know how to pass these in automatically.  However, currently all port/factory.py
3112         functions are free functions instead of being on an object.  This patch
3113         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
3114
3115         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
3116         pass along the proper scm/user/filesystem to the Port object.
3117
3118         * Scripts/webkitpy/common/host.py:
3119         * Scripts/webkitpy/layout_tests/port/factory.py:
3120         * Scripts/webkitpy/tool/commands/queries.py:
3121         * Scripts/webkitpy/tool/mocktool.py:
3122
3123 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3124
3125         Unreviewed, rolling out r94441.
3126         http://trac.webkit.org/changeset/94441
3127         https://bugs.webkit.org/show_bug.cgi?id=67731
3128
3129         "MacEWSes are backed up due to new machines not able to reach
3130         git.webkit.org.  Disabling tests for now" (Requested by
3131         eseidel2 on #webkit).
3132
3133         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3134
3135 2011-09-07  Elliot Poger  <epoger@google.com>
3136
3137         filter test_expectations properly for chromium-mac vs chromium-cg-mac
3138         https://bugs.webkit.org/show_bug.cgi?id=67324
3139
3140         Reviewed by Dirk Pranke.
3141
3142         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3143         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3144         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3145         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3146         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3147
3148 2011-09-07  Eric Boren  <borenet@gmail.com>
3149
3150         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3151         https://bugs.webkit.org/show_bug.cgi?id=66800
3152
3153         Reviewed by Darin Fisher.
3154
3155         * DumpRenderTree/chromium/EventSender.cpp:
3156         (EventSender::sendCurrentTouchEvent):
3157
3158 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
3159
3160         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3161         https://bugs.webkit.org/show_bug.cgi?id=67254
3162
3163         Reviewed by Csaba Osztrogonác.
3164
3165         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
3166         derived from the running location of DumpRenderTree binary.
3167
3168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3169         (LayoutTestController::pathToLocalResource):
3170         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
3171
3172 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3173
3174         REGRESSION(r94288) build-webkit doesn't work on Symbian
3175         https://bugs.webkit.org/show_bug.cgi?id=67706
3176
3177         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
3178         (buildQMakeProject):
3179
3180 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3181
3182         REGRESSION(r94288) build-webkit doesn't work on Windows
3183         https://bugs.webkit.org/show_bug.cgi?id=67646
3184
3185         Roll back r94655 with a small fix.
3186
3187         * Scripts/webkitdirs.pm:
3188         (buildQMakeProject):
3189
3190 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3191
3192         Unreviewed, rolling out r94635.
3193         http://trac.webkit.org/changeset/94635
3194         https://bugs.webkit.org/show_bug.cgi?id=67704
3195
3196         Linux Touch build is failing to compile this change.
3197         (Requested by loislo on #webkit).
3198
3199         * DumpRenderTree/chromium/EventSender.cpp:
3200         (EventSender::sendCurrentTouchEvent):
3201
3202 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3203
3204         Unreviewed, rolling out r94655.
3205         http://trac.webkit.org/changeset/94655
3206         https://bugs.webkit.org/show_bug.cgi?id=67703
3207
3208         It broke Leopard debug bot (Requested by ossy on #webkit).
3209
3210         * Scripts/webkitdirs.pm:
3211
3212 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3213
3214         REGRESSION(r94288) build-webkit doesn't work on Windows
3215         https://bugs.webkit.org/show_bug.cgi?id=67646
3216
3217         Reviewed by Csaba Osztrogonác.
3218
3219         * Scripts/webkitdirs.pm:
3220
3221 2011-09-06  Eric Boren  <borenet@gmail.com>
3222
3223         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3224         https://bugs.webkit.org/show_bug.cgi?id=66800
3225
3226         Reviewed by Darin Fisher.
3227
3228         * DumpRenderTree/chromium/EventSender.cpp:
3229         (EventSender::sendCurrentTouchEvent):
3230
3231 2011-09-06  Adam Barth  <abarth@webkit.org>
3232
3233         garden-o-matic details view should having working rebaseline and next/previous buttons
3234         https://bugs.webkit.org/show_bug.cgi?id=67659
3235
3236         Reviewed by Dimitri Glazkov.
3237
3238         This patch wires up basic back/forward buttons that let you traverse
3239         through the results we're examining in the details view.  This ended up
3240         being more code than I expected, but I wanted to keep all the state
3241         information in the DOM itself.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3246
3247 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
3248
3249         fix MockFileSystem.glob(), refactor filesystem tests
3250         https://bugs.webkit.org/show_bug.cgi?id=67462
3251
3252         Reviewed by Eric Seidel.
3253
3254         In debugging why my proposed change for MockFileSystem.glob()
3255         in bug 66228 didn't work, I stumbled across two real bugs
3256         that cancelled each other out for the unit tests. I fixed those
3257         (glob shouldn't recurse into subdirs, and we weren't populating
3258         self.dirs from self.files properly).
3259
3260         I have also created a "mixin" class for tests that can be shared
3261         between the real filesystem and the mock filesystem - MockFileSystem
3262         is being used enough it needs its own tests.
3263
3264         * Scripts/webkitpy/common/system/filesystem_mock.py:
3265         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
3266         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3267
3268 2011-09-06  Anders Carlsson  <andersca@apple.com>
3269
3270         Move NPAPI headers in bridge to plugins
3271         https://bugs.webkit.org/show_bug.cgi?id=67661
3272
3273         Update forwarding headers.
3274
3275         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3276         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3277
3278 2011-09-06  Tony Chang  <tony@chromium.org>
3279
3280         [chromium] Check in 'build' for compiled binaries first
3281         https://bugs.webkit.org/show_bug.cgi?id=67549
3282
3283         Reviewed by Dirk Pranke.
3284
3285         I'm working on moving the windows build output to a common location
3286         rather than relative to the sln file.  Because of that, we need to
3287         check those build locations first for DumpRenderTree.exe.
3288
3289         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3290
3291 2011-09-06  Adam Barth  <abarth@webkit.org>
3292
3293         Use a hierarchial structure for the garden-o-matic results view
3294         https://bugs.webkit.org/show_bug.cgi?id=67620
3295
3296         Reviewed by Dimitri Glazkov.
3297
3298         This patch re-organizes the results view to use a hierachial structure
3299         for selection.  At the top-level are sections for each test.  Expanding
3300         the test section shows a tab selector for builders.
3301
3302         This structure prepares us for wiring up various actions to this view.
3303
3304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3305         (.):
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3307         ():
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3309         (.):
3310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3312         (.results-view>.toolbar):
3313         (.results-view>.toolbar ul.actions):
3314         (.results-view>.toolbar ul.actions li):
3315         (.results-grid table):
3316         (.results-grid table td, .results-view table th):
3317         (.results-grid table th):
3318         (.results-grid .text-result):
3319         (.results-grid .image-result):
3320
3321 2011-09-06  Adam Barth  <abarth@webkit.org>
3322
3323         garden-o-matic's base.probe generates spam in the JavaScript console
3324         https://bugs.webkit.org/show_bug.cgi?id=67622
3325
3326         Reviewed by Dimitri Glazkov.
3327
3328         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
3329         instead of HTMLScriptElement to test whether results exist.  This
3330         reduces the console.log spam and saves bandwidth because we can use a
3331         HEAD request instead of a GET request.
3332
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3334
3335 2011-09-05  Adam Barth  <abarth@webkit.org>
3336
3337         Add a tab to garden-o-matic for viewing expected failures
3338         https://bugs.webkit.org/show_bug.cgi?id=67619
3339
3340         Reviewed by Dimitri Glazkov.
3341
3342         This patch adds a basic tab to garden-o-matic that shows all the tests
3343         failing on the bots, including the expected failures.  This patch
3344         mostly involves refactoring existing classes to allow new subclasses.
3345
3346         This view is useful for when gardeners mark tests as expected to fail
3347         and then rebaseline them later.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3356
3357 2011-09-05  Adam Barth  <abarth@webkit.org>
3358
3359         Fix global variable leak in garden-o-matic
3360         https://bugs.webkit.org/show_bug.cgi?id=67617
3361
3362         Reviewed by Dimitri Glazkov.
3363
3364         Caught by running the unit tests with noglobals turned on.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3367
3368 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3369
3370         [Qt][WK2] Add pixel test support
3371         https://bugs.webkit.org/show_bug.cgi?id=66283
3372
3373         Reviewed by Andreas Kling.
3374
3375         Implemented pixel result generation by reusing the logic
3376         that we have in DumpRenderTree.
3377         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3378         (WTR::dumpImage):
3379         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3380
3381 2011-09-04  Robin Dunn  <robin@alldunn.com>
3382
3383         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3384         https://bugs.webkit.org/show_bug.cgi?id=67577
3385
3386         Reviewed by Kevin Ollivier.
3387
3388         * waf/build/settings.py:
3389
3390 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3391
3392         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3393
3394         * waf/build/settings.py:
3395
3396 2011-09-03  Dan Bernstein  <mitz@apple.com>
3397
3398         32-bit build fix.
3399
3400         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3401         (TestWebKitAPI::Util::toSTD):
3402
3403 2011-09-03  Dan Bernstein  <mitz@apple.com>
3404
3405         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3406         https://bugs.webkit.org/show_bug.cgi?id=67559
3407
3408         Reviewed by Darin Adler.
3409
3410         * DumpRenderTree/mac/DumpRenderTree.mm:
3411         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3412         the call to it.
3413         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3415         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3416         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3417         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3418         (TestWebKitAPI::Util::toSTD): Added.
3419
3420 2011-09-03  Adam Barth  <abarth@webkit.org>
3421
3422         garden-o-matic results view should have a better results selector
3423         https://bugs.webkit.org/show_bug.cgi?id=67542
3424
3425         Reviewed by Dimitri Glazkov.
3426
3427         This patch adds a basic grid-based results selector to the results
3428         view.  Currently, this grid just shows how the tests fail on the
3429         various bots.  A future patch will let you select which failure to view
3430         and to mark the failures for rebaselining.
3431
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3434           - Add some more basic functions for manipulating dictionaries.
3435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3438
3439 2011-09-03  Adam Barth  <abarth@webkit.org>
3440
3441         garden-o-matic results view should show Actual and Expected results for text failures
3442         https://bugs.webkit.org/show_bug.cgi?id=67536
3443
3444         Reviewed by Eric Seidel.
3445
3446         In the past, we didn't show actual and expected text results (we just
3447         showed the diff) because we didn't have the awesome six-by-two results
3448         grid.  Now that we do, we can move show these results.
3449
3450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3452           - Fixed some typos that were preventing these unit tests from running.
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3454         (.):
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3456           - Report -actual.txt and -expected.txt as possible results URLs.
3457
3458 2011-09-03  Adam Barth  <abarth@webkit.org>
3459
3460         garden-o-matic shows "ghost" failures that are already fixed
3461         https://bugs.webkit.org/show_bug.cgi?id=67535
3462
3463         Reviewed by Eric Seidel.
3464
3465         About 10% of writes fail to stick on test-results.appspot.com.  This
3466         patch causes us to fetch the full_results.json blob directly from
3467         build.chromium.org rather than relying upon AppEngine.
3468
3469         Unforuntately, we still need to get historical information from
3470         AppEngine.  That will take several patches to fix becuase I need to
3471         change the bots to write the full_results.json file to the
3472         build-specific directory in addition to the zip file.
3473
3474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3477
3478 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3479
3480         Unreviewed, rolling out r94458.
3481         http://trac.webkit.org/changeset/94458
3482         https://bugs.webkit.org/show_bug.cgi?id=67558
3483
3484         Caused appcache test to fail on various bots (Requested by
3485         rniwa on #webkit).
3486
3487         * Scripts/webkitpy/layout_tests/port/webkit.py:
3488         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3489
3490 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3491
3492         Unreviewed, rolling out r94453.
3493         http://trac.webkit.org/changeset/94453
3494         https://bugs.webkit.org/show_bug.cgi?id=67557
3495
3496         Caused appcache test to fail on various bots (Requested by
3497         rniwa on #webkit).
3498
3499         * Scripts/webkitpy/layout_tests/port/webkit.py:
3500
3501 2011-09-02  Michael Saboff  <msaboff@apple.com>
3502
3503         Add JSC:RegExp functional tests
3504         https://bugs.webkit.org/show_bug.cgi?id=67339
3505
3506         New perl script to build JavaScriptCore and run the RegExp tests.
3507
3508         Reviewed by Gavin Barraclough.
3509
3510         * Scripts/run-regexp-tests: Added.
3511
3512 2011-09-02  Michael Saboff  <msaboff@apple.com>
3513
3514         Add JSC:RegExp functional tests
3515         https://bugs.webkit.org/show_bug.cgi?id=67339
3516
3517         New perl script to build JavaScriptCore and run the RegExp tests.
3518
3519         Reviewed by Gavin Barraclough.
3520
3521         * Scripts/run-regexp-tests: Added.
3522
3523 2011-09-02  Eric Seidel  <eric@webkit.org>
3524
3525         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3526         https://bugs.webkit.org/show_bug.cgi?id=67530
3527
3528         Unreviewed.  Fixing typo from previous commit.
3529
3530         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
3531         which exercises the code I previously made a typo in.
3532
3533         * Scripts/webkitpy/layout_tests/port/webkit.py:
3534         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3535
3536 2011-09-02  Eric Seidel  <eric@webkit.org>
3537
3538         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3539         https://bugs.webkit.org/show_bug.cgi?id=67530
3540
3541         Reviewed by Adam Barth.
3542
3543         No functional change, just reshuffling code.
3544
3545         * Scripts/webkitpy/layout_tests/port/webkit.py:
3546
3547 2011-09-02  Darin Adler  <darin@apple.com>
3548
3549         Added Subversion ignore for .pyc generated files.
3550
3551         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
3552         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
3553         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
3554
3555 2011-09-02  Adam Barth  <abarth@webkit.org>
3556
3557         Enable testing on mac-ews
3558         https://bugs.webkit.org/show_bug.cgi?id=67505
3559
3560         Reviewed by Eric Seidel.
3561
3562         This patch enables testing on the Mac EWS, which should help
3563         contributors not turn the Mac bots red.
3564
3565         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3566
3567 2011-09-01  Beth Dakin  <bdakin@apple.com>
3568
3569         https://bugs.webkit.org/show_bug.cgi?id=67451
3570         Add a test for going back to a cached page after changing the device scale factor
3571
3572         Reviewed by Adam Roben.
3573
3574         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
3575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3576         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
3577         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3578         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
3579         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3580         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
3581         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3582         (TestWebKitAPI::TEST_F):
3583
3584         Added new function to WebKitAgnosticTest to goBack. Separated 
3585         waitForLoadToFinish() into its own function (instead of being a part of 
3586         loadAndWaitUntilFinished()) so that it can be called from goBack as 
3587         well. Also added initializeView() so we can set the cache model.
3588         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
3589         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
3590         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3591         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
3592         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3593         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3594         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
3595         (TestWebKitAPI::WebKitAgnosticTest::goBack):
3596         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
3597
3598 2011-09-02  Anders Carlsson  <andersca@apple.com>
3599
3600         Build fix.
3601
3602         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
3603         (PrivateBrowsing::ScriptableObject::pluginTest):
3604
3605 2011-09-02  Anders Carlsson  <andersca@apple.com>
3606
3607         Move private browsing test to a PluginTest subclass
3608         https://bugs.webkit.org/show_bug.cgi?id=67498
3609
3610         Reviewed by Darin Adler.
3611
3612         * DumpRenderTree/DumpRenderTree.gypi:
3613         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3614         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3615         (pluginGetProperty):
3616         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3617         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3618         (PluginTest::NPP_SetValue):
3619         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3620         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
3621         (PrivateBrowsing::PrivateBrowsing):
3622         (PrivateBrowsing::privateBrowsingEnabled):
3623         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
3624         (PrivateBrowsing::ScriptableObject::hasProperty):
3625         (PrivateBrowsing::ScriptableObject::getProperty):
3626         (PrivateBrowsing::ScriptableObject::pluginTest):
3627         (PrivateBrowsing::NPP_New):
3628         (PrivateBrowsing::NPP_GetValue):
3629         (PrivateBrowsing::NPP_SetValue):
3630         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3631         (NPP_New):
3632         (NPP_SetValue):
3633         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3634         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3635         * GNUmakefile.am:
3636
3637 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
3638
3639         [Qt] Build dependency problems
3640         https://bugs.webkit.org/show_bug.cgi?id=38054
3641
3642         Trivial fix after r94288.
3643
3644         Rubber-stamped by Andras Becsi.
3645
3646         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
3647         (buildQMakeProject):
3648
3649 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
3650
3651         Remove my old e-mail address and add my new one.
3652
3653         Rubber-stamped by Tor Arne Vestbø.
3654
3655         * Scripts/webkitpy/common/config/committers.py:
3656
3657 2011-09-02  Philippe Normand  <pnormand@igalia.com>
3658
3659         [GTK] run-gtk-tests leaves a zombie Xvfb process
3660         https://bugs.webkit.org/show_bug.cgi?id=67389
3661
3662         Reviewed by Martin Robinson.
3663
3664         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
3665         child process instead of doing shell redirection.
3666
3667 2011-09-01  Mark Rowe  <mrowe@apple.com>
3668
3669         Fix the build by adding some more missing return types.
3670
3671         *&nbs