ae0e0288504685e6f61cadde4bccc9b17b222ef9
[WebKit-https.git] / Tools / ChangeLog
1 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
2
3         [GTK] Move user style sheet API out of WebKitWebViewGroup
4         https://bugs.webkit.org/show_bug.cgi?id=134551
5
6         Reviewed by Carlos Garcia Campos.
7
8         Removes testing user style sheet injection from
9         TestWebKitWebViewGroup and moves that into a new
10         TestWebKitUserContentManager, adapting the existing tests to the new
11         API. Also, it contains a new test case for
12         webkit_web_view_new_with_user_content_manager().
13
14         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
15         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
16         (UserContentManagerTest::UserContentManagerTest):
17         (testWebViewNewWithUserContentManager):
18         (isStyleSheetInjectedForURLAtPath):
19         (fillURLListFromPaths):
20         (removeOldInjectedStyleSheetsAndResetLists):
21         (testUserContentManagerInjectedStyleSheet):
22         (serverCallback):
23         (beforeAll):
24         (afterAll):
25         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
26         (beforeAll):
27         (afterAll):
28         (isStyleSheetInjectedForURLAtPath): Deleted.
29         (fillURLListFromPaths): Deleted.
30         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
31         (testWebViewGroupInjectedStyleSheet): Deleted.
32         (serverCallback): Deleted.
33         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
34         (WebViewTest::WebViewTest):
35         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
36
37 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
38
39         [GTK] Gstreamer missing from the install-dependencies script
40         https://bugs.webkit.org/show_bug.cgi?id=134727
41
42         Reviewed by Mario Sanchez Prada.
43
44         Added missing gstreamer dependencies for debian based systems.
45
46         * gtk/install-dependencies: Added 2 dependencies for apt-get.
47
48 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
49
50         Add myself to the watchlist for text-related files
51         https://bugs.webkit.org/show_bug.cgi?id=134707
52
53         Reviewed by Timothy Horton.
54
55         * Scripts/webkitpy/common/config/watchlist:
56
57 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
58
59         Add option to specify output file location in sunspider.
60         https://bugs.webkit.org/show_bug.cgi?id=134339
61
62         Reviewed by Darin Adler.
63
64         * Scripts/run-sunspider:
65
66 2014-07-07  Alex Christensen  <achristensen@webkit.org>
67
68         Unreviewed build fix.
69
70         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
71         Make Common.cpp excluded from both 32-bit and 64-bit builds.
72
73 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
74
75         Have MiniBrowser log and reload if the Web Content Process crashes
76         https://bugs.webkit.org/show_bug.cgi?id=134691
77
78         Reviewed by Tim Horton.
79         
80         Implement _webViewWebProcessDidCrash, log and reload when the web process
81         crashes.
82
83         * MiniBrowser/mac/WK2BrowserWindowController.m:
84         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
85
86 2014-07-07  Alberto Garcia  <berto@igalia.com>
87
88         update-webkitgtk-libs script fails by unsatisfied dependencies
89         https://bugs.webkit.org/show_bug.cgi?id=134547
90
91         Reviewed by Martin Robinson.
92
93         Install libxcb-xfixes0-dev, needed to build Mesa.
94
95         * gtk/install-dependencies:
96
97 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
98
99         Turn on img@sizes compile flag
100         https://bugs.webkit.org/show_bug.cgi?id=134634
101
102         Reviewed by Benjamin Poulain.
103
104         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
105
106 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
107
108         Unreviewed. Adding myself to committers.
109
110         * Scripts/webkitpy/common/config/contributors.json:
111
112 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
113
114         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
115         https://bugs.webkit.org/show_bug.cgi?id=134648
116
117         Reviewed by Gyuyoung Kim.
118
119         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
120
121         * efl/install-dependencies:
122
123 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
124
125         [EFL] Support Geolocation
126         https://bugs.webkit.org/show_bug.cgi?id=134439
127
128         Reviewed by Antonio Gomes.
129
130         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
131
132 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
133
134         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
135         https://bugs.webkit.org/show_bug.cgi?id=134485
136
137         Reviewed by Gyuyoung Kim.
138
139         Use script_execute_callback to get selected/highlighted text and show in search bar.
140
141         * MiniBrowser/efl/main.c:
142         (script_execute_callback):
143         (on_key_down):
144
145 2014-07-04  Dan Bernstein  <mitz@apple.com>
146
147         Build fix after r170811.
148
149         * MiniBrowser/mac/WK2BrowserWindowController.m:
150         (-[WK2BrowserWindowController reload:]):
151
152 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
153
154         Typo in watchlist config means four specific people get Cc'd on everything
155         https://bugs.webkit.org/show_bug.cgi?id=134626
156
157         Reviewed by Gyuyoung Kim.
158
159         * Scripts/webkitpy/common/config/watchlist:
160         Remove leading pipe, which meant that this rule matched everything!
161
162 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
163
164         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
165         https://bugs.webkit.org/show_bug.cgi?id=134486
166
167         Reviewed by Gyuyoung Kim.
168
169         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
170
171         * MiniBrowser/efl/main.c:
172         (search_box_show):
173         (search_box_hide):
174         (on_search_close_button_clicked):
175         (on_search_text_found):
176         (window_create):
177
178 2014-07-03  Daniel Bates  <dabates@apple.com>
179
180         Add WTF::move()
181         https://bugs.webkit.org/show_bug.cgi?id=134500
182
183         Rubber-stamped by Anders Carlsson.
184
185         Substitute WTF::move() for std::move().
186
187         * DumpRenderTree/win/DRTDataObject.cpp:
188         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
189         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
190         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
191         * TestWebKitAPI/Tests/WTF/Vector.cpp:
192         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
193         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
194         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
195         ConstructionFromSameType, and ConstructionFromSimilarType.
196         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
197
198 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
199
200         [JavaScriptCore] Add --cmakeargs option to build-jsc.
201         https://bugs.webkit.org/show_bug.cgi?id=134590
202
203         Reviewed by Ryosuke Niwa.
204
205         * Scripts/build-jsc:
206
207 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
208
209         Add option to specify jsc args in run-sunspider.
210         https://bugs.webkit.org/show_bug.cgi?id=134341
211
212         Reviewed by Csaba Osztrogonác.
213
214         * Scripts/run-sunspider:
215
216 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
217
218         [GTK] Unreviewed gardening.
219
220         * Scripts/run-gtk-tests:
221         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
222
223 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
224
225         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
226         https://bugs.webkit.org/show_bug.cgi?id=134581
227
228         Reviewed by Tim Horton.
229
230         Should be removed unused EFL bot info.
231
232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
234         (EWS):
235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
236         (WebKitBuildbot):
237         * TestResultServer/static-dashboards/builders.jsonp:
238         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
239         (test):
240
241 2014-07-02  Alex Christensen  <achristensen@webkit.org>
242
243         Unreviewed.  Moved self to reviewers list.
244
245         * Scripts/webkitpy/common/config/contributors.json:
246         Moved self to reviewers list, added WebGL to expertise.
247
248 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
249
250         [GTK] Make dist only works when run from the source directory
251         https://bugs.webkit.org/show_bug.cgi?id=134543
252
253         Reviewed by Martin Robinson.
254
255         Since the paths in the manifest are relative to the source dir,
256         and the script expects the current working directory to be the
257         source directory, resolve all passed in relative paths while
258         parsing the arguments and then change the current working
259         directory.
260
261         * gtk/make-dist.py:
262
263 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
264
265         [GTK] make dist is broken
266         https://bugs.webkit.org/show_bug.cgi?id=134542
267
268         Reviewed by Martin Robinson.
269
270         * gtk/make-dist.py: Rename command line options to match what cmake uses.
271         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
272
273 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
274
275         [GTK] WebKitWebView::create should receive information about the navigation action
276         https://bugs.webkit.org/show_bug.cgi?id=133680
277
278         Reviewed by Martin Robinson.
279
280         Add unit test to check the WebKitNavigationAction passed to
281         WebKitWebView::create callback.
282
283         * MiniBrowser/gtk/BrowserWindow.c:
284         (webViewCreate): Add WebKitNavigationAction parameter.
285         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
286         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
287         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
288         (testWebViewCreateNavigationData):
289         (beforeAll):
290         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
291         (createCallback):
292
293 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
294
295         [GTK] Do not add forward declaration of class struct for interfaces
296         https://bugs.webkit.org/show_bug.cgi?id=134297
297
298         Reviewed by Martin Robinson.
299
300         Add Iface symbol to documentation instead of Class for interfaces.
301
302         * gtk/webkitdom.py:
303         (WebKitDOMDocGeneratorSections.write_section):
304
305 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
306
307         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
308         https://bugs.webkit.org/show_bug.cgi?id=134028
309
310         Reviewed by Gustavo Noronha Silva.
311
312         Add unit tests to check WebKitDOMXPathNSResolver API when using the
313         native one and a user provided one.
314
315         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
316         to the list of GTK+ public API exceptions.
317         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
318         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
319         (webkitXPathNSResolverLookupNamespaceURI):
320         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
321         (webkit_xpath_ns_resolver_init):
322         (webkit_xpath_ns_resolver_class_init):
323         (WebKitDOMXPathNSResolverTest::create):
324         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
325         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
326         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
327         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
328         (WebKitDOMXPathNSResolverTest::runTest):
329         (registerTests):
330         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
331         (runTest):
332         (testWebKitDOMXPathNSResolverNative):
333         (testWebKitDOMXPathNSResolverCustom):
334         (serverCallback):
335         (beforeAll):
336         (afterAll):
337         * gtk/webkitdom.py:
338         (WebKitDOMDocGeneratorSections.write_section): Add
339         WebKitDOMXPathNSResolver to the list of interfaces.
340
341 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
342
343         Fix build break on EFL and GTK ports since r170683
344         https://bugs.webkit.org/show_bug.cgi?id=134536
345
346         Unreviewed, build fix.
347
348         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
349
350 2014-07-01  Sam Weinig  <sam@webkit.org>
351
352         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
353         <rdar://problem/17523159>
354         https://bugs.webkit.org/show_bug.cgi?id=134496
355
356         Reviewed by Beth Dakin.
357
358         * MiniBrowser/mac/BrowserWindowController.m:
359         (-[BrowserWindowController windowDidLoad]):
360         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
361
362 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
363
364         [CMake] Add necessary support for building for the Wayland target
365         https://bugs.webkit.org/show_bug.cgi?id=134160
366
367         Reviewed by Darin Adler.
368
369         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
370         the X11 windowing target is enabled.
371
372 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
373
374         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
375         https://bugs.webkit.org/show_bug.cgi?id=134492
376
377         Reviewed by Andreas Kling.
378
379         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
380         (AccessibilityUIElement::isIndeterminate):
381         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
382         (WTR::AccessibilityUIElement::isIndeterminate):
383
384 2014-07-01  Daniel Bates  <dabates@apple.com>
385
386         Remove unnecessary calls to std::move()
387         https://bugs.webkit.org/show_bug.cgi?id=134493
388
389         Reviewed by Anders Carlsson.
390
391         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
392         (TestWebKitAPI::TEST):
393         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
394         (TestWebKitAPI::TEST):
395
396 2014-07-01  Pratik Solanki  <psolanki@apple.com>
397
398         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
399
400         * Scripts/webkitpy/common/config/contributors.json:
401
402 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
403
404         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
405         https://bugs.webkit.org/show_bug.cgi?id=40095
406
407         Reviewed by Csaba Osztrogonác.
408
409         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
410         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
411         (Bugzilla):
412         (Bugzilla.bug_id_for_attachment_id): ditto.
413
414 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
415
416         [webkitpy] Refactor pluralizer in grammar.py
417         https://bugs.webkit.org/show_bug.cgi?id=133067
418
419         Reviewed by Csaba Osztrogonác.
420
421         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
422         (LayoutTestRunner.run_tests):
423         * Scripts/webkitpy/layout_tests/controllers/manager.py:
424         (Manager.run):
425         * Scripts/webkitpy/layout_tests/views/printing.py:
426         (Printer.print_found):
427         (Printer.print_workers_and_shards):
428         (Printer._print_one_line_summary):
429         * Scripts/webkitpy/test/printer.py:
430         (Printer.print_result):
431         * Scripts/webkitpy/tool/bot/feeders.py:
432         (EWSFeeder.feed):
433         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
434         (FlakyTestReporter._lookup_bug_for_flaky_test):
435         * Scripts/webkitpy/tool/bot/irc_command.py:
436         (Rollout._check_diff_failure):
437         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
438         (IRCCommandTest.test_rollout):
439         * Scripts/webkitpy/tool/commands/download.py:
440         (AbstractPatchProcessingCommand._process_patch.execute):
441         (ProcessBugsMixin._fetch_list_of_patches_to_process):
442         (ProcessURLsMixin._fetch_list_of_patches_to_process):
443         * Scripts/webkitpy/tool/commands/queries.py:
444         (WhatBroke.execute):
445         * Scripts/webkitpy/tool/commands/suggestnominations.py:
446         (SuggestNominations._print_nominations):
447         (SuggestNominations._print_counts):
448         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
449         (_make_options):
450         (test_basic):
451         (test_with_verbose):
452         * Scripts/webkitpy/tool/commands/upload.py:
453         (PostCommits.execute):
454         * Scripts/webkitpy/tool/grammar.py:
455         (pluralize):
456         * Scripts/webkitpy/tool/grammar_unittest.py:
457         (GrammarTest.test_join_with_separators):
458         (GrammarTest):
459         (GrammarTest.test_plural):
460         (GrammarTest.test_pluralize):
461         * Scripts/webkitpy/tool/multicommandtool.py:
462         (Command.check_arguments_and_execute):
463         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
464         (ObsoletePatches.run):
465         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
466         (PrepareChangeLogForRevert._message_for_revert):
467
468 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
469
470         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
471         https://bugs.webkit.org/show_bug.cgi?id=134133
472
473         Reviewed by Simon Fraser.
474
475         Replace it with CTFontManagerRegisterGraphicsFont
476
477         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
478         * DumpRenderTree/mac/DumpRenderTree.mm:
479         (activateFontIOS):
480
481 2014-06-30  Michael Saboff  <msaboff@apple.com>
482
483         Add option to run-jsc-stress-testes to filter out tests that use large heaps
484         https://bugs.webkit.org/show_bug.cgi?id=134458
485
486         Reviewed by Filip Pizlo.
487
488         Added new --memory-limited to filter out tests that have large heap usage.
489         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
490
491         * Scripts/run-jsc-stress-tests:
492
493 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
494
495         DRT in iOS sim crashes while loading fonts
496         https://bugs.webkit.org/show_bug.cgi?id=134451
497
498         Reviewed by Geoffrey Garen.
499
500         The magic linker symbols had the same name, and were therefore being unified
501         to a single font file. Then, adding the same file twice was failing.
502
503         * DumpRenderTree/mac/DumpRenderTree.mm:
504         (activateFontsIOS):
505
506 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
507
508         Remove Qt cruft from webkitpy
509         https://bugs.webkit.org/show_bug.cgi?id=134445
510
511         Reviewed by Csaba Osztrogonác.
512
513         * Scripts/webkitpy/common/config/ports.py:
514         (DeprecatedPort.port):
515         (QtPort): Deleted.
516         (QtPort.build_webkit_command): Deleted.
517         (QtPort.run_webkit_tests_command): Deleted.
518         (QtWK2Port): Deleted.
519         (QtWK2Port.build_webkit_command): Deleted.
520         (QtWK2Port.run_webkit_tests_command): Deleted.
521         * Scripts/webkitpy/common/config/ports_unittest.py:
522         (DeprecatedPortTest): Deleted.
523         (DeprecatedPortTest.test_qt_port): Deleted.
524         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
525
526 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
527
528         Add support for HTMLImageElement's sizes attribute
529         https://bugs.webkit.org/show_bug.cgi?id=133620
530
531         Reviewed by Dean Jackson.
532
533         Added an ENABLE_PICTURE_SIZES compile flag.
534
535         * Scripts/webkitperl/FeatureList.pm:
536
537 2014-06-27  Tim Horton  <timothy_horton@apple.com>
538
539         check-webkit-style should check the order of #imports as well as #includes
540         https://bugs.webkit.org/show_bug.cgi?id=134428
541
542         Reviewed by Dan Bernstein.
543
544         * Scripts/webkitpy/style/checkers/cpp.py:
545         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
546
547 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
548
549         [EFL] Remove efl-wk2 from baseline search path
550         https://bugs.webkit.org/show_bug.cgi?id=134391
551
552         Reviewed by Gyuyoung Kim.
553
554         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
555         are merged efl-wk2 search path should be removed.
556
557         * Scripts/webkitpy/port/base.py:
558         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
559         * Scripts/webkitpy/port/efl.py:
560         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
561         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
562         * Scripts/webkitpy/port/port_testcase.py:
563         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
564         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
565         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
566         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
567         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
568
569 2014-06-26  Dan Bernstein  <mitz@apple.com>
570
571         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
572         https://bugs.webkit.org/show_bug.cgi?id=134387
573
574         Reviewed by Tim Horton.
575
576         * Scripts/prepare-ChangeLog:
577         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
578
579 2014-06-26  Dan Bernstein  <mitz@apple.com>
580
581         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
582         https://bugs.webkit.org/show_bug.cgi?id=134383
583
584         Reviewed by Tim Horton.
585
586         * Scripts/prepare-ChangeLog:
587         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
588         colons.
589
590 2014-06-26  Brady Eidson  <beidson@apple.com>
591
592         MiniBrowser should support a preference to override the default URL
593         https://bugs.webkit.org/show_bug.cgi?id=134373
594
595         Reviewed by Darin Adler.
596
597         * MiniBrowser/mac/AppDelegate.m:
598         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
599           overriding the default URL, and use it if there is.
600
601 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
602
603         [Win] Fix potential buffer overrun in DLLLauncher
604         https://bugs.webkit.org/show_bug.cgi?id=134351
605         <rdar://problem/17469185>
606
607         Reviewed by Darin Adler.
608
609         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
610         in end-of-buffer calculation.
611
612 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
613
614         [EFL] Missing dependency between freetype6 and fontconfig libs.
615         https://bugs.webkit.org/show_bug.cgi?id=134190
616
617         Reviewed by Gyuyoung Kim.
618
619         The external dependencies contain the freetype6 and the fontconfig libs.
620         The fontconfig lib requires freetype, but the dependency is not set in
621         the efl/jhbuild.modules file. So, during building the external libs,
622         fontconfig uses the freetype package of the system, while WebKit
623         binaries will use freetype from the WebKitBuild/Dependency directory.
624         There are more similar dependencies that were not indicated in the
625         jhbuild.modules file.
626
627         * efl/jhbuild.modules:
628           Added dependencies between libs.
629
630 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
631
632         [Win] Expose Cache Information to WinLauncher
633         https://bugs.webkit.org/show_bug.cgi?id=134318
634
635         Reviewed by Dean Jackson.
636
637         * WinLauncher/Common.cpp: Update for new dialog.
638         * WinLauncher/WinLauncher.cpp: Add support for WebCache
639         and WebCoreStatistics.
640         * WinLauncher/WinLauncher.h:
641         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
642         Update for new Cache Dialog.
643         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
644         WTF.lib
645         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
646         for new Dialog.
647
648 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
649
650         [Win] Unreviewed gardening. Use consistent line-endings in file.
651
652         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
653         '\r\n' EOL.
654
655 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
656
657         [JavaScriptCore] Make build-jsc output format better.
658         https://bugs.webkit.org/show_bug.cgi?id=133547
659
660         Reviewed by Ryosuke Niwa.
661
662         * Scripts/build-jsc: Emit built time information on successful builds.
663         (writeCongrats):
664         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
665         (cMakeArgsFromFeatures):
666         (formatBuildTime): Deleted.
667         * Scripts/webkitdirs.pm:
668         (formatBuildTime):
669
670 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
671
672         Add an undo group for each dictated utterance in WebKit
673         https://bugs.webkit.org/show_bug.cgi?id=134086
674
675         Reviewed by Enrica Casucci.
676
677         Create a method for creating attributed strings with the undo insertion marker.
678
679         * DumpRenderTree/mac/TextInputController.m:
680         (+[TextInputController isSelectorExcludedFromWebScript:]):
681         (+[TextInputController webScriptNameForSelector:]):
682         (-[TextInputController stringWithUndoGroupingInsertion:]):
683
684 2014-06-25  Michael Saboff  <msaboff@apple.com>
685
686         Provide javascript aware backtrace script for lldb
687         https://bugs.webkit.org/show_bug.cgi?id=134276
688
689         Reviewed by Jer Noble.
690
691         * lldb/lldb_webkit.py:
692         (__lldb_init_module):
693         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
694
695 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
696
697         REGRESSION (r170426) Broke two python tests
698         https://bugs.webkit.org/show_bug.cgi?id=134299
699
700         Reviewed by Csaba Osztrogonác.
701
702         * Scripts/webkitpy/port/efl.py:
703         (EflPort._search_paths): Added search path for efl-wk2.
704
705 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
706
707         [EFL] Remove WebKit1 related code from scripts
708         https://bugs.webkit.org/show_bug.cgi?id=134195
709
710         Reviewed by Laszlo Gombos.
711
712         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree, 
713         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
714
715         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
716         * Scripts/webkitdirs.pm:
717         (builtDylibPathForName): Remove reference to libewebkit.so
718         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
719         (_set_up_derived_options): Script runs WKTR by default.
720         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
721         (PerfTestsRunner.__init__): Ditto.
722         * Scripts/webkitpy/port/efl.py:
723         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
724         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
725
726 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
727
728         Remove build guard for progress element
729         https://bugs.webkit.org/show_bug.cgi?id=134292
730
731         Reviewed by Benjamin Poulain.
732
733         * Scripts/webkitperl/FeatureList.pm:
734
735 2014-06-24  Tomas Popela  <tpopela@redhat.com>
736
737         [GTK] Some of DOM bindings macros are misnamed
738         https://bugs.webkit.org/show_bug.cgi?id=121543
739
740         Reviewed by Carlos Garcia Campos.
741
742         As we are using WebKitDOM as a namespace we should unify all type macros
743         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
744         more exceptions to decamelize function in GObject bindings generator
745         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
746
747         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
748         * gtk/webkitdom.py:
749         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
750         (WebKitDOMDocGeneratorSections.write_section):
751
752 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
753
754         [EFL] Install Latin Modern Math on the bots
755         https://bugs.webkit.org/show_bug.cgi?id=134153
756
757         Reviewed by Gyuyoung Kim.
758
759         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
760
761 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
762
763         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
764         https://bugs.webkit.org/show_bug.cgi?id=134153
765
766         Reviewed by Martin Robinson.
767
768         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
769         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
770
771 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
772
773         Unreviewed, update my speciality.
774
775         * Scripts/webkitpy/common/config/contributors.json:
776
777 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
778
779         [Win] Clean up and refactor WinLauncher
780         https://bugs.webkit.org/show_bug.cgi?id=134209
781
782         Reviewed by Tim Thorton.
783
784         Relanding r170339 and r170340 with correct WinLauncher.h file.
785
786         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
787         (PrintView):
788         (ToggleMenuItem):
789         (WndProc):
790         (BackButtonProc):
791         (ForwardButtonProc):
792         (loadURL):
793         (shouldUseFullDesktop): Deleted.
794         (SimpleEventListener::SimpleEventListener): Deleted.
795         (SimpleEventListener::handleEvent): Deleted.
796         (WinLauncherWebHost::updateAddressBar): Deleted.
797         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
798         (WinLauncherWebHost::QueryInterface): Deleted.
799         (WinLauncherWebHost::AddRef): Deleted.
800         (WinLauncherWebHost::Release): Deleted.
801         (updateMenuItemForHistoryItem): Deleted.
802         (showLastVisitedSites): Deleted.
803         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
804         (resizeSubViews): Deleted.
805         (setToDefaultPreferences): Deleted.
806         (wWinMain): Deleted.
807         (MyRegisterClass): Deleted.
808         (LaunchInspector): Deleted.
809         (NavigateForwardOrBackward): Deleted.
810         (NavigateToHistory): Deleted.
811         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
812         (DOMEventListener::Release):
813         (WebScriptObject::WebScriptObject): Deleted.
814         (WebScriptObject::~WebScriptObject): Deleted.
815         (WebScriptObject::throwException): Deleted.
816         (WebScriptObject::callWebScriptMethod): Deleted.
817         (WebScriptObject::evaluateWebScript): Deleted.
818         (WebScriptObject::removeWebScriptKey): Deleted.
819         (WebScriptObject::stringRepresentation): Deleted.
820         (WebScriptObject::webScriptValueAtIndex): Deleted.
821         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
822         (WebScriptObject::setException): Deleted.
823         (DOMEventListener::throwException): Deleted.
824         (DOMEventListener::callWebScriptMethod): Deleted.
825         (DOMEventListener::evaluateWebScript): Deleted.
826         (DOMEventListener::removeWebScriptKey): Deleted.
827         (DOMEventListener::stringRepresentation): Deleted.
828         (DOMEventListener::webScriptValueAtIndex): Deleted.
829         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
830         (DOMEventListener::setException): Deleted.
831         (DOMEventListener::handleEvent): Deleted.
832         * WinLauncher/DOMDefaultImpl.h:
833         (WebScriptObject::QueryInterface): Deleted.
834         (WebScriptObject::AddRef): Deleted.
835         (WebScriptObject::Release): Deleted.
836         (DOMObject::QueryInterface): Deleted.
837         (DOMEventListener::QueryInterface): Deleted.
838         (DOMEventListener::AddRef): Deleted.
839         (DOMEventListener::Release): Deleted.
840         * WinLauncher/WinLauncher.cpp:
841         (WinLauncher::WinLauncher):
842         (WinLauncher::init):
843         (WinLauncher::prepareViews):
844         (WinLauncher::setFrameLoadDelegate):
845         (WinLauncher::setUIDelegate):
846         (WinLauncher::setAccessibilityDelegate):
847         (WinLauncher::mainFrame):
848         (WinLauncher::seedInitialDefaultPreferences):
849         (WinLauncher::setToDefaultPreferences):
850         (updateMenuItemForHistoryItem):
851         (WinLauncher::showLastVisitedSites):
852         (WinLauncher::launchInspector):
853         (WinLauncher::navigateForwardOrBackward):
854         (WinLauncher::navigateToHistory):
855         (WinLauncher::goBack):
856         (WinLauncher::goForward):
857         (WinLauncher::loadURL):
858         (shouldUseFullDesktop): Deleted.
859         (SimpleEventListener::SimpleEventListener): Deleted.
860         (SimpleEventListener::handleEvent): Deleted.
861         (WinLauncherWebHost::updateAddressBar): Deleted.
862         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
863         (WinLauncherWebHost::QueryInterface): Deleted.
864         (WinLauncherWebHost::AddRef): Deleted.
865         (WinLauncherWebHost::Release): Deleted.
866         (showLastVisitedSites): Deleted.
867         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
868         (resizeSubViews): Deleted.
869         (subclassForLayeredWindow): Deleted.
870         (computeFullDesktopFrame): Deleted.
871         (DllMain): Deleted.
872         (getAppDataFolder): Deleted.
873         (setToDefaultPreferences): Deleted.
874         (setCacheFolder): Deleted.
875         (createCrashReport): Deleted.
876         (wWinMain): Deleted.
877         (MyRegisterClass): Deleted.
878         (AbortProc): Deleted.
879         (getPrinterDC): Deleted.
880         (initDocStruct): Deleted.
881         (PrintView): Deleted.
882         (ToggleMenuItem): Deleted.
883         (LaunchInspector): Deleted.
884         (NavigateForwardOrBackward): Deleted.
885         (NavigateToHistory): Deleted.
886         (WndProc): Deleted.
887         (EditProc): Deleted.
888         (BackButtonProc): Deleted.
889         (ForwardButtonProc): Deleted.
890         (About): Deleted.
891         (loadURL): Deleted.
892         (dllLauncherEntryPoint): Deleted.
893         * WinLauncher/WinLauncher.h:
894         (WinLauncher::standardPreferences):
895         (WinLauncher::privatePreferences):
896         (WinLauncher::hasWebView):
897         (WinLauncher::usesLayeredWebView):
898         (WinLauncherWebHost::WinLauncherWebHost): Deleted.
899         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
900         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
901         (WinLauncherWebHost::didCommitLoadForFrame): Deleted.
902         (WinLauncherWebHost::didReceiveTitle): Deleted.
903         (WinLauncherWebHost::didChangeIcons): Deleted.
904         (WinLauncherWebHost::didReceiveIcon): Deleted.
905         (WinLauncherWebHost::didFailLoadWithError): Deleted.
906         (WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
907         (WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
908         (WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
909         (WinLauncherWebHost::willCloseFrame): Deleted.
910         (WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
911         (WinLauncherWebHost::didClearWindowObject): Deleted.
912         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
913         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
914         * WinLauncher/WinLauncherReplace.h:
915         (processCrashReport):
916         * WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
917         (WinLauncherWebHost::updateAddressBar):
918         (WinLauncherWebHost::QueryInterface):
919         (WinLauncherWebHost::AddRef):
920         (WinLauncherWebHost::Release):
921         (WinLauncherWebHost::didFinishLoadForFrame):
922         (shouldUseFullDesktop): Deleted.
923         (updateMenuItemForHistoryItem): Deleted.
924         (showLastVisitedSites): Deleted.
925         (resizeSubViews): Deleted.
926         (subclassForLayeredWindow): Deleted.
927         (computeFullDesktopFrame): Deleted.
928         (DllMain): Deleted.
929         (getAppDataFolder): Deleted.
930         (setToDefaultPreferences): Deleted.
931         (setCacheFolder): Deleted.
932         (createCrashReport): Deleted.
933         (wWinMain): Deleted.
934         (MyRegisterClass): Deleted.
935         (AbortProc): Deleted.
936         (getPrinterDC): Deleted.
937         (initDocStruct): Deleted.
938         (PrintView): Deleted.
939         (ToggleMenuItem): Deleted.
940         (LaunchInspector): Deleted.
941         (NavigateForwardOrBackward): Deleted.
942         (NavigateToHistory): Deleted.
943         (WndProc): Deleted.
944         (EditProc): Deleted.
945         (BackButtonProc): Deleted.
946         (ForwardButtonProc): Deleted.
947         (About): Deleted.
948         (loadURL): Deleted.
949         (dllLauncherEntryPoint): Deleted.
950         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
951         (WinLauncherWebHost::WinLauncherWebHost):
952         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
953         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
954         (WinLauncherWebHost::didCommitLoadForFrame):
955         (WinLauncherWebHost::didReceiveTitle):
956         (WinLauncherWebHost::didChangeIcons):
957         (WinLauncherWebHost::didReceiveIcon):
958         (WinLauncherWebHost::didFailLoadWithError):
959         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
960         (WinLauncherWebHost::willPerformClientRedirectToURL):
961         (WinLauncherWebHost::didCancelClientRedirectForFrame):
962         (WinLauncherWebHost::willCloseFrame):
963         (WinLauncherWebHost::windowScriptObjectAvailable):
964         (WinLauncherWebHost::didClearWindowObject):
965         * WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
966         (wWinMain):
967         (MyRegisterClass):
968         (shouldUseFullDesktop): Deleted.
969         (SimpleEventListener::SimpleEventListener): Deleted.
970         (SimpleEventListener::handleEvent): Deleted.
971         (WinLauncherWebHost::updateAddressBar): Deleted.
972         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
973         (WinLauncherWebHost::QueryInterface): Deleted.
974         (WinLauncherWebHost::AddRef): Deleted.
975         (WinLauncherWebHost::Release): Deleted.
976         (updateMenuItemForHistoryItem): Deleted.
977         (showLastVisitedSites): Deleted.
978         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
979         (resizeSubViews): Deleted.
980         (subclassForLayeredWindow): Deleted.
981         (computeFullDesktopFrame): Deleted.
982         (DllMain): Deleted.
983         (getAppDataFolder): Deleted.
984         (setToDefaultPreferences): Deleted.
985         (setCacheFolder): Deleted.
986         (createCrashReport): Deleted.
987         (AbortProc): Deleted.
988         (getPrinterDC): Deleted.
989         (initDocStruct): Deleted.
990         (PrintView): Deleted.
991         (ToggleMenuItem): Deleted.
992         (LaunchInspector): Deleted.
993         (NavigateForwardOrBackward): Deleted.
994         (NavigateToHistory): Deleted.
995         (WndProc): Deleted.
996         (EditProc): Deleted.
997         (BackButtonProc): Deleted.
998         (ForwardButtonProc): Deleted.
999         (About): Deleted.
1000         (loadURL): Deleted.
1001         (dllLauncherEntryPoint): Deleted.
1002
1003 2014-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1004
1005         [iOS] getsectdata() is deprecated and we use it in DRT
1006         https://bugs.webkit.org/show_bug.cgi?id=134122
1007
1008         Reviewed by Alexey Proskuryakov.
1009
1010         Migrate to using magic linker symbols.
1011
1012         No tests because there should be no behavior change
1013
1014         * DumpRenderTree/mac/DumpRenderTree.mm:
1015         (activateFontsIOS):
1016
1017 2014-06-24  Javier Fernandez  <jfernandez@igalia.com>
1018
1019         Name moving. Unreviewed.
1020
1021         * Scripts/webkitpy/common/config/contributors.json:
1022
1023 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1024
1025         Remove EFL WK1 watch category
1026         https://bugs.webkit.org/show_bug.cgi?id=134231
1027
1028         Reviewed by Csaba Osztrogonác.
1029
1030         * Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
1031
1032 2014-06-24  Krzysztof Czech  <k.czech@samsung.com>
1033
1034         [ATK] Remove some unused code from DumpRenderTree
1035         https://bugs.webkit.org/show_bug.cgi?id=134191
1036
1037         Reviewed by Chris Fleizach.
1038
1039         DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
1040
1041         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
1042         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
1043         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
1044         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
1045         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
1046         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
1047
1048 2014-06-23  Shivakumar JM  <shiva.jm@samsung.com>
1049
1050         [EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
1051         https://bugs.webkit.org/show_bug.cgi?id=134025
1052
1053         Reviewed by Gyuyoung Kim.
1054
1055         Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
1056
1057         * MiniBrowser/efl/main.c:
1058         (window_create):
1059
1060 2014-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
1061
1062         [EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
1063         https://bugs.webkit.org/show_bug.cgi?id=134236
1064
1065         Reviewed by Gyuyoung Kim.
1066
1067         * ImageDiff/efl/ImageDiff.cpp:
1068         (calculateDifference):
1069         (printImageDifferences):
1070         (readImageFromStdin):
1071         (main):
1072
1073 2014-06-23  Daniel Bates  <dabates@apple.com>
1074
1075         Rolling out r170340 and r170339.
1076
1077         Changeset r170339 broke the Apple Windows Debug and Release builds.
1078
1079         Reverted changesets:
1080
1081         "[Win] Build fix after r134209"
1082         http://trac.webkit.org/changeset/170340
1083
1084         "[Win] Clean up and refactor WinLauncher"
1085         https://bugs.webkit.org/show_bug.cgi?id=134209
1086         http://trac.webkit.org/changeset/170339
1087
1088 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
1089
1090         [Win] Build fix after r134209
1091
1092         * WinLauncher/WinMain.cpp: Must include the resources file
1093         before Common.cpp.
1094
1095 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
1096
1097         [Win] Clean up and refactor WinLauncher
1098         https://bugs.webkit.org/show_bug.cgi?id=134209
1099
1100         Reviewed by Tim Horton.
1101
1102         Make WinLauncher a class, and move all non-class driver functions
1103         into "Common.cpp" and "WinMain.cpp". These files are distinct
1104         to allow some internal tools to reuse the code in 'Common'.
1105
1106         * WinLauncher/Common.cpp: Added. Consists of code moved from
1107         'WinLauncher.cpp' that can be reused for other tools.
1108         (subclassForLayeredWindow):
1109         (computeFullDesktopFrame):
1110         (DllMain):
1111         (getAppDataFolder):
1112         (setCacheFolder):
1113         (createCrashReport):
1114         (AbortProc):
1115         (getPrinterDC):
1116         (initDocStruct):
1117         (PrintView):
1118         (ToggleMenuItem):
1119         (WndProc):
1120         (EditProc):
1121         (BackButtonProc):
1122         (ForwardButtonProc):
1123         (About):
1124         (loadURL):
1125         (dllLauncherEntryPoint):
1126         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
1127         (DOMEventListener::Release):
1128         (WebScriptObject::WebScriptObject): Deleted.
1129         (WebScriptObject::~WebScriptObject): Deleted.
1130         (WebScriptObject::throwException): Deleted.
1131         (WebScriptObject::callWebScriptMethod): Deleted.
1132         (WebScriptObject::evaluateWebScript): Deleted.
1133         (WebScriptObject::removeWebScriptKey): Deleted.
1134         (WebScriptObject::stringRepresentation): Deleted.
1135         (WebScriptObject::webScriptValueAtIndex): Deleted.
1136         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
1137         (WebScriptObject::setException): Deleted.
1138         (DOMEventListener::throwException): Deleted.
1139         (DOMEventListener::callWebScriptMethod): Deleted.
1140         (DOMEventListener::evaluateWebScript): Deleted.
1141         (DOMEventListener::removeWebScriptKey): Deleted.
1142         (DOMEventListener::stringRepresentation): Deleted.
1143         (DOMEventListener::webScriptValueAtIndex): Deleted.
1144         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
1145         (DOMEventListener::setException): Deleted.
1146         (DOMEventListener::handleEvent): Deleted.
1147         * WinLauncher/DOMDefaultImpl.h:
1148         (WebScriptObject::QueryInterface): Deleted.
1149         (WebScriptObject::AddRef): Deleted.
1150         (WebScriptObject::Release): Deleted.
1151         (DOMObject::QueryInterface): Deleted.
1152         (DOMEventListener::QueryInterface): Deleted.
1153         (DOMEventListener::AddRef): Deleted.
1154         (DOMEventListener::Release): Deleted.
1155         * WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
1156         into a C++ class and removed WinAPI code.
1157         (WinLauncher::WinLauncher):
1158         (WinLauncher::init):
1159         (WinLauncher::prepareViews):
1160         (WinLauncher::setFrameLoadDelegate):
1161         (WinLauncher::setUIDelegate):
1162         (WinLauncher::setAccessibilityDelegate):
1163         (WinLauncher::mainFrame):
1164         (WinLauncher::seedInitialDefaultPreferences):
1165         (WinLauncher::setToDefaultPreferences):
1166         (updateMenuItemForHistoryItem):
1167         (WinLauncher::showLastVisitedSites):
1168         (WinLauncher::launchInspector):
1169         (WinLauncher::navigateForwardOrBackward):
1170         (WinLauncher::navigateToHistory):
1171         (WinLauncher::goBack):
1172         (WinLauncher::goForward):
1173         (WinLauncher::loadURL):
1174         (shouldUseFullDesktop): Deleted.
1175         (SimpleEventListener::SimpleEventListener): Deleted.
1176         (SimpleEventListener::handleEvent): Deleted.
1177         (WinLauncherWebHost::updateAddressBar): Deleted.
1178         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1179         (WinLauncherWebHost::QueryInterface): Deleted.
1180         (WinLauncherWebHost::AddRef): Deleted.
1181         (WinLauncherWebHost::Release): Deleted.
1182         (showLastVisitedSites): Deleted.
1183         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1184         (resizeSubViews): Deleted.
1185         (subclassForLayeredWindow): Deleted.
1186         (computeFullDesktopFrame): Deleted.
1187         (DllMain): Deleted.
1188         (getAppDataFolder): Deleted.
1189         (setToDefaultPreferences): Deleted.
1190         (setCacheFolder): Deleted.
1191         (createCrashReport): Deleted.
1192         (wWinMain): Deleted.
1193         (MyRegisterClass): Deleted.
1194         (AbortProc): Deleted.
1195         (getPrinterDC): Deleted.
1196         (initDocStruct): Deleted.
1197         (PrintView): Deleted.
1198         (ToggleMenuItem): Deleted.
1199         (LaunchInspector): Deleted.
1200         (NavigateForwardOrBackward): Deleted.
1201         (NavigateToHistory): Deleted.
1202         (WndProc): Deleted.
1203         (EditProc): Deleted.
1204         (BackButtonProc): Deleted.
1205         (ForwardButtonProc): Deleted.
1206         (About): Deleted.
1207         (loadURL): Deleted.
1208         (dllLauncherEntryPoint): Deleted.
1209         * WinLauncher/WinLauncher.h: Removed.
1210         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1211         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1212         * WinLauncher/WinLauncherReplace.h:
1213         (processCrashReport):
1214         * WinLauncher/WinLauncherWebHost.cpp: Added.
1215         (SimpleEventListener::SimpleEventListener):
1216         (SimpleEventListener::handleEvent):
1217         (WinLauncherWebHost::updateAddressBar):
1218         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1219         (WinLauncherWebHost::QueryInterface):
1220         (WinLauncherWebHost::AddRef):
1221         (WinLauncherWebHost::Release):
1222         (WinLauncherWebHost::didFinishLoadForFrame):
1223         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
1224         Moved WinLauncherWebHost implementation from WinLauncher.cpp into
1225         its own set of files.
1226         (WinLauncherWebHost::WinLauncherWebHost):
1227         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1228         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1229         (WinLauncherWebHost::didCommitLoadForFrame):
1230         (WinLauncherWebHost::didReceiveTitle):
1231         (WinLauncherWebHost::didChangeIcons):
1232         (WinLauncherWebHost::didReceiveIcon):
1233         (WinLauncherWebHost::didFailLoadWithError):
1234         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1235         (WinLauncherWebHost::willPerformClientRedirectToURL):
1236         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1237         (WinLauncherWebHost::willCloseFrame):
1238         (WinLauncherWebHost::windowScriptObjectAvailable):
1239         (WinLauncherWebHost::didClearWindowObject):
1240         * WinLauncher/WinMain.cpp: Added. This consists of code from
1241         WinLauncher that is unique to the WinLauncher utility, and is
1242         not part of the WinLauncher class.
1243         (wWinMain):
1244         (MyRegisterClass):
1245
1246 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
1247
1248         Enable the Web Inspector in MiniBrowser
1249         https://bugs.webkit.org/show_bug.cgi?id=134148
1250
1251         Reviewed by Joseph Pecoraro.
1252         
1253         Set the pref to enable Web Inspector in both WK1 and WK2 windows.
1254
1255         * MiniBrowser/mac/AppDelegate.m:
1256         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1257
1258 2014-06-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1259
1260         Disable gamepad feature on EFL and GTK ports by default
1261         https://bugs.webkit.org/show_bug.cgi?id=134169
1262
1263         Reviewed by Brady Eidson.
1264
1265         EFL and GTK ports disabled Gamepad feature now. Besides current implementation
1266         was treated to 'deprecated' status.
1267
1268         ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
1269
1270         * Scripts/webkitperl/FeatureList.pm:
1271
1272 2014-06-21  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1273
1274         [Inspector][EFL] Can't resume a special break point on EFL inspector
1275         https://bugs.webkit.org/show_bug.cgi?id=129294
1276
1277         Reviewed by Gyuyoung Kim.
1278
1279         Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
1280         by Ryuan Choi - <https://phab.enlightenment.org/D790>
1281
1282         * efl/jhbuild.modules:
1283         * efl/patches/ecore.patch: Added.
1284
1285 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1286
1287         Removing PAGE_VISIBILITY_API compile guard.
1288         https://bugs.webkit.org/show_bug.cgi?id=133844
1289
1290         Reviewed by Gavin Barraclough.
1291
1292         * Scripts/webkitperl/FeatureList.pm:
1293
1294 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
1295
1296         [EFL] Remove DumpRenderTree/efl and EWebLauncher
1297         https://bugs.webkit.org/show_bug.cgi?id=134138
1298
1299         Reviewed by Gyuyoung Kim.
1300
1301         DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
1302
1303         * CMakeLists.txt:
1304         * DumpRenderTree/PlatformEfl.cmake: Removed.
1305         * DumpRenderTree/efl: Removed entire directory.
1306         * EWebLauncher: Ditto.
1307         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
1308         (buildPath):
1309         (getCoreFontFiles):
1310         (addFontDirectory):
1311         (addFontFiles):
1312         (getCustomBuildDir):
1313         (getPlatformFontsPath):
1314         (addFontsToEnvironment):
1315         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
1316         * WebKitTestRunner/PlatformEfl.cmake:
1317
1318 2014-06-20  Zalan Bujtas  <zalan@apple.com>
1319
1320         Name moving. Unreviewed.
1321
1322         * Scripts/webkitpy/common/config/contributors.json:
1323
1324 2014-06-20  Javier Fernandez  <jfernandez@igalia.com>
1325
1326         Unreviewed. Adding myself to committers.
1327
1328         * Scripts/webkitpy/common/config/contributors.json:
1329
1330 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
1331
1332         Unreviewed. Adding myself to committers.
1333
1334         * Scripts/webkitpy/common/config/contributors.json:
1335
1336 2014-06-20  Tim Horton  <timothy_horton@apple.com>
1337
1338         Make WebKit2 more accessible in MiniBrowser
1339         https://bugs.webkit.org/show_bug.cgi?id=134099
1340
1341         Reviewed by Anders Carlsson.
1342
1343         * MiniBrowser/mac/AppDelegate.h:
1344         * MiniBrowser/mac/AppDelegate.m:
1345         (-[BrowserAppDelegate newWindow:]):
1346         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1347         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
1348         (-[BrowserAppDelegate _useWebKit2ByDefault]):
1349         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1350         (-[BrowserAppDelegate validateMenuItem:]):
1351         * MiniBrowser/mac/MainMenu.xib:
1352         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
1353         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
1354         Make the non-default new-window menu item always show up, because people often don't find it
1355         when you have to press option to have it show up.
1356
1357         * MiniBrowser/mac/BrowserWindowController.h:
1358         * MiniBrowser/mac/BrowserWindowController.m:
1359         (-[BrowserWindowController initWithWindow:]):
1360         
1361         * MiniBrowser/mac/WK1BrowserWindowController.m:
1362         (-[WK1BrowserWindowController validateMenuItem:]):
1363         * MiniBrowser/mac/WK2BrowserWindowController.m:
1364         (-[WK2BrowserWindowController validateMenuItem:]):
1365         Use the cached [menuItem action] like the earlier cases do.
1366
1367 2014-06-20  Daniel Bates  <dabates@apple.com>
1368
1369         Teach run-{safari, webkit-app} about iOS Simulator
1370         https://bugs.webkit.org/show_bug.cgi?id=133986
1371
1372         Reviewed by David Kilzer.
1373
1374         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
1375         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
1376         and run-safari.
1377
1378         * Scripts/old-run-webkit-tests:
1379         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
1380         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
1381         to call it.
1382         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
1383         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
1384         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
1385         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
1386         when the iOS device SDK is used as we don't support launching an app on the device at this time.
1387         * Scripts/webkitdirs.pm:
1388         (xcodeSDKVersion): Added.
1389         (setupIOSWebKitEnvironment): Added.
1390         (installedMobileSafariBundle): Added.
1391         (mobileSafariBundle): Added.
1392         (plistPathFromBundle): Added.
1393         (appIdentiferFromBundle): Added.
1394         (appDisplayNameFromBundle): Added.
1395         (loadIPhoneSimulatorNotificationIfNeeded): Added.
1396         (openIOSSimulator): Added.
1397         (quitIOSSimulator): Added.
1398         (iosSimulatorDeviceByName): Added.
1399         (iosSimulatorRuntime): Added.
1400         (findOrCreateSimulatorForIOSDevice): Added.
1401         (runIOSWebKitAppInSimulator): Added.
1402         (installAndLaunchIOSWebKitAppInSimulator): Added.
1403         (runIOSWebKitApp): Added.
1404         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
1405         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
1406         device at this time.
1407
1408 2014-06-19  Anders Carlsson  <andersca@apple.com>
1409
1410         Add WTF::Optional class
1411         https://bugs.webkit.org/show_bug.cgi?id=134083
1412
1413         Reviewed by Andreas Kling.
1414
1415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1416         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
1417         (TestWebKitAPI::TEST):
1418
1419 2014-06-20  Ion Rosca  <rosca@adobe.com>
1420
1421         Unreviewed. Adding myself to Committers list.
1422
1423         * Scripts/webkitpy/common/config/contributors.json:
1424
1425 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1426
1427         [EFL] Add gstreamer as dependecy of EFL after r169785
1428         https://bugs.webkit.org/show_bug.cgi?id=134066
1429
1430         Reviewed by Gyuyoung Kim.
1431
1432         * efl/jhbuild.modules:
1433
1434 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
1435
1436         [EFL] Merge url_utils.c to MiniBrowser
1437         https://bugs.webkit.org/show_bug.cgi?id=134095
1438
1439         Reviewed by Csaba Osztrogonác.
1440
1441         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
1442         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
1443
1444         * MiniBrowser/efl/CMakeLists.txt:
1445         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
1446         * MiniBrowser/efl/main.c:
1447         (has_scheme): Copied from url_utils.c
1448         (url_from_user_input): Ditto.
1449
1450 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1451
1452         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
1453
1454         Reviewed by Csaba Osztrogonác.
1455
1456         * Scripts/webkitpy/common/config/ports_unittest.py:
1457         (DeprecatedPortTest.test_gtk_wk2_port):
1458         (DeprecatedPortTest.test_efl_port): Deleted.
1459         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1460         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1461         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1462         (TestRebaselineExpectations.test_rebaseline_expectations):
1463
1464 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
1465
1466         [EFL][CMAKE] Disable WebKit1 build as a default
1467         https://bugs.webkit.org/show_bug.cgi?id=134093
1468
1469         Reviewed by Gyuyoung Kim.
1470
1471         * CMakeLists.txt:
1472
1473 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1474
1475         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
1476         https://bugs.webkit.org/show_bug.cgi?id=93002
1477
1478         Reviewed by Gustavo Noronha Silva.
1479
1480         Add unit tests to check WebKitDOMNodefilter API used from both
1481         TreeWalker and NodeIterator.
1482
1483         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
1484         public headers and add WebKitDOMNodeFilter to the list of exceptions.
1485         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
1486         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
1487         (webkitNodeFilterAcceptNode):
1488         (webkitNodeFilterDOMNodeFilterIfaceInit):
1489         (webkit_node_filter_init):
1490         (webkit_node_filter_class_init):
1491         (WebKitDOMNodeFilterTest::create):
1492         (WebKitDOMNodeFilterTest::webPageFromArgs):
1493         (WebKitDOMNodeFilterTest::testTreeWalker):
1494         (WebKitDOMNodeFilterTest::testNodeIterator):
1495         (WebKitDOMNodeFilterTest::runTest):
1496         (registerTests):
1497         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
1498         (runTest):
1499         (testWebKitDOMNodeFilterTreeWalker):
1500         (testWebKitDOMNodeFilterNodeIterator):
1501         (beforeAll):
1502         (afterAll):
1503         * gtk/webkitdom.py:
1504         (WebKitDOMDocGeneratorSections.__init__):
1505         (WebKitDOMDocGeneratorSections._symbol_list):
1506         (WebKitDOMDocGeneratorSections.write_section):
1507
1508 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1509
1510         [GTK] Limit the amount of API exposed to GObject DOM bindings API
1511         https://bugs.webkit.org/show_bug.cgi?id=133726
1512
1513         Reviewed by Gustavo Noronha Silva.
1514
1515         Don't make fatal finding files without a .symbols file, since now
1516         only the stable DOM API has .symbols files.
1517
1518         * gtk/webkitdom.py:
1519         (get_all_webkitdom_symbol_files):
1520
1521 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1522
1523         Remove efl wk1 buildbot and ews
1524         https://bugs.webkit.org/show_bug.cgi?id=134089
1525
1526         Reviewed by Benjamin Poulain.
1527
1528         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/config.json:
1531         * QueueStatusServer/config/queues.py:
1532         * Scripts/webkitpy/common/config/ews.json:
1533         * Scripts/webkitpy/common/config/ports.py:
1534         (DeprecatedPort.port):
1535         (QtWK2Port.run_webkit_tests_command):
1536         (EflPort): Deleted.
1537         (EflPort.build_webkit_command): Deleted.
1538         * Scripts/webkitpy/port/builders.py:
1539         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1540         * TestResultServer/static-dashboards/loader_unittests.js:
1541
1542 2014-06-19  David Kilzer  <ddkilzer@apple.com>
1543
1544         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
1545         <http://webkit.org/b/134061>
1546
1547         Reviewed by Dan Bernstein.
1548
1549         * Scripts/webkitpy/style/checkers/cpp.py:
1550         (check_spacing): Ignore '@' immediately before '{'.
1551         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1552         (CppStyleTest.test_spacing_before_braces): Add unit test for
1553         '^{' block syntax and '@{' Objective-C liternal NSDitionary
1554         syntax.
1555
1556 2014-06-18  Tim Horton  <timothy_horton@apple.com>
1557
1558         All of MiniBrowser's WKWebViews should share a configuration
1559         https://bugs.webkit.org/show_bug.cgi?id=134017
1560
1561         Reviewed by Anders Carlsson.
1562
1563         * MiniBrowser/mac/WK2BrowserWindowController.m:
1564         (-[WK2BrowserWindowController awakeFromNib]):
1565         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
1566         This means that they'll share things like preferences, visited links, etc.
1567         It also means that we'll properly share processes once we hit the process limit.
1568
1569 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
1570
1571         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
1572         https://bugs.webkit.org/show_bug.cgi?id=133971
1573
1574         Reviewed by Martin Robinson.
1575
1576         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
1577         building for the Wayland target. The latest 3.12 version is required to match
1578         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
1579         as well due to GTK+ depending on a newer version.
1580
1581 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
1582
1583         [EFL] Turn on NOSNIFF in FeatureList.pm
1584         https://bugs.webkit.org/show_bug.cgi?id=134010
1585
1586         Reviewed by Csaba Osztrogonác.
1587
1588         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
1589
1590         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
1591
1592 2014-06-17  Tim Horton  <timothy_horton@apple.com>
1593
1594         MiniBrowser should show Web Content process pids in the window title
1595         https://bugs.webkit.org/show_bug.cgi?id=134016
1596
1597         Reviewed by Sam Weinig.
1598
1599         * MiniBrowser/mac/WK2BrowserWindowController.m:
1600         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1601
1602 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1603
1604         [GTK] Fix the handling of resize events after r169505.
1605         https://bugs.webkit.org/show_bug.cgi?id=133517
1606
1607         Reviewed by Martin Robinson.
1608
1609         * Scripts/webkitpy/port/xvfbdriver.py:
1610         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
1611         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
1612         need at least 900x640 pixels to pass.
1613         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1614         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
1615         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
1616         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
1617         (XvfbDriverTest.test_start_next_worker): Update resolution.
1618         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1619         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
1620         be requested over the main widget instead of the window.
1621         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
1622         the Mac port.
1623         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
1624         (WTR::PlatformWebView::setWindowFrame): Set the size and position
1625         of the Window and the web view.
1626
1627 2014-06-17  Matthew Mirman <mmirman@apple.com>
1628
1629         Unreviewed. Added myself to list of contributors.
1630
1631         * Scripts/webkitpy/common/config/contributors.json: Added myself.
1632
1633 2014-06-17  Commit Queue  <commit-queue@webkit.org>
1634
1635         Unreviewed, rolling out r170058.
1636         https://bugs.webkit.org/show_bug.cgi?id=133993
1637
1638         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
1639         on #webkit).
1640
1641         Reverted changeset:
1642
1643         "[GTK] Fix the handling of resize events after r169505."
1644         https://bugs.webkit.org/show_bug.cgi?id=133517
1645         http://trac.webkit.org/changeset/170058
1646
1647 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
1648
1649         Update import-w3c-tests to reflect current W3C test repo directory structure
1650         https://bugs.webkit.org/show_bug.cgi?id=133460
1651
1652         Reviewed by Bem Jones-Bey.
1653
1654         Removed all references to test status, which are no longer reflected in the
1655         directory names in the W3C CSS test repo.  No tests are required for this 
1656         change, the existing tests pass.
1657
1658         * Scripts/webkitpy/w3c/test_importer.py:
1659         (main):
1660         (TestImporter.__init__):
1661         (TestImporter.find_importable_tests):
1662         (TestImporter.setup_destination_directory):
1663         (TestImporter.write_import_log):
1664         (TestImporter.update_test_status): Deleted.
1665
1666 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1667
1668         [GTK] Fix the handling of resize events after r169505.
1669         https://bugs.webkit.org/show_bug.cgi?id=133517
1670
1671         Reviewed by Martin Robinson.
1672
1673         * Scripts/webkitpy/port/xvfbdriver.py:
1674         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
1675         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
1676         need at least 900x640 pixels to pass.
1677         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1678         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
1679         be requested over the main widget instead of the window.
1680         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
1681         the Mac port.
1682         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
1683         (WTR::PlatformWebView::setWindowFrame): Set the size and position
1684         of the Window and the web view.
1685
1686 2014-06-17  Dan Bernstein  <mitz@apple.com>
1687
1688         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
1689         https://bugs.webkit.org/show_bug.cgi?id=133968
1690
1691         Reviewed by Anders Carlsson.
1692
1693         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1694         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
1695         share an impl() with the original.
1696
1697 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1698
1699         [EFL][WK2] Skip failing EFL API tests
1700         https://bugs.webkit.org/show_bug.cgi?id=133981
1701
1702         Reviewed by Csaba Osztrogonác.
1703
1704         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
1705
1706         * TestWebKitAPI/PlatformEfl.cmake:
1707
1708 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
1709
1710         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
1711         https://bugs.webkit.org/show_bug.cgi?id=133962
1712
1713         Reviewed by Gyuyoung Kim.
1714
1715         Since we bumped EFL to 1.9, this workaround is unnecessary.
1716
1717         * MiniBrowser/efl/main.c:
1718         (update_view_favicon):
1719
1720 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
1721
1722         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1723         https://bugs.webkit.org/show_bug.cgi?id=131472
1724
1725         Reviewed by Martin Robinson.
1726
1727         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
1728
1729         * Scripts/webkitpy/port/xvfbdriver.py:
1730         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1731         when running WebKitTestRunner with the Xvfb driver.
1732         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
1733         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1734         installed.
1735         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1736         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1737         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1738         deal.
1739
1740 2014-06-16  Tanay C  <tanay.c@samsung.com>
1741
1742         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
1743         https://bugs.webkit.org/show_bug.cgi?id=133792
1744
1745         Reviewed by Gyuyoung Kim.
1746
1747         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
1748         (show_file_entry_dialog):
1749         (window_create):
1750
1751 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
1752
1753         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
1754         https://bugs.webkit.org/show_bug.cgi?id=133512
1755
1756         Reviewed by Chris Fleizach.
1757
1758         Added support for connecting to AtkSelection's 'selection-changed'
1759         signal, and print it out as AXSelectedChildrenChanged in the tests.
1760
1761         Also removed some dead code, that became useless after r169487.
1762
1763         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1764         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
1765
1766 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
1767
1768         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
1769         https://bugs.webkit.org/show_bug.cgi?id=133841
1770
1771         Reviewed by Gyuyoung Kim.
1772
1773         * MiniBrowser/efl/main.c:
1774         (window_create):
1775
1776 2014-06-15  Dan Bernstein  <mitz@apple.com>
1777
1778         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
1779
1780         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
1781
1782 2014-06-15  Anders Carlsson  <andersca@apple.com>
1783
1784         Fix build.
1785
1786         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1787         (callRunJavaScriptBlockAndRelease):
1788         (runJavaScriptInMainFrame):
1789         (TEST_F):
1790
1791 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1792
1793         Create MSE and EME watchlist
1794         https://bugs.webkit.org/show_bug.cgi?id=133810
1795
1796         Reviewed by Eric Carlson.
1797
1798         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
1799         definition and add Eric Carlson and myself to it.
1800
1801 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1802
1803         [GTK] Remove all deprecated API from GObject DOM bindings
1804         https://bugs.webkit.org/show_bug.cgi?id=133728
1805
1806         Reviewed by Martin Robinson.
1807
1808         * gtk/webkitdom.py:
1809         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
1810         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
1811
1812 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
1813
1814         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
1815         https://bugs.webkit.org/show_bug.cgi?id=133835
1816
1817         Reviewed by Tim Horton.
1818         
1819         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
1820
1821         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1822         (-[WebKitTestRunnerWindow initWithFrame:]):
1823         (-[WebKitTestRunnerWindow setFrame:]):
1824
1825 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1826
1827         [GTK] Performance tests should be always ran with WKTR.
1828         https://bugs.webkit.org/show_bug.cgi?id=133780
1829
1830         Reviewed by Ryosuke Niwa.
1831
1832         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1833         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
1834         is GTK.
1835
1836 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
1837
1838         [GTK] REGRESSION: application name is not correctly appended to the UA
1839         https://bugs.webkit.org/show_bug.cgi?id=133793
1840
1841         Reviewed by Carlos Garcia Campos.
1842
1843         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1844         (testWebKitSettingsUserAgent):
1845
1846 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
1847
1848         [GTK] Unsupported browser in www.icloud.com
1849         https://bugs.webkit.org/show_bug.cgi?id=133403
1850
1851         Reviewed by Martin Robinson.
1852
1853         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
1854         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
1855         quirk that was removed.
1856
1857 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
1858
1859         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
1860         https://bugs.webkit.org/show_bug.cgi?id=133779
1861
1862         Reviewed by Benjamin Poulain.
1863         
1864         Tell the WebPage to use the testing viewport configuration from the injected bundle.
1865
1866         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1867         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
1868         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1869         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
1870         on iOS.
1871
1872 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
1873
1874         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
1875         https://bugs.webkit.org/show_bug.cgi?id=133770
1876
1877         Reviewed by Anders Carlsson.
1878         
1879         Push the per-test view configuration up to TestController, so that platforms
1880         can modify the behavior. This also allows platform-specific changes (e.g.
1881         for threaded scrolling) to made without #ifefs.
1882
1883         * WebKitTestRunner/TestController.cpp:
1884         (WTR::TestController::updateWebViewSizeForTest):
1885         (WTR::TestController::updateWindowScaleForTest):
1886         (WTR::shouldUseFixedLayout):
1887         (WTR::TestController::updateLayoutTypeForTest):
1888         (WTR::TestController::platformConfigureViewForTest):
1889         (WTR::TestController::configureViewForTest):
1890         * WebKitTestRunner/TestController.h:
1891         * WebKitTestRunner/TestInvocation.cpp:
1892         (WTR::TestInvocation::invoke):
1893         (WTR::sizeWebViewForCurrentTest): Deleted.
1894         (WTR::changeWindowScaleIfNeeded): Deleted.
1895         (WTR::shouldUseThreadedScrolling): Deleted.
1896         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
1897         (WTR::shouldUseFixedLayout): Deleted.
1898         (WTR::updateLayoutType): Deleted.
1899         * WebKitTestRunner/TestInvocation.h:
1900         (WTR::TestInvocation::pathOrURL):
1901         * WebKitTestRunner/ios/TestControllerIOS.mm:
1902         (WTR::shouldMakeViewportFlexible):
1903         (WTR::TestController::platformConfigureViewForTest):
1904         * WebKitTestRunner/mac/TestControllerMac.mm:
1905         (WTR::shouldUseThreadedScrolling):
1906         (WTR::TestController::platformConfigureViewForTest):
1907
1908 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1909
1910         [EFL] Add dependencies packages to efl install-dependencies file
1911         https://bugs.webkit.org/show_bug.cgi?id=133720
1912
1913         Reviewed by Csaba Osztrogonác.
1914
1915         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
1916         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
1917
1918         * efl/install-dependencies:
1919
1920 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
1921
1922         Unreviewed. Moving myself to the list of reviewers.
1923
1924         * Scripts/webkitpy/common/config/contributors.json:
1925
1926 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1927
1928         [EFL] Drop to maintain EFL 32bit release bot
1929         https://bugs.webkit.org/show_bug.cgi?id=133710
1930
1931         Reviewed by Csaba Osztrogonác.
1932
1933         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
1934
1935 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1936
1937         [GTK] Use a different user agent string depending on the site
1938         https://bugs.webkit.org/show_bug.cgi?id=132681
1939
1940         Reviewed by Anders Carlsson.
1941
1942         Add a unit test to check user agent quirks.
1943
1944         * TestWebKitAPI/PlatformGTK.cmake:
1945         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
1946         (TestWebKitAPI::TEST):
1947         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1948         (testWebKitSettings): Site specific quirks setting is now enabled
1949         by default.
1950
1951 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1952
1953         Unreviewed, update my list of email addresses in contributors.json.
1954
1955         * Scripts/webkitpy/common/config/contributors.json:
1956
1957 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
1958
1959         Always switch to an sRGB screen color profile when running tests
1960         https://bugs.webkit.org/show_bug.cgi?id=133712
1961
1962         Reviewed by Tim Horton.
1963         
1964         Switch the screen color profile to sRGB when running tests, because even ref
1965         tests need the screen to use the correct color profile.
1966
1967         * DumpRenderTree/mac/LayoutTestHelper.m:
1968         (installLayoutTestColorProfile):
1969         * Scripts/webkitpy/port/mac.py:
1970         (MacPort.start_helper):
1971
1972 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
1973
1974         [EFL] Bump EFL libraries to 1.9
1975         https://bugs.webkit.org/show_bug.cgi?id=125479
1976
1977         Reviewed by Gyuyoung Kim.
1978
1979         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
1980         and László Langó <llango.u-szeged@partner.samsung.com>.
1981
1982         * ImageDiff/CMakeLists.txt:
1983         * MiniBrowser/efl/CMakeLists.txt:
1984         * efl/install-dependencies:
1985         * efl/jhbuild.modules:
1986         * efl/jhbuildrc:
1987
1988 2014-06-10  David Farler  <dfarler@apple.com>
1989
1990         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
1991         https://bugs.webkit.org/show_bug.cgi?id=133663
1992
1993         Reviewed by David Kilzer.
1994
1995         * Scripts/old-run-webkit-tests:
1996         (installAndLaunchDumpToolAppUsingNotification):
1997         - Remove obsolete notification keys
1998         - Key off of mandatory device UDID (a UUID)
1999         - Create a device on demand via CoreSimulator if necessary
2000         -- Grab the UDID from the created device plist.
2001         * Scripts/webkitdirs.pm:
2002         (iOSSimulatorDevicesPath): Added
2003         (iOSSimulatorDevices): Added
2004         (createiOSSimulatorDevice): Added
2005         (deleteiOSSimulatorDevice): Added
2006
2007 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2008
2009         [GTK][gtkdoc] remove -Wcast-align
2010         https://bugs.webkit.org/show_bug.cgi?id=133640
2011
2012         Apparently gcc warns that GParamSpec is not castable to
2013         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
2014         though ARM hackers claim that those only need 4byte alignment. As long as gcc
2015         behaves that way, this warning is not very useful, also they break the Debian
2016         packaging.
2017
2018         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
2019         scanner compilation, thus the compiler ignores the previous
2020         -Waling-cast flag.
2021
2022         Reviewed by Martin Robinson.
2023
2024         * gtk/generate-gtkdoc:
2025         (get_generator_for_config):
2026
2027 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
2028
2029         Disable button animations in regression tests
2030         https://bugs.webkit.org/show_bug.cgi?id=133647
2031         <rdar://problem/16677530>
2032
2033         Reviewed by Tim Horton.
2034
2035         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2036         (WTR::InjectedBundle::platformInitialize):
2037
2038 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2039
2040         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
2041         https://bugs.webkit.org/show_bug.cgi?id=133650
2042
2043         Reviewed by Tim Horton.
2044         
2045         No point checking for a Windows-style path in Cocoa code.
2046
2047         * WebKitTestRunner/TestInvocation.cpp:
2048         (WTR::shouldUseThreadedScrolling):
2049
2050 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2051
2052         Fix more latched scrolling test flakiness and slowness
2053         https://bugs.webkit.org/show_bug.cgi?id=133601
2054
2055         Reviewed by Brent Fulgham.
2056         
2057         Latched scrolling tests were flakey for two reasons. First, the EventSender
2058         wheel events were async from the web to the UI process, and the resulting
2059         synthetic events also async from the UI to the web process. Make them sync
2060         for testing.
2061         
2062         Secondly, the timer-based scrolling tree commit could result in the scrolling
2063         tree (specifically the frame node's notion of the scrollable area and content
2064         size) not being updated before the scrolling thread starts getting wheel events.
2065         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
2066         
2067         Finally remove all the now-unnecessary timeouts from the tests.
2068
2069         * WebKitTestRunner/mac/EventSenderProxy.mm:
2070         (WTR::EventSenderProxy::mouseMoveTo):
2071         (WTR::EventSenderProxy::mouseScrollBy):
2072         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2073
2074 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
2075
2076         [EFL] Add parameter to MiniBrowser to disable web security
2077         https://bugs.webkit.org/show_bug.cgi?id=121095
2078
2079         Reviewed by Gyuyoung Kim.
2080
2081         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
2082         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
2083         resources from other domains (cross-domain requests) such as access map location on another server.
2084         Another possibility is to launch in a webkit browser local file tests that will refer to the links
2085         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
2086
2087         * MiniBrowser/efl/main.c:
2088         (window_create):
2089         (elm_main):
2090
2091 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2092
2093         32-bit build fix.
2094
2095         * WebKitTestRunner/mac/EventSenderProxy.mm:
2096         (WTR::EventSenderProxy::mouseMoveTo):
2097         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2098
2099 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2100
2101         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
2102
2103         * DumpRenderTree/mac/DumpRenderTree.mm:
2104         (createWebViewAndOffscreenWindow):
2105         * DumpRenderTree/mac/EventSendingController.mm:
2106         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2107         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2108         * WebKitTestRunner/mac/EventSenderProxy.mm:
2109         (WTR::EventSenderProxy::mouseScrollBy):
2110         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2111
2112 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2113
2114         Latched scrolling tests are flakey on Mavericks
2115         https://bugs.webkit.org/show_bug.cgi?id=133578
2116         <rdar://problem/17180591>
2117
2118         Reviewed by Brent Fulgham.
2119         
2120         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
2121         be wrong on machines with more than one screen. This is because we use
2122         [NSScreen mainScreen] when computing the global coordinates of the events, but
2123         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
2124         
2125         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
2126         add comments clarifying why the coordinate math works (which is not obvious given
2127         the events have no target window).
2128         
2129         Some scrolling tests also dispatched events outside the 800x600 test window, so
2130         fix those tests, and add logging that will appear in test output when this happens.
2131
2132         * DumpRenderTree/mac/DumpRenderTree.mm:
2133         (createWebViewAndOffscreenWindow):
2134         * DumpRenderTree/mac/EventSendingController.mm:
2135         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2136         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2137         * WebKitTestRunner/mac/EventSenderProxy.mm:
2138         (WTR::EventSenderProxy::mouseMoveTo):
2139         (WTR::EventSenderProxy::mouseScrollBy):
2140         (WTR::EventSenderProxy::continuousMouseScrollBy):
2141         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2142
2143 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2144
2145         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
2146         https://bugs.webkit.org/show_bug.cgi?id=133533
2147
2148         Reviewed by Carlos Garcia Campos.
2149
2150         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2151         (run): Remove the jhbuild-wrapper wrapper from here. It should be
2152         on Scripts/webkitpy/port/gtk.py.
2153         * Scripts/webkitpy/port/base.py:
2154         (Port.set_option): Add a set_option(name, value) function to set
2155         the optparse parameter "name" to the value "value", even if the
2156         parameter "name" is already initialized.
2157         * Scripts/webkitpy/port/gtk.py:
2158         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
2159         If another wrapper is specified via the option "-l --wrapper=x",
2160         then prepend the jhbuild-wrapper to the one specified.
2161
2162 2014-06-04  David Farler  <dfarler@apple.com>
2163
2164         Build ASan WebKit for iOS Simulator
2165         https://bugs.webkit.org/show_bug.cgi?id=133489
2166
2167         Reviewed by Darin Adler.
2168
2169         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2170         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2171         - Add missing ASan LDFLAGS.
2172         * asan/asan.xcconfig:
2173         - Split compiler-rt linker flags for OS X and iOS Simulator
2174
2175 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
2176
2177         Add myself (yoav@yoav.ws) to contributors.json
2178         https://bugs.webkit.org/show_bug.cgi?id=133492
2179
2180         * Scripts/webkitpy/common/config/contributors.json:
2181
2182 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2183
2184         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
2185         https://bugs.webkit.org/show_bug.cgi?id=133149
2186
2187         Reviewed by Csaba Osztrogonác.
2188
2189         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
2190
2191 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2192
2193         Add a verbose flag to binding tests
2194         https://bugs.webkit.org/show_bug.cgi?id=122303
2195
2196         Reviewed by Csaba Osztrogonác.
2197
2198         This patch will:
2199         - Add a verbose keyword argument to the BindingsTests constructor,
2200         - Add --no-verbose option to the run-bindigs-test.
2201         Verbose mode, which is on by default, prints positive results to stdout as before.
2202         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
2203
2204         Original patch from Matthew Hanson <matthew_hanson@apple.com>
2205
2206         * Scripts/run-bindings-tests:
2207         (main):
2208         * Scripts/webkitpy/bindings/main.py:
2209         (BindingsTests.__init__):
2210         (BindingsTests.detect_changes):
2211
2212 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
2213
2214         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
2215         https://bugs.webkit.org/show_bug.cgi?id=133455
2216
2217         Reviewed by Timothy Hatcher.
2218
2219         Since the perf. dashboard doesn't support following renamed benchmarks,
2220         keep reporting Speedometer results as DoYouEvenBench results.
2221
2222         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2223         (_generate_results_dict):
2224
2225 2014-05-31  Darin Adler  <darin@apple.com>
2226
2227         Viewport percentage tests that resize the viewport are flaky
2228         https://bugs.webkit.org/show_bug.cgi?id=133351
2229
2230         Reviewed by Anders Carlsson.
2231
2232         * DumpRenderTree/mac/DumpRenderTree.mm:
2233         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
2234         happens to be stored in the UI delegate object. This is part of resetting the
2235         window position.
2236
2237         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
2238         a frame rectangle. The size is stored in the size of the web view itself.
2239         * DumpRenderTree/mac/UIDelegate.mm:
2240         (-[UIDelegate resetWindowOrigin]): Added.
2241         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
2242         old version would store the frame, but not resize the web view!
2243         (-[UIDelegate webViewFrame:]): Get the size from the web view.
2244
2245         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2246         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
2247
2248         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2249         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
2250         the window.
2251
2252         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2253         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
2254         window gets resized too, not just the web view.
2255         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
2256
2257         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2258         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
2259         window gets resized too, not just the web view.
2260         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
2261
2262 2014-05-30  Michael Saboff  <msaboff@apple.com>
2263
2264         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
2265         https://bugs.webkit.org/show_bug.cgi?id=133409
2266
2267         Reviewed by Filip Pizlo.
2268
2269         Handle creating a tarball the same way as running remote when processing
2270         paths in prepareBundle.
2271
2272         * Scripts/run-jsc-stress-tests:
2273
2274 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
2275
2276         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
2277         https://bugs.webkit.org/show_bug.cgi?id=132280
2278
2279         Reviewed by Chris Fleizach.
2280
2281         Remove implementation of logAccessibilityEvents() for ATK based
2282         ports, as this has proved to be a flaky method of checking that
2283         ATK events are being properly emitted. Instead, it's better to use
2284         the addNotificationListener() functions and provide a JS callback
2285         to check that the right events are being emmitted from the tests.
2286
2287         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2288         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
2289         with dummy implementation.
2290         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2291         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
2292
2293 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
2294
2295         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
2296         https://bugs.webkit.org/show_bug.cgi?id=132280
2297
2298         Rubber stamped by Carlos Garcia Campos.
2299
2300         Fix two small issues with previous patch (r169483), that caused some tests to break.
2301
2302         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2303         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
2304         duplicated entry.
2305         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2306         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
2307
2308 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
2309
2310         [ATK] Added new accessibility signal: text-caret-moved.
2311         Make AccessibilityUIElement.setSelectedTextRange work
2312         as atk_text_set_caret_offset when given offset == 0.
2313         https://bugs.webkit.org/show_bug.cgi?id=132527
2314
2315         Reviewed by Mario Sanchez Prada.
2316
2317         text-caret-moved signal in accessibilityController is needed to
2318         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
2319         as LayoutTests. Add the signal to the controller.
2320
2321         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2322         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2323         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2324         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2325         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2326         (setSelectedTextRange): Change return type to bool.
2327         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2328         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
2329         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2330         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
2331         for extra arguments passed to handler and use it for text-caret-moved offset.
2332         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2333         Connect callback to new listener for ATK:AtkText:text-caret-moved.
2334         Refactor so that failures be reported.
2335         Initialize atk interfaces before trying to connect to them, see
2336         https://bugzilla.gnome.org/show_bug.cgi?id=729922
2337         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2338         Simplify code by using a vector in place of dozen variables.
2339         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2340         Comment about not synchronizing with accessibilityController.
2341
2342 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2343
2344         [GTK] Add a WebKit2 Performance bot.
2345         https://bugs.webkit.org/show_bug.cgi?id=132862
2346
2347         Reviewed by Csaba Osztrogonác.
2348
2349         This adds a GTK WebKit2 perf bot.
2350
2351         * BuildSlaveSupport/build.webkit.org-config/config.json:
2352
2353 2014-05-29  Dan Bernstein  <mitz@apple.com>
2354
2355         Fixed the WebKitTestRunner build after r169452.
2356
2357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2358         (WTR::InjectedBundle::initialize):
2359
2360 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
2361
2362         Unreviewed. Update my email addresses in contributors.json.
2363
2364         * Scripts/webkitpy/common/config/contributors.json:
2365
2366 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
2367
2368         Need an API test for bug #133193 (r169315)
2369         <https://bugs.webkit.org/show_bug.cgi?id=133324>
2370
2371         This adds an API test that ensures that calling "stop loading" during a
2372         "did fail provisional load" callback doesn't crash.
2373
2374         Reviewed by Andy Estes.
2375
2376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2377         Add new files to project.
2378
2379         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
2380         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2381         If the message is the "test done" message, record that.
2382         (TestWebKitAPI::setInjectedBundleClient):
2383         Register a function for the "did receive message from injected bundle"
2384         callback.
2385         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2386         Assert that we received the message from the injected bundle, and set
2387         'done' to finish the test.
2388         (TestWebKitAPI::TEST):
2389         Create a WebView, register a page loader client for the "did fail
2390         provisional load" callback, and load a non-existent resource.
2391
2392         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
2393         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
2394         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
2395         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
2396         provisional load failed.
2397         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
2398         Register a page loader client for the "did fail provisional load"
2399         callback.
2400         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
2401         Call WKBundlePageStopLoading() during the callback. This not crashing
2402         is what we're ensuring with this test.
2403
2404 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2405
2406         [GTK] Make it possible to build with FTL enabled
2407         https://bugs.webkit.org/show_bug.cgi?id=133219
2408
2409         Reviewed by Philippe Normand.
2410
2411         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
2412         same revision than mac.
2413
2414 2014-05-27  Michael Saboff  <msaboff@apple.com>
2415
2416         REGRESSION(r169265): sh: line 0: cd: ../.vm
2417         https://bugs.webkit.org/show_bug.cgi?id=133242
2418
2419         Rubber stamped by Oliver Hunt.
2420
2421         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
2422         array since the command may contain character escapes that don't work with the
2423         array form of system().
2424
2425         * Scripts/run-jsc-stress-tests:
2426
2427 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2428
2429         [EFL] Change download url of freetype6
2430         https://bugs.webkit.org/show_bug.cgi?id=133303
2431
2432         Reviewed by Csaba Osztrogonác.
2433
2434         freetype6 tarball isn't downloaded in Korea. So, we need to
2435         change the url for now.
2436
2437         * efl/jhbuild.modules:
2438
2439 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2440
2441         Remove BLOB guards
2442         https://bugs.webkit.org/show_bug.cgi?id=132863
2443
2444         Reviewed by Csaba Osztrogonác.
2445
2446         * Scripts/webkitperl/FeatureList.pm:
2447
2448 2014-05-27  Alberto Garcia  <berto@igalia.com>
2449
2450         Remove leftover comment from r165182.
2451
2452         Rubber stamped by Carlos Garcia Campos.
2453
2454         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2455
2456 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2457
2458         [EFL] Add LLVM as optional jhbuild module for FTL developers
2459         https://bugs.webkit.org/show_bug.cgi?id=133216
2460
2461         Reviewed by Gyuyoung Kim.
2462
2463         * efl/jhbuild.modules:
2464
2465 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2466
2467         Fix test failures on python test
2468         https://bugs.webkit.org/show_bug.cgi?id=133297
2469
2470         Reviewed by Dirk Schulze.
2471
2472         2 tests are failing because of unbounded local variable reference in test_importer.py.
2473
2474         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
2475         (TestImporter.import_tests):
2476
2477 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2478
2479         [GTK] GObject DOM bindings API break test fails in the tests bots
2480         https://bugs.webkit.org/show_bug.cgi?id=133211
2481
2482         Reviewed by Martin Robinson.
2483
2484         When generating the built product archive on platform GTK, we need
2485         to copy also the file gtkdoc-webkitdom.cfg and the directory
2486         DerivedSources/webkitdom.
2487
2488         * BuildSlaveSupport/built-product-archive:
2489         (archiveBuiltProduct):
2490
2491 2014-05-26  Commit Queue  <commit-queue@webkit.org>
2492
2493         Unreviewed, rolling out r169122.
2494         https://bugs.webkit.org/show_bug.cgi?id=133288
2495
2496         Broke CJK font fallback (Requested by ap on #webkit).
2497
2498         Reverted changeset:
2499
2500         "[Mac] WebProcess doesn't follow localization of UI process
2501         when run as a service"
2502         https://bugs.webkit.org/show_bug.cgi?id=133126
2503         http://trac.webkit.org/changeset/169122
2504
2505 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2506
2507         [GTK] WebProcess leaked when closing pages with network process enabled
2508         https://bugs.webkit.org/show_bug.cgi?id=129684
2509
2510         Reviewed by Anders Carlsson.
2511
2512         Enable the test to check that web processes finish when the web
2513         view is destroyed.
2514
2515         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2516
2517 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2518
2519         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
2520         https://bugs.webkit.org/show_bug.cgi?id=133279
2521
2522         Reviewed by Philippe Normand.
2523
2524         generator.saw_warnings is only set by GTKDoc::generate(), so it
2525         should only be used after generate.
2526
2527         * gtk/generate-gtkdoc:
2528         (generate_documentation_for_config): Do not check
2529         generator.saw_warnings again, simply return the value returned by
2530         generate_doc() which is generator.saw_warnings. When rebasing,
2531         returns always False since there aren't warnings.
2532
2533 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2534
2535         W3C test importer should catch exceptions coming from HTML/CSS conversion
2536         https://bugs.webkit.org/show_bug.cgi?id=133176
2537
2538         Reviewed by Darin Adler.
2539
2540         Exceptions raised when converting HTML/CSS are caught.
2541         Files for which conversion failed are still copied to the target directory.
2542         Each individual conversion failure is logged.
2543         Total conversion failure number is logged at the end of the import process.
2544
2545         * Scripts/webkitpy/w3c/test_importer.py:
2546         (TestImporter.import_tests):
2547
2548 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2549
2550         [GTK] Allow to run the tests on the native X display.
2551         https://bugs.webkit.org/show_bug.cgi?id=133157
2552
2553         Reviewed by Benjamin Poulain.
2554
2555         This adds a new driver (xorgdriver) that runs the tests on the
2556         X display referenced by the environment variable DISPLAY.
2557
2558         This new driver will be activated only if the environment variable
2559         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
2560         tests and performance tests.
2561
2562         This patch also makes the script run-perf-tests to check the
2563         system dependencies before starting the tests. Previously this
2564         was not checked, and if the system dependencies were not met,
2565         the script tried to execute the tests anyway, causing massive
2566         failures. For example, if you had Xvfb not installed and you
2567         wanted to use the Xvfb driver (the default on GTK and EFL),
2568         run-perf-tests would not abort.
2569
2570         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2571         (PerfTestsRunner._parse_args): Check the system dependencies of
2572         the driver before starting the tests.
2573         * Scripts/webkitpy/port/driver.py:
2574         (Driver): Implement generic check_driver method.
2575         (Driver.check_driver):
2576         (Driver.check_driver.implementation):
2577         * Scripts/webkitpy/port/gtk.py:
2578         (GtkPort._driver_class): Check for environment variable
2579         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
2580         * Scripts/webkitpy/port/xorgdriver.py: Added.
2581         (XorgDriver): Implement Xorg driver.
2582         (XorgDriver.check_driver):
2583         (XorgDriver._start):
2584
2585 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2586
2587         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
2588         https://bugs.webkit.org/show_bug.cgi?id=133215
2589
2590         Reviewed by Csaba Osztrogonác.
2591
2592         This reverts r166798.
2593
2594         * BuildSlaveSupport/kill-old-processes:
2595         (main):
2596
2597 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2598
2599         [EFL] Turn on ENABLE_CSS_FILTERS in build script
2600         https://bugs.webkit.org/show_bug.cgi?id=133278
2601
2602         Reviewed by Gyuyoung Kim.
2603
2604         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
2605
2606 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2607
2608         run-javascriptcore-tests warning fix on non Mac platforms
2609         https://bugs.webkit.org/show_bug.cgi?id=133260
2610
2611         Reviewed by Darin Adler.
2612
2613         * Scripts/webkitdirs.pm:
2614         (argumentsForConfiguration):
2615
2616 2014-05-23  Michael Saboff  <msaboff@apple.com>
2617
2618         REGRESSION(r169265): sh: line 0: cd: ../.vm
2619         https://bugs.webkit.org/show_bug.cgi?id=133242
2620
2621         Rubber stamped by Geoffrey Garen.
2622
2623         Added missing shell escapes '\' required as part of previous fix.
2624
2625         * Scripts/run-jsc-stress-tests:
2626
2627 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
2628
2629         Revert the erroneous change committed in r169286.
2630
2631         * Scripts/webkitpy/performance_tests/perftest.py:
2632         (PerfTest._run_with_driver):
2633
2634 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
2635
2636         run-perf-tests should ignore whitespace lines when snarfing test output
2637         https://bugs.webkit.org/show_bug.cgi?id=133238
2638
2639         Reviewed by Ryosuke Niwa.
2640
2641         Required for PerformanceTests/Canvas/terrain.html.
2642
2643         * Scripts/webkitpy/performance_tests/perftest.py:
2644         (PerfTest._run_with_driver):
2645         (PerfTest):
2646
2647 2014-05-23  Michael Saboff  <msaboff@apple.com>
2648
2649         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
2650         https://bugs.webkit.org/show_bug.cgi?id=133223
2651
2652         Reviewed by Geoffrey Garen.
2653
2654         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
2655         string before calling IO.popen() to work with older versions of ruby.
2656         Changed the remote path in runShellTestRunner to quote the command
2657         string we want to run via ssh so that it will work correctly with array
2658         to string conversion needed for popen.
2659
2660         * Scripts/run-jsc-stress-tests:
2661
2662 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2663
2664         Remove 'css-shaders' option from the build-webkit
2665         https://bugs.webkit.org/show_bug.cgi?id=133212
2666
2667         Reviewed by Daniel Bates.
2668
2669         Original CSS shaders removed in r162644.
2670
2671         * Scripts/webkitperl/FeatureList.pm:
2672
2673 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2674
2675         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
2676         https://bugs.webkit.org/show_bug.cgi?id=133209
2677
2678         Reviewed by Sergio Villar Senin.
2679
2680         Return FAILURE when the command failed to run.
2681
2682         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2683         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
2684
2685 2014-05-23  Alberto Garcia  <berto@igalia.com>
2686
2687         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
2688         https://bugs.webkit.org/show_bug.cgi?id=133210
2689
2690         Reviewed by Carlos Garcia Campos.
2691
2692         * gtk/install-dependencies:
2693
2694 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
2695
2696         Add Yusuke Suzuki to the list of contributors (for real)
2697
2698         Wrong section...
2699
2700         * Scripts/webkitpy/common/config/contributors.json:
2701
2702 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
2703
2704         Add Yusuke Suzuki to the list of contributors
2705
2706         * Scripts/webkitpy/common/config/contributors.json:
2707
2708 2014-05-22  Michael Saboff  <msaboff@apple.com>
2709
2710         Eliminate n/total progress update from run-jsc-stress-tests output to file
2711         https://bugs.webkit.org/show_bug.cgi?id=133191
2712
2713         Reviewed by Geoffrey Garen.
2714
2715         Changed progressMeter setting to be based on stdout being a tty instead of
2716         stdin.  Unified the processing of output from the shell runner to match the
2717         same processing as is used by the makefile runner.  As part of this, the 
2718         shell runner script was simplified.  It now forwards the output of each
2719         test_script just like the Makefile and doesn't provide its own progress.
2720
2721         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2722         * Scripts/run-jsc-stress-tests:
2723
2724 2014-05-22  Michael Saboff  <msaboff@apple.com>
2725
2726         Add option to run-jsc-stress-tests to use installed jsc
2727         https://bugs.webkit.org/show_bug.cgi?id=133102
2728
2729         Reviewed by Geoffrey Garen.
2730
2731         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
2732         provied with the --jsc option.
2733
2734         * Scripts/run-jsc-stress-tests:
2735
2736 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2737
2738         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
2739         https://bugs.webkit.org/show_bug.cgi?id=132907
2740
2741         Reviewed by Gyuyoung Kim.
2742
2743         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
2744         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
2745
2746         * efl/install-dependencies:
2747
2748 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2749
2750         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
2751         https://bugs.webkit.org/show_bug.cgi?id=133145
2752
2753         Reviewed by Csaba Osztrogonác.
2754
2755         * Scripts/run-jsc-stress-tests:
2756
2757 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
2758
2759         [Mac] WebProcess doesn't follow localization of UI process when run as a service
2760         https://bugs.webkit.org/show_bug.cgi?id=133126
2761         <rdar://problem/13396515>
2762         <rdar://problem/16561084>
2763
2764         Reviewed by Sam Weinig and Tim Horton.
2765
2766         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2767         (WTR::InjectedBundle::platformInitialize): It was too late to override language
2768         here, and it's not necessary any more. Keeping the code for older OS versions in
2769         case it did have effect in some code paths.
2770
2771 2014-05-19  David Farler  <dfarler@apple.com>
2772
2773         Move WebKitTestRunner to std::unique_ptr
2774         https://bugs.webkit.org/show_bug.cgi?id=133081
2775
2776         Reviewed by Daniel Bates.
2777
2778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2779         (WTR::InjectedBundle::didCreatePage):
2780         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2781         * WebKitTestRunner/TestController.cpp:
2782         (WTR::TestController::initialize):
2783         (WTR::TestController::createWebViewWithOptions):
2784         (WTR::TestController::resetStateToConsistentValues):
2785         (WTR::TestController::runTest):
2786         * WebKitTestRunner/TestController.h:
2787         * WebKitTestRunner/TestInvocation.cpp:
2788         * WebKitTestRunner/TestInvocation.h:
2789         * WebKitTestRunner/WorkQueueManager.cpp:
2790         (WTR::WorkQueueManager::processWorkQueue):
2791         (WTR::WorkQueueManager::enqueue):
2792         * WebKitTestRunner/WorkQueueManager.h:
2793
2794 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2795
2796         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
2797         https://bugs.webkit.org/show_bug.cgi?id=133119
2798
2799         Reviewed by Sergio Villar Senin.
2800
2801         Check that redirect response parameter of
2802         WebKitWebPage::send-request signal is NULL when not redirecting
2803         and a valid WebKitURIResponse object when redirecting.
2804
2805         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2806         (testWebResourceSendRequest):
2807         (serverCallback):
2808         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2809         (sendRequestCallback):
2810
2811 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2812
2813         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
2814         https://bugs.webkit.org/show_bug.cgi?id=133117
2815
2816         Reviewed by Philippe Normand.
2817
2818         Bring back missing tests to the build.
2819
2820         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2821
2822 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
2823
2824         Take care of some ARM64 test failures
2825         https://bugs.webkit.org/show_bug.cgi?id=133090
2826
2827         Reviewed by Geoffrey Garen.
2828
2829         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
2830
2831 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2832
2833         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
2834         <http://webkit.org/b/133089>
2835
2836         Reviewed by Darin Adler.
2837
2838         * Scripts/webkitdirs.pm:
2839         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
2840         specified on the command line, we would remove the '--sdk'
2841         arguments, but leave '--sim', potentially passing it along to
2842         xcodebuild causing a build failure.  This happens when
2843         'old-run-webkit-tests --release --sim' invokes
2844         build-dumprendertree when DumpRenderTree hasn't been built yet.
2845
2846 2014-05-19  David Farler  <dfarler@apple.com>
2847
2848         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
2849         https://bugs.webkit.org/show_bug.cgi?id=133086
2850
2851         Reviewed by Daniel Bates.
2852
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2854
2855 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2856
2857         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
2858         <http://webkit.org/b/132954>
2859
2860         * Scripts/webkitdirs.pm:
2861         (sharedCommandLineOptionsUsage): Remove the prototype for the
2862         subroutine.  Older perls don't like the "+@" syntax.
2863
2864 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2865
2866         run-javascriptcore-tests should sort the list of failing stress tests
2867         https://bugs.webkit.org/show_bug.cgi?id=132989
2868
2869         Reviewed by Csaba Osztrogonác.
2870
2871         * Scripts/run-javascriptcore-tests:
2872
2873 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2874
2875         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
2876         <http://webkit.org/b/132954>
2877
2878         Reviewed by Darin Adler.
2879
2880         Extract code into setupMacWebKitEnvironment() for setting up
2881         common environment variables so it may be shared.  Sets
2882         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
2883         using guardmalloc to some scripts.
2884
2885         Also adds support for parsing shared (common) command-line
2886         switches, initially just -g|--guard-malloc.
2887
2888         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
2889         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
2890         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
2891         local copy of %ENV when launching Safari so we don't have to
2892         restore variables.
2893
2894         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
2895         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
2896         Check result of GetOptions() to catch invalid command-line
2897         switches.
2898         (runTest): Use a local copy of %ENV when running tests so we
2899         don't have to restore variables.
2900         (prepareEnvironmentForRunningTestTool): Call
2901         setupMacWebKitEnvironment().
2902
2903         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
2904         using sharedCommandLineOptions() and
2905         sharedCommandLineOptionsUsage().  Call
2906         setupMacWebKitEnvironment().
2907
2908         * Scripts/webkitdirs.pm:
2909         (sharedCommandLineOptions): Return array of common switches to
2910         pass to Getopt::Long::GetOptions().
2911         (sharedCommandLineOptionsUsage): Return formatted string of
2912         common switches for printing usage help text.
2913         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
2914         guardmalloc.
2915         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
2916         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
2917         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
2918         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
2919         local copy of %ENV when launching Safari so we don't have to
2920         restore variables.
2921         (execMacWebKitAppForDebugging): Call
2922         setupMacWebKitEnvironment().
2923
2924 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
2925
2926         support for navigator.hardwareConcurrency
2927         https://bugs.webkit.org/show_bug.cgi?id=132588
2928
2929         Reviewed by Filip Pizlo.
2930
2931         * Scripts/webkitperl/FeatureList.pm:
2932
2933 2014-05-18  Anders Carlsson  <andersca@apple.com>
2934
2935         Implement Navigations for all methods declared returning one
2936         https://bugs.webkit.org/show_bug.cgi?id=133048
2937         <rdar://problem/16830064>
2938
2939         Reviewed by Sam Weinig.
2940
2941         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2942         Import WebKit.h.
2943         
2944         * MiniBrowser/mac/WK2BrowserWindowController.m:
2945         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2946         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2947         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2948         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2949         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2950         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2951         Print out the navigations.
2952
2953 2014-05-17  Zalan Bujtas  <zalan@apple.com>
2954
2955         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
2956         https://bugs.webkit.org/show_bug.cgi?id=133029
2957
2958         Reviewed by Simon Fraser.
2959
2960         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
2961         toggling it on a WK2 window needs restart.
2962         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
2963         the WebPreferences just to support this temporary toggle.
2964
2965         * MiniBrowser/mac/BrowserWindowController.h:
2966         * MiniBrowser/mac/MainMenu.xib:
2967         * MiniBrowser/mac/WK1BrowserWindowController.m:
2968         (-[WK1BrowserWindowController validateMenuItem:]):
2969         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
2970         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
2971         * MiniBrowser/mac/WK2BrowserWindowController.m:
2972         (-[WK2BrowserWindowController validateMenuItem:]):
2973         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
2974         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
2975
2976 2014-05-17  Anders Carlsson  <andersca@apple.com>
2977
2978         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
2979         https://bugs.webkit.org/show_bug.cgi?id=133033
2980         <rdar://problem/16830143>
2981
2982         Reviewed by Sam Weinig.
2983
2984         Set up the WebSQL and IndexedDB directories.
2985
2986         * WebKitTestRunner/TestController.cpp:
2987         (WTR::TestController::initialize):
2988
2989 2014-05-16  Martin Hock  <mhock@apple.com>
2990
2991         MemoryCache::addImageToCache should return the result of add().
2992         https://bugs.webkit.org/show_bug.cgi?id=132928
2993         <rdar://problem/16651547>
2994
2995         Reviewed by Alexey Proskuryakov.
2996
2997         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2999         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
3000         (TestWebKitAPI::TEST):
3001
3002 2014-05-15  David Farler  <dfarler@apple.com>
3003
3004         old-run-webkit-tests: allow specifying a simulator app path
3005         https://bugs.webkit.org/show_bug.cgi?id=132975
3006
3007         Reviewed by Anders Carlsson.
3008
3009         * Scripts/old-run-webkit-tests:
3010         (openIPhoneSimulator):
3011         Add new --simulator-app command line parameter for specifying the
3012         absolute path to the simulator app to launch before starting a
3013         session.
3014
3015 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3016
3017         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
3018         https://bugs.webkit.org/show_bug.cgi?id=131363
3019
3020         Reviewed by Csaba Osztrogonác.
3021
3022         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3023         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3024         (MockBugzilla):
3025         * Scripts/webkitpy/tool/commands/download_unittest.py:
3026         (test_create_rollout_multiple_revision_with_one_resolved):
3027         (test_create_rollout_multiple_resolved):
3028         (test_rollout_two_revisions):
3029         (test_rollout_multiple_revisions):
3030         (test_rollout_multiple_revisions_with_a_missing_bug_id):
3031         * Scripts/webkitpy/tool/steps/createbug.py:
3032         (CreateBug.run):
3033         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3034         (ReopenBugAfterRollout.run):
3035
3036 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
3037
3038         [WK2] Change the remaining framework includes from WebKit2 to WebKit
3039         https://bugs.webkit.org/show_bug.cgi?id=132956
3040
3041         Reviewed by Sam Weinig.
3042
3043         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
3044         * MiniBrowser/mac/AppDelegate.m:
3045         * MiniBrowser/mac/WK2BrowserWindowController.m:
3046         * TestWebKitAPI/InjectedBundleController.h:
3047         * TestWebKitAPI/InjectedBundleMain.cpp:
3048         * TestWebKitAPI/JavaScriptTest.cpp:
3049         * TestWebKitAPI/PlatformUtilities.h:
3050         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3051         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3052         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3053         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3054         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
3055         (TestWebKitAPI::TEST):
3056         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
3057         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
3058         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3059         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3060         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3061         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3062         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
3063         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
3064         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3065         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3066         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3067         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3068         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3069         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3070         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3071         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3072         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3073         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3074         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3075         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3076         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
3077         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
3078         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3079         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3080         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3081         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3082         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
3083         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
3084         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
3085         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
3086         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
3087         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3088         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
3089         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
3090         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
3091         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3092         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3093         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3094         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3095         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
3096         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3097         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3098         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3099         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3100         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3101         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
3102         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
3103         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
3104         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
3105         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3106         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3107         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
3108         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3109         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
3110         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3111         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3112         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
3113         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
3114         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3115         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3116         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3117         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3118         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
3119         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3120         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
3121         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3122         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
3123         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
3124         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3125         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
3126         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3127         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
3128         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3129         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3130         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3131         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3132         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3133         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3134         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3135         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3136         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
3137         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3138         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3139         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
3140         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3141         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3142         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3143         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3144         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3145         * TestWebKitAPI/config.h:
3146         * TestWebKitAPI/efl/PlatformWebView.cpp:
3147         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
3148         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3149         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3150         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3151         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3152         * WebKitTestRunner/EventSenderProxy.h:
3153         * WebKitTestRunner/GeolocationProviderMock.cpp:
3154         * WebKitTestRunner/GeolocationProviderMock.h:
3155         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3156         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3157         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3158         * WebKitTestRunner/InjectedBundle/GCController.cpp:
3159         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3160         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3161         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3162         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3163         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3166         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3168         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3170         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3171         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3172         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
3173         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3174         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3175         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3176         * WebKitTestRunner/PlatformWebView.h:
3177         * WebKitTestRunner/StringFunctions.h:
3178         * WebKitTestRunner/TestController.cpp:
3179         * WebKitTestRunner/TestController.h:
3180         * WebKitTestRunner/TestInvocation.cpp:
3181         * WebKitTestRunner/TestInvocation.h:
3182         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3183         * WebKitTestRunner/WebNotificationProvider.cpp:
3184         * WebKitTestRunner/WebNotificationProvider.h:
3185         * WebKitTestRunner/WorkQueueManager.cpp:
3186         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3187         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3188         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3189         * WebKitTestRunner/config.h:
3190         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3191         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3192         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3193         * WebKitTestRunner/ios/TestControllerIOS.mm:
3194         * WebKitTestRunner/mac/EventSenderProxy.mm:
3195         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3196         * WebKitTestRunner/mac/TestControllerMac.mm:
3197
3198 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3199
3200         [EFL][WK2] Skip failing unit tests
3201         https://bugs.webkit.org/show_bug.cgi?id=132979
3202
3203         Reviewed by Daniel Bates.
3204
3205         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
3206
3207 2014-05-15  David Kilzer  <ddkilzer@apple.com>
3208
3209         [iOS] Support TestWebKitAPI in the iOS Simulator
3210         <http://webkit.org/b/129535>
3211         <rdar://problem/16203529>
3212
3213         Reviewed by Daniel Bates.
3214
3215         * Scripts/run-api-tests:
3216         (runTest):
3217         (listAllTests):
3218         - Extract common arguments into local variable.
3219         - Use xcrun to find the sim tool in order to invoke
3220         TestWebKitAPI properly in the iOS Simulator. 
3221
3222         * Scripts/webkitdirs.pm:
3223         (argumentsForConfiguration): Set --device or --sim as
3224         appropriate to fix buildTestTool() in run-api-tests.
3225
3226 2014-05-15  Tim Horton  <timothy_horton@apple.com>
3227
3228         Fix a logging typo in copy-webkitlibraries-to-product-directory
3229
3230         Reviewed by Dean Jackson.
3231
3232         * Scripts/copy-webkitlibraries-to-product-directory:
3233
3234 2014-05-15  David Kilzer  <ddkilzer@apple.com>
3235
3236         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
3237         <http://webkit.org/b/132959>
3238
3239         Reviewed by Dan Bernstein.
3240
3241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
3242         Cocoa directory to project and move URLExtras.mm into it.
3243         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
3244
3245 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3246
3247         [GTK] Compile all installed resources as GResources
3248         https://bugs.webkit.org/show_bug.cgi?id=131099
3249
3250         Reviewed by Philippe Normand.
3251
3252         * Scripts/webkitpy/port/gtk.py:
3253         (GtkPort.setup_environ_for_server): Removed now unneeded
3254         AUDIO_RESOURCES_PATH env var.
3255
3256 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3257
3258         Remove CSS_STICKY_POSITION guards
3259         https://bugs.webkit.org/show_bug.cgi?id=132676
3260
3261         Reviewed by Simon Fraser.
3262
3263         * Scripts/webkitperl/FeatureList.pm:
3264
3265 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3266
3267         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
3268         https://bugs.webkit.org/show_bug.cgi?id=132686
3269
3270         Reviewed by Philippe Normand.
3271
3272         Bring back InputMethodFilter test to the build and compile it into
3273         a single binary TestWebCore with the other WebCore tests. Also
3274         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
3275
3276         * Scripts/run-gtk-tests:
3277         (TestRunner): Remove WebCoreGtk from the list of test directories.
3278         * TestWebKitAPI/PlatformGTK.cmake:
3279         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
3280
3281 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3282
3283         [EFL] Make XVFBDriver optional
3284         https://bugs.webkit.org/show_bug.cgi?id=131036
3285
3286         Reviewed by Gyuyoung Kim.
3287
3288         * Scripts/webkitpy/port/efl.py:
3289         (EflPort._driver_class):
3290
3291 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3292
3293         Flakiness dashboard contains outdated list of bots on builders.jsonp
3294         https://bugs.webkit.org/show_bug.cgi?id=132874
3295
3296         Reviewed by Darin Adler.
3297
3298         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
3299         file by changing to the directory Tools/TestResultServer and executing
3300         the script generate_builders_json.py
3301
3302 2014-05-11  Anders Carlsson  <andersca@apple.com>
3303
3304         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
3305         https://bugs.webkit.org/show_bug.cgi?id=132809
3306
3307         Reviewed by Dan Bernstein.
3308
3309         * WebKitTestRunner/TestController.cpp:
3310         (WTR::TestController::initialize):
3311         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
3312
3313 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3314
3315         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
3316         https://bugs.webkit.org/show_bug.cgi?id=132739
3317
3318         Reviewed Anders Carlsson.
3319
3320         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
3321         the JSC unit tests.
3322         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
3323
3324 2014-05-11  Anders Carlsson  <andersca@apple.com>
3325
3326         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
3327         https://bugs.webkit.org/show_bug.cgi?id=132806
3328
3329         Reviewed by Beth Dakin.
3330
3331         Migrate to WKContextConfiguration.
3332
3333         * WebKitTestRunner/TestController.cpp:
3334         (WTR::TestController::initialize):
3335
3336 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3337
3338         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
3339         https://bugs.webkit.org/show_bug.cgi?id=132685
3340
3341         Reviewed by Martin Robinson.
3342
3343         Use a single TestWebKit2 binary for all WebKit2 C API tests.
3344
3345         * TestWebKitAPI/PlatformGTK.cmake:
3346
3347 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
3348
3349         [iOS] Switch geolocation to an explicit authorization query model
3350         https://bugs.webkit.org/show_bug.cgi?id=132717
3351
3352         Reviewed by Sam Weinig.
3353
3354         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3355         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
3356         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
3357
3358 2014-05-09  David Farler  <dfarler@apple.com>
3359
3360         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
3361         https://bugs.webkit.org/show_bug.cgi?id=132718
3362
3363         Reviewed by David Kilzer.
3364
3365         The simulator may not be able to look up runtimes by SDK paths
3366         and instead will map SDK versions to runtimes instead. In
3367         com.apple.iphonesimulator.startSession notifications,
3368         'runtimeIdentifier' (SDK version string) is preferred over
3369         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
3370         when creating a new DRT or WKTR simulator session.
3371
3372         IPhoneSimulatorNotification.pm filters out keys for this
3373         notification's userInfo with a hard-coded list. There's no harm
3374         in including extra key-value pairs in an NSNotification userInfo
3375         dictionary anyway and the simulator may again change its
3376         userInfo schema for this notification.
3377
3378         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3379         (postStartSessionNotification):
3380         * Scripts/old-run-webkit-tests:
3381         (installAndLaunchDumpToolAppUsingNotification):
3382
3383 2014-05-09  Anders Carlsson  <andersca@apple.com>
3384
3385         Another build fix.
3386
3387         * Scripts/build-webkit:
3388         WebKit2 should always be built for OS X and iOS.
3389
3390 2014-05-09  Anders Carlsson  <andersca@apple.com>
3391
3392         Follow-up build fix.
3393
3394         * Scripts/build-webkit:
3395         WebKit2 should no longer be built before WebKit.
3396
3397 2014-05-09  Anders Carlsson  <andersca@apple.com>
3398
3399         Rename WebKit2.framework to WebKit.framework
3400         https://bugs.webkit.org/show_bug.cgi?id=132743
3401         <rdar://problem/15920046>
3402
3403         Reviewed by Dan Bernstein.
3404
3405         * Scripts/check-for-inappropriate-files-in-framework:
3406         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
3407         Change WebKit2 to WebKit.
3408
3409         * Scripts/check-for-webkit-framework-include-consistency:
3410         Change WebKit to WebKitLegacy.
3411
3412 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
3413
3414         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
3415         https://bugs.webkit.org/show_bug.cgi?id=132732
3416
3417         Reviewed by Alexey Proskuryakov.
3418
3419         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
3420
3421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3422         (EWS): Remove GTK+ WK1 EWS.
3423
3424 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3425
3426         Add new u-szeged contributors.
3427
3428         Reviewed by Csaba Osztrogonác.
3429
3430         * Scripts/webkitpy/common/config/contributors.json:
3431
3432 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3433
3434         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
3435         https://bugs.webkit.org/show_bug.cgi?id=132736
3436
3437         Reviewed by Philippe Normand.
3438
3439         There are two problems, the path returned by common.library_build_path() is wrong when
3440         common.binary_build_path() has previously been called, and the test is still looking for
3441         the .la instead of .so
3442
3443         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3444         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
3445         of .la as extension of the injected bundle library.
3446         * gtk/common.py:
3447         (binary_build_path): Remove unused global variable and add a new
3448         one for binary_build_dir instead of sharing the same global
3449         variable for library_build_path and binary_build_path.
3450
3451 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
3452
3453         [EFL] Enable MEDIA_STREAM for EFL port
3454         https://bugs.webkit.org/show_bug.cgi?id=132648
3455
3456         Reviewed by Gyuyoung Kim.
3457
3458         Script modified to enable MEDIA_STREAM for EFL build.
3459
3460         * Scripts/webkitperl/FeatureList.pm: 
3461
3462 2014-05-08  David Farler  <dfarler@apple.com>
3463
3464         old-run-webkit-tests: update strings for simulator devices and app name
3465         https://bugs.webkit.org/show_bug.cgi?id=132687
3466
3467         Reviewed by Darin Adler.
3468
3469         iPhone Retina (4-inch) -> iPhone 5
3470         iPhone Retina (4-inch 64-bit) -> iPhone 5s
3471
3472         * Scripts/old-run-webkit-tests:
3473         (installAndLaunchDumpToolAppUsingNotification):
3474         (openIPhoneSimulator):
3475         (quitIPhoneSimulator):
3476         quit iOS Simulator, not iPhone Simulator.
3477
3478 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3479
3480         REGRESSION(r168471): Update the builder names on the scheduler list.
3481         https://bugs.webkit.org/show_bug.cgi?id=132699
3482
3483         Reviewed by Martin Robinson.
3484
3485         On r168471 I missed to update the builder names for the GTK build
3486         bots on the AnyBranchScheduler type scheduler list of bots.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/config.json:
3489
3490 2014-05-08  Brady Eidson  <beidson@apple.com>
3491
3492         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
3493         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
3494
3495         Reviewed by Tim Horton.
3496
3497         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
3498         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
3499
3500 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3501
3502         REGRESSION(r168471): Duplicate builddirs broke the build master.
3503         https://bugs.webkit.org/show_bug.cgi?id=132688
3504
3505         Reviewed by Carlos Garcia Campos.
3506
3507         Rename the builddirs of the new GTK bots introduced on r168471 to
3508         be unique. Otherwise the master will break.
3509
3510         * BuildSlaveSupport/build.webkit.org-config/config.json:
3511
3512 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3513
3514         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
3515         https://bugs.webkit.org/show_bug.cgi?id=132674
3516
3517         Reviewed by Philippe Normand.
3518
3519         Only ignore mkdir failure when exception is raised because the
3520         file already exists and it's a directory.
3521
3522         * gtk/webkitdom.py:
3523         (write_doc_files):
3524
3525 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3526
3527         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
3528         https://bugs.webkit.org/show_bug.cgi?id=131358
3529
3530         Reviewed by Carlos Garcia Campos.
3531
3532         Current 64-bit GTK build bots (Release and Debug) not only test
3533         the build, but run all tests. Split each one of the bots in
3534         BuildOnly and TestWebKit2.
3535
3536         This will allow us to have a better overview of the status of
3537         the GTK port.
3538
3539         Original patch from Sergio Villar Senin <svillar@igalia.com>
3540
3541         * BuildSlaveSupport/build.webkit.org-config/config.json:
3542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3544         (WebKitBuildbot):
3545         * Scripts/webkitpy/port/builders.py:
3546         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3547         (TestRebaselineTest.test_baseline_directory):
3548         * TestResultServer/static-dashboards/builders.jsonp:
3549         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3550         (resetGlobals):
3551         * TestResultServer/static-dashboards/loader_unittests.js:
3552
3553 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3554
3555         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
3556         https://bugs.webkit.org/show_bug.cgi?id=126022
3557
3558         Reviewed by Benjamin Poulain.
3559
3560         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
3561
3562         Added an unit test case to check if scroll position and scale are restored properly.
3563
3564         * TestWebKitAPI/PlatformEfl.cmake:
3565         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
3566         (TestWebKitAPI::didFinishLoadForFrame):
3567         (TestWebKitAPI::didChangeContentsPosition):
3568         (TestWebKitAPI::TEST):
3569         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
3570         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
3571
3572 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
3573
3574         WebKit1 is flashy when compositing layers come and go
3575         https://bugs.webkit.org/show_bug.cgi?id=132655
3576         <rdar://problem/16830981&16788846>
3577
3578         Reviewed by Sam Weinig.
3579         
3580         Revert the change from r166117.
3581
3582         * DumpRenderTree/mac/DumpRenderTree.mm:
3583         (updateDisplay):
3584
3585 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
3586
3587         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
3588         https://bugs.webkit.org/show_bug.cgi?id=132622
3589
3590         Reviewed by Mario Sanchez Prada.
3591
3592         * DumpRenderTree/AccessibilityUIElement.cpp:
3593         (selectTextWithCriteriaCallback):
3594         (isEqualCallback):
3595         * DumpRenderTree/AccessibilityUIElement.h:
3596         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3597         (AccessibilityUIElement::selectTextWithCriteria):
3598         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3599         (AccessibilityUIElement::selectTextWithCriteria):
3600         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3601         (selectTextParameterizedAttributeForCriteria):
3602         (AccessibilityUIElement::selectTextWithCriteria):
3603         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3604         (AccessibilityUIElement::selectTextWithCriteria):
3605         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3606         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3607         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3608         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3609         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3610         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3611         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3612         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3613         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3614         (WTR::selectTextParameterizedAttributeForCriteria):
3615         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3616
3617 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3618
3619         [SOUP] TLSErrors do not cause page load to fail when not ignored
3620         https://bugs.webkit.org/show_bug.cgi?id=121548
3621
3622         Reviewed by Sergio Villar Senin.
3623
3624         Add unit tests to check that the load fails with TLS errors in
3625         case of a redirection.
3626
3627         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3628         (testTLSErrorsRedirect):
3629         (httpsServerCallback):
3630         (beforeAll):
3631
3632 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
3633
3634         [CSS Grid Layout] Remove runtime feature
3635         https://bugs.webkit.org/show_bug.cgi?id=132382
3636
3637         Reviewed by Benjamin Poulain.
3638
3639         Remove cssGridLayoutEnabled setting usage.
3640
3641         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3642         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3643         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3644         (TestRunner::overridePreference):
3645         * DumpRenderTree/mac/DumpRenderTree.mm:
3646         (resetWebPreferencesToConsistentValues):
3647
3648 2014-05-06  David Kilzer  <ddkilzer@apple.com>
3649
3650         Add Makefile targets for copying static libraries (LLVM and WKSI)
3651         <http://webkit.org/b/132619>
3652
3653         Reviewed by Mark Rowe.
3654
3655         * Scripts/copy-webkitlibraries-to-product-directory: Set a
3656         sensible default for product directory if not specified on
3657         either the command-line or in the environment (by Xcode) by
3658         calling productDir() in webkitdirs.pm.
3659
3660 2014-05-06  Brady Eidson  <beidson@apple.com>
3661
3662         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
3663         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
3664
3665         Reviewed by Sam Weinig.
3666
3667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3668
3669         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
3670         (TestWebKitAPI::itemURLLastComponentIsString):
3671         (TestWebKitAPI::didFinishLoadForFrame):
3672         (TestWebKitAPI::willGoToBackForwardListItem):
3673         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
3674         (TestWebKitAPI::setPageLoaderClient):
3675         (TestWebKitAPI::TEST):
3676         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
3677         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
3678
3679         * WebKitTestRunner/TestController.cpp:
3680         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
3681
3682 2014-05-06  Darin Adler  <darin@apple.com>
3683
3684         Try to fix iOS build.
3685
3686         * DumpRenderTree/mac/TestRunnerMac.mm:
3687         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
3688         Updated since I changed testRunner into a pointer instead of a reference.
3689         Updated argument names to avoid conflict with field names.
3690         (-[APITestDelegateIPhone run]): Ditto.
3691         (-[APITestDelegateIPhone _cleanUp]): Ditto.
3692
3693 2014-05-06  Commit Queue  <commit-queue@webkit.org>
3694
3695         Unreviewed, rolling out r168304.
3696         https://bugs.webkit.org/show_bug.cgi?id=132607
3697
3698         Broke the build (Requested by KaL on #webkit).
3699
3700         Reverted changeset:
3701
3702         "[GTK][CMake] Unable to do make install"
3703         https://bugs.webkit.org/show_bug.cgi?id=130188
3704         http://trac.webkit.org/changeset/168304
3705
3706 2014-05-04  Darin Adler  <darin@apple.com>
3707
3708         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
3709         https://bugs.webkit.org/show_bug.cgi?id=80222
3710
3711         Reviewed by Alexey Proskuryakov.
3712
3713         * DumpRenderTree/mac/TestRunnerMac.mm:
3714         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
3715         do more work here so we don't use RetainPtr local variables.
3716         (-[APITestDelegateIPhone dealloc]): Added.
3717         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
3718         created. Updated for changes to member names and types.
3719         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
3720         updated for changes to member names and types. Changed to two word spelling.
3721         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
3722         name of _cleanUp method.
3723         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
3724         Ditto.
3725         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
3726
3727 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
3728
3729         Clean up Image Document and tweak the layout and viewport
3730         https://bugs.webkit.org/show_bug.cgi?id=132552
3731
3732         Reviewed by Anders Carlsson.
3733
3734         * DumpRenderTree/mac/DumpRenderTree.mm:
3735         (resetWebPreferencesToConsistentValues):
3736         Update the default settings to have something consistent with WebKit2.
3737
3738 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
3739
3740         [GTK][CMake] Unable to do make install
3741         https://bugs.webkit.org/show_bug.cgi?id=130188
3742
3743         Reviewed by Carlos Garcia Campos.
3744
3745         * Scripts/webkitdirs.pm:
3746         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
3747         will give an early signal that a change has broken the documentation.
3748
3749 2014-05-05  Pratik Solanki  <psolanki@apple.com>
3750
3751         Update framework locations in package-root
3752         https://bugs.webkit.org/show_bug.cgi?id=132571
3753
3754         Reviewed by Simon Fraser.
3755
3756         * Scripts/package-root:
3757
3758 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
3759
3760         [EFL][WK2] Refactor favicon database APIs
3761         https://bugs.webkit.org/show_bug.cgi?id=132519
3762
3763         Reviewed by Gyuyoung Kim.
3764
3765         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
3766         (update_view_favicon):
3767         (on_icon_changed_cb):
3768         (window_free):
3769         (on_url_changed):
3770         (window_create):
3771         (on_view_favicon_changed): Deleted.
3772
3773 2014-05-02  Mark Rowe  <mrowe@apple.com>
3774
3775         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
3776
3777         Reviewed by Dan Bernstein.
3778
3779         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
3780         when determining which LLVM archive to extract.
3781
3782 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
3783
3784         Add Jeremy as a committer.
3785         https://bugs.webkit.org/show_bug.cgi?id=132492
3786
3787         Reviewed by Jer Noble.
3788
3789         Add myself as a committer.
3790
3791         * Scripts/webkitpy/common/config/contributors.json:
3792
3793 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
3794
3795         Add Jeremy as a committer.
3796         https://bugs.webkit.org/show_bug.cgi?id=132492
3797
3798         Reviewed by Jer Noble.
3799
3800         Add Jeremy Jones to the committers file.
3801
3802         * Scripts/webkitpy/common/config/contributors.json:
3803
3804 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
3805
3806         Hard to figure out how to run a single test with run-api-tests
3807         https://bugs.webkit.org/show_bug.cgi?id=116332
3808
3809         Reviewed by Alexey Proskuryakov.
3810
3811         * Scripts/run-api-tests: add two examples to the help message.
3812
3813 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
3814
3815         Fix several memory leaks found by code inspection
3816         https://bugs.webkit.org/show_bug.cgi?id=132472
3817
3818         Reviewed by Geoffrey Garen.
3819         
3820         Fix memory leaks.
3821
3822         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3823         (TestWebKitAPI::TEST):
3824         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3825         (WTR::InjectedBundlePage::willSendRequestForFrame):
3826         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3827         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3828
3829 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
3830
3831         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
3832         https://bugs.webkit.org/show_bug.cgi?id=132446
3833
3834         Reviewed by Mark Hahnenberg.
3835         
3836         Test the FTL by default now that it's enabled by default.
3837
3838         * Scripts/run-javascriptcore-tests:
3839
3840 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
3841
3842         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
3843         https://bugs.webkit.org/show_bug.cgi?id=132240
3844
3845         Reviewed by Anders Carlsson.
3846
3847         Removed ewk_view_setting_tiled_backingstore related code.
3848
3849         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3850         (DumpRenderTreeChrome::createView):
3851         (shouldUseTiledBackingStore): Deleted.
3852         * EWebLauncher/main.c:
3853         (windowCreate):
3854         (parseUserArguments):
3855
3856 2014-05-01  Anders Carlsson  <andersca@apple.com>
3857
3858         window.testRunner.keepWebHistory() should update the UI process state
3859         https://bugs.webkit.org/show_bug.cgi?id=132440
3860
3861         Reviewed by Dan Bernstein.
3862
3863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3864         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3865         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3866         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3867         (WTR::TestRunner::keepWebHistory):
3868         * WebKitTestRunner/TestInvocation.cpp:
3869         (WTR::TestInvocation::invoke):
3870         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3871
3872 2014-05-01  David Kilzer  <ddkilzer@apple.com>
3873
3874         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
3875         <http://webkit.org/b/132432>
3876
3877         Reviewed by Tim Horton.
3878
3879         * Scripts/webkitperl/FeatureList.pm: Remove support for
3880         --plugin-proxy-for-video switch.
3881
3882 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3883
3884         Kernel sysctl interface hw.activecpu don't exists on Linux.
3885         https://bugs.webkit.org/show_bug.cgi?id=132286
3886
3887         Reviewed by Filip Pizlo.
3888
3889         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
3890         calling sysctl over hw.activecpu
3891
3892 2014-04-30  Anders Carlsson  <andersca@apple.com>
3893
3894         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
3895         https://bugs.webkit.org/show_bug.cgi?id=132399
3896         <rdar://problem/15920046>
3897
3898         Reviewed by Dan Bernstein.
3899
3900         * Scripts/check-for-webkit-framework-include-consistency:
3901         Allos WAK headers in WebKitLegacy as well as WebKit.
3902
3903         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3904         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3905         Update header imports.
3906
3907 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
3908
3909         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
3910         https://bugs.webkit.org/show_bug.cgi?id=131954
3911
3912         Reviewed by Darin Adler.
3913         
3914         WebKitTestRunner was adding application-specific information to crash reports
3915         to log the test path, but only in the web process. Fix it to also do this
3916         for the UI process, for both iOS and OS X.
3917         
3918         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
3919         both iOS and OS X.
3920         
3921         Factored crash reprorter-related code into CrashReporterInfo, and call it from
3922         a new TestController::platformWillRunTest() function on Mac and iOS.
3923         
3924         Also remove Xcode-added unit test junk from the project.
3925
3926         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
3927         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3928         * WebKitTestRunner/TestController.cpp:
3929         (WTR::TestController::runTest):
3930         * WebKitTestRunner/TestController.h:
3931         * WebKitTestRunner/TestInvocation.cpp:
3932         (WTR::TestInvocation::url):
3933         * WebKitTestRunner/TestInvocation.h:
3934         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3935         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
3936         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
3937         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
3938         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
3939         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
3940         (WTR::testPathFromURL):
3941         (WTR::setCrashReportApplicationSpecificInformationToURL):
3942         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3943         (WTR::TestController::platformWillRunTest):
3944         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3945         (WTR::TestController::platformWillRunTest):
3946         * WebKitTestRunner/ios/TestControllerIOS.mm:
3947         (WTR::TestController::platformWillRunTest):
3948         (WTR::TestController::setHidden):
3949         * WebKitTestRunner/mac/TestControllerMac.mm:
3950         (WTR::TestController::platformWillRunTest):
3951
3952 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
3953
3954         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
3955
3956         Reviewed by Tim Horton.
3957
3958         * DumpRenderTree/mac/DumpRenderTree.mm:
3959         (resetWebPreferencesToConsistentValues):
3960         (prepareConsistentTestingEnvironment):
3961
3962 2014-04-30  Anders Carlsson  <andersca@apple.com>
3963
3964         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
3965         https://bugs.webkit.org/show_bug.cgi?id=132397
3966
3967         Reviewed by Dan Bernstein.
3968
3969         * Scripts/check-for-inappropriate-macros-in-external-headers:
3970
3971 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
3972
3973         [GTK] Make it easier to run CMake for downstreams
3974         https://bugs.webkit.org/show_bug.cgi?id=132370
3975
3976         Reviewed by Carlos Garcia Campos.
3977
3978         * Scripts/webkitdirs.pm:
3979         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
3980         the GTK+ port.
3981
3982 2014-04-29  Stephanie Lewis  <slewis@apple.com>
3983
3984         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
3985         
3986         Rubber stamped by Jessie Berlin.
3987
3988         JSON.pm was removed from our tools setup.
3989
3990         * Scripts/generate-coverage-data:
3991
3992 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
3993
3994         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
3995         https://bugs.webkit.org/show_bug.cgi?id=112840
3996
3997         Rubber stamped by Geoffrey Garen.
3998
3999         * Scripts/build-jsc: Enable it on Mac.
4000         * Scripts/build-webkit: Enable it on Mac.
4001         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
4002
4003 2014-04-28  Sam Weinig  <sam@webkit.org>
4004
4005         REGRESSION (r167751): svn-create-patch is very slow
4006         https://bugs.webkit.org/show_bug.cgi?id=132300
4007
4008         Reviewed by Alexey Proskuryakov.
4009
4010         * Scripts/svn-create-patch:
4011         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
4012         by calling `svn-create-patch --style`.
4013
4014 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
4015
4016         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
4017         https://bugs.webkit.org/show_bug.cgi?id=132190
4018
4019         Reviewed by Gustavo Noronha Silva.
4020
4021         * Scripts/webkitdirs.pm:
4022         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
4023             if ninja is in the path.
4024         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
4025             to the previous ninja generator if not.
4026
4027 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4028
4029         check-webkit-style should understand --git-index
4030         https://bugs.webkit.org/show_bug.cgi?id=125364
4031
4032         Reviewed by Csaba Osztrogonác.
4033
4034         * Scripts/webkitpy/common/checkout/scm/git.py:
4035         (Git.create_patch): The command now supports the --cached option.
4036         * Scripts/webkitpy/style/main.py:
4037         (CheckWebKitStyle.main): Passing the --git-index option.
4038         * Scripts/webkitpy/style/optparser.py:
4039         (CommandOptionValues.__init__): The git-index option is switched off by default.
4040         (CommandOptionValues.__eq__): Equality check for the new option.
4041         (ArgumentParser._create_option_parser):Adding the --git-index option
4042         (ArgumentParser.parse):
4043         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
4044         (CommandOptionValuesTest.test_init): 
4045         (CommandOptionValuesTest.test_eq):
4046
4047 2014-04-28  Michael Saboff  <msaboff@apple.com>
4048
4049         Crash in platform/mac/accessibility/table-visible-rows.html
4050         https://bugs.webkit.org/show_bug.cgi?id=132146
4051
4052         Reviewed by Filip Pizlo.
4053
4054         Instead of creating a local JSValueRef array on the stack and passing that to
4055         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
4056         values using the JSObjectSetPropertyAtIndex() API.
4057
4058         * DumpRenderTree/AccessibilityUIElement.cpp:
4059         (elementsForRangeCallback):
4060         (convertElementsToObjectArray):
4061         * DumpRenderTree/mac/TestRunnerMac.mm:
4062         (originsArrayToJS):
4063         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4064         (WTR::EventSendingController::contextClick):
4065         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4066         (WTR::stringArrayToJS):
4067         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4068         (WTR::convertElementsToObjectArray):
4069
4070 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
4071
4072         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
4073         "no-cjit" runs force the old-school threshold.
4074
4075         Rubber stamped by Mark Hahnenberg.
4076
4077         * Scripts/run-jsc-stress-tests:
4078
4079 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4080
4081         [GTK] install-dependencies should also install ruby-json and ruby-highline
4082         https://bugs.webkit.org/show_bug.cgi?id=132292
4083
4084         Reviewed by Philippe Normand.
4085
4086         * gtk/install-dependencies: Install ruby json and highline packages.
4087
4088 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
4089
4090         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
4091         https://bugs.webkit.org/show_bug.cgi?id=132176
4092
4093         Reviewed by Gyuyoung Kim.
4094
4095         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
4096         and turn off indexedDB feature until the sqlite implementation is introduced.
4097
4098         * Scripts/webkitperl/FeatureList.pm:
4099
4100 2014-04-25  James Craig  <jcraig@apple.com>
4101
4102         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
4103         https://bugs.webkit.org/show_bug.cgi?id=132209
4104
4105         Reviewed by Daniel Bates.
4106
4107         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
4108         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
4109
4110         * Scripts/prepare-ChangeLog:
4111         (main): 
4112
4113 2014-04-25  Michael Saboff  <msaboff@apple.com>
4114
4115         Crash in platform/mac/accessibility/table-visible-rows.html
4116         https://bugs.webkit.org/show_bug.cgi?id=132146
4117
4118         Reviewed by Mark Lam.
4119
4120         Changed to use a local JSValueRef array temporary instead of a
4121         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
4122         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
4123         the temporary values could be collected.
4124
4125         * DumpRenderTree/AccessibilityUIElement.cpp:
4126         (convertElementsToObjectArray):
4127         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4128         (WTR::EventSendingController::contextClick):
4129         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4130         (WTR::convertElementsToObjectArray):
4131
4132 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
4133
4134         Unreviewed GTK gardening
4135
4136         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
4137         (TestRunner):
4138
4139 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
4140
4141         prepare-ChangeLog reports as deleted methods that has not been removed.
4142         https://bugs.webkit.org/show_bug.cgi?id=131733
4143
4144         Reviewed by Ryosuke Niwa.
4145
4146         * Scripts/prepare-ChangeLog:
4147         (originalFile): Set merge base to origin/master by default.
4148
4149 2014-04-23  James Craig  <jcraig@apple.com>
4150
4151         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
4152         https://bugs.webkit.org/show_bug.cgi?id=131115
4153
4154         Reviewed by Daniel Bates.
4155
4156         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
4157
4158         * Scripts/commit-log-editor: Added --no-style.
4159         * Scripts/prepare-ChangeLog: Primary patch.
4160         (main): Primary patch.
4161         (createPatchCommand): Added --no-style.
4162         * Scripts/svn-create-patch: Primary patch.
4163         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
4164         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
4165         (SVN.create_patch): Added --no-style.
4166
4167 2014-04-23  Anders Carlsson  <andersca@apple.com>
4168
4169         Try to fix iOS build.
4170
4171         * DumpRenderTree/mac/DumpRenderTree.mm:
4172
4173 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
4174
4175         Eliminate internals.setMockScrollbarsEnabled()
4176         https://bugs.webkit.org/show_bug.cgi?id=132085
4177
4178         Reviewed by Tim Horton.
4179
4180         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
4181         No need to reset the preference, there is no way it can change.
4182
4183 2014-04-23  James Craig  <jcraig@apple.com>
4184
4185         Unreviewed. Moving myself from Contributors to Committers list.
4186
4187         * Scripts/webkitpy/common/config/contributors.json:
4188
4189 2014-04-23  Tim Horton  <timothy_horton@apple.com>
4190
4191         Mock scrollbars don't always work in DumpRenderTree
4192         https://bugs.webkit.org/show_bug.cgi?id=132082
4193
4194         Reviewed by Alexey Proskuryakov.
4195
4196         * DumpRenderTree/mac/DumpRenderTree.mm:
4197         (prepareConsistentTestingEnvironment):
4198         Set the mock scrollbar setting before creating the WebView, as this setting
4199         cannot be dynamically changed, so any scrollbars that are created during
4200         WebView initialization and are not replaced before snapshotting will end
4201         up being platform scrollbars instead of mock ones.
4202         WebKitTestRunner already sets this preference before creating WKViews,
4203         so we're just matching its behavior.
4204
4205 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4206
4207         [GTK] ShadowRoot API was removed in r164131
4208         https://bugs.webkit.org/show_bug.cgi?id=132059
4209
4210         Reviewed by Gustavo Noronha Silva.
4211
4212         Add WebKitDOMShadowRoot to the list of deleted classes to generate
4213         the API docs.
4214
4215         * gtk/webkitdom.py:
4216         (WebKitDOMDocGenerator):
4217
4218 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
4219
4220         [GTK] run-webkit-tests script is failing to invoke run-launcher
4221         https://bugs.webkit.org/show_bug.cgi?id=132051
4222
4223         Reviewed by Philippe Normand.
4224
4225         After the WK1 support was dropped, if run-webkit-tests is executed
4226         without --no-show-results parameter, the launcher is being called
4227         using a -2 parameter that is it causing the run-launcher to break.
4228
4229         * Scripts/webkitpy/port/gtk.py:
4230         (GtkPort.show_results_html_file):
4231
4232 2014-04-22  Tim Horton  <timothy_horton@apple.com>
4233
4234         DumpRenderTree generates black snapshots on some platforms
4235         https://bugs.webkit.org/show_bug.cgi?id=132029
4236         <rdar://problem/16679363>
4237
4238         Reviewed by Simon Fraser.
4239
4240         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4241         (createBitmapContextFromWebView):
4242         DRT checks with the WebView to determine whether it can use the window's
4243         backing store directly or (because of compositing) needs to take a WindowServer
4244         snapshot. However, on some platforms and in some situations, the window can
4245         be layer backed without the WebView necessarily currently being composited.
4246         We should check with the window in addition to the WebView before going
4247         ahead and using its backing store.
4248
4249 2014-04-22  Tim Horton  <timothy_horton@apple.com>
4250
4251         DumpRenderTree generates white snapshots on some platforms
4252         https://bugs.webkit.org/show_bug.cgi?id=132026
4253         <rdar://problem/16679363>
4254
4255         Reviewed by Simon Fraser.
4256
4257         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
4258         Link DRT against QuartzCore.
4259
4260         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4261         (createBitmapContextFromWebView):
4262         Force CoreAnimation to synchronously update layers in a more explicit
4263         way that doesn't depend on AppKit behavior. This is very similar to what
4264         WebKitTestRunner does (indirectly) during its force repaint.
4265
4266 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
4267
4268         [Win] Support Python 2.7 in Cygwin
4269         https://bugs.webkit.org/show_bug.cgi?id=132023
4270
4271         Reviewed by Michael Saboff.
4272
4273         * Scripts/webkitdirs.pm:
4274         (checkInstalledTools): Remove check for Python 2.7, since
4275         it now works properly.
4276
4277 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
4278
4279         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
4280         https://bugs.webkit.org/show_bug.cgi?id=130867
4281         <rdar://problem/16432456> 
4282
4283         Reviewed by Mark Hahnenberg.
4284
4285         * Scripts/build-webkit:
4286         * Scripts/copy-webkitlibraries-to-product-directory:
4287
4288 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
4289
4290         [GTK] Fails to build documentation when output is redirected
4291         https://bugs.webkit.org/show_bug.cgi?id=131178
4292
4293         Reviewed by Martin Robinson.
4294
4295         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
4296         explicitly to avoid encoding issues when they are redirected.
4297
4298 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
4299
4300         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
4301         https://bugs.webkit.org/show_bug.cgi?id=131911
4302
4303         Reviewed by Martin Robinson.
4304
4305         common.get_build_path returns release path even though Debug configuration
4306         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
4307
4308         * gtk/ycm_extra_conf.py:
4309         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
4310         (FlagsForFile):
4311
4312 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
4313
4314         Unreviewed build fix.
4315
4316         * DumpRenderTree/mac/EventSendingController.mm:
4317         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
4318         Correct a typo that prevented tests from working properly.
4319
4320 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
4321
4322         [GTK] Should have the ability to output composited contents during layout testing
4323         https://bugs.webkit.org/show_bug.cgi?id=131864
4324
4325         Reviewed by Philippe Normand.
4326
4327         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
4328         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
4329         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
4330         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4331         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
4332
4333 2014-04-21  Sam Weinig  <sam@webkit.org>
4334
4335         Attempt to fix the tests.
4336
4337         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
4338         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4339         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
4340