Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2
3         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
4         https://bugs.webkit.org/show_bug.cgi?id=175797
5         <rdar://problem/29270035>
6
7         Reviewed by Geoffrey Garen.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
11         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
12         (-[UITestDelegate _showPage:]):
13         (-[UITestDelegate webView:startURLSchemeTask:]):
14         (-[UITestDelegate webView:stopURLSchemeTask:]):
15         (TEST):
16
17 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
18
19         Fix leak-checking for iOS Simulators
20         https://bugs.webkit.org/show_bug.cgi?id=175735
21
22         Reviewed by David Kilzer.
23
24         Follow-up fix to r220942. _proc may be undefined.
25
26         * Scripts/webkitpy/port/server_process.py:
27         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
28
29 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
30
31         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
32         https://bugs.webkit.org/show_bug.cgi?id=175822
33
34         Reviewed by Xabier Rodriguez-Calvar.
35
36         * gtk/install-dependencies: Add the bad plugins to the list.
37         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
38
39 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
40
41         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
42         https://bugs.webkit.org/show_bug.cgi?id=175787
43         <rdar://problem/33996612>
44
45         Reviewed by Wenson Hsieh.
46
47         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
48         (TestWebKitAPI::TEST):
49
50 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
51
52         Typo in "webkit-patch land"
53         https://bugs.webkit.org/show_bug.cgi?id=175788
54
55         Reviewed by Tim Horton.
56
57         * Scripts/webkitpy/tool/steps/commit.py:
58         (Commit._commit_warning):
59
60 2017-08-20  Sam Weinig  <sam@webkit.org>
61
62         StringView could use a function to strip leading/trailing characters without allocation
63         https://bugs.webkit.org/show_bug.cgi?id=175757
64
65         Reviewed by Darin Adler.
66
67         * TestWebKitAPI/Tests/WTF/StringView.cpp:
68         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
69
70 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
71
72         [PAL] Move spi/mac directory into PAL
73         https://bugs.webkit.org/show_bug.cgi?id=175649
74
75         Reviewed by Myles C. Maxfield.
76
77         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
78
79 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
80
81         [Win] DRT should only allow any https certificate for localhost.
82         https://bugs.webkit.org/show_bug.cgi?id=175147
83
84         Reviewed by Brent Fulgham.
85
86         Add check to make sure only localhost requests allow any https certificate.
87
88         * DumpRenderTree/win/DumpRenderTree.cpp:
89         (runTest):
90
91 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
92
93         Add WTFLogChannel level to allow runtime log filtering
94         https://bugs.webkit.org/show_bug.cgi?id=175731
95         <rdar://problem/33967234>
96
97         Unreviewed build fix.
98
99         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
100         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
101         fails on some of the bots.
102
103 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
104
105         Add WTFLogChannel level to allow runtime log filtering
106         https://bugs.webkit.org/show_bug.cgi?id=175731
107         <rdar://problem/33967234>
108
109         Reviewed by Jer Noble.
110
111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
112         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
113         (TestWebKitAPI::LoggingTest::output):
114         (TestWebKitAPI::TEST_F):
115
116 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
117
118         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
119         https://bugs.webkit.org/show_bug.cgi?id=175509
120         <rdar://problem/33728169>
121
122         Reviewed by Ryosuke Niwa.
123
124         Removes ExternalSourceAttributedStringToContentEditable and adds
125         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
126         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
127         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
128         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
129         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
130         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
131
132         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
133
134         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
135         (TestWebKitAPI::TEST):
136
137 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
138
139         Unreviewed, rolling out r220938.
140
141         The API tests added with this change are failing.
142
143         Reverted changeset:
144
145         "Add WTFLogChannel level to allow runtime log filtering"
146         https://bugs.webkit.org/show_bug.cgi?id=175731
147         http://trac.webkit.org/changeset/220938
148
149 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
150
151         Unreviewed, change my email.
152
153         * Scripts/webkitpy/common/config/contributors.json:
154
155 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
156
157         Fix leak-checking for iOS Simulators
158         https://bugs.webkit.org/show_bug.cgi?id=175735
159
160         Reviewed by Darin Adler.
161
162         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
163         Simulator (or device) because the process will have already been killed by the time we
164         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
165
166         * Scripts/webkitpy/port/server_process.py:
167         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
168         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
169         and SimulatorProcess.
170         * Scripts/webkitpy/port/simulator_process.py:
171         (SimulatorProcess.stop): Before closing the process, check for leaks.
172
173 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
174
175         Add WTFLogChannel level to allow runtime log filtering
176         https://bugs.webkit.org/show_bug.cgi?id=175731
177         <rdar://problem/33967234>
178
179         Reviewed by Jer Noble.
180
181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
182         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
183         (TestWebKitAPI::LoggingTest::output):
184         (TestWebKitAPI::TEST_F):
185
186 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
187
188         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
189
190         * Scripts/webkitpy/common/config/contributors.json:
191
192 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
193
194         [Tools] Add script to download a GitHub release
195         https://bugs.webkit.org/show_bug.cgi?id=175279
196
197         Reviewed by Brent Fulgham.
198
199         * Scripts/download-latest-github-release.py: Added.
200
201 2017-08-18  Commit Queue  <commit-queue@webkit.org>
202
203         Unreviewed, rolling out r220854.
204         https://bugs.webkit.org/show_bug.cgi?id=175716
205
206         I'm not sure we really need this (Requested by KaL on
207         #webkit).
208
209         Reverted changeset:
210
211         "[GTK][WPE] Add NTLM authentication enabled API"
212         https://bugs.webkit.org/show_bug.cgi?id=122952
213         http://trac.webkit.org/changeset/220854
214
215 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
216
217         [GTK] Make TestContextMenu work on Fedora
218         https://bugs.webkit.org/show_bug.cgi?id=175708
219
220         Reviewed by Carlos Garcia Campos.
221
222         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
223         and my student last summer who was trying to work on a context menu API. It's trying to load
224         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
225         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
226         don't care to investigate. Let's switch it to WebM so I can move on.
227
228         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
229         (prepareContextMenuTestView):
230         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
231         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
232
233 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
234
235         check-webkit-style shouldn't check spacing in #elif preprocessor lines
236         https://bugs.webkit.org/show_bug.cgi?id=175652
237
238         Reviewed by Alex Christensen.
239
240         * Scripts/webkitpy/style/checkers/cpp.py:
241         (check_spacing):
242         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
243         (CppStyleTest.test_spacing_for_binary_ops):
244
245 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
246
247         Fix the build on other platforms after r220865
248         https://bugs.webkit.org/show_bug.cgi?id=175683
249
250         Reviewed by Tim Horton.
251
252         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
253         availability is determined by SDK version rather than deployment version.
254
255         * TestWebKitAPI/ios/UIKitSPI.h:
256
257 2017-08-17  Andreas Kling  <akling@apple.com>
258
259         Disable CSS regions at compile time
260         https://bugs.webkit.org/show_bug.cgi?id=175630
261
262         Reviewed by Antti Koivisto.
263
264         * Scripts/webkitperl/FeatureList.pm:
265         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
266
267 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
268
269         Unreviewed, try to fix the internal iOS 10 build after r220865.
270
271         * TestWebKitAPI/ios/UIKitSPI.h:
272
273         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
274         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
275         this compiler guard.
276
277 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         [iOS] Respect type fidelities when copying image elements to the pasteboard
280         https://bugs.webkit.org/show_bug.cgi?id=175638
281         <rdar://problem/26556043>
282
283         Reviewed by Ryosuke Niwa.
284
285         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
286         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
287         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
288
289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
290         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
291         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
292         (TestWebKitAPI::TEST):
293         (TestWebKitAPI::presentActionSheetAndChooseAction):
294         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
295         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
296         (checkEstimatedSize):
297         (checkSuggestedNameAndEstimatedSize):
298
299         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
300
301         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/ios/DataInteractionSimulator.h:
304         * TestWebKitAPI/ios/UIKitSPI.h: Added.
305
306 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
307
308         Recursively create resource load statistics folder for testing
309         https://bugs.webkit.org/show_bug.cgi?id=175676
310
311         Reviewed by Brady Eidson.
312
313         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
314         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
315
316 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
317
318         [GTK][WPE] Add NTLM authentication enabled API
319         https://bugs.webkit.org/show_bug.cgi?id=122952
320
321         Reviewed by Michael Catanzaro.
322
323         Add a test case to check we can enable/disable NTLM.
324
325         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
326         (testWebViewAuthenticationNTLM):
327         (beforeAll):
328
329 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
330
331         [PAL] Move spi/ios and spi/win directories into PAL
332         https://bugs.webkit.org/show_bug.cgi?id=175171
333
334         Reviewed by Antti Koivisto.
335
336         * DumpRenderTree/mac/EventSendingController.mm:
337
338 2017-08-16  Andy Estes  <aestes@apple.com>
339
340         [Payment Request] Add an ENABLE flag and an experimental feature preference
341         https://bugs.webkit.org/show_bug.cgi?id=175622
342
343         Reviewed by Tim Horton.
344
345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
346         * WebKitTestRunner/TestController.cpp:
347         (WTR::TestController::resetPreferencesToConsistentValues):
348
349 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
350
351         undefined URL in PopoverTracker for failed step
352         https://bugs.webkit.org/show_bug.cgi?id=175593
353         <rdar://problem/33898769>
354
355         Reviewed by Daniel Bates.
356
357         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
358         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
359
360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
361         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
362         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
364         (BuildbotTestResults): Accept URL in constructor.
365
366 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
367
368         Remove Proximity Events and related code
369         https://bugs.webkit.org/show_bug.cgi?id=175545
370
371         Reviewed by Daniel Bates.
372
373         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
374         and other related code.
375
376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
377
378 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
379
380         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
381         https://bugs.webkit.org/show_bug.cgi?id=175504
382
383         Reviewed by Sam Weinig.
384
385         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
386
387 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
388
389         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
390         https://bugs.webkit.org/show_bug.cgi?id=175557
391
392         Reviewed by Jon Lee.
393         
394         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
395
396         * DumpRenderTree/TestRunner.cpp:
397         (TestRunner::staticFunctions):
398         (setViewModeMediaFeatureCallback): Deleted.
399         * DumpRenderTree/TestRunner.h:
400         * DumpRenderTree/mac/TestRunnerMac.mm:
401         (TestRunner::setViewModeMediaFeature): Deleted.
402         * DumpRenderTree/win/TestRunnerWin.cpp:
403         (TestRunner::setViewModeMediaFeature): Deleted.
404         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
405
406 2017-08-14  Andy Estes  <aestes@apple.com>
407
408         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
409         https://bugs.webkit.org/show_bug.cgi?id=175548
410         <rdar://problem/33866206>
411
412         Reviewed by Brady Eidson.
413
414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
415         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
416         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
417
418 2017-08-14  Youenn Fablet  <youenn@apple.com>
419
420         WPT server should be able to do logging even if its output folder is not created at launch time
421         https://bugs.webkit.org/show_bug.cgi?id=175543
422
423         Reviewed by Alexey Proskuryakov.
424
425         Removing no longer used stdout/stderr member variables.
426         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
427
428         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
429         (WebPlatformTestServer.__init__):
430         (WebPlatformTestServer._prepare_config):
431         (WebPlatformTestServer._spawn_process):
432         (WebPlatformTestServer._stop_running_server):
433
434 2017-08-14  Daniel Bates  <dabates@apple.com>
435
436         webkit-patch: Passing --no-review should submit patch to EWS by default
437         https://bugs.webkit.org/show_bug.cgi?id=148899
438
439         Reviewed by David Kilzer.
440
441         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
442         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
443         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
444
445         Frequently I want to post a draft of a patch without review to have the EWS bots process
446         it to catch build and test breakage before I clean it up and post it for formal review.
447         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
448         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
449         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
450
451         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
452         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
453         parse the attachment id from the response page after adding an attachment to the bug.
454         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
455         HTTP response after uploading the patch.
456         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
457         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
458         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
459         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
460         * Scripts/webkitpy/tool/commands/upload.py:
461         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
462         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
463         this command.
464         (PostCommits.execute): Submit the patch to EWS, if applicable.
465         * Scripts/webkitpy/tool/commands/upload_unittest.py:
466         (test_upload): Set options.ews to False as the upload command expects this option
467         to be specified.
468         (test_upload_with_no_review_and_ews): Added.
469         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
470         * Scripts/webkitpy/tool/steps/options.py:
471         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
472         * Scripts/webkitpy/tool/steps/postdiff.py:
473         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
474         this command.
475         (PostDiff.run): Submit the patch to EWS, if applicable.
476         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
477         (SubmitToEWS):
478         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
479         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
480
481 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
482
483         Disable two flaky VideoControlsManager API tests.
484
485         Unreviewed test gardening.
486
487         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
488         (TestWebKitAPI::TEST):
489
490 2017-08-14  Tim Horton  <timothy_horton@apple.com>
491
492         Only create directory and sandbox extension handle for storage directories if they are set
493         https://bugs.webkit.org/show_bug.cgi?id=175522
494
495         Reviewed by Brady Eidson.
496
497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
498         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
499         (TEST):
500         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
501         doesn't log anything to stderr.
502
503 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
504
505         sub-categorize Sandbox violation logs
506         https://bugs.webkit.org/show_bug.cgi?id=175536
507         <rdar://problem/33834416>
508
509         Reviewed by David Kilzer.
510
511         * Scripts/webkitpy/common/system/crashlogs.py:
512         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
513         a Sandbox violation.
514         (CrashLogs._find_all_logs_darwin): Update comment.
515         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
516         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
517         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
518         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
519         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
520         * Scripts/webkitpy/port/darwin.py:
521         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
522
523 2017-08-14  Daniel Bates  <dabates@apple.com>
524
525         Add Automator service to copy permalink to Clipboard
526         https://bugs.webkit.org/show_bug.cgi?id=170978
527
528         Reviewed by Joseph Pecoraro.
529
530         It is helpful to reference using a hyperlink a particular line of code when having
531         a discussion on IRC or in a bug. You can get such a link by navigating to the file
532         in the Trac Browse Source viewer and selecting the line your are interested in.
533         I found myself doing this often enough that I wrote an Automator service to do it
534         for me.
535
536         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
537
538         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
539         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
540         * CopyPermalink/README: Added.
541
542 2017-08-14  Chris Dumez  <cdumez@apple.com>
543
544         Address flakiness related to download tests
545         https://bugs.webkit.org/show_bug.cgi?id=175338
546         <rdar://problem/33865119>
547
548         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
549         between tests.
550
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::TestController::resetStateToConsistentValues):
553
554 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
555
556         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
557         https://bugs.webkit.org/show_bug.cgi?id=175474
558         <rdar://problem/33844628>
559
560         Reviewed by Wenson Hsieh.
561
562         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
563
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (resetWebPreferencesToConsistentValues):
566         * WebKitTestRunner/TestController.cpp:
567         (WTR::TestController::resetPreferencesToConsistentValues):
568
569 2017-08-12  Chris Dumez  <cdumez@apple.com>
570
571         Address flakiness related to download tests
572         https://bugs.webkit.org/show_bug.cgi?id=175338
573
574         Reviewed by Ryosuke Niwa.
575
576         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
577           is actually queried when a download completes. Previously, this would be
578           identical to a call to testRunner.waitUntilDone() because any download
579           completion would call testRunner.notifyDone().
580         - Disable logging of download callbacks by default and add a
581           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
582           enable such logging.
583
584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
586         (WTR::InjectedBundle::didReceiveMessageToPage):
587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
588         (WTR::TestRunner::setShouldLogDownloadCallbacks):
589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::TestController::downloadDidStart):
592         (WTR::TestController::decideDestinationWithSuggestedFilename):
593         (WTR::TestController::downloadDidFinish):
594         (WTR::TestController::downloadDidFail):
595         (WTR::TestController::downloadDidCancel):
596         * WebKitTestRunner/TestController.h:
597         (WTR::TestController::setShouldLogDownloadCallbacks):
598         * WebKitTestRunner/TestInvocation.cpp:
599         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
600
601 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
602
603         Create mock ITP data in testing to prevent grandfathering
604         https://bugs.webkit.org/show_bug.cgi?id=174720
605
606         Unreviewed follow-up fix for r220604.
607
608         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
609         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
610
611 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
612
613         Create mock ITP data in testing to prevent grandfathering
614         https://bugs.webkit.org/show_bug.cgi?id=174720
615         <rdar://problem/33457779>
616
617         Reviewed by Brent Fulgham.
618
619         We don't need to be triggering grandfathering when each test runner starts. On Mac,
620         this may launch plugins which can cause layout tests to fail later if the test
621         runner does not shut-down before the plugins unload.
622
623         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
624         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
625         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
626         prevent grandfathering from being triggered.
627         * WebKitTestRunner/ios/TestControllerIOS.mm:
628         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
629         * WebKitTestRunner/mac/TestControllerMac.mm:
630         (WTR::TestController::platformInitialize): Ditto.
631
632 2017-08-11  Sam Weinig  <sam@webkit.org>
633
634         WTF::Function does not allow for reference / non-default constructible return types
635         https://bugs.webkit.org/show_bug.cgi?id=175244
636         <rdar://problem/33801582>
637
638         Reviewed by Chris Dumez.
639
640         * TestWebKitAPI/Tests/WTF/Function.cpp:
641         (TestWebKitAPI::TEST):
642
643 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
644
645         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
646         https://bugs.webkit.org/show_bug.cgi?id=175378
647
648         Reviewed by Sergio Villar Senin.
649
650         Add two test cases to check proxy authentication.
651
652         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
653         (Tunnel::Tunnel):
654         (Tunnel::~Tunnel):
655         (Tunnel::connect):
656         (Tunnel::connected):
657         (serverCallback):
658         (ProxyAuthenticationTest::ProxyAuthenticationTest):
659         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
660         (ProxyAuthenticationTest::proxyServerPortAsString):
661         (testWebViewAuthenticationProxy):
662         (testWebViewAuthenticationProxyHTTPS):
663         (beforeAll):
664
665 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
666
667         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
668         https://bugs.webkit.org/show_bug.cgi?id=175428
669
670         Both ports share the GStreamer code as multimedia backend and till
671         not so long they were using different versions. Now they do use
672         the same versions and it does not make any sense anymore (and
673         neither had sense before) to have differences in the modulesets.
674
675         In this patch I created a GStreamer moduleset and referenced it
676         from both GTK+'s and WPE's. GStreamer patches were also moved there.
677
678         Reviewed by Žan Doberšek.
679
680         * gstreamer/jhbuild.modules: Added.
681         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
682         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
683         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
684         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
685         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
686         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
687         * gtk/jhbuild.modules:
688         * wpe/jhbuild.modules:
689         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
690         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
691         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
692         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
693         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
694
695 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
696
697         Unreviewed, adding Ross Kirsling to contributors.json
698
699         * Scripts/webkitpy/common/config/contributors.json:
700
701 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
702
703         Unreviewed, attempt to fix build failure with VC2017
704
705         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
706         (TEST):
707
708 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
709
710         Unreviewed, suppress warnings on GCC
711
712         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
713         (TestWebKitAPI::CheckedArithmeticTester::run):
714
715 2017-08-10  Dan Bernstein  <mitz@apple.com>
716
717         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
718         https://bugs.webkit.org/show_bug.cgi?id=173223
719
720         Reviewed by Tim Horton.
721
722         The rebuilds were happening due to a difference in the compiler options that the IDE and
723         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
724         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
725         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
726         Advanced when a Custom Absolute path is selected.
727
728         * Scripts/webkitdirs.pm:
729         (determineBaseProductDir):
730
731 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
732
733         Run more WTF tests
734         https://bugs.webkit.org/show_bug.cgi?id=174970
735
736         Reviewed by Michael Catanzaro.
737
738         Some of WTF tests are not executed in non Apple ports while they are generic ones.
739         This patch adds these tests to non-Apple port TestWebKitAPI.
740         Currently, we do not add Signals.cpp since it depends on signal functionality.
741
742         * TestWebKitAPI/CMakeLists.txt:
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
744         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
745         (isHigherPriority):
746         (TEST):
747         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
748         (TEST):
749         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
750         (TEST):
751
752 2017-08-10  obinna obike  <oobike@apple.com>
753
754         Remove obsolete link from webkit-queues status page
755         https://bugs.webkit.org/show_bug.cgi?id=175337
756
757         Reviewed by Aakash Jain.
758
759         * QueueStatusServer/templates/recentstatus.html:
760         Removed the link to the ews-watcher server.
761
762 2017-08-10  Brian Burg  <bburg@apple.com>
763
764         WKPreferences should conform to NSCopying
765         https://bugs.webkit.org/show_bug.cgi?id=175303
766         <rdar://problem/33764939>
767
768         Reviewed by Dan Bernstein.
769
770         Add unit test to make sure a WKPreference and its copy are
771         not aliased to each other or affect each other's properties.
772
773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
774         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
775         (TEST):
776
777 2017-08-10  Tim Horton  <timothy_horton@apple.com>
778
779         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
780         https://bugs.webkit.org/show_bug.cgi?id=175436
781         <rdar://problem/33667497>
782
783         Reviewed by Simon Fraser.
784
785         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
786         (TestWebKitAPI::TEST_F):
787
788 2017-08-10  Lucas Forschler  <lforschler@apple.com>
789
790         Fix duplicated code in r220534.
791
792         Unreviewed cleanup.
793
794         * Scripts/bisect-builds:
795
796 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
797
798         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
799         https://bugs.webkit.org/show_bug.cgi?id=175344
800         <rdar://problem/28507240>
801
802         Reviewed by Alexey Proskuryakov.
803
804         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
805         Finally enable the existing tests for iOS.
806
807         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
808         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
810         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
811
812 2017-08-10  Lucas Forschler  <lforschler@apple.com>
813
814         Write a tool to bisect WebKit builds
815         https://bugs.webkit.org/show_bug.cgi?id=174596
816
817         Reviewed by Dean Johnson and Kocsen Chung.
818
819         * Scripts/bisect-builds: Added.
820         (bisect_builds): main bisection algorithm
821         (download_archive):download an archive from S3 using existing tools
822         (extract_archive):extract an archive using existing tools
823         (find_le):Find rightmost value less than or equal to x
824         (find_ge):Find leftmost item greater than or equal to x
825         (get_api_url):generate url for the rest api/database
826         (get_indices_from_revisions):convert revisions to list indexes for bisection
827         (get_sorted_revisions):retrieve sorted revision list
828         (get_s3_location_for_revision):calculate the S3 archive storage location
829         (parse_args):parse command line arguments
830         (pick_next_build):compute the next build to bisect
831         (prompt_did_reproduce):prompt user for direction for bisection
832         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
833         (test_archive):Platform specific logic to test downloaded archive
834         (minified_platforms):return a list of minified platforms in the database
835         (unminified_platforms):return a list of full platforms in the database
836         (is_supported_platform):check if platform is supported
837         (validate_options):validate command line options
838         (main):
839
840 2017-08-10  Lucas Forschler  <lforschler@apple.com>
841
842         Remove bisect-builds script.
843         https://bugs.webkit.org/show_bug.cgi?id=175433
844         
845         Reviewed by Aakash Jain.
846
847         * Scripts/bisect-builds: Removed.
848
849 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
850
851         Remove ENABLE_GAMEPAD_DEPRECATED
852         https://bugs.webkit.org/show_bug.cgi?id=175361
853
854         Reviewed by Carlos Garcia Campos.
855
856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
857
858 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
859
860         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
861         https://bugs.webkit.org/show_bug.cgi?id=175426
862
863         Reviewed by Carlos Garcia Campos.
864
865         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
866
867 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
868
869         Add Ms2ger as contributor.
870         https://bugs.webkit.org/show_bug.cgi?id=175325
871
872         Reviewed by Carlos Alberto Lopez Perez.
873
874         * Scripts/webkitpy/common/config/contributors.json:
875
876 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
877
878         Fix run-benchmark after r220483.
879         https://bugs.webkit.org/show_bug.cgi?id=175415
880         <rdar://problem/33803003>
881
882         Reviewed by Ryosuke Niwa.
883
884         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
885
886         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
887         (WebServerBenchmarkRunner._run_one_test):
888
889 2017-08-09  Chris Dumez  <cdumez@apple.com>
890
891         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
892         https://bugs.webkit.org/show_bug.cgi?id=175401
893
894         Reviewed by Brady Eidson.
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (enableExperimentalFeatures):
898
899 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
900
901         [PAL] Move spi/cocoa and spi/cg directories into PAL
902         https://bugs.webkit.org/show_bug.cgi?id=175175
903
904         Reviewed by Myles C. Maxfield.
905
906         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
907         * DumpRenderTree/mac/DumpRenderTree.mm:
908         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
909         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
910
911         * Scripts/webkitpy/style/checker.py:
912         * Scripts/webkitpy/style/checker_unittest.py:
913         (GlobalVariablesTest.test_path_rules_specifier):
914
915         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
916
917         * Scripts/webkitpy/style/checkers/cpp.py:
918         (check_braces):
919         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
920         (WebKitStyleTest.test_braces.CF_OPTIONS):
921         (WebKitStyleTest.test_braces):
922
923         Prevent CF_OPTIONS() from being handled as funtion definition.
924
925 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
926
927         [WTF] Move TextStream into WTF
928         https://bugs.webkit.org/show_bug.cgi?id=175211
929
930         Reviewed by Myles C. Maxfield.
931
932         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
933
934 2017-08-09  Andy Estes  <aestes@apple.com>
935
936         Part 3 of: Rename DatabaseProcess to StorageProcess
937         https://bugs.webkit.org/show_bug.cgi?id=175034
938
939         Reviewed by Brady Eidson.
940
941         * WebKitTestRunner/TestController.cpp:
942         (WTR::TestController::databaseProcessName): Updated to return
943         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
944
945 2017-08-09  Commit Queue  <commit-queue@webkit.org>
946
947         Unreviewed, rolling out r220466, r220477, and r220487.
948         https://bugs.webkit.org/show_bug.cgi?id=175411
949
950         This change broke existing API tests and follow up fixes did
951         not resolve all the issues. (Requested by ryanhaddad on
952         #webkit).
953
954         Reverted changesets:
955
956         https://bugs.webkit.org/show_bug.cgi?id=175244
957         http://trac.webkit.org/changeset/220466
958
959         "WTF::Function does not allow for reference / non-default
960         constructible return types"
961         https://bugs.webkit.org/show_bug.cgi?id=175244
962         http://trac.webkit.org/changeset/220477
963
964         https://bugs.webkit.org/show_bug.cgi?id=175244
965         http://trac.webkit.org/changeset/220487
966
967 2017-08-09  Sam Weinig  <sam@webkit.org>
968
969         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
970
971         Remove one addition of null Function test.
972
973 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
974
975         Allow nested timeouts in webkitpy
976         https://bugs.webkit.org/show_bug.cgi?id=175390
977         <rdar://problem/33803003>
978
979         Reviewed by David Kilzer.
980
981         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
982         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
983         the executive to detect and recover from any issues connecting with devices.
984
985         * Scripts/webkitpy/benchmark_runner/utils.py:
986         (TimeoutError): Deleted.
987         (timeout): Deleted.
988         * Scripts/webkitpy/common/timeout_context.py: Added.
989         (Timeout): A timeout context designed to be nested.
990         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
991         (Timeout.TimeoutData.__init__):
992         (Timeout.default_handler): Timeout handler used if none is specified.
993         (Timeout.current): Access data about the most urgent timeout.
994         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
995         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
996         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
997         urgent timeout data.
998         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
999         most urgent timeout data, if such data exists.
1000         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
1001         (TimeoutContextTests):
1002         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
1003         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
1004         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
1005         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
1006         over a less urgent outer timeout.
1007         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
1008         over a less urgent inner timeout.
1009         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
1010         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
1011         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
1012         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
1013         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
1014         * Scripts/webkitpy/port/simulator_process.py:
1015         (SimulatorProcess._start): Use Timeout class.
1016         * Scripts/webkitpy/xcode/simulated_device.py:
1017         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
1018         (SimulatedDevice.launch_app): Ditto.
1019         (SimulatedDevice.launch_app._install_timeout): Deleted.
1020         * Scripts/webkitpy/xcode/simulator.py:
1021         (Simulator.wait_until_device_is_booted):Use Timeout class.
1022         (Simulator.wait_until_device_is_in_state): Ditto.
1023
1024 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1025
1026         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1027         https://bugs.webkit.org/show_bug.cgi?id=175392
1028         <rdar://problem/33783207>
1029
1030         Reviewed by Tim Horton and Megan Gardner.
1031
1032         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1033
1034         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1035
1036 2017-08-09  Sam Weinig  <sam@webkit.org>
1037
1038         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1039
1040         * TestWebKitAPI/Tests/WTF/Function.cpp:
1041         Remove tests of null Functions, as they are no longer supported.
1042
1043 2017-08-09  Daniel Bates  <dabates@apple.com>
1044
1045         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1046         https://bugs.webkit.org/show_bug.cgi?id=175247
1047         <rdar://problem/33679804>
1048
1049         Reviewed by Brady Eidson.
1050
1051         Add tests for redirects.
1052
1053         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1054         (TEST):
1055         * TestWebKitAPI/cocoa/TestProtocol.mm:
1056         (createRedirectURL):
1057         (-[TestProtocol startLoading]):
1058
1059 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1060
1061         Unreviewed, rolling out r220393.
1062
1063         This patch regresses the performance of WebPage::editorState.
1064
1065         Reverted changeset:
1066
1067         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1068         cmb+b,i,u inside a contenteditable div"
1069         https://bugs.webkit.org/show_bug.cgi?id=175116
1070         http://trac.webkit.org/changeset/220393
1071
1072 2017-08-08  obinna obike  <oobike@apple.com>
1073
1074         Created Individual EWS Pages
1075         https://bugs.webkit.org/show_bug.cgi?id=174477
1076
1077         Reviewed by Aakash Jain.
1078
1079         Created individual pages for each EWS. Changed the link within each status bubble
1080         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1081
1082         * QueueStatusServer/handlers/patch.py:
1083         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1084         * QueueStatusServer/handlers/statusbubble.py:
1085         (StatusBubble._build_bubble): Updated url for specific EWS.
1086         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1087         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1088         all ews queues.
1089         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1090         takes you directly to the individual ews page.
1091
1092 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1093
1094         Separate jsc stress test script writer from run-jsc-stress-tests
1095         https://bugs.webkit.org/show_bug.cgi?id=175216
1096
1097         Reviewed by Mark Lam.
1098
1099         * Scripts/run-jsc-stress-tests:
1100         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1101
1102 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1103
1104         Unreviewed, fix Ubuntu LTS build
1105         https://bugs.webkit.org/show_bug.cgi?id=174490
1106
1107         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1108
1109 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1112         https://bugs.webkit.org/show_bug.cgi?id=175302
1113         <rdar://problem/33762116>
1114
1115         Reviewed by Tim Horton.
1116
1117         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1118         See WebKit ChangeLog for more details.
1119
1120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1121         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1122         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1123         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1124         (-[SlowTextInputContext handleEvent:completionHandler:]):
1125         (-[SlowInputWebView inputContext]):
1126         (-[SlowInputWebView _web_superInputContext]):
1127         (TEST):
1128
1129 2017-08-08  John Wilander  <wilander@apple.com>
1130
1131         Resource Load Statistics: Clear web processes' state on history removal
1132         https://bugs.webkit.org/show_bug.cgi?id=175271
1133         <rdar://problem/33756560>
1134
1135         Reviewed by Chris Dumez.
1136
1137         Test infrastructure for asynchronous tests of website data
1138         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1139
1140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1141         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1142         (WTR::InjectedBundle::didReceiveMessageToPage):
1143         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1144         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1145         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1146         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1147         * WebKitTestRunner/TestController.cpp:
1148         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1149         * WebKitTestRunner/TestController.h:
1150         * WebKitTestRunner/TestInvocation.cpp:
1151         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1152         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1153         * WebKitTestRunner/TestInvocation.h:
1154         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1155         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1156
1157 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1158
1159         Add Alicia Boya García as contributor
1160         https://bugs.webkit.org/show_bug.cgi?id=175326
1161
1162         Reviewed by Michael Catanzaro.
1163
1164         * Scripts/webkitpy/common/config/contributors.json:
1165
1166 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1167
1168         [CMake] Properly test if compiler supports compiler flags
1169         https://bugs.webkit.org/show_bug.cgi?id=174490
1170
1171         Reviewed by Konstantin Tokarev.
1172
1173         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1174         * MiniBrowser/gtk/CMakeLists.txt:
1175         * TestRunnerShared/Bindings/JSWrapper.cpp:
1176         (WTR::JSWrapper::initialize):
1177         * TestWebKitAPI/CMakeLists.txt:
1178         * TestWebKitAPI/PlatformGTK.cmake:
1179         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1180         (TestWebKitAPI::CheckedArithmeticTester::run):
1181         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1182         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1183         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1184         (formControlsAssociatedCallback):
1185         * TestWebKitAPI/glib/CMakeLists.txt:
1186         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1187         (Test::getResourcesDir):
1188         * WebKitTestRunner/CMakeLists.txt:
1189         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1190         (WTR::menuItemClickCallback):
1191         (WTR::staticConvertMenuItemToType):
1192         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1193         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1195         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1196         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1197         (WTR::AccessibilityUIElement::helpText const):
1198         (WTR::AccessibilityUIElement::attributedStringForRange):
1199         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1200         (WTR::EventSenderProxy::updateTouchPoint):
1201         (WTR::EventSenderProxy::releaseTouchPoint):
1202
1203 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1204
1205         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1206         https://bugs.webkit.org/show_bug.cgi?id=175116
1207         <rdar://problem/28279301>
1208
1209         Reviewed by Darin Adler and Ryosuke Niwa.
1210
1211         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1212         EditorStateTests run on both iOS and Mac.
1213
1214         * TestWebKitAPI/EditingTestHarness.h: Added.
1215         * TestWebKitAPI/EditingTestHarness.mm: Added.
1216
1217         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1218         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1219         the state of the latest observed EditorState.
1220
1221         (-[EditingTestHarness initWithWebView:]):
1222         (-[EditingTestHarness dealloc]):
1223         (-[EditingTestHarness webView]):
1224         (-[EditingTestHarness latestEditorState]):
1225         (-[EditingTestHarness editorStateHistory]):
1226         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1227         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1228         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1229         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1230         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1231         (-[EditingTestHarness toggleBold]):
1232         (-[EditingTestHarness toggleItalic]):
1233         (-[EditingTestHarness toggleUnderline]):
1234         (-[EditingTestHarness setForegroundColor:]):
1235         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1236         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1237         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1238         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1239         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1240         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1241         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1242
1243         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1244         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1245         keys and values.
1246
1247         (-[EditingTestHarness latestEditorStateContains:]):
1248         (-[EditingTestHarness _webView:editorStateDidChange:]):
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1251         (TestWebKitAPI::setUpEditorStateTestHarness):
1252         (TestWebKitAPI::TEST):
1253         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1254
1255 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1256
1257         Prevent domain from being set to a TLD
1258         https://bugs.webkit.org/show_bug.cgi?id=175226
1259         <rdar://problem/11079948>
1260
1261         Reviewed by Chris Dumez.
1262
1263         Extend the public suffix tests to include cases used by the
1264         Public Domain 'Public Suffix List'.
1265
1266         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1267         (TestWebKitAPI::TEST):
1268
1269 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1270
1271         [XCode] webkit-patch should run sort-Xcode-project-file
1272         https://bugs.webkit.org/show_bug.cgi?id=174036
1273         <rdar://problem/33732709>
1274
1275         Reviewed by Simon Fraser.
1276
1277         * Scripts/webkitpy/common/config/ports.py:
1278         * Scripts/webkitpy/tool/commands/download.py:
1279         * Scripts/webkitpy/tool/commands/download_unittest.py:
1280         * Scripts/webkitpy/tool/commands/upload.py:
1281         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1282         * Scripts/webkitpy/tool/steps/__init__.py:
1283         * Scripts/webkitpy/tool/steps/options.py:
1284         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1285
1286 2017-08-07  Devin Rousso  <drousso@apple.com>
1287
1288         Web Inspector: Preview Canvas path when viewing a recording
1289         https://bugs.webkit.org/show_bug.cgi?id=174967
1290
1291         Reviewed by Brian Burg.
1292
1293         * DumpRenderTree/TestOptions.h:
1294         * DumpRenderTree/TestOptions.mm:
1295         (TestOptions::TestOptions):
1296         * DumpRenderTree/mac/DumpRenderTree.mm:
1297         (setWebPreferencesForTestOptions):
1298         * WebKitTestRunner/TestController.cpp:
1299         (WTR::TestController::resetPreferencesToConsistentValues):
1300         (WTR::updateTestOptionsFromTestHeader):
1301         * WebKitTestRunner/TestOptions.h:
1302         (WTR::TestOptions::hasSameInitializationOptions const):
1303         Add plumbing for new InspectorAdditions runtime flag.
1304
1305 2017-08-07  obinna obike  <oobike@apple.com>
1306
1307         Sorted EWS Queues on Patch page
1308         https://bugs.webkit.org/show_bug.cgi?id=173667
1309
1310         Reviewed by Aakash Jain.
1311
1312         * QueueStatusServer/handlers/patch.py:
1313         (Patch.get): Sorted queue_status.
1314         * QueueStatusServer/templates/patch.html:
1315         Changed queue_status.items to queue_status because it's a list.
1316
1317 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1318
1319         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1320         https://bugs.webkit.org/show_bug.cgi?id=175286
1321
1322         Reviewed by Myles C. Maxfield.
1323
1324         * Scripts/webkitpy/style/checkers/cpp.py:
1325         (check_braces):
1326         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1327         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1328         (WebKitStyleTest.test_braces):
1329         (WebKitStyleTest.test_braces.NS_OPTIONS):
1330
1331 2017-08-07  Brian Burg  <bburg@apple.com>
1332
1333         Remove CANVAS_PATH compilation guard
1334         https://bugs.webkit.org/show_bug.cgi?id=175207
1335
1336         Reviewed by Sam Weinig.
1337
1338         * Scripts/webkitperl/FeatureList.pm:
1339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1340
1341 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1342
1343         [Win] Use Visual Studio 2017 if installed.
1344         https://bugs.webkit.org/show_bug.cgi?id=175188
1345
1346         Reviewed by Sam Weinig.
1347
1348         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1349
1350         * Scripts/webkitdirs.pm:
1351         (visualStudioInstallDir):
1352         (msBuildInstallDir):
1353
1354 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1355
1356         [GTK][WPE] Add API to provide browser information required by automation
1357         https://bugs.webkit.org/show_bug.cgi?id=175130
1358
1359         Reviewed by Michael Catanzaro.
1360
1361         * MiniBrowser/gtk/main.c:
1362         (automationStartedCallback): Set browser information when a new automation session is started.
1363         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1364         (testAutomationSessionApplicationInfo):
1365         (beforeAll):
1366
1367 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1368
1369         Unreviewed, rolling out r220295.
1370
1371         This change introduced 4 errors in webkitpy tests.
1372
1373         Reverted changeset:
1374
1375         "[XCode] webkit-patch should run sort-Xcode-project-file"
1376         https://bugs.webkit.org/show_bug.cgi?id=174036
1377         http://trac.webkit.org/changeset/220295
1378
1379 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1380
1381         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1382
1383         Unreviewed test gardening.
1384
1385         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1386         (TestWebKitAPI::TEST):
1387
1388 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1389
1390         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1391         https://bugs.webkit.org/show_bug.cgi?id=175083
1392
1393         Reviewed by Oliver Hunt.
1394         
1395         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1396         to wait for VM destructions to finish before running the next test. This makes it easier to 
1397         understand leaks results from workers tests, and leads to fewer reported leaks.
1398
1399         * DumpRenderTree/mac/DumpRenderTree.mm:
1400         (runTest):
1401
1402 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1403
1404         check-webkit-style: fix path-specific rules for WebKit2 rename
1405         https://bugs.webkit.org/show_bug.cgi?id=175182
1406
1407         Reviewed by David Kilzer.
1408
1409         * Scripts/webkitpy/style/checker.py:
1410
1411 2017-08-04  Youenn Fablet  <youenn@apple.com>
1412
1413         [Cache API] Add Cache and CacheStorage IDL definitions
1414         https://bugs.webkit.org/show_bug.cgi?id=175201
1415
1416         Reviewed by Brady Eidson.
1417
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (enableExperimentalFeatures):
1420         (resetWebPreferencesToConsistentValues):
1421         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1422         (WTR::InjectedBundle::beginTesting):
1423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1424         (WTR::TestRunner::setCacheAPIEnabled):
1425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1426
1427 2017-08-04  John Wilander  <wilander@apple.com>
1428
1429         Resource Load Statistics: Report user interaction immediately, but only when needed
1430         https://bugs.webkit.org/show_bug.cgi?id=175090
1431         <rdar://problem/33685546>
1432
1433         Reviewed by Chris Dumez.
1434
1435         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1436         (WTR::InjectedBundle::beginTesting):
1437             Now calls WebCore::ResourceLoadObserver::clearState().
1438
1439 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1440
1441         Add an API test for r220286
1442         https://bugs.webkit.org/show_bug.cgi?id=175206
1443
1444         Reviewed by Simon Fraser.
1445
1446         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1447         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1448         (createAnimatedResizeWebView):
1449         (TEST):
1450         Add a test to ensure that we don't call
1451         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1452         animated resize.
1453
1454 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1455
1456         [XCode] webkit-patch should run sort-Xcode-project-file
1457         https://bugs.webkit.org/show_bug.cgi?id=174036
1458
1459         Reviewed by Simon Fraser.
1460
1461         * Scripts/webkitpy/common/config/ports.py:
1462         * Scripts/webkitpy/tool/commands/download.py:
1463         * Scripts/webkitpy/tool/commands/upload.py:
1464         * Scripts/webkitpy/tool/steps/__init__.py:
1465         * Scripts/webkitpy/tool/steps/options.py:
1466         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1467
1468 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1469
1470         REGRESSION(r219857): run-benchmark --allplans broken
1471         https://bugs.webkit.org/show_bug.cgi?id=175186
1472
1473         Reviewed by Saam Barati.
1474
1475         r219857 forgot to update also the calls to BenchmarkRunner() that
1476         is done when the script is run with --allplans.
1477
1478         To fix this (and avoid future issues like this), let's factorize
1479         the calls to the benchhmark runner in a run_benchmark_plan()
1480         function.
1481
1482         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1483         (run_benchmark_plan):
1484         (start):
1485
1486 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1487
1488         Dashboard bubbles sometimes show failure count instead of crash count
1489         https://bugs.webkit.org/show_bug.cgi?id=175157
1490         <rdar://problem/33709009>
1491
1492         Reviewed by Alexey Proskuryakov.
1493
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1495         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1496
1497 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1498
1499         Add tests for NeverDestroyed
1500         https://bugs.webkit.org/show_bug.cgi?id=175146
1501
1502         Reviewed by Darin Adler.
1503
1504         * CMakeLists.txt:
1505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1506         New files and sort.
1507
1508         * TestWebKitAPI/Tests/WTF/Logger.h:
1509         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1510         (TestWebKitAPI::log):
1511         (TestWebKitAPI::takeLogStr):
1512         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1513         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1514         (TestWebKitAPI::log): Deleted.
1515         (TestWebKitAPI::takeLogStr): Deleted.
1516         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1517
1518         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1519         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1520         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1521         (TestWebKitAPI::LifecycleLogger::operator=):
1522         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1523         (TestWebKitAPI::LifecycleLogger::setName):
1524         (TestWebKitAPI::TEST):
1525         Add a class that logs construction / assignment / modifications.
1526
1527         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1528         (TestWebKitAPI::TEST):
1529         (TestWebKitAPI::list):
1530         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1531
1532 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1533
1534         minification logic is not implemented for ios builds
1535         <rdar://problem/33726561>
1536
1537         Reviewed by Dean Johnson
1538
1539         * BuildSlaveSupport/built-product-archive:
1540         (minifyDirectory): refactor minifySource -> minifyDirectory
1541         (archiveBuiltProduct): add ios minification logic
1542         (minifySource): Deleted.
1543
1544 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1545
1546         Unreviewed, rolling out r220271.
1547
1548         Rolling out due to Layout Test failing on iOS Simulator.
1549
1550         Reverted changeset:
1551
1552         "Remove STREAMS_API compilation guard"
1553         https://bugs.webkit.org/show_bug.cgi?id=175165
1554         http://trac.webkit.org/changeset/220271
1555
1556 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1557
1558         Unreviewed, rolling out r220268.
1559
1560         This change caused assertion failures on macOS and iOS Debug
1561         WK2.
1562
1563         Reverted changeset:
1564
1565         "Resource Load Statistics: Report user interaction
1566         immediately, but only when needed"
1567         https://bugs.webkit.org/show_bug.cgi?id=175090
1568         http://trac.webkit.org/changeset/220268
1569
1570 2017-08-04  Youenn Fablet  <youenn@apple.com>
1571
1572         Remove STREAMS_API compilation guard
1573         https://bugs.webkit.org/show_bug.cgi?id=175165
1574
1575         Reviewed by Darin Adler.
1576
1577         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1578
1579 2017-08-04  John Wilander  <wilander@apple.com>
1580
1581         Resource Load Statistics: Report user interaction immediately, but only when needed
1582         https://bugs.webkit.org/show_bug.cgi?id=175090
1583         <rdar://problem/33685546>
1584
1585         Reviewed by Chris Dumez.
1586
1587         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1588         (WTR::InjectedBundle::beginTesting):
1589             Now calls WebCore::ResourceLoadObserver::clearState().
1590
1591 2017-08-03  Brian Burg  <bburg@apple.com>
1592
1593         Remove ENABLE(WEB_SOCKET) guards
1594         https://bugs.webkit.org/show_bug.cgi?id=167044
1595
1596         Reviewed by Joseph Pecoraro.
1597
1598         * Scripts/webkitperl/FeatureList.pm:
1599         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1600
1601 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1602
1603         REGRESSION(r219850): run-benchmark script broken on Linux
1604         https://bugs.webkit.org/show_bug.cgi?id=175126
1605
1606         Reviewed by Stephanie Lewis.
1607
1608         The run-benchmark script dynamically generates the list of supported
1609         browsers and platforms (currently Linux and OSX) by loading all
1610         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1611         and getting the browser_name and platform variables from the
1612         classes defined there.
1613
1614         This means that this classes should not raise an exception when
1615         loaded on other platforms or otherwise they will broke the whole
1616         script. Its fine if they raise an exception when executing any of
1617         the methods they implement, but not when just loading/importing
1618         the class.
1619
1620         Move the argument variable definitions that call on the platform
1621         specific OSXBrowserDriver._screen_size() function from beeing
1622         variables that are evaluated when loading the file, to be functions
1623         that are only evaluated when the actual functionality needs to be
1624         executed.
1625
1626         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1627         (OSXChromeDriver.launch_url):
1628         (OSXChromeCanaryDriver.launch_url):
1629         (create_args):
1630         (create_chrome_options):
1631         (create_window_size_arg):
1632         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1633         (OSXFirefoxDriver.launch_url):
1634         (OSXFirefoxNightlyDriver.launch_url):
1635         (OSXFirefoxNightlyDriver.launch_driver):
1636         (create_args):
1637
1638 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1639
1640         [PAL] Move spi/cf directory into PAL
1641         https://bugs.webkit.org/show_bug.cgi?id=175057
1642
1643         Reviewed by Antti Koivisto.
1644
1645         * Scripts/webkitpy/style/checker.py:
1646         * Scripts/webkitpy/style/checker_unittest.py:
1647         (GlobalVariablesTest.test_path_rules_specifier):
1648
1649         Ignore "readability/naming/underscores" style errors for sources
1650         under the WebCore/PAL/pal/spi directory.
1651
1652         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1653
1654 2017-08-03  Youenn Fablet  <youenn@apple.com>
1655
1656         Remove FETCH_API compilation guard
1657         https://bugs.webkit.org/show_bug.cgi?id=175154
1658
1659         Reviewed by Chris Dumez.
1660
1661         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1662
1663 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1664
1665         Enable archive minification on iOS builds
1666         https://bugs.webkit.org/show_bug.cgi?id=174718
1667         
1668         Reviewed by Aakash Jain.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1671         (BuildFactory.__init__):
1672
1673 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1674
1675         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1676         https://bugs.webkit.org/show_bug.cgi?id=175140
1677
1678         Reviewed by Alexey Proskuryakov.
1679
1680         We are having lately issues with JSC tests causing problems on
1681         the GTK+ and WPE bots due to the high amount of memory some tests
1682         need to run.
1683
1684         The best thing we can do now is to workaround this by disabling
1685         all the tests marked as memoryLimited on the GTK and WPE bots.
1686         We may revise this on the future.
1687
1688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1689         (RunJavaScriptCoreTests.start):
1690
1691 2017-08-03  Brady Eidson  <beidson@apple.com>
1692
1693         Add SW IDLs and stub out basic functionality.
1694         https://bugs.webkit.org/show_bug.cgi?id=175115
1695
1696         Reviewed by Chris Dumez.
1697
1698         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1699
1700         * Scripts/webkitpy/bindings/main.py:
1701
1702 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1703
1704         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1705         https://bugs.webkit.org/show_bug.cgi?id=159510
1706
1707         Reviewed by Daniel Bates.
1708
1709         Allow any https certificate when running tests.
1710
1711         * DumpRenderTree/win/DumpRenderTree.cpp:
1712         (runTest):
1713
1714 2017-08-02  Youenn Fablet  <youenn@apple.com>
1715
1716         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1717         https://bugs.webkit.org/show_bug.cgi?id=175089
1718
1719         Reviewed by Chris Dumez.
1720
1721         * DumpRenderTree/TestOptions.mm:
1722         (TestOptions::TestOptions): Using absolutePath if available.
1723         * DumpRenderTree/mac/DumpRenderTree.mm:
1724         (computeTestURL): Removing http/tests/ specific URL computation.
1725         * Scripts/webkitpy/port/driver.py:
1726         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1727
1728 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1729
1730         download-built-product should allow for a proxy option
1731         https://bugs.webkit.org/show_bug.cgi?id=174875
1732
1733         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1734
1735         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1736         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1737         
1738
1739 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1740
1741         check-webkit-style: deleting lines in a file runs the linter on the whole file
1742         https://bugs.webkit.org/show_bug.cgi?id=175078
1743
1744         Reviewed by David Kilzer.
1745
1746         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1747         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1748
1749         * Scripts/webkitpy/style/checkers/test_expectations.py:
1750         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1751         * Scripts/webkitpy/style/main_unittest.py:
1752         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1753         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1754         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1755
1756 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1757
1758         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1759         https://bugs.webkit.org/show_bug.cgi?id=175075
1760
1761         Reviewed by David Kilzer.
1762
1763         We have no way of handling text files with illegal unicode characters. Allow the callers of
1764         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1765         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1766
1767         * Scripts/webkitpy/common/system/filesystem.py:
1768         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1769         (FileSystem.write_text_file): Ditto.
1770         * Scripts/webkitpy/common/system/filesystem_mock.py:
1771         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1772         (MockFileSystem.write_text_file): Ditto.
1773         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1774         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1775         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1776
1777 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1778
1779         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1780         https://bugs.webkit.org/show_bug.cgi?id=175072
1781
1782         Reviewed by Alexey Proskuryakov.
1783
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1785         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1786
1787 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1788
1789         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1790         https://bugs.webkit.org/show_bug.cgi?id=175019
1791
1792         Reviewed by Darin Adler.
1793
1794         * TestWebKitAPI/CMakeLists.txt:
1795
1796 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1797
1798         Enabling uploading archives to S3
1799         https://bugs.webkit.org/show_bug.cgi?id=174198
1800
1801         Unreviewed unit test fix after r219235.
1802
1803         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1804
1805 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1806
1807         Fix JSCOnly ARM buildbots after r220047
1808         https://bugs.webkit.org/show_bug.cgi?id=174993
1809
1810         Unreviewed fix after r220087.
1811
1812         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1813         (BuildAndRemoteJSCTestsFactory.__init__):
1814
1815 2017-08-01  Chris Dumez  <cdumez@apple.com>
1816
1817         Add initial support for navigator.sendBeacon
1818         https://bugs.webkit.org/show_bug.cgi?id=175007
1819         <rdar://problem/33547728>
1820
1821         Reviewed by Sam Weinig.
1822
1823         Enable the Beacon API at runtime in the context of layout tests since the
1824         feature is currently disabled by default.
1825
1826         * DumpRenderTree/mac/DumpRenderTree.mm:
1827         (enableExperimentalFeatures):
1828         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1829         (WTR::InjectedBundle::beginTesting):
1830         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1831         (WTR::TestRunner::setModernMediaControlsEnabled):
1832         (WTR::TestRunner::setBeaconAPIEnabled):
1833         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1834
1835 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1836
1837         Update Bot Watcher's Dashboard for Buildbot 0.9
1838         https://bugs.webkit.org/show_bug.cgi?id=174777
1839
1840         Reviewed by Daniel Bates.
1841
1842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1843         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1844         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1845         in a dictionary.
1846         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1847         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1849         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1850         (parseRevisionProperty): Ditto.
1851         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1852         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1853         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1854         have changed in Buildbot 0.9.
1855         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1856         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1857         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1858         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1859         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1860         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1861         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1862         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1863         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1864         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1866         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1867         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1868         (BuildbotQueue.prototype.get overviewURL): Ditto.
1869         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1870         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1871         Buildbot 0.8 or 0.9.
1872         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1873         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1874         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1875         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1876         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1877         Therefore we are fetching information for fixed number of build. 
1878         Also iterating the loop incrementally since the build data is already reverse sorted.
1879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1880         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1881         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1883         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1884
1885 2017-08-01  Devin Rousso  <drousso@apple.com>
1886
1887         Web Inspector: simplify WebInspector with WI
1888         https://bugs.webkit.org/show_bug.cgi?id=175058
1889
1890         Reviewed by Joseph Pecoraro.
1891
1892         * Scripts/check-inspector-strings:
1893         (extract_ui_strings):
1894         * Scripts/extract-localizable-js-strings:
1895
1896 2017-08-01  Youenn Fablet  <youenn@apple.com>
1897
1898         Layout tests with 'https' suffix should be run over HTTPS
1899         https://bugs.webkit.org/show_bug.cgi?id=174992
1900
1901         Reviewed by Chris Dumez.
1902
1903         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1904         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1905         Covered by corresponding unit tests.
1906
1907         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1908         (run_server):
1909         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1910         (base_http_url):
1911         (base_https_url):
1912         (base_url): Deleted.
1913         * Scripts/webkitpy/port/base.py:
1914         (Port.to.web_platform_test_server_base_http_url):
1915         (Port.to):
1916         (Port.to.web_platform_test_server_base_https_url):
1917         (Port.to.web_platform_test_server_base_url): Deleted.
1918         * Scripts/webkitpy/port/driver.py:
1919         (Driver.__init__):
1920         (Driver.wpt_test_path_to_uri):
1921         (Driver):
1922         (Driver.http_test_path_to_uri):
1923         (Driver.test_to_uri):
1924         (Driver.uri_to_test):
1925         * Scripts/webkitpy/port/driver_unittest.py:
1926         (DriverTest.test_test_to_uri):
1927         (DriverTest.test_uri_to_test):
1928
1929 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1930
1931         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1932         https://bugs.webkit.org/show_bug.cgi?id=173998
1933
1934         Reviewed by Darin Adler.
1935
1936         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1937         detect mistakes in backward compatibility in the future when we change it.
1938
1939         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1940         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1941         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1942         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1943         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1944         internal key data slot.
1945
1946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1947         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1948         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1949         (getNextMessage):
1950         (TEST):
1951         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1952         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1954         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1955         These are the pre-baked databases.
1956         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1957         This is the actual test that do all the reads and comparisons.
1958         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1959         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1960         IndexedDB new stuffs. Then it can be used to bake the database again.
1961
1962 2017-08-01  Brady Eidson  <beidson@apple.com>
1963
1964         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1965         https://bugs.webkit.org/show_bug.cgi?id=175030
1966
1967         Reviewed by Andy Estes.
1968
1969         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1970         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1971
1972 2017-08-01  Brady Eidson  <beidson@apple.com>
1973
1974         Part 2 of: Rename DatabaseProcess to StorageProcess.
1975         https://bugs.webkit.org/show_bug.cgi?id=174880
1976
1977         Reviewed by Andy Estes.
1978
1979         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1980         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1981         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1982         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1983         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1984         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1985         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1986         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1987
1988 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1989
1990         Fix JSCOnly ARM buildbots after r220047
1991         https://bugs.webkit.org/show_bug.cgi?id=174993
1992
1993         Reviewed by Saam Barati.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1996         (BuildAndRemoteJSCTestsFactory.__init__):
1997
1998 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1999
2000         [WTF] Introduce Private Symbols
2001         https://bugs.webkit.org/show_bug.cgi?id=174935
2002
2003         Reviewed by Darin Adler.
2004
2005         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2006         (TestWebKitAPI::TEST):
2007
2008 2017-07-30  Darin Adler  <darin@apple.com>
2009
2010         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2011         https://bugs.webkit.org/show_bug.cgi?id=130653
2012
2013         Reviewed by Antti Koivisto.
2014
2015         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2016         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
2017         when calling frameDidChangeLocation.
2018         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
2019         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
2020         thus causing mysterious failures of a couple of tests. There are two remaining issues:
2021         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
2022         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
2023         same logic flaw that causes "top loading frame" to get set to one of the subframes in
2024         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
2025         loading, subframe starts loading. It would be good to clean that up some day, but for now
2026         this patch makes the two work identically rather than changing both.
2027         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2028
2029 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2030
2031         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2032         https://bugs.webkit.org/show_bug.cgi?id=174963
2033
2034         Reviewed by Darin Adler.
2035
2036         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2037         RetainPtr<>. This patch changes them to all use auto.
2038
2039         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2040         (TestWebKitAPI::TEST):
2041
2042 2017-07-30  Brady Eidson  <beidson@apple.com>
2043
2044         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2045         https://bugs.webkit.org/show_bug.cgi?id=174958
2046
2047         Reviewed by Darin Adler.
2048
2049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2050         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2051         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2052         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2053         (runUntilTasksInFlight):
2054         (TEST):
2055
2056 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2057
2058         Unreviewed, rolling out r219990.
2059         https://bugs.webkit.org/show_bug.cgi?id=174961
2060
2061         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2062         estes on #webkit).
2063
2064         Reverted changeset:
2065
2066         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2067         https://bugs.webkit.org/show_bug.cgi?id=174880
2068         http://trac.webkit.org/changeset/219990
2069
2070 2017-07-28  Brady Eidson  <beidson@apple.com>
2071
2072         API tests that use URLSchemeHandler are failing.
2073         https://bugs.webkit.org/show_bug.cgi?id=174950
2074
2075         Reviewed by Alex Christensen.
2076
2077         Fix the NoMIMEType test to be correct.
2078
2079         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2080         (-[SchemeHandler initWithData:mimeType:]):
2081         (-[SchemeHandler webView:startURLSchemeTask:]):
2082         (TEST):
2083
2084 2017-07-28  Daniel Bates  <dabates@apple.com>
2085
2086         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2087         https://bugs.webkit.org/show_bug.cgi?id=174876
2088
2089         Reviewed by Alex Christensen.
2090
2091         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2092         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2093         they provide a more direct way to test the platform abstraction.
2094
2095         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2096
2097         * Scripts/prepare-ChangeLog:
2098         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2099         of the current working directory.
2100
2101 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2102
2103         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2104         https://bugs.webkit.org/show_bug.cgi?id=174930
2105
2106         Unreviewed test fix.
2107
2108         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2109
2110         * Scripts/prepare-ChangeLog:
2111         (get_function_line_ranges_for_cpp):
2112
2113 2017-07-28  JF Bastien  <jfbastien@apple.com>
2114
2115         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2116         https://bugs.webkit.org/show_bug.cgi?id=174930
2117
2118         Reviewed by Daniel Bates.
2119
2120         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2121         here also teach it about const and volatile overloads. I didn't do
2122         reference and rvalue reference overloads because we don't really
2123         use them, and the current parser throws away those characters and
2124         it doesn't seem worth making it more complex.
2125
2126         * Scripts/prepare-ChangeLog:
2127         (get_function_line_ranges_for_cpp):
2128         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2129         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2130         (Foo::Arrow::arrow):
2131         (Foo::Arrow::otherArrow):
2132         (Foo::Arrow::otherArrow const):
2133         (Foo::Arrow::otherArrow volatile):
2134         (Foo::Arrow::otherArrow const volatile):
2135
2136 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2137
2138         [GTK] Building with ENABLE_VIDEO=OFF fails
2139         https://bugs.webkit.org/show_bug.cgi?id=174940
2140
2141         Reviewed by Alex Christensen.
2142
2143         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2144         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2145
2146         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2147         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2148
2149 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2150
2151         [WPE] Implement EventSenderProxy in WTR
2152         https://bugs.webkit.org/show_bug.cgi?id=173419
2153
2154         Reviewed by Žan Doberšek.
2155
2156         Add the implementation of EventSenderProxy to the WTR. This
2157         allows us to extend the coverage of the test suite in WKWPE.
2158
2159         * WebKitTestRunner/EventSenderProxy.h:
2160         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2161         libxkbcommon needed to deal with key events.
2162         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2163         (WTR::EventSenderProxy::EventSenderProxy):
2164         (WTR::senderButtonToWPEButton):
2165         (WTR::EventSenderProxy::mouseDown):
2166         (WTR::EventSenderProxy::mouseUp):
2167         (WTR::EventSenderProxy::mouseMoveTo):
2168         (WTR::EventSenderProxy::mouseScrollBy):
2169         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2170         (WTR::EventSenderProxy::leapForward):
2171         (WTR::wkEventModifiersToWPE):
2172         (WTR::getXKBKeySymForKeyRef):
2173         (WTR::EventSenderProxy::keyDown):
2174         (WTR::EventSenderProxy::addTouchPoint):
2175         (WTR::EventSenderProxy::updateTouchPoint):
2176         (WTR::EventSenderProxy::setTouchModifier):
2177         (WTR::EventSenderProxy::setTouchPointRadius):
2178         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2179         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2180         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2181         (WTR::EventSenderProxy::touchStart):
2182         (WTR::EventSenderProxy::touchMove):
2183         (WTR::EventSenderProxy::touchEnd):
2184         (WTR::EventSenderProxy::touchCancel):
2185         (WTR::EventSenderProxy::clearTouchPoints):
2186         (WTR::EventSenderProxy::releaseTouchPoint):
2187         (WTR::EventSenderProxy::cancelTouchPoint):
2188
2189 2017-07-27  Brady Eidson  <beidson@apple.com>
2190
2191         Part 2 of: Rename DatabaseProcess to StorageProcess.
2192         https://bugs.webkit.org/show_bug.cgi?id=174880
2193
2194         Reviewed by Andy Estes.
2195
2196         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2197         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2198         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2199         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2200         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2201         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2202         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2203         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2204
2205 2017-07-26  Mark Lam  <mark.lam@apple.com>
2206
2207         Add ability to only run specific tests in run-javascriptcore-tests.
2208         https://bugs.webkit.org/show_bug.cgi?id=174884
2209
2210         Reviewed by Saam Barati.
2211
2212         For example, if we only want to run testapi, we can do so as follows:
2213             $ run-javascriptcore-tests --testapi
2214
2215         Previously, specifying --testapi effectively does nothing because we run all tests
2216         by default.  Only --no-testapi had the effect of disabling the test set.  This
2217         old behavior for --testapi is not very useful or meaningful.  We're now changing
2218         it to mean that we will only run that test.
2219
2220         With this change, we can also run more than one set of tests.  For example, if we
2221         only want to run testmasm and testair, we can do so as follows:
2222             $ run-javascriptcore-tests --testmasm --testair
2223
2224         By default, if no specific test option is specified, run-javascriptcore-tests will
2225         run all tests.
2226
2227         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2228         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2229         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2230         the other set will not run.  For example, the following only runs the mozilla tests:
2231             $ run-javascriptcore-tests --mozilla-tests
2232
2233         Note also that --jit-stress-tests is not for choosing a different set of tests.
2234         Instead, it is used for determining whether we run JIT'ed test configurations
2235         on the jsc stress tests and mozilla tests.  As a result, specifying
2236         --jit-stress-tests will not omit other tests.  For example, the following still
2237         runs all tests:
2238             $ run-javascriptcore-tests --jit-stress-tests
2239
2240         * Scripts/run-javascriptcore-tests:
2241         (defaultStringForTestState):
2242         (enableTestOrNot):
2243         (runJSCStressTests):
2244
2245 2017-07-26  Mark Lam  <mark.lam@apple.com>
2246
2247         Make run-javascriptcore-test run testair, testb3, and testmasm.
2248         https://bugs.webkit.org/show_bug.cgi?id=174837
2249         <rdar://problem/33522927>
2250
2251         Reviewed by Saam Barati and Filip Pizlo.
2252
2253         1. Refactors code for running testapi so that we can use it to run other tests.
2254         2. Added running of testmasm, testair, testb3.
2255
2256         Note: the existing testapi invocation code does not support remote invocation of
2257         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2258         and testb3 also do not support remote invocation.  If we wish to add remote
2259         invocation support, we should do that in a separate patch.
2260
2261         * Scripts/run-javascriptcore-tests:
2262         (testPath):
2263         (runTest):
2264         (testapiPath): Deleted.
2265
2266 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2267
2268         Remove duplicate code from Buildbot.js in dashboard
2269         https://bugs.webkit.org/show_bug.cgi?id=174870
2270
2271         Reviewed by Daniel Bates.
2272
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2274         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2275         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2277         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2278
2279 2017-07-26  Brady Eidson  <beidson@apple.com>
2280
2281         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2282         https://bugs.webkit.org/show_bug.cgi?id=174851
2283
2284         Reviewed by Chris Dumez.
2285
2286         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2287         (TEST):
2288
2289 2017-07-26  Brian Burg  <bburg@apple.com>
2290
2291         Remove WEB_TIMING feature flag
2292         https://bugs.webkit.org/show_bug.cgi?id=174795
2293
2294         Reviewed by Alex Christensen.
2295
2296         * Scripts/webkitperl/FeatureList.pm:
2297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2298
2299 2017-07-26  Chris Dumez  <cdumez@apple.com>
2300
2301         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2302         https://bugs.webkit.org/show_bug.cgi?id=174864
2303         <rdar://problem/33009088>
2304
2305         Reviewed by Geoffrey Garen.
2306
2307         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2308         WKTR.
2309
2310         * DumpRenderTree/mac/EventSendingController.mm:
2311         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2312
2313 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2314
2315         Unreviewed, added Romain Bellessort to contributors.json.
2316
2317         * Scripts/webkitpy/common/config/contributors.json:
2318
2319 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2320
2321         [WPE] WebGL2 support
2322         https://bugs.webkit.org/show_bug.cgi?id=174249
2323
2324         Reviewed by Alex Christensen.
2325
2326         * Scripts/webkitperl/FeatureList.pm:
2327         Enable WebGL2 for WPE when building through build-webkit.
2328
2329 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2330
2331         Unreviewed. Fix GTK distcheck.
2332
2333         * gtk/make-dist.py:
2334         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2335
2336 2017-07-25  Brady Eidson  <beidson@apple.com>
2337
2338         ResourceLoadStatistics grandfathering happens much too often.
2339         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2340
2341         Reviewed by Chris Dumez.
2342
2343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2344         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2345         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2346         (TEST):
2347
2348 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2349
2350         Fix autoinstaller failing on autoinstall_everything
2351         https://bugs.webkit.org/show_bug.cgi?id=174830
2352
2353         Reviewed by Joseph Pecoraro.
2354
2355         * Scripts/webkitpy/thirdparty/__init__.py:
2356         (AutoinstallImportHook.find_module):
2357         (AutoinstallImportHook.install_chromedriver):
2358         (AutoinstallImportHook.install_geckodriver):
2359         (AutoinstallImportHook._install_chromedriver): Deleted.
2360         (AutoinstallImportHook._install_geckodriver): Deleted.
2361
2362 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2363
2364         Replace --runtime with something for both ios-simulator and ios-device
2365         https://bugs.webkit.org/show_bug.cgi?id=173775
2366         <rdar://problem/32952164>
2367
2368         Reviewed by Aakash Jain.
2369
2370         Add --version flag for both iOS simulator and iOS device.
2371
2372         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2373         (parse_args): Add --version flag and move --no-install.
2374         * Scripts/webkitpy/port/factory.py:
2375         (platform_options): Move --no-intall to run_webkit_tests.py.
2376         * Scripts/webkitpy/port/ios.py:
2377         (IOSPort):
2378         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2379         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2380         * Scripts/webkitpy/port/ios_device.py:
2381         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2382         devices for iOS version.
2383         * Scripts/webkitpy/port/ios_device_unittest.py:
2384         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2385         expectation paths without devices connected.
2386         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2387         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2388         (IOSDeviceTest.test_expectations_ordering): Deleted.
2389         * Scripts/webkitpy/port/ios_simulator.py:
2390         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2391         flag to specify a runtime.
2392         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2393         flag and then use the default runtime.
2394
2395 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2396
2397         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2398         https://bugs.webkit.org/show_bug.cgi?id=174815
2399
2400         Reviewed by Carlos Alberto Lopez Perez.
2401
2402         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2403         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2404         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2405         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2406         think), probably because of a newer CMake version.
2407
2408         * CMakeLists.txt:
2409         * TestWebKitAPI/CMakeLists.txt:
2410         * TestWebKitAPI/PlatformGTK.cmake:
2411
2412 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2413
2414         Fix BenchmarkRunner to only import selenium when needed
2415         https://bugs.webkit.org/show_bug.cgi?id=174808
2416
2417         Reviewed by Stephanie Lewis.
2418
2419         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2420         (LinuxChromeDriver.launch_driver):
2421         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2422         (LinuxFirefoxDriver.launch_driver):
2423         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2424         (OSXChromeDriver.launch_driver):
2425         (OSXChromeCanaryDriver.launch_driver):
2426         (create_chrome_options):
2427         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2428         (OSXFirefoxDriver.launch_driver):
2429         (OSXFirefoxNightlyDriver.launch_driver):
2430         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2431         (OSXSafariDriver.launch_driver):
2432         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2433         (WebDriverBenchmarkRunner._run_one_test):
2434
2435 2017-07-23  Darin Adler  <darin@apple.com>
2436
2437         More NeverDestroyed and related cleanup
2438         https://bugs.webkit.org/show_bug.cgi?id=174745
2439
2440         Reviewed by Alex Christensen.
2441
2442         * DumpRenderTree/JavaScriptThreading.cpp:
2443         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2444         DEPRECATED_DEFINE_STATIC_LOCAL.
2445         (javaScriptThreads): Ditto.
2446
2447 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2448
2449         Subclass Benchmark Runner script for WebDriver support
2450         https://bugs.webkit.org/show_bug.cgi?id=174390
2451
2452         Reviewed by Dewei Zhu, Stephanie Lewis.
2453
2454         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2455
2456         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2457         (BenchmarkBuilder.__init__):
2458         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2459         (BenchmarkRunner.__init__):
2460         (BenchmarkRunner._find_plan_file):
2461         (BenchmarkRunner._run_one_test.and):
2462         (BenchmarkRunner.execute):
2463         (BenchmarkRunner._get_result): Deleted.
2464         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2465         (parse_args):
2466         (start):
2467         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2468         (WebDriverBenchmarkRunner):
2469         (WebDriverBenchmarkRunner._get_result):
2470         (WebDriverBenchmarkRunner._run_one_test):
2471         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2472         (WebServerBenchmarkRunner):
2473         (WebServerBenchmarkRunner.__init__):
2474         (WebServerBenchmarkRunner._get_result):
2475         (WebServerBenchmarkRunner._run_one_test):
2476
2477 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2478
2479         Add BenchmarkRunner patches with WebDriver support for each testing plan
2480         https://bugs.webkit.org/show_bug.cgi?id=174443
2481
2482         Reviewed by Dewei Zhu, Stephanie Lewis.
2483
2484         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2485         (BenchmarkBuilder.__enter__):
2486         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2487         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2488         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2489         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2490         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2491         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2492         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2493         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2494         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2495         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2496         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2497         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2498         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2499         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2500         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2501         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2502         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2503         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2504         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2505         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2506         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2507         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2508         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2509         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2510         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2511         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2512         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2513         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2514         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2515         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2516         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2517         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2518         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2519
2520 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2521
2522         Add functions to autoinstaller needed for Benchmark Runner script
2523         https://bugs.webkit.org/show_bug.cgi?id=174331
2524
2525         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2526
2527         Adds autoinstaller functions to install selenium and webdriver binaries
2528         which will be used by the browser driver part of Benchmark Runner.
2529
2530         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2531         (BrowserDriver.restore_env):
2532         (BrowserDriver):
2533         (BrowserDriver.get_webdriver_binary_path):
2534         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2535         (LinuxChromeDriver.launch_driver):
2536         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2537         (LinuxFirefoxDriver.launch_driver):
2538         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2539         (OSXChromeDriver.launch_driver):
2540         (OSXChromeCanaryDriver.launch_driver):
2541         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2542         (OSXFirefoxDriver.launch_driver):
2543         (OSXFirefoxNightlyDriver.launch_driver):
2544         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2545         * Scripts/webkitpy/benchmark_runner/utils.py:
2546         (get_driver_binary_path):
2547         * Scripts/webkitpy/common/system/autoinstall.py:
2548         (AutoInstaller._unzip):
2549         * Scripts/webkitpy/thirdparty/__init__.py:
2550         (AutoinstallImportHook.find_module):
2551         (AutoinstallImportHook._install_selenium):
2552         (AutoinstallImportHook):
2553         (AutoinstallImportHook._install_chromedriver):
2554         (AutoinstallImportHook._install_geckodriver):
2555         (AutoinstallImportHook.get_latest_pypi_url):
2556         (AutoinstallImportHook.install_binary):
2557         (autoinstall_everything):
2558         (get_driver_filename):
2559         (get_os_info):
2560
2561 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2562
2563         Add WebDriver support in browser driver part of BenchmarkRunner
2564         https://bugs.webkit.org/show_bug.cgi?id=174445
2565
2566         Reviewed by Stephanie Lewis.
2567
2568         Adds a launch_driver function to each BrowserDriver subclass. This
2569         function sets up the arguments for the webdriver and launches the
2570         webdriver specific to that browser.
2571
2572         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2573         (BrowserDriver.launch_webdriver):
2574         (BrowserDriver):
2575         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2576         (LinuxBrowserDriver.launch_webdriver):
2577         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2578         (LinuxChromeDriver.launch_url):
2579         (LinuxChromeDriver):
2580         (LinuxChromeDriver.launch_driver):
2581         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2582         (EpiphanyBrowserDriver.launch_url):
2583         (EpiphanyBrowserDriver):
2584         (EpiphanyBrowserDriver.launch_driver):
2585         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2586         (LinuxFirefoxDriver):
2587         (LinuxFirefoxDriver.launch_url):
2588         (LinuxFirefoxDriver.launch_driver):
2589         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2590         (GTKMiniBrowserDriver.launch_url):
2591         (GTKMiniBrowserDriver):
2592         (GTKMiniBrowserDriver.launch_driver):
2593         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2594         (OSXBrowserDriver._launch_webdriver):
2595         (OSXBrowserDriver):
2596         (OSXBrowserDriver._screen_size):
2597         (OSXBrowserDriver._insert_url):
2598         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2599         (OSXChromeDriver):
2600         (OSXChromeDriver.launch_url):
2601         (OSXChromeDriver.launch_driver):
2602         (OSXChromeCanaryDriver):
2603         (OSXChromeCanaryDriver.launch_url):
2604         (OSXChromeCanaryDriver.launch_driver):
2605         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2606         (OSXFirefoxDriver):
2607         (OSXFirefoxDriver.launch_url):
2608         (OSXFirefoxDriver.launch_driver):
2609         (OSXFirefoxNightlyDriver):
2610         (OSXFirefoxNightlyDriver.launch_url):
2611         (OSXFirefoxNightlyDriver.launch_driver):
2612         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2613         (OSXSafariDriver.launch_driver):
2614
2615 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2616
2617         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2618         https://bugs.webkit.org/show_bug.cgi?id=174793
2619
2620         Reviewed by Tim Horton.
2621
2622         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2623         down. Without r219765, this test will dereference null and crash.
2624
2625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2626         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2627         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2628         (TEST):
2629
2630 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2631
2632         [Win] Implement Authentication dialog in MiniBrowser
2633         https://bugs.webkit.org/show_bug.cgi?id=174662
2634
2635         Reviewed by Alex Christensen.
2636
2637         * MiniBrowser/win/Common.cpp:
2638         (CustomUserAgent):
2639         (DisplayAuthDialog):
2640         (AuthDialogProc):
2641         * MiniBrowser/win/MiniBrowserLib.rc:
2642         * MiniBrowser/win/MiniBrowserLibResource.h:
2643         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2644         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2645
2646 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2647
2648         Handle case where line_numbers is None instead of an array of line numbers
2649         https://bugs.webkit.org/show_bug.cgi?id=174775
2650
2651         Reviewed by Aakash Jain.
2652
2653         Added files set line_numbers to None in process_file.
2654
2655         * Scripts/webkitpy/style/filereader.py:
2656         (TextFileReader.process_file): Handle case where line_number is set to None.
2657         * Scripts/webkitpy/style/main_unittest.py:
2658         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2659
2660 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2661
2662         [WPE] Add libepoxy to the Jhbuild moduleset
2663         https://bugs.webkit.org/show_bug.cgi?id=174711
2664
2665         Reviewed by Carlos Alberto Lopez Perez.
2666
2667         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2668
2669 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2670
2671         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2672         https://bugs.webkit.org/show_bug.cgi?id=174780
2673
2674         Reviewed by Carlos Garcia Campos.
2675
2676         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2677         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2678         in case the eglplatform.h header doesn't provide that macro. This replicates
2679         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2680
2681 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2682
2683         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2684         https://bugs.webkit.org/show_bug.cgi?id=174758
2685
2686         Reviewed by Dan Bernstein.
2687
2688         Migrate position-information-related unit tests from the PositionInformationTests suite to
2689         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2690
2691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2692         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2693         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2694         (TestWebKitAPI::TEST):
2695         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2696         * TestWebKitAPI/cocoa/TestWKWebView.h:
2697         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2698         (-[TestWKWebView activatedElementAtPosition:]):
2699
2700 2017-07-22  Chris Dumez  <cdumez@apple.com>
2701
2702         REGRESSION(r204565): WKObject is broken
2703         https://bugs.webkit.org/show_bug.cgi?id=174736
2704         <rdar://problem/33246169>
2705
2706         Reviewed by Dan Bernstein.
2707
2708         Add API test that used to crash.
2709
2710         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2711         (TestWebKitAPI::TEST):
2712
2713 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2714
2715         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2716         https://bugs.webkit.org/show_bug.cgi?id=174705
2717
2718         Reviewed by Mark Lam.
2719
2720         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2721         (TestWebKitAPI::testThreadGroup):
2722         (TestWebKitAPI::TEST):
2723
2724 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2725
2726         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2727         https://bugs.webkit.org/show_bug.cgi?id=174724
2728
2729         Reviewed by Aakash Jain.
2730
2731         * Scripts/webkitpy/port/ios_simulator.py:
2732         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2733         simulator. Errors here should be treated the same as no simulators found.
2734
2735 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2736
2737         [CMake] Add an option to stop build after generating project files
2738         https://bugs.webkit.org/show_bug.cgi?id=174664
2739
2740         Reviewed by Konstantin Tokarev.
2741
2742         Add "--generate-project-only" to stop build after generating project files.
2743
2744         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2745         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2746         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2747         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2748         (isGenerateProjectOnly): ditto
2749
2750 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2751
2752         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2753         https://bugs.webkit.org/show_bug.cgi?id=174501
2754
2755         Reviewed by Darin Adler.
2756
2757         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2758         (TestWebKitAPI::TEST):
2759
2760 2017-07-20  David Quesada  <david_quesada@apple.com>
2761
2762         Add SPI to notify WKNavigationDelegate about client redirects
2763         https://bugs.webkit.org/show_bug.cgi?id=174680
2764         rdar://problem/33184886
2765
2766         Reviewed by Brady Eidson.
2767
2768         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2769         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2770         (TEST):
2771         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2772
2773 2017-07-20  Brady Eidson  <beidson@apple.com>
2774
2775         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2776         https://bugs.webkit.org/show_bug.cgi?id=174685
2777
2778         Reviewed by Andy Estes.
2779
2780         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2781         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2782
2783 2017-07-20  Brady Eidson  <beidson@apple.com>
2784
2785         Deprecate WebIconDatabase in WebKitLegacy/mac.
2786         https://bugs.webkit.org/show_bug.cgi?id=174607
2787
2788         Reviewed by Alex Christensen.
2789
2790         * DumpRenderTree/mac/TestRunnerMac.mm:
2791
2792 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2793
2794         lint-test-expectations should be run during style checking
2795         https://bugs.webkit.org/show_bug.cgi?id=173559
2796         <rdar://problem/32854941>
2797
2798         Reviewed by Aakash Jain.
2799
2800         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2801         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2802         prevents identifying errors on specific lines in a file.
2803         * Scripts/webkitpy/style/main_unittest.py:
2804         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2805         case where a linter error is in the file modified, but the line modified is not related to
2806         the linter error.
2807
2808 2017-07-20  Brady Eidson  <beidson@apple.com>
2809
2810         Remove WebIconDatabase from WebKitLegacy/win.
2811         https://bugs.webkit.org/show_bug.cgi?id=174608
2812
2813         Reviewed by Alex Christensen.
2814
2815         * DumpRenderTree/win/DumpRenderTree.cpp:
2816         (main):
2817         * DumpRenderTree/win/TestRunnerWin.cpp:
2818         (TestRunner::setIconDatabaseEnabled):
2819
2820 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2821
2822         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2823         https://bugs.webkit.org/show_bug.cgi?id=174671
2824
2825         Reviewed by Carlos Garcia Campos.
2826
2827         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2828         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2829         priority for this source in order to have it dispatched on the same
2830         priority as the other WebKit-controlled GSource objects.
2831
2832 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2833
2834         lint-test-expectations should be run during style checking
2835         https://bugs.webkit.org/show_bug.cgi?id=173559
2836         <rdar://problem/32854941>
2837
2838         Reviewed by Daniel Bates.
2839
2840         Follow up fix addressing style and a few minor bugs.
2841
2842         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2843         (TestExpectationParser.__init__): Use lambda x: x instead of str
2844         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2845         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2846         reduce the calls of _shorten_filename, fix minor bug in appending the current
2847         expectation's line number instead of the previous ones, clarify treatment of None
2848         in file-to-line-number mapping.
2849         (TestExpectations._report_warnings): Collapse call.
2850         * Scripts/webkitpy/style/checkers/test_expectations.py:
2851         (TestExpectationsChecker.lint_test_expectations):
2852         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2853         (TextFileReader.process_file): Add comment explaining treatment of None in
2854         file-to-line-number mapping.
2855         (TextFileReader.delete_file): Collapse call.
2856
2857 2017-07-19  Chris Dumez  <cdumez@apple.com>
2858
2859         Unreviewed attempt to fix API test failure after r219663.
2860
2861         The test was hard-coding an exception string and the string has changed slightly
2862         in r219663.
2863
2864         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2865         (TEST):
2866
2867 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2868
2869         Don't write file URLs to iOS Pasteboard
2870         https://bugs.webkit.org/show_bug.cgi?id=174647
2871         <rdar://problem/33199730>
2872
2873         Reviewed by Wenson Hsieh.
2874
2875         Updating tests to reflect the lack of file URLs for images.
2876
2877         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2878         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2879         (checkEstimatedSize):
2880         (TestWebKitAPI::TEST):
2881
2882 2017-07-19  Brady Eidson  <beidson@apple.com>
2883
2884         iBooks sometimes crashes when closing a book.
2885         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2886
2887         Reviewed by Oliver Hunt.
2888
2889         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2890         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2891         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2892         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2893         (TestWebKitAPI::TEST):
2894
2895         Add a "spin the runloop X number of times" utility:
2896         * TestWebKitAPI/Utilities.h:
2897         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2898         (TestWebKitAPI::Util::spinRunLoop):
2899
2900 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2901
2902         lint-test-expectations should be run during style checking
2903         https://bugs.webkit.org/show_bug.cgi?id=173559
2904         <rdar://problem/32854941>
2905
2906         Reviewed by David Kilzer.
2907
2908         Running the test expectation linter requires reading both files and lines not in the
2909         patch because, for example, deletion of a test can cause a lint failure even though
2910         no test expectations where modified. This means that the linter will occasionally warn
2911         about lines which were not changed in a given patch but whose error is related to a
2912         change made in that patch.
2913
2914         * Scripts/webkitpy/common/system/filesystem_mock.py:
2915         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2916         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2917         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2918         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2919         content, description of the error and the name of the associated test.
2920         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2921         (TestExpectationParser.__init__): Pass shorten_filename function to
2922         TestExpectationsParser to add a deleted file to the related_files dictionary.
2923         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2924         missing path to the related_files dictionary.
2925         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2926         files and line numbers related to this test expectation line. This will allow
2927         tracking linter errors in the style checker occurring across multiple files.
2928         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2929         lines to related_files dictionary.
2930         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2931         (TestExpectations._report_warnings): Construct warning object instead of string
2932         when adding to warnings list.
2933         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2934         clean-up log.
2935         * Scripts/webkitpy/style/checker.py:
2936         (ProcessorBase.do_association_check): Add required function for processor classes.
2937         (StyleProcessor):
2938         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2939         checking for errors between associated files.
2940         * Scripts/webkitpy/style/checkers/test_expectations.py:
2941         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2942         (TestExpectationsChecker):
2943         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2944         of modified files, the current working directory and the host, determine if the linter
2945         warning is associated with the changes.
2946         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2947         style checker.
2948         * Scripts/webkitpy/style/filereader.py:
2949         (TextFileReader):
2950         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2951         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2952         (TextFileReader.process_file): Track both the number of files changed and which lines
2953         in those files were changed.
2954         (TextFileReader.do_association_check): Run the processor's association check on all
2955         modified or deleted files processed by TextFileReader.
2956         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2957         (TextFileReader.count_delete_only_file): Deleted.
2958         * Scripts/webkitpy/style/filereader_unittest.py:
2959         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2960         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2961         * Scripts/webkitpy/style/main.py:
2962         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2963         explicitly run the association check on the file reader.
2964         * Scripts/webkitpy/style/main_unittest.py:
2965         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2966         embedded in the style checker.
2967         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2968         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2969         construct the TextFileReader object with a StyleProcessor used to run style checks on
2970         specific files.
2971         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2972         testing the test expectation linter inside the style checker. This host must contain a
2973         mock file system with the basic structure of test expectations.
2974         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2975         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2976         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2977         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2978         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2979         * Scripts/webkitpy/style/patchreader.py:
2980         (PatchReader.check): Specify which file was deleted, run the association check.
2981         * Scripts/webkitpy/style/patchreader_unittest.py:
2982         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2983         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2984         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2985
2986 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2987
2988         [WTF] Implement WTF::ThreadGroup
2989         https://bugs.webkit.org/show_bug.cgi?id=174081
2990
2991         Reviewed by Mark Lam.
2992
2993         Add WTF::ThreadGroup tests.
2994
2995         * TestWebKitAPI/CMakeLists.txt:
2996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2997         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2998         (TestWebKitAPI::testThreadGroup):
2999         (TestWebKitAPI::TEST):
3000
3001 2017-07-18  Andy Estes  <aestes@apple.com>
3002
3003         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3004         https://bugs.webkit.org/show_bug.cgi?id=174631
3005
3006         Reviewed by Tim Horton.
3007
3008         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3009         * MiniBrowser/Configurations/Base.xcconfig:
3010         * MobileMiniBrowser/Configurations/Base.xcconfig:
3011         * TestWebKitAPI/Configurations/Base.xcconfig:
3012         * WebKitTestRunner/Configurations/Base.xcconfig:
3013
3014 2017-07-18  Andy Estes  <aestes@apple.com>
3015
3016         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3017         https://bugs.webkit.org/show_bug.cgi?id=174631
3018
3019         Reviewed by Sam Weinig.
3020
3021         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3022         * MiniBrowser/Configurations/Base.xcconfig:
3023         * MobileMiniBrowser/Configurations/Base.xcconfig:
3024         * TestWebKitAPI/Configurations/Base.xcconfig:
3025         * WebKitTestRunner/Configurations/Base.xcconfig:
3026
3027 2017-07-18  Daniel Bates  <dabates@apple.com>
3028
3029         lldb: Add type summary for StringView
3030         https://bugs.webkit.org/show_bug.cgi?id=174637
3031
3032         Reviewed by Sam Weinig.
3033
3034         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3035         StringView object will print output that has the form:
3036
3037             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3038               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3039               m_length = 2
3040               m_is8Bit = true
3041               m_underlyingString = 0x0000614000000a90
3042             }
3043
3044         * lldb/lldb_webkit.py:
3045         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3046         (WTFStringView_SummaryProvider):
3047         (WTFStringViewProvider):
3048         (WTFStringViewProvider.__init__):
3049         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3050         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3051         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3052         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3053
3054 2017-07-18  Andy Estes  <aestes@apple.com>
3055
3056         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3057         https://bugs.webkit.org/show_bug.cgi?id=174631
3058
3059         Reviewed by Dan Bernstein.
3060
3061         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3062         * MiniBrowser/Configurations/Base.xcconfig:
3063         * MobileMiniBrowser/Configurations/Base.xcconfig:
3064         * TestWebKitAPI/Configurations/Base.xcconfig:
3065         * WebKitTestRunner/Configurations/Base.xcconfig:
3066
3067 2017-07-18  Devin Rousso  <drousso@apple.com>
3068
3069         Web Inspector: Add memoryCost to Inspector Protocol objects
3070         https://bugs.webkit.org/show_bug.cgi?id=174478
3071
3072         Reviewed by Joseph Pecoraro.
3073
3074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3075         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3076         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3077         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3078         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3079         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3080         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3081         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3082         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3083         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3084         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3085         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3086         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3087         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3088         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3089         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3090         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3091
3092 2017-07-18  Andy Estes  <aestes@apple.com>
3093
3094         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3095         https://bugs.webkit.org/show_bug.cgi?id=174631
3096
3097         Reviewed by Darin Adler.
3098
3099         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3100         * MiniBrowser/Configurations/Base.xcconfig:
3101         * MobileMiniBrowser/Configurations/Base.xcconfig:
3102         * TestWebKitAPI/Configurations/Base.xcconfig:
3103         * WebKitTestRunner/Configurations/Base.xcconfig:
3104
3105 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3106
3107         Unreviewed, fix the iOS build.
3108
3109         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3110
3111         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3112         (TestWebKitAPI::TEST):
3113
3114 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3115
3116         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3117         https://bugs.webkit.org/show_bug.cgi?id=174585
3118         <rdar://problem/33302541>
3119
3120         Reviewed by Tim Horton.
3121
3122         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3123         being dragged when initiating a drag.
3124
3125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3126         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3127         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3128         (TestWebKitAPI::TEST):
3129         * TestWebKitAPI/cocoa/TestWKWebView.h:
3130
3131         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3132
3133         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3134         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3135
3136 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3137
3138         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3139         https://bugs.webkit.org/show_bug.cgi?id=174547
3140
3141         Reviewed by Alex Christensen.
3142
3143         * DumpRenderTree/PlatformWin.cmake:
3144         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3145
3146 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3147
3148         Update style checker to deal with "final"
3149         https://bugs.webkit.org/show_bug.cgi?id=174528
3150
3151         Reviewed by Alex Christensen.
3152         
3153         check-webkit-style shouldn't complain about an open brace to start a
3154         line after a function definition with "final" or "const final".
3155
3156         * Scripts/webkitpy/style/checkers/cpp.py:
3157         (check_braces):
3158         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3159         (CppStyleTest.test_brace_at_begin_of_line):
3160
3161 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3162
3163         Modernize content extension code
3164         https://bugs.webkit.org/show_bug.cgi?id=174588
3165
3166         Reviewed by Sam Weinig.
3167
3168         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3169         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3170         (TestWebKitAPI::testRequest):
3171         (TestWebKitAPI::makeBackend):
3172         (TestWebKitAPI::TEST_F):
3173
3174 2017-07-17  Brady Eidson  <beidson@apple.com>
3175
3176         WKHTTPCookieStore observing only works on the default cookie store.
3177         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3178
3179         Reviewed by Sam Weinig.
3180
3181         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3182         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3183           called for the default store, a non-persistent store, and a custom store.
3184         (TEST):
3185
3186 2017-07-16  Sam Weinig  <sam@webkit.org>
3187
3188         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3189         https://bugs.webkit.org/show_bug.cgi?id=174575
3190
3191         Reviewed by Brady Eidson.
3192
3193         * Scripts/svn-create-patch:
3194         (findModificationType):
3195         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3196         default value of "unknown".
3197
3198         (generateFileList):
3199         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3200         for untracked, which matches our old behavior.
3201
3202 2017-07-17  Charlie Turner  <cturner@igalia.com>
3203
3204         Add some missing build dependencies on Fedora
3205         https://bugs.webkit.org/show_bug.cgi?id=174578
3206
3207         Unreviewed dependency update.
3208
3209         * gtk/install-dependencies:
3210
3211 2017-07-16  Brady Eidson  <beidson@apple.com>
3212
3213         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3214         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3215
3216         Reviewed by Tim Horton.
3217
3218         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3219         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3220         (TEST):
3221
3222 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3223
3224         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3225         https://bugs.webkit.org/show_bug.cgi?id=174540
3226
3227         Reviewed by Michael Catanzaro.
3228
3229         * gtk/generate-inspector-gresource-manifest.py:
3230         (get_filenames): sort list of input files
3231
3232 2017-07-15  Brady Eidson  <beidson@apple.com>
3233
3234         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3235         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3236
3237         Reviewed by Tim Horton.
3238
3239         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3240         (TEST): Make this test more reliable by clearing everything beforehand.
3241
3242 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3243
3244         Make it possible to extend check-webkit-style with Apple-internal checkers
3245         <https://webkit.org/b/174464>
3246         <rdar://problem/25564402>
3247
3248         Reviewed by Darin Adler.
3249
3250         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3251         (_all_categories): Add categories from apple_additions() if it
3252         exists.
3253         (CheckerDispatcher._create_checker): Create python checker
3254         from apple_additions() if it exists.
3255
3256 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3257
3258         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3259         https://bugs.webkit.org/show_bug.cgi?id=174539
3260         <rdar://problem/33307395>
3261
3262         Reviewed by Darin Adler.
3263
3264         Adds a new unit test suite to cover action sheet popover presentation.
3265
3266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3267         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3268         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3269         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3270
3271         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3272
3273         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3274         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3275
3276         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3277
3278         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3279         (TestWebKitAPI::TEST):
3280
3281 2017-07-15  Sam Weinig  <sam@webkit.org>
3282
3283         [Scripts] Make svn-create-patch work better when called in sub directories
3284         https://bugs.webkit.org/show_bug.cgi?id=174551
3285
3286         Reviewed by Darin Adler.
3287
3288         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3289           by ensuring that the prefix is applied as is done in generateDiff.
3290         - Silence output of explanatory lines from svn stat (" > move to ...")
3291           that show up in STDERR when running svn-create-patch.
3292         - Add verbose logging that I found useful while debugging this issue.
3293
3294         * Scripts/svn-create-patch:
3295         (findBaseUrl):
3296         (findMimeType):
3297         (findSourceFileAndRevision):
3298         (generateDiff):
3299         (generateFileList):
3300         (manufacturePatchForAdditionWithHistory):
3301
3302 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3303
3304         Unreviewed build fix after r219537.
3305
3306         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3307
3308 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3309
3310         Add iOS 11 SPI
3311         https://bugs.webkit.org/show_bug.cgi?id=174430
3312         <rdar://problem/33269288>
3313
3314         Reviewed by Tim Horton.
3315
3316         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3317         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3318         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3319
3320 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3321
3322         Failing to install on iPad simulators
3323         https://bugs.webkit.org/show_bug.cgi?id=174532
3324         <rdar://problem/33328347>
3325
3326         Reviewed by Stephanie Lewis.
3327
3328         * Scripts/webkitpy/xcode/simulated_device.py:
3329         (SimulatedDevice.install_app): Place install command in retry try-except block.
3330
3331 2017-07-14  Jeff Miller  <jeffm@apple.com>
3332
3333         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3334         https://bugs.webkit.org/show_bug.cgi?id=174524
3335
3336         Reviewed by Sam Weinig.
3337
3338         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3339         (TEST):
3340         Renamed TestParameter to TestParameter1.
3341         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3342
3343         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3344         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3345         Observe changes for two bundle parameters.
3346
3347         (-[BundleParametersPlugIn dealloc]):
3348         Remove observers for two bundle parameters.
3349
3350 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3351
3352         Unreviewed, rolling out r219510.
3353         https://bugs.webkit.org/show_bug.cgi?id=174525
3354
3355         Need to revert length() == 0 check for null string (Requested
3356         by yusukesuzuki on #webkit).
3357
3358         Reverted changeset:
3359
3360         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3361         static string if StringImpl is static"
3362         https://bugs.webkit.org/show_bug.cgi?id=174501
3363         http://trac.webkit.org/changeset/219510
3364
3365 2017-07-14  Jer Noble  <jer.noble@apple.com>
3366
3367         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3368         https://bugs.webkit.org/show_bug.cgi?id=174514
3369
3370         Reviewed by Sam Weinig.
3371
3372         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3373         (TestWebKitAPI::TEST_F):
3374
3375 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3376
3377         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3378         https://bugs.webkit.org/show_bug.cgi?id=174501
3379
3380         Reviewed by Darin Adler.
3381
3382         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3383         (TestWebKitAPI::TEST):
3384
3385 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3386
3387         Bring mac expectations in-line with other platforms
3388         https://bugs.webkit.org/show_bug.cgi?id=174472
3389         <rdar://problem/33297388>
3390
3391         Reviewed by David Kilzer.
3392
3393         The override order for Mac test expectations does not conform to the pattern used by iOS,
3394         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3395
3396             platform/mac-wk2
3397             platform/wk2
3398             platform/mac-elcapitan
3399             platform/mac-sierra
3400             generic
3401
3402         After this change, El Capitan's baseline search path looks like this:
3403
3404             platform/mac-sierra-wk2
3405             platform/mac-sierra
3406             platform/mac-wk2
3407             platform/wk2
3408             generic
3409
3410         * Scripts/webkitpy/port/mac.py:
3411         (MacPort.__init__): If a specific version is specified in the port name, use that
3412         as the os version.
3413         (MacPort.default_baseline_search_path): Expectation search paths should work the
3414         same way they do on other ports. Port + version overrides port, port overrides generic
3415         and wk1/wk2 should override expectations for the two combined.
3416         * Scripts/webkitpy/port/mac_unittest.py:
3417         (MacTest.test_tests_for_other_platforms): Deleted.
3418         (MacTest._assert_search_path): Deleted.
3419         (MacTest.test_baseline_search_path): Deleted.
3420         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3421         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3422         (test_rebaseline_test_and_print_scm_changes): Ditto.
3423         (test_rebaseline_and_copy_test): Ditto.
3424         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3425         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3426         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3427
3428 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3429
3430         Fix style checker unit test
3431
3432         Unreviewed WebKit2 => WebKit fixup.
3433
3434         * Scripts/webkitpy/style/checker_unittest.py:
3435         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3436
3437 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3438
3439         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3440
3441         Unreviewed build fix.
3442
3443         r219492 missed one hunk from its partial revert of r219489.
3444         This patch reverts that hunk.
3445
3446         * TestWebKitAPI/CMakeLists.txt:
3447
3448 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3449
3450         Use the old WebKit/WebKit2 targets for CMake builds.
3451
3452         Unreviewed build fix.
3453
3454         We can update the target names to match the Framework names in a future patch.
3455         This is a partial revert of r219489.
3456
3457         * TestWebKitAPI/CMakeLists.txt:
3458         WebKitLegacy => WebKit
3459         WebKit => WebKit2
3460
3461 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3462
3463         Fix TestWebKit API.
3464         https://bugs.webkit.org/show_bug.cgi?id=174164
3465         rdar://problem/33137595
3466
3467         Reviewed by Dan Bernstein.
3468
3469         * TestWebKitAPI/CMakeLists.txt:
3470         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3471         * TestWebKitAPI/PlatformGTK.cmake:
3472
3473 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3474
3475         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3476         https://bugs.webkit.org/show_bug.cgi?id=174164
3477         rdar://problem/33137595
3478
3479         Reviewed by Dan Bernstein.
3480
3481         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3482         (ShouldBuildTest):
3483         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3484         * Scripts/build-webkit:
3485         * Scripts/do-file-rename:
3486         * Scripts/do-webcore-rename:
3487         * Scripts/update-webkit-localizable-strings:
3488         * Scripts/webkitpy/common/config/watchlist:
3489         * Scripts/webkitpy/style/checker.py:
3490         * Scripts/webkitpy/style/checkers/featuredefines.py:
3491         * gtk/make-dist.py:
3492         (ensure_version_if_possible):
3493         * gtk/manifest.txt.in:
3494
3495 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3496
3497         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3498         https://bugs.webkit.org/show_bug.cgi?id=174162
3499         rdar://problem/33137594
3500
3501         Reviewed by Dan Bernstein.
3502
3503         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3504
3505         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3506         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3507         * EWSTools/configure-clang-linux.sh:
3508         * Scripts/build-webkit:
3509         * Scripts/do-file-rename:
3510         * Scripts/do-webcore-rename:
3511         * Scripts/update-webkit-localizable-strings:
3512         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3513         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3514         * Scripts/webkitpy/style/checkers/featuredefines.py:
3515         * gtk/manifest.txt.in:
3516
3517 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3518
3519         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3520         https://bugs.webkit.org/show_bug.cgi?id=174438
3521         <rdar://problem/33277112>
3522
3523         Reviewed by Aakash Jain.
3524
3525         Given a patch, this will convert the changes from the path to the new directory structure.
3526
3527         * Scripts/rebase-patch-after-webkit-move: Added.
3528         (append_source): Append 'Source' to the provided path.
3529         (is_editable_line): Return true if a line the script expects to modify.
3530         (needs_rebase): Return if a line needs to be rebased based on it's content.
3531         (rebase_line): Rebase the provided line.
3532         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3533         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3534         were provided.
3535
3536 2017-07-12  Nan Wang  <n_wang@apple.com>
3537
3538         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3539         https://bugs.webkit.org/show_bug.cgi?id=174393
3540         <rdar://problem/33248006>
3541
3542         Reviewed by Chris Fleizach.
3543
3544         * DumpRenderTree/AccessibilityUIElement.cpp:
3545         (textMarkerRangeMatchesTextNearMarkersCallback):
3546         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3547         (AccessibilityUIElement::getJSClass):
3548         * DumpRenderTree/AccessibilityUIElement.h:
3549         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3550         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3551         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3552         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3553         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3554         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3555         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3556         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3557
3558 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3559
3560         Unreviewed, rolling out r219409.
3561
3562         The revision caused the Windows builds to fail.
3563
3564         Reverted changeset:
3565
3566         "AX: [iOS] Implement a way to retrieve a text marker range
3567         with desired text that is closest to a position"
3568         https://bugs.webkit.org/show_bug.cgi?id=174393
3569         http://trac.webkit.org/changeset/219409
3570
3571 2017-07-12  Nan Wang  <n_wang@apple.com>
3572
3573         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3574         https://bugs.webkit.org/show_bug.cgi?id=174393
3575         <rdar://problem/33248006>
3576
3577         Reviewed by Chris Fleizach.
3578
3579         * DumpRenderTree/AccessibilityUIElement.cpp:
3580         (textMarkerRangeMatchesTextNearMarkersCallback):
3581         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3582         (AccessibilityUIElement::getJSClass):
3583         * DumpRenderTree/AccessibilityUIElement.h:
3584         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3585         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3586         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3587         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3588         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3589         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3590         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3591         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3592
3593 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3594
3595         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3596         https://bugs.webkit.org/show_bug.cgi?id=174197
3597
3598         Reviewed by Darin Adler.
3599
3600         This bit me the first time I tried to submit a patch to WebKit, and still I have
3601         to manually edit the ChangeLog every time I use the script.
3602
3603         This generates a more convenient and standard ChangeLog entry.
3604
3605         * Scripts/prepare-ChangeLog:
3606         (generateNewChangeLogs):
3607
3608 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3609
3610    &nbs