Dashboard tests fails to fetch the revision from commits
[WebKit-https.git] / Tools / ChangeLog
1 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2
3         Dashboard tests fails to fetch the revision from commits
4         https://bugs.webkit.org/show_bug.cgi?id=170191
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
9         Added recordedCommitIndicesByRevisionNumber.
10         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
11         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
12
13 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
14
15         Safari crashes when attempting to close tab that is displaying PDF
16         https://bugs.webkit.org/show_bug.cgi?id=170201
17         <rdar://problem/31242019>
18
19         Reviewed by Wenson Hsieh.
20
21         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
22         (TEST):
23         Add a test for doAfterNextStablePresentationUpdate just like the existing
24         non-stable one.
25
26 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
27
28         webkitpy: Use host pattern for devices
29         https://bugs.webkit.org/show_bug.cgi?id=170121
30
31         Reviewed by Daniel Bates.
32
33         Devices should be treated like hosts throughout webkitpy
34         so that more code can be re-used.  Add the needed properties
35         and use executive over custom implemented polling/killing
36         functions.
37
38         * Scripts/webkitpy/port/device.py:
39         (Device):
40         (Device.executive): Add optional executive property.
41         (Device.filesystem): Add optional filesystem property.
42         (Device.user): Add optional user property.
43         (Device.platform): Add optional platform property.
44         (Device.workspace): Add optional workspace property.
45         (Device.poll): Deleted.
46         * Scripts/webkitpy/port/simulator_process.py:
47         (SimulatorProcess.Popen.poll): Use the devices executive.
48         (SimulatorProcess.stop): Ditto.
49         (SimulatorProcess._kill): Ditto.
50         * Scripts/webkitpy/xcode/simulated_device.py:
51         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
52         and workspace to the platform device.
53         (SimulatedDevice.poll): Deleted.
54
55 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
56
57         Dashboard test fails with error: latestIterationGetter is not a function
58         https://bugs.webkit.org/show_bug.cgi?id=170167
59
60         Reviewed by Alexey Proskuryakov.
61
62         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
63         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
64
65 2017-03-27  Lucas Forschler  <lforschler@apple.com>
66
67         Another test v8.
68
69 2017-03-27  Lucas Forschler  <lforschler@apple.com>
70
71         Another test v7.
72
73 2017-03-27  Lucas Forschler  <lforschler@apple.com>
74
75         Another test v6.
76
77 2017-03-27  Lucas Forschler  <lforschler@apple.com>
78
79         Another test v5.
80
81 2017-03-27  Lucas Forschler  <lforschler@apple.com>
82
83         Another test v4.
84
85 2017-03-27  Lucas Forschler  <lforschler@apple.com>
86
87         Another test v3.
88
89 2017-03-27  Lucas Forschler  <lforschler@apple.com>
90
91         Another test v2.
92
93 2017-03-27  Lucas Forschler  <lforschler@apple.com>
94
95         Another test.
96
97 2017-03-27  Lucas Forschler  <lforschler@apple.com>
98
99         <rdar://problem/30949128>
100         Update build.webkit.org to use port 16000 for PBChangeSource.
101         
102         Reviewed by Alexey Proskuryakov.
103
104         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
105
106 2017-03-27  Jason Marcell  <jmarcell@apple.com>
107
108         Bots should run the dashboard tests
109         https://bugs.webkit.org/show_bug.cgi?id=168994
110
111         Reviewed by Daniel Bates and David Kilzer.
112
113         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
114
115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
116         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
117         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
118         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
119         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
120         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
121         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
122         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
124
125 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
126
127         webkitpy: Look for 'ios' test expectations for IOSPorts
128         https://bugs.webkit.org/show_bug.cgi?id=169413
129
130         Reviewed by Alexey Proskuryakov.
131
132         Test expectations for iOS tests should include the 'ios' folder.  Modify
133         default_baseline_search_path to include 'ios' folder and derivatives for
134         IOSPort.
135
136         * Scripts/webkitpy/port/ios.py:
137         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
138         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
139         (IOSPort.test_expectations_file_position): Added for testing.
140         * Scripts/webkitpy/port/ios_simulator.py:
141         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
142         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
143
144 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
145
146         REGRESSION: Reseting _device_map on each child process
147         <rdar://problem/31274476>
148
149         Unreviewed infrastructure fix.
150
151         * Scripts/webkitpy/port/ios_simulator.py:
152         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
153         (IOSSimulatorPort.__init__): Use shared class variable
154         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
155         (IOSSimulatorPort._create_devices): Ditto.
156         (IOSSimulatorPort._quit_ios_simulator): Ditto.
157         (IOSSimulatorPort.clean_up_test_run): Ditto.
158
159 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
160
161         REGRESSION: Failing to iterate over Simulator.managed_devices map
162         <rdar://problem/31274476>
163
164         Unreviewed infrastructure fix.
165
166         * Scripts/webkitpy/port/ios_simulator.py:
167         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
168
169 2017-03-27  Alex Christensen  <achristensen@webkit.org>
170
171         Make WebSockets work in network process
172         https://bugs.webkit.org/show_bug.cgi?id=169930
173
174         Reviewed by Youenn Fablet.
175
176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
177         Add terminateNetworkProcess for the new test
178         http/tests/websocket/tests/hybi/network-process-crash-error.html
179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
180         (WTR::TestRunner::setAllowsAnySSLCertificate):
181         (WTR::TestRunner::terminateNetworkProcess):
182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
183         * WebKitTestRunner/TestController.cpp:
184         (WTR::TestController::setAllowsAnySSLCertificate):
185         (WTR::TestController::terminateNetworkProcess):
186         * WebKitTestRunner/TestController.h:
187         * WebKitTestRunner/TestInvocation.cpp:
188         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
189         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
190         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
191         (WTR::TestController::platformContext):
192         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
193         (WTR::TestController::platformContext):
194         (WTR::TestController::platformLibraryPathForTesting):
195         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
196         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
197         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
198         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
199         which tests that wss works, but our test certificate has an invalid certificate chain.
200         We want production software to not have the ability to have its security weakened, so this
201         is a test code path that is only implemented in WebKitTestRunner.
202
203 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
204
205         webkitpy: Use generalized device instead of platform specific one
206         https://bugs.webkit.org/show_bug.cgi?id=170078
207
208         Reviewed by Daniel Bates.
209
210         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
211         should remain persistent.  Changing Device to a more explicit interface.
212         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
213         wrapping SimulatedDevices.
214
215         * Scripts/webkitpy/port/device.py: Added.
216         (Device):
217         (Device.__init__): Construct with platform device.
218         (Device.install_app): Install app at app path on platform device.
219         (Device.launch_app): Launch app with bundle ID on platform device.
220         (Device.poll): Poll platform device.
221         (Device.udid): Access platform device UDID.
222         (Device.__nonzero__): Check if instantiated with a valid platform device.
223         (Device.__eq__): Compare by udid.
224         (Device.__ne__): Ditto.
225         (Device.__repr__): Print out platform_device representation.
226         * Scripts/webkitpy/port/ios_simulator.py:
227         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
228         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
229         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
230         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
231         device map.
232         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
233         * Scripts/webkitpy/xcode/device.py: Removed.
234         * Scripts/webkitpy/xcode/simulated_device.py:
235         (SimulatedDevice):
236         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
237         (SimulatedDevice.__eq__): Compare two simulated devices.
238         (SimulatedDevice.__ne__): Ditto.
239         (SimulatedDevice.__repr__): Print name and udid.
240
241 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
242
243         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
244         https://bugs.webkit.org/show_bug.cgi?id=170059
245
246         Reviewed by Carlos Garcia Campos.
247
248         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
249         the only use of the method in this same file ignores the returned value anyway.
250
251 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
252
253         webkitpy should be able to run API tests
254         https://bugs.webkit.org/show_bug.cgi?id=170028
255
256         Reviewed by Alexey Proskuryakov.
257
258         * Scripts/webkitpy/common/config/ports.py:
259         (DeprecatedPort.run_api_tests_command): Added.
260         * Scripts/webkitpy/port/base.py:
261         (Port.api_results_directory): Added.
262         * Scripts/webkitpy/tool/steps/runtests.py:
263         (RunTests.run): Check if we should be running API tests.
264         (RunTests._run_api_tests): Generate script to run API tests with json output.
265         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
266
267 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
268
269         Add JSON results for API tests
270         https://bugs.webkit.org/show_bug.cgi?id=170021
271
272         Reviewed by Alexey Proskuryakov.
273
274         * Scripts/run-api-tests:
275         (runTestsBySuite): Appends failures and timeouts to JSON data.
276         (writeJsonDataIfApplicable): Writes JSON data to a file.
277
278 2017-03-24  Lucas Forschler  <lforschler@apple.com>
279
280         update committer_auth.py to be python 2.7 compliant
281         https://bugs.webkit.org/show_bug.cgi?id=170063
282         
283         Reviewed by Alexey Proskuryakov.
284
285         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
286         (CommitterAuth.authenticate):
287             convert e.message to e.args[0]
288
289 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
290
291         webkitpy: Parse JSON results from run-api-tests
292         https://bugs.webkit.org/show_bug.cgi?id=170062
293
294         Reviewed by Alexey Proskuryakov.
295
296         * Scripts/webkitpy/common/net/apitestresults.py: Added.
297         (APITestResults): Structure to represent API test results.
298         (APITestResults.__init__):
299         (APITestResults.intersection): Return the failures common to both sets of results.
300         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
301         (APITestResults.equals): Return True if both results were the same.
302         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
303         (APITestResults.all_passed): Return True if everything passed.
304         (APITestResults.failing_tests): List of tests that didn't pass.
305         (APITestResults.did_exceed_test_failure_limit): Always False.
306         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
307         (APITestResultsTest): Unit tests.
308         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
309         (APITestResultsReader): Read contents of JSON results file.
310
311 2017-03-24  Alex Christensen  <achristensen@webkit.org>
312
313         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
314         https://bugs.webkit.org/show_bug.cgi?id=169167
315
316         Reviewed by Simon Fraser.
317
318         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
319         (TestWebKitAPI::TEST_F):
320         Test an example of a selector that was incorrectly determined to be invalid.
321
322 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
323
324         Increase timeout for booting simulators.
325         <rdar://problem/31080009>
326
327         Unreviewed infrastructure fix.
328
329         * Scripts/webkitpy/xcode/simulator.py:
330         (Simulator.wait_until_device_is_booted): Increase timeout.
331         (Simulator.wait_until_device_is_in_state): Increase timeout.
332
333 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
334
335         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
336
337         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
338         in our unit tests to work.
339
340         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
341         (testWebViewJavaScriptDialogs):
342
343 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
344
345         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
346         https://bugs.webkit.org/show_bug.cgi?id=170001
347
348         Reviewed by Michael Catanzaro.
349
350         Ignore style of xdgmime sources.
351
352         * Scripts/webkitpy/tool/steps/checkstyle.py:
353
354 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
355
356         Dragging on a large image should not revert to a file icon if data interaction is enabled
357         https://bugs.webkit.org/show_bug.cgi?id=170018
358         <rdar://problem/31184508>
359
360         Reviewed by Tim Horton.
361
362         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
363         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
364
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
366         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
367         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
368         (TestWebKitAPI::TEST):
369
370 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
371
372         Update WinCairoRequirements.zip
373         https://bugs.webkit.org/show_bug.cgi?id=169950
374
375         Reviewed by Alex Christensen.
376
377         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
378
379 == Rolled over to ChangeLog-2017-03-23 ==