[WinCairo] Pass correct url for http test to test driver.
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2
3         [WinCairo] Pass correct url for http test to test driver.
4         https://bugs.webkit.org/show_bug.cgi?id=181814
5
6         Reviewed by Alex Christensen.
7
8         * Scripts/webkitpy/port/driver.py:
9         (Driver):
10         (Driver.http_test_path_to_uri):
11         (Driver.is_secure_path):
12         (Driver.http_base_url):
13         (Driver.uri_to_test):
14
15 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
16
17         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
18
19         * BuildSlaveSupport/build.webkit.org-config/config.json:
20
21 2018-01-18  Dan Bernstein  <mitz@apple.com>
22
23         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
24         https://bugs.webkit.org/show_bug.cgi?id=181803
25
26         Reviewed by Tim Horton.
27
28         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
29         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
30         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
31         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
32         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
33         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
34         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
35         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
36         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
37           helpers.
38         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
39           settings useful for defining settings that depend on the target macOS version.
40         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
41         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
42
43 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
44
45         Remove Opensource El Capitan queues from buildbot
46         https://bugs.webkit.org/show_bug.cgi?id=181712
47
48         Reviewed by Aakash Jain.
49
50         * BuildSlaveSupport/build.webkit.org-config/config.json:
51         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
52         (WebKitBuildbot):
53         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
54
55 2018-01-18  Chris Dumez  <cdumez@apple.com>
56
57         Service Workers restored from persistent storage have 'redundant' state
58         https://bugs.webkit.org/show_bug.cgi?id=181749
59         <rdar://problem/36556486>
60
61         Reviewed by Youenn Fablet.
62
63         Add API test coverage.
64
65         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
66         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
67
68 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
69
70         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
71         https://bugs.webkit.org/show_bug.cgi?id=176796
72
73         Reviewed by Chris Fleizach.
74
75         Add sanity check that we have a URL before calling g_strstr_len().
76
77         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
78         (WTR::AccessibilityUIElement::url):
79
80 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
81
82         Add triggers for Sierra test262 and perf queues
83         https://bugs.webkit.org/show_bug.cgi?id=181799
84
85         Reviewed by Aakash Jain.
86
87         * BuildSlaveSupport/build.webkit.org-config/config.json:
88
89 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
90
91         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
92         https://bugs.webkit.org/show_bug.cgi?id=181783
93         <rdar://problem/35785445>
94
95         Reviewed by Ryosuke Niwa.
96
97         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
98         copying an image contains a relevant title.
99
100         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
101         (TestWebKitAPI::TEST):
102         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
103         * TestWebKitAPI/ios/UIKitSPI.h:
104
105 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
106
107         WebDriver: ignore the driver in selenium test names when getting expectations
108         https://bugs.webkit.org/show_bug.cgi?id=181738
109
110         Reviewed by Carlos Alberto Lopez Perez.
111
112         In selenium tests, the driver is added as a parameter to every test which results in tests names like
113         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
114         driver name in the test expectations file, so we need to remove it when querying the expectations.
115
116         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
117         (TestExpectationsMarker.__init__): Save the param to ignore.
118         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
119         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
120         (run): Pass param to ignore to TestExpectationsMarker().
121         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
122         (WebDriverSeleniumExecutor.__init__): Save the driver name.
123         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
124
125 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
126
127         [GTK][WPE] Show unit tests unexpectedly passing in the bots
128         https://bugs.webkit.org/show_bug.cgi?id=181726
129
130         Reviewed by Michael Catanzaro.
131
132         Now that we have the info, let's show it also in the bots.
133
134         * BuildSlaveSupport/build.webkit.org-config/steps.py:
135         (RunGLibAPITests.commandComplete):
136
137 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
138
139         Fix broken unittest after r227048
140         https://bugs.webkit.org/show_bug.cgi?id=181760
141
142         Reviewed by Aakash Jain.
143
144
145 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
146
147         WEBKIT_FRAMEWORK should not modify file-global include directories
148         https://bugs.webkit.org/show_bug.cgi?id=181656
149
150         Reviewed by Konstantin Tokarev.
151
152         * TestWebKitAPI/PlatformWPE.cmake:
153         * TestWebKitAPI/glib/CMakeLists.txt:
154
155 2018-01-17  Alicia Boya García  <aboya@igalia.com>
156
157         Unreviewed, mark Alicia as committer in contributors.json
158
159         * Scripts/webkitpy/common/config/contributors.json:
160
161 2018-01-17  Youenn Fablet  <youenn@apple.com>
162
163         Put fetch Request.keepalive behind a runtime flag
164         https://bugs.webkit.org/show_bug.cgi?id=181592
165
166         Reviewed by Chris Dumez.
167
168         * DumpRenderTree/mac/DumpRenderTree.mm:
169         (enableExperimentalFeatures):
170         * DumpRenderTree/win/DumpRenderTree.cpp:
171         (enableExperimentalFeatures):
172         * WebKitTestRunner/TestController.cpp:
173         (WTR::TestController::resetPreferencesToConsistentValues):
174
175 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
176
177         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
178         https://bugs.webkit.org/show_bug.cgi?id=181637
179         <rdar://problem/36508471>
180
181         Reviewed by Tim Horton.
182
183         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
184         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
187         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
188         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
189
190         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
191         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
194         (webViewForTestingAttachments):
195         (-[TestWKWebView tagsInBody]):
196         (-[TestWKWebView expectElementTagsInOrder:]):
197         (-[TestWKWebView expectElementTag:toComeBefore:]):
198
199         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
200         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
201
202         (TestWebKitAPI::TEST):
203         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
204         (WTR::InjectedBundlePage::InjectedBundlePage):
205
206 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
207
208         WebDriver: add support for test expectations
209         https://bugs.webkit.org/show_bug.cgi?id=180420
210
211         Reviewed by Carlos Alberto Lopez Perez.
212
213         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
214
215         * Scripts/run-webdriver-tests: Get the retval from process_results().
216         * Scripts/webkitpy/thirdparty/__init__.py:
217         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
218         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
219         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
220         (TestExpectationsMarker.__init__): Initialize expectations.
221         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
222         (run): Create and use TestExpectationsMarker plugin.
223         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
224         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
225         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
226         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
227         (WebDriverTestRunner.run): Do not count results here.
228         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
229         amount of failures. Printing the test summary while processing results will be made optional in a follow up
230         patch.
231         (WebDriverTestRunner.process_results.report): Return the amount of failures.
232         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
233         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
234         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
235         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
236         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
237         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
238         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
239         (WebDriverTestRunnerW3C._scan_directory): Ditto.
240         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
241         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
242         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
243
244 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
245
246         Unreviewed WPE gardening. Mark some known unit test failures.
247
248         * TestWebKitAPI/glib/TestExpectations.json:
249
250 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
251
252         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
253         https://bugs.webkit.org/show_bug.cgi?id=181724
254
255         Reviewed by Philippe Normand.
256
257         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
258         reason to use different names. This way we can refer to the same test names for both and we can share the
259         expectations in the TestExpectations.json file.
260
261         * TestWebKitAPI/glib/TestExpectations.json:
262         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
263
264 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
265
266         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
267
268         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
269         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
270
271         * glib/api_test_runner.py:
272         (TestRunner._run_test_glib):
273         (TestRunner._run_google_test):
274
275 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
276
277         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
278         https://bugs.webkit.org/show_bug.cgi?id=179914
279
280         Reviewed by Žan Doberšek.
281
282         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
283         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
284         all symbols listed in the script are present in the library.
285
286         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
287         (bss_symbols):
288         * Scripts/check-for-invalid-symbols-in-version-script: Added.
289         (script_symbols):
290         * Scripts/make-dist:
291         (Distcheck.build):
292         (Distcheck):
293         (Distcheck.check_symbols):
294         (Distcheck.check):
295
296 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
297
298         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
299         https://bugs.webkit.org/show_bug.cgi?id=181722
300
301         Reviewed by Žan Doberšek.
302
303         I forgot to pass the parameters to run() when restarting.
304
305         * glib/glib_test_runner.py:
306         (GLibTestRunner.run):
307
308 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
309
310         [CMake] Remove WebCoreDerivedSources library target
311         https://bugs.webkit.org/show_bug.cgi?id=181664
312
313         Reviewed by Carlos Garcia Campos.
314
315         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
316         * TestWebKitAPI/PlatformWin.cmake: Ditto.
317
318 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
319
320         Move Debug Test262, Release Test262 and Performance queues to Sierra
321         https://bugs.webkit.org/show_bug.cgi?id=181692
322
323         Unreviewed
324
325 2018-01-16  Zach Li  <zachli@apple.com>
326
327         Add pop-up policy support in website policies.
328         https://bugs.webkit.org/show_bug.cgi?id=181544.
329         rdar://problem/30521400.
330
331         Reviewed by Alex Christensen.
332
333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
334         Added pop-up-check.html.
335
336         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
337
338         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
339         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
340         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
341         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
342         (TEST):
343
344 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
345
346         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
347         https://bugs.webkit.org/show_bug.cgi?id=181638
348         <rdar://problem/36508702>
349
350         Reviewed by Dan Bernstein.
351
352         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
353         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
354
355         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
356         (-[AttachmentUpdateObserver init]):
357         (-[AttachmentUpdateObserver sourceForIdentifier:]):
358         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
359         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
360         (TestWebKitAPI::TEST):
361         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
362
363 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
364
365         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
366
367         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
368
369         * glib/api_test_runner.py:
370         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
371         * glib/glib_test_runner.py:
372         (GLibTestRunner.run): Use given env.
373
374 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
375
376         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
377         https://bugs.webkit.org/show_bug.cgi?id=181676
378
379         Reviewed by Carlos Alberto Lopez Perez.
380
381         The option was removed in r226967.
382
383         * BuildSlaveSupport/build.webkit.org-config/steps.py:
384         (RunGtkAPITests):
385         (RunWPEAPITests):
386
387 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
388
389         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
390
391         The bots are still passing that option and the step is failing because it was removed in r226967.
392
393         * glib/api_test_runner.py:
394         (add_options):
395
396 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
397
398         [GTK][WPE] Improve the way glib tests are run
399         https://bugs.webkit.org/show_bug.cgi?id=181674
400
401         Reviewed by Žan Doberšek.
402
403         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
404         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
405         tests failing due to an expected assert in the test and unexpected crashes.
406         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
407         not showing the subtest name in stdout in case of timeouts.
408         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
409         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
410         of every test case.
411
412         * glib/api_test_runner.py:
413         (TestRunner._run_test_glib): Use GLibTestRunner.
414         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
415         (add_options):
416         * glib/glib_test_runner.py: Added.
417         (TestTimeout):
418         (Message):
419         (Message.__init__):
420         (Message.create):
421         (Message.create.read_unsigned):
422         (Message.create.read_double):
423         (Message.create.read_string):
424         (GLibTestRunner):
425         (GLibTestRunner.__init__):
426         (GLibTestRunner._process_data):
427         (GLibTestRunner._process_message):
428         (GLibTestRunner._read_from_pipe):
429         (GLibTestRunner._read_from_stderr):
430         (GLibTestRunner._start_timeout):
431         (GLibTestRunner._start_timeout._alarm_handler):
432         (GLibTestRunner._stop_timeout):
433         (GLibTestRunner._subtest_start):
434         (GLibTestRunner._subtest_message):
435         (GLibTestRunner._subtest_stderr):
436         (GLibTestRunner._subtest_end):
437         (GLibTestRunner.run):
438
439 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
440
441         Unreviewed, add Thibault to contributors.json
442
443         It's a bit weird to add someone here before their first contribution, but this affects
444         Bugzilla autocomplete, and that is serious business.
445
446         * Scripts/webkitpy/common/config/contributors.json:
447
448 2018-01-15  JF Bastien  <jfbastien@apple.com>
449
450         Remove makePoisonedUnique
451         https://bugs.webkit.org/show_bug.cgi?id=181630
452         <rdar://problem/36498623>
453
454         Reviewed by Mark Lam.
455
456         Update tests.
457
458         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
461         (TestWebKitAPI::TEST):
462
463 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
464
465         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
466         https://bugs.webkit.org/show_bug.cgi?id=181476
467
468         Reviewed by Michael Catanzaro.
469
470         Update to xorg-server 1.19.6 which depends on libxfont2, and change
471         the lists of packages to install libxfont2-devel (or equivalent).
472
473         * gtk/install-dependencies:
474         * gtk/jhbuild.modules:
475
476 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
477
478         [GTK][WPE] Add support for unit test expectations
479         https://bugs.webkit.org/show_bug.cgi?id=181589
480
481         Reviewed by Michael Catanzaro.
482
483         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
484         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
485         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
486         script itself is not a good idea either.
487
488         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
489         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
490         convenient methods to query them.
491
492         * Scripts/run-gtk-tests:
493         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
494         * Scripts/run-wpe-tests:
495         (WPETestRunner): Ditto.
496         * Scripts/webkitpy/common/test_expectations.py: Added.
497         (TestExpectations):
498         (TestExpectations.__init__):
499         (TestExpectations._port_name_for_expected):
500         (TestExpectations._expected_value):
501         (TestExpectations.skipped_tests):
502         (TestExpectations.skipped_subtests):
503         (TestExpectations._expectation_value):
504         (TestExpectations.is_slow):
505         (TestExpectations.get_expectation):
506         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
507         (MockTestExpectations):
508         (MockTestExpectations.__init__):
509         (MockTestExpectations.is_skip):
510         (ExpectationsTest):
511         (assert_exp):
512         (assert_not_exp):
513         (assert_bad_exp):
514         (assert_skip):
515         (test_basic):
516         (test_skip):
517         (test_flaky):
518         (test_build_type):
519         * TestWebKitAPI/glib/TestExpectations.json: Added.
520         * glib/api_test_runner.py:
521         (TestRunner): Remove SkippedTest implementation.
522         (TestRunner.__init__): Create a TestExpectations.
523         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
524         (TestRunner._should_run_test_program): Ditto.
525         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
526         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
527         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
528         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
529         (TestRunner.run_tests.report): Helper to write report to stdout.
530
531 2018-01-13  Mark Lam  <mark.lam@apple.com>
532
533         Replace all use of ConstExprPoisoned with Poisoned.
534         https://bugs.webkit.org/show_bug.cgi?id=181542
535         <rdar://problem/36442138>
536
537         Reviewed by JF Bastien.
538
539         1. Converted tests to using new uintptr_t& poison type.
540         2. Added tests for Poisoned comparison operators.
541
542         * TestWebKitAPI/CMakeLists.txt:
543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
544         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
545         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
546         (TestWebKitAPI::TEST):
547         (TestWebKitAPI::initializeTestPoison): Deleted.
548         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
549         (TestWebKitAPI::TEST):
550         (TestWebKitAPI::passWithRef):
551         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
552         (TestWebKitAPI::TEST):
553         (TestWebKitAPI::f1):
554         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
555         (TestWebKitAPI::TEST):
556         (TestWebKitAPI::poisonedPtrFoo):
557         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
558         (TestWebKitAPI::TEST):
559         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
560         (TestWebKitAPI::TEST):
561
562 2018-01-13  David Kilzer  <ddkilzer@apple.com>
563
564         check-webkit-style: false positive for [whitespace/braces] with os_log format string
565         <https://webkit.org/b/181606>
566
567         Reviewed by Darin Adler.
568
569         * Scripts/webkitpy/style/checkers/cpp.py:
570         (check_spacing): Modify regular expression to ignore
571         os_log format strings like '%{public}'.
572         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
573         (CppStyleTest.test_spacing_before_braces): Add os_log
574         format string test.
575
576 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
577
578         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
579         https://bugs.webkit.org/show_bug.cgi?id=181626
580
581         Reviewed by Joseph Pecoraro.
582
583         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
584         Additionally, write a new API test covering the change in r226915.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
587         (webViewForTestingAttachments):
588         (TestWebKitAPI::TEST):
589
590 2018-01-12  Alex Christensen  <achristensen@webkit.org>
591
592         History state should be updated during client redirects with asynchronous policy decisions
593         https://bugs.webkit.org/show_bug.cgi?id=181358
594         <rdar://problem/35547689>
595
596         Reviewed by Andy Estes.
597
598         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
599         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
600         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
601         (TEST):
602
603 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
604
605         webkitpy: Refactor simulator code (Part 4)
606         https://bugs.webkit.org/show_bug.cgi?id=180555
607         <rdar://problem/36131381>
608
609         Reviewed by Aakash Jain.
610
611         Move new_simulated_device.py to simulated_device.py.
612
613         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
614         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
615         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
616         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
617         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
618
619 2018-01-12  Alex Christensen  <achristensen@webkit.org>
620
621         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
622         https://bugs.webkit.org/show_bug.cgi?id=181595
623
624         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
625         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
626         I change the < and > to $ to make this test pass and continue to test what it used to.
627
628         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
629         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
630         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
631
632 2018-01-11  Keith Miller  <keith_miller@apple.com>
633
634         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
635         https://bugs.webkit.org/show_bug.cgi?id=181573
636
637         Reviewed by Simon Fraser.
638
639         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
640
641 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
642
643         [WebAuthN] Import a CBOR coder from Chromium
644         https://bugs.webkit.org/show_bug.cgi?id=181522
645         <rdar://problem/36055729>
646
647         Reviewed by Brent Fulgham.
648
649         This patch also imports all unit tests into our API tests to ensure all
650         workarounds and modification against the original codebase doesn't change
651         any original functionalities.
652
653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
654         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
655         (TestWebKitAPI::TEST):
656         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
657         (TestWebKitAPI::TEST):
658         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
659         (TestWebKitAPI::eq):
660         Workarounds applied.
661         (TestWebKitAPI::TEST):
662
663 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
664
665         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
666         https://bugs.webkit.org/show_bug.cgi?id=181538
667         <rdar://problem/36440580>
668
669         Reviewed by Aakash Jain.
670
671         When disambiguating a device type, it is possible that the provided device type is sufficiently
672         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
673         will result in a failure to disambiguate the type.
674
675         * Scripts/webkitpy/xcode/new_simulated_device.py:
676         (SimulatedDeviceManager._disambiguate_device_type):
677
678 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
679
680         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
681         https://bugs.webkit.org/show_bug.cgi?id=181136
682         <rdar://problem/36116604>
683
684         Reviewed by Chris Dumez.
685
686         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
687         browsing sessions.
688
689         * Scripts/run-gtk-tests:
690         (GtkTestRunner): Unskip test now that it passes.
691         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
692         (TEST): Add new WebsiteDataStoreEphemeral test.
693
694 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
695
696         Unreviewed, rolling out r226816.
697
698         This change broke LayoutTests on the bots.
699
700         Reverted changeset:
701
702         "run-webkit-tests fails when there is a curly brace in Xcode
703         build output"
704         https://bugs.webkit.org/show_bug.cgi?id=181254
705         https://trac.webkit.org/changeset/226816
706
707 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
708
709         webkitpy: Fix flakey webserver tests
710         https://bugs.webkit.org/show_bug.cgi?id=181555
711         <rdar://problem/36448273>
712
713         Reviewed by Aakash Jain.
714
715         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
716         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
717         determine if a specific server is running.
718
719 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
720
721         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
722         https://bugs.webkit.org/show_bug.cgi?id=181561
723         <rdar://problem/36452652>
724
725         Reviewed by Aakash Jain.
726
727         BeautifulSoup.find may return None, this case should be gracefully handled.
728
729         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
730         (BugzillaQueries._parse_result_count):
731         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
732
733 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
734
735         run-webkit-tests fails when there is a curly brace in Xcode build output
736         https://bugs.webkit.org/show_bug.cgi?id=181254
737
738         Reviewed by Daniel Bates.
739
740         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
741         (MeteredStream.write):
742
743 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
744
745         webkitpy: Reimplement simulator code (Part 3)
746         https://bugs.webkit.org/show_bug.cgi?id=180555
747         <rdar://problem/36131381>
748
749         Reviewed by Aakash Jain.
750
751         Remove old simulator code.
752
753         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
754         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
755         * Scripts/webkitpy/xcode/simulator.py: Removed.
756         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
757
758 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
759
760         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
761         https://bugs.webkit.org/show_bug.cgi?id=181337
762         <rdar://problem/36324813>
763
764         Reviewed by Tim Horton.
765
766         Add 3 new API tests for attachment element dragging.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
769         (-[TestWKWebView expectElementTag:toComeBefore:]):
770         (-[NSItemProvider expectType:withData:]):
771         (TestWebKitAPI::TEST):
772
773 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
774
775         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
776         https://bugs.webkit.org/show_bug.cgi?id=179621
777         <rdar://problem/35589585>
778
779         Unreviewed infrastructure fix.
780
781         * Scripts/webkitpy/port/mac.py:
782         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
783         list if we are the VERSION_MAX, which usually corresponds with future.
784
785 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
786
787         CodeBlocks should be in IsoSubspaces
788         https://bugs.webkit.org/show_bug.cgi?id=180884
789
790         Reviewed by Saam Barati.
791         
792         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
793         shouldn't take a long time due to benchmarks we don't optimize for.
794         
795         * Scripts/run-jsc-benchmarks:
796
797 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
798
799         Test gardening for GTK.
800         https://bugs.webkit.org/show_bug.cgi?id=181477
801
802         Unreviewed test gardening.
803
804         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
805         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
806
807 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
808
809         Add the new JSCOnly bot to the scheduler.
810         https://bugs.webkit.org/show_bug.cgi?id=181487
811
812         Unreviewed follow-up patch after r226729
813
814         On r226729 I missed to add the new JSCOnly bot the default scheduler.
815         This is needed to make the bot automatically pick each commit for testing.
816
817         * BuildSlaveSupport/build.webkit.org-config/config.json:
818
819 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
820
821         [Attachment Support] Support dragging attachment elements out as files on iOS
822         https://bugs.webkit.org/show_bug.cgi?id=181199
823         <rdar://problem/36299316>
824
825         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
826
827         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
828         attachment API tests.
829
830         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
831         (-[NSItemProvider expectType:withData:]):
832         (TestWebKitAPI::TEST):
833
834         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
835         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
836         -expectType:withData: helper to inspect the item providers created from the drag source.
837
838         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
839         (TestWebKitAPI::TEST):
840         * TestWebKitAPI/ios/DataInteractionSimulator.h:
841         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
842         (-[MockDragSession localContext]):
843         (-[MockDragSession setLocalContext:]):
844         (-[DataInteractionSimulator _resetSimulatedState]):
845         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
846         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
847         (-[DataInteractionSimulator _advanceProgress]):
848         (-[DataInteractionSimulator endDataTransfer]):
849
850         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
851         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
852         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
853         MockDragSession to hold on to a localContext.
854
855 2018-01-11  Ali Juma  <ajuma@chromium.org>
856
857         Unreviewed. Add Ali Juma as contributor
858
859         * Scripts/webkitpy/common/config/contributors.json:
860
861 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         Unreviewed. Update Selenium WebDriver imported tests.
864
865         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
866         environment variables.
867
868         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
869         (collect): Reorder the arguments to make pytest happy.
870         (run): Ditto.
871         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
872         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
873
874 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
875
876         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
877         https://bugs.webkit.org/show_bug.cgi?id=181492
878         <rdar://problem/36359679>
879
880         Reviewed by Alexey Proskuryakov. 
881
882 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
883
884         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
885         https://bugs.webkit.org/show_bug.cgi?id=181475
886
887         Reviewed by Michael Catanzaro.
888
889         * gtk/install-dependencies: Update package list for Arch Linux, extend
890         message shown at end of installation with additional tips.
891
892 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
893
894         REGRESSION(r222507): Composition highlight doesn't render when using IME
895         https://bugs.webkit.org/show_bug.cgi?id=181485
896         <rdar://problem/35896516>
897
898         Reviewed by Ryosuke Niwa.
899
900         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
901         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
902         allow rendering composition backgrounds (see InlineTextBox::paint).
903
904         * DumpRenderTree/ios/TextInputControllerIOS.m:
905         (+[TextInputController isSelectorExcludedFromWebScript:]):
906         (+[TextInputController webScriptNameForSelector:]):
907         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
908         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
909         * DumpRenderTree/mac/TextInputControllerMac.m:
910         (+[TextInputController isSelectorExcludedFromWebScript:]):
911         (+[TextInputController webScriptNameForSelector:]):
912         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
913         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
914         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
915         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
916         (WTR::TextInputController::setMarkedText):
917         * WebKitTestRunner/InjectedBundle/TextInputController.h:
918
919 2018-01-10  JF Bastien  <jfbastien@apple.com>
920
921         Poison small JSObject derivatives which only contain pointers
922         https://bugs.webkit.org/show_bug.cgi?id=181483
923         <rdar://problem/36407127>
924
925         Reviewed by Mark Lam.
926
927         Test the new move-assign and move-copy from unique_ptr, as well as
928         nullptr_t ctors.
929
930         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
931         (TestWebKitAPI::TEST):
932         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
933         (TestWebKitAPI::TEST):
934         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
935         (TestWebKitAPI::TEST):
936
937 2018-01-10  Chris Dumez  <cdumez@apple.com>
938
939         Multiple http/wpt/beacon/contentextensions/ test are flaky.
940         https://bugs.webkit.org/show_bug.cgi?id=179256
941         <rdar://problem/35401978>
942
943         Reviewed by Alex Christensen.
944
945         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
946         instance gets its own folder to avoid conflicts and flakiness.
947
948         * WebKitTestRunner/mac/TestControllerMac.mm:
949         (WTR::TestController::platformConfigureViewForTest):
950
951 2018-01-10  Tim Horton  <timothy_horton@apple.com>
952
953         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
954         https://bugs.webkit.org/show_bug.cgi?id=181269
955         <rdar://problem/35110344>
956
957         Reviewed by Simon Fraser.
958
959         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
960         (WTR::UIScriptController::beginBackSwipe):
961         (WTR::UIScriptController::completeBackSwipe):
962         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
963         (WTR::UIScriptController::beginBackSwipe):
964         (WTR::UIScriptController::completeBackSwipe):
965         (WTR::UIScriptController::overridePreference):
966         (WTR::UIScriptController::replaceTextAtRange):
967         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
968         (WTR::PlatformWebView::setNavigationGesturesEnabled):
969         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
970         (WTR::UIScriptController::beginBackSwipe):
971         (WTR::UIScriptController::completeBackSwipe):
972         Implement beginBackSwipe and completeBackSwipe on iOS (they already
973         exist on Mac) in terms of the new WKWebView testing SPI.
974
975 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
976
977         REGRESSION (r226715): ignore WARNING output in linter tests
978         https://bugs.webkit.org/show_bug.cgi?id=181486
979         <rdar://problem/36408847>
980
981         Reviewed by Aakash Jain.
982
983         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
984
985         * Scripts/webkitpy/common/system/outputcapture.py:
986         (OutputCapture.__init__): Pass logging level to be captured.
987         * Scripts/webkitpy/style/main_unittest.py:
988         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
989         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
990         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
991         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
992         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
993         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
994         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
995         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
996
997 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
998
999         Add a JSCOnly MIPS buildbot
1000         https://bugs.webkit.org/show_bug.cgi?id=181487
1001
1002         Reviewed by Michael Catanzaro.
1003
1004         Add the new bot configs definitions for the master and update the unit tests.
1005
1006         * BuildSlaveSupport/build.webkit.org-config/config.json:
1007         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1008
1009 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1010
1011         REGRESSION (r226715): don't re-check number of simulators in child processes
1012         https://bugs.webkit.org/show_bug.cgi?id=181484
1013         <rdar://problem/36407151>
1014
1015         Reviewed by Aakash Jain.
1016
1017         * Scripts/webkitpy/port/ios_simulator.py:
1018         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1019         are already initialized.
1020
1021 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1022
1023         Unreviewed, rolling out r226667 and r226673.
1024         https://bugs.webkit.org/show_bug.cgi?id=181488
1025
1026         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1027
1028         Reverted changesets:
1029
1030         "CodeBlocks should be in IsoSubspaces"
1031         https://bugs.webkit.org/show_bug.cgi?id=180884
1032         https://trac.webkit.org/changeset/226667
1033
1034         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1035         https://bugs.webkit.org/show_bug.cgi?id=180884
1036         https://trac.webkit.org/changeset/226673
1037
1038 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1039
1040         Follow-up fix to r226715
1041         https://bugs.webkit.org/show_bug.cgi?id=180555
1042         <rdar://problem/36131381>
1043
1044         Unreviewed infrastructure fix.
1045
1046         * Scripts/webkitpy/xcode/new_simulated_device.py:
1047         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1048         of delete.
1049
1050 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1051
1052         webkitpy: Refactor simulator code (Part 2)
1053         https://bugs.webkit.org/show_bug.cgi?id=180555
1054         <rdar://problem/36131381>
1055
1056         Reviewed by Aakash Jain.
1057
1058         The patch leverages the SimulatedDeviceManager when running layout tests.
1059         This patch is primarily code removal, since much of the IOSSimulatorPort
1060         was dedicated to managing simulators. The removed code is either now owned by the
1061         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1062         boot multiple simulators which was made obsolete in Xcode 9.
1063
1064         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1065         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1066         strip those spaces.
1067         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1068         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1069         * Scripts/webkitpy/port/ios.py:
1070         (IOSPort.__init__): The _current_device idiom is no longer required since the
1071         SimulatedDeviceManager keeps track of any previously booted devices.
1072         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1073         through the array of managed devices.
1074         (IOSPort.using_multiple_devices): Deleted.
1075         * Scripts/webkitpy/port/ios_device.py:
1076         (IOSDevicePort.using_multiple_devices): Deleted.
1077         * Scripts/webkitpy/port/ios_simulator.py:
1078         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1079         class strings so they can be parsed by the DeviceType class.
1080         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1081         the number of simulators currently booted, the number of child processes specified
1082         and the maximum number of simulators supported by this system.
1083         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1084         devices owned by the SimulatedDeviceManager.
1085         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1086         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1087         the maximum number of supported simulators on this system.
1088         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1089         request for each child process and send this list to the SimulatedDeviceManager to
1090         initialize the devices.
1091         (IOSSimulatorPort.clean_up_test_run):
1092         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1093         specified version of iOS.
1094         (IOSSimulatorPort.reset_preferences):
1095         (IOSSimulatorPort.simulator_runtime): Deleted.
1096         (IOSSimulatorPort.simulator_device_type): Deleted.
1097         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1098         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1099         (IOSSimulatorPort._create_simulators): Deleted.
1100         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1101         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1102         (IOSSimulatorPort.using_multiple_devices): Deleted.
1103         (IOSSimulatorPort._create_device): Deleted.
1104         (IOSSimulatorPort.get_simulator_path): Deleted.
1105         (IOSSimulatorPort._createSimulatorApps): Deleted.
1106         (IOSSimulatorPort._createSimulatorApp): Deleted.
1107         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1108         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1109         maximum number of simulators run on this system.
1110         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1111         * Scripts/webkitpy/xcode/new_simulated_device.py:
1112         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1113
1114 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1115
1116         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1117         https://bugs.webkit.org/show_bug.cgi?id=181474
1118
1119         Reviewed by Carlos Alberto Lopez Perez.
1120
1121         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1122         name as the name.
1123
1124         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1125         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1126         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1127
1128 2018-01-09  Andy Estes  <aestes@apple.com>
1129
1130         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1131         https://bugs.webkit.org/show_bug.cgi?id=181459
1132
1133         Reviewed by Dan Bernstein.
1134
1135         * ImageDiff/cg/Configurations/Base.xcconfig:
1136
1137 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1138
1139         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1140         https://bugs.webkit.org/show_bug.cgi?id=181374
1141
1142         Reviewed by Simon Fraser.
1143
1144         The test requires Palatino.
1145
1146         * DumpRenderTree/mac/DumpRenderTree.mm:
1147         (allowedFontFamilySet):
1148         * WebKitTestRunner/mac/TestControllerMac.mm:
1149         (WTR::allowedFontFamilySet):
1150
1151 2018-01-09  Saam Barati  <sbarati@apple.com>
1152
1153         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1154         https://bugs.webkit.org/show_bug.cgi?id=181449
1155
1156         Reviewed by JF Bastien.
1157
1158         This allows me to Cmd+f in my terminal to search for things without
1159         having the results become misaligned.
1160
1161         * Scripts/display-profiler-output:
1162
1163 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1164
1165         [webkitpy] PlatformInfo should have default argument for casual use
1166         https://bugs.webkit.org/show_bug.cgi?id=180827
1167
1168         Reviewed by David Kilzer.
1169
1170         PlatformInfo should be the only way to check platform specific thing instead
1171         of sys.platform or other various checks. If there is something you want to check,
1172         it should be placed in PlatformInfo.
1173
1174         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1175         sys, platform and Executive(). They are straight forward and should be handled
1176         by default arguments. Then we can instantiate PlatformInfo more casual.
1177
1178         * Scripts/webkitpy/common/system/platforminfo.py:
1179         (PlatformInfo): Use relative module path import
1180         (PlatformInfo.__init__):
1181         (PlatformInfo.executive): Lazy instantiation of Executive()
1182         (PlatformInfo.total_bytes_memory): Accessing via above property
1183         (PlatformInfo.xcode_sdk_version): Ditto
1184         (PlatformInfo.xcode_simctl_list): Ditto
1185         (PlatformInfo.xcode_version): Ditto
1186         (PlatformInfo._win_version_str): Ditto
1187         * Scripts/webkitpy/common/system/systemhost.py:
1188         (SystemHost.__init__):
1189         * Scripts/webkitpy/common/system/user.py:
1190         (User.__init__):
1191
1192 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1193
1194         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1195         https://bugs.webkit.org/show_bug.cgi?id=176443
1196
1197         Reviewed by Darin Adler.
1198
1199         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1200         (TEST):
1201
1202 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1203
1204         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1205         https://bugs.webkit.org/show_bug.cgi?id=181394
1206
1207         Reviewed by Darin Adler.
1208
1209         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1210         as the second parameter instead of ios(WK_IOS_TBA). This generally
1211         builds for iOS on EWS but not when using the public SDK. See r224057,
1212         r223207 and r226211 for example. This patch adds a basic style check
1213         for that macro to prevent this kind of mistake.
1214
1215         * Scripts/webkitpy/style/checkers/cpp.py:
1216         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1217         (check_style): Run new style check.
1218         (CppChecker): Add build type for the new style check.
1219         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1220         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1221
1222 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1223
1224         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1225         https://bugs.webkit.org/show_bug.cgi?id=181420
1226         <rdar://problem/36365827>
1227
1228         Reviewed by Alex Christensen.
1229
1230         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1231         of corresponding _WKAttachments.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1234         (TestWebKitAPI::TEST):
1235
1236 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1237
1238         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1239         https://bugs.webkit.org/show_bug.cgi?id=181410
1240         <rdar://problem/36167199>
1241
1242         Reviewed by Wenson Hsieh.
1243
1244         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1245         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1246         (TEST):
1247
1248 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1249
1250         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1251         https://bugs.webkit.org/show_bug.cgi?id=181408
1252         <rdar://problem/35884960>
1253
1254         Reviewed by Tim Horton.
1255
1256         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1257         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1258
1259 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1260
1261         [Attachment Support] Expose file name and content type of WKAttachment
1262         https://bugs.webkit.org/show_bug.cgi?id=181390
1263         <rdar://problem/36336837>
1264
1265         Reviewed by Tim Horton.
1266
1267         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1268
1269         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1270         (-[_WKAttachment synchronouslyRequestInfo:]):
1271         (-[_WKAttachment synchronouslyRequestData:]):
1272
1273         Reimplement this in terms of -synchronouslyRequestInfo:.
1274
1275         (-[_WKAttachment expectRequestedDataToBe:]):
1276         (TestWebKitAPI::TEST):
1277
1278 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1279
1280         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1281         https://bugs.webkit.org/show_bug.cgi?id=181365
1282         <rdar://problem/36340647>
1283
1284         Reviewed by Tim Horton.
1285
1286         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1287         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1288         detail.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1291         (TestWebKitAPI::TEST):
1292
1293 2018-01-08  Youenn Fablet  <youenn@apple.com>
1294
1295         navigator.onLine does not work inside service workers
1296         https://bugs.webkit.org/show_bug.cgi?id=181079
1297         <rdar://problem/36178606>
1298
1299         Reviewed by Darin Adler.
1300
1301         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1302         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1303
1304 2018-01-07  Saam Barati  <sbarati@apple.com>
1305
1306         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1307         https://bugs.webkit.org/show_bug.cgi?id=181372
1308
1309         Reviewed by Filip Pizlo.
1310
1311         Adding these sorting modes makes it easier to analyze functions
1312         that recompile a lot and exit a lot.
1313
1314         * Scripts/display-profiler-output:
1315
1316 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1317
1318         Unreviewed, remove my Cisco email from contributors.json
1319
1320         * Scripts/webkitpy/common/config/contributors.json:
1321
1322 2018-01-05  JF Bastien  <jfbastien@apple.com>
1323
1324         WebAssembly: poison JS object's secrets
1325         https://bugs.webkit.org/show_bug.cgi?id=181339
1326         <rdar://problem/36325001>
1327
1328         Reviewed by Mark Lam.
1329
1330         Update tests for swap(Poisoned<k, T>, T*)
1331
1332         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1333         (TestWebKitAPI::TEST):
1334         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1335         (TestWebKitAPI::TEST):
1336         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1337         (TestWebKitAPI::TEST):
1338
1339 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1340
1341         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1342         https://bugs.webkit.org/show_bug.cgi?id=181359
1343
1344         Reviewed by Tim Horton.
1345
1346         Ensure that these tests still pass using older SDKs.
1347
1348         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1349         (TestWebKitAPI::TEST):
1350
1351 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1352
1353         Rebase API test after r226469
1354         https://bugs.webkit.org/show_bug.cgi?id=181308
1355
1356         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1357         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1358         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1359
1360 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1361
1362         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1363         https://bugs.webkit.org/show_bug.cgi?id=181217
1364
1365         Reviewed by Tim Horton.
1366
1367         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1368         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1369         (TEST):
1370
1371 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1372
1373         Add WKBundleFrameCreateFrameHandle
1374         https://bugs.webkit.org/show_bug.cgi?id=181232
1375         <rdar://problem/35926696>
1376
1377         Reviewed by Tim Horton.
1378
1379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1380         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1381         (mouseDidMoveOverElement):
1382         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1383         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1384         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1385         (TEST):
1386
1387 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1388
1389         iOS: Build fix after r226432.
1390         
1391         Unreviewed. Stop duplicating speakAs symbols for iOS.
1392
1393         * DumpRenderTree/AccessibilityUIElement.cpp:
1394         (AccessibilityUIElement::speakAs):
1395
1396 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1397
1398         Unreviewed, added myself as WebKit reviewer
1399
1400         * Scripts/webkitpy/common/config/contributors.json:
1401
1402 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1403
1404         WPE: Build fix after r226432.
1405
1406         Unreviewed. Rename ::speak() to ::speakAs().
1407         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1408         (WTR::AccessibilityUIElement::speakAs):
1409         (WTR::AccessibilityUIElement::speak): Deleted.
1410
1411 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1412
1413         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1414         https://bugs.webkit.org/show_bug.cgi?id=180361
1415
1416         Reviewed by Zalan Bujtas.
1417
1418         * DumpRenderTree/AccessibilityUIElement.cpp:
1419         (speakAsCallback):
1420         (AccessibilityUIElement::speakAs):
1421         (AccessibilityUIElement::getJSClass):
1422         (speakCallback): Deleted.
1423         (AccessibilityUIElement::speak): Deleted.
1424         * DumpRenderTree/AccessibilityUIElement.h:
1425         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1426         (AccessibilityUIElement::speakAs):
1427         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1428         (AccessibilityUIElement::speakAs):
1429         (AccessibilityUIElement::speak): Deleted.
1430         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1431         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1432         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1433         (WTR::AccessibilityUIElement::speakAs):
1434         (WTR::AccessibilityUIElement::speak): Deleted.
1435         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1436         (WTR::AccessibilityUIElement::speakAs):
1437         (WTR::AccessibilityUIElement::speak): Deleted.
1438
1439 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1440
1441         REGRESSION (r226395): test-webkitperl test expectations incorrect
1442         https://bugs.webkit.org/show_bug.cgi?id=181307
1443         <rdar://problem/36306558>
1444
1445         Rubber-stamped by Aakash Jain.
1446
1447         r226395 added two lines towards the beginning of
1448         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1449         numbers in the test expectations need to update.
1450
1451         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1452
1453 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1454
1455         WKWebView loses minimum layout size overrides that happen while the process is terminated
1456         https://bugs.webkit.org/show_bug.cgi?id=181306
1457         <rdar://problem/34398288>
1458
1459         Reviewed by Dan Bernstein.
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1462         (TEST):
1463         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1464         while the process is terminated results in the page getting the correct
1465         minimum layout size.
1466
1467 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1468
1469         [MediaStream] Add Mock screen capture source
1470         https://bugs.webkit.org/show_bug.cgi?id=181291
1471         <rdar://problem/36298164>
1472
1473         Reviewed by Dean Jackson.
1474
1475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1476         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1477         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1478
1479 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1480
1481         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1482
1483         Reviewed by Ling Ho.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1486
1487 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         [Attachment Support] Create attachment elements when dropping files on iOS
1490         https://bugs.webkit.org/show_bug.cgi?id=181192
1491         <rdar://problem/36280945>
1492
1493         Reviewed by Tim Horton.
1494
1495         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1496         switch is enabled. See below for more details.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1499         (-[NSItemProvider registerData:type:]):
1500         (platformCopyPNG):
1501         (TestWebKitAPI::TEST):
1502         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1503
1504         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1505         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1506         kUTTypeRTF instead.
1507
1508         (TestWebKitAPI::TEST):
1509
1510         Tests a few cases of inserting attachment elements via drop:
1511         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1512             Instead of inserting the contents as inline web content, this should generate attachment elements.
1513         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1514             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1515             back to inserting the content as an attachment.
1516         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1517             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1518             or at the end).
1519
1520         * TestWebKitAPI/cocoa/TestWKWebView.h:
1521         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1522         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1523
1524         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1525         -stringByEvaluatingJavaScript to just turn around and call this.
1526
1527         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1528
1529 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1530
1531         Replace hard-coded paths in shebangs with #!/usr/bin/env
1532         https://bugs.webkit.org/show_bug.cgi?id=181040
1533
1534         Reviewed by Alex Christensen.
1535
1536         * BuildSlaveSupport/build-launcher-app:
1537         * BuildSlaveSupport/build-launcher-dmg:
1538         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1539         * BuildSlaveSupport/built-product-archive:
1540         * BuildSlaveSupport/clean-build:
1541         * BuildSlaveSupport/delete-stale-build-files:
1542         * BuildSlaveSupport/download-built-product:
1543         * BuildSlaveSupport/gtk/buildbot/log/run:
1544         * BuildSlaveSupport/gtk/buildbot/run:
1545         * BuildSlaveSupport/gtk/pulseaudio/run:
1546         * BuildSlaveSupport/kill-old-processes:
1547         * BuildSlaveSupport/test-result-archive:
1548         * BuildSlaveSupport/win/kill-old-processes:
1549         * Scripts/SpacingHeuristics.pm:
1550         * Scripts/add-include:
1551         * Scripts/build-api-tests:
1552         * Scripts/build-dumprendertree:
1553         * Scripts/build-imagediff:
1554         * Scripts/build-jsc:
1555         * Scripts/build-webkit:
1556         * Scripts/build-webkittestrunner:
1557         * Scripts/check-Xcode-source-file-types:
1558         * Scripts/check-dom-results:
1559         * Scripts/check-for-exit-time-destructors:
1560         * Scripts/check-for-global-initializers:
1561         * Scripts/check-for-inappropriate-objc-class-names:
1562         * Scripts/check-for-weak-vtables-and-externals:
1563         * Scripts/clean-header-guards:
1564         * Scripts/compare-timing-files:
1565         * Scripts/configure-xcode-for-ios-development:
1566         * Scripts/copy-webkitlibraries-to-product-directory:
1567         * Scripts/create-exports:
1568         * Scripts/debug-minibrowser:
1569         * Scripts/debug-safari:
1570         * Scripts/debug-test-runner:
1571         * Scripts/do-file-rename:
1572         * Scripts/do-webcore-rename:
1573         * Scripts/dump-webkit-tests-run:
1574         * Scripts/ensure-valid-python:
1575         * Scripts/execAppWithEnv:
1576         * Scripts/extract-localizable-js-strings:
1577         * Scripts/filter-build-webkit:
1578         * Scripts/find-extra-includes:
1579         * Scripts/fix-blink-patch:
1580         * Scripts/generate-coverage-data:
1581         * Scripts/git-add-reviewer:
1582         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1583         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1584         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1585         * Scripts/make-new-script-test:
1586         * Scripts/make-script-test-wrappers:
1587         * Scripts/package-root:
1588         * Scripts/parse-malloc-history:
1589         * Scripts/report-include-statistics:
1590         * Scripts/resolve-ChangeLogs:
1591         * Scripts/run-api-tests:
1592         * Scripts/run-bindings-tests:
1593         * Scripts/run-content-extension-tester:
1594         * Scripts/run-iexploder-tests:
1595         * Scripts/run-javascriptcore-tests:
1596         * Scripts/run-jsc:
1597         * Scripts/run-leaks:
1598         * Scripts/run-mangleme-tests:
1599         * Scripts/run-minibrowser:
1600         * Scripts/run-pageloadtest:
1601         * Scripts/run-regexp-tests:
1602         * Scripts/run-safari:
1603         * Scripts/run-sunspider:
1604         * Scripts/run-test-runner:
1605         * Scripts/run-webkit-app:
1606         * Scripts/run-webkit-httpd:
1607         * Scripts/run-webkit-websocketserver:
1608         * Scripts/set-webkit-configuration:
1609         * Scripts/show-pretty-diff:
1610         * Scripts/sort-Xcode-project-file:
1611         * Scripts/split-file-by-class:
1612         * Scripts/sunspider-compare-results:
1613         * Scripts/svn-apply:
1614         * Scripts/svn-unapply:
1615         * Scripts/test-webkit-scripts:
1616         * Scripts/test-webkitperl:
1617         * Scripts/update-iexploder-cssproperties:
1618         * Scripts/update-javascriptcore-test-results:
1619         * Scripts/update-webkit:
1620         * Scripts/update-webkit-auxiliary-libs:
1621         * Scripts/update-webkit-dependency:
1622         * Scripts/update-webkit-libs-jhbuild:
1623         * Scripts/update-webkit-localizable-strings:
1624         * Scripts/update-webkit-support-libs:
1625         * Scripts/update-webkitgtk-libs:
1626         * Scripts/update-webkitwpe-libs:
1627         * Scripts/webkit-build-directory:
1628         * Scripts/webkitperl/LoadAsModule.pm:
1629         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1630         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1631         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1632         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1633         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1634         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1635         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1636         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1637         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1638         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1639         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1640         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1641         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1642         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1643         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1644         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1645         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1646         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1647         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1648         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1649         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1650         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1651         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1652         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1653         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1654         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1655         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1656         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1657         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1658         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1659         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1660         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1661         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1662         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1663         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1664         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1665         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1666         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1667         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1668         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1669         * ccache/ccache-clang:
1670         * ccache/ccache-clang++:
1671         * ccache/ccache-wrapper:
1672         * gtk/install-dependencies:
1673         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1674         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1675         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1676         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1677         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1678         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1679         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1680         * iExploder/iexploder-1.7.2/src/webserver.rb:
1681         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1682         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1683         * wpe/install-dependencies:
1684
1685 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1686
1687         filter-build-webkit filters out useful compiler error lines
1688         https://bugs.webkit.org/show_bug.cgi?id=179864
1689
1690         Reviewed by Tim Horton.
1691
1692         Don't filter out lines that contain information about build errors by always showing lines
1693         after a line that contains "note:" or "error:".
1694
1695         * Scripts/filter-build-webkit:
1696         (shouldShowSubsequentLine):
1697         (shouldIgnoreLine):
1698
1699 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1700
1701         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1702         https://bugs.webkit.org/show_bug.cgi?id=173915
1703
1704         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1705         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1706         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1707         empty string in this case.
1708
1709         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1710         (emitFormSubmissionEvent):
1711
1712 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1713
1714         [GTK] Add web process API to detect when form is submitted via JavaScript
1715         https://bugs.webkit.org/show_bug.cgi?id=173915
1716
1717         Reviewed by Carlos Garcia Campos.
1718
1719         Test it.
1720
1721         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1722         (FormSubmissionTest::FormSubmissionTest):
1723         (FormSubmissionTest::~FormSubmissionTest):
1724         (FormSubmissionTest::testFormSubmissionResult):
1725         (FormSubmissionTest::willSendDOMEventCallback):
1726         (FormSubmissionTest::willCompleteCallback):
1727         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1728         (testWebExtensionFormSubmissionSteps):
1729         (beforeAll):
1730         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1731         (DelayedSignal::DelayedSignal):
1732         (emitFormSubmissionEvent):
1733         (handleFormSubmissionCallback):
1734         (willSubmitFormCallback):
1735         (pageCreatedCallback):
1736
1737 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1738
1739         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1740         https://bugs.webkit.org/show_bug.cgi?id=181251
1741
1742         * Scripts/run-gtk-tests:
1743         (GtkTestRunner):
1744
1745 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1746
1747         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1748         https://bugs.webkit.org/show_bug.cgi?id=181136
1749
1750         * Scripts/run-gtk-tests:
1751         (GtkTestRunner):
1752
1753 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1754
1755         [macOS, iOS] Adopt new secure coding APIs in WebKit
1756         https://bugs.webkit.org/show_bug.cgi?id=181085
1757         <rdar://problem/34837397>
1758
1759         Reviewed by Tim Horton.
1760
1761         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1762         capable of supporting NSSecureCoding, so pass through the current coding routines.
1763
1764         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1765         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1766         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1767         routines if necessary.
1768         (TEST): Updated for NSSecureCoding.
1769         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1770         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1771
1772 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1773
1774         Remove std::chrono completely
1775         https://bugs.webkit.org/show_bug.cgi?id=181186
1776
1777         Reviewed by Alex Christensen.
1778
1779         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1780         (WTR::TestController::platformRunUntil):
1781
1782 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1783
1784         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1785         https://bugs.webkit.org/show_bug.cgi?id=181231
1786
1787         Reviewed by Alex Christensen.
1788
1789         Implement TestController APIs needed by ResourceLoadStatistics tests.
1790
1791         * WebKitTestRunner/TestController.cpp:
1792         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1793         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1794
1795 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1796
1797         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1798         https://bugs.webkit.org/show_bug.cgi?id=181219
1799
1800         Reviewed by Wenson Hsieh.
1801
1802         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1803
1804 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1805
1806         Add a WebAuthentication runtime feature flag
1807         https://bugs.webkit.org/show_bug.cgi?id=181220
1808         <rdar://problem/36055305>
1809
1810         Reviewed by Brent Fulgham.
1811
1812         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1813
1814         * DumpRenderTree/TestOptions.h:
1815         * DumpRenderTree/TestOptions.mm:
1816         (TestOptions::TestOptions):
1817         * DumpRenderTree/mac/DumpRenderTree.mm:
1818         (enableExperimentalFeatures):
1819         (setWebPreferencesForTestOptions):
1820         * WebKitTestRunner/TestController.cpp:
1821         (WTR::TestController::resetPreferencesToConsistentValues):
1822         (WTR::updateTestOptionsFromTestHeader):
1823         * WebKitTestRunner/TestOptions.h:
1824         (WTR::TestOptions::hasSameInitializationOptions const):
1825
1826 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1827
1828         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1829         https://bugs.webkit.org/show_bug.cgi?id=181143
1830         <rdar://problem/36200381>
1831
1832         Reviewed by Tim Horton.
1833
1834         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1835         attachment elements are enabled.
1836
1837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1838         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1839         (TestWebKitAPI::TEST):
1840
1841 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1842
1843         Update Credential Management API for WebAuthentication
1844         https://bugs.webkit.org/show_bug.cgi?id=181082
1845         <rdar://problem/36055239>
1846
1847         Reviewed by Brent Fulgham.
1848
1849         Enable Credential Management API for testing.
1850
1851         * DumpRenderTree/TestOptions.h:
1852         * WebKitTestRunner/TestOptions.h:
1853
1854 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1855
1856         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1857         https://bugs.webkit.org/show_bug.cgi?id=168194
1858
1859         Reviewed by Carlos Garcia Campos.
1860
1861         Fix an assertion and unskip the test. The order that form controls are associated is not
1862         guaranteed.
1863
1864         * Scripts/run-gtk-tests:
1865         (GtkTestRunner):
1866         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1867         (didAssociateFormControlsCallback):
1868
1869 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1870
1871         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1872         https://bugs.webkit.org/show_bug.cgi?id=180897
1873         <rdar://problem/35535328>
1874
1875         Reviewed by Brent Fulgham.
1876
1877         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1880         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1881         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1882         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1883         (websiteDataStoreTestWebView):
1884         (TEST):
1885
1886 == Rolled over to ChangeLog-2018-01-01 ==