ac6f6b975966c2dcd494da810eeb2e2d978c3fac
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-29  Lucas Forschler  <lforschler@apple.com>
2
3         Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
4         https://bugs.webkit.org/show_bug.cgi?id=123450
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9         (RunWebKit2Tests.start):
10
11 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
12
13         [Mac] Rationalize user defaults override code
14         https://bugs.webkit.org/show_bug.cgi?id=123436
15
16         Reviewed by Dan Bernstein.
17
18         * DumpRenderTree/mac/DumpRenderTree.mm:
19         (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
20         because this function only resets WebPreferences now.
21         (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
22         here, because tests never change them, and they only need to be set once, not
23         before each test. Removed long obsolete workaround for HIToolbox preferences.
24         Don't call resetWebPreferencesToConsistentValues, because it will be called before
25         the first test anyway.
26         (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
27         (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
28         and setlocale calls out of resetWebPreferencesToConsistentValues().
29         Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
30         also needed in WK1.
31
32         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
33         (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
34         dictionary.
35
36         * WebKitTestRunner/mac/main.mm:
37         (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
38         use NSArgumentDomain for everything.
39
40 2013-10-29  Philippe Normand  <pnormand@igalia.com>
41
42         [GTK] enable media-stream in build-webkit
43         https://bugs.webkit.org/show_bug.cgi?id=123144
44
45         Reviewed by Martin Robinson.
46
47         * Scripts/webkitperl/FeatureList.pm: Enable media-stream build
48         for the GTK+ port.
49
50 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
51
52         EFL 32 bit buildbot doesn't work on dashboard
53         https://bugs.webkit.org/show_bug.cgi?id=123435
54
55         Reviewed by Csaba Osztrogonác.
56
57         32 bit buildbot doesn't work on dashboard because name is different from buildbot list.
58
59         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
60         (WebKitBuildbot):
61
62 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
63
64         Floating left the header broke other pages, and this CSS has no way to customize
65         per-page.
66
67         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
68
69 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
70
71         Remove underlines on the bot names in the header.
72         
73         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
74         (td.LastBuild a):
75
76 2013-10-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
77
78         Add EFL release bots to the buildbot dashboard
79         https://bugs.webkit.org/show_bug.cgi?id=123430
80
81         Reviewed by Darin Adler.
82
83         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
84         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
85         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
86         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
87         (table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
88
89 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
90
91         More waterfall tweaking.
92
93         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
94         (body > .header):
95         (td.LastBuild):
96         (td.LastBuild a):
97         (td.LastBuild,td.Activity a,td.Change a,td.Builder a):
98
99 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
100
101         More waterfall tweaking.
102
103         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
104         (body.interface):
105         (body > hr):
106         (div.content h1):
107         (body > .header):
108         (td.Activity a,td.Change a,td.Builder a):
109         (td.Builder):
110
111 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
112
113         Apply changes to default.css, revert buildbot.css which seems to be unused.
114
115         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
116         (body):
117         (body, td):
118         (a:link,a:visited,a:active):
119         (td.Time):
120         (td.Activity):
121         (.exception, td.offline):
122         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
123         (body.interface):
124         (.auth):
125         (td.LastBuild):
126         (td.Time):
127         (td.Activity):
128         (.offline,td.offline,.retry):
129
130 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
131
132         Prettify the waterfall page, and make it a little more space-efficient.
133         
134         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
135         (body, td):
136         (body.interface):
137         (.auth):
138         (.header):
139         (div.content h1):
140         (a):
141         (a:link,a:active):
142         (a:link,a:visited,a:active):
143         (td.LastBuild):
144         (td.Time):
145         (td.Activity):
146         (.exception, td.offline, .retry):
147
148 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
149
150         Fix Lion readableName (spotted by Dan Bernstein).
151
152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
153
154 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
155
156         Add tooltips to the platform icons in Dashboard
157         https://bugs.webkit.org/show_bug.cgi?id=123429
158
159         Reviewed by Alexey Proskuryakov.
160         
161         Add a human readable name to Buildbot.Platform entries, and use it to
162         show a tooltip on the ring image.
163
164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
166         (documentReady):
167
168 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
169
170         Allow explicit sort order for Dashboard platforms
171         https://bugs.webkit.org/show_bug.cgi?id=123419
172
173         Reviewed by Tim Hatcher.
174         
175         Assign a specific sort order to Dashboard platforms, rather than
176         just using object property order.
177
178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
180         (BuildbotQueue):
181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
182         (documentReady):
183
184 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
185
186         Tidy up main http://build.webkit.org page
187         https://bugs.webkit.org/show_bug.cgi?id=123413
188
189         Reviewed by Alexey Proskuryakov.
190         
191         Break the list of links into sections. Add some font style.
192
193         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
194
195 2013-10-28  Myles C. Maxfield  <mmaxfield@apple.com>
196
197         Parsing support for -webkit-text-decoration-skip: ink
198         https://bugs.webkit.org/show_bug.cgi?id=123358
199
200         Reviewed by Dean Jackson.
201
202         Adding ENABLE(CSS3_TEXT_DECORATION)
203
204         * Scripts/webkitperl/FeatureList.pm:
205
206 2013-10-28  Lucas Forschler  <lforschler@apple.com>
207
208         Add additional Apple Mavericks test bots.
209         
210         Unreviewed.
211         
212         * BuildSlaveSupport/build.webkit.org-config/config.json:
213
214 2013-10-28  Bastien Nocera <hadess@hadess.net>
215
216         Name all the GLib timeout sources
217         https://bugs.webkit.org/show_bug.cgi?id=123229
218
219         Reviewed by Anders Carlsson.
220
221         Give a name to GLib timeout sources, this is helpful when
222         profiling WebKitGTK applications.
223
224 2013-10-28  Bastien Nocera <hadess@hadess.net>
225
226         Replace 0 timeouts g_timeout_add() by g_idle_add()
227         https://bugs.webkit.org/show_bug.cgi?id=123260
228
229         Reviewed by Carlos Garcia Campos.
230
231         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
232         without the nagging feeling that the wrong API was used.
233
234         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
235         of 0-timer.
236         (topLoadingFrameLoadFinished):
237         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
238         (scheduleAsynchronousClickCallback):
239         (scheduleAsynchronousKeyDownCallback):
240
241 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
242
243         [GTK] [WebKit2] CanHandleRequest API test fails
244         https://bugs.webkit.org/show_bug.cgi?id=88453
245
246         Reviewed by Martin Robinson.
247
248         * Scripts/run-gtk-tests:
249         (TestRunner):
250
251 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
252
253         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
254
255         * Scripts/webkitpy/port/base.py:
256         (Port.repository_paths):
257
258 2013-10-25  Jer Noble  <jer.noble@apple.com>
259
260         [WTF] Add a multiplication operator (and a few others) to MediaTime
261         https://bugs.webkit.org/show_bug.cgi?id=123137
262
263         Reviewed by Eric Carlson.
264
265         Add tests for new MediaTime operators.
266
267         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
268         (TestWebKitAPI::TEST):
269
270 2013-10-24  Mark Rowe  <mrowe@apple.com>
271
272         Remove references to OS X 10.7 from Xcode configuration settings.
273
274         Now that we're not building for OS X 10.7 they're no longer needed.
275
276         Reviewed by Anders Carlsson.
277
278         * DumpRenderTree/mac/Configurations/Base.xcconfig:
279         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
280         * MiniBrowser/Configurations/Base.xcconfig:
281         * MiniBrowser/Configurations/DebugRelease.xcconfig:
282         * TestWebKitAPI/Configurations/Base.xcconfig:
283         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
284         * WebKitLauncher/Configurations/Base.xcconfig:
285         * WebKitTestRunner/Configurations/Base.xcconfig:
286         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
287
288 2013-10-24  Mark Rowe  <mrowe@apple.com>
289
290         <rdar://problem/15312643> Prepare for the mysterious future.
291
292         Reviewed by David Kilzer.
293
294         * DumpRenderTree/mac/Configurations/Base.xcconfig:
295         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
296         * MiniBrowser/Configurations/Base.xcconfig:
297         * MiniBrowser/Configurations/DebugRelease.xcconfig:
298         * TestWebKitAPI/Configurations/Base.xcconfig:
299         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
300         * WebKitLauncher/Configurations/Base.xcconfig:
301         * WebKitTestRunner/Configurations/Base.xcconfig:
302         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
303
304 2013-10-24  Daniel Bates  <dabates@apple.com>
305
306         Crash in WebCore::NavigationScheduler::startTimer()
307         https://bugs.webkit.org/show_bug.cgi?id=123288
308         <rdar://problem/14055644>
309
310         Reviewed by Alexey Proskuryakov.
311
312         Add API test.
313
314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
315         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
316         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
317
318 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
319
320         [GTK] Disable css-image-orientation
321         https://bugs.webkit.org/show_bug.cgi?id=123257
322
323         Reviewed by Martin Robinson.
324
325         CSS image orientation isn't stable yet. So, test regression happen since r157909.
326         This feature should be enabled again after it is stable.
327
328         * Scripts/webkitperl/FeatureList.pm:
329
330 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
331
332         Fix argument passing for jhbuild.
333         https://bugs.webkit.org/show_bug.cgi?id=123253
334
335         Reviewed by Gustavo Noronha Silva.
336
337         The update-webkit-libs-jhbuild previously didn't allowed
338         extra arguments to be passed to jhbuild.
339
340         * Scripts/update-webkit-libs-jhbuild:
341         (runJhbuild):
342         * Scripts/update-webkitefl-libs:
343
344 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
345
346         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
347         https://bugs.webkit.org/show_bug.cgi?id=123251
348
349         Reviewed by Csaba Osztrogonác.
350
351         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
352         compilation warning on 64-Bit.
353
354         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
355         (onExceededDatabaseQuota):
356
357 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
358
359         [EFL] Build break with latest EFL 1.8 libraries.
360         https://bugs.webkit.org/show_bug.cgi?id=123245
361
362         Reviewed by Gyuyoung Kim.
363
364         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
365         Eo typedef and splitted header files which contain version macro.
366
367         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
368         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
369         * WebKitTestRunner/PlatformWebView.h: Ditto.
370
371 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
372
373         [GObject bindings] Make EventTarget interface introspectable
374         https://bugs.webkit.org/show_bug.cgi?id=77835
375
376         Reviewed by Gustavo Noronha Silva.
377
378         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
379         GObject DOM bindings headers.
380
381 2013-10-23  Lucas Forschler  <lforschler@apple.com>
382
383         Add two more mac bots to the Mavericks Test Queue.
384         
385         Unreviewed.
386         
387         * BuildSlaveSupport/build.webkit.org-config/config.json:
388
389 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
390
391         Have a way of dealing with slow tests in run-jsc-stress-tests
392         https://bugs.webkit.org/show_bug.cgi?id=123221
393
394         Reviewed by Mark Hahnenberg.
395         
396         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
397         rather than appended to it. This means that slow tests get queued up first and are less likely
398         to block completion.
399
400         * Scripts/run-jsc-stress-tests:
401
402 2013-10-23  Alex Christensen  <achristensen@webkit.org>
403
404         Explicitly build Win32 or x64 configuration on Windows.
405         https://bugs.webkit.org/show_bug.cgi?id=123206
406
407         Reviewed by Brent Fulgham.
408
409         * Scripts/webkitdirs.pm:
410         (jscPath):
411         (determineConfigurationForVisualStudio):
412         (determinePassedConfiguration):
413         Add |Win32 to the end of 32-bit Visual Studio build configurations.
414         (safariPath):
415         * Scripts/build-webkit:
416         * Scripts/old-run-webkit-tests:
417         * Scripts/run-api-tests:
418         (testToolPath):
419         * Scripts/run-javascriptcore-tests:
420         (testapiPath):
421         * Scripts/run-regexp-tests:
422         (testapiPath):
423         * Scripts/sunspider-compare-results:
424         (pathToBuiltJSC):
425         Use configuration instead of configurationForVisualStudio, which are now always different.
426
427 2013-10-23  Mark Lam  <mark.lam@apple.com>
428
429         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
430         https://bugs.webkit.org/show_bug.cgi?id=123131.
431
432         Reviewed by Geoffrey Garen.
433
434         Updated these files to allow database quotas to grow within a limit for
435         testing purposes.
436
437         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
438         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
439         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
440         (onExceededDatabaseQuota):
441         * DumpRenderTree/mac/UIDelegate.mm:
442         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
443         * DumpRenderTree/win/UIDelegate.cpp:
444         (UIDelegate::exceededDatabaseQuota):
445         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
446         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
447         * WebKitTestRunner/TestController.cpp:
448         (WTR::exceededDatabaseQuota):
449
450 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
451
452         It's valid to have a build ID of 0.
453
454         Reviewed by Tim Hatcher.
455
456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
457         (BuildbotIteration):
458
459 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
460
461         Remove Lion bots from the Dashboard.
462
463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
464         (WebKitBuildbot):
465
466 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
467
468         [GTK] Expose image links properly
469         https://bugs.webkit.org/show_bug.cgi?id=84044
470
471         Reviewed by Chris Fleizach.
472
473         Expose the accessible URL if present, as yet another attribute
474         for the AccessibilityUIElement wrapper. For coherence with what
475         the Mac port does (and what you would expect as the output of
476         the layout test), we strip the absolute URL path for relative
477         references, if it's the case, leaving the base of the URL path
478         out of the exposed string.
479
480         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
481         (attributesOfElement): Print the AXURL, if available.
482         (AccessibilityUIElement::url): Expose the URL if present. That
483         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
484         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
485         (attributesOfElement): Print the AXURL, if available.
486         (WTR::AccessibilityUIElement::url): Expose the URL if present.
487         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
488
489 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
490
491         Remove Lion bots.
492
493         * BuildSlaveSupport/build.webkit.org-config/config.json:
494
495 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
496
497         Dashboard repaints constantly
498         https://bugs.webkit.org/show_bug.cgi?id=122133
499
500         Reviewed by Tim Horton.
501         
502         Pulsing shadows are really bad for battery life.
503
504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
505         (.status-line.bad .bubble):
506         (.status-line.bad .message):
507
508 2013-10-22  Commit Queue  <commit-queue@webkit.org>
509
510         Unreviewed, rolling out r157835.
511         http://trac.webkit.org/changeset/157835
512         https://bugs.webkit.org/show_bug.cgi?id=123192
513
514         broke 32-bit builds (Requested by smfr on #webkit).
515
516         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
517         (TestWebKitAPI::TEST):
518
519 2013-10-22  Jer Noble  <jer.noble@apple.com>
520
521         [WTF] Add a multiplication operator (and a few others) to MediaTime
522         https://bugs.webkit.org/show_bug.cgi?id=123137
523
524         Reviewed by Eric Carlson.
525
526         Add tests for new MediaTime operators.
527
528         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
529         (TestWebKitAPI::TEST):
530
531 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
532
533         Educate webkitpy about Mavericks.
534
535         Reviewed by Ryosuke Niwa.
536
537         * Scripts/webkitpy/common/system/platforminfo.py:
538         (PlatformInfo._determine_mac_version):
539         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
540         (TestPlatformInfo.test_os_version):
541         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
542         (TestExpectationParser):
543         * Scripts/webkitpy/port/builders.py:
544         * Scripts/webkitpy/port/mac.py:
545         (MacPort):
546         * Scripts/webkitpy/port/mac_unittest.py:
547         (test_versions):
548         (test_baseline_search_path):
549         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
550         (TestRebaselineTest.test_baseline_directory):
551         (TestRebaselineExpectations.test_rebaseline_expectations):
552
553 2013-10-22  Stephanie Lewis  <slewis@apple.com>
554
555         Update the build trigger list for Mavericks.
556
557         Unreviewed.
558
559         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
560         (_should_file_trigger_build):
561
562 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
563
564         Add Mavericks bots to the dashboard.
565
566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
567         (WebKitBuildbot):
568
569 2013-10-22  Samuel White  <samuel_white@apple.com>
570
571         AX: Add paramAttrs to fetch start and end text markers in a given rect.
572         https://bugs.webkit.org/show_bug.cgi?id=122164
573
574         Reviewed by Chris Fleizach.
575
576         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
577
578         * DumpRenderTree/AccessibilityUIElement.cpp:
579         (endTextMarkerForBoundsCallback):
580         (startTextMarkerForBoundsCallback):
581         (AccessibilityUIElement::endTextMarkerForBounds):
582         (AccessibilityUIElement::startTextMarkerForBounds):
583         (AccessibilityUIElement::getJSClass):
584         * DumpRenderTree/AccessibilityUIElement.h:
585         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
586         (AccessibilityUIElement::endTextMarkerForBounds):
587         (AccessibilityUIElement::startTextMarkerForBounds):
588         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
589         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
590         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
591         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
592         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
593         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
594         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
595         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
596         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
597         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
598         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
599
600 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
601
602         There should be a way to specify additional repository paths in NRWT
603         https://bugs.webkit.org/show_bug.cgi?id=123135
604
605         Reviewed by Alexey Proskuryakov.
606
607         Added --additional-repository-name and --additional-repository-path options to NRWT.
608         These options allow us to submit addtional repository information, such as of Safari's
609         to the new flakiness dashboard.
610
611         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
612         (parse_args):
613         * Scripts/webkitpy/port/base.py:
614         (Port.repository_paths):
615
616 2013-10-22  Commit Queue  <commit-queue@webkit.org>
617
618         Unreviewed, rolling out r157774.
619         http://trac.webkit.org/changeset/157774
620         https://bugs.webkit.org/show_bug.cgi?id=123167
621
622         causes python test to fail (Requested by smfr on #webkit).
623
624         * Scripts/webkitpy/layout_tests/controllers/manager.py:
625         (Manager.run):
626         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
627         (TestExpectations.__init__):
628         (TestExpectations._add_expectations):
629         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
630         (parse_args):
631         (_set_up_derived_options):
632
633 2013-10-22  Lucas Forschler  <lforschler@apple.com>
634
635         Prepare WebKit Buildbot master for Mavericks.
636         This adds the following bot configurations:
637             Mavericks Release/Debug builders
638             Mavericks Release/Debug WK1 Testers
639             Mavericks Release/Debug WK2 Testers
640
641         Unreviewed.
642         
643         * BuildSlaveSupport/build.webkit.org-config/config.json:
644
645 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
646
647         Run tests as if they are expected to pass when --force is given.
648         https://bugs.webkit.org/show_bug.cgi?id=112890
649
650         Reviewed by Ryosuke Niwa.
651
652         The --force switch of new-run-webkit-tests is now forces all tests to
653         be run with 'PASS' as expected result.
654
655         * Scripts/webkitpy/layout_tests/controllers/manager.py:
656         (Manager.run):
657         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
658         (TestExpectations.__init__):
659         (TestExpectations._add_expectations):
660         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
661         (parse_args):
662         (_set_up_derived_options):
663
664 2013-10-21  Mark Rowe  <mrowe@apple.com>
665
666         Add a version of WebKitSystemInterface for Mavericks.
667
668         Reviewed by Ryosuke Niwa.
669
670         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
671         * Scripts/copy-webkitlibraries-to-product-directory:
672         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
673
674 2013-10-21  Anders Carlsson  <andersca@apple.com>
675
676         Navigation policy callback not called when performing the same fragment navigation twice
677         https://bugs.webkit.org/show_bug.cgi?id=123121
678         <rdar://problem/15230466>
679
680         Reviewed by Beth Dakin.
681
682         Add a test.
683
684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
685         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
686         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
687         (+[WebKit1FragmentNavigationTestDelegate shared]):
688         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
689         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
690         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
691         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
692         (TestWebKitAPI::TEST):
693
694 2013-10-21  Dan Bernstein  <mitz@apple.com>
695
696         Style checker should allow a space after the @property keyword
697         https://bugs.webkit.org/show_bug.cgi?id=123117
698
699         Reviewed by Anders Carlsson.
700
701         * Scripts/webkitpy/style/checkers/cpp.py:
702         (check_spacing_for_function_call): Allow a space between @property and the following (
703         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
704         (CppStyleTest.test_spacing_for_fncall): Added a test case.
705
706 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
707
708         [WinCairo] Build does not start.
709         https://bugs.webkit.org/show_bug.cgi?id=123059
710
711         Reviewed by Csaba Osztrogonác.
712
713         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
714
715         * Scripts/build-webkit:
716
717 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
718
719         [Jhbuild] Bump the required Jhbuild revision
720         https://bugs.webkit.org/show_bug.cgi?id=123089
721
722         Reviewed by Carlos Garcia Campos.
723
724         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
725         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
726         in the Jhbuild source so a more recent revision of it should be used.
727
728 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
729
730         Mac build fix.
731
732         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
733
734 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
735
736         Enable webaudio/ tests on DRT/Mac
737         https://bugs.webkit.org/show_bug.cgi?id=86914
738
739         Reviewed by Darin Adler.
740
741         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
742         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
743         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
744         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
745
746         * DumpRenderTree/TestRunner.cpp:
747         (setAudioResultCallback): 
748         (TestRunner::staticFunctions):
749         * DumpRenderTree/TestRunner.h:
750         (TestRunner::audioResult):
751         (TestRunner::setAudioResult):
752         The function has a different name and argument type now, updated accordingly.
753         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
754
755         * DumpRenderTree/mac/DumpRenderTree.mm:
756         (dumpAudio): Updated for the new name of audioResult accessor.
757         (dump): Print the result in the format webkitpy currently expects.
758
759         * WebKitTestRunner/TestInvocation.cpp:
760         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
761         chunks made no sense.
762
763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
764         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
765
766         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
767         so that "SourceProvider.h" can be found.
768
769 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
770
771         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
772         https://bugs.webkit.org/show_bug.cgi?id=123070
773
774         Reviewed by Alexey Proskuryakov.
775
776         * Scripts/webkitpy/layout_tests/controllers/manager.py:
777         (Manager.run):
778         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
779         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
780         in the test expectations when this argument is set to true.
781
782 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
783
784         Mac DumpRenderTree builds without NDEBUG even in release mode
785         https://bugs.webkit.org/show_bug.cgi?id=123066
786
787         Reviewed by Dan Bernstein.
788
789         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
790         * DumpRenderTree/mac/Configurations/Base.xcconfig:
791         Use the same pattern as WebCore and WebKitTestRunner.
792
793 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
794
795         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
796         https://bugs.webkit.org/show_bug.cgi?id=123064
797
798         Reviewed by Ryosuke Niwa.
799
800         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
801
802         * Scripts/webkitpy/common/config/ports.py: Added.
803         (DeprecatedPort):
804         (DeprecatedPort.name):
805         (DeprecatedPort.flag):
806         (DeprecatedPort.script_path):
807         (DeprecatedPort.script_shell_command):
808         (DeprecatedPort.port):
809         (DeprecatedPort.makeArgs):
810         (DeprecatedPort.update_webkit_command):
811         (DeprecatedPort.check_webkit_style_command):
812         (DeprecatedPort.prepare_changelog_command):
813         (DeprecatedPort.build_webkit_command):
814         (DeprecatedPort.run_javascriptcore_tests_command):
815         (DeprecatedPort.run_webkit_unit_tests_command):
816         (DeprecatedPort.run_webkit_tests_command):
817         (DeprecatedPort.run_python_unittests_command):
818         (DeprecatedPort.run_perl_unittests_command):
819         (DeprecatedPort.run_bindings_tests_command):
820         (MacPort):
821         (MacWK2Port):
822         (MacWK2Port.run_webkit_tests_command):
823         (WinPort):
824         (WinPort.run_bindings_tests_command):
825         (GtkPort):
826         (GtkPort.build_webkit_command):
827         (GtkPort.run_webkit_tests_command):
828         (GtkWK2Port):
829         (GtkWK2Port.build_webkit_command):
830         (GtkWK2Port.run_webkit_tests_command):
831         (QtPort):
832         (QtPort.build_webkit_command):
833         (QtPort.run_webkit_tests_command):
834         (QtWK2Port):
835         (QtWK2Port.build_webkit_command):
836         (QtWK2Port.run_webkit_tests_command):
837         (EflPort):
838         (EflPort.build_webkit_command):
839         (EflWK2Port):
840         (EflWK2Port.build_webkit_command):
841         * Scripts/webkitpy/common/config/ports_mock.py: Added.
842         (MockPort):
843         (MockPort.name):
844         (MockPort.check_webkit_style_command):
845         (MockPort.update_webkit_command):
846         (MockPort.build_webkit_command):
847         (MockPort.prepare_changelog_command):
848         (MockPort.run_python_unittests_command):
849         (MockPort.run_perl_unittests_command):
850         (MockPort.run_javascriptcore_tests_command):
851         (MockPort.run_webkit_unit_tests_command):
852         (MockPort.run_webkit_tests_command):
853         (MockPort.run_bindings_tests_command):
854         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
855         (DeprecatedPortTest):
856         (DeprecatedPortTest.test_mac_port):
857         (DeprecatedPortTest.test_gtk_port):
858         (DeprecatedPortTest.test_gtk_wk2_port):
859         (DeprecatedPortTest.test_efl_port):
860         (DeprecatedPortTest.test_qt_port):
861         (DeprecatedPortTest.test_qt_wk2_port):
862         * Scripts/webkitpy/port/base.py:
863         (Port._port_flag_for_scripts):
864         (Port._wk2_port_name):
865         * Scripts/webkitpy/port/base_unittest.py:
866         (PortTest.test_build_path):
867         * Scripts/webkitpy/port/efl_unittest.py:
868         (EflPortTest.test_show_results_html_file):
869         * Scripts/webkitpy/port/gtk_unittest.py:
870         (GtkPortTest.test_get_crash_log):
871         * Scripts/webkitpy/port/mac_unittest.py:
872         (test_64bit):
873         * Scripts/webkitpy/port/test.py:
874         (TestPort.virtual_test_suites):
875         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
876         (FlakyTestReporter.__init__):
877         * Scripts/webkitpy/tool/bot/irc_command.py:
878         (Rollout._update_working_copy):
879         * Scripts/webkitpy/tool/commands/download_unittest.py:
880         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
881         (AbstractEarlyWarningSystem.run_command):
882         * Scripts/webkitpy/tool/commands/queues.py:
883         (PatchProcessingQueue.begin_work_queue):
884         (CommitQueue.run_command):
885         * Scripts/webkitpy/tool/main.py:
886         (WebKitPatch.__init__):
887         (WebKitPatch.deprecated_port):
888         (WebKitPatch.handle_global_options):
889         * Scripts/webkitpy/tool/mocktool.py:
890         (MockTool.__init__):
891         (MockTool.deprecated_port):
892         * Scripts/webkitpy/tool/steps/build.py:
893         (Build.build):
894         * Scripts/webkitpy/tool/steps/checkstyle.py:
895         (CheckStyle.run):
896         * Scripts/webkitpy/tool/steps/commit.py:
897         (Commit._check_test_expectations):
898         * Scripts/webkitpy/tool/steps/preparechangelog.py:
899         (PrepareChangeLog.run):
900         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
901         (PrepareChangeLogForRevert.run):
902         * Scripts/webkitpy/tool/steps/runtests.py:
903         (RunTests.run):
904         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
905         (RunTestsTest.test_webkit_run_unit_tests):
906         * Scripts/webkitpy/tool/steps/steps_unittest.py:
907         (StepsTest.test_runtests_args):
908         * Scripts/webkitpy/tool/steps/update.py:
909         (Update._update_command):
910         * Scripts/webkitpy/tool/steps/update_unittest.py:
911         (UpdateTest.test_update_command_non_interactive):
912         (UpdateTest.test_update_command_interactive):
913
914 2013-10-19  Andreas Kling  <akling@apple.com>
915
916         RefPtr::releaseNonNull() incorrectly increments the refcount.
917         <https://webkit.org/b/123063>
918
919         Add an API test to verify that no extra refs are added when calling
920         RefPtr::releaseNonNull().
921
922         Reviewed by Anders Carlsson.
923
924 2013-10-18  Rik Cabanier <cabanier@adobe.com>
925         Add Rik Cabanier to list of committers
926         https://bugs.webkit.org/show_bug.cgi?id=123031
927
928         reviewed by Dirk Schulze.
929
930         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
931
932 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
933
934         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
935         https://bugs.webkit.org/show_bug.cgi?id=122970
936
937         Reviewed by Mario Sanchez Prada.
938
939         Removed an invalid signal to set an object state to layout-complete
940         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
941
942         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
943         (axObjectEventListener): Replaced layout-complete with load-complete.
944         (connectAccessibilityCallbacks): Connect callback to new listener for
945         ATK:AtkDocument:load-complete.
946         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
947         for ATK:AtkDocument:load-complete.
948         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
949         (axObjectEventListener): Replaced layout-complete with load-complete.
950         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
951         Connect callback to new listener for ATK:AtkDocument:load-complete.
952         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
953         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
954
955 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
956
957         [GTK] Generate API documentation for GObject DOM bindings
958         https://bugs.webkit.org/show_bug.cgi?id=121538
959
960         Reviewed by Gustavo Noronha Silva.
961
962         The .symbols file that is now generated for checking GObject DOM
963         bindings API compatibility while building can also be used to
964         generate the files needed to produce the gtk-doc
965         documentation. The new script generate-webkitdom-doc-files can
966         generate the docs.sgml and sections.txt files from the given list
967         of .symbols files.
968
969         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
970         and webkitdomgtk-sections.txt as well as rules to install the
971         generated WebKitDOMGTK documentation.
972         * gtk/generate-gtkdoc:
973         (webkitdom_docs_html_path): New helper function that returns the
974         path where the DOM API documentation has been generated.
975         (get_webkit2_options): Include DOM API docs to the list of xref
976         dependencies.
977         (get_webkit1_options): Ditto.
978         (get_webkitdom_options): Return the gtk-doc options to generate
979         the DOM API docs.
980         (get_webkitdom_options.derived_sources_path):
981         (get_webkitdom_options.src_path):
982         * gtk/generate-webkitdom-doc-files: Added.
983         (WebKitDOMDocGenerator):
984         (WebKitDOMDocGenerator.write_header):
985         (WebKitDOMDocGenerator.write_section):
986         (WebKitDOMDocGenerator.write_footer):
987         (WebKitDOMDocGeneratorDocs):
988         (WebKitDOMDocGeneratorDocs.write_header):
989         (write_section):
990         (write_footer):
991         (WebKitDOMDocGeneratorSections):
992         (WebKitDOMDocGeneratorSections.__init__):
993         (WebKitDOMDocGeneratorSections._dom_class):
994         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
995         (WebKitDOMDocGeneratorSections._symbol_list):
996         (WebKitDOMDocGeneratorSections.write_section):
997
998 2013-10-17  Alex Christensen  <achristensen@webkit.org>
999
1000         Run JavaScriptCore tests again on Windows.
1001         https://bugs.webkit.org/show_bug.cgi?id=122787
1002
1003         Reviewed by Tim Horton.
1004
1005         * Scripts/build-jsc:
1006         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
1007         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
1008         * Scripts/webkitdirs.pm:
1009         (determineConfigurationForVisualStudio):
1010         (determineConfigurationProductDir):
1011         Build directory should end with bin64 and configuration should end with |x64 on Win64.
1012         (isAppleWinWebKit):
1013         (copyInspectorFrontendFiles):
1014         (setPathForRunningWebKitApp):
1015         Separated WinCairo directories and options from AppleWin.
1016
1017 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
1018
1019         Unreviewed. Add myself as a reviewer.
1020
1021         * Scripts/webkitpy/common/config/contributors.json:
1022
1023 2013-10-17  Andreas Kling  <akling@apple.com>
1024
1025         Make it possible to assign a PassRef to a RefPtr.
1026         <https://webkit.org/b/122943>
1027
1028         Added a small API test for RefPtr=(PassRef) so we know this code
1029         will compile (and work.)
1030
1031         Reviewed by Antti Koivisto.
1032
1033 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
1034
1035         We need test coverage for just the Baseline JIT
1036         https://bugs.webkit.org/show_bug.cgi?id=122929
1037
1038         Reviewed by Sam Weinig.
1039         
1040         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
1041         variant.
1042
1043         * Scripts/run-jsc-stress-tests:
1044
1045 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
1046
1047         Support multiple repositories in submitting results to --results-server-host
1048         https://bugs.webkit.org/show_bug.cgi?id=122935
1049
1050         Reviewed by Anders Carlsson.
1051
1052         Remoevd --got-revision and added the logic to extract revision information
1053         from multiple repositories as done in run-perf-tests.
1054
1055         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1056         (Manager.upload_results):
1057         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1058         (parse_args):
1059
1060 2013-10-16  Darin Adler  <darin@apple.com>
1061
1062         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
1063         https://bugs.webkit.org/show_bug.cgi?id=122904
1064
1065         Reviewed by Anders Carlsson.
1066
1067         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
1068
1069 2013-10-16  Darin Adler  <darin@apple.com>
1070
1071         Need tests for RefPtr self-assignment and self-move-assignment.
1072
1073         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
1074
1075 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
1076
1077         [EFL] Minibrowser can't load child window's location
1078         https://bugs.webkit.org/show_bug.cgi?id=122485
1079
1080         Reviewed by Gyuyoung Kim.
1081
1082         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
1083             followed by an explicit call to ewk_view_url_set() where appropriate.
1084         (on_key_down):
1085         (on_window_create):
1086         (window_create):
1087         (elm_main):
1088
1089 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
1090
1091         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
1092         https://bugs.webkit.org/show_bug.cgi?id=122872
1093
1094         Reviewed by Anders Carlsson.
1095
1096         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
1097         failing.
1098
1099 2013-10-15  Dean Jackson  <dino@apple.com>
1100
1101         Add ENABLE_WEB_ANIMATIONS flag
1102         https://bugs.webkit.org/show_bug.cgi?id=122871
1103
1104         Reviewed by Tim Horton.
1105
1106         Eventually might be http://dev.w3.org/fxtf/web-animations/
1107         but this is just engine-internal work at the moment.
1108
1109         * Scripts/webkitperl/FeatureList.pm:
1110
1111 2013-10-15  Darin Adler  <darin@apple.com>
1112
1113         Add some API tests for Vector, RefPtr, and Ref
1114         https://bugs.webkit.org/show_bug.cgi?id=122840
1115
1116         Reviewed by Andreas Kling.
1117
1118         * TestWebKitAPI/CMakeLists.txt: Added new files.
1119         * TestWebKitAPI/GNUmakefile.am: Ditto.
1120         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1121         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1123
1124         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
1125         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
1126         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
1127         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
1128
1129 2013-10-14  Roger Fong  <roger_fong@apple.com>
1130
1131         Adding myself to CC list for some components.
1132
1133         * Scripts/webkitpy/common/config/watchlist:
1134
1135 2013-10-13  Darin Adler  <darin@apple.com>
1136
1137         Deprecate or remove deleteAllValues functions; there are only a few call sites left
1138         https://bugs.webkit.org/show_bug.cgi?id=122738
1139
1140         Reviewed by Anders Carlsson.
1141
1142         * DumpRenderTree/win/DRTDataObject.cpp:
1143         (DRTDataObject::~DRTDataObject):
1144         * DumpRenderTree/win/UIDelegate.cpp:
1145         (DRTUndoStack::~DRTUndoStack):
1146         (DRTUndoStack::clear):
1147         Renamed deleteAllValues to deprecatedDeleteAllValues.
1148
1149         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
1150
1151 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
1152
1153         build.webkit.org/dashboard incorrectly shows interrupted builds as green
1154         https://bugs.webkit.org/show_bug.cgi?id=122732
1155
1156         Reviewed by Tim Hatcher.
1157
1158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1159         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
1160         I don't see it occur any time in recent history, but judging from what happens for
1161         status 5 (RETRY), we can just finish this function normally.
1162         Record overall text description for iteration as BuildbotIteration.text.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1165         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
1166         but no tests failed, make it yellow, and use buildbot-provided description for it.
1167
1168 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
1169
1170         Remove Chromium specific code from flakiness dashboard
1171         https://bugs.webkit.org/show_bug.cgi?id=122714
1172
1173         Reviewed by Sam Weinig.
1174
1175         Also removed code related to GPU tests and virtual suites.
1176         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
1177
1178         * TestResultServer/model/jsonresults_unittest.py:
1179         * TestResultServer/static-dashboards/builders.js:
1180         * TestResultServer/static-dashboards/dashboard_base.js:
1181         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1182         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1183         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
1184         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1185         * TestResultServer/static-dashboards/history.js:
1186         * TestResultServer/static-dashboards/loader.js:
1187         * TestResultServer/static-dashboards/ui.js:
1188         * TestResultServer/templates/uploadform.html:
1189
1190 2013-10-11  Timothy Hatcher  <timothy@apple.com>
1191
1192         Remove preference support for picking the old Web Inspector.
1193         https://bugs.webkit.org/show_bug.cgi?id=122655
1194
1195         Reviewed by Alexey Proskuryakov.
1196
1197         * WebKitTestRunner/TestController.cpp:
1198         (WTR::TestController::resetStateToConsistentValues):
1199
1200 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
1201
1202         Fix 64-bit build on everything but Windows.
1203
1204         Rubber stamped by Brent Fulgham.
1205
1206         * Scripts/webkitdirs.pm:
1207         (argumentsForConfiguration):
1208
1209 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1210
1211         Touch a file to see how auto-update works.
1212
1213         Rubber-stamped by Tim Hatcher.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1216
1217 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1218
1219         LeaksViewer fails to present recent results list if current build is still updating svn
1220         https://bugs.webkit.org/show_bug.cgi?id=122670
1221
1222         Fixed an obvious mistake in the previous patch.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1225         (RecentBuildsLoader.prototype.start):
1226
1227 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1228
1229         LeaksViewer fails to present recent results list if current build is still updating svn
1230         https://bugs.webkit.org/show_bug.cgi?id=122670
1231
1232         Reviewed by Adam Roben.
1233
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1235         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
1236
1237 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
1238
1239         Unreviewed build fix for --64-bit target.
1240
1241         * Scripts/webkitdirs.pm:
1242         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
1243         been removed by this point.
1244         (hasArgument): Remove unused temporary.
1245
1246 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1247
1248         webkit-patch failure-reason has a quite low limit for 'too many failures'
1249         https://bugs.webkit.org/show_bug.cgi?id=122556
1250
1251         Reviewed by Darin Adler.
1252
1253         * Scripts/webkitpy/tool/commands/queries.py:
1254         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
1255         to match what the layout test runners use these days.
1256
1257 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1258
1259         webkit-patch failure-reason should allow specifying failures one is interested in
1260         https://bugs.webkit.org/show_bug.cgi?id=122554
1261
1262         Reviewed by Darin Adler.
1263
1264         * Scripts/webkitpy/tool/commands/queries.py:
1265         (FailureReason):
1266         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
1267         loop if the ones we're interested in been explained.
1268         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
1269         (FailureReason.execute): initialize failures to explain and the explained set.
1270
1271 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1272
1273         Make sure that DataTypes.h is in the binary drop.
1274
1275         Rubber stamped by Michael Saboff.
1276
1277         * Scripts/export-llvm-build:
1278
1279 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1280
1281         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
1282         https://bugs.webkit.org/show_bug.cgi?id=122566
1283
1284         Reviewed by Mark Rowe.
1285
1286         * Scripts/configure-llvm:
1287
1288 2013-10-10  Mark Rowe  <mrowe@apple.com>
1289
1290         <rdar://problem/13341666> WebKit should always build against an SDK.
1291
1292         Have all projects default to building against the OS X Internal SDK for the Production
1293         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1294         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1295
1296         Reviewed by Dan Bernstein.
1297
1298         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1299         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1300         * MiniBrowser/Configurations/Base.xcconfig:
1301         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1302         * TestWebKitAPI/Configurations/Base.xcconfig:
1303         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1304         * WebKitTestRunner/Configurations/Base.xcconfig:
1305         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1306
1307 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
1308
1309         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
1310
1311         * Scripts/run-gtk-tests:
1312         (TestRunner): skip TestInspectorServer.
1313
1314 2013-10-10  Andres Gomez  <agomez@igalia.com>
1315
1316         [GTK] Provide search functionality to MiniBrowser
1317         https://bugs.webkit.org/show_bug.cgi?id=117631
1318
1319         Reviewed by Carlos Garcia Campos.
1320
1321         Adds a search bar to MiniBrowser with the minimum functionality
1322         and a new button to the toolbar for showing the new search
1323         bar. Typical keyboard shortcuts are also added.
1324
1325         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
1326         (doSearch):
1327         (searchNext):
1328         (searchPrevious):
1329         (searchCloseButtonClickedCallback):
1330         (searchEntryMenuIconPressedCallback):
1331         (searchEntryClearIconReleasedCallback):
1332         (searchEntryChangedCallback):
1333         (searchEntryActivatedCallback):
1334         (searchPrevButtonClickedCallback):
1335         (searchNextButtonClickedCallback):
1336         (searchMenuCheckButtonToggledCallback):
1337         (browser_search_bar_init):
1338         (browserSearchBarFinalize):
1339         (browser_search_bar_class_init):
1340         (browser_search_bar_new):
1341         (browser_search_bar_add_accelerators):
1342         (browser_search_bar_open):
1343         (browser_search_bar_close):
1344         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
1345         * MiniBrowser/gtk/BrowserWindow.c:
1346         (webViewEnterFullScreen): Closes new search bar.
1347         (webViewLeaveFullScreen): Opens new search bar if previously
1348         visible.
1349         (searchCallback): Added. Shows and hides the new search bar.
1350         (browser_window_init): Added search button to the toolbar.
1351         (browserWindowConstructed): Creates the new search bar.
1352         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
1353
1354 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1355
1356         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1357         https://bugs.webkit.org/show_bug.cgi?id=122552
1358
1359         Reviewed by Darin Adler.
1360
1361         * Scripts/webkitpy/common/checkout/commitinfo.py:
1362         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1363         will cause UnicodeDecodeError for non-ascii characters.
1364
1365 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1366
1367         Would like a link to dashboard from build.webkit.org main page
1368         https://bugs.webkit.org/show_bug.cgi?id=122577
1369
1370         Reviewed by Tim Hatcher.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1373
1374 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1375
1376         [Win] Check for MathML fonts and warn user if they are missing.
1377         https://bugs.webkit.org/show_bug.cgi?id=122568
1378
1379         Reviewed by Tim Horton.
1380
1381         * Scripts/webkitdirs.pm:
1382         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1383         Windows-specific code I added previously.
1384         (fontExists): Added
1385         (checkInstalledTools): Add check for MathML fonts.
1386
1387 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1388
1389         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1390         https://bugs.webkit.org/show_bug.cgi?id=122471
1391
1392         Reviewed by Tim Hatcher.
1393
1394         Added links to webkitpy, webkitperl and bindings-tests results.
1395
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1397         (Buildbot.prototype.apiTestResultsURLForIteration):
1398         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1399         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1400         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1402         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1403
1404 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1405
1406         Move some functions from WebKitBuildbot to Buildbot class.
1407
1408         Suggested by Tim Hatcher.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1411         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1412         (Buildbot.prototype.apiTestResultsURLForIteration):
1413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1414         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1415
1416 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1417
1418         Add API tests to the Dashbord page.
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=122283
1421
1422         Reviewed by Timothy Hatcher.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1425         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1427         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1428
1429 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1430
1431         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1432
1433         https://bugs.webkit.org/show_bug.cgi?id=122515
1434
1435         Reviewed by Alexey Proskuryakov.
1436
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1438         (BuildbotIteration.prototype.update):
1439
1440 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1441
1442         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1443         https://bugs.webkit.org/show_bug.cgi?id=122573
1444
1445         Reviewed by Tim Hatcher.
1446
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1448         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1449
1450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1451         (Buildbot.prototype.buildPageURLForIteration): Added.
1452
1453 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1454
1455         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1456         https://bugs.webkit.org/show_bug.cgi?id=122569
1457
1458         Reviewed by Tim Hatcher.
1459
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1461         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1462         to be produced by the old Mozilla test harness that we don't use any more.
1463
1464 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1465
1466         Add GTK 64 bits release to the buildbot dashboard
1467         https://bugs.webkit.org/show_bug.cgi?id=122548
1468
1469         Reviewed by Darin Adler.
1470
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1473         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1475         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1476
1477 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1478
1479         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1480         https://bugs.webkit.org/show_bug.cgi?id=120638
1481
1482         Reviewed by Gustavo Noronha Silva.
1483
1484         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1485         can check both the old and new APIs to retrieve text at a given offset.
1486
1487 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1488
1489         Improved WinLauncher.
1490         https://bugs.webkit.org/show_bug.cgi?id=122536
1491
1492         Reviewed by Brent Fulgham.
1493
1494         * WinLauncher/PrintWebUIDelegate.cpp:
1495         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1496         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1497         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1498         * WinLauncher/WinLauncher.cpp:
1499         (createCrashReport): Use the executable name instead of "WinLauncher".
1500         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1501         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1502         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1503
1504 2013-10-08  Mark Lam  <mark.lam@apple.com>
1505
1506         Fix ruby LoadError when running run-javascriptcore-tests.
1507         https://bugs.webkit.org/show_bug.cgi?id=122519.
1508
1509         Reviewed by Mark Hahnenberg.
1510
1511         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1512         (versions before 1.9).
1513
1514         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1515         * Scripts/run-jsc-stress-tests:
1516
1517 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1518
1519         Unreviewed, add my new email to contributors.json.
1520
1521         * Scripts/webkitpy/common/config/contributors.json:
1522
1523 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1524
1525         Unreviewed build correction.
1526
1527         * Scripts/webkitpy/port/win.py:
1528         (WinPort.write_registry_value): Use string representation of error message to avoid
1529         format conversion problem.
1530
1531 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1532
1533         [Win] Add checks for proper build and test environment
1534         https://bugs.webkit.org/show_bug.cgi?id=122466
1535
1536         Reviewed by Darin Adler.
1537
1538         This patch makes two changes:
1539         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1540            error messages so that people know what to fix to get things working.
1541         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1542            the various environment settings are properly configured for our test environment.
1543
1544         * Scripts/webkitdirs.pm:
1545         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1546         caused problems in the past.
1547         (setupAppleWinEnv):
1548         * Scripts/webkitpy/port/win.py:
1549         (WinPort):
1550         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1551         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1552         DWORD, etc.)
1553         (WinPort.write_registry_string): Revise to call new generic registry write function.
1554         (WinPort.setup_crash_log_saving): Revise for new API
1555         (WinPort.restore_crash_log_saving): Ditto
1556         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1557         servers from running.
1558         (WinPort.allow_error_dialogs): Ditto.
1559         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1560         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1561
1562 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1563
1564         [GStreamer] enable v4l2 plugin
1565         https://bugs.webkit.org/show_bug.cgi?id=122503
1566
1567         Reviewed by Martin Robinson.
1568
1569         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1570         we updated our GStreamer version to 1.0.8.
1571
1572 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1573
1574         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1575         https://bugs.webkit.org/show_bug.cgi?id=122104
1576
1577         Reviewed by Chris Fleizach.
1578
1579         Updated stringAttributeValue to double check that the exposure of
1580         aria-invalid as a state is consistent with its exposure as a text
1581         attribute as well, when it applies (implementations of AtkText).
1582
1583         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1584         (AccessibilityUIElement::stringAttributeValue): Add double check.
1585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1586         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1587
1588 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1589
1590         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1591         https://bugs.webkit.org/show_bug.cgi?id=122459
1592
1593         Reviewed by Darin Adler.
1594
1595         * Scripts/run-jsc-stress-tests:
1596
1597 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1598
1599         [buildbot] parse tests that are reported as crashed correctly for GTK+
1600         https://bugs.webkit.org/show_bug.cgi?id=122476
1601
1602         Reviewed by Martin Robinson.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1605         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1606         as a failure of the API tests.
1607
1608 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1609
1610         Unreviewed. Skipping API test that is causing the next one to crash,
1611         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1612
1613         * Scripts/run-gtk-tests:
1614         (TestRunner):
1615
1616 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1617
1618         [GTK] run-gtk-tests does not distinguish between failure and crashes
1619         https://bugs.webkit.org/show_bug.cgi?id=122135
1620
1621         Reviewed by Martin Robinson.
1622
1623         The GTK+ API test runner does not distinguish between failures and crashes. This change
1624         makes it do that, so it's easier for us to spot the more important/higher priority crash
1625         case.
1626
1627         * Scripts/run-gtk-tests:
1628         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1629         so we have more information on how the process ended.
1630         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1631         (TestRunner.run_tests): report crashes.
1632
1633 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1634
1635         [GTK] Missing packages for APT on install-dependencies
1636         https://bugs.webkit.org/show_bug.cgi?id=121555
1637
1638         Reviewed by Martin Robinson.
1639
1640         * gtk/install-dependencies: add packages that are needed for
1641         building WebKit itself and the jhbuild dependencies.
1642
1643 2013-10-07  Anders Carlsson  <andersca@apple.com>
1644
1645         Fix test failures.
1646
1647         * Scripts/webkitpy/port/base.py:
1648         (Port.to.start_helper):
1649         * Scripts/webkitpy/port/mock_drt.py:
1650         (MockDRTPort.start_helper):
1651
1652 2013-10-07  Anders Carlsson  <andersca@apple.com>
1653
1654         Always force discrete mode when running layout tests
1655         https://bugs.webkit.org/show_bug.cgi?id=122465
1656
1657         Reviewed by Tim Horton.
1658
1659         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1660         
1661         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1662         Link with IOKit.
1663
1664         * DumpRenderTree/mac/LayoutTestHelper.m:
1665         (installLayoutTestColorProfile):
1666         Check installColorProfile.
1667
1668         (restoreUserColorProfile):
1669         Check installColorProfile.
1670
1671         (lockDownDiscreteGraphics):
1672         New function to force discrete graphics.
1673
1674         (main):
1675         Add '--install-color-profile' option.
1676
1677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1678         (Manager._set_up_run):
1679         Always start the helper, but pass self._options.pixel_tests to it.
1680
1681         * Scripts/webkitpy/port/mac.py:
1682         (MacPort.start_helper):
1683         Pass --install-color-profile' to the helper if pixel_tests is true.
1684
1685 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1686
1687         Properly count binding test failures as failures.
1688
1689         Fix the total for multiple failures in different steps too by avoiding undefined.
1690
1691         https://bugs.webkit.org/show_bug.cgi?id=122232
1692
1693         Reviewed by Alexey Proskuryakov.
1694
1695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1696         (BuildbotTestResults):
1697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1698         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1699
1700 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1701
1702         [GTK] Fails to build with jhbuild with newer system glib
1703         https://bugs.webkit.org/show_bug.cgi?id=122132
1704
1705         Reviewed by Martin Robinson.
1706
1707         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1708         started relying on. glib is not a dependency that should change test results, and is provided in
1709         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1710         should not be an issue.
1711
1712         * gtk/jhbuild.modules:
1713
1714 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1715
1716         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1717         https://bugs.webkit.org/show_bug.cgi?id=122437
1718
1719         Reviewed by Antoine Quint.
1720
1721         * Scripts/run-jsc-stress-tests:
1722
1723 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1724
1725         Unreviewed, fix build on old Rubies.
1726
1727         * Scripts/run-jsc-stress-tests:
1728
1729 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1730
1731         Unified test infrastructure via the jsc shell
1732         https://bugs.webkit.org/show_bug.cgi?id=120696
1733
1734         Reviewed by Oliver Hunt.
1735         
1736         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1737         output (silent or noisy) and different styles of test failure (just bad exit code,
1738         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1739         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1740         running in run-jsc-stress-tests.
1741         
1742         Also removes all of the code paths that defended against not having shellwords. Just
1743         install the shellwords gem if you want to run tests.
1744         
1745         Also removes the non-parallel test running code. No reason for it to exist anymore.
1746         
1747         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1748         as part of this patch, and left three more as new bugzillas.
1749
1750         * Scripts/create-mozilla-js-test-list: Added.
1751         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1752         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1753         * Scripts/run-javascriptcore-tests:
1754         * Scripts/run-jsc-stress-tests:
1755
1756 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1757
1758         run-jsc-stress-tests should be less verbose
1759         https://bugs.webkit.org/show_bug.cgi?id=122397
1760
1761         Reviewed by Sam Weinig.
1762         
1763         It now just prints something like:
1764         
1765          965/1831 ....
1766         
1767         Where the first number is the number of tests that completed, the second number is the
1768         number of tests total, and the dots are the number of tests running right now - which is
1769         useful towards the end when you're waiting for the last slow tests to finish.
1770         
1771         It will also print out the output from failing tests and it will print a line for skipped
1772         tests (to annoy you into getting them into a shape where they can be unskipped). For
1773         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1774
1775         * Scripts/run-jsc-stress-tests:
1776
1777 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1778
1779         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1780         https://bugs.webkit.org/show_bug.cgi?id=122385
1781
1782         Reviewed by Sam Wieinig.
1783         
1784         Make tests run via YAML be able to do the parse-for-commands trick that allows
1785         us to skip tests and do other custom per-test stuff.
1786
1787         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1788         * Scripts/run-jsc-stress-tests:
1789
1790 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1791
1792         Unreviewed, fix tests on older Rubies.
1793
1794         * Scripts/run-jsc-stress-tests:
1795
1796 2013-10-05  Anders Carlsson  <andersca@apple.com>
1797
1798         Don't filter the weak symbols.
1799
1800         * Scripts/check-for-weak-vtables-and-externals:
1801
1802 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1803
1804         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1805         https://bugs.webkit.org/show_bug.cgi?id=122376
1806
1807         Reviewed by Mark Hahnenberg.
1808
1809         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1810         * Scripts/run-javascriptcore-tests:
1811         (printThingsFound):
1812         * Scripts/run-jsc-stress-tests:
1813
1814 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1815
1816         It should be even easier to run and debug a failing JSC stress test
1817         https://bugs.webkit.org/show_bug.cgi?id=122337
1818
1819         Reviewed by Oliver Hunt.
1820         
1821         If a test fails, you can now just say:
1822
1823         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1824
1825         and get the reproduction. You don't have to set any environment variables like before.
1826         Also if you want to debug the failing test you can now just say:
1827
1828         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1829
1830         Broadly, any arguments passed to the reproduction script are prepended to the command to
1831         run the test. This is sort of quirky and won't work for some tests (for example the
1832         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1833         them and that's good enough for now.
1834
1835         * Scripts/run-jsc-stress-tests:
1836
1837 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1838
1839         [Windows] Correct run-path when using 64-bit binaries.
1840
1841         Reviewed by David Kilzer.
1842
1843         * Scripts/webkitdirs.pm:
1844         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1845         directory. Otherwise use the existing 'bin32' directory.
1846
1847 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1848
1849         Teach webkitdirs.pm to honor the --64-bit flag
1850         https://bugs.webkit.org/show_bug.cgi?id=122357
1851
1852         Reviewed by David Kilzer.
1853
1854         * Scripts/webkitdirs.pm:
1855         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1856         by the user.
1857         (findMatchingArguments): Added.
1858         (hasArgument): Added.
1859         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1860         findMatchingArguments subroutine.
1861
1862 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1863
1864         Update svn-config for new Visual Studio extensions
1865         https://bugs.webkit.org/show_bug.cgi?id=122344
1866
1867         Reviewed by Brent Fulgham.
1868
1869         * svn-config: Add new Visual Studio extensions.
1870
1871 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1872
1873         Made WinLauncher have better error handling, crash reporting, and modifiability.
1874         https://bugs.webkit.org/show_bug.cgi?id=122319
1875
1876         Reviewed by Brent Fulgham.
1877
1878         * WinLauncher/WinLauncher.cpp:
1879         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1880         Don't display the numerous "Cancelled" messages that are obviously from the user.
1881         (createCrashReport): Added.
1882         (dllLauncherEntryPoint):
1883         Made main loop back into while loop and write a crash report if it crashes.
1884         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1885         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1886         Added WinLauncherReplace.h.
1887         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1888         Added linking to DbgHelp.lib.
1889         * WinLauncher/WinLauncherReplace.h:
1890         Added to make modifying WinLauncher behaviour and appearance easy.
1891         (processCrashDump): Added.
1892
1893 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1894
1895         remove dpranke from webkitpy watchlist
1896         https://bugs.webkit.org/show_bug.cgi?id=122331
1897
1898         Reviewed by Brent Fulgham.
1899
1900         * Scripts/webkitpy/common/config/watchlist:
1901
1902 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1903
1904         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1905         https://bugs.webkit.org/show_bug.cgi?id=122299
1906
1907         Reviewed by Beth Dakin.
1908
1909         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1910         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1911         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1912
1913 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1914
1915         Watchlist is broken after <http://trac.webkit.org/r156880>
1916
1917         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1918
1919 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1920
1921         Remove Qt features from build and test tools
1922         https://bugs.webkit.org/show_bug.cgi?id=122312
1923
1924         Reviewed by Anders Carlsson.
1925
1926         * Scripts/build-dumprendertree:
1927         * Scripts/build-jsc:
1928         * Scripts/build-webkit:
1929         * Scripts/build-webkittestrunner:
1930         * Scripts/old-run-webkit-tests:
1931         (openDumpTool):
1932         (buildPlatformResultHierarchy):
1933         (buildPlatformTestHierarchy):
1934         (readSkippedFiles):
1935         * Scripts/run-launcher:
1936         * Scripts/run-qtwebkit-tests: Removed.
1937         * Scripts/run-webkit-tests:
1938         (useNewRunWebKitTests):
1939         * Scripts/update-webkit:
1940         * Scripts/webkit-build-directory:
1941         * Scripts/webkitdirs.pm:
1942         (argumentsForConfiguration):
1943         (jscProductDir):
1944         (builtDylibPathForName):
1945         (isAppleWebKit):
1946         (launcherPath):
1947         (launcherName):
1948         (checkRequiredSystemConfig):
1949         (setupCygwinEnv):
1950         (copyInspectorFrontendFiles):
1951         (setPathForRunningWebKitApp):
1952         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1953         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1954         (BaselineOptimizerTest.test_mac_future):
1955         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1956         (BaselineOptimizerTest.test_common_directory_includes_root):
1957         (BaselineOptimizerTest.test_virtual_ports_filtered):
1958         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1959         (test_parse_reviewer_text):
1960         * Scripts/webkitpy/common/config/watchlist:
1961         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1962         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1963         * Scripts/webkitpy/port/base.py:
1964         (Port.__init__):
1965         (Port._port_flag_for_scripts):
1966         (Port._wk2_port_name):
1967         * Scripts/webkitpy/port/builders.py:
1968         * Scripts/webkitpy/port/factory.py:
1969         (platform_options):
1970         (PortFactory):
1971         (PortFactory._default_port):
1972         * Scripts/webkitpy/port/factory_unittest.py:
1973         (FactoryTest.test_gtk):
1974         * Scripts/webkitpy/port/qt.py: Removed.
1975         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1976         * Scripts/webkitpy/style/checker.py:
1977         * Scripts/webkitpy/style/checker_unittest.py:
1978         (GlobalVariablesTest.test_path_rules_specifier):
1979         * Scripts/webkitpy/style/checkers/cmake.py:
1980         (CMakeChecker):
1981         * Scripts/webkitpy/style/checkers/cpp.py:
1982         (_classify_include):
1983         (check_include_line):
1984         (check_identifier_name_in_declaration):
1985         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1986         (OrderOfIncludesTest.test_classify_include):
1987         (WebKitStyleTest.test_names):
1988         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1989         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1990         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1991         (TestRebaselineTest.test_baseline_directory):
1992         * Scripts/webkitpy/tool/main.py:
1993         (WebKitPatch):
1994
1995 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1996
1997         Unreviewed. Add myself to some watchlists.
1998
1999         * Scripts/webkitpy/common/config/watchlist:
2000
2001 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2002
2003         Remove Qt builders from the flakiness dashboard.
2004
2005         * TestResultServer/static-dashboards/builders.jsonp:
2006         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2007         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2008         * TestResultServer/static-dashboards/loader_unittests.js:
2009
2010 2013-10-03  Tim Horton  <timothy_horton@apple.com>
2011
2012         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
2013         https://bugs.webkit.org/show_bug.cgi?id=122299
2014
2015         Reviewed by Beth Dakin.
2016
2017         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2018         Disable threaded scrolling.
2019
2020         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2021         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2022         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
2023
2024 2013-10-03  Anders Carlsson  <andersca@apple.com>
2025
2026         Use numeric strings in the OS version dictionary
2027         https://bugs.webkit.org/show_bug.cgi?id=122300
2028
2029         Reviewed by Mark Rowe.
2030
2031         * Scripts/webkitpy/common/system/platforminfo.py:
2032         (PlatformInfo._determine_mac_version):
2033
2034 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
2035
2036         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
2037
2038         Rubber-stamped by Tim Horton.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2041         (LeaksViewer._displayURLPrompt):
2042
2043 2013-10-03  Dan Bernstein  <mitz@apple.com>
2044
2045         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
2046         https://bugs.webkit.org/show_bug.cgi?id=122260
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         For the API to work, the tests need to be compiled with a newer version of the LLVM
2051         compiler. Until the bots are updated to that version, disable the tests on 10.8.
2052
2053         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2054
2055 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
2056
2057         [ATK] Expose aria-invalid as a text attribute (not object attribute)
2058         https://bugs.webkit.org/show_bug.cgi?id=122015
2059
2060         Reviewed by Chris Fleizach.
2061
2062         Adapted DRT and WKTR to check the exposure of the aria-invalid
2063         attribute as a text attribute, instead of an object attribute.
2064
2065         Also, done some refactoring of the code to try to keep things
2066         simpler and more coherent, by defining new helper functions,
2067         simplifying code, moving static variables and functions into
2068         unnammed namespaces and so on, without altering the logic other
2069         than for checking the text attribute for aria-invalid.
2070
2071         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2072         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
2073         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
2074         Also, never return an empty string if not falling through any of
2075         the cases checked here, and return the original attribute instead.
2076         (atkAttributeValueToCoreAttributeValue): New helper function to
2077         match the attributes values returned by the ATK wrapper with the
2078         values expected by the layout tests. Moved the mappings for the
2079         values of AXSortDirection here as well.
2080         (getAttributeSet): New helper function to retrieve a list of
2081         attributes (an AtkAttributeSet) from an AtkObject using the right
2082         API depending on whether we want the object attributes or the text
2083         attributes (in case the object implements AtkText).
2084         (getAttributeSetValueForId): Simplified by using getAttributeSet
2085         and atkAttributeValueToCoreAttributeValue. Also, added a new
2086         parameter to indicater whether we are interested in object
2087         attributes or text attributes.
2088         (getAtkAttributeSetAsString): Ditto.
2089         (attributesOfElement): Updated to pass the new required parameter
2090         to getAtkAttributeSetAsString, indicating that we want the object
2091         attributes in this case, for backwards compatibility.
2092         (indexRangeInTable): Moved up in the file into the unnammed namespace.
2093         (alterCurrentValue): Ditto.
2094         (AccessibilityUIElement::stringAttributeValue): After moving most
2095         of the code here to the new helper functions, simplified it by
2096         just checking whether the required attribute is provided as an
2097         object attribute or, if that's not the case, as a text attribute.
2098         (AccessibilityUIElement::isAttributeSupported): Ditto.
2099         (AccessibilityUIElement::intValue): Updated to pass the new
2100         required parameter to getAttributeSetValueForId, indicating that
2101         we want the object attributes in this case.
2102         (AccessibilityUIElement::hasPopup): Ditto.
2103
2104         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2105         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
2106         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
2107         (WTR::getAttributeSet): Ditto.
2108         (WTR::getAttributeSetValueForId): Ditto.
2109         (WTR::getAtkAttributeSetAsString): Ditto.
2110         (WTR::attributesOfElement): Ditto.
2111         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2112         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
2113         (WTR::AccessibilityUIElement::intValue): Ditto.
2114         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2115
2116 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
2117
2118         EWS build fix after the Qt EWS removal.
2119
2120         * QueueStatusServer/model/attachment.py:
2121         (Attachment._calculate_queue_positions):
2122
2123 2013-10-02  Anders Carlsson  <andersca@apple.com>
2124
2125         Remove Qt code from Tools/
2126         https://bugs.webkit.org/show_bug.cgi?id=122227
2127
2128         Reviewed by Andreas Kling.
2129
2130         * DumpRenderTree/WorkQueue.cpp:
2131         * DumpRenderTree/blackberry/src.pro: Removed.
2132         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
2133         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
2134         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
2135         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
2136         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
2137         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
2138         * DumpRenderTree/qt/EventSenderQt.h: Removed.
2139         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
2140         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
2141         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
2142         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
2143         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
2144         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
2145         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
2146         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
2147         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
2148         * DumpRenderTree/qt/resources/user.css: Removed.
2149         * DumpRenderTree/qt/testplugin.cpp: Removed.
2150         * DumpRenderTree/qt/testplugin.h: Removed.
2151         * ImageDiff/ImageDiff.pro: Removed.
2152         * ImageDiff/qt/ImageDiff.cpp: Removed.
2153         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
2154         * MiniBrowser/qt/BrowserWindow.h: Removed.
2155         * MiniBrowser/qt/MiniBrowser.pro: Removed.
2156         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
2157         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
2158         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
2159         * MiniBrowser/qt/UrlLoader.cpp: Removed.
2160         * MiniBrowser/qt/UrlLoader.h: Removed.
2161         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
2162         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
2163         * MiniBrowser/qt/icons/contents_width.png: Removed.
2164         * MiniBrowser/qt/icons/favicon.png: Removed.
2165         * MiniBrowser/qt/icons/find.png: Removed.
2166         * MiniBrowser/qt/icons/folder.png: Removed.
2167         * MiniBrowser/qt/icons/info.png: Removed.
2168         * MiniBrowser/qt/icons/next.png: Removed.
2169         * MiniBrowser/qt/icons/plus.png: Removed.
2170         * MiniBrowser/qt/icons/previous.png: Removed.
2171         * MiniBrowser/qt/icons/refresh.png: Removed.
2172         * MiniBrowser/qt/icons/stop.png: Removed.
2173         * MiniBrowser/qt/icons/titlebar.png: Removed.
2174         * MiniBrowser/qt/icons/touch.png: Removed.
2175         * MiniBrowser/qt/icons/touchpoint.png: Removed.
2176         * MiniBrowser/qt/icons/up.png: Removed.
2177         * MiniBrowser/qt/js/MultiSelect.js: Removed.
2178         * MiniBrowser/qt/main.cpp: Removed.
2179         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
2180         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
2181         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
2182         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
2183         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
2184         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
2185         * MiniBrowser/qt/qml/Dialog.qml: Removed.
2186         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
2187         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
2188         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
2189         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
2190         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
2191         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
2192         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
2193         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
2194         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
2195         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
2196         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
2197         * MiniBrowser/qt/raw/Target.pri: Removed.
2198         * MiniBrowser/qt/raw/View.cpp: Removed.
2199         * MiniBrowser/qt/raw/View.h: Removed.
2200         * MiniBrowser/qt/utils.cpp: Removed.
2201         * MiniBrowser/qt/utils.h: Removed.
2202         * QtTestBrowser/QtTestBrowser.pro: Removed.
2203         * QtTestBrowser/QtTestBrowser.qrc: Removed.
2204         * QtTestBrowser/cookiejar.cpp: Removed.
2205         * QtTestBrowser/cookiejar.h: Removed.
2206         * QtTestBrowser/favicon.png: Removed.
2207         * QtTestBrowser/fpstimer.cpp: Removed.
2208         * QtTestBrowser/fpstimer.h: Removed.
2209         * QtTestBrowser/launcherwindow.cpp: Removed.
2210         * QtTestBrowser/launcherwindow.h: Removed.
2211         * QtTestBrowser/locationedit.cpp: Removed.
2212         * QtTestBrowser/locationedit.h: Removed.
2213         * QtTestBrowser/mainwindow.cpp: Removed.
2214         * QtTestBrowser/mainwindow.h: Removed.
2215         * QtTestBrowser/qttestbrowser.cpp: Removed.
2216         * QtTestBrowser/urlloader.cpp: Removed.
2217         * QtTestBrowser/urlloader.h: Removed.
2218         * QtTestBrowser/useragentlist.txt: Removed.
2219         * QtTestBrowser/utils.cpp: Removed.
2220         * QtTestBrowser/utils.h: Removed.
2221         * QtTestBrowser/webinspector.h: Removed.
2222         * QtTestBrowser/webpage.cpp: Removed.
2223         * QtTestBrowser/webpage.h: Removed.
2224         * QtTestBrowser/webview.cpp: Removed.
2225         * QtTestBrowser/webview.h: Removed.
2226         * TestWebKitAPI/DerivedSources.pri: Removed.
2227         * TestWebKitAPI/InjectedBundle.pri: Removed.
2228         * TestWebKitAPI/PlatformWebView.h:
2229         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
2230         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
2231         * TestWebKitAPI/Tests.pri: Removed.
2232         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
2233         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2234         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
2235         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
2236         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
2237         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
2238         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
2239         * TestWebKitAPI/qt/main.cpp: Removed.
2240         * Tools.pro: Removed.
2241         * WebKitTestRunner/DerivedSources.pri: Removed.
2242         * WebKitTestRunner/EventSenderProxy.h:
2243         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
2244         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
2245         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2246         (WTR::InjectedBundlePage::resetAfterTest):
2247         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2248         (WTR::InjectedBundlePage::didClearWindowForFrame):
2249         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
2250         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2251         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
2252         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
2253         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
2254         * WebKitTestRunner/PlatformWebView.h:
2255         * WebKitTestRunner/Target.pri: Removed.
2256         * WebKitTestRunner/TestController.cpp:
2257         (WTR::TestController::resetStateToConsistentValues):
2258         * WebKitTestRunner/TestController.h:
2259         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
2260         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
2261         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
2262         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
2263         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
2264         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
2265         * WebKitTestRunner/qt/main.cpp: Removed.
2266         * WebKitTestRunner/qt/resources/user.css: Removed.
2267         * qmake/.qmake.cache: Removed.
2268         * qmake/.qmake.conf: Removed.
2269         * qmake/README: Removed.
2270         * qmake/config.tests/README: Removed.
2271         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
2272         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
2273         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2274         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2275         * qmake/config.tests/glx/glx.cpp: Removed.
2276         * qmake/config.tests/glx/glx.pro: Removed.
2277         * qmake/config.tests/gnuld/gnuld.pro: Removed.
2278         * qmake/config.tests/gnuld/main.cpp: Removed.
2279         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
2280         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
2281         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
2282         * qmake/config.tests/libXrender/libXrender.pro: Removed.
2283         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
2284         * qmake/config.tests/libwebp/libwebp.pro: Removed.
2285         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
2286         * qmake/config.tests/libxml2/libxml2.pro: Removed.
2287         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
2288         * qmake/config.tests/libxslt/libxslt.pro: Removed.
2289         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
2290         * qmake/config.tests/libzlib/libzlib.pro: Removed.
2291         * qmake/dump-features.pl: Removed.
2292         * qmake/mkspecs/features/configure.prf: Removed.
2293         * qmake/mkspecs/features/default_post.prf: Removed.
2294         * qmake/mkspecs/features/default_pre.prf: Removed.
2295         * qmake/mkspecs/features/features.prf: Removed.
2296         * qmake/mkspecs/features/features.pri: Removed.
2297         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
2298         * qmake/mkspecs/features/functions.prf: Removed.
2299         * qmake/mkspecs/features/gprof.prf: Removed.
2300         * qmake/mkspecs/features/mac/default_post.prf: Removed.
2301         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
2302         * qmake/mkspecs/features/minimal_qt.prf: Removed.
2303         * qmake/mkspecs/features/production_build.prf: Removed.
2304         * qmake/mkspecs/features/rpath.prf: Removed.
2305         * qmake/mkspecs/features/unix/default_post.prf: Removed.
2306         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
2307         * qmake/mkspecs/features/unix/icc.prf: Removed.
2308         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
2309         * qmake/mkspecs/features/valgrind.prf: Removed.
2310         * qmake/mkspecs/features/webkit_modules.prf: Removed.
2311         * qmake/mkspecs/features/win32/default_post.prf: Removed.
2312         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
2313         * qmake/mkspecs/modules/angle.prf: Removed.
2314         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
2315         * qmake/mkspecs/modules/webcore.prf: Removed.
2316         * qmake/mkspecs/modules/webkit1.prf: Removed.
2317         * qmake/mkspecs/modules/webkit2.prf: Removed.
2318         * qmake/mkspecs/modules/wtf.prf: Removed.
2319
2320 2013-10-02  Tim Horton  <timothy_horton@apple.com>
2321
2322         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
2323         https://bugs.webkit.org/show_bug.cgi?id=121859
2324         <rdar://problem/15069359>
2325
2326         Reviewed by Anders Carlsson.
2327
2328         * WebKitTestRunner/TestInvocation.cpp:
2329         (WTR::shouldUseThreadedScrolling):
2330         (WTR::updateThreadedScrollingForCurrentTest):
2331         (WTR::TestInvocation::invoke):
2332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2333         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
2334         (WTR::PlatformWebView::PlatformWebView):
2335         (WTR::PlatformWebView::viewSupportsOptions):
2336         Rename the tiled drawing switch to threaded scrolling, since that's really
2337         all it switches now that we use tiled drawing everywhere.
2338
2339         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
2340         and to more closely match the case we're interested in testing.
2341
2342 2013-10-02  Anders Carlsson  <andersca@apple.com>
2343
2344         Move AHEM____.TTF from qt/fonts/ to fonts/.
2345
2346         Rubber-stamped by Andreas Kling.
2347
2348         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2349         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2350
2351 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2352
2353         Remove Qt bots and EWS from trunk.
2354         https://bugs.webkit.org/show_bug.cgi?id=122210.
2355
2356         Reviewed by Allan Sandfeld Jensen.
2357
2358         Remove Qt buil dbots.
2359
2360         * BuildSlaveSupport/build.webkit.org-config/config.json:
2361         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2362         (appendCustomBuildFlags):
2363         (RunGtkAPITests.getText2):
2364         (Factory.__init__):
2365         (TestFactory.__init__):
2366         (BuildAndTestFactory.__init__):
2367         (loadBuilderConfig):
2368         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2369
2370 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2371
2372         Remove Qt bots and EWS from trunk.
2373         https://bugs.webkit.org/show_bug.cgi?id=122210.
2374
2375         Reviewed by Allan Sandfeld Jensen.
2376
2377         Remove Qt EWS bots.
2378
2379         * QueueStatusServer/config/queues.py:
2380         * Scripts/webkitpy/common/config/ews.json:
2381
2382 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2383
2384         Fix singular labels for test failures.
2385
2386         https://bugs.webkit.org/show_bug.cgi?id=122200
2387
2388         Reviewed by Joseph Pecoraro.
2389
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2391         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2392
2393 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2394
2395         Don't keep appending iterations each time the queue updates.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=122198
2398
2399         Reviewed by Joseph Pecoraro.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2402         (BuildbotQueue.prototype.update):
2403
2404 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2405
2406         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2407
2408         https://bugs.webkit.org/show_bug.cgi?id=122196
2409
2410         Reviewed by Brent Fulgham.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2413         (BuildbotIteration):
2414         (BuildbotIteration.prototype.update):
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2416         (BuildbotQueue.prototype.update):
2417         (BuildbotQueue.prototype.sortIterations):
2418
2419 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2420
2421         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2422
2423         Also fix some URLs to not have extras slashes and add a page title.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=122192
2426
2427         Reviewed by Joseph Pecoraro.
2428
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2430         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2432         (WebKitBuildbot.prototype.buildLogURLForIteration):
2433         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2434         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2436
2437 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2438
2439         [Mac] Set NSApplication current event while sending events directly to views
2440         https://bugs.webkit.org/show_bug.cgi?id=122179
2441
2442         Reviewed by Darin Adler.
2443
2444         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2445         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2446         use the current event.
2447
2448         * DumpRenderTree/mac/EventSendingController.mm:
2449         (-[EventSendingController mouseDown:withModifiers:]):
2450         (-[EventSendingController mouseUp:withModifiers:]):
2451         (-[EventSendingController mouseMoveToX:Y:]):
2452         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2453         (-[EventSendingController contextClick]):
2454         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2455         * WebKitTestRunner/mac/EventSenderProxy.mm:
2456         (WTR::EventSenderProxy::mouseDown):
2457         (WTR::EventSenderProxy::mouseUp):
2458         (WTR::EventSenderProxy::mouseMoveTo):
2459         (WTR::EventSenderProxy::keyDown):
2460         (WTR::EventSenderProxy::mouseScrollBy):
2461         Update the current event. We were already using the SPI in WebKit.
2462
2463 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2464
2465         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2466         https://bugs.webkit.org/show_bug.cgi?id=122183
2467
2468         Reviewed by Timothy Hatcher.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2471         (BuildbotIteration.prototype.update):
2472
2473 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2474
2475         Tweaks to the Buildbot Dashboard
2476
2477         https://bugs.webkit.org/show_bug.cgi?id=122169
2478
2479         Reviewed by Alexey Proskuryakov.
2480
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2482         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2484         (BuildbotQueueView.prototype.revisionLinksForIteration):
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2486         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2490         (WebKitBuildbot.prototype.buildLogURLForIteration):
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2492
2493 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2494
2495         Unreviewed, rolling out r156725.
2496         http://trac.webkit.org/changeset/156725
2497         https://bugs.webkit.org/show_bug.cgi?id=122176
2498
2499         broke all the mismatch tests again (Requested by thorton on
2500         #webkit).
2501
2502         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2503         (WTR::PlatformWebView::PlatformWebView):
2504
2505 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2506
2507         Implemented createWebViewWithRequest in WinLauncher.
2508         https://bugs.webkit.org/show_bug.cgi?id=122069
2509
2510         Reviewed by Brent Fulgham.
2511
2512         * WinLauncher/PrintWebUIDelegate.cpp:
2513         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2514         * WinLauncher/PrintWebUIDelegate.h:
2515         Removed createWebViewWithRequest stub.
2516
2517 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2518
2519         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2520         https://bugs.webkit.org/show_bug.cgi?id=122006
2521         <rdar://problem/15095197>
2522
2523         Reviewed by Dean Jackson.
2524
2525         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2526         (WTR::PlatformWebView::PlatformWebView):
2527         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2528         where the window server snapshot API returns blank snapshots.
2529
2530         Re-landing after r156724, this should not break everything now.
2531
2532 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2533
2534         [mac] 1x emulation on Retina hardware shouldn't use SPI
2535         https://bugs.webkit.org/show_bug.cgi?id=122152
2536         <rdar://problem/15119384>
2537
2538         Reviewed by Anders Carlsson.
2539
2540         * DumpRenderTree/mac/DumpRenderTree.mm:
2541         (createWebViewAndOffscreenWindow):
2542         (main):
2543         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2544         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2545         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2546         (WTR::PlatformWebView::PlatformWebView):
2547         * WebKitTestRunner/mac/main.mm:
2548         (main):
2549         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2550
2551 2013-09-30  Sam Weinig  <sam@webkit.org>
2552
2553         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2554         https://bugs.webkit.org/show_bug.cgi?id=116474
2555
2556         Reviewed by Ryosuke Niwa.
2557
2558         * Scripts/webkitpy/style/checkers/cpp.py:
2559         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2560
2561 2013-09-30  Sam Weinig  <sam@webkit.org>
2562
2563         Remove support for DOMFileSystem
2564         https://bugs.webkit.org/show_bug.cgi?id=122137
2565
2566         Reviewed by Anders Carlsson.
2567
2568         * Scripts/webkitperl/FeatureList.pm:
2569         * Scripts/webkitpy/style/checkers/cpp.py:
2570         (check_spacing):
2571         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2572         (CppStyleTest.test_spacing_for_binary_ops):
2573         * qmake/mkspecs/features/features.pri:
2574
2575 2013-09-30  Mark Rowe  <mrowe@apple.com>
2576
2577         More build fixage for builds with SDKs.
2578
2579         * WebKitTestRunner/Configurations/Base.xcconfig:
2580         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2581
2582 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2583
2584         Add initial version of a new Buildbot dashboard view.
2585
2586         https://bugs.webkit.org/show_bug.cgi?id=122131
2587
2588         Reviewed by Alexey Proskuryakov.
2589
2590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2622
2623 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2624
2625         Remove the code guarded by STYLE_SCOPED
2626         https://bugs.webkit.org/show_bug.cgi?id=122123
2627
2628         Reviewed by Anders Carlsson.
2629
2630         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2631         (resetDefaultsToConsistentValues):
2632         * Scripts/webkitperl/FeatureList.pm:
2633         * qmake/mkspecs/features/features.pri:
2634
2635 2013-09-30  Mark Rowe  <mrowe@apple.com>
2636
2637         Fix the build when building against an SDK.
2638
2639         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2640         the compiler command lines. It can't know to do this for the system framework search paths
2641         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2642
2643         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2644         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2645
2646 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2647
2648         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2649
2650         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2651         it to be double-freed.
2652
2653         * WinLauncher/WinLauncher.cpp:
2654         (EditProc): Be explicit about type passed to loadURL.
2655         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2656         that reallocating the BSTR is done with the knowledge of the smart pointer.
2657
2658 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2659
2660         [Qt] Fix force_static_libs_as_shared in WebKit2
2661         https://bugs.webkit.org/show_bug.cgi?id=121961
2662
2663         Reviewed by Csaba Osztrogonác.
2664
2665         Get rid of the unused WebKit2QML library
2666
2667         * qmake/mkspecs/features/webkit_modules.prf:
2668         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2669
2670 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2671
2672         [EFL] Fix incorrect click counting in EventSenderProxy
2673         https://bugs.webkit.org/show_bug.cgi?id=122098
2674
2675         Reviewed by Gyuyoung Kim.
2676
2677         Previously used two types of recording time, which conflicted with each other.
2678
2679         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2680         (WTR::EventSenderProxy::mouseUp):
2681
2682 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2683
2684         [webkitpy] Make the Xvfb screen depth overridable
2685         https://bugs.webkit.org/show_bug.cgi?id=122089
2686
2687         Reviewed by Gyuyoung Kim.
2688
2689         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2690         was set. The default value that's used if the variable wasn't set is 24.
2691
2692         * Scripts/webkitpy/port/xvfbdriver.py:
2693         (XvfbDriver._xvfb_screen_depth):
2694         (XvfbDriver._start):
2695         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2696         (XvfbDriverTest.make_driver):
2697         (XvfbDriverTest.test_start_no_pixel_tests):
2698         (XvfbDriverTest.test_start_pixel_tests):
2699         (XvfbDriverTest.test_start_arbitrary_worker_number):
2700         (XvfbDriverTest.test_next_free_display):
2701         (XvfbDriverTest.test_start_next_worker):
2702
2703 2013-09-29  Mark Rowe  <mrowe@apple.com>
2704
2705         Fix the Lion build.
2706
2707         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2708
2709         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2710         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2711
2712 2013-09-28  Mark Rowe  <mrowe@apple.com>
2713
2714         Fix some failures with newer versions of clang.
2715
2716         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2717         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2718         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2719         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2720         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2721
2722         Reviewed by Dan Bernstein.
2723
2724         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2725         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2726         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2727         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2728         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2729         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2730         * WebKitTestRunner/Configurations/Base.xcconfig:
2731         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2732         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2733         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2734         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2735
2736 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2737
2738         Unreviewed, rolling out r156569.
2739         http://trac.webkit.org/changeset/156569
2740         https://bugs.webkit.org/show_bug.cgi?id=122035
2741
2742         broke a lot of mismatch tests (Requested by thorton on
2743         #webkit).
2744
2745         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2746         (WTR::PlatformWebView::PlatformWebView):
2747
2748 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2749
2750         Don't retry failures on Apple MountainLion Release WK1 tester
2751         https://bugs.webkit.org/show_bug.cgi?id=122026
2752
2753         Reviewed by Mark Rowe.
2754
2755         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2756         on this bot.
2757
2758 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2759
2760         Don't hardcode builder specific configuration in buildbot master.cfg
2761         https://bugs.webkit.org/show_bug.cgi?id=122023
2762
2763         Reviewed by Mark Rowe.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2766         property to Qt Mountain Lion Release, making it run pixel tests.
2767
2768         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2769         (RunWebKitTests.start): Use additionalArguments.
2770         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2771
2772 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2773
2774         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2775         https://bugs.webkit.org/show_bug.cgi?id=122006
2776         <rdar://problem/15095197>
2777
2778         Reviewed by Dean Jackson.
2779
2780         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2781         (WTR::PlatformWebView::PlatformWebView):
2782         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2783         where the window server snapshot API returns blank snapshots.
2784
2785 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2786
2787         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2788         https://bugs.webkit.org/show_bug.cgi?id=106924
2789
2790         Reviewed by Chris Fleizach.
2791
2792         Consider headings levels as values to be returned in intValue()
2793         both in DRT and WKTR, so we can share more tests with other ports.
2794
2795         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2796         (AccessibilityUIElement::intValue): Consider headings too.
2797         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2798         (WTR::AccessibilityUIElement::intValue): Ditto.
2799
2800 2013-09-26  Darin Adler  <darin@apple.com>
2801
2802         rename KURL to URL
2803         https://bugs.webkit.org/show_bug.cgi?id=16214
2804
2805         Reviewed by Andreas Kling.
2806
2807         * many files: Renamed, using script.
2808
2809 2013-09-27  Darin Adler  <darin@apple.com>
2810
2811         Fix Python scripts test failures.
2812
2813         * Scripts/webkitpy/style/checkers/cpp.py:
2814         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2815         now, not by the checker itself.
2816
2817 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2818
2819         [GTK][WK2] Logging of accessibility events is not disabled between tests
2820         https://bugs.webkit.org/show_bug.cgi?id=121957
2821
2822         Reviewed by Mario Sanchez Prada.
2823
2824         Fixed an issue in AccessibilityNotificationHandler where the destructor
2825         was not disconnecting accessibility event callbacks if logging was on.
2826         The decision of disconnecting events can solely rely on the existence of
2827         notification handlers because logging uses the global notification
2828         handler.
2829
2830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2831         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2832         disconnection when logging is on.
2833
2834 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2835
2836         Add general CMakeLists.txt for DRT
2837         https://bugs.webkit.org/show_bug.cgi?id=119268
2838
2839         Reviewed by Gyuyoung Kim.
2840
2841         The new file allows better sharing between ports.
2842
2843         * CMakeLists.txt:
2844         * DumpRenderTree/CMakeLists.txt: Added.
2845         * DumpRenderTree/PlatformEfl.cmake: Added.
2846         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2847
2848 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2849
2850         [Qt] Fix force_static_libs_as_shared in WebKit2
2851         https://bugs.webkit.org/show_bug.cgi?id=121961
2852
2853         Reviewed by Csaba Osztrogonác.
2854
2855         Reenable force_static_libs_as_shared when building WebKit2.
2856
2857         * qmake/mkspecs/features/default_post.prf:
2858
2859 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2860
2861         [Qt] Mock implementations of positioning and orientation not used
2862         https://bugs.webkit.org/show_bug.cgi?id=121956
2863
2864         Reviewed by Csaba Osztrogonác.
2865
2866         Move production_build checks to sanitizeFeatures where its value is actually known.
2867
2868         * qmake/mkspecs/features/features.prf:
2869         * qmake/mkspecs/features/features.pri:
2870
2871 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2872
2873         [ATK] Normalize checks in entry points for DRT and WKTR
2874         https://bugs.webkit.org/show_bug.cgi?id=121959
2875
2876         Reviewed by Chris Fleizach.
2877
2878         Always check if we have a proper instance of AtkObject,
2879         implementing the interfaces that we might need for each case, at
2880         the entry point of every method of AccessibilityUIElement for ATK,
2881         and do those checks in an uniform way across DRT and WKTR, to
2882         avoid confusion and issues when modifying these files in the future.
2883
2884         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2885         (AccessibilityUIElement::getChildren): Use normalized checks.
2886         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2887         (AccessibilityUIElement::rowCount): Ditto.
2888         (AccessibilityUIElement::columnCount): Ditto.
2889         (AccessibilityUIElement::childrenCount): Ditto.
2890         (AccessibilityUIElement::elementAtPoint): Ditto.
2891         (AccessibilityUIElement::getChildAtIndex): Ditto.
2892         (AccessibilityUIElement::allAttributes): Ditto.
2893         (AccessibilityUIElement::titleUIElement): Ditto.
2894         (AccessibilityUIElement::parentElement): Ditto.
2895         (AccessibilityUIElement::attributesOfChildren): Ditto.
2896         (AccessibilityUIElement::role): Ditto.
2897         (AccessibilityUIElement::title): Ditto.
2898         (AccessibilityUIElement::description): Ditto.
2899         (AccessibilityUIElement::stringValue): Ditto.
2900         (AccessibilityUIElement::language): Ditto.
2901         (AccessibilityUIElement::x): Ditto.
2902         (AccessibilityUIElement::y): Ditto.
2903         (AccessibilityUIElement::width): Ditto.
2904         (AccessibilityUIElement::height): Ditto.
2905         (AccessibilityUIElement::orientation): Ditto.
2906         (AccessibilityUIElement::intValue): Ditto.
2907         (AccessibilityUIElement::minValue): Ditto.
2908         (AccessibilityUIElement::maxValue): Ditto.
2909         (indexRangeInTable): Ditto.
2910         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2911         (AccessibilityUIElement::stringAttributeValue): Ditto.
2912         (alterCurrentValue): Ditto.
2913         (AccessibilityUIElement::press): Ditto.
2914         (AccessibilityUIElement::documentEncoding): Ditto.
2915         (AccessibilityUIElement::documentURI): Ditto.
2916         (AccessibilityUIElement::hasPopup): Ditto.
2917
2918         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2919         (WTR::indexRangeInTable): Use normalized checks.
2920         (WTR::alterCurrentValue): Ditto.
2921         (WTR::AccessibilityUIElement::getChildren): Ditto.
2922         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2923         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2924         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2925         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2926         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2927         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2928         (WTR::AccessibilityUIElement::parentElement): Ditto.
2929         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2930         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2931         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2932         (WTR::AccessibilityUIElement::role): Ditto.
2933         (WTR::AccessibilityUIElement::title): Ditto.
2934         (WTR::AccessibilityUIElement::description): Ditto.
2935         (WTR::AccessibilityUIElement::orientation): Ditto.
2936         (WTR::AccessibilityUIElement::stringValue): Ditto.
2937         (WTR::AccessibilityUIElement::language): Ditto.
2938         (WTR::AccessibilityUIElement::x): Ditto.
2939         (WTR::AccessibilityUIElement::y): Ditto.
2940         (WTR::AccessibilityUIElement::width): Ditto.
2941         (WTR::AccessibilityUIElement::height): Ditto.
2942         (WTR::AccessibilityUIElement::intValue): Ditto.
2943         (WTR::AccessibilityUIElement::minValue): Ditto.
2944         (WTR::AccessibilityUIElement::maxValue): Ditto.
2945         (WTR::AccessibilityUIElement::rowCount): Ditto.
2946         (WTR::AccessibilityUIElement::columnCount): Ditto.
2947         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2948         (WTR::AccessibilityUIElement::press): Ditto.
2949         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2950         (WTR::AccessibilityUIElement::documentURI): Ditto.
2951         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2952
2953 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2954
2955         [ATK] accessibility/aria-sort.html is failing after r156409
2956         https://bugs.webkit.org/show_bug.cgi?id=121947
2957
2958         Reviewed by Chris Fleizach.
2959
2960         Implement AccessibilityUIElement::isSupported for the ATK
2961         platforms, just by checking whether we have an associated object
2962         attribute exposed for the wrapper object matching the required
2963         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2964
2965         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2966         (AccessibilityUIElement::isAttributeSupported): Implemented.
2967         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2968         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2969
2970 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2971
2972         [MediaStream] make MediaStream testable
2973         https://bugs.webkit.org/show_bug.cgi?id=121967
2974
2975         Reviewed by Dean Jackson.
2976
2977         * DumpRenderTree/mac/UIDelegate.mm:
2978         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2979             user media request policy delegate.
2980
2981 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2982
2983         build-webkit --inspector-frontend should copy WebInspectorUI files
2984         https://bugs.webkit.org/show_bug.cgi?id=117851
2985
2986         Reviewed by Joseph Pecoraro.
2987
2988         Change the --inspector-frontend build option to additionally build/copy 
2989         WebInspectorUI by setting it as the only project that needs to be built.
2990
2991         * Scripts/build-webkit:
2992
2993 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2994
2995         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2996         https://bugs.webkit.org/show_bug.cgi?id=121951
2997
2998         Reviewed by Carlos Garcia Campos.
2999
3000         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
3001         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
3002         500 layout tests that trigger accelerated compositing to be used.
3003
3004         * Scripts/webkitpy/port/xvfbdriver.py:
3005         (XvfbDriver._start):
3006         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
3007         (XvfbDriverTest.test_start_no_pixel_tests):
3008         (XvfbDriverTest.test_start_pixel_tests):
3009         (XvfbDriverTest.test_start_arbitrary_worker_number):
3010         (XvfbDriverTest.test_next_free_display):
3011         (XvfbDriverTest.test_start_next_worker):
3012
3013 2013-09-26  Tim Horton  <timothy_horton@apple.com>
3014
3015         Tiled drawing should not imply threaded scrolling
3016         https://bugs.webkit.org/show_bug.cgi?id=121874
3017         <rdar://problem/15071494>
3018
3019         Reviewed by Sam Weinig.
3020
3021         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3022         (WTR::PlatformWebView::PlatformWebView):
3023         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
3024
3025 2013-09-26  Commit Queue  <commit-queue@webkit.org>
3026
3027         Unreviewed, rolling out r156457.
3028         http://trac.webkit.org/changeset/156457
3029         https://bugs.webkit.org/show_bug.cgi?id=121960
3030
3031         Broke webkitpy tests. (Requested by kling on #webkit).
3032
3033         * Scripts/webkitpy/port/xvfbdriver.py:
3034         (XvfbDriver._start):
3035
3036 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
3037
3038         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
3039         https://bugs.webkit.org/show_bug.cgi?id=121951
3040
3041         Reviewed by Carlos Garcia Campos.
3042
3043         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
3044         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
3045         500 layout tests that trigger accelerated compositing to be used.
3046
3047         * Scripts/webkitpy/port/xvfbdriver.py:
3048         (XvfbDriver._start):
3049
3050 2013-09-25  Alex Christensen  <achristensen@webkit.org>
3051
3052         Removed check for Apple Application Support directory in WinCairo port.
3053         https://bugs.webkit.org/show_bug.cgi?id=121869
3054
3055         Reviewed by Brent Fulgham.
3056
3057         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3058         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3059         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3060         Use DLLLauncherWinCairo.props for WinCairo ports.
3061         * win/DLLLauncher/DLLLauncherMain.cpp:
3062         (wWinMain):
3063         Don't call modifyPath to check for AAS in the WinCairo port.
3064         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
3065
3066 2013-09-25  Alex Christensen  <achristensen@webkit.org>
3067
3068         Enabled AssembleBuildLogs on WinCairo port.
3069         https://bugs.webkit.org/show_bug.cgi?id=121923
3070
3071         Reviewed by Brent Fulgham.
3072
3073         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3074         Fixed reference to README, added WinCairo configurations.
3075         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
3076         Fixed reference to README.
3077         * win/AssembleBuildLogs/AssembleLogs.cmd:
3078         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
3079         * win/AssembleBuildLogs/README: Fixed spelling.
3080
3081 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
3082
3083         [WIN] Fix MSVC C4146 compiler warning
3084         https://bugs.webkit.org/show_bug.cgi?id=121838
3085
3086         Reviewed by Brent Fulgham.
3087
3088         Fix some variables from unsinged to int to fix the compiler warning
3089         "unary minus operator applied to unsigned type, result still unsigned".
3090
3091         * DumpRenderTree/WorkQueueItem.h:
3092         (BackItem::BackItem):
3093         (ForwardItem::ForwardItem):
3094         * DumpRenderTree/win/DumpRenderTree.cpp:
3095         (createWebViewAndOffscreenWindow):
3096
3097 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
3098
3099         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
3100         https://bugs.webkit.org/show_bug.cgi?id=121256
3101
3102         Reviewed by Martin Robinson.
3103
3104         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
3105         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/config.json:
3108
3109 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
3110
3111         Add style checker for CMake lists
3112         https://bugs.webkit.org/show_bug.cgi?id=121764
3113
3114         Reviewed by Ryosuke Niwa.
3115
3116         Add an additional check to make sure that list of files are sorted.
3117         Exclude lists of include directories for now, since the order
3118         can be importent for compilation of some files.
3119
3120         * Scripts/webkitpy/style/checkers/cmake.py:
3121         (CMakeChecker.check):
3122         (CMakeChecker._check_indent):
3123         (CMakeChecker):
3124         (CMakeChecker._check_list_order):
3125         (CMakeChecker._list_item_path):
3126         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3127         (CMakeCheckerTest.test_check):
3128
3129 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
3130
3131         CMakeChecker takes unusually long time to run
3132         https://bugs.webkit.org/show_bug.cgi?id=105662
3133
3134         Reviewed by Ryosuke Niwa.
3135
3136         Move the caching mechanism for regular expression of the C++ checker into
3137         a common file and use it for the CMake and ChangeLog checkers too.
3138
3139         * Scripts/webkitpy/style/checkers/changelog.py:
3140         (ChangeLogChecker.check_entry):
3141         * Scripts/webkitpy/style/checkers/cmake.py:
3142         (CMakeChecker._process_line):
3143         (CMakeChecker._check_no_space_cmds):
3144         (CMakeChecker._check_one_space_cmds):
3145         (CMakeChecker._check_non_lowercase_cmd):
3146         * Scripts/webkitpy/style/checkers/common.py:
3147         (match):
3148         (search):
3149         (searchIgnorecase):
3150         (sub):
3151         (subn):
3152         * Scripts/webkitpy/style/checkers/cpp.py:
3153
3154 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3155
3156         [Qt] Fix build with Qt 5.2 QtPosition module
3157         https://bugs.webkit.org/show_bug.cgi?id=121089
3158
3159         Reviewed by Simon Hausmann.
3160
3161         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
3162         that might depend on them.
3163
3164         * qmake/mkspecs/features/default_pre.prf:
3165         * qmake/mkspecs/features/features.prf:
3166
3167 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
3168
3169         [ATK] Fix style issues in AccessibilityUIElementAtk
3170         https://bugs.webkit.org/show_bug.cgi?id=121898
3171
3172         Reviewed by Chris Fleizach.
3173
3174         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
3175         instead of { 0, { { 0 } } } to initialize a GValue.
3176
3177         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3178         (AccessibilityUIElement::clickPointX): Remove suffix.
3179         (AccessibilityUIElement::clickPointY): Ditto.
3180         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
3181         (AccessibilityUIElement::minValue): Ditto.
3182         (AccessibilityUIElement::maxValue): Ditto.
3183         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
3184         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3185         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
3186         (WTR::AccessibilityUIElement::x): Ditto.
3187         (WTR::AccessibilityUIElement::y): Ditto.
3188         (WTR::AccessibilityUIElement::width): Ditto.
3189         (WTR::AccessibilityUIElement::height): Ditto.
3190         (WTR::AccessibilityUIElement::clickPointX): Ditto.
3191         (WTR::AccessibilityUIElement::clickPointY): Ditto.
3192         (WTR::AccessibilityUIElement::intValue): Ditto.
3193         (WTR::AccessibilityUIElement::minValue): Ditto.
3194         (WTR::AccessibilityUIElement::maxValue): Ditto.
3195
3196 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
3197
3198         [EFL] accessibility/loading-iframe-sends-notification.html is failing
3199         https://bugs.webkit.org/show_bug.cgi?id=112003
3200
3201         Reviewed by Mario Sanchez Prada.
3202
3203         Enabled addNotificationListener and removeNotificationListener for EFL port.
3204
3205         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3206         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3207         (WTR::AccessibilityController::removeNotificationListener):
3208
3209 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
3210
3211         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
3212         https://bugs.webkit.org/show_bug.cgi?id=121844
3213
3214         Reviewed by Mark Hahnenberg.
3215
3216         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
3217
3218 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
3219
3220         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
3221         https://bugs.webkit.org/show_bug.cgi?id=121854
3222
3223         Reviewed by Anders Carlsson.
3224
3225         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3226         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
3227         settings in underlying frameworks.
3228
3229 2013-09-24  Mark Rowe  <mrowe@apple.com>
3230
3231         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
3232
3233         Reviewed by Dan Bernstein.
3234
3235         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3236         * MiniBrowser/Configurations/Base.xcconfig:
3237         * TestWebKitAPI/Configurations/Base.xcconfig:
3238         * WebKitLauncher/Configurations/Base.xcconfig:
3239         * WebKitTestRunner/Configurations/Base.xcconfig:
3240
3241 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
3242
3243         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
3244         https://bugs.webkit.org/show_bug.cgi?id=121674
3245
3246         Reviewed by Mario Sanchez Prada.
3247
3248         Implemented the global notification listener for
3249         AccessibilityController. The signal is generated by
3250         AXObjectCache::postPlatformNotification() and received by
3251         axObjectEventListener(). axObjectEventListener will then invoke
3252         JSObjectCallAsFunction() with the respective callback function.
3253
3254         There is no additional test for this patch since its implementation will
3255         be tested by an accessibility layout test that is currently failing
3256         (accessibility/loading-iframe-sends-notification.html).
3257
3258         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
3259         stub implementations of addNotificationListener and
3260         removeNotificationListener for the GTK port.
3261         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3262         (WTR::AccessibilityController::addNotificationListener): Creates the
3263         notification handler and sets the notification function callback.
3264         (WTR::AccessibilityController::removeNotificationListener): Removes the
3265         global handler.
3266
3267 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
3268
3269         [GTK] fast/images/exif-orientation-composited.html is failing
3270         https://bugs.webkit.org/show_bug.cgi?id=119731
3271
3272         Reviewed by Carlos Garcia Campos.
3273
3274         Add handling respect image orientation property in DRT.
3275
3276         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3277         (TestRunner::overridePreference):
3278
3279 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
3280
3281         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
3282         https://bugs.webkit.org/show_bug.cgi?id=121787
3283
3284         Reviewed by Gustavo Noronha Silva.
3285
3286         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
3287         with the Wayland target enabled to version 3.10.0.
3288
3289 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
3290
3291         use NOMINMAX instead of #define min min
3292         https://bugs.webkit.org/show_bug.cgi?id=73563
3293
3294         Reviewed by Brent Fulgham.
3295
3296         Use NOMINMAX instead of #define min/max as a cleaner
3297         way of ensuring that Windows system header files don't
3298         define min/max as macro in the first place.
3299
3300         * DumpRenderTree/DumpRenderTreePrefix.h:
3301         * DumpRenderTree/cg/ImageDiffCG.cpp:
3302         * DumpRenderTree/config.h:
3303         * DumpRenderTree/win/ImageDiffCairo.cpp:
3304         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3305         * WebKitTestRunner/config.h:
3306
3307 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3308
3309         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3310         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3311
3312         Reviewed by Alexey Proskuryakov.
3313
3314         Previously, initalizing a WebPreference would change the cache model
3315         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3316         preference file on disk.
3317
3318         This patch fixes the tests by resetting the default, and using the proper
3319         default values after initializing WebPreference.
3320
3321         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3322         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3323         to the previous runs.
3324
3325         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3326         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
3327         cache model to the one required.
3328
3329         * TestWebKitAPI/ios/mainIOS.mm:
3330         (main): Reset the preferences before testing.
3331         * TestWebKitAPI/mac/mainMac.mm:
3332         (main): Ditto.
3333
3334 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3335
3336         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3337         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3338
3339         Reviewed by Alexey Proskuryakov.
3340
3341         Previously, initalizing a WebPreference would change the cache model
3342         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3343         preference file on disk.
3344
3345         This patch fixes the tests by resetting the default, and using the proper
3346         default values after initializing WebPreference.
3347
3348         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3349         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3350         to the previous runs.
3351
3352         * TestWebKitAPI/ios/mainIOS.mm:
3353         (main): Reset the preferences before testing.
3354         * TestWebKitAPI/mac/mainMac.mm:
3355         (main): Ditto.
3356
3357 2013-09-23  Anders Carlsson  <andersca@apple.com>
3358
3359         ListHashSet should work with move-only types
3360         https://bugs.webkit.org/show_bug.cgi?id=121802
3361
3362         Reviewed by Andreas Kling.
3363
3364         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3365         (TestWebKitAPI::TEST):
3366         Add a test for move-only types.
3367
3368 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3369
3370         Added --64-bit option for Windows build.
3371         https://bugs.webkit.org/show_bug.cgi?id=121799
3372
3373         Reviewed by Brent Fulgham.
3374
3375         * Scripts/webkitdirs.pm:
3376         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3377         (isWin64): Added.
3378         (determineIsWin64): Added.
3379
3380 2013-09-23  Anders Carlsson  <andersca@apple.com>
3381
3382         ListHashSet should use std::reverse_iterator for reverse iterators
3383         https://bugs.webkit.org/show_bug.cgi?id=121795
3384
3385         Reviewed by Antti Koivisto.
3386
3387         Add test for reverse iterators.
3388
3389         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3390         (TestWebKitAPI::TEST):
3391
3392 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3393
3394         [EFL] accessibility/aria-invalid is failing
3395         https://bugs.webkit.org/show_bug.cgi?id=111986
3396
3397         Reviewed by Mario Sanchez Prada.
3398
3399         Adds possibility to retrieve JS context.
3400         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3401         from 119883 and 120421.
3402
3403         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3404         (axObjectEventListener):
3405         (addAccessibilityNotificationHandler):
3406         (removeAccessibilityNotificationHandler):
3407         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3408         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3409         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3410
3411 2013-09-20  Mark Rowe  <mrowe@apple.com>
3412
3413         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3414
3415         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3416
3417         Reviewed by David Kilzer.
3418
3419         * Scripts/webkitdirs.pm:
3420         (checkRequiredSystemConfig):
3421
3422 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3423
3424         [ATK] Do not expose aria-help in ATK based platforms
3425         https://bugs.webkit.org/show_bug.cgi?id=121675
3426
3427         Reviewed by Chris Fleizach.
3428
3429         Remove the implementations for AccessibilityUIElement::helpText()
3430         from DRT and WKTR for GTK and EFL, since they are based on the
3431         AccessibilityObject::helpText() method and the 'aria-help'
3432         attributes, which is wrong since they should not depend on that
3433         but in ATK specific API (see also http://webkit.org/b/121684).
3434
3435         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3436         (AccessibilityUIElement::helpText): Added a new and empty
3437         implementation, now that we are no longer using this in ATK.
3438         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3439         as the only function provided here was helpText().
3440         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3441         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3442         removed from the list of sources to compile.
3443         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3444         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3445         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3446         based in DumpRenderTreeSupportGtk with an empty one.
3447
3448 2013-09-20  Dan Bernstein  <mitz@apple.com>
3449
3450         Make extract-localizable-strings available to WebCore clients
3451         https://bugs.webkit.org/show_bug.cgi?id=121699
3452
3453         Reviewed by Darin Adler.
3454
3455         * Scripts/extract-localizable-strings: Copied to
3456         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3457         executes the script from its new location. This is a temporary measure until certain code
3458         that is external to WebKit is adapted to the new location.
3459         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3460         from its new location.
3461
3462 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3463
3464         Nuke remaining VS2005 tools from the tree.
3465         https://bugs.webkit.org/show_bug.cgi?id=121691
3466
3467         Reviewed by Brent Fulgham.
3468
3469         * CLWrapper/CLWrapper.cpp: Removed.
3470         * CLWrapper/CLWrapper.sln: Removed.
3471         * CLWrapper/CLWrapper.vcproj: Removed.
3472         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3473         * MIDLWrapper/MIDLWrapper.sln: Removed.
3474         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3475         * Scripts/parallelcl: Removed.
3476         * vcbin/cl.exe: Removed.
3477         * vcbin/midl.exe: Removed.
3478
3479 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3480
3481         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3482         https://bugs.webkit.org/show_bug.cgi?id=121294
3483
3484         Reviewed by Martin Robinson.
3485
3486         Provide a new patch to deal with the issue in the GTK+ module from
3487         the internal jhbuild environment. This issue has been reported
3488         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3489
3490         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3491         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3492
3493 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3494
3495         [ATK][WTR] accessibility/aria-invalid.html times out
3496         https://bugs.webkit.org/show_bug.cgi?id=121668
3497
3498         Reviewed by Mario Sanchez Prada.
3499
3500         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3501         false in case of aria-invalid event with empty value.
3502
3503         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3504         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3505         case of aria-invalid event with empty value.
3506
3507 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3508
3509         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3510         https://bugs.webkit.org/show_bug.cgi?id=120421
3511
3512         Reviewed by Mario Sanchez Prada.
3513
3514         Implemented the notification listener for AccessibilityUIElement for
3515         WebKitTestRunner. The signal is generated by
3516         AXObjectCache::postPlatformNotification() and received by
3517         axObjectEventListener(). axObjectEventListener() will then invoke
3518         JSObjectCallAsFunction() with the respective callback function. The
3519         notification handlers are stored in HashMap in
3520         AccessibilityNotificationHandlerAtk.cpp.
3521
3522         Moved ATK signal handling (printAccessibilityEvent and
3523         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3524
3525         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3526         include path.
3527         * WebKitTestRunner/GNUmakefile.am:
3528         Added AccessibilityNotificationHandlerAtk.cpp/h.
3529         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3530         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3531         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3532         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3533         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3534         notification handler for GTK+ and EFL.
3535         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3536         Moved printAccessibilityEvent and axObjectEventListener to
3537         AccessibilityNotificationHandlerAtk.cpp.
3538         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3539         IDs to AccessibilityNotificationHandlerAtk.cpp.
3540         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3541         IDs to AccessibilityNotificationHandlerAtk.cpp.
3542         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3543         (WTR::printAccessibilityEvent): Prints accessibility events. This
3544         function was moved from AccessibilityControllerAtk.cpp.
3545         (WTR::axObjectEventListener): Callback for signals. This function was
3546         moved from AccessibilityControllerAtk.cpp.
3547         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3548         Initialize element and function callback.
3549         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3550         Removes handler from HashMap and disconnects callbacks if necessary.
3551         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3552         logging mode and connects callbacks.
3553         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3554         Sets the notification callback and connects callback to signals.
3555         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3556         Removes the notification callback from HashMap.
3557         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3558         Connects axObjectEventListener to ATK signals.
3559         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3560         Disconnects callback.
3561         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3562         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3563         of AccessibilityNotificationHandler.
3564         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3565         element.
3566         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3567         element.
3568         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3569         Gets the notification callback.
3570         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3571         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3572         notification handler, set the platform element and the notification
3573         callback.
3574         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3575         notification handler.
3576         * WebKitTestRunner/PlatformEfl.cmake:
3577         Added AccessibilityNotificationHandlerAtk.cpp.
3578
3579 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3580
3581         Update features.pri
3582         https://bugs.webkit.org/show_bug.cgi?id=121670
3583
3584         Reviewed by Jocelyn Turcotte.
3585
3586         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3587
3588         * qmake/mkspecs/features/features.pri:
3589
3590 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3591
3592         [GTK][WK2] accessibility/selection-states.html is failing
3593         https://bugs.webkit.org/show_bug.cgi?id=116972
3594
3595         Reviewed by Mario Sanchez Prada.
3596
3597         isSelectable() was not exposed in Accessibility.
3598
3599         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3600
3601 2013-09-19  Dan Bernstein  <mitz@apple.com>
3602
3603         Attempted build fix after r156114.
3604
3605         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3606
3607 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3608
3609         REGRESSION (r129451): run-safari --no-saved-state is broken
3610         https://bugs.webkit.org/show_bug.cgi?id=121566
3611
3612         Undo a last minute change that doesn't actually work.
3613
3614         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3615         via command line, <rdar://problem/15032886>.
3616
3617 2013-09-19  Dan Bernstein  <mitz@apple.com>
3618
3619         Add a style guideline regarding spacing in range-based for loops
3620         https://bugs.webkit.org/show_bug.cgi?id=121620
3621
3622         Reviewed by Anders Carlsson.
3623
3624         * Scripts/webkitpy/style/checkers/cpp.py:
3625         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3626         loop.
3627         (CppChecker): Added whitespace/colon to the categories set.
3628         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3629         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3630
3631 2013-09-18  Sam Weinig  <sam@webkit.org>
3632
3633         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3634         https://bugs.webkit.org/show_bug.cgi?id=121588
3635
3636         Reviewed by Anders Carlsson.
3637
3638         * DumpRenderTree/TestRunner.cpp:
3639         * ImageDiff/efl/ImageDiff.cpp:
3640         * TestWebKitAPI/JavaScriptTest.cpp:
3641         * TestWebKitAPI/PlatformUtilities.cpp:
3642         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3643         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: