abc3e469b357bf5fdf41c015e82bb579603c1c26
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
2
3         Dashboard bubbles sometimes show failure count instead of crash count
4         https://bugs.webkit.org/show_bug.cgi?id=175157
5         <rdar://problem/33709009>
6
7         Reviewed by Alexey Proskuryakov.
8
9         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
10         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
11
12 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
13
14         Add tests for NeverDestroyed
15         https://bugs.webkit.org/show_bug.cgi?id=175146
16
17         Reviewed by Darin Adler.
18
19         * CMakeLists.txt:
20         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21         New files and sort.
22
23         * TestWebKitAPI/Tests/WTF/Logger.h:
24         * TestWebKitAPI/Tests/WTF/Logger.cpp:
25         (TestWebKitAPI::log):
26         (TestWebKitAPI::takeLogStr):
27         * TestWebKitAPI/Tests/WTF/RefLogger.h:
28         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
29         (TestWebKitAPI::log): Deleted.
30         (TestWebKitAPI::takeLogStr): Deleted.
31         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
32
33         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
34         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
35         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
36         (TestWebKitAPI::LifecycleLogger::operator=):
37         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
38         (TestWebKitAPI::LifecycleLogger::setName):
39         (TestWebKitAPI::TEST):
40         Add a class that logs construction / assignment / modifications.
41
42         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
43         (TestWebKitAPI::TEST):
44         (TestWebKitAPI::list):
45         Test construction behavior is as expected both directly and using makeNeverDestroyed.
46
47 2017-08-04  Lucas Forschler  <lforschler@apple.com>
48
49         minification logic is not implemented for ios builds
50         <rdar://problem/33726561>
51
52         Reviewed by Dean Johnson
53
54         * BuildSlaveSupport/built-product-archive:
55         (minifyDirectory): refactor minifySource -> minifyDirectory
56         (archiveBuiltProduct): add ios minification logic
57         (minifySource): Deleted.
58
59 2017-08-04  Matt Lewis  <jlewis3@apple.com>
60
61         Unreviewed, rolling out r220271.
62
63         Rolling out due to Layout Test failing on iOS Simulator.
64
65         Reverted changeset:
66
67         "Remove STREAMS_API compilation guard"
68         https://bugs.webkit.org/show_bug.cgi?id=175165
69         http://trac.webkit.org/changeset/220271
70
71 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
72
73         Unreviewed, rolling out r220268.
74
75         This change caused assertion failures on macOS and iOS Debug
76         WK2.
77
78         Reverted changeset:
79
80         "Resource Load Statistics: Report user interaction
81         immediately, but only when needed"
82         https://bugs.webkit.org/show_bug.cgi?id=175090
83         http://trac.webkit.org/changeset/220268
84
85 2017-08-04  Youenn Fablet  <youenn@apple.com>
86
87         Remove STREAMS_API compilation guard
88         https://bugs.webkit.org/show_bug.cgi?id=175165
89
90         Reviewed by Darin Adler.
91
92         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
93
94 2017-08-04  John Wilander  <wilander@apple.com>
95
96         Resource Load Statistics: Report user interaction immediately, but only when needed
97         https://bugs.webkit.org/show_bug.cgi?id=175090
98         <rdar://problem/33685546>
99
100         Reviewed by Chris Dumez.
101
102         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
103         (WTR::InjectedBundle::beginTesting):
104             Now calls WebCore::ResourceLoadObserver::clearState().
105
106 2017-08-03  Brian Burg  <bburg@apple.com>
107
108         Remove ENABLE(WEB_SOCKET) guards
109         https://bugs.webkit.org/show_bug.cgi?id=167044
110
111         Reviewed by Joseph Pecoraro.
112
113         * Scripts/webkitperl/FeatureList.pm:
114         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
115
116 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
117
118         REGRESSION(r219850): run-benchmark script broken on Linux
119         https://bugs.webkit.org/show_bug.cgi?id=175126
120
121         Reviewed by Stephanie Lewis.
122
123         The run-benchmark script dynamically generates the list of supported
124         browsers and platforms (currently Linux and OSX) by loading all
125         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
126         and getting the browser_name and platform variables from the
127         classes defined there.
128
129         This means that this classes should not raise an exception when
130         loaded on other platforms or otherwise they will broke the whole
131         script. Its fine if they raise an exception when executing any of
132         the methods they implement, but not when just loading/importing
133         the class.
134
135         Move the argument variable definitions that call on the platform
136         specific OSXBrowserDriver._screen_size() function from beeing
137         variables that are evaluated when loading the file, to be functions
138         that are only evaluated when the actual functionality needs to be
139         executed.
140
141         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
142         (OSXChromeDriver.launch_url):
143         (OSXChromeCanaryDriver.launch_url):
144         (create_args):
145         (create_chrome_options):
146         (create_window_size_arg):
147         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
148         (OSXFirefoxDriver.launch_url):
149         (OSXFirefoxNightlyDriver.launch_url):
150         (OSXFirefoxNightlyDriver.launch_driver):
151         (create_args):
152
153 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
154
155         [PAL] Move spi/cf directory into PAL
156         https://bugs.webkit.org/show_bug.cgi?id=175057
157
158         Reviewed by Antti Koivisto.
159
160         * Scripts/webkitpy/style/checker.py:
161         * Scripts/webkitpy/style/checker_unittest.py:
162         (GlobalVariablesTest.test_path_rules_specifier):
163
164         Ignore "readability/naming/underscores" style errors for sources
165         under the WebCore/PAL/pal/spi directory.
166
167         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
168
169 2017-08-03  Youenn Fablet  <youenn@apple.com>
170
171         Remove FETCH_API compilation guard
172         https://bugs.webkit.org/show_bug.cgi?id=175154
173
174         Reviewed by Chris Dumez.
175
176         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
177
178 2017-08-03  Lucas Forschler  <lforschler@apple.com>
179
180         Enable archive minification on iOS builds
181         https://bugs.webkit.org/show_bug.cgi?id=174718
182         
183         Reviewed by Aakash Jain.
184
185         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
186         (BuildFactory.__init__):
187
188 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
189
190         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
191         https://bugs.webkit.org/show_bug.cgi?id=175140
192
193         Reviewed by Alexey Proskuryakov.
194
195         We are having lately issues with JSC tests causing problems on
196         the GTK+ and WPE bots due to the high amount of memory some tests
197         need to run.
198
199         The best thing we can do now is to workaround this by disabling
200         all the tests marked as memoryLimited on the GTK and WPE bots.
201         We may revise this on the future.
202
203         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
204         (RunJavaScriptCoreTests.start):
205
206 2017-08-03  Brady Eidson  <beidson@apple.com>
207
208         Add SW IDLs and stub out basic functionality.
209         https://bugs.webkit.org/show_bug.cgi?id=175115
210
211         Reviewed by Chris Dumez.
212
213         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
214
215         * Scripts/webkitpy/bindings/main.py:
216
217 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
218
219         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
220         https://bugs.webkit.org/show_bug.cgi?id=159510
221
222         Reviewed by Daniel Bates.
223
224         Allow any https certificate when running tests.
225
226         * DumpRenderTree/win/DumpRenderTree.cpp:
227         (runTest):
228
229 2017-08-02  Youenn Fablet  <youenn@apple.com>
230
231         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
232         https://bugs.webkit.org/show_bug.cgi?id=175089
233
234         Reviewed by Chris Dumez.
235
236         * DumpRenderTree/TestOptions.mm:
237         (TestOptions::TestOptions): Using absolutePath if available.
238         * DumpRenderTree/mac/DumpRenderTree.mm:
239         (computeTestURL): Removing http/tests/ specific URL computation.
240         * Scripts/webkitpy/port/driver.py:
241         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
242
243 2017-08-02  Lucas Forschler  <lforschler@apple.com>
244
245         download-built-product should allow for a proxy option
246         https://bugs.webkit.org/show_bug.cgi?id=174875
247
248         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
249
250         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
251         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
252         
253
254 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
255
256         check-webkit-style: deleting lines in a file runs the linter on the whole file
257         https://bugs.webkit.org/show_bug.cgi?id=175078
258
259         Reviewed by David Kilzer.
260
261         Deleting lines in a file should not cause linter errors to be blamed on the patch.
262         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
263
264         * Scripts/webkitpy/style/checkers/test_expectations.py:
265         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
266         * Scripts/webkitpy/style/main_unittest.py:
267         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
268         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
269         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
270
271 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
272
273         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
274         https://bugs.webkit.org/show_bug.cgi?id=175075
275
276         Reviewed by David Kilzer.
277
278         We have no way of handling text files with illegal unicode characters. Allow the callers of
279         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
280         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
281
282         * Scripts/webkitpy/common/system/filesystem.py:
283         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
284         (FileSystem.write_text_file): Ditto.
285         * Scripts/webkitpy/common/system/filesystem_mock.py:
286         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
287         (MockFileSystem.write_text_file): Ditto.
288         * Scripts/webkitpy/common/system/filesystem_unittest.py:
289         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
290         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
291
292 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
293
294         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
295         https://bugs.webkit.org/show_bug.cgi?id=175072
296
297         Reviewed by Alexey Proskuryakov.
298
299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
300         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
301
302 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
303
304         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
305         https://bugs.webkit.org/show_bug.cgi?id=175019
306
307         Reviewed by Darin Adler.
308
309         * TestWebKitAPI/CMakeLists.txt:
310
311 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
312
313         Enabling uploading archives to S3
314         https://bugs.webkit.org/show_bug.cgi?id=174198
315
316         Unreviewed unit test fix after r219235.
317
318         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
319
320 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
321
322         Fix JSCOnly ARM buildbots after r220047
323         https://bugs.webkit.org/show_bug.cgi?id=174993
324
325         Unreviewed fix after r220087.
326
327         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
328         (BuildAndRemoteJSCTestsFactory.__init__):
329
330 2017-08-01  Chris Dumez  <cdumez@apple.com>
331
332         Add initial support for navigator.sendBeacon
333         https://bugs.webkit.org/show_bug.cgi?id=175007
334         <rdar://problem/33547728>
335
336         Reviewed by Sam Weinig.
337
338         Enable the Beacon API at runtime in the context of layout tests since the
339         feature is currently disabled by default.
340
341         * DumpRenderTree/mac/DumpRenderTree.mm:
342         (enableExperimentalFeatures):
343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
344         (WTR::InjectedBundle::beginTesting):
345         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
346         (WTR::TestRunner::setModernMediaControlsEnabled):
347         (WTR::TestRunner::setBeaconAPIEnabled):
348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
349
350 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
351
352         Update Bot Watcher's Dashboard for Buildbot 0.9
353         https://bugs.webkit.org/show_bug.cgi?id=174777
354
355         Reviewed by Daniel Bates.
356
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
358         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
359         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
360         in a dictionary.
361         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
362         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
364         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
365         (parseRevisionProperty): Ditto.
366         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
367         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
368         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
369         have changed in Buildbot 0.9.
370         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
371         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
372         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
373         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
374         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
375         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
376         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
377         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
378         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
379         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
381         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
382         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
383         (BuildbotQueue.prototype.get overviewURL): Ditto.
384         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
385         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
386         Buildbot 0.8 or 0.9.
387         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
388         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
389         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
390         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
391         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
392         Therefore we are fetching information for fixed number of build. 
393         Also iterating the loop incrementally since the build data is already reverse sorted.
394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
395         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
396         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
398         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
399
400 2017-08-01  Devin Rousso  <drousso@apple.com>
401
402         Web Inspector: simplify WebInspector with WI
403         https://bugs.webkit.org/show_bug.cgi?id=175058
404
405         Reviewed by Joseph Pecoraro.
406
407         * Scripts/check-inspector-strings:
408         (extract_ui_strings):
409         * Scripts/extract-localizable-js-strings:
410
411 2017-08-01  Youenn Fablet  <youenn@apple.com>
412
413         Layout tests with 'https' suffix should be run over HTTPS
414         https://bugs.webkit.org/show_bug.cgi?id=174992
415
416         Reviewed by Chris Dumez.
417
418         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
419         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
420         Covered by corresponding unit tests.
421
422         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
423         (run_server):
424         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
425         (base_http_url):
426         (base_https_url):
427         (base_url): Deleted.
428         * Scripts/webkitpy/port/base.py:
429         (Port.to.web_platform_test_server_base_http_url):
430         (Port.to):
431         (Port.to.web_platform_test_server_base_https_url):
432         (Port.to.web_platform_test_server_base_url): Deleted.
433         * Scripts/webkitpy/port/driver.py:
434         (Driver.__init__):
435         (Driver.wpt_test_path_to_uri):
436         (Driver):
437         (Driver.http_test_path_to_uri):
438         (Driver.test_to_uri):
439         (Driver.uri_to_test):
440         * Scripts/webkitpy/port/driver_unittest.py:
441         (DriverTest.test_test_to_uri):
442         (DriverTest.test_uri_to_test):
443
444 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
445
446         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
447         https://bugs.webkit.org/show_bug.cgi?id=173998
448
449         Reviewed by Darin Adler.
450
451         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
452         detect mistakes in backward compatibility in the future when we change it.
453
454         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
455         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
456         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
457         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
458         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
459         internal key data slot.
460
461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
462         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
463         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
464         (getNextMessage):
465         (TEST):
466         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
467         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
468         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
469         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
470         These are the pre-baked databases.
471         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
472         This is the actual test that do all the reads and comparisons.
473         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
474         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
475         IndexedDB new stuffs. Then it can be used to bake the database again.
476
477 2017-08-01  Brady Eidson  <beidson@apple.com>
478
479         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
480         https://bugs.webkit.org/show_bug.cgi?id=175030
481
482         Reviewed by Andy Estes.
483
484         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
485         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
486
487 2017-08-01  Brady Eidson  <beidson@apple.com>
488
489         Part 2 of: Rename DatabaseProcess to StorageProcess.
490         https://bugs.webkit.org/show_bug.cgi?id=174880
491
492         Reviewed by Andy Estes.
493
494         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
495         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
496         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
497         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
498         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
499         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
500         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
501         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
502
503 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
504
505         Fix JSCOnly ARM buildbots after r220047
506         https://bugs.webkit.org/show_bug.cgi?id=174993
507
508         Reviewed by Saam Barati.
509
510         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
511         (BuildAndRemoteJSCTestsFactory.__init__):
512
513 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
514
515         [WTF] Introduce Private Symbols
516         https://bugs.webkit.org/show_bug.cgi?id=174935
517
518         Reviewed by Darin Adler.
519
520         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
521         (TestWebKitAPI::TEST):
522
523 2017-07-30  Darin Adler  <darin@apple.com>
524
525         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
526         https://bugs.webkit.org/show_bug.cgi?id=130653
527
528         Reviewed by Antti Koivisto.
529
530         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
531         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
532         when calling frameDidChangeLocation.
533         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
534         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
535         thus causing mysterious failures of a couple of tests. There are two remaining issues:
536         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
537         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
538         same logic flaw that causes "top loading frame" to get set to one of the subframes in
539         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
540         loading, subframe starts loading. It would be good to clean that up some day, but for now
541         this patch makes the two work identically rather than changing both.
542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
543
544 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
545
546         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
547         https://bugs.webkit.org/show_bug.cgi?id=174963
548
549         Reviewed by Darin Adler.
550
551         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
552         RetainPtr<>. This patch changes them to all use auto.
553
554         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
555         (TestWebKitAPI::TEST):
556
557 2017-07-30  Brady Eidson  <beidson@apple.com>
558
559         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
560         https://bugs.webkit.org/show_bug.cgi?id=174958
561
562         Reviewed by Darin Adler.
563
564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
565         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
566         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
567         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
568         (runUntilTasksInFlight):
569         (TEST):
570
571 2017-07-28  Commit Queue  <commit-queue@webkit.org>
572
573         Unreviewed, rolling out r219990.
574         https://bugs.webkit.org/show_bug.cgi?id=174961
575
576         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
577         estes on #webkit).
578
579         Reverted changeset:
580
581         "Part 2 of: Rename DatabaseProcess to StorageProcess."
582         https://bugs.webkit.org/show_bug.cgi?id=174880
583         http://trac.webkit.org/changeset/219990
584
585 2017-07-28  Brady Eidson  <beidson@apple.com>
586
587         API tests that use URLSchemeHandler are failing.
588         https://bugs.webkit.org/show_bug.cgi?id=174950
589
590         Reviewed by Alex Christensen.
591
592         Fix the NoMIMEType test to be correct.
593
594         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
595         (-[SchemeHandler initWithData:mimeType:]):
596         (-[SchemeHandler webView:startURLSchemeTask:]):
597         (TEST):
598
599 2017-07-28  Daniel Bates  <dabates@apple.com>
600
601         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
602         https://bugs.webkit.org/show_bug.cgi?id=174876
603
604         Reviewed by Alex Christensen.
605
606         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
607         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
608         they provide a more direct way to test the platform abstraction.
609
610         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
611
612         * Scripts/prepare-ChangeLog:
613         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
614         of the current working directory.
615
616 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
617
618         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
619         https://bugs.webkit.org/show_bug.cgi?id=174930
620
621         Unreviewed test fix.
622
623         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
624
625         * Scripts/prepare-ChangeLog:
626         (get_function_line_ranges_for_cpp):
627
628 2017-07-28  JF Bastien  <jfbastien@apple.com>
629
630         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
631         https://bugs.webkit.org/show_bug.cgi?id=174930
632
633         Reviewed by Daniel Bates.
634
635         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
636         here also teach it about const and volatile overloads. I didn't do
637         reference and rvalue reference overloads because we don't really
638         use them, and the current parser throws away those characters and
639         it doesn't seem worth making it more complex.
640
641         * Scripts/prepare-ChangeLog:
642         (get_function_line_ranges_for_cpp):
643         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
644         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
645         (Foo::Arrow::arrow):
646         (Foo::Arrow::otherArrow):
647         (Foo::Arrow::otherArrow const):
648         (Foo::Arrow::otherArrow volatile):
649         (Foo::Arrow::otherArrow const volatile):
650
651 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
652
653         [GTK] Building with ENABLE_VIDEO=OFF fails
654         https://bugs.webkit.org/show_bug.cgi?id=174940
655
656         Reviewed by Alex Christensen.
657
658         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
659         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
660
661         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
662         (methodCallCallback): Add missing USE(GSTREAMER) guard.
663
664 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
665
666         [WPE] Implement EventSenderProxy in WTR
667         https://bugs.webkit.org/show_bug.cgi?id=173419
668
669         Reviewed by Žan Doberšek.
670
671         Add the implementation of EventSenderProxy to the WTR. This
672         allows us to extend the coverage of the test suite in WKWPE.
673
674         * WebKitTestRunner/EventSenderProxy.h:
675         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
676         libxkbcommon needed to deal with key events.
677         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
678         (WTR::EventSenderProxy::EventSenderProxy):
679         (WTR::senderButtonToWPEButton):
680         (WTR::EventSenderProxy::mouseDown):
681         (WTR::EventSenderProxy::mouseUp):
682         (WTR::EventSenderProxy::mouseMoveTo):
683         (WTR::EventSenderProxy::mouseScrollBy):
684         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
685         (WTR::EventSenderProxy::leapForward):
686         (WTR::wkEventModifiersToWPE):
687         (WTR::getXKBKeySymForKeyRef):
688         (WTR::EventSenderProxy::keyDown):
689         (WTR::EventSenderProxy::addTouchPoint):
690         (WTR::EventSenderProxy::updateTouchPoint):
691         (WTR::EventSenderProxy::setTouchModifier):
692         (WTR::EventSenderProxy::setTouchPointRadius):
693         (WTR::EventSenderProxy::getUpdatedTouchEvents):
694         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
695         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
696         (WTR::EventSenderProxy::touchStart):
697         (WTR::EventSenderProxy::touchMove):
698         (WTR::EventSenderProxy::touchEnd):
699         (WTR::EventSenderProxy::touchCancel):
700         (WTR::EventSenderProxy::clearTouchPoints):
701         (WTR::EventSenderProxy::releaseTouchPoint):
702         (WTR::EventSenderProxy::cancelTouchPoint):
703
704 2017-07-27  Brady Eidson  <beidson@apple.com>
705
706         Part 2 of: Rename DatabaseProcess to StorageProcess.
707         https://bugs.webkit.org/show_bug.cgi?id=174880
708
709         Reviewed by Andy Estes.
710
711         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
712         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
713         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
714         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
715         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
716         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
717         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
718         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
719
720 2017-07-26  Mark Lam  <mark.lam@apple.com>
721
722         Add ability to only run specific tests in run-javascriptcore-tests.
723         https://bugs.webkit.org/show_bug.cgi?id=174884
724
725         Reviewed by Saam Barati.
726
727         For example, if we only want to run testapi, we can do so as follows:
728             $ run-javascriptcore-tests --testapi
729
730         Previously, specifying --testapi effectively does nothing because we run all tests
731         by default.  Only --no-testapi had the effect of disabling the test set.  This
732         old behavior for --testapi is not very useful or meaningful.  We're now changing
733         it to mean that we will only run that test.
734
735         With this change, we can also run more than one set of tests.  For example, if we
736         only want to run testmasm and testair, we can do so as follows:
737             $ run-javascriptcore-tests --testmasm --testair
738
739         By default, if no specific test option is specified, run-javascriptcore-tests will
740         run all tests.
741
742         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
743         the mozilla tests (--mozilla-tests) even though both are run via the lower level
744         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
745         the other set will not run.  For example, the following only runs the mozilla tests:
746             $ run-javascriptcore-tests --mozilla-tests
747
748         Note also that --jit-stress-tests is not for choosing a different set of tests.
749         Instead, it is used for determining whether we run JIT'ed test configurations
750         on the jsc stress tests and mozilla tests.  As a result, specifying
751         --jit-stress-tests will not omit other tests.  For example, the following still
752         runs all tests:
753             $ run-javascriptcore-tests --jit-stress-tests
754
755         * Scripts/run-javascriptcore-tests:
756         (defaultStringForTestState):
757         (enableTestOrNot):
758         (runJSCStressTests):
759
760 2017-07-26  Mark Lam  <mark.lam@apple.com>
761
762         Make run-javascriptcore-test run testair, testb3, and testmasm.
763         https://bugs.webkit.org/show_bug.cgi?id=174837
764         <rdar://problem/33522927>
765
766         Reviewed by Saam Barati and Filip Pizlo.
767
768         1. Refactors code for running testapi so that we can use it to run other tests.
769         2. Added running of testmasm, testair, testb3.
770
771         Note: the existing testapi invocation code does not support remote invocation of
772         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
773         and testb3 also do not support remote invocation.  If we wish to add remote
774         invocation support, we should do that in a separate patch.
775
776         * Scripts/run-javascriptcore-tests:
777         (testPath):
778         (runTest):
779         (testapiPath): Deleted.
780
781 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
782
783         Remove duplicate code from Buildbot.js in dashboard
784         https://bugs.webkit.org/show_bug.cgi?id=174870
785
786         Reviewed by Daniel Bates.
787
788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
789         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
790         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
792         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
793
794 2017-07-26  Brady Eidson  <beidson@apple.com>
795
796         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
797         https://bugs.webkit.org/show_bug.cgi?id=174851
798
799         Reviewed by Chris Dumez.
800
801         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
802         (TEST):
803
804 2017-07-26  Brian Burg  <bburg@apple.com>
805
806         Remove WEB_TIMING feature flag
807         https://bugs.webkit.org/show_bug.cgi?id=174795
808
809         Reviewed by Alex Christensen.
810
811         * Scripts/webkitperl/FeatureList.pm:
812         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
813
814 2017-07-26  Chris Dumez  <cdumez@apple.com>
815
816         Pressing the Escape key should not be a valid user gesture to enter fullscreen
817         https://bugs.webkit.org/show_bug.cgi?id=174864
818         <rdar://problem/33009088>
819
820         Reviewed by Geoffrey Garen.
821
822         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
823         WKTR.
824
825         * DumpRenderTree/mac/EventSendingController.mm:
826         (-[EventSendingController keyDown:withModifiers:withLocation:]):
827
828 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
829
830         Unreviewed, added Romain Bellessort to contributors.json.
831
832         * Scripts/webkitpy/common/config/contributors.json:
833
834 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
835
836         [WPE] WebGL2 support
837         https://bugs.webkit.org/show_bug.cgi?id=174249
838
839         Reviewed by Alex Christensen.
840
841         * Scripts/webkitperl/FeatureList.pm:
842         Enable WebGL2 for WPE when building through build-webkit.
843
844 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
845
846         Unreviewed. Fix GTK distcheck.
847
848         * gtk/make-dist.py:
849         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
850
851 2017-07-25  Brady Eidson  <beidson@apple.com>
852
853         ResourceLoadStatistics grandfathering happens much too often.
854         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
855
856         Reviewed by Chris Dumez.
857
858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
859         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
860         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
861         (TEST):
862
863 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
864
865         Fix autoinstaller failing on autoinstall_everything
866         https://bugs.webkit.org/show_bug.cgi?id=174830
867
868         Reviewed by Joseph Pecoraro.
869
870         * Scripts/webkitpy/thirdparty/__init__.py:
871         (AutoinstallImportHook.find_module):
872         (AutoinstallImportHook.install_chromedriver):
873         (AutoinstallImportHook.install_geckodriver):
874         (AutoinstallImportHook._install_chromedriver): Deleted.
875         (AutoinstallImportHook._install_geckodriver): Deleted.
876
877 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
878
879         Replace --runtime with something for both ios-simulator and ios-device
880         https://bugs.webkit.org/show_bug.cgi?id=173775
881         <rdar://problem/32952164>
882
883         Reviewed by Aakash Jain.
884
885         Add --version flag for both iOS simulator and iOS device.
886
887         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
888         (parse_args): Add --version flag and move --no-install.
889         * Scripts/webkitpy/port/factory.py:
890         (platform_options): Move --no-intall to run_webkit_tests.py.
891         * Scripts/webkitpy/port/ios.py:
892         (IOSPort):
893         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
894         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
895         * Scripts/webkitpy/port/ios_device.py:
896         (IOSDevicePort.ios_version): Consult --version flag before checking connected
897         devices for iOS version.
898         * Scripts/webkitpy/port/ios_device_unittest.py:
899         (IOSDeviceTest.make_port): Set --version option so that we can generate test
900         expectation paths without devices connected.
901         (IOSDeviceTest.test_additional_platform_directory): Deleted.
902         (IOSDeviceTest.test_baseline_searchpath): Deleted.
903         (IOSDeviceTest.test_expectations_ordering): Deleted.
904         * Scripts/webkitpy/port/ios_simulator.py:
905         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
906         flag to specify a runtime.
907         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
908         flag and then use the default runtime.
909
910 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
911
912         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
913         https://bugs.webkit.org/show_bug.cgi?id=174815
914
915         Reviewed by Carlos Alberto Lopez Perez.
916
917         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
918         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
919         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
920         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
921         think), probably because of a newer CMake version.
922
923         * CMakeLists.txt:
924         * TestWebKitAPI/CMakeLists.txt:
925         * TestWebKitAPI/PlatformGTK.cmake:
926
927 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
928
929         Fix BenchmarkRunner to only import selenium when needed
930         https://bugs.webkit.org/show_bug.cgi?id=174808
931
932         Reviewed by Stephanie Lewis.
933
934         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
935         (LinuxChromeDriver.launch_driver):
936         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
937         (LinuxFirefoxDriver.launch_driver):
938         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
939         (OSXChromeDriver.launch_driver):
940         (OSXChromeCanaryDriver.launch_driver):
941         (create_chrome_options):
942         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
943         (OSXFirefoxDriver.launch_driver):
944         (OSXFirefoxNightlyDriver.launch_driver):
945         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
946         (OSXSafariDriver.launch_driver):
947         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
948         (WebDriverBenchmarkRunner._run_one_test):
949
950 2017-07-23  Darin Adler  <darin@apple.com>
951
952         More NeverDestroyed and related cleanup
953         https://bugs.webkit.org/show_bug.cgi?id=174745
954
955         Reviewed by Alex Christensen.
956
957         * DumpRenderTree/JavaScriptThreading.cpp:
958         (javaScriptThreadsMutex): Use NeverDestroyed instead of
959         DEPRECATED_DEFINE_STATIC_LOCAL.
960         (javaScriptThreads): Ditto.
961
962 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
963
964         Subclass Benchmark Runner script for WebDriver support
965         https://bugs.webkit.org/show_bug.cgi?id=174390
966
967         Reviewed by Dewei Zhu, Stephanie Lewis.
968
969         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
970
971         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
972         (BenchmarkBuilder.__init__):
973         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
974         (BenchmarkRunner.__init__):
975         (BenchmarkRunner._find_plan_file):
976         (BenchmarkRunner._run_one_test.and):
977         (BenchmarkRunner.execute):
978         (BenchmarkRunner._get_result): Deleted.
979         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
980         (parse_args):
981         (start):
982         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
983         (WebDriverBenchmarkRunner):
984         (WebDriverBenchmarkRunner._get_result):
985         (WebDriverBenchmarkRunner._run_one_test):
986         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
987         (WebServerBenchmarkRunner):
988         (WebServerBenchmarkRunner.__init__):
989         (WebServerBenchmarkRunner._get_result):
990         (WebServerBenchmarkRunner._run_one_test):
991
992 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
993
994         Add BenchmarkRunner patches with WebDriver support for each testing plan
995         https://bugs.webkit.org/show_bug.cgi?id=174443
996
997         Reviewed by Dewei Zhu, Stephanie Lewis.
998
999         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1000         (BenchmarkBuilder.__enter__):
1001         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1002         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1003         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1004         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1005         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1006         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1007         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1008         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1009         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1010         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1011         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1012         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1013         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1014         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1015         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1016         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1017         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1018         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1019         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1020         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1021         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1022         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1023         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1024         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1025         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1026         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1027         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1028         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1029         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1030         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1031         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1032         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1033         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1034
1035 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1036
1037         Add functions to autoinstaller needed for Benchmark Runner script
1038         https://bugs.webkit.org/show_bug.cgi?id=174331
1039
1040         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1041
1042         Adds autoinstaller functions to install selenium and webdriver binaries
1043         which will be used by the browser driver part of Benchmark Runner.
1044
1045         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1046         (BrowserDriver.restore_env):
1047         (BrowserDriver):
1048         (BrowserDriver.get_webdriver_binary_path):
1049         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1050         (LinuxChromeDriver.launch_driver):
1051         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1052         (LinuxFirefoxDriver.launch_driver):
1053         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1054         (OSXChromeDriver.launch_driver):
1055         (OSXChromeCanaryDriver.launch_driver):
1056         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1057         (OSXFirefoxDriver.launch_driver):
1058         (OSXFirefoxNightlyDriver.launch_driver):
1059         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1060         * Scripts/webkitpy/benchmark_runner/utils.py:
1061         (get_driver_binary_path):
1062         * Scripts/webkitpy/common/system/autoinstall.py:
1063         (AutoInstaller._unzip):
1064         * Scripts/webkitpy/thirdparty/__init__.py:
1065         (AutoinstallImportHook.find_module):
1066         (AutoinstallImportHook._install_selenium):
1067         (AutoinstallImportHook):
1068         (AutoinstallImportHook._install_chromedriver):
1069         (AutoinstallImportHook._install_geckodriver):
1070         (AutoinstallImportHook.get_latest_pypi_url):
1071         (AutoinstallImportHook.install_binary):
1072         (autoinstall_everything):
1073         (get_driver_filename):
1074         (get_os_info):
1075
1076 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1077
1078         Add WebDriver support in browser driver part of BenchmarkRunner
1079         https://bugs.webkit.org/show_bug.cgi?id=174445
1080
1081         Reviewed by Stephanie Lewis.
1082
1083         Adds a launch_driver function to each BrowserDriver subclass. This
1084         function sets up the arguments for the webdriver and launches the
1085         webdriver specific to that browser.
1086
1087         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1088         (BrowserDriver.launch_webdriver):
1089         (BrowserDriver):
1090         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1091         (LinuxBrowserDriver.launch_webdriver):
1092         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1093         (LinuxChromeDriver.launch_url):
1094         (LinuxChromeDriver):
1095         (LinuxChromeDriver.launch_driver):
1096         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1097         (EpiphanyBrowserDriver.launch_url):
1098         (EpiphanyBrowserDriver):
1099         (EpiphanyBrowserDriver.launch_driver):
1100         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1101         (LinuxFirefoxDriver):
1102         (LinuxFirefoxDriver.launch_url):
1103         (LinuxFirefoxDriver.launch_driver):
1104         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1105         (GTKMiniBrowserDriver.launch_url):
1106         (GTKMiniBrowserDriver):
1107         (GTKMiniBrowserDriver.launch_driver):
1108         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1109         (OSXBrowserDriver._launch_webdriver):
1110         (OSXBrowserDriver):
1111         (OSXBrowserDriver._screen_size):
1112         (OSXBrowserDriver._insert_url):
1113         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1114         (OSXChromeDriver):
1115         (OSXChromeDriver.launch_url):
1116         (OSXChromeDriver.launch_driver):
1117         (OSXChromeCanaryDriver):
1118         (OSXChromeCanaryDriver.launch_url):
1119         (OSXChromeCanaryDriver.launch_driver):
1120         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1121         (OSXFirefoxDriver):
1122         (OSXFirefoxDriver.launch_url):
1123         (OSXFirefoxDriver.launch_driver):
1124         (OSXFirefoxNightlyDriver):
1125         (OSXFirefoxNightlyDriver.launch_url):
1126         (OSXFirefoxNightlyDriver.launch_driver):
1127         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1128         (OSXSafariDriver.launch_driver):
1129
1130 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1131
1132         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1133         https://bugs.webkit.org/show_bug.cgi?id=174793
1134
1135         Reviewed by Tim Horton.
1136
1137         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1138         down. Without r219765, this test will dereference null and crash.
1139
1140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1141         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1142         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1143         (TEST):
1144
1145 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1146
1147         [Win] Implement Authentication dialog in MiniBrowser
1148         https://bugs.webkit.org/show_bug.cgi?id=174662
1149
1150         Reviewed by Alex Christensen.
1151
1152         * MiniBrowser/win/Common.cpp:
1153         (CustomUserAgent):
1154         (DisplayAuthDialog):
1155         (AuthDialogProc):
1156         * MiniBrowser/win/MiniBrowserLib.rc:
1157         * MiniBrowser/win/MiniBrowserLibResource.h:
1158         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1159         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1160
1161 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1162
1163         Handle case where line_numbers is None instead of an array of line numbers
1164         https://bugs.webkit.org/show_bug.cgi?id=174775
1165
1166         Reviewed by Aakash Jain.
1167
1168         Added files set line_numbers to None in process_file.
1169
1170         * Scripts/webkitpy/style/filereader.py:
1171         (TextFileReader.process_file): Handle case where line_number is set to None.
1172         * Scripts/webkitpy/style/main_unittest.py:
1173         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1174
1175 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1176
1177         [WPE] Add libepoxy to the Jhbuild moduleset
1178         https://bugs.webkit.org/show_bug.cgi?id=174711
1179
1180         Reviewed by Carlos Alberto Lopez Perez.
1181
1182         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1183
1184 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1185
1186         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1187         https://bugs.webkit.org/show_bug.cgi?id=174780
1188
1189         Reviewed by Carlos Garcia Campos.
1190
1191         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1192         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1193         in case the eglplatform.h header doesn't provide that macro. This replicates
1194         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1195
1196 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1197
1198         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1199         https://bugs.webkit.org/show_bug.cgi?id=174758
1200
1201         Reviewed by Dan Bernstein.
1202
1203         Migrate position-information-related unit tests from the PositionInformationTests suite to
1204         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1205
1206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1207         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1208         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1209         (TestWebKitAPI::TEST):
1210         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1211         * TestWebKitAPI/cocoa/TestWKWebView.h:
1212         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1213         (-[TestWKWebView activatedElementAtPosition:]):
1214
1215 2017-07-22  Chris Dumez  <cdumez@apple.com>
1216
1217         REGRESSION(r204565): WKObject is broken
1218         https://bugs.webkit.org/show_bug.cgi?id=174736
1219         <rdar://problem/33246169>
1220
1221         Reviewed by Dan Bernstein.
1222
1223         Add API test that used to crash.
1224
1225         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1226         (TestWebKitAPI::TEST):
1227
1228 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1229
1230         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1231         https://bugs.webkit.org/show_bug.cgi?id=174705
1232
1233         Reviewed by Mark Lam.
1234
1235         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1236         (TestWebKitAPI::testThreadGroup):
1237         (TestWebKitAPI::TEST):
1238
1239 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1240
1241         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1242         https://bugs.webkit.org/show_bug.cgi?id=174724
1243
1244         Reviewed by Aakash Jain.
1245
1246         * Scripts/webkitpy/port/ios_simulator.py:
1247         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1248         simulator. Errors here should be treated the same as no simulators found.
1249
1250 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1251
1252         [CMake] Add an option to stop build after generating project files
1253         https://bugs.webkit.org/show_bug.cgi?id=174664
1254
1255         Reviewed by Konstantin Tokarev.
1256
1257         Add "--generate-project-only" to stop build after generating project files.
1258
1259         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1260         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1261         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1262         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1263         (isGenerateProjectOnly): ditto
1264
1265 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1266
1267         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1268         https://bugs.webkit.org/show_bug.cgi?id=174501
1269
1270         Reviewed by Darin Adler.
1271
1272         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1273         (TestWebKitAPI::TEST):
1274
1275 2017-07-20  David Quesada  <david_quesada@apple.com>
1276
1277         Add SPI to notify WKNavigationDelegate about client redirects
1278         https://bugs.webkit.org/show_bug.cgi?id=174680
1279         rdar://problem/33184886
1280
1281         Reviewed by Brady Eidson.
1282
1283         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1284         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1285         (TEST):
1286         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1287
1288 2017-07-20  Brady Eidson  <beidson@apple.com>
1289
1290         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1291         https://bugs.webkit.org/show_bug.cgi?id=174685
1292
1293         Reviewed by Andy Estes.
1294
1295         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1296         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1297
1298 2017-07-20  Brady Eidson  <beidson@apple.com>
1299
1300         Deprecate WebIconDatabase in WebKitLegacy/mac.
1301         https://bugs.webkit.org/show_bug.cgi?id=174607
1302
1303         Reviewed by Alex Christensen.
1304
1305         * DumpRenderTree/mac/TestRunnerMac.mm:
1306
1307 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1308
1309         lint-test-expectations should be run during style checking
1310         https://bugs.webkit.org/show_bug.cgi?id=173559
1311         <rdar://problem/32854941>
1312
1313         Reviewed by Aakash Jain.
1314
1315         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1316         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1317         prevents identifying errors on specific lines in a file.
1318         * Scripts/webkitpy/style/main_unittest.py:
1319         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1320         case where a linter error is in the file modified, but the line modified is not related to
1321         the linter error.
1322
1323 2017-07-20  Brady Eidson  <beidson@apple.com>
1324
1325         Remove WebIconDatabase from WebKitLegacy/win.
1326         https://bugs.webkit.org/show_bug.cgi?id=174608
1327
1328         Reviewed by Alex Christensen.
1329
1330         * DumpRenderTree/win/DumpRenderTree.cpp:
1331         (main):
1332         * DumpRenderTree/win/TestRunnerWin.cpp:
1333         (TestRunner::setIconDatabaseEnabled):
1334
1335 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1336
1337         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1338         https://bugs.webkit.org/show_bug.cgi?id=174671
1339
1340         Reviewed by Carlos Garcia Campos.
1341
1342         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1343         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1344         priority for this source in order to have it dispatched on the same
1345         priority as the other WebKit-controlled GSource objects.
1346
1347 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1348
1349         lint-test-expectations should be run during style checking
1350         https://bugs.webkit.org/show_bug.cgi?id=173559
1351         <rdar://problem/32854941>
1352
1353         Reviewed by Daniel Bates.
1354
1355         Follow up fix addressing style and a few minor bugs.
1356
1357         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1358         (TestExpectationParser.__init__): Use lambda x: x instead of str
1359         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1360         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1361         reduce the calls of _shorten_filename, fix minor bug in appending the current
1362         expectation's line number instead of the previous ones, clarify treatment of None
1363         in file-to-line-number mapping.
1364         (TestExpectations._report_warnings): Collapse call.
1365         * Scripts/webkitpy/style/checkers/test_expectations.py:
1366         (TestExpectationsChecker.lint_test_expectations):
1367         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1368         (TextFileReader.process_file): Add comment explaining treatment of None in
1369         file-to-line-number mapping.
1370         (TextFileReader.delete_file): Collapse call.
1371
1372 2017-07-19  Chris Dumez  <cdumez@apple.com>
1373
1374         Unreviewed attempt to fix API test failure after r219663.
1375
1376         The test was hard-coding an exception string and the string has changed slightly
1377         in r219663.
1378
1379         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1380         (TEST):
1381
1382 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1383
1384         Don't write file URLs to iOS Pasteboard
1385         https://bugs.webkit.org/show_bug.cgi?id=174647
1386         <rdar://problem/33199730>
1387
1388         Reviewed by Wenson Hsieh.
1389
1390         Updating tests to reflect the lack of file URLs for images.
1391
1392         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1393         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1394         (checkEstimatedSize):
1395         (TestWebKitAPI::TEST):
1396
1397 2017-07-19  Brady Eidson  <beidson@apple.com>
1398
1399         iBooks sometimes crashes when closing a book.
1400         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1401
1402         Reviewed by Oliver Hunt.
1403
1404         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1405         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1406         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1407         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1408         (TestWebKitAPI::TEST):
1409
1410         Add a "spin the runloop X number of times" utility:
1411         * TestWebKitAPI/Utilities.h:
1412         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1413         (TestWebKitAPI::Util::spinRunLoop):
1414
1415 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1416
1417         lint-test-expectations should be run during style checking
1418         https://bugs.webkit.org/show_bug.cgi?id=173559
1419         <rdar://problem/32854941>
1420
1421         Reviewed by David Kilzer.
1422
1423         Running the test expectation linter requires reading both files and lines not in the
1424         patch because, for example, deletion of a test can cause a lint failure even though
1425         no test expectations where modified. This means that the linter will occasionally warn
1426         about lines which were not changed in a given patch but whose error is related to a
1427         change made in that patch.
1428
1429         * Scripts/webkitpy/common/system/filesystem_mock.py:
1430         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1431         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1432         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1433         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1434         content, description of the error and the name of the associated test.
1435         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1436         (TestExpectationParser.__init__): Pass shorten_filename function to
1437         TestExpectationsParser to add a deleted file to the related_files dictionary.
1438         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1439         missing path to the related_files dictionary.
1440         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1441         files and line numbers related to this test expectation line. This will allow
1442         tracking linter errors in the style checker occurring across multiple files.
1443         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1444         lines to related_files dictionary.
1445         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1446         (TestExpectations._report_warnings): Construct warning object instead of string
1447         when adding to warnings list.
1448         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1449         clean-up log.
1450         * Scripts/webkitpy/style/checker.py:
1451         (ProcessorBase.do_association_check): Add required function for processor classes.
1452         (StyleProcessor):
1453         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1454         checking for errors between associated files.
1455         * Scripts/webkitpy/style/checkers/test_expectations.py:
1456         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1457         (TestExpectationsChecker):
1458         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1459         of modified files, the current working directory and the host, determine if the linter
1460         warning is associated with the changes.
1461         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1462         style checker.
1463         * Scripts/webkitpy/style/filereader.py:
1464         (TextFileReader):
1465         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1466         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1467         (TextFileReader.process_file): Track both the number of files changed and which lines
1468         in those files were changed.
1469         (TextFileReader.do_association_check): Run the processor's association check on all
1470         modified or deleted files processed by TextFileReader.
1471         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1472         (TextFileReader.count_delete_only_file): Deleted.
1473         * Scripts/webkitpy/style/filereader_unittest.py:
1474         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1475         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1476         * Scripts/webkitpy/style/main.py:
1477         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1478         explicitly run the association check on the file reader.
1479         * Scripts/webkitpy/style/main_unittest.py:
1480         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1481         embedded in the style checker.
1482         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1483         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1484         construct the TextFileReader object with a StyleProcessor used to run style checks on
1485         specific files.
1486         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1487         testing the test expectation linter inside the style checker. This host must contain a
1488         mock file system with the basic structure of test expectations.
1489         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1490         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1491         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1492         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1493         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1494         * Scripts/webkitpy/style/patchreader.py:
1495         (PatchReader.check): Specify which file was deleted, run the association check.
1496         * Scripts/webkitpy/style/patchreader_unittest.py:
1497         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1498         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1499         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1500
1501 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1502
1503         [WTF] Implement WTF::ThreadGroup
1504         https://bugs.webkit.org/show_bug.cgi?id=174081
1505
1506         Reviewed by Mark Lam.
1507
1508         Add WTF::ThreadGroup tests.
1509
1510         * TestWebKitAPI/CMakeLists.txt:
1511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1512         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1513         (TestWebKitAPI::testThreadGroup):
1514         (TestWebKitAPI::TEST):
1515
1516 2017-07-18  Andy Estes  <aestes@apple.com>
1517
1518         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1519         https://bugs.webkit.org/show_bug.cgi?id=174631
1520
1521         Reviewed by Tim Horton.
1522
1523         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1524         * MiniBrowser/Configurations/Base.xcconfig:
1525         * MobileMiniBrowser/Configurations/Base.xcconfig:
1526         * TestWebKitAPI/Configurations/Base.xcconfig:
1527         * WebKitTestRunner/Configurations/Base.xcconfig:
1528
1529 2017-07-18  Andy Estes  <aestes@apple.com>
1530
1531         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1532         https://bugs.webkit.org/show_bug.cgi?id=174631
1533
1534         Reviewed by Sam Weinig.
1535
1536         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1537         * MiniBrowser/Configurations/Base.xcconfig:
1538         * MobileMiniBrowser/Configurations/Base.xcconfig:
1539         * TestWebKitAPI/Configurations/Base.xcconfig:
1540         * WebKitTestRunner/Configurations/Base.xcconfig:
1541
1542 2017-07-18  Daniel Bates  <dabates@apple.com>
1543
1544         lldb: Add type summary for StringView
1545         https://bugs.webkit.org/show_bug.cgi?id=174637
1546
1547         Reviewed by Sam Weinig.
1548
1549         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1550         StringView object will print output that has the form:
1551
1552             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1553               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1554               m_length = 2
1555               m_is8Bit = true
1556               m_underlyingString = 0x0000614000000a90
1557             }
1558
1559         * lldb/lldb_webkit.py:
1560         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1561         (WTFStringView_SummaryProvider):
1562         (WTFStringViewProvider):
1563         (WTFStringViewProvider.__init__):
1564         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1565         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1566         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1567         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1568
1569 2017-07-18  Andy Estes  <aestes@apple.com>
1570
1571         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1572         https://bugs.webkit.org/show_bug.cgi?id=174631
1573
1574         Reviewed by Dan Bernstein.
1575
1576         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1577         * MiniBrowser/Configurations/Base.xcconfig:
1578         * MobileMiniBrowser/Configurations/Base.xcconfig:
1579         * TestWebKitAPI/Configurations/Base.xcconfig:
1580         * WebKitTestRunner/Configurations/Base.xcconfig:
1581
1582 2017-07-18  Devin Rousso  <drousso@apple.com>
1583
1584         Web Inspector: Add memoryCost to Inspector Protocol objects
1585         https://bugs.webkit.org/show_bug.cgi?id=174478
1586
1587         Reviewed by Joseph Pecoraro.
1588
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1591         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1592         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1593         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1594         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1595         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1596         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1597         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1598         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1599         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1600         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1601         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1602         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1603         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1604         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1605         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1606
1607 2017-07-18  Andy Estes  <aestes@apple.com>
1608
1609         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1610         https://bugs.webkit.org/show_bug.cgi?id=174631
1611
1612         Reviewed by Darin Adler.
1613
1614         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1615         * MiniBrowser/Configurations/Base.xcconfig:
1616         * MobileMiniBrowser/Configurations/Base.xcconfig:
1617         * TestWebKitAPI/Configurations/Base.xcconfig:
1618         * WebKitTestRunner/Configurations/Base.xcconfig:
1619
1620 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1621
1622         Unreviewed, fix the iOS build.
1623
1624         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1625
1626         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1627         (TestWebKitAPI::TEST):
1628
1629 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1630
1631         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1632         https://bugs.webkit.org/show_bug.cgi?id=174585
1633         <rdar://problem/33302541>
1634
1635         Reviewed by Tim Horton.
1636
1637         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1638         being dragged when initiating a drag.
1639
1640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1641         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1642         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1643         (TestWebKitAPI::TEST):
1644         * TestWebKitAPI/cocoa/TestWKWebView.h:
1645
1646         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1647
1648         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1649         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1650
1651 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1652
1653         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1654         https://bugs.webkit.org/show_bug.cgi?id=174547
1655
1656         Reviewed by Alex Christensen.
1657
1658         * DumpRenderTree/PlatformWin.cmake:
1659         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1660
1661 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1662
1663         Update style checker to deal with "final"
1664         https://bugs.webkit.org/show_bug.cgi?id=174528
1665
1666         Reviewed by Alex Christensen.
1667         
1668         check-webkit-style shouldn't complain about an open brace to start a
1669         line after a function definition with "final" or "const final".
1670
1671         * Scripts/webkitpy/style/checkers/cpp.py:
1672         (check_braces):
1673         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1674         (CppStyleTest.test_brace_at_begin_of_line):
1675
1676 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1677
1678         Modernize content extension code
1679         https://bugs.webkit.org/show_bug.cgi?id=174588
1680
1681         Reviewed by Sam Weinig.
1682
1683         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1684         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1685         (TestWebKitAPI::testRequest):
1686         (TestWebKitAPI::makeBackend):
1687         (TestWebKitAPI::TEST_F):
1688
1689 2017-07-17  Brady Eidson  <beidson@apple.com>
1690
1691         WKHTTPCookieStore observing only works on the default cookie store.
1692         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1693
1694         Reviewed by Sam Weinig.
1695
1696         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1697         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1698           called for the default store, a non-persistent store, and a custom store.
1699         (TEST):
1700
1701 2017-07-16  Sam Weinig  <sam@webkit.org>
1702
1703         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1704         https://bugs.webkit.org/show_bug.cgi?id=174575
1705
1706         Reviewed by Brady Eidson.
1707
1708         * Scripts/svn-create-patch:
1709         (findModificationType):
1710         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1711         default value of "unknown".
1712
1713         (generateFileList):
1714         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1715         for untracked, which matches our old behavior.
1716
1717 2017-07-17  Charlie Turner  <cturner@igalia.com>
1718
1719         Add some missing build dependencies on Fedora
1720         https://bugs.webkit.org/show_bug.cgi?id=174578
1721
1722         Unreviewed dependency update.
1723
1724         * gtk/install-dependencies:
1725
1726 2017-07-16  Brady Eidson  <beidson@apple.com>
1727
1728         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1729         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1730
1731         Reviewed by Tim Horton.
1732
1733         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1734         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1735         (TEST):
1736
1737 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1738
1739         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1740         https://bugs.webkit.org/show_bug.cgi?id=174540
1741
1742         Reviewed by Michael Catanzaro.
1743
1744         * gtk/generate-inspector-gresource-manifest.py:
1745         (get_filenames): sort list of input files
1746
1747 2017-07-15  Brady Eidson  <beidson@apple.com>
1748
1749         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1750         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1751
1752         Reviewed by Tim Horton.
1753
1754         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1755         (TEST): Make this test more reliable by clearing everything beforehand.
1756
1757 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1758
1759         Make it possible to extend check-webkit-style with Apple-internal checkers
1760         <https://webkit.org/b/174464>
1761         <rdar://problem/25564402>
1762
1763         Reviewed by Darin Adler.
1764
1765         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1766         (_all_categories): Add categories from apple_additions() if it
1767         exists.
1768         (CheckerDispatcher._create_checker): Create python checker
1769         from apple_additions() if it exists.
1770
1771 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1772
1773         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1774         https://bugs.webkit.org/show_bug.cgi?id=174539
1775         <rdar://problem/33307395>
1776
1777         Reviewed by Darin Adler.
1778
1779         Adds a new unit test suite to cover action sheet popover presentation.
1780
1781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1782         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1783         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1784         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1785
1786         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1787
1788         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1789         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1790
1791         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1792
1793         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1794         (TestWebKitAPI::TEST):
1795
1796 2017-07-15  Sam Weinig  <sam@webkit.org>
1797
1798         [Scripts] Make svn-create-patch work better when called in sub directories
1799         https://bugs.webkit.org/show_bug.cgi?id=174551
1800
1801         Reviewed by Darin Adler.
1802
1803         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1804           by ensuring that the prefix is applied as is done in generateDiff.
1805         - Silence output of explanatory lines from svn stat (" > move to ...")
1806           that show up in STDERR when running svn-create-patch.
1807         - Add verbose logging that I found useful while debugging this issue.
1808
1809         * Scripts/svn-create-patch:
1810         (findBaseUrl):
1811         (findMimeType):
1812         (findSourceFileAndRevision):
1813         (generateDiff):
1814         (generateFileList):
1815         (manufacturePatchForAdditionWithHistory):
1816
1817 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1818
1819         Unreviewed build fix after r219537.
1820
1821         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1822
1823 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1824
1825         Add iOS 11 SPI
1826         https://bugs.webkit.org/show_bug.cgi?id=174430
1827         <rdar://problem/33269288>
1828
1829         Reviewed by Tim Horton.
1830
1831         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1832         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1833         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1834
1835 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1836
1837         Failing to install on iPad simulators
1838         https://bugs.webkit.org/show_bug.cgi?id=174532
1839         <rdar://problem/33328347>
1840
1841         Reviewed by Stephanie Lewis.
1842
1843         * Scripts/webkitpy/xcode/simulated_device.py:
1844         (SimulatedDevice.install_app): Place install command in retry try-except block.
1845
1846 2017-07-14  Jeff Miller  <jeffm@apple.com>
1847
1848         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1849         https://bugs.webkit.org/show_bug.cgi?id=174524
1850
1851         Reviewed by Sam Weinig.
1852
1853         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1854         (TEST):
1855         Renamed TestParameter to TestParameter1.
1856         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1857
1858         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1859         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1860         Observe changes for two bundle parameters.
1861
1862         (-[BundleParametersPlugIn dealloc]):
1863         Remove observers for two bundle parameters.
1864
1865 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1866
1867         Unreviewed, rolling out r219510.
1868         https://bugs.webkit.org/show_bug.cgi?id=174525
1869
1870         Need to revert length() == 0 check for null string (Requested
1871         by yusukesuzuki on #webkit).
1872
1873         Reverted changeset:
1874
1875         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1876         static string if StringImpl is static"
1877         https://bugs.webkit.org/show_bug.cgi?id=174501
1878         http://trac.webkit.org/changeset/219510
1879
1880 2017-07-14  Jer Noble  <jer.noble@apple.com>
1881
1882         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1883         https://bugs.webkit.org/show_bug.cgi?id=174514
1884
1885         Reviewed by Sam Weinig.
1886
1887         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1888         (TestWebKitAPI::TEST_F):
1889
1890 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1891
1892         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1893         https://bugs.webkit.org/show_bug.cgi?id=174501
1894
1895         Reviewed by Darin Adler.
1896
1897         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1898         (TestWebKitAPI::TEST):
1899
1900 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1901
1902         Bring mac expectations in-line with other platforms
1903         https://bugs.webkit.org/show_bug.cgi?id=174472
1904         <rdar://problem/33297388>
1905
1906         Reviewed by David Kilzer.
1907
1908         The override order for Mac test expectations does not conform to the pattern used by iOS,
1909         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1910
1911             platform/mac-wk2
1912             platform/wk2
1913             platform/mac-elcapitan
1914             platform/mac-sierra
1915             generic
1916
1917         After this change, El Capitan's baseline search path looks like this:
1918
1919             platform/mac-sierra-wk2
1920             platform/mac-sierra
1921             platform/mac-wk2
1922             platform/wk2
1923             generic
1924
1925         * Scripts/webkitpy/port/mac.py:
1926         (MacPort.__init__): If a specific version is specified in the port name, use that
1927         as the os version.
1928         (MacPort.default_baseline_search_path): Expectation search paths should work the
1929         same way they do on other ports. Port + version overrides port, port overrides generic
1930         and wk1/wk2 should override expectations for the two combined.
1931         * Scripts/webkitpy/port/mac_unittest.py:
1932         (MacTest.test_tests_for_other_platforms): Deleted.
1933         (MacTest._assert_search_path): Deleted.
1934         (MacTest.test_baseline_search_path): Deleted.
1935         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1936         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1937         (test_rebaseline_test_and_print_scm_changes): Ditto.
1938         (test_rebaseline_and_copy_test): Ditto.
1939         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1940         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1941         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1942
1943 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1944
1945         Fix style checker unit test
1946
1947         Unreviewed WebKit2 => WebKit fixup.
1948
1949         * Scripts/webkitpy/style/checker_unittest.py:
1950         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1951
1952 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1953
1954         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1955
1956         Unreviewed build fix.
1957
1958         r219492 missed one hunk from its partial revert of r219489.
1959         This patch reverts that hunk.
1960
1961         * TestWebKitAPI/CMakeLists.txt:
1962
1963 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1964
1965         Use the old WebKit/WebKit2 targets for CMake builds.
1966
1967         Unreviewed build fix.
1968
1969         We can update the target names to match the Framework names in a future patch.
1970         This is a partial revert of r219489.
1971
1972         * TestWebKitAPI/CMakeLists.txt:
1973         WebKitLegacy => WebKit
1974         WebKit => WebKit2
1975
1976 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1977
1978         Fix TestWebKit API.
1979         https://bugs.webkit.org/show_bug.cgi?id=174164
1980         rdar://problem/33137595
1981
1982         Reviewed by Dan Bernstein.
1983
1984         * TestWebKitAPI/CMakeLists.txt:
1985         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1986         * TestWebKitAPI/PlatformGTK.cmake:
1987
1988 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1989
1990         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1991         https://bugs.webkit.org/show_bug.cgi?id=174164
1992         rdar://problem/33137595
1993
1994         Reviewed by Dan Bernstein.
1995
1996         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1997         (ShouldBuildTest):
1998         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1999         * Scripts/build-webkit:
2000         * Scripts/do-file-rename:
2001         * Scripts/do-webcore-rename:
2002         * Scripts/update-webkit-localizable-strings:
2003         * Scripts/webkitpy/common/config/watchlist:
2004         * Scripts/webkitpy/style/checker.py:
2005         * Scripts/webkitpy/style/checkers/featuredefines.py:
2006         * gtk/make-dist.py:
2007         (ensure_version_if_possible):
2008         * gtk/manifest.txt.in:
2009
2010 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2011
2012         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2013         https://bugs.webkit.org/show_bug.cgi?id=174162
2014         rdar://problem/33137594
2015
2016         Reviewed by Dan Bernstein.
2017
2018         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2019
2020         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2021         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2022         * EWSTools/configure-clang-linux.sh:
2023         * Scripts/build-webkit:
2024         * Scripts/do-file-rename:
2025         * Scripts/do-webcore-rename:
2026         * Scripts/update-webkit-localizable-strings:
2027         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2028         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2029         * Scripts/webkitpy/style/checkers/featuredefines.py:
2030         * gtk/manifest.txt.in:
2031
2032 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2033
2034         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2035         https://bugs.webkit.org/show_bug.cgi?id=174438
2036         <rdar://problem/33277112>
2037
2038         Reviewed by Aakash Jain.
2039
2040         Given a patch, this will convert the changes from the path to the new directory structure.
2041
2042         * Scripts/rebase-patch-after-webkit-move: Added.
2043         (append_source): Append 'Source' to the provided path.
2044         (is_editable_line): Return true if a line the script expects to modify.
2045         (needs_rebase): Return if a line needs to be rebased based on it's content.
2046         (rebase_line): Rebase the provided line.
2047         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2048         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2049         were provided.
2050
2051 2017-07-12  Nan Wang  <n_wang@apple.com>
2052
2053         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2054         https://bugs.webkit.org/show_bug.cgi?id=174393
2055         <rdar://problem/33248006>
2056
2057         Reviewed by Chris Fleizach.
2058
2059         * DumpRenderTree/AccessibilityUIElement.cpp:
2060         (textMarkerRangeMatchesTextNearMarkersCallback):
2061         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2062         (AccessibilityUIElement::getJSClass):
2063         * DumpRenderTree/AccessibilityUIElement.h:
2064         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2065         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2066         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2067         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2068         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2069         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2070         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2071         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2072
2073 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2074
2075         Unreviewed, rolling out r219409.
2076
2077         The revision caused the Windows builds to fail.
2078
2079         Reverted changeset:
2080
2081         "AX: [iOS] Implement a way to retrieve a text marker range
2082         with desired text that is closest to a position"
2083         https://bugs.webkit.org/show_bug.cgi?id=174393
2084         http://trac.webkit.org/changeset/219409
2085
2086 2017-07-12  Nan Wang  <n_wang@apple.com>
2087
2088         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2089         https://bugs.webkit.org/show_bug.cgi?id=174393
2090         <rdar://problem/33248006>
2091
2092         Reviewed by Chris Fleizach.
2093
2094         * DumpRenderTree/AccessibilityUIElement.cpp:
2095         (textMarkerRangeMatchesTextNearMarkersCallback):
2096         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2097         (AccessibilityUIElement::getJSClass):
2098         * DumpRenderTree/AccessibilityUIElement.h:
2099         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2100         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2101         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2102         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2103         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2104         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2105         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2106         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2107
2108 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2109
2110         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2111         https://bugs.webkit.org/show_bug.cgi?id=174197
2112
2113         Reviewed by Darin Adler.
2114
2115         This bit me the first time I tried to submit a patch to WebKit, and still I have
2116         to manually edit the ChangeLog every time I use the script.
2117
2118         This generates a more convenient and standard ChangeLog entry.
2119
2120         * Scripts/prepare-ChangeLog:
2121         (generateNewChangeLogs):
2122
2123 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2124
2125         Unreviewed, rolling out r219401.
2126
2127         This revision rolled out the previous patch, but after talking
2128         with reviewer, a rebaseline is what was needed.Rolling back in
2129         before rebaseline.
2130
2131         Reverted changeset:
2132
2133         "Unreviewed, rolling out r219379."
2134         https://bugs.webkit.org/show_bug.cgi?id=174400
2135         http://trac.webkit.org/changeset/219401
2136
2137 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2138
2139         Unreviewed, rolling out r219379.
2140
2141         This revision caused a consistent failure in the test
2142         fast/dom/Window/property-access-on-cached-window-after-frame-
2143         removed.html.
2144
2145         Reverted changeset:
2146
2147         "Remove NAVIGATOR_HWCONCURRENCY"
2148         https://bugs.webkit.org/show_bug.cgi?id=174400
2149         http://trac.webkit.org/changeset/219379
2150
2151 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2152
2153         [WPE] Use libepoxy
2154         https://bugs.webkit.org/show_bug.cgi?id=172104
2155
2156         Reviewed by Michael Catanzaro.
2157
2158         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2159         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2160
2161 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2162
2163         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2164         https://bugs.webkit.org/show_bug.cgi?id=174363
2165
2166         Reviewed by Michael Catanzaro.
2167
2168         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2169         between the GTK+ and WPE port. There's no reason for the two ports to apply
2170         different patches over same versions of GStreamer releases.
2171
2172         This aligns the two ports on this specific issue. Next we'll look into
2173         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2174         to keep these patches in a single place, avoiding duplicate files.
2175
2176         * gtk/jhbuild.modules:
2177         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2178         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2179         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2180         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2181
2182 2017-07-11  Dean Jackson  <dino@apple.com>
2183
2184         Remove NAVIGATOR_HWCONCURRENCY
2185         https://bugs.webkit.org/show_bug.cgi?id=174400
2186
2187         Reviewed by Sam Weinig.
2188
2189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2190
2191 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2192
2193         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2194         https://bugs.webkit.org/show_bug.cgi?id=174239
2195
2196         Reviewed by Brady Eidson.
2197
2198         Create windows with specific features set and make sure those are properly reflected in the
2199         WKWindowFeatures object.
2200
2201         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2202         (resetToConsistentState):
2203         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2204         (TEST):
2205
2206 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2207
2208         Do not duplicate files when deleting directories with svn 1.9
2209         https://bugs.webkit.org/show_bug.cgi?id=174339
2210         <rdar://problem/33226781>
2211
2212         Reviewed by David Kilzer.
2213
2214         * Scripts/svn-create-patch:
2215         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2216         (generateFileList): Determine which files are deleted because they are part of a
2217         directory being deleted.
2218
2219 2017-07-11  Dean Jackson  <dino@apple.com>
2220
2221         Rolling out r219372.
2222
2223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2224
2225 2017-07-11  Dean Jackson  <dino@apple.com>
2226
2227         Remove NAVIGATOR_HWCONCURRENCY
2228         https://bugs.webkit.org/show_bug.cgi?id=174400
2229
2230         Reviewed by Sam Weinig.
2231
2232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2233
2234 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2235
2236         Teach build workers to fetch archives from S3.
2237         https://bugs.webkit.org/show_bug.cgi?id=174384
2238
2239         Reviewed by Aakash Jain.
2240
2241         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2242         (DownloadBuiltProduct):
2243
2244 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2245
2246         Configure buildbot to transfer all archives to S3.
2247         Previously this was Mac only, but it's time to expand!
2248         https://bugs.webkit.org/show_bug.cgi?id=174378
2249         
2250         Reviewed by Aakash Jain.
2251
2252         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2253         (BuildFactory.__init__):
2254
2255 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2256
2257         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2258         https://bugs.webkit.org/show_bug.cgi?id=174350
2259
2260         Reviewed by Xabier Rodriguez-Calvar.
2261
2262         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2263         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2264         patches are removed. The patches for gst-plugins-good are updated, removing
2265         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2266         rtpbin elements that will help with the EMEv3 development.
2267
2268         * wpe/jhbuild.modules:
2269         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2270         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2271         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2272         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2273         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2274         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2275         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2276         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2277         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2278
2279 2017-07-10  John Wilander  <wilander@apple.com>
2280
2281         Resource Load Statistics: Prune statistics in orders of importance
2282         https://bugs.webkit.org/show_bug.cgi?id=174215
2283         <rdar://problem/33164403>
2284
2285         Reviewed by Chris Dumez.
2286
2287         Nest infrastructure. Adds these functions:
2288         1. testRunner.setStatisticsLastSeen()
2289         2. setStatisticsMaxStatisticsEntries()
2290         3. setStatisticsPruneEntriesDownTo()
2291
2292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2294         (WTR::TestRunner::setStatisticsLastSeen):
2295         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2296         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2298         * WebKitTestRunner/TestController.cpp:
2299         (WTR::TestController::setStatisticsLastSeen):
2300         (WTR::TestController::setMaxStatisticsEntries):
2301         (WTR::TestController::setPruneEntriesDownTo):
2302         * WebKitTestRunner/TestController.h:
2303         * WebKitTestRunner/TestInvocation.cpp:
2304         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2305         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2306         (WTR::TestController::setStatisticsLastSeen):
2307         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2308         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2309
2310 2017-07-03  Brian Burg  <bburg@apple.com>
2311
2312         Web Replay: remove some unused code
2313         https://bugs.webkit.org/show_bug.cgi?id=173903
2314
2315         Rubber-stamped by Joseph Pecoraro.
2316
2317         * Scripts/run-input-generator-tests: Removed.
2318         * Scripts/webkitpy/replay/__init__.py: Removed.
2319         * Scripts/webkitpy/replay/main.py: Removed.
2320
2321 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2322
2323         [WPE] Fix layout test baseline and TestExpectations hierarchy
2324         https://bugs.webkit.org/show_bug.cgi?id=174092
2325
2326         Reviewed by Michael Catanzaro.
2327
2328         Like for the GTK+ port, override the default_baseline_search_path() and
2329         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2330         Both methods operate on a short list of search paths that defaults to 'wpe' and
2331         'wk2', along with any other user-specified platform directory.
2332
2333         The test_expectations_file_position() method is overridden for testing purposes,
2334         and relevant unit tests are added.
2335
2336         * Scripts/webkitpy/port/wpe.py:
2337         (WPEPort._search_paths):
2338         (WPEPort):
2339         (WPEPort.default_baseline_search_path):
2340         (WPEPort._port_specific_expectations_files):
2341         (WPEPort.test_expectations_file_position):
2342         * Scripts/webkitpy/port/wpe_unittest.py:
2343         (WPEPortTest.test_default_baseline_search_path):
2344         (WPEPortTest):
2345         (WPEPortTest.test_port_specific_expectations_files):
2346
2347 2017-07-10  Chris Dumez  <cdumez@apple.com>
2348
2349         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2350         https://bugs.webkit.org/show_bug.cgi?id=174301
2351
2352         Reviewed by Brent Fulgham.
2353
2354         Rename some of the testRunner API for clarity and to better match what it calls
2355         internally.
2356
2357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2359         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2360         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2362         * WebKitTestRunner/TestController.cpp:
2363         (WTR::TestController::statisticsUpdateCookiePartitioning):
2364         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2365         * WebKitTestRunner/TestController.h:
2366         * WebKitTestRunner/TestInvocation.cpp:
2367         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2368         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2369         (WTR::TestController::statisticsUpdateCookiePartitioning):
2370         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2371
2372 2017-07-10  Charlie Turner  <cturner@igalia.com>
2373
2374         [GStreamer] Live twitch.tv videos do not play
2375         https://bugs.webkit.org/show_bug.cgi?id=174222
2376
2377         Reviewed by Michael Catanzaro.
2378
2379         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2380         fixes videos not playing on twitch.tv.
2381
2382         * gtk/jhbuild.modules:
2383
2384 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2385
2386         Add WebGL2 configuration option to build-webkit
2387         https://bugs.webkit.org/show_bug.cgi?id=174251
2388
2389         Reviewed by Michael Catanzaro.
2390
2391         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2392         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2393         is marked as enabled for the Apple Cocoa ports.
2394
2395 2017-07-08  Chris Dumez  <cdumez@apple.com>
2396
2397         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2398         https://bugs.webkit.org/show_bug.cgi?id=174290
2399
2400         Reviewed by Brent Fulgham.
2401
2402         Rename testRunner API to match the new internal API names.
2403
2404         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2405         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2406         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2407         (WTR::TestRunner::statisticsSubmitTelemetry):
2408         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2409         * WebKitTestRunner/TestController.cpp:
2410         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2411         (WTR::TestController::statisticsSubmitTelemetry):
2412         * WebKitTestRunner/TestController.h:
2413         * WebKitTestRunner/TestInvocation.cpp:
2414         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2415         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2416         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2417         (WTR::TestController::statisticsSubmitTelemetry):
2418
2419 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2420
2421         Drop NOSNIFF compile flag
2422         https://bugs.webkit.org/show_bug.cgi?id=174289
2423
2424         Reviewed by Michael Catanzaro.
2425
2426         * Scripts/webkitperl/FeatureList.pm:
2427         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2428
2429 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2430
2431         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2432         https://bugs.webkit.org/show_bug.cgi?id=174219
2433         <rdar://problem/32083177>
2434
2435         Reviewed by Ryosuke Niwa.
2436
2437         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2438         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2439         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2440         place.
2441
2442         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2443         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2444         no action is taken when dropping.
2445
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2447         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2448         (TestWebKitAPI::TEST):
2449         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2450         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2451         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2452         (-[MockDragDropSession allowsMoveOperation]):
2453         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2454         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2455         (-[DataInteractionSimulator initWithWebView:]):
2456         (-[DataInteractionSimulator runFrom:to:]):
2457         (-[DataInteractionSimulator _advanceProgress]):
2458         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2459         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2460         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2461
2462 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2463
2464         Unreviewed, rolling out r219238, r219239, and r219241.
2465         https://bugs.webkit.org/show_bug.cgi?id=174265
2466
2467         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2468         (Requested by yusukesuzuki on #webkit).
2469
2470         Reverted changesets:
2471
2472         "[WTF] Implement WTF::ThreadGroup"
2473         https://bugs.webkit.org/show_bug.cgi?id=174081
2474         http://trac.webkit.org/changeset/219238
2475
2476         "Unreviewed, build fix after r219238"
2477         https://bugs.webkit.org/show_bug.cgi?id=174081
2478         http://trac.webkit.org/changeset/219239
2479
2480         "Unreviewed, CLoop build fix after r219238"
2481         https://bugs.webkit.org/show_bug.cgi?id=174081
2482         http://trac.webkit.org/changeset/219241
2483
2484 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2485
2486         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2487         https://bugs.webkit.org/show_bug.cgi?id=174250
2488
2489         Reviewed by Carlos Alberto Lopez Perez.
2490
2491         * Scripts/webkitperl/FeatureList.pm:
2492
2493 2017-07-07  Charlie Turner  <cturner@igalia.com>
2494         [GStreamer] vid.me videos do not play
2495         https://bugs.webkit.org/show_bug.cgi?id=172240
2496
2497         Reviewed by Xabier Rodriguez-Calvar.
2498
2499         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2500         have the existing libsoup build against GNOME to avoid header drift
2501         against GStreamer's linked Soup library.
2502
2503         * gtk/jhbuild.modules:
2504
2505 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2506
2507         Write a support script to enable buildbot to upload to S3
2508         https://bugs.webkit.org/show_bug.cgi?id=174196
2509         
2510         Reviewed by Stephanie Lewis.
2511
2512         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2513         (uploadToS3):
2514         (archiveExists):
2515
2516 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2517
2518         Enabling uploading archives to S3.
2519         https://bugs.webkit.org/show_bug.cgi?id=174198
2520         
2521         Reviewed by Stephanie Lewis.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2524         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2525         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2526         (TransferToS3): Transfer full and minified archives to S3
2527
2528 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2529
2530         [WTF] Implement WTF::ThreadGroup
2531         https://bugs.webkit.org/show_bug.cgi?id=174081
2532
2533         Reviewed by Mark Lam.
2534
2535         Add WTF::ThreadGroup tests.
2536
2537         * TestWebKitAPI/CMakeLists.txt:
2538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2539         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2540         (TestWebKitAPI::TEST):
2541
2542 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2543
2544         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2545         https://bugs.webkit.org/show_bug.cgi?id=174150
2546
2547         Reviewed by Mark Lam.
2548
2549         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2550         (TestWebKitAPI::TEST):
2551         * TestWebKitAPI/TestsController.cpp:
2552         (TestWebKitAPI::TestsController::TestsController):
2553
2554 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2555
2556         Enabling uploading archives to S3.
2557         https://bugs.webkit.org/show_bug.cgi?id=174198
2558         
2559         Reviewed by Lucas Forschler.
2560
2561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2562         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2563         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2564         (TransferToS3): Transfer full and minified archives to S3
2565
2566 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2567
2568         [GTK][WPE] kill-old-process should kill more webkit related process
2569         https://bugs.webkit.org/show_bug.cgi?id=174220
2570
2571         Reviewed by Michael Catanzaro.
2572
2573         Generate list of possible webkit-related process names and add
2574         them to the list of process to kill.
2575         Also update the possible system related process for GTK+/WPE.
2576
2577         * BuildSlaveSupport/kill-old-processes:
2578         (listAllWebKitPrograms):
2579         (main):
2580
2581 2017-07-06  Chris Dumez  <cdumez@apple.com>
2582
2583         FileMonitor should not be ref counted
2584         https://bugs.webkit.org/show_bug.cgi?id=174166
2585
2586         Reviewed by Brent Fulgham.
2587
2588         Update the API tests to reflect the API change.
2589
2590         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2591         (TestWebKitAPI::TEST_F):
2592
2593 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2594
2595         Unreviewed, rolling out r219194.
2596         https://bugs.webkit.org/show_bug.cgi?id=174207
2597
2598         it broke some layout tests (Requested by clopez on #webkit).
2599
2600         Reverted changeset:
2601
2602         "[GStreamer] vid.me videos do not play"
2603         https://bugs.webkit.org/show_bug.cgi?id=172240
2604         http://trac.webkit.org/changeset/219194
2605
2606 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2607
2608         Unreviewed, rolling out r219178.
2609
2610         This caused a consistent failure with the API test
2611         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2612
2613         Reverted changeset:
2614
2615         "[WTF] Clean up StringStatics.cpp by using
2616         LazyNeverDestroyed<> for Atoms"
2617         https://bugs.webkit.org/show_bug.cgi?id=174150
2618         http://trac.webkit.org/changeset/219178
2619
2620 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2621
2622         Add CWD to Perl library path (no longer the default since 5.26.0)
2623         https://bugs.webkit.org/show_bug.cgi?id=174200
2624
2625         Reviewed by Michael Catanzaro.
2626
2627         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2628         (SetupGitClone._get_username_and_email):
2629
2630 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2631
2632         Unreviewed, update my email address.
2633
2634         * Scripts/webkitpy/common/config/contributors.json:
2635
2636 2017-07-06  Charlie Turner  <cturner@igalia.com>
2637         [GStreamer] vid.me videos do not play
2638         https://bugs.webkit.org/show_bug.cgi?id=172240
2639
2640         Reviewed by Xabier Rodriguez-Calvar.
2641
2642         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2643         have the existing libsoup build against GNOME to avoid header drift
2644         against GStreamer's linked Soup library.
2645
2646         * gtk/jhbuild.modules:
2647
2648 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2649
2650         [WTF] Move SoftLinking.h into WTF
2651         https://bugs.webkit.org/show_bug.cgi?id=174000
2652
2653         Reviewed by Alex Christensen.
2654
2655         * DumpRenderTree/mac/TestRunnerMac.mm:
2656         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2657         (test_primary_header):
2658         (ErrorCollector.__init__): Deleted.
2659         (ErrorCollector.__call__): Deleted.
2660         (ErrorCollector.results): Deleted.
2661         (ErrorCollector.result_list): Deleted.
2662         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2663         (MockIo.open): Deleted.
2664         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2665         (CppFunctionsTest.test_create_acronym): Deleted.
2666         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2667         (CppFunctionsTest.test_parameter): Deleted.
2668         (CppFunctionsTest.test_single_line_view): Deleted.
2669         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2670         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2671         (CppFunctionsTest.test_parameter_list): Deleted.
2672         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2673         (CppStyleTestBase.process_file_data): Deleted.
2674         (CppStyleTestBase.perform_lint): Deleted.
2675         (CppStyleTestBase.perform_single_line_lint): Deleted.
2676         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2677         (CppStyleTestBase.perform_language_rules_check): Deleted.
2678         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2679         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2680         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2681         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2682         (CppStyleTestBase.perform_header_guard_check): Deleted.
2683         (CppStyleTestBase.assert_lint): Deleted.
2684         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2685         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2686         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2687         (CppStyleTestBase.assert_language_rules_check): Deleted.
2688         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2689         (CppStyleTestBase.assert_header_guard): Deleted.
2690         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2691         (CppStyleTestBase.assert_positions_equal): Deleted.
2692         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2693         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2694         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2695         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2696         (FunctionDetectionTest.test_ignore_macros): Deleted.
2697         (FunctionDetectionTest.test_non_functions): Deleted.
2698         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2699         (FunctionDetectionTest.test_parameter_list): Deleted.
2700         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2701         (CppStyleTest.test_asm_lines_ignored): Deleted.
2702         (CppStyleTest.test_get_line_width): Deleted.
2703         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2704         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2705         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2706         (CppStyleTest.test_position): Deleted.
2707         (CppStyleTest.test_rfind_in_lines): Deleted.
2708         (CppStyleTest.test_close_expression): Deleted.
2709         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2710         (CppStyleTest.test_cstyle_cast): Deleted.
2711         (CppStyleTest.test_runtime_casting): Deleted.
2712         (CppStyleTest.test_runtime_selfinit): Deleted.
2713         (CppStyleTest.test_runtime_rtti): Deleted.
2714         (CppStyleTest.test_static_cast_readability): Deleted.
2715         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2716         (CppStyleTest.void): Deleted.
2717         (CppStyleTest.test_deprecated_cast): Deleted.
2718         (CppStyleTest.test_mock_method): Deleted.
2719         (CppStyleTest.test_sizeof_type): Deleted.
2720         (CppStyleTest.cases): Deleted.
2721         (CppStyleTest.for): Deleted.
2722         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2723         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2724         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2725         (CppStyleTest.test_include_what_you_use): Deleted.
2726         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2727         (CppStyleTest.test_cleanse_line): Deleted.
2728         (CppStyleTest.test_multi_line_comments): Deleted.
2729         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2730         (CppStyleTest.test_multiline_strings): Deleted.
2731         (CppStyleTest.test_platformh_comments): Deleted.
2732         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2733         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2734         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2735         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2736         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2737         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2738         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2739         (CppStyleTest.test_check_posix_threading): Deleted.
2740         (CppStyleTest.test_insecure_string_operations): Deleted.
2741         (CppStyleTest.test_format_strings): Deleted.
2742         (CppStyleTest.test_insecure_temp_file): Deleted.
2743         (CppStyleTest.test_variable_length_array_detection): Deleted.
2744         (CppStyleTest.test_braces): Deleted.
2745         (CppStyleTest.test_check_check): Deleted.
2746         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2747         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2748         (CppStyleTest.test_spacing_for_fncall): Deleted.
2749         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2750         (CppStyleTest.test_spacing_before_braces): Deleted.
2751         (CppStyleTest.test_spacing_between_braces): Deleted.
2752         (CppStyleTest.test_spacing_before_brackets): Deleted.
2753         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2754         (CppStyleTest.test_objective_c_block): Deleted.
2755         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2756         (CppStyleTest.test_spacing_around_else): Deleted.
2757         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2758         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2759         (CppStyleTest.test_operator_methods): Deleted.
2760         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2761         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2762         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2763         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2764         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2765         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2766         (CppStyleTest.test_space_after_comment_marker): Deleted.
2767         (CppStyleTest.test_newline_at_eof): Deleted.
2768         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2769         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2770         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2771         (CppStyleTest.test_invalid_utf8): Deleted.
2772         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2773         (CppStyleTest.test_is_blank_line): Deleted.
2774         (CppStyleTest.test_blank_lines_check): Deleted.
2775         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2776         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2777         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2778         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2779         (CppStyleTest.test_comma): Deleted.
2780         (CppStyleTest.test_declaration): Deleted.
2781         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2782         (CppStyleTest.test_indent): Deleted.
2783         (CppStyleTest.test_indent.Foo): Deleted.
2784         (CppStyleTest.test_not_alabel): Deleted.
2785         (CppStyleTest.test_tab): Deleted.
2786         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2787         (CppStyleTest.test_build_class): Deleted.
2788         (CppStyleTest.test_build_class.definitions): Deleted.
2789         (CppStyleTest.test_build_class.Foo): Deleted.
2790         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2791         (CppStyleTest.test_build_end_comment): Deleted.
2792         (CppStyleTest.test_build_forward_decl): Deleted.
2793         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2794         (CppStyleTest.test_build_header_guard): Deleted.
2795         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2796         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2797         (CppStyleTest.test_build_printf_format): Deleted.
2798         (CppStyleTest.test_runtime_printf_format): Deleted.
2799         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2800         (CppStyleTest.test_build_storage_class): Deleted.
2801         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2802         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2803         (CppStyleTest.test_build_storage_class.after): Deleted.
2804         (CppStyleTest.test_build_storage_class.is): Deleted.
2805         (CppStyleTest.test_legal_copyright): Deleted.
2806         (CppStyleTest.test_invalid_increment): Deleted.
2807         (CppStyleTest.test_enum_bitfields): Deleted.
2808         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2809         (CleansedLinesTest.test_init_empty): Deleted.
2810         (CleansedLinesTest.test_collapse_strings): Deleted.
2811         (OrderOfIncludesTest.tearDown): Deleted.
2812         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2813         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2814         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2815         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2816         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2817         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2818         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2819         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2820         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2821         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2822         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2823         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2824         (OrderOfIncludesTest.test_primary_header): Deleted.
2825         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2826         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2827         (OrderOfIncludesTest.test_classify_include): Deleted.
2828         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2829         (CheckForFunctionLengthsTest.tearDown): Deleted.
2830         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2831         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2832         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2833         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2834         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2835         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2836         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2837         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2838         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2839         (CheckForFunctionLengthsTest.function_body): Deleted.
2840         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2841         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2842         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2843         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2844         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2845         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2846         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2847         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2848         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2849         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2850         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2851         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2852         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2853         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2854         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2855         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2856         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2857         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2858         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2859         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2860         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2861         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2862         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2863         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2864         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2865         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2866         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2867         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2868         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2869         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2870         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2871         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2872         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2873         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2874         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2875         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2876         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2877         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2878         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2879         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2880         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2881         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2882         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2883         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2884         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2885         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2886         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2887         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2888         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2889         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2890         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2891         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2892         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2893         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2894         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2895         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2896         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2897         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2898         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2899         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2900         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2901         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2902         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2903         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2904         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2905         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2906         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2907         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2908         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2909         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2910         (LeakyPatternTest.test_get_dc): Deleted.
2911         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2912         (LeakyPatternTest.test_own_get_dc): Deleted.
2913         (LeakyPatternTest.test_create_dc): Deleted.
2914         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2915         (WebKitStyleTest.test_indentation): Deleted.
2916         (WebKitStyleTest.test_indentation.Foo): Deleted.
2917         (WebKitStyleTest.test_indentation.Document): Deleted.
2918         (WebKitStyleTest.test_spacing): Deleted.
2919         (WebKitStyleTest.test_line_breaking): Deleted.
2920         (WebKitStyleTest.test_braces): Deleted.
2921         (WebKitStyleTest.test_braces.MyClass): Deleted.
2922         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2923         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2924         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2925         (WebKitStyleTest.test_null_false_zero): Deleted.
2926         (WebKitStyleTest.test_directive_indentation): Deleted.
2927         (WebKitStyleTest.test_using_std): Deleted.
2928         (WebKitStyleTest.test_using_namespace): Deleted.
2929         (WebKitStyleTest.test_max_macro): Deleted.
2930         (WebKitStyleTest.test_min_macro): Deleted.
2931         (WebKitStyleTest.test_wtf_move): Deleted.
2932         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2933         (WebKitStyleTest.test_names): Deleted.
2934         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2935         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2936         (WebKitStyleTest.test_names.declarations): Deleted.
2937         (WebKitStyleTest.test_names.struct): Deleted.
2938         (WebKitStyleTest.test_names.VectorType): Deleted.
2939         (WebKitStyleTest.test_parameter_names): Deleted.
2940         (WebKitStyleTest.test_comments): Deleted.
2941         (WebKitStyleTest.test_webkit_export_check): Deleted.
2942         (WebKitStyleTest.test_member_initialization_list): Deleted.
2943         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2944         (WebKitStyleTest.test_other): Deleted.
2945         (CppCheckerTest.mock_handle_style_error): Deleted.
2946         (CppCheckerTest._checker): Deleted.
2947         (CppCheckerTest.test_init): Deleted.
2948         (CppCheckerTest.test_eq): Deleted.
2949         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2950         (CppCheckerTest.test_ne): Deleted.
2951         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2952         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2953         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2954         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2955         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2956         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2957
2958 2017-07-05  Saam Barati  <sbarati@apple.com>
2959
2960         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2961         https://bugs.webkit.org/show_bug.cgi?id=174188
2962         <rdar://problem/30581423>
2963
2964         Reviewed by Mark Lam.
2965
2966         * Scripts/run-jsc-stress-tests:
2967
2968 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2969
2970         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2971         https://bugs.webkit.org/show_bug.cgi?id=174150
2972
2973         Reviewed by Mark Lam.
2974
2975         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2976         (TestWebKitAPI::TEST):
2977
2978 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2979
2980         Remove copy of ICU headers from WebKit
2981         https://bugs.webkit.org/show_bug.cgi?id=116407
2982
2983         Reviewed by Alex Christensen.
2984
2985         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2986         * TestWebKitAPI/Configurations/Base.xcconfig:
2987         * WebKitTestRunner/Configurations/Base.xcconfig:
2988
2989 2017-07-05  Chris Dumez  <cdumez@apple.com>
2990
2991         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2992         https://bugs.webkit.org/show_bug.cgi?id=174163
2993         <rdar://problem/33067518>
2994
2995         Reviewed by Alex Christensen.
2996
2997         Add API test coverage.
2998
2999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3000         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3001         (TEST):
3002
3003 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3004
3005         When dragging a selection, clearing the selection in dragstart should not crash the web process
3006         https://bugs.webkit.org/show_bug.cgi?id=174142
3007         <rdar://problem/33067501>
3008
3009         Reviewed by Tim Horton.
3010
3011         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3012         drag is starting up.
3013
3014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3015         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3016         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3017         (TestWebKitAPI::TEST):
3018
3019 2017-07-05  Daniel Bates  <dabates@apple.com>
3020
3021         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3022         API navigation
3023         https://bugs.webkit.org/show_bug.cgi?id=174170
3024         <rdar://problem/33140328>
3025
3026         Reviewed by Brady Eidson.
3027
3028         Update tests as needed for the behavior change.
3029
3030         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3031         (TEST):
3032
3033 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3034
3035         Add WebKitPrivateFrameworkStubs for iOS 11
3036         https://bugs.webkit.org/show_bug.cgi?id=173988
3037
3038         Reviewed by David Kilzer.
3039
3040         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3041         should use the same directory for private framework stubs.
3042         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3043
3044 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3045
3046         [MediaStream] Protect request and web view during gUM client callback
3047         https://bugs.webkit.org/show_bug.cgi?id=174096
3048         <rdar://problem/32833102>
3049
3050         Reviewed by Youenn Fablet.
3051
3052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3053         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3054
3055 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3056
3057         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3058
3059         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3060
3061 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3062
3063         Unreviewed, rolling out r219128.
3064
3065         Spoke with engineer who originally submitted, Patch for APi
3066         test to follow.
3067
3068         Reverted changeset:
3069
3070         "Unreviewed, rolling out r219070."
3071         https://bugs.webkit.org/show_bug.cgi?id=174082
3072         http://trac.webkit.org/changeset/219128
3073
3074 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3075
3076         Unreviewed, rolling out r219070.
3077
3078         This revision caused consistent failures of the API test
3079         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3080
3081         Reverted changeset:
3082
3083         "Pasting single words copied to UIPasteboard inserts URLs in
3084         editable areas"
3085         https://bugs.webkit.org/show_bug.cgi?id=174082
3086         http://trac.webkit.org/changeset/219070
3087
3088 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3089
3090         Remove unused EFL logo from bot watcher dashboard
3091         https://bugs.webkit.org/show_bug.cgi?id=174136
3092
3093         Reviewed by Alexey Proskuryakov.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3097
3098 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3099
3100         [GTK] Add more GTK bots to dashboard
3101         https://bugs.webkit.org/show_bug.cgi?id=174129
3102
3103         Reviewed by Carlos Alberto Lopez Perez.
3104
3105         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3106         them.
3107
3108         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3109         less-essential GTK bots.
3110
3111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3113         (WebKitBuildbot):
3114
3115 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3116
3117         [WPE] Add WPE to bot watcher dashboard
3118         https://bugs.webkit.org/show_bug.cgi?id=174119
3119
3120         Reviewed by Alexey Proskuryakov.
3121
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3127         (WebKitBuildbot):
3128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3129         (table.queue-grid tr.platform.linux-wpe img.logo):
3130
3131 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=174105
3134         
3135         Reviewed by Stephanie Lewis.
3136
3137         * BuildSlaveSupport/built-product-archive:
3138         (main): Add a -minify parser option
3139         (createZip): Pass along the optional Minify argument if requested
3140         (minifySource): This will trim down archives, logic limited to Mac platform.
3141
3142 2017-07-03  Matt Rajca  <mrajca@apple.com>
3143
3144         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3145         https://bugs.webkit.org/show_bug.cgi?id=174103
3146
3147         Reviewed by Alex Christensen.
3148
3149         Added an API test.
3150
3151         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3152         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3153         (TEST): Added test.
3154         * TestWebKitAPI/cocoa/TestWKWebView.h:
3155         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3156         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3157
3158 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3159
3160         Unreviewed, rolling out r219103.
3161
3162         Caused multiple build failures.
3163
3164         Reverted changeset:
3165
3166         "Remove copy of ICU headers from WebKit"
3167         https://bugs.webkit.org/show_bug.cgi?id=116407
3168         http://trac.webkit.org/changeset/219103
3169
3170 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3171
3172         Remove copy of ICU headers from WebKit
3173         https://bugs.webkit.org/show_bug.cgi?id=116407
3174
3175         Reviewed by Alex Christensen.
3176
3177         Use WTF's copy of ICU headers.
3178
3179         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3180         * TestWebKitAPI/Configurations/Base.xcconfig:
3181         * WebKitTestRunner/Configurations/Base.xcconfig:
3182
3183 2017-07-03  Brady Eidson  <beidson@apple.com>
3184
3185         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3186         https://bugs.webkit.org/show_bug.cgi?id=174073
3187
3188         Reviewed by Andy Estes.
3189
3190         * DumpRenderTree/mac/TestRunnerMac.mm:
3191         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3192
3193         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3194         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3195
3196 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3197
3198         Unreviewed, rolling out r219083.
3199
3200         The revision caused an API failure on all testing platforms.
3201
3202         Reverted changeset:
3203
3204         "[MediaStream] Protect request and web view during gUM client
3205         callback"
3206         https://bugs.webkit.org/show_bug.cgi?id=174096
3207         http://trac.webkit.org/changeset/219083
3208
3209 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3210
3211         webkitpy: Properly number duplicated crashlogs
3212         https://bugs.webkit.org/show_bug.cgi?id=172002
3213
3214         Reviewed by Aakash Jain.
3215
3216         * Scripts/webkitpy/common/system/crashlogs.py:
3217         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3218         an increasing integer.
3219         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3220         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3221         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3222         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3223
3224 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3225
3226         WebContent processes crash when the network process crashes with pending connection requests
3227         https://bugs.webkit.org/show_bug.cgi?id=174065
3228         <rdar://problem/30359835>
3229
3230         Reviewed by Tim Horton.
3231
3232         Add a API to ensure UI process tries to relaunch a new network process when the network process
3233         crashes with pending network connection requests.
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3237         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3238         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3239         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3240
3241 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3242
3243         [MediaStream] Protect request and web view during gUM client callback
3244         https://bugs.webkit.org/show_bug.cgi?id=174096
3245         <rdar://problem/32833102>
3246
3247         Reviewed by Youenn Fablet.
3248
3249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3250         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3251
3252 2017-07-03  Andy Estes  <aestes@apple.com>
3253
3254         [Xcode] Add an experimental setting to build with ccache
3255         https://bugs.webkit.org/show_bug.cgi?id=173875
3256
3257         Reviewed by Tim Horton.
3258
3259         On systems that already have ccache(1) installed, this patch adds experimental support for
3260         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3261
3262         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3263         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3264         find the toolchain from which to run clang, and then invokes ccache with the required
3265         arguments.
3266
3267         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3268         precompiled headers to work properly [1].
3269
3270         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3271         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3272         during linking.
3273         
3274         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3275
3276         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3277         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3278         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3279         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3280         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3281         * ccache/README.md: Added.
3282         * ccache/ccache-clang: Added.
3283         * ccache/ccache-clang++: Added.
3284         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3285
3286 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3287
3288         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3289         https://bugs.webkit.org/show_bug.cgi?id=174051
3290
3291         Reviewed by Tim Horton.
3292
3293         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3294         (TestWebKitAPI::TEST_F):
3295
3296 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3297
3298         Unreviewed, rolling out r219024.
3299
3300         This patch cause 3 didferent test to fail.
3301
3302         Reverted changeset:
3303
3304         "REGRESSION(r215096) Queries of URLs with non-special schemes
3305         should not percent-encode single quotes"
3306         https://bugs.webkit.org/show_bug.cgi?id=174051
3307         http://trac.webkit.org/changeset/219024
3308
3309 2017-07-03  Chris Dumez  <cdumez@apple.com>
3310
3311         Drop ResourceLoadStatisticsStore's statisticsLock
3312         https://bugs.webkit.org/show_bug.cgi?id=174080
3313
3314         Reviewed by Brent Fulgham.
3315
3316         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3317
3318         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3319         (WTR::TestController::isStatisticsPrevalentResource):
3320         (WTR::TestController::isStatisticsHasHadUserInteraction):
3321         (WTR::TestController::isStatisticsGrandfathered):
3322
3323 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3324
3325         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3326         https://bugs.webkit.org/show_bug.cgi?id=174082
3327         <rdar://problem/33046992>
3328
3329         Reviewed by Tim Horton.
3330
3331         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3332
3333         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3334         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3335         (TestWebKitAPI::TEST):
3336
3337 2017-07-02  Brady Eidson  <beidson@apple.com>
3338
3339         Add API test for all parts of WebKit1 API related to favicons.
3340         https://bugs.webkit.org/show_bug.cgi?id=174069
3341
3342         Reviewed by Andy Estes.
3343
3344         These two API tests cover all WebKit1 API related to icons.
3345         
3346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3347         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3348         (mainResourceData):
3349         (defaultFaviconData):
3350         (customFaviconData):
3351         (imageFromData):
3352         (+[IconLoadingProtocol canInitWithRequest:]):
3353         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3354         (-[IconLoadingProtocol startLoading]):
3355         (-[IconLoadingProtocol stopLoading]):
3356         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3357         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3358         (TestWebKitAPI::TEST):
3359
3360 2017-07-01  Dan Bernstein  <mitz@apple.com>
3361
3362         [iOS] Remove code only needed when building for iOS 9.x
3363         https://bugs.webkit.org/show_bug.cgi?id=174068
3364
3365         Reviewed by Tim Horton.
3366
3367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3368         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3369         (WTR::initializeWebViewConfiguration):
3370         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3371         (-[HIDEventGenerator _createIOHIDEventType:]):
3372
3373 2017-07-01  Brady Eidson  <beidson@apple.com>
3374
3375         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3376         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3377
3378         Reviewed by Alex Christensen.
3379
3380         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3381
3382 2017-07-01  Dan Bernstein  <mitz@apple.com>
3383
3384         [macOS] Remove code only needed when building for OS X Yosemite
3385         https://bugs.webkit.org/show_bug.cgi?id=174067
3386
3387         Reviewed by Tim Horton.
3388
3389         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3390         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3391         * DumpRenderTree/mac/DumpRenderTree.mm:
3392         (setDefaultsToConsistentValuesForTesting):
3393         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3394         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3395         * MiniBrowser/Configurations/Base.xcconfig:
3396         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3397         * TestWebKitAPI/Configurations/Base.xcconfig:
3398         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3399         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3400         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3401         (TestWebKitAPI::TEST_F):
3402         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3403         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3404         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3405         (TestWebKitAPI::TEST_F):
3406         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3407         (TestWebKitAPI::TEST):
3408         * WebKitTestRunner/Configurations/Base.xcconfig:
3409         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3410         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3411         (WTR::InjectedBundle::platformInitialize):
3412         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3413         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3414
3415 2017-07-01  Chris Dumez  <cdumez@apple.com>
3416
3417         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3418         https://bugs.webkit.org/show_bug.cgi?id=174060
3419
3420         Reviewed by Brent Fulgham.
3421
3422         Port WebKitTestRunner over to the new Cocoa SPI.
3423
3424         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3425         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3426         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3427         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3428         no-ops since this code runs in the WebContent process, not the
3429         UIProcess.
3430
3431         * WebKitTestRunner/TestController.cpp:
3432         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3433
3434 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3435
3436         Unreviewed mac build fix.
3437
3438         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3439         (TestWebKitAPI::TEST):
3440
3441 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3442
3443         Add API to get WKActivatedElementInfo
3444         https://bugs.webkit.org/show_bug.cgi?id=174001
3445         <rdar://problem/29165518>
3446         
3447         Tests for now SPI to get activatedElementInfo.
3448
3449         Reviewed by Tim Horton.
3450
3451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3452         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3453         (TestWebKitAPI::TEST):
3454
3455 2017-06-30  Chris Dumez  <cdumez@apple.com>
3456
3457         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3458         https://bugs.webkit.org/show_bug.cgi?id=174038
3459
3460         Reviewed by Brent Fulgham.
3461
3462         Fix typo in API name.
3463
3464         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3465         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3466         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3467         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3468         * WebKitTestRunner/TestController.cpp:
3469         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3470         * WebKitTestRunner/TestController.h:
3471         * WebKitTestRunner/TestInvocation.cpp:
3472         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3473
3474 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3475
3476         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3477         https://bugs.webkit.org/show_bug.cgi?id=174051
3478         <rdar://problem/33002846>
3479
3480         Reviewed by Tim Horton.
3481
3482         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3483         (TestWebKitAPI::TEST_F):
3484
3485 2017-06-30  Daniel Bates  <dabates@apple.com>
3486
3487         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3488         https://bugs.webkit.org/show_bug.cgi?id=165160
3489         <rdar://problem/29451999>
3490
3491         Reviewed by Brady Eidson.
3492
3493         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3494         for navigations and window creation.
3495
3496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3497         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3498         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3499         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3500         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3501         (TEST):
3502
3503 2017-06-29  Jer Noble  <jer.noble@apple.com>
3504
3505         Make Legacy EME API controlled by RuntimeEnabled setting.
3506         https://bugs.webkit.org/show_bug.cgi?id=173994
3507
3508         Reviewed by Sam Weinig.
3509
3510         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3511
3512 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3513
3514         Follow-up fix for r218996
3515
3516         Unreviewed infrastructure fix.
3517
3518         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3519
3520         * Scripts/webkitpy/port/ios_simulator.py:
3521         (IOSSimulatorPort): Memoize ios_version().
3522
3523 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3524
3525         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3526         https://bugs.webkit.org/show_bug.cgi?id=174017
3527         <rdar://problem/32959782>
3528
3529         Reviewed by Simon Fraser.
3530
3531         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3532         changes, the caret would appear outside of the iframe.
3533
3534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3535         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3536         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3537         (checkDragCaretRectIsContainedInRect):
3538         (TestWebKitAPI::TEST):
3539         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3540         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3541         (-[DataInteractionSimulator _resetSimulatedState]):
3542         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3543         (-[DataInteractionSimulator _advanceProgress]):
3544         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3545
3546 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3547
3548         Add support for different versions of iOS when loading test expectations
3549         https://bugs.webkit.org/show_bug.cgi?id=173774
3550         <rdar://problem/32951132>
3551
3552         Rubber-stamped by Aakash Jain.
3553
3554         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3555
3556         * Scripts/webkitpy/port/ios.py:
3557         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3558         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3559         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3560         * Scripts/webkitpy/port/ios_device.py:
3561         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3562         * Scripts/webkitpy/port/ios_device_unittest.py:
3563         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3564         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3565         (IOSDeviceTest.test_expectations_ordering): Ditto.
3566         * Scripts/webkitpy/port/ios_simulator.py:
3567         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3568         ask the platform.
3569
3570 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3571
3572         Fontconfig build breaks with glibc 2.15+
3573         https://bugs.webkit.org/show_bug.cgi?id=174019
3574
3575         Reviewed by Carlos Alberto Lopez Perez.
3576
3577         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3578
3579         * wpe/jhbuild.modules:
3580         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
3581
3582 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3583
3584         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
3585         https://bugs.webkit.org/show_bug.cgi?id=174010
3586         <rdar://problem/32597802>
3587
3588         Reviewed by Tim Horton.
3589
3590         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
3591         snapshot fails for any reason.
3592
3593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3594         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
3595         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3596         (TestWebKitAPI::TEST):
3597