[Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
[WebKit-https.git] / Tools / ChangeLog
1 2013-08-26  Arunprasad Rajkumar  <arurajku@cisco.com>
2
3         [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
4         https://bugs.webkit.org/show_bug.cgi?id=119791
5
6         Reviewed by Jocelyn Turcotte.
7         
8         Load empty url to send onunload event to currently running page. onunload event is 
9         mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
10         LayoutTests/plugins/geturlnotify-during-document-teardown.html.
11
12         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
13         (WebPage::~WebPage):
14
15 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
16
17         [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
18         https://bugs.webkit.org/show_bug.cgi?id=120290
19
20         Reviewed by Philippe Normand.
21
22         * MiniBrowser/gtk/GNUmakefile.am: Add
23         -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
24
25 2013-08-26  Zan Dobersek  <zdobersek@igalia.com>
26
27         [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
28         https://bugs.webkit.org/show_bug.cgi?id=120288
29
30         Reviewed by Carlos Garcia Campos.
31
32         * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
33         into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
34         These unit tests are at the moment failing in debug configurations, so it would be nice to
35         have the GTK builds report these failures as well.
36
37 2013-08-25  Ryuan Choi  <ryuan.choi@samsung.com>
38
39         [EFL] EWebLauncher is executed as full screen with device pixel ratio
40         https://bugs.webkit.org/show_bug.cgi?id=120282
41
42         Reviewed by Gyuyoung Kim.
43
44         * EWebLauncher/main.c:
45         Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
46
47 2013-08-25  Zan Dobersek  <zdobersek@igalia.com>
48
49         [gdb] Remove the pretty printer for KURLGooglePrivate
50         https://bugs.webkit.org/show_bug.cgi?id=120263
51
52         Reviewed by Benjamin Poulain.
53
54         Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
55         was usable inside the gdb debugger. The structure was remove from the codebase
56         along with the GoogleURL backend for KURL.
57
58         * gdb/webkit.py:
59         (JSCJSStringPrinter.to_string):
60         (add_pretty_printers):
61
62 2013-08-24  Filip Pizlo  <fpizlo@apple.com>
63
64         Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
65         prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
66         libraries depend on libgtest anyway.
67
68         * Scripts/copy-webkitlibraries-to-product-directory:
69
70 2013-08-24  Darin Adler  <darin@apple.com>
71
72         RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
73         https://bugs.webkit.org/show_bug.cgi?id=120255
74
75         Reviewed by Andreas Kling.
76
77         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
78
79 2013-08-24  Anders Carlsson  <andersca@apple.com>
80
81         Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
82         https://bugs.webkit.org/show_bug.cgi?id=120249
83
84         Reviewed by Andreas Kling.
85
86         * Scripts/extract-localizable-strings:
87
88 2013-08-24  Carlos Garcia Campos  <cgarcia@igalia.com>
89
90         [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
91         https://bugs.webkit.org/show_bug.cgi?id=119743
92
93         Reviewed by Anders Carlsson.
94
95         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
96         (WTR::InjectedBundlePage::InjectedBundlePage): Add
97         willDestroyFrame.
98
99 2013-08-23  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
100
101         Move TestWebKitAPI_LIBRARIES before platform specific cmake include
102         https://bugs.webkit.org/show_bug.cgi?id=120220
103
104         Reviewed by Martin Robinson.
105
106         * TestWebKitAPI/CMakeLists.txt:
107
108 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
109
110         build-jsc --ftl-jit should work
111         https://bugs.webkit.org/show_bug.cgi?id=120194
112
113         Reviewed by Oliver Hunt.
114
115         * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
116
117 2013-08-23  Commit Queue  <commit-queue@webkit.org>
118
119         Unreviewed, rolling out r153534.
120         http://trac.webkit.org/changeset/153534
121         https://bugs.webkit.org/show_bug.cgi?id=120216
122
123         Too many tests failing just WinEWS bots (Requested by rfong on
124         #webkit).
125
126         * Scripts/webkitpy/common/config/ews.json:
127
128 2013-08-23  Alex Christensen  <alex.christensen@flexsim.com>
129
130         Unreviewed.  Added my webkit.org email address.
131
132         * Scripts/webkitpy/common/config/contributors.json:
133
134 2013-08-23  Peter Gal  <galpeter@inf.u-szeged.hu>
135
136         [WTR] Should dump as text when the mimetype is text/plain
137         https://bugs.webkit.org/show_bug.cgi?id=118306
138
139         Reviewed by Christophe Dumez.
140
141         Check for the text/plain mimetype and if true then mark it as
142         text dump.
143
144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
145         (WTR::InjectedBundlePage::dump):
146
147 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
148
149         Update LLVM binary drops and scripts to the latest version from SVN
150         https://bugs.webkit.org/show_bug.cgi?id=120184
151
152         Reviewed by Mark Hahnenberg.
153
154         * ReducedFTL/build.sh:
155         * Scripts/configure-llvm: Added.
156         * Scripts/copy-webkitlibraries-to-product-directory:
157         * Scripts/export-llvm-build:
158
159 2013-08-22  Andy Estes  <aestes@apple.com>
160
161         <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
162
163         Reviewed by David Kilzer.
164
165         * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
166         OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
167         DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
168
169 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
170
171         NRWT: Add the ability to upload test results to new test results server
172         https://bugs.webkit.org/show_bug.cgi?id=120146
173
174         Reviewed by Andreas Kling.
175         
176         For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
177         that contains the full summary of the test run including information about passed tests.
178
179         Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
180         --build-slave
181         --got-revision
182         --results-server-host
183
184         The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
185         so we should be able to delete --test-results-server in time.
186
187         * Scripts/webkitpy/layout_tests/controllers/manager.py:
188         (Manager.run):
189         (Manager._upload_json_files):
190         (Manager):
191         (Manager.upload_results):
192         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
193         (summarize_results):
194         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
195         (summarized_results):
196         (SummarizedResultsTest.test_summarized_results_wontfix):
197         (SummarizedResultsTest):
198         (SummarizedResultsTest.test_summarized_results_include_passes):
199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
200         (parse_args):
201
202 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
203
204         WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
205
206         * Scripts/webkitpy/tool/bot/irc_command.py:
207         (Hi.execute):
208
209 2013-08-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
210
211         [Qt] DRT bug revealed/caused by r154300
212         https://bugs.webkit.org/show_bug.cgi?id=120151
213
214         Reviewed by Simon Hausmann.
215
216         Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
217         the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
218         in r154300.
219
220         DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
221         between native Qt methods and JSC bound methods. This patch changes the check to see if the 
222         property is writable since the Qt methods are ReadOnly.
223
224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
225         (DumpRenderTree::initJSObjects):
226
227 2013-08-21  Joseph Pecoraro  <pecoraro@apple.com>
228
229         <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
230
231         Reviewed by Benjamin Poulain.
232
233         WTFString moved the is8bit bit by one in r152201.
234
235         * lldb/lldb_webkit.py:
236         (WTFStringImplProvider.is_8bit):
237
238 2013-08-21  Tim Horton  <timothy_horton@apple.com>
239
240         Revert http://trac.webkit.org/changeset/154022, as it failed to update
241         a variety of scripts that depended on the old format.
242
243         See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
244
245         * Scripts/prepare-ChangeLog:
246         (main):
247         (generateNewChangeLogs):
248
249 2013-08-21  Brent Fulgham  <bfulgham@apple.com>
250
251         [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
252
253         * WinLauncher/WinLauncher.cpp:
254         (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
255
256 2013-08-21  Zan Dobersek  <zdobersek@igalia.com>
257
258         <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
259
260         Reviewed by Andreas Kling.
261
262         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
263         (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
264         (WTR::activateFonts): Ditto.
265
266 2013-08-21  Brian Holt  <brian.holt@samsung.com>
267
268         [GTK] Suppress irrelevant or known leaks for Valgrind
269         https://bugs.webkit.org/show_bug.cgi?id=119448
270
271         Reviewed by Martin Robinson.
272
273         Add a suppressions file to suppress known leaks for Valgrind.
274         Valgrind also takes longer when using suppressions and
275         times out unless the driver timeout is increased.
276
277         * Scripts/valgrind/suppressions.txt: Added.
278         * Scripts/webkitpy/port/gtk.py:
279         (GtkPort.driver_stop_timeout):
280         (GtkPort.setup_environ_for_server):
281
282 2013-08-20  Alex Christensen  <achristensen@apple.com>
283
284         [Windows] Linking fix for Win64.
285
286         Rubberstamped by Brent Fulgham.
287
288         * win/DLLLauncher/DLLLauncherMain.cpp:
289         (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
290
291 2013-08-20  Brent Fulgham  <bfulgham@apple.com>
292
293         <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
294
295         Reviewed by Tim Horton.
296
297         * win/DLLLauncher/DLLLauncherMain.cpp:
298         (getLastErrorString): New method to convert GetLastError to text.
299         (wWinMain): Use new error formatter to provide useful diagnostic text to user.
300
301 2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>
302
303         <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
304
305         Reviewed by Martin Robinson.
306
307         * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
308         from naming/enum_casing rules, since it needs to provide GObject-style APIs.
309
310 2013-08-20  Anton Obzhirov  <a.obzhirov@samsung.com>
311
312         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
313
314         Reviewed by Martin Robinson.
315
316         Added stop button in MiniBrowser
317
318         * MiniBrowser/gtk/BrowserWindow.c:
319         (reloadOrStopCallback): Callback to handle stop or reload button click.
320         (webViewLoadProgressChanged): Update reload or stop button icon.
321         (browser_window_init): Save button pointer for further icon updates.
322
323 2013-08-20  Simon Pena  <simon.pena@samsung.com>
324
325         <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
326
327         Reviewed by Alexey Proskuryakov.
328
329         Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
330         printing didFailLoadWithError.
331
332         Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
333         DumpRenderTree, printing didFailLoadWithError.
334
335         * DumpRenderTree/gtk/DumpRenderTree.cpp:
336         (webFrameLoadStatusNotified):
337
338 2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>
339
340         <https://webkit.org/b/120049> Delete code for Snow Leopard
341
342         Reviewed by Benjamin Poulain.
343
344         * DumpRenderTree/mac/CheckedMalloc.cpp:
345         (protectionOfRegion):
346         (makeLargeMallocFailSilently):
347         * DumpRenderTree/mac/DumpRenderTree.mm:
348         (resetDefaultsToConsistentValues):
349         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
350         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
351         * DumpRenderTree/mac/FrameLoadDelegate.mm:
352         (testPathFromURL):
353         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
354         * DumpRenderTree/mac/LayoutTestHelper.m:
355         * DumpRenderTree/mac/TestRunnerMac.mm:
356         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
357         (WTR::InjectedBundle::platformInitialize):
358         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
359         (WTR::testPathFromURL):
360         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
361
362 2013-08-19  Alexey Proskuryakov  <ap@apple.com>
363
364         https://bugs.webkit.org/show_bug.cgi?id=119915
365         REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
366
367         Reviewed by Darin Adler.
368
369         The issue was that we ended up having no CFNetwork cache in the testing session due
370         to an incorrect cache model. There is a number of things not implemented when it
371         comes to dynamically changing cache model as attempted by WebKitTestRunner, but
372         the easiest way to get this going is to initialize it to correct value upfront.
373
374         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
375
376 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
377
378         REGRESSION(r154275): webkitpy tests failing
379         https://bugs.webkit.org/show_bug.cgi?id=120010
380
381         Reviewed by Jocelyn Turcotte.
382
383         Update unit-tests to tests the new search-path structure,
384         but reverting the architecture search path addition.
385
386         * Scripts/webkitpy/port/qt.py:
387         (QtPort):
388         (QtPort.__init__):
389         (QtPort._generate_all_test_configurations):
390         (QtPort.qt_architecture):
391         * Scripts/webkitpy/port/qt_unittest.py:
392         (QtPortTest):
393         (QtPortTest._assert_search_path):
394         (QtPortTest._assert_expectations_files):
395         (QtPortTest._qt_version):
396
397 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
398
399         [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
400
401         Unreviewed meta gardening.
402
403         We need to keep using the qt-5.0-wk2 path until it is fully migrated.
404
405         * Scripts/webkitpy/port/qt.py:
406         (QtPort._search_paths):
407
408 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
409
410         Restructure Qt test expectations
411
412         Unreviewed meta gardening.
413
414         Removed 5.0 name from WK1 and WK2 results and made it possible to set
415         expectations by both Qt version and mayor architectures.
416
417         * Scripts/webkitpy/port/qt.py:
418         (QtPort._wk2_port_name):
419         (QtPort.__init__):
420         (QtPort.qt_version):
421         (QtPort.architecture):
422         (QtPort._search_paths):
423         (QtPort._port_specific_expectations_files):
424
425 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
426
427         [Windows] DRT is not using the same preferences as the Mac build.
428         https://bugs.webkit.org/show_bug.cgi?id=119822
429
430         Reviewed by Darin Adler.
431
432         * DumpRenderTree/win/DumpRenderTree.cpp:
433         (runTest): Process Windows message queue using CFRunLoop to allow
434         dispatch routines to run properly.
435         (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
436         to prevent problems on WinCairo port.
437
438 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
439
440         [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
441         https://bugs.webkit.org/show_bug.cgi?id=119583
442
443         Reviewed by Alexey Proskuryakov.
444
445         * DumpRenderTree/win/DumpRenderTree.cpp:
446         (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
447         component if the URL does not contain the expected base URL.
448
449 2013-08-16  Pratik Solanki  <psolanki@apple.com>
450
451         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
452
453         Reviewed by Andreas Kling.
454
455         m_script is never NULL so we can just return a reference. Also remove some pointless null
456         checks as a result of doing this.
457
458         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
459         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
460
461 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
462
463         [WK2] NetworkProcess should use a temporary storage session for test
464         https://bugs.webkit.org/show_bug.cgi?id=119855
465
466         Reviewed by Darin Adler.
467
468         Use a new API that takes care of both WebProcess and NetworkProcess.
469
470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
471         (WTR::InjectedBundle::initialize):
472         * WebKitTestRunner/TestController.cpp:
473         (WTR::TestController::initialize):
474
475 2013-08-15  Bem Jones-Bey  <bjonesbe@adobe.com>
476
477         <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
478
479         Reviewed by Dirk Pranke.
480
481         This is a port from Blink of
482         https://src.chromium.org/viewvc/blink?revision=155647&view=revision
483         originally by Dirk Pranke.
484
485         From the original commit:
486
487         This gives something like a 15x speedup over compiling and matching
488         one property at a time and doing multiple passes over the file.
489
490         * Scripts/webkitpy/w3c/test_converter.py:
491         (W3CTestConverter.__init__):
492         (W3CTestConverter.convert_prefixed_properties):
493         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
494
495 2013-08-15  Dan Bernstein  <mitz@apple.com>
496
497         <https://webkit.org/b/119856> Improve extract-localizable-strings messages
498
499         Reviewed by Darin Adler.
500
501         * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
502         added a message that points to the source code. Removed some unnecessary repetition of what
503         is already in the file.
504
505 2013-08-15  Andy Estes  <aestes@apple.com>
506
507         <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
508
509         Reviewed by Brady Eidson.
510
511         Wrote an API test that verifies -[WebView stopLoading:] can be called
512         inside webView:resource:didFinishLoadingFromDataSource: without crashing.
513
514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
515         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
516         (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
517         (TestWebKitAPI::TEST):
518
519 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
520
521         Adding Myles Maxfield to contributors.json.
522
523         Oops, wrong section, fixing.
524
525         * Scripts/webkitpy/common/config/contributors.json:
526
527 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
528
529         Adding Myles Maxfield to contributors.json.
530
531         * Scripts/webkitpy/common/config/contributors.json:
532
533 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
534
535         [Qt] Do not check specifically for version 5.0
536         https://bugs.webkit.org/show_bug.cgi?id=119846
537
538         Reviewed by Jocelyn Turcotte.
539
540         For Qt 5.x we should always use both wk1 and wk2 basepath results.
541
542         * Scripts/webkitpy/port/qt.py:
543         (QtPort._search_paths):
544
545 2013-08-15  Simon Pena  <simon.pena@samsung.com>
546
547         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
548
549         Reviewed by Gustavo Noronha Silva.
550
551         Following a similar approach as in r153977, return a path string
552         that is relative to main frame URL or just file name if the
553         resource is not in the same directory subtree, and replace empty
554         strings with "(null)".
555
556         Update pathFromSoupURI so it behaves more closely to the other
557         ports, and remove the unused code after we no longer print
558         <unknown> in certain cases. Also move
559         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
560         be used both in TestRunnerGtk and in DumpRenderTree.
561
562         * DumpRenderTree/gtk/DumpRenderTree.cpp:
563         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
564         we can print Soup URIs with the password, since soup_uri_to_string
565         doesn't preserve them.
566         (pathFromSoupURI): Updated following EFL implementation in
567         r153977, and return a WTFString instead of a CString.
568         (convertSoupMessageToURLPath): Return "(null)" instead of empty
569         strings, and handle the new return type of pathFromSoupURI.
570         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
571         reference, and handle the new return type of pathFromSoupURI.
572         (descriptionSuitableForTestResult): Remove unused code.
573         (didFinishLoading): Use convertResourceToURLPath.
574         (didFailLoadingWithError): Use convertResourceToURLPath.
575         (authenticationCallback): Display the URL of the authentication
576         challenge.
577         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
578         soupURIToStringPreservingPassword.
579         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
580         soupURIToStringPreservingPassword.
581
582 2013-08-14  Tim Horton  <timothy_horton@apple.com>
583
584         Un-inline dataLog dumpers for IntSize and IntPoint
585         https://bugs.webkit.org/show_bug.cgi?id=119697
586
587         Reviewed by Sam Weinig.
588
589         * TestWebKitAPI/GNUmakefile.am:
590
591 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
592
593         Flakiness dashboard build fix.
594
595         * TestResultServer/static-dashboards/flakiness_dashboard.js:
596         (processTestRunsForBuilder):
597
598 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
599
600         [GTK] [CMake] Add support for building TestWebKitAPI
601         https://bugs.webkit.org/show_bug.cgi?id=116987
602
603         Reviewed by Philippe Normand.
604
605         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
606         platform-specific file, so that GTK+ can override them.
607         * TestWebKitAPI/PlatformGTK.cmake: Added.
608
609 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
610
611         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
612         https://bugs.webkit.org/show_bug.cgi?id=119775
613
614         This bug updates the WinLauncher program with a few useful menu
615         options to toggle certain debugging and development features of
616         WebKit.
617
618         Reviewed by Tim Horton.
619
620         * WinLauncher/WinLauncher.cpp:
621         (dllLauncherEntryPoint): Clean up preference objects on exit.
622         (ToggleMenuItem): New function.
623         (LaunchInspector): New function.
624         (WndProc): Add handler for new menu items. Also properly terminate
625         CFRunLoop operation on program exit.
626         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
627         menu items.
628         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
629         resource folder to search path.
630         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
631         for new menu items.
632
633 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
634
635         Add a hyperlink from build.webkit.org to the flakiness dashboard.
636
637         Rubbers-tamped by Simon Fraser.
638
639         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
640
641 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
642
643         [Qt] Activate visibility API layout tests
644         https://bugs.webkit.org/show_bug.cgi?id=119790
645
646         Reviewed by Allan Sandfeld Jensen.
647
648         * DumpRenderTree/qt/TestRunnerQt.cpp:
649         (TestRunner::resetPageVisibility):
650         (TestRunner::setPageVisibility):
651
652 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
653
654         [GTK] WK does not link properly against libxslt
655         https://bugs.webkit.org/show_bug.cgi?id=119688
656
657         Reviewed by Gustavo Noronha Silva.
658
659         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
660         MiniBrowser.
661         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
662
663 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
664
665         [Mac] fast/dom/attr-style-too-lazy.html is flaky
666         https://bugs.webkit.org/show_bug.cgi?id=119763
667
668         Reviewed by Darin Adler.
669
670         * DumpRenderTree/mac/UIDelegate.mm:
671         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
672         a test, it would just semi-randomly leak to the next one.
673         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
674         for good measure.
675
676 2013-08-13  Tim Horton  <timothy_horton@apple.com>
677
678         [mac] Give MiniBrowser a reasonable bundle identifier
679         https://bugs.webkit.org/show_bug.cgi?id=119773
680
681         Rubber-stamped by Simon Fraser.
682
683         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
684
685         * MiniBrowser/mac/Info.plist:
686         * MiniBrowser/mac/WebBundle/Info.plist:
687
688 2013-08-13  Dean Jackson  <dino@apple.com>
689
690         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
691
692         Reviewed by Mark Rowe.
693
694         Have prepare-ChangeLog produce webkit.org/b/id style
695         URLs rather than exposing the inner workings of our
696         cgi. I was going to use the term "Future Proofing"
697         but that seems excessive :)
698
699         * Scripts/prepare-ChangeLog:
700         (main): Generate a more human readable form.
701         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
702
703 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
704
705         [EFL][DRT] Simplify call to reverseFind()
706         https://bugs.webkit.org/show_bug.cgi?id=119746
707
708         Reviewed by Christophe Dumez.
709
710         Follow-up to r153977.
711
712         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
713         (pathSuitableForTestResult): Instead of defining a static variable
714         that's only used in a single place, pass '/' to reverseFind() directly.
715
716 2013-08-13  Alberto Garcia  <berto@igalia.com>
717
718         [GTK] Closing inspector window crashes wk
719         https://bugs.webkit.org/show_bug.cgi?id=110865
720
721         Reviewed by Carlos Garcia Campos.
722
723         Disconnect all signal handlers if the inspector window is
724         destroyed.
725
726         * GtkLauncher/LauncherInspectorWindow.c:
727         (inspectorWindowDestroyed):
728         (launcherInspectorWindowNew):
729
730 2013-08-12  Dan Bernstein  <mitz@apple.com>
731
732         extract-localizable-strings output is not suited for parsing by Xcode
733         https://bugs.webkit.org/show_bug.cgi?id=119728
734
735         Reviewed by Darin Adler.
736
737         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
738         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
739         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
740         with 0).
741
742         * Scripts/extract-localizable-strings:
743
744 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
745
746         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
747         https://bugs.webkit.org/show_bug.cgi?id=119585
748
749         Reviewed by Gyuyoung Kim.
750
751         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
752         (pathSuitableForTestResult):
753         Return path string that's relative to main frame URL, or just file name if
754         the resource is not in the same directory subtree.
755         Referenced WebKitTestRunner code in r153852.
756         (descriptionSuitableForTestResult):
757         (DumpRenderTreeChrome::onFrameRedirectRequested):
758         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
759
760 2013-08-12  Dan Bernstein  <mitz@apple.com>
761
762         extract-localizable-strings doesn't know how to verify an existing strings file
763         https://bugs.webkit.org/show_bug.cgi?id=119704
764
765         Reviewed by Darin Adler.
766
767         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
768         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
769         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
770         the way directories to skip are specified from prefixing the directory with a “-” to
771         specifying it with --skip.
772         Finally, added a --verify option. When specified, the strings file is not written to, but
773         instead read in and checked for consistency with the comments, keys and values derived from
774         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
775         mismatching comments are reported as errors.
776         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
777         directories to skip and no exceptions file.
778
779 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
780
781         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
782         https://bugs.webkit.org/show_bug.cgi?id=85522
783
784         Reviewed by Andy Estes.
785
786         * DumpRenderTree/mac/UIDelegate.mm:
787         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
788         when already done with a test. We already had this check in all UI delegate functions,
789         except for -webView:addMessageToConsole:withSource: somehow.
790
791 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
792
793         https://bugs.webkit.org/show_bug.cgi?id=119693
794         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
795         because of connect-src-websocket-allowed.html
796
797         Reviewed by Darin Adler.
798
799         Starting a load of about:blank and immediately stopping it cancels outstanding
800         resource loads, but the page has to transition to committed state to have timers
801         or WebSockets stopped too.
802
803         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
804         ensure that transition to committed state happens before we start the next test.
805
806 2013-08-12  Beth Dakin  <bdakin@apple.com>
807
808         The LayoutMilestones didLayout callback should only fire for the main frame
809         https://bugs.webkit.org/show_bug.cgi?id=119457
810
811         Reviewed by Sam Weinig.
812
813         Now that the didLayout callback only fires for the main frame, we want to make 
814         sure it will fire even when all of the content is in a subframe.
815
816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
817         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
818         (TestWebKitAPI::didLayout):
819         (TestWebKitAPI::TEST):
820         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
821
822 2013-08-12  Beth Dakin  <bdakin@apple.com>
823
824         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
825         https://bugs.webkit.org/show_bug.cgi?id=119658
826
827         Reviewed by Darin Adler.
828
829         * MiniBrowser/mac/WK2BrowserWindowController.m:
830         (-[WK2BrowserWindowController awakeFromNib]):
831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
832         (WTR::InjectedBundlePage::InjectedBundlePage):
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::createWebViewWithOptions):
835
836 2013-08-12  Seokju Kwon  <seokju@webkit.org>
837
838         Remove glu's libtest rule from checker.py
839         https://bugs.webkit.org/show_bug.cgi?id=119674
840
841         Reviewed by Darin Adler.
842
843         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
844
845 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
846
847         Unreviewed. Change my primary mail address.
848
849         * Scripts/webkitpy/common/config/contributors.json:
850
851 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
852
853         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
854         https://bugs.webkit.org/show_bug.cgi?id=115751
855
856         Reviewed by Martin Robinson.
857
858         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
859         with yum.
860
861 2013-08-09  Beth Dakin  <bdakin@apple.com>
862
863         AX: Not able to use arrow keys to read text in a WK2 app
864         https://bugs.webkit.org/show_bug.cgi?id=119605
865         -and corresponding-
866         <rdar://problem/14281275>
867
868         Reviewed by Darin Adler.
869
870         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
871         to scroll. 
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
874         (TestWebKitAPI::didFinishLoadForFrame):
875         (TestWebKitAPI::didNotHandleKeyEventCallback):
876         (TestWebKitAPI::TEST):
877
878 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
879
880         Add support for KeyboardEvent.location attribute
881         https://bugs.webkit.org/show_bug.cgi?id=119326
882
883         Reviewed by Benjamin Poulain.
884
885         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
886
887         * DumpRenderTree/mac/EventSendingController.mm:
888         (-[EventSendingController keyDown:withModifiers:withLocation:]):
889         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
890         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
891         (-[EventSendingController handleEvent:]):
892         (-[EventSendingController fireKeyboardEventsToElement:]):
893
894 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
895
896         <unknown> is often dumped instead of path in test output
897         https://bugs.webkit.org/show_bug.cgi?id=119590
898
899         Reviewed by Anders Carlsson.
900
901         There were two reasons for <unknown>:
902         1. When delegate logging is enabled via a testRunner call, that obviously happens
903         after main resource load starts, so we don't record its URL.
904         2. Authentication delegate logging relied on URL recording, but it's only turned on
905         when enabling resource loading delegate logging, not auth one.
906
907         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
908         landed without posted rationale and unreviewed. Just undoing that change now.
909
910         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
911         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
912         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
913         (WTR::InjectedBundlePage::didInitiateLoadForResource):
914
915 2013-08-08  Alex Christensen  <achristensen@apple.com>
916
917         Windows build fixes.
918
919         Rubberstamped by Brent Fulgham.
920
921         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
922         Removed /SAFESEH link option which doesn't work with x64.
923
924 2013-08-08  Daniel Bates  <dabates@apple.com>
925
926         Add iOS support to run-javascriptcore-tests
927         https://bugs.webkit.org/show_bug.cgi?id=119602
928
929         Reviewed by Joseph Pecoraro.
930
931         Make run-javascriptcore-tests work for iOS WebKit.
932
933         * Scripts/run-javascriptcore-tests:
934
935 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
936
937         [WK2] loader/go-back-cached-main-resource.html fails
938         https://bugs.webkit.org/show_bug.cgi?id=116491
939
940         Reviewed by Tim Horton.
941
942         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
943         * DumpRenderTree/gtk/DumpRenderTree.cpp:
944         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
945         * DumpRenderTree/win/DumpRenderTree.cpp:
946         Added FIXMEs about making path printing normalization more compatible.
947
948         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
949         Return last path component in cases where we used to return a full path, which is
950         never desirable. Added a null check to basePath to prevent potentially getting
951         an Objective C exception.
952
953         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
954         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
955         for a currently loading one (which is different for tests that use multiple windows).
956         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
957         last path component as last fallback.
958         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
959         frame URL here, and it was potentially a wrong frame.
960         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
961         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
962         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
963         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
964         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
965
966 2013-08-08  Alex Christensen  <achristensen@apple.com>
967
968         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
969         https://bugs.webkit.org/show_bug.cgi?id=116125
970
971         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
972
973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
974         (WTR::pathSuitableForTestResult):
975         Changed string operations to match _drt_descriptionSuitableForTestResult.
976         (WTR::dumpRequestDescriptionSuitableForTestResult):
977         (WTR::dumpResponseDescriptionSuitableForTestResult):
978         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
979         (WTR::InjectedBundlePage::didInitiateLoadForResource):
980         (WTR::InjectedBundlePage::willSendRequestForFrame):
981         (WTR::InjectedBundlePage::didReceiveResponseForResource):
982         Pass the main frame's URL to pathSuitableForTestResult.
983         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
984         Added WKBundlePageRef to willPerformClientRedirectForFrame.
985
986 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
987
988         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
989         https://bugs.webkit.org/show_bug.cgi?id=119317
990
991         Reviewed by Tim Horton.
992         
993         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
994         the test to complete, which is not power friendly. Although DRT instances
995         are generally busy anyway, not sitting in a busy loop should free up some CPU
996         cycles for other instances of DRT.
997         
998         Editing tests continue to pass. All Java tests are skipped and were not
999         tested, but when run fail similarly with and without the patch.
1000
1001         * DumpRenderTree/mac/DumpRenderTree.mm:
1002         (dump):
1003         (runTest):
1004
1005 2013-08-07  Daniel Bates  <dabates@apple.com>
1006
1007         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
1008         <https://bugs.webkit.org/show_bug.cgi?id=119558>
1009
1010         Reviewed by Martin Robinson.
1011
1012         Currently we build the command line to execute jsDriver.pl twice so as to both
1013         print it to standard output and actually execute it. We should only build up
1014         this command line once. Moreover, we should print to standard output the actual
1015         command line that we are going to use including the GTK- and EFL-specific call
1016         to /Tools/jhbuild/jhbuild-wrapper.
1017
1018         * Scripts/run-javascriptcore-tests:
1019
1020 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
1021
1022         [EFL] REGRESSION after r153432: some accessibility tests crash.
1023         https://bugs.webkit.org/show_bug.cgi?id=119333
1024
1025         Reviewed by Darin Adler.
1026
1027         Use a RefPtr to store a reference to the parent element of
1028         an AccessibilityUIElement instead of the raw pointer, so we
1029         never derefence a function from an invalid pointer.
1030
1031         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1032         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
1033
1034 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
1035
1036         Unreviewed. Add myself as a committer.
1037
1038         * Scripts/webkitpy/common/config/contributors.json:
1039
1040 2013-08-04  Sam Weinig  <sam@webkit.org>
1041
1042         Remove support for HTML5 MicroData
1043         https://bugs.webkit.org/show_bug.cgi?id=119480
1044
1045         Reviewed by Anders Carlsson.
1046
1047         * Scripts/webkitperl/FeatureList.pm:
1048         * qmake/mkspecs/features/features.pri:
1049
1050 2013-07-23  David Farler  <dfarler@apple.com>
1051
1052         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
1053         https://bugs.webkit.org/show_bug.cgi?id=117762
1054
1055         Reviewed by Mark Rowe.
1056
1057         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1058         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1059         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1060         Add ASAN_OTHER_LDFLAGS.
1061         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1062         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1063         * Scripts/check-for-weak-vtables-and-externals:
1064         Ignore ___asan externals, these are populated by compiler-rt.
1065         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1066         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1067         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1068         Add ASAN_OTHER_LDFLAGS.
1069         * WebKitLauncher/Configurations/Base.xcconfig:
1070         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1071         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
1072         Add ASAN_OTHER_LDFLAGS.
1073         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1074         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1075         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1076         Add ASAN_OTHER_LDFLAGS.
1077         * asan/asan.xcconfig: Added.
1078         * asan/webkit-asan-ignore.txt: Added.
1079
1080 2013-08-05  Brian Holt  <brian.holt@samsung.com>
1081
1082         [GTK] Implement leak checking with valgrind
1083         https://bugs.webkit.org/show_bug.cgi?id=118785
1084
1085         Reviewed by Dirk Pranke.
1086
1087         Launch the DRT under Valgrind to generate xml files with details
1088         of leaks found.
1089
1090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1091         (parse_args):
1092         * Scripts/webkitpy/port/gtk.py:
1093         (GtkPort.__init__):
1094         (GtkPort.default_timeout_ms): Allow extra time to run under
1095         Valgrind.
1096         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1097         using environment variables.
1098
1099 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1100
1101         [EFL] REGRESSION after r153432: some accessibility tests crash.
1102         https://bugs.webkit.org/show_bug.cgi?id=119333
1103
1104         Reviewed by Gustavo Noronha Silva.
1105
1106         Add missing null-check to avoid dereferencing a non-existent parent.
1107
1108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1109         (WTR::attributesOfElement): Ditto.
1110
1111 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
1112
1113         Add --rmdir option to git svn dcommit
1114         https://bugs.webkit.org/show_bug.cgi?id=119398
1115
1116         Reviewed by Ryosuke Niwa.
1117
1118         Add this option tells git-svn to remove empty directories
1119         from the svn tree so they do not leave over there.
1120
1121         * Scripts/webkitpy/common/checkout/scm/git.py:
1122         (Git.push_local_commits_to_server):
1123
1124 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
1125
1126         [Windows] WebKit1 Fullscreen Video Play is Broken
1127         https://bugs.webkit.org/show_bug.cgi?id=119415
1128
1129         Reviewed by Jer Noble.
1130
1131         * WinLauncher/WinLauncher.cpp:
1132         (dllLauncherEntryPoint): Activate full screen mode via
1133         IWebPreferencesInternal interface.
1134
1135 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1136
1137         Unreviewed. Add an alternative address to show my affiliation in team.html.
1138
1139         * Scripts/webkitpy/common/config/contributors.json:
1140
1141 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1142
1143         Duplicate property names can cause test to fail
1144         https://bugs.webkit.org/show_bug.cgi?id=119399
1145
1146         Reviewed by Dirk Pranke.
1147
1148         This problem was noticed when porting the patch for
1149         http://wkb.ug/119357 to Blink: a test would fail because the converted
1150         and test property lists weren't the same length, but they contained
1151         all of the same property names. It looks like this is actually caused
1152         by a bug in converting the HTML, which is being currently rewritten.
1153         In the meantime, as long as this compares the number of unique
1154         properties, it makes the test more robust.
1155
1156         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1157         (verify_prefixed_properties):
1158
1159 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1160
1161         Unreviewed. Adding my expertise.
1162
1163         * Scripts/webkitpy/common/config/contributors.json:
1164
1165 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1166
1167         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1168
1169         * Scripts/webkitpy/common/config/contributors.json:
1170
1171 2013-08-01  Commit Queue  <commit-queue@webkit.org>
1172
1173         Unreviewed, rolling out r153518.
1174         http://trac.webkit.org/changeset/153518
1175         https://bugs.webkit.org/show_bug.cgi?id=119386
1176
1177         The Jhbuild dep bump of GTK+ is not actually required by
1178         layout testing, is causing pango dep problems (Requested by
1179         zdobersek on #webkit).
1180
1181         * gtk/jhbuild.modules:
1182
1183 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1184
1185         Unreviewed. Add myself as a committer.
1186
1187         * Scripts/webkitpy/common/config/contributors.json:
1188
1189 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
1190
1191         Unreviewed. Add myself as a committer.
1192
1193         * Scripts/webkitpy/common/config/contributors.json:
1194
1195 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
1196
1197         Unreviewed. Add myself as a committer.
1198
1199         * Scripts/webkitpy/common/config/contributors.json:
1200
1201 2013-08-01  Alberto Garcia  <berto@igalia.com>
1202
1203         Unreviewed. Add myself as a committer.
1204
1205         * Scripts/webkitpy/common/config/contributors.json:
1206
1207 2013-07-31  Seokju Kwon  <seokju@webkit.org>
1208
1209         Unreviewed. Add myself as a committer.
1210
1211         * Scripts/webkitpy/common/config/contributors.json:
1212
1213 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1214
1215         W3C test import script prefixes some properties that it shouldn't
1216         https://bugs.webkit.org/show_bug.cgi?id=119357
1217
1218         Reviewed by Dirk Pranke.
1219
1220         Some prefixed properties also have unprefixed implemetations, but when
1221         the implementations aren't identical, they aren't declared in
1222         CSSPropertyNames.in on the same line. This fixes the import script so
1223         that it catches all instances of prefixed properties that have an
1224         unprefixed variant, and does not add the prefix in those cases.
1225
1226         * Scripts/webkitpy/w3c/test_converter.py:
1227         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1228         the properties on every line and record if they are prefixed or not.
1229         Use this information to only return prefixed properties that do not
1230         have any unprefixed variant. The prefixed property list has also
1231         changed to not include the '-webkit-' prefix, making it much easier to
1232         do the comparison, and removing the need to remove the prefix later.
1233         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1234         longer needs to remove the '-webkit-' prefix, but needs to add it in
1235         the case where a property that needs a prefix is found.
1236         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1237         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1238         for '-webkit-' prefix, as it is no longer included in the properties
1239         in the prefixed property list.
1240
1241 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1242
1243         Update location of w3c shapes tests to reflect new import location
1244         https://bugs.webkit.org/show_bug.cgi?id=118156
1245
1246         Reviewed by Dirk Pranke.
1247
1248         Partial imports should not be imported to the same place as the full
1249         import, so this adds an option to allow importing to a different
1250         location than the default. In doing that, I found that imports from
1251         contributor directories didn't seem to be working correctly, so I
1252         updated the import to be smarter about both contributor directories
1253         and the test status directories. It should now be more likely that the
1254         script guesses the root directory properly.
1255
1256         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1257             script not working with the full set of contributors, as that is
1258             no longer true, and I didn't see a good way to keep that behavior.
1259             Also update documentation to properly explain what happens when a
1260             contributor dir is imported.
1261         (main): Attempt to find the proper repo dir by looking at the
1262             directory above the "test status" in the given path, this is still
1263             not exactly right, but is less error prone than just trimming.
1264         (parse_args): Add -d option to set the import directory.
1265         (TestImporter.__init__): Stop appending the subdirs to the
1266             destination_directory because it was making things more complex
1267             and isn't really needed.
1268         (TestImporter.update_test_status): Remove hardcoded strings and use
1269             the TEST_STATUS constants instead.
1270         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1271         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1272             support for new option.
1273         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1274
1275 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
1276
1277         [Windows] Winlauncher shouldn't look for Safari Install Directory
1278         https://bugs.webkit.org/show_bug.cgi?id=119351
1279
1280         Reviewed by Darin Adler.
1281
1282         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1283         the Safari install location. Instead, use the proper support
1284         library path for the build architecture.
1285
1286 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1287
1288         Update scripts to reference contributors.json instead of committers.py in messaging
1289         https://bugs.webkit.org/show_bug.cgi?id=119342
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         Change the scripts to point people to contributors.json instead of
1294         committers.py since the latter no longer contains the list of
1295         contributors.
1296
1297         * Scripts/webkitpy/common/config/committervalidator.py:
1298         (CommitterValidator._contributors_json_path):
1299         (CommitterValidator._flag_permission_rejection_message):
1300         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1301         (CommitterValidatorTest.test_flag_permission_rejection_message):
1302         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1303         (Bugzilla._commit_queue_flag):
1304         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1305         (WatchListParser._validate):
1306         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1307         (WatchListParserTest.test_cc_rule_with_invalid_email):
1308         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1309         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1310         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1311         (ValidateReviewer.run):
1312
1313 2013-07-31  Roger Fong  <roger_fong@apple.com>
1314
1315         Unreviewed. Re-enable WinEWS tests following r153527.
1316
1317         * Scripts/webkitpy/common/config/ews.json:
1318
1319 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1320
1321         Unreviewed: Adding myself to the committers' list.
1322
1323         * Scripts/webkitpy/common/config/contributors.json:
1324
1325 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1326
1327         [Qt] Build WebKit with C++11
1328         https://bugs.webkit.org/show_bug.cgi?id=119337
1329
1330         Reviewed by Csaba Osztrogonác.
1331
1332         Enable building with C++11.
1333
1334         * qmake/mkspecs/features/default_pre.prf:
1335         * qmake/mkspecs/features/unix/default_post.prf:
1336         * qmake/mkspecs/features/unix/default_pre.prf:
1337
1338 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1339
1340         [Qt] ASSERTS trigger in release builds
1341         https://bugs.webkit.org/show_bug.cgi?id=119336
1342
1343         Reviewed by Jocelyn Turcotte.
1344
1345         Ensure the qmake also defaults to release if no configuration is known.
1346
1347         * qmake/mkspecs/features/default_post.prf:
1348
1349 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
1350
1351         [texmap][GStreamer][GTK] composited video shows tearing
1352         https://bugs.webkit.org/show_bug.cgi?id=118253
1353
1354         Reviewed by Martin Robinson.
1355
1356         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1357         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1358         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1359
1360 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
1361
1362         Unreviewed: Adding myself to the committers' list.
1363
1364         * Scripts/webkitpy/common/config/contributors.json:
1365
1366 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1367
1368         Unreviewed, add my new email to contributors.json.
1369
1370         * Scripts/webkitpy/common/config/contributors.json:
1371
1372 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
1373
1374         [EFL] REGRESSION after r153439: layout tests do not run.
1375         https://bugs.webkit.org/show_bug.cgi?id=119240
1376
1377         Reviewed by Christophe Dumez.
1378
1379         Changed attribute name from check_xvfb to check_driver.
1380
1381         * Scripts/webkitpy/port/efl.py:
1382         (EflPort.check_sys_deps):
1383
1384 2013-07-29  Commit Queue  <commit-queue@webkit.org>
1385
1386         Unreviewed, rolling out r152860.
1387         http://trac.webkit.org/changeset/152860
1388         https://bugs.webkit.org/show_bug.cgi?id=119227
1389
1390         Disable WinEWS tests until tests stop crashing (Requested by
1391         rfong on #webkit).
1392
1393         * Scripts/webkitpy/common/config/ews.json:
1394
1395 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1396
1397         [GTK] Add WestonDriver, use it when appropriate
1398         https://bugs.webkit.org/show_bug.cgi?id=119100
1399
1400         Reviewed by Dirk Pranke.
1401
1402         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1403         and sets up an environment that enables the test runner to run inside it.
1404
1405         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1406         environment variable is set, that is when NRWT is being run under a Wayland display.
1407
1408         * Scripts/webkitpy/port/base.py:
1409         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1410         * Scripts/webkitpy/port/gtk.py:
1411         (GtkPort):
1412         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1413         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1414         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1415         instead of hard-coding the XvfbDriver class in the check.
1416         * Scripts/webkitpy/port/westondriver.py: Added.
1417         (WestonDriver):
1418         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1419         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1420         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1421         driver and then launches the driver in said environment, using the driver's Weston display.
1422         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1423         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1424         and returns the absolute path to it.
1425         * Scripts/webkitpy/port/xvfbdriver.py:
1426         (XvfbDriver.check_driver): Renamed from check_xvfb.
1427         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1428
1429 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1430
1431         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1432         https://bugs.webkit.org/show_bug.cgi?id=118967
1433
1434         Reviewed by Gustavo Noronha Silva.
1435
1436         Implemented AccessibilityUIElement::attributesOfChildren() both
1437         in DumpRenderTree and the WebKitTestRunner.
1438
1439         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1440         (AccessibilityUIElement::attributesOfChildren): Implemented.
1441
1442         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1443         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1444
1445 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1446
1447         [ATK] Implement allAttributes() for AccessibilityUIElement
1448         https://bugs.webkit.org/show_bug.cgi?id=118966
1449
1450         Reviewed by Gustavo Noronha Silva.
1451
1452         Implemented AccessibilityUIElement::allAttributes() both in
1453         DumpRenderTree and the WebKitTestRunner.
1454
1455         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1456         (getAtkAttributeSetAsString): Moved up in the file, and refactored
1457         to use StringBuilder and return a String instead of a gchar*.
1458         (roleToString): Changed not to return the "AXRole: " prefix, so
1459         we can use it as well from attributesOfElement().
1460         (attributesOfElement): New function to dump attributes for an object.
1461         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1462         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1463
1464         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1465         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1466         a String instead of a gchar*.
1467
1468         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1469         so we can use it as well from attributesOfElement().
1470         (WTF::attributesOfElement): New function to dump attributes for an object.
1471         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1472         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1473
1474 2013-07-29  Daniel Bates  <dabates@apple.com>
1475
1476         Add support infrastructure for iOS WebKit port
1477         https://bugs.webkit.org/show_bug.cgi?id=119168
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         Implement support infrastructure towards building iOS WebKit.
1482
1483         * Scripts/webkitdirs.pm:
1484         (xcodeSDKPlatformName): Added.
1485         (determineConfigurationProductDir):
1486         (builtDylibPathForName):
1487         (willUseIOSDeviceSDKWhenBuilding): Added.
1488         (willUseIOSSimulatorSDKWhenBuilding): Added.
1489         (isIOSWebKit): Added.
1490         (copyInspectorFrontendFiles):
1491
1492 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
1493
1494         CoordinatedGraphics: Add API to get and set the active state of a WebView
1495         https://bugs.webkit.org/show_bug.cgi?id=119067
1496
1497         Reviewed by Noam Rosenthal.
1498
1499         Added API tests for WKViewIsActive and WKViewSetIsActive.
1500
1501         * TestWebKitAPI/PlatformEfl.cmake:
1502         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1503         (TestWebKitAPI::didFinishLoadForFrame):
1504         (TestWebKitAPI::webProcessCrashed):
1505         (TestWebKitAPI::webProcessRelaunched):
1506         (TestWebKitAPI::TEST):
1507         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1508         Bundle added to allow crashing the WebProcess and testing the active state of a view
1509         under such condition.
1510         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1511         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1512
1513 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1514
1515         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1516         https://bugs.webkit.org/show_bug.cgi?id=119212
1517
1518         Reviewed by Carlos Garcia Campos.
1519
1520         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1521         variables that are not defined during the configuration process.
1522         * TestWebKitAPI/GNUmakefile.am: Ditto.
1523         * WebKitTestRunner/GNUmakefile.am: Ditto.
1524
1525 2013-07-28  Andy Estes  <aestes@apple.com>
1526
1527         Include <stdio.h> to declare perror()
1528         https://bugs.webkit.org/show_bug.cgi?id=119198
1529
1530         Reviewed by Andreas Kling.
1531
1532         Silences an implicit declaration warning.
1533
1534         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1535
1536 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1537
1538         [EFL] Bump required version of EFL to 1.7
1539         https://bugs.webkit.org/show_bug.cgi?id=119144
1540
1541         Reviewed by Christophe Dumez.
1542
1543         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1544
1545 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
1546
1547         WKTR should know about the JSC extensions to testRunner
1548         https://bugs.webkit.org/show_bug.cgi?id=119154
1549
1550         Reviewed by Mark Hahnenberg and Geoffrey Garen.
1551         
1552         This makes some fast/js tests pass.
1553
1554         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1556         (WTR::TestRunner::numberOfDFGCompiles):
1557         (WTR::TestRunner::neverInlineFunction):
1558         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1559
1560 2013-07-25  Mark Rowe  <mrowe@apple.com>
1561
1562         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1563
1564         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1565         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1566         so they pull the version out of the SDK.
1567
1568 2013-07-25  Anders Carlsson  <andersca@apple.com>
1569
1570         Localizable.strings generated by extract-localizable-strings should be UTF-8
1571         https://bugs.webkit.org/show_bug.cgi?id=119106
1572
1573         Reviewed by Mark Rowe.
1574
1575         Output strings as UTF-8.
1576
1577         * Scripts/extract-localizable-strings:
1578
1579 2013-07-25  Sam Weinig  <sam@webkit.org>
1580
1581         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1582         https://bugs.webkit.org/show_bug.cgi?id=119099
1583         <rdar://problem/13439291>
1584
1585         Reviewed by Enrica Casucci.
1586
1587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1589         (TestWebKitAPI::attributedString):
1590         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1591         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1592         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1593         (TestWebKitAPI::TEST_F):
1594         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1595         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1596         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1597         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1598         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
1599         to make adding more easier in the future.
1600
1601 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1602
1603         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1604         https://bugs.webkit.org/show_bug.cgi?id=118948
1605
1606         Reviewed by Sam Weinig.
1607         
1608         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1609           by exporting it as a function.
1610         
1611         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1612           it even if you know that you've already done so. See processIRDump.sh.
1613         
1614         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1615           runs it through ReducedFTL automatically. You typically want to say something like:
1616           
1617           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1618           ./processIRDump.sh --timing < jsc-output.txt
1619
1620         * ReducedFTL/ReducedFTL.c:
1621         (webkit_osr_exit):
1622         * ReducedFTL/combineModules.rb:
1623         * ReducedFTL/processIRDump.sh: Added.
1624
1625 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1626
1627         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1628         https://bugs.webkit.org/show_bug.cgi?id=118947
1629
1630         Reviewed by Dan Bernstein.
1631
1632         * Scripts/copy-webkitlibraries-to-product-directory:
1633
1634 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
1635
1636         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1637         https://bugs.webkit.org/show_bug.cgi?id=118647
1638
1639         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1640
1641         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1642         way that the FTL would.
1643         
1644         Also add a tool that combines multiple LLVM modules generated by FTL into a
1645         single module.
1646
1647         * ReducedFTL: Added.
1648         * ReducedFTL/ReducedFTL.c: Added.
1649         (usage):
1650         (currentTime):
1651         (MemorySection):
1652         (mmAllocateCodeSection):
1653         (mmAllocateDataSection):
1654         (mmApplyPermissions):
1655         (mmDestroy):
1656         (symbolLookupCallback):
1657         (main):
1658         * ReducedFTL/build.sh: Added.
1659         * ReducedFTL/combineModules.rb: Added.
1660
1661 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
1662
1663         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1664         for the "/" that is printed between engine counts.
1665
1666         * Scripts/display-profiler-output:
1667
1668 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
1669
1670         testRunner should have a way of disabling inlining of functions
1671         https://bugs.webkit.org/show_bug.cgi?id=116875
1672
1673         Reviewed by Mark Hahnenberg.
1674
1675         * DumpRenderTree/TestRunner.cpp:
1676         (neverInlineFunction):
1677         (TestRunner::staticFunctions):
1678
1679 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
1680
1681         testRunner should be able to tell you if a function is DFG compiled
1682         https://bugs.webkit.org/show_bug.cgi?id=116847
1683
1684         Reviewed by Mark Hahnenberg.
1685
1686         * DumpRenderTree/TestRunner.cpp:
1687         (numberOfDFGCompiles):
1688         (TestRunner::staticFunctions):
1689
1690 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
1691
1692         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1693         https://bugs.webkit.org/show_bug.cgi?id=116556
1694
1695         Reviewed by Oliver Hunt.
1696         
1697         This adds three new capabilities:
1698         
1699         - 'display' now accepts negative compilation indices, and allows specifying
1700           wildcard hashes combined with combination indices. Previously you could say
1701           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1702           latter would display every compilation. This improves this so that you can
1703           say 'display *-<index>-<engine>'. It also makes it so that you can give a
1704           negative index, which allows you to say things like 'display blah--1-dfg',
1705           which displays just the last DFG compilation. Also you can say
1706           'display *--1-dfg', which displays the last DFG compilation for each code
1707           block. I realize that this is kind of ugly, but gosh is it practical.
1708         
1709         - You can now say 'sort hash', which will henceforth sort all of the output
1710           by code hash rather than by the time when it was compiled. This means that
1711           if you're doing 'dispay *--1-dfg' and then want to diff the results against
1712           something else, you can ensure that this doesn't get confused just by
1713           changes in compilation order.
1714         
1715         - You can now say 'counts off', which will henceforth disable the display of
1716           execution counts from 'bytecode' and 'display'. This is also useful for
1717           diffs, since if you're trying to figure out why two compilations are
1718           different, they probably have radically different counts. 'counts off' gets
1719           this out of the output so that it doesn't confuse your diff.
1720         
1721         Note that to use this effectively you should also have a script that scrubs
1722         pointers from text so that the diff doesn't get confused by pointers. I'll
1723         post my elimptr script to the bug. Maybe at some point I'll integrate that
1724         into display-profiler-output.
1725         
1726         Put together this is pretty awesome. I was able to do the following:
1727         
1728         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1729         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1730         diff -u richards-serial.asm richards-concurrent.asm
1731         
1732         And this immediately told me that the reason why richards is slower in the
1733         concurrent compilation case is just that we end up compiling *tons* more
1734         functions, most of which are trivially inlineable. Basically, concurrent
1735         compilation breaks our previous heuristics for delaying compilation of
1736         inlineables just enough that they never trigger compilation. We should fix
1737         that in a separate bug.
1738
1739         * Scripts/display-profiler-output:
1740
1741 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
1742
1743         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1744
1745         Rubber stamped by Mark Rowe.
1746
1747         * Scripts/copy-webkitlibraries-to-product-directory:
1748
1749 2013-07-16  Oliver Hunt <oliver@apple.com>
1750
1751         Merge dfgFourthTier r148853
1752
1753     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1754
1755         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1756         https://bugs.webkit.org/show_bug.cgi?id=114933
1757
1758         Reviewed by Andy Estes.
1759         
1760         This makes it easy to get set up for tandem LLVM builds.
1761
1762         * Scripts/copy-webkitlibraries-to-product-directory:
1763
1764 2013-07-16  Oliver Hunt <oliver@apple.com>
1765
1766         Merge dfgFourthTier r148850
1767
1768     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1769
1770         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1771         https://bugs.webkit.org/show_bug.cgi?id=114926
1772
1773         Reviewed by Geoffrey Garen.
1774         
1775         If the LLVM libraries change, then touch a phony header, which will force relink
1776         of JavaScriptCore.
1777
1778         * Scripts/copy-webkitlibraries-to-product-directory:
1779         (unpackIfNecessary):
1780
1781 2013-07-16  Oliver Hunt <oliver@apple.com>
1782
1783         Merge dfgFourthTier r148848
1784
1785     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1786
1787         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1788         https://bugs.webkit.org/show_bug.cgi?id=114925
1789
1790         Reviewed by Geoffrey Garen.
1791         
1792         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1793         will also optionally build LLVM and quickly symlink LLVM's built products into
1794         the right places.
1795         
1796         Most WebKit and JSC hackers will want to rely on the checked-in already-built
1797         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1798         increasingly common use-case for me, and it may become a common use case for a
1799         handful of others. Currently, this is really painful: you first have to build
1800         LLVM, then you have to export-llvm-build (which takes a while), and then you
1801         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1802         variables are set to point to the thing you exported. The whole process loses
1803         track of dependencies very quickly: making a tiny change in LLVM requires
1804         packaging, and then unpackaging, a large number of potentially large headers and
1805         static libraries. Not only is this slow but it then causes the WebKit build
1806         system to rebuild anything that transitively includes any LLVM header, which is
1807         now quite a few files. While this sort of use pattern is still worthwhile if
1808         you're trying to package a binary drop and test it, it's not great if you're
1809         just trying to do experimental development that involves making small changes
1810         in both trees.
1811         
1812         This change fixes this use case while keeping the old use cases intact. You can
1813         do tandem development using one of two modes:
1814         
1815         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1816         the LLVM directory you're using. Once this is done, any invocation of a WebKit
1817         build via build-jsc or build-webkit will also build LLVM, and then quickly
1818         symlink things into place without perturbing dependency tracking.
1819         
1820         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1821         right off of the WebKit source tree, then the build system will automatically
1822         use this.
1823         
1824         Here's how this takes care of dependencies:
1825         
1826         Headers: the include/llvm and include/llvm-c directories are symlinked into
1827         $productsDir/usr/local/include. And then everything just works.
1828         
1829         Libraries: the build system detects, by reading LLVM's Makefile.config, which
1830         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1831         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1832         if they have changed, by checking both the modification time and also whether
1833         the last time we had a symlink, that symlink was from the same directory.
1834         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1835         but that build wasn't yet ranlib'd.
1836         
1837         One problem that this does not yet solve is that xcodebuild will not relink
1838         JavaScriptCore if the only thing that changed was the libraries. I will work
1839         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1840
1841         * Scripts/copy-webkitlibraries-to-product-directory:
1842         (unpackIfNecessary):
1843         (fileContains):
1844         (fileContentsEquals):
1845
1846 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
1847
1848         fourthTier: Update LLVM-related build scripts to copy generated headers as well
1849         https://bugs.webkit.org/show_bug.cgi?id=114551
1850
1851         Reviewed by Oliver Hunt.
1852         
1853         Also added the ability to use something other than bzip2 compression, since although
1854         it is great for checking things into the tree, it increases turn-around times when
1855         experimenting.
1856
1857         * Scripts/copy-webkitlibraries-to-product-directory:
1858         (unpackIfNecessary):
1859         * Scripts/export-llvm-build:
1860
1861 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
1862
1863         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1864         https://bugs.webkit.org/show_bug.cgi?id=113921
1865
1866         Reviewed by Oliver Hunt.
1867
1868         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1869         the export script to do this.
1870         
1871         * Scripts/export-llvm-build:
1872
1873 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1874
1875         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1876         https://bugs.webkit.org/show_bug.cgi?id=113452
1877
1878         Rubber stamped by Mark Hahnenberg.
1879
1880         * Scripts/copy-webkitlibraries-to-product-directory:
1881         * Scripts/export-llvm-build:
1882
1883 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1884
1885         fourthTier: FTL JIT should be able run some simple function
1886         https://bugs.webkit.org/show_bug.cgi?id=113481
1887
1888         Reviewed by Geoffrey Garen.
1889         
1890         Give the scripts the ability to find an LLVM build and use it.
1891         
1892         Also added a script, export-llvm-build, that allows you to take your
1893         own build of LLVM and package it for use by WebKit's build system.
1894         
1895         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1896         one for the library archives and one for the headers. It then unpacks
1897         them into your built products directory in a mannner that is mostly
1898         analogous to how WebKitSystemInterface works.
1899
1900         * Scripts/build-jsc:
1901         * Scripts/copy-webkitlibraries-to-product-directory:
1902         (unpackIfNecessary):
1903         (dittoHeaders):
1904         * Scripts/export-llvm-build: Added.
1905
1906 2013-07-24  Anders Carlsson  <andersca@apple.com>
1907
1908         Crash when calling WKPageGetProcessIdentifier after aborted process launch
1909         https://bugs.webkit.org/show_bug.cgi?id=119069
1910         <rdar://problem/14494064>
1911
1912         Reviewed by Andreas Kling.
1913
1914         Add a test.
1915
1916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1917         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1918         (TestWebKitAPI::didFinishLoadForFrame):
1919         (TestWebKitAPI::TEST):
1920
1921 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
1922
1923         Make KURL::hasPath private
1924         https://bugs.webkit.org/show_bug.cgi?id=118279
1925
1926         Reviewed by Darin Adler.
1927
1928         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1929         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1930
1931 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1932
1933         [GTK] TestInspectorServer unit test is timing out
1934         https://bugs.webkit.org/show_bug.cgi?id=105866
1935
1936         Reviewed by Gustavo Noronha Silva.
1937
1938         * Scripts/run-gtk-tests:
1939         (TestRunner):
1940
1941 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1942
1943         [GTK] [WK2] Handle wheel event with delta zero
1944         https://bugs.webkit.org/show_bug.cgi?id=118973
1945
1946         Reviewed by Gustavo Noronha Silva.
1947
1948         Added handling of zero mouse scroll deltas in EventSenderProxy similar
1949         to WK1 and Qt/EFL ports.
1950
1951         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1952         failing on WK2.
1953
1954         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1955         (WTR::EventSenderProxy::mouseScrollBy):
1956
1957 2013-07-23  Andreas Kling  <akling@apple.com>
1958
1959         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1960         <rdar://problem/14324895>
1961         <http://webkit.org/b/119023>
1962
1963         Reviewed by Simon Fraser.
1964
1965         Add a test for this rather specific problem.
1966
1967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1968         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1969         (TestWebKitAPI::TEST):
1970         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1971         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1972         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1973         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1974
1975 2013-07-23  Tim Horton  <timothy_horton@apple.com>
1976
1977         Add a test for plug-in unavailability indicator obscurity detection
1978         https://bugs.webkit.org/show_bug.cgi?id=119007
1979
1980         Reviewed by Anders Carlsson.
1981
1982         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1983
1984         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1985         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1986         (WTR::TestRunner::setBlockAllPlugins):
1987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1988         * WebKitTestRunner/TestInvocation.cpp:
1989         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1990         Add testRunner.setBlockAllPlugins function (and corresponding message to
1991         forward it through to TestController).
1992
1993         * WebKitTestRunner/TestController.cpp:
1994         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1995
1996         (WTR::TestController::createWebViewWithOptions):
1997         Register our pluginLoadPolicy callback.
1998
1999         (WTR::TestController::resetStateToConsistentValues):
2000         Reset m_shouldBlockAllPlugins to false.
2001
2002         (WTR::TestController::pluginLoadPolicy):
2003         Return the existing plugin load policy, unless setBlockAllPlugins(true)
2004         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
2005
2006         * WebKitTestRunner/TestController.h:
2007         (WTR::TestController::setBlockAllPlugins):
2008
2009 2013-07-21  Andreas Kling  <akling@apple.com>
2010
2011         KURL creates duplicate strings when completing data: URIs.
2012         <http://webkit.org/b/118952>
2013         <rdar://problem/14504480>
2014
2015         Reviewed by Anders Carlsson.
2016
2017         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2018         (TestWebKitAPI::TEST_F):
2019
2020 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
2021
2022         AX: VoiceOver not detecting misspelled words don't work in all cases
2023         https://bugs.webkit.org/show_bug.cgi?id=118924
2024
2025         Reviewed by Tim Horton.
2026
2027         Make the misspelled detection dependent on both types of attributes being present.
2028
2029         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2030         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2031         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2032         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2033
2034 2013-07-19  Alex Christensen  <achristensen@apple.com>
2035
2036         Improved code coverage generation.
2037         https://bugs.webkit.org/show_bug.cgi?id=118926
2038
2039         Reviewed by Tim Horton.
2040
2041         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
2042         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
2043         (generateReport): Moved report generation to a subroutine.
2044
2045 2013-07-19  Stephanie Lewis  <slewis@apple.com>
2046
2047         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
2048
2049         Unreviewed.
2050
2051         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
2052
2053         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2054         (TestWebKitAPI::didLayout):
2055
2056 2013-07-19  Daniel Bates  <dabates@apple.com>
2057
2058         Make Perl tools work when using git bisect with Git branch build setup
2059         https://bugs.webkit.org/show_bug.cgi?id=118512
2060
2061         Reviewed by Martin Robinson.
2062
2063         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
2064         during a git bisect session with a Git branch build setup (i.e. git config
2065         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
2066         specific build of WebKit because they cannot determine the branch Git is on (since
2067         git bisect puts Git into a detached HEAD state). We should teach our tooling to
2068         parse the file .git/BISECT_START (created by git bisect start) for the name of the
2069         branch Git was on when we began a git bisect session. Then the tools can determine
2070         the path to the built WebKit.
2071
2072         * Scripts/VCSUtils.pm:
2073         (gitDirectory): Added.
2074         (gitBisectStartBranch): Added.
2075         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
2076         HEAD (e.g. running git bisect).
2077         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2078         the .git directory in the Git checkout.
2079
2080 2013-07-19  Alex Christensen  <achristensen@apple.com>
2081
2082         Added x64 configuration to Visual Studio build.
2083         https://bugs.webkit.org/show_bug.cgi?id=118888
2084
2085         Reviewed by Brent Fulgham.
2086
2087         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2088         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2089         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2090         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2091         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2092         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2093         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2094         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2095         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2096         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2097         * win/record-memory/record-memory.vcxproj:
2098
2099 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
2100
2101         Add a couple people to the MathML watchlist
2102         https://bugs.webkit.org/show_bug.cgi?id=118909
2103
2104         Reviewed by Andreas Kling.
2105
2106         Add a couple people to the MathML watchlist and add Kalyan's other
2107         email address to fix style checker warnings about the watchlist
2108         contents.
2109
2110         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
2111         list of contributors and add Kalyan's second email address.
2112         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
2113         watchlist.
2114
2115 2013-07-19  Simon Pena  <simon.pena@samsung.com>
2116
2117         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
2118         https://bugs.webkit.org/show_bug.cgi?id=118895
2119
2120         Reviewed by Philippe Normand.
2121
2122         In r152782 an uri is used to create an string representation without checking first if it
2123         is valid. That fails later when the string is used to check for existing redirections. This
2124         patch ensures that the uri is valid before using it.
2125
2126         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2127         (willSendRequestCallback): Ensure an uri is valid before using it.
2128
2129 2013-07-18  Timothy Hatcher  <timothy@apple.com>
2130
2131         Add extract-localizable-js-strings and use it for WebInspectorUI.
2132
2133         https://bugs.webkit.org/show_bug.cgi?id=118851
2134
2135         Reviewed by Joseph Pecoraro.
2136
2137         * Scripts/extract-localizable-js-strings: Added.
2138         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
2139         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
2140         the WebInspectorUI project.
2141
2142 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2143
2144         [Windows] Build correction #2 after r152861.
2145
2146         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2147
2148 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2149
2150         [Windows] Build correction after r152861.
2151
2152         * WinLauncher/WinLauncher.cpp: Don't reference private header.
2153
2154 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
2155
2156         [Win] Support in-band text tracks.
2157         https://bugs.webkit.org/show_bug.cgi?id=103770
2158
2159         Reviewed by Eric Carlson.
2160
2161         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2162         libdispatch and CFRunLoop elements are services during the run loop.
2163
2164         * WinLauncher/WinLauncher.cpp:
2165         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2166         a CoreFoundation (or CFLite) support library.
2167         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2168         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2169         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2170         and WinLauncherCFLite.props.
2171
2172 2013-07-18  Roger Fong  <roger_fong@apple.com>
2173
2174         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2175
2176         * Scripts/webkitpy/common/config/ews.json:
2177
2178 2013-07-18  Daniel Bates  <dabates@apple.com>
2179
2180         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2181         https://bugs.webkit.org/show_bug.cgi?id=118854
2182         <rdar://problem/14081339>
2183
2184         Reviewed by David Kilzer.
2185
2186         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2187         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2188         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2189         listen on these ports so that we can run tests that use port 8443 and 8080.
2190
2191         * Scripts/old-run-webkit-tests:
2192         (configureAndOpenHTTPDIfNeeded):
2193
2194 2013-07-17  Tim Horton  <timothy_horton@apple.com>
2195
2196         Update blocked/missing plug-in UI
2197         https://bugs.webkit.org/show_bug.cgi?id=118347
2198         <rdar://problem/14209318>
2199
2200         Reviewed by Sam Weinig.
2201
2202         * MiniBrowser/mac/WK2BrowserWindowController.m:
2203         (-[WK2BrowserWindowController awakeFromNib]):
2204         * WebKitTestRunner/TestController.cpp:
2205         (WTR::TestController::createWebViewWithOptions):
2206         Match new WKPageLoaderClient entry.
2207
2208 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2209
2210         Unreviewed, rolling out r152701, r152703, r152739, r152754,
2211         and r152756.
2212         http://trac.webkit.org/changeset/152701
2213         http://trac.webkit.org/changeset/152703
2214         http://trac.webkit.org/changeset/152739
2215         http://trac.webkit.org/changeset/152754
2216         http://trac.webkit.org/changeset/152756
2217         https://bugs.webkit.org/show_bug.cgi?id=118821
2218
2219         this was a buggy fix and we're going to try something
2220         different (Requested by thorton on #webkit).
2221
2222         * MiniBrowser/mac/WK2BrowserWindowController.m:
2223         (-[WK2BrowserWindowController awakeFromNib]):
2224         * WebKitTestRunner/TestController.cpp:
2225         (WTR::TestController::createWebViewWithOptions):
2226
2227 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2228
2229         Unreviewed, rolling out r151535.
2230         http://trac.webkit.org/changeset/151535
2231         https://bugs.webkit.org/show_bug.cgi?id=118804
2232
2233         Re-disable WinEWS tests (Requested by rfong on #webkit).
2234
2235         * Scripts/webkitpy/common/config/ews.json:
2236
2237 2013-07-17  Simon Pena  <simon.pena@samsung.com>
2238
2239         [GTK] Make DRT obbey testRunner's addURLToRedirect
2240         https://bugs.webkit.org/show_bug.cgi?id=118239
2241
2242         Reviewed by Gustavo Noronha Silva.
2243
2244         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2245         to the proper URI when indicated.
2246
2247         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2248         (willSendRequestCallback):
2249
2250 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2251
2252         Add a new find-resolved-bugs command to webkit-patch.
2253         https://bugs.webkit.org/show_bug.cgi?id=118060
2254
2255         Reviewed by Csaba Osztrogonác.
2256
2257         * Scripts/webkitpy/tool/commands/queries.py:
2258         (PrintBaselines._platform_for_path):
2259         (FindResolvedBugs):
2260         (FindResolvedBugs.execute):
2261
2262 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
2263
2264         [CMake] Undefined references should be detected at build time
2265         https://bugs.webkit.org/show_bug.cgi?id=110236
2266
2267         Reviewed by Christophe Dumez.
2268
2269         Add library dependencies that were not defined explicitly before.
2270
2271         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2272         * TestWebKitAPI/CMakeLists.txt:
2273         * WebKitTestRunner/CMakeLists.txt:
2274
2275 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
2276
2277         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2278         https://bugs.webkit.org/show_bug.cgi?id=118755
2279
2280         Reviewed by Ryosuke Niwa.
2281
2282         Fix r152719 to check "using namespace foo;" only in headers.
2283
2284         * Scripts/webkitpy/style/checkers/cpp.py:
2285         (check_using_namespace):
2286         (check_style):
2287         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2288         (WebKitStyleTest.test_using_namespace):
2289
2290 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2291
2292         Get rid of multiple inheritance support from the bindings generators
2293         https://bugs.webkit.org/show_bug.cgi?id=118353
2294
2295         Reviewed by Kentaro Hara.
2296
2297         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2298         deprecated domInterface->parents.
2299
2300         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2301         (_parentInterface):
2302
2303 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2304
2305         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2306         https://bugs.webkit.org/show_bug.cgi?id=57241
2307
2308         Reviewed by Ryosuke Niwa.
2309
2310         Added check for "using namespace foo" and unit test.
2311
2312         * Scripts/webkitpy/style/checkers/cpp.py:
2313         (check_using_namespace):
2314         (check_style):
2315         (CppChecker):
2316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2317         (WebKitStyleTest.test_using_namespace):
2318
2319 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
2320
2321         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2322         https://bugs.webkit.org/show_bug.cgi?id=110222
2323
2324         Reviewed by Gustavo Noronha Silva.
2325
2326         Added handling of zero mouse scroll deltas in EventSender.
2327
2328         * DumpRenderTree/gtk/EventSender.cpp:
2329         (mouseScrollByCallback):
2330
2331 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2332
2333         webkitpy: replace urllib with urllib2 for downloading additional modules
2334         https://bugs.webkit.org/show_bug.cgi?id=118671
2335
2336         Reviewed by Ryosuke Niwa.
2337
2338         Urllib2 is available whereever urllib is, but has better proxy support.
2339
2340         * Scripts/webkitpy/common/system/autoinstall.py:
2341         (AutoInstaller._download_to_stream):
2342
2343 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
2344
2345         [ATK] Adds support for aria-haspopup property.
2346         https://bugs.webkit.org/show_bug.cgi?id=117834
2347
2348         Reviewed by Christophe Dumez.
2349
2350         Adds implementation for testing aria-haspopup property.
2351
2352         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2353         (getAttributeSetValueForId):
2354         (AccessibilityUIElement::stringAttributeValue):
2355         (AccessibilityUIElement::hasPopup):
2356         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2357         (WTR::getAttributeSetValueForId):
2358         (WTR::AccessibilityUIElement::stringAttributeValue):
2359         (WTR::AccessibilityUIElement::hasPopup):
2360
2361 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
2362
2363         [Qt] Replace Nokia references.
2364         https://bugs.webkit.org/show_bug.cgi?id=118728
2365
2366         Reviewed by Simon Hausmann.
2367
2368         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2369         (MiniBrowserApplication::MiniBrowserApplication):
2370         * QtTestBrowser/qttestbrowser.cpp:
2371         (LauncherApplication::LauncherApplication):
2372
2373 2013-07-15  Tim Horton  <timothy_horton@apple.com>
2374
2375         Update blocked/missing plug-in UI
2376         https://bugs.webkit.org/show_bug.cgi?id=118347
2377         <rdar://problem/14209318>
2378
2379         Reviewed by Sam Weinig.
2380
2381         * MiniBrowser/mac/WK2BrowserWindowController.m:
2382         (-[WK2BrowserWindowController awakeFromNib]):
2383         * WebKitTestRunner/TestController.cpp:
2384         (WTR::TestController::createWebViewWithOptions):
2385         Match new WKPageLoaderClient entry.
2386
2387 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
2388
2389         Update James Craig's email address.
2390
2391         * Scripts/webkitpy/common/config/contributors.json:
2392
2393 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
2394
2395         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2396         https://bugs.webkit.org/show_bug.cgi?id=118583
2397
2398         Reviewed by Christophe Dumez.
2399
2400         There're many fails on efl webkit2 API test if opengl is not available.
2401         So, add fallback to non-opengl evas engine.
2402
2403         * TestWebKitAPI/efl/PlatformWebView.cpp:
2404         (TestWebKitAPI::initEcoreEvas):
2405
2406 2013-07-15  Brian Holt  <brian.holt@samsung.com>
2407
2408         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2409         https://bugs.webkit.org/show_bug.cgi?id=118592
2410
2411         Reviewed by Martin Robinson.
2412
2413         Added a suppression for pylint false positives and a unit test.
2414
2415         * Scripts/webkitpy/style/checkers/python.py:
2416         (Pylinter):
2417         * Scripts/webkitpy/style/checkers/python_unittest.py:
2418         (PythonCheckerTest.test_check):
2419         (PythonCheckerTest):
2420         (PythonCheckerTest.test_pylint_false_positives):
2421         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2422         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2423         (test_popen):
2424
2425 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2426
2427         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2428         https://bugs.webkit.org/show_bug.cgi?id=115166
2429
2430         Reviewed by Philippe Normand.
2431
2432         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2433
2434 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
2435
2436         Unreviewed. Add an email address and update my domain of experts.
2437
2438         * Scripts/webkitpy/common/config/contributors.json:
2439
2440 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2441
2442         [jhbuild] Avoid restarting from scratch failed initial checkouts
2443         https://bugs.webkit.org/show_bug.cgi?id=118603
2444
2445         Reviewed by Martin Robinson.
2446
2447         If the initial checkout is interrupted midway (eg. because the internet
2448         connection went down) config files do not get generated and that causes
2449         the next checkout to start from scratch (the missing files cause the
2450         script to delete the build root and the downloaded sources).
2451
2452         By generating the files before invoking jhbuild, subsequent runs are able
2453         to start where the previous run left.
2454
2455         * Scripts/update-webkit-libs-jhbuild:
2456         (saveJhbuildMd5): invoke it before runJhbuild().
2457
2458 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
2459
2460         [Windows] Remove single-worker restriction on tests.
2461
2462         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2463
2464 2013-07-12  Commit Queue  <commit-queue@webkit.org>
2465
2466         Unreviewed, rolling out r152599.
2467         http://trac.webkit.org/changeset/152599
2468         https://bugs.webkit.org/show_bug.cgi?id=118612
2469
2470         This patch includes a failing unit test (Requested by
2471         mrobinson on #webkit).
2472
2473         * Scripts/webkitpy/style/checkers/python.py:
2474         (Pylinter):
2475         * Scripts/webkitpy/style/checkers/python_unittest.py:
2476         (PythonCheckerTest.test_check):
2477         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2478
2479 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2480
2481         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2482         https://bugs.webkit.org/show_bug.cgi?id=91223
2483
2484         Reviewed by Martin Robinson.
2485
2486         When run on a clean checkout, `build-webkit` complains that no
2487         GNUmakefile exists when trying to detect the previously configured
2488         architecture, but in this case there's no previous configuration so
2489         the warning is pointless.
2490
2491         * Scripts/webkitdirs.pm:
2492         (determineArchitecture): Redirect grep stderr to /dev/null.
2493
2494 2013-07-12  Brian Holt  <brian.holt@samsung.com>
2495
2496         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2497         https://bugs.webkit.org/show_bug.cgi?id=118592
2498
2499         Reviewed by Martin Robinson.
2500
2501         Added a suppression for pylint false positives and a unit test.
2502
2503         * Scripts/webkitpy/style/checkers/python.py:
2504         (Pylinter):
2505         * Scripts/webkitpy/style/checkers/python_unittest.py:
2506         (PythonCheckerTest.test_check):
2507         (PythonCheckerTest):
2508         (PythonCheckerTest.test_pylint_false_positives):
2509         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2510         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2511         (test_popen):
2512
2513 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
2514
2515         Unreviewed. Add myself as a committer.
2516
2517         * Scripts/webkitpy/common/config/contributors.json:
2518
2519 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
2520
2521         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2522         https://bugs.webkit.org/show_bug.cgi?id=118538
2523
2524         Reviewed by Christophe Dumez.
2525
2526         When attempting some odd url such as ``foo'', MiniBrowser will now show an
2527         error message such as "Cannot resolve hostname (foo)".
2528
2529         Previously, it had the following behavior if MiniBrowser was started with
2530         such urls, e.g ``./MiniBrowser foo'':
2531
2532         - Debug:
2533         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2534
2535         - Release:
2536         No asserts, naturally, but the view would remain blank, even if we tried to
2537         change to a valid url.
2538
2539         * MiniBrowser/efl/main.c:
2540         (window_create):
2541
2542 2013-07-10  Simon Pena  <simon.pena@samsung.com>
2543
2544         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2545         https://bugs.webkit.org/show_bug.cgi?id=118509
2546
2547         Reviewed by Martin Robinson.
2548
2549         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2550         when trying to remove an event already removed, if another event is
2551         processed in the middle. By using a Deque's takeFirst, we ensure the
2552         element is removed before we dispatch it.
2553
2554         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2555         crashes after this fix is added.
2556
2557         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2558         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2559         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2560         from the queue.
2561
2562 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
2563
2564         [EFL] Add ewk_view_device_pixel_ratio_set
2565         https://bugs.webkit.org/show_bug.cgi?id=118521
2566
2567         Reviewed by Gyuyoung Kim.
2568
2569         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2570         (windowCreate):
2571         (parseUserArguments):
2572
2573 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2574
2575         Unreviewed change of my email addresses.
2576         https://bugs.webkit.org/show_bug.cgi?id=100122
2577
2578         * Scripts/webkitpy/common/config/contributors.json:
2579
2580 2013-07-09  Anders Carlsson  <andersca@apple.com>
2581
2582         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2583         https://bugs.webkit.org/show_bug.cgi?id=118514
2584         <rdar://problem/13686836>
2585
2586         Reviewed by Sam Weinig.
2587
2588         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2589
2590         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2591         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2592         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2593         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2594         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2595
2596         * DumpRenderTree/mac/DumpRenderTree.mm:
2597         (allocateGlobalControllers):
2598         Allocate a DefaultPolicyDelegate object.
2599
2600         (resetWebViewToConsistentStateBeforeTesting):
2601         Set the policy delegate to the default policy delegate.
2602
2603         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2604         Declare the defaultPolicyDelegate object.
2605
2606         * DumpRenderTree/mac/TestRunnerMac.mm:
2607         (TestRunner::setCustomPolicyDelegate):
2608         Set the policy delegate to the default delegate if setDelegate is false.
2609
2610 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
2611
2612         KURL unit test fixture class should have a meaningful name
2613         https://bugs.webkit.org/show_bug.cgi?id=118467
2614
2615         Reviewed by Sam Weinig.
2616
2617         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2618         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2619         instead of the generic and inappropriate 'WebCore' name.
2620
2621 2013-07-08  Antti Koivisto  <antti@apple.com>
2622
2623         Add Deque::removeLast
2624         https://bugs.webkit.org/show_bug.cgi?id=118466
2625
2626         Reviewed by Andreas Kling.
2627
2628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2629         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2630         (TestWebKitAPI::TEST):
2631
2632 2013-07-08  Brian Holt  <brian.holt@samsung.com>
2633
2634         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2635         https://bugs.webkit.org/show_bug.cgi?id=118412
2636
2637         Reviewed by Martin Robinson.
2638
2639         An adoptRef is required to balance ref and deref calls.
2640
2641         * DumpRenderTree/gtk/EventSender.cpp:
2642         (beginDragWithFilesCallback):
2643
2644 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
2645
2646         Update list of EFL WK2 API tests
2647         https://bugs.webkit.org/show_bug.cgi?id=118443
2648
2649         Reviewed by Christophe Dumez.
2650
2651         The following tests were included:
2652
2653         Passing:
2654         - CloseThenTerminate
2655         - DidAssociateFormControls
2656         - PageVisibilityState
2657         - ResponsivenessTimerDoesntFireEarly
2658         - TerminateTwice
2659         - WillLoad
2660
2661         Failing:
2662         - ResizeReversePaginatedWebView
2663         - ScrollPinningBehaviors
2664
2665         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2666         alphabetical order.
2667
2668         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2669         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2670
2671 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2672
2673         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2674         https://bugs.webkit.org/show_bug.cgi?id=118439
2675         <rdar://problem/14366120>
2676
2677         Reviewed by Anders Carlsson.
2678
2679         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2680         (TestWebKitAPI::didLayout):
2681         (TestWebKitAPI::TEST):
2682         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2683         - Assert that we got the right number of pages for sanity.
2684         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2685             so much memory that SharedMemory asserts and makes the test time out.
2686         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2687             because paint doesn't fire if the window is offscreen.
2688
2689 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2690
2691         [wk2] Add API to lock the scroll position at the top or bottom of the page
2692         https://bugs.webkit.org/show_bug.cgi?id=118429
2693         <rdar://problem/14120323>
2694
2695         Reviewed by Anders Carlsson.
2696
2697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2698         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2699         (TestWebKitAPI::didFinishDocumentLoadForFrame):
2700         (TestWebKitAPI::TEST):
2701         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2702         all work correctly in the face of resizing the view and scrolling from JS.
2703
2704 2013-07-05  Michael Pruett  <michael@68k.org>
2705
2706         Unreviewed. Add myself as a committer.
2707
2708         * Scripts/webkitpy/common/config/contributors.json:
2709
2710 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2711
2712         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2713         https://bugs.webkit.org/show_bug.cgi?id=111434
2714
2715         Reviewed by Carlos Garcia Campos.
2716
2717         * Scripts/run-gtk-tests:
2718         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2719
2720 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
2721
2722         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2723         https://bugs.webkit.org/show_bug.cgi?id=118370
2724
2725         Reviewed by Christophe Dumez.
2726
2727         Add fallback to software X11 engine if opengl_x11 engine creation fails.
2728
2729         * DumpRenderTree/efl/DumpRenderTree.cpp:
2730         (initEcoreEvas):
2731
2732 2013-07-04  Brian Holt  <brian.holt@samsung.com>
2733
2734         [ATK] Leak: AtkAttributeSet* should be freed
2735         https://bugs.webkit.org/show_bug.cgi?id=118307
2736
2737         Reviewed by Christophe Dumez.
2738
2739         Fixed memory leaks for AtkAttributeSet by calling
2740         atk_attribute_set_free().
2741
2742         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2743         (AccessibilityController::childElementById):
2744         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2745         (getAtkAttributeSetAsString):
2746         (AccessibilityUIElement::allAttributes):
2747         (AccessibilityUIElement::stringAttributeValue):
2748         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2749         (WTR::childElementById):
2750         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2751         (WTR::getAtkAttributeSetAsString):
2752         (WTR::AccessibilityUIElement::allAttributes):
2753         (WTR::AccessibilityUIElement::stringAttributeValue):
2754
2755 2013-07-03  David Farler  <dfarler@apple.com>
2756
2757         Add Makefile to WebKitLauncher
2758         https://bugs.webkit.org/show_bug.cgi?id=118365
2759
2760         Reviewed by Mark Rowe.
2761
2762         * WebKitLauncher/Makefile: Added.
2763
2764 2013-07-03  Brian Holt  <brian.holt@samsung.com>
2765
2766         [ATK] Leak: more leaks in AccessibilityUIElement
2767         https://bugs.webkit.org/show_bug.cgi?id=118362
2768
2769         Reviewed by Christophe Dumez.
2770
2771         Free the memory created by g_strdup_printf.
2772
2773         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2774         (AccessibilityUIElement::language):
2775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2776         (WTR::AccessibilityUIElement::language):
2777
2778 2013-07-03  Jer Noble  <jer.noble@apple.com>
2779
2780         Xcode often gets in a state where the debugger is completely unresponsive
2781         https://bugs.webkit.org/show_bug.cgi?id=118157
2782
2783         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2784         Rather than pull the character data out of the debugger one byte at a time
2785         through the GetPointeeData() API, retrieve the memory contents of the string through
2786         the ReadMemory() API, and convert the retrieved memory into a python string.
2787
2788         Reviewed by Anders Carlsson.
2789
2790         * lldb/lldb_webkit.py:
2791         (__lldb_init_module.lldb_webkit):
2792         (guess_string_length):
2793         (ustring_to_string):
2794         (lstring_to_string):
2795
2796 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
2797
2798         [GTK] Let F5 refresh the page in MiniBrowser
2799         https://bugs.webkit.org/show_bug.cgi?id=117638
2800
2801         Reviewed by Carlos Garcia Campos.
2802
2803         Also use the correct icon for the refresh button that was already there.
2804
2805         * MiniBrowser/gtk/BrowserWindow.c:
2806         (browser_window_init):
2807
2808 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
2809
2810         Unreviewed. Add my email to a few watchlists.
2811
2812         * Scripts/webkitpy/common/config/watchlist:
2813
2814 2013-07-02  David Farler  <dfarler@apple.com>
2815
2816         Unreviewed. Adding myself to contributors.json.
2817
2818         * Scripts/webkitpy/common/config/contributors.json:
2819
2820 2013-07-02  Brian Holt  <brian.holt@samsung.com>
2821
2822         [ATK] Leak: leaks in AccessibilityUIElement
2823         https://bugs.webkit.org/show_bug.cgi?id=118297
2824
2825         Fixed memory leak.
2826
2827         Reviewed by Christophe Dumez.
2828
2829         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2830         (AccessibilityUIElement::stringValue):
2831
2832 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
2833
2834         Fix WebKitTestRunner crashes.
2835         https://bugs.webkit.org/show_bug.cgi?id=117630
2836
2837         Reviewed by Darin Adler.
2838
2839         Create static function to dump for WebProcess unresponsiveness status,
2840         and use it before calling TestController::runTest().
2841
2842         Accessing TestController::m_currentInvocation before calling
2843         TestController::runTest() can make crash because the invocation
2844         instance will be assigned at the function.
2845
2846         * WebKitTestRunner/TestController.cpp:
2847         (WTR::TestController::run):
2848         * WebKitTestRunner/TestInvocation.cpp:
2849         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2850         * WebKitTestRunner/TestInvocation.h:
2851
2852 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2853
2854         [Qt][WK1] Support WebGL with EGL on Linux
2855         https://bugs.webkit.org/show_bug.cgi?id=118251
2856
2857         Reviewed by Kenneth Rohde Christiansen.
2858
2859         * qmake/mkspecs/features/features.prf:
2860
2861 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
2862
2863         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2864         https://bugs.webkit.org/show_bug.cgi?id=118267
2865
2866         Reviewed by Gyuyoung Kim.
2867
2868         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2869         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2870         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2871
2872         * efl/jhbuildrc:
2873         * gtk/jhbuildrc:
2874
2875 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2876
2877         [GTK] Remove unsupported AC backends
2878         https://bugs.webkit.org/show_bug.cgi?id=117362
2879
2880         Reviewed by Martin Robinson.
2881
2882         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2883         and cogl, so removed.
2884
2885 2013-07-01  Timothy Hatcher  <timothy@apple.com>
2886
2887         Link to WebInspectorUI.framework at build time instead of soft linking.
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=118261
2890
2891         Reviewed by Joseph Pecoraro.
2892
2893         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2894
2895 2013-07-01  Tim Horton  <timothy_horton@apple.com>
2896
2897         Maximum scroll position can be negative in some cases
2898         https://bugs.webkit.org/show_bug.cgi?id=118175
2899         <rdar://problem/14301217>
2900
2901         Reviewed by Anders Carlsson.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2905         (TestWebKitAPI::didRunJavaScript):
2906         (TestWebKitAPI::didLayout):
2907         (TestWebKitAPI::TEST):
2908         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2909         Add a test that loads a vertical-lr document, paginates it horizontally
2910         from right to left, resizes the view to fit the entire document, and
2911         verifies that the scroll position is negative, as it must be for the
2912         document to be enclosed by the view.
2913
2914 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2915
2916         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2917         https://bugs.webkit.org/show_bug.cgi?id=117249
2918
2919         Reviewed by Brent Fulgham.
2920
2921         Finish converting all use cases of WEBKITOUTPUTDIR to
2922         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2923
2924         * DumpRenderTree/efl/FontManagement.cpp:
2925         (getCustomBuildDir):
2926         (getPlatformFontsPath):
2927         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2928         (getOutputDir):
2929         * Scripts/webkitdirs.pm:
2930         (determineBaseProductDir):
2931         (usesPerConfigurationBuildDirectory):
2932         * Scripts/webkitpy/port/base.py:
2933         (Port.to.setup_environ_for_server):
2934         * Scripts/webkitpy/port/driver.py:
2935         (Driver._setup_environ_for_driver):
2936         * Scripts/webkitpy/port/gtk.py:
2937         (GtkPort.setup_environ_for_server):
2938         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2939         (WTR::getOutputDir):
2940         * jhbuild/jhbuildutils.py:
2941         (get_dependencies_path):
2942
2943 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
2944
2945         Unreviewed change of my email address.
2946
2947         * Scripts/webkitpy/common/config/contributors.json:
2948
2949 2013-06-28  Andreas Kling  <akling@apple.com>
2950
2951         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2952
2953         * DumpRenderTree/win/DumpRenderTree.cpp:
2954         (addFontFallbackIfPresent):
2955         (removeFontFallbackIfPresent):
2956
2957 2013-06-28  Anders Carlsson  <andersca@apple.com>
2958
2959         Remove String::deprecatedCharactersWithNullTermination() and related code
2960         https://bugs.webkit.org/show_bug.cgi?id=118211
2961
2962         Reviewed by Benjamin Poulain.
2963
2964         Remove all hasTerminatingNullCharacter() checks.
2965
2966         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2967         (TestWebKitAPI::TEST):
2968         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2969         (TestWebKitAPI::TEST):
2970         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2971         (TestWebKitAPI::TEST):
2972
2973 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
2974
2975         [Mac] Crash when loading is stopped from -didReceiveResponse
2976         https://bugs.webkit.org/show_bug.cgi?id=118209
2977         <rdar://problem/14259249>
2978
2979         Reviewed by Brady Eidson.
2980
2981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2983         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2984         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2985         (TestWebKitAPI::TEST):
2986
2987 2013-06-28  Andy Estes  <aestes@apple.com>
2988
2989         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2990         https://bugs.webkit.org/show_bug.cgi?id=118208
2991
2992         Reviewed by Mark Rowe.
2993
2994         Newer versions of clang use a default template depth of 128, but this
2995         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2996         previous default.
2997
2998         Clang lowered the default to keep recursive template instantiation
2999         from overflowing the stack (see <rdar://problem/13935016>), but
3000         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
3001         higher limit. If for some reason this starts happening then we can
3002         lower the limit back down.
3003
3004         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
3005
3006 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
3007
3008         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
3009         https://bugs.webkit.org/show_bug.cgi?id=118195
3010
3011         Reviewed by Daniel Bates.
3012
3013         Currently, ports that use jhbuild fail to determine jhbuild directory
3014         when "webKitBranchBuild" git configuration property is enabled. To reproduce
3015         that issue in Efl port, enable that flag in .git/config, switch to a git branch
3016         other than "master" and try to build webkit. The build will fail to
3017         locate dependencies due to lack of pkg-config paths which should be set
3018         by jhbuild.
3019
3020         For more details about "webKitBranchBuild" option, see:
3021         https://trac.webkit.org/wiki/UsingGitWithWebKit
3022
3023         * Scripts/webkitdirs.pm:
3024         (getJhbuildPath):
3025
3026 2013-06-28  Jessie Berlin  <jberlin@apple.com>
3027
3028         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
3029         https://bugs.webkit.org/show_bug.cgi?id=118201
3030
3031         Reviewed by Dean Jackson.
3032
3033         * WebKitTestRunner/mac/main.mm:
3034         (main):
3035         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
3036         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
3037
3038 2013-06-28  David Farler  <dfarler@apple.com>
3039
3040         Upstream WebKit Nightly’s WebKitLauncher
3041         https://bugs.webkit.org/show_bug.cgi?id=117418
3042
3043         Reviewed by Mark Rowe.
3044
3045         Literal patch from Nightly's OpenSource repo.
3046
3047         * WebKitLauncher/Configurations/Base.xcconfig:
3048         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
3049         * WebKitLauncher/Info.plist:
3050         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3051         * WebKitLauncher/WebKitLauncherURLProtocol.m:
3052         (+[WebKitLauncherURLProtocol load]):
3053         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
3054         (-[WebKitLauncherURLProtocol startLoading]):
3055         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
3056         (-[WebKitLauncherURLProtocol resourceNotFound]):
3057         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3058         (initializeSparkle):
3059         * WebKitLauncher/main.m:
3060         (determineExecutablePath):
3061         (currentMacOSXVersion):
3062         (main):
3063         * WebKitLauncher/start.html:
3064
3065 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
3066
3067         [EFL] back/forward keyboard shortcuts are non-intuitive
3068         https://bugs.webkit.org/show_bug.cgi?id=118193
3069
3070         Reviewed by Christophe Dumez.
3071
3072         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
3073
3074         * EWebLauncher/main.c:
3075         (on_key_down):
3076         * MiniBrowser/efl/main.c:
3077         (on_key_down):
3078
3079 2013-06-28  Roger Fong  <roger_fong@apple.com>
3080
3081         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3082         https://bugs.webkit.org/show_bug.cgi?id=118194.
3083
3084         Reviewed by Brent Fulgham.
3085
3086         * DumpRenderTree/win/DumpRenderTree.cpp:
3087         (dllLauncherEntryPoint):
3088         * WinLauncher/WinLauncher.cpp:
3089         (dllLauncherEntryPoint):
3090
3091 2013-06-28  Roger Fong  <roger_fong@apple.com>
3092
3093         Unreviewed build fix for AppleWin port. Fix some file paths.
3094
3095         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3096         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3097
3098 2013-06-27  Roger Fong  <roger_fong@apple.com>
3099
3100         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
3101         https://bugs.webkit.org/show_bug.cgi?id=118160.
3102
3103         Reviewed by Brent Fulgham.
3104
3105         * WinLauncher/AccessibilityDelegate.cpp: Added.
3106         (AccessibilityDelegate::QueryInterface):
3107         (AccessibilityDelegate::AddRef):
3108         (AccessibilityDelegate::Release):
3109         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
3110         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
3111         * WinLauncher/AccessibilityDelegate.h: Added.
3112         (AccessibilityDelegate::AccessibilityDelegate):
3113         * WinLauncher/WinLauncher.cpp:
3114         (dllLauncherEntryPoint):
3115         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3116         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3117
3118 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3119
3120         Clean up temporary files created by the bindings test script
3121         https://bugs.webkit.org/show_bug.cgi?id=118189
3122
3123         Reviewed by Kentaro Hara.
3124
3125         Remove temporary files created by preprocess-idls.pl script after
3126         the bindings tests are executed.
3127
3128         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
3129
3130         * Scripts/webkitpy/bindings/main.py:
3131         (BindingsTests.main):
3132
3133 2013-06-26  Dean Jackson  <dino@apple.com>
3134
3135         [Mac] Add Mavericks system font to Test systems
3136         https://bugs.webkit.org/show_bug.cgi?id=118109
3137
3138         Reviewed by Simon Fraser.
3139
3140         OS X Mavericks uses a different font for system controls. Tell DRT and
3141         WKTR about them otherwise they use a fallback font. Unfortunately the
3142         fonts are hidden (not found in the list of available fonts) so I
3143         had to add them manually.
3144
3145         Even though there is only one at the moment, I implemented this
3146         as a set so it will be easier to add new fonts if necessary.
3147
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         (allowedFontFamilySet): Fixed typo.
3150         (systemHiddenFontFamilySet): New method that returns the system control font.
3151         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3152         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3153         (WTR::allowedFontFamilySet): Fixed typo.
3154         (WTR::systemHiddenFontFamilySet): As above.
3155         (WTR::wtr_NSFontManager_availableFonts):
3156
3157 2013-06-27  Anders Carlsson  <andersca@apple.com>
3158
3159         Get rid of the last uses of deprecatedCharactersWithNullTermination()
3160         https://bugs.webkit.org/show_bug.cgi?id=118159
3161
3162         Reviewed by Andreas Kling.
3163
3164         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3165
3166         * DumpRenderTree/win/DumpRenderTree.cpp:
3167         (findFontFallback):
3168
3169 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
3170
3171         Sync up w3c import script with changes in Blink
3172         https://bugs.webkit.org/show_bug.cgi?id=118149
3173
3174         Reviewed by Dirk Pranke.
3175
3176         This is a port of the following blink changes:
3177
3178         https://codereview.chromium.org/15366004
3179         https://chromiumcodereview.appspot.com/15592005
3180         https://codereview.chromium.org/16021006
3181         https://codereview.chromium.org/15590004
3182         https://codereview.chromium.org/15901008
3183         https://codereview.chromium.org/16171009
3184         https://codereview.chromium.org/16465007
3185         https://codereview.chromium.org/15981013
3186
3187         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3188         (setUp):
3189         (test_commit_message_for_this_commit):
3190         * Scripts/webkitpy/port/base.py:
3191         (Port):
3192         * Scripts/webkitpy/port/test.py:
3193         * Scripts/webkitpy/w3c/test_converter.py:
3194         (W3CTestConverter.__init__):
3195         (W3CTestConverter.read_webkit_prefixed_css_property_list):
3196         (W3CTestConverter.convert_for_webkit):
3197         (W3CTestConverter.convert_css):
3198         (W3CTestConverter.convert_html):
3199         (W3CTestConverter.convert_testharness_paths):
3200         (W3CTestConverter.convert_prefixed_properties):
3201         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3202         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3203         * Scripts/webkitpy/w3c/test_importer.py:
3204         (main):
3205         (configure_logging):
3206         (configure_logging.LogHandler):
3207         (configure_logging.LogHandler.format):
3208         (parse_args):
3209         (TestImporter.__init__):
3210         (TestImporter.find_importable_tests):
3211         (TestImporter.import_tests):
3212         (TestImporter.setup_destination_directory):
3213         (TestImporter.remove_deleted_files):
3214         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3215         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3216         (TestImporterTest.test_import_dir_with_no_tests):
3217         (TestImporterTest):
3218         * Scripts/webkitpy/w3c/test_parser.py:
3219         (TestParser.load_file):
3220         (TestParser.analyze_test):
3221         (TestParser.support_files):
3222         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3223
3224 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
3225
3226         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3227         https://bugs.webkit.org/show_bug.cgi?id=118128
3228
3229         Reviewed by Ryosuke Niwa.
3230
3231         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3232         https://bugs.webkit.org/show_bug.cgi?id=117831
3233
3234         * Scripts/webkitpy/tool/commands/download.py:
3235         (AbstractPatchSequencingCommand):
3236         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3237         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3238         (AbstractPatchSequencingCommand._prepare_state): Added.
3239
3240 2013-06-27  Brendan Long  <b.long@cablelabs.com>
3241
3242         [Qt] Build overrides -j when given --makeargs="-sj40"
3243         https://bugs.webkit.org/show_bug.cgi?id=116897
3244
3245         Reviewed by Csaba Osztrogonác.
3246
3247         * Scripts/webkitdirs.pm:
3248         (buildQMakeProjects):
3249         Change regex checking for -j* to also check for -*j*
3250
3251 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3252
3253         Remove [NoInterfaceObject] from WorkerGlobalScope
3254         https://bugs.webkit.org/show_bug.cgi?id=118071
3255
3256         Reviewed by Kentaro Hara.
3257
3258         Update bindings test script to pass 2 additional parameters
3259         now needed by the preprocess-idls.pl script.
3260
3261         * Scripts/webkitpy/bindings/main.py:
3262         (BindingsTests.generate_supplemental_dependency):
3263         (BindingsTests.main):
3264
3265 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3266
3267         Fixing some compiler warnings
3268         https://bugs.webkit.org/show_bug.cgi?id=117791
3269
3270         Reviewed by Martin Robinson.
3271
3272         * GNUmakefile.am: Silenced format warning.
3273         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3274         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3275         Solved warning about uninitialized variable.
3276
3277 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3278
3279         Fix bindings tests after r152080
3280         https://bugs.webkit.org/show_bug.cgi?id=118118
3281
3282         Reviewed by Gyuyoung Kim.
3283
3284         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3285         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3286         accordingly.
3287
3288         * Scripts/webkitpy/bindings/main.py:
3289         (BindingsTests.generate_supplemental_dependency):
3290         (BindingsTests.main):
3291
3292 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
3293
3294         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3295         https://bugs.webkit.org/show_bug.cgi?id=117982
3296
3297         Reviewed by Rob Buis.
3298
3299         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3300         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3301         m_policyDelegateIsPermissive.
3302         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3303         Reset m_policyDelegateIsPermissive.
3304         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3305         m_policyDelegateIsPermissive.
3306         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3307         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3308         Return whether custom policy is enabled.
3309         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3310         Return whether custom policy is permissive.
3311
3312 2013-06-26  Anders Carlsson  <andersca@apple.com>
3313
3314         Deprecate StringImpl::charactersWithNullTermination
3315         https://bugs.webkit.org/show_bug.cgi?id=118108
3316
3317         Reviewed by Beth Dakin.
3318
3319         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3320
3321         * DumpRenderTree/win/DumpRenderTree.cpp:
3322         (findFontFallback):
3323         (addFontFallbackIfPresent):
3324         (removeFontFallbackIfPresent):
3325
3326 2013-06-26  Nico Weber  <thakis@chromium.org>
3327
3328         Remove detect-mismached-virtual-const.
3329         https://bugs.webkit.org/show_bug.cgi?id=117999
3330
3331         Reviewed by Anders Carlsson.
3332
3333         Clang warns on mismatched virtual const, so there's no need for this
3334         script any more.
3335
3336         * Scripts/detect-mismatched-virtual-const: Removed.
3337
3338 2013-06-26  Alex Christensen  <achristensen@apple.com>
3339
3340         Added a code coverage report.
3341         https://bugs.webkit.org/show_bug.cgi?id=117941
3342
3343         Reviewed by Joseph Pecoraro.
3344
3345         * CodeCoverage: Added.
3346         * CodeCoverage/results-template.html: Added.
3347         * Scripts/generate-coverage-data: Generate and open the new report.
3348
3349 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3350
3351         gdb: Remove the webcore.py pretty printer.
3352         https://bugs.webkit.org/show_bug.cgi?id=117992
3353
3354         Reviewed by Jochen Eisinger.
3355
3356         webcore.py has been only a placeholder for backwards compatibility
3357         for almost 3 years. It should be safe enough to remove it now.
3358
3359         * gdb/webcore.py: Removed.
3360
3361 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
3362
3363         Creating cURL watchlist and adding myself to it.
3364
3365         Reviewed by Csaba Osztrogonác.
3366
3367         * Scripts/webkitpy/common/config/watchlist:
3368
3369 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3370
3371         Unreviewed, change my email address for watch list.
3372
3373         * Scripts/webkitpy/common/config/watchlist:
3374
3375 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
3376
3377         [EFL] Add a script to install dependencies.
3378         https://bugs.webkit.org/show_bug.cgi?id=117968
3379
3380         Reviewed by Christophe Dumez.
3381
3382         Add a script which installs basic dependencies for building WebKit EFL.
3383
3384         The dependencies are from the current EFLWebKit wiki page.
3385         After this patch is landed, the wiki page will be updated to use
3386         this script.
3387
3388         * efl/install-dependencies: Added.
3389
3390 2013-06-24  Dean Jackson  <dino@apple.com>
3391
3392         [Mac] Update font used for Chinese in test systems
3393         https://bugs.webkit.org/show_bug.cgi?id=117970
3394
3395         Reviewed by Alexey Proskuryakov.
3396
3397         Add "Songti TC" and "Songti SC" to the list of allowed fonts
3398         in DRT and WKTR.
3399
3400         * DumpRenderTree/mac/DumpRenderTree.mm:
3401         (allowedFontFamilySet):
3402         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3403         (WTR::allowedFontFamilySet):
3404
3405 2013-06-24  Tim Horton  <timothy_horton@apple.com>
3406
3407         Make MiniBrowser paginated mode work with WebKit1
3408         https://bugs.webkit.org/show_bug.cgi?id=117950
3409
3410         Reviewed by Beth Dakin.
3411
3412         * MiniBrowser/mac/WK1BrowserWindowController.m:
3413         (-[WK1BrowserWindowController isPaginated]):
3414         (-[WK1BrowserWindowController togglePaginationMode:]):
3415         Hook up isPaginated and togglePaginationMode just as for WebKit2.
3416
3417 2013-06-24  David Kilzer  <ddkilzer@apple.com>
3418
3419         bisect-builds: improve heuristic for choosing the next build after a broken build
3420         <http://webkit.org/b/117918>
3421
3422         Reviewed by Simon Fraser.
3423
3424         * Scripts/bisect-builds: When a build is broken, use a heuristic
3425         that "bisects" the left side or the right side of the remaining
3426         revisions to pick a revision that's sufficiently different from
3427         the revision of the broken build.  This heuristic assumes there
3428         is a sequential range of broken builds whenever one broken build
3429         is found.
3430
3431 2013-06-24  Chris Rogers  <crogers@google.com>
3432
3433         WaveTable name has changed to PeriodicWave
3434         https://bugs.webkit.org/show_bug.cgi?id=117748
3435
3436         Reviewed by Jer Noble.
3437
3438         * Scripts/do-webcore-rename:
3439
3440 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
3441
3442         [EFL] Add support for MHTML save/load feature to MiniBrowser
3443         https://bugs.webkit.org/show_bug.cgi?id=106620
3444
3445         Reviewed by Christophe Dumez.
3446
3447         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3448         from filesystem.
3449
3450         * MiniBrowser/efl/CMakeLists.txt:
3451         * MiniBrowser/efl/main.c:
3452         (page_contents_callback):
3453         (on_key_down):
3454         (show_file_entry_dialog): generic function to show file enrty
3455         selector dialogue
3456
3457 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
3458
3459         [Windows] Unreviewed crash protection for DRT
3460
3461         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3462         to avoid crashing during test runs.
3463
3464 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3465
3466         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3467         https://bugs.webkit.org/show_bug.cgi?id=117825
3468
3469         Reviewed by Kentaro Hara.
3470
3471         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3472
3473         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3474         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3475         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3476         (TestRunner::overridePreference):
3477
3478 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
3479
3480         [ATK] Added support for aria-required attribute.
3481         https://bugs.webkit.org/show_bug.cgi?id=117730
3482
3483         Reviewed by Chris Fleizach.
3484
3485         Added support for testing aria-required attribute.
3486
3487         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3488         (AccessibilityUIElement::isRequired):
3489         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3490         (WTR::AccessibilityUIElement::isRequired):
3491
3492 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
3493
3494         [CMAKE][EFL] Enable DOM4 Events Constructor
3495         https://bugs.webkit.org/show_bug.cgi?id=117858
3496
3497         Reviewed by Laszlo Gombos.
3498
3499         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3500
3501 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3502
3503         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3504         https://bugs.webkit.org/show_bug.cgi?id=117827
3505
3506         Reviewed by Rob Buis.
3507
3508         Reset the passed in request if willSendRequestReturnsNull() is
3509         true or willSendRequestReturnsNullOnRedirect() is true and it's a
3510         redirection.
3511
3512         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3513         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3514         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3515
3516 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
3517
3518         Commit queue shouldn't reopen unrelated bugs because of flakiness
3519         https://bugs.webkit.org/show_bug.cgi?id=117503
3520
3521         Reviewed by Ryosuke Niwa.
3522
3523         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3524         (_follow_duplicate_chain):
3525         (_update_bug_for_flaky_test):
3526
3527 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
3528
3529         [Windows] AX: Expand notification support.
3530         https://bugs.webkit.org/show_bug.cgi?id=117761
3531
3532         Reviewed by Anders Carlsson.
3533
3534         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3535         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3536         (AccessibilityUIElement::press): Provide implementation.
3537
3538 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
3539
3540         Use the PlatformEvent timestamp when creating a DOM Event
3541         https://bugs.webkit.org/show_bug.cgi?id=117179
3542
3543         Reviewed by Darin Adler.
3544
3545         * WebKitTestRunner/mac/EventSenderProxy.mm:
3546         (WTR::EventSenderProxy::mouseDown):
3547         (WTR::EventSenderProxy::mouseUp):
3548         (WTR::EventSenderProxy::mouseMoveTo):
3549         (WTR::EventSenderProxy::keyDown):
3550
3551 2013-06-18  Alex Christensen  <achristensen@apple.com>
3552
3553         Working on coverage script, added xml to json data extraction script.
3554         https://bugs.webkit.org/show_bug.cgi?id=117648
3555
3556         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
3557         coverage data, runs the tests, and collects all of the data in json format.
3558
3559         Reviewed by Stephanie Lewis.
3560
3561         * Scripts/generate-coverage-data:
3562         (parseGcovrOutput):
3563         (getFileHitsAndBranches):
3564         (addLineCounts):
3565         (createResultName):
3566         * Scripts/webkitpy/tool/gcovr: Added.
3567
3568 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
3569
3570         Unreviewed build fix after r151699.
3571
3572         * TestWebKitAPI/CMakeLists.txt:
3573         * WebKitTestRunner/CMakeLists.txt:
3574         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3575
3576 2013-06-18  Roger Fong  <roger_fong@apple.com>
3577
3578         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3579         <rdar://problem/14118143>.
3580
3581         Rubberstamped by Brent Fulgham.
3582
3583         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3584         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3585         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3586         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3587         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3588         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3589         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3590         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3591         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3592         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3593         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3594         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3595         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3596         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3597         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3598         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3599         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3600         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3601         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3602         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3603         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3604         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3605         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3606         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3607         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3608         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3609         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3610         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3611         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3612         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3613         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3614         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3615         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3616         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3617         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3618         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3619         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3620         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3621         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3622         * win/record-memory/record-memory.vcxproj:
3623         * win/record-memory/record-memoryDebug.props:
3624         * win/record-memory/record-memoryDebugWinCairo.props:
3625         * win/record-memory/record-memoryProduction.props:
3626         * win/record-memory/record-memoryRelease.props:
3627         * win/record-memory/record-memoryReleaseWinCairo.props:
3628
3629 2013-06-17  Kangil Han  <kangil.han@samsung.com>
3630
3631         Unreviewed. Add my email to a DOM watchlist.
3632
3633         * Scripts/webkitpy/common/config/watchlist:
3634
3635 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
3636
3637         Unreviewed GTK gardening.
3638
3639         * Scripts/run-gtk-tests:
3640         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3641
3642 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
3643
3644         Unreviewed. Reorder my email addresses.
3645         https://bugs.webkit.org/show_bug.cgi?id=100122
3646
3647         * Scripts/webkitpy/common/config/contributors.json:
3648
3649 2013-06-14  Enrica Casucci  <enrica@apple.com>
3650
3651         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3652         https://bugs.webkit.org/show_bug.cgi?id=117647
3653         <rdar://problem/13881024>
3654
3655         Reviewed by Darin Adler.
3656         
3657         The test now uses content with a selection and tests both
3658         forwards and backward find as well as the case of a find
3659         that has no matches after the user selection.
3660
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3663         (TestWebKitAPI::didFindStringMatches):
3664         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3665
3666 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@