[chromium] rename newwtf target back to wtf
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-23  Tony Chang  <tony@chromium.org>
2
3         [chromium] rename newwtf target back to wtf
4         https://bugs.webkit.org/show_bug.cgi?id=82064
5
6         Reviewed by Adam Barth.
7
8         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9
10 2012-03-23  Jessie Berlin  <jberlin@apple.com>
11
12         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
13         the Lion Intel WebKit2 Debug bots.
14         https://bugs.webkit.org/show_bug.cgi?id=81012.
15
16         Rubber-stamped by Dan Bernstein.
17
18         Add a step to kill the pasteboard server while we investigate what is causing these
19         assertion failures (to get the bots green).
20
21         * BuildSlaveSupport/kill-old-processes:
22
23 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
24
25         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
26         https://bugs.webkit.org/show_bug.cgi?id=81986
27
28         Reviewed by David Levin.
29
30         Track whether or not errors are filtered in error handlers. If an
31         alphabetical sorting error is reported for a header and filtered, try
32         reporting it for the other potential source of the error. This ensures
33         that the style bot can still find new sorting errors in both potential
34         situations:
35
36             #include <foo.h> <-- 1. edited line
37             #include <baz.h> <-- 2. edited line
38
39         * Scripts/webkitpy/style/checkers/cpp.py:
40         (check_include_line): Potentially report the error for both lines,
41         if the first error is filtered.
42         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
43         test that allows only reporting errors for certain lines. This verifies that
44         when one line of an ordering error is filtered, the error is reported on the
45         other line.
46         (ErrorCollector.__init__):
47         (ErrorCollector.__call__):
48         (CppStyleTestBase.perform_lint):
49         (CppStyleTestBase.perform_language_rules_check):
50         (CppStyleTestBase.assert_language_rules_check):
51         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
52         Added a new test that verifies that when one line of the two lines of an ordering
53         error occur, the error is reported on the other line.
54         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
55         (MockErrorHandler.__call__): Report True because the error is handled.
56         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
57         (ErrorCollector.__call__): Ditto.
58         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
59         (MockErrorHandler.__call__): Ditto.
60         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
61         (TestErrorHandler.__call__): Ditto.
62         * Scripts/webkitpy/style/checkers/xml_unittest.py:
63         (MockErrorHandler.__call__): Ditto.
64         * Scripts/webkitpy/style/error_handlers.py:
65         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
66         and False if it is filtered.
67
68 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
69
70         Build fix for WinCE after r111778.
71
72         * WinCELauncher/CMakeLists.txt:
73
74 2012-03-23  Peter Beverloo  <peter@chromium.org>
75
76         Unreviewed buildfix for the Chromium Android builder.
77
78         Disable the ImageDiff target for now. Android needs to build this for
79         host rather than for target (as other configurations do), but since the
80         WTF move the dependency chain got significantly more complicated.
81
82         I'll work out a proper fix in the following bug, but since several
83         things are broken due to this, this buildfix should be landed first.
84         https://bugs.webkit.org/show_bug.cgi?id=82039
85
86         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
87
88 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
89
90         [EFL][DRT] Implement LayoutTestController's methods related with editing.
91         https://bugs.webkit.org/show_bug.cgi?id=80136
92
93         Reviewed by Ryosuke Niwa.
94
95         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
96         setSelectTrailingWhitespaceEnabled.
97
98         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
99         (LayoutTestController::setSmartInsertDeleteEnabled):
100         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
101
102 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
103
104         Convert hasGrammarMarker to use Internals interface
105         https://bugs.webkit.org/show_bug.cgi?id=82004
106
107         Reviewed by Ryosuke Niwa.
108
109         Remove hasGrammarMarker functions, because it is able to work in the
110         cross-port way through the Internals interface.
111
112         * DumpRenderTree/LayoutTestController.cpp:
113         (LayoutTestController::staticFunctions):
114         * DumpRenderTree/LayoutTestController.h:
115         (LayoutTestController):
116         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
117         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
118         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
119         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
120         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
121         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
122
123 2012-03-22  Adam Barth  <abarth@webkit.org>
124
125         sync-master-with-upstream creates non-linear git history
126         https://bugs.webkit.org/show_bug.cgi?id=82006
127
128         Reviewed by Julien Chaffraix.
129
130         Previously this script would create a merge commit at the HEAD of
131         origin/master, causing your fork of WebKit to diverge from upstream.
132         The new version of this script pushes directly from upstream to origin
133         (without round-tripping through any local branches), avoiding this
134         problem.
135
136         * Scripts/sync-master-with-upstream:
137
138 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
139
140         Unreviewed build fix. Add knowledge of the WTF project to
141         the autotools build system scripts so that build-jsc works
142         correctly for GTK+.
143
144         * Scripts/webkitdirs.pm:
145         (buildAutotoolsProject): handle the WTF project, build the
146         libWTF.la target.
147         (buildGtkProject): add WTF to the list of supported projects.
148
149 2012-03-22  Eric Seidel  <eric@webkit.org>
150
151         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
152         https://bugs.webkit.org/show_bug.cgi?id=81984
153
154         Reviewed by Adam Barth.
155
156         * Scripts/VCSUtils.pm:
157         (adjustPathForRecentRenamings):
158
159 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
160
161         [CMake] Fix build-jsc after r111778 and r111797.
162         https://bugs.webkit.org/show_bug.cgi?id=82001
163
164         Reviewed by Filip Pizlo.
165
166         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
167         does return if no error occurred, and build-jsc failed with
168         "building not defined for this platform".
169
170         * Scripts/build-jsc: Always exit after caling
171         buildCMakeProjectOrExit().
172         * Scripts/webkitdirs.pm:
173         (buildCMakeProjectOrExit): Return 0 if no error occurred.
174
175 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
176
177         [CMake] Unreviewed build fix after r111778.
178
179         * DumpRenderTree/efl/CMakeLists.txt: Replace
180         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
181         paths.
182         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
183         wtf include.
184         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
185         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
186         with ${WTF_DIR}/wtf in the include paths.
187
188 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
189
190         Tools/Scripts/build-jsc doesn't work after WTF move
191         https://bugs.webkit.org/show_bug.cgi?id=81999
192
193         Reviewed by Eric Seidel.
194         
195         For ports that require WTF and JSC to be built as two projects and where
196         the machinery to build both does not already exist, teach the tool to do
197         so for us.
198
199         * Scripts/build-jsc:
200         (buildMyProject):
201
202 2012-03-22  Ojan Vafai  <ojan@chromium.org>
203
204         Fix accidental missing line in r111793.
205
206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
208         Remove base.values. It was unused and duplicates the builtin Object.values.
209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
210         Accidentally deleted this line before committing r111793.
211
212 2012-03-22  Ojan Vafai  <ojan@chromium.org>
213
214         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
215         https://bugs.webkit.org/show_bug.cgi?id=81983
216
217         Reviewed by Adam Barth.
218
219         The dialogs get in the way if you are doing multiple rebaselines. Also,
220         a number of people didn't realize that you could do multiple rebaselines
221         in parallel. A non-modal dialog is just confusing.
222
223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
225         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
226         show the number of tests being rebaselined.
227
228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
229         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
230         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
231         into a single area.
232
233         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
234         also serves to clear all teh content in the StatusArea. 
235
236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
238
239 2012-03-22  Tony Chang  <tony@chromium.org>
240
241         Unreviewed, fix chromium build after wtf move.
242
243         Only use newwtf, remove references to wtf.
244
245         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
246
247 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
248
249         Actually move WTF files to their new home
250         https://bugs.webkit.org/show_bug.cgi?id=81844
251
252         [Qt] Unreviewed buildfix after r111778.
253
254         * DumpRenderTree/qt/DumpRenderTree.pro:
255
256 2012-03-22  Dan Bernstein  <mitz@apple.com>
257
258         Font fallback in WebKitTestRunner depends on user settings
259         https://bugs.webkit.org/show_bug.cgi?id=81978
260
261         Reviewed by Jessie Berlin.
262
263         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
264         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
265         with a value consisting of the array ("en") to the override defaults
266         dictionary. This is the same value used in DumpRenderTree, and it
267         ensures that font fallback follows a consistent path that is not
268         affected by the language preferences of the user running the test.
269
270 2012-03-22  Andy Estes  <aestes@apple.com>
271
272         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
273         https://bugs.webkit.org/show_bug.cgi?id=81971
274
275         Reviewed by Dan Bernstein.
276
277         Xcode will automatically link ObjC binaries against libarclite in some
278         cases, which defines a class called __ARCLite__.
279         check-for-inappropriate-objc-class-names shouldn't complain about this
280         class name.
281
282         * Scripts/check-for-inappropriate-objc-class-names:
283
284 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
285
286         new-run-webkit-tests blames the wrong test for crashing
287         https://bugs.webkit.org/show_bug.cgi?id=81951
288
289         Reviewed by Adam Barth.
290
291         NRWT wasn't extracting the WebProcess pid correct; should've
292         used re.search instead of re.match :(. Add more tests!
293
294         * Scripts/webkitpy/layout_tests/port/mac.py:
295         (MacPort._get_crash_log):
296         * Scripts/webkitpy/layout_tests/port/webkit.py:
297         (WebKitDriver.has_crashed):
298         (WebKitDriver._check_for_driver_crash):
299         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
300         (WebKitDriverTest.test_no_timeout):
301         (WebKitDriverTest):
302         (WebKitDriverTest.test_check_for_driver_crash):
303         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
304         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
305         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
306         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
307         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
308         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
309
310 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
311
312         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
313         https://bugs.webkit.org/show_bug.cgi?id=81512
314
315         Adding missing implementation markerTextForListItem to EFL's
316         LayoutTestController so that we can unskip related tests from
317         the skip list.
318
319         Reviewed by Antonio Gomes.
320
321         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
322         (LayoutTestController::markerTextForListItem): Implemented.
323
324 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
325
326         [EFL] Enable view mode media feature layout tests
327         https://bugs.webkit.org/show_bug.cgi?id=81205
328
329         Adding missing implementation setViewModeMediaFeature to EFL's 
330         LayoutTestController so that we can unskip view mode 
331         media feature layout tests.
332
333         Reviewed by Antonio Gomes.
334
335         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
336         (LayoutTestController::setViewModeMediaFeature): Implemented.
337
338 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
339
340         nrwt: crash while stopping layout test helper on apple mac lion
341         https://bugs.webkit.org/show_bug.cgi?id=81949
342
343         Reviewed by Eric Seidel.
344
345         stop_helper() didn't work right if the helper process wasn't
346         still running or didn't respond properly to being shut down. Fix
347         this and add some tests. Also add code to MockExecutive() to be
348         able to mock executive.popen() properly.
349
350         * Scripts/webkitpy/common/system/executive_mock.py:
351         (MockProcess.__init__):
352         (MockProcess.wait):
353         (MockExecutive.__init__):
354         (MockExecutive.popen):
355         * Scripts/webkitpy/common/system/systemhost_mock.py:
356         (MockSystemHost.__init__):
357         * Scripts/webkitpy/layout_tests/port/mac.py:
358         (MacPort.start_helper):
359         (MacPort.stop_helper):
360         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
361         (test_get_crash_log):
362         (test_helper_starts):
363         (test_helper_fails_to_start):
364         (test_helper_fails_to_stop):
365         (test_helper_fails_to_stop.bad_waiter):
366
367 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
368
369         [GTK] Add make to the jhbuild moduleset
370         https://bugs.webkit.org/show_bug.cgi?id=81769
371
372         Reviewed by Martin Robinson.
373
374         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
375         Add GNU make with custom patches to fix several issues:
376
377         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
378           fix the argument list limit of GNU make when running make
379           distcheck.
380         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
381           and Jeremy Devenport to fix parallel build issues present in
382           GNU make 3.82
383
384         * gtk/jhbuild.modules: Added make with patches.
385         * gtk/patches/make-3.82-arg-list-length.patch: Added.
386         * gtk/patches/make-3.82-parallel-build.patch: Added.
387
388 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
389
390         [wx] Unreviewed. Adding Source/WTF to the build and updating
391         waf port list.
392
393         * DumpRenderTree/wscript:
394         * waf/build/settings.py:
395
396 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
397
398         Re-land fix for r81603 yet again (!) with latest build fix.
399         https://bugs.webkit.org/show_bug.cgi?id=81603
400
401         Unreviewed, build fix.
402
403         The latest problem was a bad sprintf() in
404         BasePort._get_crash_log(). I've reworked that routine and added
405         unit tests for coverage.
406
407         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
408         (SingleTestRunner._handle_error):
409         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
410         (write_test_result):
411         (TestResultWriter.write_crash_log):
412         * Scripts/webkitpy/layout_tests/port/base.py:
413         (Port.diff_text):
414         (Port._get_crash_log):
415         * Scripts/webkitpy/layout_tests/port/chromium.py:
416         (ChromiumDriver.run_test):
417         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
418         (ChromiumDriverTest.test_crash_log):
419         * Scripts/webkitpy/layout_tests/port/driver.py:
420         (DriverOutput.__init__):
421         * Scripts/webkitpy/layout_tests/port/mac.py:
422         (MacPort.is_lion):
423         (MacPort._get_crash_log):
424         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
425         (test_default_child_processes):
426         (test_get_crash_log):
427         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
428         (MockDRTPortTest.test_get_crash_log):
429         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
430         (PortTestCase.test_get_crash_log):
431         * Scripts/webkitpy/layout_tests/port/test.py:
432         (TestDriver.run_test):
433         * Scripts/webkitpy/layout_tests/port/webkit.py:
434         (WebKitDriver.__init__):
435         (WebKitDriver._start):
436         (WebKitDriver.has_crashed):
437         (WebKitDriver._check_for_driver_crash):
438         (WebKitDriver.run_test):
439
440 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
441
442         [Qt] Enable support for handling database quota's in the MiniBrowser
443         https://bugs.webkit.org/show_bug.cgi?id=81928
444
445         Reviewed by Simon Hausmann.
446
447         * MiniBrowser/qt/qml/BrowserWindow.qml:
448
449 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
450
451         [EFL] Implement LayoutTestController::setEditingBehavior
452         https://bugs.webkit.org/show_bug.cgi?id=81124
453
454         Adding missing implementation setEditingBehavior to EFL's
455         LayoutTestController. This implementation allows us to
456         unskip some tests from the skip list.
457
458         Reviewed by Martin Robinson.
459
460         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
461         (LayoutTestController::setEditingBehavior): Implemented.
462
463 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
464
465         [GTK] Use the angle-bracket form to include wtf headers
466         https://bugs.webkit.org/show_bug.cgi?id=81884
467
468         Reviewed by Eric Seidel.
469
470         Use #include <wtf/foo> instead of #include "foo".
471
472         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
473         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
475         * DumpRenderTree/gtk/EditingCallbacks.cpp:
476         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
477         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
478
479 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
480
481         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
482
483         * Scripts/webkitpy/common/config/committers.py:
484
485 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
486
487         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
488         https://bugs.webkit.org/show_bug.cgi?id=81889
489
490         Reviewed by Kenneth Rohde Christiansen.
491
492         Enable FAST_MOBILE_SCROLLING feature.
493
494         * qmake/mkspecs/features/features.prf:
495
496 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
497
498         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
499         https://bugs.webkit.org/show_bug.cgi?id=81900
500
501         Reviewed by Gustavo Noronha Silva.
502
503         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
504         path which assumed a certain directory structure for the build
505         directory which may noy be true.
506
507         Instead, hardcode the path to the downloaded fonts starting from the
508         top-level source directory. While this solution is also far from
509         perfect, it makes it more consistent and reliable, and easier to
510         tackle at once with the rest of bug 81475.
511
512         * DumpRenderTree/efl/CMakeLists.txt:
513
514 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
515
516         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
517         https://bugs.webkit.org/show_bug.cgi?id=81888
518
519         Reviewed by Philippe Normand.
520
521         * Scripts/update-webkit-libs-jhbuild:
522         (runJhbuild): Helper function to run jhbuild with a given command.
523         Instead of running jhbuild directly, use the jhbuild-wrapper, so
524         that we don't need to run it first to check whether jhbuild is
525         installed or not.
526         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
527         * gtk/run-with-jhbuild: Ditto.
528         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
529         not only run.
530
531 2012-03-22  Philippe Normand  <pnormand@igalia.com>
532
533         Unreviewed, test-webkitpy fix after r111661.
534
535         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
536         (MainTest.test_crash_log):
537         (MainTest.test_web_process_crash_log):
538
539 2012-03-22  Philippe Normand  <pnormand@igalia.com>
540
541         Unreviewed, test-webkitpy fix after r111642.
542
543         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
544         (ChromiumDriverTest.setUp):
545         (ChromiumDriverTest.test_two_drivers):
546
547 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
548
549         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
550         https://bugs.webkit.org/show_bug.cgi?id=81603
551
552         Unreviewed rolling out r111609 and part of r111615,
553         because it broke NRWT on Qt-WK2 platform.
554
555         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
556         (SingleTestRunner._handle_error):
557         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
558         (write_test_result):
559         (TestResultWriter.write_crash_report):
560         * Scripts/webkitpy/layout_tests/port/base.py:
561         (Port.is_crash_reporter):
562         (Port._driver_class):
563         * Scripts/webkitpy/layout_tests/port/chromium.py:
564         (ChromiumDriver.run_test):
565         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
566         (ChromiumDriverTest.test_crashed_process_name):
567         * Scripts/webkitpy/layout_tests/port/driver.py:
568         (DriverOutput.__init__):
569         * Scripts/webkitpy/layout_tests/port/mac.py:
570         (MacPort):
571         (MacPort.is_crash_reporter):
572         (MacPort.release_http_lock):
573         * Scripts/webkitpy/layout_tests/port/test.py:
574         (TestDriver.run_test):
575         * Scripts/webkitpy/layout_tests/port/webkit.py:
576         (WebKitDriver.__init__):
577         (WebKitDriver._start):
578         (WebKitDriver.has_crashed):
579         (WebKitDriver._check_for_driver_crash):
580         (WebKitDriver.run_test):
581
582 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
583
584         [Qt] Add full platforms to Qt buildslaves
585         https://bugs.webkit.org/show_bug.cgi?id=81877
586
587         Reviewed by Ryosuke Niwa.
588
589         * BuildSlaveSupport/build.webkit.org-config/config.json:
590
591 2012-03-21  Johnny Ding  <jnd@chromium.org>
592
593         Customize layout test timeout value for different ports.
594         https://bugs.webkit.org/show_bug.cgi?id=79859
595
596         Reviewed by Ojan Vafai.
597
598         * Scripts/webkitpy/layout_tests/controllers/manager.py:
599         (Manager):
600         * Scripts/webkitpy/layout_tests/port/base.py:
601         (Port.default_test_timeout_ms):
602         * Scripts/webkitpy/layout_tests/port/chromium.py:
603         (ChromiumDriver.stop):
604         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
605         (ChromiumAndroidPort.default_test_timeout_ms):
606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
607         (_set_up_derived_options):
608
609 2012-03-21  Mark Rowe  <mrowe@apple.com>
610
611         Fix the build.
612
613         Ensure that our test tools don't try and use RTTI unnecessarily.
614
615         * DumpRenderTree/mac/Configurations/Base.xcconfig:
616         * TestWebKitAPI/Configurations/Base.xcconfig:
617         * WebKitTestRunner/Configurations/Base.xcconfig:
618
619 2012-03-21  Adam Barth  <abarth@webkit.org>
620
621         WebKit should have some scripts to smooth interactions with GitHub
622         https://bugs.webkit.org/show_bug.cgi?id=81842
623
624         Reviewed by Eric Seidel.
625
626         These scripts support the workflow in
627         https://trac.webkit.org/wiki/UsingGitHub by automating the
628         configuration and syncing operations needed for a GitHub fork of WebKit
629         to track the main WebKit repository.
630
631         * Scripts/configure-github-as-upstream: Added.
632         * Scripts/sync-master-with-upstream: Added.
633
634 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
635
636         WTR - log the pid of a crashing WebProcess
637         https://bugs.webkit.org/show_bug.cgi?id=81575
638
639         Reviewed by Alexey Proskuryakov.
640
641         This allows run-webkit-tests to find the right crash log for a
642         given crashed WebProcess in WebKit2.
643
644         * WebKitTestRunner/TestController.cpp:
645         (WTR::exceededDatabaseQuota):
646         (WTR::TestController::createOtherPage):
647         (WTR::TestController::initialize):
648         (WTR::TestController::resetStateToConsistentValues):
649         (WTR::TestController::runTest):
650         (WTR::TestController::processDidCrash):
651
652 2012-03-21  Enrica Casucci  <enrica@apple.com>
653
654         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
655         https://bugs.webkit.org/show_bug.cgi?id=81835
656         <rdar://problem/11082749>
657
658         Reviewed by Brady Eidson.
659
660         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
661         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
662         (TestWebKitAPI::contextMenuCopyLink):
663
664 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
665
666         [CSS Shaders] Make CSS Shaders compile on Chromium
667         https://bugs.webkit.org/show_bug.cgi?id=81435
668
669         Reviewed by Stephen White.
670         
671         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
672
673         * DumpRenderTree/chromium/LayoutTestController.cpp:
674         (LayoutTestController::overridePreference):
675         * DumpRenderTree/chromium/WebPreferences.cpp:
676         (WebPreferences::reset):
677         (WebPreferences::applyTo):
678         * DumpRenderTree/chromium/WebPreferences.h:
679         (WebPreferences):
680
681 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
682
683         fix regression on gtk port introduced by r111609
684         https://bugs.webkit.org/show_bug.cgi?id=81839
685
686         Reviewed by Philippe Normand.
687
688         r111609 should've initialized a couple of missing fields in
689         WebKitDriver, and also should've checked for method overrides
690         in the other ports :(.
691
692         * Scripts/webkitpy/layout_tests/port/gtk.py:
693         (GtkDriver._start):
694         * Scripts/webkitpy/layout_tests/port/webkit.py:
695         (WebKitDriver.__init__):
696         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
697         (MainTest.test_crash_log):
698         (MainTest.test_web_process_crash_log):
699
700 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
701
702         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
703         https://bugs.webkit.org/show_bug.cgi?id=81603
704
705         Reviewed by Adam Barth.
706
707         Add a new _get_crash_log() overridable method on the Port
708         object to customize how we fetch crash logs per port.
709         Mac will now slow-spin with a timeout waiting for the crash log, rather
710         than waiting for the ReportCrash process to exit (it appears
711         that the mac will manage multiple crashes with a single
712         ReportCrash process, the process waits around longer than
713         necessary, presumably to avoid thrashing if processes are
714         repeatedly crashing).
715
716         Also, add the DriverOutput should contain the crash log and other info,
717         which is created in a port-specific manner but can then be
718         treated generically. Previously single_test_runner would get
719         told that something crashed and attempt to do something to get
720         the crash log, but it didn't have the information it needed to
721         od the right thing; better to make the driver hand back the
722         right info.
723
724         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
725         (SingleTestRunner._handle_error):
726         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
727         (write_test_result):
728         (TestResultWriter.write_crash_log):
729         * Scripts/webkitpy/layout_tests/port/base.py:
730         (Port.diff_text):
731         (Port._get_crash_log):
732         * Scripts/webkitpy/layout_tests/port/chromium.py:
733         (ChromiumDriver.run_test):
734         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
735         (ChromiumDriverTest.test_crash_log):
736         * Scripts/webkitpy/layout_tests/port/driver.py:
737         (DriverOutput.__init__):
738         * Scripts/webkitpy/layout_tests/port/mac.py:
739         (MacPort.is_lion):
740         (MacPort._get_crash_log):
741         * Scripts/webkitpy/layout_tests/port/test.py:
742         (TestDriver.run_test):
743         * Scripts/webkitpy/layout_tests/port/webkit.py:
744         (WebKitDriver.__init__):
745         (WebKitDriver._start):
746         (WebKitDriver.has_crashed):
747         (WebKitDriver._check_for_driver_crash):
748         (WebKitDriver.run_test):
749
750 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
751
752         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
753         https://bugs.webkit.org/show_bug.cgi?id=81507
754
755         Now that we're only loading from one directory, no need to
756         iterate over a list of directories anymore.
757
758         Reviewed by Martin Robinson.
759
760         * DumpRenderTree/efl/CMakeLists.txt:
761         * DumpRenderTree/efl/FontManagement.cpp:
762         (addFontDirectory):
763         (addFontsToEnvironment):
764
765 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
766
767         webkitpy: get ServerProcess out of the reportcrash business
768         https://bugs.webkit.org/show_bug.cgi?id=81600
769
770         Unreviewed, build fix.
771
772         Re-land r111307 and r111293 with another fix for a crash in NRWT;
773         we need to check if the driver has crashed before attempting to
774         read from it.
775
776
777         * Scripts/webkitpy/layout_tests/port/server_process.py:
778         (ServerProcess._reset):
779         (ServerProcess._handle_possible_interrupt):
780         (ServerProcess.write):
781         (ServerProcess.read_stdout):
782         (ServerProcess.has_crashed):
783         (ServerProcess._read):
784         (ServerProcess.stop):
785         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
786         (TrivialMockPort.check_for_leaks):
787         (TestServerProcess.test_broken_pipe):
788         * Scripts/webkitpy/layout_tests/port/webkit.py:
789         (WebKitPort._read_image_diff):
790         (WebKitDriver.has_crashed):
791         (WebKitDriver._check_for_driver_crash):
792         (WebKitDriver.run_test):
793         (WebKitDriver._read_block):
794         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
795         (MockServerProcess.__init__):
796         (MockServerProcess):
797         (MockServerProcess.has_crashed):
798
799 2012-03-21  Zeno Albisser  <zeno@webkit.org>
800
801         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
802         https://bugs.webkit.org/show_bug.cgi?id=81750
803
804         Building WebCore on mac currently creates an archive that is bigger than
805         4GB. But ranlib fails to create a symbol table for such a big archive,
806         even on 64bit machines.
807         Therefore we start using SVGAllInOne.cpp when building debug
808         on mac. This reduces the size of the archive by about 300MB.
809
810         Reviewed by Tor Arne Vestbø.
811
812         * qmake/mkspecs/features/mac/default_pre.prf:
813
814 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
815
816         Updated the address list of committers.py.
817
818         Reviewed by Csaba Osztrogonác.
819
820         * Scripts/webkitpy/common/config/committers.py:
821
822 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
823
824         Updating my nick in committers file.
825
826         Unreviewed.
827
828         * Scripts/webkitpy/common/config/committers.py:
829
830 2012-03-21  Peter Beverloo  <peter@chromium.org>
831
832         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
833         https://bugs.webkit.org/show_bug.cgi?id=80861
834
835         Reviewed by Tony Chang.
836
837         Remove most Android-specific logic from webkitdirs.pm in favor of
838         handling this during project generation time.
839
840         * Scripts/webkitdirs.pm:
841         (buildChromiumMakefile):
842
843 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
844
845         [GTK] Allow running javascript from location bar in MiniBrowser
846         https://bugs.webkit.org/show_bug.cgi?id=81331
847
848         Reviewed by Martin Robinson.
849
850         * MiniBrowser/gtk/BrowserWindow.c:
851         (activateUriEntryCallback): Use browser_window_load_uri().
852         (browser_window_load_uri): Check whether uri starts with
853         javascript: and run the given script, or just call
854         webkit_web_view_load_uri() to load the given uri.
855         * MiniBrowser/gtk/BrowserWindow.h:
856         * MiniBrowser/gtk/main.c:
857         (createBrowserWindow): Use browser_window_load_uri().
858
859 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
860
861         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
862         https://bugs.webkit.org/show_bug.cgi?id=75543
863
864         Reviewed by Martin Robinson.
865
866         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
867         MiniBrowser CPP flags.
868
869 2012-03-20  Eric Seidel  <eric@webkit.org>
870
871         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
872         https://bugs.webkit.org/show_bug.cgi?id=80911
873
874         Reviewed by Adam Barth.
875
876         Update include paths for Source/WTF.
877
878         * DumpRenderTree/efl/CMakeLists.txt:
879         * DumpRenderTree/qt/DumpRenderTree.pro:
880         * QtTestBrowser/QtTestBrowser.pro:
881         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
882
883 2012-03-20  Adam Barth  <abarth@webkit.org>
884
885         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
886         https://bugs.webkit.org/show_bug.cgi?id=81567
887
888         Reviewed by Eric Seidel.
889
890         This temporary measure should help us avoid disrupting the folks
891         working on WebAudio when we move the webaudio directory to Modules.
892
893         * Scripts/VCSUtils.pm:
894         (adjustPathForRecentRenamings):
895         (parseGitDiffHeader):
896         (parseSvnDiffHeader):
897
898 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
899
900         Unreviewed, rolling out r111453.
901         http://trac.webkit.org/changeset/111453
902         https://bugs.webkit.org/show_bug.cgi?id=81600
903
904         still broken
905
906         * Scripts/webkitpy/layout_tests/port/server_process.py:
907         (ServerProcess._reset):
908         (ServerProcess.handle_interrupt):
909         (ServerProcess.write):
910         (ServerProcess._check_for_crash):
911         (ServerProcess._handle_timeout):
912         (ServerProcess._check_for_abort):
913         (ServerProcess._read):
914         (ServerProcess.stop):
915         (ServerProcess):
916         (ServerProcess.set_crashed):
917         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
918         (TrivialMockPort.is_crash_reporter):
919         (TestServerProcess.test_broken_pipe):
920         * Scripts/webkitpy/layout_tests/port/webkit.py:
921         (WebKitPort._read_image_diff):
922         (WebKitDriver.has_crashed):
923         (WebKitDriver._check_for_driver_crash):
924         (WebKitDriver):
925         (WebKitDriver._detected_crash):
926         (WebKitDriver._subprocess_crashed):
927         (WebKitDriver._crashed_process_name):
928         (WebKitDriver.run_test):
929         (WebKitDriver._read_block):
930         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
931         (MockServerProcess.__init__):
932
933 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
934
935         webkitpy: get ServerProcess out of the reportcrash business
936         https://bugs.webkit.org/show_bug.cgi?id=81600
937
938         Unreviewed, build fix.
939
940         Re-land r111307 and r111293 with fix for crash in NRWT; I
941         was failing to set the crashing process name.
942
943         * Scripts/webkitpy/layout_tests/port/server_process.py:
944         (ServerProcess._reset):
945         (ServerProcess._handle_possible_interrupt):
946         (ServerProcess.write):
947         (ServerProcess.read_stdout):
948         (ServerProcess.has_crashed):
949         (ServerProcess._read):
950         (ServerProcess.stop):
951         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
952         (TrivialMockPort.check_for_leaks):
953         (TestServerProcess.test_broken_pipe):
954         * Scripts/webkitpy/layout_tests/port/webkit.py:
955         (WebKitPort._read_image_diff):
956         (WebKitDriver.has_crashed):
957         (WebKitDriver._check_for_driver_crash):
958         (WebKitDriver.run_test):
959         (WebKitDriver._read_block):
960         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
961         (MockServerProcess.__init__):
962         (MockServerProcess):
963         (MockServerProcess.has_crashed):
964
965 2012-03-20  Tim Horton  <timothy_horton@apple.com>
966
967         [mac] Restore color space switching code to run-webkit-tests
968         https://bugs.webkit.org/show_bug.cgi?id=80571
969         <rdar://problem/11008529>
970
971         Reviewed by Simon Fraser.
972
973         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
974         
975         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
976         didn't exist until Lion.
977
978         * DumpRenderTree/mac/LayoutTestHelper.m:
979         (installLayoutTestColorProfile):
980         (restoreUserColorProfile):
981
982 2012-03-20  Adele Peterson  <adele@apple.com>
983
984         Update the last test to use EXPECT_WK_STREQ.
985
986         Reviewed by Dan Bernstein.
987
988         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
989
990 2012-03-20  Adele Peterson  <adele@apple.com>
991
992         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
993         https://bugs.webkit.org/show_bug.cgi?id=81630
994         <rdar://problem/10650660>
995
996         Reviewed by Alexey Proskuryakov.
997
998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
999         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
1000         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
1001         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
1002         (TestWebKitAPI):
1003         (TestWebKitAPI::didFinishLoadForFrame):
1004         (TestWebKitAPI::TEST):
1005         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
1006
1007 2012-03-20  Eric Seidel  <eric@webkit.org>
1008
1009         Add link on queues.webkit.org to kov's fancy queue-depth graph
1010         https://bugs.webkit.org/show_bug.cgi?id=81690
1011
1012         Reviewed by Adam Barth.
1013
1014         * QueueStatusServer/templates/recentstatus.html:
1015
1016 2012-03-20  Tim Horton  <timothy_horton@apple.com>
1017
1018         [mac] Restore color space switching code to run-webkit-tests
1019         https://bugs.webkit.org/show_bug.cgi?id=80571
1020         <rdar://problem/11008529>
1021
1022         Reviewed by Simon Fraser.
1023
1024         Make use of the layout test helper hooks to restore the Mac system-wide
1025         color profile switching code. This makes WkTR and DRT results match, and
1026         causes the main display's color profile to not affect results on Lion.
1027
1028         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1029         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
1030         (installLayoutTestColorProfile):
1031         (restoreUserColorProfile):
1032         (simpleSignalHandler):
1033         (main):
1034         * Scripts/webkitpy/layout_tests/port/mac.py:
1035         (MacPort.release_http_lock):
1036         (MacPort):
1037         (MacPort._path_to_helper):
1038         (MacPort.start_helper):
1039         (MacPort.stop_helper):
1040         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1041         (WTR::PlatformWebView::PlatformWebView):
1042         (WTR::PlatformWebView::windowSnapshotImage):
1043
1044 2012-02-24  Darin Fisher  <darin@chromium.org>
1045
1046         Add more Chromium WebKit API reviewers
1047         https://bugs.webkit.org/show_bug.cgi?id=81576
1048
1049         Reviewed by Adam Barth and David Levin.
1050
1051         Simplify watchlist to lump all WebKit API into one.
1052
1053         * Scripts/webkitpy/common/config/watchlist:
1054
1055 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1056
1057         Convert hasSpellingMarker to use Internals interface.
1058         https://bugs.webkit.org/show_bug.cgi?id=81300
1059
1060         Reviewed by Ryosuke Niwa.
1061
1062         Remove hasSpellingMarker functions, because it is able to work in the
1063         cross-port way through the Internals interface.
1064
1065         * DumpRenderTree/LayoutTestController.cpp:
1066         (LayoutTestController::staticFunctions):
1067         * DumpRenderTree/LayoutTestController.h:
1068         (LayoutTestController):
1069         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1070         * DumpRenderTree/chromium/LayoutTestController.cpp:
1071         (LayoutTestController::LayoutTestController):
1072         * DumpRenderTree/chromium/LayoutTestController.h:
1073         (LayoutTestController):
1074         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1075         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1076         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1077         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1078         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1079         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1080         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1081
1082 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1083
1084         Add new Qt-WK2 performance tester bot to build.webkit.org
1085         https://bugs.webkit.org/show_bug.cgi?id=80842
1086
1087         Reviewed by Ryosuke Niwa.
1088
1089         * BuildSlaveSupport/build.webkit.org-config/config.json:
1090         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1091         (RunAndUploadPerfTestsWebKit2):
1092         (RunAndUploadPerfTestsWebKit2.start):
1093         (BuildAndPerfTestWebKit2Factory):
1094         (BuildAndPerfTestWebKit2Factory.__init__):
1095         (DownloadAndPerfTestWebKit2Factory):
1096         (DownloadAndPerfTestWebKit2Factory.__init__):
1097
1098 2012-03-20  Peter Beverloo  <peter@chromium.org>
1099
1100         [Chromium] Update to Android NDK r7b
1101         https://bugs.webkit.org/show_bug.cgi?id=81005
1102
1103         Reviewed by Adam Barth.
1104
1105         Update to version r7b of the Android NDK, release notes of which are
1106         available on the following page:
1107         http://developer.android.com/sdk/ndk/index.html
1108
1109         * Scripts/update-webkit-chromium:
1110
1111 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1112
1113         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
1114         https://bugs.webkit.org/show_bug.cgi?id=81502
1115
1116         Unreviewed.
1117
1118         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
1119
1120 2012-03-19  Jessie Berlin  <jberlin@apple.com>
1121
1122         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
1123         because they broke running the layout tests on mac.
1124
1125         * Scripts/webkitpy/layout_tests/port/webkit.py:
1126         (WebKitDriver._check_for_driver_crash):
1127
1128 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
1129
1130         [GTK] Allow running run-gtk-tests during 'make distcheck'
1131         https://bugs.webkit.org/show_bug.cgi?id=81415
1132
1133         Reviewed by Philippe Normand.
1134
1135         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
1136
1137         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
1138         main command run during 'make check.'
1139         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
1140         a requirement to run it. If jhbuild isn't around it will simply not start the
1141         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
1142         main loop and simply use the main loop in a synchronous method to start SPI
1143         daemons. Did a bunch of general cleanup around these tasks.
1144
1145 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1146
1147         jhbuild: Use the multiprocessing module to get the number of CPUs.
1148         https://bugs.webkit.org/show_bug.cgi?id=81585
1149
1150         Reviewed by Martin Robinson.
1151
1152         Now that support for Python 2.5 has been dropped, we can safely
1153         use multiprocessing.cpu_count() to obtain the current number of
1154         CPUs in the system instead of running a webkitperl script for
1155         that.
1156
1157         * efl/common.py:
1158         (top_level_path):
1159         * efl/jhbuildrc:
1160         * gtk/common.py:
1161         (build_path):
1162         * gtk/jhbuildrc:
1163
1164 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1165
1166         We should only add a live event listener once, not once per TestSelector.
1167         Adding one per TestSelector would cause accordion('option', 'active') to
1168         incorrectly be "false" if you examine multiple sets of tests.
1169
1170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1171
1172 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1173
1174         Fix typo introduced in r111293.
1175
1176         Unreviewed, build fix.
1177
1178         * Scripts/webkitpy/layout_tests/port/webkit.py:
1179         (WebKitDriver._check_for_driver_crash):
1180
1181 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1182
1183         webkitpy: get ServerProcess out of the reportcrash business
1184         https://bugs.webkit.org/show_bug.cgi?id=81600
1185
1186         Reviewed by Adam Barth.
1187
1188         ServerProcess was half-aware that ReportCrash might run
1189         sometimes, and that the process ServerProcess was talking to
1190         might have its own crashing subprocesses; neither of these
1191         things really worked right and it made the logic convoluted, so
1192         this change makes handling crashes completely separate from the
1193         server_process code, so that it can focus on just I/O to the
1194         subprocess.
1195
1196         There should be no functional changes resulting from this patch.
1197
1198         * Scripts/webkitpy/layout_tests/port/server_process.py:
1199         (ServerProcess._reset):
1200         (ServerProcess._handle_possible_interrupt):
1201         (ServerProcess.write):
1202         (ServerProcess.read_stdout):
1203         (ServerProcess.has_crashed):
1204         (ServerProcess._read):
1205         (ServerProcess.stop):
1206         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1207         (TrivialMockPort.check_for_leaks):
1208         (TestServerProcess.test_broken_pipe):
1209         * Scripts/webkitpy/layout_tests/port/webkit.py:
1210         (WebKitPort._read_image_diff):
1211         (WebKitDriver.has_crashed):
1212         (WebKitDriver._check_for_driver_crash):
1213         (WebKitDriver.run_test):
1214         (WebKitDriver._read_block):
1215         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1216         (MockServerProcess.__init__):
1217         (MockServerProcess):
1218         (MockServerProcess.has_crashed):
1219
1220 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1221
1222         webkitpy: crashlog parsing is broken
1223         https://bugs.webkit.org/show_bug.cgi?id=81586
1224
1225         Reviewed by Adam Barth.
1226
1227         Seeking on a file opened through codecs() appears to not work
1228         correctly (at least on SL).
1229         
1230         The code was more complicated than it needed to be, so I have
1231         revamped it to just read a full crashlog at once and then look
1232         for matches. 
1233         
1234         I have also added the ability to optionally propagate
1235         errors back (which can be helpful to debug races when ReportCrash is
1236         still running and you need to see that you couldn't open some
1237         files, rather than just ignoring them).
1238
1239         * Scripts/webkitpy/common/system/crashlogs.py:
1240         (CrashLogs.find_newest_log):
1241         (CrashLogs._find_newest_log_darwin):
1242         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1243         (CrashLogsTest.test_find_log_darwin):
1244
1245 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1246
1247         webkitpy: clean up some port._filesystem references to not reference private members
1248         https://bugs.webkit.org/show_bug.cgi?id=81595
1249
1250         Reviewed by Eric Seidel.
1251
1252         There should be no functional changes in this patch, just some
1253         refactoring. Also, fixes a minor nit in write_image_diff_files(()
1254
1255         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1256         (SingleTestRunner.__init__):
1257         (SingleTestRunner._run_compare_test):
1258         (SingleTestRunner._run_rebaseline):
1259         (SingleTestRunner._save_baseline_data):
1260         (SingleTestRunner._handle_error):
1261         (SingleTestRunner._run_reftest):
1262         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1263         (write_test_result):
1264         (TestResultWriter.__init__):
1265         (TestResultWriter._make_output_directory):
1266         (TestResultWriter.output_filename):
1267         (TestResultWriter._output_testname):
1268         (TestResultWriter.write_output_files):
1269         (TestResultWriter.write_stderr):
1270         (TestResultWriter.write_crash_report):
1271         (TestResultWriter.create_text_diff_and_write_result):
1272         (TestResultWriter.write_image_diff_files):
1273         (copy_file):
1274         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1275         (TestResultWriterTest.test_reftest_diff_image):
1276
1277 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1278
1279         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
1280         https://bugs.webkit.org/show_bug.cgi?id=81598
1281
1282         Reviewed by Eric Seidel.
1283
1284         "DumpRenderTree" shouldn't be hard-coded here, since some other
1285         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
1286         
1287         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1288         (TestExpectations):
1289
1290 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1291
1292         webkitpy: allow instance data in TestFailure objects
1293         https://bugs.webkit.org/show_bug.cgi?id=81580
1294
1295         Reviewed by Tony Chang.
1296
1297         Current TestFailures are basically enums, but it would be nice,
1298         especially for crashes, if they contained the name and pid of
1299         the process that crashed.
1300
1301         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1302         (TestFailure.message):
1303         (FailureTimeout.message):
1304         (FailureCrash):
1305         (FailureCrash.__init__):
1306         (FailureCrash.message):
1307         (FailureMissingResult.message):
1308         (FailureTextMismatch.message):
1309         (FailureMissingImageHash.message):
1310         (FailureMissingImage.message):
1311         (FailureImageHashMismatch.message):
1312         (FailureImageHashIncorrect.message):
1313         (FailureReftestMismatch.message):
1314         (FailureReftestMismatchDidNotOccur.message):
1315         (FailureReftestNoImagesGenerated.message):
1316         (FailureMissingAudio.message):
1317         (FailureAudioMismatch.message):
1318         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1319         (TestFailuresTest.test_equals):
1320         (TestFailuresTest):
1321         (TestFailuresTest.test_crashes):
1322
1323 2012-03-19  Brady Eidson  <beidson@apple.com>
1324
1325         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
1326         Crash in 3rd party WebKit apps under XHR/Cache code
1327
1328         Reviewed by Antti Koivisto.
1329
1330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1331         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
1332         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
1333         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1334         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1335         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1336         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1337         (TestWebKitAPI):
1338         (TestWebKitAPI::TEST):
1339
1340 2012-03-19  Brady Eidson  <beidson@apple.com>
1341
1342         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
1343         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
1344
1345         Reviewed by Enrica Casucci.
1346
1347         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
1348         are in the correct format.
1349
1350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1351         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
1352         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
1353         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
1354         (TestWebKitAPI::contextMenuCopyLink):
1355         (TestWebKitAPI::TEST):
1356
1357 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1358
1359         Make the selected item in the accordion a link to the flakiness dashboard
1360         https://bugs.webkit.org/show_bug.cgi?id=81571
1361
1362         Reviewed by Dimitri Glazkov.
1363
1364         Also, make it so that you can select the text of the link, instead of the current behavior
1365         of acting as if you had clicked on the accordion header.
1366
1367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1369
1370 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1371
1372         NRWT runs some tests that are skipped with -i command line option
1373         https://bugs.webkit.org/show_bug.cgi?id=81535
1374
1375         Reviewed by Ojan Vafai.
1376
1377         This change modifies the interaction of Skipped files and
1378         test_expectations files so that entries in Skipped files (and
1379         the -i command line) override *everything* in the expectations
1380         file.
1381
1382         Specifically, a directory in a Skipped file will cause all of
1383         the tests in the dir to be skipped even if individual tests in
1384         the dir are listed in the test_expectations.txt.
1385
1386         Skipped files also override anything in an overrides files.
1387
1388         This seems to make more intuitive sense, since if you list
1389         something in the Skips file (and even more specify it on the
1390         command line) you probably want it to be universally applied.
1391
1392         Theoretically we could add more precedence levels and have full
1393         paths in an expectations file override dirs in a Skipped file
1394         (but not the command line), but I don't know yet that that level
1395         of complexity is justified.
1396         
1397         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1398         (TestExpectations.__init__):
1399         (TestExpectations._add_skipped_tests):
1400         (TestExpectations._add_test):
1401         (TestExpectations._add_expectations):
1402         (TestExpectations._add_expectation_line):
1403         (TestExpectations._already_seen_better_match):
1404         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1405         (test_more_specific_override_resets_skip):
1406         (SkippedTests):
1407         (SkippedTests.get_exp):
1408         (SkippedTests.assert_exp):
1409         (SkippedTests.test_skipped_tests_work):
1410         (SkippedTests.test_duplicate_skipped_test_fails_lint):
1411         (SkippedTests.test_skipped_file_overrides_expectations):
1412         (SkippedTests.test_skipped_dir_overrides_expectations):
1413         (SkippedTests.test_skipped_file_overrides_overrides):
1414         (SkippedTests.test_skipped_dir_overrides_overrides):
1415
1416 2012-03-19  Eric Seidel  <eric@webkit.org>
1417
1418         Fix WTF header include discipline in Chromium WebKit
1419         https://bugs.webkit.org/show_bug.cgi?id=81281
1420
1421         Reviewed by James Robinson.
1422
1423         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1424         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
1425
1426 2012-03-19  Andy Chen  <andchen@rim.com>
1427
1428         [BlackBerry] Add new layout test for text match marker
1429         https://bugs.webkit.org/show_bug.cgi?id=81531
1430
1431         Make the LayoutTestControllerBlackBerry::findString to test the
1432         BlackBerry port implementation.
1433
1434         Reviewed by Rob Buis.
1435
1436         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1437         (LayoutTestController::findString):
1438
1439 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1440
1441         Don't show WONTFIX tests in garden-o-matic
1442         https://bugs.webkit.org/show_bug.cgi?id=81554
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1448
1449 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
1450
1451         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
1452         https://bugs.webkit.org/show_bug.cgi?id=81530
1453
1454         Reviewed by Jessie Berlin.
1455
1456         Add rowAtIndex to WebKitTestRunner.
1457
1458         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1459         (WTR::AccessibilityUIElement::rowAtIndex):
1460         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1461         (AccessibilityUIElement):
1462         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1463         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1464         (WTR):
1465         (WTR::AccessibilityUIElement::rowAtIndex):
1466
1467 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1468
1469         Change garden-o-matic All Failures tab to Expected Failures
1470         https://bugs.webkit.org/show_bug.cgi?id=81540
1471
1472         Reviewed by Dimitri Glazkov.
1473
1474         Also, fix some broken unittests that had just gotten stale.
1475
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1486
1487 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
1488
1489         [chromium] DRT crashes at shutdown.
1490         https://bugs.webkit.org/show_bug.cgi?id=81504
1491
1492         Reviewed by James Robinson.
1493
1494         WebCompositor must be destroyed after WebView is properly destroyed,
1495         or some compositor objects like CCLayerTreeHost may not be destroyed.
1496         However, it is really hard to make the destruction order correct
1497         explicitly in ~TestShell. So move it out to DumpRenderTree.
1498
1499         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1500         (main):
1501         * DumpRenderTree/chromium/TestShell.cpp:
1502         (TestShell::~TestShell):
1503
1504 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1505
1506         add dpranke to webkitpy watchlist
1507         https://bugs.webkit.org/show_bug.cgi?id=81433
1508
1509         Reviewed by Benjamin Poulain.
1510
1511         * Scripts/webkitpy/common/config/watchlist:
1512
1513 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1514
1515         test-webkitpy is failing on SL/Python 2.6.1
1516         https://bugs.webkit.org/show_bug.cgi?id=81533
1517
1518         Reviewed by Ojan Vafai.
1519
1520         It appears that itertools.combinations() is buggy in 2.6.1; this
1521         backports the implementation from 2.7.
1522
1523         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1524         (TestConfigurationConverter.collapse_macros):
1525         (TestConfigurationConverter):
1526         (TestConfigurationConverter.combinations):
1527
1528 2012-03-19  David Michael Barr  <davidbarr@google.com>
1529
1530         Optimize the cleanup sequence in the start-queue.sh script
1531         https://github.com/abarth/webkit/pull/1
1532
1533         Reviewed by Adam Barth.
1534
1535         Updating the working copy is an expensive operation
1536         for a repository the size of WebKit.
1537         Attempt to reset only to the target revision.
1538
1539         * EWSTools/start-queue.sh:
1540
1541 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1542
1543         Adjust architecture type of the EFL build bot.
1544         https://bugs.webkit.org/show_bug.cgi?id=81452
1545
1546         Reviewed by Tony Chang.
1547
1548         * BuildSlaveSupport/build.webkit.org-config/config.json: The
1549         buildslave is a 64-bit machine, therefore describe it as being
1550         x86_64, not i386.
1551
1552 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1553
1554         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
1555         https://bugs.webkit.org/show_bug.cgi?id=81514
1556
1557         Reviewed by Simon Hausmann.
1558
1559         * MiniBrowser/qt/qml/BrowserWindow.qml:
1560
1561 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1562
1563         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
1564         https://bugs.webkit.org/show_bug.cgi?id=81491
1565
1566         Reviewed by Philippe Normand.
1567
1568         For the find_path(), find_library() etc CMake calls to find the
1569         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
1570         set, otherwise CMake cannot know the dependencies exist and will only
1571         look in the standard directories.
1572
1573         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
1574         the jhbuild Root directory.
1575
1576 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1577
1578         [EFL] Add XDG env vars to jhbuildrc
1579         https://bugs.webkit.org/show_bug.cgi?id=81510
1580
1581         Needed to ensure correct glib behaviour in jhbuild environment.
1582
1583         Reviewed by Philippe Normand.
1584
1585         * efl/jhbuildrc:
1586
1587 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1588
1589         Select best target for tap gesture.
1590         https://bugs.webkit.org/show_bug.cgi?id=78801
1591
1592         Reviewed by Kenneth Rohde Christiansen.
1593
1594         Add TOUCH_ADJUSTMENT to enabled features.
1595
1596         * qmake/mkspecs/features/features.prf:
1597
1598 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
1599
1600         [chromium] synthesize wheel events for fling on main thread
1601         https://bugs.webkit.org/show_bug.cgi?id=81458
1602
1603         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
1604
1605         Reviewed by James Robinson.
1606
1607         * DumpRenderTree/chromium/EventSender.cpp:
1608         (EventSender::EventSender):
1609         (EventSender::gestureFlingCancel):
1610         (EventSender::gestureFlingStart):
1611         * DumpRenderTree/chromium/EventSender.h:
1612         (EventSender):
1613
1614 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1615
1616         [Qt] Add command line option to set the user agent in the MiniBrowser
1617         https://bugs.webkit.org/show_bug.cgi?id=81508
1618
1619         Reviewed by Simon Hausmann.
1620
1621         * MiniBrowser/qt/BrowserWindow.cpp:
1622         (BrowserWindow::BrowserWindow):
1623         (BrowserWindow::webViewExperimental):
1624         * MiniBrowser/qt/BrowserWindow.h:
1625         (BrowserWindow):
1626         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1627         (printHelp):
1628         (MiniBrowserApplication::handleUserOptions):
1629         * MiniBrowser/qt/MiniBrowserApplication.h:
1630         (WindowOptions::WindowOptions):
1631         (WindowOptions::setUserAgent):
1632         (WindowOptions::userAgent):
1633         (WindowOptions):
1634
1635 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1636
1637         [Qt] Remove dead user agent code from the MiniBrowser.
1638
1639         Reviewed by Simon Hausmann.
1640
1641         * MiniBrowser/qt/BrowserWindow.cpp:
1642         * MiniBrowser/qt/BrowserWindow.h:
1643         (BrowserWindow):
1644         * MiniBrowser/qt/MiniBrowser.qrc:
1645         * MiniBrowser/qt/useragentlist.txt: Removed.
1646
1647 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1648
1649         jhbuild: Call jhbuild's autogen.sh via bash.
1650         https://bugs.webkit.org/show_bug.cgi?id=81485
1651
1652         Reviewed by Philippe Normand.
1653
1654         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
1655         this is usually true only on Linux systems, and even then bash for
1656         some reason might not be available in that location. It is safer to
1657         call bash directly and pass autogen.sh to it instead.
1658
1659         * jhbuild/jhbuild-wrapper:
1660         (install_jhbuild):
1661
1662 2012-03-19  Philippe Normand  <pnormand@igalia.com>
1663
1664         [GTK] Prefix run-launcher with run-with-jhbuild
1665         https://bugs.webkit.org/show_bug.cgi?id=81503
1666
1667         Reviewed by Hajime Morita.
1668
1669         * Scripts/run-launcher:
1670
1671 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1672
1673         [EFL] Prefix run-launcher with run-with-jhbuild
1674         https://bugs.webkit.org/show_bug.cgi?id=80026
1675
1676         Reviewed by Hajime Morita.
1677
1678         * Scripts/run-launcher:
1679
1680 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1681
1682         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
1683         https://bugs.webkit.org/show_bug.cgi?id=81498
1684
1685         * qmake/mkspecs/features/unix/default_post.prf:
1686
1687 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1688
1689         Unreviewed; switch to using my FreeBSD.org email address, the
1690         other one is going to disappear soon.
1691
1692         * Scripts/webkitpy/common/config/committers.py:
1693         * Scripts/webkitpy/common/config/watchlist:
1694
1695 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1696
1697         Unreviewed; fix webkitpy unit test failures after r111116.
1698
1699         It turns out that cmd_line in the patch in bug 80025 had the right
1700         signature when it was submitted, but r109242 added a few more
1701         required parameters, and since the method (and EflDriver) did not
1702         exist at the time we ended up committing a broken method.
1703
1704         * Scripts/webkitpy/layout_tests/port/efl.py:
1705         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
1706         arguments.
1707
1708 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
1709
1710         [BlackBerry] Enable Web Timing for performance profiling and improvement.
1711         https://bugs.webkit.org/show_bug.cgi?id=81085
1712
1713         Reviewed by Rob Buis.
1714
1715         * Scripts/build-webkit:
1716
1717 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1718
1719         Add a dependencies installation step for EFL to buildbot master.cfg
1720         https://bugs.webkit.org/show_bug.cgi?id=81337
1721
1722         Reviewed by Gustavo Noronha Silva.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1725         (InstallEflDependencies):
1726         (Factory.__init__):
1727
1728 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1729
1730         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
1731         https://bugs.webkit.org/show_bug.cgi?id=80025
1732
1733         Reviewed by Gustavo Noronha Silva.
1734
1735         * Scripts/webkitpy/layout_tests/port/efl.py:
1736         (EflDriver):
1737         (EflDriver.cmd_line):
1738         (EflPort._driver_class):
1739
1740 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1741
1742         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
1743         https://bugs.webkit.org/show_bug.cgi?id=79904
1744
1745         build-webkit --efl will use jhbuild for fetching and building dependencies.
1746
1747         Reviewed by Gustavo Noronha Silva.
1748
1749         * Scripts/update-webkitefl-libs: Added.
1750         * Scripts/webkitdirs.pm:
1751         (jhbuildWrapperPrefixIfNeeded):
1752         (generateBuildSystemFromCMakeProject):
1753         (buildCMakeGeneratedProject):
1754         * efl/common.py: Added.
1755         (script_path):
1756         (top_level_path):
1757         (number_of_cpus):
1758         * efl/jhbuild.modules: Added.
1759         * efl/jhbuildrc: Added.
1760         * efl/run-with-jhbuild: Added.
1761
1762 2012-03-16  Stephanie Lewis  <slewis@apple.com>
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=81065
1765         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
1766         Fix crash preventing WebKitTestRunner from working in Release.  
1767         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
1768         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
1769         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
1770
1771         I removed ostringstream in favor of StringBuilder.  
1772
1773         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
1774
1775         Reviewed by Geoff Garen.
1776
1777         Add DEBUG_DEFINES to set NDEBUG on release builds.
1778         * WebKitTestRunner/Configurations/Base.xcconfig:
1779         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1780
1781         Remove ostringstream member in favor of StringBuilder.
1782         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1783         (WTR::InjectedBundle::initialize):
1784         (WTR::InjectedBundle::beginTesting):
1785         (WTR::InjectedBundle::done):
1786         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1787         (WTF):
1788         (WTR::InjectedBundle::stringBuilder):
1789         (InjectedBundle):
1790
1791         Append output to StringBuilder.
1792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1793         (WTR::hasPrefix):
1794         (WTR::dumpPath):
1795         (WTR::rangeToStr):
1796         (WTR::styleDecToStr):
1797         (WTR::frameToStr):
1798         (WTR::dumpFrameScrollPosition):
1799         (WTR::dumpFrameText):
1800         (WTR::dumpDescendantFramesText):
1801         (WTR::InjectedBundlePage::dump):
1802         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1803         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1804         (WTR::InjectedBundlePage::willSendRequestForFrame):
1805         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1806         (WTR::lastFileURLPathComponent):
1807         (WTR::InjectedBundlePage::willAddMessageToConsole):
1808         (WTR::InjectedBundlePage::willSetStatusbarText):
1809         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1810         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1811         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1812         (WTR::InjectedBundlePage::shouldBeginEditing):
1813         (WTR::InjectedBundlePage::shouldEndEditing):
1814         (WTR::InjectedBundlePage::shouldInsertNode):
1815         (WTR::InjectedBundlePage::shouldInsertText):
1816         (WTR::InjectedBundlePage::shouldDeleteRange):
1817         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1818         (WTR::InjectedBundlePage::shouldApplyStyle):
1819         (WTR::InjectedBundlePage::didBeginEditing):
1820         (WTR::InjectedBundlePage::didEndEditing):
1821         (WTR::InjectedBundlePage::didChange):
1822         (WTR::InjectedBundlePage::didChangeSelection):
1823         (WTR::InjectedBundlePage::supportsFullScreen):
1824         (WTR::InjectedBundlePage::enterFullScreenForElement):
1825         (WTR::InjectedBundlePage::exitFullScreenForElement):
1826         (WTR::InjectedBundlePage::beganEnterFullScreen):
1827         (WTR::InjectedBundlePage::beganExitFullScreen):
1828         (WTR::dumpBackForwardListItem):
1829         (WTR::InjectedBundlePage::dumpBackForwardList):
1830         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1831         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
1832         (WTR::LayoutTestController::dumpConfigurationForViewport):
1833         
1834         Convert between WTF::String and WKStringRef.
1835         * WebKitTestRunner/StringFunctions.h:
1836         (WTR::toWTFString):
1837         (WTR):
1838         * WebKitTestRunner/TestInvocation.cpp:
1839         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1840
1841 2012-03-16  Eric Seidel  <eric@webkit.org>
1842
1843         Add a land-from-url command
1844         https://bugs.webkit.org/show_bug.cgi?id=81411
1845
1846         Reviewed by Adam Barth.
1847
1848         Very basic so far.  The goal is to make it landing smarter
1849         so that users don't have to bother to parse out the ids out of the urls.
1850
1851         * Scripts/webkitpy/common/config/urls.py:
1852         (parse_bug_id):
1853         (parse_attachment_id):
1854         * Scripts/webkitpy/common/config/urls_unittest.py:
1855         (URLsTest.test_parse_bug_id):
1856         (URLsTest):
1857         (URLsTest.test_parse_attachment_id):
1858         * Scripts/webkitpy/tool/commands/download.py:
1859         (ProcessURLsMixin):
1860         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1861         (LandFromURL):
1862         * Scripts/webkitpy/tool/commands/download_unittest.py:
1863         (test_land_from_bug):
1864         (test_land_from_url):
1865
1866 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
1867
1868         build-webkit launcher instructions use wrong relative path for Qt
1869         https://bugs.webkit.org/show_bug.cgi?id=81357
1870
1871         Reviewed by Eric Seidel.
1872
1873         Ensure we are at the proper directory before generating run-launcher
1874         instructions.
1875
1876         * Scripts/build-webkit:
1877
1878 2012-03-16  Brady Eidson  <beidson@apple.com>
1879
1880         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1881         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1882
1883         Reviewed by Geoff Garen.
1884
1885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1886         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
1887
1888 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1889
1890         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
1891         https://bugs.webkit.org/show_bug.cgi?id=81407
1892
1893         Reviewed by Adam Barth.
1894
1895         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1896         (summarize_results):
1897         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1898         (ResultSummaryTest.summarized_results):
1899         (ResultSummaryTest.test_no_svn_revision):
1900         (ResultSummaryTest.test_svn_revision):
1901         (ResultSummaryTest):
1902         (ResultSummaryTest.test_summarized_results_wontfix):
1903
1904 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1905
1906         Have webkit-patch rebaseline-test update test_expectations.txt
1907         https://bugs.webkit.org/show_bug.cgi?id=81054
1908
1909         Recommit http://trac.webkit.org/changeset/110783 now that
1910         http://trac.webkit.org/changeset/111034 has landed.
1911
1912         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1913         (TestExpectations.remove_configuration_from_test):
1914         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1915         (RemoveConfigurationsTest):
1916         (RemoveConfigurationsTest.test_remove):
1917         (test_remove_line):
1918         * Scripts/webkitpy/tool/commands/rebaseline.py:
1919         (RebaselineTest._update_expectations_file):
1920         (RebaselineTest._rebaseline_test_and_update_expectations):
1921         (RebaselineTest):
1922         (RebaselineTest.execute):
1923         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1924         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1925         (test_rebaseline_updates_expectations_file):
1926
1927 2012-03-15  Ojan Vafai  <ojan@chromium.org>
1928
1929         Specifier collapsing when writing test expectations lines gets a number of cases wrong
1930         https://bugs.webkit.org/show_bug.cgi?id=81309
1931
1932         Reviewed by Dimitri Glazkov.
1933
1934         I've run this over all the lines in the current Chromium test_expectations.txt file,
1935         so I'm relatively confident we now cover all the cases.
1936
1937         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1938         (TestConfigurationConverter.__init__):
1939         (TestConfigurationConverter.collapse_macros):
1940         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
1941         (TestConfigurationConverter):
1942         (TestConfigurationConverter.intersect_combination):
1943         (TestConfigurationConverter.symmetric_difference):
1944         (TestConfigurationConverter.to_specifiers_list):
1945         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1946         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1947         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1948         (make_mock_all_test_configurations_set):
1949         (TestConfigurationConverterTest.test_symmetric_difference):
1950         (TestConfigurationConverterTest.test_to_config_set):
1951         (TestConfigurationConverterTest.test_macro_expansion):
1952         (TestConfigurationConverterTest.test_to_specifier_lists):
1953         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1954         * Scripts/webkitpy/layout_tests/port/chromium.py:
1955         (ChromiumPort):
1956         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1957         (ChromiumAndroidPort.__init__):
1958         The android port uses "arm" as it's architecture, which is technically correct,
1959         but considerably complicates making collapsing work. We probably should kill
1960         the concept of architecture entirely. The benefits are not worth the code
1961         complexity.
1962
1963         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1964         (ChromiumPortTest.test_all_test_configurations):
1965         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1966         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1967         (test_rebaseline_updates_expectations_file):
1968
1969 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
1970
1971         [Qt][Wk2] Assertion Failure and crash on file upload
1972         https://bugs.webkit.org/show_bug.cgi?id=80854
1973
1974         Reviewed by Simon Hausmann.
1975
1976         Added filePicker to WebView using experimental API.
1977
1978         * MiniBrowser/qt/MiniBrowser.qrc:
1979         * MiniBrowser/qt/icons/folder.png: Added.
1980         * MiniBrowser/qt/icons/titlebar.png: Added.
1981         * MiniBrowser/qt/icons/up.png: Added.
1982         * MiniBrowser/qt/qml/BrowserWindow.qml:
1983         * MiniBrowser/qt/qml/FilePicker.qml: Added.
1984
1985 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1986
1987         Updating email for committer.py script.
1988
1989         * Scripts/webkitpy/common/config/committers.py:
1990
1991 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
1992
1993         [chromium] DRT: Add support for sending gesture scrolls without a begin
1994         https://bugs.webkit.org/show_bug.cgi?id=81292
1995
1996         Reviewed by Kent Tamura.
1997
1998         * DumpRenderTree/chromium/EventSender.cpp:
1999         (EventSender::EventSender):
2000         (EventSender::gestureScrollFirstPoint):
2001         * DumpRenderTree/chromium/EventSender.h:
2002         (EventSender):
2003
2004 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
2005
2006         [GTK] WebKitIconDatabase doesn't keep icons cached
2007         https://bugs.webkit.org/show_bug.cgi?id=56200
2008
2009         Reviewed by Martin Robinson.
2010
2011         Add support for favicons in GtkLauncher.
2012
2013         * GtkLauncher/main.c:
2014         (activateUriEntryCb):
2015         (iconLoadedCb):
2016         (createBrowser):
2017
2018 2012-03-16  Adam Barth  <abarth@webkit.org>
2019
2020         Remove sheriff-bot's last-green-revision command
2021         https://bugs.webkit.org/show_bug.cgi?id=81314
2022
2023         Reviewed by Eric Seidel.
2024
2025         This command is a cruel joke.  WebKit doesn't really ever have a
2026         last-green-revision.
2027
2028         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2029         (BuildBot._find_green_revision):
2030         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2031         (MockBuildBot.builder_statuses):
2032         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2033         (test_find_green_revision):
2034         * Scripts/webkitpy/tool/bot/irc_command.py:
2035         (IRCCommand.execute):
2036         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2037         (SheriffIRCBotTest.test_help):
2038         * Scripts/webkitpy/tool/commands/queries.py:
2039         (PatchesToReview.execute):
2040
2041 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2042
2043         [Qt] Make gccdepends test aware of broken icecream deps generation
2044
2045         Icecream seems to build the files without passing -o to gcc with
2046         the original destination path, which means the target name in the
2047         dependency file is wrong.
2048
2049         Also, echo something to the final file instead of just touching it,
2050         so it's not deleted on every build.
2051
2052         Reviewed by Simon Hausmann.
2053
2054         * qmake/config.tests/gccdepends/gccdepends.pro:
2055
2056 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
2057
2058         Support for Battery Status API
2059         https://bugs.webkit.org/show_bug.cgi?id=62698
2060
2061         Add include directory and file.
2062         http://www.w3.org/TR/battery-status/
2063
2064         Reviewed by Adam Barth.
2065
2066         * Scripts/build-webkit:
2067
2068 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
2069
2070         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
2071         https://bugs.webkit.org/show_bug.cgi?id=81007
2072
2073         Reviewed by Adam Barth.
2074
2075         A dedidcated build slave is available for efl on build.webkit.org. 
2076         This change add's an entry for the elf port in list of available port builders.
2077         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
2078
2079         * Scripts/webkitpy/layout_tests/port/builders.py:
2080
2081 2012-03-16  Adam Barth  <abarth@webkit.org>
2082
2083         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
2084         https://bugs.webkit.org/show_bug.cgi?id=81302
2085
2086         Reviewed by Eric Seidel.
2087
2088         This is a trivial patch, but the variable name turned up in a grep of
2089         webkitpy and looks like copy pasta.
2090
2091         * Scripts/webkitpy/common/net/statusserver.py:
2092         (StatusServer.next_work_item):
2093
2094 2012-03-16  Andrew Lo  <anlo@rim.com>
2095
2096         [BlackBerry] Enable PAGE_VISIBILITY_API
2097         https://bugs.webkit.org/show_bug.cgi?id=81257
2098
2099         Enable Page Visibility API for BlackBerry.
2100
2101         Reviewed by Rob Buis.
2102
2103         * Scripts/build-webkit:
2104
2105 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
2106
2107         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
2108         https://bugs.webkit.org/show_bug.cgi?id=81232
2109
2110         Reviewed by Philippe Normand.
2111
2112         Use the newly-added helper method in DumpRenderTreeSupportGtk.
2113
2114         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2115         (LayoutTestController::computedStyleIncludingVisitedInfo):
2116
2117 2012-03-15  Eric Seidel  <eric@webkit.org>
2118
2119         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
2120         https://bugs.webkit.org/show_bug.cgi?id=81313
2121
2122         Reviewed by Adam Barth.
2123
2124         * Scripts/webkitpy/common/checkout/changelog.py:
2125         (parse_bug_id_from_changelog):
2126         * Scripts/webkitpy/common/config/urls.py:
2127         (parse_bug_id):
2128         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
2129         (URLsTest):
2130         (URLsTest.test_parse_bug_id):
2131         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2132         (test_parse_bug_id):
2133         * Scripts/webkitpy/tool/bot/irc_command.py:
2134         (_post_error_and_check_for_bug_url):
2135         * Scripts/webkitpy/tool/bot/sheriff.py:
2136         (Sheriff.post_rollout_patch):
2137         (Sheriff.post_chromium_deps_roll):
2138
2139 2012-03-15  Adam Barth  <abarth@webkit.org>
2140
2141         The commit-queue should fast-track patches that have already passed the testing EWS bots
2142         https://bugs.webkit.org/show_bug.cgi?id=81305
2143
2144         Reviewed by Eric Seidel.
2145
2146         If a patch has already passed the testing EWS bots (currently only the
2147         chromium-ews bot), we should be able to land the patch without running
2148         the tests again.  This patch is somewhat risky in that the tests might
2149         have been broken between when the EWS bots ran and when the
2150         commit-queue is processing the patch.  If that turns out to be a
2151         problem in practice, we'll tighten up this fast-track in some way,
2152         likely by making sure that the pass status is recent.
2153
2154         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2155         (CommitQueueTaskDelegate.did_pass_testing_ews):
2156         (CommitQueueTask._did_pass_tests_recently):
2157         (CommitQueueTask.run):
2158         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2159         (MockCommitQueue.did_pass_testing_ews):
2160         (test_fast_success_case):
2161         * Scripts/webkitpy/tool/commands/queues.py:
2162         (CommitQueue.did_pass_testing_ews):
2163         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2164         (test_did_pass_testing_ews):
2165
2166 2012-03-15  Kentaro Hara  <haraken@chromium.org>
2167
2168         [PerformanceTests] run-perf-tests should output correct units
2169         https://bugs.webkit.org/show_bug.cgi?id=78303
2170
2171         Reviewed by Ryosuke Niwa.
2172
2173         Previously run-perf-tests just supported "ms" for units.
2174         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
2175         This patch fixes run-perf-tests so that they can support custom units.
2176         The default unit is "ms".
2177
2178         The test result looks like this:
2179
2180         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
2181         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
2182         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
2183
2184         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2185         (PerfTestsRunner._process_parser_test_result):
2186
2187 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
2188
2189         [WinCairo] Unreviewed build change after wtf path changes.
2190
2191         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
2192         directories to look at the private header directory to find 'wtf'.
2193
2194 2012-03-15  Kent Tamura  <tkent@chromium.org>
2195
2196         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
2197         https://bugs.webkit.org/show_bug.cgi?id=81293
2198
2199         Reviewed by Adam Barth.
2200
2201         r110595 introduced new format of the author field of ChangeLog entry:
2202         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
2203         Updte chanelog.py to support it.
2204
2205         * Scripts/webkitpy/common/checkout/changelog.py:
2206         (ChangeLogEntry._split_contributor_names):
2207         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2208         (test_parse_authors):
2209
2210 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
2211
2212         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
2213
2214         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
2215
2216         Reviewed by Jessie Berlin.
2217
2218         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2219         (LayoutTestController::setValueForUser):
2220         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2221         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2222         (WTR::LayoutTestController::setValueForUser):
2223         (WTR):
2224         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2225         (LayoutTestController):
2226
2227 2012-03-15  Adam Barth  <abarth@webkit.org>
2228
2229         Update the start-queue.sh script to match what we're using on the bots
2230         https://bugs.webkit.org/show_bug.cgi?id=81277
2231
2232         Reviewed by Eric Seidel.
2233
2234         Over time we've added more magic git commands to clean up the local repo after
2235         it has been borked in various ways. The idea behind this sequence is to clear
2236         out any changes in the working copy and then to rebuild the master branch from
2237         origin/master.
2238
2239         This patch also removes the watchdog timer that we've stopped using on the
2240         bots.
2241
2242         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
2243         Note: Eric and I are experimenting with GitHub to see if it might be
2244         useful for WebKit.  If you have thoughts on this topic, please feel
2245         free to grab Eric or me on #webkit to chat.  I assume that he and I are
2246         the only ones who care about this file so using this alternative
2247         process for this patch shouldn't cause any trouble.
2248
2249         * EWSTools/start-queue.sh:
2250
2251 2012-03-15  Adam Barth  <abarth@webkit.org>
2252
2253         The commit-queue can hang when the test_expectations.txt style check fails during commit
2254         https://bugs.webkit.org/show_bug.cgi?id=81251
2255
2256         Reviewed by Eric Seidel.
2257
2258         We forgot to check the --non-interactive flag, so we end up prompting
2259         the "user" who doesn't exist on the bot.  We might consider teaching
2260         the User class about non-interactive if we have this sort of bug again.
2261
2262         * Scripts/webkitpy/tool/steps/commit.py:
2263         (Commit.options):
2264         (Commit._check_test_expectations):
2265         (Commit.run):
2266         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2267         (CommitTest.test_check_test_expectations):
2268
2269 2012-03-15  Jessie Berlin  <jberlin@apple.com>
2270
2271         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
2272         Mac WK2 because WebAudio is not enabled
2273         https://bugs.webkit.org/show_bug.cgi?id=81259
2274
2275         Reviewed by Dan Bernstein.
2276
2277         Enable WebAudio so that it appears in the window object in the tests.
2278         The webaudio tests are all still skipped in the Mac Skipped list.
2279
2280         * WebKitTestRunner/TestController.cpp:
2281         (WTR::TestController::resetStateToConsistentValues):
2282
2283 2012-03-15  David Levin  <levin@chromium.org>
2284
2285         Various autoresize fixes.
2286         https://bugs.webkit.org/show_bug.cgi?id=81199
2287
2288         Reviewed by Darin Fisher.
2289
2290         * DumpRenderTree/chromium/LayoutTestController.cpp:
2291         (LayoutTestController::reset): Stop using the deprecated api that was removed.
2292
2293 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         [GTK] Actually use --release and --debug command line options in run-gtk-test
2296         https://bugs.webkit.org/show_bug.cgi?id=81234
2297
2298         Reviewed by Philippe Normand.
2299
2300         Actually handle --release and --debug command line options to
2301         create the build directory, falling back to current hack to detect
2302         whether it's a Release or Debug build when both options are missed.
2303
2304         * Scripts/run-gtk-tests:
2305         (TestRunner.__init__): Receive options too.
2306         (TestRunner._get_top_level_directory): Helper function to get the
2307         top level directory.
2308         (TestRunner._get_build_directory): Helper function to get the
2309         build directory depending on --release/--debug command line
2310         options or gessing it if both options are missing.
2311         (TestRunner._ensure_accessibility_daemon_is_running): Use
2312         self-options now.
2313         (TestRunner.run): Ditto.
2314         (TestRunner.run.run_tests): Pass options to the constructor
2315         instead of run().
2316
2317 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2318
2319         [GTK] Run unit tests with --verbose in the bots
2320         https://bugs.webkit.org/show_bug.cgi?id=81230
2321
2322         Reviewed by Martin Robinson.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2325         (RunGtkAPITests): Add --verbose to run-gtk-test command.
2326
2327 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2328
2329         Move wx port to using export macros
2330         https://bugs.webkit.org/show_bug.cgi?id=77279
2331
2332         Reviewed by Hajime Morita.
2333
2334         * waf/build/settings.py:
2335         (common_configure):
2336
2337 2012-03-15  Philippe Normand  <pnormand@igalia.com>
2338
2339         Unreviewed, GTK build fix attempt after r110845.
2340
2341         * Scripts/run-gtk-tests: Added --release and --debug options.
2342
2343 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2344
2345         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
2346         https://bugs.webkit.org/show_bug.cgi?id=79673
2347
2348         Preparatory work for bringing jhbuild enabled build to EFL port.
2349
2350         Reviewed by Philippe Normand.
2351
2352         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
2353         * Scripts/update-webkitgtk-libs:
2354         * gtk/run-with-jhbuild:
2355         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
2356         (top_level_path):
2357         (jhbuild_installed):
2358         (jhbuild_cloned):
2359         (jhbuild_at_expected_revision):
2360         (update_jhbuild):
2361         (clone_jhbuild):
2362         (install_jhbuild):
2363         (update_webkit_libs_jhbuild):
2364         (determine_platform):
2365         (ensure_jhbuild):
2366
2367 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2368
2369         [GTK] Add command line options to run-gtk-tests script
2370         https://bugs.webkit.org/show_bug.cgi?id=81218
2371
2372         Reviewed by Philippe Normand.
2373
2374         Following command line options have been added:
2375
2376         -v, --verbose: to run gtester with --verbose. That would be used
2377         by the bots to make it easier to know which test case it failing.
2378
2379         --display: to use a different display for Xvfb
2380
2381         It's also possible to pass one or more tests as arguments.
2382
2383         * Scripts/run-gtk-tests:
2384         (TestRunner.__init__): Receive command line arguments.
2385         (TestRunner._get_tests): Get all the tests or the ones passed by
2386         command line arguments.
2387         (TestRunner._ensure_accessibility_daemon_is_running): Use display
2388         command line argument.
2389         (TestRunner.run): Pas command line options.
2390         (TestRunner.run.run_tests): Pass command line arguments.
2391
2392 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2393
2394         [GTK] WebKit2APITests/TestPrinting timeout in the bots
2395         https://bugs.webkit.org/show_bug.cgi?id=81211
2396
2397         Reviewed by Philippe Normand.
2398
2399         Add gtk+ patch to fix timeout in the bots. A similar patch has
2400         already landed in updatream gtk+, see
2401         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
2402
2403         * gtk/jhbuild.modules:
2404         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
2405
2406 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
2407
2408         sheriffbot should also be addressable with a comma in addition to colon
2409         https://bugs.webkit.org/show_bug.cgi?id=81101
2410
2411         Reviewed by Adam Barth.
2412
2413         * Scripts/webkitpy/common/net/irc/ircbot.py:
2414         (IRCBot.on_pubmsg):
2415
2416 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
2417
2418         [Qt] MiniBrowser scroll indicators should not scroll out of view
2419         https://bugs.webkit.org/show_bug.cgi?id=81131
2420
2421         Reviewed by Kenneth Rohde Christiansen.
2422
2423         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2424
2425 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
2426
2427         AX: ARIA tables need to support selected rows attribute/select rows changed notification
2428         https://bugs.webkit.org/show_bug.cgi?id=79821
2429
2430         Reviewed by Beth Dakin.
2431
2432         * DumpRenderTree/AccessibilityUIElement.cpp:
2433         (rowAtIndexCallback):
2434         (AccessibilityUIElement::getJSClass):
2435         * DumpRenderTree/AccessibilityUIElement.h:
2436         (AccessibilityUIElement):
2437         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2438         (AccessibilityUIElement::rowAtIndex):
2439         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2440         (AccessibilityUIElement::rowAtIndex):
2441         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2442         (AccessibilityUIElement::rowAtIndex):
2443         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2444         (AccessibilityUIElement::rowAtIndex):
2445
2446 2012-03-14  Tim Horton  <timothy_horton@apple.com>
2447
2448         NRWT should respect --additional-platform-directory's Skipped list
2449         https://bugs.webkit.org/show_bug.cgi?id=81172
2450
2451         Reviewed by Timothy Hatcher.
2452
2453         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
2454         from said path are already used, but the Skipped file is ignored.
2455
2456         * Scripts/webkitpy/layout_tests/port/webkit.py:
2457         (WebKitPort._skipped_file_search_paths):
2458         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2459         (test_skipped_file_search_paths):
2460
2461 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2462
2463         Unreviewed, rolling out r110783.
2464         http://trac.webkit.org/changeset/110783
2465         https://bugs.webkit.org/show_bug.cgi?id=81054
2466
2467         Caused existing test expectation lines to expand to one for
2468         each test configuration.
2469
2470         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2471         (TestExpectations.has_warnings):
2472         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2473         (test_macro_overrides):
2474         * Scripts/webkitpy/tool/commands/rebaseline.py:
2475         (RebaselineTest._save_baseline):
2476         (RebaselineTest._rebaseline_test):
2477         (RebaselineTest.execute):
2478         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2479         (TestRebaseline.test_tests_to_update):
2480
2481 2012-03-13  Jon Lee  <jonlee@apple.com>
2482
2483         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
2484         https://bugs.webkit.org/show_bug.cgi?id=80922
2485         <rdar://problem/11035082>
2486
2487         Reviewed by Jian Li.
2488
2489         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
2490         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
2491         new API. Therefore, APIs that are common between the two will have:
2492         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2493
2494         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
2495         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
2496
2497         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2498         * DumpRenderTree/chromium/LayoutTestController.cpp:
2499         (LayoutTestController::grantDesktopNotificationPermission):
2500         (LayoutTestController::simulateDesktopNotificationClick):
2501         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2502         * DumpRenderTree/chromium/TestShell.cpp:
2503         (TestShell::TestShell):
2504         (TestShell::resetTestController):
2505         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2506         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2507
2508 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2509
2510         Have webkit-patch rebaseline-test update test_expectations.txt
2511         https://bugs.webkit.org/show_bug.cgi?id=81054
2512
2513         Reviewed by Dirk Pranke.
2514
2515         This will allow us to use the All Failures tab in garden-o-matic
2516         to rebaseline tests without making test_expectations.txt stale.
2517
2518         It's conservative and only removes lines if the test is
2519         not flaky and fails in a way the rebaseline would fix (e.g.
2520         CRASH/TIMEOUT will not be touched).
2521
2522         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2523         (TestExpectations.remove_configuration_from_test):
2524         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2525         (RemoveConfigurationsTest):
2526         (RemoveConfigurationsTest.test_remove):
2527         (test_remove_line):
2528         * Scripts/webkitpy/tool/commands/rebaseline.py:
2529         (RebaselineTest._is_supported_port):
2530         (RebaselineTest):
2531         (RebaselineTest._update_expectations_file):
2532         (RebaselineTest._rebaseline_test_and_update_expectations):
2533         (RebaselineTest.execute):
2534         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2535         (TestRebaseline.test_rebaseline_updates_expectations_file):
2536
2537 2012-03-14  Jessie Berlin  <jberlin@apple.com>
2538
2539         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
2540         https://bugs.webkit.org/show_bug.cgi?id=81167
2541
2542         Reviewed by Sam Weinig.
2543
2544         Do not use 0 as a key in a HashMap.
2545
2546         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2547         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
2548
2549 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2550
2551         Add the chromium lion bot to garden-o-matic and remove
2552         the platform_move_to in builders.py since the Chromium Lion
2553         port is now a normal port.
2554
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2556         * Scripts/webkitpy/layout_tests/port/builders.py:
2557
2558 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2559
2560         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
2561
2562         Unreviewed, build fix.
2563
2564         * Scripts/webkitpy/layout_tests/port/base.py:
2565         (Port.skipped_tests):
2566
2567 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2568
2569         Please add a way to manually skip some tests in NRWT
2570         https://bugs.webkit.org/show_bug.cgi?id=81019
2571
2572         Reviewed by Ojan Vafai.
2573
2574         This patch implements the -i / --ignore-tests flag from ORWT
2575         and refactors the test_expectations.py code slightly to handle
2576         it.
2577
2578         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2579         (Manager.parse_expectations):
2580         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2581         (TestExpectations.__init__):
2582         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2583         (test_add_skipped_tests):
2584         (test_add_skipped_tests_duplicate):
2585         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2586         (parse_args):
2587         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2588         (MainTest.test_ignore_tests):
2589         (MainTest.test_ignore_tests.assert_ignored):
2590
2591 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2592
2593         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
2594         https://bugs.webkit.org/show_bug.cgi?id=81028
2595
2596         Reviewed by Ojan Vafai.
2597
2598         The mac port had incorrect lookups for 'mac-lion' and
2599         'mac-future' in some places. This patch fixes that and adds a
2600         bunch of tests.
2601
2602         * Scripts/webkitpy/layout_tests/port/mac.py:
2603         (MacPort.baseline_path):
2604         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2605         (MacTest.assert_skipped_file_search_paths):
2606         (MacTest.test_skipped_file_search_paths):
2607         (_assert_search_path):
2608         (test_baseline_search_path):
2609         * Scripts/webkitpy/layout_tests/port/webkit.py:
2610         (WebKitPort._skipped_file_search_paths):
2611
2612 2012-03-13  Jer Noble  <jer.noble@apple.com>
2613
2614         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
2615         https://bugs.webkit.org/show_bug.cgi?id=81056
2616
2617         Reviewed by Jessie Berlin.
2618
2619         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
2620
2621         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2622         (WTR::InjectedBundlePage::InjectedBundlePage):
2623         (WTR::InjectedBundlePage::beganEnterFullScreen):
2624         (WTR::InjectedBundlePage::beganExitFullScreen):
2625
2626 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2627
2628         The width and height of the scroll indicators in the MiniBrowser does
2629         not consider the offset margins.
2630         https://bugs.webkit.org/show_bug.cgi?id=81112
2631
2632         Reviewed by Kenneth Rohde Christiansen.
2633
2634         This patch fixes the issue by withdrawing two times the anchor
2635         margins.
2636
2637         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2638
2639 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2640
2641         [EFL] Implement LayoutTestController::clearBackForwardList
2642         https://bugs.webkit.org/show_bug.cgi?id=80142
2643
2644         Adding missing implementation clearBackForwardList to EFL's
2645         LayoutTestController. This implementation allows us to unskip 
2646         tests connected with history.
2647
2648         Reviewed by Antonio Gomes.
2649
2650         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2651         (LayoutTestController::clearBackForwardList): Implemented.
2652
2653 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2654
2655         [EFL][DRT] Expose window.internals object
2656         https://bugs.webkit.org/show_bug.cgi?id=79900
2657
2658         Exposes window.internals for EFL's DRT. Makes possible to
2659         remove some tests from the skip list.
2660
2661         Reviewed by Antonio Gomes.
2662
2663         * DumpRenderTree/efl/CMakeLists.txt:
2664         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2665         (DumpRenderTreeChrome::onWindowObjectCleared):
2666
2667 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
2668
2669         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2670         https://bugs.webkit.org/show_bug.cgi?id=78853
2671
2672         Reviewed by Adam Barth.
2673
2674         * Scripts/build-webkit:
2675         * qmake/mkspecs/features/features.prf:
2676
2677 2012-03-12  Antonio Gomes  <agomes@rim.com>
2678
2679         Convert nodesFromRect tests to use Internals interface
2680         https://bugs.webkit.org/show_bug.cgi?id=80886
2681
2682         Reviewed by Ryosuke Niwa.
2683
2684         This clean up allows to remove port specific bits of each
2685         DRT implementation that supports testing Document::nodesFromRect,
2686         in favor of making use of the 'Internals' interface to test it.
2687
2688         This makes its code conveniently more expansible and cleaner.
2689
2690         Also removed stubs from Win and EFL DRTs.
2691
2692         * DumpRenderTree/LayoutTestController.cpp:
2693         (LayoutTestController::staticFunctions):
2694         * DumpRenderTree/LayoutTestController.h:
2695         (LayoutTestController):
2696         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2697         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2698         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2699         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2700         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2701         (LayoutTestController):
2702         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2703
2704 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2705
2706         Rebaselining for a new port doesn't work right with multiple fallback ports
2707         https://bugs.webkit.org/show_bug.cgi?id=80932
2708
2709         Reviewed by Adam Barth.
2710
2711         Since chromium-leopard also falls back to mac-leopard, we need to
2712         copy the existing result for both chromium-leopard and chromium-snowleopard
2713         before doing lion rebaselines.
2714
2715         * Scripts/webkitpy/layout_tests/port/builders.py:
2716         (fallback_port_names_for_new_port):
2717         * Scripts/webkitpy/tool/commands/rebaseline.py:
2718         (RebaselineTest):
2719         (RebaselineTest._copy_existing_baseline):
2720         (RebaselineTest._rebaseline_test):
2721         (RebaselineTest.execute):
2722         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2723         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2724         (GardeningHTTPRequestHandler.rebaseline):
2725         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2726         (GardeningServerTest.test_rebaseline_new_port):
2727
2728 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2729
2730         [Qt] Tweak minibrowser UI
2731
2732         Add some margins to the scroll indicators, and set a dark background
2733         color so you see the page dimensions.
2734
2735         Reviewed by Antonio Gomes.
2736
2737         * MiniBrowser/qt/qml/BrowserWindow.qml:
2738         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2739
2740 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2741
2742         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
2743         https://bugs.webkit.org/show_bug.cgi?id=79601
2744
2745         Reviewed by Gustavo Noronha Silva.
2746
2747         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
2748         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
2749         and is taken over to sendKeyDown.
2750         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2751         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2752
2753         * DumpRenderTree/efl/EventSender.cpp:
2754         (KeyEventInfo::KeyEventInfo):
2755         (KeyEventInfo):
2756         (createKeyEventInfo):
2757         (sendKeyDown):
2758         (keyDownCallback):
2759         (sendAsynchronousKeyDown):
2760         (scheduleAsynchronousKeyDownCallback):
2761
2762 2012-03-12  Ojan Vafai  <ojan@chromium.org>
2763
2764         webkit-patch optimize-baselines sometimes creates a mac-future result
2765         https://bugs.webkit.org/show_bug.cgi?id=80717
2766
2767         Reviewed by Adam Barth.
2768
2769         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2770         (_baseline_search_hypergraph):
2771         (BaselineOptimizer._find_optimal_result_placement):
2772         (BaselineOptimizer._filter_virtual_ports):
2773         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2774         (BaselineOptimizerTest.test_no_add_mac_future):
2775
2776 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2777
2778         More Windows build fixing.
2779
2780         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2781
2782 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2783
2784         More Windows build fixing.
2785
2786         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2787         * DumpRenderTree/win/EditingDelegate.cpp:
2788         * DumpRenderTree/win/EventSender.cpp:
2789         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2790         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2791         * DumpRenderTree/win/UIDelegate.cpp:
2792
2793 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2794
2795         remove the 'gpu' group from the flakiness dashboard
2796         https://bugs.webkit.org/show_bug.cgi?id=80353
2797
2798         Reviewed by Adam Barth.
2799
2800         Since those bots are obsolete, we don't need this any more.
2801
2802         * TestResultServer/static-dashboards/builders.js:
2803         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2804         (testPlatformAndBuildType):
2805         (testHtmlForTestTypeSwitcherGroup):
2806
2807 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2808
2809         remove graphics_type from webkitpy.layout_tests.models.test_configuration
2810         https://bugs.webkit.org/show_bug.cgi?id=80643
2811
2812         Reviewed by Ojan Vafai.
2813
2814         Now that the chromium-gpu ports are gone, there's no need for
2815         the graphics_type CPU/GPU distinction. Most of this change is
2816         just updating tests accordingly.
2817
2818         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2819         (TestExpectationEditorTests):
2820         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2821         (TestConfiguration.__init__):
2822         (TestConfiguration.category_order):
2823         (TestConfiguration.__str__):
2824         (TestConfiguration.__repr__):
2825         (TestConfiguration.__hash__):
2826         (TestConfigurationConverter.to_specifiers_list):
2827         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2828         (make_mock_all_test_configurations_set):
2829         (TestConfigurationTest.test_items):
2830         (TestConfigurationTest.test_keys):
2831         (TestConfigurationTest.test_str):
2832         (TestConfigurationTest.test_repr):
2833         (TestConfigurationTest.test_hash):
2834         (TestConfigurationTest.test_hash.query_unknown_key):
2835         (TestConfigurationTest.test_eq):
2836         (TestConfigurationTest.test_values):
2837         (SpecifierSorterTest.test_specifier_priority):
2838         (SpecifierSorterTest.test_sort_specifiers):
2839         (TestConfigurationConverterTest.test_to_config_set):
2840         (TestConfigurationConverterTest.test_macro_expansion):
2841         (TestConfigurationConverterTest.test_to_specifier_lists):
2842         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2843         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2844         (test_error_on_different_build_type):
2845         (TestExpectationSerializerTests.test_parsed_to_string):
2846         (TestExpectationSerializerTests.test_reconstitute_only_these):
2847         * Scripts/webkitpy/layout_tests/port/apple.py:
2848         (ApplePort._generate_all_test_configurations):
2849         * Scripts/webkitpy/layout_tests/port/base.py:
2850         (Port.__init__):
2851         (Port.name):
2852         (Port.version):
2853         (Port.test_configuration):
2854         * Scripts/webkitpy/layout_tests/port/builders.py:
2855         * Scripts/webkitpy/layout_tests/port/chromium.py:
2856         (ChromiumPort):
2857         (ChromiumPort._generate_all_test_configurations):
2858         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2859         (ChromiumLinuxPort.__init__):
2860         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2861         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2862         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2863         (ChromiumMacPortTest.test_baseline_path):
2864         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2865         (ChromiumPortTest.test_all_test_configurations):
2866         * Scripts/webkitpy/layout_tests/port/efl.py:
2867         (EflPort._generate_all_test_configurations):
2868         * Scripts/webkitpy/layout_tests/port/gtk.py:
2869         (GtkPort._generate_all_test_configurations):
2870         * Scripts/webkitpy/layout_tests/port/qt.py:
2871         (QtPort._generate_all_test_configurations):
2872         * Scripts/webkitpy/layout_tests/port/test.py:
2873         (TestPort.all_test_configurations):
2874         (TestPort._all_build_types):
2875         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2876         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2877         (BuildCoverageExtrapolatorTest.test_extrapolate):
2878         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
2879         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
2880         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
2881         (GardeningExpectationsUpdaterTest.test_pass_expectation):
2882         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
2883         (GardeningExpectationsUpdaterTest.test_spurious_updates):
2884
2885 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2886
2887         _runtime_feature_list isn't supported on Apple Mac DRT
2888         https://bugs.webkit.org/show_bug.cgi?id=80906
2889
2890         Reviewed by Eric Seidel.
2891
2892         It looks like this feature is actually only supported on the Win
2893         DRT port, so this patch reworks the code to make that clearer
2894         and reduce unnecessary overrides.
2895
2896         * Scripts/webkitpy/layout_tests/port/efl.py:
2897         (EflPort._path_to_webcore_library):
2898         * Scripts/webkitpy/layout_tests/port/gtk.py:
2899         (GtkPort._path_to_webcore_library):
2900         * Scripts/webkitpy/layout_tests/port/qt.py:
2901         (QtPort._skipped_file_search_paths):
2902         * Scripts/webkitpy/layout_tests/port/webkit.py:
2903         (WebKitPort._runtime_feature_list):
2904         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2905         (TestWebKitPort.__init__):
2906         (TestWebKitPort.all_test_configurations):
2907         (test_skipped_directories_for_features):
2908         * Scripts/webkitpy/layout_tests/port/win.py:
2909         (WinPort):
2910         (WinPort._runtime_feature_list):
2911         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2912         (WinPortTest.test_operating_system):
2913         (WinPortTest):
2914         (WinPortTest.test_runtime_feature_list):
2915
2916 2012-03-12  Peter Beverloo  <peter@chromium.org>
2917
2918         [Chromium] Temporary build-fix for the Android bot
2919         https://bugs.webkit.org/show_bug.cgi?id=80862
2920
2921         Reviewed by Adam Barth.
2922
2923         Manually set the environmental variables required to compile source
2924         files through the Android NDK instead of relying on the envsetup.sh
2925         script. A proper fix will be landed to Chromium ASAP, and following
2926         a Chromium roll into WebKit this code will be removed.
2927
2928         * Scripts/webkitdirs.pm:
2929         (buildChromiumMakefile):
2930
2931 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2932
2933         [Qt] Use right construct to detect config_test_gccdepends
2934
2935         Reviewed by Andreas Kling.
2936
2937         * qmake/mkspecs/features/default_pre.prf:
2938
2939 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2940
2941         [Qt] Expose location of WebKit's bin and imports dir through module file
2942
2943         Reviewed by Andreas Kling.
2944
2945         * qmake/qt_webkit.pri:
2946
2947 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
2948
2949         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
2950         https://bugs.webkit.org/show_bug.cgi?id=80832
2951
2952         Reviewed by Tor Arne Vestbø.
2953
2954         Add a basic scroll indicator component to MiniBrowser so that it
2955         behaves similar to the ScrollDecorator QML component.
2956
2957         * MiniBrowser/qt/MiniBrowser.qrc:
2958         * MiniBrowser/qt/qml/BrowserWindow.qml:
2959         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
2960
2961 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
2962
2963         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
2964         https://bugs.webkit.org/show_bug.cgi?id=80809
2965
2966         Reviewed by Philippe Normand.
2967
2968         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
2969
2970 2012-03-12  Ming Xie  <mxie@rim.com>
2971
2972         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
2973         https://bugs.webkit.org/show_bug.cgi?id=80812
2974
2975         Reviewed by Rob Buis.
2976
2977         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
2978         * Scripts/webkitdirs.pm:
2979         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
2980
2981
2982 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
2983
2984         [Qt] Fix build with newer Qt 5.
2985
2986         Reviewed by Tor Arne Vestbø.
2987
2988         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
2989         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
2990         we should disable -Werror.
2991
2992         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
2993         implicit load was removed recently.
2994
2995         * qmake/mkspecs/features/default_pre.prf:
2996         * qmake/mkspecs/features/unix/default_post.prf:
2997
2998 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
2999
3000         Add --instruments option to sunspider to profile with Instruments
3001         https://bugs.webkit.org/show_bug.cgi?id=80783
3002
3003         Reviewed by Filip Pizlo.
3004
3005         * Scripts/run-sunspider:
3006
3007 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3008
3009         [Qt] [WK2] Support threaded renderer in WK2
3010         https://bugs.webkit.org/show_bug.cgi?id=76661
3011
3012         Remove disabling of threaded rendering.
3013
3014         Reviewed by Noam Rosenthal.
3015
3016         * MiniBrowser/qt/main.cpp:
3017         (main):
3018
3019 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
3020
3021         [WK2] run-perf-tests should be able to run with WTR
3022         https://bugs.webkit.org/show_bug.cgi?id=80042
3023
3024         Reviewed by Martin Robinson.
3025
3026         Add an option to PerfTestRunner to use WebKitTestRunner instead of
3027         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
3028         to avoid timing out when running performance tests.
3029
3030         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3031         (PerfTestsRunner._parse_args):
3032         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3033         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
3034         to true.
3035         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
3036         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
3037         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3038         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3039         publicly accessible.
3040         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3041         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
3042         is required.
3043         * WebKitTestRunner/TestController.cpp:
3044         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
3045         to true.
3046         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
3047         if '--no-timeout' option is present.
3048         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
3049         value, or -1.0 if timeout should not occur.
3050         * WebKitTestRunner/TestController.h:
3051         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3052         publicly accessible.
3053         * WebKitTestRunner/TestInvocation.cpp:
3054         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
3055         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
3056         Waiting for final message should not time out if not necessary.
3057         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3058         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
3059         * WebKitTestRunner/qt/TestControllerQt.cpp:
3060         (WTR::TestController::platformRunUntil): Ditto.
3061         * WebKitTestRunner/mac/TestControllerMac.mm:
3062         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
3063         is missing.
3064         * WebKitTestRunner/win/TestControllerWin.cpp:
3065         (WTR::TestController::platformRunUntil): Ditto.
3066
3067 2012-03-09  Jon Lee  <jonlee@apple.com>
3068
3069         Rename NotificationPresenter to NotificationClient
3070         https://bugs.webkit.org/show_bug.cgi?id=80488
3071         <rdar://problem/10965558>
3072
3073         Reviewed by Kentaro Hara.
3074
3075         Refactor to use renamed WebCore::NotificationClient.
3076         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3077         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3078
3079 2012-03-07  James Robinson  <jamesr@chromium.org>
3080
3081         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
3082         https://bugs.webkit.org/show_bug.cgi?id=80523
3083
3084         Reviewed by Darin Fisher.
3085
3086         * DumpRenderTree/chromium/WebViewHost.cpp:
3087         (WebViewHost::createGraphicsContext3D):
3088         * DumpRenderTree/chromium/WebViewHost.h:
3089         (WebViewHost):
3090
3091 2012-03-09  Eric Seidel  <eric@webkit.org>
3092
3093         build-webkit should build Source/WTF on Mac
3094         https://bugs.webkit.org/show_bug.cgi?id=80728
3095
3096         Reviewed by Adam Barth.
3097
3098         We'll add other ports to this list in future commits.
3099
3100         * Scripts/build-webkit:
3101
3102 2012-03-09  Jon Lee  <jonlee@apple.com>
3103
3104         Add support for ENABLE(LEGACY_NOTIFICATIONS)
3105         https://bugs.webkit.org/show_bug.cgi?id=80497
3106
3107         Reviewed by Adam Barth.
3108
3109         Prep for b80472: Update API for Web Notifications
3110         * Scripts/build-webkit:
3111         * qmake/mkspecs/features/features.prf:
3112
3113 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
3114
3115         Bash scripts should support LF endings only
3116         https://bugs.webkit.org/show_bug.cgi?id=79509
3117
3118         Reviewed by David Kilzer.
3119
3120         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
3121         * EWSTools/start-queue.sh: Added property svn:eol-style.
3122         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
3123         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
3124         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
3125         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
3126
3127 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
3128
3129         [BUILD] use detected python to run generate-gtkdoc
3130         https://bugs.webkit.org/show_bug.cgi?id=80695
3131
3132         Reviewed by Gustavo Noronha Silva.
3133
3134         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
3135
3136 2012-03-09  Nat Duca  <nduca@chromium.org>
3137
3138         Make check-webkit-style complain about "no new tests" lines in changelogs
3139         https://bugs.webkit.org/show_bug.cgi?id=80582
3140
3141         Reviewed by David Levin.
3142
3143         * Scripts/webkitpy/style/checkers/changelog.py:
3144         (ChangeLogChecker.check_entry):
3145         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3146         (ChangeLogCheckerTest.test_no_new_tests):
3147
3148 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3149
3150         Unreviewed, rolling out r110250.
3151         http://trac.webkit.org/changeset/110250
3152         https://bugs.webkit.org/show_bug.cgi?id=80682
3153
3154         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
3155         qt-linux at all. (Requested by Ossy on #webkit).
3156
3157         * Scripts/old-run-webkit-tests:
3158         * Scripts/webkitpy/layout_tests/port/qt.py:
3159         (QtPort):
3160         (QtPort.determine_full_port_name):
3161         (QtPort.baseline_search_path):
3162         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3163         (QtPortTest):
3164         (QtPortTest._assert_search_path):
3165         (QtPortTest.test_baseline_search_path):
3166
3167 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3168
3169         [Qt] Use Qt's module system for install rules and depending on QtWebKit
3170
3171         Instead of rolling our own install rules we now use the same approach as
3172         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
3173
3174         This ensures that we follow the same semantics as the rest of Qt on
3175         what sort of config options are enabled by default (create_cmake eg.).
3176         It also allows us to use QT += webkit instead of the workaround we had
3177         with CONFIG += qtwebkit.
3178
3179         We do however force Qt to always treat our build as a non-developer build,
3180         so the libraries will end up in the WebKit lib directory instead of the
3181         qtbase directory (as with a normal developer-build). This allows us to
3182         keep the webkit-build self-contained. If Qt is a developer build we still
3183         copy the module file manually to Qt, so that you don't have to install
3184         WebKit to make it available.
3185
3186         For non-developer builds of Qt, it is still possible to use the built
3187         WebKit libraries without having to install them, by having the variable
3188         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
3189         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
3190
3191         https://bugs.webkit.org/show_bug.cgi?id=80590
3192
3193         Reviewed by Simon Hausmann.
3194
3195         * DumpRenderTree/qt/DumpRenderTree.pro:
3196         * MiniBrowser/qt/BrowserWindow.cpp:
3197         * MiniBrowser/qt/MiniBrowser.pro:
3198         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3199         * MiniBrowser/qt/UrlLoader.cpp:
3200         * QtTestBrowser/QtTestBrowser.pro:
3201         * Tools.pro:
3202         * WebKitTestRunner/InjectedBundle/Target.pri:
3203         * WebKitTestRunner/Target.pri:
3204         * qmake/mkspecs/features/default_post.prf:
3205         * qmake/mkspecs/features/default_pre.prf:
3206         * qmake/mkspecs/features/functions.prf:
3207         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
3208         * qmake/mkspecs/features/qtwebkit.prf:
3209         * qmake/mkspecs/features/rpath.prf:
3210         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
3211         * qmake/qt_webkit.pri: Added.
3212
3213 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
3214
3215         Unreviewed. Update my email.
3216
3217         * Scripts/webkitpy/common/config/committers.py:
3218
3219 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3220
3221         Recent changes to chromium.py etc. broke chromium_android.py
3222         https://bugs.webkit.org/show_bug.cgi?id=80623
3223
3224         Reviewed by Dirk Pranke.
3225
3226         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3227         (ChromiumAndroidDriver.__init__):
3228         (ChromiumAndroidDriver._start):
3229
3230 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3231
3232         [Chromium] Exception running reftest with --no-pixel-tests
3233         https://bugs.webkit.org/show_bug.cgi?id=80642
3234
3235         Reviewed by Dirk Pranke.
3236
3237         * Scripts/webkitpy/layout_tests/port/chromium.py:
3238         (ChromiumDriver.__init__):
3239         (ChromiumDriver._wrapper_options):
3240
3241 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
3242
3243         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3244         https://bugs.webkit.org/show_bug.cgi?id=72489
3245
3246         Reviewed by Dirk Pranke.
3247
3248         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3249         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3250         --platform will override the platform name and then we'll use it.
3251
3252         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3253         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
3254         override it in the end.
3255
3256         * Scripts/old-run-webkit-tests:
3257         * Scripts/webkitpy/layout_tests/port/qt.py:
3258         (QtPort):
3259         (QtPort.determine_full_port_name):
3260         (QtPort.baseline_search_path):
3261         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3262         (QtPortTest):
3263         (QtPortTest._assert_search_path):
3264         (QtPortTest.test_baseline_search_path):
3265
3266 2012-03-08  Beth Dakin  <bdakin@apple.com>
3267
3268         https://bugs.webkit.org/show_bug.cgi?id=80463
3269         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
3270         -and corresponding-
3271         <rdar://problem/10970221>
3272
3273         Reviewed by Dan Bernstein.
3274
3275         New test!
3276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3277         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
3278         (TestWebKitAPI):
3279         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3280         (TestWebKitAPI::setPageLoaderClient):
3281         (TestWebKitAPI::TEST):
3282         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
3283         (TestWebKitAPI):
3284         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
3285         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
3286         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
3287         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
3288
3289 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3290
3291         [Qt] Prospective Windows build fix
3292
3293         Don't assume that windows-builds will always run inside a cmd.exe shell.
3294
3295         * qmake/mkspecs/features/default_pre.prf:
3296
3297 2012-03-08  Dan Bernstein  <mitz@apple.com>
3298
3299         <rdar://problem/10981173> Dashboard regions should not be in device space
3300
3301         Reviewed by John Sullivan.
3302
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
3305         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
3306         (TestWebKitAPI):
3307         (TestWebKitAPI::TEST):
3308
3309 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
3310
3311         webkit-patch works oddly on local Git branches
3312         https://bugs.webkit.org/show_bug.cgi?id=76958
3313
3314         Reviewed by Ojan Vafai.
3315
3316         This change makes the '-g' flag to webkit-patch behave a
3317         little more consistently with git. The 'HEAD..' syntax
3318         is changed to 'HEAD....' (four dots), so as to not
3319         collide with the underlying git syntax. We also generalize
3320         the syntax to support any refname, so 'foo....' means
3321         diff against foo and include working copy changes.
3322
3323         This change also adds the 'UPSTREAM' shortcut to identify
3324         whatever the current upstream/tracking branch is; this is
3325         useful if you have multiple local branches stacked up.
3326
3327         * Scripts/webkitpy/common/checkout/scm/git.py:
3328         (Git._branch_from_ref):
3329         (Git):
3330         (Git._current_branch):
3331         (Git._upstream_branch):
3332         (Git.merge_base):
3333         (Git._commit_on_branch):
3334         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3335         (GitSVNTest._second_local_commit):
3336         (GitSVNTest._two_local_commits):
3337         (GitSVNTest.test_commit_with_message_git_commit_range):
3338         (GitSVNTest.test_upstream_branch):
3339         (GitSVNTest.test_create_patch_working_copy_only):
3340         (GitSVNTest.test_changed_files_local_plus_working_copy):
3341         (GitSVNTest.test_changed_files_working_copy_only):
3342         (GitSVNTest.test_changed_files_upstream):
3343         * Scripts/webkitpy/tool/steps/options.py:
3344         (Options):
3345
3346 2012-03-08  John Sullivan  <sullivan@apple.com>
3347
3348         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
3349
3350         Reviewed by Eric Carlson.
3351
3352         * Scripts/extract-localizable-strings:
3353         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
3354         with NSLocalized. Also improved an error message to include the troublesome token.
3355
3356 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3357
3358         Unreviewed, rolling out r110115.
3359         http://trac.webkit.org/changeset/110115
3360         https://bugs.webkit.org/show_bug.cgi?id=80581
3361
3362         broke test-webkitpy (Requested by philn-tp on #webkit).
3363
3364         * Scripts/old-run-webkit-tests:
3365         * Scripts/webkitpy/layout_tests/port/qt.py:
3366         (QtPort):
3367         (QtPort.determine_full_port_name):
3368         (QtPort.baseline_search_path):
3369
3370 2012-03-08  Kentaro Hara  <haraken@chromium.org>
3371
3372         Unreviewed. Added myself to watchlist.
3373
3374         * Scripts/webkitpy/common/config/watchlist:
3375
3376 2012-03-07  Jessie Berlin  <jberlin@apple.com>
3377
3378         Clean Windows build fails after r110033
3379         https://bugs.webkit.org/show_bug.cgi?id=80553
3380
3381         Rubber-stamped by Jon Honeycutt and Eric Seidel.
3382
3383         Add the new JavaScriptCore include directory to some more vsprops files.
3384
3385         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3386         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3387         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3388
3389 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
3390
3391         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3392         https://bugs.webkit.org/show_bug.cgi?id=72489
3393
3394         Reviewed by Dirk Pranke.
3395
3396         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3397         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3398         --platform will override the platform name and then we'll use it.
3399
3400         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3401         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
3402         override it in the end.
3403
3404         * Scripts/old-run-webkit-tests:
3405         * Scripts/webkitpy/layout_tests/port/qt.py:
3406         (QtPort):
3407         (QtPort.determine_full_port_name):
3408         (QtPort.baseline_search_path):
3409
3410 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
3411
3412         [Qt][WK2] MiniBrowser on desktop does not react to click events
3413         https://bugs.webkit.org/show_bug.cgi?id=80314
3414
3415         Reviewed by Kenneth Rohde Christiansen.
3416
3417         Do not enable touch mocking on desktop mode.
3418
3419         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3420         (MiniBrowserApplication::handleUserOptions):
3421
3422 2012-03-07  Ojan Vafai  <ojan@chromium.org>
3423
3424         Automatically move to the next test after rebaseline in the results view
3425         https://bugs.webkit.org/show_bug.cgi?id=80527
3426
3427         Reviewed by Dimitri Glazkov.
3428
3429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3431
3432 2012-03-07  Ojan Vafai  <ojan@chromium.org>
3433
3434         garden-o-matic rebaseline is broken for ports that don't have a fallback port
3435         https://bugs.webkit.org/show_bug.cgi?id=80526
3436
3437         Reviewed by Adam Barth.
3438
3439         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
3440         since there is no "None" port.
3441
3442         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3443         (GardeningHTTPRequestHandler.rebaseline):
3444         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3445         (GardeningServerTest.test_rebaseline):
3446
3447 2012-03-07  James Robinson  <jamesr@chromium.org>
3448
3449         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
3450         https://bugs.webkit.org/show_bug.cgi?id=80521
3451
3452         Reviewed by Kenneth Russell.
3453
3454         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
3455         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
3456         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
3457
3458         Covered by platform/chromium/compositing/plugins/*
3459
3460         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3461         (TestWebPlugin::TestWebPlugin):
3462         (TestWebPlugin::initialize):
3463         (TestWebPlugin::updateGeometry):
3464         (TestWebPlugin::initScene):
3465         (TestWebPlugin::destroyScene):
3466         * DumpRenderTree/chromium/TestWebPlugin.h:
3467         (TestWebPlugin):
3468         * DumpRenderTree/chromium/WebViewHost.cpp:
3469         (WebViewHost::createPlugin):
3470
3471 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3472
3473         [GTK] remove webkitpy dependency in run-gtk-tests
3474         https://bugs.webkit.org/show_bug.cgi?id=80500
3475
3476         Reviewed by Martin Robinson.
3477
3478         Replace Executive calls with bare subprocess calls.
3479
3480         * Scripts/run-gtk-tests:
3481         (TestRunner):
3482         (TestRunner._lookup_atspi2_binary):
3483         (TestRunner.run):
3484         (TestRunner.run.run_for_real):
3485
3486 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3487
3488         Unreviewed, GTK build fix after r110059.
3489
3490         * Scripts/run-gtk-tests:
3491         (TestRunner._check_if_tests_have_timed_out):
3492         (TestRunner.run.run_tests):
3493         (TestRunner):
3494
3495 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3496
3497         [GTK] race condition in run-gtk-tests
3498         https://bugs.webkit.org/show_bug.cgi?id=80495
3499
3500         Reviewed by Martin Robinson.
3501
3502         Refactored the script to wait the a11y dbus service becomes
3503         available before starting the tests.
3504
3505         * Scripts/run-gtk-tests:
3506         (TestRunner._lookup_atspi2_binary):
3507         (TestRunner):
3508         (TestRunner._wait_dbus_service_and_run):
3509         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
3510         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
3511         (TestRunner.run):
3512         (TestRunner.run.bailout):
3513         (TestRunner.run.run_for_real):
3514
3515 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
3516
3517         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
3518         https://bugs.webkit.org/show_bug.cgi?id=80425
3519
3520         Reviewed by Simon Hausmann.
3521
3522         Set startScreenPos in mock touch point
3523
3524         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3525         (MiniBrowserApplication::notify):
3526         * MiniBrowser/qt/MiniBrowserApplication.h:
3527         (MiniBrowserApplication):
3528
3529 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3530
3531         [Qt] Windows build fix.
3532
3533         Reviewed by Tor Arne Vestbø.
3534
3535         Pass the -j parameter only to "make", not "nmake".
3536
3537         * Scripts/webkitdirs.pm:
3538         (buildQMakeProjects):
3539
3540 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3541
3542         [Qt] Fix compilation without QtQuick1
3543         https://bugs.webkit.org/show_bug.cgi?id=80503
3544
3545         Reviewed by Tor Arne Vestbø.
3546
3547         Introduce HAVE_QQUICK1 as feature and added haveQtModule
3548         as convenience function.
3549
3550         * qmake/mkspecs/features/features.prf:
3551         * qmake/mkspecs/features/functions.prf:
3552
3553 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
3554
3555         [Qt] Add qmake config tests for JPEG and PNG library
3556         https://bugs.webkit.org/show_bug.cgi?id=80398
3557
3558         Add JPEG and PNG library tests to config.tests and
3559         add error() abort to WebCore.pri if tests don't work.
3560
3561         Reviewed by Tor Arne Vestbø.
3562
3563         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
3564         (main):
3565         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
3566         * qmake/config.tests/libpng/libpng.cpp: Added.
3567         (main):
3568         * qmake/config.tests/libpng/libpng.pro: Added.
3569         * qmake/sync.profile:
3570
3571 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
3572
3573         [EFL] Build warning: Fix warn_unused_result warnings.
3574         https://bugs.webkit.org/show_bug.cgi?id=79194
3575
3576         Reviewed by Filip Pizlo.
3577
3578         Fixed build warning which is getting generated when not using return
3579         value of a fuction, especially declared with warn_unused_result
3580         attribute.
3581
3582         * DumpRenderTree/efl/ImageDiff.cpp:
3583         (printImage):
3584
3585 2012-03-07  Kangil Han  <kangil.han@samsung.com>
3586
3587         [DRT] Remove PlainTextController implementations.
3588         https://bugs.webkit.org/show_bug.cgi?id=79959
3589
3590         Reviewed by Hajime Morita.
3591
3592         PlainTextController usages in existing tests have been
3593         replaced by internals API by bug 78570.
3594         So this patch will remove PlainTextController implementations
3595         to avoid further usage in new tests.
3596
3597         * DumpRenderTree/DumpRenderTree.gypi:
3598         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3599         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
3600         * DumpRenderTree/chromium/PlainTextController.h: Removed.
3601         * DumpRenderTree/chromium/TestShell.cpp:
3602         (TestShell::TestShell):
3603         (TestShell::bindJSObjectsToWindow):
3604         * DumpRenderTree/chromium/TestShell.h:
3605         (TestShell):
3606         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3607         (webViewWindowObjectCleared):
3608         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
3609         * DumpRenderTree/gtk/PlainTextController.h: Removed.
3610         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3611         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3612         * DumpRenderTree/mac/PlainTextController.h: Removed.
3613         * DumpRenderTree/mac/PlainTextController.mm: Removed.
3614         * DumpRenderTree/qt/DumpRenderTree.pro:
3615         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3616         (WebCore::DumpRenderTree::DumpRenderTree):
3617         (WebCore::DumpRenderTree::initJSObjects):
3618         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3619         (DumpRenderTree):
3620         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
3621         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
3622         * GNUmakefile.am:
3623
3624 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3625
3626         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
3627         https://bugs.webkit.org/show_bug.cgi?id=80137
3628
3629         Reviewed by Eric Seidel.
3630
3631         Adds implementation LayoutTestController's setPopupBlockingEnabled.
3632         To pass popup-blocking-click-in-iframe.html EventSender should not
3633         repeat click events in idler's function. EventSender allows to
3634         asynchronously send click event through ecore_idler_add.
3635         This event will be called repeatedly as long as it return true.
3636         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
3637
3638         * DumpRenderTree/efl/EventSender.cpp:
3639         (sendMouseEvent): Changed return value from bool to void because it always returns true.
3640         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
3641         (mouseDownCallback): Remove unnecessary checking of return value.
3642         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3643         (LayoutTestController::setPopupBlockingEnabled):
3644
3645 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3646
3647         rebaseline_chromium_webkit_tests is obsolete and should be removed
3648         https://bugs.webkit.org/show_bug.cgi?id=80347
3649
3650         Reviewed by Tony Chang.
3651
3652         * Scripts/rebaseline-chromium-webkit-tests: Removed.
3653         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
3654         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
3655
3656 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3657
3658         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
3659         https://bugs.webkit.org/show_bug.cgi?id=80468
3660
3661         Unreviewed, build fix.
3662
3663         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
3664
3665         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3666         (Lighttpd._prepare_config):
3667
3668 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3669
3670         remove chromium_gpu ports
3671         https://bugs.webkit.org/show_bug.cgi?id=80345
3672
3673         Reviewed by Ojan Vafai.
3674
3675         This change leaves in the 'graphics_type' distinction in the
3676         test_expectations; removing that will require more updates and a
3677         pass over test_expectations.txt, so I'm separating that out.
3678
3679         * Scripts/webkitpy/layout_tests/port/builders.py:
3680 &