1 2016-08-26 Aakash Jain <aakash_jain@apple.com>
3 webkit-queues queue-status page should should list more recent statuses
4 https://bugs.webkit.org/show_bug.cgi?id=161220
6 Reviewed by Daniel Bates.
8 * QueueStatusServer/handlers/queuestatus.py:
9 (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
11 2016-08-26 Dan Bernstein <mitz@apple.com>
13 [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
14 https://bugs.webkit.org/show_bug.cgi?id=161258
16 Reviewed by Anders Carlsson.
18 * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
19 (TestWebKitAPI::TEST):
21 2016-08-26 Csaba Osztrogonác <ossy@webkit.org>
23 Fix the ENABLE(WEBASSEMBLY) build on Linux
24 https://bugs.webkit.org/show_bug.cgi?id=161197
30 2016-08-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
32 [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
33 https://bugs.webkit.org/show_bug.cgi?id=161149
35 Reviewed by Carlos Garcia Campos.
37 Add a new function for waiting for the accesibility bus. It sets
38 the test environment variables before starting the GLib mainloop.
39 And restores the previous environment after it has finished.
40 It also adds a timeout (5 seconds) to abort in case it has not
41 been able to detect the accesibility bus before the timeout expires.
43 * Scripts/run-gtk-tests:
45 (TestRunner._wait_for_accessibility_bus):
46 (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
47 (TestRunner._start_accessibility_daemons):
48 (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
50 2016-08-26 Per Arne Vollan <pvollan@apple.com>
53 https://bugs.webkit.org/show_bug.cgi?id=161236
55 Reviewed by Brent Fulgham.
57 The & operator in the Test struct has no body.
59 * TestWebKitAPI/Tests/WTF/Vector.cpp:
60 (TestWebKitAPI::TEST):
62 2016-08-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
64 [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
65 https://bugs.webkit.org/show_bug.cgi?id=160736
67 Reviewed by Carlos Garcia Campos.
69 This plugs run-gtk-tests into the webkitpy testing infrastructure.
70 As a benefit of this, run-gtk-tests now can be executed over any of
71 the existing supported gtk test display servers (xvfb, weston-over-xvfb,
72 or native xorg). A new command line switch --wayland is added for
75 * Scripts/run-gtk-tests:
76 (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
77 Add a --wayland command line switch.
78 (TestRunner._start_accessibility_daemons):
80 (TestRunner.__init__):
81 (TestRunner._run_xvfb): Deleted.
82 (TestRunner._create_driver):
83 (TestRunner._setup_testing_environment): Delete the environment variable definitions that
84 are now done by driver._setup_environ_for_test().
85 (TestRunner._tear_down_testing_environment):
86 * Scripts/webkitpy/port/driver.py:
87 (Driver.__init__): Define self._server_name in the constructor of the base class.
88 It is used by several functions, so it makes sense to store once the value here.
89 (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
90 (Driver._start): Get the environment from self._setup_environ_for_test()
91 * Scripts/webkitpy/port/driver_unittest.py:
93 (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
94 * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
96 (GtkPort._driver_class):
97 * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
98 (WestonDriver._setup_environ_for_test):
99 (WestonDriver._start):
100 * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
101 (XorgDriver._setup_environ_for_test):
103 * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
104 (XvfbDriver._setup_environ_for_test):
107 2016-08-26 Csaba Osztrogonác <ossy@webkit.org>
109 [EFL][GTK] REGRESSION(204877): Fix the clean build
110 https://bugs.webkit.org/show_bug.cgi?id=161240
112 Reviewed by Carlos Garcia Campos.
114 * WebKitTestRunner/PlatformEfl.cmake:
115 * WebKitTestRunner/PlatformGTK.cmake:
117 2016-08-26 Aakash Jain <aakash_jain@apple.com>
119 EWS should indicate which bot processed the patch
120 https://bugs.webkit.org/show_bug.cgi?id=161222
122 Reviewed by Daniel Bates.
124 * QueueStatusServer/handlers/statusbubble.py:
125 (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
126 after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
127 Also added "Started processing patch" message to progress_statuses.
128 I might consider displaying bot id in other statuses as well later on.
130 2016-08-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
132 [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
133 https://bugs.webkit.org/show_bug.cgi?id=161184
135 Reviewed by Carlos Garcia Campos.
137 * MiniBrowser/efl/main.c: Set www.ewebkit.org.
139 2016-08-25 Aakash Jain <aakash_jain@apple.com>
141 ews queues should update status server when they start processing patch
142 https://bugs.webkit.org/show_bug.cgi?id=161223
144 Reviewed by Daniel Bates.
146 * Scripts/webkitpy/tool/commands/queues.py:
147 (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
148 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
149 (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
150 * Scripts/webkitpy/tool/commands/queues_unittest.py:
151 (StyleQueueTest.test_style_queue_with_style_exception): Same.
152 (test_style_queue_with_watch_list_exception): Same.
153 (test_non_valid_patch): Same.
155 2016-08-25 Alex Christensen <achristensen@webkit.org>
159 * DumpRenderTree/PlatformMac.cmake:
161 2016-08-25 Alex Christensen <achristensen@webkit.org>
163 Fix URLParserTest with GuardMalloc
164 https://bugs.webkit.org/show_bug.cgi?id=161214
165 rdar://problem/28014390
167 Reviewed by Tim Horton.
169 The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
170 This just does the comparison of the CStrings instead to keep them in scope during the comparison.
172 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
174 (TestWebKitAPI::checkURL):
175 (TestWebKitAPI::checkURLDifferences):
176 (TestWebKitAPI::s): Deleted.
178 2016-08-25 Wenson Hsieh <wenson_hsieh@apple.com>
180 Dragging against the end of the inline media scrubber causes the media scrubber to hide
181 https://bugs.webkit.org/show_bug.cgi?id=161207
183 Reviewed by Eric Carlson.
185 Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
186 controls in this case, we should actually continue showing them. This is because seeking due to user gestures
187 similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
189 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
190 (TestWebKitAPI::TEST):
192 2016-08-25 Daniel Bates <dabates@apple.com>
196 * Scripts/webkitpy/common/config/watchlist:
198 2016-08-25 Daniel Bates <dabates@apple.com>
200 Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
201 (https://bugs.webkit.org/show_bug.cgi?id=148437)
203 Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
204 and is not installed on the GTK Linux bots.
206 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
207 (writeFileWithContent): Added.
209 2016-08-25 Per Arne Vollan <pvollan@apple.com>
211 [Win] run-api-tests is failing.
212 https://bugs.webkit.org/show_bug.cgi?id=161140
214 Reviewed by Brent Fulgham.
216 Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
218 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
219 (TestWebKitAPI::TEST):
221 2016-08-24 Per Arne Vollan <pvollan@apple.com>
223 [Win] run-api-tests is failing.
224 https://bugs.webkit.org/show_bug.cgi?id=161140
226 Reviewed by Brent Fulgham.
228 The number of times the move constructor is called is different on Windows in this test. This seems
229 to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
231 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
232 (TestWebKitAPI::TEST):
234 2016-08-24 Simon Fraser <simon.fraser@apple.com>
238 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
239 (WTR::UIScriptController::zoomToScale):
241 2016-08-24 Simon Fraser <simon.fraser@apple.com>
243 [iOS DRT] Hook up uiController.zoomToScale() for DRT
244 https://bugs.webkit.org/show_bug.cgi?id=161173
246 Reviewed by Tim Horton.
248 Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
249 UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
251 UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
252 the WebThread!), but queue up the callback first.
254 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
255 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
256 (-[DumpRenderTreeWebScrollView initWithFrame:]):
257 (-[DumpRenderTreeWebScrollView dealloc]):
258 (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
259 (-[DumpRenderTreeWebScrollView completedZoomToScale]):
260 (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
261 (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
262 (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
263 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
264 (WTR::UIScriptController::zoomToScale):
265 * DumpRenderTree/mac/DumpRenderTree.mm:
266 (createWebViewAndOffscreenWindow):
267 * TestRunnerShared/UIScriptContext/UIScriptController.h:
268 (WTR::UIScriptController::context):
270 2016-08-24 Ryan Haddad <ryanhaddad@apple.com>
272 Attempt to fix Windows build after r204918.
274 Unreviewed build fix.
276 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
277 (ResourceLoadDelegate::willSendRequest):
279 2016-08-24 Simon Fraser <simon.fraser@apple.com>
281 [iOS DRT] Get basic viewport tests working in DRT
282 https://bugs.webkit.org/show_bug.cgi?id=161160
284 Reviewed by Tim Horton.
286 Hook up enough of UIScriptController in iOS DRT to be able to read viewport
287 scale, and get the contentVisibleRect.
289 Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
290 requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
292 One test has different results between DRT and WTR, but DRT behavior seems to differ
293 from UIWebView here, so just give it a WK1-specific result.
295 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
296 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
297 (-[DumpRenderTreeBrowserView documentVisibleRect]):
298 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
299 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
300 (WTR::UIScriptController::zoomScale):
301 (WTR::UIScriptController::minimumZoomScale):
302 (WTR::UIScriptController::maximumZoomScale):
303 (WTR::UIScriptController::contentVisibleRect):
304 * DumpRenderTree/mac/DumpRenderTree.mm:
305 (createWebViewAndOffscreenWindow):
306 * DumpRenderTree/mac/DumpRenderTreeMac.h:
308 2016-08-24 Simon Fraser <simon.fraser@apple.com>
310 Minor project rearrangement.
312 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
314 2016-08-24 Simon Fraser <simon.fraser@apple.com>
316 [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
317 https://bugs.webkit.org/show_bug.cgi?id=161124
319 Reviewed by Daniel Bates.
321 Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
322 and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
324 Remove some unnecessary zero initializations of static variables.
326 Change _setVisibleSize to use the window size, which should not be a behavior change
327 because this it just used for text autosizing, which is disabled by default,
328 and only the width is consulted.
330 * DumpRenderTree/mac/DumpRenderTree.mm:
331 (adjustWebDocumentForFlexibleViewport):
332 (adjustWebDocumentForStandardViewport):
333 (createWebViewAndOffscreenWindow):
335 2016-08-24 Jonathan Bedard <jbedard@apple.com>
337 WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
338 https://bugs.webkit.org/show_bug.cgi?id=42777
340 Reviewed by Darin Adler.
342 The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called. Removed function and test.
344 * DumpRenderTree/TestRunner.cpp:
345 (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
346 * DumpRenderTree/TestRunner.h:
347 (TestRunner::deferMainResourceDataLoad): Ditto.
348 (TestRunner::setDeferMainResourceDataLoad): Ditto.
349 * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
351 2016-08-23 Anders Carlsson <andersca@apple.com>
353 Add enum traits and use them in the IPC::Decoder
354 https://bugs.webkit.org/show_bug.cgi?id=161103
356 Reviewed by Sam Weinig.
360 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
361 * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
362 (TestWebKitAPI::TEST):
364 2016-08-24 Filip Pizlo <fpizlo@apple.com>
366 Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
368 * DumpRenderTree/TestRunner.cpp:
369 * DumpRenderTree/mac/DumpRenderTree.mm:
370 (DumpRenderTreeMain):
371 * Scripts/run-jsc-stress-tests:
372 * TestWebKitAPI/Tests/WTF/Vector.cpp:
373 (TestWebKitAPI::TEST):
375 2016-08-24 Simon Fraser <simon.fraser@apple.com>
377 Try to fix Production builds.
379 PRODUCTION_FRAMEWORKS_DIR was undefined here.
381 * DumpRenderTree/mac/Configurations/Base.xcconfig:
383 2016-08-24 Dan Bernstein <mitz@apple.com>
385 Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
386 https://bugs.webkit.org/show_bug.cgi?id=161152
388 Reviewed by Anders Carlsson.
390 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391 * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
392 (TestWebKitAPI::didFinishLoadForFrame):
393 (TestWebKitAPI::TEST):
395 2016-08-24 Nan Wang <n_wang@apple.com>
397 AX: Add test for line text marker range on iOS
398 https://bugs.webkit.org/show_bug.cgi?id=161108
399 <rdar://problem/27976405>
401 Reviewed by Chris Fleizach.
403 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
404 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
405 (AccessibilityUIElement::textMarkerRangeForElement):
406 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
407 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
408 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
410 2016-08-24 Per Arne Vollan <pvollan@apple.com>
413 https://bugs.webkit.org/show_bug.cgi?id=161079
415 Reviewed by Brent Fulgham.
417 * MiniBrowser/win/WebDownloadDelegate.cpp:
418 * MiniBrowser/win/WinMain.cpp:
419 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
420 (TestWebKitAPI::TEST):
422 2016-08-23 Simon Fraser <simon.fraser@apple.com>
424 Fix Windows DRT build.
426 * DumpRenderTree/win/TestRunnerWin.cpp:
427 (TestRunner::mainFrameJSContext):
429 2016-08-23 Simon Fraser <simon.fraser@apple.com>
431 Try to fix Windows build.
433 Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
434 so that perl finds CodeGeneratorDumpRenderTree.pm.
436 * DumpRenderTree/CMakeLists.txt:
438 2016-08-23 Simon Fraser <simon.fraser@apple.com>
440 Hook up UIScriptController in DumpRenderTree
441 https://bugs.webkit.org/show_bug.cgi?id=161064
443 Reviewed by Sam Weinig.
445 Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
446 Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
447 in fast/harness which test this.
449 Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
451 Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
452 WK2-isms. Fix the makefiles to refer to the new location.
454 Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
455 by ID and firing them once they are complete.
457 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
458 * DumpRenderTree/CMakeLists.txt:
459 * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
460 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
461 * DumpRenderTree/TestRunner.cpp:
462 (runUIScriptCallback):
463 (TestRunner::staticFunctions):
464 (TestRunner::cacheTestRunnerCallback):
465 (TestRunner::callTestRunnerCallback):
466 (TestRunner::clearTestRunnerCallbacks):
467 (nextUIScriptCallbackID):
468 (TestRunner::runUIScript):
469 (TestRunner::callUIScriptCallback):
470 (TestRunner::uiScriptDidComplete):
471 (TestRunner::cleanup):
472 * DumpRenderTree/TestRunner.h:
473 * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
474 * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
475 * DumpRenderTree/mac/DumpRenderTree.mm:
477 * DumpRenderTree/mac/TestRunnerMac.mm:
478 (TestRunner::mainFrameJSContext):
479 * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
480 (WTR::UIScriptController::doAsyncTask):
481 * DumpRenderTree/win/DumpRenderTree.cpp:
482 * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
483 (WTR::JSWrappable::~JSWrappable):
484 (WTR::JSValueMakeStringOrNull):
485 * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
486 (WTR::JSWrapper::wrap):
487 (WTR::JSWrapper::unwrap):
489 (WTR::JSWrapper::initialize):
490 (WTR::JSWrapper::finalize):
491 * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
494 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
495 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
496 * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
497 (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
498 * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
499 * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
500 * WebKitTestRunner/CMakeLists.txt:
501 * WebKitTestRunner/DerivedSources.make:
502 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
503 (WTR::JSWrappable::~JSWrappable): Deleted.
504 (WTR::JSValueMakeStringOrNull): Deleted.
505 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
506 (WTR::JSWrapper::wrap): Deleted.
507 (WTR::JSWrapper::unwrap): Deleted.
508 (WTR::unwrapObject): Deleted.
509 (WTR::JSWrapper::initialize): Deleted.
510 (WTR::JSWrapper::finalize): Deleted.
511 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
512 (WTR::toJS): Deleted.
513 (WTR::setProperty): Deleted.
514 * WebKitTestRunner/TestInvocation.cpp:
515 (WTR::TestInvocation::runUISideScript):
516 (WTR::TestInvocation::uiScriptDidComplete):
517 * WebKitTestRunner/TestInvocation.h:
518 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
519 * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
520 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
521 * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
522 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
523 * WebKitTestRunner/config.h:
524 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
525 (WTR::UIScriptController::contentVisibleRect):
527 2016-08-23 Saam Barati <sbarati@apple.com>
529 JSC should have a "microbenchmarks" directory instead of "regress" directory
530 https://bugs.webkit.org/show_bug.cgi?id=161096
532 Rubber stamped by Mark Lam.
534 This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
535 directory and removes all the related html and txt files. I did this because
536 that directory was only there for microbenchmarks, and not for "regression"
537 tests. I also changed the various scripts to point to it.
539 * Scripts/run-javascriptcore-tests:
541 * Scripts/run-jsc-benchmarks:
543 2016-08-23 Alex Christensen <achristensen@webkit.org>
547 * TestWebKitAPI/CMakeLists.txt:
548 Include new directory.
550 2016-08-22 Filip Pizlo <fpizlo@apple.com>
552 Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
553 https://bugs.webkit.org/show_bug.cgi?id=160125
555 Reviewed by Geoffrey Garen.
557 * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
558 * Scripts/run-jsc-stress-tests: New test flag!
560 2016-08-23 Brady Eidson <beidson@apple.com>
562 WK2 Gamepad layout test support.
563 https://bugs.webkit.org/show_bug.cgi?id=134671
565 Reviewed by Alex Christensen.
567 Have the injected bundle expose the MockGamepadProvider to the UI process, which will then
568 feed back into the UIGamepadProvider.
570 Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
571 as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
573 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
575 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
576 (WTR::TestRunner::setMockGamepadDetails):
577 (WTR::TestRunner::setMockGamepadAxisValue):
578 (WTR::TestRunner::setMockGamepadButtonValue):
580 * WebKitTestRunner/PlatformWebView.h:
582 * WebKitTestRunner/TestController.cpp:
583 (WTR::TestController::initialize):
585 * WebKitTestRunner/TestInvocation.cpp:
586 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
587 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
589 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
591 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
592 (-[WebKitTestRunnerWindow initWithFrame:]):
593 (-[WebKitTestRunnerWindow dealloc]):
594 (WTR::PlatformWebView::keyWindow):
596 * WebKitTestRunner/ios/TestControllerIOS.mm:
597 (WTR::wtr_NSApplication_keyWindow):
598 (WTR::TestController::platformInitialize):
600 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
601 (+[WebKitTestRunnerWindow _WTR_keyWindow]):
602 (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
603 (-[WebKitTestRunnerWindow dealloc]):
604 (WTR::PlatformWebView::keyWindow):
606 * WebKitTestRunner/mac/TestControllerMac.mm:
607 (WTR::wtr_NSApplication_keyWindow):
608 (WTR::TestController::platformInitialize):
609 * WebKitTestRunner/mac/main.mm:
611 2016-08-23 Alexey Proskuryakov <ap@apple.com>
613 REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
614 https://bugs.webkit.org/show_bug.cgi?id=161047
615 rdar://problem/27434307
617 Reviewed by Lucas Forschler.
619 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
621 2016-08-23 Chris Dumez <cdumez@apple.com>
623 Unreviewed, rolling out r204243.
625 Caused some layout test failures
629 "Write API test to cover crash fix in r204135"
630 https://bugs.webkit.org/show_bug.cgi?id=160587
631 http://trac.webkit.org/changeset/204243
633 2016-08-23 Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au>
635 Order feature option list in FeatureList.pm
636 https://bugs.webkit.org/show_bug.cgi?id=161074
638 Reviewed by Michael Catanzaro.
640 Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
642 * Scripts/webkitperl/FeatureList.pm:
644 2016-08-22 Dewei Zhu <dewei_zhu@apple.com>
646 Stop python icon bouncing in the dock while running browser benchmarks.
647 https://bugs.webkit.org/show_bug.cgi?id=161066
649 Reviewed by Ryosuke Niwa.
651 Bouncing python icon may impact browser benchmark results.
652 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
653 (OSXBrowserDriver.prepare_env):
654 (OSXBrowserDriver.restore_env):
656 2016-08-22 Simon Fraser <simon.fraser@apple.com>
658 <select> menu on iPad causes shifting of hit-testing areas
659 https://bugs.webkit.org/show_bug.cgi?id=150079
661 Reviewed by Tim Horton.
663 -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
664 so when it changes we have to update visible rects. We were doing this on focus, but failing
667 Added the ability to test by:
668 1. Making it possible to initiate an animated scroll in the UI process
669 2. Adding callbacks for starting and ending interaction with a form control. Sadly
670 the "ending interaction" for <select> popovers on iPad isn't late enough, since we
671 have no way currently to know when the dimming view behind the popover animates out,
672 so for now the test keeps trying to tap a button.
674 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
675 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
676 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
677 (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
678 (WTR::UIScriptController::didStartFormControlInteractionCallback):
679 (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
680 (WTR::UIScriptController::didEndFormControlInteractionCallback):
681 (WTR::UIScriptController::scrollToOffset):
682 (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
683 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
684 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
685 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
686 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
687 (-[TestRunnerWKWebView dealloc]):
688 (-[TestRunnerWKWebView didStartFormControlInteraction]):
689 (-[TestRunnerWKWebView didEndFormControlInteraction]):
690 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
691 (WTR::contentOffsetBoundedInValidRange):
692 (WTR::UIScriptController::scrollToOffset):
693 (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
694 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
696 2016-08-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
698 [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
699 https://bugs.webkit.org/show_bug.cgi?id=160927
701 Reviewed by Daniel Bates.
703 * Scripts/process-linux-coredump: Removed.
704 * Scripts/webkitpy/port/efl.py:
705 (EflPort._get_crash_log):
706 * Scripts/webkitpy/port/gtk.py:
707 (GtkPort._get_crash_log):
708 * Scripts/webkitpy/port/linux_get_crash_log.py:
709 (GDBCrashLogGenerator.__init__):
710 (GDBCrashLogGenerator.generate_crash_log):
711 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
712 (GDBCrashLogGeneratorTest.test_generate_crash_log):
714 2016-08-22 Jonathan Bedard <jbedard@apple.com>
716 check-webkit-style does not work with Lambda functions in C++
717 https://bugs.webkit.org/show_bug.cgi?id=160910
719 Reviewed by Darin Adler.
721 This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
723 * Scripts/webkitpy/style/checkers/cpp.py:
724 (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
725 (check_for_non_standard_constructs): Added lambda function check.
726 (check_spacing_for_function_call): Added lambda function check.
727 (check_braces): Added lambda function check.
728 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
729 (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
731 2016-08-21 Alex Christensen <achristensen@webkit.org>
733 URLParser should parse IPv4 addresses
734 https://bugs.webkit.org/show_bug.cgi?id=161023
736 Reviewed by Darin Adler.
738 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
739 (TestWebKitAPI::TEST_F):
740 (TestWebKitAPI::checkURLDifferences):
741 We are already getting differences between the old URL::parse and the new URLParser.
742 (TestWebKitAPI::shouldFail):
744 2016-08-21 Daniel Bates <dabates@apple.com>
746 prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
747 https://bugs.webkit.org/show_bug.cgi?id=148437
749 Reviewed by Dan Bernstein.
751 * Scripts/prepare-ChangeLog:
752 (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
753 This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
754 assumes that its line ranges were from a unified diff without any context lines.
755 (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
756 (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
757 * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
758 based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
759 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
760 (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
761 to /dev/null for the duration of the function call.
763 2016-08-20 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
765 [EFL] Remove unnecessary a patch to mute ecore warnings
766 https://bugs.webkit.org/show_bug.cgi?id=160997
768 Reviewed by Darin Adler.
770 There is no warning messages during the layout test and perf test
771 after bumping efl version from 1.17 to 1.18. Remove it.
773 * efl/patches/ecore_remove_warnings.patch: Removed.
775 2016-08-20 Simon Fraser <simon.fraser@apple.com>
777 REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
778 https://bugs.webkit.org/show_bug.cgi?id=160985
780 Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
781 device shutdown seems to happen as result of killing Simulator.apps, and we're racing
784 * Scripts/webkitpy/layout_tests/views/printing.py:
785 (Printer.print_config):
786 * Scripts/webkitpy/port/base.py:
787 (Port.driver_cmd_line_for_logging):
788 (Port.driver_cmd_line): Deleted.
789 * Scripts/webkitpy/port/driver.py:
790 (IOSSimulatorDriver.cmd_line):
791 * Scripts/webkitpy/port/ios.py:
792 (IOSSimulatorPort.__init__):
793 (IOSSimulatorPort.driver_cmd_line_for_logging):
794 (IOSSimulatorPort._create_simulators):
795 (IOSSimulatorPort.setup_test_run):
796 (IOSSimulatorPort._quit_ios_simulator):
797 (IOSSimulatorPort.clean_up_test_run):
798 (IOSSimulatorPort._create_device):
800 (IOSSimulatorPort._remove_device):
801 (IOSSimulatorPort._testing_device):
802 (IOSSimulatorPort.device_id_for_worker_number):
803 (IOSSimulatorPort._set_device_class): Deleted.
804 (IOSSimulatorPort.testing_device): Deleted.
805 * Scripts/webkitpy/port/port_testcase.py:
806 (PortTestCase.test_driver_cmd_line):
807 * Scripts/webkitpy/xcode/simulator.py:
813 (Simulator.create_device):
814 (Simulator.remove_device):
815 (Simulator.device_number):
816 (Simulator.device_state_description):
817 (Simulator.wait_until_device_is_in_state):
819 2016-08-19 Ryan Haddad <ryanhaddad@apple.com>
821 Unreviewed, rolling out r204659.
823 This change appears to have caused ios-simulator LayoutTests
824 to fail when shutting down the simulator
828 "REGRESSION (r204477): Running LayoutTests on ios-simulator
829 became ~15 minutes slower"
830 https://bugs.webkit.org/show_bug.cgi?id=160985
831 http://trac.webkit.org/changeset/204659
833 2016-08-19 Alexey Proskuryakov <ap@apple.com>
835 Build fix for non-USE_SIM_SERVICE_CONTEXT builds
836 * LayoutTestRelay/LayoutTestRelay/main.m: (main):
838 2016-08-18 Simon Fraser <simon.fraser@apple.com>
840 REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
841 https://bugs.webkit.org/show_bug.cgi?id=160985
843 Reviewed by Alexey Proskuryakov.
845 r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
846 a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
847 must not be @memoized, because their return value depends on the value of simulator_device_type().
849 Fix by adding some global state in simulator.py that tracks the created devices
850 in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
851 and delete them in clean_up_test_run().
853 Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
854 that killing the Simulator apps isn't enough.
856 Simulator tracks the devices in a global dictionary, since state needs to persist
857 across different instances of IOSSimulatorPort.
859 Annoyingly, the "Command line:" dumping tried to access a device before we'd done
860 any setup. Rather than implicitly creating a device here (which the old code did),
861 override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
862 and set flag to say that device_id_for_worker_number() doesn't need to return a real
865 * Scripts/webkitpy/layout_tests/views/printing.py:
867 (Printer.print_config):
868 * Scripts/webkitpy/port/base.py:
869 (Port.driver_cmd_line_for_logging):
870 (Port.driver_cmd_line): Deleted.
871 * Scripts/webkitpy/port/driver.py:
872 (IOSSimulatorDriver.cmd_line):
873 * Scripts/webkitpy/port/ios.py:
874 (IOSSimulatorPort.__init__):
875 (IOSSimulatorPort.driver_cmd_line_for_logging):
876 (IOSSimulatorPort._create_simulators):
877 (IOSSimulatorPort.setup_test_run):
878 (IOSSimulatorPort.clean_up_test_run):
879 (IOSSimulatorPort._create_device):
881 (IOSSimulatorPort._remove_device):
882 (IOSSimulatorPort._testing_device):
883 (IOSSimulatorPort.device_id_for_worker_number):
884 (IOSSimulatorPort._set_device_class): Deleted.
885 (IOSSimulatorPort.testing_device): Deleted.
886 * Scripts/webkitpy/port/port_testcase.py:
887 (PortTestCase.test_driver_cmd_line):
888 * Scripts/webkitpy/xcode/simulator.py:
892 (Simulator.create_device):
893 (Simulator.remove_device):
894 (Simulator.device_number):
895 (Simulator.device_state_description):
896 (Simulator.wait_until_device_is_in_state):
898 2016-08-19 Alexey Proskuryakov <ap@apple.com>
900 Adopt SimServiceContext in LayoutTestRelay
901 https://bugs.webkit.org/show_bug.cgi?id=161000
902 <rdar://problem/25765594>
904 Reviewed by Daniel Bates.
906 * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
907 * LayoutTestRelay/LayoutTestRelay/main.m:
909 2016-08-19 Lucas Forschler <lforschler@apple.com>
911 Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
913 Reviewed by Kocsen Chung.
915 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
918 2016-08-19 Alexey Proskuryakov <ap@apple.com>
920 Partial revert of r203811 - this key is not needed.
922 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
924 2016-08-19 Daniel Bates <dabates@apple.com>
926 Another attempt to fix the iOS 9.3 build
928 Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
930 * DumpRenderTree/mac/Configurations/Base.xcconfig:
931 * WebKitTestRunner/Configurations/Base.xcconfig:
933 2016-08-19 Lucas Forschler <lforschler@apple.com>
935 Remove Yosemite Leaks bot from config.json
937 Reviewed by Alexey Proskuryakov.
939 * BuildSlaveSupport/build.webkit.org-config/config.json:
941 2016-08-18 Dan Bernstein <mitz@apple.com>
943 [Cocoa] API::Number needs to be wrapped by an NSNumber
944 https://bugs.webkit.org/show_bug.cgi?id=160977
945 <rdar://problem/27877735>
947 Reviewed by Anders Carlsson.
949 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
950 * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
951 (TestWebKitAPI::TEST):
953 2016-08-17 Myles C. Maxfield <mmaxfield@apple.com>
955 [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
956 https://bugs.webkit.org/show_bug.cgi?id=160895
958 Reviewed by Dean Jackson.
960 Link to the existing CoreText framework.
962 * DumpRenderTree/PlatformWin.cmake:
963 * TestWebKitAPI/PlatformWin.cmake:
965 2016-08-17 Brent Fulgham <bfulgham@apple.com>
967 [Win] Remove old libraries from build inputs
968 https://bugs.webkit.org/show_bug.cgi?id=160949
970 Reviewed by Dean Jackson.
972 Modify the download script to remove the old 'icuuc.lib' and
973 'icuin.lib' files for Windows builds.
975 * Scripts/update-webkit-auxiliary-libs:
977 2016-08-17 Jonathan Bedard <jbedard@apple.com>
979 Extra logging for crash reason
980 https://bugs.webkit.org/show_bug.cgi?id=160943
982 Reviewed by Alexey Proskuryakov.
984 A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
986 * Scripts/webkitpy/port/server_process.py:
987 (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
988 (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
989 (ServerProcess.has_crashed): Ditto.
991 2016-08-17 Dan Bernstein <mitz@apple.com>
993 [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
994 https://bugs.webkit.org/show_bug.cgi?id=160938
995 <rdar://problem/27876652>
997 Reviewed by Anders Carlsson.
999 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1000 * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
1001 (TestWebKitAPI::TEST):
1003 2016-08-17 Chris Fleizach <cfleizach@apple.com>
1005 AX: Support abbreviations in iOS
1006 https://bugs.webkit.org/show_bug.cgi?id=160907
1008 Reviewed by Joanmarie Diggs.
1010 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1011 (AccessibilityUIElement::stringAttributeValue):
1012 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1013 (WTR::AccessibilityUIElement::stringAttributeValue):
1015 2016-08-17 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
1017 [EFL] Bump efl version from 1.17 to 1.18
1018 https://bugs.webkit.org/show_bug.cgi?id=160899
1020 Reviewed by Antonio Gomes.
1022 To use efl-1.18, EFL port needs to update install dependencies as well.
1024 * efl/install-dependencies:
1025 * efl/jhbuild.modules:
1027 2016-08-17 Per Arne Vollan <pvollan@apple.com>
1029 [Win] Add tests for linked fonts.
1030 https://bugs.webkit.org/show_bug.cgi?id=160898
1032 Reviewed by Brent Fulgham.
1034 Add tests for https://trac.webkit.org/changeset/204502.
1036 * TestWebKitAPI/PlatformWin.cmake:
1037 * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1038 (TestWebKitAPI::TEST):
1040 2016-08-16 Daniel Bates <dabates@apple.com>
1042 prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1043 https://bugs.webkit.org/show_bug.cgi?id=160924
1045 Reviewed by Stephanie Lewis.
1047 Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1048 and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1049 We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1050 test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1051 object that mocks out the file system and SCM operations.
1053 * Scripts/VCSUtils.pm:
1054 (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1055 * Scripts/prepare-ChangeLog:
1056 (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1057 abstracting the logic to query the file system and SCM into functions on a delegate object that
1059 (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1060 (diffHeaderFormat): Deleted.
1062 2016-08-16 Alex Christensen <achristensen@webkit.org>
1064 URLParser should parse URLs without credentials
1065 https://bugs.webkit.org/show_bug.cgi?id=160913
1067 Reviewed by Brady Eidson.
1069 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1071 (TestWebKitAPI::checkURL):
1072 (TestWebKitAPI::TEST_F):
1074 2016-08-16 Anders Carlsson <andersca@apple.com>
1077 https://bugs.webkit.org/show_bug.cgi?id=160908
1079 Reviewed by Geoffrey Garen.
1081 * TestWebKitAPI/CMakeLists.txt:
1082 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1083 * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1084 (TestWebKitAPI::TEST):
1086 2016-08-16 Aakash Jain <aakash_jain@apple.com>
1088 EWS logs file are rotated too quickly
1089 https://bugs.webkit.org/show_bug.cgi?id=160724
1091 Reviewed by Daniel Bates.
1093 Currently we are rotating the log file after 10 iterations of queue. If the queue
1094 doesn't have any pending patches, these iterations result in very small amount of
1095 logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1096 This results in a lot of log files in a day. This patch ensures that we rotate the
1097 log file when its file size is greater than or equal to 100 KB.
1099 * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1101 2016-08-16 Daniel Bates <dabates@apple.com>
1103 WKSI static library should be named by major iOS revision, not individual updates
1104 https://bugs.webkit.org/show_bug.cgi?id=160727
1105 <rdar://problem/22274848>
1107 Reviewed by Alexey Proskuryakov.
1109 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1110 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1111 * Scripts/copy-webkitlibraries-to-product-directory:
1112 * WebKitTestRunner/Configurations/Base.xcconfig:
1113 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1115 2016-08-16 Simon Fraser <simon.fraser@apple.com>
1117 Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1118 https://bugs.webkit.org/show_bug.cgi?id=160909
1120 Reviewed by Enrica Casucci.
1122 Add functions to UIScriptController to dismiss the form accessory view for iOS,
1123 and to programmatically pick a row from a <select> picker.
1125 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1126 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1127 (WTR::UIScriptController::dismissFormAccessoryView):
1128 (WTR::UIScriptController::selectFormAccessoryPickerRow):
1129 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1130 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1131 (WTR::UIScriptController::dismissFormAccessoryView):
1132 (WTR::UIScriptController::selectFormAccessoryPickerRow):
1134 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1136 [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1137 https://bugs.webkit.org/show_bug.cgi?id=160878
1139 Reviewed by Tim Horton.
1141 Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1142 now that we have the ability to run tests in the iPad simulator.
1144 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1145 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1146 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1147 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1148 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1149 * WebKitTestRunner/ios/TestControllerIOS.mm:
1150 (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1151 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1152 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1153 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1155 2016-08-15 Anders Carlsson <andersca@apple.com>
1157 Add an address-of operator to RetainPtr
1158 https://bugs.webkit.org/show_bug.cgi?id=160879
1160 Reviewed by Tim Horton.
1162 Test HashMap and HashSet with an object whose operator& is deleted.
1164 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1165 Sort the Xcode project.
1167 * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1168 (DeletedAddressOfOperator::DeletedAddressOfOperator):
1169 (DeletedAddressOfOperator::value):
1170 (DeletedAddressOfOperator::operator==):
1171 (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1172 (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1173 (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1174 (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1175 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1176 (TestWebKitAPI::TEST):
1177 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1178 (TestWebKitAPI::TEST):
1180 2016-08-16 Jonathan Bedard <jbedard@apple.com>
1182 False crashes in fast/text/emoji-gender-* tests
1183 https://bugs.webkit.org/show_bug.cgi?id=160779
1185 Reviewed by Alexey Proskuryakov.
1187 Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1189 * Scripts/webkitpy/port/driver.py:
1190 (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1191 * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1192 * Scripts/webkitpy/port/server_process.py:
1193 (ServerProcess.write): Allow caller to disable crash flag on exception.
1195 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1197 webkitpy error in TestRunResults.merge()
1198 https://bugs.webkit.org/show_bug.cgi?id=160882
1200 Reviewed by Daniel Bates.
1202 The argument to TestRunResults.merge() can be None if there are no device-specifc
1203 initial results or retry results in Manager.run(), so just return early in that case.
1205 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1206 (TestRunResults.merge):
1208 2016-08-15 Sam Weinig <sam@webkit.org>
1210 Speed up compile times by not including wtf/Variant.h so much
1211 https://bugs.webkit.org/show_bug.cgi?id=160847
1213 Reviewed by Alex Christensen and Saam Barati.
1215 * TestWebKitAPI/Tests/WTF/Variant.cpp:
1216 (TestWebKitAPI::TEST):
1217 Explicitly use std::experimental::variant.
1219 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1221 Allow a port to run tests with a custom device setup
1222 https://bugs.webkit.org/show_bug.cgi?id=160833
1224 Reviewed by Daniel Bates.
1226 These changes allow the IOSSimulator port to run tests in iPad mode.
1228 This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1229 in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1230 a custom device will be collected into a set, and run in that device's environment after
1231 the other tests have run.
1233 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1234 (Manager._custom_device_for_test): If the test contains a directory matching a
1235 custom device suffix, return that custom device.
1236 (Manager._set_up_run): Push the custom device class, if any, into options so
1237 that the Worker can get to it.
1238 (Manager.run): Go through the list of tests, and break it down into device-generic
1239 tests, and tests for each device class. _run_test_subset is then called for
1240 each collection of tests, and the results merged.
1241 (Manager._run_test_subset): Some lines unwrapped.
1242 (Manager._end_test_run):
1243 (Manager._run_tests):
1244 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1245 (SingleTestRunner.__init__): Unwrapped a line.
1246 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1247 (TestRunResults.merge): Add this function to merge TestRunResults
1248 * Scripts/webkitpy/layout_tests/views/printing.py:
1249 (Printer.print_workers_and_shards): Print the custom device, if any.
1250 * Scripts/webkitpy/port/base.py:
1251 (Port): Base port has empty array of custom devices.
1252 (Port.setup_test_run): Add device_class argument.
1253 * Scripts/webkitpy/port/driver.py:
1254 (DriverInput.__repr__):
1255 (Driver.check_driver.implementation):
1256 * Scripts/webkitpy/port/efl.py:
1257 (EflPort.setup_test_run):
1258 * Scripts/webkitpy/port/gtk.py:
1259 (GtkPort.setup_test_run):
1260 * Scripts/webkitpy/port/ios.py:
1261 (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1262 (IOSSimulatorPort.__init__):
1263 (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1264 based on the custom device class.
1265 (IOSSimulatorPort._set_device_class):
1266 (IOSSimulatorPort._create_simulators): Factor some code into this function.
1267 (IOSSimulatorPort.setup_test_run):
1268 (IOSSimulatorPort.testing_device):
1269 (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1270 seemed wrong for this function. That was moved to setup_test_run().
1271 (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1272 but this happened too early, before we knew which kind of devices to create. Devices
1273 are now created in setup_test_run().
1274 * Scripts/webkitpy/port/win.py:
1275 (WinPort.setup_test_run):
1277 2016-08-15 Daniel Bates <dabates@apple.com>
1279 Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1280 private frameworks and libraries
1281 https://bugs.webkit.org/show_bug.cgi?id=155931
1282 <rdar://problem/25807989>
1284 Reviewed by Dan Bernstein.
1286 Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1287 where X is the major version of the active iOS SDK.
1289 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1290 * WebKitTestRunner/Configurations/Base.xcconfig:
1292 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1294 Add a setting and preferences to enable visual viewport mode
1295 https://bugs.webkit.org/show_bug.cgi?id=160843
1297 Reviewed by Sam Weinig.
1299 Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1301 * MiniBrowser/mac/SettingsController.h:
1302 * MiniBrowser/mac/SettingsController.m:
1303 (-[SettingsController _populateMenu]):
1304 (-[SettingsController validateMenuItem:]):
1305 (-[SettingsController visualViewportEnabled]):
1306 (-[SettingsController toggleVisualViewportEnabled:]):
1307 * MiniBrowser/mac/WK1BrowserWindowController.m:
1308 (-[WK1BrowserWindowController didChangeSettings]):
1309 * MiniBrowser/mac/WK2BrowserWindowController.m:
1310 (-[WK2BrowserWindowController didChangeSettings]):
1312 2016-08-15 Konstantin Tokarev <annulen@yandex.ru>
1314 Allow using make-dist with non-GTK ports
1315 https://bugs.webkit.org/show_bug.cgi?id=160842
1317 Reviewed by Michael Catanzaro.
1319 This patch adds support for setting base name of tarball and argument
1320 passed to cmake's -DPORT= via command line arguments.
1323 (Distcheck.configure):
1325 (get_tarball_root_and_output_filename_from_arguments):
1327 2016-08-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
1329 [GTK] Install script lacks gstreamer related dependencies
1330 https://bugs.webkit.org/show_bug.cgi?id=160814
1332 Reviewed by Carlos Garcia Campos.
1334 * gtk/install-dependencies: Fedora case had already listed this dependencies,
1335 but both Arch and Debian/Ubuntu were missing them.
1337 2016-08-13 Konstantin Tokarev <annulen@yandex.ru>
1339 make-dist.py should not allow unknown rules in manifest
1340 https://bugs.webkit.org/show_bug.cgi?id=160841
1342 Reviewed by Carlos Garcia Campos.
1345 (Manifest.process_line):
1347 2016-08-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
1349 [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1350 https://bugs.webkit.org/show_bug.cgi?id=160809
1352 Reviewed by Carlos Garcia Campos.
1354 * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1355 case, and use it also for the new package names of libpng and libgeoclue.
1356 * gtk/install-dependencies: Ditto.
1358 2016-08-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1360 Skip to check directories existence in build-webkit
1361 https://bugs.webkit.org/show_bug.cgi?id=160691
1363 Reviewed by Alex Christensen.
1365 CMake checks if directories are there itself. So CMake ports
1366 don't need to check it in the build-webkit script.
1368 * Scripts/build-webkit:
1369 * Scripts/webkitdirs.pm:
1370 (determineSourceDir):
1373 2016-08-12 Alex Christensen <achristensen@webkit.org>
1375 Make URLParser work with URLs missing URL parts
1376 https://bugs.webkit.org/show_bug.cgi?id=160824
1378 Reviewed by Brady Eidson.
1380 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1382 (TestWebKitAPI::checkURL):
1383 (TestWebKitAPI::TEST_F):
1384 (TestWebKitAPI::eq): Deleted.
1386 2016-08-12 John Wilander <wilander@apple.com>
1388 Add HashCountedSet API tests to TestWTFLibrary target
1389 https://bugs.webkit.org/show_bug.cgi?id=160815
1391 Reviewed by Alex Christensen.
1393 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1394 Added HashCountedSet.cpp and sorted the file reference section
1395 according to UNIX sort.
1397 2016-08-12 Ryosuke Niwa <rniwa@webkit.org>
1399 run-benchmark should run JetStream 1.1 instead of 1.0.1
1400 https://bugs.webkit.org/show_bug.cgi?id=160816
1402 Reviewed by Filip Pizlo.
1404 Use the latest JetStream 1.1 in run-benchmark.
1406 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1407 (BenchmarkBuilder.__exit__):
1408 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1409 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1410 change to JetStream directory.
1412 2016-08-12 Alex Christensen <achristensen@webkit.org>
1414 Initial URLParser implementation
1415 https://bugs.webkit.org/show_bug.cgi?id=160811
1417 Reviewed by Brady Eidson.
1419 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1420 (TestWebKitAPI::eq):
1421 (TestWebKitAPI::checkURL):
1422 (TestWebKitAPI::TEST_F):
1424 2016-08-12 Brady Eidson <beidson@apple.com>
1426 Fix the 32-bit Mac build after:
1427 Add WK2 ExperimentalFeature support to MiniBrowser
1428 https://bugs.webkit.org/show_bug.cgi?id=160788
1432 Sprinkle "#if WK_API_ENABLED"s liberally.
1434 * MiniBrowser/mac/AppDelegate.m:
1435 (defaultConfiguration):
1436 * MiniBrowser/mac/SettingsController.m:
1437 (-[SettingsController _populateMenu]):
1438 (-[SettingsController validateMenuItem:]):
1440 2016-08-12 Philippe Normand <pnormand@igalia.com>
1442 [GStreamer][OWR] Video rendering fixes
1443 https://bugs.webkit.org/show_bug.cgi?id=160764
1445 Reviewed by Xabier Rodriguez-Calvar.
1447 * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1449 2016-08-12 Per Arne Vollan <pvollan@apple.com>
1451 Add missing return statement in convertFast function added in r204376.
1455 * Scripts/webkitpy/common/system/path.py:
1456 (_CygPath.convertFast):
1458 2016-08-11 Brady Eidson <beidson@apple.com>
1460 Add WK2 ExperimentalFeature support to MiniBrowser.
1461 https://bugs.webkit.org/show_bug.cgi?id=160788
1463 Reviewed by Alex Christensen.
1465 * MiniBrowser/mac/AppDelegate.h:
1466 * MiniBrowser/mac/AppDelegate.m:
1467 (defaultConfiguration):
1468 (defaultPreferences):
1470 * MiniBrowser/mac/SettingsController.m:
1471 (-[SettingsController _populateMenu]):
1472 (-[SettingsController validateMenuItem:]):
1473 (-[SettingsController toggleExperimentalFeature:]):
1475 2016-08-11 Aakash Jain <aakash_jain@apple.com>
1477 Keep EWS logs for longer
1478 https://bugs.webkit.org/show_bug.cgi?id=160776
1480 Reviewed by Daniel Bates.
1482 * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1484 2016-08-11 Simon Fraser <simon.fraser@apple.com>
1486 iOS DRT/WTR project cleanup
1487 https://bugs.webkit.org/show_bug.cgi?id=160778
1489 Reviewed by Tim Horton.
1491 Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1493 Remove AppDelegate.* which were unused.
1495 Exclude ios/Launch.storyboard on more platforms.
1497 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1498 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1499 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1500 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1501 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1502 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1503 (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1505 2016-08-11 Alex Christensen <achristensen@webkit.org>
1507 Fix Yosemite bots' cookie accept policies after r204365.
1508 https://bugs.webkit.org/show_bug.cgi?id=160758
1510 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1512 This makes the test fully clean up after itself.
1514 2016-08-11 Alex Christensen <achristensen@webkit.org>
1516 Fix Yosemite bots' cookie accept policies after r204365.
1517 https://bugs.webkit.org/show_bug.cgi?id=160758
1519 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1521 I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1522 On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1523 On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1524 causing any problems because there are no other API tests that do anything with cookies.
1525 My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1526 but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1527 to reset any bots that have run tests since r204365. I will commit a followup that sets it to originalCookieAcceptPolicy.
1529 2016-08-11 Aakash Jain <aakash_jain@apple.com>
1531 EWS should check if the patch is still valid before executing every major step
1532 https://bugs.webkit.org/show_bug.cgi?id=160739
1533 rdar://problem/27768813
1535 Reviewed by Alexey Proskuryakov.
1537 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1538 (CommitQueueTask.run): validate method is now executed in base class.
1539 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1540 (EarlyWarningSystemTask.run): validate method is now executed in base class.
1541 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1542 (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1543 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1544 (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1545 that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1546 * Scripts/webkitpy/tool/commands/perfalizer.py:
1547 (PerfalizerTask.validate): Added.
1548 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1549 (test_manual_reject_during_processing): Updated test case.
1551 2016-08-11 Alex Christensen <achristensen@webkit.org>
1554 https://bugs.webkit.org/show_bug.cgi?id=160770
1556 Reviewed by Sam Weinig.
1558 * TestWebKitAPI/PlatformGTK.cmake:
1559 * TestWebKitAPI/PlatformWin.cmake:
1560 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1561 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1562 (TestWebKitAPI::TEST_F):
1564 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1566 [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1567 https://bugs.webkit.org/show_bug.cgi?id=160761
1569 Reviewed by Tim Horton.
1571 Give iOS DRT a Launch storyboard.
1573 Have it use a UIViewController so future forms testing works correctly.
1575 Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1576 can run in iPad mode.
1578 Remove empty InfoPlist.strings files.
1580 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1581 * DumpRenderTree/ios/Info.plist:
1582 * DumpRenderTree/ios/Launch.storyboard: Added.
1583 * DumpRenderTree/mac/DumpRenderTree.mm:
1584 (createWebViewAndOffscreenWindow):
1585 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1586 * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1587 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1588 (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1590 2016-08-11 Per Arne Vollan <pvollan@apple.com>
1592 [Win] Unable to reliably run tests in parallel
1593 https://bugs.webkit.org/show_bug.cgi?id=140914
1595 Reviewed by Brent Fulgham.
1597 The cygpath utility function can fail badly when running with multiple DumpRenderTree
1598 processes. We can use string replacement to convert the Cygwin path to a Windows path
1601 * Scripts/webkitpy/common/system/path.py:
1603 * Scripts/webkitpy/port/driver.py:
1604 (Driver._command_from_driver_input):
1606 2016-08-10 Alex Christensen <achristensen@webkit.org>
1608 Fix crash when changing cookie accept policy after r204327
1609 https://bugs.webkit.org/show_bug.cgi?id=160758
1611 Reviewed by Simon Fraser.
1613 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1614 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1615 (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1617 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1619 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1621 [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1622 https://bugs.webkit.org/show_bug.cgi?id=160757
1624 Reviewed by Tim Horton.
1626 When programmatically creating the test UIWindow, make a root UIViewController and parent
1627 the WKWebView in its view. This makes the app more like a normal UIKit application.
1629 Move the WKWebView down 20px to avoid the status bar.
1631 Give the UIWindow a gray background so it's obvious where the window and view positioned.
1633 Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1635 Remove duplicate references to Launch.storyboard.
1637 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1638 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1639 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1640 (-[AppDelegate applicationWillResignActive:]): Deleted.
1641 (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1642 (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1643 (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1644 (-[AppDelegate applicationWillTerminate:]): Deleted.
1645 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1646 (WTR::viewRectForWindowRect):
1647 (WTR::PlatformWebView::PlatformWebView):
1648 (WTR::PlatformWebView::setWindowFrame):
1650 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1652 [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1653 https://bugs.webkit.org/show_bug.cgi?id=160748
1655 Reviewed by Tim Horton.
1657 Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1658 opens the door for tests using other device sizes.
1660 * WebKitTestRunner/ios/TestControllerIOS.mm:
1661 (WTR::TestController::platformConfigureViewForTest):
1663 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1665 Sort the feature flags in the FEATURE_DEFINES lines
1666 https://bugs.webkit.org/show_bug.cgi?id=160742
1668 Reviewed by Anders Carlsson.
1670 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1672 2016-08-09 Simon Fraser <simon.fraser@apple.com>
1674 Logging and other minor improvements to iOS webkitpy
1675 https://bugs.webkit.org/show_bug.cgi?id=160722
1677 Reviewed by Dan Bates.
1679 Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1680 to make it easier to debug launching issues.
1682 Have reset_preferences() reset the device, rather than just nuking the data
1683 directory (which broke some versions of the simulator).
1685 Make the Simulator.app launch in the background with open -g.
1687 Wait for the simulator device to be in a known state in some more places.
1689 * Scripts/webkitpy/port/ios.py:
1690 (IOSSimulatorPort.setup_test_run):
1691 (IOSSimulatorPort._quit_ios_simulator):
1692 (IOSSimulatorPort.clean_up_test_run):
1693 (IOSSimulatorPort.setup_environ_for_server):
1694 (IOSSimulatorPort.reset_preferences):
1695 * Scripts/webkitpy/xcode/simulator.py:
1700 (Simulator.wait_until_device_is_booted):
1701 (Simulator.wait_until_device_is_in_state):
1703 (Simulator.delete_device):
1704 (Simulator.reset_device):
1705 (Simulator.lookup_or_create_device):
1707 2016-08-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
1709 [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1710 https://bugs.webkit.org/show_bug.cgi?id=160697
1712 Reviewed by Antonio Gomes.
1714 * Scripts/webkitpy/port/base.py:
1715 (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1716 list of environment variables to copy.
1718 2016-08-09 George Ruan <gruan@apple.com>
1720 Implement functionality of media capture on iOS
1721 https://bugs.webkit.org/show_bug.cgi?id=158945
1722 <rdar://problem/26893343>
1724 Reviewed by Tim Horton.
1726 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1727 Capture feature on iOS.
1729 2016-08-09 Saam Barati <sbarati@apple.com>
1731 Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1732 https://bugs.webkit.org/show_bug.cgi?id=160671
1733 <rdar://problem/27756112>
1735 Reviewed by Mark Lam.
1737 * Scripts/run-jsc-stress-tests:
1739 2016-08-09 Alexey Proskuryakov <ap@apple.com>
1741 Make directory reading code in iOSSimulatorDevices() more strict
1742 https://bugs.webkit.org/show_bug.cgi?id=160702
1744 Reviewed by Tim Horton.
1746 * Scripts/webkitdirs.pm:
1747 (iOSSimulatorDevices):
1749 2016-08-06 Sam Weinig <sam@webkit.org>
1751 Replace NodeOrString with std::variant<RefPtr<Node>, String>
1752 https://bugs.webkit.org/show_bug.cgi?id=160638
1754 Reviewed by Anders Carlsson.
1756 * TestWebKitAPI/CMakeLists.txt:
1757 * TestWebKitAPI/Tests/WTF/Variant.cpp:
1758 Add additional tests for the initial state of std::variant and using
1759 makeVisitor for visiting.
1761 2016-08-09 Aakash Jain <aakash_jain@apple.com>
1763 EWS logging should ensure the logging to file is stopped on queue termination
1764 https://bugs.webkit.org/show_bug.cgi?id=160698
1765 rdar://problem/24464570
1767 Reviewed by Daniel Bates.
1769 * Scripts/webkitpy/tool/bot/queueengine.py:
1770 (QueueEngine._stopping): Stop logging to file on queue termination.
1771 (QueueEngine._begin_logging): Configure the Python logger to log to file.
1772 * Scripts/webkitpy/common/system/logutils.py:
1773 (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1774 * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1775 (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1776 * Scripts/webkitpy/tool/commands/queues.py:
1777 (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1778 (AbstractQueue.queue_log_path): Same.
1779 (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1780 (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1781 which moved to QueueEngine now.
1782 (PatchProcessingQueue.__init__): Same.
1783 (CommitQueue.__init__): Same.
1784 (AbstractReviewQueue.__init__): Same.
1785 (StyleQueue.__init__): Same.
1786 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1787 (TestCommitQueue): Removed host parameter.
1788 (TestCommitQueue.__init__): Same.
1789 (AbstractPatchQueueTest.test_next_patch): Same.
1790 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1791 (test_commit_queue_failure): Same.
1792 (mock_run_webkit_patch):
1793 (MockCommitQueueTask.results_from_patch_test_run): Same.
1794 (test_rollout_lands): Same.
1795 (test_non_valid_patch): Same.
1796 (test_auto_retry): Same.
1797 (test_style_queue_with_watch_list_exception): Same.
1798 (TestQueue.__init__): Deleted.
1799 (TestReviewQueue.__init__): Deleted.
1800 (TestFeederQueue.__init__): Deleted.
1802 2016-08-09 Konstantin Tokarev <annulen@yandex.ru>
1804 webkit-gtk tarball fails to build due to missing files
1805 https://bugs.webkit.org/show_bug.cgi?id=160684
1807 Reviewed by Alex Christensen.
1809 * gtk/manifest.txt.in: Added back spi directories.
1811 2016-08-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
1813 [GTK] Build the jhbuild with -O2 optimization level by default
1814 https://bugs.webkit.org/show_bug.cgi?id=160544
1816 Reviewed by Michael Catanzaro.
1818 * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1819 which don't increases the required disk space significatively and
1820 provides better debug information than no passing it.
1822 2016-08-09 Csaba Osztrogonác <ossy@webkit.org>
1824 Allow more --cmakeargs option in build-jsc and build-webkit
1825 https://bugs.webkit.org/show_bug.cgi?id=160340
1827 Reviewed by Michael Catanzaro.
1829 * Scripts/build-jsc:
1830 * Scripts/build-webkit:
1832 2016-08-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1834 Do not check if WebKitLibraries folder exists on EFL and GTK
1835 https://bugs.webkit.org/show_bug.cgi?id=160659
1837 Reviewed by Csaba Osztrogonác.
1839 Though WebKitLibraries is only needed by mac and win ports,
1840 EFL and GTK ports have checked whether it exists.
1842 * Scripts/build-webkit:
1844 2016-08-08 Aakash Jain <aakash_jain@apple.com>
1846 Some EWS console logs doesn't go to log file
1847 https://bugs.webkit.org/show_bug.cgi?id=160585
1848 rdar://problem/24464570
1850 Reviewed by Daniel Bates.
1852 * Scripts/webkitpy/common/system/logutils.py:
1853 (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1854 any possible overwriting.
1855 * Scripts/webkitpy/common/system/filesystem.py:
1856 (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1857 * Scripts/webkitpy/common/system/filesystem_mock.py:
1858 (MockFileSystem.open_text_file_for_writing): Same.
1859 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1860 (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1861 (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1862 * Scripts/webkitpy/tool/commands/queues.py:
1863 (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1864 This will ensure that all the sub-modules inside webkitpy will log to file.
1866 2016-08-08 Simon Fraser <simon.fraser@apple.com>
1868 Have the iOS platform interit from the Apple platform in webkitpy
1869 https://bugs.webkit.org/show_bug.cgi?id=160672
1871 Reviewed by Dan Bates.
1873 The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1874 Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1877 Since WinPort also inherits from ApplePort, it needs to stub out some things
1878 that are unavailable on Windows (leaks, sampling).
1880 Some SnowLeopard-related code and the associated test were removed.
1882 * Scripts/webkitpy/port/apple.py:
1883 (ApplePort.__init__):
1885 (ApplePort._make_leak_detector):
1886 (ApplePort.default_timeout_ms):
1887 (ApplePort.supports_per_test_timeout):
1888 (ApplePort.should_retry_crashes):
1889 (ApplePort._generate_all_test_configurations):
1890 (ApplePort.check_for_leaks):
1891 (ApplePort.print_leaks_summary):
1892 (ApplePort._path_to_webcore_library):
1893 (ApplePort.show_results_html_file):
1894 (ApplePort._merge_crash_logs):
1895 (ApplePort._look_for_all_crash_logs_in_log_dir):
1896 (ApplePort._get_crash_log):
1897 (ApplePort.look_for_new_crash_logs):
1898 (ApplePort.sample_process):
1899 (ApplePort.sample_file_path):
1900 (ApplePort.look_for_new_samples):
1901 (ApplePort._path_to_helper):
1902 (ApplePort.determine_full_port_name): Deleted.
1903 * Scripts/webkitpy/port/ios.py:
1905 (IOSSimulatorPort.__init__):
1906 (IOSSimulatorPort.default_timeout_ms): Deleted.
1907 (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1908 (IOSSimulatorPort.should_retry_crashes): Deleted.
1909 (IOSSimulatorPort.check_for_leaks): Deleted.
1910 (IOSSimulatorPort.print_leaks_summary): Deleted.
1911 (IOSSimulatorPort._path_to_webcore_library): Deleted.
1912 (IOSSimulatorPort.show_results_html_file): Deleted.
1913 (IOSSimulatorPort.sample_file_path): Deleted.
1914 (IOSSimulatorPort._merge_crash_logs): Deleted.
1915 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1916 (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1917 (IOSSimulatorPort.look_for_new_samples): Deleted.
1918 (IOSSimulatorPort.sample_process): Deleted.
1919 (IOSSimulatorPort._path_to_helper): Deleted.
1920 (IOSSimulatorPort.make_command): Deleted.
1921 * Scripts/webkitpy/port/mac.py:
1923 (MacPort.make_command):
1924 (MacPort._build_java_test_support):
1926 (MacPort.default_timeout_ms): Deleted.
1927 (MacPort.supports_per_test_timeout): Deleted.
1928 (MacPort.should_retry_crashes): Deleted.
1929 (MacPort.default_child_processes): Deleted.
1930 (MacPort.check_for_leaks): Deleted.
1931 (MacPort.print_leaks_summary): Deleted.
1932 (MacPort._path_to_webcore_library): Deleted.
1933 (MacPort.show_results_html_file): Deleted.
1934 (MacPort.sample_file_path): Deleted.
1935 (MacPort._merge_crash_logs): Deleted.
1936 (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1937 (MacPort.look_for_new_crash_logs): Deleted.
1938 (MacPort.look_for_new_samples): Deleted.
1939 (MacPort.sample_process): Deleted.
1940 (MacPort._path_to_helper): Deleted.
1941 * Scripts/webkitpy/port/mac_unittest.py:
1942 (MacTest.test_default_child_processes): Deleted.
1943 * Scripts/webkitpy/port/win.py:
1944 (WinPort.look_for_new_samples):
1946 (WinPort.sample_process):
1947 (WinPort._make_leak_detector):
1948 (WinPort.check_for_leaks):
1949 (WinPort.print_leaks_summary):
1950 (WinPort._path_to_webcore_library):
1952 2016-08-08 Matt Baker <mattbaker@apple.com>
1954 Unreviewed: moved myself to the reviewers list.
1956 * Scripts/webkitpy/common/config/contributors.json:
1958 2016-08-08 Chris Dumez <cdumez@apple.com>
1960 Update API tests in mac/SetDocumentURI.mm after r204247
1961 https://bugs.webkit.org/show_bug.cgi?id=160660
1963 Reviewed by Alex Christensen.
1965 * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1966 (TestWebKitAPI::TEST):
1968 2016-08-08 Jonathan Bedard <jbedard@apple.com>
1970 run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1971 https://bugs.webkit.org/show_bug.cgi?id=159827
1973 Reviewed by Daniel Bates.
1975 This change was spurred by a process hang which occurred between tests and did
1976 not produce a meaningful crashlog.
1978 * Scripts/webkitpy/port/driver.py:
1979 (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1981 * Scripts/webkitpy/port/ios.py:
1983 (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1984 * Scripts/webkitpy/port/mac.py:
1986 (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1988 * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1989 * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1991 * WebKitTestRunner/TestController.h:
1992 (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1993 * WebKitTestRunner/TestInvocation.cpp:
1994 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1996 2016-08-07 Dan Bernstein <mitz@apple.com>
1998 [Cocoa] Reply block leaks if the remote object doesn’t call it
1999 https://bugs.webkit.org/show_bug.cgi?id=160642
2001 Reviewed by Sam Weinig.
2003 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
2004 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2005 (TEST): Added a test case that checks that the reply block is released even when it’s not
2007 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2008 (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
2009 calling the completion handler.
2011 2016-08-07 Chris Dumez <cdumez@apple.com>
2013 Write API test to cover crash fix in r204135
2014 https://bugs.webkit.org/show_bug.cgi?id=160587
2016 Reviewed by Darin Adler.
2018 Add API test to cover crash fix in r204135. This reproduces the crash
2019 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2022 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2023 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2026 2016-08-06 Chris Dumez <cdumez@apple.com>
2028 Unreviewed, rolling out r204226.
2030 Broke some API tests
2034 "Write API test to cover crash fix in r204135"
2035 https://bugs.webkit.org/show_bug.cgi?id=160587
2036 http://trac.webkit.org/changeset/204226
2038 2016-08-06 Aakash Jain <aakash_jain@apple.com>
2040 EWS Style Queue fails to process patches which fails validation
2041 https://bugs.webkit.org/show_bug.cgi?id=160632
2043 Reviewed by Alexey Proskuryakov.
2045 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2046 (StyleQueueTask.validate): Add more information about validation failure.
2047 (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2048 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2049 (test_non_valid_patch): Add a unit test to test the above code path.
2051 2016-08-06 Sam Weinig <sam@webkit.org>
2053 WTF needs a variant implementation
2054 https://bugs.webkit.org/show_bug.cgi?id=160618
2056 Reviewed by Darin Adler.
2058 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2059 * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2060 Add tests for the variant implementation.
2062 2016-08-06 Chris Dumez <cdumez@apple.com>
2064 Write API test to cover crash fix in r204135
2065 https://bugs.webkit.org/show_bug.cgi?id=160587
2067 Reviewed by Darin Adler.
2069 Add API test to cover crash fix in r204135. This reproduces the crash
2070 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2073 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2074 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2077 2016-08-05 Tim Horton <timothy_horton@apple.com>
2079 run-api-tests should use a headed simulator
2080 https://bugs.webkit.org/show_bug.cgi?id=160611
2082 Reviewed by Sam Weinig.
2084 CADisplayLink doesn't work in a headless simulator, but is
2085 vital for the proper functioning of WebKit2 painting on iOS.
2086 So, we should not use a headless simulator.
2088 * Scripts/run-api-tests:
2089 Launch a simulator app, don't just boot the simulator.
2091 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2092 Re-enable a test that works now.
2094 2016-08-05 Dan Bernstein <mitz@apple.com>
2096 [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2097 https://bugs.webkit.org/show_bug.cgi?id=160589
2099 Reviewed by Tim Horton.
2101 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2102 (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2103 blocks, which wasn’t caught because the test wasn’t run correctly.
2104 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2105 (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2106 added a test that sends over an NSRange.
2107 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2108 (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2109 handler with the range‘s location and length.
2111 2016-08-05 Enrica Casucci <enrica@apple.com>
2113 Fixing tests failing after r204175.
2117 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2119 2016-08-05 Enrica Casucci <enrica@apple.com>
2121 Build fix after 204053.
2125 * TestWebKitAPI/Configurations/Base.xcconfig:
2126 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2127 (-[MockContentFilterEnabler initWithCoder:]):
2128 (-[MockContentFilterEnabler dealloc]):
2130 2016-08-05 Konstantin Tokarev <annulen@yandex.ru>
2132 Print test name in "Last character read from DRT..." error message.
2133 https://bugs.webkit.org/show_bug.cgi?id=160559
2135 Reviewed by Michael Catanzaro.
2137 * Scripts/webkitpy/port/driver.py:
2139 (Driver._read_first_block):
2140 (Driver._read_optional_image_block):
2141 (Driver._read_block):
2142 * Scripts/webkitpy/port/driver_unittest.py:
2143 (DriverTest.test_read_block):
2144 (DriverTest.test_read_binary_block):
2145 (DriverTest.test_read_base64_block):
2147 2016-08-05 Commit Queue <commit-queue@webkit.org>
2149 Unreviewed, rolling out r204123.
2150 https://bugs.webkit.org/show_bug.cgi?id=160597
2152 Caused layout test timeouts on Windows. (Requested by perarne
2157 "[Win] Unable to reliably run tests in parallel"
2158 https://bugs.webkit.org/show_bug.cgi?id=140914
2159 http://trac.webkit.org/changeset/204123
2161 2016-08-04 Saam Barati <sbarati@apple.com>
2163 Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2164 https://bugs.webkit.org/show_bug.cgi?id=151241
2166 Reviewed by Benjamin Poulain.
2168 * Scripts/run-jsc-stress-tests:
2170 2016-08-04 Dean Johnson <dean_johnson@apple.com>
2172 UI improvements to Flakiness Dashboard.
2173 https://bugs.webkit.org/show_bug.cgi?id=153295
2175 Reviewed by Alexey Proskuryakov.
2177 * TestResultServer/static-dashboards/flakiness_dashboard.css:
2178 (td.options-container): Center text in most fields.
2179 * TestResultServer/static-dashboards/flakiness_dashboard.js:
2180 (createBugHTML): Text/Grammar updates.
2181 (tableHeaders): Ditto.
2182 (htmlForSingleTestRow): Ditto.
2183 (headerForTestTableHtml): Ditto.
2184 * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2185 (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2187 2016-08-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
2189 [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2190 https://bugs.webkit.org/show_bug.cgi?id=160518
2192 Reviewed by Michael Catanzaro.
2194 * Scripts/webkitpy/thirdparty/__init__.py:
2195 (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2196 * gtk/install-dependencies:
2198 2016-08-04 Alexey Proskuryakov <ap@apple.com>
2200 Optimize bot watcher's dashboard a little
2201 https://bugs.webkit.org/show_bug.cgi?id=160515
2202 rdar://problem/26096900
2204 Reviewed by Lucas Forschler.
2206 Made re-sorting after loading an iteration more efficient.
2208 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2209 (BuildbotIteration.prototype._updateWithData):
2210 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2211 (BuildbotQueue.prototype.updateIterationPosition):
2213 2016-08-04 Per Arne Vollan <pvollan@apple.com>
2215 [Win] Unable to reliably run tests in parallel
2216 https://bugs.webkit.org/show_bug.cgi?id=140914
2218 Reviewed by Brent Fulgham.
2220 The cygpath utility function can fail badly when running with multiple DumpRenderTree
2221 processes. We can use string replacement to convert the Cygwin path to a Windows path
2224 * Scripts/webkitpy/common/system/path.py:
2226 * Scripts/webkitpy/port/driver.py:
2227 (Driver._command_from_driver_input):
2229 2016-08-03 Aakash Jain <aakash_jain@apple.com>
2231 Document instructions for increasing process and file limits
2232 https://bugs.webkit.org/show_bug.cgi?id=160528
2233 rdar://problem/24777576
2235 Reviewed by Alexey Proskuryakov.
2237 * Scripts/webkitpy/port/ios.py:
2238 (IOSSimulatorPort.default_child_processes):
2240 2016-08-03 Anders Carlsson <andersca@apple.com>
2242 Remove the Objective-C bindings generator
2243 https://bugs.webkit.org/show_bug.cgi?id=160526
2245 Reviewed by Sam Weinig.
2247 * Scripts/run-bindings-tests:
2250 2016-08-03 Tim Horton <timothy_horton@apple.com>
2252 Revise a TestWebKitAPI comment to mention the actual underlying problem
2254 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2255 Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2257 2016-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
2259 Benchmark test content-animation timeouts always
2260 https://bugs.webkit.org/show_bug.cgi?id=160057
2262 Reviewed by Simon Fraser.
2264 * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2265 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2268 2016-08-02 Nan Wang <n_wang@apple.com>
2270 AX: Simulated touch events are not working on iOS
2271 https://bugs.webkit.org/show_bug.cgi?id=160395
2272 <rdar://problem/27633597>
2274 Reviewed by Chris Fleizach.
2276 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2277 (WTR::AccessibilityUIElement::press):
2278 (WTR::AccessibilityUIElement::setSelectedChild):
2280 2016-08-02 Filip Pizlo <fpizlo@apple.com>
2282 run-javascriptcore-tests should accept multiple --extra-tests
2283 https://bugs.webkit.org/show_bug.cgi?id=160486
2285 Reviewed by Saam Barati.
2287 We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2288 test suites. This does it by using GetOpt::Long's array support.
2290 * Scripts/run-javascriptcore-tests:
2291 (runJSCStressTests):
2293 2016-08-02 Enrica Casucci <enrica@apple.com>
2295 Allow building with content filtering disabled.
2296 https://bugs.webkit.org/show_bug.cgi?id=160454
2298 Reviewed by Simon Fraser.
2300 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2302 2016-08-02 Brady Eidson <beidson@apple.com>
2304 Removing IndexedDB WebsiteData can fail for some users.
2305 https://bugs.webkit.org/show_bug.cgi?id=160463
2307 Reviewed by Alex Christensen.
2309 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2311 2016-08-01 Alex Christensen <achristensen@webkit.org>
2313 _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2314 https://bugs.webkit.org/show_bug.cgi?id=160437
2315 <rdar://problem/27578272>
2317 Reviewed by Brady Eidson.
2319 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2320 (-[DownloadDelegate _download:didReceiveResponse:]):
2321 (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2323 Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2325 2016-08-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
2327 [Tools] The GDB backtrace report tool don't checks the gdb return code.
2328 https://bugs.webkit.org/show_bug.cgi?id=160414
2330 Reviewed by Michael Catanzaro.
2332 * Scripts/webkitpy/port/linux_get_crash_log.py:
2333 (GDBCrashLogGenerator._wait_for_corefile):
2335 2016-08-01 Youenn Fablet <youenn@apple.com>
2337 Make wpt server generate its certificates in layout test results folder
2338 https://bugs.webkit.org/show_bug.cgi?id=160422
2340 Reviewed by Chris Dumez.
2342 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2343 (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2345 2016-08-01 Jonathan Bedard <jbedard@apple.com>
2347 Function Call on NULL Object
2348 https://bugs.webkit.org/show_bug.cgi?id=160325
2350 Reviewed by Darin Adler.
2352 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2353 (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2354 * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2356 2016-08-01 Keith Miller <keith_miller@apple.com>
2358 We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2359 https://bugs.webkit.org/show_bug.cgi?id=160372
2361 Rubber stamped by Geoffrey Garen.
2363 This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2364 a new top level directory, JSTests. Having the tests in the Source directory
2365 was both confusing an inconvenient for people that just want to checkout the
2366 source code of WebKit. Since there is no other obvious place to put all the
2367 JavaScript tests a new top level directory seemed the most sensible.
2369 * Scripts/import-test262-tests:
2370 * Scripts/run-javascriptcore-tests:
2371 * Scripts/update-javascriptcore-test-res:
2373 2016-07-31 Nan Wang <n_wang@apple.com>
2375 AX: Add a check for touch event listener on iOS accessibility object
2376 https://bugs.webkit.org/show_bug.cgi?id=160388
2378 Reviewed by Chris Fleizach.
2380 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2381 (AccessibilityUIElement::boolAttributeValue):
2382 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2383 (WTR::AccessibilityUIElement::boolAttributeValue):
2385 2016-07-30 Manuel Rego Casasnovas <rego@igalia.com>
2387 Unreviewed: add myself to the reviewers list.
2389 * Scripts/webkitpy/common/config/contributors.json:
2391 2016-07-29 Alexey Proskuryakov <ap@apple.com>
2393 Undo r203939, and copy over a rule that clips the logos.
2395 Sierra wasn't the only logo without transparency.
2397 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2398 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2399 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2401 2016-07-29 Alan Sien Wei Hshieh <hshieh@apple.com>
2403 The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2404 https://bugs.webkit.org/show_bug.cgi?id=160377
2406 Reviewed by Brian Weinstein.
2408 Update assets to remove the white background and use a transparent background instead.
2410 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2411 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2413 2016-07-29 David Kilzer <ddkilzer@apple.com>
2415 Ignore most check-webkit-style checks for ANGLE project
2416 <https://webkit.org/b/160333>
2418 Reviewed by Daniel Bates.
2420 * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2422 - No spaces at the end of lines.
2423 - No carriage returns (DOS line endings).
2425 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
2427 Media controls are not displayed for some autoplaying videos at certain browser dimensions
2428 https://bugs.webkit.org/show_bug.cgi?id=160360
2429 <rdar://problem/27179484>
2431 Reviewed by Myles C. Maxfield.
2433 Adds two tests verifying that videos may be considered main content as long as they
2434 are large enough and cover a majority of the mainframe's viewport.
2436 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2437 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2438 (TestWebKitAPI::TEST):
2439 * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2440 * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2442 2016-07-29 Mark Lam <mark.lam@apple.com>
2444 Gardening: removed unused variable.
2448 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2449 (TestWebKitAPI::TEST):
2451 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
2453 Add TestWebKitAPI support for interacting with media controls
2454 https://bugs.webkit.org/show_bug.cgi?id=160342
2455 <rdar://problem/27610246>
2457 Reviewed by Beth Dakin.
2459 Adds support for testing interaction with some media controls, as well as a basic test
2460 verifying that media control teardown after interaction does not result in a crash.
2462 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2463 (-[WKWebView mouseDownAtPoint:]):
2464 (-[WKWebView performAfterLoading:]):
2465 (TestWebKitAPI::TEST):
2467 2016-07-29 Jonathan Bedard <jbedard@apple.com>
2469 Crash Log Clobbering on Unbound Crashes
2470 https://bugs.webkit.org/show_bug.cgi?id=160198
2471 <rdar://problem/27472618>
2473 Reviewed by Alexey Proskuryakov.
2475 * Scripts/webkitpy/common/system/crashlogs.py:
2476 (CrashLogs): Fix header order.
2477 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2478 (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2480 2016-07-29 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
2482 Update for contributors.json
2483 https://bugs.webkit.org/show_bug.cgi?id=160294
2485 * Scripts/webkitpy/common/config/contributors.json:
2487 2016-07-28 Myles C. Maxfield <mmaxfield@apple.com>
2489 Remove deprecated SPI for video inline / fullscreen controls
2490 https://bugs.webkit.org/show_bug.cgi?id=160318
2492 Reviewed by Tim Horton.
2494 * DumpRenderTree/mac/DumpRenderTree.mm:
2495 (setDefaultsToConsistentValuesForTesting): Deleted.
2496 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2497 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2498 * WebKitTestRunner/TestController.cpp:
2499 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2500 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2501 (WTR::initializeWebViewConfiguration): Deleted.
2503 2016-07-28 Daniel Bates <dabates@apple.com>
2505 [iOS] TestWebKitAPI bundle targets are not code signed
2506 https://bugs.webkit.org/show_bug.cgi?id=160328
2507 <rdar://problem/27409246>
2509 Reviewed by Andy Estes.
2511 Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2512 CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2513 the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2515 * TestWebKitAPI/Configurations/Base.xcconfig:
2517 2016-07-28 Tim Horton <timothy_horton@apple.com>
2519 Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2521 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2522 (animatedResizeWebView):
2524 This test times out only when run in the WebKit Testing simulator environment,
2525 but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2527 2016-07-28 Tim Horton <timothy_horton@apple.com>
2529 Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2530 https://bugs.webkit.org/show_bug.cgi?id=160289
2531 <rdar://problem/27553464>
2533 Reviewed by Simon Fraser.
2535 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2536 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2537 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2538 (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2539 (-[AnimatedResizeWebView _endAnimatedResize]):
2540 (animatedResizeWebView):
2542 * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2543 Add two tests that ensure that hidden-content and animated resizes
2544 don't cause unnecessary synchronous waits. Only the hidden-content
2545 one fails before my patch, but it seemed reasonable to add both anyway.
2547 2016-07-28 David Kilzer <ddkilzer@apple.com>
2549 webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2550 <https://webkit.org/b/83342>
2552 Reviewed by Ryosuke Niwa.
2554 * Scripts/webkitpy/common/checkout/scm/git.py:
2555 (Git.revisions_changing_file): Remove code to raise an exception
2556 when the file doesn't exist. If a file was moved or renamed,
2557 then this caused the script to terminate, which was very
2558 frustrating when you wanted a list of reviewers.
2559 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2560 (SCMTest._shared_test_revisions_changing_file): Update test
2561 expectation to return an empty list of revisions.
2562 (test_create_patch_is_full_patch): Drive-by fix when running all
2563 webkitpy tests (including scm tests).
2564 * Scripts/webkitpy/common/checkout/scm/svn.py:
2565 (SVN.revisions_changing_file): Catch ScriptError exceptions and
2566 return an empty array of revisions if this occurs.
2568 2016-07-28 Aakash Jain <aakash_jain@apple.com>
2570 EWS error message "Error: * did not process patch" should include explanation
2571 https://bugs.webkit.org/show_bug.cgi?id=159903
2572 <rdar://problem/27410788>
2574 Reviewed by Alexey Proskuryakov.
2576 * QueueStatusServer/handlers/statusbubble.py:
2577 (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2579 * QueueStatusServer/handlers/processingtimesjson.py:
2580 (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2582 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2583 (CommitQueueTask.validate): Add more information about validation failure.
2584 (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2585 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2586 (EarlyWarningSystemTask.validate): Add more information about validation failure.
2587 (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2588 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2589 (PatchIsNotValid.__init__): Add the failure_message argument.
2590 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2591 (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2593 * Scripts/webkitpy/tool/commands/queues.py:
2594 (CommitQueue.process_work_item): Same.
2595 (StyleQueue.review_patch): Same.
2596 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2597 (test_non_valid_patch): Updated test-cases messages to match the above changes.
2599 2016-07-27 Alexey Proskuryakov <ap@apple.com>
2601 LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2602 https://bugs.webkit.org/show_bug.cgi?id=160262
2604 Reviewed by Daniel Bates.
2606 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2607 (-[LTRelayController installApp]):
2609 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
2611 Disable WebCoreNSURLSessionTest API tests on ios-simulator
2612 https://bugs.webkit.org/show_bug.cgi?id=160225
2614 Reviewed by Alexey Proskuryakov.
2616 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2618 2016-07-27 Miguel Gomez <magomez@igalia.com>
2620 [GTK] Fix some video/canvas tests that should be passing
2621 https://bugs.webkit.org/show_bug.cgi?id=160023
2623 Reviewed by Carlos Garcia Campos.
2625 Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2626 EFL or GTK platforms.
2628 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2629 (WTR::TestController::platformConfigureViewForTest):
2630 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2631 (WTR::TestController::platformConfigureViewForTest):
2633 2016-07-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
2635 [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2636 https://bugs.webkit.org/show_bug.cgi?id=160247
2638 Reviewed by Michael Catanzaro.
2640 * BuildSlaveSupport/built-product-archive:
2643 (archiveBuiltProduct):
2645 2016-07-26 Alex Christensen <achristensen@webkit.org>
2647 Fix tests after r203743.
2648 https://bugs.webkit.org/show_bug.cgi?id=156947
2650 * WebKitTestRunner/TestController.cpp:
2651 (WTR::TestController::resetStateToConsistentValues):
2652 Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2654 2016-07-26 Myles C. Maxfield <mmaxfield@apple.com>
2656 [iPhone] Playing a video on tudou.com plays only sound, no video
2657 https://bugs.webkit.org/show_bug.cgi?id=160178
2658 <rdar://problem/27535468>
2660 Reviewed by Dan Bernstein.
2662 * DumpRenderTree/mac/DumpRenderTree.mm:
2663 (setDefaultsToConsistentValuesForTesting):
2664 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2665 (RequiresUserActionForPlaybackTest::SetUp):
2666 * WebKitTestRunner/TestController.cpp:
2667 (WTR::TestController::resetPreferencesToConsistentValues):
2668 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2669 (WTR::initializeWebViewConfiguration):
2671 2016-07-26 Simon Fraser <simon.fraser@apple.com>
2673 Allow LOG macros to be used outside the namespace, and other logging cleanup
2674 https://bugs.webkit.org/show_bug.cgi?id=160216
2676 Reviewed by Anders Carlsson.
2678 initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2680 * DumpRenderTree/TestRunner.cpp:
2681 * DumpRenderTree/mac/DumpRenderTree.mm:
2682 (resetWebViewToConsistentStateBeforeTesting):
2684 2016-07-26 David Kilzer <ddkilzer@apple.com>
2686 Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2687 https://bugs.webkit.org/show_bug.cgi?id=156947
2688 <rdar://problem/23325160>
2690 Reviewed by Alex Christensen.
2692 * DumpRenderTree/TestRunner.cpp:
2693 (TestRunner::TestRunner):
2694 (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2695 * DumpRenderTree/TestRunner.h:
2696 (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2697 (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2698 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2699 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2700 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2701 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2702 (WTR::TestRunner::queueNonLoadingScript):
2703 (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2704 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2705 * WebKitTestRunner/TestController.cpp:
2706 (WTR::TestController::didReceiveAuthenticationChallenge):
2707 * WebKitTestRunner/TestController.h:
2708 (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2709 * WebKitTestRunner/TestInvocation.cpp:
2710 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2711 Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2713 2016-07-26 David Kilzer <ddkilzer@apple.com>
2715 check-for-exit-time-destructors should be usable outside Xcode
2716 <https://webkit.org/b/160195>
2718 Reviewed by Darin Adler.
2720 * Scripts/check-for-exit-time-destructors: Update to parse
2721 -h|--help switch, or to take one argument to a binary to check
2722 for exit time destructors on the command-line. The clang
2723 compiler will find these at compile-time with the
2724 -Wexit-time-destructors switch, but this script will check for
2725 them after-the-fact.
2727 2016-07-26 Lucas Forschler <lforschler@apple.com>
2729 Test svn.webkit.org functionality after maintenance.
2731 2016-07-25 Brady Eidson <beidson@apple.com>
2733 Modern IDB: Make sure IndexedDB works from file:// url documents by default
2734 https://bugs.webkit.org/show_bug.cgi?id=153783
2736 Reviewed by Alex Christensen.
2738 Previously, to grant IndexedDB access to file:// urls for testing purposes,
2739 we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2741 As of https://trac.webkit.org/changeset/203695 this is no longer required.
2743 Change the relevant API tests to make sure this continues to be no longer required.
2745 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2746 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2747 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2748 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2749 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2750 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2752 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
2754 Media controls should not be displayed for a video until it starts playing
2755 https://bugs.webkit.org/show_bug.cgi?id=160092
2756 <rdar://problem/26986673>
2758 Reviewed by Beth Dakin.
2760 Verify that multiple videos do or don't show the media controller depending on whether videos
2761 are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2762 passing because we were always showing media controls for large videos with audio, even if they
2763 had not played back yet. This change ensures that large videos with audio show media controls
2764 only after they begin to play back, and not by virtue of being large enough for main content.
2766 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2767 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2768 (TestWebKitAPI::TEST):
2769 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2770 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2771 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2773 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
2775 Media controls on apple.com don't disappear when movie finishes playing
2776 https://bugs.webkit.org/show_bug.cgi?id=160068
2777 <rdar://problem/26668526>
2779 Reviewed by Darin Adler.
2781 Adds new API tests. Please see WebCore ChangeLog for more details.
2783 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2784 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2785 (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2786 (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2787 (TestWebKitAPI::TEST):
2788 (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2789 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2790 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2791 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2792 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2794 2016-07-25 Philippe Normand <pnormand@igalia.com>
2796 Unreviewed, fix test-webkitpy after r203674.
2798 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2799 (GDBCrashLogGeneratorTest.test_generate_crash_log):
2801 2016-07-24 Philippe Normand <pnormand@igalia.com>
2803 Unreviewed, forgot to commit this file in r203674.
2805 * Scripts/process-linux-coredump: Added.
2808 2016-07-25 Philippe Normand <pnormand@igalia.com>
2810 Improve GDB backtrace generation for GTK/EFL
2811 https://bugs.webkit.org/show_bug.cgi?id=128928
2813 Reviewed by Carlos Garcia Campos.
2815 The PID of the crashed process is now correctly supplied to the
2816 crash log reporter. The kernel core_pattern needs to be updated
2817 after this change to something like:
2819 echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2821 * Scripts/process-linux-coredump: Added.
2822 (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2823 * Scripts/webkitpy/port/efl.py:
2824 (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2825 * Scripts/webkitpy/port/gtk.py:
2826 (GtkPort._get_crash_log): Ditto.
2827 * Scripts/webkitpy/port/linux_get_crash_log.py:
2828 (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2829 (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2830 (GDBCrashLogGenerator): Deleted.
2831 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2832 (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2833 * WebKitTestRunner/TestController.cpp:
2834 (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2835 (WTR::TestController::databaseProcessDidCrash): Ditto.
2836 (WTR::TestController::processDidCrash): Ditto.
2838 2016-07-23 Youenn Fablet <youenn@apple.com>
2840 WPT stash server should be kept running when launching wpt server
2841 https://bugs.webkit.org/show_bug.cgi?id=160052
2843 Reviewed by Sam Weinig.
2845 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2846 (main): waiting to read stdin while stash server is started.
2848 2016-07-22 Wenson Hsieh <wenson_hsieh@apple.com>
2850 Media controls should be displayed for media in media documents
2851 https://bugs.webkit.org/show_bug.cgi?id=160104
2852 <rdar://problem/27438936>
2854 Reviewed by Myles C. Maxfield.
2856 Verifies that even a small video with audio in a media document gets media controls.
2858 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2859 (TestWebKitAPI::TEST):
2861 2016-07-22 Michael Saboff <msaboff@apple.com>
2863 REGRESSION(203616): no FTL testing was inadvertently removed
2864 https://bugs.webkit.org/show_bug.cgi?id=160100
2866 Rubber-stamped by Filip Pizlo.
2868 Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2869 Renamed runLayoutTestNoFTL to runLayoutTestDefault. Restructured the test
2870 logic for the runLayout and runNoisy variants to match the run test logic,
2871 that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2874 * Scripts/run-jsc-stress-tests:
2876 2016-07-22 Brady Eidson <beidson@apple.com>
2878 Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2879 https://bugs.webkit.org/show_bug.cgi?id=160089
2881 Reviewed by Darin Adler.
2883 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2884 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2885 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2887 2016-07-22 Konstantin Tokarev <annulen@yandex.ru>
2889 [GTK] Improved exclusion patterns in make-dist.py manifest.
2890 https://bugs.webkit.org/show_bug.cgi?id=160094
2892 Reviewed by Michael Catanzaro.
2894 * gtk/manifest.txt.in:
2895 Exclude Platform*.cmake files for more ports.
2896 Removed obsolete .gyp and .pro.user patterns.
2897 Exclude 'Configurations' and 'spi' directories.
2898 Exclude CMakeLists.txt.user (Qt Creator IDE).
2900 2016-07-22 Michael Saboff <msaboff@apple.com>
2902 Don't run FTL related JSC stress tests on non-FTL platforms
2903 https://bugs.webkit.org/show_bug.cgi?id=160033
2905 Reviewed by Mark Lam.
2907 Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2908 Refactored several of the runXXX test methods to always runXXXDefault and made those
2909 runXXXDefault to pass FTL_OPTIONS. For platforms that don't enable the FTL, FTL_OPTIONS
2910 doesn't cause a problem.
2912 * Scripts/run-jsc-stress-tests:
2914 2016-07-22 Per Arne Vollan <pvollan@apple.com>
2916 IWebView::mainFrame crashes if called after IWebView::close
2917 https://bugs.webkit.org/show_bug.cgi?id=32868
2919 Reviewed by Brent Fulgham.
2921 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2922 (TestWebKitAPI::TEST_F): Added test.
2924 2016-07-22 Carlos Garcia Campos <cgarcia@igalia.com>
2926 [GTK] Enable threaded compositor by default
2927 https://bugs.webkit.org/show_bug.cgi?id=160079
2929 Reviewed by Žan Doberšek.
2931 * Scripts/webkitperl/FeatureList.pm:
2933 2016-07-22 Youenn Fablet <youenn@apple.com>
2935 run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2936 https://bugs.webkit.org/show_bug.cgi?id=159921
2938 Reviewed by Brian Burg.
2940 Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2942 * Scripts/webkitpy/codegen/main.py:
2943 (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2944 (BuiltinsGeneratorTests):
2945 (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2946 (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2947 (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2948 (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2950 2016-07-21 Dan Bernstein <mitz@apple.com>
2952 [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2953 https://bugs.webkit.org/show_bug.cgi?id=160072
2955 Reviewed by Andy Estes.
2957 * Scripts/webkitdirs.pm:
2958 (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2959 for old Xcode versions.
2960 (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2961 to readXcodeUserDefault.
2962 (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2964 (determineDebugger): Ditto.
2965 (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2967 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2969 (execMacWebKitAppForDebugging): Removed support for GDB.
2971 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
2973 Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2974 https://bugs.webkit.org/show_bug.cgi?id=160066
2976 Reviewed by Dean Jackson.
2978 * DumpRenderTree/mac/DumpRenderTree.mm:
2979 (setDefaultsToConsistentValuesForTesting): Deleted.
2980 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2981 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2982 * WebKitTestRunner/TestController.cpp:
2983 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2984 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2985 (WTR::initializeWebViewConfiguration): Deleted.
2987 2016-07-21 Chelsea Pugh <cpugh@apple.com>
2989 [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2990 https://bugs.webkit.org/show_bug.cgi?id=159980
2991 rdar://problem/27450825
2993 Reviewed by Dan Bernstein.
2995 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2996 * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2997 (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2998 when our delegate has hit -dealloc.
2999 (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
3000 and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
3001 will not be messaged.
3003 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3005 Follow-up patch to r203520
3006 https://bugs.webkit.org/show_bug.cgi?id=159967
3007 <rdar://problem/26964090>
3011 * DumpRenderTree/mac/DumpRenderTree.mm:
3012 (setDefaultsToConsistentValuesForTesting):
3013 * WebKitTestRunner/TestController.cpp:
3014 (WTR::TestController::resetPreferencesToConsistentValues):
3016 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3018 [iPhone] Playing a video on tudou.com plays only sound, no video
3019 https://bugs.webkit.org/show_bug.cgi?id=159967
3020 <rdar://problem/26964090>
3022 Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3024 Migrate tests to use new SPI.
3026 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3027 (RequiresUserActionForPlaybackTest::SetUp):
3028 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3029 (WTR::initializeWebViewConfiguration):
3031 2016-07-21 Csaba Osztrogonác <ossy@webkit.org>
3033 Clarify testing mode names in run-jsc-stress-tests
3034 https://bugs.webkit.org/show_bug.cgi?id=160021
3036 Reviewed by Mark Lam.
3038 Default should mean really default, not default with disabled FTL, renamed
3039 - runMozillaTestDefault to runMozillaTestNoFTL
3040 - runMozillaTestDefaultFTL to runMozillaTestDefault
3041 - runDefault to runNoFTL
3042 - runDefaultFTL to runDefault
3043 - runLayoutTestDefault to runLayoutTestNoFTL
3044 - runLayoutTestDefaultFTL to runLayoutTestDefault
3045 - runNoisyTestDefault to runNoisyTestNoFTL
3046 - runNoisyTestDefaultFTL to runNoisyTestDefault
3048 * Scripts/run-jsc-stress-tests:
3050 2016-07-21 Yongjun Zhang <yongjun_zhang@apple.com>
3052 WebBackForwardList's currentIndex could get out of bounds when filtering items.
3053 https://bugs.webkit.org/show_bug.cgi?id=159986
3055 Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3058 Reviewed by Dan Bernstein.
3060 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3061 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3062 (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3065 2016-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
3067 [GTK] Web view background colors don't work in accelerated compositing mode
3068 https://bugs.webkit.org/show_bug.cgi?id=159455
3070 Reviewed by Michael Catanzaro.
3072 Set always RGBA visual to the view widget when setting a background color.
3074 * MiniBrowser/gtk/BrowserWindow.c:
3075 (browser_window_set_background_color):
3077 2016-07-20 Youenn Fablet <youenn@apple.com>
3079 Bots should run built-ins generator tests
3080 https://bugs.webkit.org/show_bug.cgi?id=159971
3082 Reviewed by Alexey Proskuryakov.
3084 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3085 (RunBuiltinsTests): New step to run built-in generator tests.
3086 (TestFactory.__init__): Adding an additional step for bultin generator tests.
3087 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3088 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3090 2016-07-20 Aakash Jain <aakash_jain@apple.com>
3092 Revert temporary fix r203417
3093 https://bugs.webkit.org/show_bug.cgi?id=160001
3095 Reviewed by Alexey Proskuryakov.
3097 * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3099 2016-07-20 Aakash Jain <aakash_jain@apple.com>
3101 REGRESSION(r148588): ews classes might get garbage collected
3102 https://bugs.webkit.org/show_bug.cgi?id=159990
3104 Reviewed by Ryosuke Niwa.
3106 * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3107 in a variable so that they do not get garbage collected.
3109 2016-07-20 Jeremy Jones <jeremyj@apple.com>
3111 Add API test for layout constraints after exit fullscreen
3112 https://bugs.webkit.org/show_bug.cgi?id=159900
3114 Reviewed by Jon Lee.
3116 Added Fullscreen.LaytoutConstraints API test.
3117 Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3119 This test compares layout constraints on the web view before and after fullscreen to make sure
3122 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3123 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3124 (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3125 (TestWebKitAPI::TEST):
3127 2016-07-20 Ryan Haddad <ryanhaddad@apple.com>
3129 Disable two failing API tests.
3131 Unreviewed test gardening.
3133 * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3134 (TestWebKitAPI::TEST):
3136 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
3138 Unreviewed iOS build fix.
3140 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3142 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
3144 Media controls don't appear when pausing a small autoplaying video
3145 https://bugs.webkit.org/show_bug.cgi?id=159972
3146 <rdar://problem/27180657>
3148 Reviewed by Beth Dakin.
3150 Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3151 for simulating basic user interaction in VideoControlsManager.
3153 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3154 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3155 (-[WKWebView mouseDownAtPoint:]):
3156 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3157 (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3158 (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3159 (TestWebKitAPI::TEST):
3160 * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3162 2016-07-20 Per Arne Vollan <pvollan@apple.com>
3164 [Win] MathML fonts are not found.
3165 https://bugs.webkit.org/show_bug.cgi?id=159920
3167 Reviewed by Alex Christensen.
3169 When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3170 for a specific registry key value.
3172 * Scripts/webkitdirs.pm:
3175 2016-07-20 Joseph Pecoraro <pecoraro@apple.com>
3177 Improve prepare-ChangeLog for @media blocks
3178 https://bugs.webkit.org/show_bug.cgi?id=159907
3180 Reviewed by Timothy Hatcher.
3182 * Scripts/prepare-ChangeLog:
3183 (get_selector_line_ranges_for_css):
3184 Get a range for @media blocks just like a selector.
3185 Start Line = line with '{'
3186 End line = line with '}'
3189 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3190 Improved error messages for unbalanced portions.
3192 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3193 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3194 (.media-query::before):
3195 (@media only screen and (max-width: 980px)):
3197 (@media (-webkit-min-device-pixel-ratio: 2)):
3201 (.media-query::after):
3203 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
3205 Fix expectedFailErrorHandler in run-jsc-stress-tests
3206 https://bugs.webkit.org/show_bug.cgi?id=159811
3208 Reviewed by Yusuke Suzuki.
3210 * Scripts/run-jsc-stress-tests:
3212 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
3214 Unreviewed Mac cmake buildfix after r203426. Just for fun.
3216 * TestWebKitAPI/PlatformMac.cmake:
3218 2016-07-19 Filip Pizlo <fpizlo@apple.com>
3220 The default testing mode should not involve disabling the FTL JIT
3221 https://bugs.webkit.org/show_bug.cgi?id=159929
3223 Rubber stamped by Mark Lam and Saam Barati.
3225 It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3226 Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3227 FTL was not the default. You had to enable it with an option.
3229 For some reason we have kept this arrangement even though the FTL JIT is now the default on
3230 all of the major ports. This has become a serious pain. For example, it's useful to be able
3231 to say that a test should only run in the default config that is representative of what a
3232 normal user would see if they ran JSC. Clearly, this would be a config that does not
3233 explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3234 your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3236 So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3237 try to fix it, because:
3239 - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3240 have the FTL enabled never run any tests that explicitly disable the FTL, since that
3241 doesn't do anything. The code is not really structured to allow this.
3243 - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3244 disabled in testing. On the other hand there are already build bots that do FTL tests
3245 despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3246 preserving this broken feature, we should create something that (a) acknowledges the fact
3247 that the FTL is the default on those platforms that support it and (b) avoids running
3248 no-ftl tests on precisely those platforms that don't have FTL.
3250 - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3251 relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3252 default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3253 pretending that the FTL JIT is not the default just because some bots used that as an
3256 This change allows me to speed up some debug tests and paint some bots green.
3258 * Scripts/run-javascriptcore-tests:
3259 (runJSCStressTests):
3260 * Scripts/run-jsc-stress-tests:
3262 2016-07-19 Alex Christensen <achristensen@webkit.org>
3264 Fix API test after r203426.
3265 https://bugs.webkit.org/show_bug.cgi?id=159949
3267 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3269 If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3270 This is no problem. We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3272 2016-07-19 Andy Estes <aestes@apple.com>
3274 Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3275 https://bugs.webkit.org/show_bug.cgi?id=159956
3277 Reviewed by Dan Bernstein.
3279 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3280 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3281 Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3282 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3284 2016-07-19 Alex Christensen <achristensen@webkit.org>
3286 Add regression test for r203392
3287 https://bugs.webkit.org/show_bug.cgi?id=159949
3289 Reviewed by Brady Eidson.
3291 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3293 (swizzledBundleIdentifierWebBookmarksD):
3294 (defaultApplicationCacheDirectory):
3296 (swizzledBundleIdentifierMobileSafari): Deleted.
3297 This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3298 I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3299 problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3301 2016-07-19 Alex Christensen <achristensen@webkit.org>
3303 Add regression test for r203392
3304 https://bugs.webkit.org/show_bug.cgi?id=159949
3306 Reviewed by Brady Eidson.
3308 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3309 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3310 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3311 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3312 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3315 (swizzledBundleIdentifierMobileSafari):
3316 (swizzledBundleIdentifierWebBookmarksD):
3317 (defaultApplicationCacheDirectory):
3318 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3319 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3320 * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3321 * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3323 2016-07-19 Keith Miller <keith_miller@apple.com>
3325 Test262 should have a file with the revision and url
3326 https://bugs.webkit.org/show_bug.cgi?id=159937
3328 Reviewed by Mark Lam.
3330 The import script should update the information from
3331 the path to the test262 repository it gets.
3333 * Scripts/import-test262-tests:
3335 2016-07-19 Alexey Proskuryakov <ap@apple.com>
3337 Temporary workaround for iOS EWS failing after the fix for bug 159539.
3338 To be deleted once the root cause is found and addressed.
3340 * EWSTools/start-queue-mac.sh:
3342 2016-07-19 Frederic Wang <fwang@igalia.com>
3344 [win] Fixup the register name for STIX Math and Latin Modern Math
3346 Unreviewed follow-up of r203406
3348 * Scripts/webkitdirs.pm:
3349 (checkInstalledTools):
3351 2016-07-19 Frederic Wang <fwang@igalia.com>
3353 [win] Update the list of MathML fonts
3354 https://bugs.webkit.org/show_bug.cgi?id=156838
3356 The set of recommended math fonts is now described at
3357 https://trac.webkit.org/wiki/MathML/Fonts
3358 We update the Perl script to use the latest list of fonts.
3360 Reviewed by Brent Fulgham.
3362 * Scripts/webkitdirs.pm:
3363 (checkInstalledTools):
3365 2016-07-19 Per Arne Vollan <pvollan@apple.com>
3367 [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3368 https://bugs.webkit.org/show_bug.cgi?id=159342
3370 Reviewed by Darin Adler.
3372 Implement required functions in event sender.
3374 * DumpRenderTree/PlatformWin.cmake:
3375 * DumpRenderTree/win/EventSender.cpp:
3376 (monitorWheelEvents): Added.
3377 (callAfterScrollingCompletes): Added.
3379 2016-07-19 Youenn Fablet <youenn@apple.com>
3381 Add new aliases to http test server
3382 https://bugs.webkit.org/show_bug.cgi?id=159878
3384 Reviewed by Darin Adler.
3386 Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3387 Adding explicitly these links to perl script.
3388 Extracting default alias in an aliases.json file.
3389 Reading that file from python scripts to initialize aliases from that file.
3391 Python script changes covered by unit tests and changed layout test.
3393 * Scripts/webkitperl/httpd.pm:
3394 (getDefaultConfigForTestDirectory): Adding 3 new aliases
3395 * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3396 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3397 (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3398 Adding -c directives for each alias.
3399 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3400 (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3401 * Scripts/webkitpy/layout_tests/servers/http_server.py:
3402 (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3403 Adding alias directive for each alias.
3404 (Lighttpd._prepare_config):
3405 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3406 (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3407 (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3408 layout tests directory.
3409 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3410 (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3411 (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3413 2016-07-18 Aakash Jain <aakash_jain@apple.com>
3415 EWS console logs doesn't go to log file
3416 https://bugs.webkit.org/show_bug.cgi?id=159539
3417 <rdar://problem/24464570>
3419 Reviewed by David Kilzer.
3421 * Scripts/webkitpy/common/system/logutils.py:
3422 (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3423 (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3424 to filesystem. It also supports passing MockFilesystem.
3425 (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3426 (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3427 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3428 (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3430 * Scripts/webkitpy/tool/commands/queues.py:
3431 (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3432 (AbstractQueue._log_directory): Using filesystem object instead of os.
3433 (AbstractQueue.queue_log_path): Same.
3434 (AbstractQueue.__init__): Passed host parameter.
3435 (PatchProcessingQueue.__init__): Same.
3436 (CommitQueue.__init__): Same.
3437 (AbstractReviewQueue.__init__): Same.
3438 (StyleQueue.__init__): Same.
3439 * Scripts/webkitpy/tool/commands/queues_unittest.py:
3440 (TestCommitQueue): Passed MockHost() as host.
3441 (TestCommitQueue.__init__): Same.
3442 (TestQueue.__init__): Same.
3443 (TestReviewQueue.__init__): Same.
3444 (TestFeederQueue.__init__): Same.
3445 (AbstractPatchQueueTest.test_next_patch): Same.
3446 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3447 (test_commit_queue_failure): Same.
3448 (MockCommitQueueTask.results_from_patch_test_run): Same.
3449 (test_rollout_lands): Same.
3450 (test_non_valid_patch): Same.
3451 (test_auto_retry): Same.
3452 (test_style_queue_with_watch_list_exception): Same.
3454 2016-07-02 Filip Pizlo <fpizlo@apple.com>
3456 WTF::Lock should be fair eventually
3457 https://bugs.webkit.org/show_bug.cgi?id=159384
3459 Reviewed by Geoffrey Garen.
3461 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3463 2016-07-17 Sam Weinig <sam@webkit.org>
3465 [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3466 <rdar://problem/26554137>
3467 https://bugs.webkit.org/show_bug.cgi?id=159856
3469 Reviewed by Dan Bernstein.
3471 * MiniBrowser/mac/WK2BrowserWindowController.m:
3472 (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3473 Add basic window.open implementation.
3475 (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3476 Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3477 to open a single non-web URL, all others are dropped.
3479 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3480 * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3481 * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3482 Add API for the new SPI.
3484 2016-07-17 Yusuke Suzuki <utatane.tea@gmail.com>
3486 [JSC] Enable test262 module tests
3487 https://bugs.webkit.org/show_bug.cgi?id=159854
3489 Reviewed by Saam Barati.
3491 Use --module-file instead.
3493 * Scripts/run-jsc-stress-tests:
3495 2016-07-16 Chris Dumez <cdumez@apple.com>
3497 Unreviewed, rolling out r203318.
3499 Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3504 "[JSC] Change some parameters based on a random search"
3505 https://bugs.webkit.org/show_bug.cgi?id=158514
3506 http://trac.webkit.org/changeset/203318
3508 2016-07-16 Chris Dumez <cdumez@apple.com>
3510 Add move constructor / assignment operator to ListHashSet
3511 https://bugs.webkit.org/show_bug.cgi?id=159837
3513 Reviewed by Darin Adler.
3517 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3518 (TestWebKitAPI::TEST):
3520 2016-07-15 Benjamin Poulain <bpoulain@apple.com>
3522 [JSC] Change some parameters based on a random search
3523 https://bugs.webkit.org/show_bug.cgi?id=158514
3525 Reviewed by Saam Barati.
3527 * Scripts/run-jsc-stress-tests:
3529 2016-07-15 Jon Davis <jond@apple.com>
3531 Changed the start page URL for WebKit Nightly builds.
3532 https://bugs.webkit.org/show_bug.cgi?id=159816
3534 Reviewed by Timothy Hatcher.
3536 * WebKitLauncher/start.html:
3538 2016-07-15 Per Arne Vollan <pvollan@apple.com>
3540 Uninitialized variable in DIBPixelData can cause a dangerous memory write
3541 https://bugs.webkit.org/show_bug.cgi?id=159414
3543 Reviewed by Brent Fulgham.
3545 Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3546 when the HDC parameter is invalid.
3548 * TestWebKitAPI/PlatformWin.cmake:
3549 * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3550 (TestWebKitAPI::TEST):
3552 2016-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
3554 [GTK] Add basic tabs support to MiniBrowser
3555 https://bugs.webkit.org/show_bug.cgi?id=159803
3557 Reviewed by Sergio Villar Senin.
3559 It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3560 like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3562 * MiniBrowser/gtk/BrowserTab.c: Added.
3566 (removeChildIfInfoBar):
3568 (createInfoBarQuestionMessage):
3569 (tlsErrorsDialogResponse):
3570 (loadFailedWithTLSerrors):
3571 (permissionRequestDialogResponse):
3572 (decidePermissionRequest):
3573 (colorChooserRGBAChanged):
3574 (popoverColorClosed):
3575 (colorChooserRequestFinished):
3576 (runColorChooserCallback):
3577 (inspectorOpenedInWindow):
3579 (browserTabSetProperty):
3580 (browserTabFinalize):
3582 (browserTabConstructed):
3583 (browser_tab_class_init):
3586 (browser_tab_get_web_view):
3587 (browser_tab_load_uri):
3588 (browser_tab_get_title_widget):
3589 (browser_tab_set_status_text):
3590 (browser_tab_toggle_inspector):
3591 (browser_tab_start_search):
3592 (browser_tab_stop_search):
3593 (browser_tab_add_accelerators):
3594 (fullScreenMessageTimeoutCallback):
3595 (browser_tab_enter_fullscreen):
3596 (browser_tab_leave_fullscreen):
3597 * MiniBrowser/gtk/BrowserTab.h: Added.
3598 * MiniBrowser/gtk/BrowserWindow.c:
3600 (browserWindowSetStatusText):
3601 (reloadOrStopCallback):
3603 (goForwardCallback):
3605 (webViewURIChanged):
3606 (browserWindowHistoryItemActivated):
3607 (browserWindowUpdateNavigationActions):
3609 (webViewEnterFullScreen):
3610 (webViewLeaveFullScreen):
3611 (webViewDecidePolicy):
3612 (browserWindowCanZoomIn):
3613 (browserWindowCanZoomOut):
3614 (browserWindowZoomIn):
3615 (browserWindowZoomOut):
3616 (scrollEventCallback):
3618 (webViewIsLoadingChanged):
3619 (defaultZoomCallback):
3622 (toggleWebInspector):
3624 (reloadPageIgnoringCache):
3627 (editingCommandCallback):
3628 (insertImageCommandCallback):
3629 (insertLinkCommandCallback):
3630 (browserWindowSetupEditorToolbar):
3631 (browserWindowSwitchTab):
3632 (browserWindowTabAddedOrRemoved):
3633 (browser_window_init):
3634 (browserWindowConstructed):
3635 (browserWindowSaveSession):
3636 (browserWindowDeleteEvent):
3637 (browser_window_new):
3638 (browser_window_append_view):
3639 (browser_window_load_uri):
3640 (browser_window_load_session):
3641 (browser_window_set_background_color):
3642 (resetStatusText): Deleted.
3643 (activateUriEntryCallback): Deleted.
3644 (webViewTitleChanged): Deleted.
3645 (resetEntryProgress): Deleted.
3646 (browserWindowCreateBackForwardMenu): Deleted.
3647 (webViewReadyToShow): Deleted.
3648 (webViewLoadFailed): Deleted.
3649 (webViewMouseTargetChanged): Deleted.
3650 (browserWindowUpdateZoomActions): Deleted.
3651 (webViewZoomLevelChanged): Deleted.
3652 (updateUriEntryIcon): Deleted.
3653 (zoomInCallback): Deleted.
3654 (zoomOutCallback): Deleted.
3655 (toggleFullScreen): Deleted.
3656 (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3657 (browserWindowFinalize): Deleted.
3658 (browser_window_class_init): Deleted.
3659 * MiniBrowser/gtk/BrowserWindow.h:
3660 * MiniBrowser/gtk/CMakeLists.txt:
3661 * MiniBrowser/gtk/main.c:
3663 (aboutURISchemeRequestCallback):
3665 (parseBackgroundColor): Deleted.
3667 2016-07-14 Alex Christensen <achristensen@webkit.org>
3669 Allow RefPtrs of const RefCounted types
3670 https://bugs.webkit.org/show_bug.cgi?id=158269
3672 Reviewed by Anders Carlsson.
3674 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3675 (TestWebKitAPI::TEST):
3676 (TestWebKitAPI::ConstRefCounted::create):
3677 (TestWebKitAPI::returnConstRefCountedRef):
3678 (TestWebKitAPI::returnRefCountedRef):
3680 2016-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
3682 Test WTF.StringViewIterators is crashing since r203119
3683 https://bugs.webkit.org/show_bug.cgi?id=159710
3685 Reviewed by Darin Adler.
3687 There are two problems in the test case added in r203119. First is that it's testing
3688 StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3689 StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3690 const reference to the string view member of the deleted CodePoints object.
3692 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3693 (TestWebKitAPI::TEST):
3695 2016-07-13 Daniel Bates <dabates@apple.com>
3697 [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3698 https://bugs.webkit.org/show_bug.cgi?id=159738
3699 <rdar://problem/27304649>
3701 Reviewed by Dan Bernstein.
3703 The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3704 code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3705 of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3706 PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3708 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3709 * WebKitTestRunner/ios/TestControllerIOS.mm:
3710 (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3711 bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3713 2016-07-13 Beth Dakin <bdakin@apple.com>
3715 Attempted build fix.
3717 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3719 2016-07-12 Ryosuke Niwa <rniwa@webkit.org>
3721 REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3722 https://bugs.webkit.org/show_bug.cgi?id=159686
3724 Reviewed by Chris Dumez.
3726 Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3728 * WebKitTestRunner/TestController.cpp:
3729 (WTR::runOpenPanel):
3730 (WTR::TestController::createOtherPage):
3731 (WTR::TestController::createWebViewWithOptions):
3733 2016-07-13 Beth Dakin <bdakin@apple.com>
3735 Add more candidate tests
3736 https://bugs.webkit.org/show_bug.cgi?id=159730
3738 Reviewed by Tim Horton.
3740 This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds
3741 two new tests to that file.
3742 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3743 * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3744 * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3745 (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3746 (TestWebKitAPI::TEST):
3747 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3749 2016-07-13 Joanmarie Diggs <jdiggs@igalia.com>
3751 AX: [ATK] spinbutton-crash.html fails
3752 https://bugs.webkit.org/show_bug.cgi?id=159723
3754 Reviewed by Chris Fleizach.
3756 Implement support for AXDecrementButton and AXIncrementButton in
3757 ATK's AccessibilityUIElement::uiElementAttributeValue().
3759 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3760 (WTR::AccessibilityUIElement::uiElementAttributeValue):
3762 2016-07-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
3764 [EFL] [GTK] Enable back crypto subtle on development builds.
3765 https://bugs.webkit.org/show_bug.cgi?id=159260
3767 Reviewed by Carlos Garcia Campos.
3769 * Scripts/webkitperl/FeatureList.pm:
3771 2016-07-12 Mark Lam <mark.lam@apple.com>
3773 We should use different stack limits for stack checks from JS and host code.
3774 https://bugs.webkit.org/show_bug.cgi?id=159442
3775 <rdar://problem/26889188>
3777 Reviewed by Geoffrey Garen.
3779 In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3780 run with to keep stack overflow tests sane. Turns out, we also need to teach the
3781 LayoutTestRelay to pass env vars over to the iOS simulator. This is needed in
3782 order to keep the js/regress-139548.html test happy with this patch.
3784 Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3785 JSC_maxPerThreadStackUsage option. Otherwise, it will pass a float value.
3787 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3788 (-[LTRelayController _environmentVariables]):
3789 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3792 2016-07-12 Filip Pizlo <fpizlo@apple.com>
3794 platformUserPreferredLanguages on Mac should not try to put the region into the language
3795 https://bugs.webkit.org/show_bug.cgi?id=159693
3797 Rubber stamped by Alexey Proskuryakov.
3799 Revert the test change in r200105.
3801 * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3802 (TestWebKitAPI::languageForSystemLanguage):
3804 2016-07-12 Chris Dumez <cdumez@apple.com>
3806 [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3807 https://bugs.webkit.org/show_bug.cgi?id=159663
3808 <rdar://problem/18995873>
3810 Reviewed by Benjamin Poulain.
3812 Add API test coverage.
3814 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3815 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3816 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3817 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3818 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3819 (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3822 2016-07-12 Myles C. Maxfield <mmaxfield@apple.com>
3824 Relax ordering requirements on StringView::CodePoints iterator
3825 https://bugs.webkit.org/show_bug.cgi?id=159609
3827 Reviewed by Darin Adler.
3829 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3830 (TestWebKitAPI::TEST):
3832 2016-07-12 Youenn Fablet <youenn@apple.com>
3834 Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3835 https://bugs.webkit.org/show_bug.cgi?id=159564
3837 Reviewed by Brian Burg.
3839 * Scripts/webkitpy/codegen/main.py:
3840 (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3842 2016-07-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3844 Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3845 https://bugs.webkit.org/show_bug.cgi?id=159671
3847 Reviewed by Csaba Osztrogonác.
3849 ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3850 https://bugs.webkit.org/show_bug.cgi?id=89235
3852 So this guard can be removed in build scripts.
3854 * Scripts/webkitperl/FeatureList.pm:
3855 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3857 2016-07-11 Jason Marcell <jmarcell@apple.com>
3859 SVN.create_patch should find svn-create-patch relative to the WebKit root.
3860 https://bugs.webkit.org/show_bug.cgi?id=159652
3862 Reviewed by Daniel Bates.
3864 * Scripts/webkitpy/common/checkout/scm/svn.py:
3865 (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3867 2016-07-11 Myles C. Maxfield <mmaxfield@apple.com>
3869 Implement grapheme cluster iterator on StringView
3870 https://bugs.webkit.org/show_bug.cgi?id=159598
3872 Reviewed by Anders Carlsson.
3874 This is in preparation for honoring the second argument to FontFaceSet.load().
3876 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3877 (TestWebKitAPI::compareLoopIterations):
3878 (TestWebKitAPI::TEST):
3880 2016-07-11 Nan Wang <n_wang@apple.com>
3882 AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3883 https://bugs.webkit.org/show_bug.cgi?id=158364
3885 Reviewed by Anders Carlsson.
3887 Added a function in TestRunner so that we can toggle the ignoring viewport
3888 scale limits setting. Also added a test option for that in order to change the
3889 configuration of the webview in test.
3891 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3892 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3893 (WTR::TestRunner::setNavigationGesturesEnabled):
3894 (WTR::TestRunner::setIgnoresViewportScaleLimits):
3895 (WTR::nextUIScriptCallbackID):
3896 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3897 (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3898 * WebKitTestRunner/TestController.cpp:
3899 (WTR::TestController::resetStateToConsistentValues):
3900 (WTR::updateTestOptionsFromTestHeader):
3901 (WTR::TestController::setNavigationGesturesEnabled):
3902 (WTR::TestController::setIgnoresViewportScaleLimits):
3903 (WTR::TestController::platformWillRunTest):
3904 * WebKitTestRunner/TestController.h:
3905 (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3906 * WebKitTestRunner/TestInvocation.cpp:
3907 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3908 * WebKitTestRunner/TestOptions.h:
3909 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3910 (WTR::TestController::platformCreateWebView):
3912 2016-07-11 Konstantin Tokarev <annulen@yandex.ru>
3914 [GTK] install-dependencies should not install packages built by jhbuild.
3915 https://bugs.webkit.org/show_bug.cgi?id=159628
3917 Reviewed by Michael Catanzaro.
3919 * gtk/install-dependencies:
3920 Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3922 2016-07-11 Olivier Blin <olivier.blin@softathome.com>
3924 System proxy settings not used when building deps with jhbuild
3925 https://bugs.webkit.org/show_bug.cgi?id=159567
3927 Reviewed by Michael Catanzaro.
3929 This adds the gsettings-desktop-schemas-devel build dep to enable
3930 the libgiognomeproxy.so gio module in glib-networking, which uses
3931 GSettings on org.gnome.system.proxy.
3932 This is needed to query system proxy settings for Gnome desktops.
3934 dconf can be manually added to jhbuild to build the
3935 libdconfsettings.so gio module for GSettings, so that
3936 libgiognomeproxy.so can access system settings.
3937 https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3939 As an alternative to dconf settings, this commit also adds the
3940 libproxy-devel build dep to enable the libgiolibproxy.so module in
3941 glib-networking (suggested by Fujii Hironori).
3943 It is useful to read proxy settings from environment variables.
3944 From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3945 environment variable to force using the envvar module in libproxy.
3947 * gtk/install-dependencies:
3949 2016-07-11 Mark Lam <mark.lam@apple.com>
3951 Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3952 https://bugs.webkit.org/show_bug.cgi?id=159524
3954 Reviewed by Michael Saboff.
3956 Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3957 Also fixed up some tests to behave better to work with this new limit. This
3958 should make stack overflow tests complete sooner.
3960 * Scripts/run-jsc-stress-tests:
3961 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3964 2016-07-11 Michael Catanzaro <mcatanzaro@igalia.com>
3966 [GTK] Whitespace fixes in install-dependencies script
3970 * gtk/install-dependencies:
3972 2016-07-11 Michael Catanzaro <mcatanzaro@igalia.com>
3974 [GTK] Install missing Fedora dependencies
3978 * gtk/install-dependencies:
3980 2016-07-09 Dan Bernstein <mitz@apple.com>
3982 Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3983 https://bugs.webkit.org/show_bug.cgi?id=159600
3985 Reviewed by Daniel Bates.
3987 * Scripts/git-add-reviewer:
3988 Added the -s|--rubber-stamp option.
3989 (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3992 2016-07-08 Andy Estes <aestes@apple.com>
3994 [Content Filtering] Load blocked pages more like other error pages are loaded
3995 https://bugs.webkit.org/show_bug.cgi?id=159485
3996 <rdar://problem/26014076>
3998 Reviewed by Brady Eidson.
4000 Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
4001 to a content filtering provisional navigation failure is ignored in preference of
4002 ContentFilter's own error page.
4004 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4005 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4006 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
4007 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4008 (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
4009 (loadAlternateTest):
4011 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
4012 (-[MockContentFilterEnabler initWithCoder:]):
4013 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
4014 (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4015 (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
4016 (TestWebKitAPI::loadAlternateTest):
4017 (TestWebKitAPI::TEST):
4019 2016-07-08 Commit Queue <commit-queue@webkit.org>
4021 Unreviewed, rolling out r202944.
4022 https://bugs.webkit.org/show_bug.cgi?id=159570
4024 caused some tests to crash under GuardMalloc (Requested by
4029 "[Content Filtering] Load blocked pages more like other error
4031 https://bugs.webkit.org/show_bug.cgi?id=159485
4032 http://trac.webkit.org/changeset/202944
4034 2016-07-08 Martin Robinson <mrobinson@igalia.com>
4036 Remove mrobinson from the MathML watchlist
4037 https://bugs.webkit.org/show_bug.cgi?id=159559
4039 Reviewed by Philippe Normand.
4041 * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
4043 2016-07-08 Brady Eidson <beidson@apple.com>
4045 Clearing LocalStorage doesn't also delete -wal and -shm files.
4046 <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
4048 Reviewed by Brent Fulgham.
4049 Also helpfully picked over by Andy "Never Forgets" Estes.
4051 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4052 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
4053 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
4055 2016-07-08 Konstantin Tokarev <annulen@yandex.ru>
4057 Removed Qt leftovers from Tools.
4058 https://bugs.webkit.org/show_bug.cgi?id=159557
4060 Reviewed by Csaba Osztrogonác.
4062 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4063 Removed 'qt' platform config.
4064 * Scripts/webkitpy/common/net/bugzilla/bug.py:
4065 Deleted non-functional e-mail address.
4067 2016-07-08 Commit Queue <commit-queue@webkit.org>
4069 Unreviewed, rolling out r202967.
4070 https://bugs.webkit.org/show_bug.cgi?id=159556
4072 This patch caused crashes in https tests on Windows (Requested
4073 by perarne on #webkit).
4077 "[Win] The test http/tests/security/contentSecurityPolicy
4078 /upgrade-insecure-requests/basic-upgrade.https.html is
4080 https://bugs.webkit.org/show_bug.cgi?id=159510
4081 http://trac.webkit.org/changeset/202967
4083 2016-07-08 Youenn Fablet <youenn@apple.com>
4085 Generate WebCore builtin wrapper files
4086 https://bugs.webkit.org/show_bug.cgi?id=159461
4088 Reviewed by Brian Burg.
4090 * Scripts/webkitpy/codegen/main.py:
4091 (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
4092 (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
4094 2016-07-08 Hunseop Jeong <hs85.jeong@samsung.com>
4096 [EFL] Fix build when media-stream is enabled.
4097 https://bugs.webkit.org/show_bug.cgi?id=159206
4099 Bump up the openwebrtc to find the correct package.
4101 Reviewed by Gyuyoung Kim.
4103 * efl/jhbuild.modules:
4104 * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
4106 2016-07-07 Per Arne Vollan <pvollan@apple.com>
4108 [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
4109 https://bugs.webkit.org/show_bug.cgi?id=159510
4111 Reviewed by Brent Fulgham.
4113 Allow any https certificate when running tests.
4115 * DumpRenderTree/win/DumpRenderTree.cpp:
4118 2016-07-07 Beth Dakin <bdakin@apple.com>
4120 API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
4121 https://bugs.webkit.org/show_bug.cgi?id=159532
4123 rdar://problem/27177179
4125 Reviewed by Tim Horton.
4127 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
4128 (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
4130 2016-07-07 Andy Estes <aestes@apple.com>
4132 [Content Filtering] Load blocked pages more like other error pages are loaded
4133 https://bugs.webkit.org/show_bug.cgi?id=159485
4134 <rdar://problem/26014076>
4136 Reviewed by Brady Eidson.
4138 Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
4139 to a content filtering provisional navigation failure is ignored in preference of
4140 ContentFilter's own error page.
4142 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4143 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4144 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
4145 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4146 (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
4147 (loadAlternateTest):
4149 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
4150 (-[MockContentFilterEnabler initWithCoder:]):
4151 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
4152 (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4153 (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
4154 (TestWebKitAPI::loadAlternateTest):
4155 (TestWebKitAPI::TEST):
4157 2016-07-07 Per Arne Vollan <pvollan@apple.com>
4159 Unreviewed: add myself to the reviewers list.
4161 * Scripts/webkitpy/common/config/contributors.json:
4163 2016-07-07 Per Arne Vollan <pvollan@apple.com>
4165 [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
4166 https://bugs.webkit.org/show_bug.cgi?id=159509
4168 Reviewed by Alex Christensen.
4170 We should always insert the url in the url map when identifierForInitialRequest
4171 is called. Otherwise we can end up with identifiers not having an entry in the
4172 url map when urls are written to the test output file.
4174 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4175 (ResourceLoadDelegate::identifierForInitialRequest):
4177 2016-07-06 Tim Horton <timothy_horton@apple.com>
4179 Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
4180 https://bugs.webkit.org/show_bug.cgi?id=159498
4181 <rdar://problem/26719903>
4183 Reviewed by Sam Weinig.
4185 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4186 * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
4187 (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
4188 (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
4191 Add a test ensuring that ReferenceDate in the DataDetectors context is respected
4192 when deciding what to linkify.
4194 2016-07-06 Alexey Proskuryakov <ap@apple.com>
4196 Build fix - work around rdar://problem/27196668.
4198 * LayoutTestRelay/Configurations/Base.xcconfig:
4200 2016-07-05 Per Arne Vollan <pvollan@apple.com>
4202 Enhance Windows DRT implementation to support platform scroll wheel events.
4203 https://bugs.webkit.org/show_bug.cgi?id=36002
4205 Reviewed by Brent Fulgham.
4207 Implement function continuousMouseScrollBy in Windows event sender.
4209 * DumpRenderTree/win/EventSender.cpp:
4211 (continuousMouseScrollBy):
4213 2016-07-05 Myles C. Maxfield <mmaxfield@apple.com>
4215 [Sierra] Rebaseline tests to use un-mocked system font metrics
4216 https://bugs.webkit.org/show_bug.cgi?id=159311
4217 <rdar://problem/24138411>
4219 Reviewed in person by Alexey Proskuryakov.
4221 Stop mocking the system font on Sierra.
4223 * DumpRenderTree/mac/DumpRenderTree.mm:
4224 (setDefaultsToConsistentValuesForTesting):
4225 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4226 (WTR::InjectedBundle::platformInitialize):
4228 2016-07-05 Brady Eidson <beidson@apple.com>
4230 Database process crashes deleting a corrupt SQLite database file (null deref).
4231 https://bugs.webkit.org/show_bug.cgi?id=155506.
4233 Reviewed by Alex Christensen.
4235 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4236 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
4237 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
4238 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
4239 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
4240 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
4242 2016-07-05 Alexey Proskuryakov <ap@apple.com>
4244 run-webkit-tests should print more complete baseline search paths
4245 https://bugs.webkit.org/show_bug.cgi?id=159354
4247 Reviewed by Daniel Bates.
4249 run-webkit-tests used to only print directory names in baseline search paths.
4250 This was ok in basic usage, but quickly got confusing when using
4251 --additional-platform-directory flags.
4253 * Scripts/webkitpy/layout_tests/views/printing.py:
4254 (Printer.print_config):
4255 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4256 (Testprinter.test_print_config):
4257 (Testprinter.test_print_one_line_summary):
4259 2016-07-04 Brady Eidson <beidson@apple.com>
4261 WebProcesses don't handle DatabaseProcess going away uncleanly..
4262 https://bugs.webkit.org/show_bug.cgi?id=159371
4264 Reviewed by Alex Christensen.
4266 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4267 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
4268 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
4269 (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
4270 (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
4272 2016-07-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
4274 [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
4275 https://bugs.webkit.org/show_bug.cgi?id=158141
4277 Rubber-stamped by Michael Catanzaro.
4279 Instead of checking for an specific Ubuntu version, query the apt
4280 database to see which version of PHP is available.
4282 * efl/install-dependencies:
4283 * gtk/install-dependencies:
4285 2016-07-04 Fujii Hironori <Hironori.Fujii@sony.com>
4287 webkit-patch failure-reason always raises TypeError
4288 https://bugs.webkit.org/show_bug.cgi?id=159394
4290 Reviewed by Benjamin Poulain.
4292 In r170637 (Bug 133067), the first and second arguments of
4293 pluralize were swapped.
4295 * Scripts/webkitpy/tool/commands/queries.py:
4296 (FailureReason._builder_to_explain): Swap the first and second
4297 arguments of pluralize.
4299 2016-07-02 Youenn Fablet <youennf@gmail.com>
4301 Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
4302 https://bugs.webkit.org/show_bug.cgi?id=152486