aa7dbe62c961da998ae7d95a5a2a888b6fbc057e
[WebKit-https.git] / Tools / ChangeLog
1 2012-10-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2
3         Rename first/second to key/value in HashMap iterators
4         https://bugs.webkit.org/show_bug.cgi?id=82784
5
6         Reviewed by Eric Seidel.
7
8         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
9         (MockWebSpeechInputController::addMockRecognitionResult):
10         * DumpRenderTree/chromium/NotificationPresenter.cpp:
11         (NotificationPresenter::simulateClick):
12         (NotificationPresenter::show):
13         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
14         (CppBoundClass::~CppBoundClass):
15         (CppBoundClass::invoke):
16         (CppBoundClass::getProperty):
17         (CppBoundClass::setProperty):
18         (CppBoundClass::bindCallback):
19         (CppBoundClass::bindProperty):
20         * DumpRenderTree/chromium/WebPreferences.cpp:
21         (applyFontMap):
22         * DumpRenderTree/chromium/WebViewHost.cpp:
23         (WebViewHost::printResourceDescription):
24         * DumpRenderTree/mac/TestRunnerMac.mm:
25         (worldIDForWorld):
26         (TestRunner::evaluateScriptInIsolatedWorld):
27         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
28         (AccessibilityController::~AccessibilityController):
29         (AccessibilityController::winNotificationReceived):
30         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
31         (ResourceLoadDelegate::descriptionSuitableForTestResult):
32         * DumpRenderTree/win/TestRunnerWin.cpp:
33         (worldIDForWorld):
34         (TestRunner::evaluateScriptInIsolatedWorld):
35         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
36         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
37         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
38         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
39         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
40         (WTR::TestRunner::worldIDForWorld):
41         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
42
43 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
44
45         Unreviewed, rolling out r130596.
46         http://trac.webkit.org/changeset/130596
47         https://bugs.webkit.org/show_bug.cgi?id=98616
48
49         Broke build bots without IPV6 support
50
51         * Scripts/webkitpy/common/system/platforminfo_mock.py:
52         (MockPlatformInfo.is_cygwin):
53         * Scripts/webkitpy/layout_tests/port/base.py:
54         (Port.baseline_version_dir):
55         (Port.to.start_websocket_server):
56         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
57         (PortTest.test_operating_system):
58         (PortTest.test_build_path):
59         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
60         (LayoutTestApacheHttpd):
61         (LayoutTestApacheHttpd.__init__):
62
63 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
64
65         webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
66         https://bugs.webkit.org/show_bug.cgi?id=98602
67
68         Reviewed by Eric Seidel.
69
70         Unify all the different `Listen' directives present in the several
71         httpd.conf files we have in LayoutTests/http/conf. For one, we
72         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
73         and opening the other ports from the conf files.
74
75         The configuration files differed mostly in the way they handled
76         IPV6 ports. Some of them did not listen to IPV6 ports because the
77         systems which used them sometimes did not have IPV6 support. The
78         `http_server_supports_ipv6' method has been added to Port to
79         address that. cygwin, on its turn, still seems to use Apache 1.3,
80         which does not support IPV6 at all; the newly-added method has a
81         special case for that.
82
83         * Scripts/webkitpy/common/system/platforminfo_mock.py:
84         (MockPlatformInfo.is_cygwin):
85         * Scripts/webkitpy/layout_tests/port/base.py:
86         (Port.baseline_version_dir):
87         (Port.to.start_websocket_server):
88         (Port.to):
89         (Port.to.http_server_supports_ipv6):
90         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
91         (PortTest.test_http_server_supports_ipv6):
92         (PortTest.test_build_path):
93         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
94         (LayoutTestApacheHttpd):
95         (LayoutTestApacheHttpd.__init__):
96
97 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
98
99         Attempt to fix the SnowLeopard build to making the implementation of
100         -isPaginated come before its use.
101
102         * MiniBrowser/mac/WK1BrowserWindowController.m:
103         (-[WK1BrowserWindowController reload:]):
104         (-[WK1BrowserWindowController forceRepaint:]):
105         (-[WK1BrowserWindowController goBack:]):
106         (-[WK1BrowserWindowController goForward:]):
107         (-[WK1BrowserWindowController isPaginated]):
108
109 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
110
111         Provide a way to run WebKit1
112         https://bugs.webkit.org/show_bug.cgi?id=98568
113
114         Reviewed by Tim Horton.
115
116         Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
117         
118         Turn BrowserWindowController into a base class; subclassed by
119         WK1BrowserWindowController and WK2BrowserWindowController, each of
120         which implement the BrowserController protocol.
121         
122         Use Command-N to get a WebKit1 window, and Command-Option-N to
123         get a WK2 window. Also add "Open Location" to focus the URL bar,
124         and code to add an http:// if missing.
125         
126         Hook up window title callbacks; append " [WK1/2]" to window title
127         as appropriate.
128
129         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
130         * MiniBrowser/mac/AppDelegate.m:
131         (-[BrowserAppDelegate newWindow:]):
132         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
133         * MiniBrowser/mac/BrowserWindowController.h:
134         * MiniBrowser/mac/BrowserWindowController.m:
135         (-[BrowserWindowController initWithWindow:]):
136         (-[BrowserWindowController windowDidLoad]):
137         (-[BrowserWindowController openLocation:]):
138         (-[BrowserWindowController loadURLString:]):
139         (-[BrowserWindowController applicationTerminating]):
140         (-[BrowserWindowController addProtocolIfNecessary:]):
141         * MiniBrowser/mac/MainMenu.xib:
142         * MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
143         (WebView):
144         * MiniBrowser/mac/WK1BrowserWindowController.m: Added.
145         (-[WK1BrowserWindowController awakeFromNib]):
146         (-[WK1BrowserWindowController dealloc]):
147         (-[WK1BrowserWindowController loadURLString:]):
148         (-[WK1BrowserWindowController fetch:]):
149         (-[WK1BrowserWindowController showHideWebView:]):
150         (-[WK1BrowserWindowController removeReinsertWebView:]):
151         (-[WK1BrowserWindowController validateMenuItem:]):
152         (-[WK1BrowserWindowController reload:]):
153         (-[WK1BrowserWindowController forceRepaint:]):
154         (-[WK1BrowserWindowController goBack:]):
155         (-[WK1BrowserWindowController goForward:]):
156         (-[WK1BrowserWindowController validateUserInterfaceItem:]):
157         (-[WK1BrowserWindowController validateToolbar]):
158         (-[WK1BrowserWindowController windowShouldClose:]):
159         (-[WK1BrowserWindowController windowWillClose:]):
160         (-[WK1BrowserWindowController applicationTerminating]):
161         (-[WK1BrowserWindowController currentZoomFactor]):
162         (-[WK1BrowserWindowController canZoomIn]):
163         (-[WK1BrowserWindowController zoomIn:]):
164         (-[WK1BrowserWindowController canZoomOut]):
165         (-[WK1BrowserWindowController zoomOut:]):
166         (-[WK1BrowserWindowController canResetZoom]):
167         (-[WK1BrowserWindowController resetZoom:]):
168         (-[WK1BrowserWindowController toggleZoomMode:]):
169         (-[WK1BrowserWindowController isPaginated]):
170         (-[WK1BrowserWindowController togglePaginationMode:]):
171         (-[WK1BrowserWindowController find:]):
172         (-[WK1BrowserWindowController dumpSourceToConsole:]):
173         (-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
174         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
175         * MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
176         * MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
177         (-[WK2BrowserWindowController initWithContext:pageGroup:]):
178         (-[WK2BrowserWindowController dealloc]):
179         (-[WK2BrowserWindowController fetch:]):
180         (-[WK2BrowserWindowController showHideWebView:]):
181         (-[WK2BrowserWindowController removeReinsertWebView:]):
182         (-[WK2BrowserWindowController validateMenuItem:]):
183         (-[WK2BrowserWindowController reload:]):
184         (-[WK2BrowserWindowController forceRepaint:]):
185         (-[WK2BrowserWindowController goBack:]):
186         (-[WK2BrowserWindowController goForward:]):
187         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
188         (-[WK2BrowserWindowController validateToolbar]):
189         (-[WK2BrowserWindowController windowShouldClose:]):
190         (-[WK2BrowserWindowController windowWillClose:]):
191         (-[WK2BrowserWindowController applicationTerminating]):
192         (-[WK2BrowserWindowController currentZoomFactor]):
193         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
194         (-[WK2BrowserWindowController canZoomIn]):
195         (-[WK2BrowserWindowController zoomIn:]):
196         (-[WK2BrowserWindowController canZoomOut]):
197         (-[WK2BrowserWindowController zoomOut:]):
198         (-[WK2BrowserWindowController canResetZoom]):
199         (-[WK2BrowserWindowController resetZoom:]):
200         (-[WK2BrowserWindowController toggleZoomMode:]):
201         (-[WK2BrowserWindowController isPaginated]):
202         (-[WK2BrowserWindowController togglePaginationMode:]):
203         (-[WK2BrowserWindowController dumpSourceToConsole:]):
204         (didStartProvisionalLoadForFrame):
205         (didReceiveServerRedirectForProvisionalLoadForFrame):
206         (didFailProvisionalLoadWithErrorForFrame):
207         (didCommitLoadForFrame):
208         (didFinishDocumentLoadForFrame):
209         (didFinishLoadForFrame):
210         (didFailLoadWithErrorForFrame):
211         (didSameDocumentNavigationForFrame):
212         (didReceiveTitleForFrame):
213         (didFirstLayoutForFrame):
214         (didFirstVisuallyNonEmptyLayoutForFrame):
215         (didRemoveFrameFromHierarchy):
216         (didDisplayInsecureContentForFrame):
217         (didRunInsecureContentForFrame):
218         (didDetectXSSForFrame):
219         (didStartProgress):
220         (didChangeProgress):
221         (didFinishProgress):
222         (didBecomeUnresponsive):
223         (didBecomeResponsive):
224         (processDidExit):
225         (didChangeBackForwardList):
226         (decidePolicyForNavigationAction):
227         (decidePolicyForNewWindowAction):
228         (decidePolicyForResponse):
229         (createNewPage):
230         (showPage):
231         (closePage):
232         (runJavaScriptAlert):
233         (runJavaScriptConfirm):
234         (runJavaScriptPrompt):
235         (setStatusText):
236         (mouseDidMoveOverElement):
237         (getWindowFrame):
238         (setWindowFrame):
239         (runBeforeUnloadConfirmPanel):
240         (runOpenPanel):
241         (-[WK2BrowserWindowController awakeFromNib]):
242         (-[WK2BrowserWindowController didStartProgress]):
243         (-[WK2BrowserWindowController didChangeProgress:]):
244         (-[WK2BrowserWindowController didFinishProgress]):
245         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
246         (-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
247         (-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
248         (-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
249         (-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
250         (-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
251         (-[WK2BrowserWindowController didCommitLoadForFrame:]):
252         (-[WK2BrowserWindowController loadURLString:]):
253         (-[WK2BrowserWindowController performFindPanelAction:]):
254         (-[WK2BrowserWindowController find:]):
255
256 2012-10-05  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
257
258         [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
259         https://bugs.webkit.org/show_bug.cgi?id=98524
260
261         Reviewed by Alexey Proskuryakov.
262
263         Add implementation for testRunner.setSerializeHTTPLoads in
264         WebKitTestRunner.
265
266         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
267         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
268         (WTR::InjectedBundle::beginTesting):
269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
270         (WTR::TestRunner::setSerializeHTTPLoads):
271         (WTR):
272         * WebKitTestRunner/InjectedBundle/TestRunner.h:
273         (TestRunner):
274
275 2012-10-05  Richard Larocque  <rlarocque@chromium.org>
276
277         TestResultsServer does not display sync_integration_tests results
278         https://bugs.webkit.org/show_bug.cgi?id=98551
279
280         Reviewed by Ojan Vafai.
281
282         Allow builders whose name contains "Sync" to pass through the
283         isChromiumWebkitDepsTestRunner filter.
284
285         The test expectations in flakiness_dashboard_unittests.js have been
286         updated to match the new behaviour.
287
288         * TestResultServer/static-dashboards/builders.js:
289         (isChromiumDepsGTestRunner):
290
291 2012-10-05  Roger Fong  <roger_fong@apple.com>
292
293         Tests in webkitpy involving child processes are flaky. 
294         Skipping run_webkit_tests_integrationtest.py.
295         https://bugs.webkit.org/show_bug.cgi?id=98559
296
297         Reviewed by Dirk Pranke.
298
299         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
300         (MainTest.test_verbose_in_child_processes):
301
302 2012-10-05  Zan Dobersek  <zandobersek@gmail.com>
303
304         [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
305         https://bugs.webkit.org/show_bug.cgi?id=91009
306
307         Reviewed by Martin Robinson.
308
309         Include libxml2 into the jhbuild module. Version 2.8.0 introduces
310         a more correct (but not completely correct) behavior in the
311         fast/xsl/xslt-missing-namespace-in-xslt.html test.
312
313         * gtk/jhbuild.modules:
314
315 2012-10-05  Rob Buis  <rbuis@rim.com>
316
317         [BlackBerry] Implement TestRunner.setMockDeviceOrientation
318         https://bugs.webkit.org/show_bug.cgi?id=98542
319
320         Reviewed by Antonio Gomes.
321
322         PR 120681
323
324         This fixes tests in fast/dom/DeviceOrientation.
325
326         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
327         (TestRunner::setMockDeviceOrientation):
328
329 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
330
331         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
332         https://bugs.webkit.org/show_bug.cgi?id=98256
333
334         Reviewed by Kenneth Rohde Christiansen.
335
336         Implement UIClient's focus callbacks for the main page in
337         WebKitTestRunner.
338
339         * WebKitTestRunner/TestController.cpp:
340         (WTR::focus):
341         (WTR::TestController::initialize):
342
343 2012-10-05  Mark Hahnenberg  <mhahnenberg@apple.com>
344
345         JSC should have a way to gather and log Heap memory use and pause times
346         https://bugs.webkit.org/show_bug.cgi?id=98431
347
348         Reviewed by Geoffrey Garen.
349
350         * DumpRenderTree/mac/DumpRenderTree.mm:
351         (main): Added a check as to whether we should dump our JSC Heap statistics on exit.
352
353 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
354
355         [EFL][WK2] Fix mktemp() compilation warning in Minibrowser
356         https://bugs.webkit.org/show_bug.cgi?id=98493
357
358         Reviewed by Kenneth Rohde Christiansen.
359
360         Fix wrong mktemp usage causing a compilation warning
361         in MiniBrowser.
362
363         * MiniBrowser/efl/main.c:
364         (on_download_request):
365
366 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
367
368         [WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
369         https://bugs.webkit.org/show_bug.cgi?id=98503
370
371         Reviewed by Kenneth Rohde Christiansen.
372
373         Avoid the need for duplicating UIClient callbacks for main page
374         and other pages by passing the view as clientInfo
375         for those callbacks.
376
377         Previously, callbacks for the main page were passed the
378         TestController as clientInfo while the callbacks for other pages
379         were passed the PlatformWebView as clientInfo. This was error prone
380         and leads to useless code duplication.
381
382         * WebKitTestRunner/TestController.cpp:
383         (WTR::getWindowFrame):
384         (WTR::setWindowFrame):
385         (WTR::runBeforeUnloadConfirmPanel):
386         (WTR::TestController::createOtherPage):
387         (WTR::TestController::initialize):
388         (WTR::TestController::decidePolicyForNotificationPermissionRequest):
389
390 2012-10-05  Sadrul Habib Chowdhury  <sadrul@chromium.org>
391
392         [chromium] Allow dragging into plugins.
393         https://bugs.webkit.org/show_bug.cgi?id=98277
394
395         Reviewed by Tony Chang.
396
397         Update the TestWebPlugin to receive drag events and print them out.
398
399         * DumpRenderTree/chromium/TestWebPlugin.cpp:
400         (TestWebPlugin::handleDragStatusUpdate):
401         * DumpRenderTree/chromium/TestWebPlugin.h:
402         (TestWebPlugin):
403
404 2012-10-05  Jongseok Yang  <js45.yang@samsung.com>
405
406         [EFL][WK2] Remove "web" word from ewk_web_error APIs
407         https://bugs.webkit.org/show_bug.cgi?id=97886
408
409         Reviewed by Gyuyoung Kim.
410
411         Remove "web" word from ewk_web_error APIs.
412         "web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.
413
414         * MiniBrowser/efl/main.c:
415         (on_error):
416
417 2012-10-05  Csaba Osztrogonác  <ossy@webkit.org>
418
419         [Qt] Enable CSS compositing by default
420         https://bugs.webkit.org/show_bug.cgi?id=98490
421
422         Reviewed by Simon Hausmann.
423
424         * qmake/mkspecs/features/features.pri:
425
426 2012-10-05  Sheriff Bot  <webkit.review.bot@gmail.com>
427
428         Unreviewed, rolling out r130466.
429         http://trac.webkit.org/changeset/130466
430         https://bugs.webkit.org/show_bug.cgi?id=98495
431
432         It made 12 tests crash on Qt-WK2 (Requested by Ossy on
433         #webkit).
434
435         * WebKitTestRunner/TestController.cpp:
436         (WTR::focus):
437         (WTR::TestController::initialize):
438
439 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
440
441         [EFL] Fix window resizing / moving in WK1 and WKTR
442         https://bugs.webkit.org/show_bug.cgi?id=98486
443
444         Reviewed by Gyuyoung Kim.
445
446         Fix PlatformWebView::windowFrame() and
447         PlatformWebView::setWindowFrame() in EFL's WKTR so
448         that it resizes / moves the window, not the view.
449
450         The new code matches the implementation in EwkView's
451         UIClient.
452
453         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
454         (WTR::PlatformWebView::windowFrame):
455         (WTR::PlatformWebView::setWindowFrame):
456
457 2012-10-04  KyungTae Kim  <ktf.kim@samsung.com>
458
459         [EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
460         https://bugs.webkit.org/show_bug.cgi?id=98334
461
462         Reviewed by Gyuyoung Kim.
463
464         Add callback functions for download requests to Minibrowser to set the destination path for download.
465         Set the destination path with suggested file name as (destination folder) + (suggested file name).
466         The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
467
468         Additionally, for printing out the download status, 
469         use the info macro and set the verbose variable to 1 to enable it.
470
471         * MiniBrowser/efl/main.c:
472         (on_download_request):
473         (on_download_finished):
474         (on_download_failed):
475         (browserCreate):
476
477 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
478
479         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
480         https://bugs.webkit.org/show_bug.cgi?id=98256
481
482         Reviewed by Kenneth Rohde Christiansen.
483
484         Implement UIClient's focus callbacks in WebKitTestRunner.
485
486         * WebKitTestRunner/TestController.cpp:
487         (WTR::focus):
488         (WTR::TestController::initialize):
489
490 2012-10-04  Rik Cabanier  <cabanier@adobe.com>
491
492         Turn Compositing on by default in WebKit build
493         https://bugs.webkit.org/show_bug.cgi?id=98315
494
495         Reviewed by Simon Fraser.
496
497         enable -webkit-blend-mode on trunk.
498
499         * Scripts/webkitperl/FeatureList.pm:
500
501 2012-10-04  Ryuan Choi  <ryuan.choi@samsung.com>
502
503         [EFL][WK2] Add APIs to get/set the frame flattening.
504         https://bugs.webkit.org/show_bug.cgi?id=95982
505
506         Reviewed by Gyuyoung Kim.
507
508         * MiniBrowser/efl/main.c: Added frame flattening option to test.
509         (browserCreate):
510         (main):
511
512 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
513
514         [EFL] Add libxml 2.8.0 to jhbuild
515         https://bugs.webkit.org/show_bug.cgi?id=98418
516
517         Reviewed by Laszlo Gombos.
518
519         Add libxml 2.8.0 to EFL's jhbuild for consistency.
520
521         * efl/jhbuild.modules:
522
523 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
524
525         [WK2] Support all attributes of GeolocationPosition
526         https://bugs.webkit.org/show_bug.cgi?id=98212
527
528         Reviewed by Sam Weinig.
529
530         Expand WebKitTestRunner and DumpRenderTree to test all the attributes
531         of GeolocationPosition.
532
533         * DumpRenderTree/TestRunner.cpp:
534         (setMockGeolocationPositionCallback):
535         * DumpRenderTree/TestRunner.h:
536         (TestRunner):
537         * DumpRenderTree/efl/TestRunnerEfl.cpp:
538         (TestRunner::setMockGeolocationPosition):
539         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
540         (TestRunner::setMockGeolocationPosition):
541         * DumpRenderTree/mac/TestRunnerMac.mm:
542         (TestRunner::setMockGeolocationPosition):
543         * DumpRenderTree/win/TestRunnerWin.cpp:
544         (TestRunner::setMockGeolocationPosition):
545         * DumpRenderTree/wx/TestRunnerWx.cpp:
546         (TestRunner::setMockGeolocationPosition):
547         * WebKitTestRunner/GeolocationProviderMock.cpp:
548         (WTR::GeolocationProviderMock::setPosition):
549         * WebKitTestRunner/GeolocationProviderMock.h:
550         (GeolocationProviderMock):
551         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
552         (_platformTypeVariableDeclaration):
553         Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
554         to build the pointer outself.
555         This is necessary to support optional JSValueRef properly.
556
557         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
558         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
559         (WTR::InjectedBundle::setMockGeolocationPosition):
560         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
561         (InjectedBundle):
562         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
563         (WTR::TestRunner::setMockGeolocationPosition):
564         * WebKitTestRunner/InjectedBundle/TestRunner.h:
565         (TestRunner):
566         * WebKitTestRunner/TestController.cpp:
567         (WTR::TestController::setMockGeolocationPosition):
568         * WebKitTestRunner/TestController.h:
569         (TestController):
570         * WebKitTestRunner/TestInvocation.cpp:
571         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
572
573 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
574
575         Make the Xvfb driver recognize `X' as a valid X server binary.
576         https://bugs.webkit.org/show_bug.cgi?id=98434
577
578         Reviewed by Dirk Pranke.
579
580         The X server binary can also be called `X', so account for that
581         possibility in the _next_free_display regexp.
582
583         Additionally, make the regular expression require at least one
584         space character after the `ps comm' part.
585
586         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
587         (XvfbDriver._next_free_display):
588         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
589         (XvfbDriverTest.test_next_free_display):
590
591 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
592
593         webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
594         https://bugs.webkit.org/show_bug.cgi?id=98436
595
596         Reviewed by Dirk Pranke.
597
598         The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
599         the environment for the server process, and the WEBKITOUTPUTDIR
600         environment variable was not being passed through, causing the
601         build directory to be wrongfully set to WebKitBuild/ all the time.
602
603         * Scripts/webkitpy/layout_tests/port/base.py:
604         (Port.to.setup_environ_for_server):
605
606 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
607
608         [EFL][WK2] Add setting to allow file access from file:// URLs
609         https://bugs.webkit.org/show_bug.cgi?id=98121
610
611         Reviewed by Laszlo Gombos.
612
613         Allow file access from file:// URLs by default in Minibrowser
614         to facilitate testing.
615
616         * MiniBrowser/efl/main.c:
617         (browserCreate):
618
619 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
620
621         [EFL] Run unit tests with Xvfb
622         https://bugs.webkit.org/show_bug.cgi?id=98389
623
624         Reviewed by Laszlo Gombos.
625
626         Run EFL unit tests with Xvfb, similarly to GTK port.
627
628         * Scripts/run-efl-tests:
629
630 2012-10-04  Adrian Perez de Castro  <aperez@igalia.com>
631
632         [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
633         https://bugs.webkit.org/show_bug.cgi?id=98333
634
635         Reviewed by Xan Lopez.
636
637         Both MiniBrowser and GtkLauncher are tools for testing, so in
638         the end every time we want to test the inspector we have to
639         manually enable enable the “developer extras” setting when using
640         them. It make sense to have this setting enabled by default.
641
642         * GtkLauncher/main.c:
643         (main):
644         * MiniBrowser/gtk/main.c:
645         (main):
646
647 2012-10-04  Harald Alvestrand  <hta@google.com>
648
649         Change RTCPeerConnection GetStats to use Date timestamp format
650         https://bugs.webkit.org/show_bug.cgi?id=98263
651
652         Reviewed by Yury Semikhatsky.
653
654         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
655         (MockWebRTCPeerConnectionHandler::getStats):
656
657 2012-10-04  Dirk Pranke  <dpranke@chromium.org>
658
659         [NRWT] --skipped option is ignored when --test-list is used
660         https://bugs.webkit.org/show_bug.cgi?id=98260
661
662         Reviewed by Ojan Vafai.
663
664         Adds a --skipped=always flag that will skip any tests listed in
665         TestExpectations even if they're listed explicitly on the
666         command line.
667
668         This is most useful if you are using --test-list to specify a
669         long list of files but you still want to skip some of them
670         depending on what's in TestExpectations.
671
672         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
673         (LayoutTestFinder.skip_tests):
674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
675         (parse_args):
676         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
677         (MainTest.test_skipped_flag):
678
679 2012-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
680
681         Unreviewed, rolling out r130377.
682         http://trac.webkit.org/changeset/130377
683         https://bugs.webkit.org/show_bug.cgi?id=98392
684
685         Chromium Win compilation is broken (Requested by yurys on
686         #webkit).
687
688         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
689         (MockWebRTCPeerConnectionHandler::getStats):
690
691 2012-10-04  Harald Alvestrand  <hta@google.com>
692
693         Change RTCPeerConnection GetStats to use Date timestamp format
694         https://bugs.webkit.org/show_bug.cgi?id=98263
695
696         Reviewed by Adam Barth.
697
698         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
699         (MockWebRTCPeerConnectionHandler::getStats):
700
701 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
702
703         Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.
704
705         * Scripts/webkitperl/FeatureList.pm:
706
707 2012-10-03  Philip Rogers  <pdr@google.com>
708
709         Force GC between PageLoad tests.
710         https://bugs.webkit.org/show_bug.cgi?id=98203
711
712         Reviewed by Ryosuke Niwa.
713
714         Previously, our PageLoad PerfTests had multi-modal distributions,
715         typically with a small cluster at 1-2x the median. This turned out
716         to be caused by not garbage collecting between tests!
717
718         This patch adds a new file, force-gc.html, and loads this file between
719         PageLoad tests to force a GC. I manually verified that this cleans up
720         our perf test outliers.
721
722         * Scripts/webkitpy/performance_tests/perftest.py:
723         (PageLoadingPerfTest.__init__):
724         (PageLoadingPerfTest):
725         (PageLoadingPerfTest.run_single):
726
727             This function now loads two pages: one to force a gc and
728             then the test to run.
729
730         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
731
732             Modified several existing tests to show that the force-gc file
733             is loaded.
734
735         (MockPort):
736         (MockPort.__init__):
737         (MockPort.perf_tests_dir):
738         (TestPageLoadingPerfTest.MockDriver.__init__):
739         (TestPageLoadingPerfTest.MockDriver.run_test):
740         (TestPageLoadingPerfTest.test_run):
741         (TestPageLoadingPerfTest.test_run_with_bad_output):
742         (TestReplayPerfTest.ReplayTestPort):
743         (TestReplayPerfTest.ReplayTestPort.__init__):
744         (TestReplayPerfTest.test_run_single.run_test):
745         (TestReplayPerfTest.test_run_single):
746         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
747         (TestPerfTestFactory.test_regular_test):
748         (TestPerfTestFactory.test_inspector_test):
749         (TestPerfTestFactory.test_page_loading_test):
750
751 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
752
753         [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
754         https://bugs.webkit.org/show_bug.cgi?id=98231
755
756         Reviewed by Gyuyoung Kim.
757
758         Enable use of X11 in DumpRenderTree / WebKitTestRunner.
759         Call ecore_evas_new() instead of ecore_evas_buffer_new()
760         in EFL's DumpRenderTree and WebKitTestRunner.
761         It is safe to do this now that we are using XvfbDriver
762         for the layout tests.
763
764         * DumpRenderTree/efl/DumpRenderTree.cpp:
765         (parseCommandLineOptions):
766         (initEcoreEvas):
767         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
768         (WTR::initEcoreEvas):
769         * WebKitTestRunner/efl/main.cpp:
770         (main):
771
772 2012-10-03  Dirk Pranke  <dpranke@chromium.org>
773
774         run-webkit-tests tests on win32 after r127302
775         https://bugs.webkit.org/show_bug.cgi?id=98323
776
777         Reviewed by Eric Seidel.
778
779         run-webkit-tests tests on win32 after r127302
780         https://bugs.webkit.org/show_bug.cgi?id=98323
781
782         Reviewed by Eric Seidel.
783
784         Looks like when we converted the json-building logic to use scm
785         to try and get the svn revision, we missed a win32-ism and
786         didn't check to make sure had initialized the scm subsystem.
787
788         This change fixes that and renames _initialize_scm to be a public method.
789
790         * Scripts/webkitpy/common/host.py:
791         (Host.initialize_scm):
792         * Scripts/webkitpy/common/host_mock.py:
793         (MockHost.__init__):
794         (MockHost.initialize_scm):
795         * Scripts/webkitpy/layout_tests/controllers/manager.py:
796         (summarize_results):
797         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
798         (JSONResultsGeneratorBase.get_json):
799         (JSONResultsGeneratorBase._get_result_char):
800         (JSONResultsGeneratorBase._get_svn_revision):
801         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
802         (PerfTestsRunner.__init__):
803         * Scripts/webkitpy/style/checkers/test_expectations.py:
804         (TestExpectationsChecker.__init__):
805         * Scripts/webkitpy/style/main.py:
806         (CheckWebKitStyle.main):
807         * Scripts/webkitpy/tool/main.py:
808         (WebKitPatch.handle_global_options):
809         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
810         (get_test_baselines):
811
812 2012-10-03  Adrian Perez de Castro  <aperez@igalia.com>
813
814         [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
815         https://bugs.webkit.org/show_bug.cgi?id=98310
816
817         Reviewed by Martin Robinson.
818
819         Make MiniBrowser/GtkLauncher define the path to the inspector
820         resources by setting the WEBKIT_INSPECTOR_PATH environment
821         variable pointing to the copy of the inspector resources in
822         the build directory. If the environment variable is already
823         defined, its value is not overwritten. The path is derived
824         from the WEBKIT_EXEC_PATH macro defined in the makefiles.
825
826         * GNUmakefile.am:
827         * GtkLauncher/main.c:
828         (main):
829         * MiniBrowser/gtk/main.c:
830         (main):
831
832 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
833
834         Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
835         https://bugs.webkit.org/show_bug.cgi?id=97608
836
837         Reviewed by Sam Weinig.
838
839         The test fast/dom/Geolocation/window-close-crash.html was crashing because
840         handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
841         the page was created, the void* clientInfo can either be a PlatformWebView or
842         a TestController.
843
844         Using the global TestController fixes the issue.
845
846         * WebKitTestRunner/GeolocationProviderMock.cpp:
847         (WTR::GeolocationProviderMock::setPosition):
848         (WTR::GeolocationProviderMock::setPositionUnavailableError):
849         To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
850         to clear the error and vice versa.
851         This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
852
853         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
854         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
855         Some tests expect the position/error cant be sent multiple time,
856         just keep the position after sending.
857
858         * WebKitTestRunner/TestController.cpp:
859         (WTR::decidePolicyForGeolocationPermissionRequest):
860         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
861         * WebKitTestRunner/TestController.h:
862         Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
863         client would have to do.
864
865 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
866
867         [BlackBerry] Implementing the NetworkInfo API for BB port
868         https://bugs.webkit.org/show_bug.cgi?id=98273
869
870         Reviewed by Rob Buis.
871
872         Enabling NetworkInfo API for the BlackBerry port.
873
874         * Scripts/webkitperl/FeatureList.pm:
875
876 2012-10-03  Anders Carlsson  <andersca@apple.com>
877
878         Exception thrown when running accessibility/container-node-delete-causes-crash.html test
879         https://bugs.webkit.org/show_bug.cgi?id=98291
880
881         Reviewed by Andreas Kling.
882
883         The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
884         to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
885         when trying to access the children of an element that didn't have any children. Fix this by adding
886         BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
887
888         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
889         (findAccessibleObjectById):
890
891 2012-10-03  Ojan Vafai  <ojan@chromium.org>
892
893         Make partytime work when loading garden-o-matic from trac.webkit.org
894         https://bugs.webkit.org/show_bug.cgi?id=98283
895
896         Reviewed by Adam Barth.
897
898         CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
900
901 2012-10-03  Roger Fong  <roger_fong@apple.com>
902
903         Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
904         https://bugs.webkit.org/show_bug.cgi?id=98288
905
906         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
907         (ChromiumAndroidDriverTest.test_command_from_driver_input):
908
909 2012-10-03  Ojan Vafai  <ojan@chromium.org>
910
911         Get rid of warning about non-existant platform name when loading garden-o-matic
912         https://bugs.webkit.org/show_bug.cgi?id=98282
913
914         Reviewed by Adam Barth.
915
916         If you loaded without a platform query parameter we'd return "null" as the platform name
917         instead of null.
918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
920
921 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>
922
923         [Qt] Enable mock scrollbars
924         https://bugs.webkit.org/show_bug.cgi?id=98011
925
926         Reviewed by Csaba Osztrogonác.
927
928         Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
929
930         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
931         (WebCore::DumpRenderTree::DumpRenderTree):
932         * WebKitTestRunner/TestController.cpp:
933         (WTR::TestController::resetStateToConsistentValues):
934
935 2012-10-03  Alberto Garcia  <agarcia@igalia.com>
936
937         [GTK] [WK2] Add favicon support to the MiniBrowser
938         https://bugs.webkit.org/show_bug.cgi?id=98063
939
940         Reviewed by Carlos Garcia Campos.
941
942         Set the icon in the URI text entry using the favicon property of
943         the WebKitWebView.
944
945         * MiniBrowser/gtk/BrowserWindow.c:
946         (_BrowserWindow):
947         (updateUriEntryIcon):
948         (uriEntryTextChanged):
949         (faviconChanged):
950         (browserWindowFinalize):
951         (browser_window_init):
952         (browserWindowConstructed):
953
954 2012-10-03  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
955
956         [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
957         https://bugs.webkit.org/show_bug.cgi?id=98200
958
959         Reviewed by Csaba Osztrogonác.
960
961         * DumpRenderTree/qt/TestRunnerQt.cpp:
962         (TestRunner::overridePreference):
963
964 2012-10-03  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
965
966         [Qt][WRT] Fix build error with MSVC on Windows.
967         https://bugs.webkit.org/show_bug.cgi?id=97697
968
969         Reviewed by Simon Hausmann.
970
971         WTR build is failing when WebKit directory is located on a longer path.
972         This seems to caused by source files that has the same name in
973         WTR and DRT directories. The solution is removing referencies 
974         from Target.pri to DRT directory and adding an alternate version of
975         the required files to WTR. Those files simply include the real ones from DRT.
976
977         * WebKitTestRunner/InjectedBundle/Target.pri:
978         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
979         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
980
981 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
982
983         [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
984         https://bugs.webkit.org/show_bug.cgi?id=98238
985
986         Reviewed by Csaba Osztrogonác.
987
988         Reset AlwaysAcceptCookies setting between tests to avoid
989         flakiness due to TestRunner.setAlwaysAcceptCookies().
990
991         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
992         (WTR::InjectedBundle::beginTesting):
993
994 2012-10-03  Harald Alvestrand  <hta@google.com>
995
996         Add data passing to the GetStats interface of RTCPeerConnection
997         https://bugs.webkit.org/show_bug.cgi?id=98003
998
999         Reviewed by Adam Barth.
1000
1001         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1002         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
1003         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1004         (MockWebRTCPeerConnectionHandler::addStream):
1005         (MockWebRTCPeerConnectionHandler::removeStream):
1006         (MockWebRTCPeerConnectionHandler::getStats):
1007         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1008         (MockWebRTCPeerConnectionHandler):
1009
1010 == Rolled over to ChangeLog-2012-10-02 ==