aa2f7b9c1ae64790ecae7bf888ef8b0d77bac351
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Add my new address to contributors.json. (Unreviewed)
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
8
9         Unreviewed. Move myself to the reviewers list.
10
11         * Scripts/webkitpy/common/config/contributors.json:
12
13 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
14
15         Unreviewed. Add my email to a few watchlists.
16
17         * Scripts/webkitpy/common/config/watchlist:
18
19 2013-05-10  Simon Pena  <simon.pena@samsung.com>
20
21         Unicode support missing from string representation of Contributors in committers.py
22         https://bugs.webkit.org/show_bug.cgi?id=115859
23
24         Reviewed by Darin Adler.
25
26         Contributors, in committers.py, provided a string representation in __str__ which
27         didn't support unicode characters, so printing a contributor would fail in that case.
28         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
29         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
30
31         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
32         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
33         representation.
34         (Contributor.__str__):
35         (Contributor):
36         (Contributor.__unicode__):
37         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
38         a contributor with unicode characters can be represented as a string.
39         (CommittersTest):
40         (CommittersTest.test_contributor_encoding):
41
42 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
43
44         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
45         https://bugs.webkit.org/show_bug.cgi?id=92371
46
47         Reviewed by Brent Fulgham.
48
49         Use JavaScriptThreading.cpp where the same functionality is
50         implemented too. This reduces the dependency on the pthread
51         library. Also replace assert() with WebKit ASSERT().
52
53         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
54         * DumpRenderTree/win/DumpRenderTree.cpp:
55         (dumpHistoryItem):
56         (dumpBackForwardList):
57         * DumpRenderTree/win/DumpRenderTree.vcproj:
58
59 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
60
61         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
62         https://bugs.webkit.org/show_bug.cgi?id=92505
63
64         Reviewed by Brent Fulgham.
65
66         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
67         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
68         (javaScriptThreadsMutex):
69         (javaScriptThreads):
70         (runJavaScriptThread):
71         (startJavaScriptThreads):
72         (stopJavaScriptThreads):
73         * DumpRenderTree/pthreads: Removed.
74         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
75
76 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
77
78         Unreviewed. Update Simon Pena email on his behalf.
79
80         * Scripts/webkitpy/common/config/contributors.json:
81
82 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
83
84         Add support for [NoInterfaceObject] Web IDL extended attribute
85         https://bugs.webkit.org/show_bug.cgi?id=115714
86
87         Reviewed by Kentaro Hara.
88
89         Update BindingsTests.generate_supplemental_dependency() to pass an
90         additional windowConstructorsFile argument to preprocess-idls.pl.
91
92         * Scripts/webkitpy/bindings/main.py:
93         (BindingsTests.generate_supplemental_dependency):
94         (BindingsTests.main):
95
96 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
97
98         [GTK][AC] Buildfix after r149694
99         https://bugs.webkit.org/show_bug.cgi?id=115797
100
101         Reviewed by Gustavo Noronha Silva.
102
103         Add CLUTTER_LIBS for linking TestWebCore.
104
105         * TestWebKitAPI/GNUmakefile.am:
106
107 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
108
109         [EFL] Remove unnecessary pkgs in EFL jhbuild
110         https://bugs.webkit.org/show_bug.cgi?id=114908
111
112         Reviewed by Laszlo Gombos.
113
114         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
115         handle them using jhbuild. We can reduce build time when using --update-efl.
116
117         * efl/jhbuild.modules:
118
119 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
120
121         [EFL] Disable SHADOW DOM feature in FeatureList.pm
122         https://bugs.webkit.org/show_bug.cgi?id=115834
123
124         Reviewed by Gyuyoung Kim.
125
126         * Scripts/webkitperl/FeatureList.pm:
127
128 2013-05-08  Lucas Forschler  <lforschler@apple.com>
129
130         Add Scheduler for Mac MtnLion 32bit Release builder.
131         
132         Unreviewed.
133         
134         * BuildSlaveSupport/build.webkit.org-config/config.json:
135
136 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
137
138         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
139         https://bugs.webkit.org/show_bug.cgi?id=115808
140
141         Reviewed by Darin Adler.
142
143         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
144         was left outdated after r127191, when the m_string member was changed
145         from UString to String. This patch calls the right pretty printer for it.
146
147         * gdb/webkit.py:
148         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
149         WTFImplPrettyPrinter.
150
151 2013-05-08  Andy Estes  <aestes@apple.com>
152
153         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
154         https://bugs.webkit.org/show_bug.cgi?id=115790
155
156         Reviewed by Alexey Proskuryakov.
157
158         Added two API tests:
159
160         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
161         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
162
163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
164         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
165         (TestWebKitAPI):
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
168         (TestWebKitAPI):
169         (TestWebKitAPI::decidePolicyForNavigationAction):
170         (CustomProtocolInvalidSchemeTest):
171         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
172
173 2013-05-08  Lucas Forschler  <lforschler@apple.com>
174
175         Teach buildbot how to compile 32-bit on Mac.
176
177         Reviewed by Ryosuke Niwa.
178
179         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
180         (CompileWebKit.start):
181         (ExtractTestResultsAndLeaks):
182
183 2013-05-08  Eli Fidler  <efidler@blackberry.com>
184
185         [BlackBerry] Fix usage of BlackBerry::Platform::String
186         https://bugs.webkit.org/show_bug.cgi?id=115781
187
188         Reviewed by Rob Buis.
189
190         BlackBerry PRs 304193 and 327181
191         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
192
193         We currently have a problem where we're passing UTF-8 encoded data into
194         the char* constructors of BlackBerry::Platform::String. This means the string
195         thinks its data is not UTF-8.
196
197         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
198         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
199         (BlackBerry::WebKit::dumpHistoryItem):
200         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
201         (TestRunner::setUserStyleSheetLocation):
202         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
203         (LoadHTMLStringItem::invoke):
204
205 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
206
207         Tools: add new BlackBerry include dirs.
208         https://bugs.webkit.org/show_bug.cgi?id=115514
209
210         Reviewed by Rob Buis.
211
212         iType include dirs are missing, and HarfBuzz needs to be fixed.
213
214         * Scripts/webkitdirs.pm:
215         (blackberryCMakeArguments):
216
217 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
218
219         [GTK] Plumb the Automake build system for the Battery Status API feature
220         https://bugs.webkit.org/show_bug.cgi?id=115718
221
222         Reviewed by Martin Robinson.
223
224         * Scripts/webkitdirs.pm:
225         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
226         through the --(enable|disable)-battery-status flag passed to configure.
227
228 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
229
230         new-run-webkit-websocketserver doesn't work after Chromium removal
231         https://bugs.webkit.org/show_bug.cgi?id=115816
232
233         Reviewed by Joseph Pecoraro.
234
235         Fix the bug by instantiating the correct port object.
236
237         * Scripts/new-run-webkit-websocketserver:
238         (main):
239
240 2013-05-07  Lucas Forschler  <lforschler@apple.com>
241
242         Configure buildbot for 32bit builder.
243         https://bugs.webkit.org/show_bug.cgi?id=115769
244         
245         Reviewed by Ryosuke Niwa.
246
247         * BuildSlaveSupport/build.webkit.org-config/config.json:
248
249 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
250
251         Unreviewed. Update to show my apple.com address.
252
253         * Scripts/webkitpy/common/config/contributors.json: Added
254         my apple.com e-mail address.
255
256 2013-05-08  David Kilzer  <ddkilzer@apple.com>
257
258         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
259
260         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
261         (concatenateAttributeAndValue): Switch to appendVector().
262
263 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
264
265         [Qt][WTR] Fix the build on Mac after r149692
266
267         Unreviewed build fix.
268
269         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
270         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
271
272 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
273
274         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
275         to the watchlist for Accessibility.
276
277         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
278         * Scripts/webkitpy/common/config/watchlist: Added myself.
279
280 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
281
282         [Qt] Build fails with clang
283         https://bugs.webkit.org/show_bug.cgi?id=115741
284
285         Reviewed by Benjamin Poulain.
286
287         Since r149112 std::move is used in AtomicString for compilers that
288         support rvalue references and this requires a standard library
289         implementing c++11 move semantics.
290         We only explicitely require c++11 for WebKit2, but since clang supports
291         rvalue references the build of subtargets using AtomicString fails because
292         of missing std::move.
293         It is safe to add CONFIG += c++11 for the whole project when using clang
294         since we explicitely disable c++11 for ANGLE that had probems with libc++.
295
296         * qmake/mkspecs/features/unix/default_pre.prf:
297
298 2013-05-08  Darin Adler  <darin@apple.com>
299
300         Fix one more place that needed to use adoptCF/NS
301         https://bugs.webkit.org/show_bug.cgi?id=115778
302
303         Reviewed by Benjamin Poulain.
304
305         Not sure why I missed this code last time, but found a bit more code that needs
306         to switch to the newer style adoptCF/NS.
307
308         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
309         (convertWebResourceDataToString): Use adoptCF.
310         (convertWebResourceResponseToDictionary): Ditto.
311         (createXMLStringFromWebArchiveData): Ditto.
312         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
313         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
314
315 2013-05-08  Commit Queue  <commit-queue@webkit.org>
316
317         Unreviewed, rolling out r149271.
318         http://trac.webkit.org/changeset/149271
319         https://bugs.webkit.org/show_bug.cgi?id=115780
320
321         The mangled symbols are now enforced through LDFLAGS
322         (Requested by zdobersek on #webkit).
323
324         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
325
326 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
327
328         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
329         https://bugs.webkit.org/show_bug.cgi?id=115636
330
331         Reviewed by Ryosuke Niwa.
332
333         * TestResultServer/static-dashboards/flakiness_dashboard.js:
334         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
335         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
336         while Chromium-specific, can't be removed just yet as there's more code that uses it.
337
338 2013-05-06  Darin Adler  <darin@apple.com>
339
340         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
341         https://bugs.webkit.org/show_bug.cgi?id=115657
342
343         Reviewed by Sam Weinig.
344
345         This is similar to my last set of changes, but covers code that I missed with
346         global replace using the Safari Xcode workspace.
347
348         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
349         (convertWebResourceDataToString):
350         (convertWebResourceResponseToDictionary):
351         (createXMLStringFromWebArchiveData):
352         * DumpRenderTree/cg/ImageDiffCG.cpp:
353         (createImageFromStdin):
354         (createDifferenceImage):
355         (main):
356         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
357         (printPNG):
358         (dumpBitmap):
359         * DumpRenderTree/cg/PixelDumpSupportCG.h:
360         (BitmapContext::BitmapContext):
361         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
362         (-[MockWebNotificationProvider init]):
363         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
364         (createBitmapContext):
365         * DumpRenderTree/mac/TestRunnerMac.mm:
366         (TestRunner::addDisallowedURL):
367         (TestRunner::applicationCacheDiskUsageForOrigin):
368         (TestRunner::localStorageDiskUsageForOrigin):
369         (TestRunner::clearApplicationCacheForOrigin):
370         (TestRunner::deleteLocalStorageForOrigin):
371         (TestRunner::copyDecodedHostName):
372         (TestRunner::copyEncodedHostName):
373         (TestRunner::queueLoad):
374         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
375         (TestRunner::setMockGeolocationPositionUnavailableError):
376         (TestRunner::setUserStyleSheetLocation):
377         (TestRunner::setValueForUser):
378         (TestRunner::overridePreference):
379         (TestRunner::setPersistentUserStyleSheetLocation):
380         (TestRunner::execCommand):
381         (TestRunner::findString):
382         (TestRunner::isCommandEnabled):
383         (TestRunner::addOriginAccessWhitelistEntry):
384         (TestRunner::removeOriginAccessWhitelistEntry):
385         (TestRunner::addUserScript):
386         (TestRunner::addUserStyleSheet):
387         (TestRunner::evaluateInWebInspector):
388         (TestRunner::evaluateScriptInIsolatedWorld):
389         (TestRunner::apiTestNewWindowDataLoadBaseURL):
390         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
391         (TestRunner::authenticateSession):
392         (TestRunner::grantWebNotificationPermission):
393         (TestRunner::denyWebNotificationPermission):
394         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
395         (createCFURLResponseFromResponseData):
396         * DumpRenderTree/mac/WorkQueueItemMac.mm:
397         (LoadItem::invoke):
398         (LoadHTMLStringItem::invoke):
399         (ScriptItem::invoke):
400         * DumpRenderTree/win/DumpRenderTree.cpp:
401         (substringFromIndex):
402         (urlSuitableForTestResult):
403         (lastPathComponent):
404         (sharedCFURLCache):
405         * DumpRenderTree/win/ImageDiffCairo.cpp:
406         (createImageFromStdin):
407         (main):
408         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
409         (createBitmapContextFromWebView):
410         * DumpRenderTree/win/TestRunnerWin.cpp:
411         (TestRunner::setUserStyleSheetLocation):
412         (TestRunner::setPersistentUserStyleSheetLocation):
413         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
414         (TestWebKitAPI::TEST):
415         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
416         (TestWebKitAPI::TEST):
417         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
418         (TestWebKitAPI::TEST):
419         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
420         (TestWebKitAPI::TEST):
421         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
422         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
423         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
424         (TestWebKitAPI::createWindow):
425         (TestWebKitAPI::TEST):
426         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
427         (TestWebKitAPI::TEST):
428         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
429         (TestWebKitAPI::AcceptsFirstMouse::runTest):
430         * TestWebKitAPI/Tests/mac/AttributedString.mm:
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
435         (TestWebKitAPI::TEST):
436         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
445         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
446         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
447         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
448         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
455         (TestWebKitAPI::TEST):
456         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
457         (TestWebKitAPI::TEST):
458         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
459         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
460         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
465         (TestWebKitAPI::TEST):
466         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
471         (TestWebKitAPI::TEST):
472         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
473         (TestWebKitAPI::TEST):
474         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
475         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
476         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
477         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
478         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
479         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
480         (WTR::testPathFromURL):
481         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
482         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
483         * WebKitTestRunner/cg/TestInvocationCG.cpp:
484         (WTR::createCGContextFromImage):
485         (WTR::dumpBitmap):
486         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
487         * WebKitTestRunner/mac/EventSenderProxy.mm:
488         (WTR::EventSenderProxy::mouseScrollBy):
489         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
490         (WTR::PlatformWebView::windowSnapshotImage):
491         * WebKitTestRunner/win/TestControllerWin.cpp:
492         (WTR::TestController::initializeTestPluginDirectory):
493         Use adoptCF and adoptNS.
494
495 2013-05-07  Alex Christensen  <achristensen@apple.com>
496
497         Fix a memory leak introduced in r149692
498         https://bugs.webkit.org/show_bug.cgi?id=115766
499
500         Reviewed by Mark Rowe.
501
502         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
503         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
504
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
506         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
507         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
508
509 2013-05-07  Darin Adler  <darin@apple.com>
510
511         [Win] Fix storage leak in Windows DumpRenderTree
512         https://bugs.webkit.org/show_bug.cgi?id=115651
513
514         Reviewed by Sam Weinig.
515
516         * DumpRenderTree/win/DumpRenderTree.cpp:
517         (lastPathComponent): Added a missing call to adoptCF.
518
519 2013-05-07  Alex Christensen  <achristensen@apple.com>
520
521         fixed a memory leak introduced by bug 42324 by using a RetainPtr
522         https://bugs.webkit.org/show_bug.cgi?id=115760
523
524         Reviewed by Tim Horton.
525
526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
527         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
528         fixed memory leak, added UNUSED_PARAM macros
529
530 2013-05-07  Alex Christensen  <achristensen@apple.com>
531
532         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
533         https://bugs.webkit.org/show_bug.cgi?id=42324
534         <rdar://problem/8193633>
535
536         Reviewed by Tim Horton.
537
538         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
539         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
540         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
541         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
542         Added dumpDOMAsWebArchive code that is called when dumping.        
543         (WTR::InjectedBundlePage::dump):
544         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
545         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
546         (InjectedBundlePage):
547         Added dumpDOMAsWebArchive declaration.
548         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
549         (WTR::TestRunner::dumpDOMAsWebArchive):
550         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
551         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
552         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
553         * Tools/WebKitTestRunner/cf: Added.
554         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
555         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
556         (convertMIMEType):
557         (convertWebResourceDataToString):
558         (normalizeHTTPResponseHeaderFields):
559         (normalizeWebResourceURL):
560         (convertWebResourceResponseToDictionary):
561         (compareResourceURLs):
562         (createXMLStringFromWebArchiveData):
563         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
564         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
565         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
566         Copied from Tools/DumpRenderTree/mac for used functions.
567         (createCFURLResponseFromResponseData):
568         (supportedNonImageMIMETypes):
569
570 2013-05-07  Alex Christensen  <achristensen@apple.com>
571
572         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
573         https://bugs.webkit.org/show_bug.cgi?id=115745
574
575         Reviewed by Tim Horton.
576
577         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
578         (compareResourceURLs):
579         Updated style.
580
581 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
582
583         Add an 'isReadOnly' member to IDL parse tree structure
584         https://bugs.webkit.org/show_bug.cgi?id=115704
585
586         Reviewed by Kentaro Hara.
587
588         Use newly added isReadOnly attribute.
589
590         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
591         (_generateHeaderFile):
592         (_generateImplementationFile):
593         (_staticValuesGetterImplementation):
594
595 2013-05-07  Anders Carlsson  <andersca@apple.com>
596
597         Remove AlwaysInline.h from WTF
598         https://bugs.webkit.org/show_bug.cgi?id=115727
599
600         Reviewed by Brent Fulgham.
601
602         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
603         to keep AlwaysInline.h around anymore.
604
605         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
606         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
607
608 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
609
610         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
611         https://bugs.webkit.org/show_bug.cgi?id=114808
612
613         Reviewed by Jocelyn Turcotte.
614
615         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
616         (https://codereview.qt-project.org/#change,54234)
617
618         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
619         (WTR::WrapperWindow::handleStatusChanged):
620
621 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
622
623         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
624
625         * Scripts/webkitpy/common/config/watchlist:
626
627 2013-05-06  Kangil Han  <kangil.han@samsung.com>
628
629         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
630         https://bugs.webkit.org/show_bug.cgi?id=115645
631
632         Reviewed by Gyuyoung Kim.
633
634         To run performance tests in wk1, we need --no-timeout option implementation.
635         So adopt it from gtk+ port.
636
637         * DumpRenderTree/efl/DumpRenderTree.cpp:
638         (shouldSetWaitToDumpWatchdog):
639         (parseCommandLineOptions):
640         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
641         * DumpRenderTree/efl/TestRunnerEfl.cpp:
642         (TestRunner::setWaitToDump):
643
644 2013-05-06  Commit Queue  <commit-queue@webkit.org>
645
646         Unreviewed, rolling out r149547.
647         http://trac.webkit.org/changeset/149547
648         https://bugs.webkit.org/show_bug.cgi?id=115682
649
650         Added unittests that fail on bots and spits out text into
651         stdout (Requested by rniwa on #webkit).
652
653         * Scripts/import-w3c-tests: Removed.
654         * Scripts/webkitpy/w3c/__init__.py: Removed.
655         * Scripts/webkitpy/w3c/test_converter.py: Removed.
656         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
657         * Scripts/webkitpy/w3c/test_importer.py: Removed.
658         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
659         * Scripts/webkitpy/w3c/test_parser.py: Removed.
660         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
661
662 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
663
664         [jhbuild] bump jhbuild version to take advantage of new improvements
665         https://bugs.webkit.org/show_bug.cgi?id=115558
666
667         Reviewed by Martin Robinson.
668
669         One of the important improvements is jhbuild no longer fetches git
670         repositories if they are already at the expected revision, which should
671         make the EWS bots more robust to git servers unavailability.
672
673         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
674
675 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
676
677         [GTK] Add webkit_uri_scheme_request_finish_error
678         https://bugs.webkit.org/show_bug.cgi?id=94316
679
680         Reviewed by Anders Carlsson.
681
682         * MiniBrowser/gtk/main.c:
683         (miniBrowserErrorQuark): Add function to create a global quark for
684         MiniBrowser.
685         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
686         function webkit_uri_scheme_request_finish_error().
687
688 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
689
690         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
691         https://bugs.webkit.org/show_bug.cgi?id=113808
692
693         Reviewed by Rob Buis.
694
695         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
696         to true for BlackBerry.
697
698         * Scripts/webkitperl/FeatureList.pm:
699
700 2013-05-06  Jessie Berlin  <jberlin@apple.com>
701
702         check-webkit-style should complain about a layering violation if platform-specific guards are
703         used in WebCore outside of the platform directory
704         https://bugs.webkit.org/show_bug.cgi?id=115567
705
706         Reviewed by Benjamin Poulain.
707
708         * Scripts/webkitpy/style/checkers/cpp.py:
709         (check_for_webcore_platform_layering_violation):
710         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
711         (process_line):
712         Add the check_for_webcore_platform_layering_violation.
713         (CppChecker):
714         List the new check.
715
716         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
717         (CppStyleTest.test_webcore_platform_layering_violation):
718         Add tests.
719
720 2013-05-06  David Kilzer  <ddkilzer@apple.com>
721
722         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
723         <http://webkit.org/b/115667>
724
725         Reviewed by Dirk Pranke.
726
727         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
728         (Bugzilla._check_create_bug_response): Update regex to work with
729         Bugzilla 3.2.3 and 4.2.5.
730         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
731         (test__check_create_bug_response): Add new test that covers both
732         old and new <title> variations.
733
734 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
735
736         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
737         https://bugs.webkit.org/show_bug.cgi?id=115661
738
739         Reviewed by Ryosuke Niwa.
740
741         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
742         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
743         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
744
745         * TestResultServer/static-dashboards/flakiness_dashboard.js:
746         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
747
748 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
749
750         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
751         https://bugs.webkit.org/show_bug.cgi?id=114603
752
753         Reviewed by Ryosuke Niwa.
754
755         * TestResultServer/generate_builders_json.py:
756         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
757         to represent these to be 'layout-test', for backwards compatibility.
758         (main): Remove all the build.chromium.org masters.
759         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
760         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
761         (GenerateBuildersJsonTest):
762         (GenerateBuildersJsonTest.test_generate_json_data):
763         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
764         test-running builders from the webkit.org master.
765
766 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
767
768         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
769         https://bugs.webkit.org/show_bug.cgi?id=114988
770
771         Reviewed by Ryosuke Niwa.
772
773         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
774         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
775         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
776         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
777         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
778
779 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
780
781         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
782         https://bugs.webkit.org/show_bug.cgi?id=114954
783
784         Reviewed by Ryosuke Niwa.
785
786         * TestResultServer/static-dashboards/flakiness_dashboard.js:
787         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
788         modifier unions in the list of modifiers.
789         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
790         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
791
792 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
793
794         [Flakiness Dashboard] Simplify builder-name-based platform recognition
795         https://bugs.webkit.org/show_bug.cgi?id=114957
796
797         Reviewed by Ryosuke Niwa.
798
799         * TestResultServer/static-dashboards/flakiness_dashboard.js:
800         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
801         (chromiumPlatform): Removed, unnecessary.
802         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
803         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
804         the builder operates with debug builds, no webkit.org builders are named this way.
805         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
806         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
807
808 2013-05-06  Andy Estes  <aestes@apple.com>
809
810         Added two files I neglected to commit in r149589.
811
812         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
813         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
814
815 2013-05-04  Andy Estes  <aestes@apple.com>
816
817         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
818         https://bugs.webkit.org/show_bug.cgi?id=115609
819
820         Reviewed by Oliver Hunt.
821
822         Added an API test.
823
824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
825         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
826         (+[TestDelegate shared]):
827         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
828         (-[TestDelegate webView:createWebViewWithRequest:]):
829         (TestWebKitAPI):
830         (TestWebKitAPI::TEST):
831         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
832
833 2013-05-06  Antoine Quint  <graouts@apple.com>
834
835         Manage the presentation of the snapshotted plug-in using JavaScript
836         https://bugs.webkit.org/show_bug.cgi?id=115548
837
838         Reviewed by Dean Jackson.
839
840         Take into account the new plugInExtraScript method added to support
841         the injection of a JS file from the chrome client to customize the
842         rendering of a snapshotted plug-in's shadow tree.
843
844         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
845         (WTR::InjectedBundlePage::InjectedBundlePage):
846
847 2013-05-05  Anders Carlsson  <andersca@apple.com>
848
849         Remove the Vector::append overload that takes a Vector
850         https://bugs.webkit.org/show_bug.cgi?id=115535
851
852         Reviewed by Andreas Kling.
853
854         Use Vector::appendVector instead.
855
856         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
857         (concatenateAttributeAndValue):
858         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
859         (WTR::concatenateAttributeAndValue):
860
861 2013-05-04  Sam Weinig  <sam@webkit.org>
862
863         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
864         <rdar://problem/13702008>
865         https://bugs.webkit.org/show_bug.cgi?id=115607
866
867         Reviewed by Benjamin Poulain.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
871         (TestWebKitAPI::didFinishLoadForFrame):
872         (TestWebKitAPI::TEST):
873         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
874
875 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
876
877         Unreviewed.
878
879         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
880
881 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
882
883         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
888
889         [GTK] Catch select.error exceptions in parse_output_lines
890         https://bugs.webkit.org/show_bug.cgi?id=115253
891
892         Reviewed by Gustavo Noronha Silva.
893
894         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
895         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
896         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
897         error code and the error message) and the loop is re-entered.
898
899         * gtk/common.py:
900         (parse_output_lines):
901
902 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
903
904         [GTK] Set up the TestWebCore in TestWebKitAPI
905         https://bugs.webkit.org/show_bug.cgi?id=115237
906
907         Reviewed by Gustavo Noronha Silva.
908
909         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
910         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
911         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
912         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
913         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
914
915         * TestWebKitAPI/GNUmakefile.am:
916
917 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
918
919         Create a script to import W3C tests
920         https://bugs.webkit.org/show_bug.cgi?id=111513
921
922         Reviewed by Dirk Pranke.
923
924         Script to automate the import of W3C tests into WebKit. 
925         For the full description of how it works, see the comments
926         at the top of test_importer.py.
927
928         * Scripts/import-w3c-tests: Added.
929         * Scripts/webkitpy/w3c/__init__.py: Added.
930         * Scripts/webkitpy/w3c/test_converter.py: Added.
931         (TestConverter):
932         (TestConverter.__init__):
933         (TestConverter.load_prefixed_prop_list):
934         (TestConverter.load_file):
935         (TestConverter.convert_for_webkit):
936         (TestConverter.convert_testharness_paths):
937         (TestConverter.convert_prefixed_properties):
938         (TestConverter.scrub_unprefixed_props):
939         (TestConverter.replace_tag):
940         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
941         (TestConverterTest):
942         (TestConverterTest.testLoadPrefixedPropList):
943         (TestConverterTest.test_convertForWebkitNothingToConvert):
944         (test_convertForWebkitHarnessOnly):
945         (test_convertForWebkitPropsOnly):
946         (test_convertForWebkitHarnessAndProps):
947         (test_convertTestHarnessPaths):
948         (test_convertPrefixedProperties):
949         (verifyTestHarnessPaths):
950         (verifyPrefixedProperties):
951         (generateTestContent):
952         * Scripts/webkitpy/w3c/test_importer.py: Added.
953         (main):
954         (parse_args):
955         (validate_import_directory):
956         (TestImporter):
957         (TestImporter.__init__):
958         (TestImporter.do_import):
959         (TestImporter.get_changeset):
960         (TestImporter.scan_source_directory):
961         (TestImporter.import_tests):
962         (TestImporter.setup_destination_directory):
963         (TestImporter.get_test_status):
964         (TestImporter.remove_deleted_files):
965         (TestImporter.write_import_log):
966         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
967         (TestImporterTest):
968         (TestImporterTest.test_ImportDirWithNoTests):
969         * Scripts/webkitpy/w3c/test_parser.py: Added.
970         (TestParser):
971         (TestParser.__init__):
972         (TestParser.load_file):
973         (TestParser.analyze_test):
974         (TestParser.get_reftests):
975         (TestParser.is_jstest):
976         (TestParser.get_support_files):
977         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
978         (TestParserTest):
979         (TestParserTest.test_analyzeTestReftestOneMatch):
980         (test_analyzeTestReftestMultipleMatches):
981         (test_analyzeTestReftestMatchAndMismatch):
982         (test_analyzeTestReftestWithRefSupportFiles):
983         (test_analyzeJSTest):
984         (test_analyzePixelTestAllTrue):
985         (test_analyzePixelTestAllFalse):
986         (test_analyzeNonHTMLFile):
987
988 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
989
990         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
991
992         * Scripts/webkitpy/common/config/contributors.json:
993
994 2013-05-02  Nico Weber  <thakis@chromium.org>
995
996         Remove a stale script file.
997         https://bugs.webkit.org/show_bug.cgi?id=115521
998
999         Reviewed by Anders Carlsson.
1000
1001         This script was added in
1002         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
1003         Bakefile system that was removed in
1004         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
1005         script just asserts when it's run and is useless.
1006
1007         * Scripts/update-sources-list.py: Removed.
1008
1009 2013-05-01  Glenn Adams  <glenn@skynav.com>
1010
1011         [webkitpy] Need abstract base class for commands that analyze commit logs
1012         https://bugs.webkit.org/show_bug.cgi?id=115391
1013
1014         Reviewed by Benjamin Poulain.
1015
1016         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
1017         in preparation for adding two new commands that will reuse this functionality along with
1018         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
1019         https://bugs.webkit.org/show_bug.cgi?id=115388.
1020
1021         No new tests as this patch does not change existing functionality or behavior.
1022
1023         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1024         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
1025         (AbstractCommitLogCommand.__init__):
1026         (AbstractCommitLogCommand._init_options):
1027         (AbstractCommitLogCommand._parse_commit_message):
1028         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
1029         (SuggestNominations.__init__): 
1030         (SuggestNominations._init_options):
1031
1032 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
1033
1034         Web Inspector: Fix check-inspector-strings script and fix localized strings
1035         https://bugs.webkit.org/show_bug.cgi?id=115495
1036
1037         Reviewed by Joseph Pecoraro.
1038
1039         * Scripts/check-inspector-strings:
1040
1041 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
1042
1043         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
1044         https://bugs.webkit.org/show_bug.cgi?id=115470
1045
1046         Reviewed by Martin Robinson.
1047
1048         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
1049         not building either of the IOS, Windows or GTK-WK1 platforms.
1050
1051         Up until now the header was included for everything but the IOS and Windows platforms due to
1052         an incorrectly stated condition regarding the GTK platform.
1053
1054         * TestWebKitAPI/config.h:
1055
1056 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
1057
1058         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
1059         https://bugs.webkit.org/show_bug.cgi?id=115469
1060
1061         Reviewed by Martin Robinson.
1062
1063         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
1064         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
1065         for the WebKit2 tests and the injected bundle required by them.
1066
1067         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
1068         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
1069         under the WebKit2 code).
1070
1071         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
1072         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
1073         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
1074
1075         * TestWebKitAPI/GNUmakefile.am:
1076
1077 2013-04-30  Glenn Adams  <glenn@skynav.com>
1078
1079         Unreviewed. Add myself to watchlist entries.
1080
1081         * Scripts/webkitpy/common/config/watchlist:
1082
1083 2013-04-30  Glenn Adams  <glenn@skynav.com>
1084
1085         [webkitpy] suggest-nominations doesn't count all qualified patches
1086         https://bugs.webkit.org/show_bug.cgi?id=115285
1087
1088         Reviewed by Benjamin Poulain.
1089
1090         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
1091         nomination. Improve commit log parsing.
1092
1093         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1094         (CommitLogError):
1095         (CommitLogError.__init__):
1096         (CommitLogMissingReviewer):
1097         (CommitLogMissingReviewer.__init__):
1098         (SuggestNominations):
1099         (SuggestNominations.__init__):
1100         (SuggestNominations._recent_commit_messages):
1101         (SuggestNominations._author_name_from_email):
1102         (SuggestNominations._contributor_from_email):
1103         (SuggestNominations._parse_commit_message):
1104         (SuggestNominations._count_commit):
1105         (SuggestNominations._count_recent_patches):
1106         (SuggestNominations._collect_nominations):
1107         (SuggestNominations._print_nominations):
1108         (SuggestNominations.execute):
1109         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1110         (_make_options):
1111         (test_recent_commit_messages):
1112         (test_basic):
1113
1114 2013-04-30  Commit Queue  <rniwa@webkit.org>
1115
1116         Unreviewed, rolling out r149309.
1117         http://trac.webkit.org/changeset/149309
1118         https://bugs.webkit.org/show_bug.cgi?id=115430
1119
1120         The patch does not build on WK1-only builds of the GTK port
1121         (Requested by zdobersek on #webkit).
1122
1123         * TestWebKitAPI/GNUmakefile.am:
1124
1125 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1126
1127         Stop using "in" keyword in IDL files
1128         https://bugs.webkit.org/show_bug.cgi?id=115418
1129
1130         Reviewed by Kentaro Hara.
1131
1132         Remove "in" keyword from IDL files as this is no longer part of the Web
1133         IDL specification.
1134
1135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1136         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1137         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1138         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1139         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1140         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
1141         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1142         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1143
1144 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1145
1146         [EFL] Enable scaled cursors
1147         https://bugs.webkit.org/show_bug.cgi?id=106242
1148
1149         Reviewed by Gyuyoung Kim.
1150
1151         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
1152
1153         * Scripts/webkitperl/FeatureList.pm:
1154
1155 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1156
1157         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
1158         https://bugs.webkit.org/show_bug.cgi?id=115380
1159
1160         Reviewed by Kentaro Hara.
1161
1162         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
1163         keyword.
1164
1165         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1166         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1167
1168 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1169
1170         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
1171         https://bugs.webkit.org/show_bug.cgi?id=114684
1172
1173         Reviewed by Simon Hausmann.
1174
1175         Remove the ANGLE requirement for USE(3D_GRAPHICS).
1176         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
1177
1178         * qmake/mkspecs/features/features.prf:
1179
1180 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1181
1182         [GTK] Disable Shadow DOM feature
1183         https://bugs.webkit.org/show_bug.cgi?id=115374
1184
1185         Reviewed by Martin Robinson.
1186
1187         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
1188
1189         * Scripts/webkitperl/FeatureList.pm:
1190
1191 2013-04-29  Glenn Adams  <glenn@skynav.com>
1192
1193         [webkitpy] Add missing contributor email addresses
1194         https://bugs.webkit.org/show_bug.cgi?id=115394
1195
1196         Reviewed by Ryosuke Niwa.
1197
1198         * Scripts/webkitpy/common/config/contributors.json:
1199
1200 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
1201
1202         Remove all remaining Skia code
1203         https://bugs.webkit.org/show_bug.cgi?id=115263
1204
1205         Reviewed by Benjamin Poulain.
1206
1207         Remove all remaining references to Skia.
1208
1209         * Scripts/webkitdirs.pm:
1210         (blackberryCMakeArguments):
1211         * Scripts/webkitpy/common/config/contributionareas.py:
1212         * Scripts/webkitpy/common/config/watchlist:
1213
1214 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
1215
1216         Get rid of unused options in Tools/Scripts/webkit-build-directory
1217         https://bugs.webkit.org/show_bug.cgi?id=115383
1218
1219         Reviewed by Darin Adler.
1220
1221         * Scripts/webkit-build-directory:
1222
1223 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1224
1225         [WK2][Mac] Test with NetworkProcess enabled.
1226
1227         Fix the build for non-Mac.
1228
1229         * WebKitTestRunner/TestController.cpp:
1230         (WTR::TestController::initialize):
1231
1232 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1233
1234         [WK2][Mac] Test with NetworkProcess enabled.
1235
1236         Reviewed by Sam Weinig.
1237
1238         * WebKitTestRunner/TestController.cpp:
1239         (WTR::TestController::initialize):
1240
1241 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1242
1243         [GTK] Set up the TestWebCore in TestWebKitAPI
1244         https://bugs.webkit.org/show_bug.cgi?id=115237
1245
1246         Reviewed by Gustavo Noronha Silva.
1247
1248         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
1249         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
1250         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
1251         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
1252         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
1253
1254         * TestWebKitAPI/GNUmakefile.am:
1255
1256 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1257
1258         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
1259         https://bugs.webkit.org/show_bug.cgi?id=115236
1260
1261         Reviewed by Gustavo Noronha Silva.
1262
1263         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
1264         under the TestWebKitAPI/Tests/JavaScriptCore directory.
1265
1266         * TestWebKitAPI/GNUmakefile.am:
1267
1268 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1269
1270         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
1271         https://bugs.webkit.org/show_bug.cgi?id=115323
1272
1273         Reviewed by Philippe Normand.
1274
1275         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
1276         Its presence enforces linkers to output mangled symbols when reporting linking failures
1277         due to unresolved references. People trying to fix the build can then simply copy
1278         the printed mangled symbol into the symbols.filter file instead of doing a manual build
1279         or connecting to the builders to discover the mangled version of the missing symbol.
1280
1281         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1282
1283 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1284
1285         Remove Chromium code from Tools/BuildSlaveSupport
1286         https://bugs.webkit.org/show_bug.cgi?id=115325
1287
1288         Reviewed by Benjamin Poulain.
1289
1290         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
1291         covering archiving test results and built products.
1292
1293         * BuildSlaveSupport/built-product-archive:
1294         (archiveBuiltProduct):
1295         (extractBuiltProduct):
1296         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
1297         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
1298         * BuildSlaveSupport/test-result-archive:
1299         (archiveTestResults):
1300
1301 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
1302
1303         Remove support for Chromium from webkitdirs.pm
1304         https://bugs.webkit.org/show_bug.cgi?id=115338
1305
1306         Reviewed by Darin Adler.
1307
1308         * Scripts/webkitdirs.pm:
1309         (determineBaseProductDir):
1310         (argumentsForConfiguration):
1311         (builtDylibPathForName):
1312         (determineIsQt):
1313         (isAppleWebKit):
1314
1315 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1316
1317         Rename TestRunner's setAudioData to setAudioResult
1318         https://bugs.webkit.org/show_bug.cgi?id=115326
1319
1320         Reviewed by Darin Adler.
1321
1322         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
1323         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
1324         affected tests are adjusted accordingly.
1325
1326         * DumpRenderTree/qt/TestRunnerQt.cpp:
1327         (TestRunnerQt::setAudioResult):
1328         * DumpRenderTree/qt/TestRunnerQt.h:
1329         (TestRunnerQt):
1330         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1331         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1332         (WTR::TestRunner::setAudioResult):
1333         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1334         (TestRunner):
1335
1336 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1337
1338         [WKTR] Tests dumping audio data shouldn't dump pixels
1339         https://bugs.webkit.org/show_bug.cgi?id=115270
1340
1341         Reviewed by Benjamin Poulain.
1342
1343         Prevent dumping the pixel output when Web Audio tests are dumping output data
1344         as the testing output. Pixel output in these tests has no real meaning and is
1345         as such unnecessary.
1346
1347         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1348         (WTR::TestRunner::setAudioData):
1349
1350 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1351
1352         [EFL] Unreviewed Intel bots fix after r149231.
1353
1354         * efl/jhbuild.modules: Disable the libxml Python bindings since the
1355         bots don't have Python's development files installed. libxml should
1356         detect this kind of thing better.
1357
1358 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
1359
1360         [EFL] Build break using jhbuild on ubuntu 13.04
1361         https://bugs.webkit.org/show_bug.cgi?id=115225
1362
1363         Reviewed by Gyuyoung Kim.
1364
1365         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
1366         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
1367         So this patch bumped libxml version to 2.9.1.
1368
1369         * efl/jhbuild.modules:
1370
1371 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
1372
1373         delete-stale-build-files does not clear .d files
1374         http://bugs.webkit.org/show_bug.cgi?id=115293
1375
1376         Reviewed by Ryosuke Niwa.
1377
1378         * BuildSlaveSupport/delete-stale-build-files:
1379         (main): Add .d to the file type list
1380
1381 2013-04-26  Roger Fong  <roger_fong@apple.com>
1382
1383         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
1384         Make the DebugSuffix configuration use _debug dependencies.
1385
1386         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1387         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
1388         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1389         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1390         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1391         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1392         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
1393         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1394         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1395         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1396         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
1397         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1398         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1399         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1400         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1401         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1402         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1403         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1404         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1405         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
1406         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1407         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1408         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1409         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1410         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1411         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1412         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
1413         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1414         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1415         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1416         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1417         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1418         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1419         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
1420         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1421         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1422         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1423         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1424         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1425         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1426         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1427         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1428         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1429         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
1430         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1431         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1432         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1433         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1434         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1435         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1436         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1437         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1438         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1439         * win/AssembleBuildLogs/AssembleLogs.cmd:
1440         * win/record-memory/record-memory.vcxproj:
1441         * win/record-memory/record-memoryDebug.props:
1442         * win/record-memory/record-memoryDebugWinCairo.props:
1443         * win/record-memory/record-memoryProduction.props:
1444         * win/record-memory/record-memoryRelease.props:
1445         * win/record-memory/record-memoryReleaseWinCairo.props:
1446
1447 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1448
1449         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
1450         https://bugs.webkit.org/show_bug.cgi?id=115233
1451
1452         Reviewed by Martin Robinson.
1453
1454         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
1455         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
1456         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
1457         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
1458         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
1459
1460         * TestWebKitAPI/GNUmakefile.am:
1461
1462 2013-04-25  Andy Estes  <aestes@apple.com>
1463
1464         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
1465         https://bugs.webkit.org/show_bug.cgi?id=115223
1466
1467         Reviewed by Darin Adler.
1468
1469         Added an API test.
1470
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1472         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
1473         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
1474         when it loads a request with a custom protocol.
1475         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
1476         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
1477         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
1478         miscellaneous cleanup.
1479         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
1480         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
1481         (+[TestProtocol canInitWithRequest:]):
1482         (+[TestProtocol canonicalRequestForRequest:]):
1483         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1484         (+[TestProtocol scheme]):
1485         (-[TestProtocol startLoading]):
1486         (-[TestProtocol stopLoading]):
1487
1488 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1489
1490         Remove the remaining Skia #ifdefs
1491         https://bugs.webkit.org/show_bug.cgi?id=114886
1492
1493         Reviewed by Benjamin Poulain.
1494
1495         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1496         (createBitmapContextFromWebView): Remove Skia #ifdef references.
1497
1498 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1499
1500         [BlackBerry] Clean up load interface in WebPage
1501         https://bugs.webkit.org/show_bug.cgi?id=113267
1502
1503         Reviewed by Rob Buis.
1504
1505         Update DumpRenderTree with change of load() interface in WebPage.
1506         RIM Bug# 315535, internally reviewed by Joe Mason.
1507
1508         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1509         (BlackBerry::WebKit::DumpRenderTree::runTest):
1510
1511 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1512
1513         Remove the HeapGraphSerializer unit test
1514         https://bugs.webkit.org/show_bug.cgi?id=115231
1515
1516         Reviewed by Andreas Kling.
1517
1518         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
1519         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
1520
1521         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1522
1523 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1524
1525         Remove support for Chromium from build/update scripts
1526         https://bugs.webkit.org/show_bug.cgi?id=115218
1527
1528         Reviewed by Darin Adler.
1529
1530         * Scripts/build-webkit:
1531         (writeCongrats):
1532         * Scripts/update-webkit:
1533
1534 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1535
1536         Remove support for Chromium from api-test
1537         https://bugs.webkit.org/show_bug.cgi?id=115211
1538
1539         Reviewed by Dirk Pranke.
1540
1541         * Scripts/build-api-tests:
1542         * Scripts/run-api-tests:
1543         (isSupportedPlatform):
1544
1545 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1546
1547         Get rid of Chromium in build-dumprendertree
1548         https://bugs.webkit.org/show_bug.cgi?id=115212
1549
1550         Reviewed by Dirk Pranke.
1551
1552         * Scripts/build-dumprendertree:
1553
1554 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
1555
1556         Pass relatedPage when creating a page in WebKitTestRunner
1557         https://bugs.webkit.org/show_bug.cgi?id=115206
1558
1559         Reviewed by Geoffrey Garen.
1560
1561         To make sure that window.open() opens in the same process even when using multiple processes.
1562
1563         * WebKitTestRunner/PlatformWebView.h:
1564         * WebKitTestRunner/TestController.cpp:
1565         (WTR::TestController::createOtherPage):
1566         (WTR::TestController::createWebViewWithOptions):
1567         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1568         (WTR::PlatformWebView::PlatformWebView):
1569         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1570         (WTR::PlatformWebView::PlatformWebView):
1571         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1572         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1573         (WTR::PlatformWebView::PlatformWebView):
1574         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1575         (WTR::PlatformWebView::PlatformWebView):
1576         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1577         (WTR::PlatformWebView::PlatformWebView):
1578
1579 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1580
1581         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
1582
1583         * Scripts/webkitpy/common/config/contributors.json:
1584
1585 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1586
1587         Build fix. Forgot to merge args.
1588
1589         * Scripts/webkitpy/tool/bot/irc_command.py:
1590         (Hi.execute):
1591
1592 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1593
1594         webkitbot should recognize its own nickname in greetings.
1595         https://bugs.webkit.org/show_bug.cgi?id=115196
1596
1597         Reviewed by Andreas Kling.
1598
1599         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
1600
1601         * Scripts/webkitpy/tool/bot/irc_command.py:
1602         (Hi.execute):
1603
1604 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
1605
1606         [GTK] Tools/gtk/install-dependencies added ragel dependency
1607         https://bugs.webkit.org/show_bug.cgi?id=115163
1608
1609         Reviewed by Xan Lopez.
1610
1611         The install-dependencies script was missing a dependency on ragel
1612         which is expected when building HarfBuzz.
1613
1614         * gtk/install-dependencies: Added a dependency on ragel for both
1615         apt and yum.
1616
1617 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
1618
1619         [GTK] Remove pango from optional jhbuild dependencies
1620         https://bugs.webkit.org/show_bug.cgi?id=115162
1621
1622         Reviewed by Martin Robinson.
1623
1624         Pango is not needed since revision r148293 that lowers the pango
1625         dependency to 1.30, which is available in most distributions.
1626
1627         * gtk/jhbuild-optional.modules: Removes description of pango module.
1628
1629 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1630
1631         Remove Chromium-specific cases from FeatureList.pm
1632         https://bugs.webkit.org/show_bug.cgi?id=115169
1633
1634         Reviewed by Andreas Kling.
1635
1636         * Scripts/webkitperl/FeatureList.pm:
1637
1638 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1639
1640         Remove checking chromium from run-webkit-tests
1641         https://bugs.webkit.org/show_bug.cgi?id=115139
1642
1643         Reviewed by Benjamin Poulain.
1644
1645         * Scripts/run-webkit-tests:
1646         (useNewRunWebKitTests):
1647
1648 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
1649
1650         Pixel tests in SVG are all broken in WK2
1651         https://bugs.webkit.org/show_bug.cgi?id=114218
1652
1653         Reviewed by Darin Adler.
1654         
1655         Window snapshots in WebKitTestRunner on Mac are window-sized
1656         (800x600), which is wrong for the W3C SVG tests that require a
1657         480x360 snapshot.
1658         
1659         Fix by resizing the window, as well as the web view in
1660         PlatformWebView::resizeTo() so that window snapshots are correctly
1661         sized.
1662         
1663         Also do some drive-by cleanup of the window size constants in both
1664         DRT and WTR to remove magic numbers, and make the code more similar.
1665         
1666         * DumpRenderTree/TestRunner.cpp:
1667         (TestRunner::setShouldPaintBrokenImage):
1668         * DumpRenderTree/TestRunner.h:
1669         * DumpRenderTree/efl/DumpRenderTree.cpp:
1670         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1671         (webInspectorShowWindow):
1672         * DumpRenderTree/mac/DumpRenderTree.mm:
1673         (createWebViewAndOffscreenWindow):
1674         (sizeWebViewForCurrentTest):
1675         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1676         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1677         (createPagedBitmapContext):
1678         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1679         (DumpRenderTree::DumpRenderTree):
1680         (DumpRenderTree::open):
1681         * DumpRenderTree/qt/TestRunnerQt.cpp:
1682         * DumpRenderTree/qt/TestRunnerQt.h:
1683         * DumpRenderTree/win/DumpRenderTree.cpp:
1684         (sizeWebViewForCurrentTest):
1685         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1686         * WebKitTestRunner/TestController.cpp:
1687         (WTR::TestController::resetStateToConsistentValues):
1688         * WebKitTestRunner/TestController.h:
1689         * WebKitTestRunner/TestInvocation.cpp:
1690         (WTR::sizeWebViewForCurrentTest):
1691         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1692         (WTR::PlatformWebView::PlatformWebView):
1693         (WTR::PlatformWebView::resizeTo):
1694
1695 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
1696
1697         [EFL] Fix build error after r148963.
1698         https://bugs.webkit.org/show_bug.cgi?id=115126
1699
1700         Reviewed by Laszlo Gombos.
1701
1702         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
1703
1704         * TestWebKitAPI/PlatformEfl.cmake:
1705
1706 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         [GTK] Use stamp files for generate-forwarding-headers makefile rules
1709         https://bugs.webkit.org/show_bug.cgi?id=115118
1710
1711         Reviewed by Martin Robinson.
1712
1713         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
1714         forwarding generator rules and don't call it for soup since there
1715         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
1716
1717         * TestWebKitAPI/GNUmakefile.am:
1718         * WebKitTestRunner/GNUmakefile.am:
1719
1720 2013-04-24  Simon Pena  <simon.pena@samsung.com>
1721
1722         [GTK] Update build dependencies
1723         https://bugs.webkit.org/show_bug.cgi?id=115111
1724
1725         Reviewed by Martin Robinson.
1726
1727         The install-dependencies script was missing a dependency on EGL,
1728         which is expected when building Cairo.
1729
1730         * gtk/install-dependencies: Added a dependency on libegl1-mesa
1731         for both apt and yum.
1732
1733 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1734
1735         Remove the Chromium-specific helper from run_webkit_tests.py
1736         https://bugs.webkit.org/show_bug.cgi?id=114996
1737
1738         Reviewed by Dirk Pranke.
1739
1740         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1741         (parse_args):
1742
1743 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
1744
1745         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
1746         https://bugs.webkit.org/show_bug.cgi?id=114850
1747
1748         Reviewed by Andreas Kling.
1749
1750         Revision r148312 fixed WebPageProxy cleanup and also changed the process
1751         termination semantics when requested by the user so that a client is not
1752         notified of a crash anymore, since there was no crash anyway.
1753
1754         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
1755         relied on being notified of a crash after calling WKPageTerminate(). As
1756         a result of not being notified of such non-existent crash, the test would
1757         timeout right after making the terminate call.
1758
1759         This patch adds an InjectedBundle to be used for simulating a crash, by
1760         calling abort() upon receiving a "Crash" message, and thus we are able to
1761         keep testing the crash callback.
1762
1763         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
1764         had been disabled in revisions r148858 and r148855, since it was failing.
1765
1766         * TestWebKitAPI/PlatformEfl.cmake:
1767         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
1770         (TestWebKitAPI):
1771         (WKViewClientWebProcessCallbacksTest):
1772         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
1773         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
1774
1775 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1776
1777         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
1778         https://bugs.webkit.org/show_bug.cgi?id=115095
1779
1780         Reviewed by Antonio Gomes.
1781
1782         Use different subfolders under DumpRenderTree Temp folder for every
1783         functionality (icon database, cache, localstorage, ...). This makes
1784         sure there is no conflict between the functionalities.
1785
1786         In EFL's case, libsoup cache was causing problems for the icon
1787         database if sharing the same folder.
1788
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::TestController::initialize):
1791
1792 == Rolled over to ChangeLog-2013-04-24 ==