a9c6e085fea96a9e228de837dde455c04d3f7bf0
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-07  Tony Payne  <tpayne@chromium.org>
2
3         [chromium] Allow LayoutTests under new git workflow
4         https://bugs.webkit.org/show_bug.cgi?id=88575
5
6         On Windows, chromium indirects through git.bat. Adds the same hack that
7         is currently used for discovering svn.bat to support the new git
8         workflow.
9
10         Reviewed by Dirk Pranke.
11
12         * Scripts/webkitpy/common/checkout/scm/git.py:
13         (Git): Replaces all hard-coded references to 'git' with the class
14         variable executable_name.
15         (Git._check_git_architecture):
16         (Git.in_working_directory):
17         (Git.find_checkout_root):
18         (Git.read_git_config):
19         (Git.discard_local_commits):
20         (Git.local_commits):
21         (Git.working_directory_is_clean):
22         (Git.clean_working_directory):
23         (Git.status_command):
24         (Git.add_list):
25         (Git.delete_list):
26         (Git.exists):
27         (Git._current_branch):
28         (Git.changed_files):
29         (Git._changes_files_for_commit):
30         (Git.revisions_changing_file):
31         (Git.conflicted_files):
32         (Git.svn_revision):
33         (Git.create_patch):
34         (Git._run_git_svn_find_rev):
35         (Git.contents_at_revision):
36         (Git.diff_for_file):
37         (Git.show_head):
38         (Git.committer_email_for_revision):
39         (Git.apply_reverse_diff):
40         (Git.revert_files):
41         (Git.commit_with_message):
42         (Git._commit_on_branch):
43         (Git.svn_commit_log):
44         (Git.last_svn_commit_log):
45         (Git.svn_blame):
46         (Git._branch_ref_exists):
47         (Git.delete_branch):
48         (Git.remote_merge_base):
49         (Git.commit_locally_with_message):
50         (Git.push_local_commits_to_server):
51         (Git.commit_ids_from_commitish_arguments):
52         (Git.commit_message_for_local_commit):
53         (Git.files_changed_summary_for_commit):
54         * Scripts/webkitpy/common/host.py:
55         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
56         that duplicates the logic in the existing 'svn.bat' hack.
57
58 2012-06-07  Ojan Vafai  <ojan@chromium.org>
59
60         Style build architectures like build versions for non-layout test failures
61         https://bugs.webkit.org/show_bug.cgi?id=88590
62
63         Reviewed by Tony Chang.
64
65         Since we show the list of failing tests after the architecture, we want the
66         buildtype and architecture to be grouped together visually.
67
68         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
69         (.effects a.failing-builder>span.architecture):
70
71 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
72
73         [Chromium] Remove header dependency of ImageDiff to WTF
74         https://bugs.webkit.org/show_bug.cgi?id=88422
75
76         Reviewed by Ryosuke Niwa.
77
78         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
79         * DumpRenderTree/chromium/ImageDiff.cpp:
80         (untestedCompareImages):
81
82 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
83
84         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
85         https://bugs.webkit.org/show_bug.cgi?id=88491
86
87         Reviewed by Dirk Pranke.
88
89         DRT should enable WebAudio when WebAudio feature is enabled,
90         so that the WebAudio feature could be tested by the Layouttest.
91
92         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
93         (LayoutTestController::overridePreference):
94
95 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
96
97         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
98         https://bugs.webkit.org/show_bug.cgi?id=88581
99
100         Reviewed by Ojan Vafai.
101
102         webkit-paptch rebaseline-expectations was ignoring what the
103         expected results for a test were and pulling down all the result
104         files from a bot. This could lead to us pulling down old,
105         incorrect .txt or .png files. With this patch we will now only
106         pull down expectations of the appropriate file types (so an
107         IMAGE failure will only pull the png and not the txt file).
108
109         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
110         (has_pixel_failures):
111         (suffixes_for_expectations):
112         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
113         (FunctionsTest.test_suffixes_for_expectations):
114         * Scripts/webkitpy/tool/commands/rebaseline.py:
115         (AbstractRebaseliningCommand.__init__):
116         (RebaselineExpectations._is_supported_port):
117         (RebaselineExpectations._update_expectations_file):
118         (RebaselineExpectations._tests_to_rebaseline):
119         (RebaselineExpectations._rebaseline_port):
120         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
121         (test_overrides_are_included_correctly):
122
123 2012-06-07  Ojan Vafai  <ojan@chromium.org>
124
125         Fix recent null pointer error regression in the flakiness dashboard
126         https://bugs.webkit.org/show_bug.cgi?id=88573
127
128         Reviewed by Dirk Pranke.
129
130         * TestResultServer/static-dashboards/builders.js:
131         (requestBuilderList):
132         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
133
134 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
135
136         Add Konrad Piascik to committers.py
137         https://bugs.webkit.org/show_bug.cgi?id=88560
138
139         Unreviewed.
140
141         * Scripts/webkitpy/common/config/committers.py:
142
143 2012-06-07  Tony Chang  <tony@chromium.org>
144
145         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
146         https://bugs.webkit.org/show_bug.cgi?id=77368
147
148         Reviewed by Ojan Vafai.
149
150         It doesn't look like we ever get a rect with width or height of 0.
151         I ran css1, css2.1, fast/forms, and tables without any crashes.
152
153         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
154         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
155
156 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
157
158         run-webkit-tests --lint-test-files gives an error when run on linux
159         https://bugs.webkit.org/show_bug.cgi?id=88551
160
161         Reviewed by Ojan Vafai.
162
163         We weren't mapping the expectations properly for the
164         google-chrome ports.
165
166         * Scripts/webkitpy/layout_tests/port/base.py:
167         (Port.path_to_test_expectations_file):
168         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
169         (TestGoogleChromePort.test_path_to_expectations):
170
171 2012-06-07  Daniel Erat  <derat@chromium.org>
172
173         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
174         https://bugs.webkit.org/show_bug.cgi?id=88263
175
176         Reviewed by Tony Chang.
177
178         * DumpRenderTree/chromium/LayoutTestController.cpp:
179         (LayoutTestController::LayoutTestController):
180         (LayoutTestController::reset):
181         (LayoutTestController::setTextSubpixelPositioning):
182         * DumpRenderTree/chromium/LayoutTestController.h:
183         (LayoutTestController):
184         * DumpRenderTree/chromium/fonts.conf:
185
186 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
187
188         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
189         https://bugs.webkit.org/show_bug.cgi?id=88060
190
191         Reviewed by Martin Robinson.
192
193         Spin the main loop before acquiring the pixel content. This ensures things
194         like late size allocations are finished before calling gtk_widget_draw,
195         avoiding assertions and subsequent empty pixel results.
196
197         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
198         (createBitmapContextFromWebView):
199
200 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
201
202         [Qt] Improve the visual of the viewport info box
203         https://bugs.webkit.org/show_bug.cgi?id=88410
204
205         Reviewed by Tor Arne Vestbø.
206
207         Improve the visual and make it possible to see the content more easy.
208
209         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
210
211 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
212
213         [EFL][WK2] Compile webkit1 and webkit2 by default.
214         https://bugs.webkit.org/show_bug.cgi?id=85041
215
216         Reviewed by Chang Shu.
217
218         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
219         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
220
221         * Scripts/build-webkit:
222
223 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
224
225         Unreviewed, rolling out r119662.
226         http://trac.webkit.org/changeset/119662
227         https://bugs.webkit.org/show_bug.cgi?id=88487
228
229         Broke builds (Requested by rniwa on #webkit).
230
231         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
232         * DumpRenderTree/chromium/ImageDiff.cpp:
233         (untestedCompareImages):
234
235 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
236
237         [Chromium] Remove header dependency of ImageDiff to WTF
238         https://bugs.webkit.org/show_bug.cgi?id=88422
239
240         Reviewed by Adam Barth.
241
242         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
243         * DumpRenderTree/chromium/ImageDiff.cpp:
244         (untestedCompareImages):
245
246 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
247
248         [WebKit] DeviceOrientation cleanup
249         https://bugs.webkit.org/show_bug.cgi?id=88406
250
251         Reviewed by Kent Tamura.
252
253         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
254
255         * DumpRenderTree/chromium/LayoutTestController.cpp:
256         (LayoutTestController::setMockDeviceOrientation):
257
258 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
259
260         webkitpy: add support for an ordered dict of test expectations
261         https://bugs.webkit.org/show_bug.cgi?id=87802
262
263         Reviewed by Ojan Vafai.
264
265         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
266         support a cascaded list of test expectations files. An easy way
267         to think of this is as an ordered dictionary of name -> contents
268         for files, where the name is usually a path on disk (I say
269         usually because we want to support other kinds of expectations
270         like the compile-time skips for unsupported features in
271         webkit.py, and we want to continue to support "in-memory" test
272         expectations that don't require a filesystem).
273
274         Conveniently there is an OrderedDict implementation in Python
275         2.7+ and it is available as a backport, so the first step in
276         adding this support is to use that implementation. Subsequent
277         patches will update the test_expectations.py module (and other
278         callers) to access the dict directly.
279
280         This patch just changes the base internal implementation and
281         provides wrappers for compatibility. The derived ports
282         (WebKitPort, TestPort, etc.) still need to be updated.
283
284         * Scripts/webkitpy/layout_tests/port/base.py:
285         (Port._expectations_dict):
286         (Port.test_expectations):
287         (Port):
288         (Port._expectations_overrides_dict):
289         (Port.test_expectations_overrides):
290         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
291         (PortTestCase.test_expectations_ordering):
292         (PortTestCase):
293         (PortTestCase.test_expectations_overrides_ordering):
294         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
295         (OrderedDict):
296         (OrderedDict.__init__):
297         (OrderedDict.clear):
298         (OrderedDict.__setitem__):
299         (OrderedDict.__delitem__):
300         (OrderedDict.__iter__):
301         (OrderedDict.__reversed__):
302         (OrderedDict.popitem):
303         (OrderedDict.__reduce__):
304         (OrderedDict.__repr__):
305         (OrderedDict.copy):
306         (OrderedDict.fromkeys):
307
308 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
309
310         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
311
312         * gtk/run-api-tests:
313         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
314
315 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
316
317         nrwt should look in 'out' for binaries on chromium win to support ninja
318         https://bugs.webkit.org/show_bug.cgi?id=88273
319
320         Reviewed by Tony Chang.
321
322         This patch standardizes the search algorithm the chromium ports
323         use to figure out which driver to run. We will look in a
324         chromium location before a webkit location (e.g., in
325         Source/WebKit/chromium/out before out/) and we will look in the
326         "legacy" directory (xcodebuild) before the directory ninja uses
327         (out).
328
329         Unfortunately due to the way the test code is set up testing the
330         properly requires some duplication of test code. I will fix that
331         in a followup patch.
332
333         * Scripts/webkitpy/layout_tests/port/chromium.py:
334         (ChromiumPort):
335         (ChromiumPort._static_build_path):
336         (ChromiumPort._build_path):
337         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
338         (ChromiumLinuxPort):
339         (ChromiumLinuxPort._determine_driver_path_statically):
340         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
341         (ChromiumLinuxPortTest.test_build_path):
342         (ChromiumLinuxPortTest):
343         (ChromiumLinuxPortTest.test_driver_name_option):
344         (ChromiumLinuxPortTest.path_to_image_diff):
345         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
346         (ChromiumMacPort):
347         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
348         (ChromiumMacPortTest.test_build_path):
349         (ChromiumMacPortTest):
350         (ChromiumMacPortTest.test_driver_name_option):
351         (ChromiumMacPortTest.path_to_image_diff):
352         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
353         (ChromiumPortTest.test_overrides_and_builder_names):
354         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
355         (ChromiumWinPort):
356         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
357         (ChromiumWinTest.test_build_path):
358         (ChromiumWinTest.test_operating_system):
359         (ChromiumWinTest):
360         (ChromiumWinTest.test_driver_name_option):
361         (ChromiumWinPortTest.path_to_image_diff):
362         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
363         (PortTestCase.assert_build_path):
364
365 2012-06-06  Jessie Berlin  <jberlin@apple.com>
366
367         Remove very red Windows WebKit2 testers
368         https://bugs.webkit.org/show_bug.cgi?id=88452
369
370         Reviewed by Steve Falkenburg.
371
372         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
373         need to focus on getting the WK1 testers green.
374
375         * BuildSlaveSupport/build.webkit.org-config/config.json:
376
377 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
378
379         get rebaselining tools to kinda work with the skia overrides file
380         https://bugs.webkit.org/show_bug.cgi?id=88456
381
382         Reviewed by Ryosuke Niwa.
383
384         Update rebaseline-expectations so that we read in the overrides
385         when looking for tests to rebaseline, but don't read in the
386         overrides when we are writing the expectations file back out.
387         This prevents the overrides from getting written into the main
388         file. This is kind of a hack but will have to do until we
389         support multiple expectations files properly.
390
391         * Scripts/webkitpy/tool/commands/rebaseline.py:
392         (RebaselineExpectations._expectations):
393         (RebaselineExpectations._update_expectations_file):
394         (RebaselineExpectations._tests_to_rebaseline):
395         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
396         (test_overrides_are_included_correctly):
397
398 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
399
400         webkitpy: two manager_worker_broker_unittest tests are broken
401         https://bugs.webkit.org/show_bug.cgi?id=88445
402
403         Reviewed by Ojan Vafai.
404
405         These tests were never updated when we removed the
406         --worker-model argument, and we were passing 'inline' instead of
407         1 (for the number of workers) :(. As a result we were creating
408         multiprocessing queues unnecessarily and that was failing on cygwin.
409
410         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
411         (InterfaceTest.test_managerconnection_is_abstract):
412         (InterfaceTest.test_workerconnection_is_abstract):
413
414 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
415
416         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
417         https://bugs.webkit.org/show_bug.cgi?id=87406
418
419         Reviewed by Dirk Pranke.
420
421         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
422         (TestExpectations.__init__):
423         * Scripts/webkitpy/tool/commands/rebaseline.py:
424         (RebaselineTest._update_expectations_file):
425         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
426         (test_rebaseline_does_not_include_overrides):
427
428 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
429
430         webkitpy: perf tests unit tests fail on chromium win
431         https://bugs.webkit.org/show_bug.cgi?id=88279
432
433         Reviewed by Ryosuke Niwa.
434
435         I'm seeing weird failures running the unit tests in my win32
436         checkout, and we don't really expect webpagereplay to work on
437         win32 anyway, so I'm skipping the import of that module for now
438         and adding a warning.
439
440         * Scripts/run-perf-tests:
441         * Scripts/webkitpy/performance_tests/perftest.py:
442
443 2012-06-06  Yong Li <yoli@rim.com>
444
445         Unreviewed. Update my email address in committers.py.
446
447         * Scripts/webkitpy/common/config/committers.py:
448
449 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
450
451         Add Robert Kroeger  to commiters.py
452         https://bugs.webkit.org/show_bug.cgi?id=88415
453
454         Unreviewed.
455
456         * Scripts/webkitpy/common/config/committers.py:
457
458 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
459
460         [EFL][DRT] http/tests/globalhistory testcases do not pass
461         https://bugs.webkit.org/show_bug.cgi?id=82579
462
463         Reviewed by Csaba Osztrogonác.
464
465         DRT has provided callbacks for ewk_view "global history delegate" signals.
466
467         * DumpRenderTree/efl/DumpRenderTree.cpp:
468         (isGlobalHistoryTest): Aux function to ident global history testcase.
469         (createLayoutTestController):
470         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
471         (DumpRenderTreeChrome::createView):
472         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
473         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
474         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
475         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
476         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
477         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
478         (DumpRenderTreeChrome):
479
480 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
481
482         [Qt] run-qtwebkit-tests hangs with -j1
483         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
484         This could happen due to an uncancelled timer after results were returned. This timer was
485         started only if --timeout was set.
486         https://bugs.webkit.org/show_bug.cgi?id=85475
487
488         Reviewed by Csaba Osztrogonác.
489
490         * Scripts/run-qtwebkit-tests:
491         (run_test):
492
493 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
494
495         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
496         https://bugs.webkit.org/show_bug.cgi?id=88327
497
498         Reviewed by Kenneth Rohde Christiansen.
499
500         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
501         * MiniBrowser/qt/icons/contents_width.png: Added.
502         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
503         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
504
505 2012-06-05  Jon Lee  <jonlee@apple.com>
506
507         Buildbot fix.
508
509         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
510         in the function. Store in a local variable.
511         (loadBuilderConfig):
512
513 2012-06-05  Jon Lee  <jonlee@apple.com>
514
515         Buildbot fix.
516
517         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
518         (loadBuilderConfig):
519
520 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
521
522         webkitpy: clean up win-specific path handling and tests
523         https://bugs.webkit.org/show_bug.cgi?id=88281
524
525         Reviewed by Adam Barth.
526
527         There was a bunch of inconsistent logic for handling path
528         conversions for win32 and cygwin paths due to us sometimes
529         looking at sys.platform and sometimes using mock hosts. This
530         patch cleans everything up so that we are required to pass
531         PlatformInfo objects to the path module and stop trying to do
532         different things when running on cygwin or win32 hosts (except
533         in the path_unittest module itself).
534
535         This may slightly reduce test coverage for the win32 code paths
536         but will be a lot easier to follow and maintain.
537
538         * Scripts/webkitpy/common/system/path.py:
539         (abspath_to_uri):
540         (_convert_path):
541         * Scripts/webkitpy/common/system/path_unittest.py:
542         (AbspathTest.platforminfo):
543         (AbspathTest.test_abspath_to_uri_cygwin):
544         (AbspathTest.test_abspath_to_uri_unixy):
545         (AbspathTest.test_abspath_to_uri_win):
546         (AbspathTest.test_abspath_to_uri_escaping_unixy):
547         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
548         (AbspathTest.test_stop_cygpath_subprocess):
549         * Scripts/webkitpy/common/system/platforminfo.py:
550         (PlatformInfo.__init__):
551         (PlatformInfo.is_cygwin):
552         * Scripts/webkitpy/common/system/platforminfo_mock.py:
553         (MockPlatformInfo.is_cygwin):
554         * Scripts/webkitpy/layout_tests/port/base.py:
555         (Port.to.show_results_html_file):
556         * Scripts/webkitpy/layout_tests/port/driver.py:
557         (Driver.test_to_uri):
558         (Driver.uri_to_test):
559         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
560         (DriverTest.test_test_to_uri):
561         (DriverTest.test_uri_to_test):
562         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
563         (MockDRTPortTest.make_port):
564         (MockDRTTest.input_line):
565         (MockChromiumDRTTest.test_pixeltest__fails):
566         * Scripts/webkitpy/layout_tests/port/test.py:
567         * Scripts/webkitpy/layout_tests/port/win.py:
568         (WinPort.show_results_html_file):
569         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
570         (MainTest.test_unexpected_failures):
571         (MainTest.test_results_directory_absolute):
572         (MainTest.test_results_directory_default):
573         (MainTest.test_results_directory_relative):
574
575 2012-06-05  Jon Lee  <jonlee@apple.com>
576
577         Workaround buildbot bug when merging build requests.
578         https://bugs.webkit.org/show_bug.cgi?id=88158
579
580         Reviewed by Mark Rowe.
581
582         For expediency, we still want testers to pick the latest build to test, but to ensure
583         that the builders are reporting the correct revision number, we should let the building bots
584         run as they normally would. That is, the builder picks the oldest revision, and merges
585         subsequent requests. Because merged requests get appended to the list of changes for a given
586         build, the last change in that list is also the latest change. When we used pickLatestBuild
587         for the builders, this was not the case (it would always report the penultimate change).
588
589         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
590
591         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
592         for all Apple builders.
593         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
594         the latest build to run.
595         (loadBuilderConfig):
596
597 2012-06-05  Jessie Berlin  <jberlin@apple.com>
598
599         [Win] DumpRenderTree should call resetInternalsObject
600         https://bugs.webkit.org/show_bug.cgi?id=88346
601
602         Reviewed by Simon Fraser.
603
604         Invoke it on Windows in the same place it is invoked on Mac.
605
606         * DumpRenderTree/win/DumpRenderTree.cpp:
607         (resetWebViewToConsistentStateBeforeTesting):
608
609 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
610
611         [GTK] Fix two more memory leaks in DRT
612         https://bugs.webkit.org/show_bug.cgi?id=88255
613
614         Reviewed by Martin Robinson.
615
616         Fixed memory leaks in GTK's DRT code.
617
618         * DumpRenderTree/gtk/DumpRenderTree.cpp:
619         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
620         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
621         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
622         (createBitmapContextFromWebView): Free the cairo surface.
623
624 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
625
626         [Qt] Building when a top directory is named Source
627         https://bugs.webkit.org/show_bug.cgi?id=77727
628
629         Reviewed by Tor Arne Vestbø.
630
631         Change regex to only replace the last instance of OUT_PWD.
632
633         * qmake/mkspecs/features/default_pre.prf:
634
635 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
636
637         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
638         https://bugs.webkit.org/show_bug.cgi?id=73176
639
640         Reviewed by Adam Barth.
641
642         Two more APIs are added in Custom Scheme Handler specification.
643         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
644         One is 'isProtocolHandlerRegistered' to query whether the specific URL
645         is registered or not.
646         The other is 'unregisterProtocolHandler' to remove the registered URL.
647
648         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
649
650 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
651
652         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
653         https://bugs.webkit.org/show_bug.cgi?id=83879
654
655         Reviewed by Carlos Garcia Campos.
656
657         Make minibrowser connect to the new 'permission requests' signal
658         to allow users handle the Geolocation permission requests.
659
660         * MiniBrowser/gtk/BrowserWindow.c:
661         (geolocationRequestDialogCallback): Callback for the dialog asking
662         the user for allowing or not geolocation permission requests.
663         (webViewDecidePermissionRequest): Launch a dialog to ask the user
664         whether to allow or deny geolocation permission requests.
665         (browserWindowConstructed): Connect to 'permission-request' signal.
666
667 2012-06-04  Chase Phillips  <cmp@google.com>
668
669         Make a builder group support+expect multiple loads.
670         https://bugs.webkit.org/show_bug.cgi?id=88260
671
672         Change BuilderGroup to allow expecting multiple
673         loads.  This allows merging results for a given set
674         of builders into one group.
675
676         Add a test that verifies that the group count
677         increments correctly based on successful and failed
678         list loads.
679
680         Reviewed by Ojan Vafai.
681
682         * TestResultServer/static-dashboards/builders.js:
683         (BuilderGroup):
684         (BuilderGroup.prototype.setbuilder):
685         (BuilderGroup.prototype.append):
686         (BuilderGroup.prototype.loaded):
687         (requestBuilderList.xhr.onload):
688         (requestBuilderList.xhr.onerror):
689         (onErrorLoadingBuilderList):
690         (loadBuildersList):
691         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
692         (test):
693         * TestResultServer/static-dashboards/run-unittests.html:
694
695 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
696
697         Python test fix attempt for Chromium Windows.
698
699         * Scripts/webkitpy/layout_tests/port/driver.py:
700         (Driver.uri_to_test):
701
702 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
703
704         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
705         https://bugs.webkit.org/show_bug.cgi?id=88243
706
707         Reviewed by Adam Barth.
708
709         * qmake/mkspecs/features/features.prf:
710
711 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
712
713         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
714         https://bugs.webkit.org/show_bug.cgi?id=88280
715
716         Unreviewed, build fix.
717
718         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
719         (TestServerProcess.test_basic):
720
721 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
722
723         test-webkitpy is hanging under cygwin
724         https://bugs.webkit.org/show_bug.cgi?id=88269
725
726         Reviewed by Ryosuke Niwa.
727
728         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
729         so we need to skip any tests that use it.
730
731         * Scripts/webkitpy/common/system/executive.py:
732         (Executive.run_in_parallel):
733         * Scripts/webkitpy/common/system/executive_unittest.py:
734         (ExecutiveTest.test_run_in_parallel):
735
736 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
737
738         test-webkitpy is failing on win32 after r115054
739         https://bugs.webkit.org/show_bug.cgi?id=88264
740
741         Reviewed by Ryosuke Niwa.
742
743         The failing http_server test was improperly suppressed (the
744         tuple was missing a comma, and so wasn't a tuple at all, just a
745         string) and so we were skipping *all* tests on win32. The right
746         way to skip a single test is to disable it inside the test
747         itself.
748
749         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
750         (TestHttpServer.test_start_cmd):
751         * Scripts/webkitpy/test/test_finder.py:
752         (TestFinder._default_names):
753         * Scripts/webkitpy/test/main.py:
754         (Tester.run): Add error message if we don't find any tests to run.
755         * Scripts/webkitpy/test/main_unittest.py:
756             
757
758 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
759
760         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
761         https://bugs.webkit.org/show_bug.cgi?id=88215
762
763         Reviewed by Martin Robinson.
764
765         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
766         for newly allocated strings.
767
768         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
769         (attributeSetToString):
770         (AccessibilityUIElement::allAttributes):
771
772 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
773
774         [GTK] Memory leaks in DumpRenderTree.cpp
775         https://bugs.webkit.org/show_bug.cgi?id=88213
776
777         Reviewed by Martin Robinson.
778
779         Fixed memory leaks in DumpRenderTree.
780
781         * DumpRenderTree/gtk/DumpRenderTree.cpp:
782         (appendString): Accepts const gchar* as the second argument.
783         (dumpFramesAsText): Free the string returned by g_strdup_printf().
784         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
785
786 2012-06-04  David Dorwin  <ddorwin@chromium.org>
787
788         Enable Chromium media player to instantiate a plugin
789         https://bugs.webkit.org/show_bug.cgi?id=87399
790
791         Reviewed by Kent Tamura.
792
793         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
794
795         * DumpRenderTree/chromium/WebViewHost.cpp:
796         (WebViewHost::createPopupMenu):
797
798 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
799
800         [GTK][WK2] Implement geolocation provider for the GTK port
801         https://bugs.webkit.org/show_bug.cgi?id=83877
802
803         Reviewed by Carlos Garcia Campos.
804
805         * gtk/generate-gtkdoc:
806         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
807
808 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
809
810         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
811         https://bugs.webkit.org/show_bug.cgi?id=87668
812
813         Reviewed by Ryosuke Niwa.
814
815         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
816         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
817         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
818
819         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
820         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
821
822 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
823
824         [EFL] Refactor ewk_view_context_paint code.
825         https://bugs.webkit.org/show_bug.cgi?id=85588
826
827         Reviewed by Hajime Morita.
828
829         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
830
831 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
832
833         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
834         https://bugs.webkit.org/show_bug.cgi?id=87869
835
836         Reviewed by Andreas Kling.
837
838         Replace %lld by PRId64 macro to print an int64_t value and silent a
839         compilation warning on 64-Bit.
840
841         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
842         (onExceededApplicationCacheQuota):
843
844 2012-06-03  Varun Jain  <varunjain@google.com>
845
846         [chromium] Add new gesture type (two finger tap) that triggers context menu.
847         https://bugs.webkit.org/show_bug.cgi?id=88173
848
849         Reviewed by Adam Barth.
850
851         * DumpRenderTree/chromium/EventSender.cpp:
852         (EventSender::EventSender):
853         (EventSender::gestureTwoFingerTap):
854         (EventSender::gestureEvent):
855         * DumpRenderTree/chromium/EventSender.h:
856         (EventSender):
857
858 2012-06-02  Zeno Albisser  <zeno@webkit.org>
859
860         Fix and enable WebGL for WebKit2 on Qt.
861         https://bugs.webkit.org/show_bug.cgi?id=86214
862
863         Enable WebGL by default for Qt MiniBrowser.
864
865         Reviewed by Noam Rosenthal.
866
867         * MiniBrowser/qt/qml/BrowserWindow.qml:
868
869 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
870
871         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
872         https://bugs.webkit.org/show_bug.cgi?id=88164
873
874         Reviewed by Kentaro Hara.
875
876         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
877         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
878
879         * Scripts/VCSUtils.pm:
880         (adjustPathForRecentRenamings):
881         (fixChangeLogPatch):
882
883 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
884
885         Rename test_expectations.txt to TestExpectations
886         https://bugs.webkit.org/show_bug.cgi?id=86690
887
888         Reviewed by Dirk Pranke.
889
890         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
891         We can the code to read test_expectations.txt once we've successfully transitioned.
892
893         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
894         (TestExpectationParser._check_path_does_not_exist):
895         (TestExpectationParser._tokenize):
896         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
897         * Scripts/webkitpy/layout_tests/port/base.py:
898         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
899         test_expectations.txt if one exists and the path to TestExpectations otherwise.
900         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
901         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
902         virtual.
903         * Scripts/webkitpy/layout_tests/port/chromium.py:
904         (ChromiumPort.path_from_chromium_base):
905         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
906         (ChromiumAndroidPort.test_expectations):
907         * Scripts/webkitpy/layout_tests/port/test.py:
908         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
909         (TestPort.__init__):
910         * Scripts/webkitpy/layout_tests/port/webkit.py:
911         (WebKitPort.baseline_search_path):
912         (WebKitPort.test_expectations):
913         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
914         tests to base as a follow up.
915         (WebKitPortTest.test_path_to_test_expectations_file):
916         (test_test_expectations):
917         (test_legacy_test_expectations):
918         * Scripts/webkitpy/style/checker.py:
919         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
920         with one for TestExpectations.
921         * Scripts/webkitpy/style/checkers/test_expectations.py:
922         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
923         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
924         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
925         test_expectations.txt.
926         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
927         (TestExpectationsTestCase.assert_lines_lint):
928         * Scripts/webkitpy/tool/commands/queries.py:
929         (PrintExpectations.__init__):
930         * Scripts/webkitpy/tool/commands/rebaseline.py:
931         (RebaselineExpectations):
932         * Scripts/webkitpy/tool/steps/commit.py:
933         (Commit._check_test_expectations):
934         * Scripts/webkitpy/tool/steps/commit_unittest.py:
935         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
936         (CommitTest.test_check_test_expectations): For TestExpectations.
937         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
938         * TestResultServer/static-dashboards/dashboard_base.js:
939         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
940         Error only when neither exists.
941         * TestResultServer/static-dashboards/flakiness_dashboard.js:
942         (processMissingAndExtraExpectations):
943         (htmlForTestsWithExpectationsButNoFailures):
944         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
945
946 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
947
948         Remove dependency from ImageDiff to WTF
949         https://bugs.webkit.org/show_bug.cgi?id=88147
950
951         Reviewed by Adam Barth.
952
953         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
954
955 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
956
957         NRWT seems to leak (more?) temp dirs
958         https://bugs.webkit.org/show_bug.cgi?id=88126
959
960         Re-land r119297 with chromium fix (weren't calling the
961         super() method if not in --test-shell mode in start().
962         Add unit tests to chromium_unittest as well to check.
963
964         * Scripts/webkitpy/layout_tests/port/chromium.py:
965         (ChromiumDriver.start):
966         * Scripts/webkitpy/layout_tests/port/webkit.py:
967         (WebKitDriver.__del__):
968         (WebKitDriver._start):
969         (WebKitDriver.run_test):
970         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
971         (WebKitDriverTest.test_check_for_driver_crash):
972         (WebKitDriverTest.test_stop_cleans_up_properly):
973         (WebKitDriverTest):
974         (WebKitDriverTest.test_two_starts_cleans_up_properly):
975         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
976         (ChromiumDriverTest.test_stop_cleans_up_properly):
977         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
978
979 2012-06-01  Tim Horton  <timothy_horton@apple.com>
980
981         Lots of "failed download-built-product" on Apple bots
982         https://bugs.webkit.org/show_bug.cgi?id=88158
983
984         Reviewed by Jessie Berlin.
985         
986         Disable mergeRequests on all Apple builders. This is a speculative fix.
987
988         * BuildSlaveSupport/build.webkit.org-config/config.json:
989
990 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
991
992         Unreviewed, rolling out r119297.
993         http://trac.webkit.org/changeset/119297
994         https://bugs.webkit.org/show_bug.cgi?id=88156
995
996         May have broken Chromium bots (Requested by rniwa on #webkit).
997
998         * Scripts/webkitpy/layout_tests/port/webkit.py:
999         (WebKitDriver.__del__):
1000         (WebKitDriver.run_test):
1001         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1002         (WebKitDriverTest.test_check_for_driver_crash):
1003         (WebKitDriverTest.test_stop_cleans_up_properly):
1004
1005 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1006
1007         nrwt seems to leak tmpdirs
1008         https://bugs.webkit.org/show_bug.cgi?id=88126
1009
1010         Reviewed by Ojan Vafai.
1011
1012         Fix leak possibly introduced in r118979 - we now will
1013         make sure we clean up any stale temp directories during the
1014         start routine and attempt to clean up again in __del__. It
1015         turns out that asserting in __del__ logs a message but is
1016         caught by the runtime, so it's mostly useless.
1017
1018         * Scripts/webkitpy/layout_tests/port/webkit.py:
1019         (WebKitDriver.__del__):
1020         (WebKitDriver._start):
1021         (WebKitDriver.run_test):
1022         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1023         (WebKitDriverTest.test_check_for_driver_crash):
1024         (WebKitDriverTest.test_stop_cleans_up_properly):
1025         (WebKitDriverTest):
1026         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1027
1028 2012-06-01  Michael Saboff  <msaboff@apple.com>
1029
1030         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1031         https://bugs.webkit.org/show_bug.cgi?id=88109
1032
1033         Reviewed by Geoffrey Garen.
1034
1035         Additional test case.
1036
1037         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1038         (TestWebKitAPI::TEST):
1039
1040 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1041
1042         [Qt] Use -Werror only in developer builds
1043
1044         Rubber-stamped by Tor Arne Vestbø.
1045
1046         In production builds -Werror with custom toolchains and wierd system
1047         headers, -Werror is of no use and just creates confusion. So use it
1048         only if Qt is configured with -developer-build.
1049
1050         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1051         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1052         only if qt_developer_build is set.
1053
1054 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1055
1056         [watchlist] Add myself to loader and v8 bindings changes
1057         https://bugs.webkit.org/show_bug.cgi?id=88112
1058
1059         Reviewed by Adam Barth.
1060
1061         * Scripts/webkitpy/common/config/watchlist:
1062
1063 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1064
1065         Adding Jacky Jiang to committers.py
1066         https://bugs.webkit.org/show_bug.cgi?id=88122
1067
1068         Reviewed by Rob Buis.
1069
1070         Adding myself to committers.py as a Committer.
1071
1072         * Scripts/webkitpy/common/config/committers.py:
1073
1074 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1075
1076         Fix Windows build.
1077
1078         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1079
1080 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1081
1082         Windows WK2 MouseMoveAfterCrash API test failing
1083         https://bugs.webkit.org/show_bug.cgi?id=69982
1084
1085         Disable the test on Windows to get the bots greener.
1086
1087         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1088         (TestWebKitAPI::TEST):
1089
1090 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1091
1092         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1093         https://bugs.webkit.org/show_bug.cgi?id=86866
1094
1095         Reviewed by Adam Barth.
1096
1097         Catch new "intent,service,register" signal on the frame and print out
1098         information about the Web Intent service in EFL's DumpRenderTree.
1099
1100         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1101         (DumpRenderTreeChrome::createView):
1102         (DumpRenderTreeChrome::onFrameCreated):
1103         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1104         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1105         (DumpRenderTreeChrome):
1106
1107 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1108
1109         The ChangeLog parser cannot handle reviewers with initials in their name
1110         https://bugs.webkit.org/show_bug.cgi?id=87864
1111
1112         Reviewed by Ryosuke Niwa.
1113
1114         Add support in the ChangeLog parser for reviewer names that have
1115         initials in them.
1116
1117         * Scripts/webkitpy/common/checkout/changelog.py:
1118         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1119         in the replacement string. This allows for matching the word characters before a
1120         period, without totally throwing them away.
1121         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1122         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1123         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1124
1125 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1126
1127         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1128         https://bugs.webkit.org/show_bug.cgi?id=86865
1129
1130         Reviewed by Adam Barth.
1131
1132         Add deliverWebIntent method to LayoutTestController and provide
1133         implementation for EFL port.
1134
1135         * DumpRenderTree/LayoutTestController.cpp:
1136         (deliverWebIntentCallback):
1137         (LayoutTestController::staticFunctions):
1138         * DumpRenderTree/LayoutTestController.h:
1139         (LayoutTestController):
1140         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1141         (LayoutTestController::deliverWebIntent):
1142         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1143         (LayoutTestController::deliverWebIntent):
1144         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1145         (LayoutTestController::deliverWebIntent):
1146         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1147         (LayoutTestController::deliverWebIntent):
1148         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1149         (LayoutTestController::deliverWebIntent):
1150         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1151         (LayoutTestController::deliverWebIntent):
1152
1153 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1154
1155         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1156
1157         Reviewed by Simon Hausmann.
1158
1159         * Tools.pro:
1160
1161 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1162
1163         Add public page loading performance tests using web-page-replay
1164         https://bugs.webkit.org/show_bug.cgi?id=84008
1165
1166         Reviewed by Dirk Pranke.
1167
1168         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1169         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1170         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1171
1172         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1173         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1174         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1175         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1176
1177         * Scripts/webkitpy/layout_tests/port/driver.py:
1178         (Driver.is_external_http_test): Added.
1179         * Scripts/webkitpy/layout_tests/port/webkit.py:
1180         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1181         * Scripts/webkitpy/performance_tests/perftest.py:
1182         (PerfTest.__init__): Takes port.
1183         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1184         (PerfTest):
1185         (PerfTest.run): Calls run_single.
1186         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1187         (ChromiumStylePerfTest.__init__):
1188         (PageLoadingPerfTest.__init__):
1189         (PageLoadingPerfTest.run):
1190         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1191         (ReplayServer.__init__):
1192         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1193         but it caused a dead lock on some web pages.
1194         (ReplayServer.stop):
1195         (ReplayServer.__del__):
1196         (ReplayPerfTest):
1197         (ReplayPerfTest.__init__):
1198         (ReplayPerfTest._start_replay_server):
1199         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1200         The subsequent runs of the same test will just use test.wpr.
1201         (ReplayPerfTest.run_single):
1202         (PerfTestFactory):
1203         (PerfTestFactory.create_perf_test):
1204         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1205         (MainTest.test_parse_output):
1206         (MainTest.test_parse_output_with_failing_line):
1207         (TestPageLoadingPerfTest.test_run):
1208         (TestPageLoadingPerfTest.test_run_with_bad_output):
1209         (TestReplayPerfTest):
1210         (TestReplayPerfTest.ReplayTestPort):
1211         (TestReplayPerfTest.ReplayTestPort.__init__):
1212         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1213         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1214         (TestReplayPerfTest.ReplayTestPort._driver_class):
1215         (TestReplayPerfTest.MockReplayServer):
1216         (TestReplayPerfTest.MockReplayServer.__init__):
1217         (TestReplayPerfTest.MockReplayServer.stop):
1218         (TestReplayPerfTest._add_file):
1219         (TestReplayPerfTest._setup_test):
1220         (TestReplayPerfTest.test_run_single):
1221         (TestReplayPerfTest.test_run_single.run_test):
1222         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1223         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1224         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1225         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1226         (TestReplayPerfTest.test_prepare):
1227         (TestReplayPerfTest.test_prepare.run_test):
1228         (TestReplayPerfTest.test_prepare_calls_run_single):
1229         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1230         (TestPerfTestFactory.test_regular_test):
1231         (TestPerfTestFactory.test_inspector_test):
1232         (TestPerfTestFactory.test_page_loading_test):
1233         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1234         (PerfTestsRunner):
1235         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1236         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1237         (PerfTestsRunner._collect_tests._is_test_file):
1238         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1239         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1240         (create_runner):
1241         (run_test):
1242         (_tests_for_runner):
1243         (test_run_test_set):
1244         (test_run_test_set_kills_drt_per_run):
1245         (test_run_test_pause_before_testing):
1246         (test_run_test_set_for_parser_tests):
1247         (test_run_test_set_with_json_output):
1248         (test_run_test_set_with_json_source):
1249         (test_run_test_set_with_multiple_repositories):
1250         (test_run_with_upload_json):
1251         (test_upload_json):
1252         (test_upload_json.MockFileUploader.upload_single_text_file):
1253         (_add_file):
1254         (test_collect_tests):
1255         (test_collect_tests_with_multile_files):
1256         (test_collect_tests_with_multile_files.add_file):
1257         (test_collect_tests_with_skipped_list):
1258         (test_collect_tests_with_page_load_svg):
1259         (test_collect_tests_should_ignore_replay_tests_by_default):
1260         (test_collect_tests_with_replay_tests):
1261         (test_parse_args):
1262         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1263         (AutoinstallImportHook.find_module):
1264         (AutoinstallImportHook._install_webpagereplay):
1265
1266 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1267
1268         Support building the Android port of chromium with Ninja
1269         https://bugs.webkit.org/show_bug.cgi?id=87545
1270
1271         Reviewed by Adam Barth.
1272
1273         Ensures that shared libraries are looked up in a generator-agnostic
1274         way and that output is placed in the correct directory.
1275
1276         Depends on http://codereview.chromium.org/10386188/
1277
1278         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1279
1280 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1281
1282         [Chromium] Chromium DRT should be able to load external resources
1283         https://bugs.webkit.org/show_bug.cgi?id=87893
1284
1285         Reviewed by Dirk Pranke.
1286
1287         Allow external resources to be loaded when the main frame's URL is also an external resource.
1288         This change is analogous to r118231 for Mac port.
1289
1290         * DumpRenderTree/chromium/WebViewHost.cpp:
1291         (blockRequest):
1292         (isLocalhost):
1293         (hostIsUsedBySomeTestsToGenerateError):
1294         (WebViewHost::willSendRequest):
1295
1296 2012-05-31  Anders Carlsson  <andersca@apple.com>
1297
1298         Build fixes.
1299
1300         Disable the C++11 extensions warning.
1301
1302         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1303         * TestWebKitAPI/Configurations/Base.xcconfig:
1304         * WebKitTestRunner/Configurations/Base.xcconfig:
1305
1306 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1307
1308         [WK2] window.internals settings are not reset between tests
1309         https://bugs.webkit.org/show_bug.cgi?id=87783
1310
1311         Reviewed by Mihai Parparita.
1312
1313         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1314         (WTR::InjectedBundle::done): Call resetAfterTest().
1315
1316         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1317         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1318         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1319         This needs to be done after a tets, because the code assumes that there is an object
1320         with this name in global scope.
1321
1322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1323
1324 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1325
1326         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1327         https://bugs.webkit.org/show_bug.cgi?id=85006
1328
1329         Reviewed by Tor Arne Vestbø.
1330
1331         Added navigation_policy_decision implementation for DumpRenderTreeView.
1332         Added LayoutTestController::setCustomPolicyDelegate implementation.
1333         Modified LayoutTestController::waitForPolicyDelegate.
1334
1335         * DumpRenderTree/efl/DumpRenderTree.cpp:
1336         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1337         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1338         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1339         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1340         (navigationTypeToString): aux function
1341         (onNavigationPolicyDecision): navigation_policy_decision implementation
1342         (drtViewAdd):
1343         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1344         (LayoutTestController::setCustomPolicyDelegate):
1345         (LayoutTestController::waitForPolicyDelegate):
1346
1347 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1348
1349         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1350         https://bugs.webkit.org/show_bug.cgi?id=86195
1351
1352         Reviewed by Gustavo Noronha Silva.
1353
1354         Implement clearApplicationCacheForOrigin in EFL
1355         LayoutTestController.
1356
1357         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1358         (LayoutTestController::clearApplicationCacheForOrigin):
1359
1360 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1361
1362         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1363         https://bugs.webkit.org/show_bug.cgi?id=87955
1364
1365         Reviewed by Simon Hausmann.
1366
1367         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1368         * DumpRenderTree/qt/EventSenderQt.cpp:
1369         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1370         * DumpRenderTree/qt/main.cpp:
1371         * QtTestBrowser/cookiejar.cpp:
1372         * QtTestBrowser/launcherwindow.cpp:
1373         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1374         * qmake/mkspecs/features/default_post.prf:
1375
1376 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1377
1378         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1379
1380         Rubber-stamped by Kenneth Rohde Christiansen.
1381
1382         * qmake/config.tests/libpng/libpng.pro:
1383
1384 2012-05-30  Peter Beverloo  <peter@chromium.org>
1385
1386         [Chromium] Automatically install 64-bit linker for Android
1387         https://bugs.webkit.org/show_bug.cgi?id=79780
1388
1389         Reviewed by Adam Barth.
1390
1391         Change the update-webkit-chromium script to check whether the 64-bit
1392         linker needs to be installed as part of the update process. The actual
1393         code for doing these checks and "installing" it has been added to the
1394         webkitdirs.pm script.
1395
1396         The linker itself is part of the third_party/aosp repository, which
1397         will be pulled in through the DEPS change.
1398
1399         * Scripts/update-webkit-chromium:
1400         * Scripts/webkitdirs.pm:
1401         (chromiumInstall64BitAndroidLinkerIfNeeded):
1402         (chromiumReplaceAndroidLinkerIfNeeded):
1403
1404 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1405
1406         https://bugs.webkit.org/show_bug.cgi?id=87803
1407         Layout tests often fail trying to stat nonexistent logs 
1408
1409         Reviewed by Dirk Pranke.
1410
1411         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1412         try/catch block around accessing the logs as a precaution.
1413
1414         * Scripts/webkitpy/common/system/crashlogs.py:
1415         (CrashLogs._find_newest_log_darwin):
1416
1417 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1418
1419         Add a LayoutTest for prerender remove after stop.
1420         https://bugs.webkit.org/show_bug.cgi?id=87860
1421
1422         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1423         can be tested by LayoutTests now.
1424
1425         Reviewed by Adam Barth.
1426
1427         * DumpRenderTree/DumpRenderTree.gypi:
1428         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1429         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1430         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1431         (MockWebPrerenderingSupport::add):
1432         (MockWebPrerenderingSupport::cancel):
1433         (MockWebPrerenderingSupport::abandon):
1434         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1435         (MockWebPrerenderingSupport):
1436         * DumpRenderTree/chromium/TestShell.cpp:
1437         (TestShell::initialize):
1438         * DumpRenderTree/chromium/TestShell.h:
1439         (TestShell):
1440         * DumpRenderTree/chromium/WebViewHost.cpp:
1441         (WebViewHost::willAddPrerender):
1442         (WebViewHost::setWebWidget):
1443         * DumpRenderTree/chromium/WebViewHost.h:
1444         (WebViewHost):
1445
1446 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1447
1448         https://bugs.webkit.org/show_bug.cgi?id=87717
1449         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1450
1451         Reviewed by Dirk Pranke.
1452
1453         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1454         If there isn't a crash log found for the process add a message saying
1455         the process was unresponsive.
1456
1457         * Scripts/webkitpy/layout_tests/port/webkit.py:
1458         (WebKitDriver.__init__):
1459         (WebKitDriver._check_for_driver_crash):
1460         (WebKitDriver.run_test):
1461         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1462         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1463         (WebKitDriverTest):
1464         (WebKitDriverTest.test_check_for_driver_crash):
1465         * WebKitTestRunner/TestController.cpp:
1466         (WTR):
1467         (WTR::TestController::runTest):
1468
1469 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1470
1471         https://bugs.webkit.org/show_bug.cgi?id=87714
1472         Mac crash logs can take a really long time to be written out.
1473
1474         Reviewed by Dirk Pranke.
1475
1476         Make a second pass looking for crash logs after the tests have completed running.
1477
1478         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1479         (use_trac_links_in_results_html):
1480         (Manager.run):
1481         * Scripts/webkitpy/layout_tests/port/base.py:
1482         (Port.repository_paths):
1483         (Port.look_for_new_crash_logs):
1484         * Scripts/webkitpy/layout_tests/port/mac.py:
1485         (MacPort.look_for_new_crash_logs):
1486         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1487         (test_get_crash_log):
1488         (test_look_for_new_crash_logs):
1489         (test_look_for_new_crash_logs.fake_time_cb):
1490
1491 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1492
1493         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1494
1495         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1496         (LayoutWebViewEventHandler::OnAlertEvent):
1497         (LayoutWebViewEventHandler::OnConfirmEvent):
1498         (LayoutWebViewEventHandler):
1499         (LayoutWebViewEventHandler::OnPromptEvent):
1500         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1501         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1502
1503 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1504
1505         Only give lint errors for -expected.png png files that lack a checksum
1506         https://bugs.webkit.org/show_bug.cgi?id=87875
1507
1508         Reviewed by Tony Chang.
1509
1510         We have other pngs in the tree, e.g. for the inspector, that legitimately
1511         lack a checksum.
1512
1513         * Scripts/webkitpy/style/checkers/png.py:
1514         (PNGChecker.check):
1515         * Scripts/webkitpy/style/checkers/png_unittest.py:
1516         (PNGCheckerTest.test_check):
1517
1518 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1519
1520         nrwt: seems to leak temp dirs
1521         https://bugs.webkit.org/show_bug.cgi?id=87795
1522
1523         Reviewed by Ojan Vafai.
1524
1525         There appears to be a bug where the chromium bots are creating
1526         temporary directories and not cleaning them up that started
1527         after the switch to WebKitDriver. It's possible that __del__
1528         wasn't getting called in a timely manner (or at all), and it's
1529         generally bad style to rely on __del__ being called, so this
1530         code changes things so that we create a temp dir in
1531         driver.start() and remove it in driver.stop(). We could be
1532         paranoid and leave the __del__ code in, but there doesn't seem
1533         to be much advantage to it. If there are bugs that result in
1534         drivers being started but not stopped, we have other problems.
1535
1536         * Scripts/webkitpy/common/system/filesystem_mock.py:
1537         (MockFileSystem.__init__):
1538         (MockFileSystem._mktemp):
1539         (MockFileSystem.mkdtemp):
1540         * Scripts/webkitpy/layout_tests/port/webkit.py:
1541         (WebKitDriver.__init__):
1542         (WebKitDriver._start):
1543         (WebKitDriver.stop):
1544         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1545         (WebKitDriverTest.test_check_for_driver_crash):
1546         (WebKitDriverTest):
1547         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1548         (WebKitDriverTest.test_stop_cleans_up_properly):
1549
1550 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1551
1552         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1553         https://bugs.webkit.org/show_bug.cgi?id=86841
1554
1555         Reviewed by Adam Barth.
1556
1557         Print the number of MessagePorts for each new intent in EFL's DRT.
1558         This output is expected by several Web Intents test cases.
1559
1560         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1561         (DumpRenderTreeChrome::onFrameIntentNew):
1562
1563 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1564
1565         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1566
1567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1568
1569 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1570
1571         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1572         https://bugs.webkit.org/show_bug.cgi?id=87829
1573
1574         Reviewed by Adam Barth.
1575
1576         EFL's LayoutTestController now makes uses of the new helper method in
1577         DumpRenderTreeSupportEfl in order to send the intent response. This is
1578         now needed because the Ewk_Intent_Request postResult / postFailure
1579         methods were made private.
1580
1581         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1582         (LayoutTestController::sendWebIntentResponse):
1583
1584 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1585
1586         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1587         https://bugs.webkit.org/show_bug.cgi?id=86296
1588
1589         Reviewed by Tony Chang.
1590
1591         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1592         (cfHDropFormat):
1593         (cfFileNameWFormat):
1594         (cfUrlWFormat):
1595         (WCEnumFormatEtc):
1596         (WCEnumFormatEtc::WCEnumFormatEtc):
1597         (WCEnumFormatEtc::QueryInterface):
1598         (WCEnumFormatEtc::AddRef):
1599         (WCEnumFormatEtc::Release):
1600         (WCEnumFormatEtc::Next):
1601         (WCEnumFormatEtc::Skip):
1602         (WCEnumFormatEtc::Reset):
1603         (WCEnumFormatEtc::Clone):
1604         (DRTDataObject::createInstance):
1605         (DRTDataObject::DRTDataObject):
1606         (DRTDataObject::~DRTDataObject):
1607         (DRTDataObject::QueryInterface):
1608         (DRTDataObject::AddRef):
1609         (DRTDataObject::Release):
1610         (DRTDataObject::GetData):
1611         (DRTDataObject::GetDataHere):
1612         (DRTDataObject::QueryGetData):
1613         (DRTDataObject::GetCanonicalFormatEtc):
1614         (DRTDataObject::SetData):
1615         (DRTDataObject::CopyMedium):
1616         (DRTDataObject::EnumFormatEtc):
1617         (DRTDataObject::DAdvise):
1618         (DRTDataObject::DUnadvise):
1619         (DRTDataObject::EnumDAdvise):
1620         (DRTDataObject::clearData):
1621         * DumpRenderTree/win/DRTDataObject.h: Added.
1622         (DRTDataObject):
1623         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1624         (DRTDropSource::DRTDropSource):
1625         (DRTDropSource::~DRTDropSource):
1626         (DRTDropSource::QueryInterface):
1627         (DRTDropSource::AddRef):
1628         (DRTDropSource::Release):
1629         (DRTDropSource::createInstance):
1630         (DRTDropSource::QueryContinueDrag):
1631         (DRTDropSource::GiveFeedback):
1632         * DumpRenderTree/win/DRTDropSource.h: Added.
1633         (DRTDropSource):
1634         * DumpRenderTree/win/DumpRenderTree.vcproj:
1635         * DumpRenderTree/win/EventSender.cpp:
1636         (beginDragWithFilesCallback):
1637
1638 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1639
1640         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1641         https://bugs.webkit.org/show_bug.cgi?id=58593
1642
1643         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1644         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1645         public C API of the WebProcess.
1646
1647         Reviewed by Darin Adler.
1648
1649         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1650         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1651         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1652         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1653         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1654
1655 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1656
1657         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1658         https://bugs.webkit.org/show_bug.cgi?id=87848
1659
1660         Reviewed by Csaba Osztrogonác.
1661
1662         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1663         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1664         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1665
1666         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1667         (DumpRenderTreeChrome::extraViews):
1668         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1669         (DumpRenderTreeChrome):
1670
1671 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1672
1673         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1674         https://bugs.webkit.org/show_bug.cgi?id=87833
1675
1676         Reviewed by Tor Arne Vestbø.
1677
1678         Print "postProgressFinishedNotification" message if frame load finished 
1679         to unskip http/tests/loading/progress-finished-callback.html.
1680
1681         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1682         (DumpRenderTreeChrome::onFrameLoadFinished):
1683
1684 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1685
1686         [EFL][WK2] Fix WebKit2-EFL build
1687         https://bugs.webkit.org/show_bug.cgi?id=83693
1688
1689         Reviewed by Carlos Garcia Campos.
1690
1691         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1692
1693 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1694
1695         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1696         (They only used to check for Skipped in platform/qt-5.0-wk1)
1697         https://bugs.webkit.org/show_bug.cgi?id=87376
1698
1699         Reviewed by Csaba Osztrogonác.
1700
1701         * Scripts/old-run-webkit-tests:
1702         (buildPlatformResultHierarchy):
1703         * Scripts/webkitpy/layout_tests/port/qt.py:
1704         (QtPort.baseline_search_path):
1705
1706 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1707
1708         Add a linter error for pngs that lack an embedded checksum
1709         https://bugs.webkit.org/show_bug.cgi?id=87793
1710
1711         Reviewed by Dirk Pranke.
1712
1713         * Scripts/read-checksum-from-png:
1714         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1715         (read_checksum):
1716         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1717         (ReadChecksumFromPngTest):
1718         (ReadChecksumFromPngTest.test_read_checksum):
1719         * Scripts/webkitpy/layout_tests/port/base.py:
1720         * Scripts/webkitpy/style/checkers/png.py:
1721         (PNGChecker.check):
1722         * Scripts/webkitpy/style/checkers/png_unittest.py:
1723         (PNGCheckerTest.test_check):
1724
1725 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1726
1727         https://bugs.webkit.org/show_bug.cgi?id=87720
1728         WebProcess is often killed due to being unresponsive on the bots
1729
1730         Reviewed by Alexey Proskuryakov.
1731
1732         Blind attempt to improve flakiness on the bots by reducing the number
1733         of crashes due to an unresponsive process.  This helped on my personal machine
1734         under stress conditions.  I don't have enough cores to hit the problem
1735         under normal conditions.
1736
1737         * WebKitTestRunner/TestController.cpp:
1738         (WTR):
1739
1740 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1741
1742         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1743         https://bugs.webkit.org/show_bug.cgi?id=87779
1744
1745         Reviewed by Eric Seidel.
1746
1747         Update output to match the names in scm.py as per
1748         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1749
1750         * Scripts/webkitpy/tool/commands/rebaseline.py:
1751         (RebaselineTest.execute):
1752         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1753         (test_rebaseline_test_and_print_scm_changes):
1754         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1755         (GardeningServerTest.test_rebaselineall):
1756
1757 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1758
1759         https://bugs.webkit.org/show_bug.cgi?id=87711
1760
1761         Reviewed by Jessie Berlin.
1762
1763         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1764         are better maintained.
1765
1766         * BuildSlaveSupport/build.webkit.org-config/config.json:
1767
1768 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1769
1770         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1771         https://bugs.webkit.org/show_bug.cgi?id=87538
1772
1773         Reviewed by Ojan Vafai.
1774
1775         Invoking git and svn on one file at a time is kinda slow. We
1776         should batch the add and rm operations together.
1777
1778         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1779         (BaselineOptimizer._move_baselines):
1780
1781 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1782
1783         garden-o-matic should rebaseline baselines in parallel
1784         https://bugs.webkit.org/show_bug.cgi?id=87451
1785
1786         Reviewed by Ojan Vafai.
1787                                                                                
1788         This modifies garden-o-matic so that we will fetch all                  
1789         of the baselines in parallel from the bots, and then                    
1790         optimize the baselines serially (since that should be fairly            
1791         quick and we get into trouble if we optimize in parallel due            
1792         to concurrent access to the source control system).                     
1793
1794         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1795         so that the files that need to be modified in the SCM are returned to 
1796         garden-o-matic rather than actually added or removed. This is done so that
1797         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1798         concurrently). In order to safely return the files (as a JSON dict) I
1799         needed to shift all of the logging in rebaseline-test to use the logging
1800         module (and hence log to stderr).
1801
1802         I also had to stub out a line in chromium.py that would get confused if
1803         the skia overrides file didn't exist in a mock checkout.
1804
1805         * Scripts/webkitpy/common/system/executive.py:
1806         (Executive.popen):
1807         (Executive):
1808         (Executive.run_in_parallel):
1809         (_run_command_thunk):
1810         * Scripts/webkitpy/common/system/executive_mock.py:
1811         (MockExecutive.run_in_parallel):
1812         * Scripts/webkitpy/common/system/executive_unittest.py:
1813         (ExecutiveTest.test_run_in_parallel):
1814         * Scripts/webkitpy/layout_tests/port/chromium.py:
1815         (ChromiumPort._expectations_file_contents):
1816         * Scripts/webkitpy/tool/commands/rebaseline.py:
1817         (AbstractRebaseliningCommand.__init__):
1818         (RebaselineTest.__init__):
1819         (RebaselineTest._copy_existing_baseline):
1820         (RebaselineTest._save_baseline):
1821         (RebaselineTest):
1822         (RebaselineTest._add_to_scm):
1823         (RebaselineTest._rebaseline_test):
1824         (RebaselineTest.execute):
1825         (RebaselineExpectations._rebaseline_port):
1826         (RebaselineExpectations.execute):
1827         (Rebaseline._builder_to_pull_from):
1828         (Rebaseline.execute):
1829         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1830         (test_rebaseline_updates_expectations_file):
1831         (test_rebaseline_test):
1832         (test_rebaseline_test_and_print_scm_changes):
1833         (test_rebaseline_and_copy_test):
1834         (test_rebaseline_and_copy_test_no_existing_result):
1835         (test_rebaseline_and_copy_test_with_lion_result):
1836         (test_rebaseline_and_copy_no_overwrite_test):
1837         (test_rebaseline_expectations):
1838         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1839         (GardeningHTTPRequestHandler._rebaseline_commands):
1840         (GardeningHTTPRequestHandler):
1841         (GardeningHTTPRequestHandler._files_to_add):
1842         (GardeningHTTPRequestHandler._optimize_baselines):
1843         (GardeningHTTPRequestHandler.rebaselineall):
1844         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1845         (GardeningServerTest._post_to_path):
1846         (GardeningServerTest.test_rebaselineall):
1847         (GardeningServerTest.test_rebaselineall.run_command):
1848
1849 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1850
1851         Fix the type of dispatch_time() offset
1852
1853         Rubber-stamped by Joseph Pecoraro.
1854
1855         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1856
1857         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1858         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1859
1860 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1861
1862         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1863
1864         [BlackBerry] OpenGL content is not rendered on simulator
1865         https://bugs.webkit.org/show_bug.cgi?id=87721
1866
1867         Reviewed by George Staikos.
1868
1869         Fixed by enabling GLES2 support in simulator builds.
1870
1871         To experiment with building without OpenGL support, you can set the
1872         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1873
1874         PR #150695
1875
1876         * Scripts/webkitdirs.pm:
1877         (blackberryCMakeArguments):
1878
1879 2012-05-29  David Barr  <davidbarr@chromium.org>
1880
1881         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1882         https://bugs.webkit.org/show_bug.cgi?id=87685
1883
1884         Reviewed by Eric Seidel.
1885
1886         Add a configuration option for CSS image-resolution support, disabling it by default.
1887
1888         * Scripts/webkitperl/FeatureList.pm:
1889         * qmake/mkspecs/features/features.pri:
1890
1891 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1892
1893         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1894
1895         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1896             valid for C++/ObjC++ but not for C [enabled by default]"
1897
1898         Reviewed by Simon Hausmann.
1899
1900         * qmake/mkspecs/features/unix/default_post.prf:
1901
1902 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1903
1904         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=87133
1907
1908         We now base64-encode the page url in the image-provider url, so that any
1909         normalization done by QUrl will not mess up the page-url. The logic of
1910         creating and parsing the provider-url has been moved into the image
1911         provider, to keep it in one place.
1912
1913         We were also releasing icons (even ones we hadn't retained), which we can't
1914         do since we don't know when the icon url is no longer in use.
1915
1916         Reviewed-by Simon Hausmann.
1917
1918         * MiniBrowser/qt/icons/favicon.png:
1919         * MiniBrowser/qt/qml/BrowserWindow.qml:
1920
1921 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1922
1923         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1924         https://bugs.webkit.org/show_bug.cgi?id=87654
1925
1926         Reviewed by Csaba Osztrogonác.
1927
1928         Event sender provides strings for all the key events.
1929         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1930         a key event has empty string.
1931
1932         * DumpRenderTree/efl/EventSender.cpp:
1933         (KeyEventInfo::KeyEventInfo):
1934         (keyPadNameFromJSValue):
1935         (keyNameFromJSValue):
1936
1937 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1938
1939         [Qt] Cancel potential url-edit when going back/forward
1940
1941         Reviewed by Kenneth Rohde Christiansen.
1942
1943         * MiniBrowser/qt/qml/BrowserWindow.qml:
1944
1945 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1946
1947         [EFL] Compilation warning in DumpRenderTreeView.cpp
1948         https://bugs.webkit.org/show_bug.cgi?id=87636
1949
1950         Reviewed by Filip Pizlo.
1951
1952         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1953         specifier in printf. Also fix the return type for
1954         onExceededApplicationCacheQuota callback.
1955
1956         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1957         (onExceededApplicationCacheQuota):
1958
1959 2012-05-29  Hironori Bono  <hbono@chromium.org>
1960
1961         Adding Hironori Bono to committers.py.
1962         https://bugs.webkit.org/show_bug.cgi?id=87697
1963
1964         * Scripts/webkitpy/common/config/committers.py:
1965
1966 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1967
1968         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1969         https://bugs.webkit.org/show_bug.cgi?id=80135
1970
1971         Reviewed by Rob Buis.
1972
1973         Implemented interface function didReceiveAuthenticationChallenge in class
1974         DumpRenderTree.
1975
1976         Resubmit the patch reverted by r115104 after the digest infinite loop
1977         issue for BlackBerry porting get identified and fixed.
1978
1979         Internally reviewed by Joe Mason <jmason@rim.com>
1980
1981         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1982         (drtCredentialDescription):
1983         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1984         (WebKit):
1985         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1986         (WebCore):
1987         (DumpRenderTree):
1988
1989 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1990
1991         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1992         https://bugs.webkit.org/show_bug.cgi?id=42328
1993
1994         Reviewed by Eric Seidel.
1995
1996         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1997         move to windows.internals.settings.
1998
1999         * DumpRenderTree/LayoutTestController.cpp:
2000         (LayoutTestController::staticFunctions):
2001         * DumpRenderTree/LayoutTestController.h:
2002         (LayoutTestController):
2003         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2004         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2005         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2006         (DRTDevToolsAgent):
2007         * DumpRenderTree/chromium/LayoutTestController.cpp:
2008         (LayoutTestController::LayoutTestController):
2009         * DumpRenderTree/chromium/LayoutTestController.h:
2010         (LayoutTestController):
2011         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2012         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2013         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2014         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2015         * DumpRenderTree/mac/DumpRenderTree.mm:
2016         (resetWebViewToConsistentStateBeforeTesting):
2017         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2018         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2019         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2020         (LayoutTestController):
2021         * DumpRenderTree/win/DumpRenderTree.cpp:
2022         (resetWebViewToConsistentStateBeforeTesting):
2023         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2024         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2025         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2026         (LayoutTestController):
2027
2028 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2029
2030         Move allowRoundingHacks to Internals interface
2031         https://bugs.webkit.org/show_bug.cgi?id=87328
2032
2033         Reviewed by Hajime Morita.
2034
2035         Remove allowRoundingHacks functions, because it is able to work in the
2036         cross-port way through the Internals interface.
2037
2038         * DumpRenderTree/LayoutTestController.cpp:
2039         (LayoutTestController::staticFunctions):
2040         * DumpRenderTree/LayoutTestController.h:
2041         (LayoutTestController):
2042         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2043         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2044         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2045         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2046         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2047         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2048
2049 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2050
2051         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2052         https://bugs.webkit.org/show_bug.cgi?id=87616
2053
2054         Reviewed by Hajime Morita.
2055
2056         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2057         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2058         Patch just adds a #ifndef / #define check.
2059
2060         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2061         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2062
2063 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2064
2065         [EFL] Enable blob support for the EFL port
2066         https://bugs.webkit.org/show_bug.cgi?id=85363
2067
2068         Reviewed by Hajime Morita.
2069
2070         Enable Blob support by default for the EFL port.
2071
2072         * Scripts/webkitperl/FeatureList.pm:
2073
2074 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2075
2076         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2077         https://bugs.webkit.org/show_bug.cgi?id=87582
2078
2079         Reviewed by Darin Adler.
2080
2081         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2082         possible to test pages in a similar way as they are loaded in Browsers.
2083
2084         * DumpRenderTree/LayoutTestController.cpp:
2085         (LayoutTestController::LayoutTestController):
2086         (setUseDeferredFrameLoadingCallback):
2087         (LayoutTestController::staticFunctions):
2088         * DumpRenderTree/LayoutTestController.h:
2089         (LayoutTestController::useDeferredFrameLoading):
2090         (LayoutTestController::setUseDeferredFrameLoading):
2091         (LayoutTestController):
2092         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2093         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2094
2095 2012-05-27  David Barton  <dbarton@mathscribe.com>
2096
2097         [watchlist] Improve MathML rule
2098         https://bugs.webkit.org/show_bug.cgi?id=87592
2099
2100         Reviewed by Adam Barth.
2101
2102         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2103         but if this changed the rule would be slow. We protect against this, clarify the rule,
2104         and make it more similar to existing rules.
2105
2106         * Scripts/webkitpy/common/config/watchlist:
2107
2108 2012-05-27  David Barton  <dbarton@mathscribe.com>
2109
2110         [watchlist] Add myself & a rule for MathML
2111         https://bugs.webkit.org/show_bug.cgi?id=87586
2112
2113         Reviewed by Adam Barth.
2114
2115         * Scripts/webkitpy/common/config/watchlist:
2116
2117 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2118
2119         Use xcrun to find path to nm for Mac port
2120         <http://webkit.org/b/87588>
2121
2122         Reviewed by Dan Bernstein.
2123
2124         * Scripts/webkitpy/layout_tests/port/mac.py:
2125         (MacPort.nm_command): Add. Tries to find a path for the nm
2126         command using xcrun.  Falls back to returning 'nm'.
2127         * Scripts/webkitpy/layout_tests/port/webkit.py:
2128         (WebKitPort.nm_command): Add. Returns 'nm'.
2129         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2130
2131 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2132
2133         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2134
2135         Reviewed by Eric Seidel.
2136
2137         * DumpRenderTree/win/DumpRenderTree.vcproj:
2138         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2139         (FrameLoadDelegate::FrameLoadDelegate):
2140         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2141         * DumpRenderTree/win/FrameLoadDelegate.h:
2142         (FrameLoadDelegate):
2143         * DumpRenderTree/win/TextInputController.cpp: Added.
2144         (setMarkedTextCallback):
2145         (hasMarkedTextCallback):
2146         (unmarkTextCallback):
2147         (markedRangeCallback):
2148         (insertTextCallback):
2149         (firstRectForCharacterRangeCallback):
2150         (selectedRangeCallback):
2151         (TextInputController::makeWindowObject):
2152         (TextInputController::getJSClass):
2153         (TextInputController::staticValues):
2154         (TextInputController::staticFunctions):
2155         * DumpRenderTree/win/TextInputController.h: Added.
2156         (TextInputController):
2157         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2158         (TextInputController::setMarkedText):
2159         (TextInputController::hasMarkedText):
2160         (TextInputController::unmarkText):
2161         (TextInputController::markedRange):
2162         (TextInputController::insertText):
2163         (TextInputController::firstRectForCharacterRange):
2164         (TextInputController::selectedRange):
2165
2166 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2167
2168         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2169         https://bugs.webkit.org/show_bug.cgi?id=87528
2170
2171         Reviewed by Ojan Vafai.
2172
2173         launching git or svn for individual files can be slow; this
2174         change will hand multiple paths at once to git and svn so they
2175         can be added in a batch.
2176
2177         * Scripts/webkitpy/common/checkout/scm/git.py:
2178         (Git.add_list):
2179         (Git.delete_list):
2180         * Scripts/webkitpy/common/checkout/scm/scm.py:
2181         (SCM.add):
2182         (SCM):
2183         (SCM.add_list):
2184         (SCM.delete):
2185         (SCM.delete_list):
2186         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2187         (MockSCM.add):
2188         (MockSCM):
2189         (MockSCM.add_list):
2190         (MockSCM.delete):
2191         (MockSCM.delete_list):
2192         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2193         (_shared_test_exists):
2194         (_shared_test_added_files):
2195         (_test_delete_list):
2196         * Scripts/webkitpy/common/checkout/scm/svn.py:
2197         (SVN.add_list):
2198         (SVN.delete_list):
2199
2200 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2201
2202         [NRWT] Add unit testing for perf tests on locked shards
2203         https://bugs.webkit.org/show_bug.cgi?id=87489
2204
2205         Reviewed by Dirk Pranke.
2206
2207         Adding utests that makes sure that perf tests are running in locked
2208         shards and by passing --no-http won't break NRWT (r118421).
2209
2210         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2211         (ShardingTests):
2212         (ShardingTests.test_shard_by_dir):
2213         (ShardingTests.test_shard_every_file):
2214         (ShardingTests.test_shard_in_two):
2215         (ShardingTests.test_multiple_locked_shards):
2216         (LockCheckingManager):
2217         (LockCheckingManager.__init__):
2218         (LockCheckingManager.handle_finished_list):
2219         (ManagerTest.test_http_locking):
2220         (ManagerTest):
2221         (ManagerTest.test_perf_locking):
2222         * Scripts/webkitpy/layout_tests/port/test.py:
2223
2224 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2225
2226         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2227         https://bugs.webkit.org/show_bug.cgi?id=87511
2228
2229         Reviewed by Alexey Proskuryakov.
2230
2231         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2232
2233         * DumpRenderTree/win/EventSender.cpp:
2234         (keyDownCallback):
2235
2236 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2237
2238         Adding Ken Buchanan to committers.py
2239         https://bugs.webkit.org/show_bug.cgi?id=87443
2240
2241         Unreviewed.
2242
2243         Adding self to committers.py as a Committer.
2244
2245         * Scripts/webkitpy/common/config/committers.py:
2246
2247 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2248
2249         [Qt] Buildfix for newer Qt5
2250         https://bugs.webkit.org/show_bug.cgi?id=87257
2251
2252         Reviewed by Simon Hausmann.
2253
2254         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2255
2256 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2257
2258         [Qt] Unreviewed fix after r118484.
2259
2260         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2261         They were enabled uncoditinally before r118484.
2262
2263         * qmake/mkspecs/features/features.pri:
2264
2265 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2266
2267         Add feature defines for web-facing parts of CSS Regions and Exclusions
2268         https://bugs.webkit.org/show_bug.cgi?id=87442
2269         <rdar://problem/10887709>
2270
2271         Reviewed by Dan Bernstein.
2272
2273         * Scripts/webkitperl/FeatureList.pm:
2274
2275 2012-05-24  Hironori Bono  <hbono@chromium.org>
2276
2277         Enable grammar checking on Chromium when we paste text (Take 2)
2278         https://bugs.webkit.org/show_bug.cgi?id=74393
2279
2280         Reviewed by Ryosuke Niwa.
2281
2282         This change enables grammar checking on Chromium and implements a mock grammar
2283         checker to fix a failing test.
2284
2285         * DumpRenderTree/DumpRenderTree.gypi:
2286         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2287         (MockGrammarCheck::checkGrammarOfString):
2288         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2289         (WebKit):
2290         (MockGrammarCheck):
2291         * DumpRenderTree/chromium/WebViewHost.cpp:
2292         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2293
2294 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2295
2296         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2297         https://bugs.webkit.org/show_bug.cgi?id=86842
2298
2299         Reviewed by Antonio Gomes.
2300
2301         Add support for overriding the application cache support preference
2302         through EFL's LayoutTestController.
2303
2304         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2305         (LayoutTestController::overridePreference):
2306
2307 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2308
2309         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2310         https://bugs.webkit.org/show_bug.cgi?id=85209
2311
2312         Reviewed by Antonio Gomes.
2313
2314         Set developer extras setting called twice on the test startup. Hence, removing
2315         an unnecessary extra call which set wrong value. 
2316
2317         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2318         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2319
2320 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2321
2322         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2323         https://bugs.webkit.org/show_bug.cgi?id=86916
2324
2325         Reviewed by Adam Barth.
2326
2327         Note that if release and debug are failing differently, debug
2328         will be ignored ...
2329
2330         Note: also change the use of a fake port name from
2331         "mock-port-name" to "test-mac-leopard" to make it more friendly
2332         to the port factory ("mock" actually is a real port).
2333
2334         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2335         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2336         (GardeningHTTPRequestHandler.rebaselineall):
2337         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2338         (GardeningServerTest.test_rebaselineall):
2339         (GardeningServerTest.test_rebaseline_new_port):
2340
2341 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2342
2343         nrwt: fix baseline search path for official chrome builders
2344         https://bugs.webkit.org/show_bug.cgi?id=87432
2345
2346         Reviewed by Tony Chang.
2347
2348         The official chrome builders need to use the win7 and SL
2349         baseline paths, not the XP and Leopard paths. Linux is correct.
2350
2351         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2352         (GoogleChromeMacPort.determine_full_port_name):
2353         (GoogleChromeWinPort.determine_full_port_name):
2354         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2355         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2356         (TestGoogleChromePort.test_get_google_chrome_port):
2357
2358 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2359
2360         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2361         https://bugs.webkit.org/show_bug.cgi?id=86800
2362
2363         Reviewed by Dirk Pranke.
2364
2365         Don't launch a HTTP server with lock based only on the existence of
2366         locked shards since we now run perf on locked shards too.
2367
2368         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2369         (Manager._run_tests):
2370
2371 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2372
2373         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2374         https://bugs.webkit.org/show_bug.cgi?id=87128
2375
2376         Reviewed by Dirk Pranke.
2377
2378         * Scripts/webkitpy/layout_tests/port/base.py:
2379         (Port.driver_name):
2380         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2381         (ChromiumLinuxPort._path_to_driver):
2382         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2383         (ChromiumPortTest.test_driver_name_option):
2384         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2385         (ChromiumWinPort._path_to_driver):
2386         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2387         (parse_args):
2388
2389 2012-05-24  John Mellor  <johnme@chromium.org>
2390
2391         Font Boosting: Add compile flag and runtime setting
2392         https://bugs.webkit.org/show_bug.cgi?id=87394
2393
2394         Reviewed by Adam Barth.
2395
2396         Add ENABLE_FONT_BOOSTING.
2397
2398         * Scripts/webkitperl/FeatureList.pm:
2399         * qmake/mkspecs/features/features.pri:
2400
2401 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2402
2403         [EFL] [DRT] keyboard-related tests do not pass
2404         https://bugs.webkit.org/show_bug.cgi?id=85369
2405
2406         Reviewed by Gustavo Noronha Silva.
2407
2408         Add SHIFT modifier for capital letters as VK_ 
2409         codes do not distinguish between lows and caps and also to be consistent
2410         with other ports which send caps as lowercase letters with the shift key down.
2411
2412         * DumpRenderTree/efl/EventSender.cpp:
2413         (keyNameFromJSValue): 
2414
2415 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2416
2417         [WK2] Let the client give local files universal access on a case by case basis
2418         https://bugs.webkit.org/show_bug.cgi?id=87174
2419         <rdar://problem/11024330>
2420
2421         Reviewed by Maciej Stachowiak.
2422
2423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2424         Added initialization of a new structure member to prevent build failure.
2425
2426 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2427
2428         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2429         https://bugs.webkit.org/show_bug.cgi?id=87203
2430
2431         Reviewed by Andreas Kling.
2432
2433         Add the required changes to make
2434         fast/events/keydown-leftright-keys.html pass after r118001.
2435
2436         * DumpRenderTree/efl/EventSender.cpp:
2437         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2438         into the proper X11 keysym definitions.
2439
2440 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2441
2442         Unreviewed, rolling out r118352.
2443         http://trac.webkit.org/changeset/118352
2444         https://bugs.webkit.org/show_bug.cgi?id=87390
2445
2446         Caused 6 editing/spelling tests crash/fail on chromium in
2447         debug. (Requested by vsevik on #webkit).
2448
2449         * DumpRenderTree/DumpRenderTree.gypi:
2450         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2451         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2452         * DumpRenderTree/chromium/WebViewHost.cpp:
2453         (WebViewHost::finishLastTextCheck):
2454
2455 2012-05-24  Peter Beverloo  <peter@chromium.org>
2456
2457         Add John Mellor as a contributor
2458         https://bugs.webkit.org/show_bug.cgi?id=87389
2459
2460         Reviewed by Kenneth Rohde Christiansen.
2461
2462         John will be working on Font Boosting and is very involved with various
2463         web-facing subjects of Chrome for Android, such as viewport.
2464
2465         * Scripts/webkitpy/common/config/committers.py:
2466
2467 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2468
2469         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2470         https://bugs.webkit.org/show_bug.cgi?id=86840
2471
2472         Reviewed by Csaba Osztrogonác.
2473
2474         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2475         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2476         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2477         (LayoutTestController::setCacheModel): Implementation added.
2478
2479 2012-05-24  Hironori Bono  <hbono@chromium.org>
2480
2481         Enable grammar checking on Chromium when we paste text.
2482         https://bugs.webkit.org/show_bug.cgi?id=74393
2483
2484         Reviewed by Hajime Morita.
2485
2486         This change enables grammar checking on Chromium and implements a mock grammar
2487         checker to fix a failing test.
2488
2489         * DumpRenderTree/DumpRenderTree.gypi:
2490         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2491         (MockGrammarCheck::checkGrammarOfString):
2492         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2493         (WebKit):
2494         (MockGrammarCheck):
2495         * DumpRenderTree/chromium/WebViewHost.cpp:
2496         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2497
2498 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2499
2500         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2501
2502         * qmake/mkspecs/features/features.pri:
2503
2504 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2505
2506         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2507         https://bugs.webkit.org/show_bug.cgi?id=86867
2508
2509         Reviewed by Adam Barth.
2510
2511         Add implementation for sendWebIntentResponse() in EFL's
2512         LayoutTestController and add empty implementation for other ports.
2513
2514         * DumpRenderTree/LayoutTestController.cpp:
2515         (sendWebIntentResponseCallback):
2516         (LayoutTestController::staticFunctions):
2517         * DumpRenderTree/LayoutTestController.h:
2518         (LayoutTestController):
2519         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2520         (LayoutTestController::sendWebIntentResponse):
2521         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2522         (DumpRenderTreeChrome::currentIntentRequest):
2523         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2524         (DumpRenderTreeChrome::onFrameIntentNew):
2525         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2526         (DumpRenderTreeChrome):
2527         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2528         (LayoutTestController::sendWebIntentResponse):
2529         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2530         (LayoutTestController::sendWebIntentResponse):
2531         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2532         (LayoutTestController::sendWebIntentResponse):
2533         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2534         (LayoutTestController::sendWebIntentResponse):
2535         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2536         (LayoutTestController::sendWebIntentResponse):
2537
2538 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2539
2540         [EFL] The EFL port has no support for title directionality
2541         https://bugs.webkit.org/show_bug.cgi?id=86462
2542
2543         Reviewed by Gustavo Noronha Silva.
2544
2545         Update "title,changed" signal handlers in DRT and EWebLauncher to
2546         reflect the change from const char* to Ewk_Text_With_Direction* type
2547         for the title.
2548
2549         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2550         (DumpRenderTreeChrome::onTitleChanged):
2551         * EWebLauncher/main.c:
2552         (title_set):
2553         (on_title_changed):
2554         (on_key_down):
2555
2556 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2557
2558         Change EFL debug build name with more detail one
2559         https://bugs.webkit.org/show_bug.cgi?id=87254
2560
2561         Reviewed by Ryosuke Niwa.
2562
2563         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2564         In addition, remove efl-linux-debug triggerable since nobody uses it.
2565
2566         * BuildSlaveSupport/build.webkit.org-config/config.json:
2567
2568 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2569
2570         [EFL][DRT] Fix WebCore library path and rebaseline result
2571         https://bugs.webkit.org/show_bug.cgi?id=86355
2572
2573         Reviewed by Dirk Pranke.
2574
2575         Currently EFL DRT uses wrong WebCore library path when running DRT.
2576         Therefore, this patch adjusted the path correctly.
2577
2578         * Scripts/webkitpy/layout_tests/port/efl.py:
2579         (EflPort._path_to_webcore_library):
2580
2581 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2582
2583         add back the ability to disable flexbox
2584         https://bugs.webkit.org/show_bug.cgi?id=87147
2585
2586         Reviewed by Tony Chang.
2587
2588         * Scripts/webkitperl/FeatureList.pm:
2589
2590 2012-05-23  Tony Chang  <tony@chromium.org>
2591
2592         Remove the Chromium Grid Layout bot from the waterfall
2593         https://bugs.webkit.org/show_bug.cgi?id=87311
2594
2595         Reviewed by Ryosuke Niwa.
2596
2597         I removed the compiler define in r117613, so we don't need a separate
2598         bot to compile/test this code.
2599
2600         * BuildSlaveSupport/build.webkit.org-config/config.json:
2601
2602 2012-05-23  Ian Vollick  <vollick@chromium.org>
2603
2604         Add vollick to list of contributors.
2605         https://bugs.webkit.org/show_bug.cgi?id=87305
2606
2607         Reviewed by Adam Barth.
2608
2609         * Scripts/webkitpy/common/config/committers.py:
2610
2611 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2612
2613         [Chromium-Android] Fix chromium_android_unittest
2614         https://bugs.webkit.org/show_bug.cgi?id=87196
2615
2616         Reviewed by Tony Chang.
2617
2618         Update unit tests after ChromiumAndroidPort supported apk based
2619         DumpRenderTree.
2620
2621         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2622         (ChromiumAndroidPortTest):
2623         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2624         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2625         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2626         (ChromiumAndroidDriverTest):
2627         (ChromiumAndroidDriverTest.setUp):
2628         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2629         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2630
2631 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2632
2633         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2634         https://bugs.webkit.org/show_bug.cgi?id=87303
2635
2636         Reviewed by Alexis Menard.
2637
2638         * Scripts/webkitpy/common/config/watchlist:
2639
2640 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2641
2642         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2643         https://bugs.webkit.org/show_bug.cgi?id=86916
2644
2645         Reviewed by Adam Barth.
2646
2647         This change pushes all of the logic for rebaselining a cluster
2648         of failures (a list of tests failing a list of suffixes on a
2649         list of bots) onto the server, so there is a single call from
2650         the web page; we will then be able to optimize the performance
2651         of the rebaselining better.
2652
2653         Also remove the 'optimizebaseline' entry point on garden-o-matic
2654         (and the client-side call) since we don't need it any more.
2655
2656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2658         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2659         (GardeningHTTPRequestHandler.rebaselineall):
2660         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2661
2662 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2663
2664         Mac DRT should be able to load external URLs for replay performance tests
2665         https://bugs.webkit.org/show_bug.cgi?id=86191
2666
2667         Reviewed by Alexey Proskuryakov.
2668
2669         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2670         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2671         "DumpRenderTree http://localhost:8000/".
2672
2673         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2674         (isLocalhost):
2675         (hostIsUsedBySomeTestsToGenerateError):
2676         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2677
2678 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2679
2680         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2681         debug symbols for easier debugging.
2682         https://bugs.webkit.org/show_bug.cgi?id=87151
2683
2684         Reviewed by Kevin Ollivier.
2685
2686         * waf/build/settings.py:
2687         (common_configure):
2688
2689 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2690
2691         Unreviewed. Move myself to reviewers.
2692
2693         * Scripts/webkitpy/common/config/committers.py:
2694
2695 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2696
2697         [EFL] Implements the registerProtocolHandler method and option.
2698         https://bugs.webkit.org/show_bug.cgi?id=73638
2699
2700         Reviewed by Andreas Kling.
2701
2702         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2703
2704 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2705
2706         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2707         https://bugs.webkit.org/show_bug.cgi?id=87221
2708
2709         Reviewed by Martin Robinson.
2710
2711         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2712         rightShift key names into proper GDK key symbols.
2713
2714         * DumpRenderTree/gtk/EventSender.cpp:
2715         (createKeyPressEvent):
2716
2717 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2718
2719         [Qt] Make the web view's url property follow the active url
2720
2721         https://bugs.webkit.org/show_bug.cgi?id=77554
2722
2723         Update  the location bar in the minibrowser to behave
2724         a bit more like normal browsers in terms of when the url will change
2725         and how active focus is handled.
2726
2727         Reviewed by Simon Hausmann.
2728
2729         * MiniBrowser/qt/qml/BrowserWindow.qml:
2730
2731 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2732
2733         [Qt] Remove references to $$QT_SOURCE_TREE
2734
2735         With a modularized Qt, it's ambigious. What we really want is qtbase,
2736         which qtcore is a proxy for (we assume it will always live in qtbase).
2737
2738         Reviewed by Tor Arne Vestbø.
2739
2740         * DumpRenderTree/qt/DumpRenderTree.pro:
2741
2742 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2743
2744         [Qt] Fix qmake conditional for c++-11 compat warnings
2745
2746         Reviewed by Tor Arne Vestbø.
2747
2748         * qmake/mkspecs/features/unix/default_post.prf:
2749
2750 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2751
2752         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2753         https://bugs.webkit.org/show_bug.cgi?id=85956
2754
2755         Reviewed by Gustavo Noronha Silva.
2756
2757         Catch new "load,provisional,failed" signal and print
2758         didFailProvisionalLoadWithError messages when LayoutTestController's
2759         dumpFrameLoadCallbacks() returns true. Also make sure the
2760         didFailLoadWithError message is not printed in case of provisional
2761         load failure.
2762
2763         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2764         (DumpRenderTreeChrome::createView):
2765         (DumpRenderTreeChrome::onFrameCreated):
2766         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2767         (DumpRenderTreeChrome::onFrameLoadError):
2768         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2769         (DumpRenderTreeChrome):
2770
2771 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2772
2773         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2774         https://bugs.webkit.org/show_bug.cgi?id=86366
2775
2776         Reviewed by Antonio Gomes.
2777
2778         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2779
2780         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2781         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2782
2783 2012-05-22  Darin Adler  <darin@apple.com>
2784
2785         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2786         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2787
2788 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2789
2790         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2791         https://bugs.webkit.org/show_bug.cgi?id=86922
2792
2793         Because we have new platformInit() in TestShellAndroid.cpp, and
2794         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2795         is split into TestShellPosix.cpp and TestShellX11.cpp.
2796
2797         Reviewed by Kent Tamura.
2798
2799         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2800         * DumpRenderTree/DumpRenderTree.gypi:
2801         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2802         (platformInit):
2803         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2804         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2805         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2806         (AlarmHandler):
2807         (TestShell::waitTestFinished):
2808         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2809         (openStartupDialog): from TestShellGtk.cpp
2810         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2811         (setupFontconfig):
2812         (platformInit):
2813
2814 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2815
2816         [EFL][DRT] Implement touch event
2817         https://bugs.webkit.org/show_bug.cgi?id=86720
2818
2819         Reviewed by Hajime Morita.
2820
2821         Currently EFL DRT doesn't support touch event.
2822         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2823
2824         * DumpRenderTree/efl/EventSender.cpp:
2825         (TouchEventInfo::TouchEventInfo):
2826         (TouchEventInfo):
2827         (touchPointList):
2828         (sendTouchEvent):
2829         (addTouchPointCallback):
2830         (touchStartCallback):
2831         (updateTouchPointCallback):
2832         (touchMoveCallback):
2833         (cancelTouchPointCallback):
2834         (touchCancelCallback):
2835         (releaseTouchPointCallback):
2836         (touchEndCallback):
2837         (clearTouchPointsCallback):
2838         (setTouchModifierCallback):
2839         * Scripts/webkitperl/FeatureList.pm:
2840
2841 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2842
2843         [Chromium-Android] Fix chromium_android_unittest
2844         https://bugs.webkit.org/show_bug.cgi?id=87196
2845
2846         Not reviewed.
2847         Temporarily disable chromium_android_unittest.
2848
2849         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2850         (ChromiumAndroidPortTest):
2851         (ChromiumAndroidDriverTest):
2852
2853 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2854
2855         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2856         https://bugs.webkit.org/show_bug.cgi?id=64313
2857
2858         Reviewed by Jon Honeycutt.
2859
2860         Add it.
2861
2862         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2863         Make sure to generate the binding.
2864
2865         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2866         (WTR::LayoutTestController::setDefersLoading):
2867         Call WKBundlePageSetDefersLoading.
2868         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2869
2870 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2871
2872         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2873         https://bugs.webkit.org/show_bug.cgi?id=86923
2874
2875         chromium_android.py is modified to support running DumpRenderTree as
2876         an apk, so that we can run the tests (e.g. video) requiring features
2877         implemented in Java on Android.
2878
2879         Reviewed by Adam Barth.
2880
2881         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2882         (ChromiumAndroidPort.__init__):
2883         (ChromiumAndroidPort.default_child_processes):
2884         (ChromiumAndroidPort.check_wdiff):
2885         (ChromiumAndroidPort.check_build):
2886         (ChromiumAndroidPort.start_helper):
2887         (ChromiumAndroidPort.skipped_layout_tests):
2888         (ChromiumAndroidPort):
2889         (ChromiumAndroidPort._path_to_driver):
2890         (ChromiumAndroidPort._get_crash_log):
2891         (ChromiumAndroidPort._push_executable):
2892         (ChromiumAndroidPort._run_adb_command):
2893         (ChromiumAndroidPort._get_last_stacktrace):
2894         (ChromiumAndroidPort._get_logcat):
2895         (ChromiumAndroidPort._setup_performance):
2896         (ChromiumAndroidDriver):
2897         (ChromiumAndroidDriver.__init__):
2898         (ChromiumAndroidDriver._command_wrapper):
2899         (ChromiumAndroidDriver.cmd_line):
2900         (ChromiumAndroidDriver._file_exists_on_device):
2901         (ChromiumAndroidDriver._deadlock_detector):
2902         (ChromiumAndroidDriver._start):
2903         (ChromiumAndroidDriver.run_test):
2904         (ChromiumAndroidDriver.stop):
2905         (ChromiumAndroidDriver._write_command_and_read_line):
2906         (ChromiumAndroidDriver._output_image):
2907         (ChromiumAndroidDriver._get_stderr):
2908
2909 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2910
2911         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2912
2913         Unreviewed gardening.
2914
2915         * Scripts/webkitpy/layout_tests/port/base.py:
2916         (Port.driver_name):
2917         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2918         (ChromiumLinuxPort._path_to_driver):
2919         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2920         (ChromiumPortTest.test_overrides_and_builder_names):
2921         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2922         (ChromiumWinPort._path_to_driver):
2923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2924         (parse_args):
2925
2926 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2927
2928         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2929         https://bugs.webkit.org/show_bug.cgi?id=87176
2930
2931         Reviewed by Tony Chang.
2932
2933         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2934         * DumpRenderTree/DumpRenderTree.gypi:
2935
2936 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2937
2938         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2939         https://bugs.webkit.org/show_bug.cgi?id=87128
2940
2941         Reviewed by Dirk Pranke.
2942
2943         * Scripts/webkitpy/layout_tests/port/base.py:
2944         (Port.driver_name):
2945         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2946         (ChromiumLinuxPort._path_to_driver):
2947         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2948         (ChromiumPortTest.test_driver_name_option):
2949         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2950         (ChromiumWinPort._path_to_driver):
2951         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2952         (parse_args):
2953
2954 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2955
2956         WTR fix after r118001.
2957
2958         Rubber-stamped by Alexey Proskuryakov.
2959
2960         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2961
2962         * WebKitTestRunner/mac/EventSenderProxy.mm:
2963         (WTR::EventSenderProxy::keyDown):
2964
2965 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2966
2967         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2968         https://bugs.webkit.org/show_bug.cgi?id=86684
2969
2970         Reviewed by Darin Fisher.
2971
2972         * DumpRenderTree/chromium/LayoutTestController.cpp:
2973         (LayoutTestController::numberOfPages):
2974         * DumpRenderTree/chromium/WebViewHost.cpp:
2975         (WebViewHost::printPage):
2976
2977 == Rolled over to ChangeLog-2012-05-22 ==