Content area does not return to the correct position after rubberbanding
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-03  Anders Carlsson  <andersca@apple.com>
2
3         Remove custom scrollbar painting hooks
4         https://bugs.webkit.org/show_bug.cgi?id=69163
5
6         Reviewed by Alexey Proskuryakov.
7
8         * DumpRenderTree/chromium/WebPreferences.cpp:
9         (WebPreferences::applyTo):
10         No need to enable custom scrollbar painting.
11
12 2011-10-03  David Levin  <levin@chromium.org>
13
14         watchlist: Make watchlist run on a bot.
15         https://bugs.webkit.org/show_bug.cgi?id=68974
16
17         Reviewed by Adam Barth.
18
19         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
20         * Scripts/webkitpy/tool/commands/queues_unittest.py:
21         Change to log what is run so that we can see the style command
22         and the watchlist command being run.
23
24 2011-10-03  David Levin  <levin@chromium.org>
25
26         watchlist: Allow specified a bug to attach the watchlist info to.
27         https://bugs.webkit.org/show_bug.cgi?id=69288
28
29         Reviewed by Eric Seidel.
30
31         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
32         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
33         Add tests and fix an existing test because the unit tests do not go through the
34         normal command line processing (so the -g argument remained when we determined bug ids).
35         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
36         get the assert raises regex method.
37         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
38
39 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
40
41         [EFL] DRT: Add JSStringUtils.{cpp,h}
42         https://bugs.webkit.org/show_bug.cgi?id=66397
43
44         Reviewed by Ryosuke Niwa.
45         
46         Adds helper functions to compare the equality of C-style strings and
47         JSStringRef objects.
48
49         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
50         (equals):
51         * DumpRenderTree/efl/JSStringUtils.h: Added.
52
53 2011-10-03  Adam Barth  <abarth@webkit.org>
54
55         garden-o-matic should work in Safari 5.1
56         https://bugs.webkit.org/show_bug.cgi?id=69290
57
58         Reviewed by Sam Weinig.
59
60         My old implementation of bind was too clever by half.  This one seems
61         to work better, at least according to this test.
62
63         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
64         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
65
66 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
67
68         Unreviewed: change my e-mail in commiters.py
69
70         (I'm leaving the company and my @openbossa.org will be no more)
71
72         * Scripts/webkitpy/common/config/committers.py:
73
74 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
75
76         [GTK] Fix memory leak when loading url
77         https://bugs.webkit.org/show_bug.cgi?id=69247
78
79         Reviewed by Martin Robinson.
80
81         Release URL created with WKURLCreateWithUTF8CString().
82
83         * MiniBrowser/gtk/BrowserWindow.c:
84         (activateUriEntryCallback):
85         * MiniBrowser/gtk/main.c:
86         (loadURI):
87
88 2011-10-03  Csaba Osztrogonác  <ossy@webkit.org>
89
90         Unreviewed. Add Zoltán Árvai as contributor.
91
92         * Scripts/webkitpy/common/config/committers.py:
93
94 2011-10-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
95
96         [EFL] DRT: Add DumpHistoryItem.{cpp,h}
97         https://bugs.webkit.org/show_bug.cgi?id=63992
98
99         Reviewed by Antonio Gomes.
100
101         This is the code responsible for dumping the back and forward history
102         list.
103
104         * DumpRenderTree/efl/DumpHistoryItem.cpp: Added.
105         (dumpHistoryItem):
106         (dumpBackForwardListForWebView):
107         (dumpBackForwardListForWebViews):
108         * DumpRenderTree/efl/DumpHistoryItem.h: Added.
109
110 2011-10-03  Zeno Albisser  <zeno.albisser@nokia.com>
111
112         [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
113         https://bugs.webkit.org/show_bug.cgi?id=69223
114
115         WebKitTestRunner must include Qt / qnamespace header
116         to get a definition of Qt::MouseButtons.
117
118         Reviewed by Andreas Kling.
119
120         * WebKitTestRunner/EventSenderProxy.h:
121
122 2011-10-03  Csaba Osztrogonác  <ossy@webkit.org>
123
124         Unreviewed. Add Zoltán Árvai as contributor.
125
126         * Scripts/webkitpy/common/config/committers.py:
127
128 2011-10-02  Adam Barth  <abarth@webkit.org>
129
130         Clean up obsolete code in gardeningserver.py related to
131         STATIC_FILE_NAMES.  Rather than serve the UI via the Python HTTP
132         server, we just serve it off the filesystem directly.
133
134         We had planned to serve the UI off build.webkit.org, but that server is
135         somewhat slow.  We'll probably serve the UI of some web server, but
136         we'll need to work that out later.
137
138         * Scripts/webkitpy/tool/commands/gardenomatic.py:
139         * Scripts/webkitpy/tool/servers/gardeningserver.py:
140
141 2011-10-02  Adam Barth  <abarth@webkit.org>
142
143         Rip out half-backed garden-o-matic features in preparation for wider use
144         https://bugs.webkit.org/show_bug.cgi?id=69226
145
146         This patch rips out a bunch of half-baked features and cleans up a
147         bunch of small nits with the core set of features.  We're going to ask
148         more folks to start using the tool, and having a bunch of half-baked
149         features around is distracting.  We can add these features back under a
150         flag and interate on them after we've got the core functionality
151         nailed.
152
153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
162
163 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
164
165         Correct post-build step for WinCairo test runs.
166         https://bugs.webkit.org/show_bug.cgi?id=69191 
167
168         Reviewed by Brian Weinstein.
169
170         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
171         shell case to handle the CFLite build.
172
173 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
174
175         Added myself to reviewers, because I'm now a reviewer.
176
177         * Scripts/webkitpy/common/config/committers.py:
178
179 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
180
181         Bencher script makes it difficult to do automated performance testing
182         https://bugs.webkit.org/show_bug.cgi?id=69207
183
184         Reviewed by Sam Weinig.
185         
186         This adds two new features:
187         
188         The ability to disable automatic VM detection, which is flaky if any
189         profiling features are enabled in jsc.
190         
191         The ability to compute, and report, a scaled result for all benchmark
192         suites. It is the geometric mean of three numbers: SunSpider's
193         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
194         It is also possible to turn off all other output from bencher and just
195         get this number with the --brief option.
196
197         * Scripts/bencher:
198
199 2011-10-01  Sam Weinig  <sam@webkit.org>
200
201         WTR is not successfully changing the NSUserDefaults
202         https://bugs.webkit.org/show_bug.cgi?id=69204
203
204         Reviewed by Dan Bernstein.
205
206         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
207         (WTR::InjectedBundle::platformInitialize):
208         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
209         get our overrides picked up.
210
211 2011-09-30  Daniel Bates  <dbates@rim.com>
212
213         Cleanup: Extract code to launch a Mac WebKit application into a common function
214         https://bugs.webkit.org/show_bug.cgi?id=68662
215
216         Reviewed by Adam Roben.
217
218         Extracts common code to launch a WebKit application on Mac OS X into a function
219         so that we can remove duplicate code.
220
221         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
222         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
223         (runMacWebKitApp): Added.
224         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
225         (runMiniBrowser): Ditto.
226         (runWebKitTestRunner): Ditto.
227         (runTestWebKitAPI): Ditto.
228
229 2011-09-29  David Levin  <levin@chromium.org>
230
231         watchlist: Add webkit-patch command to run watchlist.
232         https://bugs.webkit.org/show_bug.cgi?id=68973
233
234         Reviewed by Eric Seidel.
235
236         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
237         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
238         the cc and messages as sorted lists. To allow for deterministic ordering.
239         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
240         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
241         that it will be exposed as a command by webkit-patch.
242         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
243         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
244         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
245         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
246         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
247         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
248         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
249         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
250
251 2011-09-30  David Levin  <levin@chromium.org>
252
253         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
254         https://bugs.webkit.org/show_bug.cgi?id=69031
255
256         Reviewed by Adam Barth.
257
258         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
259         a comment to explain something important about the email addresses, and
260         a comment to let emacs know to treat the file as a python file.
261         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
262         Detects increases or decreases in a pattern.
263         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
264         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
265         Added unit tests for watchlist which has "more" or "less".
266         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
267         Added support for "more" or "less".
268
269 2011-09-30  Sam Weinig  <sam@webkit.org>
270
271         Add support for eventSender.mouseScrollBy in WTR
272         https://bugs.webkit.org/show_bug.cgi?id=69189
273
274         Add implementation of eventSender.mouseScrollBy for the mac.
275
276         Reviewed by Simon Fraser.
277
278         * WebKitTestRunner/EventSenderProxy.h:
279         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
280         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
281         (WTR::EventSendingController::keyDown):
282         (WTR::EventSendingController::mouseScrollBy):
283         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
284         * WebKitTestRunner/TestController.cpp:
285         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
286         * WebKitTestRunner/mac/EventSenderProxy.mm:
287         (WTR::EventSenderProxy::mouseScrollBy):
288
289 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
290
291         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
292         https://bugs.webkit.org/show_bug.cgi?id=35273
293
294         Reviewed by Dan Bernstein.
295         
296         There are two types of font issue that can cause layout test failure.
297         First, the user may have non-standard fonts installed that affect the layout
298         of some tests. For example, some tests use the MS Gothic font if installed.
299         
300         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
301         which override the system fonts (e.g. a copy of Arial from MS Office). For
302         some tests, this can affect font metrics or fallback behavior.
303         
304         This change addresses the first problem only. It limits the set of fonts
305         available through NSFontManager, by swizzling some methods to return
306         a list of fonts or font families which only include fonts from a hardcoded
307         whitelist.
308         
309         * DumpRenderTree/mac/DumpRenderTree.mm:
310         (allowedFontFamilySet):
311         (drt_NSFontManager_availableFontFamilies):
312         (drt_NSFontManager_availableFonts):
313         (swizzleNSFontManagerMethods):
314         (activateTestingFonts):
315         (adjustFonts):
316         (createWebViewAndOffscreenWindow):
317         (prepareConsistentTestingEnvironment):
318         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
319         (WTR::allowedFontFamilySet):
320         (WTR::drt_NSFontManager_availableFontFamilies):
321         (WTR::drt_NSFontManager_availableFonts):
322         (WTR::swizzleNSFontManagerMethods):
323         (WTR::InjectedBundle::platformInitialize):
324
325 2011-09-30  David Levin  <levin@chromium.org>
326
327         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
328         https://bugs.webkit.org/show_bug.cgi?id=69039
329
330         Reviewed by Adam Barth.
331
332         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
333         Actually skip only one specific test that is failing on Windows.
334
335 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
336
337         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
338
339         For DRT we didn't install the message handler early enough to
340         catch output while constructing the QApplication. For WTR we
341         didn't even install a message handler.
342
343         Since the UI process will forward any output from the web process
344         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
345         in WTR before the web process is started. This is picked up by the
346         web process which installs its own message handler.
347
348         The environment variable can be overriden on the command line if you
349         want to see output from the web process, or you can pass --verbose to
350         WTR to see output from both processes.
351
352         https://bugs.webkit.org/show_bug.cgi?id=69132
353
354         Reviewed by Andreas Kling.
355
356         * DumpRenderTree/qt/main.cpp:
357         * WebKitTestRunner/qt/main.cpp:
358
359 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
360
361         [Qt] Make sure WTR sizes the window and item correctly
362
363         Revision 96345 changed the logic for how the view and
364         window was created, but missed a vital part, setting
365         the size.
366
367         We now use a QSGView for the window, that has a simple
368         item as its root object that is always resized to fit
369         within the window. The webview is then parented to the
370         root object and set to anchors.fill: parent. That way
371         any window geometry changes will propagate to the web
372         view.
373
374         https://bugs.webkit.org/show_bug.cgi?id=69134
375
376         Reviewed by Andreas Kling.
377
378         * WebKitTestRunner/PlatformWebView.h:
379         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
380
381 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
382
383         [EFL] Only save the current viewport in PixelDumpSupportEfl.
384         https://bugs.webkit.org/show_bug.cgi?id=68450
385
386         Reviewed by Antonio Gomes.
387
388         The previous implementation saved the whole page contents in the final
389         PNG, however the baselines and expectations in the tree only want the
390         current viewport (with a scrollbar, if needed), so we now only save the
391         currently visible contents.
392
393         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
394         (createBitmapContextFromWebView): Use
395         ewk_frame_visible_content_geometry_get instead of
396         ewk_frame_contents_size_get.
397
398 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
399
400         [EFL] Support and keep track of extra windows (views).
401         https://bugs.webkit.org/show_bug.cgi?id=68454
402
403         Reviewed by Antonio Gomes.
404
405         So far, window.open and related JavaScript code would not work, as
406         DRTView did not implementation
407         Ewk_View_Smart_Class::window_{open,close}. The default implementation
408         in ewk just returns the current window/view, which broke any
409         layouttest which relied on window.open.
410
411         We now properly create and remove these new views. Unfortunately, the
412         current way ewk works (and due to the fact that we cannot pass class
413         methods as function pointers to the EFL functions), DRTView needs to
414         know that DRTChrome exists and call `browser' directly in some points.
415
416         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
417         (onWindowCreate):
418         (onWindowCloseDelayed):
419         (onWindowClose):
420         (drtViewTiledAdd):
421
422 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
423
424         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
425         https://bugs.webkit.org/show_bug.cgi?id=42698
426
427         Reviewed by Andreas Kling.
428
429         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
430         and call clearApplicationCache when layoutTest start up.
431
432         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
433         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
434         (WTR::InjectedBundle::beginTesting):
435         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
436         (WTR::LayoutTestController::clearAllApplicationCaches):
437         (WTR::LayoutTestController::setAppCacheMaximumSize):
438         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
439
440 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
441
442         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
443         https://bugs.webkit.org/show_bug.cgi?id=69145
444
445         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
446         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
447         and is perfectly suitable for SceneGraph as well. GraphicsScene events
448         will not be available in QtGui anymore in future. Therefore we also have to change
449         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
450
451         Reviewed by Chang Shu.
452
453         * WebKitTestRunner/EventSenderProxy.h:
454         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
455         (WTR::EventSenderProxy::createMouseEvent):
456         (WTR::EventSenderProxy::mouseDown):
457         (WTR::EventSenderProxy::mouseUp):
458         (WTR::EventSenderProxy::mouseMoveTo):
459
460 2011-09-30  James Robinson  <jamesr@chromium.org>
461
462         [chromium] Add WebKit API for sending input events to the compositor thread
463         https://bugs.webkit.org/show_bug.cgi?id=69117
464
465         Reviewed by Darin Fisher.
466
467         Adds support for creating and setting a compositor thread in DRT.
468
469         * DumpRenderTree/chromium/WebViewHost.cpp:
470         (WebViewHost::WebViewHost):
471         * DumpRenderTree/chromium/WebViewHost.h:
472
473 2011-09-29  David Levin  <levin@chromium.org>
474
475         watchlist: Add cross-checks for WatchList once it is filled.
476         https://bugs.webkit.org/show_bug.cgi?id=68975
477
478         Reviewed by Eric Seidel.
479
480         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
481         instead of having trivial getter and setters.
482         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
483         pass the validation checks.
484         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
485         and fix a few style nits.
486         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
487         validation checks.
488         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
489
490 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
491
492         run-api-tests fails on chromium-win bot
493         https://bugs.webkit.org/show_bug.cgi?id=69121
494
495         On Windows running a perl script needs the interpreter.
496
497         Reviewed by Adam Barth.
498
499         * Scripts/run-api-tests:
500         (buildTestTool):
501
502 2011-09-29  Adam Barth  <abarth@webkit.org>
503
504         Attempt to make this tool work on Windows.
505
506         * Scripts/run-api-tests:
507         (buildTestTool):
508
509 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
510
511         [Qt] Try to fix the minial build
512
513         * QtTestBrowser/launcherwindow.cpp:
514         * QtTestBrowser/webpage.cpp:
515
516 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
517
518         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
519
520         QWidget and friends now live in the QtWidgets library. We update
521         includes in implementation files and private headers to us the
522         non-module-prefixed path, and leave the lookup for the include
523         path. For public headers we have to ifdef the includes as the
524         user might now have the modules we need in his QT config.
525
526         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
527         have to update our code and use windowHandle() for setting the
528         parent relationships.
529
530         https://bugs.webkit.org/show_bug.cgi?id=68687
531
532         Reviewed by Andreas Kling.
533
534         * DumpRenderTree/qt/DumpRenderTree.pro:
535         * DumpRenderTree/qt/ImageDiff.pro:
536         * MiniBrowser/qt/BrowserView.cpp:
537         * MiniBrowser/qt/BrowserView.h:
538         * MiniBrowser/qt/BrowserWindow.cpp:
539         * MiniBrowser/qt/BrowserWindow.h:
540         * MiniBrowser/qt/MiniBrowser.pro:
541         * MiniBrowser/qt/MiniBrowserApplication.h:
542         * MiniBrowser/qt/main.cpp:
543         * QtTestBrowser/QtTestBrowser.pro:
544         * QtTestBrowser/launcherwindow.cpp:
545         * QtTestBrowser/launcherwindow.h:
546         * QtTestBrowser/locationedit.h:
547         * QtTestBrowser/main.cpp:
548         * QtTestBrowser/mainwindow.cpp:
549         * QtTestBrowser/mainwindow.h:
550         * QtTestBrowser/webinspector.h:
551         * QtTestBrowser/webpage.cpp:
552         * QtTestBrowser/webview.cpp:
553         * WebKitTestRunner/PlatformWebView.h:
554         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
555
556 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
557
558         Initial implementation of WebInspector for WebKit2 GTK port.
559         https://bugs.webkit.org/show_bug.cgi?id=68235
560
561         Reviewed by Martin Robinson.
562
563         * MiniBrowser/gtk/BrowserWindow.c:
564         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
565
566 2011-09-29  Adam Barth  <abarth@webkit.org>
567
568         Unbreak the "update expectatations" button by using the existing
569         machinery to create the failureInfo objects.
570
571         Unbreak the "close" button on the progress dialog by using |this|
572         instead of the old name of the object.
573
574         Teach the controllers unit test not to talk to the actual network.
575
576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
579
580 2011-09-29  Hans Wennborg  <hans@chromium.org>
581
582         IndexedDB: Use LevelDB also for in-memory databases
583         https://bugs.webkit.org/show_bug.cgi?id=68903
584
585         Reviewed by Steve Block.
586
587         Remove the temporary dir that was necessary before LevelDB supported
588         in-memory databases.
589
590         * DumpRenderTree/chromium/TestShell.cpp:
591         (TestShell::TestShell):
592         * DumpRenderTree/chromium/TestShell.h:
593
594 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
595
596         Run TestWebKitAPI on Chromium buildbots
597         https://bugs.webkit.org/show_bug.cgi?id=68678
598
599         Reviewed by Tony Chang.
600
601         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
602
603 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
604
605         garden-o-matic results should anticipate 0 unexpected failures.
606         https://bugs.webkit.org/show_bug.cgi?id=69036
607
608         Also fixes controllers: UnexpectedFailures test.
609
610         Reviewed by Adam Barth.
611
612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
613
614 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
615
616         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
617
618         https://bugs.webkit.org/show_bug.cgi?id=67253
619
620         Reviewed by Eric Seidel.
621
622         Nearly all of the work in this was done by Simon Fraser; I'm
623         just repackaging it and cleaning it up a bit. This change
624         modifies port.diff_image() to return a tuple of (pass/fail,
625         %age), adds the value to the FailureImageHashMismatch, and
626         writes the value into the full_results.json files to be
627         displayed in the results page.
628
629         * Scripts/webkitpy/layout_tests/controllers/manager.py:
630         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
631         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
632         * Scripts/webkitpy/layout_tests/models/test_failures.py:
633         * Scripts/webkitpy/layout_tests/port/base.py:
634         * Scripts/webkitpy/layout_tests/port/chromium.py:
635         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
636         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
637         * Scripts/webkitpy/layout_tests/port/test.py:
638         * Scripts/webkitpy/layout_tests/port/webkit.py:
639         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
640
641 2011-09-25  Kentaro Hara  <haraken@chromium.org>
642
643         Unreviewed. Adding myself to committers.py.
644
645         * Scripts/webkitpy/common/config/committers.py:
646
647 2011-09-28  Adam Barth  <abarth@webkit.org>
648
649         garden-o-matic shouldn't depend on test-results.appspot.com
650         https://bugs.webkit.org/show_bug.cgi?id=69019
651
652         Reviewed by Dimitri Glazkov.
653
654         This patch moves garden-o-matic from getting full_results.json from
655         test-results.appspot.com to getting that information directly from the
656         buildbot.  This patch improve the load time and accuracy of
657         garden-o-matic because test-results.appspot.com is slow and is dropping
658         a significant number of writes (see
659         https://bugs.webkit.org/show_bug.cgi?id=68748).
660
661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
664
665 2011-09-28  David Levin  <levin@chromium.org>
666
667         watchlist: Add a way to load the watchlist from config.
668         https://bugs.webkit.org/show_bug.cgi?id=68991
669
670         Reviewed by Eric Seidel.
671
672         * Scripts/webkitpy/common/config/watchlist: Added.
673         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
674         Support for loading the watch list.
675         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
676         Tests for the loading.
677         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
678         Adjusted to use the common base class.
679         * Scripts/webkitpy/common/webkitunittest.py: Added.
680         Made a common base class for functionality used in more than one.
681
682 2011-09-28  David Levin  <levin@chromium.org>
683
684         Attempt fix for Leopard python unit test run.
685
686         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
687
688 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
689
690         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
691         https://bugs.webkit.org/show_bug.cgi?id=68938
692
693         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
694
695         Reviewed by David Hyatt.
696
697         * DumpRenderTree/chromium/WebViewHost.cpp:
698         (WebViewHost::didUpdateLayout): Added width/height queries.
699         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
700
701 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
702
703         Get rebaseline server running again
704         https://bugs.webkit.org/show_bug.cgi?id=69020
705
706         Reviewed by Adam Barth.
707
708         Make rebaseline server run again after r90337 (missing format_date_time
709         import, results_json wasn't outputting anything).
710
711         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
712         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
713
714 2011-09-28  David Grogan  <dgrogan@chromium.org>
715
716         Move dgrogan from contributor to committer
717         https://bugs.webkit.org/show_bug.cgi?id=69021
718
719         * Scripts/webkitpy/common/config/committers.py:
720
721 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
722
723         Add Mac Skia GPU bots to builders.py
724         https://bugs.webkit.org/show_bug.cgi?id=69016
725
726         Reviewed by Eric Seidel.
727
728         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
729         GPU tests.
730
731         * Scripts/webkitpy/layout_tests/port/builders.py:
732         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
733
734 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
735
736         Second try at fixing the GTK+ build.
737
738         * GNUmakefile.am:
739
740 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
741
742         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
743         https://bugs.webkit.org/show_bug.cgi?id=68680
744
745         Reviewed by Tony Chang.
746
747         * Scripts/run-chromium-webkit-unit-tests:
748         * Scripts/webkitdirs.pm:
749         (determineBaseProductDir):
750
751 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
752
753         [Gtk] Implement textInputController.doCommand
754         https://bugs.webkit.org/show_bug.cgi?id=66496
755
756         Reviewed by Martin Robinson.
757
758         * DumpRenderTree/gtk/TextInputController.cpp:
759         (doCommandCallback): Callback function for textInputController.doCommand
760
761 2011-09-28  David Levin  <levin@chromium.org>
762
763         watchlist: Suggest corrections for typos and improve error message consistency.
764         https://bugs.webkit.org/show_bug.cgi?id=68976
765
766         Reviewed by Adam Barth.
767
768         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
769         for typos and improve consistency of the error messages.
770         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
771         and improve the regex that were already present.
772
773 2011-09-28  David Levin  <levin@chromium.org>
774
775         watchlist: Add support for matching added or deleted lines.
776         https://bugs.webkit.org/show_bug.cgi?id=68972
777
778         Reviewed by Adam Barth.
779
780         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
781         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
782         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
783         to the pattern match to only have the diff lines instead of the DiffFile.
784         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
785         Add tests for the new patterns and combinations of the patterns.
786         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
787         Sort imports. Add changeline support.
788
789 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
790
791         [GTK] Add WebKitError to GTK+ WebKit2 API
792         https://bugs.webkit.org/show_bug.cgi?id=68508
793
794         Reviewed by Martin Robinson.
795
796         * GNUmakefile.am: Add path to webkitgtk derived sources to the
797         include path.
798
799 2011-09-28  Philippe Normand  <pnormand@igalia.com>
800
801         [GTK] missing WebKit2 support in run-gtk-tests
802         https://bugs.webkit.org/show_bug.cgi?id=68992
803
804         Rubber-stamped by Andreas Kling.
805
806         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
807         webkit2 directory.
808
809 2011-09-27  Philippe Normand  <pnormand@igalia.com>
810
811         [GTK] build-webkit --no-webkit2 still builds WebKit2
812         https://bugs.webkit.org/show_bug.cgi?id=68892
813
814         Reviewed by Martin Robinson.
815
816         Take the --no-webkit2 option in account when building WebKitGTK+.
817
818         * Scripts/build-webkit:
819         * Scripts/webkitdirs.pm:
820         (buildAutotoolsProject):
821         (buildGtkProject):
822
823 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
824
825         Make Chromium Win Release (Tests) a core builder
826         https://bugs.webkit.org/show_bug.cgi?id=68906
827
828         Reviewed by Adam Barth.
829
830         Add Chromium Win Release (Tests) to the list of core builders.
831
832         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
833         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
834
835 2011-09-27  Adam Barth  <abarth@webkit.org>
836
837         garden-o-matic should load faster and inform the user what is happening
838         https://bugs.webkit.org/show_bug.cgi?id=68954
839
840         Reviewed by Dimitri Glazkov.
841
842         This test disables the expected failures tab.  The web inspector showed
843         that loading the data for this tab was slowing down the loading time
844         for the whole app.  We need to find a way to load that data lazily.
845
846         This patch also improves the update message to better describe the
847         progress the app is making analyzing data from the buildbot.
848
849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
852
853 2011-09-27  Adam Barth  <abarth@webkit.org>
854
855         garden-o-matic should show the first result when examining results
856         https://bugs.webkit.org/show_bug.cgi?id=68960
857
858         Reviewed by Dimitri Glazkov.
859
860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
861
862 2011-09-27  David Levin  <levin@chromium.org>
863
864         watchlist: Add support for cc and message rules.
865         https://bugs.webkit.org/show_bug.cgi?id=68950
866
867         Reviewed by Adam Barth.
868
869         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
870         the cc's and messages for a patch.
871         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
872         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
873         for the rules.
874         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
875         A generic encapsulation of either a message list or a cc list.
876         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
877
878 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
879
880         webkit-patch doesn't like UTF-8 characters in reviewers names
881         https://bugs.webkit.org/show_bug.cgi?id=63452
882
883         Reviewed by Eric Seidel.
884
885         * Scripts/webkit-patch:
886
887 2011-09-27  Adam Barth  <abarth@webkit.org>
888
889         garden-o-matic examine buttons shows both expected and unexpected failures
890         https://bugs.webkit.org/show_bug.cgi?id=68918
891
892         Reviewed by Dimitri Glazkov.
893
894         This was a copy/paste error when I refactored this classes to share
895         more code.
896
897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
898
899 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
900
901         Add Kaustubh Atrawalkar to the list of contributors.
902
903         * Scripts/webkitpy/common/config/committers.py:
904
905 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
906
907         [Chromium] Fixed layout mode tests break subsequent tests
908         https://bugs.webkit.org/show_bug.cgi?id=68923
909         
910         Reviewed by Adam Barth.        
911
912         Reset fixed layout mode between tests, so that tests that run after
913         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
914         regular 800x600 non-fixed layout.
915
916         * DumpRenderTree/chromium/TestShell.cpp:
917         (TestShell::resetTestController):
918
919 2011-09-27  David Levin  <levin@chromium.org>
920
921         watchlist: Add the filename pattern for definitions.
922         https://bugs.webkit.org/show_bug.cgi?id=68917
923
924         Reviewed by Adam Barth.
925
926         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
927         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
928         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
929         for definitions.
930         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
931         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
932
933 2011-09-27  Adam Barth  <abarth@webkit.org>
934
935         garden-o-matic results view should sort test and builder names
936         https://bugs.webkit.org/show_bug.cgi?id=68488
937
938         Reviewed by Andy Estes.
939
940         Previously, the test and builder names were displayed in an arbitrary
941         order that changed from time to time.  That confused one user study
942         participant.  This patch sorts the lists so that they occur in a
943         predictable order.
944
945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
946
947 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
948
949         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
950         http://trac.webkit.org/changeset/96108
951         http://trac.webkit.org/changeset/96111
952         http://trac.webkit.org/changeset/96113
953         http://trac.webkit.org/changeset/96116
954         https://bugs.webkit.org/show_bug.cgi?id=68913
955
956         Wait for working Qt5 (Requested by ossy on #webkit).
957
958         * DumpRenderTree/qt/DumpRenderTree.pro:
959         * DumpRenderTree/qt/ImageDiff.pro:
960         * MiniBrowser/qt/BrowserView.cpp:
961         (BrowserView::BrowserView):
962         * MiniBrowser/qt/BrowserView.h:
963         * MiniBrowser/qt/BrowserWindow.cpp:
964         (BrowserWindow::BrowserWindow):
965         (BrowserWindow::urlChanged):
966         (BrowserWindow::~BrowserWindow):
967         * MiniBrowser/qt/BrowserWindow.h:
968         * MiniBrowser/qt/MiniBrowser.pro:
969         * MiniBrowser/qt/MiniBrowserApplication.h:
970         * MiniBrowser/qt/main.cpp:
971         * QtTestBrowser/QtTestBrowser.pro:
972         * QtTestBrowser/launcherwindow.cpp:
973         * QtTestBrowser/launcherwindow.h:
974         * QtTestBrowser/locationedit.h:
975         * QtTestBrowser/main.cpp:
976         * QtTestBrowser/mainwindow.cpp:
977         * QtTestBrowser/mainwindow.h:
978         * QtTestBrowser/webinspector.h:
979         * QtTestBrowser/webpage.cpp:
980         * QtTestBrowser/webview.cpp:
981         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
982         * WebKitTestRunner/PlatformWebView.h:
983         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
984         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
985         (WTR::WebView::wkView):
986         (WTR::WebView::pageRef):
987         (WTR::WebView::~WebView):
988         (WTR::WebView::WebView):
989         (WTR::PlatformWebView::PlatformWebView):
990         (WTR::PlatformWebView::sendEvent):
991         (WTR::PlatformWebView::postEvent):
992         * WebKitTestRunner/qt/WebKitTestRunner.pro:
993
994 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
995
996         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
997         https://bugs.webkit.org/show_bug.cgi?id=65178
998
999         Reviewed by Martin Robinson.
1000
1001         * GNUmakefile.am:
1002         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
1003
1004 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
1005
1006         [Qt][WK2] Buildfix after r96108.
1007
1008         Rubber-stamped by Andreas Kling.
1009
1010         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1011         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1012         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1013
1014 2011-09-27  David Levin  <levin@chromium.org>
1015
1016         watchlist: Change watchlistparser.py to be class based.
1017         https://bugs.webkit.org/show_bug.cgi?id=68869
1018
1019         Reviewed by Eric Seidel.
1020
1021         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1022         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1023
1024 2011-09-27  David Levin  <levin@chromium.org>
1025
1026         watchlist: Break out the diff boilerplate to allow for re-use.
1027         https://bugs.webkit.org/show_bug.cgi?id=68871
1028
1029         Reviewed by Eric Seidel.
1030
1031         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1032         Break out the diff into a new file.
1033         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
1034
1035 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
1036
1037         Web Inspector: UI performance: introduce heap size tracking stats.
1038         https://bugs.webkit.org/show_bug.cgi?id=68901
1039
1040         It is interesting how much the heap memory is used by Inspector in order of running the test.
1041
1042         Reviewed by Yury Semikhatsky.
1043
1044         * DumpRenderTree/chromium/TestShell.cpp:
1045         (TestShell::showDevTools):
1046         (TestShell::closeDevTools):
1047
1048 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1049
1050         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1051
1052         QWidget and friends now live in the QtWidgets library. We update
1053         includes in implementation files and private headers to us the
1054         non-module-prefixed path, and leave the lookup for the include
1055         path. For public headers we have to ifdef the includes as the
1056         user might now have the modules we need in his QT config.
1057
1058         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1059         have to update our code and use windowHandle() for setting the
1060         parent relationships.
1061
1062         https://bugs.webkit.org/show_bug.cgi?id=68687
1063
1064         Reviewed by Andreas Kling.
1065
1066         * DumpRenderTree/qt/DumpRenderTree.pro:
1067         * DumpRenderTree/qt/ImageDiff.pro:
1068         * MiniBrowser/qt/BrowserView.cpp:
1069         * MiniBrowser/qt/BrowserView.h:
1070         * MiniBrowser/qt/BrowserWindow.cpp:
1071         * MiniBrowser/qt/BrowserWindow.h:
1072         * MiniBrowser/qt/MiniBrowser.pro:
1073         * MiniBrowser/qt/MiniBrowserApplication.h:
1074         * MiniBrowser/qt/main.cpp:
1075         * QtTestBrowser/QtTestBrowser.pro:
1076         * QtTestBrowser/launcherwindow.cpp:
1077         * QtTestBrowser/launcherwindow.h:
1078         * QtTestBrowser/locationedit.h:
1079         * QtTestBrowser/main.cpp:
1080         * QtTestBrowser/mainwindow.cpp:
1081         * QtTestBrowser/mainwindow.h:
1082         * QtTestBrowser/webinspector.h:
1083         * QtTestBrowser/webpage.cpp:
1084         * QtTestBrowser/webview.cpp:
1085         * WebKitTestRunner/PlatformWebView.h:
1086         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1087
1088 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1089
1090         [Qt][WK2] Add support for hover API in Qt WebKit2
1091         https://bugs.webkit.org/show_bug.cgi?id=68369
1092
1093         Reviewed by Andreas Kling.
1094
1095         Change the statusbar to show the link URL when hovering links in
1096         MiniBrowser using QDesktopWebView.
1097
1098         * MiniBrowser/qt/BrowserWindow.cpp:
1099         (BrowserWindow::BrowserWindow):
1100         (BrowserWindow::onLinkHovered):
1101         * MiniBrowser/qt/BrowserWindow.h:
1102
1103 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1104
1105         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
1106         https://bugs.webkit.org/show_bug.cgi?id=68864
1107
1108         Reviewed by Adam Barth.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
1111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
1114
1115 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1116
1117         [Qt][WK2] One more unreviewed buildfix after r96005.
1118
1119         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
1120
1121 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1122
1123         [Qt][WK2] Unreviewed buildfix after r96005.
1124
1125         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1126         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1127
1128 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1129
1130         garden-o-matic should be pretty in Open Sans.
1131         https://bugs.webkit.org/show_bug.cgi?id=68845
1132
1133         Reviewed by Adam Barth.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
1136
1137 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1138
1139         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
1140         https://bugs.webkit.org/show_bug.cgi?id=68841
1141
1142         Reviewed by Adam Barth.
1143
1144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
1147
1148 2011-09-26  David Levin  <levin@chromium.org>
1149
1150         watchlist: Add parsing for definition section.
1151         https://bugs.webkit.org/show_bug.cgi?id=68850
1152
1153         Reviewed by Adam Barth.
1154
1155         * Scripts/webkitpy/common/watchlist/watchlist.py:
1156         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1157         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1158
1159 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1160
1161         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
1162
1163         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1164         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1165         * WebKitTestRunner/win/TestInvocationWin.cpp:
1166         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1167
1168 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1169
1170         Repaint tests don't work in WebKit2
1171         https://bugs.webkit.org/show_bug.cgi?id=68453
1172
1173         Reviewed by Sam Weinig.
1174         
1175         Convert DumpRenderTree to use use the repaint rects
1176         exposed via WebKit API when generating the repaint test
1177         overlay.
1178         
1179         Fix WebKitTestRunner to work with repaint tests, again
1180         using the repaint rects exposed from WK2.
1181         
1182         In both cases, layoutTestController.display() now just
1183         forces a display of the web view, and turns on repaint
1184         rect tracking on the main FrameView.
1185         
1186         Later, when pixel results are requested, the alpha overlay
1187         that shows the repaint rects is generated using the list
1188         of rects supplied by WebCore.
1189
1190         * DumpRenderTree/mac/DumpRenderTree.mm:
1191         (resetDefaultsToConsistentValues):
1192         (resetWebViewToConsistentStateBeforeTesting):
1193         (displayWebView):
1194         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1195         (paintRepaintRectOverlay):
1196         (createBitmapContextFromWebView):
1197         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1198         (WTR::InjectedBundle::beginTesting):
1199         (WTR::InjectedBundle::done):
1200         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1201         (WTR::InjectedBundle::setRepaintRects):
1202         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1203         (WTR::InjectedBundlePage::reset):
1204         (WTR::InjectedBundlePage::dump):
1205         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1206         (WTR::LayoutTestController::display):
1207         * WebKitTestRunner/TestInvocation.cpp:
1208         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1209         * WebKitTestRunner/TestInvocation.h:
1210         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1211         (WTR::paintRepaintRectOverlay):
1212         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1213
1214 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
1215
1216         Get hover'ed element URL from HitTest.
1217
1218         mouseDidMoveOverElement now gets the hover'ed element link using
1219         WKHitTestResult API's.
1220         https://bugs.webkit.org/show_bug.cgi?id=68426 
1221
1222         Reviewed by Anders Carlsson.
1223
1224         * MiniBrowser/gtk/BrowserWindow.c:
1225         (mouseDidMoveOverElement):
1226
1227 2011-09-26  David Levin  <levin@chromium.org>
1228
1229         Add skeleton parsing for a WatchList.
1230         https://bugs.webkit.org/show_bug.cgi?id=68823
1231
1232         Reviewed by Adam Barth.
1233
1234         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
1235         Parses the top level watch list sections -- none are defined yet -- and
1236         throws an exception if an invalid one is listed.
1237         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
1238         Verify the exception for an invalid section in a watch list.
1239         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
1240
1241 2011-09-26  Adam Roben  <aroben@apple.com>
1242
1243         Clean up code imported from WebKitAPITest
1244
1245         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
1246         TestWebKitAPI conventions
1247
1248         Reviewed by David Levin.
1249
1250         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
1251         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
1252         namespace name.
1253
1254         (TestWebKitAPI::WebViewDestruction::SetUp):
1255         (TestWebKitAPI::WebViewDestruction::webViewCount):
1256         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1257         (TestWebKitAPI::WebViewDestruction::runMessagePump):
1258         (TestWebKitAPI::WebViewDestruction::TearDown):
1259         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
1260         Moved functionality from free functions into these new test fixtures.
1261
1262         * TestWebKitAPI/win/HostWindow.cpp:
1263         * TestWebKitAPI/win/HostWindow.h:
1264         Prefixed Win32 API calls with ::. Updated namespace name.
1265
1266 2011-09-23  Adam Roben  <aroben@apple.com>
1267
1268         Merge WebKitAPITest into TestWebKitAPI
1269
1270         This also means that our formerly-WebKitAPITest tests will be run on the bots!
1271
1272         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
1273         them more idiomatic in a separate pass.
1274
1275         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1276         functionality (and names!)
1277
1278         Reviewed by Anders Carlsson.
1279
1280         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
1281         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
1282         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
1283
1284         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
1285
1286         * TestWebKitAPI/win/main.cpp:
1287         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
1288
1289         * WebKitAPITest: Removed this directory and its contents.
1290
1291 2011-09-23  Adam Roben  <aroben@apple.com>
1292
1293         Remove two failing WebKitAPITest tests
1294
1295         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
1296
1297         Reviewed by Anders Carlsson.
1298
1299         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
1300         MainFrameAfterClose tests.
1301
1302 2011-09-25  Adam Barth  <abarth@webkit.org>
1303
1304         Finish removing PLATFORM(BREWMP) by removing associated code
1305         https://bugs.webkit.org/show_bug.cgi?id=68779
1306
1307         Reviewed by Sam Weinig.
1308
1309         * Scripts/webkitpy/common/config/build.py:
1310         * waf/build/settings.py:
1311
1312 2011-09-21  Ai Makabi  <makabi@google.com>
1313
1314         Provides a simple LRU cache class in Python.
1315
1316         https://bugs.webkit.org/show_bug.cgi?id=67823
1317
1318         Reviewed by Tony Chang.
1319
1320         * Scripts/webkitpy/common/lru_cache.py:
1321         * Scripts/webkitpy/common/lru_cache_unittest.py:
1322
1323 2011-09-25  Adam Barth  <abarth@webkit.org>
1324
1325         Remove PLATFORM(HAIKU) and associated code
1326         https://bugs.webkit.org/show_bug.cgi?id=68774
1327
1328         Reviewed by Sam Weinig.
1329
1330         * Scripts/webkitpy/common/config/build.py:
1331         * waf/build/settings.py:
1332
1333 2011-09-24  Adam Barth  <abarth@webkit.org>
1334
1335         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1336         https://bugs.webkit.org/show_bug.cgi?id=68767
1337
1338         Reviewed by Eric Seidel.
1339
1340         * Scripts/build-webkit:
1341
1342 2011-09-24  Adam Barth  <abarth@webkit.org>
1343
1344         Remove ENABLE(WCSS) and associated code
1345         https://bugs.webkit.org/show_bug.cgi?id=68759
1346
1347         Reviewed by Darin Adler.
1348
1349         * Scripts/build-webkit:
1350         * Scripts/old-run-webkit-tests:
1351         * Scripts/webkitperl/features.pm:
1352         (hasFeature):
1353         * Scripts/webkitpy/layout_tests/port/webkit.py:
1354         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1355
1356 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1357
1358         Fixed GTK compilation after r95878, the operator== was defined
1359         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1360
1361         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1362
1363 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1364
1365         [DRT] Include the right config file for EFL's DRT.
1366         https://bugs.webkit.org/show_bug.cgi?id=67042
1367
1368         Reviewed by Martin Robinson.
1369
1370         Ports which use CMake as their buildsystem (such as the EFL one) also
1371         have config.h files, but they are named differently, so include the
1372         right one depending on the buildsystem being used.
1373
1374         * DumpRenderTree/config.h:
1375
1376 2011-09-23  Adam Klein  <adamk@chromium.org>
1377
1378         Add ENABLE_MUTATION_OBSERVERS feature flag
1379         https://bugs.webkit.org/show_bug.cgi?id=68732
1380
1381         Reviewed by Ojan Vafai.
1382
1383         This flag will guard an implementation of the "Mutation Observers" proposed in
1384         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1385
1386         * Scripts/build-webkit:
1387
1388 2011-09-23  Chang Shu  <cshu@webkit.org>
1389
1390         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1391         https://bugs.webkit.org/show_bug.cgi?id=68556
1392
1393         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1394
1395         Reviewed by Darin Adler.
1396
1397         * WebKitTestRunner/EventSenderProxy.h:
1398         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1399         * WebKitTestRunner/PlatformWebView.h:
1400         * WebKitTestRunner/mac/EventSenderProxy.mm:
1401         (WTR::EventSenderProxy::EventSenderProxy):
1402         (WTR::EventSenderProxy::leapForward):
1403         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1404         (WTR::EventSenderProxy::EventSenderProxy):
1405         (WTR::getMouseButton):
1406         (WTR::getModifiers):
1407         (WTR::EventSenderProxy::updateClickCountForButton):
1408         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1409         (WTR::EventSenderProxy::mouseDown):
1410         (WTR::EventSenderProxy::mouseUp):
1411         (WTR::EventSenderProxy::mouseMoveTo):
1412         (WTR::EventSenderProxy::leapForward):
1413         (WTR::EventSenderProxy::sendOrQueueEvent):
1414         (WTR::EventSenderProxy::replaySavedEvents):
1415         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1416         (WTR::PlatformWebView::postEvent):
1417         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1418
1419 2011-09-23  Lei Zhang  <thestig@chromium.org>
1420
1421         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1422         https://bugs.webkit.org/show_bug.cgi?id=68026
1423
1424         Reviewed by Dirk Pranke.
1425
1426         * Scripts/webkitpy/layout_tests/port/chromium.py:
1427
1428 2011-09-23  Elliot Poger  <epoger@google.com>
1429
1430         update layout_tests to account for new default of use_skia=1
1431         https://bugs.webkit.org/show_bug.cgi?id=68698
1432
1433         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1434         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1435         (Chromium-on-Mac now uses the Skia graphics library instead of
1436         Core Graphics).
1437
1438         Also updates layout_test code to work with that change.
1439
1440         Reviewed by Mihai Parparita.
1441
1442         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1443         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1444
1445 2011-09-23  Mark Rowe  <mrowe@apple.com>
1446
1447         Fix the build.
1448         
1449         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1450         the WTF namespace.
1451
1452 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1453
1454         enable NRWT for run-webkit-tests on Lion
1455         https://bugs.webkit.org/show_bug.cgi?id=68673
1456
1457         Reviewed by Eric Seidel.
1458
1459         * Scripts/run-webkit-tests:
1460         (useNewRunWebKitTests):
1461
1462 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1463
1464         Add unit test for existing StringBuilder
1465         https://bugs.webkit.org/show_bug.cgi?id=67080
1466
1467         Reviewed by Darin Adler.
1468
1469         * TestWebKitAPI/TestWebKitAPI.gypi:
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
1472         (operator<<):
1473         (TestWebKitAPI::expectBuilderContent):
1474         (TestWebKitAPI::expectEmpty):
1475         (TestWebKitAPI::TEST):
1476
1477 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
1478
1479         [EFL] Use ewk_view to navigate in history instead of ewk_history.
1480         https://bugs.webkit.org/show_bug.cgi?id=68455
1481
1482         Reviewed by Antonio Gomes.
1483
1484         BackForwardItem::invoke() was using ewk_history functions to navigate
1485         in history; however, this will only call WebCore::BackForwardListImpl
1486         and not move between pages at all. We now call ewk_view_navigate and
1487         its siblings to make sure the navigation actually happens.
1488
1489         This should make tests like fast/dom/navigation-type-back-forward.html
1490         stop timing out.
1491
1492         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1493         (BackForwardItem::invoke):
1494
1495 2011-09-22  Dean Jackson  <dino@apple.com>
1496
1497         Add ENABLE_CSS_FILTERS
1498         https://bugs.webkit.org/show_bug.cgi?id=68652
1499
1500         Reviewed by Simon Fraser.
1501
1502         * Scripts/build-webkit:
1503
1504 2011-09-22  Anders Carlsson  <andersca@apple.com>
1505
1506         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
1507         https://bugs.webkit.org/show_bug.cgi?id=68660
1508
1509         Reviewed by Adam Barth.
1510
1511         * WebKitTestRunner/mac/EventSenderProxy.mm:
1512         (WTR::EventSenderProxy::mouseUp):
1513
1514 2011-09-22  Adam Roben  <aroben@apple.com>
1515
1516         Remove FindSafari
1517
1518         It isn't used or built anymore.
1519
1520         Fixes <http://webkit.org/b/68628>
1521
1522         Reviewed by Darin Adler.
1523
1524         * FindSafari: Removed this directory and its contents.
1525
1526 2011-09-22  Adam Roben  <aroben@apple.com>
1527
1528         Remove FindSafari from all our .sln files
1529
1530         It isn't used anymore, so there's no point in building it.
1531
1532         Part of <http://webkit.org/b/68628> Remove FindSafari
1533
1534         Reviewed by Steve Falkenburg.
1535
1536         * DumpRenderTree/DumpRenderTree.sln:
1537         * WebKitTestRunner/WebKitTestRunner.sln:
1538
1539 2011-09-22  Adam Roben  <aroben@apple.com>
1540
1541         Remove all uses of FindSafari
1542
1543         It isn't really needed anymore.
1544
1545         Fixes <http://webkit.org/b/68626>.
1546
1547         Reviewed by Darin Adler.
1548
1549         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
1550
1551         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
1552         WebKit, but now we use WebKit.exe for that.
1553
1554         * Scripts/webkitdirs.pm:
1555         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
1556         do the same thing.
1557
1558         (readRegistryString):
1559         (writeRegistryString):
1560         Moved here from old-run-webkit-tests.
1561
1562 2011-09-22  Adam Roben  <aroben@apple.com>
1563
1564         Use the "direct object" form of system() to run WebKit.exe
1565
1566         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
1567         path to WebKit.exe.
1568
1569         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
1570         %WEBKITOUTPUTDIR%
1571
1572         Reviewed by Steve Falkenburg.
1573
1574         * Scripts/webkitdirs.pm:
1575         (runSafari):
1576
1577 2011-09-22  Adam Roben  <aroben@apple.com>
1578
1579         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
1580
1581         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
1582         spaces in the path to the WebKit source tree
1583
1584         Reviewed by John Sullivan.
1585
1586         * Scripts/webkitdirs.pm:
1587         (setupCygwinEnv):
1588
1589 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1590
1591         [Qt] Use same DPI for application font as rest of app in DRT and WTR
1592
1593         QApplication will initialize the default application font based
1594         on the application DPI at construction time, but we then override
1595         the application DPI using QX11Info (hard-coding it to 96 for
1596         consistency). This hard-coding is not reflected in the application
1597         font, so we explicitly have update the font ourselves.
1598
1599         The 6 test results that are updated were originally produced with
1600         a DPI of 75, as this is the default fallback DPI when a QFont is
1601         constructed before QApplication. This was wrong, and the results
1602         are updated to match a DPI of 96.
1603
1604         Reviewed by Csaba Osztrogonác.
1605
1606         * DumpRenderTree/qt/main.cpp:
1607         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1608
1609 2011-09-21  Anna Cavender  <annacc@chromium.org>
1610
1611         Update committers.py with a new contributor contact        
1612         https://bugs.webkit.org/show_bug.cgi?id=68565
1613
1614         Reviewed by Eric Carlson.
1615
1616         * Scripts/webkitpy/common/config/committers.py:
1617
1618 2011-09-21  Chang Shu  <cshu@webkit.org>
1619
1620         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1621         https://bugs.webkit.org/show_bug.cgi?id=68108
1622
1623         This patch implements the event sender mouse events through WebKit2 UIProcess which is
1624         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
1625         platform as the first step so the existing code is still kept for other platforms.
1626
1627         Reviewed by Darin Adler.
1628
1629         * WebKitTestRunner/EventSenderProxy.h:
1630         (WTR::EventSenderProxy::EventSenderProxy):
1631         (WTR::EventSenderProxy::leapForward):
1632         (WTR::EventSenderProxy::currentEventTime):
1633         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1634         (WTR::EventSendingController::EventSendingController):
1635         (WTR::EventSendingController::mouseDown):
1636         (WTR::EventSendingController::mouseUp):
1637         (WTR::EventSendingController::mouseMoveTo):
1638         (WTR::EventSendingController::leapForward):
1639         (WTR::EventSendingController::keyDown):
1640         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1643         * WebKitTestRunner/mac/EventSenderProxy.mm:
1644         (WTR::eventTypeForMouseButtonAndAction):
1645         (WTR::operator==):
1646         (WTR::EventSenderProxy::updateClickCountForButton):
1647         (WTR::EventSenderProxy::mouseDown):
1648         (WTR::EventSenderProxy::mouseUp):
1649         (WTR::EventSenderProxy::mouseMoveTo):
1650         (WTR::EventSenderProxy::keyDown):
1651         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1652         (WTR::EventSenderProxy::keyDown):
1653         (WTR::EventSenderProxy::mouseDown):
1654         (WTR::EventSenderProxy::mouseUp):
1655         (WTR::EventSenderProxy::mouseMoveTo):
1656
1657 2011-09-21  Dan Bernstein  <mitz@apple.com>
1658
1659         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
1660         https://bugs.webkit.org/show_bug.cgi?id=68451
1661
1662         Reviewed by Darin Adler.
1663
1664         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
1665         Objective-C classes with names not having one of a list of prefixes
1666         passed on the command line.
1667
1668 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
1669
1670         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
1671         https://bugs.webkit.org/show_bug.cgi?id=68206
1672
1673         Reviewed by Tony Chang.
1674
1675         * Scripts/webkitdirs.pm:
1676         (determineBaseProductDir): add support for chromium-mac
1677         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1678         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1679
1680 2011-09-21  Adam Barth  <abarth@webkit.org>
1681
1682         garden-o-matic command should explain that it is starting a local server
1683         https://bugs.webkit.org/show_bug.cgi?id=68486
1684
1685         Reviewed by Dimitri Glazkov.
1686
1687         In the user study, both participants didn't understand why the
1688         garden-o-matic command appeared to hang.  This patch adds an
1689         explaination of what's going on.  It also adds a confirmation prompt
1690         before launching the browser to give the user a chance to read the
1691         text.  If that's too much of a speed bump, we can iterate.
1692
1693         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1694
1695 2011-09-21  Chang Shu  <cshu@webkit.org>
1696
1697         [Qt] Implement KeyDown function for WebKit2 EventSender.
1698         https://bugs.webkit.org/show_bug.cgi?id=56485
1699
1700         Implement the KeyDown function on Qt platform.
1701
1702         Reviewed by Andreas Kling.
1703
1704         * WebKitTestRunner/PlatformWebView.h:
1705         * WebKitTestRunner/TestController.cpp:
1706         (WTR::TestController::TestController):
1707         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1708         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
1709         (WTR::getModifiers):
1710         (WTR::EventSenderProxy::keyDown):
1711         (buildModifierFlags):
1712         (EventSenderProxy::keyDown):
1713         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1714         (WTR::PlatformWebView::sendEvent):
1715         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1716
1717 2011-09-20  Adam Barth  <abarth@webkit.org>
1718
1719         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
1720         https://bugs.webkit.org/show_bug.cgi?id=68496
1721
1722         Reviewed by Dimitri Glazkov.
1723
1724         This patch adds a bunch of sorting to make sure things happen in a
1725         predictable order in both JavaScriptCore and V8.  We've talked before
1726         about whether these two JavaScript engines should enumerate
1727         dictionaries in the same order, but the consensus has been that they
1728         shouldn't.  Personally, I disagree with that consensus, but such is life.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1734
1735 2011-09-20  Adam Barth  <abarth@webkit.org>
1736
1737         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
1738         https://bugs.webkit.org/show_bug.cgi?id=68495
1739
1740         Reviewed by Dimitri Glazkov.
1741
1742         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
1743
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1745
1746 2011-09-20  Eric Seidel  <eric@webkit.org>
1747
1748         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1749         https://bugs.webkit.org/show_bug.cgi?id=65781
1750
1751         Reviewed by Ryosuke Niwa.
1752
1753         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
1754         to resolve the passed in url relative to the absolute url for the test.
1755         For http tests, since the test url is an http url, we can't resolve relative
1756         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
1757         for resolving.
1758
1759         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1760         (which resolves the path relative to the built location of the DRT executable)
1761         and we should move this new code into a shared location in a follow-up patch.
1762
1763         It turns out that there was a second use for pathToLocalResource, used by one
1764         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
1765         To support this test I made the new pathToLocalResource smart enough to map
1766         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
1767
1768         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1769         (LayoutTestController::pathToLocalResource):
1770         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
1771
1772 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1773
1774         Need to specify a django version, instead of using default
1775         https://bugs.webkit.org/show_bug.cgi?id=68398
1776
1777         Reviewed by Eric Seidel.
1778
1779         * QueueStatusServer/__init__.py:
1780         * QueueStatusServer/main.py:
1781
1782 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1783
1784         Update committers.py with a few more contributor contacts
1785         https://bugs.webkit.org/show_bug.cgi?id=68487
1786
1787         Reviewed by Eric Seidel.
1788
1789         * Scripts/webkitpy/common/config/committers.py:
1790
1791 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1792
1793         Fix webkitpy unit tests after 95547 and 95549
1794         https://bugs.webkit.org/show_bug.cgi?id=68483
1795
1796         Reviewed by Adam Barth.
1797         
1798         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
1799
1800         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
1801         parse_entries_from_file(), use StringIO and entry.reviewer_text().
1802         While testing parse_latest_entry_from_file(), expect the correct
1803         touched_files() list.
1804
1805 2011-09-20  Adam Barth  <abarth@webkit.org>
1806
1807         garden-o-matic makes it hard to compare images when scroll bars appear
1808         https://bugs.webkit.org/show_bug.cgi?id=68482
1809
1810         Reviewed by Eric Seidel.
1811
1812         Because we autoscale image width, the images rescale if we overflow
1813         vertically and get a scrollbar.  That makes it hard to compare two sets
1814         of images.  This patch reserves space for the scrollbar so we won't
1815         have the layout change.
1816
1817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1818
1819 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1820
1821         Unreviewed, rolling out r95565.
1822         http://trac.webkit.org/changeset/95565
1823         https://bugs.webkit.org/show_bug.cgi?id=68470
1824
1825         Broke builds (Requested by andersca on #webkit).
1826
1827         * MiniBrowser/gtk/BrowserWindow.c:
1828         (mouseDidMoveOverElement):
1829
1830 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
1831
1832         Get hover'ed element URL from HitTest.
1833         
1834         mouseDidMoveOverElement now gets the hover'ed element link using
1835         WKHitTestResult API's.
1836         https://bugs.webkit.org/show_bug.cgi?id=68426
1837
1838         Reviewed by Anders Carlsson.
1839
1840         * MiniBrowser/gtk/BrowserWindow.c:
1841         (mouseDidMoveOverElement):
1842
1843 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1844
1845         Changelog class should have a method to return all entries
1846         https://bugs.webkit.org/show_bug.cgi?id=68399
1847         
1848         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
1849         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
1850
1851         Reviewed by Ryosuke Niwa.
1852
1853         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
1854         and adapt it to become a generator.
1855         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
1856
1857 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
1858
1859         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
1860         https://bugs.webkit.org/show_bug.cgi?id=51159
1861
1862         Permit any URL with a local scheme to set a user style sheet. Allow qrc
1863         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
1864         
1865         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
1866
1867         Reviewed by Kenneth Rohde Christiansen.
1868
1869         * DumpRenderTree/qt/DumpRenderTree.pro:
1870         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
1871         * DumpRenderTree/qt/resources/user.css: Added.
1872         (body):
1873         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1874         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
1875         * WebKitTestRunner/qt/resources/user.css: Added.
1876         (body):
1877
1878 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1879
1880         ChangeLogEntry class should contain a list of touched files
1881         https://bugs.webkit.org/show_bug.cgi?id=68115
1882
1883         Reviewed by Eric Seidel.
1884         
1885         Add method to return the list of files touched in a ChangeLog entry.
1886
1887         * Scripts/webkitpy/common/checkout/changelog.py: Add
1888         touched_files_regexp and touched_files() method.
1889         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
1890         unit tests for touched_files() method.
1891
1892 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1893
1894         Unreviewed, rolling out r95526 and r95541.
1895         http://trac.webkit.org/changeset/95526
1896         http://trac.webkit.org/changeset/95541
1897         https://bugs.webkit.org/show_bug.cgi?id=68443
1898
1899         It broke 6 tests (Requested by ossy_ on #webkit).
1900
1901         * DumpRenderTree/qt/main.cpp:
1902         (main):
1903         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1904         (WTR::activateFonts):
1905
1906 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1907
1908         Fix patch and bug numbering in the mocktool simulation code
1909         https://bugs.webkit.org/show_bug.cgi?id=68374
1910
1911         Reviewed by Adam Barth.
1912
1913         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1914         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1915         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1916         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1917         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1918         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1919         * Scripts/webkitpy/tool/commands/download_unittest.py:
1920         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1921         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1922         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1923         * Scripts/webkitpy/tool/commands/queuestest.py:
1924         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1925         * Scripts/webkitpy/tool/mocktool.py:
1926         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1927         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1928
1929 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1930
1931         [Qt] Don't override default QApplication font for DRT and WTR
1932
1933         Revision 95526 moved the relevant code below the QApplication
1934         constructor, to fix a potential crash, and that made the code
1935         take effect, breaking 6 tests.
1936
1937         We should rely on the QWebSettings to set default fonts, and
1938         this QApplication::setFont() is a relic from when we didn't
1939         have that option, so we remove the code.
1940
1941         Reviewed by Csaba Osztrogonác.
1942
1943         * DumpRenderTree/qt/main.cpp:
1944         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1945
1946 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1947
1948         WebKitTestRunner: Provide usage if run without arguments
1949
1950         If WTR is run without either one or more filenames, or
1951         a '-' to indicate server mode, we don't need to start
1952         up the test machinery. Doing so might actually crash,
1953         as we'll exit the application immedeatly after anyways.
1954
1955         Reviewed by Simon Hausmann.
1956
1957         * WebKitTestRunner/TestController.cpp:
1958         (WTR::TestController::initialize):
1959
1960 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1961
1962         [Qt] Don't use QFont before initializing QApplication
1963
1964         Could potentially result in crash.
1965
1966         Reviewed by Simon Hausmann.
1967
1968         * DumpRenderTree/qt/main.cpp:
1969         (main):
1970
1971 2011-09-19  Adam Barth  <abarth@webkit.org>
1972
1973         Always enable ENABLE(EVENTSOURCE)
1974         https://bugs.webkit.org/show_bug.cgi?id=68414
1975
1976         Reviewed by Eric Seidel.
1977
1978         * Scripts/build-webkit:
1979
1980 2011-09-19  David Levin  <levin@chromium.org>
1981
1982         Sheriffbot rollout should be more intuitive.
1983         https://bugs.webkit.org/show_bug.cgi?id=68415
1984
1985         Reviewed by Adam Barth.
1986
1987         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
1988         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
1989           and a few others cases.
1990         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
1991
1992 2011-09-19  David Levin  <levin@chromium.org>
1993
1994         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
1995         https://bugs.webkit.org/show_bug.cgi?id=68391
1996
1997         Reviewed by Darin Adler.
1998
1999         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
2000         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
2001
2002 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
2003
2004         Style checker should not check public Qt WK2 API for parameter_name.
2005         https://bugs.webkit.org/show_bug.cgi?id=68359
2006
2007         Reviewed by Andreas Kling.
2008
2009         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
2010         Add an exception in the style checker to disable the check. Also added the test for it.
2011
2012         * Scripts/webkitpy/style/checker.py:
2013         * Scripts/webkitpy/style/checker_unittest.py:
2014
2015 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
2016
2017         GTK DRT leaks memory while comparing history items
2018         https://bugs.webkit.org/show_bug.cgi?id=68086
2019
2020         Reviewed by Martin Robinson.
2021         
2022         webkit_web_history_item_get_target() returns a g_strdup()'d string,
2023         so memory must be freed before compareHistoryItems() returns.
2024
2025         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2026         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
2027
2028 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2029
2030         Buildbot marks a nrwt bot red when tests are missing results
2031         https://bugs.webkit.org/show_bug.cgi?id=64812
2032
2033         Reviewed by Ryosuke Niwa.
2034
2035         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2036         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2037
2038 2011-09-19  Jessie Berlin  <jberlin@apple.com>
2039
2040         Sites that use history pushState or replaceState are recorded in history in Private Browsing
2041         mode.
2042         https://bugs.webkit.org/show_bug.cgi?id=68208
2043
2044         Reviewed by Brady Eidson.
2045
2046         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
2047         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
2048
2049         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
2050         (TestWebKitAPI::didNavigateWithNavigationData):
2051         This is a context history client callback, so it should not be called when in Private
2052         Browsing. Add a call to FAIL().
2053         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2054         This is a page load client callback that happens after the didNavigateWithNavigationData
2055         callback. End the test.
2056         (TestWebKitAPI::TEST):
2057         Enable Private Browsing and load a page that uses history.pushState.
2058
2059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2060         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
2061         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
2062         Ditto.
2063         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2064         Ditto.
2065         * TestWebKitAPI/win/copy-resources.cmd:
2066         Ditto.
2067
2068 2011-09-16  Elliot Poger  <epoger@google.com>
2069
2070         add non-CG Webkit-Mac builds to flakiness dashboard
2071         https://bugs.webkit.org/show_bug.cgi?id=68265
2072
2073         Reviewed by Adam Barth.
2074
2075         As Chromium-on-Mac approaches the switchover from Core Graphics to
2076         Skia, we need to add the Skia version to the flakiness dashboard.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2079         * TestResultServer/static-dashboards/builders.js:
2080         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2081
2082 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
2083
2084         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
2085         https://bugs.webkit.org/show_bug.cgi?id=68071
2086
2087         Reviewed by Adam Barth.
2088
2089         * DumpRenderTree/chromium/WebPermissions.cpp:
2090         (WebPermissions::allowImage):
2091         * DumpRenderTree/chromium/WebPermissions.h:
2092
2093 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
2094
2095         update-webkit-chromium should retry the gclient call if it fails once
2096         https://bugs.webkit.org/show_bug.cgi?id=68252
2097
2098         Reviewed by Adam Barth.
2099
2100         * Scripts/update-webkit-chromium:
2101
2102 2011-09-16  Rob Buis  <rbuis@rim.com>
2103
2104         Add Eli's rim address and change the nick.
2105
2106         * Scripts/webkitpy/common/config/committers.py:
2107
2108 2011-09-16  Anders Carlsson  <andersca@apple.com>
2109
2110         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
2111         https://bugs.webkit.org/show_bug.cgi?id=68269
2112
2113         Reviewed by Geoffrey Garen.
2114
2115         Update client function signatures.
2116
2117         * MiniBrowser/gtk/BrowserWindow.c:
2118         (browserWindowUIClientInit):
2119         * MiniBrowser/mac/BrowserWindowController.m:
2120         (mouseDidMoveOverElement):
2121         (-[BrowserWindowController awakeFromNib]):
2122         * MiniBrowser/win/BrowserView.cpp:
2123         (BrowserView::create):
2124         * WebKitTestRunner/TestController.cpp:
2125         (WTR::TestController::createOtherPage):
2126         (WTR::TestController::initialize):
2127
2128 2011-09-16  Anders Carlsson  <andersca@apple.com>
2129
2130         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
2131         https://bugs.webkit.org/show_bug.cgi?id=68266
2132
2133         Reviewed by John Sullivan.
2134
2135         * MiniBrowser/mac/BrowserWindowController.m:
2136         (mouseDidMoveOverElement):
2137
2138 2011-09-16  Vincent Scheib  <scheib@chromium.org>
2139
2140         Add Vincent Scheib to the committers list.
2141
2142         * Scripts/webkitpy/common/config/committers.py:
2143
2144 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2145
2146         Unreviewed, rolling out r95285.
2147         http://trac.webkit.org/changeset/95285
2148         https://bugs.webkit.org/show_bug.cgi?id=68247
2149
2150         It broke a webkitpy test (Requested by ossy on #webkit).
2151
2152         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2153
2154 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2155
2156         Buildbot marks a nrwt bot red when tests are missing results
2157         https://bugs.webkit.org/show_bug.cgi?id=64812
2158
2159         Reviewed by Dirk Pranke.
2160
2161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2162
2163 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
2164
2165         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
2166         https://bugs.webkit.org/show_bug.cgi?id=68178
2167
2168         Reviewed by Xan Lopez.
2169
2170         Add a work-around to enable WebKit2 when using build-webkit.
2171
2172         * Scripts/webkitdirs.pm:
2173         (buildAutotoolsProject): 
2174
2175 2011-09-15  James Robinson  <jamesr@chromium.org>
2176
2177         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
2178
2179         * Scripts/webkitpy/common/config/committers.py:
2180
2181 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2182
2183         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
2184         https://bugs.webkit.org/show_bug.cgi?id=68003
2185
2186         Reviewed by Adam Barth.
2187
2188         * Scripts/webkitpy/tool/mocktool.py:
2189         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2190         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2191
2192 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2193
2194         Python version check is confusing in test-webkitpy
2195         https://bugs.webkit.org/show_bug.cgi?id=68004
2196
2197         Reviewed by Adam Barth.
2198
2199         * Scripts/test-webkitpy:
2200
2201 2011-09-15  Eric Seidel  <eric@webkit.org>
2202
2203         Reviewed by Adam Barth.
2204
2205         webkit-patch should be able to find users and add them to bugzilla groups
2206         https://bugs.webkit.org/show_bug.cgi?id=63351
2207
2208         These are both very basic commands.  But it's now possible to find
2209         all users matching a regexp, as well as add all users matching a regexp
2210         to a set of groups.
2211
2212         bugzilla.py already knew how to find users (for validate-committer-lists)
2213         but now it has the ability to modify the user records.
2214
2215         I split some of the logic out into a new EditUsersParser class
2216         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
2217
2218         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2219         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2220         * Scripts/webkitpy/tool/commands/__init__.py:
2221         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
2222         * Scripts/webkitpy/tool/commands/findusers.py: Added.
2223
2224 2011-09-15  Eric Seidel  <eric@webkit.org>
2225
2226         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2227         https://bugs.webkit.org/show_bug.cgi?id=68182
2228
2229         Reviewed by Adam Barth.
2230
2231         * Scripts/build-webkit:
2232         * waf/build/settings.py:
2233
2234 2011-09-15  Eric Seidel  <eric@webkit.org>
2235
2236         Unreviewed.  Make contributor email look-up case-insensitive.
2237
2238         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
2239         was missing from committers.py due to case sensitivity.
2240
2241         This also includes a test expectations update to committers_unittest.py
2242         after my previous change.
2243
2244         * Scripts/webkitpy/common/config/committers.py:
2245         * Scripts/webkitpy/common/config/committers_unittest.py:
2246         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2247
2248 2011-09-15  Eric Seidel  <eric@webkit.org>
2249
2250         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
2251
2252         Add a bunch of email aliases to committers.py for regular contributors
2253         who are committing using other email addresses than they have listed in the file.
2254
2255         * Scripts/webkitpy/common/config/committers.py:
2256
2257 2011-09-15  Eric Seidel  <eric@webkit.org>
2258
2259         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2260         https://bugs.webkit.org/show_bug.cgi?id=68022
2261
2262         Reviewed by Ryosuke Niwa.
2263
2264         * Scripts/build-webkit:
2265         * waf/build/settings.py:
2266
2267 2011-09-15  Anders Carlsson  <andersca@apple.com>
2268
2269         Fix Mac build by including config.h where needed.
2270
2271         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2272         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2273         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2274         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2275         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2276         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2277         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2278         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2279         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2280         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2281         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2282         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2283         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2284         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2285         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2286         * TestWebKitAPI/mac/main.mm:
2287
2288 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
2289
2290         Let TestWebKitAPI work for chromium
2291         https://bugs.webkit.org/show_bug.cgi?id=67756
2292
2293         Reviewed by Sam Weinig.
2294
2295         * Scripts/build-api-tests:
2296         * Scripts/run-api-tests:
2297         (isSupportedPlatform):
2298         (runTest):
2299         (populateTests):
2300         * Scripts/webkitdirs.pm:
2301         (determineBaseProductDir):
2302         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2303         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2304         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2305         * TestWebKitAPI/InjectedBundleController.cpp:
2306         * TestWebKitAPI/InjectedBundleMain.cpp:
2307         * TestWebKitAPI/JavaScriptTest.cpp:
2308         * TestWebKitAPI/PlatformUtilities.cpp:
2309         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
2310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2311         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
2312         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2313         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2314         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2315         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2316         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2317         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2318         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2319         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2320         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2321         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2322         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2323         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2324         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2325         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2326         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2327         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2328         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2329         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2330         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2331         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2332         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2333         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2334         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2335         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2336         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2337         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2338         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2339         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2340         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2341         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2342         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2343         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2344         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2345         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2346         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2347         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2348         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2349         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2350         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2351         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2352         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2353         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2354         * TestWebKitAPI/TestsController.cpp:
2355         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2356         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2357         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2358         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2359         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2360         * TestWebKitAPI/win/main.cpp:
2361
2362 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2363
2364         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2365         https://bugs.webkit.org/show_bug.cgi?id=68145
2366
2367         This will allow for other classes in DumpRenderTree to reuse this functionality
2368
2369         Reviewed by David Levin.
2370
2371         * DumpRenderTree/chromium/TestShell.cpp:
2372         (normalizeLayoutTestURLInternal):
2373         (dumpHistoryItem):
2374         (TestShell::normalizeLayoutTestURL):
2375         * DumpRenderTree/chromium/TestShell.h:
2376
2377 2011-09-14  Ada Chan  <adachan@apple.com>
2378
2379         Add test for WKBundleFrameCopyWebArchive().
2380         https://bugs.webkit.org/show_bug.cgi?id=67857
2381
2382         Reviewed by Anders Carlsson.
2383
2384         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2385         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2386         the returned data is a valid webarchive.
2387         (TestWebKitAPI::setInjectedBundleClient):
2388         (TestWebKitAPI::didFinishLoadForFrame):
2389         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2390         injected bundle for the webarchive and check the returned webarchive.
2391         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2392         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2393         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2394         the web archive.
2395
2396         Add files to project.
2397         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2398         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2400
2401 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2402
2403         committers.py should support multiple IRC nicknames
2404         https://bugs.webkit.org/show_bug.cgi?id=68110
2405
2406         Reviewed by Eric Seidel.
2407
2408         Add multiple IRC nickname support to committers.py
2409
2410         * Scripts/webkitpy/common/config/committers.py:
2411         * Scripts/webkitpy/common/config/committers_unittest.py:
2412         * Scripts/webkitpy/tool/bot/irc_command.py:
2413         * Scripts/webkitpy/tool/bot/sheriff.py:
2414
2415 2011-09-14  Jon Lee  <jonlee@apple.com>
2416
2417         Implement globalFlag for WebKitTestRunner
2418         https://bugs.webkit.org/show_bug.cgi?id=68033
2419         <rdar://problem/10119204>
2420
2421         Reviewed by Sam Weinig.
2422
2423         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2424         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2425         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2426         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2427         (WTR::LayoutTestController::globalFlag): simple getter
2428         (WTR::LayoutTestController::setGlobalFlag): simple setter
2429
2430 2011-09-13  Eric Seidel  <eric@webkit.org>
2431
2432         Remove ENABLE_SVG_USE as <use> is required by HTML5
2433         https://bugs.webkit.org/show_bug.cgi?id=68019
2434
2435         Reviewed by Ryosuke Niwa.
2436
2437         * Scripts/build-webkit:
2438         * waf/build/settings.py:
2439
2440 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2443         since I can't confirm acceptable his committership.
2444
2445         * Scripts/webkitpy/common/config/committers.py:
2446
2447 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2448
2449         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2450         https://bugs.webkit.org/show_bug.cgi?id=68066
2451
2452         Reviewed by Adam Barth.
2453
2454         * DumpRenderTree/chromium/WebViewHost.cpp:
2455         * DumpRenderTree/chromium/WebViewHost.h:
2456
2457 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2458
2459         committers.py is missing some contributors
2460         https://bugs.webkit.org/show_bug.cgi?id=68059
2461
2462         Reviewed by Adam Barth.
2463
2464         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
2465
2466         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
2467
2468         * Scripts/webkitpy/common/config/committers.py:
2469
2470 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2471
2472         Fix webkit python test after r95061.
2473
2474         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2475
2476 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
2477
2478         Add myself as a contributor. No review needed.
2479
2480         * Scripts/webkitpy/common/config/committers.py:
2481
2482 2011-09-13  Adam Barth  <abarth@webkit.org>
2483
2484         garden-o-matic has unfriendly error messages when the local server is not available
2485         https://bugs.webkit.org/show_bug.cgi?id=68042
2486
2487         Reviewed by Dimitri Glazkov.
2488
2489         This patch moves us from using alert to showing the error inline in the
2490         progress dialog.
2491
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2497
2498 2011-09-13  Adam Barth  <abarth@webkit.org>
2499
2500         FailureGrid in garden-o-matic should link to the builder's waterfall page
2501         https://bugs.webkit.org/show_bug.cgi?id=68036
2502
2503         Reviewed by Dimitri Glazkov.
2504
2505         One of the users in the user study thought the configurations names in
2506         the failure grid would link to the underlying bots.  That makes sense,
2507         so this patch adds the behavior.
2508
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2513
2514 2011-09-13  Adam Barth  <abarth@webkit.org>
2515
2516         garden-o-matic should be able to mark failures as expected
2517         https://bugs.webkit.org/show_bug.cgi?id=68027
2518
2519         Reviewed by Dimitri Glazkov.
2520
2521         All the back-end infrastructure exists for this operation.  This patch
2522         just adds some UI to the front-end and wires that UI up to the back
2523         end.  This exact UI will likely need some more polish, but this should
2524         be a reasonable first cut.
2525
2526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2531
2532 2011-09-13  Adam Barth  <abarth@webkit.org>
2533
2534         garden-o-matic should tell you about the progress of your rebaseline
2535         https://bugs.webkit.org/show_bug.cgi?id=67967
2536
2537         Reviewed by Dimitri Glazkov.
2538
2539         This patch adds ui.MessageBox, which is a light wrapper around jQuery
2540         UI's dialog widget.  We then use ui.MessageBox to show status messages
2541         about in-progress rebaselines.  As each baseline is downloaded, the
2542         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2550
2551 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
2552
2553         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
2554         https://bugs.webkit.org/show_bug.cgi?id=68024
2555
2556         Reviewed by Gustavo Noronha Silva.
2557         
2558         Using g_list_count() and g_list_nth_data() together on a loop is
2559         inneficient since they're both O(n). Iterate over lists in a saner
2560         way.
2561
2562         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2563         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
2564         iterate on it using g_list_next(). Free the list after done with it.
2565         (dumpBackForwardListForWebView): Instead of appending (which is
2566         expensive in GLists) history items and then iterating from the tail
2567         of the itemsToPrint list, prepend items and walk forwards as usual.
2568         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
2569         remove the (unneeded) viewList variable.
2570
2571 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2572
2573         Add Eric's IRC nick.
2574
2575         * Scripts/webkitpy/common/config/committers.py:
2576
2577 2011-09-13  Anders Carlsson  <andersca@apple.com>
2578
2579         Disable C++ exceptions when building with clang
2580         https://bugs.webkit.org/show_bug.cgi?id=68031
2581         <rdar://problem/9556880>
2582
2583         Reviewed by Mark Rowe.
2584
2585         * MiniBrowser/Configurations/Base.xcconfig:
2586         * TestWebKitAPI/Configurations/Base.xcconfig:
2587         * WebKitTestRunner/Configurations/Base.xcconfig:
2588
2589 2011-09-13  Ojan Vafai  <ojan@chromium.org>
2590
2591         [chromium] fix flakiness dashboard for chromium interactive tests
2592         https://bugs.webkit.org/show_bug.cgi?id=68029
2593
2594         Reviewed by Tony Chang.
2595
2596         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2597         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2598
2599 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2600
2601         Add Alice and Aryeh to the list of contributors.
2602
2603         * Scripts/webkitpy/common/config/committers.py:
2604
2605 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2606
2607         sheriffbot whois should also tell us email addresses
2608         https://bugs.webkit.org/show_bug.cgi?id=67975
2609
2610         Reviewed by Eric Seidel and David Levin.
2611
2612         Taught sheriffbot how to tell us contributor's email addresses.
2613
2614         * Scripts/webkitpy/tool/bot/irc_command.py:
2615         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2616
2617 2011-09-13  Eric Seidel  <eric@webkit.org>
2618
2619         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2620         https://bugs.webkit.org/show_bug.cgi?id=68018
2621
2622         Reviewed by Ryosuke Niwa.
2623
2624         * Scripts/build-webkit:
2625         * waf/build/settings.py:
2626
2627 2011-09-13  Chang Shu  <cshu@webkit.org>
2628
2629         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
2630         https://bugs.webkit.org/show_bug.cgi?id=57515
2631
2632         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
2633         TestController synchronously. The latter then sends simulated event to WebKit2 module,
2634         which is synchronous, too.
2635
2636         Reviewed by Darin Adler.
2637
2638         * WebKitTestRunner/EventSenderProxy.h: Added.
2639         (WTR::EventSenderProxy::EventSenderProxy):
2640         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2641         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2642         (WTR::EventSendingController::keyDown):
2643         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2644         * WebKitTestRunner/PlatformWebView.h:
2645         (WTR::PlatformWebView::platformWindow):
2646         * WebKitTestRunner/TestController.cpp:
2647         (WTR::TestController::TestController):
2648         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2649         * WebKitTestRunner/TestController.h:
2650         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2651         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
2652         (WTR::buildModifierFlags):
2653         (WTR::EventSenderProxy::keyDown):
2654
2655 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
2656
2657         [EFL] DRT: Add DumpRenderTreeEfl.h
2658         https://bugs.webkit.org/show_bug.cgi?id=63993
2659
2660         Reviewed by Eric Seidel.
2661         
2662         This header contains some global variables used by EFL's
2663         DumpRenderTree implementation.
2664
2665         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
2666         appropriate.
2667         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
2668
2669 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
2670
2671         [EFL] Send the right key names for PageUp and PageDown.
2672         https://bugs.webkit.org/show_bug.cgi?id=67044
2673
2674         Reviewed by Kenneth Rohde Christiansen.
2675
2676         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
2677         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
2678         However, EventSender was sending "Page_Up" and "Page_Down", so tests
2679         such as editing/input/page-up-down-scrolls.html were timing out due to
2680         the right key down events not being sent.
2681
2682         * DumpRenderTree/efl/EventSender.cpp:
2683         (keyPadNameFromJSValue):
2684         (keyNameFromJSValue):
2685
2686 2011-09-12  Eric Seidel  <eric@webkit.org>
2687
2688         sheriffbot whois is case sensitive
2689         https://bugs.webkit.org/show_bug.cgi?id=67972
2690
2691         Reviewed by Adam Barth.
2692
2693         I also fixed a typo in the "More than 5 contributors" message
2694         from my previous commit.
2695
2696         * Scripts/webkitpy/common/config/committers.py:
2697         * Scripts/webkitpy/common/config/committers_unittest.py:
2698         * Scripts/webkitpy/tool/bot/irc_command.py:
2699         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2700
2701 2011-09-12  Eric Seidel  <eric@webkit.org>
2702
2703         sheriffbot whois should be smarter
2704         https://bugs.webkit.org/show_bug.cgi?id=67971
2705
2706         Reviewed by Adam Barth.
2707
2708         This makes sheriffbot whois basically grep the committers list
2709         making it much easier to find a contributor by name.
2710
2711         Unfortunately the current unittests depend on the real committers.py
2712         file, so as we add more eric's to the project, this unittest result will
2713         change.  I think that's OK for now.  We'll fix it when it breaks.
2714
2715         * Scripts/webkitpy/common/config/committers.py:
2716         * Scripts/webkitpy/tool/bot/irc_command.py:
2717         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2718
2719 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2720
2721         Unreviewed, rolling out r94976.
2722         http://trac.webkit.org/changeset/94976
2723         https://bugs.webkit.org/show_bug.cgi?id=67953
2724
2725         Broke a bunch of security/load& tests (Requested by rniwa on
2726         #webkit).
2727
2728         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2729         (LayoutTestController::pathToLocalResource):
2730
2731 2011-09-12  Eric Seidel  <eric@webkit.org>
2732
2733         Rubber-stamped by Adam Barth.
2734
2735         Remove the "the tree is burning!" warning previously shown
2736         when landing patches.  It was a dream.  But it's just noise now.
2737
2738         Some bots will require a restart to notice the removal of the option
2739         so I've left the --ignore-builders option in for now.
2740
2741         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2742         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2743         * Scripts/webkitpy/tool/commands/download.py:
2744         * Scripts/webkitpy/tool/commands/download_unittest.py:
2745         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2746         * Scripts/webkitpy/tool/steps/__init__.py:
2747         * Scripts/webkitpy/tool/steps/commit.py:
2748         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
2749         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2750
2751 2011-09-12  Eric Seidel  <eric@webkit.org>
2752
2753         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2754         https://bugs.webkit.org/show_bug.cgi?id=65781
2755
2756         Reviewed by Ryosuke Niwa.
2757
2758         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
2759         to resolve the passed in url relative to the absolute url for the test.
2760
2761         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2762         (which resolves the path relative to the built location of the DRT executable)
2763         and we should move this new code into a shared location in a follow-up patch.
2764
2765         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2766         (LayoutTestController::pathToLocalResource):
2767
2768 2011-09-12  Eric Seidel  <eric@webkit.org>
2769
2770         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2771         https://bugs.webkit.org/show_bug.cgi?id=67530
2772
2773         Reviewed by Adam Barth.
2774
2775         I believe I've fixed the bug in the original patch which prompted the rollout.
2776         The previous patch was using the wrong deadline for the initial read,
2777         subtracting time.time() twice from the deadline value.
2778
2779         * Scripts/webkitpy/layout_tests/port/webkit.py:
2780         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2781
2782 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
2783
2784         [Qt][WK2] WebKitTestRunner does not produce crash logs
2785         https://bugs.webkit.org/show_bug.cgi?id=67714
2786
2787         Reviewed by Chang Shu.
2788
2789         Added a simple way of generating backtrace on crash
2790         to the web process. The implementation is similar what
2791         we have in DRT. It depends on GNU libc functionality
2792         so it is only enabled where we are running in such an environment.
2793
2794         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2795         (WTR::printBacktrace):
2796         (WTR::crashHandler):
2797         (WTR::InjectedBundle::platformInitialize):
2798
2799 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
2800
2801         Added my IRC nick to the committers file.
2802
2803         * Scripts/webkitpy/common/config/committers.py:
2804
2805 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
2806
2807         The executable allocator makes it difficult to free individual
2808         chunks of executable memory
2809         https://bugs.webkit.org/show_bug.cgi?id=66363
2810
2811         Reviewed by Oliver Hunt.
2812         
2813         Introduced a best-fit, balanced-tree based allocator. The allocator
2814         required a balanced tree that does not allocate memory and that
2815         permits the removal of individual nodes directly (as opposed to by
2816         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
2817         Changed all references to executable code to use a reference counted
2818         handle.
2819
2820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2821         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
2822         (TestWebKitAPI::TEST_F):
2823         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
2824         (TestWebKitAPI::Pair::findExact):
2825         (TestWebKitAPI::Pair::remove):
2826         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
2827         (TestWebKitAPI::Pair::assertFoundAndRemove):
2828         (TestWebKitAPI::Pair::assertEqual):
2829         (TestWebKitAPI::Pair::assertSameValuesForKey):
2830         (TestWebKitAPI::Pair::testDriver):
2831         (TestWebKitAPI::TEST_F):
2832
2833 2011-09-10  Andy Estes  <aestes@apple.com>
2834
2835         Move myself from committers_unable_to_review to reviewers_list.
2836
2837         * Scripts/webkitpy/common/config/committers.py:
2838
2839 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
2840
2841         [wx] Unreviewed build fix. MSW build fixes.
2842
2843         * DumpRenderTree/config.h:
2844         * waf/build/wxpresets.py:
2845
2846 2011-09-10  Andreas Kling  <kling@webkit.org>
2847
2848         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
2849         https://bugs.webkit.org/show_bug.cgi?id=59328
2850
2851         Reviewed by Kenneth Rohde Christiansen.
2852
2853         * MiniBrowser/mac/BrowserWindowController.m:
2854         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
2855
2856 2011-09-10  Adam Barth  <abarth@webkit.org>
2857
2858         Build fix for Android.  DumpRenderTree is a client of the WebKit API
2859         and does not have access to notImplemented().
2860
2861         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2862         (openStartupDialog):
2863
2864 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
2865
2866         Add a script to create a monolithic script-test
2867         https://bugs.webkit.org/show_bug.cgi?id=67747
2868
2869         Reviewed by Darin Adler.
2870
2871         * Scripts/make-new-script-test: Added.
2872
2873 2011-09-09  Luiz Agostini  <luiz@webkit.org>
2874
2875         Adding myself to the reviewers list.
2876
2877         * Scripts/webkitpy/common/config/committers.py:
2878
2879 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
2880
2881         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
2882         https://bugs.webkit.org/show_bug.cgi?id=67855
2883
2884         Reviewed by Dirk Pranke.
2885
2886         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
2887         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
2888
2889         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
2890
2891         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2892
2893 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
2894
2895         Add myself to committers.py
2896         https://bugs.webkit.org/show_bug.cgi?id=67853
2897
2898         Reviewed by Darin Adler.
2899
2900         * Scripts/webkitpy/common/config/committers.py:
2901
2902 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2903
2904         [Qt] Remove common.pri
2905         https://bugs.webkit.org/show_bug.cgi?id=67814
2906
2907         Reviewed by Andreas Kling.
2908
2909         * Tools.pro:
2910
2911 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2912
2913         [NRWT] the nrwt check httpd with --no-http option
2914         https://bugs.webkit.org/show_bug.cgi?id=67835
2915
2916         Reviewed by Tony Chang.
2917
2918         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2919         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2920
2921 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
2922
2923         [chromium] Implement DRT support for Android.
2924         https://bugs.webkit.org/show_bug.cgi?id=67590
2925
2926         Reviewed by Tony Chang.
2927
2928         Add 2 mechanism to make DRT interaction more robust on Android:
2929         - Send 'QUIT' to DRT to make it stop.
2930         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
2931         input commands before it starts.
2932         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
2933         and <clocale> for 'LC_ALL' to compile on Android.
2934
2935         Also change to use sigaction instead of signal for TestShellGtk.cpp,
2936         as signal() man page recommends using sigaction().
2937
2938         * DumpRenderTree/DumpRenderTree.gypi:
2939         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2940         (main):
2941         * DumpRenderTree/chromium/LayoutTestController.cpp:
2942         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
2943         (AlarmHandler):
2944         (TestShell::waitTestFinished):
2945         (platformInit):
2946         (openStartupDialog):
2947         (checkLayoutTestSystemDependencies):
2948         * DumpRenderTree/chromium/TestShellGtk.cpp:
2949         (AlarmHandler):
2950         (TestShell::waitTestFinished):
2951
2952 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
2953
2954         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
2955
2956         * waf/build/settings.py:
2957
2958 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2959
2960         Unreviewed, rolling out r94851.
2961         http://trac.webkit.org/changeset/94851
2962         https://bugs.webkit.org/show_bug.cgi?id=67847
2963
2964         It broke a webkitpy test (Requested by ossy on #webkit).
2965
2966         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2967
2968 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2969
2970         [NRWT] the nrwt check httpd with --no-http option
2971         https://bugs.webkit.org/show_bug.cgi?id=67835
2972
2973         Reviewed by Csaba Osztrogonác.
2974
2975         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2976
2977 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
2978
2979         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
2980         https://bugs.webkit.org/show_bug.cgi?id=67794
2981         <rdar://problem/9892024>
2982         
2983         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
2984
2985         Reviewed by Brady Eidson.
2986
2987         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
2988         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
2989         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
2990         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
2991             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
2992             didPerformServerRedirect.
2993
2994         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
2995         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
2996             our InjectedBundleTest.
2997         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
2998             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
2999             the request.
3000         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
3001
3002         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
3003         
3004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3005         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
3006         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
3007         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
3008
3009 2011-09-08  David Levin  <levin@chromium.org>
3010
3011         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
3012         https://bugs.webkit.org/show_bug.cgi?id=67797
3013
3014         Reviewed by Eric Seidel.
3015
3016         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
3017         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
3018
3019 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
3020
3021         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
3022         https://bugs.webkit.org/show_bug.cgi?id=67723
3023
3024         Reviewed by Adam Barth.
3025
3026         * DumpRenderTree/chromium/EventSender.h:
3027         * DumpRenderTree/chromium/LayoutTestController.cpp:
3028         (LayoutTestController::LayoutTestController):
3029         (LayoutTestController::enableFixedLayoutMode):
3030         (LayoutTestController::setFixedLayoutSize):
3031         * DumpRenderTree/chromium/LayoutTestController.h:
3032
3033 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
3034
3035         Add standalone script that filters the output of build-webkit to be more human-readable
3036         https://bugs.webkit.org/show_bug.cgi?id=44081
3037
3038         Reviewed by Daniel Bates.
3039
3040         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
3041         a build script (e.g. build-webkit) and it spits out a prettier version.
3042         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
3043         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
3044
3045 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
3046
3047         Add myself to committers.py                 
3048         https://bugs.webkit.org/show_bug.cgi?id=67696
3049
3050         Reviewed by Kent Tamura.
3051
3052         * Scripts/webkitpy/common/config/committers.py:
3053
3054 2011-09-07  Adam Barth  <abarth@webkit.org>
3055
3056         rebaseline button in garden-o-matic details view should work
3057         https://bugs.webkit.org/show_bug.cgi?id=67738
3058
3059         Reviewed by Dimitri Glazkov.
3060
3061         This patch wires up the rebaseline button in garden-o-matic results
3062         details view.  The button is current per-test, so there isn't a way to
3063         rebaseline individual bots.  This is a place to start.  If we decide we
3064         want per-bot rebaselining, we'll need to think of some better UI.
3065
3066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3070
3071 2011-09-07  Eric Seidel  <eric@webkit.org>
3072
3073         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
3074         https://bugs.webkit.org/show_bug.cgi?id=67737
3075
3076         Reviewed by Adam Barth.
3077
3078         I got a little over-eager when deprecating host.port_factory in the previous commit.
3079         Turns out that Host.port_factory was already the "modern" port/factory.py
3080         it was just the Module object.  I un-deprecated the variable, and changed it from
3081         being the module to being an actual PortFactory, passing it a host object.
3082         I also taught PortFactory how to set user/executive/filesystem in the kwargs
3083         when instantiating a new Port object.
3084         This magically fixed the test_rebaseline test, since its now no longer talking
3085         to the real filesystem.
3086
3087         * Scripts/webkitpy/common/host.py:
3088         * Scripts/webkitpy/layout_tests/port/factory.py:
3089         * Scripts/webkitpy/tool/commands/queries.py:
3090         * Scripts/webkitpy/tool/mocktool.py:
3091
3092 2011-09-07  Eric Seidel  <eric@webkit.org>
3093
3094         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
3095         https://bugs.webkit.org/show_bug.cgi?id=67734
3096
3097         Reviewed by Adam Barth.
3098
3099         Right now every place that creates a Port object has to be very careful
3100         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
3101         The correct fix is for port/factory.py (which creates most port objects)
3102         to know how to pass these in automatically.  However, currently all port/factory.py
3103         functions are free functions instead of being on an object.  This patch
3104         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
3105
3106         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
3107         pass along the proper scm/user/filesystem to the Port object.
3108
3109         * Scripts/webkitpy/common/host.py:
3110         * Scripts/webkitpy/layout_tests/port/factory.py:
3111         * Scripts/webkitpy/tool/commands/queries.py:
3112         * Scripts/webkitpy/tool/mocktool.py:
3113
3114 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3115
3116         Unreviewed, rolling out r94441.
3117         http://trac.webkit.org/changeset/94441
3118         https://bugs.webkit.org/show_bug.cgi?id=67731
3119
3120         "MacEWSes are backed up due to new machines not able to reach
3121         git.webkit.org.  Disabling tests for now" (Requested by
3122         eseidel2 on #webkit).
3123
3124         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3125
3126 2011-09-07  Elliot Poger  <epoger@google.com>
3127
3128         filter test_expectations properly for chromium-mac vs chromium-cg-mac
3129         https://bugs.webkit.org/show_bug.cgi?id=67324
3130
3131         Reviewed by Dirk Pranke.
3132
3133         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3134         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3135         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3136         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3137         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3138
3139 2011-09-07  Eric Boren  <borenet@gmail.com>
3140
3141         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3142         https://bugs.webkit.org/show_bug.cgi?id=66800
3143
3144         Reviewed by Darin Fisher.
3145
3146         * DumpRenderTree/chromium/EventSender.cpp:
3147         (EventSender::sendCurrentTouchEvent):
3148
3149 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
3150
3151         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3152         https://bugs.webkit.org/show_bug.cgi?id=67254
3153
3154         Reviewed by Csaba Osztrogonác.
3155
3156         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
3157         derived from the running location of DumpRenderTree binary.
3158
3159         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3160         (LayoutTestController::pathToLocalResource):
3161         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
3162
3163 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3164
3165         REGRESSION(r94288) build-webkit doesn't work on Symbian
3166         https://bugs.webkit.org/show_bug.cgi?id=67706
3167
3168         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
3169         (buildQMakeProject):
3170
3171 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3172
3173         REGRESSION(r94288) build-webkit doesn't work on Windows
3174         https://bugs.webkit.org/show_bug.cgi?id=67646
3175
3176         Roll back r94655 with a small fix.
3177
3178         * Scripts/webkitdirs.pm:
3179         (buildQMakeProject):
3180
3181 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3182
3183         Unreviewed, rolling out r94635.
3184         http://trac.webkit.org/changeset/94635
3185         https://bugs.webkit.org/show_bug.cgi?id=67704
3186
3187         Linux Touch build is failing to compile this change.
3188         (Requested by loislo on #webkit).
3189
3190         * DumpRenderTree/chromium/EventSender.cpp:
3191         (EventSender::sendCurrentTouchEvent):
3192
3193 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3194
3195         Unreviewed, rolling out r94655.
3196         http://trac.webkit.org/changeset/94655
3197         https://bugs.webkit.org/show_bug.cgi?id=67703
3198
3199         It broke Leopard debug bot (Requested by ossy on #webkit).
3200
3201         * Scripts/webkitdirs.pm:
3202
3203 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3204
3205         REGRESSION(r94288) build-webkit doesn't work on Windows
3206         https://bugs.webkit.org/show_bug.cgi?id=67646
3207
3208         Reviewed by Csaba Osztrogonác.
3209
3210         * Scripts/webkitdirs.pm:
3211
3212 2011-09-06  Eric Boren  <borenet@gmail.com>
3213
3214         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3215         https://bugs.webkit.org/show_bug.cgi?id=66800
3216
3217         Reviewed by Darin Fisher.
3218
3219         * DumpRenderTree/chromium/EventSender.cpp:
3220         (EventSender::sendCurrentTouchEvent):
3221
3222 2011-09-06  Adam Barth  <abarth@webkit.org>
3223
3224         garden-o-matic details view should having working rebaseline and next/previous buttons
3225         https://bugs.webkit.org/show_bug.cgi?id=67659
3226
3227         Reviewed by Dimitri Glazkov.
3228
3229         This patch wires up basic back/forward buttons that let you traverse
3230         through the results we're examining in the details view.  This ended up
3231         being more code than I expected, but I wanted to keep all the state
3232         information in the DOM itself.
3233
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3237
3238 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
3239
3240         fix MockFileSystem.glob(), refactor filesystem tests
3241         https://bugs.webkit.org/show_bug.cgi?id=67462
3242
3243         Reviewed by Eric Seidel.
3244
3245         In debugging why my proposed change for MockFileSystem.glob()
3246         in bug 66228 didn't work, I stumbled across two real bugs
3247         that cancelled each other out for the unit tests. I fixed those
3248         (glob shouldn't recurse into subdirs, and we weren't populating
3249         self.dirs from self.files properly).
3250
3251         I have also created a "mixin" class for tests that can be shared
3252         between the real filesystem and the mock filesystem - MockFileSystem
3253         is being used enough it needs its own tests.
3254
3255         * Scripts/webkitpy/common/system/filesystem_mock.py:
3256         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
3257         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3258
3259 2011-09-06  Anders Carlsson  <andersca@apple.com>
3260
3261         Move NPAPI headers in bridge to plugins
3262         https://bugs.webkit.org/show_bug.cgi?id=67661
3263
3264         Update forwarding headers.
3265
3266         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3267         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3268
3269 2011-09-06  Tony Chang  <tony@chromium.org>
3270
3271         [chromium] Check in 'build' for compiled binaries first
3272         https://bugs.webkit.org/show_bug.cgi?id=67549
3273
3274         Reviewed by Dirk Pranke.
3275
3276         I'm working on moving the windows build output to a common location
3277         rather than relative to the sln file.  Because of that, we need to
3278         check those build locations first for DumpRenderTree.exe.
3279
3280         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3281
3282 2011-09-06  Adam Barth  <abarth@webkit.org>
3283
3284         Use a hierarchial structure for the garden-o-matic results view
3285         https://bugs.webkit.org/show_bug.cgi?id=67620
3286
3287         Reviewed by Dimitri Glazkov.
3288
3289         This patch re-organizes the results view to use a hierachial structure
3290         for selection.  At the top-level are sections for each test.  Expanding
3291         the test section shows a tab selector for builders.
3292
3293         This structure prepares us for wiring up various actions to this view.
3294
3295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3296         (.):
3297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3298         ():
3299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3300         (.):
3301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3303         (.results-view>.toolbar):
3304         (.results-view>.toolbar ul.actions):
3305         (.results-view>.toolbar ul.actions li):
3306         (.results-grid table):
3307         (.results-grid table td, .results-view table th):
3308         (.results-grid table th):
3309         (.results-grid .text-result):
3310         (.results-grid .image-result):
3311
3312 2011-09-06  Adam Barth  <abarth@webkit.org>
3313
3314         garden-o-matic's base.probe generates spam in the JavaScript console
3315         https://bugs.webkit.org/show_bug.cgi?id=67622
3316
3317         Reviewed by Dimitri Glazkov.
3318
3319         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
3320         instead of HTMLScriptElement to test whether results exist.  This
3321         reduces the console.log spam and saves bandwidth because we can use a
3322         HEAD request instead of a GET request.
3323
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3325
3326 2011-09-05  Adam Barth  <abarth@webkit.org>
3327
3328         Add a tab to garden-o-matic for viewing expected failures
3329         https://bugs.webkit.org/show_bug.cgi?id=67619
3330
3331         Reviewed by Dimitri Glazkov.
3332
3333         This patch adds a basic tab to garden-o-matic that shows all the tests
3334         failing on the bots, including the expected failures.  This patch
3335         mostly involves refactoring existing classes to allow new subclasses.
3336
3337         This view is useful for when gardeners mark tests as expected to fail
3338         and then rebaseline them later.
3339
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3347
3348 2011-09-05  Adam Barth  <abarth@webkit.org>
3349
3350         Fix global variable leak in garden-o-matic
3351         https://bugs.webkit.org/show_bug.cgi?id=67617
3352
3353         Reviewed by Dimitri Glazkov.
3354
3355         Caught by running the unit tests with noglobals turned on.
3356
3357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3358
3359 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3360
3361         [Qt][WK2] Add pixel test support
3362         https://bugs.webkit.org/show_bug.cgi?id=66283
3363
3364         Reviewed by Andreas Kling.
3365
3366         Implemented pixel result generation by reusing the logic
3367         that we have in DumpRenderTree.
3368         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3369         (WTR::dumpImage):
3370         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3371
3372 2011-09-04  Robin Dunn  <robin@alldunn.com>
3373
3374         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3375         https://bugs.webkit.org/show_bug.cgi?id=67577
3376
3377         Reviewed by Kevin Ollivier.
3378
3379         * waf/build/settings.py:
3380
3381 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3382
3383         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3384
3385         * waf/build/settings.py:
3386
3387 2011-09-03  Dan Bernstein  <mitz@apple.com>
3388
3389         32-bit build fix.
3390
3391         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3392         (TestWebKitAPI::Util::toSTD):
3393
3394 2011-09-03  Dan Bernstein  <mitz@apple.com>
3395
3396         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3397         https://bugs.webkit.org/show_bug.cgi?id=67559
3398
3399         Reviewed by Darin Adler.
3400
3401         * DumpRenderTree/mac/DumpRenderTree.mm:
3402         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3403         the call to it.
3404         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3406         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3407         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3408         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3409         (TestWebKitAPI::Util::toSTD): Added.
3410
3411 2011-09-03  Adam Barth  <abarth@webkit.org>
3412
3413         garden-o-matic results view should have a better results selector
3414         https://bugs.webkit.org/show_bug.cgi?id=67542
3415
3416         Reviewed by Dimitri Glazkov.
3417
3418         This patch adds a basic grid-based results selector to the results
3419         view.  Currently, this grid just shows how the tests fail on the
3420         various bots.  A future patch will let you select which failure to view
3421         and to mark the failures for rebaselining.
3422
3423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3425           - Add some more basic functions for manipulating dictionaries.
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3429
3430 2011-09-03  Adam Barth  <abarth@webkit.org>
3431
3432         garden-o-matic results view should show Actual and Expected results for text failures
3433         https://bugs.webkit.org/show_bug.cgi?id=67536
3434
3435         Reviewed by Eric Seidel.
3436
3437         In the past, we didn't show actual and expected text results (we just
3438         showed the diff) because we didn't have the awesome six-by-two results
3439         grid.  Now that we do, we can move show these results.
3440
3441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3443           - Fixed some typos that were preventing these unit tests from running.
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3445         (.):
3446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3447           - Report -actual.txt and -expected.txt as possible results URLs.
3448
3449 2011-09-03  Adam Barth  <abarth@webkit.org>
3450
3451         garden-o-matic shows "ghost" failures that are already fixed
3452         https://bugs.webkit.org/show_bug.cgi?id=67535
3453
3454         Reviewed by Eric Seidel.
3455
3456         About 10% of writes fail to stick on test-results.appspot.com.  This
3457         patch causes us to fetch the full_results.json blob directly from
3458         build.chromium.org rather than relying upon AppEngine.
3459
3460         Unforuntately, we still need to get historical information from
3461         AppEngine.  That will take several patches to fix becuase I need to
3462         change the bots to write the full_results.json file to the
3463         build-specific directory in addition to the zip file.
3464
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3468
3469 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3470
3471         Unreviewed, rolling out r94458.
3472         http://trac.webkit.org/changeset/94458
3473         https://bugs.webkit.org/show_bug.cgi?id=67558
3474
3475         Caused appcache test to fail on various bots (Requested by
3476         rniwa on #webkit).
3477
3478         * Scripts/webkitpy/layout_tests/port/webkit.py:
3479         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3480
3481 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3482
3483         Unreviewed, rolling out r94453.
3484         http://trac.webkit.org/changeset/94453
3485         https://bugs.webkit.org/show_bug.cgi?id=67557
3486
3487         Caused appcache test to fail on various bots (Requested by
3488         rniwa on #webkit).
3489
3490         * Scripts/webkitpy/layout_tests/port/webkit.py:
3491
3492 2011-09-02  Michael Saboff  <msaboff@apple.com>
3493
3494         Add JSC:RegExp functional tests
3495         https://bugs.webkit.org/show_bug.cgi?id=67339
3496
3497         New perl script to build JavaScriptCore and run the RegExp tests.
3498
3499         Reviewed by Gavin Barraclough.
3500
3501         * Scripts/run-regexp-tests: Added.
3502
3503 2011-09-02  Michael Saboff  <msaboff@apple.com>
3504
3505         Add JSC:RegExp functional tests
3506         https://bugs.webkit.org/show_bug.cgi?id=67339
3507
3508         New perl script to build JavaScriptCore and run the RegExp tests.
3509
3510         Reviewed by Gavin Barraclough.
3511
3512         * Scripts/run-regexp-tests: Added.
3513
3514 2011-09-02  Eric Seidel  <eric@webkit.org>
3515
3516         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3517         https://bugs.webkit.org/show_bug.cgi?id=67530
3518
3519         Unreviewed.  Fixing typo from previous commit.
3520
3521         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
3522         which exercises the code I previously made a typo in.
3523
3524         * Scripts/webkitpy/layout_tests/port/webkit.py:
3525         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3526
3527 2011-09-02  Eric Seidel  <eric@webkit.org>
3528
3529         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3530         https://bugs.webkit.org/show_bug.cgi?id=67530
3531
3532         Reviewed by Adam Barth.
3533
3534         No functional change, just reshuffling code.
3535
3536         * Scripts/webkitpy/layout_tests/port/webkit.py:
3537
3538 2011-09-02  Darin Adler  <darin@apple.com>
3539
3540         Added Subversion ignore for .pyc generated files.
3541
3542         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
3543         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
3544         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
3545
3546 2011-09-02  Adam Barth  <abarth@webkit.org>
3547
3548         Enable testing on mac-ews
3549         https://bugs.webkit.org/show_bug.cgi?id=67505
3550
3551         Reviewed by Eric Seidel.
3552
3553         This patch enables testing on the Mac EWS, which should help
3554         contributors not turn the Mac bots red.
3555
3556         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3557
3558 2011-09-01  Beth Dakin  <bdakin@apple.com>
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=67451
3561         Add a test for going back to a cached page after changing the device scale factor
3562
3563         Reviewed by Adam Roben.
3564
3565         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
3566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3567         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
3568         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3569         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
3570         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3571         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
3572         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3573         (TestWebKitAPI::TEST_F):
3574
3575         Added new function to WebKitAgnosticTest to goBack. Separated 
3576         waitForLoadToFinish() into its own function (instead of being a part of 
3577         loadAndWaitUntilFinished()) so that it can be called from goBack as 
3578         well. Also added initializeView() so we can set the cache model.
3579         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
3580         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
3581         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3582         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
3583         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3584         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3585         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
3586         (TestWebKitAPI::WebKitAgnosticTest::goBack):
3587         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
3588
3589 2011-09-02  Anders Carlsson  <andersca@apple.com>
3590
3591         Build fix.
3592
3593         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
3594         (PrivateBrowsing::ScriptableObject::pluginTest):
3595
3596 2011-09-02  Anders Carlsson  <andersca@apple.com>
3597
3598         Move private browsing test to a PluginTest subclass
3599         https://bugs.webkit.org/show_bug.cgi?id=67498
3600
3601         Reviewed by Darin Adler.
3602
3603         * DumpRenderTree/DumpRenderTree.gypi:
3604         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3605         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3606         (pluginGetProperty):
3607         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3608         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3609         (PluginTest::NPP_SetValue):
3610         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3611         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
3612         (PrivateBrowsing::PrivateBrowsing):
3613         (PrivateBrowsing::privateBrowsingEnabled):
3614         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
3615         (PrivateBrowsing::ScriptableObject::hasProperty):
3616         (PrivateBrowsing::ScriptableObject::getProperty):
3617         (PrivateBrowsing::ScriptableObject::pluginTest):
3618         (PrivateBrowsing::NPP_New):
3619         (PrivateBrowsing::NPP_GetValue):
3620         (PrivateBrowsing::NPP_SetValue):
3621         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3622         (NPP_New):
3623         (NPP_SetValue):
3624         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3625         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3626         * GNUmakefile.am:
3627
3628 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
3629
3630         [Qt] Build dependency problems
3631         https://bugs.webkit.org/show_bug.cgi?id=38054
3632
3633         Trivial fix after r94288.
3634
3635         Rubber-stamped by Andras Becsi.
3636
3637         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
3638         (buildQMakeProject):
3639
3640 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
3641
3642         Remove my old e-mail address and add my new one.
3643
3644         Rubber-stamped by Tor Arne Vestbø.
3645
3646         * Scripts/webkitpy/common/config/committers.py:
3647
3648 2011-09-02  Philippe Normand  <pnormand@igalia.com>
3649
3650         [GTK] run-gtk-tests leaves a zombie Xvfb process
3651         https://bugs.webkit.org/show_bug.cgi?id=67389
3652
3653         Reviewed by Martin Robinson.
3654
3655         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
3656         child process instead of doing shell redirection.
3657
3658 2011-09-01  Mark Rowe  <mrowe@apple.com>
3659
3660         Fix the build by adding some more missing return types.
3661
3662         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3663         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3664
3665 2011-09-01  Eric Seidel  <eric@webkit.org>
3666
3667         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
3668         https://bugs.webkit.org/show_bug.cgi?id=66228
3669
3670         Reviewed by Dirk Pranke.