[GTK] Show url of history items in a status bar in MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Show url of history items in a status bar in MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=71474
5
6         Reviewed by Martin Robinson.
7
8         * MiniBrowser/gtk/BrowserWindow.c:
9         (browserWindowSetStatusText): Set status text and show/hide the
10         status label.
11         (resetStatusText): Reset status text when history menu is hidden.
12         (browserWindowHistoryItemSelected): Show url of currently selected
13         history item.
14         (browserWindowCreateBackForwardMenu): Connect to hide signal of
15         menu to reset the status text.
16         (browserWindowConstructed): Use GtkOverlay if available to show
17         status text.
18
19 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
20
21         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
22         https://bugs.webkit.org/show_bug.cgi?id=71466
23
24         Reviewed by Martin Robinson.
25
26         * MiniBrowser/gtk/BrowserWindow.c:
27         (browserWindowHistoryItemActivated): Go to selected back formard
28         list item using webkit_web_view_go_to_back_forward_list_item()
29         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
30         given GList of WebKitBackForwardListItems.
31         (browserWindowUpdateNavigationActions): Enable/disable back and
32         forward buttons depending on whether it's possible to go
33         back/forward. Create a menu for back and forward toolbar buttons.
34         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
35         (browserWindowConstructed): Connect to WebKitBackForwardList
36         changed signal.
37
38 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
39
40         [Qt] Remove Maemo specific code paths
41         https://bugs.webkit.org/show_bug.cgi?id=71476
42
43         Reviewed by Kenneth Rohde Christiansen.
44
45         * QtTestBrowser/launcherwindow.cpp:
46         (LauncherWindow::~LauncherWindow):
47         (LauncherWindow::init):
48         (LauncherWindow::showLinkHover):
49         (LauncherWindow::selectElements):
50         (LauncherWindow::showFPS):
51         (LauncherWindow::updateFPS):
52         * QtTestBrowser/launcherwindow.h:
53         (WindowOptions::WindowOptions):
54         * QtTestBrowser/locationedit.cpp:
55         * QtTestBrowser/locationedit.h:
56
57 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
58
59         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
60         https://bugs.webkit.org/show_bug.cgi?id=71461
61
62         Reviewed by Martin Robinson.
63
64         * MiniBrowser/gtk/BrowserWindow.c:
65         (resetEntryProgress): Reset the entry progress after a while when
66         load has been completed.
67         (webViewLoadProgressChanged): Update location entry progress.
68         (browserWindowConstructed): Connect to WebView
69         notify::estimated-load-progress signal.
70
71 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
72
73         [GTK] Remove WebKit2 C API from MiniBrowser
74         https://bugs.webkit.org/show_bug.cgi?id=71459
75
76         Reviewed by Martin Robinson.
77
78         Use the GTK+ API instead to add minimum functionality. The other
79         features will be ported to GTK+ API in following patches.
80
81         * MiniBrowser/gtk/BrowserWindow.c:
82         (activateUriEntryCallback): Use webkit_web_view_load_uri().
83         (goBackCallback): Use webkit_web_view_go_back().
84         (goForwardCallback): Use webkit_web_view_go_forward().
85         (webViewURIChanged): Update location entry with current uri using
86         webkit_web_view_get_uri().
87         (browserWindowFinalize):
88         (browserWindowGetProperty):
89         (browserWindowSetProperty):
90         (browser_window_init):
91         (browserWindowConstructed): Connect to notify::uri signal of
92         WebView to be notified when the URI changes.
93         (browser_window_class_init):
94         (browser_window_new): Use WebKitWebView.
95         (browser_window_get_view): Use WebKitWebView
96         * MiniBrowser/gtk/BrowserWindow.h:
97         * MiniBrowser/gtk/GNUmakefile.am:
98         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
99         * MiniBrowser/gtk/main.c:
100         (loadURI): Use webkit_web_view_new().
101         (main):
102
103 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
104
105         [Qt] Unable to start MiniBrowser after run-webkit-tests
106         https://bugs.webkit.org/show_bug.cgi?id=71469
107
108         Reviewed by Csaba Osztrogonác.
109
110         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
111         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
112         line arguments.
113
114 2011-11-03  Philippe Normand  <pnormand@igalia.com>
115
116         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
117         https://bugs.webkit.org/show_bug.cgi?id=71445
118
119         Reviewed by Martin Robinson.
120
121         * DumpRenderTree/gtk/DumpRenderTree.cpp:
122         (initializeFonts): set directoriesDescription only when needed.
123         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
124         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
125         refactored the font files loading code to avoid copy/pastes, ease
126         maintenance and future font directories additions.
127
128 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
129
130         [GTK] Remove GtkLauncher2
131         https://bugs.webkit.org/show_bug.cgi?id=71449
132
133         Reviewed by Martin Robinson.
134
135         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
136         made sense when we wanted to implement the exactly same wk1 API
137         for wk2. Now the code would require an ifdef for most the api, so
138         it's better to remove GtkLauncher2 and port MiniBrowser to the new
139         GTK+ API.
140
141         * GNUmakefile.am:
142         * GtkLauncher/main.c:
143         (notifyProgressCb):
144         (closeWebViewCb):
145         (createBrowser):
146         (addWebSettingsGroupToContext):
147         (main):
148
149 2011-11-02  Philippe Normand  <pnormand@igalia.com>
150
151         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
152         https://bugs.webkit.org/show_bug.cgi?id=71359
153
154         Reviewed by Martin Robinson.
155
156         * DumpRenderTree/gtk/DumpRenderTree.cpp:
157         (initializeFonts): Add the new font path for Debian fonts and
158         refactored the font files loading code to avoid copy/pastes, ease
159         maintenance and future font directories additions.
160
161 2011-11-02  Eric Seidel  <eric@webkit.org>
162
163         Move Mocks into _mock files near their implementations
164         https://bugs.webkit.org/show_bug.cgi?id=71425
165
166         Reviewed by Adam Barth.
167
168         This entire change is splitting mocktool.py into separate _mock.py files
169         and placing them next to their real implementations.
170
171         I also deleted MockPortFactory (since it was wrong) and was just hiding
172         the fact that the "skipped-ports" command was broken (and has been for a long time).
173         So I made MockHost use a real PortFactory (passed a MockHost) and changed
174         the skipped-ports implementation to use modern PortFactory methods.
175
176         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
177         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
178         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
179         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
180         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
181         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
182         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
183         * Scripts/webkitpy/common/host.py:
184         * Scripts/webkitpy/common/host_mock.py: Added.
185         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
186         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
187         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
188         * Scripts/webkitpy/common/net/credentials_unittest.py:
189         * Scripts/webkitpy/common/net/failuremap_unittest.py:
190         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
191         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
192         * Scripts/webkitpy/common/net/statusserver_unittest.py:
193         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
194         * Scripts/webkitpy/common/system/executive.py:
195         * Scripts/webkitpy/common/system/executive_mock.py:
196         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
197         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
198         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
199         * Scripts/webkitpy/common/system/workspace_unittest.py:
200         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
201         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
202         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
203         * Scripts/webkitpy/layout_tests/port/__init__.py:
204         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
205         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
206         * Scripts/webkitpy/layout_tests/port/factory.py:
207         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
208         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
209         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
210         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
211         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
212         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
213         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
214         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
215         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
216         * Scripts/webkitpy/test/main.py:
217         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
218         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
219         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
220         * Scripts/webkitpy/tool/commands/queries_unittest.py:
221         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
222         * Scripts/webkitpy/tool/mocktool.py:
223         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
224
225 2011-11-02  Dan Bernstein  <mitz@apple.com>
226
227         Fixed the build and removed another copy to ColorBits.ttf.
228
229         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
230         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
231         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
232
233 2011-11-02  Dan Bernstein  <mitz@apple.com>
234
235         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
236         https://bugs.webkit.org/show_bug.cgi?id=71424
237
238         Reviewed by Sam Weinig.
239
240         Removed the ColorBits font and the code to register it in the process
241         running the tests. The font was only used by the aforementioned test,
242         which is now being removed.
243
244         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
245         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
246         * DumpRenderTree/mac/DumpRenderTree.mm:
247         (allowedFontFamilySet):
248         (activateTestingFonts):
249         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
250         (WTR::inititializeFontConfigSetting):
251         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
252         (WTR::allowedFontFamilySet):
253         (WTR::activateFonts):
254
255 2011-11-02  Dan Bernstein  <mitz@apple.com>
256
257         Fix an intermittent hang in RenderedImageFromDOMRange.
258
259         Reviewed by Anders Carlsson.
260
261         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
262         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
263         immediately if there are no sources by passing a date in the distant past.
264
265 2011-11-02  Adam Roben  <aroben@apple.com>
266
267         Add git-add-reviewer
268
269         I've been using this script for a while to add reviewers to git commits in my local
270         repository before pushing them to the Subversion repository. Basic usage is:
271
272         git-add-reviewer HEAD^ "Joe Schmoe"
273         or
274         git-add-reviewer -i trunk
275
276         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
277         git commits
278
279         Reviewed by Sam Weinig.
280
281         * Scripts/git-add-reviewer: Added.
282         (top level): Parse options, check that the working tree is clean, then run in either
283         interactive or non-interactive mode as appropriate.
284         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
285         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
286         editor exits, we check out the commit just before the earliest one we're modifying. Then
287         for each commit, we check it out, update the reviewer, and amend the commit to contain the
288         new reviewer. Finally, we update the branch that was originally checked out to point to the
289         last amended commit.
290         (nonInteractive): Check out the commit to modify, write the current commit message to the
291         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
292         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
293         a usage message and exit.
294         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
295         and index are clean.
296         (fail): Print out the specified error message, if any, and return false. This function is
297         used as a return value in various error cases throughout the script.
298         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
299         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
300         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
301         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
302
303         (addReviewerToChangeLog):
304         (addReviewerToCommitMessage):
305         These just call through to addReviewerToFile.
306
307         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
308         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
309         temp file, then move the temp file over the original file and stage it for the next commit.
310         (head): Returns the name of the currently-checked-out branch.
311         (isAncestor): Returns true if the first commit is an ancestor of the second.
312         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
313         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
314         (resetToCommit): Checks out the given commit, throwing away any local changes.
315         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
316         the specified file.
317         (rebaseOntoHead): Rebases the specified branch onto HEAD.
318         (checkout): Checks out the given commit.
319         (getConfigValue): Reads the specified config variable from git-config.
320
321 2011-11-02  Dean Jackson  <dino@apple.com>
322
323         Add ENABLE_CSS_SHADERS flag
324         https://bugs.webkit.org/show_bug.cgi?id=71394
325
326         Reviewed by Sam Weinig.
327
328         * Scripts/build-webkit:
329
330 2011-10-31  Eric Seidel  <eric@webkit.org>
331
332         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
333         https://bugs.webkit.org/show_bug.cgi?id=71237
334
335         Reviewed by Adam Barth.
336
337         Calling the static version of factory.get() with proper mocking
338         requires passsing an explict filesystem, executive, etc.
339         So instead, we use a PortFactory instance and pass it a Host pointer.
340         I had to add a MockHost since we'd not needed a non-host tool before now.
341
342         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
343         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
344         * Scripts/webkitpy/tool/commands/rebaseline.py:
345         * Scripts/webkitpy/tool/mocktool.py:
346
347 2011-11-02  Anders Carlsson  <andersca@apple.com>
348
349         Update for the WebKit2 API fixage.
350
351         * MiniBrowser/mac/BrowserWindowController.m:
352         (-[BrowserWindowController awakeFromNib]):
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::TestController::initialize):
355
356 2011-11-02  Anders Carlsson  <andersca@apple.com>
357
358         Fix build.
359
360         Add new functions to the page loader client.
361
362         * MiniBrowser/mac/BrowserWindowController.m:
363         (-[BrowserWindowController awakeFromNib]):
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::TestController::initialize):
366
367 2011-11-02  Dan Bernstein  <mitz@apple.com>
368
369         <rdar://problem/10336700> Add API to get rendered text image without having to select it
370         https://bugs.webkit.org/show_bug.cgi?id=71407
371
372         Reviewed by Simon Fraser.
373
374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
375         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
376         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
377         (TestWebKitAPI::TEST):
378
379 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
380
381         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
382         https://bugs.webkit.org/show_bug.cgi?id=71351
383
384         Reviewed by Darin Adler.
385
386         Add the delimiter "/" at the end of the path instead of adding +1 when using
387         the path.
388
389         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
390         (-[NSURL _drt_descriptionSuitableForTestResult]):
391
392 2011-11-02  Tom Sepez  <tsepez@chromium.org>
393
394         XSSAuditor is silent
395         https://bugs.webkit.org/show_bug.cgi?id=70973
396
397         Reviewed by Adam Barth.
398
399         * DumpRenderTree/chromium/WebViewHost.cpp:
400         (WebViewHost::didDetectXSS):
401         * DumpRenderTree/chromium/WebViewHost.h:
402         * DumpRenderTree/mac/FrameLoadDelegate.mm:
403         (-[FrameLoadDelegate webView:didDetectXSS:]):
404         * MiniBrowser/mac/BrowserWindowController.m:
405         (didDetectXSSForFrame):
406         (-[BrowserWindowController awakeFromNib]):
407         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
408         (WTR::InjectedBundlePage::InjectedBundlePage):
409         (WTR::InjectedBundlePage::didDetectXSSForFrame):
410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
411
412 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
413
414         [Qt] REGRESSION: 5 editing tests fail
415         https://bugs.webkit.org/show_bug.cgi?id=71117
416
417         Reviewed by Andreas Kling.
418
419         Make sure that the view is properly focused, in order to get the
420         didBeginEditing DRT calls.
421
422         This requires activating the window (the call will result in a FocusIn
423         event to the window as well as setting QGuiApplication::focusWindow())
424         as well as enabling the focus on the view item. The signature of
425         setFocus has changed to take a boolean.
426
427         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
428         (WTR::WrapperWindow::handleStatusChanged):
429
430 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
431
432         [chromium] Add per-script font preferences support in overridePreference
433         https://bugs.webkit.org/show_bug.cgi?id=71110
434
435         This allows a layout test to do something like:
436
437         // Set standard font for Arabic to Ahem.
438         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
439
440         This should make writing a layout test for per-script fonts easier.
441
442         This change only affects the Chromium DumpRenderTree, but the other
443         platforms should probably also have a similar change eventually.
444
445         Reviewed by Tony Chang.
446
447         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
448         font preferences to overridePreference
449         (LayoutTestController::cppVariantToWebStringArray):
450         (setFontMap):
451         (LayoutTestController::overridePreference):
452         * DumpRenderTree/chromium/LayoutTestController.h:
453         * DumpRenderTree/chromium/WebPreferences.cpp:
454         (setStandardFontFamilyWrapper):
455         (setFixedFontFamilyWrapper):
456         (setSerifFontFamilyWrapper):
457         (setSansSerifFontFamilyWrapper):
458         (setCursiveFontFamilyWrapper):
459         (setFantasyFontFamilyWrapper):
460         (applyFontMap):
461         (WebPreferences::applyTo):
462         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
463         preference members
464         (WebPreferences::UScriptCodeHashTraits::emptyValue):
465         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
466         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
467
468 2011-11-02  Elliot Poger  <epoger@google.com>
469
470         until use_skia=1 by default on mac, default port should be chromium-cg-mac
471         https://bugs.webkit.org/show_bug.cgi?id=71312
472
473         Reviewed by Adam Barth.
474
475         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
476         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
477         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
478
479 2011-11-02  Stephen Chenney  <schenney@chromium.org>
480
481         printing layout test failures after r98634
482         https://bugs.webkit.org/show_bug.cgi?id=71080
483
484         Reviewed by Kent Tamura
485
486         * DumpRenderTree/chromium/WebViewHost.cpp:
487         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
488         matches that for Skia.
489
490 2011-11-01  Sam Weinig  <sam@webkit.org>
491
492         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
493         https://bugs.webkit.org/show_bug.cgi?id=71346
494
495         Reviewed by Dan Bernstein.
496
497         * Scripts/webkit-tools-completion.sh:
498         Add "-o default" which allows for completing files in addition to the word list.
499
500 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
501
502         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
503         https://bugs.webkit.org/show_bug.cgi?id=71310
504
505         Reviewed by Kenneth Rohde Christiansen.
506
507         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
508         define works in EventSendingController.idl
509         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
510         handlers.
511         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
512         required by tests.
513         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
514         ui process.
515         (WTR::EventSendingController::addTouchPoint):
516         (WTR::EventSendingController::updateTouchPoint):
517         (WTR::EventSendingController::setTouchModifier):
518         (WTR::EventSendingController::touchStart):
519         (WTR::EventSendingController::touchMove):
520         (WTR::EventSendingController::touchEnd):
521         (WTR::EventSendingController::clearTouchPoints):
522         (WTR::EventSendingController::releaseTouchPoint):
523         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
524         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
525         defines.
526         * WebKitTestRunner/TestController.cpp:
527         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
528         touch messages to the EventSenderProxy.
529         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
530         (WTR::EventSenderProxy::EventSenderProxy):
531         (WTR::EventSenderProxy::addTouchPoint):
532         (WTR::EventSenderProxy::updateTouchPoint):
533         (WTR::EventSenderProxy::setTouchModifier):
534         (WTR::EventSenderProxy::touchStart):
535         (WTR::EventSenderProxy::touchMove):
536         (WTR::EventSenderProxy::touchEnd):
537         (WTR::EventSenderProxy::clearTouchPoints):
538         (WTR::EventSenderProxy::releaseTouchPoint):
539         (WTR::EventSenderProxy::sendTouchEvent):
540         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
541
542 2011-11-01  Sam Weinig  <sam@webkit.org>
543
544         resolve-ChangeLogs --help should be faster.
545
546         Reviewed by Adam Roben.
547
548         * Scripts/resolve-ChangeLogs:
549         (usageAndExit):
550         Add a call to usageAndExit() before doing work to find unmerged changelogs
551         if --help or something illegal is provided on the command line.
552
553 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
554
555         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
556         https://bugs.webkit.org/show_bug.cgi?id=71342
557
558         Reviewed by Darin Adler.
559
560         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
561         [NSString substringFromIndex:] with an index out of the string range.
562
563         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
564         from the root of the disk.
565         The problem was hidden because the exception are catched when calling the delegate.
566
567         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
568         in a subdirectory of the main frame.
569
570         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
571         (-[NSURL _drt_descriptionSuitableForTestResult]):
572
573 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
574
575         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
576         https://bugs.webkit.org/show_bug.cgi?id=71318
577
578         Reviewed by James Robinson.
579         
580         Fixed a typo for --enable-hardware-gpu flag.
581
582         * Scripts/webkitpy/layout_tests/port/chromium.py:
583
584 2011-11-01  Elliot Poger  <epoger@google.com>
585
586         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
587         https://bugs.webkit.org/show_bug.cgi?id=71286
588
589         Reviewed by Stephen White.
590
591         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
592
593 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
594
595         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
596         https://bugs.webkit.org/show_bug.cgi?id=71299
597
598         Reviewed by Andreas Kling.
599
600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
601         build to enable WebCoreTestSupport::injectInternalsObject.
602         (WTR::InjectedBundlePage::didClearWindowForFrame):
603         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
604
605 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
606
607         [Qt] Merge common desktop and touch view APIs under a base class.
608         https://bugs.webkit.org/show_bug.cgi?id=71280
609
610         Reviewed by Andreas Kling.
611
612         Remove unneded forwarding logic for TouchWebView since those properties are
613         now in the view just as the desktop web view.
614
615         * MiniBrowser/qt/qml/TouchView.qml:
616
617 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
618
619         check-webkit-style: Allow names starting with "_q_".
620         https://bugs.webkit.org/show_bug.cgi?id=70625
621
622         Reviewed by Tor Arne Vestbø.
623
624         Used by the Qt port as the standard prefix for private slots.
625
626         * Scripts/webkitpy/style/checkers/cpp.py:
627         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
628
629 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
630
631         [Qt][WK2] Fix valgrind error about uninitialized variable
632         https://bugs.webkit.org/show_bug.cgi?id=71273
633
634         Reviewed by Kenneth Christiansen.
635
636         * MiniBrowser/qt/MiniBrowserApplication.cpp:
637         (MiniBrowserApplication::notify): Initialize isPrimary.
638
639 2011-10-31  Adam Roben  <aroben@apple.com>
640
641         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
642
643         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
644         leaky builds
645
646         Reviewed by Anders Carlsson.
647
648         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
649         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
650         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
651         total of N bytes!").
652
653 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
654
655         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
656         https://bugs.webkit.org/show_bug.cgi?id=71228
657
658         Reviewed by Antonio Gomes.
659
660         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
661         (DumpRenderTreeChrome::createNewWindow):
662         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
663
664 2011-10-31  Eric Seidel  <eric@webkit.org>
665
666         webkitpy tests depend too much on the user's environment
667         https://bugs.webkit.org/show_bug.cgi?id=71234
668
669         Reviewed by Dirk Pranke.
670
671         This change just makes a bunch of our older tests use
672         more modern mocking to avoid trying to launch processes
673         or read from the user's filesystem during unittesting.
674
675         I found many of these by adding an assert in Executive.run_command
676         that we were not unittesting.  I can't add that assert always
677         as there are some valid uses of Executive during unittesting.
678         Once I fix more of these, I may find a way to add such an assert conditionally.
679
680         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
681         * Scripts/webkitpy/common/net/credentials_unittest.py:
682         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
683         * Scripts/webkitpy/layout_tests/port/base.py:
684         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
685
686 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
687
688         [Qt] MiniBrowser doesn't resize as the size is always overridden
689         https://bugs.webkit.org/show_bug.cgi?id=71212
690
691         Reviewed by Simon Hausmann.
692
693         Remove call overriden the size.
694
695         * MiniBrowser/qt/main.cpp:
696         (main):
697
698 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
699
700         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
701         http://trac.webkit.org/changeset/98819
702         http://trac.webkit.org/changeset/98823
703         http://trac.webkit.org/changeset/98825
704         http://trac.webkit.org/changeset/98830
705         https://bugs.webkit.org/show_bug.cgi?id=71199
706
707         Broke Chromium Windows bot (Requested by rniwa on #webkit).
708
709         * Scripts/webkitpy/layout_tests/port/base.py:
710         * Scripts/webkitpy/layout_tests/port/chromium.py:
711         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
712         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
713         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
714         * Scripts/webkitpy/layout_tests/port/efl.py:
715         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
716         * Scripts/webkitpy/layout_tests/port/mac.py:
717         * Scripts/webkitpy/layout_tests/port/qt.py:
718         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
719         * Scripts/webkitpy/layout_tests/port/webkit.py:
720         * Scripts/webkitpy/layout_tests/port/win.py:
721
722 2011-10-30  Eric Seidel  <eric@webkit.org>
723
724         new-run-webkit-tests is locale dependent
725         https://bugs.webkit.org/show_bug.cgi?id=68691
726
727         Unreviewed.
728
729         This is a temporary hack until someone from the cr-win port
730         can take a look and determine which environment variable
731         lighttpd is missing.
732
733         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
734
735 2011-10-30  Eric Seidel  <eric@webkit.org>
736
737         new-run-webkit-tests is locale dependent
738         https://bugs.webkit.org/show_bug.cgi?id=68691
739
740         Unreviewed.  I would have preferred to have this reviewed,
741         but relevant reviewers are asleep and bots are broken.
742
743         This was a regression from moving to a clean environment.
744         ChromiumWin (and possibly other ports), need the "PATH"
745         environment copied over.  This wasn't caught in my testing
746         because although we had unittests to cover this, they
747         weren't being run on anything but windows.  The vast majority
748         of this change is just fixing the unittests to use our
749         modern MockFileSystem/MockUser/MockExecutive so they can
750         be run on any system (and removing the platform checks from
751         the unittests so they are run everywhere).
752
753         The actual fix is the single line "PATH" string added to base.py.
754         The rest of this change is just fixing the Chromium port unittests
755         to run on all systems (including changing the Chromium port to
756         use FileSystem.path_to_module instead of __file__).
757
758         * Scripts/webkitpy/layout_tests/port/base.py:
759         * Scripts/webkitpy/layout_tests/port/chromium.py:
760         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
761         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
762         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
763         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
764
765 2011-10-29  Eric Seidel  <eric@webkit.org>
766
767         new-run-webkit-tests is locale dependent
768         https://bugs.webkit.org/show_bug.cgi?id=68691
769
770         Unreviewed.
771
772         Fix the Qt port and unittest the function so we don't break it again.
773
774         * Scripts/webkitpy/layout_tests/port/qt.py:
775         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
776
777 2011-10-29  Eric Seidel  <eric@webkit.org>
778
779         new-run-webkit-tests is locale dependent
780         https://bugs.webkit.org/show_bug.cgi?id=68691
781
782         Reviewed by Adam Barth.
783
784         Make NRWT use a clean environment just like ORWT did.
785         I've manually validated that NRWT now copies over
786         the same environment variables that ORWT did.
787         This new code is exercised by existing setup_environ_for_server tests.
788
789         * Scripts/webkitpy/layout_tests/port/base.py:
790         * Scripts/webkitpy/layout_tests/port/efl.py:
791         * Scripts/webkitpy/layout_tests/port/mac.py:
792         * Scripts/webkitpy/layout_tests/port/qt.py:
793         * Scripts/webkitpy/layout_tests/port/webkit.py:
794         * Scripts/webkitpy/layout_tests/port/win.py:
795
796 2011-10-29  Eric Seidel  <eric@webkit.org>
797
798         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
799         https://bugs.webkit.org/show_bug.cgi?id=34984
800
801         Reviewed by Adam Barth.
802
803         Move run-webkit-tests from using a white-list of supported NRWT ports
804         to a blacklist of ports requiring ORWT.
805
806         I've also added the ability to opt-in to parallel testing on a per-port basis.
807
808         With these changes I'm going to officially declare this bug dead and
809         work on remaining polish issues and individual developer complaints.
810
811         * Scripts/run-webkit-tests:
812         (useNewRunWebKitTests):
813         (platformIsReadyForParallelTesting):
814
815 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
816
817         Unreviewed, rolling out r98780.
818         http://trac.webkit.org/changeset/98780
819         https://bugs.webkit.org/show_bug.cgi?id=71173
820
821         Broke Qt bots (Requested by rniwa on #webkit).
822
823         * Scripts/run-webkit-tests:
824         (useNewRunWebKitTests):
825
826 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
827
828         webkit.py gdb visualizer is broken after change to StringImpl
829         https://bugs.webkit.org/show_bug.cgi?id=71154
830
831         Reviewed by Tony Chang.
832
833         r98624 changed StringImpl m_data to m_data32. This changes updates
834         webkit.py to match.
835
836         * gdb/webkit.py:
837
838 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
839
840         Fix typo in check-for-inappropriate-objc-class-names
841         https://bugs.webkit.org/show_bug.cgi?id=71144
842
843         Reviewed by Dan Bernstein.
844
845         * Scripts/check-for-inappropriate-objc-class-names:
846
847 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
848
849         Add support for sending scroll-update events from EventSender.
850         https://bugs.webkit.org/show_bug.cgi?id=66272
851
852         Reviewed by Adam Barth.
853
854         * DumpRenderTree/chromium/EventSender.cpp:
855         (EventSender::EventSender):
856         (EventSender::reset):
857         (EventSender::gestureScrollUpdate):
858         (EventSender::gestureEvent):
859         * DumpRenderTree/chromium/EventSender.h:
860
861 2011-10-28  Eric Seidel  <eric@webkit.org>
862
863         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
864         https://bugs.webkit.org/show_bug.cgi?id=34984
865
866         Reviewed by Adam Barth.
867
868         Move run-webkit-tests from using a white-list of supported NRWT ports
869         to a blacklist of ports requiring ORWT.
870
871         I've also added the ability to opt-in to parallel testing on a per-port basis.
872
873         With these changes I'm going to officially declare this bug dead and
874         work on remaining polish issues and individual developer complaints.
875
876         * Scripts/run-webkit-tests:
877         (useNewRunWebKitTests):
878         (platformIsReadyForParallelTesting):
879
880 2011-10-28  Eric Seidel  <eric@webkit.org>
881
882         NRWT crashes when parsing leaks output due to UTF-8 decoding error
883         https://bugs.webkit.org/show_bug.cgi?id=71112
884
885         Reviewed by Adam Barth.
886
887         Use read_binary_file instead of read_text_file and add a test
888         case with some non-utf8 data to make sure we don't break this in the future.
889
890         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
891         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
892
893 2011-10-28  David Levin  <levin@chromium.org>
894
895         watchlist should not CC the bug reporter
896         https://bugs.webkit.org/show_bug.cgi?id=71079
897
898         Reviewed by Adam Barth.
899
900         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
901         which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
902
903         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
904         * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
905         * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
906
907 2011-10-28  Zoltan Horvath  <zoltan@webkit.org>
908
909         Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
910         https://bugs.webkit.org/show_bug.cgi?id=71116
911
912         Reviewed by David Levin.
913
914         * Scripts/webkitpy/common/config/watchlist:
915
916 2011-10-28  Simon Hausmann  <simon.hausmann@nokia.com>
917
918         [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
919         https://bugs.webkit.org/show_bug.cgi?id=70494
920
921         Reviewed by Kenneth Christiansen.
922
923         Use QQuick* instead of QSG* as well as QStandardPaths
924         instead of QDesktopLocation.
925
926         * MiniBrowser/qt/BrowserWindow.cpp:
927         (BrowserWindow::BrowserWindow):
928         * MiniBrowser/qt/BrowserWindow.h:
929         * QtTestBrowser/cookiejar.cpp:
930         (TestBrowserCookieJar::TestBrowserCookieJar):
931         * QtTestBrowser/launcherwindow.cpp:
932         (LauncherWindow::setDiskCache):
933         * WebKitTestRunner/PlatformWebView.h:
934         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
935         (WTR::WrapperWindow::WrapperWindow):
936         (WTR::WrapperWindow::handleStatusChanged):
937
938 2011-10-28  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
939
940         [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
941         https://bugs.webkit.org/show_bug.cgi?id=71106
942
943         Reviewed by Simon Hausmann.
944
945         Holding Ctrl allows multiple touch points to be held on the screen using
946         mouse buttons. It would previously only prevent TouchReleased to be sent
947         and would require another MouseButtonRelease to be sent without holding Ctrl.
948
949         This patch makes sure that all held touch points are released when Ctrl
950         is released if MouseButtonRelease was received.
951         It also removes the touch QEvent::Type logic since it's currently handled
952         by QtGui by observing the modified touch points.
953
954         * MiniBrowser/qt/MiniBrowserApplication.cpp:
955         (MiniBrowserApplication::notify):
956         (MiniBrowserApplication::sendTouchEvent):
957         * MiniBrowser/qt/MiniBrowserApplication.h:
958
959 2011-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
960
961         [Qt] MiniBrowser needs a -window-size option
962         https://bugs.webkit.org/show_bug.cgi?id=70999
963
964         Reviewed by Simon Hausmann.
965
966         Add an -window-size option useful for testing the viewport handling.
967         Also clean up the option handling.
968
969         * MiniBrowser/qt/BrowserWindow.cpp:
970         (BrowserWindow::BrowserWindow):
971         * MiniBrowser/qt/MiniBrowserApplication.cpp:
972         (MiniBrowserApplication::handleUserOptions):
973         * MiniBrowser/qt/MiniBrowserApplication.h:
974         (WindowOptions::WindowOptions):
975         (WindowOptions::setRequestedWindowSize):
976         (WindowOptions::requestedWindowSize):
977         * MiniBrowser/qt/utils.cpp:
978         (takeOptionValue):
979         * MiniBrowser/qt/utils.h:
980
981 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
982
983         Add allowScriptFromSource callback to FrameLoaderClient
984         https://bugs.webkit.org/show_bug.cgi?id=71013
985
986         Reviewed by Darin Fisher.
987
988         * DumpRenderTree/chromium/LayoutTestController.cpp:
989         (LayoutTestController::LayoutTestController):
990         (LayoutTestController::setScriptsAllowed):
991         * DumpRenderTree/chromium/LayoutTestController.h:
992         * DumpRenderTree/chromium/WebPermissions.cpp:
993         (WebPermissions::allowScriptFromSource):
994         (WebPermissions::setScriptsAllowed):
995         (WebPermissions::reset):
996         * DumpRenderTree/chromium/WebPermissions.h:
997
998 2011-10-28  Alexandru Chiculita  <achicu@adobe.com>
999
1000         Added myself as a committer.
1001
1002         * Scripts/webkitpy/common/config/committers.py:
1003
1004 2011-10-27  Adam Barth  <abarth@webkit.org>
1005
1006         Remove WinCairo from the set of core builders.  WinCairo rarely builds
1007         and is never green.
1008
1009         Rubber-stamped by Eric Seidel.
1010
1011         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1012         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1013
1014 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
1015
1016         WebSocket: Connecting to localhost:8880 takes one second on Windows
1017         https://bugs.webkit.org/show_bug.cgi?id=64788
1018
1019         Reviewed by Dirk Pranke.
1020
1021         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1022         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
1023         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
1024         from timing out on Windows, because this test tries to open a lot of
1025         connections to localhost and each attempt takes one second to fall back from
1026         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
1027
1028 2011-10-27  Adam Barth  <abarth@webkit.org>
1029
1030         Dis-integrate run-bindings-tests with webkitpy
1031         https://bugs.webkit.org/show_bug.cgi?id=71092
1032
1033         Reviewed by Ryosuke Niwa.
1034
1035         These tests aren't really adding any value.
1036
1037         * Scripts/webkitpy/common/config/ports.py:
1038         * Scripts/webkitpy/tool/commands/download_unittest.py:
1039         * Scripts/webkitpy/tool/mocktool.py:
1040         * Scripts/webkitpy/tool/steps/runtests.py:
1041         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1042         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1043
1044 2011-10-27  Eric Seidel  <eric@webkit.org>
1045
1046         REGRESSION (r98639): NRWT crashes when parsing leaks output
1047         https://bugs.webkit.org/show_bug.cgi?id=71087
1048
1049         Unreviewed.  Sadly we have no good way to test logging.
1050
1051         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1052
1053 2011-10-27  David Levin  <levin@chromium.org>
1054
1055         Test expectation errors should include the file name and platform in both the log and exception info.
1056         https://bugs.webkit.org/show_bug.cgi?id=71067
1057
1058         Reviewed by Ojan Vafai.
1059
1060         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1061         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1062
1063 2011-10-27  Eric Seidel  <eric@webkit.org>
1064
1065         new-run-webkit-tests doesn't understand --qt or --gtk
1066         https://bugs.webkit.org/show_bug.cgi?id=63970
1067
1068         Reviewed by Ojan Vafai.
1069
1070         Add support for --qt and --gtk to NRWT.
1071         I also removed some incorrect comments in the option parsing
1072         code (options which we already implement, but said we didn't)
1073         as well as moved --platform parsing out of the "results_options"
1074         section into the top configuration section.
1075
1076         Now run-webkit-tests no longer needs NRWT-specific code for passing
1077         --platform=qt, etc.
1078
1079         * Scripts/run-webkit-tests:
1080         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1081
1082 2011-10-27  Eric Seidel  <eric@webkit.org>
1083
1084         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
1085         https://bugs.webkit.org/show_bug.cgi?id=66227
1086
1087         Reviewed by Adam Roben.
1088
1089         I believe this should fix the bug.
1090
1091         * Scripts/run-webkit-tests: make NRWT default for --leaks
1092         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1093         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
1094         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
1095         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
1096         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1097         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
1098         * Scripts/webkitpy/layout_tests/port/mac.py:
1099         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
1100
1101 2011-10-27  Stephen Chenney  <schenney@chromium.org>
1102
1103         [Chromium] Need setPrinting
1104         https://bugs.webkit.org/show_bug.cgi?id=46152
1105
1106         Reviewed by Hajime Morita.
1107
1108         * DumpRenderTree/chromium/LayoutTestController.cpp:
1109         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
1110         (LayoutTestController::reset): Clearing flags for setPrinting.
1111         (LayoutTestController::setPrinting): Set flags for setPrinting.
1112         * DumpRenderTree/chromium/LayoutTestController.h:
1113         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
1114         (LayoutTestController::isPrinting): Method to return the setPrinting status.
1115         * DumpRenderTree/chromium/TestShell.cpp:
1116         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
1117         (TestShell::dump): Modified to dump setPrinting-specific output.
1118         * DumpRenderTree/chromium/WebViewHost.cpp:
1119         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
1120         active.
1121         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
1122
1123 2011-10-27  Sam Weinig  <sam@webkit.org>
1124
1125         Add allowsPlugIns property to WKBrowsingContextGroup
1126         https://bugs.webkit.org/show_bug.cgi?id=70987
1127
1128         Reviewed by Anders Carlsson.
1129
1130         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1131         Add basic test for WKBrowsingContextGroup.allowsPlugIns. 
1132
1133 2011-10-27  Adam Roben  <aroben@apple.com>
1134
1135         Test WKBundlePageGetBackingScaleFactor
1136
1137         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
1138         can't reliably determine the scale factor of snapshots returned via
1139         WKBundlePageCreateSnapshot* API
1140
1141         Reviewed by Sam Weinig.
1142
1143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1144
1145         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
1146         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
1147         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
1148         (TestWebKitAPI::createWindow): Conjure up a window.
1149         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
1150         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
1151         factors and when using a custom scale factor, and check that we get those same scale factors
1152         back.
1153
1154         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
1155         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
1156         members.
1157         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
1158         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
1159         from the page using the new API and send it back.
1160
1161 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
1162
1163         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
1164
1165         Rubber-stamped by Simon Hausmann.
1166
1167         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1168         (MiniBrowserApplication::handleUserOptions):
1169         Fix typo error.
1170
1171 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
1172
1173         [WebSocket] update pywebsocket to 0.7.
1174         https://bugs.webkit.org/show_bug.cgi?id=70992
1175
1176         Reviewed by Kent Tamura.
1177
1178         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
1179
1180         * Scripts/webkitpy/thirdparty/__init__.py:
1181
1182 2011-10-27  Elliot Poger  <epoger@google.com>
1183
1184         make lion observe MAC lines in test_expectations.txt
1185         https://bugs.webkit.org/show_bug.cgi?id=70941
1186
1187         Reviewed by Ojan Vafai.
1188
1189         * Scripts/webkitpy/layout_tests/port/chromium.py:
1190         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1191
1192 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
1193
1194         [Chromium] Allow DRT to be built without notifications enabled.
1195         https://bugs.webkit.org/show_bug.cgi?id=70919
1196
1197         Reviewed by Tony Gentilcore.
1198
1199         * DumpRenderTree/chromium/LayoutTestController.cpp:
1200         (LayoutTestController::grantDesktopNotificationPermission):
1201         (LayoutTestController::simulateDesktopNotificationClick):
1202         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1203         * DumpRenderTree/chromium/TestShell.cpp:
1204         (TestShell::TestShell):
1205         (TestShell::resetTestController):
1206
1207 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1208
1209         [Qt] Improve command line arguments handling for MiniBrowser.
1210         https://bugs.webkit.org/show_bug.cgi?id=70616
1211
1212         Reviewed by Kenneth Rohde Christiansen.
1213
1214         - Use two dashes for word arguments.
1215         - Return with an error when an unsupported argument is given.
1216         - Allow the URL to be placed before option arguments.
1217
1218         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1219         (printHelp):
1220         (MiniBrowserApplication::handleUserOptions):
1221         * MiniBrowser/qt/utils.cpp:
1222         (takeOptionFlag):
1223         (takeOptionValue):
1224         * MiniBrowser/qt/utils.h:
1225
1226 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
1227
1228         [Qt] NRWT doesn't work on qt-mac platform
1229         https://bugs.webkit.org/show_bug.cgi?id=64445
1230
1231         Reviewed by Adam Barth.
1232
1233         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
1234         (useNewRunWebKitTests):
1235         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
1236
1237 2011-10-26  Sam Weinig  <sam@webkit.org>
1238
1239         Add initial setting to WKBrowsingContextGroup
1240         https://bugs.webkit.org/show_bug.cgi?id=70942
1241
1242         Reviewed by Anders Carlsson.
1243
1244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1245         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
1246         Add basic test that setting the javaScriptEnabled setting takes. It is not
1247         possible to test its effect quite yet.
1248
1249 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
1250
1251         [GTK] [WK2] Add WebKit2 distcheck support
1252         https://bugs.webkit.org/show_bug.cgi?id=70933
1253
1254         Reviewed by Martin Robinson.
1255
1256         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
1257         sources and EXTRA_DIST.
1258
1259 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
1260
1261         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
1262
1263         Reviewed by Tor Arne Vestbø.
1264
1265         We're using QScroller since r98460, which requires QWidget/QApplication. So
1266         use QApplication and QtWidgets for the time being.
1267
1268         * MiniBrowser/qt/MiniBrowser.pro:
1269         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1270         (MiniBrowserApplication::MiniBrowserApplication):
1271         (MiniBrowserApplication::notify):
1272         * MiniBrowser/qt/MiniBrowserApplication.h:
1273
1274 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1275
1276         [Qt][WK2] Rewrite MiniBrowser in QML
1277         https://bugs.webkit.org/show_bug.cgi?id=70315
1278
1279         Add the first QML based implementation of MiniBrowser.
1280
1281         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1282                  Zeno Albisser <zeno.albisser@nokia.com>
1283
1284         Reviewed by Tor Arne Vestbø.
1285
1286         * MiniBrowser/qt/BrowserWindow.cpp:
1287         (BrowserWindow::BrowserWindow):
1288         (BrowserWindow::webView):
1289         (BrowserWindow::load):
1290         (BrowserWindow::keyPressEvent):
1291         (BrowserWindow::~BrowserWindow):
1292         * MiniBrowser/qt/BrowserWindow.h:
1293         * MiniBrowser/qt/MiniBrowser.pro:
1294         * MiniBrowser/qt/MiniBrowser.qrc:
1295         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1296         (MiniBrowserApplication::MiniBrowserApplication):
1297         (MiniBrowserApplication::handleUserOptions):
1298         * MiniBrowser/qt/MiniBrowserApplication.h:
1299         (WindowOptions::WindowOptions):
1300         * MiniBrowser/qt/UrlLoader.cpp:
1301         (UrlLoader::UrlLoader):
1302         * MiniBrowser/qt/icons/next.png: Added.
1303         * MiniBrowser/qt/icons/previous.png: Added.
1304         * MiniBrowser/qt/icons/refresh.png: Added.
1305         * MiniBrowser/qt/icons/stop.png: Added.
1306         * MiniBrowser/qt/main.cpp:
1307         (main):
1308         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
1309
1310 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
1311
1312         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
1313         https://bugs.webkit.org/show_bug.cgi?id=70529
1314
1315         Remove obsolete code for a new QML based implementation
1316         of MiniBrowser.
1317         Change BrowserWindow to derive from QSGView instead of
1318         QMainWindow. QSGView is used as a top level window that
1319         provides the container for placing QML content.
1320         Make MiniBrowserApplication derive from QGuiApplication
1321         instead of QApplication.
1322
1323         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1324                  Zeno Albisser <zeno.albisser@nokia.com>
1325
1326         Reviewed by Simon Hausmann.
1327
1328         * MiniBrowser/qt/BrowserView.cpp: Removed.
1329         * MiniBrowser/qt/BrowserView.h: Removed.
1330         * MiniBrowser/qt/BrowserWindow.cpp:
1331         (BrowserWindow::BrowserWindow):
1332         (BrowserWindow::load):
1333         (BrowserWindow::screenshot):
1334         (BrowserWindow::loadURLListFromFile):
1335         (BrowserWindow::updateUserAgentList):
1336         (BrowserWindow::~BrowserWindow):
1337         * MiniBrowser/qt/BrowserWindow.h:
1338         * MiniBrowser/qt/MiniBrowser.pro:
1339         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1340         (MiniBrowserApplication::MiniBrowserApplication):
1341         (MiniBrowserApplication::notify):
1342         * MiniBrowser/qt/MiniBrowserApplication.h:
1343         * MiniBrowser/qt/UrlLoader.cpp:
1344         (UrlLoader::UrlLoader):
1345         * MiniBrowser/qt/main.cpp:
1346
1347 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1348
1349         [Qt][WK2] Remove QAction from MiniBrowser
1350         https://bugs.webkit.org/show_bug.cgi?id=70525
1351
1352         In order to rewrite MiniBrowser in QML we need a suitable
1353         mechanism for triggering navigation actions.
1354         Due to the QtWidgets dependency of QAction the current
1355         solution is not suitable anymore. Therefore we introduce
1356         invokable methods and export properties in QWebNavigationController.
1357
1358         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1359                  Zeno Albisser <zeno.albisser@nokia.com>
1360
1361         Reviewed by Simon Hausmann.
1362
1363         * MiniBrowser/qt/BrowserView.cpp:
1364         * MiniBrowser/qt/BrowserView.h:
1365         * MiniBrowser/qt/BrowserWindow.cpp:
1366         (BrowserWindow::BrowserWindow):
1367
1368 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1369
1370         [EFL] Unregister viewport,changed signal in EWebLauncher.
1371         https://bugs.webkit.org/show_bug.cgi?id=70478
1372
1373         Reviewed by Eric Seidel.
1374
1375         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
1376         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
1377         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
1378         This signal is for mobile device.
1379
1380         * EWebLauncher/main.c:
1381         (browserCreate):
1382
1383 2011-10-25  Anders Carlsson  <andersca@apple.com>
1384
1385         Plug-ins have no way to find out when the device scale factor changes
1386         https://bugs.webkit.org/show_bug.cgi?id=67226
1387         <rdar://problem/10048276>
1388
1389         Reviewed by Sam Weinig.
1390
1391         Keep a cached copy of the contents scale and update it when it changes.
1392
1393         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
1394         (ContentsScaleFactor::ContentsScaleFactor):
1395         (ContentsScaleFactor::cachedContentsScaleFactor):
1396         (ContentsScaleFactor::ScriptableObject::hasProperty):
1397         (ContentsScaleFactor::ScriptableObject::getProperty):
1398         (ContentsScaleFactor::NPP_New):
1399         (ContentsScaleFactor::NPP_SetValue):
1400
1401 2011-10-25  Sam Weinig  <sam@webkit.org>
1402
1403         Add WKBrowsingContextLoadDelegateTest test for a failed load
1404         https://bugs.webkit.org/show_bug.cgi?id=70859
1405
1406         Reviewed by Anders Carlsson.
1407
1408         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1409         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
1410  
1411         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
1412         Test that we are getting the correct NSError code and domain.
1413
1414 2011-10-25  Erik Arvidsson  <arv@chromium.org>
1415
1416         JS Test Harness: Make successfullyParsed optional
1417         https://bugs.webkit.org/show_bug.cgi?id=70784
1418
1419         Reviewed by Ojan Vafai.
1420
1421         * Scripts/make-new-script-test:
1422         (writeTestFile): Update the template for script tests.
1423
1424 2011-10-25  Anders Carlsson  <andersca@apple.com>
1425
1426         Plug-ins have to use JavaScript to find out the current device scale factor
1427         https://bugs.webkit.org/show_bug.cgi?id=67225
1428         <rdar://problem/10048258>
1429
1430         Reviewed by Darin Adler.
1431
1432         Add a plug-in test for getting the contents scale factor.
1433
1434         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1435         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
1436         (ContentsScaleFactor::ContentsScaleFactor):
1437         (ContentsScaleFactor::contentsScaleFactor):
1438         (ContentsScaleFactor::ScriptableObject::hasProperty):
1439         (ContentsScaleFactor::ScriptableObject::getProperty):
1440         (ContentsScaleFactor::ScriptableObject::pluginTest):
1441         (ContentsScaleFactor::NPP_GetValue):
1442
1443 2011-10-25  Sam Weinig  <sam@webkit.org>
1444
1445         Flesh out WKBrowsingContextLoadDelegate a bit
1446         https://bugs.webkit.org/show_bug.cgi?id=70846
1447
1448         Reviewed by Anders Carlsson.
1449
1450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1451         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
1452         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
1453         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
1454         (WKBrowsingContextLoadDelegateTest::SetUp):
1455         (WKBrowsingContextLoadDelegateTest::TearDown):
1456         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
1457         (TEST_F):
1458         Add basic testing for WKBrowsingContextLoadDelegate.
1459
1460 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
1461
1462         make-script-test-wrappers should not look outside fast/js
1463         https://bugs.webkit.org/show_bug.cgi?id=66357
1464
1465         Reviewed by Maciej Stachowiak.
1466
1467         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
1468         fast/js.
1469
1470 2011-10-25  Adam Barth  <abarth@webkit.org>
1471
1472         Add a --make option to update-webkit to engage the Makefile-based build system
1473         https://bugs.webkit.org/show_bug.cgi?id=70847
1474
1475         Reviewed by Dimitri Glazkov.
1476
1477         I can never remember what crazy environment variables I'm supposed to
1478         set to tell GYP what to do.
1479
1480         * Scripts/update-webkit:
1481
1482 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
1483
1484         [EFL] DRT: Force layout when sending events.
1485         https://bugs.webkit.org/show_bug.cgi?id=70357
1486
1487         Reviewed by Antonio Gomes.
1488
1489         Some tests such as editing/input/page-up-down-scrolls.html rely on the
1490         scrollbars being properly set up during the onload events.
1491         Document::implicitClose(), however, dispatches the onload events before
1492         calling FrameView::layout(), so these tests usually fail.
1493
1494         We now do the same as the GTK+ and Chromium ports and manually force the
1495         layout when dispatching events.
1496
1497         * DumpRenderTree/efl/EventSender.cpp:
1498         (sendMouseEvent):
1499         (keyDownCallback):
1500
1501 2011-10-25  Daniel Bates  <dbates@rim.com>
1502
1503         build-webkit --clean should only clean build directory for CMake-based ports
1504         https://bugs.webkit.org/show_bug.cgi?id=70834
1505
1506         Reviewed by Antonio Gomes.
1507
1508         Currently build-webkit --clean both cleans the build directory and builds WebKit for
1509         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
1510         as per its description in the usage message of build-webkit.
1511
1512         * Scripts/webkitdirs.pm:
1513         (buildCMakeProjectOrExit):
1514
1515 2011-10-25  Anna Cavender  <annacc@chromium.org>
1516
1517         Enable running of track layout tests for Chromium
1518         https://bugs.webkit.org/show_bug.cgi?id=70803
1519
1520         Reviewed by Adam Barth.
1521         
1522         Make DumpRenderTree/TestShell always run with track enabled
1523         (equivalent of --enable-video-track).
1524
1525         * DumpRenderTree/chromium/TestShell.cpp:
1526         (TestShell::TestShell):
1527
1528 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
1529
1530         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
1531         https://bugs.webkit.org/show_bug.cgi?id=70603
1532
1533         Reviewed by Gustavo Noronha Silva.
1534
1535         * MiniBrowser/gtk/BrowserWindow.c:
1536         (focus):
1537         (unFocus):
1538         (browserWindowUIClientInit):
1539
1540 2011-10-25  Dan Bernstein  <mitz@apple.com>
1541
1542         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
1543
1544         Reviewed by Adam Roben.
1545
1546         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1547         (TestWebKitAPI::TEST):
1548
1549 2011-10-25  Eric Seidel  <eric@webkit.org>
1550
1551         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
1552         https://bugs.webkit.org/show_bug.cgi?id=64471
1553
1554         Reviewed by Adam Roben.
1555
1556         Speculative fix.
1557
1558         * Scripts/webkitpy/layout_tests/port/win.py:
1559         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1560
1561 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
1562
1563         Fix bug summary when rolling Chromium DEPS to LKGR.
1564         https://bugs.webkit.org/show_bug.cgi?id=69917
1565
1566         Reviewed by Adam Barth.
1567
1568         * Scripts/webkitpy/tool/bot/irc_command.py:
1569         * Scripts/webkitpy/tool/bot/sheriff.py:
1570         * Scripts/webkitpy/tool/commands/roll.py:
1571         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1572
1573 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
1574
1575         [EFL] Build fix. Add include path to find npapi.h
1576         https://bugs.webkit.org/show_bug.cgi?id=70730
1577
1578         Unreviewed build fix.
1579
1580         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
1581
1582 2011-10-24  Eric Seidel  <eric@webkit.org>
1583
1584         Plugin tests are failing after switching WK2 to NRWT
1585         https://bugs.webkit.org/show_bug.cgi?id=70760
1586
1587         Reviewed by Simon Fraser.
1588
1589         Perpetuate this horrible hack.
1590
1591         * Scripts/webkitpy/layout_tests/port/webkit.py:
1592
1593 2011-10-24  Eric Seidel  <eric@webkit.org>
1594
1595         NRWT doesn't support ORWT's --root option, but should
1596         https://bugs.webkit.org/show_bug.cgi?id=70416
1597
1598         Reviewed by Dirk Pranke.
1599
1600         Add support for ORWT's --root option which is used for
1601         running tests with a nightly build of WebKit.
1602
1603         * Scripts/old-run-webkit-tests:
1604         * Scripts/webkitpy/layout_tests/port/base.py:
1605          - webkit_build_path was never called by any code, removed.
1606         * Scripts/webkitpy/layout_tests/port/webkit.py:
1607         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1608
1609 2011-10-24  David Levin  <levin@chromium.org>
1610
1611         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
1612         https://bugs.webkit.org/show_bug.cgi?id=70747
1613
1614         Reviewed by Tony Chang.
1615
1616         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
1617         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
1618
1619 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
1620
1621         [Qt][WK2] Crash when running pixel tests
1622         https://bugs.webkit.org/show_bug.cgi?id=70725
1623
1624         Reviewed by Chang Shu.
1625
1626         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1627         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1628
1629 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1630
1631         [GTK] Remove g_thread_init() calls
1632         https://bugs.webkit.org/show_bug.cgi?id=70717
1633
1634         Reviewed by Xan Lopez.
1635
1636         With newer glib it's not needed anymore and with previous versions
1637         it was already called by g_type_init().
1638
1639         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1640         (main):
1641         * GtkLauncher/main.c:
1642         (main):
1643         * MiniBrowser/gtk/main.c:
1644         (main):
1645
1646 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
1647
1648         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
1649         https://bugs.webkit.org/show_bug.cgi?id=69403
1650
1651         We did not added autotoolsconfig.h to the config.h file and we
1652         were adding Platform.h without the config.h in the
1653         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
1654         the Prefix file.
1655
1656         Reviewed by Martin Robinson.
1657
1658         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1659
1660 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
1661
1662         [EFL] Remove unused code from EWebLauncher
1663         https://bugs.webkit.org/show_bug.cgi?id=70590
1664
1665         Reviewed by Andreas Kling.
1666
1667         Removed unused function on_closeWindow from EWebLauncher
1668
1669         * EWebLauncher/main.c:
1670
1671 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
1672
1673         Add watchlist for WebCore/css and put myself on it.
1674         https://bugs.webkit.org/show_bug.cgi?id=70701
1675
1676         Reviewed by Adam Barth.
1677
1678         * Scripts/webkitpy/common/config/watchlist:
1679         Add watchlist for WebCore/css and put myself on it.
1680
1681 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1682
1683         [GTK] Implement KeyDown function for WebKit2 EventSender.
1684         https://bugs.webkit.org/show_bug.cgi?id=69410
1685
1686         Reviewed by Martin Robinson.
1687
1688         Implement the KeyDown function on Gtk platform.
1689
1690         * WebKitTestRunner/GNUmakefile.am:
1691         * WebKitTestRunner/TestController.cpp:
1692         (WTR::TestController::TestController):
1693         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1694         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
1695         (WTR::EventSenderProxy::EventSenderProxy):
1696         (WTR::dispatchEvent):
1697         (WTR::getModifiers):
1698         (WTR::getGDKKeySymForKeyRef):
1699         (WTR::EventSenderProxy::keyDown):
1700
1701 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
1702
1703         [WK2][GTK] run-launcher script fails after testing WK2 tests
1704         https://bugs.webkit.org/show_bug.cgi?id=70676
1705
1706         Reviewed by Andreas Kling.
1707
1708         Pass the '-2' flag instead of '--webkit-test-runner' when executing
1709         run-launcher script after testing with WebKitTestRunner.
1710
1711         * Scripts/webkitpy/layout_tests/port/gtk.py:
1712
1713 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
1714
1715         [WK2][GTK] Missing env variables cause WKTR to crash
1716         https://bugs.webkit.org/show_bug.cgi?id=70674
1717
1718         Reviewed by Martin Robinson.
1719
1720         Set two environment variables that the Gtk's port of WebKitTestRunner
1721         depends on and crashes if they're not explicitly set by the user.
1722         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
1723         properly uses the _build_path method.
1724
1725         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
1726         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
1727         environment variables.
1728
1729 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
1730
1731         Bencher script doesn't measure GC times accurately
1732         https://bugs.webkit.org/show_bug.cgi?id=70588
1733
1734         Reviewed by Geoff Garen.
1735         
1736         Added two new options which allow different ways of measuring GC times:
1737         
1738         --measure-gc, which omits calls to gc() between benchmark invocations.
1739         This option takes an optional argument, which is the name of the
1740         VM in which to enable this feature. This allows comparing a single VM
1741         against itself, with and without GC.
1742         
1743         --rerun <N>, which causes each sample measurement to include N invocations
1744         which do not have gc() calls between them. The default is N = 1, which
1745         results in the same behavior as before.
1746         
1747         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
1748         N >= 3) to get more of a contribution from GC to the measured times.
1749         --rerun results in tighter confidence intervals than --measure-gc, since
1750         it amortizes GC effects in each sample, while with --measure-gc some
1751         samples will see GC and some won't leading to a higher standard devation
1752         and thus requiring more samples to reduce confidence intervals to
1753         managable levels.
1754
1755         * Scripts/bencher:
1756
1757 2011-10-21  Sam Weinig  <sam@webkit.org>
1758
1759         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
1760         https://bugs.webkit.org/show_bug.cgi?id=70653
1761
1762         Reviewed by Simon Fraser.
1763
1764         * MiniBrowser/mac/AppDelegate.h:
1765         * MiniBrowser/mac/AppDelegate.m:
1766         (-[BrowserAppDelegate init]):
1767         (-[BrowserAppDelegate newWindow:]):
1768         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1769         * MiniBrowser/mac/BrowserWindowController.h:
1770         * MiniBrowser/mac/BrowserWindowController.m:
1771         (-[BrowserWindowController initWithContext:pageGroup:]):
1772         (-[BrowserWindowController windowWillClose:]):
1773         (createNewPage):
1774         (-[BrowserWindowController awakeFromNib]):
1775         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1776         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1777         Update testing code to pass a PageGroup as necessary.
1778
1779 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
1780
1781         webkitpy: Teach NRWT about the EFL port
1782         https://bugs.webkit.org/show_bug.cgi?id=70637
1783
1784         Allows using ``efl'' as a platform when executing NRWT.
1785
1786         Reviewed by Eric Seidel.
1787
1788         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
1789         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
1790         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
1791         when using PortFactory.get(port_name='efl').
1792
1793 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
1794
1795         [Gtk] mousemove event always has metaKey == true
1796         https://bugs.webkit.org/show_bug.cgi?id=35299
1797
1798         Reviewed by Martin Robinson.
1799
1800         * DumpRenderTree/gtk/EventSender.cpp:
1801         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
1802         keyboard events. So making it in sync with WebCore files.
1803         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
1804
1805 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1806
1807         watchlist: Add a new entry for WebKit2 GTK+ public API
1808         https://bugs.webkit.org/show_bug.cgi?id=70601
1809
1810         Reviewed by Philippe Normand.
1811
1812         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
1813         for patches that might include new API that points to the WebKit2
1814         GTK+ API guidelines.
1815
1816         * Scripts/webkitpy/common/config/watchlist:
1817
1818 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
1819
1820         Remove QtScript source code from WebKit.
1821         https://bugs.webkit.org/show_bug.cgi?id=64088
1822
1823         Reviewed by Tor Arne Vestbø.
1824
1825         Removed dead code that isn't developed anymore.
1826
1827         * Scripts/webkitpy/style/checker_unittest.py:
1828
1829 2011-10-20  Eric Seidel  <eric@webkit.org>
1830
1831         Switch webkit2 bot to NRWT
1832         https://bugs.webkit.org/show_bug.cgi?id=56729
1833
1834         Reviewed by Adam Barth.
1835
1836         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
1837         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
1838
1839         * Scripts/run-webkit-tests:
1840         (runningOnBuildBot):
1841         (useNewRunWebKitTests):
1842
1843 2011-10-20  Eric Seidel  <eric@webkit.org>
1844
1845         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
1846         https://bugs.webkit.org/show_bug.cgi?id=70585
1847
1848         Reviewed by Adam Barth.
1849
1850         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
1851         However since DRT was functioning fine before in Qt, we'll make this an error log for now
1852         and once we find the root cause flip this back to an assert.
1853
1854         * Scripts/webkitpy/layout_tests/port/webkit.py:
1855
1856 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
1857
1858         Unreviewed, rolling out r98064.
1859         http://trac.webkit.org/changeset/98064
1860         https://bugs.webkit.org/show_bug.cgi?id=64788
1861
1862         Broke Mac bots.
1863
1864         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1865
1866 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
1867
1868         WebSocket: Connecting to localhost:8880 takes one second on Windows
1869         https://bugs.webkit.org/show_bug.cgi?id=64788
1870
1871         Reviewed by Dirk Pranke.
1872
1873         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1874         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
1875         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
1876         from timing out on Windows, because this test tries to open a lot of
1877         connections to localhost and each attempt takes one second to fall back from
1878         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
1879
1880 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
1881
1882         nrwt: newly generated results are put in cross-platform directory
1883         https://bugs.webkit.org/show_bug.cgi?id=68931
1884
1885         Reviewed by Dirk Pranke.
1886
1887         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
1888         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
1889         (because png images are typically different on each platform), and passing True when .txt file is missing
1890         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
1891
1892         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1893         * Scripts/webkitpy/layout_tests/port/test.py:
1894         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
1895         and added a test case.
1896
1897 2011-10-20  Kent Tamura  <tkent@chromium.org>
1898
1899         Unreviewed. Adding myself to watchlist.
1900
1901         * Scripts/webkitpy/common/config/watchlist:
1902         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
1903
1904 2011-10-20  Nico Weber  <thakis@chromium.org>
1905
1906         [chromium/mac] Add support for building with make
1907         https://bugs.webkit.org/show_bug.cgi?id=70455
1908
1909         Reviewed by Adam Barth.
1910
1911         Depends on http://codereview.chromium.org/8352029/
1912         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
1913         create a toplevel Makefile.chromium.
1914
1915         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
1916         `Tools/Scripts/build-webkit --chromium` will build with make instead of
1917         xcodebuild.
1918
1919         Also let nrwt use a binary from out/ if it exists.
1920
1921         * Scripts/webkitdirs.pm:
1922         (determineBaseProductDir):
1923         (isChromiumMacMake):
1924         (determineIsChromiumMacMake):
1925         (buildChromium):
1926
1927 2011-10-20  Eric Seidel  <eric@webkit.org>
1928
1929         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
1930         https://bugs.webkit.org/show_bug.cgi?id=70524
1931
1932         Reviewed by Adam Barth.
1933
1934         This is a speculative fix, since I do not use a platform
1935         which outputs crashlogs over stderr.
1936
1937         * Scripts/webkitpy/layout_tests/port/server_process.py:
1938         * Scripts/webkitpy/layout_tests/port/webkit.py:
1939
1940 2011-10-20  Eric Seidel  <eric@webkit.org>
1941
1942         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
1943         https://bugs.webkit.org/show_bug.cgi?id=70492
1944
1945         Reviewed by Adam Barth.
1946
1947         The bug turned out to be that I was assuming the block.content
1948         would be empty before the binary content following Content-Length
1949         was read inside _read_block.  Turns out its not, due to extra newlines
1950         and "ExpectedHash" header.
1951
1952         In the process of trying to figure out what was going wrong I ended up
1953         cleaning up our newline usage in DumpRenderTree a little.  Moved
1954         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
1955
1956         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
1957         per Adam's request in the original bug.
1958
1959         * DumpRenderTree/PixelDumpSupport.cpp:
1960         (dumpWebViewAsPixelsAndCompareWithExpected):
1961         * DumpRenderTree/cg/ImageDiffCG.cpp:
1962         (main):
1963         * DumpRenderTree/mac/DumpRenderTree.mm:
1964         (dump):
1965         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1966         (restoreMainDisplayColorProfile):
1967         (setupMainDisplayColorProfile):
1968         * Scripts/webkitpy/layout_tests/port/server_process.py:
1969         * Scripts/webkitpy/layout_tests/port/webkit.py:
1970         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1971
1972 2011-10-20  Tony Chang  <tony@chromium.org>
1973
1974         [chromium] Remove <stdint.h> from ImageDiff and use
1975         unsigned int instead of uint32_t.
1976
1977         Unreviewed, fixing the chromium win build.
1978
1979         * DumpRenderTree/chromium/ImageDiff.cpp:
1980         (Image::pixelAt):
1981         (Image::setPixelAt):
1982         (maxOf3):
1983         (getRedComponent):
1984         (getGreenComponent):
1985         (getBlueComponent):
1986         (weightedPercentageDifferent):
1987         (createImageDiff):
1988
1989 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
1990
1991         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
1992         https://bugs.webkit.org/show_bug.cgi?id=69997
1993
1994         Reviewed by Tony Chang.
1995
1996         This change is required to make ImageDiff for Android, and can benefit
1997         other platforms, too. On Android, most targets are built as
1998         toolsets:target. while ImageDiff needs to be built as toolsets:host.
1999         Currently, building the standalone target of ImageDiff depends on about
2000         85 other targets (try  make ImageDiff'), which is inefficient. After the
2001         change, ImageDiff only depends on webkit_support_gfx, which in turn
2002         depends on libpng and zlib.
2003
2004         * DumpRenderTree/chromium/ImageDiff.cpp:
2005         (main):
2006
2007 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2008
2009         [EFL] Unreviewed DumpRenderTree build fix.
2010
2011         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2012         (LayoutTestController::addChromeInputField): Add stub.
2013         (LayoutTestController::removeChromeInputField): Ditto.
2014         (LayoutTestController::focusWebView): Ditto.
2015         (LayoutTestController::setBackingScaleFactor): Ditto.
2016
2017 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2018
2019         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
2020         https://bugs.webkit.org/show_bug.cgi?id=70142
2021
2022         Reviewed by Gustavo Noronha Silva.
2023
2024         * CMakeListsEfl.txt: Include DRT CMakeLists.
2025         * DumpRenderTree/efl/CMakeLists.txt: Added.
2026
2027 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2028
2029         [style] Allow usage of NULL in gst_*
2030         https://bugs.webkit.org/show_bug.cgi?id=70498
2031
2032         Reviewed by David Levin.
2033
2034         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
2035         of gst_ calls. Now just ignore NULL in all of them.
2036         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
2037
2038 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2039
2040         [EFL] Unreviewed. Build fix after r97043.
2041
2042         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2043         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
2044         * DumpRenderTree/efl/EventSender.cpp:
2045         (scalePageByCallback): Ditto.
2046
2047 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2048
2049         Unreviewed. Adding myself to watchlists.
2050         * Scripts/webkitpy/common/config/watchlist:
2051
2052 2011-10-19  Eric Seidel  <eric@webkit.org>
2053
2054         Reviewed by Adam Barth.
2055
2056         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
2057         https://bugs.webkit.org/show_bug.cgi?id=63683
2058
2059         * Scripts/webkitpy/common/net/layouttestresults.py:
2060         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2061         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2062         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2063         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2064         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2065         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2066         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2067         * Scripts/webkitpy/layout_tests/port/base.py:
2068         * Scripts/webkitpy/layout_tests/port/server_process.py:
2069         * Scripts/webkitpy/layout_tests/port/webkit.py:
2070         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2071
2072 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
2073
2074         Chromium doesn't support git branch builds, so don't add the branch to the product dir
2075         https://bugs.webkit.org/show_bug.cgi?id=70449
2076
2077         Reviewed by Eric Seidel.
2078
2079         * Scripts/webkitdirs.pm:
2080         (determineBaseProductDir):
2081
2082 2011-10-19  Ojan Vafai  <ojan@chromium.org>
2083
2084         Unreviewed. Adding myself to watchlists.
2085         * Scripts/webkitpy/common/config/watchlist:
2086
2087 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
2088
2089         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
2090         https://bugs.webkit.org/show_bug.cgi?id=62166
2091
2092         Reviewed by Eric Seidel.
2093
2094         Included options to control committer/reviewer patch count requirements,
2095         an age-limit on patches, and verbose output for more in-depth analysis.
2096
2097         * Scripts/webkitpy/common/checkout/changelog.py:
2098         * Scripts/webkitpy/tool/commands/__init__.py:
2099         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
2100         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
2101
2102 2011-10-19  Eric Seidel  <eric@webkit.org>
2103
2104         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
2105         Make NRWT normalize directory names in Skipped files during parsing.
2106
2107         Unreviewed.  Very simple (tested) change.
2108
2109         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2110         * Scripts/webkitpy/layout_tests/port/webkit.py:
2111
2112 2011-10-19  David Levin  <levin@chromium.org>
2113
2114         watchlist: Should be more robust to bad regex.
2115         https://bugs.webkit.org/show_bug.cgi?id=69486
2116
2117         Reviewed by Adam Barth.
2118
2119         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
2120           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
2121           patterns since they are no longer anchored on the right hand side.
2122         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
2123         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
2124         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
2125         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
2126         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
2127         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
2128         filenames are no longer anchored on the right hand side.
2129         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
2130         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
2131         don't kill everything.
2132
2133 2011-10-19  David Levin  <levin@chromium.org>
2134
2135         watchlist: Add a stylecheck to do validity checks for the watchlist config.
2136         https://bugs.webkit.org/show_bug.cgi?id=69487
2137
2138         Reviewed by Adam Barth.
2139
2140         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
2141         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
2142         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
2143
2144 2011-10-19  Eric Seidel  <eric@webkit.org>
2145
2146         NRWT ServerProcess can't read lines from stderr and stdio separately
2147         https://bugs.webkit.org/show_bug.cgi?id=70435
2148
2149         Reviewed by Adam Barth.
2150
2151         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
2152         DRT expects RWT to read one line at a time from stderr and stdout independently.
2153         This allows DRT to communicate errors over stderr and have them responded to immediately
2154         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
2155         class only exposed a read_line function which would read a line from stdout
2156         and batch all output from stderr into an error buffer.  Callers would only be able
2157         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
2158
2159         * Scripts/webkitpy/layout_tests/port/server_process.py:
2160         * Scripts/webkitpy/layout_tests/port/webkit.py:
2161
2162 2011-10-19  Chang Shu  <cshu@webkit.org>
2163
2164         [Qt] Support WK1-only Skipped list
2165         https://bugs.webkit.org/show_bug.cgi?id=70254
2166
2167         Reviewed by Csaba Osztrogonác.
2168
2169         Added a new search path qt-wk1 for skipping WK1-only tests.
2170
2171         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
2172         * Scripts/old-run-webkit-tests: ORWT
2173
2174 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
2175
2176         [GTK] Enable to use built-product-archive on GTK platform
2177         https://bugs.webkit.org/show_bug.cgi?id=70319
2178
2179         Reviewed by Csaba Osztrogonác.
2180
2181         * BuildSlaveSupport/built-product-archive:
2182
2183 2011-10-18  David Levin  <levin@chromium.org>
2184
2185         watchlist: Should try to run if it can and not throw on mistakes.
2186         https://bugs.webkit.org/show_bug.cgi?id=70358
2187
2188         Reviewed by Adam Barth.
2189
2190         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
2191         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
2192         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
2193         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
2194         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
2195         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
2196
2197 2011-10-18  Sam Weinig  <sam@webkit.org>
2198
2199         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
2200         https://bugs.webkit.org/show_bug.cgi?id=70387
2201
2202         Reviewed by Dan Bernstein.
2203
2204         * MiniBrowser/mac/BrowserWindowController.m:
2205         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2206         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2207         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2208         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2209         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2210         Update to include WKViewPrivate.h where necessary.
2211
2212 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
2213
2214         Web Inspector: Some localizedStrings.js Updates
2215         https://bugs.webkit.org/show_bug.cgi?id=70365
2216
2217         Reviewed by Darin Adler.
2218
2219         * Scripts/check-inspector-strings:
2220         Updated to the new webkitpy way to determine checkout root.
2221
2222         * Scripts/webkitdirs.pm:
2223         (copyInspectorFrontendFiles):
2224         Made it so build-webkit --inspector-frontend copies over
2225         the localizedStrings.js file as well as the frontend files.
2226
2227 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
2228
2229         [EFL] DRT: Clear list of visited pages before each test.
2230         https://bugs.webkit.org/show_bug.cgi?id=70355
2231
2232         Reviewed by Antonio Gomes.
2233
2234         r97596 uncovered a bug in the implementation: the list of visited
2235         links was not cleared between tests, which caused tests such as
2236         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
2237         changed depending on whether fast/repaint/border-repaint-glitch.html
2238         was visited before or not).
2239
2240         Call ewk_history_clear to make sure the visited links list does not
2241         persist between tests.
2242
2243         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2244         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2245
2246 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2247
2248         Split TestExpectationsEditor into its own file.
2249         https://bugs.webkit.org/show_bug.cgi?id=70348
2250
2251         Reviewed by Adam Barth.
2252
2253         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
2254         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
2255         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
2256         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
2257         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
2258
2259 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2260
2261         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
2262         https://bugs.webkit.org/show_bug.cgi?id=70313
2263
2264         Reviewed by Adam Barth.
2265
2266         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
2267         this parameter because build-webkit and other scripts don't accept it.
2268
2269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2270
2271 2011-10-18  Adam Barth  <abarth@webkit.org>
2272
2273         Subscribe myself to WebIDL changes
2274         https://bugs.webkit.org/show_bug.cgi?id=70341
2275
2276         Reviewed by David Levin.
2277
2278         I've also added some documentation and refactored my previous
2279         subscriptions to make it eaiser for others to subscribe as well.
2280
2281         * Scripts/webkitpy/common/config/watchlist:
2282
2283 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2284
2285         Add myself to the newfangled watchlist plumbing.
2286         https://bugs.webkit.org/show_bug.cgi?id=70338
2287
2288         Reviewed by David Levin.
2289
2290         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
2291
2292 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2293
2294         Fix a unit test in TestFailures.
2295         https://bugs.webkit.org/show_bug.cgi?id=70337
2296
2297         Reviewed by Adam Barth.
2298
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
2300             the value of a method property should always be lowercase.
2301
2302 2011-10-18  Adam Barth  <abarth@webkit.org>
2303
2304         Always enable ENABLE(XPATH)
2305         https://bugs.webkit.org/show_bug.cgi?id=70217
2306
2307         Reviewed by Eric Seidel.
2308
2309         * Scripts/build-webkit:
2310
2311 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2312
2313         garden-o-matic should not report flaking in expected failures as failures.
2314         https://bugs.webkit.org/show_bug.cgi?id=70279
2315
2316         Reviewed by Adam Barth.
2317
2318         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
2319         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
2320         same for garden-o-matic.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
2323             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
2325
2326 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
2327
2328         [Gtk] Support for client-based geolocation
2329         https://bugs.webkit.org/show_bug.cgi?id=64970
2330
2331         Reviewed by Martin Robinson.
2332
2333         Add support for testing client-based geolocation tests in DumpRenderTree.
2334
2335         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2336         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
2337         (createWebView): Create web view after declaring DumpRenderTree mode.
2338         That way a mock client for geolocation is used instead of a GeoClue
2339         client if a web view is created when testing.
2340         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
2341         geolocation layout tests.
2342         (LayoutTestController::setMockGeolocationPosition):
2343         (LayoutTestController::setMockGeolocationError):
2344         (LayoutTestController::setGeolocationPermission):
2345         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2346         * Scripts/build-webkit: Note that the Gtk port is using client-based
2347         geolocation, even though changing this flag has no effect on compilation.
2348
2349 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
2350
2351         [Chromium] suppress console output from DevTools window
2352         https://bugs.webkit.org/show_bug.cgi?id=69632
2353
2354         Reviewed by Pavel Feldman.
2355
2356         * DumpRenderTree/chromium/TestShell.cpp:
2357         (TestShell::showDevTools):
2358         * DumpRenderTree/chromium/WebViewHost.cpp:
2359         (WebViewHost::didAddMessageToConsole):
2360         (WebViewHost::reset):
2361         (WebViewHost::setLogConsoleOutput):
2362         * DumpRenderTree/chromium/WebViewHost.h:
2363
2364 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2365
2366         Unreviewed, rolling out r97735.
2367         http://trac.webkit.org/changeset/97735
2368         https://bugs.webkit.org/show_bug.cgi?id=70317
2369
2370         some people apparently use build-jsc with the qt port without
2371         building webkit first (Requested by torarne on #webkit).
2372
2373         * Scripts/build-webkit:
2374         * Scripts/webkitdirs.pm:
2375         (buildQMakeProject):
2376         (buildQMakeQtProject):
2377
2378 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2379
2380         [Qt] Remove dead code in build-webkit
2381
2382         build-webkit will iterate over a list of subdirectories to build,
2383         but this feature is only used by the Apple ports. For QtWebKit we
2384         always pass an empty directory to buildQMakeProject, which makes
2385         the logic for dealing with sub-projects in buildQMakeProject just
2386         added noise.
2387
2388         If we do want this feature at some point, we should redo it in
2389         the context of the upcoming build system changes for Qt.
2390
2391         Reviewed by Simon Hausmann.
2392
2393         * Scripts/build-webkit:
2394         * Scripts/webkitdirs.pm:
2395         (buildQt):
2396
2397 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2398
2399         Remove traces of Symbian support from the build scripts
2400
2401         Reviewed by Simon Hausmann.
2402
2403         * Scripts/build-webkit:
2404         * Scripts/webkitdirs.pm:
2405         (determineBaseProductDir):
2406         (argumentsForConfiguration):
2407         (usesPerConfigurationBuildDirectory):
2408         (buildQMakeProject):
2409
2410 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2411
2412         Build fix after r97672.
2413
2414         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2415
2416 2011-10-17  Kent Tamura  <tkent@chromium.org>
2417
2418         A follow-up of r97716.
2419         https://bugs.webkit.org/show_bug.cgi?id=68803
2420
2421         * DumpRenderTree/chromium/LayoutTestController.cpp:
2422         (LayoutTestController::reset): Initialize m_dumpCreateView.
2423
2424 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
2425
2426         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
2427         https://bugs.webkit.org/show_bug.cgi?id=68803
2428
2429         Reviewed by Nate Chapin.
2430
2431         * DumpRenderTree/chromium/LayoutTestController.cpp:
2432         (LayoutTestController::LayoutTestController):
2433         (LayoutTestController::dumpCreateView):
2434         * DumpRenderTree/chromium/LayoutTestController.h:
2435         (LayoutTestController::shouldDumpCreateView):
2436         * DumpRenderTree/chromium/WebViewHost.cpp:
2437         (WebViewHost::createView):
2438
2439 2011-10-17  Nate Chapin  <japhet@chromium.org>
2440
2441         Add myself to watchlists, and add a watch
2442         for Source/WebCore/loader/.
2443         https://bugs.webkit.org/show_bug.cgi?id=70263
2444
2445         Reviewed by David Levin.
2446
2447         * Scripts/webkitpy/common/config/watchlist:
2448
2449 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2450
2451         [EFL] DRT: Make non-recognized keys work in events as well.
2452         https://bugs.webkit.org/show_bug.cgi?id=69860
2453
2454         Reviewed by Antonio Gomes.
2455
2456         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
2457         here: it has a select box with a few non-latin options, and one of them
2458         is selected via the keyboard.
2459
2460         In this specific case, we need to make EventHandler::keyEvent send a
2461         keyPressEvent to SelectElement, so that
2462         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
2463         only when PlatformKeyEvent::text() is not empty, which was not the case
2464         so far.
2465
2466         * DumpRenderTree/efl/EventSender.cpp:
2467         (keyDownCallback):
2468
2469 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
2470
2471         Add layout tests for WebPlugin compositor path
2472         https://bugs.webkit.org/show_bug.cgi?id=69027
2473
2474         Reviewed by James Robinson.
2475
2476         * DumpRenderTree/DumpRenderTree.gypi:
2477         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
2478         (premultiplyAlpha):
2479         (TestWebPlugin::TestWebPlugin):
2480         (TestWebPlugin::~TestWebPlugin):
2481         (TestWebPlugin::mimeType):
2482         (TestWebPlugin::initialize):
2483         (TestWebPlugin::destroy):
2484         (TestWebPlugin::updateGeometry):
2485         (TestWebPlugin::parsePrimitive):
2486         (TestWebPlugin::parseColor):
2487         (TestWebPlugin::parseOpacity):
2488         (TestWebPlugin::initScene):
2489         (TestWebPlugin::drawScene):
2490         (TestWebPlugin::destroyScene):
2491         (TestWebPlugin::initProgram):
2492         (TestWebPlugin::initPrimitive):
2493         (TestWebPlugin::drawPrimitive):
2494         (TestWebPlugin::loadShader):
2495         (TestWebPlugin::loadProgram):
2496         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
2497         (TestWebPlugin::scriptableObject):
2498         (TestWebPlugin::paint):
2499         (TestWebPlugin::updateFocus):
2500         (TestWebPlugin::updateVisibility):
2501         (TestWebPlugin::acceptsInputEvents):
2502         (TestWebPlugin::handleInputEvent):
2503         (TestWebPlugin::didReceiveResponse):
2504         (TestWebPlugin::didReceiveData):
2505         (TestWebPlugin::didFinishLoading):
2506         (TestWebPlugin::didFailLoading):
2507         (TestWebPlugin::didFinishLoadingFrameRequest):
2508         (TestWebPlugin::didFailLoadingFrameRequest):
2509         (TestWebPlugin::Scene::Scene):
2510         * DumpRenderTree/chromium/WebViewHost.cpp:
2511         (WebViewHost::createPlugin):
2512
2513 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
2514
2515         [nrwt] Add new category for MISSING
2516         https://bugs.webkit.org/show_bug.cgi?id=69990
2517
2518         Reviewed by Dirk Pranke.
2519
2520         Treat missing results as a new category in summerize_results.
2521
2522         Because Chromium port wants to turn bots red when there are tests with missing results,
2523         extracted the logic to compute the exit code as exit_code_from_summarized_results in
2524         base and chromium ports.
2525
2526         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2527         * Scripts/webkitpy/layout_tests/port/base.py:
2528         * Scripts/webkitpy/layout_tests/port/chromium.py:
2529         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2530
2531 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
2532
2533         garden-o-matic operations fail because of CSP.
2534         https://bugs.webkit.org/show_bug.cgi?id=70249
2535
2536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
2537
2538 2011-10-17  Ada Chan  <adachan@apple.com>
2539
2540         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
2541         https://bugs.webkit.org/show_bug.cgi?id=70168
2542
2543         Reviewed by Alexey Proskuryakov.
2544
2545         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
2546         (TestWebKitAPI::didFinishLoadForFrame):
2547         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
2548
2549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2550         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2551         Add the new file.
2552
2553 2011-10-17  Darin Adler  <darin@apple.com>
2554
2555         Add some more *.pyc ignores in directories with Python scripts.
2556
2557         * QueueStatusServer: Added property svn:ignore.
2558         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
2559         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
2560         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
2561
2562 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
2563
2564         [Qt][WK2][meta] Fix failing API tests
2565         https://bugs.webkit.org/show_bug.cgi?id=70236
2566
2567         Reviewed by Csaba Osztrogonác.
2568
2569         In order to run WebKit2 API tests we need the WebProcess to be in
2570         the path so let's add the bin directory when running the API tests of Qt.
2571
2572         * Scripts/run-qtwebkit-tests:
2573
2574 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2575
2576         [Qt][WK2] Build dependency problems
2577         https://bugs.webkit.org/show_bug.cgi?id=68456
2578
2579         Reviewed by Csaba Osztrogonác.
2580
2581         * Scripts/webkitdirs.pm:
2582         (buildQMakeProject):
2583
2584 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2585
2586         [build] Introduce Qt/SH4 buildbot
2587         https://bugs.webkit.org/show_bug.cgi?id=70227
2588
2589         Reviewed by Adam Roben.
2590
2591         Add buildslave for Linux/Qt/SH4.
2592
2593         * BuildSlaveSupport/build.webkit.org-config/config.json:
2594
2595 2011-10-16  Adam Barth  <abarth@webkit.org>
2596
2597         Always enable ENABLE(DOM_STORAGE)
2598         https://bugs.webkit.org/show_bug.cgi?id=70189
2599
2600         Reviewed by Eric Seidel.
2601
2602         * Scripts/build-webkit:
2603         * waf/build/settings.py:
2604
2605 2011-10-15  Adam Barth  <abarth@webkit.org>
2606
2607         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
2608         https://bugs.webkit.org/show_bug.cgi?id=70194
2609
2610         Reviewed by Daniel Bates.
2611
2612         * Scripts/build-webkit:
2613
2614 2011-10-15  Ojan Vafai  <ojan@chromium.org>
2615
2616         run-webkit-tests should accept --child-processes
2617         https://bugs.webkit.org/show_bug.cgi?id=69713
2618
2619         Reviewed by Adam Barth.
2620
2621         Only set --child-processes=1 if --child-processes it not
2622         passed on the commandline.
2623
2624         * Scripts/run-webkit-tests:
2625
2626 2011-10-15  Daniel Bates  <dbates@webkit.org>
2627
2628         Extract common gdb code into its own function; Remove script gdb-safari
2629         https://bugs.webkit.org/show_bug.cgi?id=68499
2630
2631         Reviewed by David Kilzer.
2632
2633         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
2634         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
2635         We should extract the common parts into a function that can be shared by all callers
2636         so as to remove duplicate code.
2637
2638         As a side effect of removing duplicate code we can remove the script gdb-safari since
2639         its code has been incorporated into webkitdirs::debugSafari() which is called by the
2640         script debug-safari.
2641
2642         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
2643         * Scripts/gdb-safari: Removed.
2644         * Scripts/webkitdirs.pm:
2645         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
2646         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
2647         script gdb-safari to here.
2648         (debugSafari): Added.
2649         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
2650         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
2651         runSafari() always returns 1 on Windows and the script run-safari exits using this
2652         value as its exit status. Hence, the script run-safari always exits with a nonzero
2653         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
2654         exit status of the WebKit launcher application.
2655         (debugMiniBrowser): Modified to call debugMacWebKitApp().
2656         (debugWebKitTestRunner): Ditto.
2657
2658 2011-10-15  Robert Hogan  <robert@webkit.org>
2659
2660         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
2661         https://bugs.webkit.org/show_bug.cgi?id=70056
2662
2663         Reviewed by Adam Barth.
2664
2665         The preferred file-order for patches is LayoutTests at the end and
2666         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
2667         it when creating patches for review and landing.
2668
2669         * Scripts/webkitpy/common/checkout/scm/git.py:
2670         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2671         * Scripts/webkitpy/common/config/orderfile: Added.
2672
2673 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2674
2675         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
2676         https://bugs.webkit.org/show_bug.cgi?id=69920
2677
2678         Reviewed by Kenneth Rohde Christiansen.
2679
2680         * DumpRenderTree/qt/DumpRenderTree.pro:
2681         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2682         (WebCore::DumpRenderTree::open):
2683         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2684         * QtTestBrowser/QtTestBrowser.pro:
2685         * QtTestBrowser/launcherwindow.cpp:
2686         (LauncherWindow::screenshot):
2687         (LauncherWindow::showFPS):
2688         (LauncherWindow::updateFPS):
2689         * QtTestBrowser/launcherwindow.h:
2690         (WindowOptions::WindowOptions):
2691         * QtTestBrowser/mainwindow.cpp:
2692         (MainWindow::buildUI):
2693         * Scripts/webkitpy/style/checker.py: Remove rules for the
2694         WebKit/qt/symbian/platformplugin directory.
2695         * Scripts/webkitpy/style/checker_unittest.py:
2696         * Tools.pro:
2697         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2698         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2699         (WTR::LayoutTestController::platformInitialize):
2700         * WebKitTestRunner/qt/TestControllerQt.cpp:
2701         (WTR::isExistingLibrary):
2702         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2703
2704 2011-10-15  Adam Barth  <abarth@webkit.org>
2705
2706         Fix typo in webkitpy help
2707         https://bugs.webkit.org/show_bug.cgi?id=70169
2708
2709         Reviewed by Eric Seidel.
2710
2711         * Scripts/webkitpy/tool/commands/upload.py:
2712
2713 2011-10-15  Tony Chang  <tony@chromium.org>
2714
2715         fix another typo in treemap.html
2716         https://bugs.webkit.org/show_bug.cgi?id=70149
2717
2718         Reviewed by Ojan Vafai.
2719
2720         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
2721
2722         * TestResultServer/static-dashboards/treemap.html:
2723
2724 2011-10-14  Adam Barth  <abarth@webkit.org>
2725
2726         Hide status bubbles from queues which are very far behind
2727         https://bugs.webkit.org/show_bug.cgi?id=70133
2728
2729         Reviewed by Eric Seidel.
2730
2731         The mac-ews is so far behind that we shouldn't show its status bubble.
2732         The status bubble just makes contributors sad.
2733
2734         * QueueStatusServer/handlers/statusbubble.py:
2735
2736 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
2737
2738         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
2739         https://bugs.webkit.org/show_bug.cgi?id=70143
2740
2741         Reviewed by Adam Barth.
2742
2743         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
2744         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
2745
2746 2011-10-14  David Levin  <levin@chromium.org>
2747
2748         watchlist: Add a validation check for the email names in the list.
2749         https://bugs.webkit.org/show_bug.cgi?id=70154
2750
2751         Reviewed by Adam Barth.
2752
2753         If an email is listed which doesn't have a bugzilla log in, then any emails
2754         added to the bug along with that email will fail to happen, so try to prevent this
2755         from happening by validating that emails added to the watchlist are known to be
2756         contributors.
2757
2758         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
2759         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
2760         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
2761
2762 2011-10-14  David Levin  <levin@chromium.org>
2763
2764         watchlist: If the style check fails, then the watchlist will not be run.
2765         https://bugs.webkit.org/show_bug.cgi?id=69484
2766
2767         Reviewed by Adam Barth.
2768
2769         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
2770         if the style part fails and don't allow watch list failures turn the
2771         bot run red.
2772         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
2773         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
2774
2775 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
2776
2777         Plumb style-checker filter up to command options and make land-cowboy use it.
2778         https://bugs.webkit.org/show_bug.cgi?id=70119
2779
2780         Reviewed by Adam Barth.
2781
2782         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
2783         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
2784         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
2785         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
2786         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2787         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
2788         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
2789
2790 2011-10-14  Sam Weinig  <sam@webkit.org>
2791
2792         Remove the Leopard slaves.
2793
2794         Reviewed by Adam Roben.
2795
2796         * BuildSlaveSupport/build.webkit.org-config/config.json:
2797
2798 2011-10-14  Peter Beverloo  <peter@chromium.org>
2799
2800         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
2801         https://bugs.webkit.org/show_bug.cgi?id=70028
2802
2803         Reviewed by Adam Barth.
2804
2805         * Scripts/update-webkit-chromium:
2806         * Scripts/webkitdirs.pm:
2807         (buildChromiumMakefile):
2808         (buildChromium):
2809
2810 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
2811
2812         Unreviewed; add missing #includes.
2813
2814         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2815         * DumpRenderTree/efl/EventSender.cpp:
2816
2817 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2818
2819         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
2820         https://bugs.webkit.org/show_bug.cgi?id=69770
2821
2822         Reviewed by Antonio Gomes.
2823
2824         We were just appending the given URL to the absolute URI of the main
2825         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
2826         instead of "file:///foo/bar/theother/url.html".
2827
2828         This should make fast/dom/navigation-type-navigate.html behave
2829         better (it still fails, but later).
2830
2831         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2832         (LayoutTestController::queueLoad):
2833
2834 2011-10-13  Arko Saha  <arko@motorola.com>
2835
2836         Microdata: Basic implementation of document.getItems() method.
2837         https://bugs.webkit.org/show_bug.cgi?id=68610
2838
2839         Reviewed by Ryosuke Niwa.
2840
2841         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
2842         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
2843
2844         * Scripts/build-webkit:
2845
2846 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2847
2848         new-run-webkit-tests does not support qt-4.8 results
2849         https://bugs.webkit.org/show_bug.cgi?id=64071
2850
2851         Roll-back second part of r97252. :)
2852
2853         * Scripts/webkitpy/layout_tests/port/qt.py:
2854
2855 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2856
2857         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
2858         https://bugs.webkit.org/show_bug.cgi?id=70106
2859
2860         Reviewed by Antonio Gomes.
2861
2862         OwnFastMallocPtr was being used as a smart pointer that automatically called
2863         free() on the strings returned by the EFL or by ewk.
2864
2865         However, when WTF is built in release mode, it uses its own memory management
2866         code instead of using the system malloc(), free() and friends. This means bad
2867         things will happen when one uses WTF's free() on memory allocated with system
2868         malloc() by the EFL or ewk.
2869
2870         The easiest way to solve this is to call free() ourselves.
2871
2872         * DumpRenderTree/efl/DumpRenderTree.cpp:
2873         (dumpFramesAsText):
2874         (getFinalTestURL):
2875
2876 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2877
2878         [EFL] Add DumpRenderTreeSupportEfl
2879         https://bugs.webkit.org/show_bug.cgi?id=68458
2880
2881         Reviewed by Kenneth Rohde Christiansen.
2882
2883         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
2884
2885         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2886         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
2887         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2888         (DumpRenderTreeChrome::onWindowObjectCleared):
2889         (DumpRenderTreeChrome::onDocumentLoadFinished):
2890         * DumpRenderTree/efl/GCControllerEfl.cpp:
2891         (GCController::collect):
2892         (GCController::collectOnAlternateThread):
2893         (GCController::getJSObjectCount):
2894         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2895         (LayoutTestController::counterValueForElementById):
2896         (LayoutTestController::pageNumberForElementById):
2897         (LayoutTestController::numberOfPages):
2898         (LayoutTestController::workerThreadCount):
2899         (LayoutTestController::findString):
2900         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2901         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2902         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2903         (LayoutTestController::numberOfActiveAnimations):
2904         (LayoutTestController::suspendAnimations):
2905         (LayoutTestController::resumeAnimations):
2906         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2907         (createBitmapContextFromWebView):
2908
2909 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2910
2911         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
2912
2913         Unreviewed.
2914
2915         * Scripts/run-webkit-tests:
2916         (useNewRunWebKitTests):
2917
2918 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2919
2920         new-run-webkit-tests does not support qt-4.8 results
2921         https://bugs.webkit.org/show_bug.cgi?id=64071
2922
2923         Roll-back r97252 with unit test fix.
2924
2925         Reviewed by Csaba Osztrogonác.
2926
2927         * Scripts/webkitpy/layout_tests/port/qt.py:
2928         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2929
2930 2011-10-13  Ojan Vafai  <ojan@chromium.org>
2931
2932         Make filter-build-webkit exit 1 if the build fails.
2933         https://bugs.webkit.org/show_bug.cgi?id=70080
2934
2935         Reviewed by Eric Seidel.
2936
2937         This only works if you redirect stderr to stdout, but it at least makes it possible.
2938         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
2939         only if the build succeeds.
2940
2941         * Scripts/filter-build-webkit:
2942
2943 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
2944
2945         land-cowboy should at least check style.
2946         https://bugs.webkit.org/show_bug.cgi?id=70073
2947
2948         Reviewed by Adam Barth.
2949
2950         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
2951
2952 2011-10-13  Tony Chang  <tony@chromium.org>
2953
2954         fix regex in layout test times dashboard
2955         https://bugs.webkit.org/show_bug.cgi?id=70059
2956
2957         This fixes the treemapfocus query param.
2958
2959         Reviewed by Ojan Vafai.
2960
2961         * TestResultServer/static-dashboards/treemap.html:
2962
2963 2011-10-13  Beth Dakin  <bdakin@apple.com>
2964
2965         https://bugs.webkit.org/show_bug.cgi?id=70050
2966         DRT and WRT should have HiDPI testing capabilities
2967
2968         Reviewed by Darin Adler.
2969
2970         New layoutTestController function setBackingScaleFactor takes a double for a scale 
2971         factor and a callback function to call once the backing scale factor has 
2972         successfully been set for the view.
2973         * DumpRenderTree/LayoutTestController.cpp:
2974         (setBackingScaleFactorCallback):
2975         (LayoutTestController::staticFunctions):
2976
2977         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
2978         platforms do nothing.
2979         * DumpRenderTree/LayoutTestController.h:
2980         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2981         (LayoutTestController::setBackingScaleFactor):
2982         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2983         (LayoutTestController::setBackingScaleFactor):
2984         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2985         (LayoutTestController::setBackingScaleFactor):
2986
2987         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
2988         value of 0, which resets to the system default.
2989         * DumpRenderTree/mac/DumpRenderTree.mm:
2990         (resetWebViewToConsistentStateBeforeTesting):
2991
2992         When generating the pixel dump, create a Bitmap of the appropriate size based on 
2993         the backing scale factor. If it is a HiDPI view, paint into the context using 
2994         displayRectIgnoringOpacity.
2995         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2996         (createBitmapContextFromWebView):
2997
2998         And now the same stuff for WK2. Again, new layoutTestController function 
2999         setBackingScaleFactor takes a double for a scale factor and a callback function. 
3000         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3001         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3002         (WTR::LayoutTestController::setBackingScaleFactor):
3003         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
3004         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3005
3006         The InjectedBundle sends a message to the UI process to set the backing scale 
3007         factor. It also processes a message the UI process will send back once it 
3008         completes this task, and at that time, the InjectedBundle calls the callback.
3009         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3010         (WTR::InjectedBundle::didReceiveMessage):
3011         (WTR::InjectedBundle::postSetBackingScaleFactor):
3012         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3013
3014         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
3015         with a value of 0, which resets to the system default.
3016         * WebKitTestRunner/TestController.cpp:
3017         (WTR::TestController::resetStateToConsistentValues):
3018
3019         Upon receiving the SetBackingScaleFactor message, call 
3020         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
3021         back to InjectedBundle to say it has been done.
3022         * WebKitTestRunner/TestInvocation.cpp:
3023         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3024         
3025         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
3026         window's scale factor so we have to avoid that.
3027         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3028         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3029
3030 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
3031
3032         [Chromium] Allow building without speech input enabled.
3033         https://bugs.webkit.org/show_bug.cgi?id=69867
3034
3035         Reviewed by Darin Fisher.
3036
3037         * DumpRenderTree/chromium/LayoutTestController.cpp:
3038         (LayoutTestController::addMockSpeechInputResult):
3039
3040 2011-10-13  Kent Tamura  <tkent@chromium.org>
3041
3042         [Chromium] A DRT fix for r97348.
3043
3044         * DumpRenderTree/chromium/LayoutTestController.cpp:
3045         (LayoutTestController::overridePreference):
3046         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
3047         print an error message.
3048
3049 2011-10-12  Lucas Forschler  <lforschler@apple.com>
3050
3051         Update kill-old-processes logic.
3052         https://bugs.webkit.org/show_bug.cgi?id=63651
3053
3054         Reviewed by Ryosuke Niwa.
3055
3056         Remove unused mac platform specific folder.
3057         Update master.config to use new kill-old-processes.
3058
3059         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3060         * BuildSlaveSupport/kill-old-processes:
3061         * BuildSlaveSupport/mac: Removed.
3062
3063 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         [NRWT] New tests without expected files are reported as flakey tests
3066         https://bugs.webkit.org/show_bug.cgi?id=67268
3067
3068         Reviewed by Dirk Pranke.
3069
3070         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
3071         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
3072         for missing results in retry_summary.
3073
3074         Fixed the bug by treating missing results separately.
3075
3076         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3077         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3078
3079 2011-10-12  Adam Barth  <abarth@webkit.org>
3080
3081         Remove ENABLE(XHTMLMP) and associated code
3082         https://bugs.webkit.org/show_bug.cgi?id=69729
3083
3084         Reviewed by David Levin.
3085
3086         * Scripts/build-webkit:
3087         * Scripts/old-run-webkit-tests:
3088         * Scripts/webkitperl/features.pm:
3089         * Scripts/webkitpy/layout_tests/port/webkit.py:
3090         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3091
3092 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3093
3094         Kill old run-webkit-tests processes in kill-process on Mac
3095         https://bugs.webkit.org/show_bug.cgi?id=69976
3096
3097         Reviewed by Dirk Pranke.
3098
3099         Add a system call to remove all python processes running run-webkit-tests.
3100
3101         * BuildSlaveSupport/kill-old-processes:
3102         * BuildSlaveSupport/mac: Removed.
3103
3104 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3105
3106         Many WK2 snapshots are blank
3107         https://bugs.webkit.org/show_bug.cgi?id=69953
3108
3109         Reviewed by Beth Dakin.
3110         
3111         Two fixes:
3112         1. negating a size_t in CGContextTranslateCTM() fails, because
3113         size_t is unsigned. Fix by casing to CGFloat before negation.
3114         
3115         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
3116         Autodisplay is necessary to kick off Core Animation rendering.
3117
3118         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3119         (WTR::createCGContextFromImage):
3120         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3121         (WTR::PlatformWebView::PlatformWebView):
3122
3123 2011-10-12  Adam Barth  <abarth@webkit.org>
3124
3125         commit-queue doesn't have a friendly error message when the reviewer line is messed up
3126         https://bugs.webkit.org/show_bug.cgi?id=69979
3127
3128         Reviewed by Eric Seidel.
3129
3130         Rather than combining the ChangeLog validation with a more complicated
3131         command, this patch has the commit-queue run it as a separate command,
3132         which will give us more control over the error message.
3133
3134         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3135         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3136         * Scripts/webkitpy/tool/commands/download.py:
3137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3138         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3139         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3140
3141 2011-10-12  Eric Seidel  <eric@webkit.org>
3142
3143         Layout tests asserting in LayoutTestController::pathToLocalResource()
3144         https://bugs.webkit.org/show_bug.cgi?id=69898
3145
3146         Reviewed by Simon Fraser.
3147
3148         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
3149
3150         * Scripts/old-run-webkit-tests:
3151         (openDumpTool):
3152
3153 2011-10-12  Adam Barth  <abarth@webkit.org>
3154
3155         The commit-queue doesn't tell me which tests my patch broke
3156         https://bugs.webkit.org/show_bug.cgi?id=69975
3157
3158         Reviewed by Eric Seidel.
3159
3160         We now print the list of newly failing tests, like we do for the EWS.
3161
3162         * Scripts/webkitpy/tool/commands/queues.py:
3163         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3164
3165 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
3166
3167         Added myself as a committer.
3168
3169         * Scripts/webkitpy/common/config/committers.py:
3170
3171 2011-10-12  Adam Barth  <abarth@webkit.org>
3172
3173         _run_tests is a confusing variable name in webkitpy
3174         https://bugs.webkit.org/show_bug.cgi?id=69971
3175
3176         Reviewed by Eric Seidel.
3177
3178         Eric and I thought this was a function.
3179
3180         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3181
3182 2011-10-12  Tony Chang  <tony@chromium.org>
3183
3184         Fix test-webkitpy after r97307 and r97293.
3185
3186         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
3187           is None during tests so add back the check.
3188         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
3189           output directory is now build/Debug.
3190
3191 2011-10-12  Tony Chang  <tony@chromium.org>
3192
3193         [chromium] remove old build dirs on chromium-win
3194         https://bugs.webkit.org/show_bug.cgi?id=69961
3195
3196         Reviewed by Adam Barth.
3197
3198         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
3199           always in build and never in chrome or webkit.
3200
3201 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3202
3203         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
3204         https://bugs.webkit.org/show_bug.cgi?id=69954
3205
3206         Also renamed the action and associated event name to address an FIXME.
3207
3208         Reviewed by Adam Barth.
3209
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
3213
3214 2011-10-12  Tony Chang  <tony@chromium.org>
3215
3216         stop spamming 'stopping test driver timed out, killing it' when running rwt
3217         https://bugs.webkit.org/show_bug.cgi?id=69938
3218
3219         Reviewed by Adam Barth.
3220
3221         In http://trac.webkit.org/changeset/95875 , we made the timeout for
3222         stopping the driver based on time_out_ms, but we based it on the wrong
3223         default times.
3224
3225         * Scripts/webkitpy/layout_tests/port/chromium.py:
3226
3227 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3228
3229         3D transforms are flattened in WebKit2 snapshots
3230         https://bugs.webkit.org/show_bug.cgi?id=68276
3231
3232         Reviewed by Adam Roben.
3233         
3234         Fix WKImage leak noticed by Adam.
3235
3236         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3237         (WTR::PlatformWebView::windowSnapshotImage):
3238
3239 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3240
3241         garden-o-matic should color-code test failure types.
3242         https://bugs.webkit.org/show_bug.cgi?id=69945
3243
3244         Reviewed by Adam Barth.
3245
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
3247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
3250
3251 2011-10-12  Adam Barth  <abarth@webkit.org>
3252
3253         webkitpy tests are failing on Mac bots
3254         https://bugs.webkit.org/show_bug.cgi?id=69929
3255
3256         Reviewed by Simon Fraser.
3257
3258         Admit that Lion exists.
3259
3260         * Scripts/webkitpy/layout_tests/port/chromium.py:
3261         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3262
3263 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3264
3265         Improve output of run-api-tests to make time-outs more obvious
3266         https://bugs.webkit.org/show_bug.cgi?id=69788
3267
3268         Reviewed by Adam Roben.
3269         
3270         List the tests that failed and timed out at the bottom of the output,
3271         if run with --verbose.
3272
3273         * Scripts/run-api-tests:
3274         (runAllTests):
3275         (runTest):
3276
3277 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3278
3279         Unreviewed, rolling out r97252.
3280         http://trac.webkit.org/changeset/97252
3281         https://bugs.webkit.org/show_bug.cgi?id=69944
3282
3283         Broke test-webkpy (Requested by abarth on #webkit).
3284
3285         * Scripts/webkitpy/layout_tests/port/qt.py:
3286         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3287
3288 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3289
3290         new-run-webkit-tests does not support qt-4.8 results
3291         https://bugs.webkit.org/show_bug.cgi?id=64071
3292
3293         Reviewed by Csaba Osztrogonác.
3294
3295         * Scripts/webkitpy/layout_tests/port/qt.py:
3296         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3297
3298 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
3299
3300         [GTK] [WebKit2] Make adding another unit test easier
3301         https://bugs.webkit.org/show_bug.cgi?id=69409
3302
3303         Reviewed by Gustavo Noronha Silva.
3304
3305         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
3306         new WebKit2 tests.
3307
3308 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
3309
3310         [WebSocket] update pywebsocket to 0.6b6.
3311         https://bugs.webkit.org/show_bug.cgi?id=69824
3312
3313         Reviewed by Kent Tamura.
3314
3315         WebKit supports WebSocket with version 8 based protocol for now.
3316         We should update its protocol to version 13 based one like hybi-17.
3317         pywebsocket 0.6b6 supports both of version 8 and 13.
3318
3319         * Scripts/webkitpy/thirdparty/__init__.py:
3320
3321 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
3322
3323         WebKitTestRunner needs to link with WebKit for NSURL category methods
3324         https://bugs.webkit.org/show_bug.cgi?id=69892
3325
3326         Reviewed by Sam Weinig.
3327         
3328         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
3329         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
3330         WebKit.framework to fix this.
3331
3332         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3333
3334 2011-10-11  Adam Barth  <abarth@webkit.org>
3335
3336         sheriffbot takes too long to acknowledge rollout commands
3337         https://bugs.webkit.org/show_bug.cgi?id=69871
3338
3339         Reviewed by Eric Seidel.
3340
3341         We used to update the working copy before acknowledging the command
3342         because we wanted to ping all the relevant IRC nicks.  That's caused a
3343         bunch of frustration because folks don't know whether the bot has heard
3344         their commands.
3345
3346         This patch makes the bot reply immediately before updating the working
3347         copy.  All the relevenat folks are still pinged when the bot finishes
3348         preparing the rollout.
3349
3350         * Scripts/webkitpy/tool/bot/irc_command.py:
3351         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3352
3353 2011-10-11  Adam Barth  <abarth@webkit.org>
3354
3355         test-webkitpy fails on Lion
3356         https://bugs.webkit.org/show_bug.cgi?id=69873
3357
3358         Reviewed by Eric Seidel.
3359
3360         This patch fixes one of the two failures.  I'll need to track down the
3361         other failure another time.
3362
3363         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3364
3365 2011-10-11  Adam Barth  <abarth@webkit.org>
3366
3367         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
3368         https://bugs.webkit.org/show_bug.cgi?id=65230
3369
3370         Reviewed by Dimitri Glazkov.
3371
3372         This patch causes us to treat crashed or hung run-webkit-tests runs
3373         similarly to how we treat compile failures.  In some sense, they're
3374         similar because they prevent us from getting test coverage.
3375
3376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3378
3379 2011-10-11  Adam Barth  <abarth@webkit.org>
3380
3381         Failing builder display in garden-o-matic should have the same visual style as the failure grid
3382         https://bugs.webkit.org/show_bug.cgi?id=69876
3383
3384         Reviewed by Dimitri Glazkov.
3385
3386         This patch generalizes the view we use for failing builders in the
3387         FailureGrid so that we can use it for the list of builders that aren't
3388         compiling.
3389
3390         One downside of this patch is that it makes it harder to tell when
3391         debug builders are failing (as opposed to release builders) because
3392         that information isn't presented in this view.  A future patch will
3393         improve this aspect.
3394
3395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3401
3402 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
3403
3404         Some API tests are timing out in Release
3405         https://bugs.webkit.org/show_bug.cgi?id=69787
3406
3407         Reviewed by Mark Rowe.
3408         
3409         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
3410         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
3411
3412         * TestWebKitAPI/Configurations/Base.xcconfig:
3413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3414         * TestWebKitAPI/config.h:
3415
3416 2011-10-11  Adam Barth  <abarth@webkit.org>
3417
3418         garden-o-matic links to flakiness dashboard should open in a new tab
3419         https://bugs.webkit.org/show_bug.cgi?id=69864
3420
3421         Reviewed by Dimitri Glazkov.
3422
3423         This bug was obvious in the first five minutes of using this new
3424         feature.  :)
3425
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3428
3429 2011-10-11  Adam Barth  <abarth@webkit.org>
3430
3431         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
3432         that * doesn't really mean "all".  I've emailed the W3C working group
3433         about changing the spec.
3434
3435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3436
3437 2011-10-11  Adam Barth  <abarth@webkit.org>
3438
3439         garden-o-matic should link to the flakiness dashboard
3440         https://bugs.webkit.org/show_bug.cgi?id=69862
3441
3442         Reviewed by Dimitri Glazkov.
3443
3444         The flakiness dashboard has lots of great information about the failure
3445         history of each test.  This patch adds a link from garden-o-matic to
3446         the flakiness dashboard so the gardener can look at this information.
3447
3448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3451
3452 2011-10-11  David Levin  <levin@chromium.org>
3453
3454         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
3455         https://bugs.webkit.org/show_bug.cgi?id=69789
3456
3457         Reviewed by Eric Seidel.
3458
3459         Made the signature of _assertRaisesRegexp match that of Python 2.7.
3460
3461         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
3462         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
3463         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
3464         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
3465
3466 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3467
3468         [EFL] DRT: Do not abort() when an unknown key is pressed.
3469         https://bugs.webkit.org/show_bug.cgi?id=69856
3470
3471         Reviewed by Antonio Gomes.
3472
3473         A lot of tests crash due to the previous behaviour. Just using the
3474         received name of the pressed key works most of the time, and when it
3475         does not the failing tests should tell us.
3476
3477         * DumpRenderTree/efl/EventSender.cpp:
3478         (keyPadNameFromJSValue):
3479         (keyNameFromJSValue):
3480         (keyDownCallback):
3481
3482 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3483
3484         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
3485         https://bugs.webkit.org/show_bug.cgi?id=68016
3486
3487         Reviewed by Chang Shu.
3488
3489         * Scripts/webkitpy/layout_tests/port/qt.py:
3490
3491 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3492
3493         [EFL] DRT: Return the right window count in LayoutTestController.
3494         https://bugs.webkit.org/show_bug.cgi?id=69764
3495
3496         Reviewed by Antonio Gomes.
3497
3498         Follow-up to r96943: now that we have DumpRenderTreeChrome and
3499         DumpRenderTreeView in the tree, we can correctly count the number of
3500         open windows in DRT.
3501
3502         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3503         (LayoutTestController::windowCount):
3504
3505 2011-10-11  Jer Noble  <jer.noble@apple.com>
3506
3507         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
3508         https://bugs.webkit.org/show_bug.cgi?id=69800
3509
3510         Reviewed by Csaba Osztrogonác.
3511
3512         Enable WEB_AUDIO at runtime.
3513
3514         * DumpRenderTree/mac/DumpRenderTree.mm:
3515         (resetDefaultsToConsistentValues):
3516
3517 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3518
3519         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
3520         https://bugs.webkit.org/show_bug.cgi?id=69769
3521
3522         Reviewed by Antonio Gomes.
3523
3524         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3525         (LayoutTestController::setIconDatabaseEnabled):
3526
3527 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3528
3529         [Qt] Remove all references to QTDIR_build and standalone_package
3530
3531         Qt is now modularized, which means we no longer import WebKit into
3532         the Qt source tree. Instead we use git submodules, and building
3533         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
3534
3535         To decrease the number of buildsystem configurations we also remove
3536         the standalone_package code-path used when we were providing tarballs
3537         with the derived sources pre-generated.
3538
3539         Reviewed by Simon Hausmann.
3540
3541         * MiniBrowser/qt/MiniBrowser.pro:
3542         * QtTestBrowser/QtTestBrowser.pro:
3543         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3544
3545 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
3546
3547         Update Chromium accessibility support in DRT.
3548         https://bugs.webkit.org/show_bug.cgi?id=69676
3549
3550         Reviewed by Chris Fleizach.
3551
3552         Adds several missing properties and methods to enable more
3553         tests to pass, and in particular adds support for notification
3554         callbacks.
3555
3556         * DumpRenderTree/chromium/AccessibilityController.cpp:
3557         (AccessibilityController::AccessibilityController):
3558         (AccessibilityController::reset):
3559         (AccessibilityController::getFocusedElement):
3560         (AccessibilityController::shouldLogAccessibilityEvents):
3561         (AccessibilityController::notificationReceived):
3562         (AccessibilityController::logAccessibilityEventsCallback):
3563         * DumpRenderTree/chromium/AccessibilityController.h:
3564         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3565         (getHelpText):
3566         (getStringValue):
3567         (getOrientation):
3568         (AccessibilityUIElement::AccessibilityUIElement):
3569         (AccessibilityUIElement::getChildAtIndex):
3570         (AccessibilityUIElement::isEqual):
3571         (AccessibilityUIElement::notificationReceived):
3572         (AccessibilityUIElement::roleGetterCallback):
3573         (AccessibilityUIElement::titleGetterCallback):
3574         (AccessibilityUIElement::descriptionGetterCallback):
3575         (AccessibilityUIElement::helpTextGetterCallback):
3576         (AccessibilityUIElement::stringValueGetterCallback):
3577         (AccessibilityUIElement::xGetterCallback):
3578         (AccessibilityUIElement::yGetterCallback):
3579         (AccessibilityUIElement::widthGetterCallback):
3580         (AccessibilityUIElement::heightGetterCallback):
3581         (AccessibilityUIElement::intValueGetterCallback):
3582         (AccessibilityUIElement::minValueGetterCallback):
3583         (AccessibilityUIElement::maxValueGetterCallback):
3584         (AccessibilityUIElement::childrenCountGetterCallback):
3585         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3586         (AccessibilityUIElement::selectedTextRangeGetterCallback):
3587         (AccessibilityUIElement::isEnabledGetterCallback):
3588         (AccessibilityUIElement::isRequiredGetterCallback):
3589         (AccessibilityUIElement::isFocusedGetterCallback):
3590         (AccessibilityUIElement::isFocusableGetterCallback):
3591         (AccessibilityUIElement::isSelectedGetterCallback):
3592         (AccessibilityUIElement::isSelectableGetterCallback):
3593         (AccessibilityUIElement::isMultiSelectableGetterCallback):
3594         (AccessibilityUIElement::isExpandedGetterCallback):
3595         (AccessibilityUIElement::isCheckedGetterCallback):
3596         (AccessibilityUIElement::isVisibleGetterCallback):
3597         (AccessibilityUIElement::isOffScreenGetterCallback):
3598         (AccessibilityUIElement::isCollapsedGetterCallback):
3599         (AccessibilityUIElement::hasPopupGetterCallback):
3600         (AccessibilityUIElement::isValidGetterCallback):
3601         (AccessibilityUIElement::orientationGetterCallback):
3602         (AccessibilityUIElement::showMenuCallback):
3603         (AccessibilityUIElement::pressCallback):
3604         (AccessibilityUIElement::isEqualCallback):
3605         (AccessibilityUIElement::addNotificationListenerCallback):
3606         (AccessibilityUIElement::removeNotificationListenerCallback):
3607         (AccessibilityUIElement::takeFocusCallback):
3608         (AccessibilityUIElement::fallbackCallback):
3609         (RootAccessibilityUIElement::getChildAtIndex):
3610         (AccessibilityUIElementList::getOrCreate):
3611         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3612         * DumpRenderTree/chromium/CppVariant.cpp:
3613         (CppVariant::invokeDefault):
3614         * DumpRenderTree/chromium/CppVariant.h:
3615         * DumpRenderTree/chromium/LayoutTestController.cpp:
3616         (LayoutTestController::LayoutTestController):
3617         (LayoutTestController::reset):
3618         * DumpRenderTree/chromium/LayoutTestController.h:
3619         * DumpRenderTree/chromium/WebViewHost.cpp:
3620         (WebViewHost::postAccessibilityNotification):
3621
3622 2011-10-10  Adam Klein  <adamk@chromium.org>
3623
3624         Support Distributed-CompileC as an action name in filter-build-webkit
3625         https://bugs.webkit.org/show_bug.cgi?id=69783
3626
3627         Reviewed by Ojan Vafai.
3628
3629         * Scripts/filter-build-webkit:
3630
3631 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3632
3633         3D transforms are flattened in WebKit2 snapshots
3634         https://bugs.webkit.org/show_bug.cgi?id=68276
3635
3636         Reviewed by Anders Carlsson.
3637         
3638         Use a snapshot of the window, rather than an image from the web process
3639         for pixel testing in WebKitTestRunner. This correctly captures compositing
3640         layers, so works for 3D transform tests.
3641
3642         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
3643         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3644         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
3645         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
3646         use that instead of the image we get from the web process.
3647         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3648         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
3649         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3650         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3651         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3652         (WTR::PlatformWebView::windowSnapshotImage): Ditto.