a8c2c1add8bb4b686c6c1df2d5d4acc84ee606b9
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Refactor port code for devices
4         https://bugs.webkit.org/show_bug.cgi?id=191568
5         <rdar://problem/46005821>
6
7         Reviewed by Alex Christensen.
8
9         watchOS and iOS device ports share many characteristics in testing, mostly due
10         to the fact that both are devices.
11
12         * Scripts/webkitpy/port/device_port.py: Added.
13         (DevicePort): Add base class that all simulated/physical device ports share.
14         (DevicePort.__init__):
15         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
16         (DevicePort._generate_all_test_configurations): Ditto.
17         (DevicePort.child_processes): Ditto.
18         (DevicePort.driver_name): Ditto.
19         (DevicePort.target_host): Generalize worker access to attached devices and
20         simulated devices based on the device manager.
21         (DevicePort.devices): Return a list of all devices associated with this port.
22         (DevicePort._create_devices):
23         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
24         (DevicePort._install): Moved from iOS port.
25         (DevicePort.setup_test_run): Ditto.
26         (DevicePort.clean_up_test_run): Ditto.
27         (DevicePort.did_spawn_worker): Ditto.
28         (DevicePort.setup_environ_for_server): Ditto.
29         * Scripts/webkitpy/port/ios.py:
30         (IOSPort):
31         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
32         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
33         (IOSPort.driver_name): Ditto.
34         (IOSPort._generate_all_test_configurations): Ditto.
35         (IOSPort.child_processes): Ditto.
36         (IOSPort._testing_device): Ditto.
37         (IOSPort.target_host): Ditto.
38         (IOSPort._create_devices): Ditto.
39         (IOSPort.setup_test_run): Ditto.
40         (IOSPort.clean_up_test_run): Ditto.
41         (IOSPort.did_spawn_worker): Ditto.
42         * Scripts/webkitpy/port/ios_device.py:
43         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
44         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
45         (IOSDevicePort._get_crash_log): Ditto.
46         (IOSDevicePort.ios_version): Ditto.
47         (IOSDevicePort._create_devices): Ditto.
48         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
49         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
50         * Scripts/webkitpy/port/ios_device_unittest.py:
51         (IOSDeviceTest.test_get_crash_log):
52         * Scripts/webkitpy/port/ios_simulator.py:
53         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
54         (IOSSimulatorPort._create_devices): Clean up logging statement.
55         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
56         across all devices.
57         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
58         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
59         * Scripts/webkitpy/port/ios_simulator_unittest.py:
60         (IOSSimulatorTest.test_32bit):
61         (IOSSimulatorTest.test_64bit):
62
63 2018-11-14  Chris Dumez  <cdumez@apple.com>
64
65         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
66         https://bugs.webkit.org/show_bug.cgi?id=191624
67
68         Reviewed by Alex Christensen.
69
70         Add API test coverage.
71
72         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
73         (runWKHTTPCookieStoreWithoutProcessPool):
74         (TEST):
75
76 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
77
78         [WebAuthN] Support CTAP HID authenticators on macOS
79         https://bugs.webkit.org/show_bug.cgi?id=188623
80         <rdar://problem/43353777>
81
82         Reviewed by Brent Fulgham and Chris Dumez.
83
84         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
85         to hid devices.
86
87         * MiniBrowser/MiniBrowser.entitlements:
88         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
89         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
90
91 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
92
93         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
94         https://bugs.webkit.org/show_bug.cgi?id=191616
95
96         Reviewed by Chris Dumez.
97
98         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
99         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
100         resulting in the use-after-free.
101
102         Made the tests more robust by clearing geolocation provider before exiting each test
103         since we can't really prevent WKView from entering an autorelease pool.
104
105         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
106         instead of simply the end of the navigation so that the test would continue to work
107         even if a web content process was created for the second web view (lowAccuracyWebView)
108
109         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
110         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
111         (TestWebKitAPI::clearGeolocationProvider): Added.
112         (TestWebKitAPI::runJavaScriptAlert): Added.
113         (TestWebKitAPI::didFinishNavigation): Deleted.
114         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
115
116 2018-11-13  Chris Dumez  <cdumez@apple.com>
117
118         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
119         https://bugs.webkit.org/show_bug.cgi?id=191618
120
121         Reviewed by Ryosuke Niwa.
122
123         Update API test to explicitly disable automatic process prewarning since it is testing
124         manual prewarming.
125
126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
127         (TEST):
128
129 2018-11-13  Chris Dumez  <cdumez@apple.com>
130
131         Several Service Worker API tests are failing when enabling PSON
132         https://bugs.webkit.org/show_bug.cgi?id=191619
133
134         Reviewed by Youenn Fablet.
135
136         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
137         not impacted by process prewarming.
138
139         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
140
141 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
142
143         [iOS] Do not show selection UI for editable elements with opacity near zero
144         https://bugs.webkit.org/show_bug.cgi?id=191442
145         <rdar://problem/45958625>
146
147         Reviewed by Simon Fraser.
148
149         Add a couple of new testing helpers to UIScriptController.
150
151         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
152         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
153         (WTR::UIScriptController::textSelectionRangeRects const):
154         (WTR::UIScriptController::selectionCaretViewRect const):
155         (WTR::UIScriptController::selectionRangeViewRects const):
156         * TestRunnerShared/UIScriptContext/UIScriptController.h:
157         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
158         (WTR::UIScriptController::textSelectionRangeRects const):
159
160         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
161         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
162         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
163         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
164         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
165
166         Also, drive-by fix a leaked `NSMutableArray`.
167
168         (WTR::UIScriptController::selectionStartGrabberViewRect const):
169         (WTR::UIScriptController::selectionEndGrabberViewRect const):
170         (WTR::UIScriptController::selectionCaretViewRect const):
171         (WTR::UIScriptController::selectionRangeViewRects const):
172
173         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
174         rects are also clamped to WKContentView bounds.
175
176 2018-11-13  Daniel Bates  <dabates@apple.com>
177
178         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
179         https://bugs.webkit.org/show_bug.cgi?id=173341
180         <rdar://problem/32752890>
181
182         Reviewed by Simon Fraser.
183
184         There is little value to making a distinction between forward declarations
185         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
186         the contents of these two headers can conflict with each other following
187         r218275 as DumpRenderTree includes both headers. Instead we should remove
188         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
189
190         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
191         * DumpRenderTree/mac/DumpRenderTree.mm:
192         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
193         * WebKitTestRunner/Configurations/Base.xcconfig:
194         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
195         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
196         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
197         * WebKitTestRunner/ios/HIDEventGenerator.h:
198         * WebKitTestRunner/ios/HIDEventGenerator.mm:
199         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
200         * WebKitTestRunner/ios/TestControllerIOS.mm:
201         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
202         * WebKitTestRunner/ios/mainIOS.mm:
203
204 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
205
206         Remove WebKitTestRunnerLib's build warnings.
207         https://bugs.webkit.org/show_bug.cgi?id=191580
208
209         Reviewed by Fujii Hironori.
210
211         Include cmakeconfig.h in precompiled header.
212
213         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
214
215 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
216
217         Implement Cache API support for WPE/GTK
218         https://bugs.webkit.org/show_bug.cgi?id=178316
219
220         Reviewed by Michael Catanzaro.
221
222         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
223         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
224
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::generatePageConfiguration):
227         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
228         (WTR::initializeWebViewConfiguration):
229
230 2018-11-12  Christopher Reid  <chris.reid@sony.com>
231
232         [Curl] Reject entire cookie if the domain fails a tailmatch.
233         https://bugs.webkit.org/show_bug.cgi?id=191406
234
235         Reviewed by Youenn Fablet.
236
237         Added unittests for Curl cookie implementation.
238
239         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
240         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
241
242 2018-11-12  Alex Christensen  <achristensen@webkit.org>
243
244         [iOS] Implement safe browsing in WebKit
245         https://bugs.webkit.org/show_bug.cgi?id=191441
246
247         Reviewed by Tim Horton.
248
249         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
250         (checkTitleAndClick):
251         (TEST):
252
253 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
254
255         [Curl] Add API Test for Curl cookie backend.
256         https://bugs.webkit.org/show_bug.cgi?id=191493
257
258         Reviewed by Youenn Fablet.
259
260         Add unit test to TestWebCore.
261
262         * TestWebKitAPI/PlatformWin.cmake:
263         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
264
265 2018-11-12  Tim Horton  <timothy_horton@apple.com>
266
267         Make it possible to edit images inline
268         https://bugs.webkit.org/show_bug.cgi?id=191352
269         <rdar://problem/30107985>
270
271         Reviewed by Dean Jackson.
272
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::updateTestOptionsFromTestHeader):
275         * WebKitTestRunner/TestOptions.h:
276         (WTR::TestOptions::hasSameInitializationOptions const):
277         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
278         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
279         (WTR::TestController::platformCreateWebView):
280         Add a test option to enable editable images.
281
282         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
283         (WTR::UIScriptController::drawSquareInEditableImage):
284         (WTR::UIScriptController::numberOfStrokesInEditableImage):
285         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
286         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
287         (WTR::UIScriptController::drawSquareInEditableImage):
288         (WTR::UIScriptController::numberOfStrokesInEditableImage):
289         * TestRunnerShared/UIScriptContext/UIScriptController.h:
290         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
291         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
292         (WTR::findEditableImageCanvas):
293         (WTR::UIScriptController::drawSquareInEditableImage):
294         (WTR::UIScriptController::numberOfStrokesInEditableImage):
295         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
296         and also to retrieve the number of strokes currently on the PKCanvasView.
297         Currently this just takes the first canvas; we might need to make it
298         take an identifier or something in the future if we need tests with multiple
299         canvases. The indirect testing mechanism is required because PKCanvasView
300         can currently not actually paint its strokes in the Simulator.
301
302 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
303
304         [MediaStream] Screen capture should be an experimental feature on OSX only
305         https://bugs.webkit.org/show_bug.cgi?id=191552
306
307         Unreviewed test gardening.
308
309         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
310
311 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
312
313         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
314         https://bugs.webkit.org/show_bug.cgi?id=189230
315         <rdar://problem/44050379>
316
317         Reviewed by Joseph Pecoraro.
318
319         Runs all png images through zopflipng. This results in a smaller file
320         size and takes care of this issue as a byproduct.
321
322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
372
373 2018-11-12  Tim Horton  <timothy_horton@apple.com>
374
375         Modernize WebKit Tools Xcode projects for localization's sake
376         https://bugs.webkit.org/show_bug.cgi?id=191495
377
378         Reviewed by Alexey Proskuryakov.
379
380         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
381         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
382         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
383         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
384         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
385         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
386         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
388         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
389         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
390         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
391         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
392         These are less important because they're not localized, but since
393         I made the style checker complain, it now complains any time anyone
394         touches any of these projects... so upgrade them.
395
396 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
397
398         webkitpy: Check for specific process instead of using data migrator
399         https://bugs.webkit.org/show_bug.cgi?id=191551
400         <rdar://problem/45993156>
401
402         Rubber-stamped by Aakash Jain.
403
404         It's possible for the data migrator process to be stuck, but for a simulator to be
405         usable. Use device-specific processes to detect when a device is usable.
406
407         * Scripts/webkitpy/xcode/simulated_device.py:
408         (SimulatedDeviceManager._wait_until_device_is_usable):
409         (SimulatedDeviceManager):
410         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
411         since this implies that a device is booted.
412         (SimulatedDeviceManager.swap): Ditto.
413         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
414         process indicating the device is usable can be found.
415         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
416         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
417         it triggers the logic in is_usable()
418
419 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
420
421         Resurrect WebKitTestRunner for Windows port
422         https://bugs.webkit.org/show_bug.cgi?id=189257
423
424         Reviewed by Fujii Hironori.
425
426         Implement WebKitTestRunner for WinCairo.
427
428         * PlatformWin.cmake:
429         * Scripts/build-webkittestrunner:
430         * WebKitTestRunner/CMakeLists.txt:
431         * WebKitTestRunner/EventSenderProxy.h:
432         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
433         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
434         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
435         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
436         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
437         (WTR::rangeToStr):
438         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
439         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
440         (WTR::TestRunner::TestRunner):
441         * WebKitTestRunner/InjectedBundle/TestRunner.h:
442         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
443         (WTR::AccessibilityController::resetToConsistentState):
444         (WTR::AccessibilityController::accessibleElementById):
445         (WTR::AccessibilityController::platformName):
446         (WTR::AccessibilityController::rootElement):
447         (WTR::AccessibilityController::focusedElement):
448         (WTR::AccessibilityController::addNotificationListener):
449         (WTR::AccessibilityController::removeNotificationListener):
450         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
451         (WTR::AccessibilityUIElement::AccessibilityUIElement):
452         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
453         (WTR::AccessibilityUIElement::isEqual):
454         (WTR::AccessibilityUIElement::getChildren):
455         (WTR::AccessibilityUIElement::getChildrenWithRange):
456         (WTR::AccessibilityUIElement::childrenCount):
457         (WTR::AccessibilityUIElement::elementAtPoint):
458         (WTR::AccessibilityUIElement::indexOfChild):
459         (WTR::AccessibilityUIElement::childAtIndex):
460         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
461         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
462         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
463         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
464         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
465         (WTR::AccessibilityUIElement::rowAtIndex):
466         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
467         (WTR::AccessibilityUIElement::selectedChildrenCount const):
468         (WTR::AccessibilityUIElement::selectedRowAtIndex):
469         (WTR::AccessibilityUIElement::titleUIElement):
470         (WTR::AccessibilityUIElement::parentElement):
471         (WTR::AccessibilityUIElement::disclosedByRow):
472         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
473         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
474         (WTR::AccessibilityUIElement::attributesOfChildren):
475         (WTR::AccessibilityUIElement::allAttributes):
476         (WTR::AccessibilityUIElement::stringAttributeValue):
477         (WTR::AccessibilityUIElement::numberAttributeValue):
478         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
479         (WTR::AccessibilityUIElement::rowHeaders const):
480         (WTR::AccessibilityUIElement::columnHeaders const):
481         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
482         (WTR::AccessibilityUIElement::boolAttributeValue):
483         (WTR::AccessibilityUIElement::isAttributeSettable):
484         (WTR::AccessibilityUIElement::isAttributeSupported):
485         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
486         (WTR::AccessibilityUIElement::role):
487         (WTR::AccessibilityUIElement::subrole):
488         (WTR::AccessibilityUIElement::roleDescription):
489         (WTR::AccessibilityUIElement::computedRoleString):
490         (WTR::AccessibilityUIElement::title):
491         (WTR::AccessibilityUIElement::description):
492         (WTR::AccessibilityUIElement::orientation const):
493         (WTR::AccessibilityUIElement::stringValue):
494         (WTR::AccessibilityUIElement::language):
495         (WTR::AccessibilityUIElement::helpText const):
496         (WTR::AccessibilityUIElement::x):
497         (WTR::AccessibilityUIElement::y):
498         (WTR::AccessibilityUIElement::width):
499         (WTR::AccessibilityUIElement::height):
500         (WTR::AccessibilityUIElement::clickPointX):
501         (WTR::AccessibilityUIElement::clickPointY):
502         (WTR::AccessibilityUIElement::intValue const):
503         (WTR::AccessibilityUIElement::minValue):
504         (WTR::AccessibilityUIElement::maxValue):
505         (WTR::AccessibilityUIElement::valueDescription):
506         (WTR::AccessibilityUIElement::insertionPointLineNumber):
507         (WTR::AccessibilityUIElement::isPressActionSupported):
508         (WTR::AccessibilityUIElement::isIncrementActionSupported):
509         (WTR::AccessibilityUIElement::isDecrementActionSupported):
510         (WTR::AccessibilityUIElement::isEnabled):
511         (WTR::AccessibilityUIElement::isRequired const):
512         (WTR::AccessibilityUIElement::isFocused const):
513         (WTR::AccessibilityUIElement::isSelected const):
514         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
515         (WTR::AccessibilityUIElement::isExpanded const):
516         (WTR::AccessibilityUIElement::isChecked const):
517         (WTR::AccessibilityUIElement::isIndeterminate const):
518         (WTR::AccessibilityUIElement::hierarchicalLevel const):
519         (WTR::AccessibilityUIElement::speakAs):
520         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
521         (WTR::AccessibilityUIElement::ariaDropEffects const):
522         (WTR::AccessibilityUIElement::lineForIndex):
523         (WTR::AccessibilityUIElement::rangeForLine):
524         (WTR::AccessibilityUIElement::rangeForPosition):
525         (WTR::AccessibilityUIElement::boundsForRange):
526         (WTR::AccessibilityUIElement::stringForRange):
527         (WTR::AccessibilityUIElement::attributedStringForRange):
528         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
529         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
530         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
531         (WTR::AccessibilityUIElement::selectTextWithCriteria):
532         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
533         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
534         (WTR::AccessibilityUIElement::attributesOfColumns):
535         (WTR::AccessibilityUIElement::attributesOfRows):
536         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
537         (WTR::AccessibilityUIElement::attributesOfHeader):
538         (WTR::AccessibilityUIElement::rowCount):
539         (WTR::AccessibilityUIElement::columnCount):
540         (WTR::AccessibilityUIElement::indexInTable):
541         (WTR::AccessibilityUIElement::rowIndexRange):
542         (WTR::AccessibilityUIElement::columnIndexRange):
543         (WTR::AccessibilityUIElement::cellForColumnAndRow):
544         (WTR::AccessibilityUIElement::horizontalScrollbar const):
545         (WTR::AccessibilityUIElement::verticalScrollbar const):
546         (WTR::AccessibilityUIElement::selectedTextRange):
547         (WTR::AccessibilityUIElement::setSelectedTextRange):
548         (WTR::AccessibilityUIElement::increment):
549         (WTR::AccessibilityUIElement::decrement):
550         (WTR::AccessibilityUIElement::showMenu):
551         (WTR::AccessibilityUIElement::press):
552         (WTR::AccessibilityUIElement::setSelectedChild const):
553         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
554         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
555         (WTR::AccessibilityUIElement::clearSelectedChildren const):
556         (WTR::AccessibilityUIElement::accessibilityValue const):
557         (WTR::AccessibilityUIElement::documentEncoding):
558         (WTR::AccessibilityUIElement::documentURI):
559         (WTR::AccessibilityUIElement::url):
560         (WTR::AccessibilityUIElement::addNotificationListener):
561         (WTR::AccessibilityUIElement::removeNotificationListener):
562         (WTR::AccessibilityUIElement::isFocusable const):
563         (WTR::AccessibilityUIElement::isSelectable const):
564         (WTR::AccessibilityUIElement::isMultiSelectable const):
565         (WTR::AccessibilityUIElement::isVisible const):
566         (WTR::AccessibilityUIElement::isOffScreen const):
567         (WTR::AccessibilityUIElement::isCollapsed const):
568         (WTR::AccessibilityUIElement::isIgnored const):
569         (WTR::AccessibilityUIElement::isSingleLine const):
570         (WTR::AccessibilityUIElement::isMultiLine const):
571         (WTR::AccessibilityUIElement::hasPopup const):
572         (WTR::AccessibilityUIElement::takeFocus):
573         (WTR::AccessibilityUIElement::takeSelection):
574         (WTR::AccessibilityUIElement::addSelection):
575         (WTR::AccessibilityUIElement::removeSelection):
576         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
577         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
578         (WTR::AccessibilityUIElement::textMarkerRangeLength):
579         (WTR::AccessibilityUIElement::previousTextMarker):
580         (WTR::AccessibilityUIElement::nextTextMarker):
581         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
582         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
583         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
584         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
585         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
586         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
587         (WTR::AccessibilityUIElement::textMarkerForPoint):
588         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
589         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
590         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
591         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
592         (WTR::AccessibilityUIElement::indexForTextMarker):
593         (WTR::AccessibilityUIElement::isTextMarkerValid):
594         (WTR::AccessibilityUIElement::textMarkerForIndex):
595         (WTR::AccessibilityUIElement::startTextMarker):
596         (WTR::AccessibilityUIElement::endTextMarker):
597         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
598         (WTR::AccessibilityUIElement::scrollToMakeVisible):
599         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
600         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
601         (WTR::AccessibilityUIElement::supportedActions const):
602         (WTR::AccessibilityUIElement::pathDescription const):
603         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
604         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
605         (WTR::AccessibilityUIElement::classList const):
606         (WTR::AccessibilityUIElement::characterAtOffset):
607         (WTR::AccessibilityUIElement::wordAtOffset):
608         (WTR::AccessibilityUIElement::lineAtOffset):
609         (WTR::AccessibilityUIElement::sentenceAtOffset):
610         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
611         (WTR::activateFonts):
612         (WTR::installFakeHelvetica):
613         (WTR::uninstallFakeHelvetica):
614         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
615         (WTR::InjectedBundle::platformInitialize):
616         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
617         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
618         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
619         (WTR::TestRunner::pathToLocalResource):
620         (WTR::TestRunner::inspectorTestStubURL):
621         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
622         (WTR::TestRunner::platformInitialize):
623         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
624         (WTR::TestRunner::installFakeHelvetica):
625         * WebKitTestRunner/PlatformWebView.h:
626         * WebKitTestRunner/PlatformWin.cmake: Added.
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::resetStateToConsistentValues):
629         (WTR::createTestURL):
630         * WebKitTestRunner/TestInvocation.cpp:
631         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
632         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
633         (WTR::EventSenderProxy::EventSenderProxy):
634         (WTR::EventSenderProxy::~EventSenderProxy):
635         (WTR::EventSenderProxy::mouseDown):
636         (WTR::EventSenderProxy::mouseUp):
637         (WTR::EventSenderProxy::mouseMoveTo):
638         (WTR::EventSenderProxy::mouseScrollBy):
639         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
640         (WTR::EventSenderProxy::continuousMouseScrollBy):
641         (WTR::EventSenderProxy::leapForward):
642         (WTR::EventSenderProxy::keyDown):
643         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
644         (WTR::registerWindowClass):
645         (WTR::PlatformWebView::PlatformWebView):
646         (WTR::PlatformWebView::~PlatformWebView):
647         (WTR::PlatformWebView::resizeTo):
648         (WTR::PlatformWebView::page):
649         (WTR::PlatformWebView::focus):
650         (WTR::PlatformWebView::windowFrame):
651         (WTR::PlatformWebView::setWindowFrame):
652         (WTR::PlatformWebView::didInitializeClients):
653         (WTR::PlatformWebView::addChromeInputField):
654         (WTR::PlatformWebView::removeChromeInputField):
655         (WTR::PlatformWebView::addToWindow):
656         (WTR::PlatformWebView::removeFromWindow):
657         (WTR::PlatformWebView::setWindowIsKey):
658         (WTR::PlatformWebView::makeWebViewFirstResponder):
659         (WTR::generateCairoSurfaceFromBitmap):
660         (WTR::PlatformWebView::windowSnapshotImage):
661         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
662         (WTR::PlatformWebView::setNavigationGesturesEnabled):
663         (WTR::PlatformWebView::forceWindowFramesChanged):
664         (WTR::PlatformWebView::drawsBackground const):
665         (WTR::PlatformWebView::setDrawsBackground):
666         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
667         (WTR::exceptionFilter):
668         (WTR::runRunLoopUntil):
669         (WTR::TestController::notifyDone):
670         (WTR::TestController::setHidden):
671         (WTR::TestController::platformInitialize):
672         (WTR::TestController::platformPreferences):
673         (WTR::TestController::platformDestroy):
674         (WTR::toWK):
675         (WTR::TestController::platformInitializeContext):
676         (WTR::TestController::platformRunUntil):
677         (WTR::TestController::platformDidCommitLoadForFrame):
678         (WTR::TestController::initializeInjectedBundlePath):
679         (WTR::TestController::initializeTestPluginDirectory):
680         (WTR::TestController::runModal):
681         (WTR::TestController::platformContext):
682         (WTR::TestController::platformLibraryPathForTesting):
683         (WTR::TestController::platformConfigureViewForTest):
684         (WTR::TestController::platformResetPreferencesToConsistentValues):
685         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
686         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
687         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
688         (dllLauncherEntryPoint):
689
690 2018-11-12  Alicia Boya García  <aboya@igalia.com>
691
692         [MSE][GStreamer] Introduce AbortableTaskQueue
693         https://bugs.webkit.org/show_bug.cgi?id=190902
694
695         Reviewed by Xabier Rodriguez-Calvar.
696
697         Tests for AbortableTaskQueue are included.
698
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * TestWebKitAPI/PlatformGTK.cmake:
701         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
702         (TestWebKitAPI::TEST):
703         (TestWebKitAPI::FancyResponse::FancyResponse):
704         (TestWebKitAPI::FancyResponse::operator=):
705         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
706         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
707         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
708         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
709
710 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
711
712         run-bindings-tests is timing out in some WinCairo bots
713         https://bugs.webkit.org/show_bug.cgi?id=191348
714
715         Reviewed by Alex Christensen.
716
717         BuildBot kills run-bindings-tests if it outputs nothing for 20
718         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
719         and it takes more than 30 minutes to finish. And, Windows Python
720         buffers the progress output.
721
722         * Scripts/webkitpy/bindings/main.py:
723         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
724         test case result is output.
725
726 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
727
728         Implement a new edit command to change the enclosing list type
729         https://bugs.webkit.org/show_bug.cgi?id=191487
730         <rdar://problem/45955922>
731
732         Reviewed by Ryosuke Niwa.
733
734         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
735         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
736
737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
738         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
739         (-[TestWKWebView setPosition:offset:]):
740         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
741         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
742         (TestWebKitAPI::TEST):
743         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
744
745 2018-11-11  Dan Bernstein  <mitz@apple.com>
746
747         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
748         https://bugs.webkit.org/show_bug.cgi?id=191514
749
750         Reviewed by Geoffrey Garen.
751
752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
753         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
754         (TEST):
755
756 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
757
758         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
759         https://bugs.webkit.org/show_bug.cgi?id=191492
760
761         Reviewed by Alex Christensen.
762
763         Update file name.
764
765         * DumpRenderTree/mac/DumpRenderTree.mm:
766         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
767         * WebKitTestRunner/mac/TestControllerMac.mm:
768
769 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
770
771         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
772         https://bugs.webkit.org/show_bug.cgi?id=191492
773
774         Reviewed by Alex Christensen.
775
776         * DumpRenderTree/mac/DumpRenderTree.mm:
777         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
778         * WebKitTestRunner/mac/TestControllerMac.mm:
779
780 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
781
782         Unreviewed, rolling out r238065.
783
784         Breaks internal builds.
785
786         Reverted changeset:
787
788         "Make it possible to edit images inline"
789         https://bugs.webkit.org/show_bug.cgi?id=191352
790         https://trac.webkit.org/changeset/238065
791
792 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
793
794         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
795         https://bugs.webkit.org/show_bug.cgi?id=191221
796
797         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
798         that it is disabled, but we're testing that it is enabled, because I failed to update this
799         line.
800
801         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
802         (testWebKitSettings):
803
804 2018-11-10  Tim Horton  <timothy_horton@apple.com>
805
806         Make it possible to edit images inline
807         https://bugs.webkit.org/show_bug.cgi?id=191352
808         <rdar://problem/30107985>
809
810         Reviewed by Dean Jackson.
811
812         * WebKitTestRunner/TestController.cpp:
813         (WTR::updateTestOptionsFromTestHeader):
814         * WebKitTestRunner/TestOptions.h:
815         (WTR::TestOptions::hasSameInitializationOptions const):
816         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
817         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
818         (WTR::TestController::platformCreateWebView):
819         Add a test option to enable editable images.
820
821         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
822         (WTR::UIScriptController::drawSquareInEditableImage):
823         (WTR::UIScriptController::numberOfStrokesInEditableImage):
824         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
825         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
826         (WTR::UIScriptController::drawSquareInEditableImage):
827         (WTR::UIScriptController::numberOfStrokesInEditableImage):
828         * TestRunnerShared/UIScriptContext/UIScriptController.h:
829         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
830         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
831         (WTR::findEditableImageCanvas):
832         (WTR::UIScriptController::drawSquareInEditableImage):
833         (WTR::UIScriptController::numberOfStrokesInEditableImage):
834         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
835         and also to retrieve the number of strokes currently on the PKCanvasView.
836         Currently this just takes the first canvas; we might need to make it
837         take an identifier or something in the future if we need tests with multiple
838         canvases. The indirect testing mechanism is required because PKCanvasView
839         can currently not actually paint its strokes in the Simulator.
840
841 2018-11-09  Chris Dumez  <cdumez@apple.com>
842
843         Suspended page persists even after back/forward list item is gone
844         https://bugs.webkit.org/show_bug.cgi?id=191488
845         <rdar://problem/45953006>
846
847         Reviewed by Geoffrey Garen.
848
849         Add API test coverage.
850
851         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
852
853 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
854
855         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
856         https://bugs.webkit.org/show_bug.cgi?id=191471
857         <rdar://problem/45952472>
858
859         Reviewed by Tim Horton.
860
861         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
862
863         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
864         (TestWebKitAPI::webViewForEditActionTesting):
865         (TestWebKitAPI::TEST):
866
867 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
868
869         [Curl][WebKit] Implement Proxy configuration API.
870         https://bugs.webkit.org/show_bug.cgi?id=189053
871
872         Reviewed by Youenn Fablet.
873
874         Added Proxy Settings dialog to call newly added API.
875
876         * MiniBrowser/win/BrowserWindow.h:
877         * MiniBrowser/win/Common.cpp:
878         (askProxySettings):
879         (askCredential):
880         (authDialogProc): Deleted.
881         * MiniBrowser/win/Common.h:
882         * MiniBrowser/win/DialogHelper.h: Added.
883         (Dialog::run):
884         (Dialog::doalogProc):
885         (Dialog::handle):
886         (Dialog::setup):
887         (Dialog::update):
888         (Dialog::validate):
889         (Dialog::updateOkButton):
890         (Dialog::command):
891         (Dialog::ok):
892         (Dialog::cancel):
893         (Dialog::close):
894         (Dialog::hDlg):
895         (Dialog::item):
896         (Dialog::setEnabled):
897         (Dialog::setText):
898         (Dialog::getText):
899         (Dialog::getTextLength):
900         (Dialog::RadioGroup::RadioGroup):
901         (Dialog::RadioGroup::set):
902         (Dialog::RadioGroup::get):
903         (Dialog::radioGroup):
904         * MiniBrowser/win/MainWindow.cpp:
905         (MainWindow::WndProc):
906         * MiniBrowser/win/MiniBrowserLib.rc:
907         * MiniBrowser/win/MiniBrowserLibResource.h:
908         * MiniBrowser/win/WebKitBrowserWindow.cpp:
909         (createWKURL):
910         (WebKitBrowserWindow::WebKitBrowserWindow):
911         (WebKitBrowserWindow::updateProxySettings):
912         (WebKitBrowserWindow::loadURL):
913         (WebKitBrowserWindow::loadHTMLString):
914         (WebKitBrowserWindow::openProxySettings):
915         * MiniBrowser/win/WebKitBrowserWindow.h:
916         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
917         (WebKitLegacyBrowserWindow::openProxySettings):
918         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
919
920 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
921
922         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
923         https://bugs.webkit.org/show_bug.cgi?id=191410
924         <rdar://problem/45898610>
925
926         Reviewed by Dean Jackson.
927
928         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
929         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
930         hooked up to their respective editing commands.
931
932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
933         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
934         (-[TestWKWebView querySelectorExists:]):
935         (-[TestWKWebView insertString:]):
936
937         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
938         invoking the WKWebView directly on macOS and calling on the content view on iOS.
939
940         (TestWebKitAPI::webViewForEditActionTesting):
941         (TestWebKitAPI::TEST):
942
943 2018-11-09  Philippe Normand  <pnormand@igalia.com>
944
945         [Flatpak] Refactoring and drive-by fixes
946         https://bugs.webkit.org/show_bug.cgi?id=191421
947
948         Reviewed by Michael Catanzaro.
949
950         * Scripts/webkitdirs.pm:
951         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
952         the sandbox, so rely on this.
953         * flatpak/flatpakutils.py:
954         (expand_manifest): Pass explicit keywords to load_manifest() and
955         remove unused local variable.
956         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
957         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
958         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
959         build_type handling a bit.
960         * flatpak/org.webkit.CommonModules.yaml: Added.
961         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
962         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
963         declaration to CommonModules, so it can be reused later when we
964         add support for building extra libraries depending on WPE.
965
966 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
967
968 onal supported image formats
969         https://bugs.webkit.org/show_bug.cgi?id=190454
970
971         Reviewed by Simon Fraser.
972
973         Test opening a TGA image in WebView which is not allowed by default. The
974         TGA format will be allowed through WKWebViewConfiguration.
975
976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
977         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
978         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
979         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
980         (runTest):
981         (TEST):
982
983 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
984
985         Unreviewed, a proper build fix for r237983
986
987         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
988
989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
990         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
991         (TestWebKitAPI::TEST):
992         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
993         (TestWebKitAPI::getTestCorruptedSignResponse):
994         (TestWebKitAPI::getTestCredentialRawIdBytes):
995         (TestWebKitAPI::convertToVector):
996         (TestWebKitAPI::TEST):
997
998 2018-11-08  Keith Rollin  <krollin@apple.com>
999
1000         Create .xcfilelist files
1001         https://bugs.webkit.org/show_bug.cgi?id=191324
1002         <rdar://problem/45852819>
1003
1004         Reviewed by Alex Christensen.
1005
1006         As part of preparing for enabling XCBuild, create and use .xcfilelist
1007         files. These files are using during Run Script build phases in an
1008         Xcode project. If a Run Script build phase produces new files that are
1009         used later as inputs to subsequent build phases, XCBuild needs to know
1010         about these files. These files can be either specified in an "output
1011         files" section of the Run Script phase editor, or in .xcfilelist files
1012         that are associated with the Run Script build phase.
1013
1014         This patch takes the second approach. It consists of three sets of changes:
1015
1016         - Modify the DerivedSources.make files to have a
1017           'print_all_generated_files" target that produces a list of the files
1018           they create.
1019
1020         - Create a shell script that produces .xcfilelist files from the
1021           output of the previous step, as well as for the files created in the
1022           Generate Unified Sources build steps.
1023
1024         - Add the new .xcfilelist files to the associated projects.
1025
1026         Note that, with these changes, the Xcode workspace and projects can no
1027         longer be fully loaded into Xcode 9. Xcode will attempt to load the
1028         projects that have .xcfilelist files associated with them, but will
1029         fail and display a placeholder for those projects instead. It's
1030         expected that all developers are using Xcode 10 by now and that not
1031         being able to load into Xcode 9 is not a practical issue. Keep in mind
1032         that this is strictly an IDE issue, and that the projects can still be
1033         built with `xcodebuild`.
1034
1035         Also note that the shell script that creates the .xcfilelist files can
1036         also be used to verify that the set of files that's currently checked
1037         in is up-to-date. This checking can be used as part of a check-in hook
1038         or part of check-webkit-style to sooner catch cases where the
1039         .xcfilelist files need to be regenerated.
1040
1041         * DumpRenderTree/DerivedSources.make:
1042         * DumpRenderTree/DerivedSources.xcfilelist: Added.
1043         * Scripts/generate-xcfilelists: Added.
1044         * WebKitTestRunner/DerivedSources.make:
1045         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
1046
1047 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1048
1049         Unreviewed, a quick build fix for r237983
1050
1051         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
1052
1053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
1054         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
1055         (TestWebKitAPI::TEST):
1056         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
1057         (TestWebKitAPI::getTestCorruptedSignResponse):
1058         (TestWebKitAPI::getTestCredentialRawIdBytes):
1059         (TestWebKitAPI::convertToVector):
1060         (TestWebKitAPI::TEST):
1061
1062 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
1063
1064         Fix steps_unittest.py failures related to recent Win10/Win7 changes
1065         https://bugs.webkit.org/show_bug.cgi?id=191290
1066
1067         Reviewed by Alexey Proskuryakov.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
1070
1071 2018-11-08  Dean Jackson  <dino@apple.com>
1072
1073         Add a String literal that returns a String
1074         https://bugs.webkit.org/show_bug.cgi?id=191425
1075         <rdar://problem/45914556>
1076
1077         Reviewed by Sam Weinig.
1078
1079         Test _str.
1080
1081         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1082         (TestWebKitAPI::TEST):
1083
1084 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
1085
1086         webkitpy: Generalize trailing SDK specifier (Part 2)
1087         https://bugs.webkit.org/show_bug.cgi?id=191275
1088         <rdar://problem/45703660>
1089
1090         Rubber-stamped by Aakash Jain.
1091
1092         Re-landing this change, configuration issues have been resolved.
1093
1094         * Scripts/webkitpy/port/ios_device.py:
1095         (IOSDevicePort): Use normalized SDK.
1096         * Scripts/webkitpy/port/ios_simulator.py:
1097         (IOSSimulatorPort): Use normalized SDK.
1098         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1099
1100 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1101
1102         [WebAuthN] Import CTAP device request/response converters from Chromium
1103         https://bugs.webkit.org/show_bug.cgi?id=190784
1104         <rdar://problem/45460333>
1105
1106         Reviewed by Brent Fulgham.
1107
1108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1109         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1110         (TestWebKitAPI::TEST):
1111         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1112         (TestWebKitAPI::TEST):
1113         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1114         (TestWebKitAPI::getTestCorruptedSignResponse):
1115         (TestWebKitAPI::getTestCredentialRawIdBytes):
1116         (TestWebKitAPI::convertToVector):
1117         (TestWebKitAPI::TEST):
1118         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1119
1120 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1121
1122         [BigInt] Add support to BigInt into ValueAdd
1123         https://bugs.webkit.org/show_bug.cgi?id=186177
1124
1125         Reviewed by Keith Miller.
1126
1127         * Scripts/run-jsc-benchmarks:
1128
1129 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1130
1131         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1132         https://bugs.webkit.org/show_bug.cgi?id=191326
1133         <rdar://problem/45769269>
1134
1135         Reviewed by Geoffrey Garen.
1136
1137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1138         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1139         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1140         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1141         (TEST):
1142
1143 2018-11-07  Daniel Bates  <dabates@apple.com>
1144
1145         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1146         https://bugs.webkit.org/show_bug.cgi?id=190141
1147
1148         Reviewed by Darin Adler.
1149
1150         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1151         runs deterministic regardless of whether a hardware keyboard is attached.
1152
1153         * DumpRenderTree/mac/DumpRenderTree.mm:
1154         (overrideIsInHardwareKeyboardMode): Added.
1155         (prepareConsistentTestingEnvironment):
1156         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1157         * WebKitTestRunner/ios/TestControllerIOS.mm:
1158         (overrideIsInHardwareKeyboardMode): Added.
1159         (WTR::TestController::platformInitialize):
1160
1161 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1162
1163         Unreviewed, rolling out r237913.
1164
1165         Breaks running tests on Mac without iOS SDK installed
1166
1167         Reverted changeset:
1168
1169         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1170         https://bugs.webkit.org/show_bug.cgi?id=191275
1171         https://trac.webkit.org/changeset/237913
1172
1173 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1174
1175         Force a gregorian calendar to show for credit card expiration date inputs
1176         (autocomplete='cc-exp'*) regardless of default system settings.
1177         https://bugs.webkit.org/show_bug.cgi?id=191096
1178         rdar://problem/42640256
1179
1180         Reviewed by Tim Horton.
1181
1182         Implemented simulateForeignDefaultCalendar and calendarType to be used
1183         for changing the default calendar returned by the system (ie. [NSCalendar
1184         currentCalendar]) and getting the calendar type identifier of a presented date
1185         picker.
1186
1187         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1188         (WTR::UIScriptController::isShowingDataListSuggestions const):
1189         (WTR::UIScriptController::calendarType const):
1190         (WTR::UIScriptController::setDefaultCalendarType):
1191         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1192         (WTR::UIScriptController::calendarType const):
1193         (WTR::UIScriptController::setDefaultCalendarType):
1194         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1195         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1196         (WTR::UIScriptController::calendarType const): Deleted.
1197         * WebKitTestRunner/TestController.cpp:
1198         * WebKitTestRunner/TestController.h:
1199         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1200         (WTR::UIScriptController::calendarType const):
1201         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1202         (WTR::swizzledCalendar):
1203         (WTR::TestController::getOverriddenCalendarIdentifier const):
1204         (WTR::TestController::setDefaultCalendarType):
1205         (WTR::TestController::cocoaResetStateToConsistentValues):
1206         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1207         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1208         (WTR::UIScriptController::calendarType const): Deleted.
1209
1210 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1211
1212         webkitpy: Boot a single worker for custom devices
1213         https://bugs.webkit.org/show_bug.cgi?id=191312
1214         <rdar://problem/45848717>
1215
1216         Rubber-stamped by Aakash Jain.
1217
1218         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1219         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1220         simulators is expensive and unneeded for these tests.
1221         * Scripts/webkitpy/port/ios.py:
1222         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1223         overriding the number of child processes when booting custom devices.
1224
1225 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1226
1227         webkitpy: Generalize trailing SDK specifier (Part 2)
1228         https://bugs.webkit.org/show_bug.cgi?id=191275
1229         <rdar://problem/45703660>
1230
1231         Reviewed by Aakash Jain.
1232
1233         * Scripts/webkitpy/port/ios_device.py:
1234         (IOSDevicePort): Use normalized SDK.
1235         * Scripts/webkitpy/port/ios_simulator.py:
1236         (IOSSimulatorPort): Use normalized SDK.
1237         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1238
1239 2018-11-06  Justin Fan  <justin_fan@apple.com>
1240
1241         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1242         https://bugs.webkit.org/show_bug.cgi?id=191291
1243
1244         Reviewed by Myles Maxfield.
1245
1246         Properly disable WEBGPU on all non-Metal platforms for now.
1247
1248         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1249
1250 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1251
1252         [ews-app] Add URL configuration for OpenSource EWS Django app
1253         https://bugs.webkit.org/show_bug.cgi?id=191132
1254
1255         Rubber-stamped by Lucas Forschler.
1256
1257         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1258         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1259
1260 2018-11-06  Youenn Fablet  <youenn@apple.com>
1261
1262         Make mDNS ICE Candidate an experimental flag again
1263         https://bugs.webkit.org/show_bug.cgi?id=191262
1264
1265         Reviewed by Dean Jackson.
1266
1267         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1268         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1269         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1270         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
1271         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1272
1273 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-app] Add views for OpenSource EWS Django app
1276         https://bugs.webkit.org/show_bug.cgi?id=191131
1277
1278         Rubber-stamped by Lucas Forschler.
1279
1280         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
1281         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1282         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
1283         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
1284
1285 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1286
1287         [ews-app] Add models for OpenSource EWS Django app
1288         https://bugs.webkit.org/show_bug.cgi?id=191123
1289
1290         Reviewed by Lucas Forschler.
1291
1292         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1293         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
1294         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
1295         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1296         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
1297
1298 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1299
1300         [ews-app] Fix Invalid HTTP_HOST header
1301         https://bugs.webkit.org/show_bug.cgi?id=191325
1302
1303         Reviewed by Lucas Forschler.
1304
1305         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
1306
1307         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1308
1309 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-app] Rename EWS_app to ews-app - part 2
1312         https://bugs.webkit.org/show_bug.cgi?id=191317
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * BuildSlaveSupport/ews-app/EWS_app: Removed.
1317         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
1318         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1319         * BuildSlaveSupport/ews-app/ews-app/urls.py:
1320         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
1321         * BuildSlaveSupport/ews-app/manage.py:
1322
1323 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1324
1325         [ews-app] Rename EWS_app to ews-app - part 1
1326         https://bugs.webkit.org/show_bug.cgi?id=191317
1327
1328         Reviewed by Lucas Forschler.
1329
1330         * BuildSlaveSupport/EWS_app: Removed.
1331         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
1332
1333 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
1334
1335         Spelling dots are drawn in the wrong place
1336         https://bugs.webkit.org/show_bug.cgi?id=190764
1337
1338         Reviewed by Dean Jackson.
1339
1340         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1341         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1342         dots to be drawn.
1343
1344         * WebKitTestRunner/TestController.cpp:
1345         (WTR::TestController::resetStateToConsistentValues):
1346         (WTR::updateTestOptionsFromTestHeader):
1347         (WTR::TestController::platformResetStateToConsistentValues):
1348         * WebKitTestRunner/TestController.h:
1349         * WebKitTestRunner/TestOptions.h:
1350         (WTR::TestOptions::hasSameInitializationOptions const):
1351         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1352         (WTR::TestController::cocoaResetStateToConsistentValues):
1353         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1354         * WebKitTestRunner/ios/TestControllerIOS.mm:
1355         (WTR::TestController::platformResetStateToConsistentValues):
1356         * WebKitTestRunner/mac/TestControllerMac.mm:
1357         (WTR::TestController::platformResetStateToConsistentValues):
1358
1359 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
1360
1361         Feature flags not present for Visual Studio when using build-webkit
1362         https://bugs.webkit.org/show_bug.cgi?id=191288
1363
1364         Reviewed by Fujii Hironori.
1365
1366         Passes feature flags to Visual studio builds within build-webkit.
1367         Removes cmakeBasedPortArguments as it is no longer in use.
1368
1369         * Scripts/build-jsc:
1370         * Scripts/build-webkit:
1371         * Scripts/webkitdirs.pm:
1372         (cmakeBasedPortArguments): Deleted.
1373
1374 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
1375
1376         REGRESSION (r230523): Caps lock indicator not shown in password field
1377         https://bugs.webkit.org/show_bug.cgi?id=190056
1378
1379         Reviewed by Ryosuke Niwa.
1380
1381         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1383         (WTR::TestRunner::toggleCapsLock):
1384         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1385         * WebKitTestRunner/TestController.h:
1386         * WebKitTestRunner/TestInvocation.cpp:
1387         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1388         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1389         (WTR::TestController::toggleCapsLock):
1390
1391 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
1392
1393         IndexedDB: WAL file keeps growing
1394         https://bugs.webkit.org/show_bug.cgi?id=191294
1395         <rdar://problem/41333493>
1396
1397         Reviewed by Chris Dumez.
1398
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
1401         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
1402         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
1403         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
1404         (TEST):
1405
1406 2018-11-06  Alex Christensen  <achristensen@webkit.org>
1407
1408         Fix tests after r237863
1409         https://bugs.webkit.org/show_bug.cgi?id=191315
1410
1411         Reviewed by Chris Dumez.
1412
1413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1414         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
1415         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
1416         to verify that main2.html eventually loads, making this test less timing dependent.
1417
1418 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
1419
1420         Unreviewed, rolling out r237834.
1421
1422         Tests for this change crash on iOS Simulator
1423
1424         Reverted changeset:
1425
1426         "Spelling dots are drawn in the wrong place"
1427         https://bugs.webkit.org/show_bug.cgi?id=190764
1428         https://trac.webkit.org/changeset/237834
1429
1430 2018-11-05  Alex Christensen  <achristensen@webkit.org>
1431
1432         [Mac] Implement safe browsing in WebKit
1433         https://bugs.webkit.org/show_bug.cgi?id=188871
1434
1435         Reviewed by Tim Horton.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1438         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
1439         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
1440         (-[TestLookupContext lookUpURL:completionHandler:]):
1441         (simpleURL):
1442         (safeBrowsingView):
1443         (TEST):
1444         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
1445         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
1446         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
1447         * TestWebKitAPI/Utilities.h:
1448
1449 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
1450
1451         webkitpy: Generalize trailing SDK specifier (Part 1)
1452         https://bugs.webkit.org/show_bug.cgi?id=191275
1453         <rdar://problem/45703660>
1454
1455         Reviewed by Lucas Forschler.
1456
1457         * Scripts/webkitpy/common/system/platforminfo.py:
1458         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
1459         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1460         (TestPlatformInfo):
1461         (TestPlatformInfo.test_available_sdks):
1462
1463 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
1464
1465         Spelling dots are drawn in the wrong place
1466         https://bugs.webkit.org/show_bug.cgi?id=190764
1467
1468         Reviewed by Dean Jackson.
1469
1470         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1471         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1472         dots to be drawn.
1473
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::TestController::resetStateToConsistentValues):
1476         (WTR::updateTestOptionsFromTestHeader):
1477         (WTR::TestController::platformResetStateToConsistentValues):
1478         * WebKitTestRunner/TestController.h:
1479         * WebKitTestRunner/TestOptions.h:
1480         (WTR::TestOptions::hasSameInitializationOptions const):
1481         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1482         (WTR::TestController::cocoaResetStateToConsistentValues):
1483         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1484         * WebKitTestRunner/ios/TestControllerIOS.mm:
1485         (WTR::TestController::platformResetStateToConsistentValues):
1486         * WebKitTestRunner/mac/TestControllerMac.mm:
1487         (WTR::TestController::platformResetStateToConsistentValues):
1488
1489 2018-11-05  Chris Dumez  <cdumez@apple.com>
1490
1491         Use same limit for page cache and suspended pages
1492         https://bugs.webkit.org/show_bug.cgi?id=191266
1493
1494         Reviewed by Geoffrey Garen.
1495
1496         Update API tests accordingly.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1499
1500 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1501
1502         [style] Exclude style check for auto generated files.
1503         https://bugs.webkit.org/show_bug.cgi?id=191118
1504
1505         Reviewed by Eric Carlson.
1506
1507         Some files checked in to the repository are generated by other tools. In this patch,
1508         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
1509         VisualStudio.
1510
1511         There's no need to check these files because it's not practical to fix the style errors
1512         or it's hard to maintain those fixes.
1513
1514         * Scripts/webkitpy/style/checkers/cpp.py:
1515         (is_generated_file):
1516         (CppChecker.check):
1517
1518 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1519
1520         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
1521         https://bugs.webkit.org/show_bug.cgi?id=190680
1522
1523         Reviewed by Philippe Normand.
1524
1525         * flatpak/org.webkit.WebKit.yaml:
1526
1527 2018-11-05  Daniel Bates  <dabates@apple.com>
1528
1529         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
1530         https://bugs.webkit.org/show_bug.cgi?id=191094
1531
1532         Reviewed by Andy Estes.
1533
1534         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
1535         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
1536         Document summary and add closing brace '}' to both Frame and Document summary strings to make
1537         them look pretty.
1538
1539         * lldb/lldb_webkit.py:
1540         (WebCoreFrame_SummaryProvider):
1541         (WebCoreDocument_SummaryProvider):
1542
1543 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1544
1545         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
1546         https://bugs.webkit.org/show_bug.cgi?id=191240
1547         <rdar://problem/44872806>
1548
1549         Reviewed by Tim Horton.
1550
1551         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
1552         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
1553         overriding `-[WKWebView inputAssistantItem]`.
1554
1555         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1556         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
1557         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
1558         (+[InputAssistantItemTestingWebView barButtonIcon]):
1559         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
1560         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
1561         (-[InputAssistantItemTestingWebView inputAssistantItem]):
1562         (TestWebKitAPI::TEST):
1563
1564 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1565
1566         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
1567         https://bugs.webkit.org/show_bug.cgi?id=191226
1568         <rdar://problem/45781765>
1569
1570         Reviewed by Tim Horton.
1571
1572         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
1573         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
1574
1575         * WebKitTestRunner/TestOptions.h:
1576         (WTR::TestOptions::hasSameInitializationOptions const):
1577
1578 2018-11-05  Commit Queue  <commit-queue@webkit.org>
1579
1580         Unreviewed, rolling out r237784 and r237788.
1581         https://bugs.webkit.org/show_bug.cgi?id=191270
1582
1583         Caused mediastream layout test failures (Requested by
1584         ryanhaddad on #webkit).
1585
1586         Reverted changesets:
1587
1588         "[MediaStream] User should not be prompted again after denying
1589         getDisplayMedia request"
1590         https://bugs.webkit.org/show_bug.cgi?id=191227
1591         https://trac.webkit.org/changeset/237784
1592
1593         "[MediaStream] User should not be prompted again after denying
1594         getDisplayMedia request"
1595         https://bugs.webkit.org/show_bug.cgi?id=191227
1596         https://trac.webkit.org/changeset/237788
1597
1598 2018-11-05  Lucas Forschler  <lforschler@apple.com>
1599
1600         https://bugs.webkit.org/show_bug.cgi?id=191268
1601         Remove unused bots.
1602
1603         rubber-stamped by Alexey Proskuryakov.
1604
1605         * BuildSlaveSupport/build.webkit.org-config/config.json:
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1607         (WebKitBuildbot):
1608
1609 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1610
1611         [WPE][GTK] API test runner fails to respect default build type
1612         https://bugs.webkit.org/show_bug.cgi?id=190247
1613
1614         Reviewed by Carlos Garcia Campos.
1615
1616         Problem is it's looking for a release build, even though I've run set-webkit-configuration
1617         --debug. It should look for a debug build unless I explicitly pass --release.
1618
1619         * glib/api_test_runner.py:
1620         (TestRunner.__init__):
1621
1622 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1623
1624         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
1625         https://bugs.webkit.org/show_bug.cgi?id=190674
1626
1627         Reviewed by Philippe Normand.
1628
1629         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
1630         it can use to implement encoding for different formats exposing a trimmed down unified API.
1631
1632         It also adds proper handling of H264 profiles.
1633
1634         The added files follow GStreamer coding style as we aim at upstreaming the element
1635         in the future.
1636
1637         Reviewed by Philippe Normand.
1638
1639         * Scripts/webkitpy/style/checker.py:
1640
1641 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1642
1643         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1644         https://bugs.webkit.org/show_bug.cgi?id=191221
1645
1646         Reviewed by Carlos Garcia Campos.
1647
1648         This test ensures that MSE is disabled by default, but we now enable it by default, so
1649         reverse the semantics of the test.
1650
1651         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1652         (testWebKitSettings):
1653
1654 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1655
1656         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
1657         https://bugs.webkit.org/show_bug.cgi?id=191225
1658
1659         Reviewed by Alejandro G. Castro.
1660
1661         Fix a memory leak causing this test to fail.
1662
1663         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1664         (WebViewTest::initializeWebView):
1665
1666 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
1667
1668         [webkitpy] Support WPE in the run-web-platform-tests script
1669         https://bugs.webkit.org/show_bug.cgi?id=191183
1670
1671         Reviewed by Alex Christensen.
1672
1673         * Scripts/webkitpy/w3c/wpt_runner.py:
1674         (parse_args): Support `--wpe` as an argument that specifies WPE as the
1675         target port. Additionally, the `--display-server` flag now accepts
1676         `headless` as a valid value, enabling the WPE WebDriver to run in
1677         headless mode.
1678
1679 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
1680
1681         [Win] Use C++14, not C++17
1682         https://bugs.webkit.org/show_bug.cgi?id=191101
1683
1684         Reviewed by Alex Christensen.
1685
1686         std::basic_string::data() returns a read-only const buffer in
1687         C++14.
1688
1689         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1690         (createString): Use std::vector instead of std::wstring.
1691         (createUTF8String): Use std::vector instead of std::string.
1692
1693 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1694
1695         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
1696         https://bugs.webkit.org/show_bug.cgi?id=191231
1697
1698         Reviewed by Simon Fraser.
1699
1700         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
1701         it can be shared between iOS-family and macOS platforms. See below for more details.
1702
1703         No change in behavior.
1704
1705         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1706         (WTR::UIScriptController::overridePreference):
1707
1708         Add a method stub for DumpRenderTree.
1709
1710         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1711         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1712         (WTR::UIScriptController::doAsyncTask):
1713         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1714
1715         Unify these method implementations.
1716
1717         (WTR::UIScriptController::removeViewFromWindow):
1718         (WTR::UIScriptController::addViewToWindow):
1719
1720         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1721         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1722         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1723         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1724
1725         (WTR::UIScriptController::overridePreference):
1726         (WTR::UIScriptController::findString):
1727         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1728
1729         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1730
1731         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1732         (WTR::UIScriptController::doAsyncTask): Deleted.
1733         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1734         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1735         (WTR::UIScriptController::findString): Deleted.
1736         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1737         (WTR::UIScriptController::addViewToWindow): Deleted.
1738         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1739         (WTR::UIScriptController::doAsyncTask): Deleted.
1740         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1741         (WTR::UIScriptController::overridePreference): Deleted.
1742         (WTR::UIScriptController::findString): Deleted.
1743         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1744         (WTR::UIScriptController::addViewToWindow): Deleted.
1745         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1746
1747 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1748
1749         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1750         https://bugs.webkit.org/show_bug.cgi?id=191227
1751         <rdar://problem/45784512>
1752
1753         Reviewed by Youenn Fablet.
1754
1755         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1756         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1757         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1758         (TestWebKitAPI::TEST_F):
1759
1760 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1761
1762         [LFC][BFC] Add support for percentage height in quirks mode.
1763         https://bugs.webkit.org/show_bug.cgi?id=191232
1764
1765         Reviewed by Antti Koivisto.
1766
1767         * LayoutReloaded/misc/LFC-passing-tests.txt:
1768
1769 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1770
1771         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1772         https://bugs.webkit.org/show_bug.cgi?id=191229
1773
1774         Reviewed by Antti Koivisto.
1775
1776         * LayoutReloaded/misc/LFC-passing-tests.txt:
1777
1778 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1779
1780         [LFC][BFC] Resolve percentage height values.
1781         https://bugs.webkit.org/show_bug.cgi?id=191224
1782
1783         Reviewed by Antti Koivisto.
1784
1785         * LayoutReloaded/misc/LFC-passing-tests.txt:
1786
1787 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1788
1789         Mac production builds should sign the network process xpc service with entitlements
1790         https://bugs.webkit.org/show_bug.cgi?id=191209
1791         <rdar://problem/45377609>
1792
1793         Reviewed by Geoff Garen.
1794
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1797         (TEST):
1798
1799 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1800
1801         Unreviewed, rolling out r237761.
1802
1803         Makes most API tests timeout and WK2 tests crash
1804
1805         Reverted changeset:
1806
1807         "Mac production builds should sign the network process xpc
1808         service with entitlements"
1809         https://bugs.webkit.org/show_bug.cgi?id=191209
1810         https://trac.webkit.org/changeset/237761
1811
1812 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1813
1814         Unreviewed API test gardening
1815
1816         * TestWebKitAPI/glib/TestExpectations.json:
1817
1818 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1819
1820         Add new global object and preliminary Worklets support for CSS painting api
1821         https://bugs.webkit.org/show_bug.cgi?id=190979
1822
1823         Reviewed by Chris Dumez.
1824
1825         * Scripts/webkitpy/bindings/main.py:
1826         (BindingsTests.generate_supplemental_dependency):
1827         (BindingsTests.main):
1828
1829 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1830
1831         Mac production builds should sign the network process xpc service with entitlements
1832         https://bugs.webkit.org/show_bug.cgi?id=191209
1833         <rdar://problem/45377609>
1834
1835         Reviewed by Geoff Garen.
1836
1837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1838         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1839         (TEST):
1840
1841 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1842
1843         Add Windows 10 archive bots
1844         https://bugs.webkit.org/show_bug.cgi?id=190964
1845         
1846         This Change updates the Apple Windows Buildbot configuration.
1847         - Add Windows 10 specific builders and testers for release and debug.
1848         - Refactor Windows -> Windows 7.
1849         - Remove Windows 7 Debug.
1850
1851         Reviewed by Aakash Jain.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/config.json:
1854
1855 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1856
1857         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1858
1859         Rubber-stamped by Michael Catanzaro.
1860
1861         This variable is useful to get rid of shell color escapes in tests stderr files.
1862
1863         * Scripts/webkitpy/port/gtk.py:
1864         (GtkPort.setup_environ_for_server):
1865         * Scripts/webkitpy/port/wpe.py:
1866         (WPEPort.setup_environ_for_server):
1867
1868 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1869
1870         Add Basic Django web app for OpenSource EWS
1871         https://bugs.webkit.org/show_bug.cgi?id=191091
1872
1873         Reviewed by Lucas Forschler.
1874
1875         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1876         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1877         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1878         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1879         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1880         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1881         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1882         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1883         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1884         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1885         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1886         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1887         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1888         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1889
1890 2018-11-02  Daniel Bates  <dabates@apple.com>
1891
1892         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1893         https://bugs.webkit.org/show_bug.cgi?id=190487
1894
1895         Reviewed by Tim Horton.
1896
1897         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1898         match my observations when using the simulator to simulate iOS 12 and add support for testing
1899         right-hand side modifiers.
1900
1901         * DumpRenderTree/mac/EventSendingController.mm:
1902         (modifierFlags):
1903         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1904         (-[EventSendingController setTouchModifier:value:]):
1905         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1906         (hidUsageCodeForCharacter):
1907
1908 2018-11-02  Chris Dumez  <cdumez@apple.com>
1909
1910         [PSON] Reuse SuspendedPages' process when possible, for performance
1911         https://bugs.webkit.org/show_bug.cgi?id=191166
1912
1913         Reviewed by Geoffrey Garen.
1914
1915         Add API test coverage.
1916
1917         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1918
1919 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1920
1921         [LFC][IFC] Add support for intrinsic width calculation
1922         https://bugs.webkit.org/show_bug.cgi?id=191144
1923
1924         Reviewed by Antti Koivisto.
1925
1926         * LayoutReloaded/misc/LFC-passing-tests.txt:
1927
1928 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1929
1930         [Apache] Self-signed SSL certificate RSA key is considered too weak
1931         https://bugs.webkit.org/show_bug.cgi?id=191156
1932
1933         Reviewed by Michael Catanzaro.
1934
1935         * Scripts/webkitpy/common/system/pemfile.py:
1936
1937 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1938
1939         Unreviewed follow-up to r237678.
1940
1941         * wpe/jhbuild.modules: The patch element apparently has to be a child
1942         of the branch in order for Jhbuild to properly detect and apply the
1943         patch file.
1944
1945 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1946
1947         build-jsc --wincairo should update WinCairo libraries
1948         https://bugs.webkit.org/show_bug.cgi?id=191170
1949
1950         Reviewed by Fujii Hironori.
1951
1952         * Scripts/build-jsc:
1953
1954 2018-11-01  John Wilander  <wilander@apple.com>
1955
1956         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1957         https://bugs.webkit.org/show_bug.cgi?id=191119
1958         <rdar://problem/44176965>
1959
1960         Reviewed by Chris Dumez.
1961
1962         This is an API test for a WebKitLegacy WebView that is first closed and then
1963         JavaScript is handed a keyboard event.
1964
1965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1966         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1967         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1968         (-[KeyboardEventListener handleEvent:]):
1969         (TestWebKitAPI::TEST):
1970
1971 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1972
1973         Add a storage limit for IndexedDB
1974         https://bugs.webkit.org/show_bug.cgi?id=190598
1975         <rdar://problem/44654715>
1976
1977         Reviewed by Chris Dumez.
1978
1979         Add API for testing.
1980
1981         * DumpRenderTree/TestRunner.cpp:
1982         (setIDBPerOriginQuotaCallback):
1983         (TestRunner::staticFunctions):
1984         * DumpRenderTree/TestRunner.h:
1985         * DumpRenderTree/mac/TestRunnerMac.mm:
1986         (TestRunner::setIDBPerOriginQuota):
1987         * DumpRenderTree/win/TestRunnerWin.cpp:
1988         (TestRunner::setIDBPerOriginQuota):
1989         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1990         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1991         (WTR::TestRunner::setIDBPerOriginQuota):
1992         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1993         * WebKitTestRunner/TestController.cpp:
1994         (WTR::TestController::setIDBPerOriginQuota):
1995         * WebKitTestRunner/TestController.h:
1996         * WebKitTestRunner/TestInvocation.cpp:
1997         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1998
1999 2018-11-01  Chris Dumez  <cdumez@apple.com>
2000
2001         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
2002         https://bugs.webkit.org/show_bug.cgi?id=191076
2003
2004         Reviewed by Geoffrey Garen.
2005
2006         Add API test coverage.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2009         (-[PSONNavigationDelegate init]):
2010         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2011
2012 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
2013
2014         Fix build with VIDEO and WEB_AUDIO disabled
2015         https://bugs.webkit.org/show_bug.cgi?id=191147
2016         <rdar://problem/45726710>
2017
2018         Unreviewed build fix.
2019
2020         This adds the missing compilation guards in the WPE MiniBrowser.
2021
2022         * MiniBrowser/wpe/main.cpp:
2023         (main): Condition GST includes and calls.
2024
2025 2018-10-31  Zalan Bujtas  <zalan@apple.com>
2026
2027         [LFC][IFC] Add support for inline-block elements.
2028         https://bugs.webkit.org/show_bug.cgi?id=191143
2029
2030         Reviewed by Antti Koivisto.
2031
2032         * LayoutReloaded/misc/LFC-passing-tests.txt:
2033
2034 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2035
2036         [WPE] Add missing libsoup patch to jhbuild
2037         https://bugs.webkit.org/show_bug.cgi?id=191149
2038
2039         Reviewed by Žan Doberšek.
2040
2041         * wpe/jhbuild.modules:
2042         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2043
2044 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2045
2046         Fix build with VIDEO and WEB_AUDIO disabled
2047         https://bugs.webkit.org/show_bug.cgi?id=191147
2048
2049         Reviewed by Philippe Normand.
2050
2051         * MiniBrowser/gtk/main.c:
2052         (main): Condition GST includes and calls
2053
2054 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
2055
2056         Add Justin Michaud to the list of WebKit Committers
2057         https://bugs.webkit.org/show_bug.cgi?id=191142
2058
2059         * Scripts/webkitpy/common/config/contributors.json:
2060
2061 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
2062
2063         Don't run JIT tests on 32-bit platforms
2064         https://bugs.webkit.org/show_bug.cgi?id=191074
2065
2066         Reviewed by Michael Catanzaro.
2067
2068         * Scripts/run-jsc-stress-tests:
2069
2070 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
2073         https://bugs.webkit.org/show_bug.cgi?id=190530
2074         <rdar://problem/45232149>
2075
2076         Reviewed by Tim Horton.
2077
2078         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
2079         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
2080         is equivalent to the original file wrappers used to insert attachments in the first web view.
2081
2082         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
2083         is still backed by the same NSFileWrapper instance.
2084
2085         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2086         (TestWebKitAPI::TEST):
2087
2088 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2089
2090         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2091         https://bugs.webkit.org/show_bug.cgi?id=190949
2092
2093         Reviewed by Alex Christensen.
2094
2095         Visual Studio 2017 Community is the alternative.
2096
2097         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2098         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2099         (buildVisualStudioProject): Ditto.
2100         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2101         (usingVisualStudioExpress): Deleted.
2102
2103 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2104
2105         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2106         https://bugs.webkit.org/show_bug.cgi?id=191093
2107         <rdar://problem/45685706>
2108
2109         Unreviewed build fix.
2110
2111         error C2065: 'renderTarget': undeclared identifier
2112
2113         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2114         (createBitmapContextFromWebView): Restored the previous implementation.
2115
2116 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2117
2118         [PlayStation] Enable JavaScriptCore
2119         https://bugs.webkit.org/show_bug.cgi?id=191072
2120
2121         Reviewed by Brent Fulgham.
2122
2123         Add platform scripts for building the PlayStation port.
2124         perl Tools/Scripts/build-webkit --playstation
2125
2126         * Scripts/build-webkit:
2127         * Scripts/build-webkittestrunner:
2128         * Scripts/webkitdirs.pm:
2129         (argumentsForConfiguration):
2130         (determineConfigurationProductDir):
2131         (isPlayStation): Added.
2132         (getMSBuildPlatformArgument): Added.
2133         (buildVisualStudioProject):
2134         (wrapperPrefixIfNeeded):
2135         (generateBuildSystemFromCMakeProject):
2136         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2137
2138 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2139
2140         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2141         https://bugs.webkit.org/show_bug.cgi?id=191093
2142         <rdar://problem/45685706>
2143
2144         Reviewed by Alex Christensen.
2145
2146         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2147         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2148         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2149         (pixelDumpSystemFactory): Added.
2150         (printPNG): Create stub.
2151         (computeMD5HashStringForBitmapContext): Ditto.
2152         (dumpBitmap): Ditto.
2153         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2154         (BitmapContext::createByAdoptingBitmapAndContext):
2155         (BitmapContext::~BitmapContext):
2156         (BitmapContext::platformContext const):
2157         (BitmapContext::BitmapContext):
2158         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2159         (createBitmapContextFromWebView): Update to support Direct2D.
2160         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2161         logo is no longer available at this location. Switch to the new logo.
2162
2163 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2164
2165         webkitpy: Support alternate simctl list outputs
2166         https://bugs.webkit.org/show_bug.cgi?id=191090
2167         <rdar://problem/45684255>
2168
2169         Rubber-stamped by Aakash Jain.
2170
2171         * Scripts/webkitpy/xcode/simulated_device.py:
2172         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2173         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2174         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2175         (test_available_devices): Add iOS 12 with alternative availability format.
2176
2177 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2178
2179         Clean up some obsolete MAX_ALLOWED macros
2180         https://bugs.webkit.org/show_bug.cgi?id=190916
2181
2182         Reviewed by Tim Horton.
2183
2184         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2185         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2186         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2187
2188 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2189
2190         [GTK][WPE] Fixes to the PublicSuffix implementation
2191         https://bugs.webkit.org/show_bug.cgi?id=191031
2192
2193         Reviewed by Michael Catanzaro.
2194
2195         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2196         (TestWebKitAPI::TEST_F): Remove a test for a domain
2197         that is not registrable and shouldn't be tested there.
2198
2199 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2200
2201         Modernize WebKit nibs and lprojs for localization's sake
2202         https://bugs.webkit.org/show_bug.cgi?id=190911
2203         <rdar://problem/45349466>
2204
2205         Reviewed by Dan Bernstein.
2206
2207         * Scripts/check-inspector-strings:
2208         * Scripts/update-webkit-localizable-strings:
2209         * gtk/manifest.txt.in:
2210         * wpe/manifest.txt.in:
2211         English->en
2212
2213 2018-10-29  Daniel Bates  <dabates@apple.com>
2214
2215         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2216         https://bugs.webkit.org/show_bug.cgi?id=191036
2217
2218         Reviewed by Andy Estes.
2219
2220         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2221         by an enum that contains two or more enumerators with the same value. For example, suppose
2222         you have the following enum:
2223
2224         enum Flag {
2225             A = 1 << 0,
2226             AAlias = A,
2227         };
2228
2229         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2230         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2231         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2232         tend to be used in bounds checks as opposed to code that adds to a set.
2233
2234         * lldb/lldbWebKitTester/main.cpp:
2235         (testSummaryProviders):
2236         * lldb/lldb_webkit.py:
2237         (WTFOptionSetProvider.update):
2238         * lldb/lldb_webkit_unittest.py:
2239         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2240         (TestSummaryProviders):
2241         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2242
2243 2018-10-29  Daniel Bates  <dabates@apple.com>
2244
2245         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2246         https://bugs.webkit.org/show_bug.cgi?id=191033
2247
2248         Reviewed by Andy Estes.
2249
2250         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2251         We display the same details in the summary for a Frame because its Document tends to be the most
2252         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2253         and whether the origin has universal access.
2254
2255         * lldb/lldb_webkit.py:
2256         (__lldb_init_module):
2257         Register new summary providers.
2258
2259         (WebCoreSecurityOrigin_SummaryProvider):
2260         (WebCoreFrame_SummaryProvider):
2261         (WebCoreDocument_SummaryProvider):
2262         Add new summary providers.
2263
2264         (StdOptionalWrapper):
2265         (StdOptionalWrapper.__init__):
2266         (StdOptionalWrapper.has_value):
2267         (StdOptionalWrapper.value):
2268         Convenience data type that provides access to the fields of a std::optional<>.
2269         
2270         (WebCoreSecurityOriginProvider):
2271         (WebCoreSecurityOriginProvider.__init__):
2272         (WebCoreSecurityOriginProvider.is_unique):
2273         (WebCoreSecurityOriginProvider.scheme):
2274         (WebCoreSecurityOriginProvider.host):
2275         (WebCoreSecurityOriginProvider.port):
2276         (WebCoreSecurityOriginProvider.domain):
2277         (WebCoreSecurityOriginProvider.has_universal_access):
2278         (WebCoreSecurityOriginProvider.to_string):
2279         (WebCoreFrameProvider):
2280         (WebCoreFrameProvider.__init__):
2281         (WebCoreFrameProvider.is_main_frame):
2282         (WebCoreFrameProvider.document):
2283         (WebCoreDocumentProvider):
2284         (WebCoreDocumentProvider.__init__):
2285         (WebCoreDocumentProvider.url):
2286         (WebCoreDocumentProvider.origin):
2287         (WebCoreDocumentProvider.page_cache_state):
2288         (WebCoreDocumentProvider.frame):
2289
2290 2018-10-29  Chris Dumez  <cdumez@apple.com>
2291
2292         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
2293         https://bugs.webkit.org/show_bug.cgi?id=190975
2294         <rdar://problem/45059256>
2295
2296         Reviewed by Antti Koivisto.
2297
2298         Add API test coverage.
2299
2300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2301
2302 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2303
2304         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
2305         https://bugs.webkit.org/show_bug.cgi?id=191018
2306
2307         Reviewed by Antti Koivisto.
2308
2309         * LayoutReloaded/misc/LFC-passing-tests.txt:
2310
2311 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2312
2313         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
2314         https://bugs.webkit.org/show_bug.cgi?id=191011
2315
2316         Reviewed by Antti Koivisto.
2317
2318         * LayoutReloaded/misc/LFC-passing-tests.txt:
2319
2320 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2321
2322         Missing from r237549
2323
2324         Reviewed by Antti Koivisto.
2325
2326         * LayoutReloaded/misc/LFC-passing-tests.txt:
2327
2328 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2329
2330         [LFC][IFC] Add support for simple intruding floats.
2331         https://bugs.webkit.org/show_bug.cgi?id=190998
2332
2333         Reviewed by Antti Koivisto.
2334
2335         * LayoutReloaded/misc/LFC-passing-tests.txt:
2336
2337 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2338
2339         [LFC][IFC] Inline layout produces separate runs when float is present.
2340         https://bugs.webkit.org/show_bug.cgi?id=190980
2341
2342         Reviewed by Antti Koivisto.
2343
2344         * LayoutReloaded/misc/LFC-passing-tests.txt:
2345
2346 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
2347
2348         New bytecode format for JSC
2349         https://bugs.webkit.org/show_bug.cgi?id=187373
2350         <rdar://problem/44186758>
2351
2352         Reviewed by Filip Pizlo.
2353
2354         Do not force ENABLE_JIT=true when $forceCLoop is false.
2355
2356         * Scripts/build-jsc:
2357
2358 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2359
2360         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
2361
2362         Unreviewed build fix
2363
2364         The build fails because of some array-bound check related
2365         to strcmp() macro optimizations. Disabling selective Werrors
2366         when building xserver-xorg might get past this.
2367
2368         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
2369         configuration.
2370
2371 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2372
2373         [GTK] Update API test expectations after r237383
2374         https://bugs.webkit.org/show_bug.cgi?id=186913
2375
2376         Unreviewed gardening.
2377
2378         * TestWebKitAPI/glib/TestExpectations.json: Remove
2379         passing TestSSL tests.
2380
2381 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
2382
2383         [WPE] Add the WebKitVersion.h header
2384         https://bugs.webkit.org/show_bug.cgi?id=191015
2385
2386         Reviewed by Michael Catanzaro.
2387
2388         * MiniBrowser/wpe/main.cpp:
2389         (automationStartedCallback): Remove the FIXME and finally enable the
2390         webkit_application_info_set_version() call.
2391         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
2392         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
2393
2394 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2395
2396         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
2397         https://bugs.webkit.org/show_bug.cgi?id=190948
2398
2399         Reviewed by Brent Fulgham.
2400
2401         vcxproj files have been removed in Bug 154388.
2402
2403         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
2404         * Scripts/build-jsc:
2405         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
2406         which is not used because Windows ports are using CMake.
2407
2408 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
2409
2410         HashMap should support selecting a random entry
2411         https://bugs.webkit.org/show_bug.cgi?id=190814
2412
2413         Reviewed by Ryosuke Niwa.
2414
2415         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
2416         IsEvenlyDistributed to reflect the fact that we're only testing the
2417         distribution. Added a test case that covers more table densities and
2418         the remove() operation.
2419
2420 2018-10-27  Charlie Turner  <cturner@igalia.com>
2421
2422         [GTK] Add bubblewrap feature option
2423         https://bugs.webkit.org/show_bug.cgi?id=190981
2424
2425         Reviewed by Xabier Rodriguez-Calvar.
2426
2427         Without this, it was not possible to disable the bubblewrap sandbox
2428         from the webkit build scripts.
2429
2430         * Scripts/webkitperl/FeatureList.pm:
2431
2432 2018-10-26  Commit Queue  <commit-queue@webkit.org>
2433
2434         Unreviewed, rolling out r237479 and r237484.
2435         https://bugs.webkit.org/show_bug.cgi?id=190978
2436
2437         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
2438
2439         Reverted changesets:
2440
2441         "New bytecode format for JSC"
2442         https://bugs.webkit.org/show_bug.cgi?id=187373
2443         https://trac.webkit.org/changeset/237479
2444
2445         "Gardening: Build fix after r237479."
2446         https://bugs.webkit.org/show_bug.cgi?id=187373
2447         https://trac.webkit.org/changeset/237484
2448
2449 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
2450
2451         New bytecode format for JSC
2452         https://bugs.webkit.org/show_bug.cgi?id=187373
2453         <rdar://problem/44186758>
2454
2455         Reviewed by Filip Pizlo.
2456
2457         Do not force ENABLE_JIT=true when $forceCLoop is false.
2458
2459         * Scripts/build-jsc:
2460
2461 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
2462
2463         HashMap should support selecting a random entry
2464         https://bugs.webkit.org/show_bug.cgi?id=190814
2465
2466         Reviewed by Antti Koivisto.
2467
2468         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
2469         more thoroughly test for randomness.
2470
2471 2018-10-26  Antti Koivisto  <antti@apple.com>
2472
2473         hashSet.remove(hashSet.random()) doesn't build
2474         https://bugs.webkit.org/show_bug.cgi?id=190953
2475
2476         Reviewed by Chris Dumez.
2477
2478         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2479         (TestWebKitAPI::TEST):
2480
2481 2018-10-26  Zalan Bujtas  <zalan@apple.com>
2482
2483         [LFC][IFC] Layout floats as part of the inline content
2484         https://bugs.webkit.org/show_bug.cgi?id=190942
2485
2486         Reviewed by Antti Koivisto.
2487
2488         * LayoutReloaded/misc/LFC-passing-tests.txt:
2489
2490 2018-10-26  Alicia Boya García  <aboya@igalia.com>
2491
2492         [MSE][WTF][Media] Invalid MediaTime should be falsy
2493         https://bugs.webkit.org/show_bug.cgi?id=190893
2494
2495         Reviewed by Jer Noble.
2496
2497         This patch adds additional API tests for the conversions from
2498         MediaTime to boolean.
2499
2500         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2501         (TestWebKitAPI::TEST):
2502
2503 2018-10-25  Chris Dumez  <cdumez@apple.com>
2504
2505         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
2506         https://bugs.webkit.org/show_bug.cgi?id=190915
2507         <rdar://problem/45059069>
2508
2509         Reviewed by Geoffrey Garen.
2510
2511         Add API test coverage.
2512
2513         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2514
2515 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2516
2517         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
2518         https://bugs.webkit.org/show_bug.cgi?id=190896
2519
2520         Reviewed by Matt Baker.
2521
2522         * Scripts/webkitpy/common/config/watchlist:
2523
2524 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
2525
2526         HashMap should support selecting a random entry
2527         https://bugs.webkit.org/show_bug.cgi?id=190814
2528
2529         Reviewed by Antti Koivisto.
2530
2531         Unit testing is fun and easy!
2532
2533         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2534         (TestWebKitAPI::ZeroHash::hash):
2535         (TestWebKitAPI::TEST):
2536
2537 2018-10-24  Tim Horton  <timothy_horton@apple.com>
2538
2539         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
2540         https://bugs.webkit.org/show_bug.cgi?id=190897
2541
2542         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2543         (TestWebKitAPI::TEST):
2544         Disable the test for now.
2545
2546 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2547
2548         Clean up some obsolete macOS version guards
2549         https://bugs.webkit.org/show_bug.cgi?id=190887
2550
2551         Reviewed by Dan Bernstein.
2552
2553         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2554         (__simulated_forceClickAssociatedEventsMask):
2555         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2556         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2557         (WTR::initializeWebViewConfiguration):
2558         * WebKitTestRunner/mac/EventSenderProxy.mm:
2559         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2560
2561 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2562
2563         Turn on Conic Gradients
2564         https://bugs.webkit.org/show_bug.cgi?id=190810
2565
2566         Reviewed by Tim Horton.
2567
2568         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2569
2570 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
2571
2572         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
2573         https://bugs.webkit.org/show_bug.cgi?id=190328
2574
2575         Reviewed by Michael Catanzaro.
2576
2577         * TestWebKitAPI/CMakeLists.txt:
2578         * TestWebKitAPI/PlatformWPE.cmake:
2579
2580 2018-10-24  Chris Dumez  <cdumez@apple.com>
2581
2582         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
2583         https://bugs.webkit.org/show_bug.cgi?id=190846
2584         <rdar://problem/45058938>
2585
2586         Reviewed by Antti Koivisto.
2587
2588         Add API test coverage.
2589
2590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2591
2592 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
2593
2594         [GTK] TestSSL failing because of missing libsoup patch
2595         https://bugs.webkit.org/show_bug.cgi?id=190869
2596
2597         Reviewed by Michael Catanzaro.
2598
2599         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
2600         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2601
2602 2018-10-23  Justin Fan  <justin_fan@apple.com>
2603
2604         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
2605         https://bugs.webkit.org/show_bug.cgi?id=190817
2606
2607         Reviewed by Dean Jackson.
2608
2609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2610         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
2611         (TestWebKitAPI::TEST_F):
2612         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2613         (TestWebKitAPI::TEST_F):
2614         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
2615         (TestWebKitAPI::TEST_F):
2616         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2617         (TestWebKitAPI::TEST_F):
2618         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
2619         (TestWebKitAPI::TEST_F):
2620         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
2621
2622 2018-10-23  Chris Dumez  <cdumez@apple.com>
2623
2624         [PSON] Add support for cross-site client-side redirects
2625         https://bugs.webkit.org/show_bug.cgi?id=190806
2626         <rdar://problem/45047344>
2627
2628         Reviewed by Geoffrey Garen.
2629
2630         Add API test coverage.
2631
2632         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2633         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
2634         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
2635
2636 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
2637
2638         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
2639         https://bugs.webkit.org/show_bug.cgi?id=190789
2640
2641         Reviewed by Michael Catanzaro.
2642
2643         When the network process serializes certificate data to other
2644         processes through the argument coders, the certificate chain, if
2645         present, is lost. In practice this means that applications using
2646         the public API to process certificate info have no details on the
2647         certificate chain, other than the very basics included in the
2648         certificate. Serialize the entire chain if available in the
2649         certificate.
2650
2651         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2652         (testSSL): Test that the self-signed certificate has no bogus
2653         issuer certificate.
2654
2655 2018-10-22  Tim Horton  <timothy_horton@apple.com>
2656
2657         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
2658         https://bugs.webkit.org/show_bug.cgi?id=190801
2659         <rdar://problem/43674361>
2660
2661         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2662         (TEST):
2663         Use a parented WKWebView for this test, otherwise none of the assertions
2664         about gesture recognizers work anymore.
2665
2666 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
2667
2668         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
2669         https://bugs.webkit.org/show_bug.cgi?id=187972
2670
2671         Unreviewed test gardening.
2672
2673         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2674         (TestWebKitAPI::TEST): Disable the flaky test.
2675
2676 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2677
2678         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
2679         https://bugs.webkit.org/show_bug.cgi?id=190777
2680
2681         Reviewed by Tim Horton.
2682
2683         Implement isShowingDataListSuggestions on iOS. See below for more details.
2684
2685         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2686         (WTR::UIScriptController::isShowingDataListSuggestions const):
2687
2688         Add a stub implementation for DumpRenderTree.
2689
2690         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2691         (WTR::UIScriptController::isShowingDataListSuggestions const):
2692
2693         Move this stub implementation to !PLATFORM(COCOA).
2694
2695         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2696         (WTR::forEachViewInHierarchy):
2697
2698         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
2699
2700         (WTR::UIScriptController::isShowingDataListSuggestions const):
2701
2702         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
2703
2704 2018-10-19  Dan Bernstein  <mitz@apple.com>
2705
2706         [macOS] MiniBrowser has an unused injected bundle
2707         https://bugs.webkit.org/show_bug.cgi?id=190770
2708
2709         Reviewed by Tim Horton.
2710
2711         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2712         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2713           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2714         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2715         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2716         * MiniBrowser/mac/Bundle: Removed.
2717
2718 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2719
2720         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2721         https://bugs.webkit.org/show_bug.cgi?id=190621
2722         <rdar://problem/45310649>
2723
2724         Reviewed by Tim Horton.
2725
2726         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2727
2728         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2729         (WTR::UIScriptController::resignFirstResponder):
2730         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2731         (WTR::UIScriptController::resignFirstResponder):
2732         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2733         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2734         (WTR::UIScriptController::resignFirstResponder):
2735         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2736         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2737         (WTR::UIScriptController::resignFirstResponder):
2738         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2739         (WTR::PlatformWebView::makeWebViewFirstResponder):
2740
2741         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2742         responder on the WKWebView when running iOS layout tests.
2743
2744         * WebKitTestRunner/ios/TestControllerIOS.mm:
2745         (WTR::TestController::platformResetStateToConsistentValues):
2746
2747         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2748
2749 2018-10-19  Dean Jackson  <dino@apple.com>
2750
2751         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2752         https://bugs.webkit.org/show_bug.cgi?id=186946
2753         <rdar://problem/41724248>
2754
2755         Reviewed by Antoine Quint.
2756
2757         If the incoming test has different enableWebAnimationsCSSIntegration options,
2758         then we need to create a new WebView.
2759
2760         * DumpRenderTree/TestOptions.cpp:
2761         (TestOptions::webViewIsCompatibleWithOptions const):
2762
2763 2018-10-19  Charlie Turner  <cturner@igalia.com>
2764
2765         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2766         https://bugs.webkit.org/show_bug.cgi?id=190738
2767
2768         Reviewed by Xabier Rodriguez-Calvar.
2769
2770         Add a GStreamer patch to avoid crashing when the run-time logging
2771         level is TRACE. There was a missing null check which caused many
2772         tests to crash.
2773
2774         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2775
2776 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2777
2778         [Media] Use nanoseconds as MaximumTimeScale
2779         https://bugs.webkit.org/show_bug.cgi?id=190631
2780
2781         Rebased MediaTime tests covering timescales over the maximum.
2782
2783         Reviewed by Jer Noble.
2784
2785         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2786         (TestWebKitAPI::TEST):
2787
2788 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2789
2790         clean-webkit pulls in many unnecessary dependencies in webkitpy
2791         https://bugs.webkit.org/show_bug.cgi?id=190732
2792
2793         Reviewed by Alexey Proskuryakov.
2794
2795         * Scripts/webkitpy/common/host.py:
2796         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2797         (Host):
2798         (Host.bugs):
2799         (Host.bugzilla):
2800         (Host.web):
2801
2802 2018-10-18  Chris Dumez  <cdumez@apple.com>
2803
2804         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2805         https://bugs.webkit.org/show_bug.cgi?id=190721
2806         <rdar://problem/45059699>
2807
2808         Reviewed by Alex Christensen.
2809
2810         Add API test coverage.
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2813
2814 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2815
2816         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2817         https://bugs.webkit.org/show_bug.cgi?id=190729
2818
2819         Reviewed by Tim Horton.
2820
2821         * DumpRenderTree/AccessibilityController.h:
2822         * DumpRenderTree/AccessibilityTextMarker.h:
2823         * DumpRenderTree/AccessibilityUIElement.cpp:
2824         (AccessibilityUIElement::getJSClass):
2825         * DumpRenderTree/AccessibilityUIElement.h:
2826         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2827         * DumpRenderTree/TestRunner.cpp:
2828         (getSecureEventInputIsEnabledCallback):
2829         (TestRunner::staticFunctions):
2830         (TestRunner::callUIScriptCallback):
2831         * DumpRenderTree/TestRunner.h:
2832         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2833         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2834         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2835         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2836         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2837         * DumpRenderTree/ios/TextInputControllerIOS.m:
2838         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2839         * DumpRenderTree/mac/AppleScriptController.m:
2840         * DumpRenderTree/mac/DumpRenderTree.mm:
2841         (createWebViewAndOffscreenWindow):
2842         (destroyWebViewAndOffscreenWindow):
2843         (resetWebPreferencesToConsistentValues):
2844         (setDefaultsToConsistentValuesForTesting):
2845         (allocateGlobalControllers):
2846         (releaseGlobalControllers):
2847         (addTestPluginsToPluginSearchPath):
2848         (prepareConsistentTestingEnvironment):
2849         (dumpRenderTree):
2850         (DumpRenderTreeMain):
2851         (dumpFrameAsPDF):
2852         (dumpBackForwardListForAllWindows):
2853         (updateDisplay):
2854         (dump):
2855         (resetWebViewToConsistentStateBeforeTesting):
2856         (runTest):
2857         (displayWebView):
2858         (displayAndTrackRepaintsWebView):
2859         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2860         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2861         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2862         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2863         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2864         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2865         (-[DumpRenderTreeWindow close]):
2866         (-[DumpRenderTreeWindow webView]):
2867         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2868         * DumpRenderTree/mac/EventSendingController.h:
2869         * DumpRenderTree/mac/EventSendingController.mm:
2870         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2871         (+[EventSendingController webScriptNameForSelector:]):
2872         (-[EventSendingController dealloc]):
2873         (-[EventSendingController currentEventTime]):
2874         (-[EventSendingController clearKillRing]):
2875         (modifierFlags):
2876         (-[EventSendingController mouseDown:withModifiers:]):
2877         (-[EventSendingController scalePageBy:atX:andY:]):
2878         (-[EventSendingController mouseUp:withModifiers:]):
2879         (-[EventSendingController mouseMoveToX:Y:]):
2880         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2881         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2882         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2883         (-[FrameLoadDelegate init]):
2884         (-[FrameLoadDelegate dealloc]):
2885         (-[FrameLoadDelegate processWork:]):
2886         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2887         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2888         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2889         * DumpRenderTree/mac/LayoutTestHelper.m:
2890         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2891         (-[MockGeolocationProvider timerFired]):
2892         * DumpRenderTree/mac/TestRunnerMac.mm:
2893         (TestRunner::setMainFrameIsFirstResponder):
2894         (TestRunner::setAutomaticLinkDetectionEnabled):
2895         (TestRunner::setUseDashboardCompatibilityMode):
2896         (TestRunner::isCommandEnabled):
2897         (TestRunner::inspectorTestStubURL):
2898         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2899         (TestRunner::abortModal):
2900         (TestRunner::setTextDirection):
2901         (TestRunner::addChromeInputField):
2902         (TestRunner::removeChromeInputField):
2903         (TestRunner::focusWebView):
2904         (TestRunner::setBackingScaleFactor):
2905         (TestRunner::imageCountInGeneralPasteboard const):
2906         * DumpRenderTree/mac/UIDelegate.h:
2907         * DumpRenderTree/mac/UIDelegate.mm:
2908         (-[UIDelegate modalWindowWillClose:]):
2909         (-[UIDelegate webViewRunModal:]):
2910         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2911         (-[UIDelegate dealloc]):
2912         * Scripts/check-for-inappropriate-objc-class-names:
2913         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2914         * TestRunnerShared/spi/UIKitTestSPI.h:
2915         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2916         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2917         (WebCore::operator<<):
2918         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2919         (TestWebKitAPI::TEST):
2920         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2921         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2922         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2923         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2924         (TestWebKitAPI::TEST):
2925         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2926         (TestWebKitAPI::TEST):
2927         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2928         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2929         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2930         (TEST):
2931         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2932         (TEST):
2933         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2934         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2935         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2936         (TEST):
2937         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2938         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2939         (createWebViewWithCustomPasteboardDataEnabled):
2940         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2941         (TEST):
2942         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2943         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2944         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2945         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2946         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2947         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2948         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2949         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2950         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2951         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2952         (defaultWebsiteCacheDirectory):
2953         (defaultApplicationCacheDirectory):
2954         (TEST):
2955         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2956         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2957         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2958         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2959         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2960         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2961         (TestWebKitAPI::TEST):
2962         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2963         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2964         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2965         (runTestWithWidth):
2966         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2967         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2968         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2969         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2970         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2971         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2972         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2973         (platformCopyRichTextWithMultipleAttachments):
2974         (platformCopyRichTextWithImage):
2975         (platformCopyPNG):
2976         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2977         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2978         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2979         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2980         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2981         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2982         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2983         (TEST):
2984         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2985         (TEST):
2986         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2987         (TEST):
2988         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2989         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2990         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2991         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2992         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2993         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2994         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2995         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2996         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2997         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2998         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2999         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3000         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
3001         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3002         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3003         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
3004         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3005         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
3006         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
3007         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3008         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
3009         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3010         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3011         (-[WKWebView _test_waitForDidFinishNavigation]):
3012         * TestWebKitAPI/cocoa/TestWKWebView.h:
3013         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3014         * TestWebKitAPI/config.h:
3015         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3016         * TestWebKitAPI/ios/TestWKWebViewController.h:
3017         * TestWebKitAPI/ios/TestWKWebViewController.mm:
3018         * TestWebKitAPI/ios/UIKitSPI.h:
3019         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3020         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3021         (WTR::InjectedBundle::beginTesting):
3022         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3023         (WTR::TestRunner::inspectorTestStubURL):
3024         * WebKitTestRunner/TestController.cpp:
3025         (WTR::TestController::webProcessName):
3026         (WTR::TestController::networkProcessName):
3027         * WebKitTestRunner/TestInvocation.cpp:
3028         (WTR::TestInvocation::invoke):
3029         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3030         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3031         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3032         (WTR::initializeWebViewConfiguration):
3033         (WTR::TestController::platformCreateWebView):
3034         (WTR::TestController::imageCountInGeneralPasteboard const):
3035         (WTR::TestController::addTestKeyToKeychain):
3036         (WTR::TestController::cleanUpKeychain):
3037         (WTR::TestController::keyExistsInKeychain):
3038         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3039         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3040         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3041
3042 2018-10-18  Chris Dumez  <cdumez@apple.com>
3043
3044         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
3045         https://bugs.webkit.org/show_bug.cgi?id=190688
3046         <rdar://problem/45354095>
3047
3048         Reviewed by Antti Koivisto.
3049
3050         Extended API test coverage to confirm that:
3051         - We do not accumulate more than 3 suspended processes.
3052         - We can navigate back 3 times and use the page cache for each of these loads.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3055
3056 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3057
3058         Enable the datalist element by default on iOS and macOS
3059         https://bugs.webkit.org/show_bug.cgi?id=190594
3060         <rdar://problem/45281159>
3061
3062         Reviewed by Ryosuke Niwa and Tim Horton.
3063
3064         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3065
3066 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
3067
3068         AX: Certain tags should identify their context to iOS API
3069         https://bugs.webkit.org/show_bug.cgi?id=190622
3070         <rdar://problem/45308194>
3071
3072         Reviewed by Zalan Bujtas.
3073
3074         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3075         (AccessibilityUIElement::stringAttributeValue):
3076         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3077         (WTR::AccessibilityUIElement::stringAttributeValue):
3078
3079 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
3080
3081         Add a switch for Web SQL
3082         https://bugs.webkit.org/show_bug.cgi?id=190271
3083
3084         Reviewed by Ryosuke Niwa.
3085
3086         * WebKitTestRunner/TestController.cpp:
3087         (WTR::TestController::resetPreferencesToConsistentValues):
3088
3089 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3090
3091         Remove InjectedBundleBackForwardList
3092         https://bugs.webkit.org/show_bug.cgi?id=190640
3093
3094         Reviewed by Chris Dumez.
3095
3096         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3097         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3099         (WTR::InjectedBundlePage::prepare):
3100         (WTR::InjectedBundlePage::dumpHistory):
3101         (WTR::hasPrefix): Deleted.
3102         (WTR::compareByTargetName): Deleted.
3103         (WTR::dumpBackForwardListItem): Deleted.
3104         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3107         (WTR::TestRunner::clearBackForwardList):
3108
3109 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3110
3111         Unreviewed, added myself to contributors.json.
3112
3113         * Scripts/webkitpy/common/config/contributors.json:
3114
3115 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3116
3117         Implement feature flag and bindings for CSS Painting API
3118         https://bugs.webkit.org/show_bug.cgi?id=190237
3119
3120         Reviewed by Ryosuke Niwa.
3121
3122         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3123
3124 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3125
3126         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
3127
3128         * gstreamer/jhbuild.modules:
3129
3130 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3131
3132         [GTK][JHBuild] Disable libmount support in glib
3133
3134         Rubber-stamped by Alejandro G. Castro.
3135
3136         This feature doesn't seem required for our setup.
3137
3138         * gtk/jhbuild.modules:
3139
3140 2018-10-15  Justin Fan  <justin_fan@apple.com>
3141
3142         Add WebGPU 2018 feature flag and experimental feature flag
3143         https://bugs.webkit.org/show_bug.cgi?id=190509
3144
3145         Reviewed by Dean Jackson.
3146
3147         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3148         for the 2018 WebGPU prototype.
3149
3150         * DumpRenderTree/TestOptions.cpp:
3151         (TestOptions::TestOptions):
3152         * DumpRenderTree/TestOptions.h:
3153         * DumpRenderTree/mac/DumpRenderTree.mm:
3154         (setWebPreferencesForTestOptions):
3155         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3156
3157 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3158
3159         Update bot configuration for Sierra archive queues
3160         https://bugs.webkit.org/show_bug.cgi?id=190605
3161
3162         Reviewed by Aakash Jain.
3163
3164         * BuildSlaveSupport/build.webkit.org-config/config.json:
3165
3166 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3167
3168         Add support for prefers-color-scheme media query
3169         https://bugs.webkit.org/show_bug.cgi?id=190499
3170         rdar://problem/45212025
3171
3172         Reviewed by Dean Jackson.
3173
3174         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
3175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3176
3177 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3178
3179         [JHBuild] Add xdg-dbus-proxy module
3180         https://bugs.webkit.org/show_bug.cgi?id=190589
3181
3182         Reviewed by Michael Catanzaro.
3183
3184         * gtk/jhbuild.modules:
3185
3186 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3187
3188         [GTK] Add new sandboxing dependencies to install-dependencies
3189         https://bugs.webkit.org/show_bug.cgi?id=190588
3190
3191         Reviewed by Michael Catanzaro.
3192
3193         * gtk/install-dependencies:
3194
3195 2018-10-15  Chris Dumez  <cdumez@apple.com>
3196
3197         Experiment: target=_blank on anchors should imply rel=noopener
3198         https://bugs.webkit.org/show_bug.cgi?id=190481
3199
3200         Reviewed by Alex Christensen.
3201
3202         Add API test coverage to make sure we can now swap process when target=_blank
3203         is specified on an anchor but rel=noopener is not.
3204
3205         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3206
3207 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3208
3209         [iOS] Can't select text after dismissing the keyboard when changing focus
3210         https://bugs.webkit.org/show_bug.cgi?id=190563
3211         <rdar://problem/44613559>
3212
3213         Reviewed by Tim Horton.
3214
3215         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3216         (WTR::UIScriptController::isShowingKeyboard const):
3217
3218         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
3219         details.
3220
3221         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3222         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3223         (WTR::UIScriptController::isShowingKeyboard const):
3224         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3225         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3226         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3227
3228         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
3229         `isShowingKeyboard` as the getter method.
3230
3231         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3232         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3233         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3234         (WTR::UIScriptController::isShowingKeyboard const):
3235
3236 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3237
3238         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
3239
3240         * Scripts/run-javascriptcore-tests:
3241         (runJSCStressTests): Remove wsl-tests.yaml.
3242
3243 2018-10-15  Christopher Reid  <chris.reid@sony.com>
3244
3245         [Curl][WinCairo] Add Public Suffix support to WinCairo
3246         https://bugs.webkit.org/show_bug.cgi?id=183060
3247
3248         Reviewed by Alex Christensen.
3249
3250         Share mac's PublicSuffix tests with all ports.
3251
3252         * TestWebKitAPI/PlatformWin.cmake:
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3255         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
3256
3257 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
3258
3259         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
3260         https://bugs.webkit.org/show_bug.cgi?id=190555
3261
3262         Unreviewed.
3263
3264         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
3265
3266         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
3267         * WebGPUShadingLanguageRI/All.js: Removed.
3268         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
3269         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
3270         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
3271         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
3272         * WebGPUShadingLanguageRI/Assignment.js: Removed.
3273         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
3274         * WebGPUShadingLanguageRI/Block.js: Removed.
3275         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
3276         * WebGPUShadingLanguageRI/Break.js: Removed.
3277         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
3278         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
3279         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
3280         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
3281         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
3282         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
3283         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
3284         * WebGPUShadingLanguageRI/Casts.js: Removed.
3285         * WebGPUShadingLanguageRI/Check.js: Removed.
3286         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
3287         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
3288         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
3289         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
3290         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
3291         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
3292         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
3293         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
3294         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
3295         * WebGPUShadingLanguageRI/Checker.js: Removed.
3296         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
3297         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
3298         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
3299         * WebGPUShadingLanguageRI/Continue.js: Removed.
3300         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
3301         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
3302         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
3303         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
3304         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
3305         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
3306         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
3307         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
3308         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
3309         * WebGPUShadingLanguageRI/EPtr.js: Removed.
3310         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
3311         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
3312         * WebGPUShadingLanguageRI/EnumType.js: Removed.
3313         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
3314         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
3315         * WebGPUShadingLanguageRI/Expression.js: Removed.
3316         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
3317         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
3318         * WebGPUShadingLanguageRI/Field.js: Removed.
3319         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
3320         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
3321         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
3322         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
3323         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
3324         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
3325         * WebGPUShadingLanguageRI/Func.js: Removed.
3326         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
3327         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
3328         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
3329         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
3330         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
3331         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
3332         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
3333         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
3334         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
3335         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
3336         * WebGPUShadingLanguageRI/Inline.js: Removed.
3337         * WebGPUShadingLanguageRI/Inliner.js: Removed.
3338         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
3339         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
3340         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
3341         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
3342         * WebGPUShadingLanguageRI/Lexer.js: Removed.
3343         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
3344         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
3345         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
3346         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
3347         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
3348         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
3349         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
3350         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
3351         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
3352         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
3353         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
3354         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
3355         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
3356         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
3357         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
3358         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
3359         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
3360         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
3361         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
3362         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
3363         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
3364         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
3365         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
3366         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
3367         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
3368         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
3369         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
3370         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
3371         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
3372         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
3373         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
3374         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
3375         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
3376         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
3377         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
3378         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
3379         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
3380         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
3381         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
3382         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
3383         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
3384         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
3385         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
3386         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
3387         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
3388         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
3389         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
3390         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
3391         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
3392         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
3393         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
3394         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
3395         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
3396         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
3397         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
3398         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
3399         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
3400         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
3401         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
3402         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
3403         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
3404         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
3405         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
3406         * WebGPUShadingLanguageRI/NameContext.js: Removed.
3407         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
3408         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
3409         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
3410         * WebGPUShadingLanguageRI/NativeType.js: Removed.
3411         * WebGPUShadingLanguageRI/Node.js: Removed.
3412         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
3413         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
3414         * WebGPUShadingLanguageRI/NullType.js: Removed.
3415         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
3416         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
3417         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
3418         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
3419         * WebGPUShadingLanguageRI/Parse.js: Removed.
3420         * WebGPUShadingLanguageRI/Prepare.js: Removed.
3421         * WebGPUShadingLanguageRI/Program.js: Removed.
3422         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
3423         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
3424         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
3425         * WebGPUShadingLanguageRI/PtrType.js: Removed.
3426         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
3427         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
3428         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
3429         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
3430         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
3431         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
3432         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
3433         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
3434         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
3435         * WebGPUShadingLanguageRI/Return.js: Removed.
3436         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
3437         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
3438         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
3439         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
3440         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
3441         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
3442         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
3443         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
3444         * WebGPUShadingLanguageRI/Sampler.js: Removed.
3445         * WebGPUShadingLanguageRI/Semantic.js: Removed.
3446         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
3447         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
3448         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
3449         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
3450         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
3451         * WebGPUShadingLanguageRI/StructType.js: Removed.
3452         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
3453         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
3454         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
3455         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
3456         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
3457         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
3458         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
3459         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
3460         * WebGPUShadingLanguageRI/Test.html: Removed.
3461         * WebGPUShadingLanguageRI/Test.js: Removed.
3462         * WebGPUShadingLanguageRI/Texture.js: Removed.
3463         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
3464         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
3465         * WebGPUShadingLanguageRI/Type.js: Removed.
3466         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
3467         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
3468         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
3469         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
3470         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
3471         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
3472         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
3473         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
3474         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
3475         * WebGPUShadingLanguageRI/Value.js: Removed.
3476         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
3477         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
3478         * WebGPUShadingLanguageRI/VectorType.js: Removed.
3479         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
3480         * WebGPUShadingLanguageRI/Visitor.js: Removed.
3481         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
3482         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
3483         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
3484         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
3485         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
3486         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
3487         * WebGPUShadingLanguageRI/index.html: Removed.
3488         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
3489         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
3490
3491 2018-10-15  Philippe Normand  <pnormand@igalia.com>
3492
3493         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
3494         https://bugs.webkit.org/show_bug.cgi?id=190581
3495
3496         Reviewed by Michael Catanzaro.
3497
3498         These bots don't use JHBuild and their host GStreamer version is
3499         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
3500
3501         * BuildSlaveSupport/build.webkit.org-config/config.json:
3502
3503 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3504
3505         Use pragma once in WTF
3506         https://bugs.webkit.org/show_bug.cgi?id=190527
3507
3508         Reviewed by Chris Dumez.
3509
3510         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
3511
3512         * DumpRenderTree/TestRunner.cpp:
3513         (TestRunner::queueLoadHTMLString):
3514         (TestRunner::queueLoadAlternateHTMLString):
3515         (TestRunner::queueBackNavigation):
3516         (TestRunner::queueForwardNavigation):
3517         (TestRunner::queueLoadingScript):
3518         (TestRunner::queueNonLoadingScript):
3519         (TestRunner::queueReload):
3520         * DumpRenderTree/WorkQueue.cpp:
3521         (WorkQueue::singleton): Deleted.
3522         (WorkQueue::WorkQueue): Deleted.
3523         (WorkQueue::queue): Deleted.
3524         (WorkQueue::dequeue): Deleted.
3525         (WorkQueue::count): Deleted.
3526         (WorkQueue::clear): Deleted.
3527         (WorkQueue::processWork): Deleted.
3528         * DumpRenderTree/WorkQueue.h:
3529         (WorkQueue::setFrozen): Deleted.
3530         * DumpRenderTree/WorkQueueItem.h:
3531         * DumpRenderTree/mac/DumpRenderTree.mm:
3532         (runTest):
3533         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3534         (-[FrameLoadDelegate processWork:]):
3535         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3536         * DumpRenderTree/mac/TestRunnerMac.mm:
3537         (TestRunner::notifyDone):
3538         (TestRunner::forceImmediateCompletion):
3539         (TestRunner::queueLoad):
3540         * DumpRenderTree/win/DumpRenderTree.cpp:
3541         (runTest):
3542         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3543         (FrameLoadDelegate::processWork):
3544         (FrameLoadDelegate::locationChangeDone):
3545         * DumpRenderTree/win/TestRunnerWin.cpp:
3546         (TestRunner::notifyDone):
3547         (TestRunner::forceImmediateCompletion):
3548         (TestRunner::queueLoad):
3549
3550 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3551
3552         [JSC] Remove Option::useAsyncIterator
3553         https://bugs.webkit.org/show_bug.cgi?id=190567
3554
3555         Reviewed by Saam Barati.
3556
3557         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3558
3559 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
3560
3561         [WPE] Silence a unused-parameter warning
3562
3563         Unreviewed.
3564         * MiniBrowser/wpe/main.cpp:
3565         (decidePermissionRequest):
3566
3567 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
3568
3569         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
3570         https://bugs.webkit.org/show_bug.cgi?id=190537
3571
3572         Reviewed by Alexey Proskuryakov.
3573
3574         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
3575         needs to be split before adding it to the command since it is treated
3576         as a list of args.
3577
3578         * Scripts/webkitpy/common/config/ports.py:
3579         (DeprecatedPort.run_javascriptcore_tests_command):
3580
3581 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3582
3583         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
3584         https://bugs.webkit.org/show_bug.cgi?id=190504
3585         <rdar://problem/45117760>
3586
3587         Reviewed by Tim Horton.
3588
3589         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
3590         macOS and iOS.
3591
3592         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3593         (WTR::UIScriptController::setViewScale):
3594         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3595         (WTR::UIScriptController::setViewScale):
3596         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3597         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3598         (WTR::UIScriptController::setViewScale):
3599         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3600         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
3601
3602         Add a new file for UIScriptController methods on Cocoa platforms.
3603
3604         (WTR::UIScriptController::setViewScale):
3605         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3606         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3607         (WTR::TestController::cocoaResetStateToConsistentValues):
3608
3609         Ensure that _viewScale is reset to 1 after running a layout test.
3610
3611 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
3612
3613         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
3614         https://bugs.webkit.org/show_bug.cgi?id=190536
3615
3616         Reviewed by Alexey Proskuryakov.
3617
3618         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
3619
3620 2018-10-11  Youenn Fablet  <youenn@apple.com>
3621
3622         IOS 12 - Service worker cache not shared when added to homescreen
3623         https://bugs.webkit.org/show_bug.cgi?id=190269
3624         <rdar://problem/45009961>
3625
3626         Reviewed by Alex Christensen.
3627
3628         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3629         Add test to ensure that CacheStorage use the default website data store parameters.
3630
3631 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3632
3633         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
3634         https://bugs.webkit.org/show_bug.cgi?id=190476
3635         <rdar://problem/32757191>
3636
3637         Reviewed by Megan Gardner.
3638
3639         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
3640         (TEST):
3641         Add a test that we don't crash.
3642
3643 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3644
3645         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
3646
3647         * Scripts/webkitpy/tool/steps/options.py:
3648         (Options):
3649         Fix the name of the variable that the --cc-radar option writes into.
3650
3651 2018-10-10  Dean Jackson  <dino@apple.com>
3652
3653         Add --cc-radar option to webkit-patch bug creation
3654         https://bugs.webkit.org/show_bug.cgi?id=190451
3655         <rdar://problem/45176671>
3656
3657         Reviewed by Antoine Quint.
3658
3659         Add a new command line option to automatically
3660         CC radar to new or updated bugs.
3661
3662         * Scripts/webkitpy/tool/commands/commandtest.py:
3663         (CommandsTest.assert_execute_outputs):
3664         * Scripts/webkitpy/tool/commands/upload.py:
3665         (CreateBug.__init__):
3666         (CreateBug.execute):
3667         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3668         (test_prepare_with_cc):
3669         (test_prepare_with_radar):
3670         (test_prepare_with_cc_and_radar):
3671         * Scripts/webkitpy/tool/steps/createbug.py:
3672         (CreateBug.options):
3673         (CreateBug.run):
3674         * Scripts/webkitpy/tool/steps/options.py:
3675         (Options):
3676
3677 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
3678
3679         [GStreamer] Do not build gstgtk plugins
3680         https://bugs.webkit.org/show_bug.cgi?id=190463
3681
3682         Reviewed by Xabier Rodriguez-Calvar.
3683
3684         These plugins pull a GTK+ dependency that, at least in WPE,
3685         is unnecessary. The GTK+ port doesn't need it either, as far
3686         as I can tell.
3687
3688         * gstreamer/jhbuild.modules: Disable gstgtk plugins
3689
3690 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
3691
3692         [GTK][WPE] Add mediaDevices.enumerateDevices support
3693         https://bugs.webkit.org/show_bug.cgi?id=185761
3694
3695         Reviewed by Youenn Fablet.
3696
3697         Added new API test for the mediaDevices.enumerateDevices:
3698         usermedia-enumeratedevices-permission-check. And a new API test
3699         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
3700
3701         * MiniBrowser/gtk/main.c:
3702         (gotWebsiteDataCallback): Added a new section to the about:data
3703         webpage to include the information about the hash salt.
3704         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3705         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
3706         new test checking the enumerateDevices API when permission is
3707         denied and when permission is allowed for the origin.
3708         (beforeAll): Defined the new test.
3709         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3710         (serverCallback): Register a new URI for the enumerateDevices.
3711         (testWebsiteDataConfiguration): Remove the hash salts from the
3712         directories.
3713         (testWebsiteDataDeviceIdHashSalt): New test cheking the
3714         enumerateDevices API.
3715         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
3716         the init structure.
3717         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3718         (WebViewTest::initializeWebView): Make sure the media-stream is
3719         activated in the webView.
3720
3721 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3722
3723         Add WinCairo to the flakiness dashboard
3724         https://bugs.webkit.org/show_bug.cgi?id=188345
3725
3726         Reviewed by Lucas Forschler.
3727
3728         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
3729         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
3730
3731 2018-10-10  Dean Jackson  <dino@apple.com>
3732
3733         [WHSL -> MSL] Annotate semantics correctly in generated MSL
3734         https://bugs.webkit.org/show_bug.cgi?id=190452
3735         <rdar://problem/45178272>
3736
3737         Reviewed by Myles Maxfield.
3738
3739         Correctly label the appropriate semantics as [[position]]
3740         and [[color(N)]].
3741
3742         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
3743         and color attributes. Also use the semantic's index rather than
3744         a counter.
3745         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
3746         output, and only include the actual shader code.
3747
3748 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
3749
3750         build-webkit --inspector-frontend shouldn't have a nonzero exit code
3751         https://bugs.webkit.org/show_bug.cgi?id=190430
3752
3753         Reviewed by Brian Burg.
3754
3755         * Scripts/webkitdirs.pm:
3756         (argumentsForConfiguration):
3757         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
3758         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
3759
3760 2018-10-10  Tim Horton  <timothy_horton@apple.com>
3761
3762         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
3763         https://bugs.webkit.org/show_bug.cgi?id=190420
3764
3765         Reviewed by Simon Fraser.
3766
3767         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3768         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3769         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3770         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3771         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3772         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3773         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3774         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3775         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3776         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3777         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3778         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3779         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3780         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3781         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3782         Change the testing mechanism for the share sheet such that we up-front
3783         set that it should immediately return with a particular state, instead
3784         of programmatically dismissing the sheet.
3785
3786         Otherwise, running the tests on macOS doesn't work, because we pop
3787         a context menu, which spins the runloop and prevents dismissal from
3788         going through.
3789
3790 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3791
3792         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3793         https://bugs.webkit.org/show_bug.cgi?id=190429
3794
3795         Reviewed by Saam Barati.
3796
3797         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3798         (TestWebKitAPI::TEST_F):
3799
3800 2018-10-10  Chris Dumez  <cdumez@apple.com>
3801
3802         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
3803         https://bugs.webkit.org/show_bug.cgi?id=190418
3804         <rdar://problem/45059769>
3805
3806         Reviewed by Geoffrey Garen.
3807
3808         Add API test coverage.
3809
3810         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3811
3812 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
3813
3814         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
3815         https://bugs.webkit.org/show_bug.cgi?id=190191
3816
3817         Reviewed by Michael Catanzaro.
3818
3819         * QueueStatusServer/config/queues.py:
3820         * Scripts/webkitpy/common/config/ews.json:
3821         * Scripts/webkitpy/common/config/ports.py:
3822         (DeprecatedPort.run_javascriptcore_tests_command):
3823         Add the possibility to pass arguments to run-javascriptcore-tests with
3824         the JSCTESTS_OPTIONS environment variable
3825         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3826         (test_ews_name):
3827
3828
3829 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
3830
3831         Allow run-javascriptcore-tests to distribute tests between devices
3832         https://bugs.webkit.org/show_bug.cgi?id=190190
3833
3834         Reviewed by Michael Catanzaro.
3835
3836         * Scripts/run-jsc-stress-tests:
3837         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3838         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3839
3840 2018-10-09  Dean Jackson  <dino@apple.com>
3841
3842         Update WHLSL to Metal tester with semantics
3843         https://bugs.webkit.org/show_bug.cgi?id=190416
3844         <rdar://problem/45145139>
3845
3846         Reviewed by Myles Maxfield.
3847
3848         A few small changes to the WHLSL to Metal tools:
3849         - Make it compile by adding some missing JS files :)
3850         - Add semantics to the default shader
3851         - Add FIXMEs to the other shaders
3852         - Create an in-browser test for the WHLSLToMetal codepath
3853         - Fix typos in the semantics checker
3854
3855         * WebGPUShadingLanguageRI/Checker.js:
3856         (Checker.prototype._checkSemantics.checkSemanticTypes):
3857         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3858         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
3859         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
3860         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
3861         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
3862         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3863         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
3864
3865 2018-10-09  Jer Noble  <jer.noble@apple.com>
3866
3867         Crash when closing WKWebView during enter fullscreen animation
3868         https://bugs.webkit.org/show_bug.cgi?id=190412
3869
3870         Reviewed by Brian Burg.
3871
3872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3873         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
3874         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
3875         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
3876         (TestWebKitAPI::TEST):
3877
3878 2018-10-09  Chris Dumez  <cdumez@apple.com>
3879
3880         Anchor target should be ignored on activation when the download attribute is set
3881         https://bugs.webkit.org/show_bug.cgi?id=190408
3882
3883         Reviewed by Geoffrey Garen.
3884
3885         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
3886         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
3887         popup blocking.
3888
3889         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3890         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3891         (WTR::TestRunner::setCanOpenWindows):
3892         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3893         * WebKitTestRunner/TestController.cpp:
3894         (WTR::TestController::createOtherPage):
3895         * WebKitTestRunner/TestController.h:
3896         * WebKitTestRunner/TestInvocation.cpp:
3897         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3898         * WebKitTestRunner/TestInvocation.h:
3899
3900 2018-10-09  Jer Noble  <jer.noble@apple.com>
3901
3902         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
3903         https://bugs.webkit.org/show_bug.cgi?id=190098
3904         <rdar://problem/42822671>
3905
3906         Reviewed by Brian Burg.
3907
3908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3909         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
3910         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
3911         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
3912         (TestWebKitAPI::TEST):
3913
3914 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
3915
3916         [WebAuthN] Import CTAP HID message and packet structure from Chromium
3917         https://bugs.webkit.org/show_bug.cgi?id=189289
3918         <rdar://problem/44120310>
3919
3920         Reviewed by Brent Fulgham.
3921
3922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3923         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
3924         (TestWebKitAPI::TEST):
3925
3926 2018-10-09  Chris Dumez  <cdumez@apple.com>
3927
3928         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
3929         https://bugs.webkit.org/show_bug.cgi?id=190378
3930         <rdar://problem/45059466>
3931
3932         Reviewed by Geoffrey Garen.
3933
3934         Add API test coverage.
3935
3936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3937
3938 2018-10-09  Jer Noble  <jer.noble@apple.com>
3939
3940         ISOTrackEncryptionBox returns incorrect defaultKeyID
3941         https://bugs.webkit.org/show_bug.cgi?id=190368
3942
3943         Reviewed by Eric Carlson.
3944
3945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3946         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3947         (TestWebKitAPI::TEST):
3948
3949 2018-10-09  Philippe Normand  <pnormand@igalia.com>
3950
3951         [JHBuild] Update to GStreamer 1.14.4
3952         https://bugs.webkit.org/show_bug.cgi?id=190395
3953
3954         Reviewed by Xabier Rodriguez-Calvar.
3955
3956         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
3957         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
3958         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
3959         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
3960         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
3961
3962 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3963
3964         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
3965         https://bugs.webkit.org/show_bug.cgi?id=190386
3966
3967         Reviewed by Ryosuke Niwa.
3968
3969         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
3970         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
3971         of macOS.
3972
3973         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3974         (TEST):
3975
3976 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3977
3978         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
3979         https://bugs.webkit.org/show_bug.cgi?id=190342
3980         <rdar://problem/44767118>
3981
3982         Reviewed by Tim Horton.
3983
3984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3985         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3986
3987         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
3988         moving the selection around text inside nested list elements.
3989
3990         (TestWebKitAPI::checkParagraphStyles):
3991
3992         Add a new helper to check an NSParagraphStyle against expected results.
3993
3994         (TestWebKitAPI::webViewForTestingFontAttributes):
3995
3996         Allow each test to pass in the name of the test page to load.
3997
3998         (TestWebKitAPI::TEST):
3999         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
4000
4001         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
4004
4005         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
4006
4007 2018-10-08  Justin Fan  <justin_fan@apple.com>
4008
4009         WebGPU: Rename old WebGPU prototype to WebMetal
4010         https://bugs.webkit.org/show_bug.cgi?id=190325
4011         <rdar://problem/44990443>
4012
4013         Reviewed by Dean Jackson.
4014
4015         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
4016
4017         * DumpRenderTree/mac/DumpRenderTree.mm:
4018         (enableExperimentalFeatures):
4019         (resetWebPreferencesToConsistentValues):
4020         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4021         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
4022         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
4023         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
4024         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
4025         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
4026         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4027         (WTR::InjectedBundle::beginTesting):
4028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4029         (WTR::TestRunner::setWebMetalEnabled):
4030         (WTR::TestRunner::setWebGPUEnabled): Deleted.
4031         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4032
4033 2018-10-08  Commit Queue  <commit-queue@webkit.org>
4034
4035         Unreviewed, rolling out r236941.
4036         https://bugs.webkit.org/show_bug.cgi?id=190374
4037
4038         Causing API test failures in new test (Requested by jernoble
4039         on #webkit).
4040
4041         Reverted changeset:
4042
4043         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
4044         https://bugs.webkit.org/show_bug.cgi?id=190368
4045         https://trac.webkit.org/changeset/236941
4046
4047 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
4048
4049         Make <input type=color> a runtime enabled (on-by-default) feature
4050         https://bugs.webkit.org/show_bug.cgi?id=189162
4051
4052         Reviewed by Wenson Hsieh and Tim Horton.
4053
4054         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4055
4056 2018-10-08  Jer Noble  <jer.noble@apple.com>
4057
4058         ISOTrackEncryptionBox returns incorrect defaultKeyID
4059         https://bugs.webkit.org/show_bug.cgi?id=190368
4060
4061         Reviewed by Eric Carlson.
4062
4063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4064         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
4065         (TestWebKitAPI::TEST):
4066
4067 2018-10-08  Alex Christensen  <achristensen@webkit.org>
4068
4069         Remove WKBundleFileHandleRef
4070         https://bugs.webkit.org/show_bug.cgi?id=190360
4071
4072         Reviewed by Tim Horton.
4073
4074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4075         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
4076         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
4077
4078 2018-10-08  Dan Bernstein  <mitz@apple.com>
4079
4080         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
4081         https://bugs.webkit.org/show_bug.cgi?id=190250
4082
4083         Reviewed by Anders Carlsson.
4084
4085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4086
4087         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4088           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4089           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4090
4091         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
4092
4093         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
4094           around deprecated methods or categories on deprecated classes.
4095         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
4096         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
4097         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
4098         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
4099
4100         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4101           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4102           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4103
4104         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4105
4106         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
4107         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
4108           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
4109
4110         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4111           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
4112           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
4113
4114         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
4115           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
4116
4117         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4118           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4119           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4120           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
4121           many C SPI headers trigger the strict prototypes warning.
4122
4123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4124
4125         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4126         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4127         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4128         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
4129         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4130         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4131         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4132         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4133         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
4134         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
4135         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
4136         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
4137         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
4138         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
4139         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
4140         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
4141         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
4142         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
4143         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
4144         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4145         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
4146         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
4147         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
4148         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
4149         * TestWebKitAPI/mac/TestDraggingInfo.mm:
4150         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
4151
4152         In all of the above, suppressed the deprecated implementations warning where needed.
4153
4154         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
4155           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
4156           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
4157           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
4158           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
4159           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4160           and GCC_NO_COMMON_BLOCKS.
4161
4162         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4163
4164         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4165         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
4166           the deprecated implementations warning.
4167
4168         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4169         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
4170
4171 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
4172
4173         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
4174         https://bugs.webkit.org/show_bug.cgi?id=189238
4175
4176         Reviewed by Xabier Rodriguez-Calvar.
4177
4178         Modifications on GStreamer, tracked in GStreamer bugzilla:
4179         https://bugzilla.gnome.org/show_bug.cgi?id=797231
4180         https://bugzilla.gnome.org/show_bug.cgi?id=765275
4181
4182         * gstreamer/jhbuild.modules: Add new patches.
4183         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
4184         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
4185         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
4186         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
4187
4188 2018-10-06  Dan Bernstein  <mitz@apple.com>
4189
4190         [Xcode] Never build yasm with ASAN
4191         https://bugs.webkit.org/show_bug.cgi?id=190327
4192
4193         Reviewed by Youenn Fablet.
4194
4195         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
4196           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
4197
4198 2018-10-05  Chris Dumez  <cdumez@apple.com>
4199
4200         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
4201         https://bugs.webkit.org/show_bug.cgi?id=190320
4202         <rdar://problem/45044814>
4203
4204         Reviewed by Geoffrey Garen.
4205
4206         Add API test coverage.
4207
4208         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
4209         (TestWebKitAPI::TEST):
4210         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
4211         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
4212
4213 2018-10-03  Jer Noble  <jer.noble@apple.com>
4214
4215         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4216         https://bugs.webkit.org/show_bug.cgi?id=190266
4217
4218         Reviewed by Eric Carlson.
4219
4220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4221         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
4222         (TestWebKitAPI::TEST):
4223
4224 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
4225
4226         Unreviewed, rolling out r236866.
4227
4228         Breaks internal builds.
4229
4230         Reverted changeset:
4231
4232         "Add support for reporting "display composited video frames"
4233         through the VideoPlaybackQuality object."
4234         https://bugs.webkit.org/show_bug.cgi?id=190266
4235         https://trac.webkit.org/changeset/236866
4236
4237 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4238
4239         [WPE][JSC] Use Unified Sources for Platform-specific sources
4240         https://bugs.webkit.org/show_bug.cgi?id=190300
4241
4242         Reviewed by Yusuke Suzuki.
4243
4244         Currently the GTK port already used Unified Sources with the same source files.
4245         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
4246         to the list of libraries to link with.
4247
4248         * TestWebKitAPI/PlatformWPE.cmake:
4249
4250 2018-10-05  Zach Li  <zachli@apple.com>
4251
4252         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
4253         https://bugs.webkit.org/show_bug.cgi?id=190302
4254         <rdar://problem/45031469>
4255
4256         Reviewed by Tim Horton.
4257
4258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4259         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
4260         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
4261         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
4262         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
4263