a8aae08d02c1a0e6d05a569fdc768db2d36c383e
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2
3         Remove the PICTURE_SIZES build flag
4         https://bugs.webkit.org/show_bug.cgi?id=144679
5
6         Reviewed by Benjamin Poulain.
7
8         Removed the PICTURE_SIZES build time flag.
9
10         * Scripts/webkitperl/FeatureList.pm:
11
12 2015-05-09  David Kilzer  <ddkilzer@apple.com>
13
14         Layout tests broke due to unexpected simctl output
15
16         * Scripts/webkitpy/xcode/simulator.py:
17         (Simulator._parse_devices): Handle new Device Pairs header.
18         * Scripts/webkitpy/xcode/simulator_unittest.py:
19         (test_device_pairs): Add unit test for Device Pairs header.
20
21 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
22
23         Remove convenience constructors for TextRun
24         https://bugs.webkit.org/show_bug.cgi?id=144752
25
26         Reviewed by Anders Carlsson.
27
28         Test the StringView which takes a StringImpl*.
29
30         * TestWebKitAPI/Tests/WTF/StringView.cpp:
31         (StringView8Bit): Testing is8Bit() on StringView
32
33 2015-05-07  Sam Weinig  <sam@webkit.org>
34
35         [Content Extensions] Add simple tester that takes an extension and compiles it
36         https://bugs.webkit.org/show_bug.cgi?id=144781
37
38         Reviewed by Dan Bates.
39
40         * ContentExtensionTester: Added.
41         * ContentExtensionTester/Configurations: Added.
42         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
43         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
44         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
45         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
46         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
47         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
48         * ContentExtensionTester/main.m: Added.
49         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
50
51 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
52
53         Build fix.
54
55         Reviewed by Dan Bernstein.
56
57         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
58         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
59         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
60         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
61         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
62         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
63         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
64         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
65
66 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
67
68         [GTK] Some tests fail because they do not assume the popup menu captures click events
69         https://bugs.webkit.org/show_bug.cgi?id=40601
70
71         Reviewed by Carlos Garcia Campos.
72
73         Popdown all attached menus when moving between tests and between each new
74         event sent to the WebView. This prevents context and popup menus from eating
75         events.
76
77         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
78         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
79         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
80         (WTR::dispatchEvent): Popdown all menus between dispatching events.
81         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
82         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
83         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
84         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
85         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
86         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
87         longer in the platform-independent file.
88         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
89
90 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
91
92         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
93         https://bugs.webkit.org/show_bug.cgi?id=144746
94
95         Reviewed by Carlos Garcia Campos.
96
97         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
98
99         * MiniBrowser/gtk/main.c:
100         (main):
101
102 2015-05-08  Commit Queue  <commit-queue@webkit.org>
103
104         Unreviewed, rolling out r183996.
105         https://bugs.webkit.org/show_bug.cgi?id=144806
106
107         ASan detected use-after free (Requested by ap on #webkit).
108
109         Reverted changeset:
110
111         "Remove convenience constructors for TextRun"
112         https://bugs.webkit.org/show_bug.cgi?id=144752
113         http://trac.webkit.org/changeset/183996
114
115 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
116
117         Remove convenience constructors for TextRun
118         https://bugs.webkit.org/show_bug.cgi?id=144752
119
120         Reviewed by Anders Carlsson.
121
122         Test the StringView which takes a StringImpl*.
123
124         * TestWebKitAPI/Tests/WTF/StringView.cpp:
125         (StringView8Bit): Testing is8Bit() on StringView
126
127 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
128
129         [GTK] WTR doesn't correctly handle the Escape key
130         https://bugs.webkit.org/show_bug.cgi?id=144788
131
132         Reviewed by Martin Robinson.
133
134         Correctly handle 0x001B character code in GTK+ event sender to be
135         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
136         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
137         to dismiss popup menus.
138
139         Fixes editing/selection/5354455-1.html.
140
141         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
142         (WTR::getGDKKeySymForKeyRef):
143
144 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
145
146         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
147         https://bugs.webkit.org/show_bug.cgi?id=144748
148
149         Reviewed by Sergio Villar Senin.
150
151         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
152         (testWebKitSettings): Check the new setting is correctly
153         initialized and updated.
154         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
155         (testWebContextSecurityFileXHR): Check XHR to local files is
156         allowed from file URLs after changing the setting.
157         (beforeAll): Add new test.
158
159 2015-05-08  Commit Queue  <commit-queue@webkit.org>
160
161         Unreviewed, rolling out r183945.
162         https://bugs.webkit.org/show_bug.cgi?id=144789
163
164         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
165
166         Reverted changeset:
167
168         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
169         https://bugs.webkit.org/show_bug.cgi?id=144746
170         http://trac.webkit.org/changeset/183945
171
172 2015-05-07  Anders Carlsson  <andersca@apple.com>
173
174         Build fixes.
175
176         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
179         (TestWebKitAPI::TEST):
180         Add casts.
181
182 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
183
184         GC has trouble with pathologically large array allocations
185         https://bugs.webkit.org/show_bug.cgi?id=144609
186
187         Reviewed by Geoffrey Garen.
188         
189         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
190         and it's a frequently requested feature.
191         
192         Also add the ability to run a test pretending that your system has a particular RAM size.
193         This is useful for GC tests, and the new GC test that I added uses this.
194
195         * Scripts/run-javascriptcore-tests:
196         (runJSCStressTests):
197         * Scripts/run-jsc-stress-tests:
198
199 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
200
201         [EFL] Bump EFL version to 1.14.0
202         https://bugs.webkit.org/show_bug.cgi?id=144743
203
204         Reviewed by Darin Adler.
205
206         Bump EFL and elementary version to 1.14.0 and removed
207         md5sum, because it isn't used at all if hash is present.
208
209         * efl/jhbuild.modules:
210
211 2015-05-07  Saam Barati  <saambarati1@gmail.com>
212
213         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
214         https://bugs.webkit.org/show_bug.cgi?id=144753
215
216         Reviewed by Mark Lam.
217
218         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
219
220 2015-05-07  Beth Dakin  <bdakin@apple.com>
221
222         New force-related DOM events should fire in WK1 views
223         https://bugs.webkit.org/show_bug.cgi?id=144663
224         -and corresponding-
225         rdar://problem/20281886
226
227         Reviewed by Sam Weinig.
228
229         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
230         now. Just send nil. 
231         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
232         (TestWebKitAPI::buildAndPerformTest):
233
234 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
235
236         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
237         https://bugs.webkit.org/show_bug.cgi?id=144746
238
239         Reviewed by Martin Robinson.
240
241         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
242
243         * MiniBrowser/gtk/main.c:
244         (main):
245
246 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
247
248         Revert "Introducing the Platform Abstraction Layer (PAL)"
249         https://bugs.webkit.org/show_bug.cgi?id=144751
250
251         Unreviewed.
252
253         PAL should be a new target inside WebCore, rather than a top-level folder.
254
255         * Scripts/build-webkit: Add it to build-webkit.
256
257 2015-05-07  Ada Chan  <adachan@apple.com>
258
259         Add a test for WKPageCopySessionState() with filtering.
260         https://bugs.webkit.org/show_bug.cgi?id=144666
261
262         Reviewed by Darin Adler.
263
264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
265         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
266         (TestWebKitAPI::didFinishLoadForFrame):
267         (TestWebKitAPI::setPageLoaderClient):
268         (TestWebKitAPI::filterFirstItemCallback):
269         (TestWebKitAPI::filterAllItemsCallback):
270         (TestWebKitAPI::createSessionStates):
271         (TestWebKitAPI::TEST):
272
273 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
274
275         iOS build fix attempt
276
277         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
278
279         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
280
281 2015-05-06  Matt Baker  <mattbaker@apple.com>
282
283         Unreviewed, updated my list of email addresses.
284
285         * Scripts/webkitpy/common/config/contributors.json:
286
287 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
288
289         Do not link tools to WebKit2.framework
290         https://bugs.webkit.org/show_bug.cgi?id=144699
291
292         Unreviewed build fix.
293
294         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
295         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
296         These linked to WebKit2 in two ways, eliminating the other one.
297
298 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
299
300         Introducing the Platform Abstraction Layer (PAL)
301         https://bugs.webkit.org/show_bug.cgi?id=143358
302
303         Reviewed by Simon Fraser.
304
305         * Scripts/build-webkit: Add it to build-webkit.
306
307 2015-05-06  Alex Christensen  <achristensen@webkit.org>
308
309         Fix api tests after r183877.
310
311         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
312         (TestWebKitAPI::TEST_F):
313         Generate all DFAs before compiling them.
314
315 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
316
317         Do not link tools to WebKit2.framework
318         https://bugs.webkit.org/show_bug.cgi?id=144699
319
320         Reviewed by Tim Horton.
321
322         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
324         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
325
326 2015-05-06  Alex Christensen  <achristensen@webkit.org>
327
328         [Content Extensions] Test splitting NFAs by max NFA size.
329         https://bugs.webkit.org/show_bug.cgi?id=144659
330
331         Reviewed by Darin Adler.
332
333         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
334         (TestWebKitAPI::createNFAs):
335         (TestWebKitAPI::TEST_F):
336         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
337         (TestWebKitAPI::createNFAs):
338
339 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
340
341         Remove the remaining vestiges of SVG feature define
342         https://bugs.webkit.org/show_bug.cgi?id=144655
343
344         Reviewed by Alexey Proskuryakov.
345
346         * Scripts/webkitperl/FeatureList.pm:
347
348 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
349
350         Add a layout mode for computing fixed layout size from a minimum size
351         https://bugs.webkit.org/show_bug.cgi?id=144610
352         <rdar://problem/19790341>
353
354         Reviewed by Simon Fraser.
355
356         * MiniBrowser/mac/BrowserWindow.xib:
357         * MiniBrowser/mac/BrowserWindowController.h:
358         * MiniBrowser/mac/WK1BrowserWindowController.m:
359         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
360         * MiniBrowser/mac/WK2BrowserWindowController.m:
361         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
362         Add a optional toolbar item to toggle a minimum view size of 1024x0.
363
364 2015-05-05  Alex Christensen  <achristensen@webkit.org>
365
366         [Content Extensions] Release input NSString when finished copying it.
367         https://bugs.webkit.org/show_bug.cgi?id=144642
368
369         Reviewed by Brian Weinstein.
370
371         * WebKitTestRunner/mac/TestControllerMac.mm:
372         (WTR::TestController::platformConfigureViewForTest):
373         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
374
375 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
376
377         Unreviewed test fix after r183798.
378
379         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
380         (convertToDRTLabel): Mimic behavior of Mac accessibility output
381         so we can share results.
382
383 2015-05-05  Alex Christensen  <achristensen@webkit.org>
384
385         [Content Extensions] Use less memory to store the json input.
386         https://bugs.webkit.org/show_bug.cgi?id=144604
387
388         Reviewed by Benjamin Poulain.
389
390         * MiniBrowser/mac/ExtensionManagerWindowController.m:
391         (-[ExtensionManagerWindowController add:]):
392         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
393         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
394         * WebKitTestRunner/mac/TestControllerMac.mm:
395         (WTR::TestController::platformConfigureViewForTest):
396
397 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
398
399         Unreviewed. Make myself a WebKit reviewer.
400
401         * Scripts/webkitpy/common/config/contributors.json:
402
403 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
404
405         [GTK] r183783 breaks build
406         https://bugs.webkit.org/show_bug.cgi?id=144632
407
408         Reviewed by Martin Robinson.
409
410         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
411
412         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
413         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
414
415 2015-05-05  Alex Christensen  <achristensen@webkit.org>
416
417         [Content Extensions] Combine NFAs properly and free memory as we compile.
418         https://bugs.webkit.org/show_bug.cgi?id=144485
419
420         Reviewed by Benjamin Poulain.
421
422         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
423         (TestWebKitAPI::TEST_F):
424         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
425         Added tests for deep NFAs.
426
427 2015-05-04  Alex Christensen  <achristensen@webkit.org>
428
429         [Content Extensions] Use less memory when writing byte code to file
430         https://bugs.webkit.org/show_bug.cgi?id=144602
431
432         Reviewed by Darin Adler.
433
434         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
435
436 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
437
438         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
439         https://bugs.webkit.org/show_bug.cgi?id=144541
440
441         Reviewed by Žan Doberšek.
442
443         Add a test case to WorkQueue unit test, to check that sources of
444         asynchronous IO operations running in the WorkQueue thread are
445         dispatched by the WorkQueue main loop.
446
447         * TestWebKitAPI/PlatformGTK.cmake:
448         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
449         (TestWebKitAPI::TEST):
450
451 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
452
453         Correct '--show-webview' option for Tiled Drawing tests
454         https://bugs.webkit.org/show_bug.cgi?id=144621
455
456         Reviewed by Simon Fraser.
457
458         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
459         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
460
461         * WebKitTestRunner/mac/TestControllerMac.mm:
462         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
463         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
464
465 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
466
467         Large array shouldn't be slow
468         https://bugs.webkit.org/show_bug.cgi?id=144617
469
470         Reviewed by Geoffrey Garen.
471         
472         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
473         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
474         long-running. So, hash-map sort of belongs here.
475
476         * Scripts/run-jsc-benchmarks:
477
478 2015-05-04  Doug Russell  <d_russell@apple.com>
479
480         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
481         https://bugs.webkit.org/show_bug.cgi?id=144489
482
483         Reviewed by Chris Fleizach.
484
485         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
486         on the returned control.
487         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
488         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
489         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
490         Add support for setSelectedVisibleTextRange() in accessibility tests.
491
492         * DumpRenderTree/AccessibilityUIElement.cpp:
493         (setSelectedVisibleTextRangeCallback):
494         (AccessibilityUIElement::setSelectedVisibleTextRange):
495         (AccessibilityUIElement::getJSClass):
496         (AccessibilityUIElement::textMarkerForIndex): Deleted.
497         * DumpRenderTree/AccessibilityUIElement.h:
498         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
499         (AccessibilityUIElement::setSelectedVisibleTextRange):
500         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
501         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
502         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
503         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
504         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
506         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
507         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
508         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
509         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
510         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
511
512 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
513
514         [Win] Implement the "--show-webview" option for Windows
515         https://bugs.webkit.org/show_bug.cgi?id=144589
516
517         Reviewed by Alex Christensen.
518
519         Add another runtime flag (--show-webview) that causes DumpRenderTree
520         to draw its view on-screen, rather than the standard offscreen mode.
521
522         * DumpRenderTree/win/DumpRenderTree.cpp:
523         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
524         (initializeGlobalsFromCommandLineOptions): Recognize the new
525         command-line argument, and set the global 'showWebView' state if
526         appropriate.
527
528 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
529
530         Remove dead code from TestInvocationCairo.cpp
531         https://bugs.webkit.org/show_bug.cgi?id=144564
532
533         Reviewed by Gyuyoung Kim.
534
535         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
536
537         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
538         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
539
540 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
541
542         [GTK] Add libnotify in gtk install-dependencies
543         https://bugs.webkit.org/show_bug.cgi?id=144379
544
545         Reviewed by Csaba Osztrogonác.
546
547         * gtk/install-dependencies:
548
549 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
550
551         check-webkit-style fails due to system pylint
552         https://bugs.webkit.org/show_bug.cgi?id=144360
553
554         Reviewed by Darin Adler.
555
556         Make sure that the directory containing third party autoinstalled modules
557         is at the beginning of the search path, to avoid conflicts with other
558         versions of the same modules installed in the system (e.g. pylint).
559
560         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
561         modules directory to sys.path, instead of appending it.
562
563 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
564
565         Unreviewed, updated my list of email addresses.
566
567         * Scripts/webkitpy/common/config/contributors.json: Updated.
568
569 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
570
571         USE(...) macro should expect unprefixed variables
572         https://bugs.webkit.org/show_bug.cgi?id=144454
573
574         Reviewed by Daniel Bates.
575
576         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
577         * DumpRenderTree/config.h: Ditto.
578         * TestWebKitAPI/config.h: Ditto.
579
580 2015-05-01  Basile Clement  <basile_clement@apple.com>
581
582         Unreviewed. Add myself as a commiter in contributors.json.
583
584         * Scripts/webkitpy/common/config/contributors.json:
585
586 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
587
588         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
589         https://bugs.webkit.org/show_bug.cgi?id=144487
590
591         Reviewed by Ryosuke Niwa.
592
593         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
594         (BenchmarkRunner.merge): Fix bug.
595         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
596
597 2015-05-01  Brady Eidson  <beidson@apple.com>
598
599         Add API to disable meta refreshes.
600         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
601
602         Reviewed by Alexey Proskuryakov.
603
604         * DumpRenderTree/mac/DumpRenderTree.mm:
605         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
606
607 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
608
609         Provide a runtime flag to run-webkit-tests that shows the test view
610         https://bugs.webkit.org/show_bug.cgi?id=144079.
611
612         Unreviewed correction to r183651.
613
614         * WebKitTestRunner/TestController.cpp:
615         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
616         flag is included in the options dictionary passed to the PlatformWebView.
617
618 2015-05-01  Antti Koivisto  <antti@apple.com>
619
620         Remove network process load serialization code
621         https://bugs.webkit.org/show_bug.cgi?id=144448
622
623         Reviewed by Alexey Proskuryakov.
624
625         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
626         (WTR::InjectedBundle::beginTesting):
627         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
628         (WTR::TestRunner::setSerializeHTTPLoads):
629         (WTR::TestRunner::dispatchPendingLoadRequests):
630
631 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
632
633         [GTK] Add libhyphen-dev to the build dependencies
634         https://bugs.webkit.org/show_bug.cgi?id=144452
635
636         Reviewed by Martin Robinson.
637
638         * gtk/install-dependencies: Added hyphen as Fedora and Arch
639         dependencies.
640
641 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
642
643         Provide a runtime flag to run-webkit-tests that shows the test view
644         https://bugs.webkit.org/show_bug.cgi?id=144079.
645
646         Reviewed by Dean Jackson.
647
648         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
649         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
650         option:
651         
652         --additional-drt-flag="--show-webview"
653
654         * DumpRenderTree/mac/DumpRenderTree.mm:
655         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
656         '--show-webview' flag.
657         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
658         * WebKitTestRunner/Options.cpp:
659         (WTR::Options::Options):
660         (WTR::handleOptionShowWebView):
661         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
662         * WebKitTestRunner/Options.h:
663         * WebKitTestRunner/TestController.cpp:
664         (WTR::TestController::TestController):
665         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
666         * WebKitTestRunner/TestController.h:
667         (WTR::TestController::shouldShowWebView):
668         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
669         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
670         options dictionary. If it is true, display the web view while running the test.
671
672 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
673
674         r183355 didn't trigger Mac tests
675         https://bugs.webkit.org/show_bug.cgi?id=144464
676
677         Reviewed by Simon Fraser.
678
679         Update badly neglected filters and unit tests.
680
681         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
682         (_should_file_trigger_build):
683         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
684         (ShouldBuildTest):
685         (ShouldBuildTest.test_should_build):
686
687 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
688
689         [GTK] Add libhyphen-dev to the build dependencies
690         https://bugs.webkit.org/show_bug.cgi?id=144452
691
692         Reviewed by Martin Robinson.
693
694         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
695         build dependencies.
696
697 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
698
699         [GTK] Testing dictionaries are not installed automatically
700         https://bugs.webkit.org/show_bug.cgi?id=144460
701
702         Reviewed by Carlos Garcia Campos.
703
704         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
705
706 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
707
708         Fix return code issue, check return code of safari process and dump results to log
709         https://bugs.webkit.org/show_bug.cgi?id=144436
710
711         Reviewed by Ryosuke Niwa.
712
713         * Scripts/run-benchmark:
714         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
715         (BenchmarkRunner.dump): Correct typo.
716         (BenchmarkRunner.wrap): Add results to console.
717         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
718         (OSXSafariDriver.prepareEnv):
719         (OSXSafariDriver.launchUrl):
720         (OSXSafariDriver.closeBrowsers):
721
722 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
723
724         Should no longer need to worry about very old versions of Xcode
725         https://bugs.webkit.org/show_bug.cgi?id=144437
726
727         Reviewed by Dan Bernstein.
728
729         * Scripts/check-for-exit-time-destructors:
730         * Scripts/check-for-global-initializers:
731         * Scripts/check-for-weak-vtables-and-externals:
732
733 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
734
735         REGRESSION(183583): [Mac] make without SDKROOT has issues
736         https://bugs.webkit.org/show_bug.cgi?id=144431
737
738         Reviewed by Dan Bernstein.
739
740         * Makefile:
741         * WebKitTestRunner/Makefile:
742         Assume an empty SDKROOT means an macosx variant, so only
743         enable settings if the SDKROOT is not empty and does not
744         contain "macosx".
745
746 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
747
748         Expand test infrastructure to support scrolling tests
749         https://bugs.webkit.org/show_bug.cgi?id=143684
750         <rdar://problem/20375516>
751
752         Reviewed by Simon Fraser.
753
754         * DumpRenderTree/mac/DumpRenderTree.mm:
755         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
756         reset before the next test run.
757         * WebKitTestRunner/TestController.cpp:
758         (WTR::TestController::resetStateToConsistentValues): Ditto."
759
760 2015-04-29  Alex Christensen  <achristensen@webkit.org>
761
762         Run javascriptcore tests on Windows without cygwin
763         https://bugs.webkit.org/show_bug.cgi?id=144419
764
765         Reviewed by Brent Fulgham.
766
767         * Scripts/run-javascriptcore-tests:
768         (runJSCStressTests):
769         Just call ruby, not /usr/bin/env ruby.
770
771 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
772
773         [GTK] Add --enable-shared option to LLVM to build mesa
774         https://bugs.webkit.org/show_bug.cgi?id=144393
775
776         Reviewed by Martin Robinson.
777
778         The updated mesa requires the shared LLVM libraries.
779         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
780         to LLVM configure script. It will provide shared libraries in addition to static libraries.
781
782         * gtk/jhbuild-optional.modules:
783
784 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
785
786         [GTK] Add support for automatic hyphenation
787         https://bugs.webkit.org/show_bug.cgi?id=44478
788
789         Reviewed by Carlos Garcia Campos.
790
791         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
792         all systems will use the same dictionaries for testing purposes.
793
794 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
795
796         Failure when building WebKit for appletvsimulator.
797         https://bugs.webkit.org/show_bug.cgi?id=144356
798
799         Reviewed by Alexey Proskuryakov.
800
801         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
802         make TVOS and WatchOS behave correctly.
803
804         * Makefile:
805         * WebKitTestRunner/Makefile:
806
807 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
808
809         Use-after-free when invalidating WKPageForceRepaint callback
810         https://bugs.webkit.org/show_bug.cgi?id=144401
811         rdar://problem/20741111
812
813         Reviewed by Tim Horton.
814
815         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
816
817         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
818         Don't do anything on error, because the context may be a stale pointer now.
819
820 2015-04-29  David Kilzer  <ddkilzer@apple.com>
821
822         check-webkit-style: Don't complain about returning value from Objective-C method call in header
823         <http://webkit.org/b/144395>
824
825         Reviewed by Andy Estes.
826
827         * Scripts/webkitpy/style/checkers/cpp.py:
828         (check_spacing): Update regex so 'return' is ignored if it
829         precedes the whitespace and bracket.  Change category name to
830         'whitespace/brackets'.  Add period to error message.
831         (CppChecker): Add 'whitespace/brackets' as a category.
832         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
833         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
834         'CppChecker.categories' since that's where the list lives now.
835         (CppStyleTest.test_spacing_before_brackets): Add tests for
836         'whitespace/brackets' issues and non-issues.
837
838 2015-04-29  Alex Christensen  <achristensen@webkit.org>
839
840         Fix WinCairo bot.
841
842         * Scripts/webkitdirs.pm:
843         (determinePassedConfiguration):
844         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
845
846 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
847
848         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
849         https://bugs.webkit.org/show_bug.cgi?id=132159
850
851         Reviewed by Darin Adler.
852
853         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
854         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
855
856         * DumpRenderTree/mac/DumpRenderTree.mm:
857         (fontWhitelist):
858         (adjustFonts):
859         (createWebViewAndOffscreenWindow):
860         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
861         (WTR::activateFonts):
862         * WebKitTestRunner/mac/TestControllerMac.mm:
863         (WTR::allowedFontFamilySet):
864         (WTR::systemHiddenFontFamilySet):
865         (WTR::generateWhitelist):
866         (WTR::TestController::platformInitializeContext):
867
868 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
869
870         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
871         https://bugs.webkit.org/show_bug.cgi?id=144155
872
873         Reviewed by Andreas Kling.
874
875         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
876         Make sure that test window is "visible" before each test. While there is no concrete
877         evidence that this is the problem indeed, the behavior is consistent with what would
878         happen for an invisible window. Also, WKTR obviously needs to do this to protect
879         against potential buggy tests that hide the window and don't show it.
880
881 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
882
883         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
884
885         Latest changes in the inspector UI made this test fail. We were
886         relying that the sidebar was always visible and the first 'li'
887         element of the inspector was the one containing the title. This is
888         no longer true, so better use document title that is not likely
889         to change.
890
891         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
892         (openRemoteDebuggingSession):
893
894 2015-04-29  Andres Gomez  <agomez@igalia.com>
895
896         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
897
898         * Scripts/webkitpy/common/config/contributors.json:
899
900 2015-04-29  Andres Gomez  <agomez@igalia.com>
901
902         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
903
904         * Scripts/webkitpy/common/config/watchlist:
905
906 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
907
908         [EFL] Allow to run the tests on the native X display
909         https://bugs.webkit.org/show_bug.cgi?id=144247
910
911         Reviewed by Gyuyoung Kim.
912
913         Added the USE_NATIVE_XDISPLAY option for the WTR.
914         We can select the Xorg driver if environment variable is set up before running the tests.
915
916         * Scripts/webkitpy/port/efl.py:
917         (EflPort._driver_class):
918
919 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
920
921         [GTK] Add libnotify-dev in gtk install-dependencies
922         https://bugs.webkit.org/show_bug.cgi?id=144379
923
924         Reviewed by Žan Doberšek.
925
926         * gtk/install-dependencies:
927
928 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
929
930         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
931         https://bugs.webkit.org/show_bug.cgi?id=143001
932
933         Reviewed by Gyuyoung Kim.
934
935         * WebKitTestRunner/TestController.cpp:
936         (WTR::shouldUseFixedLayout):
937
938 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
939
940         Increase stablility of run-benchmark script
941         https://bugs.webkit.org/show_bug.cgi?id=144361
942
943         Reviewed by Ryosuke Niwa.
944
945         * Scripts/run-benchmark:
946         (main):
947         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
948         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
949         (GenericBenchmarkBuilder.clean):
950         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
951         (BenchmarkRunner.__init__):
952         (BenchmarkRunner.execute):
953         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
954         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
955         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
956         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
957         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
958         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
959         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
960         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
961         (HTTPServerDriver.fetchResult):
962         (HTTPServerDriver):
963         (HTTPServerDriver.killServer): Add kill server interface.
964         (HTTPServerDriver.getReturnCode): Add get return code interface.
965         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
966         (SimpleHTTPServerDriver.serve):
967         (SimpleHTTPServerDriver.fetchResult):
968         (SimpleHTTPServerDriver):
969         (SimpleHTTPServerDriver.killServer):
970         (SimpleHTTPServerDriver.getReturnCode):
971         * Scripts/webkitpy/benchmark_runner/utils.py:
972         (forceRemove): Provide python version of 'rm -rf'.
973
974 2015-04-28  Sam Weinig  <sam@webkit.org>
975
976         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
977         https://bugs.webkit.org/show_bug.cgi?id=144363
978
979         Reviewed by Alex Christensen.
980
981         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
982         (TestWebKitAPI::createNFAs):
983         (TestWebKitAPI::TEST_F):
984         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
985         (TestWebKitAPI::countLiveNodes):
986         (TestWebKitAPI::createNFAs):
987         (TestWebKitAPI::buildDFAFromPatterns):
988         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
989
990 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
991
992         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
993         https://bugs.webkit.org/show_bug.cgi?id=144304
994
995         Reviewed by Geoffrey Garen.
996
997         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
998         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
999         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1000
1001 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1002
1003         Unreviewed, rolling out r183514.
1004         https://bugs.webkit.org/show_bug.cgi?id=144359
1005
1006         It broke cloop test bots (Requested by mcatanzaro on #webkit).
1007
1008         Reverted changeset:
1009
1010         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
1011         https://bugs.webkit.org/show_bug.cgi?id=144304
1012         http://trac.webkit.org/changeset/183514
1013
1014 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1015
1016         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1017         https://bugs.webkit.org/show_bug.cgi?id=144304
1018
1019         Reviewed by Geoffrey Garen.
1020
1021         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
1022         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
1023         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1024         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1025
1026 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1027
1028         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
1029         https://bugs.webkit.org/show_bug.cgi?id=144319
1030
1031         Reviewed by Csaba Osztrogonác.
1032
1033         * TestWebKitAPI/CMakeLists.txt:
1034         * TestWebKitAPI/PlatformEfl.cmake:
1035
1036 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
1037
1038         Fix common typo "targetting" => "targeting"
1039         https://bugs.webkit.org/show_bug.cgi?id=144349
1040
1041         Reviewed by Daniel Bates.
1042
1043         * Scripts/webkitdirs.pm:
1044         (execMacWebKitAppForDebugging):
1045
1046 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1047
1048         [GTK][jhbuild] Mesa build failure with llvm 3.6
1049         https://bugs.webkit.org/show_bug.cgi?id=144250
1050
1051         Reviewed by Žan Doberšek.
1052
1053         Bump the version of Mesa to 10.5.4
1054
1055         * gtk/jhbuild.modules:
1056
1057 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
1058
1059         Disable App Nap in WebKitTestRunner UI process
1060         https://bugs.webkit.org/show_bug.cgi?id=144308
1061
1062         Reviewed by Daniel Bates.
1063
1064         * WebKitTestRunner/mac/main.mm:
1065         (disableAppNapInUIProcess):
1066         (main):
1067
1068 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1069
1070         [GTK] Update JHBuild Mesa download directory
1071         https://bugs.webkit.org/show_bug.cgi?id=144318
1072
1073         Update the download directory of Mesa module since the previous one
1074         doesn't exist any more.
1075
1076         Reviewed by Žan Doberšek.
1077
1078         * gtk/jhbuild.modules:
1079
1080 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1081
1082         Unreviewed, rolling out r183477.
1083         https://bugs.webkit.org/show_bug.cgi?id=144334
1084
1085         Roll back the Mesa dependency bump in fear of uncaught
1086         regressions while the testing bots are no-op. (Requested by
1087         zdobersek on #webkit).
1088
1089         Reverted changeset:
1090
1091         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
1092         https://bugs.webkit.org/show_bug.cgi?id=144250
1093         http://trac.webkit.org/changeset/183477
1094
1095 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1096
1097         [GTK][jhbuild] Mesa build failure with llvm 3.6
1098         https://bugs.webkit.org/show_bug.cgi?id=144250
1099
1100         Reviewed by Žan Doberšek.
1101
1102         Bump the version of Mesa to 10.5.4
1103
1104         * gtk/jhbuild.modules:
1105
1106 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
1107
1108         Add '__init__.py' and fix known bug in benchmark runner.
1109         https://bugs.webkit.org/show_bug.cgi?id=144296
1110
1111         Reviewed by Ryosuke Niwa
1112
1113         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
1114         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
1115         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1116         (BenchmarkRunner.__init__):
1117         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
1118         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
1119         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
1120
1121 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1122
1123         More build fix.
1124
1125         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1126         (-[AccessibilityNotificationHandler _notificationReceived:]):
1127         Use -objectForKey:, not array subscript.
1128
1129 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1130
1131         Catch unexpected exits in DumpRenderTree
1132         https://bugs.webkit.org/show_bug.cgi?id=144288
1133
1134         Reviewed by Tim Horton.
1135
1136         * DumpRenderTree/mac/DumpRenderTree.mm:
1137         (atexitFunction):
1138         (DumpRenderTreeMain):
1139
1140 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1141
1142         Build fix
1143
1144         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1145         (-[AccessibilityNotificationHandler _notificationReceived:]):
1146         Use -objectForKey:, not array subscript.
1147
1148 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1149
1150         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1151         https://bugs.webkit.org/show_bug.cgi?id=144155
1152
1153         Reviewed by Tim Horton.
1154
1155         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1156         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
1157         and we clearly don't want App Nap while testing.
1158
1159 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
1160
1161         [CMake] Autogenerate cmakeconfig.h.cmake
1162         https://bugs.webkit.org/show_bug.cgi?id=143997
1163
1164         Reviewed by Csaba Osztrogonác.
1165
1166         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
1167         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
1168
1169 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
1170
1171         REGRESSION(r182879): Images and video can no longer be downloaded
1172         https://bugs.webkit.org/show_bug.cgi?id=144267
1173         <rdar://problem/20702844>
1174
1175         Reviewed by Simon Fraser.
1176
1177         Revise tests to check for proper download menu state.
1178         1. Downloading a loal image should be disabled.
1179         2. Downloading a local media file should be disabled.
1180         3. Downloading non-downloadable media should be disabled.
1181
1182         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1183         (TestWebKitAPI::TEST):
1184
1185 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1186
1187         Merge run-launcher into run-minibrowser
1188         https://bugs.webkit.org/show_bug.cgi?id=141928
1189
1190         Reviewed by Darin Adler.
1191
1192         * Scripts/run-iexploder-tests:
1193         (runSafariWithIExploder):
1194         * Scripts/run-launcher: Removed.
1195         * Scripts/run-minibrowser:
1196         * Scripts/webkitdirs.pm:
1197         (launcherPath):
1198         * Scripts/webkitpy/port/efl.py:
1199         (EflPort.show_results_html_file):
1200         * Scripts/webkitpy/port/efl_unittest.py:
1201         (EflPortTest.test_show_results_html_file):
1202         * Scripts/webkitpy/port/gtk.py:
1203         (GtkPort.print_leaks_summary):
1204         (GtkPort.show_results_html_file):
1205         (GtkPort): Deleted.
1206         * Scripts/webkitpy/port/gtk_unittest.py:
1207         (GtkPortTest.test_show_results_html_file):
1208
1209 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1210
1211         [buildbot] Fix the output of perf-test buildstep on timeout
1212         https://bugs.webkit.org/show_bug.cgi?id=144097
1213
1214         Reviewed by Ryosuke Niwa.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1217         (RunAndUploadPerfTests.getText2):
1218         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1219         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
1220         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1221
1222 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1223
1224         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
1225         https://bugs.webkit.org/show_bug.cgi?id=143874
1226
1227         Reviewed by Gyuyoung Kim.
1228
1229         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
1230
1231 2015-04-24  Philippe Normand  <pnormand@igalia.com>
1232
1233         [JHBuild] Move to upstream OpenWebRTC
1234         https://bugs.webkit.org/show_bug.cgi?id=144145
1235
1236         Reviewed by Carlos Garcia Campos.
1237
1238         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
1239         and add a new simple patch to gst-plugins-base, required for
1240         OpenWebRTC build.
1241         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1242         * gtk/jhbuild.modules: Ditto.
1243         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1244
1245 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1246
1247         [ES6] Implement ES6 template literals
1248         https://bugs.webkit.org/show_bug.cgi?id=142691
1249
1250         Reviewed by Darin Adler.
1251
1252         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1253
1254         * Scripts/webkitperl/FeatureList.pm:
1255
1256 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1257
1258         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
1259         https://bugs.webkit.org/show_bug.cgi?id=144217
1260
1261         Reviewed by Darin Adler.
1262
1263         * WebKitTestRunner/PlatformEfl.cmake:
1264
1265 2015-04-26  Doug Russell  <d_russell@apple.com>
1266
1267         AX: richer text change notifications (142719)
1268         https://bugs.webkit.org/show_bug.cgi?id=142719
1269
1270         Reviewed by Darin Adler.
1271
1272         Richer accessibility value change notifications. Introduce AXTextEditType,
1273         postTextStateChangeNotification and postTextReplacementNotification to give assistive
1274         tech apps more reliable context for responding to changes in web content. Also implement
1275         a mechanism to post value changes in password form fields in coalesced ticks to thwart
1276         analyzing the cadence of changes.
1277
1278         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1279         and an overload of postTextReplacementNotification to give assistive tech apps more
1280         reliable context for responding to changes in web content selection. Also block posting
1281         selection changes on password fields.
1282
1283         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1284         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1285         (-[AccessibilityNotificationHandler stopObserving]):
1286         (-[AccessibilityNotificationHandler _notificationReceived:]):
1287         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1288         (AccessibilityUIElement::removeNotificationListener):
1289         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1290         (-[AccessibilityNotificationHandler _notificationReceived:]):
1291         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1292         (WTR::AccessibilityUIElement::removeNotificationListener):
1293
1294 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
1295
1296         Add myself to contributors.json
1297         https://bugs.webkit.org/show_bug.cgi?id=144204
1298
1299         Reviewed by Darin Adler.
1300
1301         * Scripts/webkitpy/common/config/contributors.json:
1302
1303 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
1304
1305         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1306         https://bugs.webkit.org/show_bug.cgi?id=144182
1307
1308         Reviewed by Simon Fraser.
1309
1310         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1311
1312 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
1313
1314         https://bugs.webkit.org/show_bug.cgi?id=144038
1315
1316         Reviewed by Ryosuke Niwa
1317
1318         Add a script to run Speedometer and JetStream on a browser.
1319
1320         * Scripts/run-benchmark: Wrapper script to run benchmark.
1321         (main):
1322         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1323         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1324         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1325         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1326         (BenchmarkBuilderFactory):
1327         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1328         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1329         (GenericBenchmarkBuilder):
1330         (GenericBenchmarkBuilder.prepare):
1331         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1332         (GenericBenchmarkBuilder._applyPatch):
1333         (GenericBenchmarkBuilder.clean):
1334         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1335         (JetStreamBenchmarkBuilder):
1336         (JetStreamBenchmarkBuilder.prepare):
1337         (JetStreamBenchmarkBuilder._runCreateScript):
1338         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1339         (BenchmarkRunner):
1340         (BenchmarkRunner.__init__):
1341         (BenchmarkRunner.execute):
1342         (BenchmarkRunner.dump):
1343         (BenchmarkRunner.wrap):
1344         (BenchmarkRunner.merge):
1345         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1346         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1347         (BrowserDriver):
1348         (BrowserDriver.prepareEnv):
1349         (BrowserDriver.launchUrl):
1350         (BrowserDriver.closeBrowser):
1351         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1352         (BrowserDriverFactory):
1353         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1354         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1355         (OSXChromeDriver):
1356         (OSXChromeDriver.prepareEnv):
1357         (OSXChromeDriver.launchUrl):
1358         (OSXChromeDriver.closeBrowsers):
1359         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1360         (OSXSafariDriver):
1361         (OSXSafariDriver.prepareEnv):
1362         (OSXSafariDriver.launchUrl):
1363         (OSXSafariDriver.closeBrowsers):
1364         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1365         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1366         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1367         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1368         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1369         (GenericFactory):
1370         (GenericFactory.iterateGetItem):
1371         (GenericFactory.create):
1372         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1373         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1374         (ServerControl):
1375         (ServerControl.render_GET):
1376         (ServerControl.render_POST):
1377         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1378         (HTTPServerDriver):
1379         (HTTPServerDriver.serve):
1380         (HTTPServerDriver.fetchResult):
1381         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1382         (HTTPServerDriverFactory):
1383         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1384         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1385         (SimpleHTTPServerDriver):
1386         (SimpleHTTPServerDriver.depends):
1387         (SimpleHTTPServerDriver.__init__):
1388         (SimpleHTTPServerDriver.serve):
1389         (SimpleHTTPServerDriver.baseUrl):
1390         (SimpleHTTPServerDriver.fetchResult):
1391         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1392         (ModuleNotFoundError):
1393         (loadModule):
1394         (getPathFromProjectRoot):
1395         (loadJSONFromFile):
1396         (TimeoutError):
1397         (timeout):
1398         (timeout.__init__):
1399         (timeout.handle_timeout):
1400         (timeout.__enter__):
1401         (timeout.__exit__):
1402
1403 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1404
1405         Unreviewed, rolling out r183303.
1406         https://bugs.webkit.org/show_bug.cgi?id=144181
1407
1408         Change was incorrect, broke builds (Requested by smfr on
1409         #webkit).
1410
1411         Reverted changeset:
1412
1413         "Fix the build."
1414         http://trac.webkit.org/changeset/183303
1415
1416 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
1417
1418         Fix the build.
1419
1420         * MiniBrowser/mac/WK2BrowserWindowController.m:
1421         (-[WK2BrowserWindowController initWithConfiguration:]):
1422
1423 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1424
1425         Disable ActionMenusPDFTest due to timeout on test bot
1426
1427         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1428         (TestWebKitAPI::TEST):
1429
1430 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1431
1432         Unreviewed, rolling out r183266.
1433         https://bugs.webkit.org/show_bug.cgi?id=144164
1434
1435         Broke 32-bit build and a test. (Requested by ap on #webkit).
1436
1437         Reverted changeset:
1438
1439         "AX: richer text change notifications (142719)"
1440         https://bugs.webkit.org/show_bug.cgi?id=142719
1441         http://trac.webkit.org/changeset/183266
1442
1443 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1444
1445         REGRESSION: WebKit2.ActionMenusTest API test fails
1446         https://bugs.webkit.org/show_bug.cgi?id=144149
1447         <rdar://problem/20677770>
1448
1449         Reviewed by Tim Horton.
1450
1451         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1452         as the 'ActionMenusPDFTest'.
1453         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1454         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1455         to match the hit test on the 'action-menu-target.pdf' test file.
1456
1457 2015-04-24  Daniel Bates  <dabates@apple.com>
1458
1459         Cleanup: Use @memoized for property IOSSimulator.testing_device
1460         https://bugs.webkit.org/show_bug.cgi?id=141715
1461
1462         Reviewed by Darin Adler.
1463
1464         Simplify the caching of the result of IOSSimulator.testing_device
1465         and make the code more readable by making use of the @memoized declarator
1466         instead of explicitly managing a private instance variable,
1467         IOSSimulator._testing_device, for the cached result.
1468
1469         * Scripts/webkitpy/port/ios.py:
1470         (IOSPort.determine_full_port_name):
1471         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1472         (IOSSimulatorPort):
1473         (IOSSimulatorPort.testing_device): No need to cache the created device object in
1474         IOSSimulatorPort._testing_device since we are marking this function @memoized.
1475         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1476         of caching in local variable since we only make use of this value exactly once in this function.
1477         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1478         been used since being added in r178622. So, we can remove this constructor since
1479         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1480
1481 2015-04-24  Anders Carlsson  <andersca@apple.com>
1482
1483         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1484         https://bugs.webkit.org/show_bug.cgi?id=144158
1485
1486         Reviewed by Beth Dakin.
1487
1488         * MiniBrowser/mac/WK2BrowserWindowController.m:
1489         (-[WK2BrowserWindowController initWithConfiguration:]):
1490
1491 2015-04-24  Doug Russell  <d_russell@apple.com>
1492
1493         AX: richer text change notifications (142719)
1494         https://bugs.webkit.org/show_bug.cgi?id=142719
1495
1496         Reviewed by Darin Adler.
1497
1498         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1499
1500         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1501
1502         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1503         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1504         (-[AccessibilityNotificationHandler stopObserving]):
1505         (-[AccessibilityNotificationHandler _notificationReceived:]):
1506         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1507         (AccessibilityUIElement::removeNotificationListener):
1508         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1509         (-[AccessibilityNotificationHandler _notificationReceived:]):
1510         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1511         (WTR::AccessibilityUIElement::removeNotificationListener):
1512
1513 2015-04-24  Darin Adler  <darin@apple.com>
1514
1515         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1516         https://bugs.webkit.org/show_bug.cgi?id=128007
1517
1518         Reviewed by Anders Carlsson.
1519
1520         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1521         * DumpRenderTree/win/UIDelegate.h: Ditto.
1522
1523         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1524         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1525
1526         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1527
1528         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1529         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1530         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1531         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1532         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1533         (WebKitDOMDOMWindowTest::create): Ditto.
1534         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1535         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1536         of smart pointers to DelayedSIgnal objects.
1537         (uriChangedCallback): Ditto.
1538
1539 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1540
1541         [Mac] Unreviewed test fix.
1542         https://bugs.webkit.org/show_bug.cgi?id=144149
1543
1544         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1545         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1546         test.
1547
1548 2015-04-23  Darin Adler  <darin@apple.com>
1549
1550         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1551         https://bugs.webkit.org/show_bug.cgi?id=144090
1552
1553         Reviewed by Anders Carlsson.
1554
1555         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1556
1557 2015-04-23  Michael Saboff  <msaboff@apple.com>
1558
1559         lldb macro btjs sometimes can't get a frame description
1560         https://bugs.webkit.org/show_bug.cgi?id=144130
1561
1562         Reviewed by Filip Pizlo.
1563
1564         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1565         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1566         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1567
1568         * lldb/lldb_webkit.py:
1569         (btjs):
1570
1571 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1572
1573         Use less memory when compiling content extensions.
1574         https://bugs.webkit.org/show_bug.cgi?id=144051
1575
1576         Reviewed by Darin Adler and Benjamin Poulain.
1577
1578         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1579         (TestWebKitAPI::TEST_F):
1580         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1581         (TestWebKitAPI::countLiveNodes):
1582
1583 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1584
1585         [CMake] Clean up JSC JIT options
1586         https://bugs.webkit.org/show_bug.cgi?id=143998
1587
1588         Reviewed by Filip Pizlo.
1589
1590         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1591         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1592
1593 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1594
1595         [Mac] Extend action menus to support PDF
1596         https://bugs.webkit.org/show_bug.cgi?id=143895
1597         <rdar://problem/19003333>
1598
1599         Reviewed by Tim Horton.
1600
1601         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1602         of PDF content works.
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1605         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1606         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1607         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1608         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1609         Update to support PDF tests.
1610         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1611         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1612
1613 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1614
1615         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1616
1617         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1618         (beforeAll):
1619         (testWebViewAudioOnlyUserMediaPermissionRequests):
1620
1621 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1622
1623         Add myself to watchlist
1624         https://bugs.webkit.org/show_bug.cgi?id=144041
1625
1626         Reviewed by Alex Christensen.
1627
1628         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1629
1630         * Scripts/webkitpy/common/config/watchlist:
1631
1632 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1633
1634         [GTK] MiniBrowser should use NetworkProcess by default
1635         https://bugs.webkit.org/show_bug.cgi?id=143948
1636
1637         Reviewed by Sergio Villar Senin.
1638
1639         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1640         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1641
1642         * MiniBrowser/gtk/main.c:
1643         (main):
1644
1645 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1646
1647         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1648
1649         Unreviewed build fix.
1650
1651         * Scripts/prepare-ChangeLog:
1652         (get_function_line_ranges_for_cpp):
1653         Use grep instead of any to determine if a string is an element of an array.
1654
1655 2015-04-21  Anders Carlsson  <andersca@apple.com>
1656
1657         Fix block signatures
1658         https://bugs.webkit.org/show_bug.cgi?id=144002
1659
1660         Reviewed by Andreas Kling.
1661
1662         * MiniBrowser/mac/WK2BrowserWindowController.m:
1663         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1664
1665 2015-04-21  Philippe Normand  <pnormand@igalia.com>
1666
1667         [GTK] jhbuild should not use a branch for openwebrtc
1668         https://bugs.webkit.org/show_bug.cgi?id=143981
1669
1670         Reviewed by Carlos Garcia Campos.
1671
1672         * gtk/jhbuild.modules:
1673
1674 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
1675
1676         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1677
1678         Unreviewed build fix.
1679
1680         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1681         However, it has been exposed by List::MoreUtils since its inception. This patch uses
1682         the any function exposed by List::MoreUtils for greater compatibility.
1683
1684         * Scripts/prepare-ChangeLog:
1685         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1686         the any function in all of versions of Perl used by our infrastructure.
1687
1688 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1689
1690         Remove unnecessary logs when resetting tests.
1691
1692         * WebKitTestRunner/mac/TestControllerMac.mm:
1693         (WTR::TestController::platformResetPreferencesToConsistentValues):
1694         In r183020 I added some logs when compiling or removing content extensions fails.
1695         We often try to remove a content extension that does not exist, and that is not a problem.
1696
1697 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1698
1699         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1700         https://bugs.webkit.org/show_bug.cgi?id=143897
1701
1702         Reviewed by David Kilzer.
1703
1704         This is a speculative fix that addresses two issues:
1705
1706         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1707         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1708
1709         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1710         Before: (723, 729)
1711         After: (721, 720)
1712
1713         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1714         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1715
1716         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1717         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1718
1719         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1720
1721         2. Creating git diffs from HEAD and not origin/master by default.
1722
1723         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1724         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1725
1726         * Scripts/prepare-ChangeLog:
1727         (originalFile):
1728         Use HEAD instead of origin/master in default Git case.
1729
1730         (generateFunctionLists):
1731         Ensure that the end line is not less than the start line.
1732
1733         (extractLineRangeAfterChange):
1734         Set the end line to the start line if the end line is less than the start line.
1735
1736         (extractLineRangeBeforeChange):
1737         Ditto.
1738
1739 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1740
1741         Suppress warning in prepare-ChangeLog.
1742         https://bugs.webkit.org/show_bug.cgi?id=143882
1743
1744         Reviewed by David Kilzer.
1745
1746         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1747         instead of the deprecated smartmatch operator.
1748
1749         * Scripts/prepare-ChangeLog:
1750         Import the List::Util::any function.
1751
1752         (get_function_line_ranges_for_cpp):
1753         Use the any function instead of smartmatch.
1754
1755 2015-04-20  Anders Carlsson  <andersca@apple.com>
1756
1757         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1758         https://bugs.webkit.org/show_bug.cgi?id=143966
1759
1760         Reviewed by Dan Bernstein.
1761
1762         * MiniBrowser/mac/WK2BrowserWindowController.m:
1763         (dataTypes):
1764         (-[WK2BrowserWindowController fetchWebsiteData:]):
1765         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1766         (-[WK2BrowserWindowController clearWebsiteData:]):
1767
1768 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1769
1770         Fix content extension test flakiness.
1771         https://bugs.webkit.org/show_bug.cgi?id=143950
1772
1773         Reviewed by Brady Eidson.
1774
1775         * WebKitTestRunner/mac/TestControllerMac.mm:
1776         (WTR::TestController::platformResetPreferencesToConsistentValues):
1777         Remove the TestContentExtensions if it exists.
1778         (WTR::TestController::platformConfigureViewForTest):
1779         Log errors in case there are any.
1780
1781 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1782
1783         Properly report errors from _WKUserContentExtensionStore.
1784         https://bugs.webkit.org/show_bug.cgi?id=143808
1785
1786         Reviewed by Darin Adler.
1787
1788         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1789         (TEST_F):
1790
1791 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1792
1793         Add a rule for NetworkCache to watchlist file
1794         https://bugs.webkit.org/show_bug.cgi?id=143945
1795
1796         Reviewed by Sergio Villar Senin.
1797
1798         And add myself to the list of watchers.
1799
1800         * Scripts/webkitpy/common/config/watchlist:
1801
1802 2015-04-19  Darin Adler  <darin@apple.com>
1803
1804         Update RefPtr documentation and deprecation
1805         https://bugs.webkit.org/show_bug.cgi?id=143936
1806
1807         Reviewed by Andreas Kling.
1808
1809         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1810
1811 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1812
1813         Introduce bytecode intrinsics
1814         https://bugs.webkit.org/show_bug.cgi?id=143926
1815
1816         Reviewed by Filip Pizlo.
1817
1818         Change cpplint to accept emit_intrinsic_XXX.
1819
1820         * Scripts/webkitpy/style/checkers/cpp.py:
1821         (check_identifier_name_in_declaration):
1822
1823 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
1824
1825         Fix lldb_webkit.py to show StringImpls correctly
1826         https://bugs.webkit.org/show_bug.cgi?id=143920
1827
1828         Reviewed by Andreas Kling.
1829         
1830         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1831
1832         * lldb/lldb_webkit.py:
1833         (WTFStringImplProvider.is_8bit):
1834
1835 2015-04-17  Daniel Bates  <dabates@apple.com>
1836
1837         Not able to build WebKit against iOS Simulator 8.3 SDK
1838         https://bugs.webkit.org/show_bug.cgi?id=143883
1839
1840         Reviewed by David Kilzer.
1841
1842         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1843         so that Xcode uses them.
1844
1845         * Scripts/copy-webkitlibraries-to-product-directory:
1846
1847 2015-04-17  Beth Dakin  <bdakin@apple.com>
1848
1849         Force mouse events should go through normal mouse event handling code paths
1850         https://bugs.webkit.org/show_bug.cgi?id=143749
1851         -and corresponding-
1852         rdar://problem/20472895
1853
1854         Reviewed by Dean Jackson.
1855
1856         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1857         Since there is not a way to create an NSEventTypePressure from scratch, we 
1858         subclass NSEvent and override all of the critical methods.
1859
1860         * WebKitTestRunner/EventSenderProxy.h:
1861         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1862         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1863         (WTR::EventSendingController::mouseForceDown):
1864         (WTR::EventSendingController::mouseForceUp):
1865         (WTR::EventSendingController::mouseForceChanged):
1866         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1867         * WebKitTestRunner/TestController.cpp:
1868         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1869         * WebKitTestRunner/mac/EventSenderProxy.mm:
1870         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1871         (-[EventSenderPressureEvent timestamp]):
1872         (-[EventSenderPressureEvent type]):
1873         (-[EventSenderPressureEvent locationInWindow]):
1874         (-[EventSenderPressureEvent location]):
1875         (-[EventSenderPressureEvent stage]):
1876         (-[EventSenderPressureEvent pressure]):
1877         (-[EventSenderPressureEvent phase]):
1878         (-[EventSenderPressureEvent eventNumber]):
1879         (WTR::EventSenderProxy::mouseForceDown):
1880         (WTR::EventSenderProxy::mouseForceUp):
1881         (WTR::EventSenderProxy::mouseForceChanged):
1882
1883 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
1884
1885         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1886         https://bugs.webkit.org/show_bug.cgi?id=143885
1887
1888         Reviewed by Tim Horton.
1889
1890         Fixed a case where we have two builds with the same revision(s). An in order build
1891         is one for which the revision is strictly higher.
1892
1893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1894         (BuildbotQueue.prototype._checkForInOrderResult):
1895         (BuildbotQueue.prototype.compareIterationsByRevisions):
1896
1897 2015-04-17  Commit Queue  <commit-queue@webkit.org>
1898
1899         Unreviewed, rolling out r182912 and r182920.
1900         https://bugs.webkit.org/show_bug.cgi?id=143881
1901
1902         Build breakage in some configurations (Requested by ap on
1903         #webkit).
1904
1905         Reverted changesets:
1906
1907         "Force mouse events should go through normal mouse event
1908         handling code paths"
1909         https://bugs.webkit.org/show_bug.cgi?id=143749
1910         http://trac.webkit.org/changeset/182912
1911
1912         http://trac.webkit.org/changeset/182920
1913
1914 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1915
1916         [GTK] One more unreviewed fix after r182882.
1917
1918         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1919
1920 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1921
1922         [GTK] Unreviewed speculative clean build fix after r182882.
1923
1924         TestWebKitAPI's forwarding header generator depended on WeKit2's
1925         which generated SOUP related forwarding headers too.
1926
1927         This dependency isn't necessary and was removed by r182882 to make
1928         forwarding header generators parallelizable. But in this case
1929         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1930         should generate SOUP related forwarding headers too similar to EFL.
1931
1932         * TestWebKitAPI/PlatformGTK.cmake:
1933         * WebKitTestRunner/PlatformGTK.cmake:
1934
1935 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1936
1937         [SOUP] Redirect to non HTTP destination is broken
1938         https://bugs.webkit.org/show_bug.cgi?id=143866
1939
1940         Reviewed by Sergio Villar Senin.
1941
1942         Add a unit test to check that redirect to a data URI works.
1943
1944         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1945         (testRedirectToDataURI):
1946         (serverCallback):
1947         (beforeAll):
1948
1949 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1950
1951         Changes method of quitting iOS Simulator to be more correct.
1952         https://bugs.webkit.org/show_bug.cgi?id=143847
1953         <rdar://problem/20530344>
1954
1955         Reviewed by Darin Adler.
1956
1957         Fixes by addressing the app by ID rather than by name.
1958
1959         * Scripts/webkitdirs.pm:
1960         (quitIOSSimulator):
1961         * Scripts/webkitpy/port/ios.py:
1962         (IOSSimulatorPort.check_sys_deps):
1963
1964 2015-04-16  Anders Carlsson  <andersca@apple.com>
1965
1966         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1967         https://bugs.webkit.org/show_bug.cgi?id=143844
1968
1969         Reviewed by Dan Bernstein.
1970
1971         * MiniBrowser/mac/AppDelegate.m:
1972         (-[BrowserAppDelegate newPrivateWindow:]):
1973         * MiniBrowser/mac/WK2BrowserWindowController.m:
1974         (-[WK2BrowserWindowController initWithConfiguration:]):
1975         (-[WK2BrowserWindowController fetchWebsiteData:]):
1976         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1977         (-[WK2BrowserWindowController clearWebsiteData:]):
1978
1979 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1980
1981         32-bit build fix.
1982
1983         * WebKitTestRunner/mac/TestControllerMac.mm:
1984         (WTR::TestController::platformResetPreferencesToConsistentValues):
1985         (WTR::TestController::platformConfigureViewForTest):
1986         Added WK_API_ENABLED.
1987
1988 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1989
1990         Removed unused WKUserContentFilterRef.
1991         https://bugs.webkit.org/show_bug.cgi?id=143852
1992
1993         Reviewed by Sam Weinig.
1994
1995         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1996         * WebKitTestRunner/mac/TestControllerMac.mm:
1997         (WTR::TestController::platformResetPreferencesToConsistentValues):
1998         (WTR::TestController::platformConfigureViewForTest):
1999
2000 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2001
2002         Unreviewed. Adding myself as a commiter in contributers.json.
2003
2004         * Scripts/webkitpy/common/config/contributors.json:
2005
2006 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
2007
2008         It is very hard to attach a debugger to WebProcess to debug tests
2009         https://bugs.webkit.org/show_bug.cgi?id=143837
2010
2011         Reviewed by Chris Dumez.
2012
2013         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
2014         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
2015
2016         Now it disables all timeouts in tools, as is best for debugging tests.
2017
2018         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
2019         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
2020
2021         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
2022         now has the same functionality.
2023
2024 2015-04-16  Beth Dakin  <bdakin@apple.com>
2025
2026         Force mouse events should go through normal mouse event handling code paths
2027         https://bugs.webkit.org/show_bug.cgi?id=143749
2028         -and corresponding-
2029         rdar://problem/20472895
2030
2031         Reviewed by Dean Jackson.
2032
2033         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2034         Since there is not a way to create an NSEventTypePressure from scratch, we 
2035         subclass NSEvent and override all of the critical methods.
2036
2037         * WebKitTestRunner/EventSenderProxy.h:
2038         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2039         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2040         (WTR::EventSendingController::mouseForceDown):
2041         (WTR::EventSendingController::mouseForceUp):
2042         (WTR::EventSendingController::mouseForceChanged):
2043         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2044         * WebKitTestRunner/TestController.cpp:
2045         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2046         * WebKitTestRunner/mac/EventSenderProxy.mm:
2047         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2048         (-[EventSenderPressureEvent timestamp]):
2049         (-[EventSenderPressureEvent type]):
2050         (-[EventSenderPressureEvent locationInWindow]):
2051         (-[EventSenderPressureEvent location]):
2052         (-[EventSenderPressureEvent stage]):
2053         (-[EventSenderPressureEvent pressure]):
2054         (-[EventSenderPressureEvent phase]):
2055         (-[EventSenderPressureEvent eventNumber]):
2056         (WTR::EventSenderProxy::mouseForceDown):
2057         (WTR::EventSenderProxy::mouseForceUp):
2058         (WTR::EventSenderProxy::mouseForceChanged):
2059
2060 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2061
2062         [EFL] Bump LLVM to version 3.6.0 on X86_64
2063         https://bugs.webkit.org/show_bug.cgi?id=143604
2064
2065         Reviewed by Gyuyoung Kim.
2066
2067         * efl/jhbuild.modules:
2068         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
2069         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
2070         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
2071         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
2072
2073 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2074
2075         [EFL] Remove an unnecessary workaround from jhbuildrc
2076         https://bugs.webkit.org/show_bug.cgi?id=143823
2077
2078         Reviewed by Gyuyoung Kim.
2079
2080         * efl/jhbuildrc:
2081
2082 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2083
2084         [GTK] Run forwarding headers generator unconditionally
2085         https://bugs.webkit.org/show_bug.cgi?id=143819
2086
2087         Reviewed by Carlos Garcia Campos.
2088
2089         * TestWebKitAPI/PlatformGTK.cmake:
2090         * WebKitTestRunner/PlatformGTK.cmake:
2091
2092 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2093
2094         [EFL] Add gnutls to jhbuild.module
2095         https://bugs.webkit.org/show_bug.cgi?id=143777
2096
2097         Reviewed by Csaba Osztrogonác.
2098
2099         EFL port has required at least 3.0.0 version of gnutls since r176712.
2100         However some old linux distributions don't support 3.0.0 version. Besides
2101         other projects sometimes need to use lower version of gnutls.
2102
2103         This patch supports to download gnutls through jhbuild, and use it.
2104
2105         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
2106         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
2107
2108 2015-04-15  Mark Lam  <mark.lam@apple.com>
2109
2110         Remove obsolete VMInspector debugging tool.
2111         https://bugs.webkit.org/show_bug.cgi?id=143798
2112
2113         Reviewed by Michael Saboff.
2114
2115         * TestWebKitAPI/CMakeLists.txt:
2116         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2117         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
2120
2121 2015-04-15  Jer Noble  <jer.noble@apple.com>
2122
2123         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
2124
2125         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2126
2127 2015-04-15  Jer Noble  <jer.noble@apple.com>
2128
2129         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
2130
2131         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2132         (TestWebKitAPI::TEST_F):
2133
2134 2015-04-15  Chris Dumez  <cdumez@apple.com>
2135
2136         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
2137         https://bugs.webkit.org/show_bug.cgi?id=143779
2138
2139         Reviewed by Brent Fulgham.
2140
2141         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
2142         similarly to what is done on Mac / WK1. Without this, PageCache could
2143         stay enabled after page cache tests and cause weird behaviors.
2144
2145         * DumpRenderTree/win/DumpRenderTree.cpp:
2146         (resetWebPreferencesToConsistentValues):
2147
2148 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
2149
2150         Re-enable custom dilation for antialiased fonts
2151         https://bugs.webkit.org/show_bug.cgi?id=143738
2152
2153         Reviewed by Tim Horton.
2154         
2155         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
2156         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
2157         a private WebKit pref. This pref defaults to YES, enabling the feature by default
2158         in WK1 as we do for WK2.
2159
2160         * DumpRenderTree/mac/DumpRenderTree.mm:
2161         (resetWebPreferencesToConsistentValues):
2162         * WebKitTestRunner/TestController.cpp:
2163         (WTR::TestController::resetPreferencesToConsistentValues):
2164
2165 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
2166
2167         Correct layering violation in DumpRenderTree Build
2168         https://bugs.webkit.org/show_bug.cgi?id=143732
2169
2170         Reviewed by Simon Fraser.
2171
2172         Correct a layering violation in DumpRenderTree by calling functions on the
2173         WebCoreTestSupport library, rather than attempting to work with WebCore
2174         types directly.
2175
2176         * DumpRenderTree/mac/EventSendingController.mm:
2177         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
2178         than WebCore itself.,
2179         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
2180
2181 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
2182
2183         Add a conservative DFA minimizer for the content extension matcher
2184         https://bugs.webkit.org/show_bug.cgi?id=143501
2185
2186         Reviewed by Alex Christensen.
2187
2188         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2189         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2190
2191 2015-04-14  Daniel Bates  <dabates@apple.com>
2192
2193         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
2194         https://bugs.webkit.org/show_bug.cgi?id=143693
2195         <rdar://problem/20530316>
2196
2197         Reviewed by Tim Horton.
2198
2199         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
2200         to use the fixed layout code on iOS at this time.
2201
2202         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
2203
2204 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2205
2206         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
2207         https://bugs.webkit.org/show_bug.cgi?id=143705
2208
2209         Unreviewed change to watchlist file.
2210
2211         * Scripts/webkitpy/common/config/watchlist:
2212
2213 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
2214
2215         [EFL] favicon wasn't updated for google.com sometimes.
2216         https://bugs.webkit.org/show_bug.cgi?id=141940
2217
2218         Reviewed by Gyuyoung Kim.
2219
2220         As elm_entry_utf8_to_markup can include additional characters, parameter for the
2221         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
2222
2223         * MiniBrowser/efl/main.c:
2224         (on_url_changed):
2225
2226 2015-04-13  Tim Horton  <timothy_horton@apple.com>
2227
2228         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
2229         https://bugs.webkit.org/show_bug.cgi?id=143560
2230         <rdar://problem/16302047>
2231
2232         Reviewed by Darin Adler.
2233
2234         * MiniBrowser/mac/BrowserWindowController.h:
2235         * MiniBrowser/mac/MainMenu.xib:
2236         * MiniBrowser/mac/WK1BrowserWindowController.m:
2237         (-[WK1BrowserWindowController setScale:]):
2238         * MiniBrowser/mac/WK2BrowserWindowController.m:
2239         (viewScaleForMenuItemTag):
2240         (-[WK2BrowserWindowController setScale:]):
2241         (-[WK2BrowserWindowController validateMenuItem:]):
2242         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
2243         When in use, we resize the window so that the view fits correctly, and
2244         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2245         layout size will not change when scaling down (but will update appropriately
2246         when the view is resized).
2247
2248 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2249
2250         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2251         https://bugs.webkit.org/show_bug.cgi?id=138630
2252
2253         Reviewed by Tim Horton.
2254
2255         Make sure that we always load at least one in order productive iteration.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2258         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2259         is done loading at least one iteration that wasn't an out of order build.
2260         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2261         when that's needed to check for out of order builds.
2262         (BuildbotQueue.prototype.update): Ditto.
2263         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2264         result, and if it does not, load more iterations.
2265         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2266         an in order iteration loaded too.
2267         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2268         corrected to always sort loaded iterations before unloaded ones.
2269
2270 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
2271
2272         Expand test infrastructure to support scrolling tests
2273         https://bugs.webkit.org/show_bug.cgi?id=143286
2274         <rdar://problem/20375516>
2275
2276         Reviewed by Simon Fraser.
2277
2278         Extend the WK1 and WK2 test programs to support two new EventSender commands:
2279         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2280         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2281         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2282         relevant rubberband, scroll, and scroll-snap animations are finished.
2283
2284         * DumpRenderTree/mac/EventSendingController.mm:
2285         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2286         and 'monitorWheelEvents'.
2287         (+[EventSendingController webScriptNameForSelector:]): Ditto.
2288         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2289         debugging test failures.
2290         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2291         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2292         function, then passes it to WebCore to be called once the test deferrals have been cleared.
2293         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2294         'callAfterScrollingCompletes' method.
2295         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2296         and 'monitorWheelEvents'.
2297         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2298         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2299         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2300         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2301         'callAfterScrollingComplates' method.
2302         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2303
2304 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2305
2306         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2307         https://bugs.webkit.org/show_bug.cgi?id=143656
2308
2309         Reviewed by Darin Adler.
2310
2311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2312         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2313
2314 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
2315
2316         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2317         https://bugs.webkit.org/show_bug.cgi?id=142387
2318
2319         Reviewed by Carlos Garcia Campos.
2320
2321         Running mixed content is blocked by default since r181134. Updated
2322         the test case to reflect the new default settings.
2323
2324         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2325         (testInsecureContent):
2326
2327 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2328
2329         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2330         https://bugs.webkit.org/show_bug.cgi?id=143667
2331
2332         Reviewed by Csaba Osztrogonác.
2333
2334         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2335         since r169017. Added $hardwareConcurrencySupport for it.
2336
2337         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2338
2339         * Scripts/webkitperl/FeatureList.pm:
2340
2341 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
2342
2343         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2344         https://bugs.webkit.org/show_bug.cgi?id=143664
2345
2346         Reviewed by Gyuyoung Kim.
2347
2348         * Scripts/webkitperl/FeatureList.pm:
2349
2350 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2351
2352         [EFL] Enable Media Source
2353         https://bugs.webkit.org/show_bug.cgi?id=143635
2354
2355         Reviewed by Csaba Osztrogonác.
2356
2357         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2358
2359 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
2360
2361         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2362         https://bugs.webkit.org/show_bug.cgi?id=143646
2363
2364         Reviewed by David Kilzer.
2365
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2367         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2368
2369 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
2370
2371         Use en_US spell checker for tests on Mac instead of Multilingual
2372         https://bugs.webkit.org/show_bug.cgi?id=143641
2373
2374         Reviewed by Dan Bernstein.
2375
2376         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2377         While at it, override NSUserDictionaryReplacementItems, so that user replacements
2378         cannot affect tests.
2379
2380         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2381         Made this more like WebKit1 version.
2382
2383 2015-04-10  Tim Horton  <timothy_horton@apple.com>
2384
2385         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2386         https://bugs.webkit.org/show_bug.cgi?id=143576
2387
2388         Reviewed by Simon Fraser.
2389
2390         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2391         (TEST):
2392         Adopt.
2393
2394 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2395
2396         Update my email address and expertise.
2397         https://bugs.webkit.org/show_bug.cgi?id=143586
2398
2399         Unreviewed, just update my info.
2400
2401         * Scripts/webkitpy/common/config/contributors.json:
2402
2403 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2404
2405         Flakiness Dashboard not loading insecure content if loaded with https URL
2406         https://bugs.webkit.org/show_bug.cgi?id=143570
2407
2408         Reviewed by Alexey Proskuryakov.
2409
2410         * TestResultServer/app.yaml:
2411         * TestResultServer/static-dashboards/loader.js:
2412         Switch to https scheme.
2413
2414 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
2415
2416         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2417         https://bugs.webkit.org/show_bug.cgi?id=142907
2418
2419         Reviewed by Carlos Garcia Campos.
2420
2421         * TestWebKitAPI/PlatformEfl.cmake:
2422         * TestWebKitAPI/PlatformGTK.cmake:
2423         * WebKitTestRunner/PlatformEfl.cmake:
2424         * WebKitTestRunner/PlatformGTK.cmake:
2425
2426 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2427
2428         [Mac] Unreviewed test fix after r182584
2429         https://bugs.webkit.org/show_bug.cgi?id=143452
2430
2431         Put both of these tests back to their original state now that the underlying
2432         problem is fixed.
2433
2434         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2435         (TestWebKitAPI::TEST):
2436         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2437         (TestWebKitAPI::TEST):
2438
2439 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
2440
2441         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2442         https://bugs.webkit.org/show_bug.cgi?id=143553
2443
2444         Reviewed by Ryosuke Niwa.
2445         
2446         Remove the spurious printVMs left over from an earlier change.
2447
2448         * Scripts/run-jsc-benchmarks:
2449
2450 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2451
2452         [Mac] Unreviewed test fix after r182581
2453
2454         The behavior of control-left-click is controlled by a system preference.
2455         Our test bots have this turned off.
2456
2457         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2458         (TestWebKitAPI::TEST):
2459         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2460         (TestWebKitAPI::TEST):
2461
2462 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2463
2464         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2465         https://bugs.webkit.org/show_bug.cgi?id=143452
2466         <rdar://problem/20437483>
2467
2468         Reviewed by Tim Horton.
2469
2470         Add a new API test to confirm that Cocoa mouse button press events are properly
2471         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2472
2473         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2474         some registered event handlers that the expected button press and context menu
2475         events are received.
2476
2477         The WK1 unit test creates an NSEvent with the desired button press state, and then
2478         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2479         We check the resulting PlatformMouseEvent for proper state.
2480
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2482         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2483         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2484         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2485         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2486         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2487         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2488         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2489         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2490         mouse down events.
2491         * TestWebKitAPI/mac/PlatformWebViewMac.h:
2492
2493 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2494
2495         [GTK] Add pango to jhbuild-optional.modules
2496         https://bugs.webkit.org/show_bug.cgi?id=143537
2497
2498         Reviewed by Martin Robinson.
2499
2500         * gtk/jhbuild-optional.modules: Add pango.
2501
2502 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2503
2504         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2505         https://bugs.webkit.org/show_bug.cgi?id=143530
2506
2507         Reviewed by Žan Doberšek.
2508
2509         Assume that the default value for display (:0) is reserved and start checking on :1
2510         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2511         and for X server named Xorg.bin (previous bug 1376599)
2512
2513         * Scripts/webkitpy/port/xvfbdriver.py:
2514         (XvfbDriver._next_free_display)
2515         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2516         (XvfbDriverTest.test_start_no_pixel_tests):
2517         (XvfbDriverTest.test_start_pixel_tests):
2518         (XvfbDriverTest.test_start_arbitrary_worker_number):
2519         (XvfbDriverTest.test_next_free_display):
2520         (XvfbDriverTest.test_start_next_worker):
2521 2015-04-08  Alex Christensen  <achristensen@webkit.org>
2522
2523         Block popups from content extensions.
2524         https://bugs.webkit.org/show_bug.cgi?id=143497
2525
2526         Reviewed by Brady Eidson.
2527
2528         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2529         (TestWebKitAPI::TEST_F):
2530         Added popup test.
2531
2532 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2533
2534         Add CMake build system for WinCairo port.
2535         https://bugs.webkit.org/show_bug.cgi?id=115944
2536
2537         Reviewed by Chris Dumez.
2538
2539         * CMakeLists.txt:
2540         * WinLauncher/CMakeLists.txt: Added.
2541
2542 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2543
2544         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2545         https://bugs.webkit.org/show_bug.cgi?id=143521
2546
2547         Reviewed by Martin Robinson.
2548
2549         Add a way to detect unexpected web process crashes to WebViewTest,
2550         and a test case to testDOMCache to trigger the crash.
2551
2552         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2553         (WebKitDOMNodeTest::testDOMCache):
2554         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2555         (testWebKitWebViewProcessCrashed):
2556         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2557         (WebViewTest::WebViewTest):
2558         (WebViewTest::webProcessCrashed):
2559         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2560
2561 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2562
2563         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2564         rdar://problem/20461342
2565
2566         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2567
2568 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2569
2570         Unreviewed, rolling out r182511.
2571         https://bugs.webkit.org/show_bug.cgi?id=143507
2572
2573         caused debug test failures (Requested by alexchristensen on
2574         #webkit).
2575
2576         Reverted changeset:
2577
2578         "Block popups from content extensions."
2579         https://bugs.webkit.org/show_bug.cgi?id=143497
2580         http://trac.webkit.org/changeset/182511
2581
2582 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2583
2584         Block popups from content extensions.
2585         https://bugs.webkit.org/show_bug.cgi?id=143497
2586
2587         Reviewed by Brady Eidson.
2588
2589         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2590         (TestWebKitAPI::TEST_F):
2591         Added popup test.
2592
2593 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2594
2595         Get the features.json files ready for open contributions
2596         https://bugs.webkit.org/show_bug.cgi?id=143436
2597
2598         Reviewed by Darin Adler.
2599
2600         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2601         (JSONFeaturesChecker.check):
2602         Extend the syntax checking a bit, but leave everything non-mandatory
2603         very loose until we figure what fields are important.
2604
2605 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2606
2607         Expose and test fixedLayoutSize via modern WebKit SPI
2608         https://bugs.webkit.org/show_bug.cgi?id=143500
2609
2610         Reviewed by Simon Fraser.
2611
2612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2613         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2614         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2615         (TEST):
2616         Add a test that verifies that fixedLayoutSize works at all, that
2617         it persists through a navigation, and that turning it back off reverts to
2618         laying out at the size of the view.
2619
2620 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2621
2622         Unreviewed. Add myself as a committer.
2623
2624         * Scripts/webkitpy/common/config/contributors.json:
2625
2626 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2627
2628         [Win] Bots complain about missing /etc/catalog
2629         https://bugs.webkit.org/show_bug.cgi?id=143484
2630
2631         Reviewed by Chris Dumez.
2632
2633         The libxml2 build on Mac, iOS, and Windows does not provide the set
2634         of default catalog files. We do not actually need these for our
2635         purposes, but we get warnings and some bot flakiness because they
2636         are not present.
2637
2638         We can avoid both problems the same way the Mac and iOS ports do,
2639         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2640         which avoid the warnings and bot problems.
2641
2642         * Scripts/webkitpy/port/win.py:
2643         (WinPort.setup_environ_for_server): Added.
2644
2645 2015-04-06  Sam Weinig  <sam@webkit.org>
2646
2647         Use content extensions in MiniBrowser.
2648         https://bugs.webkit.org/show_bug.cgi?id=143446
2649
2650         Reviewed by Alex Christensen.
2651
2652         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2653         * MiniBrowser/mac/AppDelegate.h:
2654         * MiniBrowser/mac/AppDelegate.m:
2655         (-[BrowserAppDelegate init]):
2656         (-[BrowserAppDelegate showExtensionsManager:]):
2657         (-[BrowserAppDelegate userContentContoller]):
2658         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2659         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2660         (-[ExtensionManagerWindowController init]):
2661         (-[ExtensionManagerWindowController windowDidLoad]):
2662         (-[ExtensionManagerWindowController add:]):
2663         (-[ExtensionManagerWindowController remove:]):
2664         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2665         * MiniBrowser/mac/MainMenu.xib:
2666
2667 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2668
2669         web-platform-tests server should retrieve the modules file relatively to its docroot path
2670         https://bugs.webkit.org/show_bug.cgi?id=142742
2671
2672         Reviewed by Darin Adler.
2673
2674         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2675         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2676
2677 2015-04-06  Commit Queue  <commit-queue@webkit.org>
2678
2679         Unreviewed, rolling out r182445.
2680         https://bugs.webkit.org/show_bug.cgi?id=143459
2681
2682         broke 32 bit build (Requested by alexchristensen on #webkit).
2683
2684         Reverted changeset:
2685
2686         "Use content extensions in MiniBrowser."
2687         https://bugs.webkit.org/show_bug.cgi?id=143446
2688         http://trac.webkit.org/changeset/182445
2689
2690 2015-04-06  Sam Weinig  <sam@webkit.org>
2691
2692         Use content extensions in MiniBrowser.
2693         https://bugs.webkit.org/show_bug.cgi?id=143446
2694
2695         Reviewed by Alex Christensen.
2696
2697         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2698         * MiniBrowser/mac/AppDelegate.h:
2699         * MiniBrowser/mac/AppDelegate.m:
2700         (-[BrowserAppDelegate init]):
2701         (-[BrowserAppDelegate showExtensionsManager:]):
2702         (-[BrowserAppDelegate userContentContoller]):
2703         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2704         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2705         (-[ExtensionManagerWindowController init]):
2706         (-[ExtensionManagerWindowController windowDidLoad]):
2707         (-[ExtensionManagerWindowController add:]):
2708         (-[ExtensionManagerWindowController remove:]):
2709         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2710         * MiniBrowser/mac/MainMenu.xib:
2711
2712 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2713
2714         [GTK] install-dependencies should prefer dnf to yum
2715         https://bugs.webkit.org/show_bug.cgi?id=143441
2716
2717         Reviewed by Martin Robinson.
2718
2719         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2720
2721         * gtk/install-dependencies:
2722
2723 2015-04-06  Andy Estes  <aestes@apple.com>
2724
2725         [iOS] 'make clean' fails in Tools/WebKitTestRunner
2726         https://bugs.webkit.org/show_bug.cgi?id=143455
2727
2728         Reviewed by Dan Bernstein.
2729
2730         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2731         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2732
2733         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2734
2735 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2736
2737         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2738         https://bugs.webkit.org/show_bug.cgi?id=143450
2739
2740         Reviewed by Anders Carlsson.
2741
2742         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2743         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2744         Also, removed unnecessary get() calls.
2745
2746 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2747
2748         Reduce the dependency on Flash in regression tests
2749         https://bugs.webkit.org/show_bug.cgi?id=143391
2750
2751         Reviewed by Anders Carlsson.
2752
2753         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2754         Only allow QuickTime and the test plug-in.
2755
2756 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2757
2758         W3C test importer should generate the modules installed dynamically to run wpt tests
2759         https://bugs.webkit.org/show_bug.cgi?id=142738
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2764         The implementation is done within TestDownloader and it is activated for the WPT repository.
2765         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2766
2767         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2768         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2769         * Scripts/webkitpy/w3c/test_downloader.py:
2770         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2771         (TestDownloader):
2772         (TestDownloader._git_submodules_description): Computes submodule description.
2773         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2774         * Scripts/webkitpy/w3c/test_importer.py:
2775         (TestImporter.do_import): Added the possibility to post process the tests.
2776         (TestImporter):
2777         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2778         (TestImporter.should_convert_test_harness_links): Updated according new options format.
2779         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2780         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
2781         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2782         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2783         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2784         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2785
2786 2015-04-05  Antti Koivisto  <antti@apple.com>
2787
2788         Bloom filter should support longer hashes
2789         https://bugs.webkit.org/show_bug.cgi?id=143419
2790
2791         Reviewed by Dan Bernstein.
2792
2793         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2794         (TestWebKitAPI::generateRandomDigests):
2795         (TestWebKitAPI::TEST):
2796
2797 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2798
2799         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2800         https://bugs.webkit.org/show_bug.cgi?id=143372
2801
2802         Reviewed by Darin Adler.
2803
2804         * Scripts/run-jsc-stress-tests:
2805
2806 2015-04-03  Antti Koivisto  <antti@apple.com>
2807
2808         Add non-counting bloom filter class
2809         https://bugs.webkit.org/show_bug.cgi?id=143366
2810
2811         Reviewed by Sam Weinig.
2812
2813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2814         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2815         (TestWebKitAPI::generateRandomHashes):
2816         (TestWebKitAPI::TEST):
2817
2818 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2819
2820         FTL JIT tests should fail if LLVM library isn't available
2821         https://bugs.webkit.org/show_bug.cgi?id=143374
2822
2823         Reviewed by Mark Lam.
2824
2825         * Scripts/run-jsc-stress-tests:
2826
2827 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2828
2829         [EFL] Speedup jhbuild with disable running autogen.sh
2830         https://bugs.webkit.org/show_bug.cgi?id=143369
2831
2832         Reviewed by Gyuyoung Kim.
2833
2834         * efl/jhbuild.modules:
2835
2836 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2837
2838         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2839         https://bugs.webkit.org/show_bug.cgi?id=143282
2840
2841         Reviewed by Daniel Bates.
2842
2843         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2844
2845 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2846
2847         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2848         https://bugs.webkit.org/show_bug.cgi?id=143240
2849         rdar://problem/19990425
2850
2851         Reviewed by Tim Horton.
2852
2853         * DumpRenderTree/mac/LayoutTestHelper.m:
2854         (colorProfileURLForDisplay):
2855         (saveDisplayColorProfiles):
2856         Gracefully handle it when the current profile cannot be retrieved, fixing at
2857         least one case when LayoutTestHelper couldn't start.
2858
2859         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2860         (Manager._set_up_run):
2861         (Manager._force_pixel_tests_if_needed):
2862         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2863         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2864         Return and check an error from start_helper().
2865
2866 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2867
2868         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2869         https://bugs.webkit.org/show_bug.cgi?id=143321
2870
2871         Reviewed by Alexey Proskuryakov.
2872
2873         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2874
2875 2015-04-01  Enrica Casucci  <enrica@apple.com>
2876
2877         Injected bundle messages should be at the page level.
2878         https://bugs.webkit.org/show_bug.cgi?id=143283
2879
2880         Reviewed by Alexey Proskuryakov.
2881
2882         Updating WebKitTestRunner to use the new page level messaging.
2883         The author of this patch is Tim Horton, I just finished it.
2884
2885         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2886         (WTR::EventSendingController::mouseDown):
2887         (WTR::EventSendingController::mouseUp):
2888         (WTR::EventSendingController::mouseMoveTo):
2889         (WTR::EventSendingController::leapForward):
2890         (WTR::EventSendingController::scheduleAsynchronousClick):
2891         (WTR::EventSendingController::keyDown):
2892         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2893         (WTR::EventSendingController::mouseScrollBy):
2894         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2895         (WTR::EventSendingController::continuousMouseScrollBy):
2896         (WTR::EventSendingController::addTouchPoint):
2897         (WTR::EventSendingController::updateTouchPoint):
2898         (WTR::EventSendingController::setTouchModifier):
2899         (WTR::EventSendingController::setTouchPointRadius):
2900         (WTR::EventSendingController::touchStart):
2901         (WTR::EventSendingController::touchMove):
2902         (WTR::EventSendingController::touchEnd):
2903         (WTR::EventSendingController::touchCancel):
2904         (WTR::EventSendingController::clearTouchPoints):
2905         (WTR::EventSendingController::releaseTouchPoint):
2906         (WTR::EventSendingController::cancelTouchPoint):
2907         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2908         (WTR::InjectedBundle::didReceiveMessage):
2909         (WTR::InjectedBundle::didReceiveMessageToPage):
2910         (WTR::InjectedBundle::done):
2911         (WTR::InjectedBundle::outputText):
2912         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2913         (WTR::InjectedBundle::postAddChromeInputField):
2914         (WTR::InjectedBundle::postRemoveChromeInputField):
2915         (WTR::InjectedBundle::postFocusWebView):
2916         (WTR::InjectedBundle::postSetBackingScaleFactor):
2917         (WTR::InjectedBundle::postSetWindowIsKey):
2918         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2919         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2920         (WTR::InjectedBundle::setGeolocationPermission):
2921         (WTR::InjectedBundle::setMockGeolocationPosition):
2922         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2923         (WTR::InjectedBundle::setUserMediaPermission):
2924         (WTR::InjectedBundle::setCustomPolicyDelegate):
2925         (WTR::InjectedBundle::setHidden):
2926         (WTR::InjectedBundle::setCacheModel):
2927         (WTR::InjectedBundle::shouldProcessWorkQueue):
2928         (WTR::InjectedBundle::processWorkQueue):
2929         (WTR::InjectedBundle::queueBackNavigation):
2930         (WTR::InjectedBundle::queueForwardNavigation):
2931         (WTR::InjectedBundle::queueLoad):
2932         (WTR::InjectedBundle::queueLoadHTMLString):
2933         (WTR::InjectedBundle::queueReload):
2934         (WTR::InjectedBundle::queueLoadingScript):
2935         (WTR::InjectedBundle::queueNonLoadingScript):
2936         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2937         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2938         (WTR::TestRunner::setAuthenticationUsername):
2939         (WTR::TestRunner::setAuthenticationPassword):
2940         (WTR::TestRunner::secureEventInputIsEnabled):
2941         (WTR::TestRunner::setBlockAllPlugins):
2942         * WebKitTestRunner/TestController.cpp:
2943         (WTR::TestController::createWebViewWithOptions):
2944         (WTR::TestController::resetStateToConsistentValues):
2945         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2946         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2947         * WebKitTestRunner/TestController.h:
2948         * WebKitTestRunner/TestInvocation.cpp:
2949         (WTR::TestInvocation::invoke):
2950         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2951
2952 2015-04-01  Commit Queue  <commit-queue@webkit.org>
2953
2954         Unreviewed, rolling out r182174 and r182177.
2955         https://bugs.webkit.org/show_bug.cgi?id=143314
2956
2957         Try to correct EWS failures (Requested by bfulgham on
2958         #webkit).
2959
2960         Reverted changesets:
2961
2962         "Python SCM should be able to retrieve untracked files"
2963         https://bugs.webkit.org/show_bug.cgi?id=143135
2964         http://trac.webkit.org/changeset/182174
2965
2966         "[buildbot] clean-build script should remove untracked files
2967         and revert local changes too"
2968         https://bugs.webkit.org/show_bug.cgi?id=142400
2969         http://trac.webkit.org/changeset/182177
2970
2971 2015-04-01  Alex Christensen  <achristensen@webkit.org>
2972
2973         [Content Extensions] Properly handle regexes that match everything.
2974         https://bugs.webkit.org/show_bug.cgi?id=143281
2975
2976         Reviewed by Benjamin Poulain.
2977
2978         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2979         (TestWebKitAPI::testRequest):
2980         (TestWebKitAPI::makeBackend):
2981         (TestWebKitAPI::TEST_F):
2982         Removed duplicate code and added test.
2983
2984 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
2985
2986         Content Extensions: split the state machines to minimize prefix states
2987         https://bugs.webkit.org/show_bug.cgi?id=143253
2988
2989         Reviewed by Alex Christensen.
2990
2991         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2992         (TestWebKitAPI::TEST_F):
2993         (TestWebKitAPI::testPatternStatus):
2994
2995 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
2996
2997         Clean up Identifier factories to clarify the meaning of StringImpl*
2998         https://bugs.webkit.org/show_bug.cgi?id=143146
2999
3000         Reviewed by Filip Pizlo.
3001
3002         Simple API tests for StringImpl are added.
3003
3004         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3005         (TestWebKitAPI::TEST):
3006
3007 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
3008
3009         [EFL] Add AArch64 builder and tester bot to build.webkit.org
3010         https://bugs.webkit.org/show_bug.cgi?id=143092
3011
3012         Reviewed by Gyuyoung Kim.
3013
3014         * BuildSlaveSupport/build.webkit.org-config/config.json:
3015         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3016         (Factory.__init__):
3017         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3018
3019 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3020
3021         [buildbot] clean-build script should remove untracked files and revert local changes too
3022         https://bugs.webkit.org/show_bug.cgi?id=142400
3023
3024         Reviewed by Ryosuke Niwa.
3025
3026         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3027         A helper routine SCM.discard_untracked_files is added for that purpose.
3028
3029         * BuildSlaveSupport/clean-build:
3030         (main): Making call to Scripts/clean-webkit
3031         * Scripts/clean-webkit: Added.
3032         (main): Revert changes and delete untracked files.
3033         * Scripts/webkitpy/common/checkout/scm/scm.py:
3034         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3035         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3036         (SCMTest._shared_test_discard_untracked_files):
3037         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3038
3039 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3040
3041         Python SCM should be able to retrieve untracked files
3042         https://bugs.webkit.org/show_bug.cgi?id=143135
3043
3044         Reviewed by Ryosuke Niwa.
3045
3046         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3047         Ignored files may be included or not in this list according boolean passed to the function.
3048
3049         * Scripts/webkitpy/common/checkout/scm/git.py:
3050         (Git.untracked_files):
3051         * Scripts/webkitpy/common/checkout/scm/scm.py:
3052         (SCM.untracked_files):
3053         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3054         (SCMTest._shared_test_untracked_files):
3055         (test_untracked_files):
3056         (GitSVNTest.test_untracked_files):
3057         * Scripts/webkitpy/common/checkout/scm/svn.py:
3058         (SVN.untracked_files):
3059
3060 2015-03-30  Alex Christensen  <achristensen@webkit.org>
3061
3062         [Content Extensions] Correctly handle regular expressions matching everything
3063         https://bugs.webkit.org/show_bug.cgi?id=143235
3064
3065         Reviewed by Benjamin Poulain.
3066
3067         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3068         (TestWebKitAPI::checkCompilerError):
3069         (TestWebKitAPI::TEST_F):
3070         Test ContentExtensionErrors.
3071
3072 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
3073
3074         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
3075         https://bugs.webkit.org/show_bug.cgi?id=143241
3076         rdar://problem/20351297
3077
3078         Reviewed by Mark Lam.
3079
3080         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3081
3082 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3083
3084         [CMake][EFL] Remove redundant library link and include path
3085         https://bugs.webkit.org/show_bug.cgi?id=143221
3086
3087         Reviewed by Csaba Osztrogonác.
3088
3089         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
3090
3091 2015-03-30  Sam Weinig  <sam@webkit.org>
3092
3093         [Content Extensions] Flesh out the UserContentExtensionStore
3094         https://bugs.webkit.org/show_bug.cgi?id=143123
3095
3096         Reviewed by Benjamin Poulain.
3097
3098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3099         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
3100         Add tests for _WKUserContentExtensionStore.
3101
3102 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3103
3104         Update install-dependencies Fedora packages after r181624
3105         https://bugs.webkit.org/show_bug.cgi?id=143215
3106
3107         Add json-glib, libv4l, openssl and pulseaudio development packages to
3108         the Fedora list providing we need them to build WebKit dependencies
3109         for this distribution.
3110
3111         Reviewed by Philippe Normand.
3112
3113         * gtk/install-dependencies:
3114
3115 2015-03-30  Commit Queue  <commit-queue@webkit.org>
3116
3117         Unreviewed, rolling out r182119.
3118         https://bugs.webkit.org/show_bug.cgi?id=143196
3119
3120         problem with syntax (Requested by youenn on #webkit).
3121
3122         Reverted changeset:
3123
3124         "[buildbot] clean-build script should remove untracked files
3125         and revert local changes too"
3126         https://bugs.webkit.org/show_bug.cgi?id=142400
3127         http://trac.webkit.org/changeset/182119
3128
3129 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
3130
3131         Start the features.json files
3132         https://bugs.webkit.org/show_bug.cgi?id=143207
3133
3134         Reviewed by Darin Adler.
3135
3136         I kept the style checking light. We'll have to figure
3137         what is the best format for each field.
3138
3139         * Scripts/webkitpy/style/checker.py:
3140         (CheckerDispatcher._create_checker):
3141         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3142         (JSONContributorsChecker.check):
3143         (JSONFeaturesChecker):
3144         (JSONFeaturesChecker.check):
3145
3146 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3147
3148         [buildbot] clean-build script should remove untracked files and revert local changes too
3149         https://bugs.webkit.org/show_bug.cgi?id=142400
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
3154
3155         * BuildSlaveSupport/clean-build:
3156         (main): Adding call to Tools/Scripts/clean-webkit.
3157         * Scripts/clean-webkit: Added.
3158         (main): Removes untracked and changed files.
3159         * Scripts/webkitpy/common/checkout/scm/git.py:
3160         (Git.untracked_files): Retrieves GIT untracked files.
3161         * Scripts/webkitpy/common/checkout/scm/scm.py:
3162         (SCM.untracked_files): Retrieves SVN untracked files.
3163         (SCM):
3164         (SCM.discard_untracked_files): Deletes untracked files/folders.
3165         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3166         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
3167         (test_untracked_files):
3168         (GitSVNTest.test_untracked_files):
3169         * Scripts/webkitpy/common/checkout/scm/svn.py:
3170         (SVN.untracked_files):
3171
3172 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3173
3174         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
3175         https://bugs.webkit.org/show_bug.cgi?id=143138
3176
3177         Reviewed by Csaba Osztrogonác.
3178
3179         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
3180         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
3181
3182         * ImageDiff/CMakeLists.txt:
3183         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
3184         * WebKitTestRunner/CMakeLists.txt: ditto.
3185
3186 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
3187
3188         Support building WTF on Windows without Cygwin
3189         https://bugs.webkit.org/show_bug.cgi?id=143084
3190
3191         Reviewed by Brent Fulgham.
3192
3193         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
3194         This patch also migrates to using File::Spec->catfile() for directory separators.
3195
3196         * Scripts/update-webkit-dependency:
3197         (wanted):
3198         * Scripts/update-webkit-support-libs:
3199         (wanted):
3200         (downloadExpectedVersionNumber):
3201         (zipFileVersion):
3202         (toUnixPath): Deleted.
3203         * Scripts/webkitdirs.pm:
3204         (determineSourceDir):
3205         (windowsSourceSourceDir):
3206         (windowsLibrariesDir):
3207         (windowsOutputDir):
3208         (checkInstalledTools):
3209         (buildVisualStudioProject):
3210
3211 2015-03-27  Alex Christensen  <achristensen@webkit.org>
3212
3213         Fix WinCairo bot.
3214         https://bugs.webkit.org/show_bug.cgi?id=143086
3215
3216         Reviewed by Brent Fulgham.
3217
3218         * Scripts/webkitdirs.pm:
3219         (buildVisualStudioProject):
3220         (runSvnUpdateAndResolveChangeLogs):
3221         Use ActivePerl-friendly perl.
3222
3223 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3224
3225         URTBF after r182059 to fix the EFL build.
3226
3227         * TestWebKitAPI/CMakeLists.txt:
3228
3229 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
3230
3231         Layout test results URL loads in WK1 but not WK2 minibrowser
3232         https://bugs.webkit.org/show_bug.cgi?id=143117
3233
3234         Reviewed by Tim Horton.
3235
3236         * MiniBrowser/mac/WK2BrowserWindowController.m:
3237         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
3238         everything.
3239         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
3240
3241 2015-03-26  Jer Noble  <jer.noble@apple.com>
3242
3243         Add --allowed-host support to run-webkit-tests
3244         https://bugs.webkit.org/show_bug.cgi?id=142938
3245
3246         Reviewed by Brent Fulgham.
3247
3248         Accept --allowed-host arguments from run-webkit-tests and pass them through to
3249         DumpRenderTree and WebKitTestRunner.
3250
3251         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3252         are placed in the wrong location. The argument is compared with each tests's path, and if a
3253         relative path or a path with '..' was used, results are placed alongside the test. Take the
3254         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3255
3256         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3257         (parse_args):
3258         * Scripts/webkitpy/port/base.py:
3259         (Port.__init__):
3260         (Port.allowed_hosts):
3261         * Scripts/webkitpy/port/driver.py:
3262         (Driver.cmd_line):
3263
3264 2015-03-26  Jer Noble  <jer.noble@apple.com>
3265
3266         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3267         https://bugs.webkit.org/show_bug.cgi?id=142931
3268
3269         Reviewed by Brent Fulgham.
3270
3271         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3272         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3273         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3274         runtime.
3275
3276         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
3277         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
3278
3279         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
3280         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
3281         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
3282         the top loading frame from the page, as we do elsewhere in this class.
3283
3284         * DumpRenderTree/TestRunner.h:
3285         (TestRunner::allowedHosts):
3286         (TestRunner::setAllowedHosts):
3287         * DumpRenderTree/mac/DumpRenderTree.mm:
3288         (initializeGlobalsFromCommandLineOptions):
3289         (runTest):
3290         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3291         (isAllowedHost):
3292         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3293         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3294         (WTR::InjectedBundle::didReceiveMessage):
3295         (WTR::InjectedBundle::isAllowedHost):
3296         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3297         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3298         (WTR::isAllowedHost):
3299         (WTR::InjectedBundlePage::willSendRequestForFrame):
3300         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3301         * WebKitTestRunner/Options.cpp:
3302         (WTR::handleOptionAllowedHost):
3303         (WTR::OptionsHandler::OptionsHandler):
3304         * WebKitTestRunner/Options.h:
3305         * WebKitTestRunner/TestController.cpp:
3306         (WTR::TestController::initialize):
3307         (WTR::TestController::resetStateToConsistentValues):
3308         * WebKitTestRunner/TestController.h:
3309
3310 2015-03-26  Brady Eidson  <beidson@apple.com>
3311
3312         Apply ContentExtension actions after redirects.
3313         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
3314
3315         Reviewed by Alex Christensen.
3316
3317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3318         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
3319           which is specifically interesting to a new test.
3320
3321 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3322
3323         [EFL] Disable building libseccomp on AArch64
3324         https://bugs.webkit.org/show_bug.cgi?id=143094
3325
3326         Reviewed by Gyuyoung Kim.
3327
3328         * efl/jhbuildrc:
3329
3330 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3331
3332         [jhbuild] git should use only 1 thread for cloning jhbuild
3333         https://bugs.webkit.org/show_bug.cgi?id=143095
3334
3335         Reviewed by Gyuyoung Kim.
3336
3337         * jhbuild/jhbuild-wrapper:
3338         (clone_jhbuild):
3339
3340 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
3341
3342         Update prepare-ChangeLog to work with ES6 Class syntax
3343         https://bugs.webkit.org/show_bug.cgi?id=143069
3344
3345         Reviewed by Timothy Hatcher.
3346
3347         * Scripts/prepare-ChangeLog:
3348         (get_function_line_ranges_for_javascript):
3349         Better handle ES6 Class syntax.
3350
3351         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3352         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3353         (BaseClass):
3354         (DerivedClass):
3355         (DerivedClass.staticMethod):
3356         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
3357         (DerivedClass.prototype.method):
3358         (DerivedClass.prototype.get getter):
3359         (namespace.MyClass):
3360         (namespace.MyClass.staticMethod):
3361         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
3362         (namespace.MyClass.prototype.method):
3363         (namespace.MyClass.prototype.get getter):
3364         Proof!
3365
3366 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
3367
3368         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
3369         https://bugs.webkit.org/show_bug.cgi?id=142993
3370
3371         Reviewed by Mark Lam.
3372         
3373         Bunch of support for testing executable allocation failure.
3374
3375         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
3376         (fail):
3377         * Scripts/run-javascriptcore-tests:
3378         (runJSCStressTests):
3379         * Scripts/run-jsc-stress-tests:
3380
3381 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3382
3383         Fix Windows build from r181977.
3384
3385         Unreviewed.
3386
3387         * Scripts/update-webkit-dependency:
3388
3389 2015-03-25  Sam Weinig  <sam@webkit.org>
3390
3391         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
3392
3393         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3394         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3395
3396 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3397
3398         Migrate update-webkit for Windows to not require Cygwin
3399         https://bugs.webkit.org/show_bug.cgi?id=143040
3400
3401         Reviewed by Brent Fulgham.
3402
3403         * Scripts/update-webkit-dependency:
3404         (wanted):
3405         (toUnixPath): Deleted.
3406         * Scripts/webkitdirs.pm:
3407         (fontExists):
3408         (checkInstalledTools):
3409         (setupAppleWinEnv):
3410
3411 2015-03-25  Sam Weinig  <sam@webkit.org>
3412
3413         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
3414         https://bugs.webkit.org/show_bug.cgi?id=143059
3415
3416         Reviewed by Alex Christensen.
3417
3418         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3419         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3420         Update for new interface of compileRuleList().
3421
3422 2015-03-25  Alex Christensen  <achristensen@webkit.org>
3423
3424         [Content Extensions] Add multi-DFA compiling and interpreting.
3425         https://bugs.webkit.org/show_bug.cgi?id=143010
3426
3427         Reviewed by Benjamin Poulain.
3428
3429         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3430         (TestWebKitAPI::testRequest):
3431         (TestWebKitAPI::TEST_F):
3432         Add some tests for ignore-previous-rules and large rulesets.
3433
3434 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
3435
3436         Mavericks WK1 still runs JSC tests
3437         https://bugs.webkit.org/show_bug.cgi?id=143035
3438
3439         Reviewed by Csaba Osztrogonác.
3440
3441         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
3442         with other bots.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
3445         accordingly.
3446
3447 2015-03-25  Commit Queue  <commit-queue@webkit.org>
3448
3449         Unreviewed, rolling out r181932.
3450         https://bugs.webkit.org/show_bug.cgi?id=143041
3451
3452         The test fails most of the time on bots (Requested by ap on
3453         #webkit).
3454
3455         Reverted changeset:
3456
3457         "[Content Extensions] Add multi-DFA compiling and
3458         interpreting."
3459         https://bugs.webkit.org/show_bug.cgi?id=143010
3460         http://trac.webkit.org/changeset/181932
3461
3462 2015-03-24  Alex Christensen  <achristensen@webkit.org>
3463
3464         [Content Extensions] Add multi-DFA compiling and interpreting.
3465         https://bugs.webkit.org/show_bug.cgi?id=143010
3466
3467         Reviewed by Benjamin Poulain.
3468
3469         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3470         (TestWebKitAPI::testRequest):
3471         (TestWebKitAPI::TEST_F):
3472         Add some tests for ignore-previous-rules and large rulesets.
3473
3474 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
3475
3476         Make URL filter patterns matching consistent and add a simple canonicalization step
3477         https://bugs.webkit.org/show_bug.cgi?id=142998
3478
3479         Reviewed by Alex Christensen.
3480
3481         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3482
3483 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
3484
3485         [EFL] Add OpenWebRTC in jhbuild
3486         https://bugs.webkit.org/show_bug.cgi?id=142778
3487
3488         Reviewed by Gyuyoung Kim.
3489
3490         Original patch by Philippe Normand <pnormand@igalia.com>
3491
3492         * efl/install-dependencies: Dependencies for OpenWebRTC.
3493         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
3494         the openwebrtc gst plugins.
3495
3496 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
3497
3498         Regression(r181257): WTF_WorkQueue.Simple is flaky
3499         https://bugs.webkit.org/show_bug.cgi?id=142560
3500
3501         Remove the check that the refCount has returned to one after the
3502         individual tasks have completed. It's too nondeterministic when
3503         the reference count will be reduced.
3504
3505         Reviewed by Alexey Proskuryakov
3506
3507         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3508         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
3509
3510 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3511
3512         [CMake][EFL] Put failure API test excutables into failure directory
3513         https://bugs.webkit.org/show_bug.cgi?id=142965
3514
3515         Reviewed by Csaba Osztrogonác.
3516
3517         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
3518
3519         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
3520         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
3521
3522 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
3523
3524         CSS Selectors: fix attribute case-insensitive matching of Contain and List
3525         https://bugs.webkit.org/show_bug.cgi?id=142932
3526
3527         Reviewed by Darin Adler.
3528
3529         Add tests for the new features and fix some existing tests using the 
3530         stringFromUTF8() utility recently added by Dhi.
3531
3532         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3533         (TestWebKitAPI::stringFromUTF8):
3534         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3535
3536 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3537
3538         [GTK] install-dependencies should install orc
3539         https://bugs.webkit.org/show_bug.cgi?id=142955
3540
3541         Reviewed by Martin Robinson.
3542
3543         Install orc, needed by openwebrtc
3544
3545         * gtk/install-dependencies:
3546
3547 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
3548
3549         Detect when url filter pattern with groups match the empty string
3550         https://bugs.webkit.org/show_bug.cgi?id=142930
3551
3552         Reviewed by Sam Weinig.
3553
3554         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3555
3556 2015-03-22  Anders Carlsson  <andersca@apple.com>
3557
3558         _WKWebsiteDataStore should clear WebSQL databases
3559         https://bugs.webkit.org/show_bug.cgi?id=142947
3560
3561         Reviewed by Sam Weinig.
3562
3563         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3564
3565         * MiniBrowser/mac/WK2BrowserWindowController.m:
3566         (-[WK2BrowserWindowController fetchWebsiteData:]):
3567         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3568         (-[WK2BrowserWindowController clearWebsiteData:]):
3569
3570 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
3571
3572         GCTimer should know keep track of nested GC phases
3573         https://bugs.webkit.org/show_bug.cgi?id=142675
3574
3575         Reviewed by Darin Adler.
3576
3577         Adds a tool to aid in parsing the GC phase timing output into a
3578         tree-like structure based on the parent-child relationships
3579         of nested GC phases.
3580
3581         * Scripts/parse-gc-phase-timings: Added.
3582         (Timing):
3583         (Timing.__init__):
3584         (Timing.__unicode__):
3585         (Timing.__str__):
3586         (Timing.__repr__):
3587         (parse_input):
3588         (print_timing_node):
3589         (print_timing_tree):
3590         (link_parents):
3591         (main):
3592
3593 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
3594
3595         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3596
3597         * Scripts/webkitpy/common/config/ews.json:
3598
3599 2015-03-20  Philippe Normand  <pnormand@igalia.com>
3600
3601         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3602         https://bugs.webkit.org/show_bug.cgi?id=142867
3603
3604         Rubber-stamped by Csaba Osztrogon.
3605
3606         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3607         a fixed revision for the openwebrtc-gst-plugins.
3608
3609 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3610
3611         Unreviewed build fix. Don't try to report stats for all benchmarks.
3612         Just report the geometric mean of preferred means.
3613
3614         * Scripts/run-jsc-benchmarks:
3615
3616 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3617
3618         run-jsc-benchmarks should only report preferred mean
3619         https://bugs.webkit.org/show_bug.cgi?id=142874
3620
3621         Reviewed by Geoffrey Garen.
3622
3623         Just collect statistics for the preferred mean.
3624
3625         * Scripts/run-jsc-benchmarks:
3626
3627 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3628
3629         [Content Extensions] Test regular expression parse failures.
3630         https://bugs.webkit.org/show_bug.cgi?id=142872
3631
3632         Reviewed by Benjamin Poulain.
3633
3634         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3635         (TestWebKitAPI::testPatternStatus):
3636         (TestWebKitAPI::TEST_F):
3637         Added tests for each parsing status.
3638
3639 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3640
3641         Fix API tests after r181754.
3642
3643         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3644         (TestWebKitAPI::testRequest):
3645
3646 2015-03-19  Brady Eidson  <beidson@apple.com>
3647
3648         Part of content extensions should apply css selectors
3649         https://bugs.webkit.org/show_bug.cgi?id=142604
3650
3651         Reviewed by Alex Christensen.
3652
3653         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3654         (WebCore::ContentExtensions::operator<<):
3655
3656 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
3657
3658         [Win] Activate tests on EWS
3659         https://bugs.webkit.org/show_bug.cgi?id=142850
3660
3661         Reviewed by Alexey Proskuryakov.
3662
3663         * Scripts/webkitpy/common/config/ews.json: Add me as
3664         the EWS bot watcher, and activate tests.
3665
3666 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
3667
3668         [GTK] Fix inspector userinterface related incremental build issue
3669         https://bugs.webkit.org/show_bug.cgi?id=142849
3670
3671         Reviewed by Carlos Garcia Campos.
3672
3673         * Scripts/webkitdirs.pm:
3674         (shouldRemoveCMakeCache):
3675
3676 2015-03-18  Alex Christensen  <achristensen@webkit.org>
3677
3678         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3679         https://bugs.webkit.org/show_bug.cgi?id=142799
3680
3681         Reviewed by Brady Eidson.
3682
3683         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3684         (TestWebKitAPI::testPattern):
3685         (TestWebKitAPI::TEST_F):
3686         Start testing regex failures.
3687
3688 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
3689
3690         Fix StringView typos after r181525 and r181558
3691         https://bugs.webkit.org/show_bug.cgi?id=142772
3692
3693         Reviewed by Darin Adler.
3694
3695         Add some tests in [1] to cover the StringView::startsWith, 
3696         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
3697         StringView::endsWithIgnoringASCIICase implementations.
3698
3699         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3700         (TestWebKitAPI::TEST):
3701
3702 2015-03-18  Dana Burkart  <dburkart@apple.com>
3703
3704         Remove extraneous import to fix the build.
3705
3706         Unreviewed.
3707
3708         * Scripts/webkitpy/port/driver.py:
3709
3710 2015-03-18  Dana Burkart  <dburkart@apple.com>
3711
3712         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
3713         https://bugs.webkit.org/show_bug.cgi?id=142547
3714
3715         Reviewed by Alexey Proskuryakov.
3716
3717         * Scripts/webkitpy/port/driver.py:
3718         (Driver._setup_environ_for_driver):
3719
3720 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
3721
3722         Tweak how AppleSystemFontOSSubversion default is added
3723         https://bugs.webkit.org/show_bug.cgi?id=142835
3724
3725         Reviewed by Dan Bernstein.
3726
3727         * DumpRenderTree/mac/DumpRenderTree.mm:
3728         (setDefaultsToConsistentValuesForTesting):
3729
3730 2015-03-18  Dan Bernstein  <mitz@apple.com>
3731
3732         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3733         https://bugs.webkit.org/show_bug.cgi?id=142815
3734
3735         Reviewed by Darin Adler.
3736
3737         * Scripts/prepare-ChangeLog:
3738         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3739         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3740         keep consuming the quoted text until the matching quotation mark is reached. Emit the
3741         warning only if a line ends without a backslash before the matching quotation mark was found.
3742
3743 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3744
3745         Remove unused "preprocessor" parameter to sub-CodeGenerators
3746         https://bugs.webkit.org/show_bug.cgi?id=142793
3747
3748         Reviewed by Darin Adler.
3749
3750         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3751         (new):
3752
3753 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3754
3755         [EFL] Bump gstreamer version to 1.4.4
3756         https://bugs.webkit.org/show_bug.cgi?id=142782
3757
3758         Reviewed by Philippe Normand.
3759
3760         * efl/jhbuild.modules:
3761         * efl/patches/gst-libav.patch:
3762         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3763         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3764
3765 2015-03-17  Tim Horton  <timothy_horton@apple.com>
3766
3767         Fix the iOS build.
3768
3769         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3770         (WTR::InjectedBundle::platformInitialize):
3771
3772 2015-03-17  Dean Jackson  <dino@apple.com>
3773
3774         check-webkit-style should allow "bool a : 1"
3775         https://bugs.webkit.org/show_bug.cgi?id=142794
3776
3777         Reviewed by Brent Fulgham.
3778
3779         We should allow member bitfields of the form:
3780
3781         bool m_var : 1;
3782
3783         It seems that Visual Studio 8 was the last compiler that
3784         wasn't happy about not using unsigned here. We already have
3785         about 500 cases (in WebCore) where people were ignoring this rule.
3786
3787         * Scripts/webkitpy/style/checkers/cpp.py:
3788         (check_language): Allow "bool".
3789         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3790         (CppStyleTest.test_enum_bitfields):
3791         (CppStyleTest.test_plain_integral_bitfields):
3792
3793 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
3794
3795         Compile character ranges targeting the same state as range check in the bytecode
3796         https://bugs.webkit.org/show_bug.cgi?id=142759
3797
3798         Reviewed by Alex Christensen.
3799
3800         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3801         (TestWebKitAPI::TEST_F):
3802
3803 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3804
3805         W3C test parser and converter should use test importer host
3806         https://bugs.webkit.org/show_bug.cgi?id=142729
3807
3808         Reviewed by Bem Jones-Bey.
3809
3810         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3811         This enables adding more TestImporter unit testing.
3812         This patch also ensures that the git object instantiated by TestDownloader is using the
3813         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3814
3815         * Scripts/webkitpy/common/system/filesystem_mock.py:
3816         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3817         * Scripts/webkitpy/w3c/test_downloader.py:
3818         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3819         (TestDownloader.checkout_test_repository): Making use of the new git function.
3820         * Scripts/webkitpy/w3c/test_importer.py:
3821         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3822         (TestImporter.import_tests): Adding host as parameter to the converter.
3823         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3824         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3825         (TestImporterTest):
3826         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
3827         * Scripts/webkitpy/w3c/test_parser.py:
3828         (TestParser.__init__): Adding host as parameter constructor.
3829
3830 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3831
3832         [GTK] WebKitDOM objects leaking
3833         https://bugs.webkit.org/show_bug.cgi?id=118788
3834
3835         Reviewed by Darin Adler and Sergio Villar Senin.
3836
3837         Update DOMObjectCache unit test to check that DOM objects are also
3838         released when new contents are loaded in the web view, and the old
3839         document is detached from the frame.
3840
3841         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3842         (testWebKitDOMObjectCache):
3843         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3844         (runTest):
3845
3846 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3847
3848         W3C test importer default import folder should be LayoutTests/imported/w3c
3849         https://bugs.webkit.org/show_bug.cgi?id=142728
3850
3851         Reviewed by Bem Jones-Bey.
3852
3853         * Scripts/webkitpy/w3c/test_importer.py:
3854         (parse_args): Updating the default destination option value to 'imported/w3c'.
3855
3856 2015-03-17  Philippe Normand  <pnormand@igalia.com>
3857
3858         [GTK] basic OpenWebRTC build support
3859         https://bugs.webkit.org/show_bug.cgi?id=142393
3860
3861         Reviewed by Carlos Garcia Campos.
3862
3863         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3864         is not the upstream OpenWebRTC repository. This temporary fork
3865         contains a few patches needed by WebKit for audio/video rendering.
3866
3867 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3868
3869         [CMake][EFL] Build test tools only for developer mode
3870         https://bugs.webkit.org/show_bug.cgi?id=142761
3871
3872         Reviewed by Csaba Osztrogonác.
3873
3874         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3875
3876         * CMakeLists.txt:
3877
3878 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
3879
3880         Remove never used "useLayerOnTop" bindings generator argument
3881         https://bugs.webkit.org/show_bug.cgi?id=142773
3882
3883         Reviewed by Darin Adler.
3884
3885         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3886         (new):
3887
3888 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
3889
3890         Enable ES6 classes by default
3891         https://bugs.webkit.org/show_bug.cgi?id=142774
3892
3893         Reviewed by Gavin Barraclough.
3894
3895         * Scripts/webkitperl/FeatureList.pm:
3896
3897 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3898
3899         Fix webkitpy tests after r181585.
3900
3901         Looks like "me" cannot be anyone's email, it's a special case.
3902
3903         * Scripts/webkitpy/common/config/contributors.json:
3904
3905 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3906
3907         Add tolerance to WebAudio tests
3908         https://bugs.webkit.org/show_bug.cgi?id=142676
3909
3910         Reviewed by Tim Horton.
3911
3912         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3913
3914         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3915         (TestResultWriter.create_audio_diff_and_write_result):
3916         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3917         (FailureAudio.write_failure):
3918         * Scripts/webkitpy/port/base.py:
3919         (Port.do_audio_results_differ):
3920         Diff audio failures.
3921
3922         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3923         tests to use real parseable WAV data, and got rid of base64, which there didn't
3924         seem to have been any reason for.
3925
3926 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3927
3928         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3929         https://bugs.webkit.org/show_bug.cgi?id=142720
3930
3931         Reviewed by Myles C. Maxfield.
3932
3933         Activate system copies of Microsoft fonts for the current process, thus overriding
3934         any other ones that could be preferred by the system otherwise.
3935
3936         * DumpRenderTree/mac/DumpRenderTree.mm:
3937         (activateSystemCoreWebFonts):
3938         (adjustFonts):
3939         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3940         (WTR::activateSystemCoreWebFonts):
3941         (WTR::activateFonts):
3942
3943 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3944
3945         Created Streams API watchlist
3946         https://bugs.webkit.org/show_bug.cgi?id=142684
3947
3948         Reviewed by Benjamin Poulain.
3949
3950         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
3951         watchlist and added Benjamin, Youenn and me to it.
3952
3953 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
3954
3955         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
3956         https://bugs.webkit.org/show_bug.cgi?id=142715
3957
3958         Reviewed by Brent Fulgham.
3959
3960         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3961         (TestWebKitAPI::TEST):
3962
3963 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
3964
3965         Change the exact attribute matching to be ASCII case-insensitive
3966         https://bugs.webkit.org/show_bug.cgi?id=142609
3967
3968         Reviewed by Darin Adler.
3969
3970         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3971         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3972
3973 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3974
3975         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
3976         https://bugs.webkit.org/show_bug.cgi?id=134764
3977
3978         Reviewed by Ryosuke Niwa.
3979
3980         TestDownloader is introduced to download W3C tests from the official
3981         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
3982         and https://github.com/w3c/csswg-test.git).
3983         TestDownloader clones the repositories and checkouts revisions of the tests
3984         defined in LayoutTests/imported/w3c/resources/TestRepositories.
3985
3986         Similarly to https://codereview.chromium.org/148173016,
3987         TestDownloader copies part of the files based on the rules
3988         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
3989
3990         TestDownloader is used by TestImporter when no source directory is provided.
3991
3992         * Scripts/webkitpy/w3c/test_downloader.py: Added.
3993         (TestDownloader):
3994         (TestDownloader.default_options):
3995         (TestDownloader.load_test_repositories):
3996         (TestDownloader.__init__):
3997         (TestDownloader.checkout_test_repository):
3998         (TestDownloader._init_paths_from_expectations):
3999         (TestDownloader._add_test_suite_paths):
4000         (TestDownloader._empty_directory):
4001         (TestDownloader.copy_tests):
4002         (TestDownloader.download_tests):
4003         * Scripts/webkitpy/w3c/test_importer.py:
4004         (main):
4005         (parse_args):
4006         (TestImporter.__init__):
4007         (TestImporter.do_import):
4008         (TestImporter.test_downloader):
4009         (TestImporter.find_importable_tests.should_keep_subdir):
4010         (TestImporter.should_convert_test_harness_links):
4011         (TestImporter.import_tests):
4012         (TestImporter.write_import_log):
4013
4014 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
4015
4016         [Mavericks] Test snapshots are 1600x1200 on Retina devices
4017         https://bugs.webkit.org/show_bug.cgi?id=142630
4018
4019         Reviewed by Tim Horton.
4020
4021         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
4022         Removed an ifdef that disabled the fix on Mavericks.
4023
4024 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
4025
4026         Remove isWK2 cruft from webkitdirs.pm after r170426
4027         https://bugs.webkit.org/show_bug.cgi?id=142618
4028
4029         Reviewed by Daniel Bates.
4030
4031         * Scripts/webkitdirs.pm:
4032         (isWK2): Deleted.
4033
4034 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
4035
4036         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
4037         https://bugs.webkit.org/show_bug.cgi?id=138687
4038
4039         Reviewed by Carlos Garcia Campos.
4040
4041         Always change cookie policy from UI process, as changing it from WebProcess doesn't
4042         affect other processes.
4043
4044         The implementation is imperfect, because the change happens asynchronously, but I
4045         don't expect it to be a problem in practice.
4046
4047         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4048         (WTR::InjectedBundle::beginTesting):
4049         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4050         (WTR::TestRunner::setAlwaysAcceptCookies):
4051         * WebKitTestRunner/TestInvocation.cpp:
4052         (WTR::TestInvocation::invoke):
4053         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4054
4055 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
4056
4057         [EFL] Enable building EFL 1.13 with NEON support
4058         https://bugs.webkit.org/show_bug.cgi?id=142619
4059
4060         Reviewed by Gyuyoung Kim.
4061
4062         * efl/jhbuild.modules:
4063
4064 2015-03-11  Alex Christensen  <achristensen@webkit.org>
4065
4066         [Content Extensions] Add resource type and load type triggers.
4067         https://bugs.webkit.org/show_bug.cgi?id=142422
4068
4069         Reviewed by Benjamin Poulain.
4070
4071         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4072         (TestWebKitAPI::testRequest):
4073         (TestWebKitAPI::mainDocumentRequest):
4074         (TestWebKitAPI::TEST_F):
4075         (TestWebKitAPI::testURL): Deleted.
4076
4077 2015-03-10  Sam Weinig  <sam@webkit.org>
4078
4079         Allow adding a button in input elements for auto fill related functionality
4080         <rdar://problem/19782066>
4081         https://bugs.webkit.org/show_bug.cgi?id=142564
4082
4083         Reviewed by Anders Carlsson.
4084
4085         * WebKitTestRunner/TestController.cpp:
4086         (WTR::TestController::createOtherPage):
4087         (WTR::TestController::createWebViewWithOptions):
4088         Update for new callback.
4089
4090 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
4091
4092         Add basic support for BOL and EOL assertions to the URL Filter parser
4093         https://bugs.webkit.org/show_bug.cgi?id=142568
4094
4095         Reviewed by Alex Christensen.
4096
4097         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4098         (TestWebKitAPI::TEST_F):
4099
4100 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
4101
4102         [GTK] Add support for handling TLS errors to MiniBrowser
4103         https://bugs.webkit.org/show_bug.cgi?id=142576
4104
4105         Reviewed by Sergio Villar Senin.
4106
4107         It's useful for testing TLS errors handling itself, but also to
4108         allow ignoring TLS errors when testing.
4109
4110         * MiniBrowser/gtk/BrowserWindow.c:
4111         (webViewLoadFailedWithTLSerrors):
4112         (browserWindowConstructed):
4113
4114 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
4115
4116         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
4117         https://bugs.webkit.org/show_bug.cgi?id=142569
4118
4119         Reviewed by David Hyatt.
4120
4121         Test Optional::valueOrCompute().
4122
4123         * TestWebKitAPI/Tests/WTF/Optional.cpp:
4124         (TestWebKitAPI::TEST):
4125
4126 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
4127
4128         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
4129         https://bugs.webkit.org/show_bug.cgi?id=126688
4130
4131         Reviewed by Gustavo Noronha Silva.
4132
4133         * CMakeLists.txt: Build testing tools only for developer builds,
4134         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
4135         * MiniBrowser/gtk/CMakeLists.txt: Only add
4136         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
4137         and add a rule to install the MiniBrowser.
4138         * MiniBrowser/gtk/main.c:
4139         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
4140         builds.
4141
4142 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
4143
4144         Add some DateMath tests to TestWebKitAPI
4145         https://bugs.webkit.org/show_bug.cgi?id=142565
4146
4147         Reviewed by Alexey Proskuryakov.
4148
4149         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
4150         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
4151         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
4152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
4153         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
4154
4155 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
4156
4157         Regression(r181257): WTF_WorkQueue.Simple is flaky
4158         https://bugs.webkit.org/show_bug.cgi?id=142560
4159
4160         Unreviewed attempt to improve test stability.
4161
4162         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
4163         the WorkQueue a little later to redue flakiness.
4164
4165 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
4166
4167         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
4168         https://bugs.webkit.org/show_bug.cgi?id=142555
4169
4170         Reviewed by Simon Fraser.
4171
4172         * DumpRenderTree/mac/DumpRenderTree.mm:
4173         (setDefaultsToConsistentValuesForTesting):
4174         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4175         (WTR::InjectedBundle::platformInitialize):
4176
4177 2015-03-10  Alex Christensen  <achristensen@webkit.org>
4178
4179         Use unsigned for HashSet size.
4180         https://bugs.webkit.org/show_bug.cgi?id=142518
4181
4182         Reviewed by Benjamin Poulain.
4183
4184         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4185         (TestWebKitAPI::TEST):
4186         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4187         (TestWebKitAPI::testInitialCapacity):
4188         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
4189         (TestWebKitAPI::TEST):
4190
4191 2015-03-10  Daniel Bates  <dabates@apple.com>
4192
4193         [iOS] Add WebKitSystemInterface for iOS 8.2
4194         https://bugs.webkit.org/show_bug.cgi?id=142505
4195
4196         Rubber-stamped by Anders Carlsson.
4197
4198         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
4199         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
4200         copy-webkitlibraries-to-product-directory in r181286.
4201
4202         * Scripts/copy-webkitlibraries-to-product-directory:
4203
4204 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
4205
4206         Extend URL filter's Term definition to support groups/subpatterns
4207         https://bugs.webkit.org/show_bug.cgi?id=142519
4208
4209         Reviewed by Alex Christensen.
4210
4211         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4212         (TestWebKitAPI::testURL):
4213
4214 2015-03-06  Jer Noble  <jer.noble@apple.com>
4215
4216         Add an option to run-webkit-tests to override the LayoutTests/ directory
4217         https://bugs.webkit.org/show_bug.cgi?id=142418
4218
4219         Reviewed by David Kilzer.
4220
4221         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
4222         directory. The base port will parse the options during initialization and store the override
4223         location if present. layout_tests_dir() will return this overridden location if set.
4224
4225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4226         (parse_args):
4227         * Scripts/webkitpy/port/base.py:
4228         (Port.__init__):
4229         (Port.layout_tests_dir):
4230
4231 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
4232
4233         [CMake] Enable WorkQueue tests for CMake ports
4234         https://bugs.webkit.org/show_bug.cgi?id=142473
4235
4236         Reviewed by Darin Adler.
4237
4238         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
4239         the list of source files.
4240         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
4241         to the list of include directories for EFL.
4242
4243 2015-03-09  David Kilzer  <ddkilzer@apple.com>
4244
4245         Attempt to fix timeouts on iOS Simulator layout tests
4246
4247         * Scripts/webkitpy/port/ios.py:
4248         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
4249         Simulator end after the first 50 tests time out.  Some analysis
4250         this past weekend shows that the 'Booted' status in the output
4251         of `xcrun simctl list` is not sufficient (and watching the test
4252         run shows that SpringBoard hasn't fully started to the point
4253         where it's displaying icons on the home screen).  The workaround
4254         until we have a better fix is to add an arbitrary timeout to let
4255         SpringBoard finish launching.  In practice, 15 seconds is
4256         probably enough, but 30 seconds should nearly always work.
4257
4258 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
4259
4260         Unreviewed. Add myself as a committer.
4261
4262         * Scripts/webkitpy/common/config/contributors.json:
4263
4264 2015-03-09  David Kilzer  <ddkilzer@apple.com>
4265
4266         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
4267
4268         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4269         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
4270         an expectation that will fail if we hit the race condition.
4271         This test is inherently racy and will deadlock if the first job
4272         for queue2 takes the mutex lock before the second job for
4273         queue1.
4274
4275 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
4276
4277         [Win] WTF::WorkQueue does not balance ref/deref properly
4278         https://bugs.webkit.org/show_bug.cgi?id=142471
4279
4280         Reviewed by Antti Koivisto.
4281
4282         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4283         (TestWebKitAPI::TEST): Check that the refcount is correct.
4284
4285 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4286
4287         Do not show passing test result on output of EFL layout test
4288         https://bugs.webkit.org/show_bug.cgi?id=142380
4289
4290         Reviewed by Darin Adler.
4291
4292         To show passing tests has caused inconvenience when we detect problem tests
4293         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
4294         in order not to show passing tests in the output of EFL layout test.
4295
4296         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4297         (RunWebKitTests.start):
4298
4299 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
4300
4301         Unreviewed build fix.
4302
4303         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4304         (TestWebKitAPI::TEST): Remove two unused variables.
4305
4306 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
4307
4308         Add some WorkQueue tests to TestWebKitAPI
4309         https://bugs.webkit.org/show_bug.cgi?id=142447
4310
4311         Reviewed by Sam Weinig.
4312
4313         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4314         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
4315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4316         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
4317         (TestWebKitAPI::simpleTest):
4318         (TestWebKitAPI::longTest):
4319         (TestWebKitAPI::thirdTest):
4320         (TestWebKitAPI::finishedTests):
4321         (TestWebKitAPI::TEST):
4322         (TestWebKitAPI::longTest2):
4323
4324 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4325
4326         Remove willDestroyFrame in WKBundlePageLoaderClient
4327         https://bugs.webkit.org/show_bug.cgi?id=142389
4328
4329         Reviewed by Anders Carlsson.
4330
4331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4332         (WTR::InjectedBundlePage::InjectedBundlePage):
4333
4334 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
4335
4336         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
4337         https://bugs.webkit.org/show_bug.cgi?id=142433
4338
4339         Reviewed by Darin Adler.
4340
4341         Include more TestWebKitAPI tests when building for Windows. Also
4342         fix a build error in MetaAllocator.cpp caused by one of the
4343         Microsoft headers #defining 'small'.
4344
4345         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4346         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
4347         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4348
4349 2015-03-06  Sam Weinig  <sam@webkit.org>
4350
4351         [Content Extensions] Move compiling of content extensions to the UIProcess
4352         https://bugs.webkit.org/show_bug.cgi?id=142402
4353
4354         Reviewed by Benjamin Poulain.
4355
4356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4357         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
4358         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
4359         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
4360         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
4361         (TestWebKitAPI::TEST_F):
4362         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
4363         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
4364         is now abstract).
4365
4366 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
4367
4368         [Win] Correct Windows build.
4369
4370         Rubberstamped by Michael Saboff
4371
4372         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
4373         in the GOTO labels.
4374
4375 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4376
4377         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
4378         https://bugs.webkit.org/show_bug.cgi?id=142385
4379
4380         Reviewed by Sergio Villar Senin.
4381
4382         Use stack allocated GMainLoopSources to make sure they are
4383         cancelled