Layout tests broke due to unexpected simctl output
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-09  David Kilzer  <ddkilzer@apple.com>
2
3         Layout tests broke due to unexpected simctl output
4
5         * Scripts/webkitpy/xcode/simulator.py:
6         (Simulator._parse_devices): Handle new Device Pairs header.
7         * Scripts/webkitpy/xcode/simulator_unittest.py:
8         (test_device_pairs): Add unit test for Device Pairs header.
9
10 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
11
12         Remove convenience constructors for TextRun
13         https://bugs.webkit.org/show_bug.cgi?id=144752
14
15         Reviewed by Anders Carlsson.
16
17         Test the StringView which takes a StringImpl*.
18
19         * TestWebKitAPI/Tests/WTF/StringView.cpp:
20         (StringView8Bit): Testing is8Bit() on StringView
21
22 2015-05-07  Sam Weinig  <sam@webkit.org>
23
24         [Content Extensions] Add simple tester that takes an extension and compiles it
25         https://bugs.webkit.org/show_bug.cgi?id=144781
26
27         Reviewed by Dan Bates.
28
29         * ContentExtensionTester: Added.
30         * ContentExtensionTester/Configurations: Added.
31         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
32         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
33         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
34         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
35         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
36         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
37         * ContentExtensionTester/main.m: Added.
38         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
39
40 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
41
42         Build fix.
43
44         Reviewed by Dan Bernstein.
45
46         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
47         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
48         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
49         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
50         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
51         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
52         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
53         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
54
55 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
56
57         [GTK] Some tests fail because they do not assume the popup menu captures click events
58         https://bugs.webkit.org/show_bug.cgi?id=40601
59
60         Reviewed by Carlos Garcia Campos.
61
62         Popdown all attached menus when moving between tests and between each new
63         event sent to the WebView. This prevents context and popup menus from eating
64         events.
65
66         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
67         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
68         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
69         (WTR::dispatchEvent): Popdown all menus between dispatching events.
70         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
71         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
72         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
73         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
74         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
75         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
76         longer in the platform-independent file.
77         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
78
79 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
80
81         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
82         https://bugs.webkit.org/show_bug.cgi?id=144746
83
84         Reviewed by Carlos Garcia Campos.
85
86         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
87
88         * MiniBrowser/gtk/main.c:
89         (main):
90
91 2015-05-08  Commit Queue  <commit-queue@webkit.org>
92
93         Unreviewed, rolling out r183996.
94         https://bugs.webkit.org/show_bug.cgi?id=144806
95
96         ASan detected use-after free (Requested by ap on #webkit).
97
98         Reverted changeset:
99
100         "Remove convenience constructors for TextRun"
101         https://bugs.webkit.org/show_bug.cgi?id=144752
102         http://trac.webkit.org/changeset/183996
103
104 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
105
106         Remove convenience constructors for TextRun
107         https://bugs.webkit.org/show_bug.cgi?id=144752
108
109         Reviewed by Anders Carlsson.
110
111         Test the StringView which takes a StringImpl*.
112
113         * TestWebKitAPI/Tests/WTF/StringView.cpp:
114         (StringView8Bit): Testing is8Bit() on StringView
115
116 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
117
118         [GTK] WTR doesn't correctly handle the Escape key
119         https://bugs.webkit.org/show_bug.cgi?id=144788
120
121         Reviewed by Martin Robinson.
122
123         Correctly handle 0x001B character code in GTK+ event sender to be
124         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
125         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
126         to dismiss popup menus.
127
128         Fixes editing/selection/5354455-1.html.
129
130         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
131         (WTR::getGDKKeySymForKeyRef):
132
133 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
134
135         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
136         https://bugs.webkit.org/show_bug.cgi?id=144748
137
138         Reviewed by Sergio Villar Senin.
139
140         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
141         (testWebKitSettings): Check the new setting is correctly
142         initialized and updated.
143         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
144         (testWebContextSecurityFileXHR): Check XHR to local files is
145         allowed from file URLs after changing the setting.
146         (beforeAll): Add new test.
147
148 2015-05-08  Commit Queue  <commit-queue@webkit.org>
149
150         Unreviewed, rolling out r183945.
151         https://bugs.webkit.org/show_bug.cgi?id=144789
152
153         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
154
155         Reverted changeset:
156
157         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
158         https://bugs.webkit.org/show_bug.cgi?id=144746
159         http://trac.webkit.org/changeset/183945
160
161 2015-05-07  Anders Carlsson  <andersca@apple.com>
162
163         Build fixes.
164
165         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
168         (TestWebKitAPI::TEST):
169         Add casts.
170
171 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
172
173         GC has trouble with pathologically large array allocations
174         https://bugs.webkit.org/show_bug.cgi?id=144609
175
176         Reviewed by Geoffrey Garen.
177         
178         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
179         and it's a frequently requested feature.
180         
181         Also add the ability to run a test pretending that your system has a particular RAM size.
182         This is useful for GC tests, and the new GC test that I added uses this.
183
184         * Scripts/run-javascriptcore-tests:
185         (runJSCStressTests):
186         * Scripts/run-jsc-stress-tests:
187
188 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
189
190         [EFL] Bump EFL version to 1.14.0
191         https://bugs.webkit.org/show_bug.cgi?id=144743
192
193         Reviewed by Darin Adler.
194
195         Bump EFL and elementary version to 1.14.0 and removed
196         md5sum, because it isn't used at all if hash is present.
197
198         * efl/jhbuild.modules:
199
200 2015-05-07  Saam Barati  <saambarati1@gmail.com>
201
202         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
203         https://bugs.webkit.org/show_bug.cgi?id=144753
204
205         Reviewed by Mark Lam.
206
207         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
208
209 2015-05-07  Beth Dakin  <bdakin@apple.com>
210
211         New force-related DOM events should fire in WK1 views
212         https://bugs.webkit.org/show_bug.cgi?id=144663
213         -and corresponding-
214         rdar://problem/20281886
215
216         Reviewed by Sam Weinig.
217
218         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
219         now. Just send nil. 
220         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
221         (TestWebKitAPI::buildAndPerformTest):
222
223 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
224
225         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
226         https://bugs.webkit.org/show_bug.cgi?id=144746
227
228         Reviewed by Martin Robinson.
229
230         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
231
232         * MiniBrowser/gtk/main.c:
233         (main):
234
235 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
236
237         Revert "Introducing the Platform Abstraction Layer (PAL)"
238         https://bugs.webkit.org/show_bug.cgi?id=144751
239
240         Unreviewed.
241
242         PAL should be a new target inside WebCore, rather than a top-level folder.
243
244         * Scripts/build-webkit: Add it to build-webkit.
245
246 2015-05-07  Ada Chan  <adachan@apple.com>
247
248         Add a test for WKPageCopySessionState() with filtering.
249         https://bugs.webkit.org/show_bug.cgi?id=144666
250
251         Reviewed by Darin Adler.
252
253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
254         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
255         (TestWebKitAPI::didFinishLoadForFrame):
256         (TestWebKitAPI::setPageLoaderClient):
257         (TestWebKitAPI::filterFirstItemCallback):
258         (TestWebKitAPI::filterAllItemsCallback):
259         (TestWebKitAPI::createSessionStates):
260         (TestWebKitAPI::TEST):
261
262 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
263
264         iOS build fix attempt
265
266         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
267
268         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
269
270 2015-05-06  Matt Baker  <mattbaker@apple.com>
271
272         Unreviewed, updated my list of email addresses.
273
274         * Scripts/webkitpy/common/config/contributors.json:
275
276 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
277
278         Do not link tools to WebKit2.framework
279         https://bugs.webkit.org/show_bug.cgi?id=144699
280
281         Unreviewed build fix.
282
283         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
284         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
285         These linked to WebKit2 in two ways, eliminating the other one.
286
287 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
288
289         Introducing the Platform Abstraction Layer (PAL)
290         https://bugs.webkit.org/show_bug.cgi?id=143358
291
292         Reviewed by Simon Fraser.
293
294         * Scripts/build-webkit: Add it to build-webkit.
295
296 2015-05-06  Alex Christensen  <achristensen@webkit.org>
297
298         Fix api tests after r183877.
299
300         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
301         (TestWebKitAPI::TEST_F):
302         Generate all DFAs before compiling them.
303
304 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
305
306         Do not link tools to WebKit2.framework
307         https://bugs.webkit.org/show_bug.cgi?id=144699
308
309         Reviewed by Tim Horton.
310
311         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
313         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
314
315 2015-05-06  Alex Christensen  <achristensen@webkit.org>
316
317         [Content Extensions] Test splitting NFAs by max NFA size.
318         https://bugs.webkit.org/show_bug.cgi?id=144659
319
320         Reviewed by Darin Adler.
321
322         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
323         (TestWebKitAPI::createNFAs):
324         (TestWebKitAPI::TEST_F):
325         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
326         (TestWebKitAPI::createNFAs):
327
328 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
329
330         Remove the remaining vestiges of SVG feature define
331         https://bugs.webkit.org/show_bug.cgi?id=144655
332
333         Reviewed by Alexey Proskuryakov.
334
335         * Scripts/webkitperl/FeatureList.pm:
336
337 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
338
339         Add a layout mode for computing fixed layout size from a minimum size
340         https://bugs.webkit.org/show_bug.cgi?id=144610
341         <rdar://problem/19790341>
342
343         Reviewed by Simon Fraser.
344
345         * MiniBrowser/mac/BrowserWindow.xib:
346         * MiniBrowser/mac/BrowserWindowController.h:
347         * MiniBrowser/mac/WK1BrowserWindowController.m:
348         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
349         * MiniBrowser/mac/WK2BrowserWindowController.m:
350         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
351         Add a optional toolbar item to toggle a minimum view size of 1024x0.
352
353 2015-05-05  Alex Christensen  <achristensen@webkit.org>
354
355         [Content Extensions] Release input NSString when finished copying it.
356         https://bugs.webkit.org/show_bug.cgi?id=144642
357
358         Reviewed by Brian Weinstein.
359
360         * WebKitTestRunner/mac/TestControllerMac.mm:
361         (WTR::TestController::platformConfigureViewForTest):
362         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
363
364 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
365
366         Unreviewed test fix after r183798.
367
368         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
369         (convertToDRTLabel): Mimic behavior of Mac accessibility output
370         so we can share results.
371
372 2015-05-05  Alex Christensen  <achristensen@webkit.org>
373
374         [Content Extensions] Use less memory to store the json input.
375         https://bugs.webkit.org/show_bug.cgi?id=144604
376
377         Reviewed by Benjamin Poulain.
378
379         * MiniBrowser/mac/ExtensionManagerWindowController.m:
380         (-[ExtensionManagerWindowController add:]):
381         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
382         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
383         * WebKitTestRunner/mac/TestControllerMac.mm:
384         (WTR::TestController::platformConfigureViewForTest):
385
386 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
387
388         Unreviewed. Make myself a WebKit reviewer.
389
390         * Scripts/webkitpy/common/config/contributors.json:
391
392 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
393
394         [GTK] r183783 breaks build
395         https://bugs.webkit.org/show_bug.cgi?id=144632
396
397         Reviewed by Martin Robinson.
398
399         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
400
401         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
402         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
403
404 2015-05-05  Alex Christensen  <achristensen@webkit.org>
405
406         [Content Extensions] Combine NFAs properly and free memory as we compile.
407         https://bugs.webkit.org/show_bug.cgi?id=144485
408
409         Reviewed by Benjamin Poulain.
410
411         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
412         (TestWebKitAPI::TEST_F):
413         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
414         Added tests for deep NFAs.
415
416 2015-05-04  Alex Christensen  <achristensen@webkit.org>
417
418         [Content Extensions] Use less memory when writing byte code to file
419         https://bugs.webkit.org/show_bug.cgi?id=144602
420
421         Reviewed by Darin Adler.
422
423         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
424
425 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
426
427         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
428         https://bugs.webkit.org/show_bug.cgi?id=144541
429
430         Reviewed by Žan Doberšek.
431
432         Add a test case to WorkQueue unit test, to check that sources of
433         asynchronous IO operations running in the WorkQueue thread are
434         dispatched by the WorkQueue main loop.
435
436         * TestWebKitAPI/PlatformGTK.cmake:
437         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
438         (TestWebKitAPI::TEST):
439
440 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
441
442         Correct '--show-webview' option for Tiled Drawing tests
443         https://bugs.webkit.org/show_bug.cgi?id=144621
444
445         Reviewed by Simon Fraser.
446
447         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
448         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
449
450         * WebKitTestRunner/mac/TestControllerMac.mm:
451         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
452         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
453
454 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
455
456         Large array shouldn't be slow
457         https://bugs.webkit.org/show_bug.cgi?id=144617
458
459         Reviewed by Geoffrey Garen.
460         
461         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
462         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
463         long-running. So, hash-map sort of belongs here.
464
465         * Scripts/run-jsc-benchmarks:
466
467 2015-05-04  Doug Russell  <d_russell@apple.com>
468
469         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
470         https://bugs.webkit.org/show_bug.cgi?id=144489
471
472         Reviewed by Chris Fleizach.
473
474         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
475         on the returned control.
476         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
477         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
478         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
479         Add support for setSelectedVisibleTextRange() in accessibility tests.
480
481         * DumpRenderTree/AccessibilityUIElement.cpp:
482         (setSelectedVisibleTextRangeCallback):
483         (AccessibilityUIElement::setSelectedVisibleTextRange):
484         (AccessibilityUIElement::getJSClass):
485         (AccessibilityUIElement::textMarkerForIndex): Deleted.
486         * DumpRenderTree/AccessibilityUIElement.h:
487         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
488         (AccessibilityUIElement::setSelectedVisibleTextRange):
489         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
490         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
491         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
492         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
493         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
495         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
496         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
497         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
498         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
499         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
500
501 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
502
503         [Win] Implement the "--show-webview" option for Windows
504         https://bugs.webkit.org/show_bug.cgi?id=144589
505
506         Reviewed by Alex Christensen.
507
508         Add another runtime flag (--show-webview) that causes DumpRenderTree
509         to draw its view on-screen, rather than the standard offscreen mode.
510
511         * DumpRenderTree/win/DumpRenderTree.cpp:
512         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
513         (initializeGlobalsFromCommandLineOptions): Recognize the new
514         command-line argument, and set the global 'showWebView' state if
515         appropriate.
516
517 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
518
519         Remove dead code from TestInvocationCairo.cpp
520         https://bugs.webkit.org/show_bug.cgi?id=144564
521
522         Reviewed by Gyuyoung Kim.
523
524         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
525
526         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
527         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
528
529 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
530
531         [GTK] Add libnotify in gtk install-dependencies
532         https://bugs.webkit.org/show_bug.cgi?id=144379
533
534         Reviewed by Csaba Osztrogonác.
535
536         * gtk/install-dependencies:
537
538 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
539
540         check-webkit-style fails due to system pylint
541         https://bugs.webkit.org/show_bug.cgi?id=144360
542
543         Reviewed by Darin Adler.
544
545         Make sure that the directory containing third party autoinstalled modules
546         is at the beginning of the search path, to avoid conflicts with other
547         versions of the same modules installed in the system (e.g. pylint).
548
549         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
550         modules directory to sys.path, instead of appending it.
551
552 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
553
554         Unreviewed, updated my list of email addresses.
555
556         * Scripts/webkitpy/common/config/contributors.json: Updated.
557
558 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
559
560         USE(...) macro should expect unprefixed variables
561         https://bugs.webkit.org/show_bug.cgi?id=144454
562
563         Reviewed by Daniel Bates.
564
565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
566         * DumpRenderTree/config.h: Ditto.
567         * TestWebKitAPI/config.h: Ditto.
568
569 2015-05-01  Basile Clement  <basile_clement@apple.com>
570
571         Unreviewed. Add myself as a commiter in contributors.json.
572
573         * Scripts/webkitpy/common/config/contributors.json:
574
575 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
576
577         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
578         https://bugs.webkit.org/show_bug.cgi?id=144487
579
580         Reviewed by Ryosuke Niwa.
581
582         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
583         (BenchmarkRunner.merge): Fix bug.
584         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
585
586 2015-05-01  Brady Eidson  <beidson@apple.com>
587
588         Add API to disable meta refreshes.
589         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
590
591         Reviewed by Alexey Proskuryakov.
592
593         * DumpRenderTree/mac/DumpRenderTree.mm:
594         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
595
596 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
597
598         Provide a runtime flag to run-webkit-tests that shows the test view
599         https://bugs.webkit.org/show_bug.cgi?id=144079.
600
601         Unreviewed correction to r183651.
602
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
605         flag is included in the options dictionary passed to the PlatformWebView.
606
607 2015-05-01  Antti Koivisto  <antti@apple.com>
608
609         Remove network process load serialization code
610         https://bugs.webkit.org/show_bug.cgi?id=144448
611
612         Reviewed by Alexey Proskuryakov.
613
614         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
615         (WTR::InjectedBundle::beginTesting):
616         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
617         (WTR::TestRunner::setSerializeHTTPLoads):
618         (WTR::TestRunner::dispatchPendingLoadRequests):
619
620 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
621
622         [GTK] Add libhyphen-dev to the build dependencies
623         https://bugs.webkit.org/show_bug.cgi?id=144452
624
625         Reviewed by Martin Robinson.
626
627         * gtk/install-dependencies: Added hyphen as Fedora and Arch
628         dependencies.
629
630 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
631
632         Provide a runtime flag to run-webkit-tests that shows the test view
633         https://bugs.webkit.org/show_bug.cgi?id=144079.
634
635         Reviewed by Dean Jackson.
636
637         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
638         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
639         option:
640         
641         --additional-drt-flag="--show-webview"
642
643         * DumpRenderTree/mac/DumpRenderTree.mm:
644         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
645         '--show-webview' flag.
646         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
647         * WebKitTestRunner/Options.cpp:
648         (WTR::Options::Options):
649         (WTR::handleOptionShowWebView):
650         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
651         * WebKitTestRunner/Options.h:
652         * WebKitTestRunner/TestController.cpp:
653         (WTR::TestController::TestController):
654         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
655         * WebKitTestRunner/TestController.h:
656         (WTR::TestController::shouldShowWebView):
657         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
658         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
659         options dictionary. If it is true, display the web view while running the test.
660
661 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
662
663         r183355 didn't trigger Mac tests
664         https://bugs.webkit.org/show_bug.cgi?id=144464
665
666         Reviewed by Simon Fraser.
667
668         Update badly neglected filters and unit tests.
669
670         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
671         (_should_file_trigger_build):
672         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
673         (ShouldBuildTest):
674         (ShouldBuildTest.test_should_build):
675
676 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
677
678         [GTK] Add libhyphen-dev to the build dependencies
679         https://bugs.webkit.org/show_bug.cgi?id=144452
680
681         Reviewed by Martin Robinson.
682
683         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
684         build dependencies.
685
686 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
687
688         [GTK] Testing dictionaries are not installed automatically
689         https://bugs.webkit.org/show_bug.cgi?id=144460
690
691         Reviewed by Carlos Garcia Campos.
692
693         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
694
695 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
696
697         Fix return code issue, check return code of safari process and dump results to log
698         https://bugs.webkit.org/show_bug.cgi?id=144436
699
700         Reviewed by Ryosuke Niwa.
701
702         * Scripts/run-benchmark:
703         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
704         (BenchmarkRunner.dump): Correct typo.
705         (BenchmarkRunner.wrap): Add results to console.
706         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
707         (OSXSafariDriver.prepareEnv):
708         (OSXSafariDriver.launchUrl):
709         (OSXSafariDriver.closeBrowsers):
710
711 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
712
713         Should no longer need to worry about very old versions of Xcode
714         https://bugs.webkit.org/show_bug.cgi?id=144437
715
716         Reviewed by Dan Bernstein.
717
718         * Scripts/check-for-exit-time-destructors:
719         * Scripts/check-for-global-initializers:
720         * Scripts/check-for-weak-vtables-and-externals:
721
722 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
723
724         REGRESSION(183583): [Mac] make without SDKROOT has issues
725         https://bugs.webkit.org/show_bug.cgi?id=144431
726
727         Reviewed by Dan Bernstein.
728
729         * Makefile:
730         * WebKitTestRunner/Makefile:
731         Assume an empty SDKROOT means an macosx variant, so only
732         enable settings if the SDKROOT is not empty and does not
733         contain "macosx".
734
735 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
736
737         Expand test infrastructure to support scrolling tests
738         https://bugs.webkit.org/show_bug.cgi?id=143684
739         <rdar://problem/20375516>
740
741         Reviewed by Simon Fraser.
742
743         * DumpRenderTree/mac/DumpRenderTree.mm:
744         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
745         reset before the next test run.
746         * WebKitTestRunner/TestController.cpp:
747         (WTR::TestController::resetStateToConsistentValues): Ditto."
748
749 2015-04-29  Alex Christensen  <achristensen@webkit.org>
750
751         Run javascriptcore tests on Windows without cygwin
752         https://bugs.webkit.org/show_bug.cgi?id=144419
753
754         Reviewed by Brent Fulgham.
755
756         * Scripts/run-javascriptcore-tests:
757         (runJSCStressTests):
758         Just call ruby, not /usr/bin/env ruby.
759
760 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
761
762         [GTK] Add --enable-shared option to LLVM to build mesa
763         https://bugs.webkit.org/show_bug.cgi?id=144393
764
765         Reviewed by Martin Robinson.
766
767         The updated mesa requires the shared LLVM libraries.
768         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
769         to LLVM configure script. It will provide shared libraries in addition to static libraries.
770
771         * gtk/jhbuild-optional.modules:
772
773 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
774
775         [GTK] Add support for automatic hyphenation
776         https://bugs.webkit.org/show_bug.cgi?id=44478
777
778         Reviewed by Carlos Garcia Campos.
779
780         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
781         all systems will use the same dictionaries for testing purposes.
782
783 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
784
785         Failure when building WebKit for appletvsimulator.
786         https://bugs.webkit.org/show_bug.cgi?id=144356
787
788         Reviewed by Alexey Proskuryakov.
789
790         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
791         make TVOS and WatchOS behave correctly.
792
793         * Makefile:
794         * WebKitTestRunner/Makefile:
795
796 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
797
798         Use-after-free when invalidating WKPageForceRepaint callback
799         https://bugs.webkit.org/show_bug.cgi?id=144401
800         rdar://problem/20741111
801
802         Reviewed by Tim Horton.
803
804         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
805
806         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
807         Don't do anything on error, because the context may be a stale pointer now.
808
809 2015-04-29  David Kilzer  <ddkilzer@apple.com>
810
811         check-webkit-style: Don't complain about returning value from Objective-C method call in header
812         <http://webkit.org/b/144395>
813
814         Reviewed by Andy Estes.
815
816         * Scripts/webkitpy/style/checkers/cpp.py:
817         (check_spacing): Update regex so 'return' is ignored if it
818         precedes the whitespace and bracket.  Change category name to
819         'whitespace/brackets'.  Add period to error message.
820         (CppChecker): Add 'whitespace/brackets' as a category.
821         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
822         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
823         'CppChecker.categories' since that's where the list lives now.
824         (CppStyleTest.test_spacing_before_brackets): Add tests for
825         'whitespace/brackets' issues and non-issues.
826
827 2015-04-29  Alex Christensen  <achristensen@webkit.org>
828
829         Fix WinCairo bot.
830
831         * Scripts/webkitdirs.pm:
832         (determinePassedConfiguration):
833         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
834
835 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
836
837         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
838         https://bugs.webkit.org/show_bug.cgi?id=132159
839
840         Reviewed by Darin Adler.
841
842         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
843         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
844
845         * DumpRenderTree/mac/DumpRenderTree.mm:
846         (fontWhitelist):
847         (adjustFonts):
848         (createWebViewAndOffscreenWindow):
849         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
850         (WTR::activateFonts):
851         * WebKitTestRunner/mac/TestControllerMac.mm:
852         (WTR::allowedFontFamilySet):
853         (WTR::systemHiddenFontFamilySet):
854         (WTR::generateWhitelist):
855         (WTR::TestController::platformInitializeContext):
856
857 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
858
859         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
860         https://bugs.webkit.org/show_bug.cgi?id=144155
861
862         Reviewed by Andreas Kling.
863
864         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
865         Make sure that test window is "visible" before each test. While there is no concrete
866         evidence that this is the problem indeed, the behavior is consistent with what would
867         happen for an invisible window. Also, WKTR obviously needs to do this to protect
868         against potential buggy tests that hide the window and don't show it.
869
870 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
871
872         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
873
874         Latest changes in the inspector UI made this test fail. We were
875         relying that the sidebar was always visible and the first 'li'
876         element of the inspector was the one containing the title. This is
877         no longer true, so better use document title that is not likely
878         to change.
879
880         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
881         (openRemoteDebuggingSession):
882
883 2015-04-29  Andres Gomez  <agomez@igalia.com>
884
885         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
886
887         * Scripts/webkitpy/common/config/contributors.json:
888
889 2015-04-29  Andres Gomez  <agomez@igalia.com>
890
891         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
892
893         * Scripts/webkitpy/common/config/watchlist:
894
895 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
896
897         [EFL] Allow to run the tests on the native X display
898         https://bugs.webkit.org/show_bug.cgi?id=144247
899
900         Reviewed by Gyuyoung Kim.
901
902         Added the USE_NATIVE_XDISPLAY option for the WTR.
903         We can select the Xorg driver if environment variable is set up before running the tests.
904
905         * Scripts/webkitpy/port/efl.py:
906         (EflPort._driver_class):
907
908 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
909
910         [GTK] Add libnotify-dev in gtk install-dependencies
911         https://bugs.webkit.org/show_bug.cgi?id=144379
912
913         Reviewed by Žan Doberšek.
914
915         * gtk/install-dependencies:
916
917 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
918
919         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
920         https://bugs.webkit.org/show_bug.cgi?id=143001
921
922         Reviewed by Gyuyoung Kim.
923
924         * WebKitTestRunner/TestController.cpp:
925         (WTR::shouldUseFixedLayout):
926
927 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
928
929         Increase stablility of run-benchmark script
930         https://bugs.webkit.org/show_bug.cgi?id=144361
931
932         Reviewed by Ryosuke Niwa.
933
934         * Scripts/run-benchmark:
935         (main):
936         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
937         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
938         (GenericBenchmarkBuilder.clean):
939         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
940         (BenchmarkRunner.__init__):
941         (BenchmarkRunner.execute):
942         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
943         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
944         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
945         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
946         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
947         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
948         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
949         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
950         (HTTPServerDriver.fetchResult):
951         (HTTPServerDriver):
952         (HTTPServerDriver.killServer): Add kill server interface.
953         (HTTPServerDriver.getReturnCode): Add get return code interface.
954         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
955         (SimpleHTTPServerDriver.serve):
956         (SimpleHTTPServerDriver.fetchResult):
957         (SimpleHTTPServerDriver):
958         (SimpleHTTPServerDriver.killServer):
959         (SimpleHTTPServerDriver.getReturnCode):
960         * Scripts/webkitpy/benchmark_runner/utils.py:
961         (forceRemove): Provide python version of 'rm -rf'.
962
963 2015-04-28  Sam Weinig  <sam@webkit.org>
964
965         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
966         https://bugs.webkit.org/show_bug.cgi?id=144363
967
968         Reviewed by Alex Christensen.
969
970         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
971         (TestWebKitAPI::createNFAs):
972         (TestWebKitAPI::TEST_F):
973         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
974         (TestWebKitAPI::countLiveNodes):
975         (TestWebKitAPI::createNFAs):
976         (TestWebKitAPI::buildDFAFromPatterns):
977         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
978
979 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
980
981         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
982         https://bugs.webkit.org/show_bug.cgi?id=144304
983
984         Reviewed by Geoffrey Garen.
985
986         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
987         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
988         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
989
990 2015-04-28  Commit Queue  <commit-queue@webkit.org>
991
992         Unreviewed, rolling out r183514.
993         https://bugs.webkit.org/show_bug.cgi?id=144359
994
995         It broke cloop test bots (Requested by mcatanzaro on #webkit).
996
997         Reverted changeset:
998
999         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
1000         https://bugs.webkit.org/show_bug.cgi?id=144304
1001         http://trac.webkit.org/changeset/183514
1002
1003 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1004
1005         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1006         https://bugs.webkit.org/show_bug.cgi?id=144304
1007
1008         Reviewed by Geoffrey Garen.
1009
1010         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
1011         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
1012         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1013         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1014
1015 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1016
1017         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
1018         https://bugs.webkit.org/show_bug.cgi?id=144319
1019
1020         Reviewed by Csaba Osztrogonác.
1021
1022         * TestWebKitAPI/CMakeLists.txt:
1023         * TestWebKitAPI/PlatformEfl.cmake:
1024
1025 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
1026
1027         Fix common typo "targetting" => "targeting"
1028         https://bugs.webkit.org/show_bug.cgi?id=144349
1029
1030         Reviewed by Daniel Bates.
1031
1032         * Scripts/webkitdirs.pm:
1033         (execMacWebKitAppForDebugging):
1034
1035 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1036
1037         [GTK][jhbuild] Mesa build failure with llvm 3.6
1038         https://bugs.webkit.org/show_bug.cgi?id=144250
1039
1040         Reviewed by Žan Doberšek.
1041
1042         Bump the version of Mesa to 10.5.4
1043
1044         * gtk/jhbuild.modules:
1045
1046 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
1047
1048         Disable App Nap in WebKitTestRunner UI process
1049         https://bugs.webkit.org/show_bug.cgi?id=144308
1050
1051         Reviewed by Daniel Bates.
1052
1053         * WebKitTestRunner/mac/main.mm:
1054         (disableAppNapInUIProcess):
1055         (main):
1056
1057 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1058
1059         [GTK] Update JHBuild Mesa download directory
1060         https://bugs.webkit.org/show_bug.cgi?id=144318
1061
1062         Update the download directory of Mesa module since the previous one
1063         doesn't exist any more.
1064
1065         Reviewed by Žan Doberšek.
1066
1067         * gtk/jhbuild.modules:
1068
1069 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1070
1071         Unreviewed, rolling out r183477.
1072         https://bugs.webkit.org/show_bug.cgi?id=144334
1073
1074         Roll back the Mesa dependency bump in fear of uncaught
1075         regressions while the testing bots are no-op. (Requested by
1076         zdobersek on #webkit).
1077
1078         Reverted changeset:
1079
1080         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
1081         https://bugs.webkit.org/show_bug.cgi?id=144250
1082         http://trac.webkit.org/changeset/183477
1083
1084 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1085
1086         [GTK][jhbuild] Mesa build failure with llvm 3.6
1087         https://bugs.webkit.org/show_bug.cgi?id=144250
1088
1089         Reviewed by Žan Doberšek.
1090
1091         Bump the version of Mesa to 10.5.4
1092
1093         * gtk/jhbuild.modules:
1094
1095 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
1096
1097         Add '__init__.py' and fix known bug in benchmark runner.
1098         https://bugs.webkit.org/show_bug.cgi?id=144296
1099
1100         Reviewed by Ryosuke Niwa
1101
1102         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
1103         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
1104         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1105         (BenchmarkRunner.__init__):
1106         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
1107         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
1108         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
1109
1110 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1111
1112         More build fix.
1113
1114         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1115         (-[AccessibilityNotificationHandler _notificationReceived:]):
1116         Use -objectForKey:, not array subscript.
1117
1118 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1119
1120         Catch unexpected exits in DumpRenderTree
1121         https://bugs.webkit.org/show_bug.cgi?id=144288
1122
1123         Reviewed by Tim Horton.
1124
1125         * DumpRenderTree/mac/DumpRenderTree.mm:
1126         (atexitFunction):
1127         (DumpRenderTreeMain):
1128
1129 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1130
1131         Build fix
1132
1133         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1134         (-[AccessibilityNotificationHandler _notificationReceived:]):
1135         Use -objectForKey:, not array subscript.
1136
1137 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1138
1139         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1140         https://bugs.webkit.org/show_bug.cgi?id=144155
1141
1142         Reviewed by Tim Horton.
1143
1144         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1145         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
1146         and we clearly don't want App Nap while testing.
1147
1148 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
1149
1150         [CMake] Autogenerate cmakeconfig.h.cmake
1151         https://bugs.webkit.org/show_bug.cgi?id=143997
1152
1153         Reviewed by Csaba Osztrogonác.
1154
1155         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
1156         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
1157
1158 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
1159
1160         REGRESSION(r182879): Images and video can no longer be downloaded
1161         https://bugs.webkit.org/show_bug.cgi?id=144267
1162         <rdar://problem/20702844>
1163
1164         Reviewed by Simon Fraser.
1165
1166         Revise tests to check for proper download menu state.
1167         1. Downloading a loal image should be disabled.
1168         2. Downloading a local media file should be disabled.
1169         3. Downloading non-downloadable media should be disabled.
1170
1171         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1172         (TestWebKitAPI::TEST):
1173
1174 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1175
1176         Merge run-launcher into run-minibrowser
1177         https://bugs.webkit.org/show_bug.cgi?id=141928
1178
1179         Reviewed by Darin Adler.
1180
1181         * Scripts/run-iexploder-tests:
1182         (runSafariWithIExploder):
1183         * Scripts/run-launcher: Removed.
1184         * Scripts/run-minibrowser:
1185         * Scripts/webkitdirs.pm:
1186         (launcherPath):
1187         * Scripts/webkitpy/port/efl.py:
1188         (EflPort.show_results_html_file):
1189         * Scripts/webkitpy/port/efl_unittest.py:
1190         (EflPortTest.test_show_results_html_file):
1191         * Scripts/webkitpy/port/gtk.py:
1192         (GtkPort.print_leaks_summary):
1193         (GtkPort.show_results_html_file):
1194         (GtkPort): Deleted.
1195         * Scripts/webkitpy/port/gtk_unittest.py:
1196         (GtkPortTest.test_show_results_html_file):
1197
1198 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1199
1200         [buildbot] Fix the output of perf-test buildstep on timeout
1201         https://bugs.webkit.org/show_bug.cgi?id=144097
1202
1203         Reviewed by Ryosuke Niwa.
1204
1205         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1206         (RunAndUploadPerfTests.getText2):
1207         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1208         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
1209         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1210
1211 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1212
1213         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
1214         https://bugs.webkit.org/show_bug.cgi?id=143874
1215
1216         Reviewed by Gyuyoung Kim.
1217
1218         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
1219
1220 2015-04-24  Philippe Normand  <pnormand@igalia.com>
1221
1222         [JHBuild] Move to upstream OpenWebRTC
1223         https://bugs.webkit.org/show_bug.cgi?id=144145
1224
1225         Reviewed by Carlos Garcia Campos.
1226
1227         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
1228         and add a new simple patch to gst-plugins-base, required for
1229         OpenWebRTC build.
1230         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1231         * gtk/jhbuild.modules: Ditto.
1232         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1233
1234 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1235
1236         [ES6] Implement ES6 template literals
1237         https://bugs.webkit.org/show_bug.cgi?id=142691
1238
1239         Reviewed by Darin Adler.
1240
1241         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1242
1243         * Scripts/webkitperl/FeatureList.pm:
1244
1245 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1246
1247         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
1248         https://bugs.webkit.org/show_bug.cgi?id=144217
1249
1250         Reviewed by Darin Adler.
1251
1252         * WebKitTestRunner/PlatformEfl.cmake:
1253
1254 2015-04-26  Doug Russell  <d_russell@apple.com>
1255
1256         AX: richer text change notifications (142719)
1257         https://bugs.webkit.org/show_bug.cgi?id=142719
1258
1259         Reviewed by Darin Adler.
1260
1261         Richer accessibility value change notifications. Introduce AXTextEditType,
1262         postTextStateChangeNotification and postTextReplacementNotification to give assistive
1263         tech apps more reliable context for responding to changes in web content. Also implement
1264         a mechanism to post value changes in password form fields in coalesced ticks to thwart
1265         analyzing the cadence of changes.
1266
1267         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1268         and an overload of postTextReplacementNotification to give assistive tech apps more
1269         reliable context for responding to changes in web content selection. Also block posting
1270         selection changes on password fields.
1271
1272         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1273         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1274         (-[AccessibilityNotificationHandler stopObserving]):
1275         (-[AccessibilityNotificationHandler _notificationReceived:]):
1276         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1277         (AccessibilityUIElement::removeNotificationListener):
1278         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1279         (-[AccessibilityNotificationHandler _notificationReceived:]):
1280         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1281         (WTR::AccessibilityUIElement::removeNotificationListener):
1282
1283 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
1284
1285         Add myself to contributors.json
1286         https://bugs.webkit.org/show_bug.cgi?id=144204
1287
1288         Reviewed by Darin Adler.
1289
1290         * Scripts/webkitpy/common/config/contributors.json:
1291
1292 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
1293
1294         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1295         https://bugs.webkit.org/show_bug.cgi?id=144182
1296
1297         Reviewed by Simon Fraser.
1298
1299         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1300
1301 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
1302
1303         https://bugs.webkit.org/show_bug.cgi?id=144038
1304
1305         Reviewed by Ryosuke Niwa
1306
1307         Add a script to run Speedometer and JetStream on a browser.
1308
1309         * Scripts/run-benchmark: Wrapper script to run benchmark.
1310         (main):
1311         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1312         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1313         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1314         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1315         (BenchmarkBuilderFactory):
1316         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1317         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1318         (GenericBenchmarkBuilder):
1319         (GenericBenchmarkBuilder.prepare):
1320         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1321         (GenericBenchmarkBuilder._applyPatch):
1322         (GenericBenchmarkBuilder.clean):
1323         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1324         (JetStreamBenchmarkBuilder):
1325         (JetStreamBenchmarkBuilder.prepare):
1326         (JetStreamBenchmarkBuilder._runCreateScript):
1327         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1328         (BenchmarkRunner):
1329         (BenchmarkRunner.__init__):
1330         (BenchmarkRunner.execute):
1331         (BenchmarkRunner.dump):
1332         (BenchmarkRunner.wrap):
1333         (BenchmarkRunner.merge):
1334         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1335         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1336         (BrowserDriver):
1337         (BrowserDriver.prepareEnv):
1338         (BrowserDriver.launchUrl):
1339         (BrowserDriver.closeBrowser):
1340         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1341         (BrowserDriverFactory):
1342         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1343         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1344         (OSXChromeDriver):
1345         (OSXChromeDriver.prepareEnv):
1346         (OSXChromeDriver.launchUrl):
1347         (OSXChromeDriver.closeBrowsers):
1348         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1349         (OSXSafariDriver):
1350         (OSXSafariDriver.prepareEnv):
1351         (OSXSafariDriver.launchUrl):
1352         (OSXSafariDriver.closeBrowsers):
1353         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1354         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1355         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1356         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1357         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1358         (GenericFactory):
1359         (GenericFactory.iterateGetItem):
1360         (GenericFactory.create):
1361         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1362         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1363         (ServerControl):
1364         (ServerControl.render_GET):
1365         (ServerControl.render_POST):
1366         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1367         (HTTPServerDriver):
1368         (HTTPServerDriver.serve):
1369         (HTTPServerDriver.fetchResult):
1370         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1371         (HTTPServerDriverFactory):
1372         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1373         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1374         (SimpleHTTPServerDriver):
1375         (SimpleHTTPServerDriver.depends):
1376         (SimpleHTTPServerDriver.__init__):
1377         (SimpleHTTPServerDriver.serve):
1378         (SimpleHTTPServerDriver.baseUrl):
1379         (SimpleHTTPServerDriver.fetchResult):
1380         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1381         (ModuleNotFoundError):
1382         (loadModule):
1383         (getPathFromProjectRoot):
1384         (loadJSONFromFile):
1385         (TimeoutError):
1386         (timeout):
1387         (timeout.__init__):
1388         (timeout.handle_timeout):
1389         (timeout.__enter__):
1390         (timeout.__exit__):
1391
1392 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1393
1394         Unreviewed, rolling out r183303.
1395         https://bugs.webkit.org/show_bug.cgi?id=144181
1396
1397         Change was incorrect, broke builds (Requested by smfr on
1398         #webkit).
1399
1400         Reverted changeset:
1401
1402         "Fix the build."
1403         http://trac.webkit.org/changeset/183303
1404
1405 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
1406
1407         Fix the build.
1408
1409         * MiniBrowser/mac/WK2BrowserWindowController.m:
1410         (-[WK2BrowserWindowController initWithConfiguration:]):
1411
1412 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1413
1414         Disable ActionMenusPDFTest due to timeout on test bot
1415
1416         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1417         (TestWebKitAPI::TEST):
1418
1419 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1420
1421         Unreviewed, rolling out r183266.
1422         https://bugs.webkit.org/show_bug.cgi?id=144164
1423
1424         Broke 32-bit build and a test. (Requested by ap on #webkit).
1425
1426         Reverted changeset:
1427
1428         "AX: richer text change notifications (142719)"
1429         https://bugs.webkit.org/show_bug.cgi?id=142719
1430         http://trac.webkit.org/changeset/183266
1431
1432 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1433
1434         REGRESSION: WebKit2.ActionMenusTest API test fails
1435         https://bugs.webkit.org/show_bug.cgi?id=144149
1436         <rdar://problem/20677770>
1437
1438         Reviewed by Tim Horton.
1439
1440         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1441         as the 'ActionMenusPDFTest'.
1442         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1443         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1444         to match the hit test on the 'action-menu-target.pdf' test file.
1445
1446 2015-04-24  Daniel Bates  <dabates@apple.com>
1447
1448         Cleanup: Use @memoized for property IOSSimulator.testing_device
1449         https://bugs.webkit.org/show_bug.cgi?id=141715
1450
1451         Reviewed by Darin Adler.
1452
1453         Simplify the caching of the result of IOSSimulator.testing_device
1454         and make the code more readable by making use of the @memoized declarator
1455         instead of explicitly managing a private instance variable,
1456         IOSSimulator._testing_device, for the cached result.
1457
1458         * Scripts/webkitpy/port/ios.py:
1459         (IOSPort.determine_full_port_name):
1460         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1461         (IOSSimulatorPort):
1462         (IOSSimulatorPort.testing_device): No need to cache the created device object in
1463         IOSSimulatorPort._testing_device since we are marking this function @memoized.
1464         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1465         of caching in local variable since we only make use of this value exactly once in this function.
1466         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1467         been used since being added in r178622. So, we can remove this constructor since
1468         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1469
1470 2015-04-24  Anders Carlsson  <andersca@apple.com>
1471
1472         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1473         https://bugs.webkit.org/show_bug.cgi?id=144158
1474
1475         Reviewed by Beth Dakin.
1476
1477         * MiniBrowser/mac/WK2BrowserWindowController.m:
1478         (-[WK2BrowserWindowController initWithConfiguration:]):
1479
1480 2015-04-24  Doug Russell  <d_russell@apple.com>
1481
1482         AX: richer text change notifications (142719)
1483         https://bugs.webkit.org/show_bug.cgi?id=142719
1484
1485         Reviewed by Darin Adler.
1486
1487         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1488
1489         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1490
1491         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1492         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1493         (-[AccessibilityNotificationHandler stopObserving]):
1494         (-[AccessibilityNotificationHandler _notificationReceived:]):
1495         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1496         (AccessibilityUIElement::removeNotificationListener):
1497         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1498         (-[AccessibilityNotificationHandler _notificationReceived:]):
1499         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1500         (WTR::AccessibilityUIElement::removeNotificationListener):
1501
1502 2015-04-24  Darin Adler  <darin@apple.com>
1503
1504         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1505         https://bugs.webkit.org/show_bug.cgi?id=128007
1506
1507         Reviewed by Anders Carlsson.
1508
1509         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1510         * DumpRenderTree/win/UIDelegate.h: Ditto.
1511
1512         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1513         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1514
1515         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1516
1517         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1518         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1519         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1520         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1521         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1522         (WebKitDOMDOMWindowTest::create): Ditto.
1523         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1524         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1525         of smart pointers to DelayedSIgnal objects.
1526         (uriChangedCallback): Ditto.
1527
1528 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1529
1530         [Mac] Unreviewed test fix.
1531         https://bugs.webkit.org/show_bug.cgi?id=144149
1532
1533         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1534         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1535         test.
1536
1537 2015-04-23  Darin Adler  <darin@apple.com>
1538
1539         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1540         https://bugs.webkit.org/show_bug.cgi?id=144090
1541
1542         Reviewed by Anders Carlsson.
1543
1544         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1545
1546 2015-04-23  Michael Saboff  <msaboff@apple.com>
1547
1548         lldb macro btjs sometimes can't get a frame description
1549         https://bugs.webkit.org/show_bug.cgi?id=144130
1550
1551         Reviewed by Filip Pizlo.
1552
1553         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1554         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1555         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1556
1557         * lldb/lldb_webkit.py:
1558         (btjs):
1559
1560 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1561
1562         Use less memory when compiling content extensions.
1563         https://bugs.webkit.org/show_bug.cgi?id=144051
1564
1565         Reviewed by Darin Adler and Benjamin Poulain.
1566
1567         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1568         (TestWebKitAPI::TEST_F):
1569         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1570         (TestWebKitAPI::countLiveNodes):
1571
1572 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1573
1574         [CMake] Clean up JSC JIT options
1575         https://bugs.webkit.org/show_bug.cgi?id=143998
1576
1577         Reviewed by Filip Pizlo.
1578
1579         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1580         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1581
1582 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1583
1584         [Mac] Extend action menus to support PDF
1585         https://bugs.webkit.org/show_bug.cgi?id=143895
1586         <rdar://problem/19003333>
1587
1588         Reviewed by Tim Horton.
1589
1590         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1591         of PDF content works.
1592
1593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1594         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1595         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1596         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1597         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1598         Update to support PDF tests.
1599         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1600         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1601
1602 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1603
1604         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1605
1606         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1607         (beforeAll):
1608         (testWebViewAudioOnlyUserMediaPermissionRequests):
1609
1610 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1611
1612         Add myself to watchlist
1613         https://bugs.webkit.org/show_bug.cgi?id=144041
1614
1615         Reviewed by Alex Christensen.
1616
1617         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1618
1619         * Scripts/webkitpy/common/config/watchlist:
1620
1621 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1622
1623         [GTK] MiniBrowser should use NetworkProcess by default
1624         https://bugs.webkit.org/show_bug.cgi?id=143948
1625
1626         Reviewed by Sergio Villar Senin.
1627
1628         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1629         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1630
1631         * MiniBrowser/gtk/main.c:
1632         (main):
1633
1634 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1635
1636         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1637
1638         Unreviewed build fix.
1639
1640         * Scripts/prepare-ChangeLog:
1641         (get_function_line_ranges_for_cpp):
1642         Use grep instead of any to determine if a string is an element of an array.
1643
1644 2015-04-21  Anders Carlsson  <andersca@apple.com>
1645
1646         Fix block signatures
1647         https://bugs.webkit.org/show_bug.cgi?id=144002
1648
1649         Reviewed by Andreas Kling.
1650
1651         * MiniBrowser/mac/WK2BrowserWindowController.m:
1652         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1653
1654 2015-04-21  Philippe Normand  <pnormand@igalia.com>
1655
1656         [GTK] jhbuild should not use a branch for openwebrtc
1657         https://bugs.webkit.org/show_bug.cgi?id=143981
1658
1659         Reviewed by Carlos Garcia Campos.
1660
1661         * gtk/jhbuild.modules:
1662
1663 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
1664
1665         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1666
1667         Unreviewed build fix.
1668
1669         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1670         However, it has been exposed by List::MoreUtils since its inception. This patch uses
1671         the any function exposed by List::MoreUtils for greater compatibility.
1672
1673         * Scripts/prepare-ChangeLog:
1674         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1675         the any function in all of versions of Perl used by our infrastructure.
1676
1677 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1678
1679         Remove unnecessary logs when resetting tests.
1680
1681         * WebKitTestRunner/mac/TestControllerMac.mm:
1682         (WTR::TestController::platformResetPreferencesToConsistentValues):
1683         In r183020 I added some logs when compiling or removing content extensions fails.
1684         We often try to remove a content extension that does not exist, and that is not a problem.
1685
1686 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1687
1688         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1689         https://bugs.webkit.org/show_bug.cgi?id=143897
1690
1691         Reviewed by David Kilzer.
1692
1693         This is a speculative fix that addresses two issues:
1694
1695         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1696         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1697
1698         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1699         Before: (723, 729)
1700         After: (721, 720)
1701
1702         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1703         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1704
1705         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1706         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1707
1708         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1709
1710         2. Creating git diffs from HEAD and not origin/master by default.
1711
1712         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1713         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1714
1715         * Scripts/prepare-ChangeLog:
1716         (originalFile):
1717         Use HEAD instead of origin/master in default Git case.
1718
1719         (generateFunctionLists):
1720         Ensure that the end line is not less than the start line.
1721
1722         (extractLineRangeAfterChange):
1723         Set the end line to the start line if the end line is less than the start line.
1724
1725         (extractLineRangeBeforeChange):
1726         Ditto.
1727
1728 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1729
1730         Suppress warning in prepare-ChangeLog.
1731         https://bugs.webkit.org/show_bug.cgi?id=143882
1732
1733         Reviewed by David Kilzer.
1734
1735         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1736         instead of the deprecated smartmatch operator.
1737
1738         * Scripts/prepare-ChangeLog:
1739         Import the List::Util::any function.
1740
1741         (get_function_line_ranges_for_cpp):
1742         Use the any function instead of smartmatch.
1743
1744 2015-04-20  Anders Carlsson  <andersca@apple.com>
1745
1746         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1747         https://bugs.webkit.org/show_bug.cgi?id=143966
1748
1749         Reviewed by Dan Bernstein.
1750
1751         * MiniBrowser/mac/WK2BrowserWindowController.m:
1752         (dataTypes):
1753         (-[WK2BrowserWindowController fetchWebsiteData:]):
1754         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1755         (-[WK2BrowserWindowController clearWebsiteData:]):
1756
1757 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1758
1759         Fix content extension test flakiness.
1760         https://bugs.webkit.org/show_bug.cgi?id=143950
1761
1762         Reviewed by Brady Eidson.
1763
1764         * WebKitTestRunner/mac/TestControllerMac.mm:
1765         (WTR::TestController::platformResetPreferencesToConsistentValues):
1766         Remove the TestContentExtensions if it exists.
1767         (WTR::TestController::platformConfigureViewForTest):
1768         Log errors in case there are any.
1769
1770 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1771
1772         Properly report errors from _WKUserContentExtensionStore.
1773         https://bugs.webkit.org/show_bug.cgi?id=143808
1774
1775         Reviewed by Darin Adler.
1776
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1778         (TEST_F):
1779
1780 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         Add a rule for NetworkCache to watchlist file
1783         https://bugs.webkit.org/show_bug.cgi?id=143945
1784
1785         Reviewed by Sergio Villar Senin.
1786
1787         And add myself to the list of watchers.
1788
1789         * Scripts/webkitpy/common/config/watchlist:
1790
1791 2015-04-19  Darin Adler  <darin@apple.com>
1792
1793         Update RefPtr documentation and deprecation
1794         https://bugs.webkit.org/show_bug.cgi?id=143936
1795
1796         Reviewed by Andreas Kling.
1797
1798         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1799
1800 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1801
1802         Introduce bytecode intrinsics
1803         https://bugs.webkit.org/show_bug.cgi?id=143926
1804
1805         Reviewed by Filip Pizlo.
1806
1807         Change cpplint to accept emit_intrinsic_XXX.
1808
1809         * Scripts/webkitpy/style/checkers/cpp.py:
1810         (check_identifier_name_in_declaration):
1811
1812 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
1813
1814         Fix lldb_webkit.py to show StringImpls correctly
1815         https://bugs.webkit.org/show_bug.cgi?id=143920
1816
1817         Reviewed by Andreas Kling.
1818         
1819         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1820
1821         * lldb/lldb_webkit.py:
1822         (WTFStringImplProvider.is_8bit):
1823
1824 2015-04-17  Daniel Bates  <dabates@apple.com>
1825
1826         Not able to build WebKit against iOS Simulator 8.3 SDK
1827         https://bugs.webkit.org/show_bug.cgi?id=143883
1828
1829         Reviewed by David Kilzer.
1830
1831         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1832         so that Xcode uses them.
1833
1834         * Scripts/copy-webkitlibraries-to-product-directory:
1835
1836 2015-04-17  Beth Dakin  <bdakin@apple.com>
1837
1838         Force mouse events should go through normal mouse event handling code paths
1839         https://bugs.webkit.org/show_bug.cgi?id=143749
1840         -and corresponding-
1841         rdar://problem/20472895
1842
1843         Reviewed by Dean Jackson.
1844
1845         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1846         Since there is not a way to create an NSEventTypePressure from scratch, we 
1847         subclass NSEvent and override all of the critical methods.
1848
1849         * WebKitTestRunner/EventSenderProxy.h:
1850         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1851         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1852         (WTR::EventSendingController::mouseForceDown):
1853         (WTR::EventSendingController::mouseForceUp):
1854         (WTR::EventSendingController::mouseForceChanged):
1855         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1858         * WebKitTestRunner/mac/EventSenderProxy.mm:
1859         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1860         (-[EventSenderPressureEvent timestamp]):
1861         (-[EventSenderPressureEvent type]):
1862         (-[EventSenderPressureEvent locationInWindow]):
1863         (-[EventSenderPressureEvent location]):
1864         (-[EventSenderPressureEvent stage]):
1865         (-[EventSenderPressureEvent pressure]):
1866         (-[EventSenderPressureEvent phase]):
1867         (-[EventSenderPressureEvent eventNumber]):
1868         (WTR::EventSenderProxy::mouseForceDown):
1869         (WTR::EventSenderProxy::mouseForceUp):
1870         (WTR::EventSenderProxy::mouseForceChanged):
1871
1872 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
1873
1874         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1875         https://bugs.webkit.org/show_bug.cgi?id=143885
1876
1877         Reviewed by Tim Horton.
1878
1879         Fixed a case where we have two builds with the same revision(s). An in order build
1880         is one for which the revision is strictly higher.
1881
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1883         (BuildbotQueue.prototype._checkForInOrderResult):
1884         (BuildbotQueue.prototype.compareIterationsByRevisions):
1885
1886 2015-04-17  Commit Queue  <commit-queue@webkit.org>
1887
1888         Unreviewed, rolling out r182912 and r182920.
1889         https://bugs.webkit.org/show_bug.cgi?id=143881
1890
1891         Build breakage in some configurations (Requested by ap on
1892         #webkit).
1893
1894         Reverted changesets:
1895
1896         "Force mouse events should go through normal mouse event
1897         handling code paths"
1898         https://bugs.webkit.org/show_bug.cgi?id=143749
1899         http://trac.webkit.org/changeset/182912
1900
1901         http://trac.webkit.org/changeset/182920
1902
1903 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1904
1905         [GTK] One more unreviewed fix after r182882.
1906
1907         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1908
1909 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1910
1911         [GTK] Unreviewed speculative clean build fix after r182882.
1912
1913         TestWebKitAPI's forwarding header generator depended on WeKit2's
1914         which generated SOUP related forwarding headers too.
1915
1916         This dependency isn't necessary and was removed by r182882 to make
1917         forwarding header generators parallelizable. But in this case
1918         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1919         should generate SOUP related forwarding headers too similar to EFL.
1920
1921         * TestWebKitAPI/PlatformGTK.cmake:
1922         * WebKitTestRunner/PlatformGTK.cmake:
1923
1924 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1925
1926         [SOUP] Redirect to non HTTP destination is broken
1927         https://bugs.webkit.org/show_bug.cgi?id=143866
1928
1929         Reviewed by Sergio Villar Senin.
1930
1931         Add a unit test to check that redirect to a data URI works.
1932
1933         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1934         (testRedirectToDataURI):
1935         (serverCallback):
1936         (beforeAll):
1937
1938 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1939
1940         Changes method of quitting iOS Simulator to be more correct.
1941         https://bugs.webkit.org/show_bug.cgi?id=143847
1942         <rdar://problem/20530344>
1943
1944         Reviewed by Darin Adler.
1945
1946         Fixes by addressing the app by ID rather than by name.
1947
1948         * Scripts/webkitdirs.pm:
1949         (quitIOSSimulator):
1950         * Scripts/webkitpy/port/ios.py:
1951         (IOSSimulatorPort.check_sys_deps):
1952
1953 2015-04-16  Anders Carlsson  <andersca@apple.com>
1954
1955         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1956         https://bugs.webkit.org/show_bug.cgi?id=143844
1957
1958         Reviewed by Dan Bernstein.
1959
1960         * MiniBrowser/mac/AppDelegate.m:
1961         (-[BrowserAppDelegate newPrivateWindow:]):
1962         * MiniBrowser/mac/WK2BrowserWindowController.m:
1963         (-[WK2BrowserWindowController initWithConfiguration:]):
1964         (-[WK2BrowserWindowController fetchWebsiteData:]):
1965         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1966         (-[WK2BrowserWindowController clearWebsiteData:]):
1967
1968 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1969
1970         32-bit build fix.
1971
1972         * WebKitTestRunner/mac/TestControllerMac.mm:
1973         (WTR::TestController::platformResetPreferencesToConsistentValues):
1974         (WTR::TestController::platformConfigureViewForTest):
1975         Added WK_API_ENABLED.
1976
1977 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1978
1979         Removed unused WKUserContentFilterRef.
1980         https://bugs.webkit.org/show_bug.cgi?id=143852
1981
1982         Reviewed by Sam Weinig.
1983
1984         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1985         * WebKitTestRunner/mac/TestControllerMac.mm:
1986         (WTR::TestController::platformResetPreferencesToConsistentValues):
1987         (WTR::TestController::platformConfigureViewForTest):
1988
1989 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1990
1991         Unreviewed. Adding myself as a commiter in contributers.json.
1992
1993         * Scripts/webkitpy/common/config/contributors.json:
1994
1995 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
1996
1997         It is very hard to attach a debugger to WebProcess to debug tests
1998         https://bugs.webkit.org/show_bug.cgi?id=143837
1999
2000         Reviewed by Chris Dumez.
2001
2002         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
2003         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
2004
2005         Now it disables all timeouts in tools, as is best for debugging tests.
2006
2007         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
2008         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
2009
2010         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
2011         now has the same functionality.
2012
2013 2015-04-16  Beth Dakin  <bdakin@apple.com>
2014
2015         Force mouse events should go through normal mouse event handling code paths
2016         https://bugs.webkit.org/show_bug.cgi?id=143749
2017         -and corresponding-
2018         rdar://problem/20472895
2019
2020         Reviewed by Dean Jackson.
2021
2022         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2023         Since there is not a way to create an NSEventTypePressure from scratch, we 
2024         subclass NSEvent and override all of the critical methods.
2025
2026         * WebKitTestRunner/EventSenderProxy.h:
2027         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2028         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2029         (WTR::EventSendingController::mouseForceDown):
2030         (WTR::EventSendingController::mouseForceUp):
2031         (WTR::EventSendingController::mouseForceChanged):
2032         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2035         * WebKitTestRunner/mac/EventSenderProxy.mm:
2036         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2037         (-[EventSenderPressureEvent timestamp]):
2038         (-[EventSenderPressureEvent type]):
2039         (-[EventSenderPressureEvent locationInWindow]):
2040         (-[EventSenderPressureEvent location]):
2041         (-[EventSenderPressureEvent stage]):
2042         (-[EventSenderPressureEvent pressure]):
2043         (-[EventSenderPressureEvent phase]):
2044         (-[EventSenderPressureEvent eventNumber]):
2045         (WTR::EventSenderProxy::mouseForceDown):
2046         (WTR::EventSenderProxy::mouseForceUp):
2047         (WTR::EventSenderProxy::mouseForceChanged):
2048
2049 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2050
2051         [EFL] Bump LLVM to version 3.6.0 on X86_64
2052         https://bugs.webkit.org/show_bug.cgi?id=143604
2053
2054         Reviewed by Gyuyoung Kim.
2055
2056         * efl/jhbuild.modules:
2057         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
2058         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
2059         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
2060         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
2061
2062 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2063
2064         [EFL] Remove an unnecessary workaround from jhbuildrc
2065         https://bugs.webkit.org/show_bug.cgi?id=143823
2066
2067         Reviewed by Gyuyoung Kim.
2068
2069         * efl/jhbuildrc:
2070
2071 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2072
2073         [GTK] Run forwarding headers generator unconditionally
2074         https://bugs.webkit.org/show_bug.cgi?id=143819
2075
2076         Reviewed by Carlos Garcia Campos.
2077
2078         * TestWebKitAPI/PlatformGTK.cmake:
2079         * WebKitTestRunner/PlatformGTK.cmake:
2080
2081 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2082
2083         [EFL] Add gnutls to jhbuild.module
2084         https://bugs.webkit.org/show_bug.cgi?id=143777
2085
2086         Reviewed by Csaba Osztrogonác.
2087
2088         EFL port has required at least 3.0.0 version of gnutls since r176712.
2089         However some old linux distributions don't support 3.0.0 version. Besides
2090         other projects sometimes need to use lower version of gnutls.
2091
2092         This patch supports to download gnutls through jhbuild, and use it.
2093
2094         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
2095         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
2096
2097 2015-04-15  Mark Lam  <mark.lam@apple.com>
2098
2099         Remove obsolete VMInspector debugging tool.
2100         https://bugs.webkit.org/show_bug.cgi?id=143798
2101
2102         Reviewed by Michael Saboff.
2103
2104         * TestWebKitAPI/CMakeLists.txt:
2105         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2106         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2108         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
2109
2110 2015-04-15  Jer Noble  <jer.noble@apple.com>
2111
2112         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
2113
2114         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2115
2116 2015-04-15  Jer Noble  <jer.noble@apple.com>
2117
2118         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
2119
2120         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2121         (TestWebKitAPI::TEST_F):
2122
2123 2015-04-15  Chris Dumez  <cdumez@apple.com>
2124
2125         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
2126         https://bugs.webkit.org/show_bug.cgi?id=143779
2127
2128         Reviewed by Brent Fulgham.
2129
2130         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
2131         similarly to what is done on Mac / WK1. Without this, PageCache could
2132         stay enabled after page cache tests and cause weird behaviors.
2133
2134         * DumpRenderTree/win/DumpRenderTree.cpp:
2135         (resetWebPreferencesToConsistentValues):
2136
2137 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
2138
2139         Re-enable custom dilation for antialiased fonts
2140         https://bugs.webkit.org/show_bug.cgi?id=143738
2141
2142         Reviewed by Tim Horton.
2143         
2144         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
2145         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
2146         a private WebKit pref. This pref defaults to YES, enabling the feature by default
2147         in WK1 as we do for WK2.
2148
2149         * DumpRenderTree/mac/DumpRenderTree.mm:
2150         (resetWebPreferencesToConsistentValues):
2151         * WebKitTestRunner/TestController.cpp:
2152         (WTR::TestController::resetPreferencesToConsistentValues):
2153
2154 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
2155
2156         Correct layering violation in DumpRenderTree Build
2157         https://bugs.webkit.org/show_bug.cgi?id=143732
2158
2159         Reviewed by Simon Fraser.
2160
2161         Correct a layering violation in DumpRenderTree by calling functions on the
2162         WebCoreTestSupport library, rather than attempting to work with WebCore
2163         types directly.
2164
2165         * DumpRenderTree/mac/EventSendingController.mm:
2166         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
2167         than WebCore itself.,
2168         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
2169
2170 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
2171
2172         Add a conservative DFA minimizer for the content extension matcher
2173         https://bugs.webkit.org/show_bug.cgi?id=143501
2174
2175         Reviewed by Alex Christensen.
2176
2177         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2178         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2179
2180 2015-04-14  Daniel Bates  <dabates@apple.com>
2181
2182         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
2183         https://bugs.webkit.org/show_bug.cgi?id=143693
2184         <rdar://problem/20530316>
2185
2186         Reviewed by Tim Horton.
2187
2188         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
2189         to use the fixed layout code on iOS at this time.
2190
2191         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
2192
2193 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2194
2195         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
2196         https://bugs.webkit.org/show_bug.cgi?id=143705
2197
2198         Unreviewed change to watchlist file.
2199
2200         * Scripts/webkitpy/common/config/watchlist:
2201
2202 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
2203
2204         [EFL] favicon wasn't updated for google.com sometimes.
2205         https://bugs.webkit.org/show_bug.cgi?id=141940
2206
2207         Reviewed by Gyuyoung Kim.
2208
2209         As elm_entry_utf8_to_markup can include additional characters, parameter for the
2210         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
2211
2212         * MiniBrowser/efl/main.c:
2213         (on_url_changed):
2214
2215 2015-04-13  Tim Horton  <timothy_horton@apple.com>
2216
2217         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
2218         https://bugs.webkit.org/show_bug.cgi?id=143560
2219         <rdar://problem/16302047>
2220
2221         Reviewed by Darin Adler.
2222
2223         * MiniBrowser/mac/BrowserWindowController.h:
2224         * MiniBrowser/mac/MainMenu.xib:
2225         * MiniBrowser/mac/WK1BrowserWindowController.m:
2226         (-[WK1BrowserWindowController setScale:]):
2227         * MiniBrowser/mac/WK2BrowserWindowController.m:
2228         (viewScaleForMenuItemTag):
2229         (-[WK2BrowserWindowController setScale:]):
2230         (-[WK2BrowserWindowController validateMenuItem:]):
2231         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
2232         When in use, we resize the window so that the view fits correctly, and
2233         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2234         layout size will not change when scaling down (but will update appropriately
2235         when the view is resized).
2236
2237 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2238
2239         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2240         https://bugs.webkit.org/show_bug.cgi?id=138630
2241
2242         Reviewed by Tim Horton.
2243
2244         Make sure that we always load at least one in order productive iteration.
2245
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2247         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2248         is done loading at least one iteration that wasn't an out of order build.
2249         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2250         when that's needed to check for out of order builds.
2251         (BuildbotQueue.prototype.update): Ditto.
2252         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2253         result, and if it does not, load more iterations.
2254         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2255         an in order iteration loaded too.
2256         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2257         corrected to always sort loaded iterations before unloaded ones.
2258
2259 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
2260
2261         Expand test infrastructure to support scrolling tests
2262         https://bugs.webkit.org/show_bug.cgi?id=143286
2263         <rdar://problem/20375516>
2264
2265         Reviewed by Simon Fraser.
2266
2267         Extend the WK1 and WK2 test programs to support two new EventSender commands:
2268         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2269         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2270         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2271         relevant rubberband, scroll, and scroll-snap animations are finished.
2272
2273         * DumpRenderTree/mac/EventSendingController.mm:
2274         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2275         and 'monitorWheelEvents'.
2276         (+[EventSendingController webScriptNameForSelector:]): Ditto.
2277         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2278         debugging test failures.
2279         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2280         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2281         function, then passes it to WebCore to be called once the test deferrals have been cleared.
2282         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2283         'callAfterScrollingCompletes' method.
2284         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2285         and 'monitorWheelEvents'.
2286         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2287         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2288         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2289         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2290         'callAfterScrollingComplates' method.
2291         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2292
2293 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2294
2295         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2296         https://bugs.webkit.org/show_bug.cgi?id=143656
2297
2298         Reviewed by Darin Adler.
2299
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2301         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2302
2303 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
2304
2305         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2306         https://bugs.webkit.org/show_bug.cgi?id=142387
2307
2308         Reviewed by Carlos Garcia Campos.
2309
2310         Running mixed content is blocked by default since r181134. Updated
2311         the test case to reflect the new default settings.
2312
2313         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2314         (testInsecureContent):
2315
2316 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2317
2318         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2319         https://bugs.webkit.org/show_bug.cgi?id=143667
2320
2321         Reviewed by Csaba Osztrogonác.
2322
2323         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2324         since r169017. Added $hardwareConcurrencySupport for it.
2325
2326         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2327
2328         * Scripts/webkitperl/FeatureList.pm:
2329
2330 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
2331
2332         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2333         https://bugs.webkit.org/show_bug.cgi?id=143664
2334
2335         Reviewed by Gyuyoung Kim.
2336
2337         * Scripts/webkitperl/FeatureList.pm:
2338
2339 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2340
2341         [EFL] Enable Media Source
2342         https://bugs.webkit.org/show_bug.cgi?id=143635
2343
2344         Reviewed by Csaba Osztrogonác.
2345
2346         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2347
2348 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
2349
2350         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2351         https://bugs.webkit.org/show_bug.cgi?id=143646
2352
2353         Reviewed by David Kilzer.
2354
2355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2356         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2357
2358 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
2359
2360         Use en_US spell checker for tests on Mac instead of Multilingual
2361         https://bugs.webkit.org/show_bug.cgi?id=143641
2362
2363         Reviewed by Dan Bernstein.
2364
2365         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2366         While at it, override NSUserDictionaryReplacementItems, so that user replacements
2367         cannot affect tests.
2368
2369         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2370         Made this more like WebKit1 version.
2371
2372 2015-04-10  Tim Horton  <timothy_horton@apple.com>
2373
2374         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2375         https://bugs.webkit.org/show_bug.cgi?id=143576
2376
2377         Reviewed by Simon Fraser.
2378
2379         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2380         (TEST):
2381         Adopt.
2382
2383 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2384
2385         Update my email address and expertise.
2386         https://bugs.webkit.org/show_bug.cgi?id=143586
2387
2388         Unreviewed, just update my info.
2389
2390         * Scripts/webkitpy/common/config/contributors.json:
2391
2392 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2393
2394         Flakiness Dashboard not loading insecure content if loaded with https URL
2395         https://bugs.webkit.org/show_bug.cgi?id=143570
2396
2397         Reviewed by Alexey Proskuryakov.
2398
2399         * TestResultServer/app.yaml:
2400         * TestResultServer/static-dashboards/loader.js:
2401         Switch to https scheme.
2402
2403 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
2404
2405         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2406         https://bugs.webkit.org/show_bug.cgi?id=142907
2407
2408         Reviewed by Carlos Garcia Campos.
2409
2410         * TestWebKitAPI/PlatformEfl.cmake:
2411         * TestWebKitAPI/PlatformGTK.cmake:
2412         * WebKitTestRunner/PlatformEfl.cmake:
2413         * WebKitTestRunner/PlatformGTK.cmake:
2414
2415 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2416
2417         [Mac] Unreviewed test fix after r182584
2418         https://bugs.webkit.org/show_bug.cgi?id=143452
2419
2420         Put both of these tests back to their original state now that the underlying
2421         problem is fixed.
2422
2423         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2424         (TestWebKitAPI::TEST):
2425         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2426         (TestWebKitAPI::TEST):
2427
2428 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
2429
2430         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2431         https://bugs.webkit.org/show_bug.cgi?id=143553
2432
2433         Reviewed by Ryosuke Niwa.
2434         
2435         Remove the spurious printVMs left over from an earlier change.
2436
2437         * Scripts/run-jsc-benchmarks:
2438
2439 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2440
2441         [Mac] Unreviewed test fix after r182581
2442
2443         The behavior of control-left-click is controlled by a system preference.
2444         Our test bots have this turned off.
2445
2446         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2447         (TestWebKitAPI::TEST):
2448         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2449         (TestWebKitAPI::TEST):
2450
2451 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2452
2453         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2454         https://bugs.webkit.org/show_bug.cgi?id=143452
2455         <rdar://problem/20437483>
2456
2457         Reviewed by Tim Horton.
2458
2459         Add a new API test to confirm that Cocoa mouse button press events are properly
2460         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2461
2462         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2463         some registered event handlers that the expected button press and context menu
2464         events are received.
2465
2466         The WK1 unit test creates an NSEvent with the desired button press state, and then
2467         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2468         We check the resulting PlatformMouseEvent for proper state.
2469
2470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2471         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2472         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2473         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2474         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2475         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2476         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2477         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2478         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2479         mouse down events.
2480         * TestWebKitAPI/mac/PlatformWebViewMac.h:
2481
2482 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2483
2484         [GTK] Add pango to jhbuild-optional.modules
2485         https://bugs.webkit.org/show_bug.cgi?id=143537
2486
2487         Reviewed by Martin Robinson.
2488
2489         * gtk/jhbuild-optional.modules: Add pango.
2490
2491 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2492
2493         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2494         https://bugs.webkit.org/show_bug.cgi?id=143530
2495
2496         Reviewed by Žan Doberšek.
2497
2498         Assume that the default value for display (:0) is reserved and start checking on :1
2499         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2500         and for X server named Xorg.bin (previous bug 1376599)
2501
2502         * Scripts/webkitpy/port/xvfbdriver.py:
2503         (XvfbDriver._next_free_display)
2504         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2505         (XvfbDriverTest.test_start_no_pixel_tests):
2506         (XvfbDriverTest.test_start_pixel_tests):
2507         (XvfbDriverTest.test_start_arbitrary_worker_number):
2508         (XvfbDriverTest.test_next_free_display):
2509         (XvfbDriverTest.test_start_next_worker):
2510 2015-04-08  Alex Christensen  <achristensen@webkit.org>
2511
2512         Block popups from content extensions.
2513         https://bugs.webkit.org/show_bug.cgi?id=143497
2514
2515         Reviewed by Brady Eidson.
2516
2517         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2518         (TestWebKitAPI::TEST_F):
2519         Added popup test.
2520
2521 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2522
2523         Add CMake build system for WinCairo port.
2524         https://bugs.webkit.org/show_bug.cgi?id=115944
2525
2526         Reviewed by Chris Dumez.
2527
2528         * CMakeLists.txt:
2529         * WinLauncher/CMakeLists.txt: Added.
2530
2531 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2532
2533         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2534         https://bugs.webkit.org/show_bug.cgi?id=143521
2535
2536         Reviewed by Martin Robinson.
2537
2538         Add a way to detect unexpected web process crashes to WebViewTest,
2539         and a test case to testDOMCache to trigger the crash.
2540
2541         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2542         (WebKitDOMNodeTest::testDOMCache):
2543         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2544         (testWebKitWebViewProcessCrashed):
2545         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2546         (WebViewTest::WebViewTest):
2547         (WebViewTest::webProcessCrashed):
2548         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2549
2550 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2551
2552         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2553         rdar://problem/20461342
2554
2555         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2556
2557 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2558
2559         Unreviewed, rolling out r182511.
2560         https://bugs.webkit.org/show_bug.cgi?id=143507
2561
2562         caused debug test failures (Requested by alexchristensen on
2563         #webkit).
2564
2565         Reverted changeset:
2566
2567         "Block popups from content extensions."
2568         https://bugs.webkit.org/show_bug.cgi?id=143497
2569         http://trac.webkit.org/changeset/182511
2570
2571 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2572
2573         Block popups from content extensions.
2574         https://bugs.webkit.org/show_bug.cgi?id=143497
2575
2576         Reviewed by Brady Eidson.
2577
2578         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2579         (TestWebKitAPI::TEST_F):
2580         Added popup test.
2581
2582 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2583
2584         Get the features.json files ready for open contributions
2585         https://bugs.webkit.org/show_bug.cgi?id=143436
2586
2587         Reviewed by Darin Adler.
2588
2589         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2590         (JSONFeaturesChecker.check):
2591         Extend the syntax checking a bit, but leave everything non-mandatory
2592         very loose until we figure what fields are important.
2593
2594 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2595
2596         Expose and test fixedLayoutSize via modern WebKit SPI
2597         https://bugs.webkit.org/show_bug.cgi?id=143500
2598
2599         Reviewed by Simon Fraser.
2600
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2602         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2603         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2604         (TEST):
2605         Add a test that verifies that fixedLayoutSize works at all, that
2606         it persists through a navigation, and that turning it back off reverts to
2607         laying out at the size of the view.
2608
2609 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2610
2611         Unreviewed. Add myself as a committer.
2612
2613         * Scripts/webkitpy/common/config/contributors.json:
2614
2615 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2616
2617         [Win] Bots complain about missing /etc/catalog
2618         https://bugs.webkit.org/show_bug.cgi?id=143484
2619
2620         Reviewed by Chris Dumez.
2621
2622         The libxml2 build on Mac, iOS, and Windows does not provide the set
2623         of default catalog files. We do not actually need these for our
2624         purposes, but we get warnings and some bot flakiness because they
2625         are not present.
2626
2627         We can avoid both problems the same way the Mac and iOS ports do,
2628         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2629         which avoid the warnings and bot problems.
2630
2631         * Scripts/webkitpy/port/win.py:
2632         (WinPort.setup_environ_for_server): Added.
2633
2634 2015-04-06  Sam Weinig  <sam@webkit.org>
2635
2636         Use content extensions in MiniBrowser.
2637         https://bugs.webkit.org/show_bug.cgi?id=143446
2638
2639         Reviewed by Alex Christensen.
2640
2641         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2642         * MiniBrowser/mac/AppDelegate.h:
2643         * MiniBrowser/mac/AppDelegate.m:
2644         (-[BrowserAppDelegate init]):
2645         (-[BrowserAppDelegate showExtensionsManager:]):
2646         (-[BrowserAppDelegate userContentContoller]):
2647         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2648         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2649         (-[ExtensionManagerWindowController init]):
2650         (-[ExtensionManagerWindowController windowDidLoad]):
2651         (-[ExtensionManagerWindowController add:]):
2652         (-[ExtensionManagerWindowController remove:]):
2653         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2654         * MiniBrowser/mac/MainMenu.xib:
2655
2656 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2657
2658         web-platform-tests server should retrieve the modules file relatively to its docroot path
2659         https://bugs.webkit.org/show_bug.cgi?id=142742
2660
2661         Reviewed by Darin Adler.
2662
2663         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2664         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2665
2666 2015-04-06  Commit Queue  <commit-queue@webkit.org>
2667
2668         Unreviewed, rolling out r182445.
2669         https://bugs.webkit.org/show_bug.cgi?id=143459
2670
2671         broke 32 bit build (Requested by alexchristensen on #webkit).
2672
2673         Reverted changeset:
2674
2675         "Use content extensions in MiniBrowser."
2676         https://bugs.webkit.org/show_bug.cgi?id=143446
2677         http://trac.webkit.org/changeset/182445
2678
2679 2015-04-06  Sam Weinig  <sam@webkit.org>
2680
2681         Use content extensions in MiniBrowser.
2682         https://bugs.webkit.org/show_bug.cgi?id=143446
2683
2684         Reviewed by Alex Christensen.
2685
2686         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2687         * MiniBrowser/mac/AppDelegate.h:
2688         * MiniBrowser/mac/AppDelegate.m:
2689         (-[BrowserAppDelegate init]):
2690         (-[BrowserAppDelegate showExtensionsManager:]):
2691         (-[BrowserAppDelegate userContentContoller]):
2692         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2693         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2694         (-[ExtensionManagerWindowController init]):
2695         (-[ExtensionManagerWindowController windowDidLoad]):
2696         (-[ExtensionManagerWindowController add:]):
2697         (-[ExtensionManagerWindowController remove:]):
2698         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2699         * MiniBrowser/mac/MainMenu.xib:
2700
2701 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2702
2703         [GTK] install-dependencies should prefer dnf to yum
2704         https://bugs.webkit.org/show_bug.cgi?id=143441
2705
2706         Reviewed by Martin Robinson.
2707
2708         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2709
2710         * gtk/install-dependencies:
2711
2712 2015-04-06  Andy Estes  <aestes@apple.com>
2713
2714         [iOS] 'make clean' fails in Tools/WebKitTestRunner
2715         https://bugs.webkit.org/show_bug.cgi?id=143455
2716
2717         Reviewed by Dan Bernstein.
2718
2719         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2720         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2721
2722         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2723
2724 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2725
2726         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2727         https://bugs.webkit.org/show_bug.cgi?id=143450
2728
2729         Reviewed by Anders Carlsson.
2730
2731         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2732         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2733         Also, removed unnecessary get() calls.
2734
2735 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2736
2737         Reduce the dependency on Flash in regression tests
2738         https://bugs.webkit.org/show_bug.cgi?id=143391
2739
2740         Reviewed by Anders Carlsson.
2741
2742         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2743         Only allow QuickTime and the test plug-in.
2744
2745 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2746
2747         W3C test importer should generate the modules installed dynamically to run wpt tests
2748         https://bugs.webkit.org/show_bug.cgi?id=142738
2749
2750         Reviewed by Ryosuke Niwa.
2751
2752         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2753         The implementation is done within TestDownloader and it is activated for the WPT repository.
2754         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2755
2756         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2757         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2758         * Scripts/webkitpy/w3c/test_downloader.py:
2759         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2760         (TestDownloader):
2761         (TestDownloader._git_submodules_description): Computes submodule description.
2762         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2763         * Scripts/webkitpy/w3c/test_importer.py:
2764         (TestImporter.do_import): Added the possibility to post process the tests.
2765         (TestImporter):
2766         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2767         (TestImporter.should_convert_test_harness_links): Updated according new options format.
2768         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2769         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
2770         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2771         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2772         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2773         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2774
2775 2015-04-05  Antti Koivisto  <antti@apple.com>
2776
2777         Bloom filter should support longer hashes
2778         https://bugs.webkit.org/show_bug.cgi?id=143419
2779
2780         Reviewed by Dan Bernstein.
2781
2782         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2783         (TestWebKitAPI::generateRandomDigests):
2784         (TestWebKitAPI::TEST):
2785
2786 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2787
2788         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2789         https://bugs.webkit.org/show_bug.cgi?id=143372
2790
2791         Reviewed by Darin Adler.
2792
2793         * Scripts/run-jsc-stress-tests:
2794
2795 2015-04-03  Antti Koivisto  <antti@apple.com>
2796
2797         Add non-counting bloom filter class
2798         https://bugs.webkit.org/show_bug.cgi?id=143366
2799
2800         Reviewed by Sam Weinig.
2801
2802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2803         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2804         (TestWebKitAPI::generateRandomHashes):
2805         (TestWebKitAPI::TEST):
2806
2807 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2808
2809         FTL JIT tests should fail if LLVM library isn't available
2810         https://bugs.webkit.org/show_bug.cgi?id=143374
2811
2812         Reviewed by Mark Lam.
2813
2814         * Scripts/run-jsc-stress-tests:
2815
2816 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2817
2818         [EFL] Speedup jhbuild with disable running autogen.sh
2819         https://bugs.webkit.org/show_bug.cgi?id=143369
2820
2821         Reviewed by Gyuyoung Kim.
2822
2823         * efl/jhbuild.modules:
2824
2825 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2826
2827         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2828         https://bugs.webkit.org/show_bug.cgi?id=143282
2829
2830         Reviewed by Daniel Bates.
2831
2832         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2833
2834 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2835
2836         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2837         https://bugs.webkit.org/show_bug.cgi?id=143240
2838         rdar://problem/19990425
2839
2840         Reviewed by Tim Horton.
2841
2842         * DumpRenderTree/mac/LayoutTestHelper.m:
2843         (colorProfileURLForDisplay):
2844         (saveDisplayColorProfiles):
2845         Gracefully handle it when the current profile cannot be retrieved, fixing at
2846         least one case when LayoutTestHelper couldn't start.
2847
2848         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2849         (Manager._set_up_run):
2850         (Manager._force_pixel_tests_if_needed):
2851         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2852         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2853         Return and check an error from start_helper().
2854
2855 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2856
2857         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2858         https://bugs.webkit.org/show_bug.cgi?id=143321
2859
2860         Reviewed by Alexey Proskuryakov.
2861
2862         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2863
2864 2015-04-01  Enrica Casucci  <enrica@apple.com>
2865
2866         Injected bundle messages should be at the page level.
2867         https://bugs.webkit.org/show_bug.cgi?id=143283
2868
2869         Reviewed by Alexey Proskuryakov.
2870
2871         Updating WebKitTestRunner to use the new page level messaging.
2872         The author of this patch is Tim Horton, I just finished it.
2873
2874         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2875         (WTR::EventSendingController::mouseDown):
2876         (WTR::EventSendingController::mouseUp):
2877         (WTR::EventSendingController::mouseMoveTo):
2878         (WTR::EventSendingController::leapForward):
2879         (WTR::EventSendingController::scheduleAsynchronousClick):
2880         (WTR::EventSendingController::keyDown):
2881         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2882         (WTR::EventSendingController::mouseScrollBy):
2883         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2884         (WTR::EventSendingController::continuousMouseScrollBy):
2885         (WTR::EventSendingController::addTouchPoint):
2886         (WTR::EventSendingController::updateTouchPoint):
2887         (WTR::EventSendingController::setTouchModifier):
2888         (WTR::EventSendingController::setTouchPointRadius):
2889         (WTR::EventSendingController::touchStart):
2890         (WTR::EventSendingController::touchMove):
2891         (WTR::EventSendingController::touchEnd):
2892         (WTR::EventSendingController::touchCancel):
2893         (WTR::EventSendingController::clearTouchPoints):
2894         (WTR::EventSendingController::releaseTouchPoint):
2895         (WTR::EventSendingController::cancelTouchPoint):
2896         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2897         (WTR::InjectedBundle::didReceiveMessage):
2898         (WTR::InjectedBundle::didReceiveMessageToPage):
2899         (WTR::InjectedBundle::done):
2900         (WTR::InjectedBundle::outputText):
2901         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2902         (WTR::InjectedBundle::postAddChromeInputField):
2903         (WTR::InjectedBundle::postRemoveChromeInputField):
2904         (WTR::InjectedBundle::postFocusWebView):
2905         (WTR::InjectedBundle::postSetBackingScaleFactor):
2906         (WTR::InjectedBundle::postSetWindowIsKey):
2907         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2908         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2909         (WTR::InjectedBundle::setGeolocationPermission):
2910         (WTR::InjectedBundle::setMockGeolocationPosition):
2911         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2912         (WTR::InjectedBundle::setUserMediaPermission):
2913         (WTR::InjectedBundle::setCustomPolicyDelegate):
2914         (WTR::InjectedBundle::setHidden):
2915         (WTR::InjectedBundle::setCacheModel):
2916         (WTR::InjectedBundle::shouldProcessWorkQueue):
2917         (WTR::InjectedBundle::processWorkQueue):
2918         (WTR::InjectedBundle::queueBackNavigation):
2919         (WTR::InjectedBundle::queueForwardNavigation):
2920         (WTR::InjectedBundle::queueLoad):
2921         (WTR::InjectedBundle::queueLoadHTMLString):
2922         (WTR::InjectedBundle::queueReload):
2923         (WTR::InjectedBundle::queueLoadingScript):
2924         (WTR::InjectedBundle::queueNonLoadingScript):
2925         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2926         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2927         (WTR::TestRunner::setAuthenticationUsername):
2928         (WTR::TestRunner::setAuthenticationPassword):
2929         (WTR::TestRunner::secureEventInputIsEnabled):
2930         (WTR::TestRunner::setBlockAllPlugins):
2931         * WebKitTestRunner/TestController.cpp:
2932         (WTR::TestController::createWebViewWithOptions):
2933         (WTR::TestController::resetStateToConsistentValues):
2934         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2935         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2936         * WebKitTestRunner/TestController.h:
2937         * WebKitTestRunner/TestInvocation.cpp:
2938         (WTR::TestInvocation::invoke):
2939         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2940
2941 2015-04-01  Commit Queue  <commit-queue@webkit.org>
2942
2943         Unreviewed, rolling out r182174 and r182177.
2944         https://bugs.webkit.org/show_bug.cgi?id=143314
2945
2946         Try to correct EWS failures (Requested by bfulgham on
2947         #webkit).
2948
2949         Reverted changesets:
2950
2951         "Python SCM should be able to retrieve untracked files"
2952         https://bugs.webkit.org/show_bug.cgi?id=143135
2953         http://trac.webkit.org/changeset/182174
2954
2955         "[buildbot] clean-build script should remove untracked files
2956         and revert local changes too"
2957         https://bugs.webkit.org/show_bug.cgi?id=142400
2958         http://trac.webkit.org/changeset/182177
2959
2960 2015-04-01  Alex Christensen  <achristensen@webkit.org>
2961
2962         [Content Extensions] Properly handle regexes that match everything.
2963         https://bugs.webkit.org/show_bug.cgi?id=143281
2964
2965         Reviewed by Benjamin Poulain.
2966
2967         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2968         (TestWebKitAPI::testRequest):
2969         (TestWebKitAPI::makeBackend):
2970         (TestWebKitAPI::TEST_F):
2971         Removed duplicate code and added test.
2972
2973 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
2974
2975         Content Extensions: split the state machines to minimize prefix states
2976         https://bugs.webkit.org/show_bug.cgi?id=143253
2977
2978         Reviewed by Alex Christensen.
2979
2980         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2981         (TestWebKitAPI::TEST_F):
2982         (TestWebKitAPI::testPatternStatus):
2983
2984 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
2985
2986         Clean up Identifier factories to clarify the meaning of StringImpl*
2987         https://bugs.webkit.org/show_bug.cgi?id=143146
2988
2989         Reviewed by Filip Pizlo.
2990
2991         Simple API tests for StringImpl are added.
2992
2993         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2994         (TestWebKitAPI::TEST):
2995
2996 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
2997
2998         [EFL] Add AArch64 builder and tester bot to build.webkit.org
2999         https://bugs.webkit.org/show_bug.cgi?id=143092
3000
3001         Reviewed by Gyuyoung Kim.
3002
3003         * BuildSlaveSupport/build.webkit.org-config/config.json:
3004         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3005         (Factory.__init__):
3006         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3007
3008 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3009
3010         [buildbot] clean-build script should remove untracked files and revert local changes too
3011         https://bugs.webkit.org/show_bug.cgi?id=142400
3012
3013         Reviewed by Ryosuke Niwa.
3014
3015         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3016         A helper routine SCM.discard_untracked_files is added for that purpose.
3017
3018         * BuildSlaveSupport/clean-build:
3019         (main): Making call to Scripts/clean-webkit
3020         * Scripts/clean-webkit: Added.
3021         (main): Revert changes and delete untracked files.
3022         * Scripts/webkitpy/common/checkout/scm/scm.py:
3023         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3024         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3025         (SCMTest._shared_test_discard_untracked_files):
3026         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3027
3028 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3029
3030         Python SCM should be able to retrieve untracked files
3031         https://bugs.webkit.org/show_bug.cgi?id=143135
3032
3033         Reviewed by Ryosuke Niwa.
3034
3035         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3036         Ignored files may be included or not in this list according boolean passed to the function.
3037
3038         * Scripts/webkitpy/common/checkout/scm/git.py:
3039         (Git.untracked_files):
3040         * Scripts/webkitpy/common/checkout/scm/scm.py:
3041         (SCM.untracked_files):
3042         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3043         (SCMTest._shared_test_untracked_files):
3044         (test_untracked_files):
3045         (GitSVNTest.test_untracked_files):
3046         * Scripts/webkitpy/common/checkout/scm/svn.py:
3047         (SVN.untracked_files):
3048
3049 2015-03-30  Alex Christensen  <achristensen@webkit.org>
3050
3051         [Content Extensions] Correctly handle regular expressions matching everything
3052         https://bugs.webkit.org/show_bug.cgi?id=143235
3053
3054         Reviewed by Benjamin Poulain.
3055
3056         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3057         (TestWebKitAPI::checkCompilerError):
3058         (TestWebKitAPI::TEST_F):
3059         Test ContentExtensionErrors.
3060
3061 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
3062
3063         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
3064         https://bugs.webkit.org/show_bug.cgi?id=143241
3065         rdar://problem/20351297
3066
3067         Reviewed by Mark Lam.
3068
3069         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3070
3071 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3072
3073         [CMake][EFL] Remove redundant library link and include path
3074         https://bugs.webkit.org/show_bug.cgi?id=143221
3075
3076         Reviewed by Csaba Osztrogonác.
3077
3078         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
3079
3080 2015-03-30  Sam Weinig  <sam@webkit.org>
3081
3082         [Content Extensions] Flesh out the UserContentExtensionStore
3083         https://bugs.webkit.org/show_bug.cgi?id=143123
3084
3085         Reviewed by Benjamin Poulain.
3086
3087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3088         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
3089         Add tests for _WKUserContentExtensionStore.
3090
3091 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3092
3093         Update install-dependencies Fedora packages after r181624
3094         https://bugs.webkit.org/show_bug.cgi?id=143215
3095
3096         Add json-glib, libv4l, openssl and pulseaudio development packages to
3097         the Fedora list providing we need them to build WebKit dependencies
3098         for this distribution.
3099
3100         Reviewed by Philippe Normand.
3101
3102         * gtk/install-dependencies:
3103
3104 2015-03-30  Commit Queue  <commit-queue@webkit.org>
3105
3106         Unreviewed, rolling out r182119.
3107         https://bugs.webkit.org/show_bug.cgi?id=143196
3108
3109         problem with syntax (Requested by youenn on #webkit).
3110
3111         Reverted changeset:
3112
3113         "[buildbot] clean-build script should remove untracked files
3114         and revert local changes too"
3115         https://bugs.webkit.org/show_bug.cgi?id=142400
3116         http://trac.webkit.org/changeset/182119
3117
3118 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
3119
3120         Start the features.json files
3121         https://bugs.webkit.org/show_bug.cgi?id=143207
3122
3123         Reviewed by Darin Adler.
3124
3125         I kept the style checking light. We'll have to figure
3126         what is the best format for each field.
3127
3128         * Scripts/webkitpy/style/checker.py:
3129         (CheckerDispatcher._create_checker):
3130         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3131         (JSONContributorsChecker.check):
3132         (JSONFeaturesChecker):
3133         (JSONFeaturesChecker.check):
3134
3135 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3136
3137         [buildbot] clean-build script should remove untracked files and revert local changes too
3138         https://bugs.webkit.org/show_bug.cgi?id=142400
3139
3140         Reviewed by Ryosuke Niwa.
3141
3142         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
3143
3144         * BuildSlaveSupport/clean-build:
3145         (main): Adding call to Tools/Scripts/clean-webkit.
3146         * Scripts/clean-webkit: Added.
3147         (main): Removes untracked and changed files.
3148         * Scripts/webkitpy/common/checkout/scm/git.py:
3149         (Git.untracked_files): Retrieves GIT untracked files.
3150         * Scripts/webkitpy/common/checkout/scm/scm.py:
3151         (SCM.untracked_files): Retrieves SVN untracked files.
3152         (SCM):
3153         (SCM.discard_untracked_files): Deletes untracked files/folders.
3154         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3155         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
3156         (test_untracked_files):
3157         (GitSVNTest.test_untracked_files):
3158         * Scripts/webkitpy/common/checkout/scm/svn.py:
3159         (SVN.untracked_files):
3160
3161 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3162
3163         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
3164         https://bugs.webkit.org/show_bug.cgi?id=143138
3165
3166         Reviewed by Csaba Osztrogonác.
3167
3168         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
3169         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
3170
3171         * ImageDiff/CMakeLists.txt:
3172         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
3173         * WebKitTestRunner/CMakeLists.txt: ditto.
3174
3175 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
3176
3177         Support building WTF on Windows without Cygwin
3178         https://bugs.webkit.org/show_bug.cgi?id=143084
3179
3180         Reviewed by Brent Fulgham.
3181
3182         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
3183         This patch also migrates to using File::Spec->catfile() for directory separators.
3184
3185         * Scripts/update-webkit-dependency:
3186         (wanted):
3187         * Scripts/update-webkit-support-libs:
3188         (wanted):
3189         (downloadExpectedVersionNumber):
3190         (zipFileVersion):
3191         (toUnixPath): Deleted.
3192         * Scripts/webkitdirs.pm:
3193         (determineSourceDir):
3194         (windowsSourceSourceDir):
3195         (windowsLibrariesDir):
3196         (windowsOutputDir):
3197         (checkInstalledTools):
3198         (buildVisualStudioProject):
3199
3200 2015-03-27  Alex Christensen  <achristensen@webkit.org>
3201
3202         Fix WinCairo bot.
3203         https://bugs.webkit.org/show_bug.cgi?id=143086
3204
3205         Reviewed by Brent Fulgham.
3206
3207         * Scripts/webkitdirs.pm:
3208         (buildVisualStudioProject):
3209         (runSvnUpdateAndResolveChangeLogs):
3210         Use ActivePerl-friendly perl.
3211
3212 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3213
3214         URTBF after r182059 to fix the EFL build.
3215
3216         * TestWebKitAPI/CMakeLists.txt:
3217
3218 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
3219
3220         Layout test results URL loads in WK1 but not WK2 minibrowser
3221         https://bugs.webkit.org/show_bug.cgi?id=143117
3222
3223         Reviewed by Tim Horton.
3224
3225         * MiniBrowser/mac/WK2BrowserWindowController.m:
3226         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
3227         everything.
3228         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
3229
3230 2015-03-26  Jer Noble  <jer.noble@apple.com>
3231
3232         Add --allowed-host support to run-webkit-tests
3233         https://bugs.webkit.org/show_bug.cgi?id=142938
3234
3235         Reviewed by Brent Fulgham.
3236
3237         Accept --allowed-host arguments from run-webkit-tests and pass them through to
3238         DumpRenderTree and WebKitTestRunner.
3239
3240         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3241         are placed in the wrong location. The argument is compared with each tests's path, and if a
3242         relative path or a path with '..' was used, results are placed alongside the test. Take the
3243         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3244
3245         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3246         (parse_args):
3247         * Scripts/webkitpy/port/base.py:
3248         (Port.__init__):
3249         (Port.allowed_hosts):
3250         * Scripts/webkitpy/port/driver.py:
3251         (Driver.cmd_line):
3252
3253 2015-03-26  Jer Noble  <jer.noble@apple.com>
3254
3255         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3256         https://bugs.webkit.org/show_bug.cgi?id=142931
3257
3258         Reviewed by Brent Fulgham.
3259
3260         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3261         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3262         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3263         runtime.
3264
3265         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
3266         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
3267
3268         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
3269         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
3270         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
3271         the top loading frame from the page, as we do elsewhere in this class.
3272
3273         * DumpRenderTree/TestRunner.h:
3274         (TestRunner::allowedHosts):
3275         (TestRunner::setAllowedHosts):
3276         * DumpRenderTree/mac/DumpRenderTree.mm:
3277         (initializeGlobalsFromCommandLineOptions):
3278         (runTest):
3279         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3280         (isAllowedHost):
3281         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3282         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3283         (WTR::InjectedBundle::didReceiveMessage):
3284         (WTR::InjectedBundle::isAllowedHost):
3285         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3286         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3287         (WTR::isAllowedHost):
3288         (WTR::InjectedBundlePage::willSendRequestForFrame):
3289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3290         * WebKitTestRunner/Options.cpp:
3291         (WTR::handleOptionAllowedHost):
3292         (WTR::OptionsHandler::OptionsHandler):
3293         * WebKitTestRunner/Options.h:
3294         * WebKitTestRunner/TestController.cpp:
3295         (WTR::TestController::initialize):
3296         (WTR::TestController::resetStateToConsistentValues):
3297         * WebKitTestRunner/TestController.h:
3298
3299 2015-03-26  Brady Eidson  <beidson@apple.com>
3300
3301         Apply ContentExtension actions after redirects.
3302         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
3303
3304         Reviewed by Alex Christensen.
3305
3306         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3307         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
3308           which is specifically interesting to a new test.
3309
3310 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3311
3312         [EFL] Disable building libseccomp on AArch64
3313         https://bugs.webkit.org/show_bug.cgi?id=143094
3314
3315         Reviewed by Gyuyoung Kim.
3316
3317         * efl/jhbuildrc:
3318
3319 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3320
3321         [jhbuild] git should use only 1 thread for cloning jhbuild
3322         https://bugs.webkit.org/show_bug.cgi?id=143095
3323
3324         Reviewed by Gyuyoung Kim.
3325
3326         * jhbuild/jhbuild-wrapper:
3327         (clone_jhbuild):
3328
3329 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
3330
3331         Update prepare-ChangeLog to work with ES6 Class syntax
3332         https://bugs.webkit.org/show_bug.cgi?id=143069
3333
3334         Reviewed by Timothy Hatcher.
3335
3336         * Scripts/prepare-ChangeLog:
3337         (get_function_line_ranges_for_javascript):
3338         Better handle ES6 Class syntax.
3339
3340         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3341         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3342         (BaseClass):
3343         (DerivedClass):
3344         (DerivedClass.staticMethod):
3345         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
3346         (DerivedClass.prototype.method):
3347         (DerivedClass.prototype.get getter):
3348         (namespace.MyClass):
3349         (namespace.MyClass.staticMethod):
3350         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
3351         (namespace.MyClass.prototype.method):
3352         (namespace.MyClass.prototype.get getter):
3353         Proof!
3354
3355 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
3356
3357         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
3358         https://bugs.webkit.org/show_bug.cgi?id=142993
3359
3360         Reviewed by Mark Lam.
3361         
3362         Bunch of support for testing executable allocation failure.
3363
3364         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
3365         (fail):
3366         * Scripts/run-javascriptcore-tests:
3367         (runJSCStressTests):
3368         * Scripts/run-jsc-stress-tests:
3369
3370 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3371
3372         Fix Windows build from r181977.
3373
3374         Unreviewed.
3375
3376         * Scripts/update-webkit-dependency:
3377
3378 2015-03-25  Sam Weinig  <sam@webkit.org>
3379
3380         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
3381
3382         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3383         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3384
3385 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3386
3387         Migrate update-webkit for Windows to not require Cygwin
3388         https://bugs.webkit.org/show_bug.cgi?id=143040
3389
3390         Reviewed by Brent Fulgham.
3391
3392         * Scripts/update-webkit-dependency:
3393         (wanted):
3394         (toUnixPath): Deleted.
3395         * Scripts/webkitdirs.pm:
3396         (fontExists):
3397         (checkInstalledTools):
3398         (setupAppleWinEnv):
3399
3400 2015-03-25  Sam Weinig  <sam@webkit.org>
3401
3402         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
3403         https://bugs.webkit.org/show_bug.cgi?id=143059
3404
3405         Reviewed by Alex Christensen.
3406
3407         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3408         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3409         Update for new interface of compileRuleList().
3410
3411 2015-03-25  Alex Christensen  <achristensen@webkit.org>
3412
3413         [Content Extensions] Add multi-DFA compiling and interpreting.
3414         https://bugs.webkit.org/show_bug.cgi?id=143010
3415
3416         Reviewed by Benjamin Poulain.
3417
3418         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3419         (TestWebKitAPI::testRequest):
3420         (TestWebKitAPI::TEST_F):
3421         Add some tests for ignore-previous-rules and large rulesets.
3422
3423 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
3424
3425         Mavericks WK1 still runs JSC tests
3426         https://bugs.webkit.org/show_bug.cgi?id=143035
3427
3428         Reviewed by Csaba Osztrogonác.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
3431         with other bots.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
3434         accordingly.
3435
3436 2015-03-25  Commit Queue  <commit-queue@webkit.org>
3437
3438         Unreviewed, rolling out r181932.
3439         https://bugs.webkit.org/show_bug.cgi?id=143041
3440
3441         The test fails most of the time on bots (Requested by ap on
3442         #webkit).
3443
3444         Reverted changeset:
3445
3446         "[Content Extensions] Add multi-DFA compiling and
3447         interpreting."
3448         https://bugs.webkit.org/show_bug.cgi?id=143010
3449         http://trac.webkit.org/changeset/181932
3450
3451 2015-03-24  Alex Christensen  <achristensen@webkit.org>
3452
3453         [Content Extensions] Add multi-DFA compiling and interpreting.
3454         https://bugs.webkit.org/show_bug.cgi?id=143010
3455
3456         Reviewed by Benjamin Poulain.
3457
3458         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3459         (TestWebKitAPI::testRequest):
3460         (TestWebKitAPI::TEST_F):
3461         Add some tests for ignore-previous-rules and large rulesets.
3462
3463 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
3464
3465         Make URL filter patterns matching consistent and add a simple canonicalization step
3466         https://bugs.webkit.org/show_bug.cgi?id=142998
3467
3468         Reviewed by Alex Christensen.
3469
3470         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3471
3472 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
3473
3474         [EFL] Add OpenWebRTC in jhbuild
3475         https://bugs.webkit.org/show_bug.cgi?id=142778
3476
3477         Reviewed by Gyuyoung Kim.
3478
3479         Original patch by Philippe Normand <pnormand@igalia.com>
3480
3481         * efl/install-dependencies: Dependencies for OpenWebRTC.
3482         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
3483         the openwebrtc gst plugins.
3484
3485 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
3486
3487         Regression(r181257): WTF_WorkQueue.Simple is flaky
3488         https://bugs.webkit.org/show_bug.cgi?id=142560
3489
3490         Remove the check that the refCount has returned to one after the
3491         individual tasks have completed. It's too nondeterministic when
3492         the reference count will be reduced.
3493
3494         Reviewed by Alexey Proskuryakov
3495
3496         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3497         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
3498
3499 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3500
3501         [CMake][EFL] Put failure API test excutables into failure directory
3502         https://bugs.webkit.org/show_bug.cgi?id=142965
3503
3504         Reviewed by Csaba Osztrogonác.
3505
3506         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
3507
3508         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
3509         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
3510
3511 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
3512
3513         CSS Selectors: fix attribute case-insensitive matching of Contain and List
3514         https://bugs.webkit.org/show_bug.cgi?id=142932
3515
3516         Reviewed by Darin Adler.
3517
3518         Add tests for the new features and fix some existing tests using the 
3519         stringFromUTF8() utility recently added by Dhi.
3520
3521         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3522         (TestWebKitAPI::stringFromUTF8):
3523         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3524
3525 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3526
3527         [GTK] install-dependencies should install orc
3528         https://bugs.webkit.org/show_bug.cgi?id=142955
3529
3530         Reviewed by Martin Robinson.
3531
3532         Install orc, needed by openwebrtc
3533
3534         * gtk/install-dependencies:
3535
3536 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
3537
3538         Detect when url filter pattern with groups match the empty string
3539         https://bugs.webkit.org/show_bug.cgi?id=142930
3540
3541         Reviewed by Sam Weinig.
3542
3543         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3544
3545 2015-03-22  Anders Carlsson  <andersca@apple.com>
3546
3547         _WKWebsiteDataStore should clear WebSQL databases
3548         https://bugs.webkit.org/show_bug.cgi?id=142947
3549
3550         Reviewed by Sam Weinig.
3551
3552         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3553
3554         * MiniBrowser/mac/WK2BrowserWindowController.m:
3555         (-[WK2BrowserWindowController fetchWebsiteData:]):
3556         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3557         (-[WK2BrowserWindowController clearWebsiteData:]):
3558
3559 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
3560
3561         GCTimer should know keep track of nested GC phases
3562         https://bugs.webkit.org/show_bug.cgi?id=142675
3563
3564         Reviewed by Darin Adler.
3565
3566         Adds a tool to aid in parsing the GC phase timing output into a
3567         tree-like structure based on the parent-child relationships
3568         of nested GC phases.
3569
3570         * Scripts/parse-gc-phase-timings: Added.
3571         (Timing):
3572         (Timing.__init__):
3573         (Timing.__unicode__):
3574         (Timing.__str__):
3575         (Timing.__repr__):
3576         (parse_input):
3577         (print_timing_node):
3578         (print_timing_tree):
3579         (link_parents):
3580         (main):
3581
3582 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
3583
3584         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3585
3586         * Scripts/webkitpy/common/config/ews.json:
3587
3588 2015-03-20  Philippe Normand  <pnormand@igalia.com>
3589
3590         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3591         https://bugs.webkit.org/show_bug.cgi?id=142867
3592
3593         Rubber-stamped by Csaba Osztrogon.
3594
3595         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3596         a fixed revision for the openwebrtc-gst-plugins.
3597
3598 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3599
3600         Unreviewed build fix. Don't try to report stats for all benchmarks.
3601         Just report the geometric mean of preferred means.
3602
3603         * Scripts/run-jsc-benchmarks:
3604
3605 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3606
3607         run-jsc-benchmarks should only report preferred mean
3608         https://bugs.webkit.org/show_bug.cgi?id=142874
3609
3610         Reviewed by Geoffrey Garen.
3611
3612         Just collect statistics for the preferred mean.
3613
3614         * Scripts/run-jsc-benchmarks:
3615
3616 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3617
3618         [Content Extensions] Test regular expression parse failures.
3619         https://bugs.webkit.org/show_bug.cgi?id=142872
3620
3621         Reviewed by Benjamin Poulain.
3622
3623         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3624         (TestWebKitAPI::testPatternStatus):
3625         (TestWebKitAPI::TEST_F):
3626         Added tests for each parsing status.
3627
3628 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3629
3630         Fix API tests after r181754.
3631
3632         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3633         (TestWebKitAPI::testRequest):
3634
3635 2015-03-19  Brady Eidson  <beidson@apple.com>
3636
3637         Part of content extensions should apply css selectors
3638         https://bugs.webkit.org/show_bug.cgi?id=142604
3639
3640         Reviewed by Alex Christensen.
3641
3642         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3643         (WebCore::ContentExtensions::operator<<):
3644
3645 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
3646
3647         [Win] Activate tests on EWS
3648         https://bugs.webkit.org/show_bug.cgi?id=142850
3649
3650         Reviewed by Alexey Proskuryakov.
3651
3652         * Scripts/webkitpy/common/config/ews.json: Add me as
3653         the EWS bot watcher, and activate tests.
3654
3655 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
3656
3657         [GTK] Fix inspector userinterface related incremental build issue
3658         https://bugs.webkit.org/show_bug.cgi?id=142849
3659
3660         Reviewed by Carlos Garcia Campos.
3661
3662         * Scripts/webkitdirs.pm:
3663         (shouldRemoveCMakeCache):
3664
3665 2015-03-18  Alex Christensen  <achristensen@webkit.org>
3666
3667         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3668         https://bugs.webkit.org/show_bug.cgi?id=142799
3669
3670         Reviewed by Brady Eidson.
3671
3672         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3673         (TestWebKitAPI::testPattern):
3674         (TestWebKitAPI::TEST_F):
3675         Start testing regex failures.
3676
3677 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
3678
3679         Fix StringView typos after r181525 and r181558
3680         https://bugs.webkit.org/show_bug.cgi?id=142772
3681
3682         Reviewed by Darin Adler.
3683
3684         Add some tests in [1] to cover the StringView::startsWith, 
3685         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
3686         StringView::endsWithIgnoringASCIICase implementations.
3687
3688         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3689         (TestWebKitAPI::TEST):
3690
3691 2015-03-18  Dana Burkart  <dburkart@apple.com>
3692
3693