1 2013-08-26 Dan Bernstein <mitz@apple.com>
3 Automatic bug reports case pain
4 https://bugs.webkit.org/show_bug.cgi?id=120330
6 Reviewed by Anders Carlsson.
8 * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
9 of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
10 “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
12 2013-08-23 Andy Estes <aestes@apple.com>
14 Fix issues found by the Clang Static Analyzer
15 https://bugs.webkit.org/show_bug.cgi?id=120230
17 Reviewed by Darin Adler.
19 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
20 (-[LocalPasteboard initWithName:]): Called [super init] first so that we
21 don't later use ivars from the wrong self.
22 * DumpRenderTree/mac/TestRunnerMac.mm:
23 (-[APITestDelegate initWithCompletionCondition:]): Ditto.
24 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
25 (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
26 WKBrowsingContextGroups, and WKViews.
28 2013-08-26 Alexey Proskuryakov <ap@apple.com>
30 WebKitTestRunner needs to protect the user's pasteboard contents while running
31 https://bugs.webkit.org/show_bug.cgi?id=81419
32 <rdar://problem/11066794>
34 Reviewed by Darin Adler.
36 Mostly a copy/paste of DRT code.
38 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
39 doesn't interfere with my clipboard while being run in a loop.
41 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
42 * WebKitTestRunner/mac/PoseAsClass.h: Added.
43 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
44 * WebKitTestRunner/mac/TestControllerMac.mm:
45 (WTR::TestController::platformInitialize):
46 (WTR::TestController::platformDestroy):
47 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
48 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
50 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
52 [GTK] Include most of the WebKit2 unit tests into the build and testing
53 https://bugs.webkit.org/show_bug.cgi?id=120307
55 Reviewed by Philippe Normand.
57 There are still various unit test source files that are not being included into
58 the build. This patch includes most of these, only leaving out tests that do not
59 compile or test features that are not supported by the GTK port.
61 * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
63 * TestWebKitAPI/GNUmakefile.am:
65 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
67 [GTK] Allow to run tests without Xvfb in run-gtk-tests
68 https://bugs.webkit.org/show_bug.cgi?id=120298
70 Reviewed by Philippe Normand.
72 Add --no-xvfb command line option to run tests in the current
75 * Scripts/run-gtk-tests:
76 (TestRunner._run_xvfb): Return early if option --no-xvfb has been
78 (TestRunner._setup_testing_environment): Use helper function
79 _run_xvfb to start Xvfb if needed.
80 (TestRunner._tear_down_testing_environment): Check Xvfb is
81 actually running before trying to terminate it.
83 2013-08-26 Zoltan Arvai <zarvai@inf.u-szeged.hu>
85 Adding Gabor Abraham to contributors.json.
87 Reviewed by Csaba Osztrogonác.
89 * Scripts/webkitpy/common/config/contributors.json:
91 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
93 [GTK] Add support for passing test directories to run-gtk-tests
94 https://bugs.webkit.org/show_bug.cgi?id=120296
96 Reviewed by Philippe Normand.
98 * Scripts/run-gtk-tests:
99 (TestRunner._get_tests_from_dir): Helper function to return all
100 unit tests found in a given directory.
101 (TestRunner._get_tests): Check the given tests passed in the
102 command line, so that if a directory is found the tests contained
103 in the directory are added to the list of tests to run.
105 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
107 [GTK] Improve the stop/reload button implementation in MiniBrowser
108 https://bugs.webkit.org/show_bug.cgi?id=120292
110 Reviewed by Philippe Normand.
112 - Use an instance member of BrowserWindow for the button widget
113 instead of a global variable.
114 - Use notify::is-loading to monitor the WebView load instead of
115 the estimated-load-progress property.
116 - Use webkit_web_view_is_loading() to check whether the view
117 is loading to change the button icon instead of a string
118 comparison of the gtk stock icon id.
119 - Use the right casts to fix compile warning.
121 * MiniBrowser/gtk/BrowserWindow.c:
122 (reloadOrStopCallback):
123 (webViewLoadProgressChanged):
124 (webViewIsLoadingChanged):
125 (browser_window_init):
126 (browserWindowConstructed):
128 2013-08-26 Arunprasad Rajkumar <arurajku@cisco.com>
130 [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
131 https://bugs.webkit.org/show_bug.cgi?id=119791
133 Reviewed by Jocelyn Turcotte.
135 Load empty url to send onunload event to currently running page. onunload event is
136 mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
137 LayoutTests/plugins/geturlnotify-during-document-teardown.html.
139 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
142 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
144 [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
145 https://bugs.webkit.org/show_bug.cgi?id=120290
147 Reviewed by Philippe Normand.
149 * MiniBrowser/gtk/GNUmakefile.am: Add
150 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
152 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
154 [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
155 https://bugs.webkit.org/show_bug.cgi?id=120288
157 Reviewed by Carlos Garcia Campos.
159 * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
160 into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
161 These unit tests are at the moment failing in debug configurations, so it would be nice to
162 have the GTK builds report these failures as well.
164 2013-08-25 Ryuan Choi <ryuan.choi@samsung.com>
166 [EFL] EWebLauncher is executed as full screen with device pixel ratio
167 https://bugs.webkit.org/show_bug.cgi?id=120282
169 Reviewed by Gyuyoung Kim.
171 * EWebLauncher/main.c:
172 Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
174 2013-08-25 Zan Dobersek <zdobersek@igalia.com>
176 [gdb] Remove the pretty printer for KURLGooglePrivate
177 https://bugs.webkit.org/show_bug.cgi?id=120263
179 Reviewed by Benjamin Poulain.
181 Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
182 was usable inside the gdb debugger. The structure was remove from the codebase
183 along with the GoogleURL backend for KURL.
186 (JSCJSStringPrinter.to_string):
187 (add_pretty_printers):
189 2013-08-24 Filip Pizlo <fpizlo@apple.com>
191 Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
192 prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
193 libraries depend on libgtest anyway.
195 * Scripts/copy-webkitlibraries-to-product-directory:
197 2013-08-24 Darin Adler <darin@apple.com>
199 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
200 https://bugs.webkit.org/show_bug.cgi?id=120255
202 Reviewed by Andreas Kling.
204 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
206 2013-08-24 Anders Carlsson <andersca@apple.com>
208 Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
209 https://bugs.webkit.org/show_bug.cgi?id=120249
211 Reviewed by Andreas Kling.
213 * Scripts/extract-localizable-strings:
215 2013-08-24 Carlos Garcia Campos <cgarcia@igalia.com>
217 [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
218 https://bugs.webkit.org/show_bug.cgi?id=119743
220 Reviewed by Anders Carlsson.
222 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
223 (WTR::InjectedBundlePage::InjectedBundlePage): Add
226 2013-08-23 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
228 Move TestWebKitAPI_LIBRARIES before platform specific cmake include
229 https://bugs.webkit.org/show_bug.cgi?id=120220
231 Reviewed by Martin Robinson.
233 * TestWebKitAPI/CMakeLists.txt:
235 2013-08-22 Filip Pizlo <fpizlo@apple.com>
237 build-jsc --ftl-jit should work
238 https://bugs.webkit.org/show_bug.cgi?id=120194
240 Reviewed by Oliver Hunt.
242 * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
244 2013-08-23 Commit Queue <commit-queue@webkit.org>
246 Unreviewed, rolling out r153534.
247 http://trac.webkit.org/changeset/153534
248 https://bugs.webkit.org/show_bug.cgi?id=120216
250 Too many tests failing just WinEWS bots (Requested by rfong on
253 * Scripts/webkitpy/common/config/ews.json:
255 2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
257 Unreviewed. Added my webkit.org email address.
259 * Scripts/webkitpy/common/config/contributors.json:
261 2013-08-23 Peter Gal <galpeter@inf.u-szeged.hu>
263 [WTR] Should dump as text when the mimetype is text/plain
264 https://bugs.webkit.org/show_bug.cgi?id=118306
266 Reviewed by Christophe Dumez.
268 Check for the text/plain mimetype and if true then mark it as
271 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
272 (WTR::InjectedBundlePage::dump):
274 2013-08-22 Filip Pizlo <fpizlo@apple.com>
276 Update LLVM binary drops and scripts to the latest version from SVN
277 https://bugs.webkit.org/show_bug.cgi?id=120184
279 Reviewed by Mark Hahnenberg.
281 * ReducedFTL/build.sh:
282 * Scripts/configure-llvm: Added.
283 * Scripts/copy-webkitlibraries-to-product-directory:
284 * Scripts/export-llvm-build:
286 2013-08-22 Andy Estes <aestes@apple.com>
288 <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
290 Reviewed by David Kilzer.
292 * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
293 OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
294 DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
296 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
298 NRWT: Add the ability to upload test results to new test results server
299 https://bugs.webkit.org/show_bug.cgi?id=120146
301 Reviewed by Andreas Kling.
303 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
304 that contains the full summary of the test run including information about passed tests.
306 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
309 --results-server-host
311 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
312 so we should be able to delete --test-results-server in time.
314 * Scripts/webkitpy/layout_tests/controllers/manager.py:
316 (Manager._upload_json_files):
318 (Manager.upload_results):
319 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
321 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
322 (summarized_results):
323 (SummarizedResultsTest.test_summarized_results_wontfix):
324 (SummarizedResultsTest):
325 (SummarizedResultsTest.test_summarized_results_include_passes):
326 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
329 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
331 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
333 * Scripts/webkitpy/tool/bot/irc_command.py:
336 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
338 [Qt] DRT bug revealed/caused by r154300
339 https://bugs.webkit.org/show_bug.cgi?id=120151
341 Reviewed by Simon Hausmann.
343 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
344 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
347 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
348 between native Qt methods and JSC bound methods. This patch changes the check to see if the
349 property is writable since the Qt methods are ReadOnly.
351 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
352 (DumpRenderTree::initJSObjects):
354 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
356 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
358 Reviewed by Benjamin Poulain.
360 WTFString moved the is8bit bit by one in r152201.
362 * lldb/lldb_webkit.py:
363 (WTFStringImplProvider.is_8bit):
365 2013-08-21 Tim Horton <timothy_horton@apple.com>
367 Revert http://trac.webkit.org/changeset/154022, as it failed to update
368 a variety of scripts that depended on the old format.
370 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
372 * Scripts/prepare-ChangeLog:
374 (generateNewChangeLogs):
376 2013-08-21 Brent Fulgham <bfulgham@apple.com>
378 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
380 * WinLauncher/WinLauncher.cpp:
381 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
383 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
385 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
387 Reviewed by Andreas Kling.
389 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
390 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
391 (WTR::activateFonts): Ditto.
393 2013-08-21 Brian Holt <brian.holt@samsung.com>
395 [GTK] Suppress irrelevant or known leaks for Valgrind
396 https://bugs.webkit.org/show_bug.cgi?id=119448
398 Reviewed by Martin Robinson.
400 Add a suppressions file to suppress known leaks for Valgrind.
401 Valgrind also takes longer when using suppressions and
402 times out unless the driver timeout is increased.
404 * Scripts/valgrind/suppressions.txt: Added.
405 * Scripts/webkitpy/port/gtk.py:
406 (GtkPort.driver_stop_timeout):
407 (GtkPort.setup_environ_for_server):
409 2013-08-20 Alex Christensen <achristensen@apple.com>
411 [Windows] Linking fix for Win64.
413 Rubberstamped by Brent Fulgham.
415 * win/DLLLauncher/DLLLauncherMain.cpp:
416 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
418 2013-08-20 Brent Fulgham <bfulgham@apple.com>
420 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
422 Reviewed by Tim Horton.
424 * win/DLLLauncher/DLLLauncherMain.cpp:
425 (getLastErrorString): New method to convert GetLastError to text.
426 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
428 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
430 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
432 Reviewed by Martin Robinson.
434 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
435 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
437 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
439 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
441 Reviewed by Martin Robinson.
443 Added stop button in MiniBrowser
445 * MiniBrowser/gtk/BrowserWindow.c:
446 (reloadOrStopCallback): Callback to handle stop or reload button click.
447 (webViewLoadProgressChanged): Update reload or stop button icon.
448 (browser_window_init): Save button pointer for further icon updates.
450 2013-08-20 Simon Pena <simon.pena@samsung.com>
452 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
454 Reviewed by Alexey Proskuryakov.
456 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
457 printing didFailLoadWithError.
459 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
460 DumpRenderTree, printing didFailLoadWithError.
462 * DumpRenderTree/gtk/DumpRenderTree.cpp:
463 (webFrameLoadStatusNotified):
465 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
467 <https://webkit.org/b/120049> Delete code for Snow Leopard
469 Reviewed by Benjamin Poulain.
471 * DumpRenderTree/mac/CheckedMalloc.cpp:
472 (protectionOfRegion):
473 (makeLargeMallocFailSilently):
474 * DumpRenderTree/mac/DumpRenderTree.mm:
475 (resetDefaultsToConsistentValues):
476 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
477 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
478 * DumpRenderTree/mac/FrameLoadDelegate.mm:
480 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
481 * DumpRenderTree/mac/LayoutTestHelper.m:
482 * DumpRenderTree/mac/TestRunnerMac.mm:
483 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
484 (WTR::InjectedBundle::platformInitialize):
485 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
486 (WTR::testPathFromURL):
487 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
489 2013-08-19 Alexey Proskuryakov <ap@apple.com>
491 https://bugs.webkit.org/show_bug.cgi?id=119915
492 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
494 Reviewed by Darin Adler.
496 The issue was that we ended up having no CFNetwork cache in the testing session due
497 to an incorrect cache model. There is a number of things not implemented when it
498 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
499 the easiest way to get this going is to initialize it to correct value upfront.
501 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
503 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
505 REGRESSION(r154275): webkitpy tests failing
506 https://bugs.webkit.org/show_bug.cgi?id=120010
508 Reviewed by Jocelyn Turcotte.
510 Update unit-tests to tests the new search-path structure,
511 but reverting the architecture search path addition.
513 * Scripts/webkitpy/port/qt.py:
516 (QtPort._generate_all_test_configurations):
517 (QtPort.qt_architecture):
518 * Scripts/webkitpy/port/qt_unittest.py:
520 (QtPortTest._assert_search_path):
521 (QtPortTest._assert_expectations_files):
522 (QtPortTest._qt_version):
524 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
526 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
528 Unreviewed meta gardening.
530 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
532 * Scripts/webkitpy/port/qt.py:
533 (QtPort._search_paths):
535 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
537 Restructure Qt test expectations
539 Unreviewed meta gardening.
541 Removed 5.0 name from WK1 and WK2 results and made it possible to set
542 expectations by both Qt version and mayor architectures.
544 * Scripts/webkitpy/port/qt.py:
545 (QtPort._wk2_port_name):
548 (QtPort.architecture):
549 (QtPort._search_paths):
550 (QtPort._port_specific_expectations_files):
552 2013-08-16 Brent Fulgham <bfulgham@apple.com>
554 [Windows] DRT is not using the same preferences as the Mac build.
555 https://bugs.webkit.org/show_bug.cgi?id=119822
557 Reviewed by Darin Adler.
559 * DumpRenderTree/win/DumpRenderTree.cpp:
560 (runTest): Process Windows message queue using CFRunLoop to allow
561 dispatch routines to run properly.
562 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
563 to prevent problems on WinCairo port.
565 2013-08-16 Brent Fulgham <bfulgham@apple.com>
567 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
568 https://bugs.webkit.org/show_bug.cgi?id=119583
570 Reviewed by Alexey Proskuryakov.
572 * DumpRenderTree/win/DumpRenderTree.cpp:
573 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
574 component if the URL does not contain the expected base URL.
576 2013-08-16 Pratik Solanki <psolanki@apple.com>
578 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
580 Reviewed by Andreas Kling.
582 m_script is never NULL so we can just return a reference. Also remove some pointless null
583 checks as a result of doing this.
585 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
586 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
588 2013-08-15 Alexey Proskuryakov <ap@apple.com>
590 [WK2] NetworkProcess should use a temporary storage session for test
591 https://bugs.webkit.org/show_bug.cgi?id=119855
593 Reviewed by Darin Adler.
595 Use a new API that takes care of both WebProcess and NetworkProcess.
597 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
598 (WTR::InjectedBundle::initialize):
599 * WebKitTestRunner/TestController.cpp:
600 (WTR::TestController::initialize):
602 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
604 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
606 Reviewed by Dirk Pranke.
608 This is a port from Blink of
609 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
610 originally by Dirk Pranke.
612 From the original commit:
614 This gives something like a 15x speedup over compiling and matching
615 one property at a time and doing multiple passes over the file.
617 * Scripts/webkitpy/w3c/test_converter.py:
618 (W3CTestConverter.__init__):
619 (W3CTestConverter.convert_prefixed_properties):
620 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
622 2013-08-15 Dan Bernstein <mitz@apple.com>
624 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
626 Reviewed by Darin Adler.
628 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
629 added a message that points to the source code. Removed some unnecessary repetition of what
630 is already in the file.
632 2013-08-15 Andy Estes <aestes@apple.com>
634 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
636 Reviewed by Brady Eidson.
638 Wrote an API test that verifies -[WebView stopLoading:] can be called
639 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
641 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
642 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
643 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
644 (TestWebKitAPI::TEST):
646 2013-08-15 Alexey Proskuryakov <ap@apple.com>
648 Adding Myles Maxfield to contributors.json.
650 Oops, wrong section, fixing.
652 * Scripts/webkitpy/common/config/contributors.json:
654 2013-08-15 Alexey Proskuryakov <ap@apple.com>
656 Adding Myles Maxfield to contributors.json.
658 * Scripts/webkitpy/common/config/contributors.json:
660 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
662 [Qt] Do not check specifically for version 5.0
663 https://bugs.webkit.org/show_bug.cgi?id=119846
665 Reviewed by Jocelyn Turcotte.
667 For Qt 5.x we should always use both wk1 and wk2 basepath results.
669 * Scripts/webkitpy/port/qt.py:
670 (QtPort._search_paths):
672 2013-08-15 Simon Pena <simon.pena@samsung.com>
674 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
676 Reviewed by Gustavo Noronha Silva.
678 Following a similar approach as in r153977, return a path string
679 that is relative to main frame URL or just file name if the
680 resource is not in the same directory subtree, and replace empty
681 strings with "(null)".
683 Update pathFromSoupURI so it behaves more closely to the other
684 ports, and remove the unused code after we no longer print
685 <unknown> in certain cases. Also move
686 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
687 be used both in TestRunnerGtk and in DumpRenderTree.
689 * DumpRenderTree/gtk/DumpRenderTree.cpp:
690 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
691 we can print Soup URIs with the password, since soup_uri_to_string
692 doesn't preserve them.
693 (pathFromSoupURI): Updated following EFL implementation in
694 r153977, and return a WTFString instead of a CString.
695 (convertSoupMessageToURLPath): Return "(null)" instead of empty
696 strings, and handle the new return type of pathFromSoupURI.
697 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
698 reference, and handle the new return type of pathFromSoupURI.
699 (descriptionSuitableForTestResult): Remove unused code.
700 (didFinishLoading): Use convertResourceToURLPath.
701 (didFailLoadingWithError): Use convertResourceToURLPath.
702 (authenticationCallback): Display the URL of the authentication
704 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
705 soupURIToStringPreservingPassword.
706 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
707 soupURIToStringPreservingPassword.
709 2013-08-14 Tim Horton <timothy_horton@apple.com>
711 Un-inline dataLog dumpers for IntSize and IntPoint
712 https://bugs.webkit.org/show_bug.cgi?id=119697
714 Reviewed by Sam Weinig.
716 * TestWebKitAPI/GNUmakefile.am:
718 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
720 Flakiness dashboard build fix.
722 * TestResultServer/static-dashboards/flakiness_dashboard.js:
723 (processTestRunsForBuilder):
725 2013-08-14 Martin Robinson <mrobinson@igalia.com>
727 [GTK] [CMake] Add support for building TestWebKitAPI
728 https://bugs.webkit.org/show_bug.cgi?id=116987
730 Reviewed by Philippe Normand.
732 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
733 platform-specific file, so that GTK+ can override them.
734 * TestWebKitAPI/PlatformGTK.cmake: Added.
736 2013-08-14 Brent Fulgham <bfulgham@apple.com>
738 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
739 https://bugs.webkit.org/show_bug.cgi?id=119775
741 This bug updates the WinLauncher program with a few useful menu
742 options to toggle certain debugging and development features of
745 Reviewed by Tim Horton.
747 * WinLauncher/WinLauncher.cpp:
748 (dllLauncherEntryPoint): Clean up preference objects on exit.
749 (ToggleMenuItem): New function.
750 (LaunchInspector): New function.
751 (WndProc): Add handler for new menu items. Also properly terminate
752 CFRunLoop operation on program exit.
753 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
755 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
756 resource folder to search path.
757 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
760 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
762 Add a hyperlink from build.webkit.org to the flakiness dashboard.
764 Rubbers-tamped by Simon Fraser.
766 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
768 2013-08-14 Benjamin Dupont <bdupont@nds.com>
770 [Qt] Activate visibility API layout tests
771 https://bugs.webkit.org/show_bug.cgi?id=119790
773 Reviewed by Allan Sandfeld Jensen.
775 * DumpRenderTree/qt/TestRunnerQt.cpp:
776 (TestRunner::resetPageVisibility):
777 (TestRunner::setPageVisibility):
779 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
781 [GTK] WK does not link properly against libxslt
782 https://bugs.webkit.org/show_bug.cgi?id=119688
784 Reviewed by Gustavo Noronha Silva.
786 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
788 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
790 2013-08-13 Alexey Proskuryakov <ap@apple.com>
792 [Mac] fast/dom/attr-style-too-lazy.html is flaky
793 https://bugs.webkit.org/show_bug.cgi?id=119763
795 Reviewed by Darin Adler.
797 * DumpRenderTree/mac/UIDelegate.mm:
798 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
799 a test, it would just semi-randomly leak to the next one.
800 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
803 2013-08-13 Tim Horton <timothy_horton@apple.com>
805 [mac] Give MiniBrowser a reasonable bundle identifier
806 https://bugs.webkit.org/show_bug.cgi?id=119773
808 Rubber-stamped by Simon Fraser.
810 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
812 * MiniBrowser/mac/Info.plist:
813 * MiniBrowser/mac/WebBundle/Info.plist:
815 2013-08-13 Dean Jackson <dino@apple.com>
817 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
819 Reviewed by Mark Rowe.
821 Have prepare-ChangeLog produce webkit.org/b/id style
822 URLs rather than exposing the inner workings of our
823 cgi. I was going to use the term "Future Proofing"
824 but that seems excessive :)
826 * Scripts/prepare-ChangeLog:
827 (main): Generate a more human readable form.
828 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
830 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
832 [EFL][DRT] Simplify call to reverseFind()
833 https://bugs.webkit.org/show_bug.cgi?id=119746
835 Reviewed by Christophe Dumez.
837 Follow-up to r153977.
839 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
840 (pathSuitableForTestResult): Instead of defining a static variable
841 that's only used in a single place, pass '/' to reverseFind() directly.
843 2013-08-13 Alberto Garcia <berto@igalia.com>
845 [GTK] Closing inspector window crashes wk
846 https://bugs.webkit.org/show_bug.cgi?id=110865
848 Reviewed by Carlos Garcia Campos.
850 Disconnect all signal handlers if the inspector window is
853 * GtkLauncher/LauncherInspectorWindow.c:
854 (inspectorWindowDestroyed):
855 (launcherInspectorWindowNew):
857 2013-08-12 Dan Bernstein <mitz@apple.com>
859 extract-localizable-strings output is not suited for parsing by Xcode
860 https://bugs.webkit.org/show_bug.cgi?id=119728
862 Reviewed by Darin Adler.
864 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
865 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
866 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
869 * Scripts/extract-localizable-strings:
871 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
873 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
874 https://bugs.webkit.org/show_bug.cgi?id=119585
876 Reviewed by Gyuyoung Kim.
878 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
879 (pathSuitableForTestResult):
880 Return path string that's relative to main frame URL, or just file name if
881 the resource is not in the same directory subtree.
882 Referenced WebKitTestRunner code in r153852.
883 (descriptionSuitableForTestResult):
884 (DumpRenderTreeChrome::onFrameRedirectRequested):
885 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
887 2013-08-12 Dan Bernstein <mitz@apple.com>
889 extract-localizable-strings doesn't know how to verify an existing strings file
890 https://bugs.webkit.org/show_bug.cgi?id=119704
892 Reviewed by Darin Adler.
894 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
895 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
896 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
897 the way directories to skip are specified from prefixing the directory with a “-” to
898 specifying it with --skip.
899 Finally, added a --verify option. When specified, the strings file is not written to, but
900 instead read in and checked for consistency with the comments, keys and values derived from
901 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
902 mismatching comments are reported as errors.
903 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
904 directories to skip and no exceptions file.
906 2013-08-12 Alexey Proskuryakov <ap@apple.com>
908 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
909 https://bugs.webkit.org/show_bug.cgi?id=85522
911 Reviewed by Andy Estes.
913 * DumpRenderTree/mac/UIDelegate.mm:
914 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
915 when already done with a test. We already had this check in all UI delegate functions,
916 except for -webView:addMessageToConsole:withSource: somehow.
918 2013-08-12 Alexey Proskuryakov <ap@apple.com>
920 https://bugs.webkit.org/show_bug.cgi?id=119693
921 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
922 because of connect-src-websocket-allowed.html
924 Reviewed by Darin Adler.
926 Starting a load of about:blank and immediately stopping it cancels outstanding
927 resource loads, but the page has to transition to committed state to have timers
928 or WebSockets stopped too.
930 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
931 ensure that transition to committed state happens before we start the next test.
933 2013-08-12 Beth Dakin <bdakin@apple.com>
935 The LayoutMilestones didLayout callback should only fire for the main frame
936 https://bugs.webkit.org/show_bug.cgi?id=119457
938 Reviewed by Sam Weinig.
940 Now that the didLayout callback only fires for the main frame, we want to make
941 sure it will fire even when all of the content is in a subframe.
943 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
944 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
945 (TestWebKitAPI::didLayout):
946 (TestWebKitAPI::TEST):
947 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
949 2013-08-12 Beth Dakin <bdakin@apple.com>
951 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
952 https://bugs.webkit.org/show_bug.cgi?id=119658
954 Reviewed by Darin Adler.
956 * MiniBrowser/mac/WK2BrowserWindowController.m:
957 (-[WK2BrowserWindowController awakeFromNib]):
958 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
959 (WTR::InjectedBundlePage::InjectedBundlePage):
960 * WebKitTestRunner/TestController.cpp:
961 (WTR::TestController::createWebViewWithOptions):
963 2013-08-12 Seokju Kwon <seokju@webkit.org>
965 Remove glu's libtest rule from checker.py
966 https://bugs.webkit.org/show_bug.cgi?id=119674
968 Reviewed by Darin Adler.
970 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
972 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
974 Unreviewed. Change my primary mail address.
976 * Scripts/webkitpy/common/config/contributors.json:
978 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
980 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
981 https://bugs.webkit.org/show_bug.cgi?id=115751
983 Reviewed by Martin Robinson.
985 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
988 2013-08-09 Beth Dakin <bdakin@apple.com>
990 AX: Not able to use arrow keys to read text in a WK2 app
991 https://bugs.webkit.org/show_bug.cgi?id=119605
993 <rdar://problem/14281275>
995 Reviewed by Darin Adler.
997 New test verifies that didNotHandleKeyEvent will be called when there is nothing
999 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1000 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
1001 (TestWebKitAPI::didFinishLoadForFrame):
1002 (TestWebKitAPI::didNotHandleKeyEventCallback):
1003 (TestWebKitAPI::TEST):
1005 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
1007 Add support for KeyboardEvent.location attribute
1008 https://bugs.webkit.org/show_bug.cgi?id=119326
1010 Reviewed by Benjamin Poulain.
1012 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
1014 * DumpRenderTree/mac/EventSendingController.mm:
1015 (-[EventSendingController keyDown:withModifiers:withLocation:]):
1016 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
1017 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
1018 (-[EventSendingController handleEvent:]):
1019 (-[EventSendingController fireKeyboardEventsToElement:]):
1021 2013-08-09 Alexey Proskuryakov <ap@apple.com>
1023 <unknown> is often dumped instead of path in test output
1024 https://bugs.webkit.org/show_bug.cgi?id=119590
1026 Reviewed by Anders Carlsson.
1028 There were two reasons for <unknown>:
1029 1. When delegate logging is enabled via a testRunner call, that obviously happens
1030 after main resource load starts, so we don't record its URL.
1031 2. Authentication delegate logging relied on URL recording, but it's only turned on
1032 when enabling resource loading delegate logging, not auth one.
1034 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
1035 landed without posted rationale and unreviewed. Just undoing that change now.
1037 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1038 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1039 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1040 (WTR::InjectedBundlePage::didInitiateLoadForResource):
1042 2013-08-08 Alex Christensen <achristensen@apple.com>
1044 Windows build fixes.
1046 Rubberstamped by Brent Fulgham.
1048 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1049 Removed /SAFESEH link option which doesn't work with x64.
1051 2013-08-08 Daniel Bates <dabates@apple.com>
1053 Add iOS support to run-javascriptcore-tests
1054 https://bugs.webkit.org/show_bug.cgi?id=119602
1056 Reviewed by Joseph Pecoraro.
1058 Make run-javascriptcore-tests work for iOS WebKit.
1060 * Scripts/run-javascriptcore-tests:
1062 2013-08-08 Alexey Proskuryakov <ap@apple.com>
1064 [WK2] loader/go-back-cached-main-resource.html fails
1065 https://bugs.webkit.org/show_bug.cgi?id=116491
1067 Reviewed by Tim Horton.
1069 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1070 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1071 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1072 * DumpRenderTree/win/DumpRenderTree.cpp:
1073 Added FIXMEs about making path printing normalization more compatible.
1075 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
1076 Return last path component in cases where we used to return a full path, which is
1077 never desirable. Added a null check to basePath to prevent potentially getting
1078 an Objective C exception.
1080 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1081 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
1082 for a currently loading one (which is different for tests that use multiple windows).
1083 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
1084 last path component as last fallback.
1085 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
1086 frame URL here, and it was potentially a wrong frame.
1087 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
1088 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
1089 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
1090 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
1091 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
1093 2013-08-08 Alex Christensen <achristensen@apple.com>
1095 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1096 https://bugs.webkit.org/show_bug.cgi?id=116125
1098 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
1100 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1101 (WTR::pathSuitableForTestResult):
1102 Changed string operations to match _drt_descriptionSuitableForTestResult.
1103 (WTR::dumpRequestDescriptionSuitableForTestResult):
1104 (WTR::dumpResponseDescriptionSuitableForTestResult):
1105 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1106 (WTR::InjectedBundlePage::didInitiateLoadForResource):
1107 (WTR::InjectedBundlePage::willSendRequestForFrame):
1108 (WTR::InjectedBundlePage::didReceiveResponseForResource):
1109 Pass the main frame's URL to pathSuitableForTestResult.
1110 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1111 Added WKBundlePageRef to willPerformClientRedirectForFrame.
1113 2013-08-07 Simon Fraser <simon.fraser@apple.com>
1115 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
1116 https://bugs.webkit.org/show_bug.cgi?id=119317
1118 Reviewed by Tim Horton.
1120 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
1121 the test to complete, which is not power friendly. Although DRT instances
1122 are generally busy anyway, not sitting in a busy loop should free up some CPU
1123 cycles for other instances of DRT.
1125 Editing tests continue to pass. All Java tests are skipped and were not
1126 tested, but when run fail similarly with and without the patch.
1128 * DumpRenderTree/mac/DumpRenderTree.mm:
1132 2013-08-07 Daniel Bates <dabates@apple.com>
1134 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
1135 <https://bugs.webkit.org/show_bug.cgi?id=119558>
1137 Reviewed by Martin Robinson.
1139 Currently we build the command line to execute jsDriver.pl twice so as to both
1140 print it to standard output and actually execute it. We should only build up
1141 this command line once. Moreover, we should print to standard output the actual
1142 command line that we are going to use including the GTK- and EFL-specific call
1143 to /Tools/jhbuild/jhbuild-wrapper.
1145 * Scripts/run-javascriptcore-tests:
1147 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
1149 [EFL] REGRESSION after r153432: some accessibility tests crash.
1150 https://bugs.webkit.org/show_bug.cgi?id=119333
1152 Reviewed by Darin Adler.
1154 Use a RefPtr to store a reference to the parent element of
1155 an AccessibilityUIElement instead of the raw pointer, so we
1156 never derefence a function from an invalid pointer.
1158 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1159 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
1161 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
1163 Unreviewed. Add myself as a committer.
1165 * Scripts/webkitpy/common/config/contributors.json:
1167 2013-08-04 Sam Weinig <sam@webkit.org>
1169 Remove support for HTML5 MicroData
1170 https://bugs.webkit.org/show_bug.cgi?id=119480
1172 Reviewed by Anders Carlsson.
1174 * Scripts/webkitperl/FeatureList.pm:
1175 * qmake/mkspecs/features/features.pri:
1177 2013-07-23 David Farler <dfarler@apple.com>
1179 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
1180 https://bugs.webkit.org/show_bug.cgi?id=117762
1182 Reviewed by Mark Rowe.
1184 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1185 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1186 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1187 Add ASAN_OTHER_LDFLAGS.
1188 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1189 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1190 * Scripts/check-for-weak-vtables-and-externals:
1191 Ignore ___asan externals, these are populated by compiler-rt.
1192 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1193 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1194 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1195 Add ASAN_OTHER_LDFLAGS.
1196 * WebKitLauncher/Configurations/Base.xcconfig:
1197 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1198 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
1199 Add ASAN_OTHER_LDFLAGS.
1200 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1201 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1202 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1203 Add ASAN_OTHER_LDFLAGS.
1204 * asan/asan.xcconfig: Added.
1205 * asan/webkit-asan-ignore.txt: Added.
1207 2013-08-05 Brian Holt <brian.holt@samsung.com>
1209 [GTK] Implement leak checking with valgrind
1210 https://bugs.webkit.org/show_bug.cgi?id=118785
1212 Reviewed by Dirk Pranke.
1214 Launch the DRT under Valgrind to generate xml files with details
1217 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1219 * Scripts/webkitpy/port/gtk.py:
1221 (GtkPort.default_timeout_ms): Allow extra time to run under
1223 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1224 using environment variables.
1226 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
1228 [EFL] REGRESSION after r153432: some accessibility tests crash.
1229 https://bugs.webkit.org/show_bug.cgi?id=119333
1231 Reviewed by Gustavo Noronha Silva.
1233 Add missing null-check to avoid dereferencing a non-existent parent.
1235 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1236 (WTR::attributesOfElement): Ditto.
1238 2013-08-02 Patrick Gansterer <paroga@webkit.org>
1240 Add --rmdir option to git svn dcommit
1241 https://bugs.webkit.org/show_bug.cgi?id=119398
1243 Reviewed by Ryosuke Niwa.
1245 Add this option tells git-svn to remove empty directories
1246 from the svn tree so they do not leave over there.
1248 * Scripts/webkitpy/common/checkout/scm/git.py:
1249 (Git.push_local_commits_to_server):
1251 2013-08-01 Brent Fulgham <bfulgham@apple.com>
1253 [Windows] WebKit1 Fullscreen Video Play is Broken
1254 https://bugs.webkit.org/show_bug.cgi?id=119415
1256 Reviewed by Jer Noble.
1258 * WinLauncher/WinLauncher.cpp:
1259 (dllLauncherEntryPoint): Activate full screen mode via
1260 IWebPreferencesInternal interface.
1262 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
1264 Unreviewed. Add an alternative address to show my affiliation in team.html.
1266 * Scripts/webkitpy/common/config/contributors.json:
1268 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
1270 Duplicate property names can cause test to fail
1271 https://bugs.webkit.org/show_bug.cgi?id=119399
1273 Reviewed by Dirk Pranke.
1275 This problem was noticed when porting the patch for
1276 http://wkb.ug/119357 to Blink: a test would fail because the converted
1277 and test property lists weren't the same length, but they contained
1278 all of the same property names. It looks like this is actually caused
1279 by a bug in converting the HTML, which is being currently rewritten.
1280 In the meantime, as long as this compares the number of unique
1281 properties, it makes the test more robust.
1283 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1284 (verify_prefixed_properties):
1286 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
1288 Unreviewed. Adding my expertise.
1290 * Scripts/webkitpy/common/config/contributors.json:
1292 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
1294 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1296 * Scripts/webkitpy/common/config/contributors.json:
1298 2013-08-01 Commit Queue <commit-queue@webkit.org>
1300 Unreviewed, rolling out r153518.
1301 http://trac.webkit.org/changeset/153518
1302 https://bugs.webkit.org/show_bug.cgi?id=119386
1304 The Jhbuild dep bump of GTK+ is not actually required by
1305 layout testing, is causing pango dep problems (Requested by
1306 zdobersek on #webkit).
1308 * gtk/jhbuild.modules:
1310 2013-08-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
1312 Unreviewed. Add myself as a committer.
1314 * Scripts/webkitpy/common/config/contributors.json:
1316 2013-08-01 Jaehun Lim <ljaehun.lim@samsung.com>
1318 Unreviewed. Add myself as a committer.
1320 * Scripts/webkitpy/common/config/contributors.json:
1322 2013-07-31 Jinwoo Song <jinwoo7.song@samsung.com>
1324 Unreviewed. Add myself as a committer.
1326 * Scripts/webkitpy/common/config/contributors.json:
1328 2013-08-01 Alberto Garcia <berto@igalia.com>
1330 Unreviewed. Add myself as a committer.
1332 * Scripts/webkitpy/common/config/contributors.json:
1334 2013-07-31 Seokju Kwon <seokju@webkit.org>
1336 Unreviewed. Add myself as a committer.
1338 * Scripts/webkitpy/common/config/contributors.json:
1340 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1342 W3C test import script prefixes some properties that it shouldn't
1343 https://bugs.webkit.org/show_bug.cgi?id=119357
1345 Reviewed by Dirk Pranke.
1347 Some prefixed properties also have unprefixed implemetations, but when
1348 the implementations aren't identical, they aren't declared in
1349 CSSPropertyNames.in on the same line. This fixes the import script so
1350 that it catches all instances of prefixed properties that have an
1351 unprefixed variant, and does not add the prefix in those cases.
1353 * Scripts/webkitpy/w3c/test_converter.py:
1354 (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1355 the properties on every line and record if they are prefixed or not.
1356 Use this information to only return prefixed properties that do not
1357 have any unprefixed variant. The prefixed property list has also
1358 changed to not include the '-webkit-' prefix, making it much easier to
1359 do the comparison, and removing the need to remove the prefix later.
1360 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1361 longer needs to remove the '-webkit-' prefix, but needs to add it in
1362 the case where a property that needs a prefix is found.
1363 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1364 (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1365 for '-webkit-' prefix, as it is no longer included in the properties
1366 in the prefixed property list.
1368 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1370 Update location of w3c shapes tests to reflect new import location
1371 https://bugs.webkit.org/show_bug.cgi?id=118156
1373 Reviewed by Dirk Pranke.
1375 Partial imports should not be imported to the same place as the full
1376 import, so this adds an option to allow importing to a different
1377 location than the default. In doing that, I found that imports from
1378 contributor directories didn't seem to be working correctly, so I
1379 updated the import to be smarter about both contributor directories
1380 and the test status directories. It should now be more likely that the
1381 script guesses the root directory properly.
1383 * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1384 script not working with the full set of contributors, as that is
1385 no longer true, and I didn't see a good way to keep that behavior.
1386 Also update documentation to properly explain what happens when a
1387 contributor dir is imported.
1388 (main): Attempt to find the proper repo dir by looking at the
1389 directory above the "test status" in the given path, this is still
1390 not exactly right, but is less error prone than just trimming.
1391 (parse_args): Add -d option to set the import directory.
1392 (TestImporter.__init__): Stop appending the subdirs to the
1393 destination_directory because it was making things more complex
1394 and isn't really needed.
1395 (TestImporter.update_test_status): Remove hardcoded strings and use
1396 the TEST_STATUS constants instead.
1397 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1398 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1399 support for new option.
1400 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1402 2013-07-31 Brent Fulgham <bfulgham@apple.com>
1404 [Windows] Winlauncher shouldn't look for Safari Install Directory
1405 https://bugs.webkit.org/show_bug.cgi?id=119351
1407 Reviewed by Darin Adler.
1409 * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1410 the Safari install location. Instead, use the proper support
1411 library path for the build architecture.
1413 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1415 Update scripts to reference contributors.json instead of committers.py in messaging
1416 https://bugs.webkit.org/show_bug.cgi?id=119342
1418 Reviewed by Ryosuke Niwa.
1420 Change the scripts to point people to contributors.json instead of
1421 committers.py since the latter no longer contains the list of
1424 * Scripts/webkitpy/common/config/committervalidator.py:
1425 (CommitterValidator._contributors_json_path):
1426 (CommitterValidator._flag_permission_rejection_message):
1427 * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1428 (CommitterValidatorTest.test_flag_permission_rejection_message):
1429 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1430 (Bugzilla._commit_queue_flag):
1431 * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1432 (WatchListParser._validate):
1433 * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1434 (WatchListParserTest.test_cc_rule_with_invalid_email):
1435 * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1436 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1437 * Scripts/webkitpy/tool/steps/validatereviewer.py:
1438 (ValidateReviewer.run):
1440 2013-07-31 Roger Fong <roger_fong@apple.com>
1442 Unreviewed. Re-enable WinEWS tests following r153527.
1444 * Scripts/webkitpy/common/config/ews.json:
1446 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1448 Unreviewed: Adding myself to the committers' list.
1450 * Scripts/webkitpy/common/config/contributors.json:
1452 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1454 [Qt] Build WebKit with C++11
1455 https://bugs.webkit.org/show_bug.cgi?id=119337
1457 Reviewed by Csaba Osztrogonác.
1459 Enable building with C++11.
1461 * qmake/mkspecs/features/default_pre.prf:
1462 * qmake/mkspecs/features/unix/default_post.prf:
1463 * qmake/mkspecs/features/unix/default_pre.prf:
1465 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1467 [Qt] ASSERTS trigger in release builds
1468 https://bugs.webkit.org/show_bug.cgi?id=119336
1470 Reviewed by Jocelyn Turcotte.
1472 Ensure the qmake also defaults to release if no configuration is known.
1474 * qmake/mkspecs/features/default_post.prf:
1476 2013-07-31 Zan Dobersek <zdobersek@igalia.com>
1478 [texmap][GStreamer][GTK] composited video shows tearing
1479 https://bugs.webkit.org/show_bug.cgi?id=118253
1481 Reviewed by Martin Robinson.
1483 * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1484 The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1485 screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1487 2013-07-30 Ruth Fong <ruth_fong@apple.com>
1489 Unreviewed: Adding myself to the committers' list.
1491 * Scripts/webkitpy/common/config/contributors.json:
1493 2013-07-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1495 Unreviewed, add my new email to contributors.json.
1497 * Scripts/webkitpy/common/config/contributors.json:
1499 2013-07-30 Krzysztof Czech <k.czech@samsung.com>
1501 [EFL] REGRESSION after r153439: layout tests do not run.
1502 https://bugs.webkit.org/show_bug.cgi?id=119240
1504 Reviewed by Christophe Dumez.
1506 Changed attribute name from check_xvfb to check_driver.
1508 * Scripts/webkitpy/port/efl.py:
1509 (EflPort.check_sys_deps):
1511 2013-07-29 Commit Queue <commit-queue@webkit.org>
1513 Unreviewed, rolling out r152860.
1514 http://trac.webkit.org/changeset/152860
1515 https://bugs.webkit.org/show_bug.cgi?id=119227
1517 Disable WinEWS tests until tests stop crashing (Requested by
1520 * Scripts/webkitpy/common/config/ews.json:
1522 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1524 [GTK] Add WestonDriver, use it when appropriate
1525 https://bugs.webkit.org/show_bug.cgi?id=119100
1527 Reviewed by Dirk Pranke.
1529 Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1530 and sets up an environment that enables the test runner to run inside it.
1532 The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1533 environment variable is set, that is when NRWT is being run under a Wayland display.
1535 * Scripts/webkitpy/port/base.py:
1536 (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1537 * Scripts/webkitpy/port/gtk.py:
1539 (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1540 should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1541 (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1542 instead of hard-coding the XvfbDriver class in the check.
1543 * Scripts/webkitpy/port/westondriver.py: Added.
1545 (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1546 (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1547 (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1548 driver and then launches the driver in said environment, using the driver's Weston display.
1549 (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1550 (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1551 and returns the absolute path to it.
1552 * Scripts/webkitpy/port/xvfbdriver.py:
1553 (XvfbDriver.check_driver): Renamed from check_xvfb.
1554 (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1556 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1558 [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1559 https://bugs.webkit.org/show_bug.cgi?id=118967
1561 Reviewed by Gustavo Noronha Silva.
1563 Implemented AccessibilityUIElement::attributesOfChildren() both
1564 in DumpRenderTree and the WebKitTestRunner.
1566 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1567 (AccessibilityUIElement::attributesOfChildren): Implemented.
1569 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1570 (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1572 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1574 [ATK] Implement allAttributes() for AccessibilityUIElement
1575 https://bugs.webkit.org/show_bug.cgi?id=118966
1577 Reviewed by Gustavo Noronha Silva.
1579 Implemented AccessibilityUIElement::allAttributes() both in
1580 DumpRenderTree and the WebKitTestRunner.
1582 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1583 (getAtkAttributeSetAsString): Moved up in the file, and refactored
1584 to use StringBuilder and return a String instead of a gchar*.
1585 (roleToString): Changed not to return the "AXRole: " prefix, so
1586 we can use it as well from attributesOfElement().
1587 (attributesOfElement): New function to dump attributes for an object.
1588 (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1589 (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1591 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1592 (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1593 a String instead of a gchar*.
1595 (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1596 so we can use it as well from attributesOfElement().
1597 (WTF::attributesOfElement): New function to dump attributes for an object.
1598 (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1599 (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1601 2013-07-29 Daniel Bates <dabates@apple.com>
1603 Add support infrastructure for iOS WebKit port
1604 https://bugs.webkit.org/show_bug.cgi?id=119168
1606 Reviewed by Ryosuke Niwa.
1608 Implement support infrastructure towards building iOS WebKit.
1610 * Scripts/webkitdirs.pm:
1611 (xcodeSDKPlatformName): Added.
1612 (determineConfigurationProductDir):
1613 (builtDylibPathForName):
1614 (willUseIOSDeviceSDKWhenBuilding): Added.
1615 (willUseIOSSimulatorSDKWhenBuilding): Added.
1616 (isIOSWebKit): Added.
1617 (copyInspectorFrontendFiles):
1619 2013-07-29 Sergio Correia <sergio.correia@openbossa.org>
1621 CoordinatedGraphics: Add API to get and set the active state of a WebView
1622 https://bugs.webkit.org/show_bug.cgi?id=119067
1624 Reviewed by Noam Rosenthal.
1626 Added API tests for WKViewIsActive and WKViewSetIsActive.
1628 * TestWebKitAPI/PlatformEfl.cmake:
1629 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1630 (TestWebKitAPI::didFinishLoadForFrame):
1631 (TestWebKitAPI::webProcessCrashed):
1632 (TestWebKitAPI::webProcessRelaunched):
1633 (TestWebKitAPI::TEST):
1634 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1635 Bundle added to allow crashing the WebProcess and testing the active state of a view
1636 under such condition.
1637 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1638 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1640 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1642 [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1643 https://bugs.webkit.org/show_bug.cgi?id=119212
1645 Reviewed by Carlos Garcia Campos.
1647 * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1648 variables that are not defined during the configuration process.
1649 * TestWebKitAPI/GNUmakefile.am: Ditto.
1650 * WebKitTestRunner/GNUmakefile.am: Ditto.
1652 2013-07-28 Andy Estes <aestes@apple.com>
1654 Include <stdio.h> to declare perror()
1655 https://bugs.webkit.org/show_bug.cgi?id=119198
1657 Reviewed by Andreas Kling.
1659 Silences an implicit declaration warning.
1661 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1663 2013-07-27 Ryuan Choi <ryuan.choi@samsung.com>
1665 [EFL] Bump required version of EFL to 1.7
1666 https://bugs.webkit.org/show_bug.cgi?id=119144
1668 Reviewed by Christophe Dumez.
1670 * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1672 2013-07-26 Filip Pizlo <fpizlo@apple.com>
1674 WKTR should know about the JSC extensions to testRunner
1675 https://bugs.webkit.org/show_bug.cgi?id=119154
1677 Reviewed by Mark Hahnenberg and Geoffrey Garen.
1679 This makes some fast/js tests pass.
1681 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1682 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1683 (WTR::TestRunner::numberOfDFGCompiles):
1684 (WTR::TestRunner::neverInlineFunction):
1685 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1687 2013-07-25 Mark Rowe <mrowe@apple.com>
1689 Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1691 * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1692 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1693 so they pull the version out of the SDK.
1695 2013-07-25 Anders Carlsson <andersca@apple.com>
1697 Localizable.strings generated by extract-localizable-strings should be UTF-8
1698 https://bugs.webkit.org/show_bug.cgi?id=119106
1700 Reviewed by Mark Rowe.
1702 Output strings as UTF-8.
1704 * Scripts/extract-localizable-strings:
1706 2013-07-25 Sam Weinig <sam@webkit.org>
1708 -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1709 https://bugs.webkit.org/show_bug.cgi?id=119099
1710 <rdar://problem/13439291>
1712 Reviewed by Enrica Casucci.
1714 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1715 * TestWebKitAPI/Tests/mac/AttributedString.mm:
1716 (TestWebKitAPI::attributedString):
1717 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1718 (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1719 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1720 (TestWebKitAPI::TEST_F):
1721 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1722 (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1723 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1724 * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1725 Add tests for attributed strings with strikethrough. Refactor the attributed string tests
1726 to make adding more easier in the future.
1728 2013-07-20 Filip Pizlo <fpizlo@apple.com>
1730 fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1731 https://bugs.webkit.org/show_bug.cgi?id=118948
1733 Reviewed by Sam Weinig.
1735 - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1736 by exporting it as a function.
1738 - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1739 it even if you know that you've already done so. See processIRDump.sh.
1741 - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1742 runs it through ReducedFTL automatically. You typically want to say something like:
1744 jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1745 ./processIRDump.sh --timing < jsc-output.txt
1747 * ReducedFTL/ReducedFTL.c:
1749 * ReducedFTL/combineModules.rb:
1750 * ReducedFTL/processIRDump.sh: Added.
1752 2013-07-20 Filip Pizlo <fpizlo@apple.com>
1754 fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1755 https://bugs.webkit.org/show_bug.cgi?id=118947
1757 Reviewed by Dan Bernstein.
1759 * Scripts/copy-webkitlibraries-to-product-directory:
1761 2013-07-16 Filip Pizlo <fpizlo@apple.com>
1763 fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1764 https://bugs.webkit.org/show_bug.cgi?id=118647
1766 Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1768 Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1769 way that the FTL would.
1771 Also add a tool that combines multiple LLVM modules generated by FTL into a
1774 * ReducedFTL: Added.
1775 * ReducedFTL/ReducedFTL.c: Added.
1779 (mmAllocateCodeSection):
1780 (mmAllocateDataSection):
1781 (mmApplyPermissions):
1783 (symbolLookupCallback):
1785 * ReducedFTL/build.sh: Added.
1786 * ReducedFTL/combineModules.rb: Added.
1788 2013-06-09 Filip Pizlo <fpizlo@apple.com>
1790 Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1791 for the "/" that is printed between engine counts.
1793 * Scripts/display-profiler-output:
1795 2013-05-28 Filip Pizlo <fpizlo@apple.com>
1797 testRunner should have a way of disabling inlining of functions
1798 https://bugs.webkit.org/show_bug.cgi?id=116875
1800 Reviewed by Mark Hahnenberg.
1802 * DumpRenderTree/TestRunner.cpp:
1803 (neverInlineFunction):
1804 (TestRunner::staticFunctions):
1806 2013-05-27 Filip Pizlo <fpizlo@apple.com>
1808 testRunner should be able to tell you if a function is DFG compiled
1809 https://bugs.webkit.org/show_bug.cgi?id=116847
1811 Reviewed by Mark Hahnenberg.
1813 * DumpRenderTree/TestRunner.cpp:
1814 (numberOfDFGCompiles):
1815 (TestRunner::staticFunctions):
1817 2013-05-21 Filip Pizlo <fpizlo@apple.com>
1819 fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1820 https://bugs.webkit.org/show_bug.cgi?id=116556
1822 Reviewed by Oliver Hunt.
1824 This adds three new capabilities:
1826 - 'display' now accepts negative compilation indices, and allows specifying
1827 wildcard hashes combined with combination indices. Previously you could say
1828 'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1829 latter would display every compilation. This improves this so that you can
1830 say 'display *-<index>-<engine>'. It also makes it so that you can give a
1831 negative index, which allows you to say things like 'display blah--1-dfg',
1832 which displays just the last DFG compilation. Also you can say
1833 'display *--1-dfg', which displays the last DFG compilation for each code
1834 block. I realize that this is kind of ugly, but gosh is it practical.
1836 - You can now say 'sort hash', which will henceforth sort all of the output
1837 by code hash rather than by the time when it was compiled. This means that
1838 if you're doing 'dispay *--1-dfg' and then want to diff the results against
1839 something else, you can ensure that this doesn't get confused just by
1840 changes in compilation order.
1842 - You can now say 'counts off', which will henceforth disable the display of
1843 execution counts from 'bytecode' and 'display'. This is also useful for
1844 diffs, since if you're trying to figure out why two compilations are
1845 different, they probably have radically different counts. 'counts off' gets
1846 this out of the output so that it doesn't confuse your diff.
1848 Note that to use this effectively you should also have a script that scrubs
1849 pointers from text so that the diff doesn't get confused by pointers. I'll
1850 post my elimptr script to the bug. Maybe at some point I'll integrate that
1851 into display-profiler-output.
1853 Put together this is pretty awesome. I was able to do the following:
1855 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1856 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1857 diff -u richards-serial.asm richards-concurrent.asm
1859 And this immediately told me that the reason why richards is slower in the
1860 concurrent compilation case is just that we end up compiling *tons* more
1861 functions, most of which are trivially inlineable. Basically, concurrent
1862 compilation breaks our previous heuristics for delaying compilation of
1863 inlineables just enough that they never trigger compilation. We should fix
1864 that in a separate bug.
1866 * Scripts/display-profiler-output:
1868 2013-04-30 Filip Pizlo <fpizlo@apple.com>
1870 fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1872 Rubber stamped by Mark Rowe.
1874 * Scripts/copy-webkitlibraries-to-product-directory:
1876 2013-07-16 Oliver Hunt <oliver@apple.com>
1878 Merge dfgFourthTier r148853
1880 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1882 fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1883 https://bugs.webkit.org/show_bug.cgi?id=114933
1885 Reviewed by Andy Estes.
1887 This makes it easy to get set up for tandem LLVM builds.
1889 * Scripts/copy-webkitlibraries-to-product-directory:
1891 2013-07-16 Oliver Hunt <oliver@apple.com>
1893 Merge dfgFourthTier r148850
1895 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1897 fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1898 https://bugs.webkit.org/show_bug.cgi?id=114926
1900 Reviewed by Geoffrey Garen.
1902 If the LLVM libraries change, then touch a phony header, which will force relink
1905 * Scripts/copy-webkitlibraries-to-product-directory:
1906 (unpackIfNecessary):
1908 2013-07-16 Oliver Hunt <oliver@apple.com>
1910 Merge dfgFourthTier r148848
1912 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1914 fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1915 https://bugs.webkit.org/show_bug.cgi?id=114925
1917 Reviewed by Geoffrey Garen.
1919 This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1920 will also optionally build LLVM and quickly symlink LLVM's built products into
1923 Most WebKit and JSC hackers will want to rely on the checked-in already-built
1924 versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1925 increasingly common use-case for me, and it may become a common use case for a
1926 handful of others. Currently, this is really painful: you first have to build
1927 LLVM, then you have to export-llvm-build (which takes a while), and then you
1928 have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1929 variables are set to point to the thing you exported. The whole process loses
1930 track of dependencies very quickly: making a tiny change in LLVM requires
1931 packaging, and then unpackaging, a large number of potentially large headers and
1932 static libraries. Not only is this slow but it then causes the WebKit build
1933 system to rebuild anything that transitively includes any LLVM header, which is
1934 now quite a few files. While this sort of use pattern is still worthwhile if
1935 you're trying to package a binary drop and test it, it's not great if you're
1936 just trying to do experimental development that involves making small changes
1939 This change fixes this use case while keeping the old use cases intact. You can
1940 do tandem development using one of two modes:
1942 Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1943 the LLVM directory you're using. Once this is done, any invocation of a WebKit
1944 build via build-jsc or build-webkit will also build LLVM, and then quickly
1945 symlink things into place without perturbing dependency tracking.
1947 Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1948 right off of the WebKit source tree, then the build system will automatically
1951 Here's how this takes care of dependencies:
1953 Headers: the include/llvm and include/llvm-c directories are symlinked into
1954 $productsDir/usr/local/include. And then everything just works.
1956 Libraries: the build system detects, by reading LLVM's Makefile.config, which
1957 mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1958 the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1959 if they have changed, by checking both the modification time and also whether
1960 the last time we had a symlink, that symlink was from the same directory.
1961 This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1962 but that build wasn't yet ranlib'd.
1964 One problem that this does not yet solve is that xcodebuild will not relink
1965 JavaScriptCore if the only thing that changed was the libraries. I will work
1966 on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1968 * Scripts/copy-webkitlibraries-to-product-directory:
1969 (unpackIfNecessary):
1971 (fileContentsEquals):
1973 2013-04-15 Filip Pizlo <fpizlo@apple.com>
1975 fourthTier: Update LLVM-related build scripts to copy generated headers as well
1976 https://bugs.webkit.org/show_bug.cgi?id=114551
1978 Reviewed by Oliver Hunt.
1980 Also added the ability to use something other than bzip2 compression, since although
1981 it is great for checking things into the tree, it increases turn-around times when
1984 * Scripts/copy-webkitlibraries-to-product-directory:
1985 (unpackIfNecessary):
1986 * Scripts/export-llvm-build:
1988 2013-04-03 Filip Pizlo <fpizlo@apple.com>
1990 fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1991 https://bugs.webkit.org/show_bug.cgi?id=113921
1993 Reviewed by Oliver Hunt.
1995 The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1996 the export script to do this.
1998 * Scripts/export-llvm-build:
2000 2013-03-29 Filip Pizlo <fpizlo@apple.com>
2002 fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
2003 https://bugs.webkit.org/show_bug.cgi?id=113452
2005 Rubber stamped by Mark Hahnenberg.
2007 * Scripts/copy-webkitlibraries-to-product-directory:
2008 * Scripts/export-llvm-build:
2010 2013-03-29 Filip Pizlo <fpizlo@apple.com>
2012 fourthTier: FTL JIT should be able run some simple function
2013 https://bugs.webkit.org/show_bug.cgi?id=113481
2015 Reviewed by Geoffrey Garen.
2017 Give the scripts the ability to find an LLVM build and use it.
2019 Also added a script, export-llvm-build, that allows you to take your
2020 own build of LLVM and package it for use by WebKit's build system.
2022 The build system treats a "build" of LLVM as a pair of .tar.bz2's,
2023 one for the library archives and one for the headers. It then unpacks
2024 them into your built products directory in a mannner that is mostly
2025 analogous to how WebKitSystemInterface works.
2027 * Scripts/build-jsc:
2028 * Scripts/copy-webkitlibraries-to-product-directory:
2029 (unpackIfNecessary):
2031 * Scripts/export-llvm-build: Added.
2033 2013-07-24 Anders Carlsson <andersca@apple.com>
2035 Crash when calling WKPageGetProcessIdentifier after aborted process launch
2036 https://bugs.webkit.org/show_bug.cgi?id=119069
2037 <rdar://problem/14494064>
2039 Reviewed by Andreas Kling.
2043 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2044 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
2045 (TestWebKitAPI::didFinishLoadForFrame):
2046 (TestWebKitAPI::TEST):
2048 2013-07-24 Zan Dobersek <zdobersek@igalia.com>
2050 Make KURL::hasPath private
2051 https://bugs.webkit.org/show_bug.cgi?id=118279
2053 Reviewed by Darin Adler.
2055 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2056 (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
2058 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
2060 [GTK] TestInspectorServer unit test is timing out
2061 https://bugs.webkit.org/show_bug.cgi?id=105866
2063 Reviewed by Gustavo Noronha Silva.
2065 * Scripts/run-gtk-tests:
2068 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
2070 [GTK] [WK2] Handle wheel event with delta zero
2071 https://bugs.webkit.org/show_bug.cgi?id=118973
2073 Reviewed by Gustavo Noronha Silva.
2075 Added handling of zero mouse scroll deltas in EventSenderProxy similar
2076 to WK1 and Qt/EFL ports.
2078 fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
2081 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2082 (WTR::EventSenderProxy::mouseScrollBy):
2084 2013-07-23 Andreas Kling <akling@apple.com>
2086 REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
2087 <rdar://problem/14324895>
2088 <http://webkit.org/b/119023>
2090 Reviewed by Simon Fraser.
2092 Add a test for this rather specific problem.
2094 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2095 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
2096 (TestWebKitAPI::TEST):
2097 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
2098 (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
2099 (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
2100 (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2102 2013-07-23 Tim Horton <timothy_horton@apple.com>
2104 Add a test for plug-in unavailability indicator obscurity detection
2105 https://bugs.webkit.org/show_bug.cgi?id=119007
2107 Reviewed by Anders Carlsson.
2109 Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
2111 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2112 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2113 (WTR::TestRunner::setBlockAllPlugins):
2114 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2115 * WebKitTestRunner/TestInvocation.cpp:
2116 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2117 Add testRunner.setBlockAllPlugins function (and corresponding message to
2118 forward it through to TestController).
2120 * WebKitTestRunner/TestController.cpp:
2121 Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
2123 (WTR::TestController::createWebViewWithOptions):
2124 Register our pluginLoadPolicy callback.
2126 (WTR::TestController::resetStateToConsistentValues):
2127 Reset m_shouldBlockAllPlugins to false.
2129 (WTR::TestController::pluginLoadPolicy):
2130 Return the existing plugin load policy, unless setBlockAllPlugins(true)
2131 was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
2133 * WebKitTestRunner/TestController.h:
2134 (WTR::TestController::setBlockAllPlugins):
2136 2013-07-21 Andreas Kling <akling@apple.com>
2138 KURL creates duplicate strings when completing data: URIs.
2139 <http://webkit.org/b/118952>
2140 <rdar://problem/14504480>
2142 Reviewed by Anders Carlsson.
2144 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2145 (TestWebKitAPI::TEST_F):
2147 2013-07-19 Chris Fleizach <cfleizach@apple.com>
2149 AX: VoiceOver not detecting misspelled words don't work in all cases
2150 https://bugs.webkit.org/show_bug.cgi?id=118924
2152 Reviewed by Tim Horton.
2154 Make the misspelled detection dependent on both types of attributes being present.
2156 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2157 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2158 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2159 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2161 2013-07-19 Alex Christensen <achristensen@apple.com>
2163 Improved code coverage generation.
2164 https://bugs.webkit.org/show_bug.cgi?id=118926
2166 Reviewed by Tim Horton.
2168 * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
2169 * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
2170 (generateReport): Moved report generation to a subroutine.
2172 2013-07-19 Stephanie Lewis <slewis@apple.com>
2174 <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
2178 Rebaseline pagination test after http://trac.webkit.org/changeset/152911
2180 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2181 (TestWebKitAPI::didLayout):
2183 2013-07-19 Daniel Bates <dabates@apple.com>
2185 Make Perl tools work when using git bisect with Git branch build setup
2186 https://bugs.webkit.org/show_bug.cgi?id=118512
2188 Reviewed by Martin Robinson.
2190 The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
2191 during a git bisect session with a Git branch build setup (i.e. git config
2192 core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
2193 specific build of WebKit because they cannot determine the branch Git is on (since
2194 git bisect puts Git into a detached HEAD state). We should teach our tooling to
2195 parse the file .git/BISECT_START (created by git bisect start) for the name of the
2196 branch Git was on when we began a git bisect session. Then the tools can determine
2197 the path to the built WebKit.
2199 * Scripts/VCSUtils.pm:
2200 (gitDirectory): Added.
2201 (gitBisectStartBranch): Added.
2202 (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
2203 HEAD (e.g. running git bisect).
2204 (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2205 the .git directory in the Git checkout.
2207 2013-07-19 Alex Christensen <achristensen@apple.com>
2209 Added x64 configuration to Visual Studio build.
2210 https://bugs.webkit.org/show_bug.cgi?id=118888
2212 Reviewed by Brent Fulgham.
2214 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2215 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2216 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2217 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2218 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2219 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2220 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2221 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2222 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2223 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2224 * win/record-memory/record-memory.vcxproj:
2226 2013-07-19 Martin Robinson <mrobinson@igalia.com>
2228 Add a couple people to the MathML watchlist
2229 https://bugs.webkit.org/show_bug.cgi?id=118909
2231 Reviewed by Andreas Kling.
2233 Add a couple people to the MathML watchlist and add Kalyan's other
2234 email address to fix style checker warnings about the watchlist
2237 * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
2238 list of contributors and add Kalyan's second email address.
2239 * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
2242 2013-07-19 Simon Pena <simon.pena@samsung.com>
2244 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
2245 https://bugs.webkit.org/show_bug.cgi?id=118895
2247 Reviewed by Philippe Normand.
2249 In r152782 an uri is used to create an string representation without checking first if it
2250 is valid. That fails later when the string is used to check for existing redirections. This
2251 patch ensures that the uri is valid before using it.
2253 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2254 (willSendRequestCallback): Ensure an uri is valid before using it.
2256 2013-07-18 Timothy Hatcher <timothy@apple.com>
2258 Add extract-localizable-js-strings and use it for WebInspectorUI.
2260 https://bugs.webkit.org/show_bug.cgi?id=118851
2262 Reviewed by Joseph Pecoraro.
2264 * Scripts/extract-localizable-js-strings: Added.
2265 * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
2266 * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
2267 the WebInspectorUI project.
2269 2013-07-18 Brent Fulgham <bfulgham@apple.com>
2271 [Windows] Build correction #2 after r152861.
2273 * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2275 2013-07-18 Brent Fulgham <bfulgham@apple.com>
2277 [Windows] Build correction after r152861.
2279 * WinLauncher/WinLauncher.cpp: Don't reference private header.
2281 2013-07-16 Brent Fulgham <bfulgham@apple.com>
2283 [Win] Support in-band text tracks.
2284 https://bugs.webkit.org/show_bug.cgi?id=103770
2286 Reviewed by Eric Carlson.
2288 Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2289 libdispatch and CFRunLoop elements are services during the run loop.
2291 * WinLauncher/WinLauncher.cpp:
2292 (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2293 a CoreFoundation (or CFLite) support library.
2294 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2295 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2296 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2297 and WinLauncherCFLite.props.
2299 2013-07-18 Roger Fong <roger_fong@apple.com>
2301 Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2303 * Scripts/webkitpy/common/config/ews.json:
2305 2013-07-18 Daniel Bates <dabates@apple.com>
2307 REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2308 https://bugs.webkit.org/show_bug.cgi?id=118854
2309 <rdar://problem/14081339>
2311 Reviewed by David Kilzer.
2313 Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2314 Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2315 run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2316 listen on these ports so that we can run tests that use port 8443 and 8080.
2318 * Scripts/old-run-webkit-tests:
2319 (configureAndOpenHTTPDIfNeeded):
2321 2013-07-17 Tim Horton <timothy_horton@apple.com>
2323 Update blocked/missing plug-in UI
2324 https://bugs.webkit.org/show_bug.cgi?id=118347
2325 <rdar://problem/14209318>
2327 Reviewed by Sam Weinig.
2329 * MiniBrowser/mac/WK2BrowserWindowController.m:
2330 (-[WK2BrowserWindowController awakeFromNib]):
2331 * WebKitTestRunner/TestController.cpp:
2332 (WTR::TestController::createWebViewWithOptions):
2333 Match new WKPageLoaderClient entry.
2335 2013-07-17 Commit Queue <commit-queue@webkit.org>
2337 Unreviewed, rolling out r152701, r152703, r152739, r152754,
2339 http://trac.webkit.org/changeset/152701
2340 http://trac.webkit.org/changeset/152703
2341 http://trac.webkit.org/changeset/152739
2342 http://trac.webkit.org/changeset/152754
2343 http://trac.webkit.org/changeset/152756
2344 https://bugs.webkit.org/show_bug.cgi?id=118821
2346 this was a buggy fix and we're going to try something
2347 different (Requested by thorton on #webkit).
2349 * MiniBrowser/mac/WK2BrowserWindowController.m:
2350 (-[WK2BrowserWindowController awakeFromNib]):
2351 * WebKitTestRunner/TestController.cpp:
2352 (WTR::TestController::createWebViewWithOptions):
2354 2013-07-17 Commit Queue <commit-queue@webkit.org>
2356 Unreviewed, rolling out r151535.
2357 http://trac.webkit.org/changeset/151535
2358 https://bugs.webkit.org/show_bug.cgi?id=118804
2360 Re-disable WinEWS tests (Requested by rfong on #webkit).
2362 * Scripts/webkitpy/common/config/ews.json:
2364 2013-07-17 Simon Pena <simon.pena@samsung.com>
2366 [GTK] Make DRT obbey testRunner's addURLToRedirect
2367 https://bugs.webkit.org/show_bug.cgi?id=118239
2369 Reviewed by Gustavo Noronha Silva.
2371 Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2372 to the proper URI when indicated.
2374 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2375 (willSendRequestCallback):
2377 2013-07-17 Gabor Abraham <abrhm@inf.u-szeged.hu>
2379 Add a new find-resolved-bugs command to webkit-patch.
2380 https://bugs.webkit.org/show_bug.cgi?id=118060
2382 Reviewed by Csaba Osztrogonác.
2384 * Scripts/webkitpy/tool/commands/queries.py:
2385 (PrintBaselines._platform_for_path):
2387 (FindResolvedBugs.execute):
2389 2013-07-16 Balazs Kelemen <kbalazs@webkit.org>
2391 [CMake] Undefined references should be detected at build time
2392 https://bugs.webkit.org/show_bug.cgi?id=110236
2394 Reviewed by Christophe Dumez.
2396 Add library dependencies that were not defined explicitly before.
2398 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2399 * TestWebKitAPI/CMakeLists.txt:
2400 * WebKitTestRunner/CMakeLists.txt:
2402 2013-07-16 Kwang Yul Seo <skyul@company100.net>
2404 check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2405 https://bugs.webkit.org/show_bug.cgi?id=118755
2407 Reviewed by Ryosuke Niwa.
2409 Fix r152719 to check "using namespace foo;" only in headers.
2411 * Scripts/webkitpy/style/checkers/cpp.py:
2412 (check_using_namespace):
2414 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2415 (WebKitStyleTest.test_using_namespace):
2417 2013-07-16 Christophe Dumez <ch.dumez@sisa.samsung.com>
2419 Get rid of multiple inheritance support from the bindings generators
2420 https://bugs.webkit.org/show_bug.cgi?id=118353
2422 Reviewed by Kentaro Hara.
2424 Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2425 deprecated domInterface->parents.
2427 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2430 2013-07-16 Brian Holt <brian.holt@samsung.com>
2432 check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2433 https://bugs.webkit.org/show_bug.cgi?id=57241
2435 Reviewed by Ryosuke Niwa.
2437 Added check for "using namespace foo" and unit test.
2439 * Scripts/webkitpy/style/checkers/cpp.py:
2440 (check_using_namespace):
2443 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2444 (WebKitStyleTest.test_using_namespace):
2446 2013-07-16 Anton Obzhirov <a.obzhirov@samsung.com>
2448 [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2449 https://bugs.webkit.org/show_bug.cgi?id=110222
2451 Reviewed by Gustavo Noronha Silva.
2453 Added handling of zero mouse scroll deltas in EventSender.
2455 * DumpRenderTree/gtk/EventSender.cpp:
2456 (mouseScrollByCallback):
2458 2013-07-16 Brian Holt <brian.holt@samsung.com>
2460 webkitpy: replace urllib with urllib2 for downloading additional modules
2461 https://bugs.webkit.org/show_bug.cgi?id=118671
2463 Reviewed by Ryosuke Niwa.
2465 Urllib2 is available whereever urllib is, but has better proxy support.
2467 * Scripts/webkitpy/common/system/autoinstall.py:
2468 (AutoInstaller._download_to_stream):
2470 2013-07-16 Krzysztof Czech <k.czech@samsung.com>
2472 [ATK] Adds support for aria-haspopup property.
2473 https://bugs.webkit.org/show_bug.cgi?id=117834
2475 Reviewed by Christophe Dumez.
2477 Adds implementation for testing aria-haspopup property.
2479 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2480 (getAttributeSetValueForId):
2481 (AccessibilityUIElement::stringAttributeValue):
2482 (AccessibilityUIElement::hasPopup):
2483 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2484 (WTR::getAttributeSetValueForId):
2485 (WTR::AccessibilityUIElement::stringAttributeValue):
2486 (WTR::AccessibilityUIElement::hasPopup):
2488 2013-07-16 Michael Brüning <michael.bruning@digia.com>
2490 [Qt] Replace Nokia references.
2491 https://bugs.webkit.org/show_bug.cgi?id=118728
2493 Reviewed by Simon Hausmann.
2495 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2496 (MiniBrowserApplication::MiniBrowserApplication):
2497 * QtTestBrowser/qttestbrowser.cpp:
2498 (LauncherApplication::LauncherApplication):
2500 2013-07-15 Tim Horton <timothy_horton@apple.com>
2502 Update blocked/missing plug-in UI
2503 https://bugs.webkit.org/show_bug.cgi?id=118347
2504 <rdar://problem/14209318>
2506 Reviewed by Sam Weinig.
2508 * MiniBrowser/mac/WK2BrowserWindowController.m:
2509 (-[WK2BrowserWindowController awakeFromNib]):
2510 * WebKitTestRunner/TestController.cpp:
2511 (WTR::TestController::createWebViewWithOptions):
2512 Match new WKPageLoaderClient entry.
2514 2013-07-15 Chris Fleizach <cfleizach@apple.com>
2516 Update James Craig's email address.
2518 * Scripts/webkitpy/common/config/contributors.json:
2520 2013-07-15 Dong-Gwan Kim <donggwan.kim@samsung.com>
2522 [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2523 https://bugs.webkit.org/show_bug.cgi?id=118583
2525 Reviewed by Christophe Dumez.
2527 There're many fails on efl webkit2 API test if opengl is not available.
2528 So, add fallback to non-opengl evas engine.
2530 * TestWebKitAPI/efl/PlatformWebView.cpp:
2531 (TestWebKitAPI::initEcoreEvas):
2533 2013-07-15 Brian Holt <brian.holt@samsung.com>
2535 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2536 https://bugs.webkit.org/show_bug.cgi?id=118592
2538 Reviewed by Martin Robinson.
2540 Added a suppression for pylint false positives and a unit test.
2542 * Scripts/webkitpy/style/checkers/python.py:
2544 * Scripts/webkitpy/style/checkers/python_unittest.py:
2545 (PythonCheckerTest.test_check):
2546 (PythonCheckerTest):
2547 (PythonCheckerTest.test_pylint_false_positives):
2548 (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2549 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2552 2013-07-15 Xabier Rodriguez Calvar <calvaris@igalia.com>
2554 [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2555 https://bugs.webkit.org/show_bug.cgi?id=115166
2557 Reviewed by Philippe Normand.
2559 * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2561 2013-07-12 Kwang Yul Seo <skyul@company100.net>
2563 Unreviewed. Add an email address and update my domain of experts.
2565 * Scripts/webkitpy/common/config/contributors.json:
2567 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2569 [jhbuild] Avoid restarting from scratch failed initial checkouts
2570 https://bugs.webkit.org/show_bug.cgi?id=118603
2572 Reviewed by Martin Robinson.
2574 If the initial checkout is interrupted midway (eg. because the internet
2575 connection went down) config files do not get generated and that causes
2576 the next checkout to start from scratch (the missing files cause the
2577 script to delete the build root and the downloaded sources).
2579 By generating the files before invoking jhbuild, subsequent runs are able
2580 to start where the previous run left.
2582 * Scripts/update-webkit-libs-jhbuild:
2583 (saveJhbuildMd5): invoke it before runJhbuild().
2585 2013-07-12 Brent Fulgham <bfulgham@apple.com>
2587 [Windows] Remove single-worker restriction on tests.
2589 * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2591 2013-07-12 Commit Queue <commit-queue@webkit.org>
2593 Unreviewed, rolling out r152599.
2594 http://trac.webkit.org/changeset/152599
2595 https://bugs.webkit.org/show_bug.cgi?id=118612
2597 This patch includes a failing unit test (Requested by
2598 mrobinson on #webkit).
2600 * Scripts/webkitpy/style/checkers/python.py:
2602 * Scripts/webkitpy/style/checkers/python_unittest.py:
2603 (PythonCheckerTest.test_check):
2604 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2606 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2608 [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2609 https://bugs.webkit.org/show_bug.cgi?id=91223
2611 Reviewed by Martin Robinson.
2613 When run on a clean checkout, `build-webkit` complains that no
2614 GNUmakefile exists when trying to detect the previously configured
2615 architecture, but in this case there's no previous configuration so
2616 the warning is pointless.
2618 * Scripts/webkitdirs.pm:
2619 (determineArchitecture): Redirect grep stderr to /dev/null.
2621 2013-07-12 Brian Holt <brian.holt@samsung.com>
2623 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2624 https://bugs.webkit.org/show_bug.cgi?id=118592
2626 Reviewed by Martin Robinson.
2628 Added a suppression for pylint false positives and a unit test.
2630 * Scripts/webkitpy/style/checkers/python.py:
2632 * Scripts/webkitpy/style/checkers/python_unittest.py:
2633 (PythonCheckerTest.test_check):
2634 (PythonCheckerTest):
2635 (PythonCheckerTest.test_pylint_false_positives):
2636 (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2637 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2640 2013-07-11 Arnaud Renevier <a.renevier@samsung.com>
2642 Unreviewed. Add myself as a committer.
2644 * Scripts/webkitpy/common/config/contributors.json:
2646 2013-07-10 Sergio Correia <sergio.correia@openbossa.org>
2648 Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2649 https://bugs.webkit.org/show_bug.cgi?id=118538
2651 Reviewed by Christophe Dumez.
2653 When attempting some odd url such as ``foo'', MiniBrowser will now show an
2654 error message such as "Cannot resolve hostname (foo)".
2656 Previously, it had the following behavior if MiniBrowser was started with
2657 such urls, e.g ``./MiniBrowser foo'':
2660 It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2663 No asserts, naturally, but the view would remain blank, even if we tried to
2664 change to a valid url.
2666 * MiniBrowser/efl/main.c:
2669 2013-07-10 Simon Pena <simon.pena@samsung.com>
2671 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2672 https://bugs.webkit.org/show_bug.cgi?id=118509
2674 Reviewed by Martin Robinson.
2676 In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2677 when trying to remove an event already removed, if another event is
2678 processed in the middle. By using a Deque's takeFirst, we ensure the
2679 element is removed before we dispatch it.
2681 fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2682 crashes after this fix is added.
2684 * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2685 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2686 (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2689 2013-07-09 Ryuan Choi <ryuan.choi@samsung.com>
2691 [EFL] Add ewk_view_device_pixel_ratio_set
2692 https://bugs.webkit.org/show_bug.cgi?id=118521
2694 Reviewed by Gyuyoung Kim.
2696 * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2698 (parseUserArguments):
2700 2013-07-09 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
2702 Unreviewed change of my email addresses.
2703 https://bugs.webkit.org/show_bug.cgi?id=100122
2705 * Scripts/webkitpy/common/config/contributors.json:
2707 2013-07-09 Anders Carlsson <andersca@apple.com>
2709 DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2710 https://bugs.webkit.org/show_bug.cgi?id=118514
2711 <rdar://problem/13686836>
2713 Reviewed by Sam Weinig.
2715 Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2717 * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2718 * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2719 (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2720 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2721 Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2723 * DumpRenderTree/mac/DumpRenderTree.mm:
2724 (allocateGlobalControllers):
2725 Allocate a DefaultPolicyDelegate object.
2727 (resetWebViewToConsistentStateBeforeTesting):
2728 Set the policy delegate to the default policy delegate.
2730 * DumpRenderTree/mac/DumpRenderTreeMac.h:
2731 Declare the defaultPolicyDelegate object.
2733 * DumpRenderTree/mac/TestRunnerMac.mm:
2734 (TestRunner::setCustomPolicyDelegate):
2735 Set the policy delegate to the default delegate if setDelegate is false.
2737 2013-07-08 Zan Dobersek <zdobersek@igalia.com>
2739 KURL unit test fixture class should have a meaningful name
2740 https://bugs.webkit.org/show_bug.cgi?id=118467
2742 Reviewed by Sam Weinig.
2744 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2745 (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2746 instead of the generic and inappropriate 'WebCore' name.
2748 2013-07-08 Antti Koivisto <antti@apple.com>
2750 Add Deque::removeLast
2751 https://bugs.webkit.org/show_bug.cgi?id=118466
2753 Reviewed by Andreas Kling.
2755 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2756 * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2757 (TestWebKitAPI::TEST):
2759 2013-07-08 Brian Holt <brian.holt@samsung.com>
2761 [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2762 https://bugs.webkit.org/show_bug.cgi?id=118412
2764 Reviewed by Martin Robinson.
2766 An adoptRef is required to balance ref and deref calls.
2768 * DumpRenderTree/gtk/EventSender.cpp:
2769 (beginDragWithFilesCallback):
2771 2013-07-06 Sergio Correia <sergio.correia@openbossa.org>
2773 Update list of EFL WK2 API tests
2774 https://bugs.webkit.org/show_bug.cgi?id=118443
2776 Reviewed by Christophe Dumez.
2778 The following tests were included:
2781 - CloseThenTerminate
2782 - DidAssociateFormControls
2783 - PageVisibilityState
2784 - ResponsivenessTimerDoesntFireEarly
2789 - ResizeReversePaginatedWebView
2790 - ScrollPinningBehaviors
2792 This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2795 * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2796 * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2798 2013-07-05 Tim Horton <timothy_horton@apple.com>
2800 Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2801 https://bugs.webkit.org/show_bug.cgi?id=118439
2802 <rdar://problem/14366120>
2804 Reviewed by Anders Carlsson.
2806 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2807 (TestWebKitAPI::didLayout):
2808 (TestWebKitAPI::TEST):
2809 - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2810 - Assert that we got the right number of pages for sanity.
2811 - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2812 so much memory that SharedMemory asserts and makes the test time out.
2813 - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2814 because paint doesn't fire if the window is offscreen.
2816 2013-07-05 Tim Horton <timothy_horton@apple.com>
2818 [wk2] Add API to lock the scroll position at the top or bottom of the page
2819 https://bugs.webkit.org/show_bug.cgi?id=118429
2820 <rdar://problem/14120323>
2822 Reviewed by Anders Carlsson.
2824 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2826 (TestWebKitAPI::didFinishDocumentLoadForFrame):
2827 (TestWebKitAPI::TEST):
2828 Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2829 all work correctly in the face of resizing the view and scrolling from JS.
2831 2013-07-05 Michael Pruett <michael@68k.org>
2833 Unreviewed. Add myself as a committer.
2835 * Scripts/webkitpy/common/config/contributors.json:
2837 2013-07-05 Xabier Rodriguez Calvar <calvaris@igalia.com>
2839 [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2840 https://bugs.webkit.org/show_bug.cgi?id=111434
2842 Reviewed by Carlos Garcia Campos.
2844 * Scripts/run-gtk-tests:
2845 (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2847 2013-07-04 Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
2849 [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2850 https://bugs.webkit.org/show_bug.cgi?id=118370
2852 Reviewed by Christophe Dumez.
2854 Add fallback to software X11 engine if opengl_x11 engine creation fails.
2856 * DumpRenderTree/efl/DumpRenderTree.cpp:
2859 2013-07-04 Brian Holt <brian.holt@samsung.com>
2861 [ATK] Leak: AtkAttributeSet* should be freed
2862 https://bugs.webkit.org/show_bug.cgi?id=118307
2864 Reviewed by Christophe Dumez.
2866 Fixed memory leaks for AtkAttributeSet by calling
2867 atk_attribute_set_free().
2869 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2870 (AccessibilityController::childElementById):
2871 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2872 (getAtkAttributeSetAsString):
2873 (AccessibilityUIElement::allAttributes):
2874 (AccessibilityUIElement::stringAttributeValue):
2875 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2876 (WTR::childElementById):
2877 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2878 (WTR::getAtkAttributeSetAsString):
2879 (WTR::AccessibilityUIElement::allAttributes):
2880 (WTR::AccessibilityUIElement::stringAttributeValue):
2882 2013-07-03 David Farler <dfarler@apple.com>
2884 Add Makefile to WebKitLauncher
2885 https://bugs.webkit.org/show_bug.cgi?id=118365
2887 Reviewed by Mark Rowe.
2889 * WebKitLauncher/Makefile: Added.
2891 2013-07-03 Brian Holt <brian.holt@samsung.com>
2893 [ATK] Leak: more leaks in AccessibilityUIElement
2894 https://bugs.webkit.org/show_bug.cgi?id=118362
2896 Reviewed by Christophe Dumez.
2898 Free the memory created by g_strdup_printf.
2900 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2901 (AccessibilityUIElement::language):
2902 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2903 (WTR::AccessibilityUIElement::language):
2905 2013-07-03 Jer Noble <jer.noble@apple.com>
2907 Xcode often gets in a state where the debugger is completely unresponsive
2908 https://bugs.webkit.org/show_bug.cgi?id=118157
2910 The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2911 Rather than pull the character data out of the debugger one byte at a time
2912 through the GetPointeeData() API, retrieve the memory contents of the string through
2913 the ReadMemory() API, and convert the retrieved memory into a python string.
2915 Reviewed by Anders Carlsson.
2917 * lldb/lldb_webkit.py:
2918 (__lldb_init_module.lldb_webkit):
2919 (guess_string_length):
2920 (ustring_to_string):
2921 (lstring_to_string):
2923 2013-07-03 Morten Stenshorne <mstensho@opera.com>
2925 [GTK] Let F5 refresh the page in MiniBrowser
2926 https://bugs.webkit.org/show_bug.cgi?id=117638
2928 Reviewed by Carlos Garcia Campos.
2930 Also use the correct icon for the refresh button that was already there.
2932 * MiniBrowser/gtk/BrowserWindow.c:
2933 (browser_window_init):
2935 2013-07-02 Kondapally Kalyan <kalyan.kondapally@intel.com>
2937 Unreviewed. Add my email to a few watchlists.
2939 * Scripts/webkitpy/common/config/watchlist:
2941 2013-07-02 David Farler <dfarler@apple.com>
2943 Unreviewed. Adding myself to contributors.json.
2945 * Scripts/webkitpy/common/config/contributors.json:
2947 2013-07-02 Brian Holt <brian.holt@samsung.com>
2949 [ATK] Leak: leaks in AccessibilityUIElement
2950 https://bugs.webkit.org/show_bug.cgi?id=118297
2954 Reviewed by Christophe Dumez.
2956 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2957 (AccessibilityUIElement::stringValue):
2959 2013-07-02 Byungwoo Lee <bw80.lee@samsung.com>
2961 Fix WebKitTestRunner crashes.
2962 https://bugs.webkit.org/show_bug.cgi?id=117630
2964 Reviewed by Darin Adler.
2966 Create static function to dump for WebProcess unresponsiveness status,
2967 and use it before calling TestController::runTest().
2969 Accessing TestController::m_currentInvocation before calling
2970 TestController::runTest() can make crash because the invocation
2971 instance will be assigned at the function.
2973 * WebKitTestRunner/TestController.cpp:
2974 (WTR::TestController::run):
2975 * WebKitTestRunner/TestInvocation.cpp:
2976 (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2977 * WebKitTestRunner/TestInvocation.h:
2979 2013-07-02 Allan Sandfeld Jensen <allan.jensen@digia.com>
2981 [Qt][WK1] Support WebGL with EGL on Linux
2982 https://bugs.webkit.org/show_bug.cgi?id=118251
2984 Reviewed by Kenneth Rohde Christiansen.
2986 * qmake/mkspecs/features/features.prf:
2988 2013-07-01 Nick Diego Yamane <nick.yamane@openbossa.org>
2990 [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2991 https://bugs.webkit.org/show_bug.cgi?id=118267
2993 Reviewed by Gyuyoung Kim.
2995 After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2996 WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2997 Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
3002 2013-07-01 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
3004 [GTK] Remove unsupported AC backends
3005 https://bugs.webkit.org/show_bug.cgi?id=117362
3007 Reviewed by Martin Robinson.
3009 * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
3010 and cogl, so removed.
3012 2013-07-01 Timothy Hatcher <timothy@apple.com>
3014 Link to WebInspectorUI.framework at build time instead of soft linking.
3016 https://bugs.webkit.org/show_bug.cgi?id=118261
3018 Reviewed by Joseph Pecoraro.
3020 * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
3022 2013-07-01 Tim Horton <timothy_horton@apple.com>
3024 Maximum scroll position can be negative in some cases
3025 https://bugs.webkit.org/show_bug.cgi?id=118175
3026 <rdar://problem/14301217>
3028 Reviewed by Anders Carlsson.
3030 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3031 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
3032 (TestWebKitAPI::didRunJavaScript):
3033 (TestWebKitAPI::didLayout):
3034 (TestWebKitAPI::TEST):
3035 * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
3036 Add a test that loads a vertical-lr document, paginates it horizontally
3037 from right to left, resizes the view to fit the entire document, and
3038 verifies that the scroll position is negative, as it must be for the
3039 document to be enclosed by the view.
3041 2013-07-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3043 [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
3044 https://bugs.webkit.org/show_bug.cgi?id=117249
3046 Reviewed by Brent Fulgham.
3048 Finish converting all use cases of WEBKITOUTPUTDIR to
3049 WEBKIT_OUTPUTDIR, which seems to be preferred these days.
3051 * DumpRenderTree/efl/FontManagement.cpp:
3052 (getCustomBuildDir):
3053 (getPlatformFontsPath):
3054 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3056 * Scripts/webkitdirs.pm:
3057 (determineBaseProductDir):
3058 (usesPerConfigurationBuildDirectory):
3059 * Scripts/webkitpy/port/base.py:
3060 (Port.to.setup_environ_for_server):
3061 * Scripts/webkitpy/port/driver.py:
3062 (Driver._setup_environ_for_driver):
3063 * Scripts/webkitpy/port/gtk.py:
3064 (GtkPort.setup_environ_for_server):
3065 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3066 (WTR::getOutputDir):
3067 * jhbuild/jhbuildutils.py:
3068 (get_dependencies_path):
3070 2013-07-01 Rafael Brandao <rafael.lobo@webkit.org>
3072 Unreviewed change of my email address.
3074 * Scripts/webkitpy/common/config/contributors.json:
3076 2013-06-28 Andreas Kling <akling@apple.com>
3078 Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
3080 * DumpRenderTree/win/DumpRenderTree.cpp:
3081 (addFontFallbackIfPresent):
3082 (removeFontFallbackIfPresent):
3084 2013-06-28 Anders Carlsson <andersca@apple.com>
3086 Remove String::deprecatedCharactersWithNullTermination() and related code
3087 https://bugs.webkit.org/show_bug.cgi?id=118211
3089 Reviewed by Benjamin Poulain.
3091 Remove all hasTerminatingNullCharacter() checks.
3093 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3094 (TestWebKitAPI::TEST):
3095 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3096 (TestWebKitAPI::TEST):
3097 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3098 (TestWebKitAPI::TEST):
3100 2013-06-28 Alexey Proskuryakov <ap@apple.com>
3102 [Mac] Crash when loading is stopped from -didReceiveResponse
3103 https://bugs.webkit.org/show_bug.cgi?id=118209
3104 <rdar://problem/14259249>
3106 Reviewed by Brady Eidson.
3108 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3109 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
3110 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
3111 (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
3112 (TestWebKitAPI::TEST):
3114 2013-06-28 Andy Estes <aestes@apple.com>
3116 [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
3117 https://bugs.webkit.org/show_bug.cgi?id=118208
3119 Reviewed by Mark Rowe.
3121 Newer versions of clang use a default template depth of 128, but this
3122 is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
3125 Clang lowered the default to keep recursive template instantiation
3126 from overflowing the stack (see <rdar://problem/13935016>), but
3127 TestWebKitAPI's C++ files don't trigger a stack overflow even with the
3128 higher limit. If for some reason this starts happening then we can
3129 lower the limit back down.
3131 * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
3133 2013-06-28 Nick Diego Yamane <nick.yamane@openbossa.org>
3135 [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
3136 https://bugs.webkit.org/show_bug.cgi?id=118195
3138 Reviewed by Daniel Bates.
3140 Currently, ports that use jhbuild fail to determine jhbuild directory
3141 when "webKitBranchBuild" git configuration property is enabled. To reproduce
3142 that issue in Efl port, enable that flag in .git/config, switch to a git branch
3143 other than "master" and try to build webkit. The build will fail to
3144 locate dependencies due to lack of pkg-config paths which should be set
3147 For more details about "webKitBranchBuild" option, see:
3148 https://trac.webkit.org/wiki/UsingGitWithWebKit
3150 * Scripts/webkitdirs.pm:
3153 2013-06-28 Jessie Berlin <jberlin@apple.com>
3155 WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
3156 https://bugs.webkit.org/show_bug.cgi?id=118201
3158 Reviewed by Dean Jackson.
3160 * WebKitTestRunner/mac/main.mm:
3162 Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
3163 setAutomaticDashSubstitutionEnabled are not exposed on WKView.
3165 2013-06-28 David Farler <dfarler@apple.com>
3167 Upstream WebKit Nightly’s WebKitLauncher
3168 https://bugs.webkit.org/show_bug.cgi?id=117418
3170 Reviewed by Mark Rowe.
3172 Literal patch from Nightly's OpenSource repo.
3174 * WebKitLauncher/Configurations/Base.xcconfig:
3175 * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
3176 * WebKitLauncher/Info.plist:
3177 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3178 * WebKitLauncher/WebKitLauncherURLProtocol.m:
3179 (+[WebKitLauncherURLProtocol load]):
3180 (+[WebKitLauncherURLProtocol canInitWithRequest:]):
3181 (-[WebKitLauncherURLProtocol startLoading]):
3182 (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
3183 (-[WebKitLauncherURLProtocol resourceNotFound]):
3184 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3185 (initializeSparkle):
3186 * WebKitLauncher/main.m:
3187 (determineExecutablePath):
3188 (currentMacOSXVersion):
3190 * WebKitLauncher/start.html:
3192 2013-06-28 Balazs Kelemen <b.kelemen@samsung.com>
3194 [EFL] back/forward keyboard shortcuts are non-intuitive
3195 https://bugs.webkit.org/show_bug.cgi?id=118193
3197 Reviewed by Christophe Dumez.
3199 Changed shortcuts for go-back/go-forward to alt+left and alt+right.
3201 * EWebLauncher/main.c:
3203 * MiniBrowser/efl/main.c:
3206 2013-06-28 Roger Fong <roger_fong@apple.com>
3208 Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3209 https://bugs.webkit.org/show_bug.cgi?id=118194.
3211 Reviewed by Brent Fulgham.
3213 * DumpRenderTree/win/DumpRenderTree.cpp:
3214 (dllLauncherEntryPoint):
3215 * WinLauncher/WinLauncher.cpp:
3216 (dllLauncherEntryPoint):
3218 2013-06-28 Roger Fong <roger_fong@apple.com>
3220 Unreviewed build fix for AppleWin port. Fix some file paths.
3222 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3223 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3225 2013-06-27 Roger Fong <roger_fong@apple.com>
3227 Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
3228 https://bugs.webkit.org/show_bug.cgi?id=118160.
3230 Reviewed by Brent Fulgham.
3232 * WinLauncher/AccessibilityDelegate.cpp: Added.
3233 (AccessibilityDelegate::QueryInterface):
3234 (AccessibilityDelegate::AddRef):
3235 (AccessibilityDelegate::Release):
3236 (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
3237 (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
3238 * WinLauncher/AccessibilityDelegate.h: Added.
3239 (AccessibilityDelegate::AccessibilityDelegate):
3240 * WinLauncher/WinLauncher.cpp:
3241 (dllLauncherEntryPoint):
3242 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3243 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3245 2013-06-28 Christophe Dumez <ch.dumez@sisa.samsung.com>
3247 Clean up temporary files created by the bindings test script
3248 https://bugs.webkit.org/show_bug.cgi?id=118189
3250 Reviewed by Kentaro Hara.
3252 Remove temporary files created by preprocess-idls.pl script after
3253 the bindings tests are executed.
3255 Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
3257 * Scripts/webkitpy/bindings/main.py:
3258 (BindingsTests.main):
3260 2013-06-26 Dean Jackson <dino@apple.com>
3262 [Mac] Add Mavericks system font to Test systems
3263 https://bugs.webkit.org/show_bug.cgi?id=118109
3265 Reviewed by Simon Fraser.
3267 OS X Mavericks uses a different font for system controls. Tell DRT and
3268 WKTR about them otherwise they use a fallback font. Unfortunately the
3269 fonts are hidden (not found in the list of available fonts) so I
3270 had to add them manually.
3272 Even though there is only one at the moment, I implemented this
3273 as a set so it will be easier to add new fonts if necessary.
3275 * DumpRenderTree/mac/DumpRenderTree.mm:
3276 (allowedFontFamilySet): Fixed typo.
3277 (systemHiddenFontFamilySet): New method that returns the system control font.
3278 (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3279 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3280 (WTR::allowedFontFamilySet): Fixed typo.
3281 (WTR::systemHiddenFontFamilySet): As above.
3282 (WTR::wtr_NSFontManager_availableFonts):
3284 2013-06-27 Anders Carlsson <andersca@apple.com>
3286 Get rid of the last uses of deprecatedCharactersWithNullTermination()
3287 https://bugs.webkit.org/show_bug.cgi?id=118159
3289 Reviewed by Andreas Kling.
3291 Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3293 * DumpRenderTree/win/DumpRenderTree.cpp:
3296 2013-06-27 Bem Jones-Bey <bjonesbe@adobe.com>
3298 Sync up w3c import script with changes in Blink
3299 https://bugs.webkit.org/show_bug.cgi?id=118149
3301 Reviewed by Dirk Pranke.
3303 This is a port of the following blink changes:
3305 https://codereview.chromium.org/15366004
3306 https://chromiumcodereview.appspot.com/15592005
3307 https://codereview.chromium.org/16021006
3308 https://codereview.chromium.org/15590004
3309 https://codereview.chromium.org/15901008
3310 https://codereview.chromium.org/16171009
3311 https://codereview.chromium.org/16465007
3312 https://codereview.chromium.org/15981013
3314 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3316 (test_commit_message_for_this_commit):
3317 * Scripts/webkitpy/port/base.py:
3319 * Scripts/webkitpy/port/test.py:
3320 * Scripts/webkitpy/w3c/test_converter.py:
3321 (W3CTestConverter.__init__):
3322 (W3CTestConverter.read_webkit_prefixed_css_property_list):
3323 (W3CTestConverter.convert_for_webkit):
3324 (W3CTestConverter.convert_css):
3325 (W3CTestConverter.convert_html):
3326 (W3CTestConverter.convert_testharness_paths):
3327 (W3CTestConverter.convert_prefixed_properties):
3328 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3329 * Scripts/webkitpy/w3c/test_converter_unittest.py:
3330 * Scripts/webkitpy/w3c/test_importer.py:
3332 (configure_logging):
3333 (configure_logging.LogHandler):
3334 (configure_logging.LogHandler.format):
3336 (TestImporter.__init__):
3337 (TestImporter.find_importable_tests):
3338 (TestImporter.import_tests):
3339 (TestImporter.setup_destination_directory):
3340 (TestImporter.remove_deleted_files):
3341 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3342 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3343 (TestImporterTest.test_import_dir_with_no_tests):
3345 * Scripts/webkitpy/w3c/test_parser.py:
3346 (TestParser.load_file):
3347 (TestParser.analyze_test):
3348 (TestParser.support_files):
3349 * Scripts/webkitpy/w3c/test_parser_unittest.py:
3351 2013-06-27 Csaba Osztrogonác <ossy@webkit.org>
3353 [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3354 https://bugs.webkit.org/show_bug.cgi?id=118128
3356 Reviewed by Ryosuke Niwa.
3358 It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3359 https://bugs.webkit.org/show_bug.cgi?id=117831
3361 * Scripts/webkitpy/tool/commands/download.py:
3362 (AbstractPatchSequencingCommand):
3363 (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3364 (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3365 (AbstractPatchSequencingCommand._prepare_state): Added.
3367 2013-06-27 Brendan Long <b.long@cablelabs.com>
3369 [Qt] Build overrides -j when given --makeargs="-sj40"
3370 https://bugs.webkit.org/show_bug.cgi?id=116897
3372 Reviewed by Csaba Osztrogonác.
3374 * Scripts/webkitdirs.pm:
3375 (buildQMakeProjects):
3376 Change regex checking for -j* to also check for -*j*
3378 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3380 Remove [NoInterfaceObject] from WorkerGlobalScope
3381 https://bugs.webkit.org/show_bug.cgi?id=118071
3383 Reviewed by Kentaro Hara.
3385 Update bindings test script to pass 2 additional parameters
3386 now needed by the preprocess-idls.pl script.
3388 * Scripts/webkitpy/bindings/main.py:
3389 (BindingsTests.generate_supplemental_dependency):
3390 (BindingsTests.main):
3392 2013-06-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
3394 Fixing some compiler warnings
3395 https://bugs.webkit.org/show_bug.cgi?id=117791
3397 Reviewed by Martin Robinson.
3399 * GNUmakefile.am: Silenced format warning.
3400 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3401 (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3402 Solved warning about uninitialized variable.
3404 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3406 Fix bindings tests after r152080
3407 https://bugs.webkit.org/show_bug.cgi?id=118118
3409 Reviewed by Gyuyoung Kim.
3411 r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3412 to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3415 * Scripts/webkitpy/bindings/main.py:
3416 (BindingsTests.generate_supplemental_dependency):
3417 (BindingsTests.main):
3419 2013-06-26 Carlos Garcia Campos <cargarcia@blackberry.com>
3421 [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3422 https://bugs.webkit.org/show_bug.cgi?id=117982
3424 Reviewed by Rob Buis.
3426 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3427 (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3428 m_policyDelegateIsPermissive.
3429 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3430 Reset m_policyDelegateIsPermissive.
3431 (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3432 m_policyDelegateIsPermissive.
3433 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3434 (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3435 Return whether custom policy is enabled.
3436 (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3437 Return whether custom policy is permissive.
3439 2013-06-26 Anders Carlsson <andersca@apple.com>
3441 Deprecate StringImpl::charactersWithNullTermination
3442 https://bugs.webkit.org/show_bug.cgi?id=118108
3444 Reviewed by Beth Dakin.
3446 Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3448 * DumpRenderTree/win/DumpRenderTree.cpp:
3450 (addFontFallbackIfPresent):
3451 (removeFontFallbackIfPresent):
3453 2013-06-26 Nico Weber <thakis@chromium.org>
3455 Remove detect-mismached-virtual-const.
3456 https://bugs.webkit.org/show_bug.cgi?id=117999
3458 Reviewed by Anders Carlsson.
3460 Clang warns on mismatched virtual const, so there's no need for this
3463 * Scripts/detect-mismatched-virtual-const: Removed.
3465 2013-06-26 Alex Christensen <achristensen@apple.com>
3467 Added a code coverage report.
3468 https://bugs.webkit.org/show_bug.cgi?id=117941
3470 Reviewed by Joseph Pecoraro.
3472 * CodeCoverage: Added.
3473 * CodeCoverage/results-template.html: Added.
3474 * Scripts/generate-coverage-data: Generate and open the new report.
3476 2013-06-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3478 gdb: Remove the webcore.py pretty printer.
3479 https://bugs.webkit.org/show_bug.cgi?id=117992
3481 Reviewed by Jochen Eisinger.
3483 webcore.py has been only a placeholder for backwards compatibility
3484 for almost 3 years. It should be safe enough to remove it now.
3486 * gdb/webcore.py: Removed.
3488 2013-05-26 Peter Gal <galpeter@inf.u-szeged.hu>
3490 Creating cURL watchlist and adding myself to it.
3492 Reviewed by Csaba Osztrogonác.
3494 * Scripts/webkitpy/common/config/watchlist:
3496 2013-06-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3498 Unreviewed, change my email address for watch list.
3500 * Scripts/webkitpy/common/config/watchlist:
3502 2013-06-25 Byungwoo Lee <bw80.lee@samsung.com>
3504 [EFL] Add a script to install dependencies.
3505 https://bugs.webkit.org/show_bug.cgi?id=117968
3507 Reviewed by Christophe Dumez.
3509 Add a script which installs basic dependencies for building WebKit EFL.
3511 The dependencies are from the current EFLWebKit wiki page.
3512 After this patch is landed, the wiki page will be updated to use
3515 * efl/install-dependencies: Added.
3517 2013-06-24 Dean Jackson <dino@apple.com>
3519 [Mac] Update font used for Chinese in test systems
3520 https://bugs.webkit.org/show_bug.cgi?id=117970
3522 Reviewed by Alexey Proskuryakov.
3524 Add "Songti TC" and "Songti SC" to the list of allowed fonts
3527 * DumpRenderTree/mac/DumpRenderTree.mm:
3528 (allowedFontFamilySet):
3529 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3530 (WTR::allowedFontFamilySet):
3532 2013-06-24 Tim Horton <timothy_horton@apple.com>
3534 Make MiniBrowser paginated mode work with WebKit1
3535 https://bugs.webkit.org/show_bug.cgi?id=117950
3537 Reviewed by Beth Dakin.
3539 * MiniBrowser/mac/WK1BrowserWindowController.m:
3540 (-[WK1BrowserWindowController isPaginated]):
3541 (-[WK1BrowserWindowController togglePaginationMode:]):
3542 Hook up isPaginated and togglePaginationMode just as for WebKit2.
3544 2013-06-24 David Kilzer <ddkilzer@apple.com>
3546 bisect-builds: improve heuristic for choosing the next build after a broken build
3547 <http://webkit.org/b/117918>
3549 Reviewed by Simon Fraser.
3551 * Scripts/bisect-builds: When a build is broken, use a heuristic
3552 that "bisects" the left side or the right side of the remaining
3553 revisions to pick a revision that's sufficiently different from
3554 the revision of the broken build. This heuristic assumes there
3555 is a sequential range of broken builds whenever one broken build
3558 2013-06-24 Chris Rogers <crogers@google.com>
3560 WaveTable name has changed to PeriodicWave
3561 https://bugs.webkit.org/show_bug.cgi?id=117748
3563 Reviewed by Jer Noble.
3565 * Scripts/do-webcore-rename:
3567 2013-06-22 Santosh Mahto <santosh.ma@samsung.com>
3569 [EFL] Add support for MHTML save/load feature to MiniBrowser
3570 https://bugs.webkit.org/show_bug.cgi?id=106620
3572 Reviewed by Christophe Dumez.
3574 Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3577 * MiniBrowser/efl/CMakeLists.txt:
3578 * MiniBrowser/efl/main.c:
3579 (page_contents_callback):
3581 (show_file_entry_dialog): generic function to show file enrty
3584 2013-06-21 Brent Fulgham <bfulgham@apple.com>
3586 [Windows] Unreviewed crash protection for DRT
3588 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3589 to avoid crashing during test runs.
3591 2013-06-21 Christophe Dumez <ch.dumez@sisa.samsung.com>
3593 REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3594 https://bugs.webkit.org/show_bug.cgi?id=117825
3596 Reviewed by Kentaro Hara.
3598 DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3600 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3601 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3602 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3603 (TestRunner::overridePreference):
3605 2013-06-21 Krzysztof Czech <k.czech@samsung.com>
3607 [ATK] Added support for aria-required attribute.
3608 https://bugs.webkit.org/show_bug.cgi?id=117730
3610 Reviewed by Chris Fleizach.
3612 Added support for testing aria-required attribute.
3614 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3615 (AccessibilityUIElement::isRequired):
3616 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3617 (WTR::AccessibilityUIElement::isRequired):
3619 2013-06-20 Ryuan Choi <ryuan.choi@samsung.com>
3621 [CMAKE][EFL] Enable DOM4 Events Constructor
3622 https://bugs.webkit.org/show_bug.cgi?id=117858
3624 Reviewed by Laszlo Gombos.
3626 * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3628 2013-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
3630 [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3631 https://bugs.webkit.org/show_bug.cgi?id=117827
3633 Reviewed by Rob Buis.
3635 Reset the passed in request if willSendRequestReturnsNull() is
3636 true or willSendRequestReturnsNullOnRedirect() is true and it's a
3639 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3640 (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3641 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3643 2013-06-20 Csaba Osztrogonác <ossy@webkit.org>
3645 Commit queue shouldn't reopen unrelated bugs because of flakiness
3646 https://bugs.webkit.org/show_bug.cgi?id=117503
3648 Reviewed by Ryosuke Niwa.
3650 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3651 (_follow_duplicate_chain):
3652 (_update_bug_for_flaky_test):
3654 2013-06-19 Brent Fulgham <bfulgham@apple.com>
3656 [Windows] AX: Expand notification support.
3657 https://bugs.webkit.org/show_bug.cgi?id=117761
3659 Reviewed by Anders Carlsson.
3661 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3662 (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3663 (AccessibilityUIElement::press): Provide implementation.
3665 2013-06-19 Benjamin Poulain <bpoulain@apple.com>
3667 Use the PlatformEvent timestamp when creating a DOM Event
3668 https://bugs.webkit.org/show_bug.cgi?id=117179
3670 Reviewed by Darin Adler.
3672 * WebKitTestRunner/mac/EventSenderProxy.mm:
3673 (WTR::EventSenderProxy::mouseDown):
3674 (WTR::EventSenderProxy::mouseUp):
3675 (WTR::EventSenderProxy::mouseMoveTo):
3676 (WTR::EventSenderProxy::keyDown):
3678 2013-06-18 Alex Christensen <achristensen@apple.com>
3680 Working on coverage script, added xml to json data extraction script.
3681 https://bugs.webkit.org/show_bug.cgi?id=117648
3683 This is part of a new test code coverage analysis tool. This compiles WebKit to generate
3684 coverage data, runs the tests, and collects all of the data in json format.
3686 Reviewed by Stephanie Lewis.
3688 * Scripts/generate-coverage-data:
3690 (getFileHitsAndBranches):
3693 * Scripts/webkitpy/tool/gcovr: Added.
3695 2013-06-18 Ryuan Choi <ryuan.choi@samsung.com>
3697 Unreviewed build fix after r151699.
3699 * TestWebKitAPI/CMakeLists.txt:
3700 * WebKitTestRunner/CMakeLists.txt:
3701 Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3703 2013-06-18 Roger Fong <roger_fong@apple.com>
3705 Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3706 <rdar://problem/14118143>.
3708 Rubberstamped by Brent Fulgham.
3710 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3711 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3712 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3713 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3714 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3715 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3716 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3717 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3718 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3719 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3720 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3721 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3722 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3723 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3724 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3725 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3726 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3727 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3728 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3729 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3730 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3731 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3732 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3733 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3734 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3735 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3736 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3737 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3738 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3739 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3740 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3741 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3742 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3743 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3744 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3745 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3746 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3747 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3748 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3749 * win/record-memory/record-memory.vcxproj:
3750 * win/record-memory/record-memoryDebug.props:
3751 * win/record-memory/record-memoryDebugWinCairo.props:
3752 * win/record-memory/record-memoryProduction.props:
3753 * win/record-memory/record-memoryRelease.props:
3754 * win/record-memory/record-memoryReleaseWinCairo.props:
3756 2013-06-17 Kangil Han <kangil.han@samsung.com>
3758 Unreviewed. Add my email to a DOM watchlist.
3760 * Scripts/webkitpy/common/config/watchlist:
3762 2013-06-17 Zan Dobersek <zdobersek@igalia.com>
3764 Unreviewed GTK gardening.
3766 * Scripts/run-gtk-tests:
3767 (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3769 2013-06-15 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
3771 Unreviewed. Reorder my email addresses.
3772 https://bugs.webkit.org/show_bug.cgi?id=100122
3774 * Scripts/webkitpy/common/config/contributors.json:
3776 2013-06-14 Enrica Casucci <enrica@apple.com>
3778 WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3779 https://bugs.webkit.org/show_bug.cgi?id=117647
3780 <rdar://problem/13881024>
3782 Reviewed by Darin Adler.
3784 The test now uses content with a selection and tests both
3785 forwards and backward find as well as the case of a find
3786 that has no matches after the user selection.
3788 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3789 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3790 (TestWebKitAPI::didFindStringMatches):
3791 * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3793 2013-06-14 Tor Arne Vestbø <tor.arne.vestbo@digia.com>
3795 Remove myself from Qt build system watchlist
3797 Reviewed by Simon Hausmann.
3799 * Scripts/webkitpy/common/config/watchlist:
3801 2013-06-13 Michael Brüning <michael.bruning@digia.com>
3803 [Qt][Mac] Disable QTKit video on OS X.
3804 https://bugs.webkit.org/show_bug.cgi?id=117591
3806 Reviewed by Tor Arne Vestbø.
3808 Deployment of Qt binaries to different Mac OS X
3809 platform version makes it impossible to link against
3810 the correct version of the WebKitSystemInterface library,
3811 so we need to disable QTKit for media elements.
3813 * qmake/mkspecs/features/features.prf:
3815 2013-06-13 Michał Pakuła vel Rutka <m.pakula@samsung.com>
3817 [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3818 https://bugs.webkit.org/show_bug.cgi?id=116610
3820 Reviewed by Noam Rosenthal.
3822 Remove unnecessary code adjusting context menu position to webview position.
3823 Now position is calculcated in EwkView.
3825 * MiniBrowser/efl/main.c:
3826 (on_context_menu_show):
3828 2013-06-12 Roger Fong <roger_fong@apple.com>
3830 Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3832 * Scripts/webkitpy/common/config/ews.json:
3834 2013-06-12 Eduardo Lima Mitev <elima@igalia.com>
3836 [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3837 https://bugs.webkit.org/show_bug.cgi?id=115647
3839 Reviewed by Martin Robinson.
3841 Locale resolution is moved to WebKitAccessibleWrapperAtk using
3842 AtkObject::get_object_locale() API. Now, implementation of
3843 AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3844 be leveraged to get_object_locale() of AtkObject.
3846 Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3849 No new functionality, no new tests.
3851 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3852 (AccessibilityUIElement::language): Leverage locale resolution to
3853 AtkObject::get_object_locale().
3854 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3855 (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3856 AtkObject::get_object_locale().
3858 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
3860 Remove last bits of GYP from build-webkit and update-webkit scripts
3861 https://bugs.webkit.org/show_bug.cgi?id=117557
3863 Reviewed by Ryosuke Niwa.
3865 * Scripts/build-webkit:
3866 * Scripts/update-webkit:
3868 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
3870 Remove forgotten unused Tools/Script/make-gypi script
3871 https://bugs.webkit.org/show_bug.cgi?id=117558
3873 Reviewed by Ryosuke Niwa.
3875 This script isn't used since the GYP removal from WebKit.
3877 * Scripts/make-gypi: Removed.
3879 2013-06-12 Andres Gomez <agomez@igalia.com>
3881 [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
3882 https://bugs.webkit.org/show_bug.cgi?id=117533
3884 Reviewed by Carlos Garcia Campos.
3886 MiniBrowser now starts automatically the download of the documents
3887 that cannot be shown just by WebKit itself on link left clicking.
3889 * MiniBrowser/gtk/BrowserWindow.c:
3890 (webViewDecidePolicy): handled the
3891 WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
3893 2013-06-12 Zan Dobersek <zdobersek@igalia.com>
3895 [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
3896 https://bugs.webkit.org/show_bug.cgi?id=116723
3898 Reviewed by Carlos Garcia Campos.
3900 * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
3901 remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
3902 and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
3903 not expensive and produces a working archive without problems even on incremental builds.
3905 2013-06-11 Santosh Mahto <santosh.ma@samsung.com>
3907 [EFL] Window resize should close the popupmenu
3908 https://bugs.webkit.org/show_bug.cgi?id=117391
3910 Reviewed by Christophe Dumez.
3912 Added the code to close the popup when main window is resized.
3914 * MiniBrowser/efl/main.c:
3917 2013-06-11 Alex Christensen <achristensen@apple.com>
3919 Removed old broken code coverage tool.
3920 https://bugs.webkit.org/show_bug.cgi?id=117520
3922 Reviewed by Sam Weinig.
3924 * CodeCoverage: Removed.
3925 * CodeCoverage/README: Removed.
3926 * CodeCoverage/amber.png: Removed.
3927 * CodeCoverage/cov.py: Removed.
3928 * CodeCoverage/emerald.png: Removed.
3929 * CodeCoverage/gcov.css: Removed.
3930 * CodeCoverage/glass.png: Removed.
3931 * CodeCoverage/regenerate-coverage-display: Removed.
3932 * CodeCoverage/ruby.png: Removed.
3933 * CodeCoverage/run-generate-coverage-data: Removed.
3934 * CodeCoverage/snow.png: Removed.
3936 2013-06-11 Timothy Hatcher <timothy@apple.com>
3938 Have build-webkit build the WebInspectorUI project.
3940 * Scripts/build-webkit:
3942 2013-06-11 Ryosuke Niwa <rniwa@webkit.org>
3944 Add an option to run-webkit-tests to skip java dependency check
3945 https://bugs.webkit.org/show_bug.cgi?id=117516
3947 Reviewed by Andreas Kling.
3949 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3951 * Scripts/webkitpy/port/mac.py:
3952 (MacPort._check_port_build):
3954 2013-06-11 Alex Christensen <achristensen@apple.com>
3956 https://bugs.webkit.org/show_bug.cgi?id=117514
3957 Removed extra Xcode code coverage flags.
3959 Reviewed by Sam Weinig.
3961 * Scripts/webkitdirs.pm:
3962 (XcodeCoverageSupportOptions):
3964 2013-06-11 Brent Fulgham <bfulgham@apple.com>
3966 [Windows] Implement 'attributeValue' accessor to support testing
3967 https://bugs.webkit.org/show_bug.cgi?id=117513
3969 Reviewed by Anders Carlsson.
3971 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3972 (comparableObject): Move earlier in file.
3973 (findAccessibleObjectById): New implemenation.
3974 (AccessibilityController::accessibleElementById): New implementation.
3976 2013-06-11 Csaba Osztrogonác <ossy@webkit.org>
3978 Make WTR use its own temporary directory for application cache
3979 https://bugs.webkit.org/show_bug.cgi?id=117143
3981 Reviewed by Alexey Proskuryakov.
3983 * WebKitTestRunner/TestController.cpp:
3984 (WTR::TestController::initialize):
3986 2013-06-10 Alexey Proskuryakov <ap@apple.com>
3988 https://bugs.webkit.org/show_bug.cgi?id=117449
3989 Remove dead code for storing fonts in __DATA section
3991 Reviewed by Dan Bernstein.
3993 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3994 Don't copy font resources to __DATA, as we don't have any code that reads them
3995 from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
3997 * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
3998 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
3999 Removed comments suggesting that we want to restore the old solution.
4001 2013-06-10 Bear Travis <betravis@adobe.com>
4003 [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
4004 https://bugs.webkit.org/show_bug.cgi?id=117162
4006 Reviewed by Alexandru Chiculita.
4008 Adding the WebCore/rendering/shapes directory to the include list.
4010 * DumpRenderTree/efl/CMakeLists.txt:
4012 2013-06-09 Brent Fulgham <bfulgham@apple.com>
4014 [Windows] Unreviewed test correction: Prevent DumpRenderTree crashes
4015 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4016 (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
4017 happends in some of the 'accessibility' test cases.
4019 2013-06-08 peavo@outlook.com <peavo@outlook.com>
4021 [WinCairo] TestWebKitAPI fails to link.
4022 https://bugs.webkit.org/show_bug.cgi?id=117345
4024 Reviewed by Brent Fulgham.
4026 Need to link with WTF.lib.
4028 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
4030 2013-06-07 Roger Fong <roger_fong@apple.com>
4032 Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
4034 Rubberstamped by Ryousuke Niwa.
4036 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4037 (RunTest.test_build_check):
4039 2013-06-07 Hugo Parente Lima <hugo.lima@openbossa.org>
4041 [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
4042 https://bugs.webkit.org/show_bug.cgi?id=117315
4044 Reviewed by Benjamin Poulain.
4046 Qt doesn't use the default values specified on FeatureList since r44681,
4047 this patch just remove a bit of noise.
4049 * Scripts/webkitperl/FeatureList.pm:
4051 2013-06-07 Jungsik Tae <davidtlay88@gmail.com>
4053 [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
4054 https://bugs.webkit.org/show_bug.cgi?id=115890
4056 Reviewed by Christophe Dumez.
4058 When user clicks HTML5 input type color,
4059 color selector window is created on browser object by using elm_colorchooser_add().
4060 It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
4061 The evas_object_color_set() sets a color value returning to browser.
4063 * MiniBrowser/efl/main.c:
4064 (window_free): When we delete parent window, deleting the colorpicker object.
4065 (on_color_changed): Change color of rectangle to show color selected by user.
4066 (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
4067 (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
4068 (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
4069 (on_color_picker_dismiss): Delete colorpicker object.
4070 (on_color_picker_request): Create colorpicker window object.
4073 2013-06-06 Yuki Sekiguchi <yuki.sekiguchi@access-company.com>
4075 svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
4076 https://bugs.webkit.org/show_bug.cgi?id=111066
4078 Reviewed by Daniel Bates.
4080 Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
4082 ParseGitDiffHeader() should support the path which line has space characters.
4083 To support this, I changed parsing algorithm like the following:
4084 - When the diff have prefix, we consider next characters after "b/" as part of a file path.
4085 - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
4087 We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
4089 If the path has a tab, the patch(1) command thinks file path is characters before the tab.
4090 I added a dummy tab and revision when we convert git diff to svn diff.
4092 * Scripts/VCSUtils.pm:
4093 (parseGitDiffHeader):
4094 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
4095 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
4096 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
4097 - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
4099 2013-06-06 Simon Fraser <simon.fraser@apple.com>
4101 Add a menu item to MiniBrowser to toggle Transparent windows
4102 https://bugs.webkit.org/show_bug.cgi?id=117316
4104 Reviewed by Anders Carlsson.
4106 Add a menu item that toggles "Transparent window" mode, which is exposed
4107 via private WebKit API and WebKit2 API.
4109 * MiniBrowser/mac/BrowserWindowController.h:
4110 * MiniBrowser/mac/MainMenu.xib:
4111 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
4112 * MiniBrowser/mac/WK1BrowserWindowController.m:
4113 (-[WK1BrowserWindowController validateMenuItem:]):
4114 (-[WK1BrowserWindowController toggleTransparentWindow:]):
4115 * MiniBrowser/mac/WK2BrowserWindowController.m:
4116 (-[WK2BrowserWindowController validateMenuItem:]):
4117 (-[WK2BrowserWindowController toggleTransparentWindow:]):
4118 (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
4121 2013-06-06 Roger Fong <roger_fong@apple.com>
4123 Stop copying AAS binaries into build folder.
4124 https://bugs.webkit.org/show_bug.cgi?id=117319.
4126 Rubberstamped by Darin Adler.
4128 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
4130 2013-06-06 Hugo Parente Lima <hugo.lima@openbossa.org>
4132 Aligning build-webkit command line switch names to the WebKit flag names
4133 https://bugs.webkit.org/show_bug.cgi?id=117254
4135 Reviewed by Laszlo Gombos.
4137 * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
4139 2013-06-06 Chris Fleizach <cfleizach@apple.com>
4141 AX: iOS ignores ARIA progressbar elements
4142 https://bugs.webkit.org/show_bug.cgi?id=116727
4144 Reviewed by David Kilzer.
4146 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4147 (AccessibilityUIElement::minValue):
4148 (AccessibilityUIElement::maxValue):
4150 2013-06-06 peavo@outlook.com <peavo@outlook.com>
4152 [WinCairo] Fix build-webkit to build WinCairo under VS2010.
4153 https://bugs.webkit.org/show_bug.cgi?id=117255
4155 Reviewed by Daniel Bates.
4157 Need to update configuration names according to solution file.
4159 * Scripts/webkitdirs.pm:
4160 (determineConfiguration):
4161 (determinePassedConfiguration):
4163 2013-06-06 Ryosuke Niwa <rniwa@webkit.org>
4165 Remove run-performance-tests
4166 https://bugs.webkit.org/show_bug.cgi?id=117285
4168 Reviewed by Andreas Kling.
4170 Remove the script since it's not used anywhere.
4172 * BuildSlaveSupport/run-performance-tests: Removed.
4174 2013-06-05 Bear Travis <betravis@adobe.com>
4176 [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
4177 https://bugs.webkit.org/show_bug.cgi?id=117172
4179 Reviewed by Alexandru Chiculita.
4181 Adding the CSS_SHAPES compile flag.
4183 * Scripts/webkitperl/FeatureList.pm:
4184 * qmake/mkspecs/features/features.pri:
4186 2013-06-05 Brent Fulgham <bfulgham@apple.com>
4188 [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
4189 to UNIX-style they will not execute properly.
4191 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
4192 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
4194 2013-06-05 Roger Fong <roger_fong@apple.com>
4196 Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
4198 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4199 (RunWebKitTests.start):
4201 2013-06-05 Brent Fulgham <bfulgham@apple.com>
4203 [Windows] Switch to NRWT
4204 https://bugs.webkit.org/show_bug.cgi?id=117200
4206 Reviewed by Anders Carlsson.
4208 * Scripts/run-webkit-tests:
4209 (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
4211 2013-06-05 Dominik Röttsches <dominik.rottsches@intel.com>
4213 Unreviewed name fix after r150662
4215 My firstname got duplicated when fixing bug 116737.
4217 * Scripts/webkitpy/common/config/contributors.json:
4219 2013-06-05 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
4221 Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
4222 https://bugs.webkit.org/show_bug.cgi?id=117244
4224 Reviewed by Daniel Bates.
4226 Fixed a regression introduced by r151196: not only does webkit.org
4227 still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
4228 infrastructure used by ports such as GTK+ and EFL also use on it for
4229 things such as jhbuild.
4231 While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
4232 both environment variables.
4234 * Scripts/webkitdirs.pm:
4235 (determineBaseProductDir):
4237 2013-06-05 Wojciech Bielawski <w.bielawski@samsung.com>
4239 [GTK] Forwarding headers not generated for incremental build
4240 https://bugs.webkit.org/show_bug.cgi?id=117198
4242 Reviewed by Carlos Garcia Campos.
4244 * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
4246 2013-06-05 Andras Becsi <andras.becsi@digia.com>
4248 [Qt][WK2] Fix layout testing with Qt 5.1
4249 https://bugs.webkit.org/show_bug.cgi?id=117203
4251 Reviewed by Jocelyn Turcotte.
4253 With Qt 5.1 synchronous requests via QNetworkAccessManager do not
4254 go into loading state but directly call handler functions for
4255 finished state instead of relying on a connection.
4256 Our wrapper QQuickView uses a data URI scheme to create the root
4257 item for testing which results in a synchronous request when loading
4258 the QML data, therefore the state of the QQuickWindow immediately
4260 Since the final initialization of the root item depended on the
4261 emission of QQuickView::statusChanged(QQuickView::Ready) we ended
4262 up with a partially initialized wrapper window, thus most of our
4263 layout tests were failing.
4264 For compatibility with pre-5.1 Qt versions keep the old behaviour
4265 in case the WrapperWindow is not ready in the constructor yet.
4267 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4268 (WTR::WrapperWindow::WrapperWindow):
4269 * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
4270 (TestWebKitAPI::WrapperWindow::WrapperWindow):
4272 2013-06-05 Dariusz Frankiewicz <d.frankiewic@samsung.com>
4274 Bad value in tests counter at new-run-webkit-tests
4275 in --debug-rwt-logging mode
4276 https://bugs.webkit.org/show_bug.cgi?id=116858
4278 Reviewed by Dirk Pranke.
4280 Fix by moving counter incrementation, from after printing line,
4281 to before printing. Also changed variable name.
4283 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4284 (LayoutTestRunner.run_tests):
4285 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
4287 * Scripts/webkitpy/layout_tests/views/printing.py:
4289 (Printer._test_status_line):
4290 (Printer.print_started_test):
4291 (Printer.print_finished_test):
4292 * Scripts/webkitpy/test/printer.py:
4294 (Printer.print_finished_test):
4295 (Printer._test_line):
4296 (Printer.print_result):
4298 2013-06-05 Zan Dobersek <zdobersek@igalia.com>
4300 Move MemoryInfo under window.internals
4301 https://bugs.webkit.org/show_bug.cgi?id=117197
4303 Reviewed by Ryosuke Niwa.
4305 * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
4307 * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
4308 testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
4310 2013-06-03 Roger Fong <roger_fong@apple.com>
4312 Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
4313 <rdar://problem/14042021>.
4315 Reviewed by Brent Fulgham.
4317 * Scripts/build-api-tests:
4318 * Scripts/build-dumprendertree:
4319 * Scripts/build-webkit:
4320 * Scripts/update-webkit-dependency:
4321 * Scripts/update-webkit-support-libs:
4322 * Scripts/webkitdirs.pm:
4323 (determineBaseProductDir):
4327 2013-06-04 Brent Fulgham <bfulgham@apple.com>
4329 [Windows] NRWT is not putting crash logs in proper place (corrections)
4330 https://bugs.webkit.org/show_bug.cgi?id=117212
4332 Reviewed by Dirk Pranke.
4334 * Scripts/webkitpy/common/system/crashlogs.py:
4335 (CrashLogs.__init__): Accept a result directory argument in constructor.
4336 (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
4337 (CrashLogs._find_newest_log_win): No longer use 'port' argument.
4338 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4339 (CrashLogsTest.test_find_log_win): Simplify test.
4340 * Scripts/webkitpy/common/system/executive.py: