[Chromium] Layout test does not return correct misspelling positions if there are...
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
2
3         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
4         https://bugs.webkit.org/show_bug.cgi?id=72655
5
6         Reviewed by Hajime Morita.
7
8         Fixed the calculation of offset.
9
10         * DumpRenderTree/chromium/WebViewHost.cpp:
11         (WebViewHost::finishLastTextCheck):
12
13 2011-11-20  Ojan Vafai  <ojan@chromium.org>
14
15         Change the final place where we use version 3 of the results json output
16         https://bugs.webkit.org/show_bug.cgi?id=72838
17
18         Reviewed by Adam Barth.
19
20         This converts the json from being a flat map of test name --> results
21         to being hierarchical by directory. This will make the json files 
22         considerably smaller.
23
24         Also cleaned up some functions that were returning/checking boolean values
25         that were always True.
26
27         * TestResultServer/model/jsonresults.py:
28         * TestResultServer/model/jsonresults_unittest.py:
29
30 2011-11-20  Ojan Vafai  <ojan@chromium.org>
31
32         Include the master name when querying the test results server.
33         This will soon be required since leaving the master name out mean
34         that multiple files could match the query.
35
36         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
37
38 2011-11-19  Ojan Vafai  <ojan@chromium.org>
39
40         Fix jsonp callback code to add the callback if json content
41         is not jsonp.
42         * TestResultServer/handlers/testfilehandler.py:
43
44 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
45
46         Modify dashboard_base.js to optionally accept version 4 results json.
47
48         Reviewed by Ojan Vafai.
49
50         * TestResultServer/static-dashboards/dashboard_base.js:
51         (ADD_RESULTS):
52         (flattenTrie):
53         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
54         (testFlattenTrie):
55
56 2011-11-19  Ojan Vafai  <ojan@chromium.org>
57
58         Stop storing results files as jsonp in the test results server
59         https://bugs.webkit.org/show_bug.cgi?id=72814
60
61         Reviewed by Adam Barth.
62
63         * TestResultServer/model/jsonresults.py:
64         * TestResultServer/model/jsonresults_unittest.py:
65
66 2011-11-19  Ojan Vafai  <ojan@chromium.org>
67
68         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
69         https://bugs.webkit.org/show_bug.cgi?id=72813
70
71         Reviewed by Adam Barth.
72
73         Once this lands, we can start storing pure json in the test results server and then
74         we can delete the code with all the FIXMEs added here.
75
76         * Scripts/webkitpy/layout_tests/controllers/manager.py:
77         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
78         Only add jsonp for full_results.json.
79         * TestResultServer/model/jsonresults.py:
80         * TestResultServer/model/jsonresults_unittest.py:
81         Accept pure json uploads.
82         * TestResultServer/static-dashboards/dashboard_base.js:
83         (appendJSONScriptElementFor):
84         Use the callback parameter so that the server can start returning pure json if it's left out.
85
86 2011-11-19  Ojan Vafai  <ojan@chromium.org>
87
88         Allow json NRWT downloads to be pure json and not jsonp
89         https://bugs.webkit.org/show_bug.cgi?id=72809
90
91         Reviewed by Adam Barth.
92
93         I'm moving the server to storing and serving up raw json instead of jsonp.
94         You can still get the jsonp by passing a "callback" parameter, but there's no
95         need for run-webkit-tests to get jsonp when all it wants is the raw json.
96
97         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
98         Make the wrapper stripping only happen if the json is actually wrapped.
99         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
100
101 2011-11-18  Daniel Bates  <dbates@rim.com>
102
103         Add CMake build infrastructure for the BlackBerry port
104         https://bugs.webkit.org/show_bug.cgi?id=72768
105
106         Reviewed by Antonio Gomes.
107
108         Add optional --blackberry command line argument to build-webkit to build the
109         BlackBerry port.
110
111         * Scripts/build-webkit:
112         * Scripts/webkitdirs.pm:
113         (determineBaseProductDir):
114         (argumentsForConfiguration):
115         (builtDylibPathForName):
116         (determineIsQt):
117         (isBlackBerry): Added.
118         (determineIsBlackBerry): Added.
119         (blackberryTargetArchitecture): Added.
120         (isAppleWebKit):
121
122 2011-11-18  James Robinson  <jamesr@chromium.org>
123
124         Unreviewed, rolling out r100835.
125         http://trac.webkit.org/changeset/100835
126         https://bugs.webkit.org/show_bug.cgi?id=72778
127
128         Broke some page scale tests
129
130         * DumpRenderTree/chromium/EventSender.cpp:
131         (EventSender::scalePageBy):
132
133 2011-11-18  Adam Barth  <abarth@webkit.org>
134
135         Prepare to move manual-tests out of WebCore
136         https://bugs.webkit.org/show_bug.cgi?id=72782
137
138         Reviewed by Eric Seidel.
139
140         Update this file to refer to the new location of ManualTests.
141
142         * Scripts/webkitpy/common/config/build.py:
143
144 2011-11-18  James Robinson  <jamesr@chromium.org>
145
146         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
147         https://bugs.webkit.org/show_bug.cgi?id=72778
148
149         Reviewed by Kenneth Russell.
150
151         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
152
153         * DumpRenderTree/chromium/EventSender.cpp:
154         (EventSender::scalePageBy):
155
156 2011-11-18  Scott Graham  <scottmg@chromium.org>
157
158         IDL changes for gamepad support
159         https://bugs.webkit.org/show_bug.cgi?id=71753
160
161         Reviewed by Adam Barth.
162
163         Runtime enable gamepad in chromium test shell.
164
165         * DumpRenderTree/chromium/TestShell.cpp:
166         (TestShell::TestShell):
167
168 2011-10-27  Darin Fisher  <darin@chromium.org>
169
170         [chromium] Improve fullscreen API
171         https://bugs.webkit.org/show_bug.cgi?id=70477
172
173         Reviewed by Adam Barth.
174
175         Implement enter/exitFullScreen.  The implementation is asynchronous,
176         via postDelayedTask, to simulate how the browser actually behaves.
177
178         * DumpRenderTree/chromium/WebViewHost.cpp:
179         (WebViewHost::enterFullScreen):
180         (WebViewHost::exitFullScreen):
181         (WebViewHost::setAddressBarURL):
182         (WebViewHost::enterFullScreenNow):
183         (WebViewHost::exitFullScreenNow):
184         * DumpRenderTree/chromium/WebViewHost.h:
185
186 2011-11-18  Adam Roben  <aroben@apple.com>
187
188         Ignore an ANGLE leak that is not WebKit's fault
189
190         * Scripts/old-run-webkit-tests:
191         (countAndPrintLeaks):
192         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
193         (LeakDetector._callstacks_to_exclude_from_leaks):
194         Added ScanFromString to the call stacks to exclude on all OS versions.
195
196 2011-11-18  Adam Roben  <aroben@apple.com>
197
198         Ignore another Lion-specific leak that is not WebKit's fault
199
200         * Scripts/old-run-webkit-tests:
201         (countAndPrintLeaks):
202         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
203         (LeakDetector._callstacks_to_exclude_from_leaks):
204         Added SecTransformExecute to the call stacks to exclude.
205
206 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
207
208         [Qt] Enable WebSocket hybi tests
209         https://bugs.webkit.org/show_bug.cgi?id=72687
210
211         Reviewed by Simon Hausmann.
212
213         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
214
215         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
216         (WebCore::WebPage::resetSettings):
217         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
218         (LayoutTestController::overridePreference):
219
220 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
221
222         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
223         https://bugs.webkit.org/show_bug.cgi?id=72707
224
225         Reviewed by Philippe Normand.
226
227         Make new-run-webkit-tests use the right path to locate the test
228         plugin used by WebKitTestRunner.
229
230         * Scripts/webkitpy/layout_tests/port/gtk.py:
231
232 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
233
234         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
235         https://bugs.webkit.org/show_bug.cgi?id=72697
236
237         Reviewed by Kenneth Rohde Christiansen.
238
239         * Tools.pro: Make WTR linux only for the moment.
240         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
241         * WebKitTestRunner/Target.pri: Ditto.
242         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
243         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
244
245 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
246
247         [Qt] Change default size of the MiniBrowser
248
249         Reviewed by Simon Hausmann.
250
251         As we lay out desktop pages using the width of 980, change our default
252         size to 980x735 so that we are not scaling down by default.
253
254         * MiniBrowser/qt/MiniBrowserApplication.h:
255         (WindowOptions::WindowOptions):
256
257 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
258
259         [EFL] Clean up the use of DATA_DIR in the buildsystem
260         https://bugs.webkit.org/show_bug.cgi?id=72681
261
262         Reviewed by Daniel Bates.
263
264         Instead of adding -DDATA_DIR in all scopes, only define it in
265         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
266         it.
267
268         We can then define DATA_DIR to the generated theme directory for
269         EWebLauncher, since it's what we want here.
270
271         * CMakeListsEfl.txt:
272
273 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
274
275         [EFL] Move platform includes last in DRT's include directories.
276         https://bugs.webkit.org/show_bug.cgi?id=72684
277
278         Reviewed by Daniel Bates.
279
280         This is the first step in fixing the build when a platform include (in
281         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
282         is included instead of WebKit's.
283
284         * DumpRenderTree/efl/CMakeLists.txt:
285
286 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
287
288         fuzzy_match doesn't recognize "Dan B" or "hyatt"
289         https://bugs.webkit.org/show_bug.cgi?id=72636
290
291         Reviewed by Eric Seidel.
292
293         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
294         and user names of email addreses such as rniwa in rniwa@webkit.org.
295
296         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
297
298         * Scripts/webkitpy/common/config/committers.py:
299         * Scripts/webkitpy/common/config/committers_unittest.py:
300
301 2011-11-17  Eric Seidel  <eric@webkit.org>
302
303         Remove support for running check-webkit-style w/o a webkit checkout
304         https://bugs.webkit.org/show_bug.cgi?id=72678
305
306         Reviewed by Adam Barth.
307
308         After talking to Dave Levin we've decided to remove this
309         code.  I know of no users of check-webkit-style w/o a webkit checkout
310         and this needlessly adds complexity.
311
312         * Scripts/webkitpy/style/main.py:
313
314 2011-11-17  Eric Seidel  <eric@webkit.org>
315
316         Remove more direct uses of os.path
317         https://bugs.webkit.org/show_bug.cgi?id=72677
318
319         Reviewed by Adam Barth.
320
321         Remove more uses of os.path, including refactoring
322         CommitterValidator to use a Host object instead of
323         manual hacks to emulate what SCM and FileSystem provide.
324
325         * Scripts/webkitpy/common/checkout/changelog.py:
326         * Scripts/webkitpy/common/config/committervalidator.py:
327         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
328         * Scripts/webkitpy/common/system/filesystem_mock.py:
329          - Turns out none of our unittests actually looked at this path.
330            now I've made it be a valid path.
331         * Scripts/webkitpy/tool/bot/feeders.py:
332         * Scripts/webkitpy/tool/commands/queues.py:
333
334 2011-11-17  Eric Seidel  <eric@webkit.org>
335
336         Teach TextFileReader about FileSystem
337         https://bugs.webkit.org/show_bug.cgi?id=72673
338
339         Reviewed by Adam Barth.
340
341         Unfortunately TextFileReader doesn't use FileSystem
342         everywhere yet, so we can't move the unittests to
343         using MockFileSystem, but we're close.
344
345         * Scripts/webkitpy/style/filereader.py:
346         * Scripts/webkitpy/style/filereader_unittest.py:
347         * Scripts/webkitpy/style/main.py:
348
349 2011-11-17  Eric Seidel  <eric@webkit.org>
350
351         Give check-webkit-style a Host
352         https://bugs.webkit.org/show_bug.cgi?id=72670
353
354         Reviewed by Adam Barth.
355
356         * Scripts/webkitpy/common/checkout/scm/detection.py:
357         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
358          - We don't run these unittests, but this one was looking for the wrong exception.
359         * Scripts/webkitpy/style/main.py:
360         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
361          - This was create a new scm object even though it already had one?
362
363 2011-11-17  Eric Seidel  <eric@webkit.org>
364
365         Move check-webkit-style change_directory code to more modern mocks
366         https://bugs.webkit.org/show_bug.cgi?id=72664
367
368         Reviewed by Adam Barth.
369
370         * Scripts/check-webkit-style:
371         * Scripts/webkitpy/style/main.py:
372         * Scripts/webkitpy/style/main_unittest.py:
373
374 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
375
376         [GTK] enable ref tests
377         https://bugs.webkit.org/show_bug.cgi?id=72601
378
379         Re-enable ref tests. Run the driver under evenly numbered display if performing
380         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
381         being run in an already used Xvfb instance if pixel tests are disabled.
382
383         Reviewed by Tony Chang.
384
385         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
386         after the process is killed
387
388 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
389
390         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
391         https://bugs.webkit.org/show_bug.cgi?id=72620
392
393         Reviewed by David Levin.
394
395         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
396         adding the suffix the cpp file. One example of false positive
397         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
398
399         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
400         basename contains the cpp's basename.
401         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
402
403 2011-11-17  Eric Seidel  <eric@webkit.org>
404
405         Move check-webkit-style's guts into webkitpy/style/main.py
406         https://bugs.webkit.org/show_bug.cgi?id=72657
407
408         Reviewed by Adam Barth.
409
410         * Scripts/check-webkit-style:
411         * Scripts/webkitpy/style/main.py:
412
413 2011-11-17  Eric Seidel  <eric@webkit.org>
414
415         new-run-webkit-tests is locale dependent
416         https://bugs.webkit.org/show_bug.cgi?id=68691
417
418         Reviewed by Adam Barth.
419
420         Make NRWT use a clean environment, just like ORWT did.
421
422         * Scripts/webkitpy/layout_tests/port/base.py:
423         * Scripts/webkitpy/layout_tests/port/chromium.py:
424         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
425         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
426         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
427         * Scripts/webkitpy/layout_tests/port/efl.py:
428         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
429         * Scripts/webkitpy/layout_tests/port/mac.py:
430         * Scripts/webkitpy/layout_tests/port/qt.py:
431         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
432         * Scripts/webkitpy/layout_tests/port/webkit.py:
433         * Scripts/webkitpy/layout_tests/port/win.py:
434
435 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
436
437         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
438         https://bugs.webkit.org/show_bug.cgi?id=72615
439
440         Reviewed by James Robinson.
441
442         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
443
444 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
445
446         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
447         https://bugs.webkit.org/show_bug.cgi?id=72595
448
449         Reviewed by Noam Rosenthal.
450
451         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
452         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
453         ensure the registration of the DRTNode JS bindings.
454         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
455         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
456         registration of QWebElement (now done implicitly through QWebPage ->
457         QtWebElementRunTime::initialize code path)
458
459 2011-11-17  Adam Roben  <aroben@apple.com>
460
461         Fix a crash-inducing typo I introduced in r100648
462
463         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
464         handling a crashing test
465
466         Reviewed by Adam Barth.
467
468         * Scripts/webkitpy/layout_tests/port/chromium.py:
469         (ChromiumDriver.run_test): Get the driver name from the port.
470
471         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
472         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
473         right crashed process name.
474
475 2011-11-17  Adam Roben  <aroben@apple.com>
476
477         Fix NRWT's parsing of the number of excluded leaks
478
479         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
480         leaks were excluded
481
482         Reviewed by Adam Barth.
483
484         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
485         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
486         regular expression match, not the entire matched string.
487
488         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
489         (LeakDetectorTest): Added some example output that shows how things look when leaks are
490         excluded.
491         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
492         correctly.
493
494 2011-11-17  Adam Roben  <aroben@apple.com>
495
496         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
497
498         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
499         when web process crashes, but WebProcess crash log should get saved instead
500
501         Reviewed by Eric Seidel.
502
503         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
504         (write_test_result): Simplified a little to share more code between the case where we
505         crashed when running the test and where we crashed when checking the expected rendering for
506         a reftest. Changed to pass the crashed process name down to write_crash_report.
507         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
508         along to CrashLogs.find_newest_log rather than always using the driver name.
509
510         * Scripts/webkitpy/layout_tests/port/chromium.py:
511         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
512         crashed.
513
514         * Scripts/webkitpy/layout_tests/port/test.py:
515         (TestInstance.__init__): Initialize new web_process_crash attribute.
516         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
517         test this patch adds.
518         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
519         specifies that the driver crashed or the web process crashed.
520
521         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
522         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
523         which we pretend the web process crashed rather than the driver process.
524
525         (MainTest.test_run_singly_actually_runs_tests):
526         (MainTest.test_unexpected_failures):
527         (EndToEndTest.test_end_to_end):
528         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
529
530 2011-11-17  Tony Chang  <tony@chromium.org>
531
532         [chromium] stop spamming features warning on every build
533         https://bugs.webkit.org/show_bug.cgi?id=72629
534
535         Reviewed by Ojan Vafai.
536
537         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
538         $mediaStreamSupport is on by default for chromium, make the default
539         for $blobSupport also on.
540
541         * Scripts/build-webkit:
542
543 2011-11-17  Adam Roben  <aroben@apple.com>
544
545         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
546
547         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
548         that are supposed to be ignored
549
550         Reviewed by Adam Barth.
551
552         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
553         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
554         required when passing arguments via the shell (which we aren't doing here). It is not
555         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
556
557         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
558         (LeakDetectorTest.test_leaks_args): Updated expectations.
559
560 2011-11-17  Philippe Normand  <pnormand@igalia.com>
561
562         Unreviewed, run-bindings-tests fix after r91028.
563
564         * Scripts/run-bindings-tests: Use scm.detection module.
565
566 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
567
568         Silence a warning about control reaching the end of a non-void function
569         https://bugs.webkit.org/show_bug.cgi?id=72616
570
571         Reviewed by Tony Gentilcore.
572
573         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
574         (AccessibilityUIElement::verticalScrollbar):
575
576 2011-11-17  Adam Roben  <aroben@apple.com>
577
578         Ignore some leaks in frameworks we link against on Lion
579
580         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
581         aren't WebKit's fault
582
583         Reviewed by Antti Koivisto.
584
585         * Scripts/old-run-webkit-tests:
586         (countAndPrintLeaks):
587         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
588         (LeakDetector._callstacks_to_exclude_from_leaks):
589         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
590
591         * Scripts/webkitpy/layout_tests/port/mac.py:
592         (MacPort.is_lion): Added.
593
594         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
595         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
596         methods.
597
598 2011-11-17  Philippe Normand  <pnormand@igalia.com>
599
600         [GTK] Disable ref tests
601         https://bugs.webkit.org/show_bug.cgi?id=72599
602
603         Reviewed by Xan Lopez.
604
605         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
606         tests to avoid massive flakiness.
607
608 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
609
610         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
611
612         A new extension object has been added to QQuickWebView (the same approach should be used
613         for other API classes that need experimental APIs). The QML extension mechanism is then
614         built on top of the experimental object.
615
616         https://bugs.webkit.org/show_bug.cgi?id=72522
617
618         Reviewed by Simon Hausmann.
619
620         * MiniBrowser/qt/BrowserWindow.cpp:
621         (BrowserWindow::BrowserWindow):
622         (BrowserWindow::webView):
623         * MiniBrowser/qt/BrowserWindow.h:
624         * MiniBrowser/qt/UrlLoader.cpp:
625         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
626         * qmake/mkspecs/features/default_post.prf:
627         * qmake/mkspecs/features/default_pre.prf:
628         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
629         * qmake/mkspecs/features/qtwebkit.prf:
630
631 2011-11-17  Adam Barth  <abarth@webkit.org>
632
633         Move test_results_uploader.py out of layout_package
634         https://bugs.webkit.org/show_bug.cgi?id=72590
635
636         Reviewed by Eric Seidel.
637
638         Most of the lines of code in this file are wrong, but I've restrained
639         myself and only changed a few of them to generalized this class to the
640         common package.
641
642         This is part of a series of patches to remove layout_package.
643
644         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
645         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
646         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
647
648 2011-11-17  Adam Barth  <abarth@webkit.org>
649
650         Unreviewed. Fix style nits in printing.py.
651
652         * Scripts/webkitpy/layout_tests/views/printing.py:
653
654 2011-11-17  Adam Barth  <abarth@webkit.org>
655
656         Minor style nits in run_webkit_tests.py
657         https://bugs.webkit.org/show_bug.cgi?id=72583
658
659         Reviewed by Eric Seidel.
660
661         This patch just fixes some minor style issues as I work my way back
662         into this code.
663
664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
665
666 2011-11-17  Adam Barth  <abarth@webkit.org>
667
668         Move test_result_writer out of layout_package
669         https://bugs.webkit.org/show_bug.cgi?id=72586
670
671         Rubber-stamped by Eric Seidel.
672
673         This is part of a series of patches to remove layout_package.
674
675         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
676         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
677         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
678         * Scripts/webkitpy/tool/commands/rebaseline.py:
679
680 2011-11-17  Adam Barth  <abarth@webkit.org>
681
682         svn-apply shouldn't magically move files into Source anymore
683         https://bugs.webkit.org/show_bug.cgi?id=72579
684
685         Reviewed by Eric Seidel.
686
687         The Source directory has existed for long enough that we don't need
688         svn-apply to magically re-write old-style patches anymore.
689
690         * Scripts/VCSUtils.pm:
691         (parseGitDiffHeader):
692         (parseSvnDiffHeader):
693
694 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
695
696         Add a list of contribution areas
697         https://bugs.webkit.org/show_bug.cgi?id=72566
698
699         Reviewed by Eric Seidel.
700
701         Added ContributionAreas class.
702
703         * Scripts/webkitpy/common/config/contributionareas.py: Added.
704         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
705
706 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
707
708         Refactor ChangeLogTest.test_parse_reviewer_text
709         https://bugs.webkit.org/show_bug.cgi?id=72572
710
711         Reviewed by Eric Seidel.
712
713         Refactored the test code by introduing two helper functions.
714
715         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
716
717 2011-11-16  Eric Seidel  <eric@webkit.org>
718
719         Add SCMDetector object to make scm detection mockable
720         https://bugs.webkit.org/show_bug.cgi?id=72247
721
722         Reviewed by Adam Barth.
723
724         I think SCM detection may eventually be rolled into Checkout,
725         but this patch at least makes it possible to mock code-paths
726         which rely on scm detection.
727         In the process of replacing callers of these free-functions
728         I found that one of the functions was no longer used,
729         and that one of the callers could instead just use the SCM
730         object it already had access to through port.host.scm().
731         I also discovered that I was not calling Host._initialize_scm()
732         and thus host.scm() was always returning None!
733
734         * Scripts/check-webkit-style:
735         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
736         * Scripts/webkitpy/common/checkout/deps.py:
737         * Scripts/webkitpy/common/checkout/scm/__init__.py:
738         * Scripts/webkitpy/common/checkout/scm/detection.py:
739         * Scripts/webkitpy/common/checkout/scm/git.py:
740         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
741         * Scripts/webkitpy/common/checkout/scm/svn.py:
742         * Scripts/webkitpy/common/host.py:
743         * Scripts/webkitpy/common/host_mock.py:
744         * Scripts/webkitpy/layout_tests/controllers/manager.py:
745         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
746         * Scripts/webkitpy/layout_tests/port/base.py:
747         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
749         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
750         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
751
752 2011-11-16  Mark Rowe  <mrowe@apple.com>
753
754         Fix the build.
755
756         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
757         Apply the workaround that we use in other projects to WebKitTestRunner.
758
759         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
760         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
761         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
762
763 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
764
765         [Qt] Fix build after WTR AX support
766         https://bugs.webkit.org/show_bug.cgi?id=72560
767
768         Reviewed by Geoffrey Garen.
769
770         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
771         * WebKitTestRunner/InjectedBundle/Target.pri:
772
773 2011-11-16  Tony Chang  <tony@chromium.org>
774
775         repurpose the flexbox bot for grid layout
776         https://bugs.webkit.org/show_bug.cgi?id=72557
777
778         Reviewed by Ryosuke Niwa.
779
780         Since new flexbox is enabled everywhere, we don't need this bot
781         anymore.  However, work on grid layout has begun, so we can use this
782         bot to compile with ENABLE_CSS_GRID_LAYOUT.
783
784         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
785         the bot on the waterfall, I will change the slave config to enable
786         the compile flag and tests.
787
788 2011-11-11  Adrienne Walker  <enne@google.com>
789
790         [chromium] Expose mock scrollbars to window.internals
791         https://bugs.webkit.org/show_bug.cgi?id=72195
792
793         Reviewed by James Robinson.
794
795         Because mock scrollbars are a global setting, reset between runs.
796
797         * DumpRenderTree/chromium/WebPreferences.cpp:
798         (WebPreferences::applyTo):
799
800 2011-11-16  James Robinson  <jamesr@chromium.org>
801
802         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
803         https://bugs.webkit.org/show_bug.cgi?id=72562
804
805         Reviewed by Dirk Pranke.
806
807         * DumpRenderTree/chromium/TestShell.cpp:
808         (TestShell::runFileTest):
809
810 2011-11-16  Tony Chang  <tony@chromium.org>
811
812         [NRWT] speculative fix for multiple subprocess test on cygwin
813         https://bugs.webkit.org/show_bug.cgi?id=72518
814
815         Reviewed by Adam Barth.
816
817         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
818             tries to emulate posix fd behavior.
819         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
820
821 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
822
823         Revert r100509; change was committed twice (first time as r100491).
824         Unreviewed, build fix.
825
826         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
827
828 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
829
830         Run a dummy test in the gpu configurations if there's nothing to do.
831         https://bugs.webkit.org/show_bug.cgi?id=72498
832
833         Reviewed by James Robinson.
834
835         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
836
837 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
838
839         contributors_by_fuzzy_match is super slow
840         https://bugs.webkit.org/show_bug.cgi?id=72540
841
842         Reviewed by Eric Seidel.
843
844         Make contributors_by_name do case insensitive search using a dictionary.
845
846         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
847         because that's the most common case.
848
849         * Scripts/webkitpy/common/config/committers.py:
850         * Scripts/webkitpy/common/config/committers_unittest.py:
851
852 2011-11-16  David Levin  <levin@chromium.org>
853
854         check-webkit-style should recognize functions even if they have OVERRIDE after them.
855         https://bugs.webkit.org/show_bug.cgi?id=72515
856
857         Reviewed by Adam Barth.
858
859         * Scripts/webkitpy/style/checkers/cpp.py:
860         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
861
862 2011-11-16  Tony Chang  <tony@chromium.org>
863
864         [NRWT] refactor drivers to require pixel_tests param
865         https://bugs.webkit.org/show_bug.cgi?id=72517
866
867         Reviewed by Ojan Vafai.
868
869         No tests, just a refactoring.
870
871         * Scripts/webkitpy/layout_tests/port/chromium.py:
872         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
873         * Scripts/webkitpy/layout_tests/port/webkit.py:
874         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
875
876 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
877
878         Run a dummy test in the gpu configurations if there's nothing to do.
879         https://bugs.webkit.org/show_bug.cgi?id=72498
880
881         Reviewed by James Robinson.
882
883         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
884
885 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
886
887         WebKitTestRunner needs to support accessibility-related DRT APIs
888         https://bugs.webkit.org/show_bug.cgi?id=42131
889
890         Reviewed by Beth Dakin.
891
892         Port the AX code in DRT to WKTestRunner by using IDL.
893
894         * DumpRenderTree/AccessibilityUIElement.cpp:
895         (horizontalScrollbarCallback):
896         (verticalScrollbarCallback):
897         (AccessibilityUIElement::horizontalScrollbar):
898         (AccessibilityUIElement::verticalScrollbar):
899         (AccessibilityUIElement::getJSClass):
900         * DumpRenderTree/AccessibilityUIElement.h:
901         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
902         (AccessibilityUIElement::horizontalScrollbar):
903         (AccessibilityUIElement::verticalScrollbar):
904         * WebKitTestRunner/DerivedSources.make:
905         * WebKitTestRunner/GNUmakefile.am:
906         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
907         (WTR::AccessibilityController::create):
908         (WTR::AccessibilityController::AccessibilityController):
909         (WTR::AccessibilityController::~AccessibilityController):
910         (WTR::AccessibilityController::makeWindowObject):
911         (WTR::AccessibilityController::wrapperClass):
912         (WTR::AccessibilityController::rootElement):
913         (WTR::AccessibilityController::focusedElement):
914         (WTR::AccessibilityController::elementAtPoint):
915         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
916         (WTR::AccessibilityController::logFocusEvents):
917         (WTR::AccessibilityController::logValueChangeEvents):
918         (WTR::AccessibilityController::logScrollingStartEvents):
919         (WTR::AccessibilityController::logAccessibilityEvents):
920         (WTR::AccessibilityController::addNotificationListener):
921         (WTR::AccessibilityController::notificationReceived):
922         (WTR::AccessibilityController::resetToConsistentState):
923         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
924         (WTR::AccessibilityTextMarker::create):
925         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
926         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
927         (WTR::AccessibilityTextMarker::platformTextMarker):
928         (WTR::AccessibilityTextMarker::wrapperClass):
929         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
930         (WTR::AccessibilityTextMarker::isEqual):
931         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
932         (WTR::AccessibilityTextMarkerRange::create):
933         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
934         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
935         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
936         (WTR::AccessibilityTextMarkerRange::wrapperClass):
937         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
938         (WTR::AccessibilityTextMarkerRange::isEqual):
939         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
940         (WTR::AccessibilityUIElement::create):
941         (WTR::AccessibilityUIElement::wrapperClass):
942         (WTR::AccessibilityUIElement::isValid):
943         (WTR::AccessibilityUIElement::AccessibilityUIElement):
944         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
945         (WTR::AccessibilityUIElement::isEqual):
946         (WTR::AccessibilityUIElement::elementAtPoint):
947         (WTR::AccessibilityUIElement::childAtIndex):
948         (WTR::AccessibilityUIElement::indexOfChild):
949         (WTR::AccessibilityUIElement::childrenCount):
950         (WTR::AccessibilityUIElement::titleUIElement):
951         (WTR::AccessibilityUIElement::parentElement):
952         (WTR::AccessibilityUIElement::takeFocus):
953         (WTR::AccessibilityUIElement::takeSelection):
954         (WTR::AccessibilityUIElement::addSelection):
955         (WTR::AccessibilityUIElement::removeSelection):
956         (WTR::AccessibilityUIElement::allAttributes):
957         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
958         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
959         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
960         (WTR::AccessibilityUIElement::attributesOfChildren):
961         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
962         (WTR::AccessibilityUIElement::increment):
963         (WTR::AccessibilityUIElement::decrement):
964         (WTR::AccessibilityUIElement::showMenu):
965         (WTR::AccessibilityUIElement::press):
966         (WTR::AccessibilityUIElement::stringAttributeValue):
967         (WTR::AccessibilityUIElement::uiElementAttributeValue):
968         (WTR::AccessibilityUIElement::numberAttributeValue):
969         (WTR::AccessibilityUIElement::boolAttributeValue):
970         (WTR::AccessibilityUIElement::isAttributeSupported):
971         (WTR::AccessibilityUIElement::isAttributeSettable):
972         (WTR::AccessibilityUIElement::isActionSupported):
973         (WTR::AccessibilityUIElement::role):
974         (WTR::AccessibilityUIElement::subrole):
975         (WTR::AccessibilityUIElement::roleDescription):
976         (WTR::AccessibilityUIElement::title):
977         (WTR::AccessibilityUIElement::description):
978         (WTR::AccessibilityUIElement::language):
979         (WTR::AccessibilityUIElement::stringValue):
980         (WTR::AccessibilityUIElement::accessibilityValue):
981         (WTR::AccessibilityUIElement::helpText):
982         (WTR::AccessibilityUIElement::orientation):
983         (WTR::AccessibilityUIElement::x):
984         (WTR::AccessibilityUIElement::y):
985         (WTR::AccessibilityUIElement::width):
986         (WTR::AccessibilityUIElement::height):
987         (WTR::AccessibilityUIElement::intValue):
988         (WTR::AccessibilityUIElement::minValue):
989         (WTR::AccessibilityUIElement::maxValue):
990         (WTR::AccessibilityUIElement::valueDescription):
991         (WTR::AccessibilityUIElement::insertionPointLineNumber):
992         (WTR::AccessibilityUIElement::selectedTextRange):
993         (WTR::AccessibilityUIElement::isEnabled):
994         (WTR::AccessibilityUIElement::isRequired):
995         (WTR::AccessibilityUIElement::isFocused):
996         (WTR::AccessibilityUIElement::isFocusable):
997         (WTR::AccessibilityUIElement::isSelected):
998         (WTR::AccessibilityUIElement::isSelectable):
999         (WTR::AccessibilityUIElement::isMultiSelectable):
1000         (WTR::AccessibilityUIElement::setSelectedChild):
1001         (WTR::AccessibilityUIElement::selectedChildrenCount):
1002         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1003         (WTR::AccessibilityUIElement::isExpanded):
1004         (WTR::AccessibilityUIElement::isChecked):
1005         (WTR::AccessibilityUIElement::isVisible):
1006         (WTR::AccessibilityUIElement::isOffScreen):
1007         (WTR::AccessibilityUIElement::isCollapsed):
1008         (WTR::AccessibilityUIElement::isIgnored):
1009         (WTR::AccessibilityUIElement::hasPopup):
1010         (WTR::AccessibilityUIElement::hierarchicalLevel):
1011         (WTR::AccessibilityUIElement::clickPointX):
1012         (WTR::AccessibilityUIElement::clickPointY):
1013         (WTR::AccessibilityUIElement::documentEncoding):
1014         (WTR::AccessibilityUIElement::documentURI):
1015         (WTR::AccessibilityUIElement::url):
1016         (WTR::AccessibilityUIElement::speak):
1017         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1018         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1019         (WTR::AccessibilityUIElement::attributesOfColumns):
1020         (WTR::AccessibilityUIElement::attributesOfRows):
1021         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1022         (WTR::AccessibilityUIElement::attributesOfHeader):
1023         (WTR::AccessibilityUIElement::indexInTable):
1024         (WTR::AccessibilityUIElement::rowIndexRange):
1025         (WTR::AccessibilityUIElement::columnIndexRange):
1026         (WTR::AccessibilityUIElement::rowCount):
1027         (WTR::AccessibilityUIElement::columnCount):
1028         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1029         (WTR::AccessibilityUIElement::disclosedByRow):
1030         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1031         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1032         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1033         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1034         (WTR::AccessibilityUIElement::ariaDropEffects):
1035         (WTR::AccessibilityUIElement::lineForIndex):
1036         (WTR::AccessibilityUIElement::rangeForLine):
1037         (WTR::AccessibilityUIElement::boundsForRange):
1038         (WTR::AccessibilityUIElement::setSelectedTextRange):
1039         (WTR::AccessibilityUIElement::stringForRange):
1040         (WTR::AccessibilityUIElement::attributedStringForRange):
1041         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1042         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1043         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1044         (WTR::AccessibilityUIElement::horizontalScrollbar):
1045         (WTR::AccessibilityUIElement::verticalScrollbar):
1046         (WTR::AccessibilityUIElement::addNotificationListener):
1047         (WTR::AccessibilityUIElement::removeNotificationListener):
1048         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1049         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1050         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1051         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1052         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1053         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1054         (WTR::AccessibilityUIElement::textMarkerForPoint):
1055         (WTR::AccessibilityUIElement::previousTextMarker):
1056         (WTR::AccessibilityUIElement::nextTextMarker):
1057         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1058         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1059         (WTR::AccessibilityUIElement::platformUIElement):
1060         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1061         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1062         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1063         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1064         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1066         (WTR::InjectedBundle::beginTesting):
1067         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1068         (WTR::InjectedBundle::accessibilityController):
1069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1070         (WTR::InjectedBundlePage::didClearWindowForFrame):
1071         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1072         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1073         (WTR::LayoutTestController::platformName):
1074         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1075         (WTR::AccessibilityTextMarker::isEqual):
1076         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1077         (WTR::AccessibilityTextMarkerRange::isEqual):
1078         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1079         (+[NSString stringWithJSStringRef:]):
1080         (-[NSString createJSStringRef]):
1081         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1082         (-[AccessibilityNotificationHandler dealloc]):
1083         (-[AccessibilityNotificationHandler _notificationReceived:]):
1084         (-[AccessibilityNotificationHandler setCallback:]):
1085         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1086         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1087         (WTR::AccessibilityUIElement::isEqual):
1088         (WTR::descriptionOfValue):
1089         (WTR::attributesOfElement):
1090         (WTR::concatenateAttributeAndValue):
1091         (WTR::convertNSArrayToVector):
1092         (WTR::descriptionOfElements):
1093         (WTR::AccessibilityUIElement::getLinkedUIElements):
1094         (WTR::AccessibilityUIElement::getDocumentLinks):
1095         (WTR::AccessibilityUIElement::getChildren):
1096         (WTR::AccessibilityUIElement::getChildrenWithRange):
1097         (WTR::AccessibilityUIElement::childrenCount):
1098         (WTR::AccessibilityUIElement::elementAtPoint):
1099         (WTR::AccessibilityUIElement::indexOfChild):
1100         (WTR::AccessibilityUIElement::childAtIndex):
1101         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1102         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1103         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1104         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1105         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1106         (WTR::AccessibilityUIElement::selectedChildrenCount):
1107         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1108         (WTR::AccessibilityUIElement::titleUIElement):
1109         (WTR::AccessibilityUIElement::parentElement):
1110         (WTR::AccessibilityUIElement::disclosedByRow):
1111         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1112         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1113         (WTR::AccessibilityUIElement::attributesOfChildren):
1114         (WTR::AccessibilityUIElement::allAttributes):
1115         (WTR::AccessibilityUIElement::stringAttributeValue):
1116         (WTR::AccessibilityUIElement::numberAttributeValue):
1117         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1118         (WTR::AccessibilityUIElement::boolAttributeValue):
1119         (WTR::AccessibilityUIElement::isAttributeSettable):
1120         (WTR::AccessibilityUIElement::isAttributeSupported):
1121         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1122         (WTR::AccessibilityUIElement::role):
1123         (WTR::AccessibilityUIElement::subrole):
1124         (WTR::AccessibilityUIElement::roleDescription):
1125         (WTR::AccessibilityUIElement::title):
1126         (WTR::AccessibilityUIElement::description):
1127         (WTR::AccessibilityUIElement::orientation):
1128         (WTR::AccessibilityUIElement::stringValue):
1129         (WTR::AccessibilityUIElement::language):
1130         (WTR::AccessibilityUIElement::helpText):
1131         (WTR::AccessibilityUIElement::x):
1132         (WTR::AccessibilityUIElement::y):
1133         (WTR::AccessibilityUIElement::width):
1134         (WTR::AccessibilityUIElement::height):
1135         (WTR::AccessibilityUIElement::clickPointX):
1136         (WTR::AccessibilityUIElement::clickPointY):
1137         (WTR::AccessibilityUIElement::intValue):
1138         (WTR::AccessibilityUIElement::minValue):
1139         (WTR::AccessibilityUIElement::maxValue):
1140         (WTR::AccessibilityUIElement::valueDescription):
1141         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1142         (WTR::AccessibilityUIElement::isActionSupported):
1143         (WTR::AccessibilityUIElement::isEnabled):
1144         (WTR::AccessibilityUIElement::isRequired):
1145         (WTR::AccessibilityUIElement::isFocused):
1146         (WTR::AccessibilityUIElement::isSelected):
1147         (WTR::AccessibilityUIElement::isExpanded):
1148         (WTR::AccessibilityUIElement::isChecked):
1149         (WTR::AccessibilityUIElement::hierarchicalLevel):
1150         (WTR::AccessibilityUIElement::speak):
1151         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1152         (WTR::AccessibilityUIElement::ariaDropEffects):
1153         (WTR::AccessibilityUIElement::lineForIndex):
1154         (WTR::AccessibilityUIElement::rangeForLine):
1155         (WTR::AccessibilityUIElement::boundsForRange):
1156         (WTR::AccessibilityUIElement::stringForRange):
1157         (WTR::AccessibilityUIElement::attributedStringForRange):
1158         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1159         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1160         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1161         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1162         (WTR::AccessibilityUIElement::attributesOfColumns):
1163         (WTR::AccessibilityUIElement::attributesOfRows):
1164         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1165         (WTR::AccessibilityUIElement::attributesOfHeader):
1166         (WTR::AccessibilityUIElement::rowCount):
1167         (WTR::AccessibilityUIElement::columnCount):
1168         (WTR::AccessibilityUIElement::indexInTable):
1169         (WTR::AccessibilityUIElement::rowIndexRange):
1170         (WTR::AccessibilityUIElement::columnIndexRange):
1171         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1172         (WTR::AccessibilityUIElement::horizontalScrollbar):
1173         (WTR::AccessibilityUIElement::verticalScrollbar):
1174         (WTR::AccessibilityUIElement::selectedTextRange):
1175         (WTR::AccessibilityUIElement::setSelectedTextRange):
1176         (WTR::AccessibilityUIElement::increment):
1177         (WTR::AccessibilityUIElement::decrement):
1178         (WTR::AccessibilityUIElement::showMenu):
1179         (WTR::AccessibilityUIElement::press):
1180         (WTR::AccessibilityUIElement::setSelectedChild):
1181         (WTR::AccessibilityUIElement::accessibilityValue):
1182         (WTR::AccessibilityUIElement::documentEncoding):
1183         (WTR::AccessibilityUIElement::documentURI):
1184         (WTR::AccessibilityUIElement::url):
1185         (WTR::AccessibilityUIElement::addNotificationListener):
1186         (WTR::AccessibilityUIElement::removeNotificationListener):
1187         (WTR::AccessibilityUIElement::isFocusable):
1188         (WTR::AccessibilityUIElement::isSelectable):
1189         (WTR::AccessibilityUIElement::isMultiSelectable):
1190         (WTR::AccessibilityUIElement::isVisible):
1191         (WTR::AccessibilityUIElement::isOffScreen):
1192         (WTR::AccessibilityUIElement::isCollapsed):
1193         (WTR::AccessibilityUIElement::isIgnored):
1194         (WTR::AccessibilityUIElement::hasPopup):
1195         (WTR::AccessibilityUIElement::takeFocus):
1196         (WTR::AccessibilityUIElement::takeSelection):
1197         (WTR::AccessibilityUIElement::addSelection):
1198         (WTR::AccessibilityUIElement::removeSelection):
1199         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1200         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1201         (WTR::AccessibilityUIElement::previousTextMarker):
1202         (WTR::AccessibilityUIElement::nextTextMarker):
1203         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1204         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1205         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1206         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1207         (WTR::AccessibilityUIElement::textMarkerForPoint):
1208         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1209         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1210         (WTR::LayoutTestController::platformName):
1211         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1212         (WTR::LayoutTestController::platformName):
1213         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1214         (WTR::LayoutTestController::platformName):
1215         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1216         * WebKitTestRunner/win/InjectedBundle.vcproj:
1217
1218 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1219
1220         [Qt] Fix use of config.tests
1221
1222         We were checking @buildArgs to determine if the optional argument was
1223         passed or not, but this is not the right way to do that in Perl. The
1224         right way is to not use a prototype for the function, and to pass
1225         the list as a reference (to avoid list expansion). That way we can
1226         check the number of arguments, and choose the right code path based
1227         on that.
1228
1229         We were also missing a default-value of 0 for any feature that's not
1230         set in features.prf.
1231
1232         Reviewed by Kenneth Rohde Christiansen.
1233
1234         * Scripts/build-webkit:
1235         * Scripts/webkitdirs.pm:
1236         (qtFeatureDefaults):
1237         (buildQMakeProject):
1238
1239 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1240
1241         [Qt] Prospective fix for broken plugin tests
1242
1243         Don't hide symbols for the NPAPI test plugin
1244
1245         Rubber-stamped by Andreas Kling.
1246
1247         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1248
1249 2011-11-16  Adam Roben  <aroben@apple.com>
1250
1251         Move filenames/line numbers off to the right edge in Leaks Viewer
1252
1253         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1254         because filenames/line numbers are right next to function names
1255
1256         Reviewed by Andreas Kling.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1259         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1260         function name. Use the filename as the profile node's URL (we don't have enough info to
1261         compute a real URL currently) and the line number as the profile node's line number so the
1262         Inspector code will put them on the right side of the callstack graph.
1263
1264         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1265         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1266         passed here, just filenames.
1267
1268         (WebInspector.linkifyURLAsNode):
1269         (WebInspector.linkifyResourceAsNode):
1270         Copied and slightly modified from inspector.js.
1271
1272 2011-11-16  Adam Roben  <aroben@apple.com>
1273
1274         Make Leaks Viewer load builds from the new Lion Leaks bot
1275
1276         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1277
1278         Reviewed by Andreas Kling.
1279
1280         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1281         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1282         SnowLeopard one.
1283
1284 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1285
1286         [EFL] Clean up the offline apps-related functions in ewk_settings.
1287         https://bugs.webkit.org/show_bug.cgi?id=72132
1288
1289         Reviewed by Kenneth Rohde Christiansen.
1290
1291         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1292         prefixes for code that is related only to the HTML5 app cache
1293         features.
1294
1295         Use `ewk_settings_application_cache' and
1296         `ewk_view_setting_application_cache' instead.
1297
1298         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1299         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1300
1301 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1302
1303         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1304
1305         Reviewed by Tor Arne Vestbø.
1306
1307         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1308         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1309         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1310         removes the .so.0.0.0 and just produces .so.
1311
1312 2011-11-16  Peter Beverloo  <peter@chromium.org>
1313
1314         Explicitly include unistd.h in TestNetscapePlugIn
1315         https://bugs.webkit.org/show_bug.cgi?id=72385
1316
1317         This is needed for the sleep() call in the indicateTestFailure method,
1318         which seems to be implicitly available for other platforms. This is not
1319         the case on Android.
1320
1321         Reviewed by Steve Block.
1322
1323         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1324
1325 2011-11-16  Peter Beverloo  <peter@chromium.org>
1326
1327         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1328         https://bugs.webkit.org/show_bug.cgi?id=72384
1329
1330         Update to Android NDK r7, which was released last Friday. This adds
1331         support for RTTI and the -mimplicit-it gcc flag, which are required to
1332         respectively build ICU and Skia.
1333
1334         Reviewed by Steve Block.
1335
1336         * Scripts/update-webkit-chromium:
1337         * Scripts/webkitdirs.pm:
1338         (buildChromiumMakefile):
1339
1340 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1341
1342         Unreviewed, rolling out r100266.
1343         http://trac.webkit.org/changeset/100266
1344
1345         Broke WTR.
1346
1347         * qmake/mkspecs/features/default_post.prf:
1348
1349 2011-11-16  Eric Seidel  <eric@webkit.org>
1350
1351         check-webkit-style broken by r99773: "Could not determine the port"
1352         https://bugs.webkit.org/show_bug.cgi?id=72275
1353
1354         Reviewed by Adam Barth.
1355
1356         I will continue engaging hacks, until windows improves.
1357
1358         * Scripts/webkitpy/common/host.py:
1359          - Host uses self.executive instead of self._executive like Port does.
1360          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1361
1362 2011-11-16  Eric Seidel  <eric@webkit.org>
1363
1364         check-webkit-style broken by r99773: "Could not determine the port"
1365         https://bugs.webkit.org/show_bug.cgi?id=72275
1366
1367         Reviewed by Adam Barth.
1368
1369         Engage windows hacks harder.
1370
1371         This is a speculative fix for ChromiumWin.  We're now
1372         creating an SCM object much earlier, so we need to
1373         engage our "awesome" windows hacks earlier.
1374
1375         * Scripts/webkitpy/common/host.py:
1376         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1377
1378 2011-11-15  Darin Adler  <darin@apple.com>
1379
1380         DRT's uiElementAttributeValueCallback function is leaky
1381         https://bugs.webkit.org/show_bug.cgi?id=72453
1382
1383         Reviewed by Dan Bernstein.
1384
1385         * DumpRenderTree/AccessibilityUIElement.cpp:
1386         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1387
1388 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1389
1390         Implement edit-distance based reviewer recognition algorithm
1391         https://bugs.webkit.org/show_bug.cgi?id=72351
1392
1393         Reviewed by Eric Seidel.
1394
1395         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1396         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1397         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1398         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1399
1400         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1401         the edit distance is implemented in edit_distance.py.
1402
1403         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1404         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1405
1406         * Scripts/webkitpy/common/checkout/changelog.py:
1407         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1408         * Scripts/webkitpy/common/config/committers.py:
1409         * Scripts/webkitpy/common/config/committers_unittest.py:
1410         * Scripts/webkitpy/common/editdistance.py: Added.
1411         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1412         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1413         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1414
1415 2011-11-15  Tony Chang  <tony@chromium.org>
1416
1417         Skip a failing webkitpy test on cygwin.
1418
1419         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1420
1421 2011-11-15  Sam Weinig  <sam@webkit.org>
1422
1423         TestWebKitAPI should not put its resources in the root products directory
1424         https://bugs.webkit.org/show_bug.cgi?id=72446
1425
1426         Reviewed by Anders Carlsson.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1430         directory.
1431
1432         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1433         (TEST_F):
1434         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1435         (TestWebKitAPI::TEST):
1436         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1437         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1438         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1439         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1440         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1441         (TestWebKitAPI::Util::createURLForResource):
1442         Update calls to retrieve files from the bundle to look in the newly
1443         created subdirectory.
1444
1445 2011-11-15  Tony Chang  <tony@chromium.org>
1446
1447         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1448
1449         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1450
1451 2011-11-15  Tony Chang  <tony@chromium.org>
1452
1453         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1454         earlier.
1455
1456         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1457         * Scripts/webkitpy/layout_tests/port/webkit.py:
1458
1459 2011-11-15  James Robinson  <jamesr@chromium.org>
1460
1461         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1462         https://bugs.webkit.org/show_bug.cgi?id=72444
1463
1464         Reviewed by Adam Barth.
1465
1466         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1467
1468 2011-11-15  Tony Chang  <tony@chromium.org>
1469
1470         Unreviewed, better fix for ref tests failures on SL Intel bot.
1471         Revert the previous change and return None if pixel results from
1472         either the test page or the expected page is missing.
1473
1474         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1475         * Scripts/webkitpy/layout_tests/port/webkit.py:
1476
1477 2011-11-15  James Robinson  <jamesr@chromium.org>
1478
1479         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1480         https://bugs.webkit.org/show_bug.cgi?id=72402
1481
1482         Reviewed by Dirk Pranke.
1483
1484         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1485         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1486         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1487         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1488         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1489         compositing enabled.
1490
1491         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1492         patch should not impact any tests.
1493
1494         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1495         (main):
1496         * DumpRenderTree/chromium/TestShell.cpp:
1497         (TestShell::TestShell):
1498         (TestShell::resetWebSettings):
1499         * DumpRenderTree/chromium/TestShell.h:
1500         (TestShell::setAcceleratedCompositingForVideoEnabled):
1501         * DumpRenderTree/chromium/WebPreferences.cpp:
1502         (WebPreferences::reset):
1503         (WebPreferences::applyTo):
1504         * DumpRenderTree/chromium/WebPreferences.h:
1505         * Scripts/webkitpy/layout_tests/port/chromium.py:
1506         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1507         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1508
1509 2011-11-15  Tony Chang  <tony@chromium.org>
1510
1511         Unreviewed, try to fix ref tests failures on SL Intel bot.
1512         It looks like ImageDiff isn't returning an image diff.
1513
1514         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1515
1516 2011-11-15  Tony Chang  <tony@chromium.org>
1517
1518         Unreviewed fix of ref-tests on GTK+.
1519         If a driver is never started, _xvfb_process is never set.
1520
1521         * Scripts/webkitpy/layout_tests/port/gtk.py:
1522
1523 2011-11-14  Tony Chang  <tony@chromium.org>
1524
1525         [NRWT] Reftests should run even when pixel tests are disabled.
1526         https://bugs.webkit.org/show_bug.cgi?id=60605
1527
1528         Reviewed by Dirk Pranke.
1529
1530         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1531             Also add an assert to make sure we get image hashes back when running ref tests.
1532         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1533         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1534         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1535         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1536             of starting a pixel driver if needed.  It handles the logic of sending the test
1537             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1538         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1539         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1540         * Scripts/webkitpy/layout_tests/port/webkit.py:
1541         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1542         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1543
1544 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1545
1546         Don't use File::Slurp for run-leaks unit tests
1547         <http://webkit.org/b/72356>
1548
1549         Reviewed by Daniel Bates.
1550
1551         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1552         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1553         Extracted common package logic into RunLeaks.pm.  Fixed call to
1554         RunLeaks::parseLeaksOutput().
1555         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1556         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1557
1558 2011-11-15  Peter Kasting  <pkasting@google.com>
1559
1560         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1561         https://bugs.webkit.org/show_bug.cgi?id=72349
1562
1563         Reviewed by Adam Roben.
1564
1565         * Scripts/VCSUtils.pm:
1566         (isSVNDirectory):
1567
1568 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1569
1570         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1571
1572         Reviewed by Tor Arne Vestbø.
1573
1574         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1575         magic here where we handle all TEMPLATE = lib .pro files.
1576
1577 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1578
1579         [Qt] Unreviewed prospective --minimal build fix.
1580
1581         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1582         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1583
1584 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1585
1586         [Qt] Unreviewed --minimal build fix.
1587
1588         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1589         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1590         to make moc's preprocessor abort.
1591
1592 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1593
1594         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1595         https://bugs.webkit.org/show_bug.cgi?id=72156
1596
1597         Reviewed by Daniel Bates.
1598
1599         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1600         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1601
1602         * Scripts/build-webkit:
1603         * Scripts/webkitdirs.pm:
1604         (generateBuildSystemFromCMakeProject):
1605
1606 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1607
1608         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1609         https://bugs.webkit.org/show_bug.cgi?id=72340
1610
1611         Reviewed by Eric Seidel.
1612
1613         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1614         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1615
1616         * Scripts/webkitpy/common/checkout/changelog.py:
1617         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1618
1619 2011-11-14  Eric Seidel  <eric@webkit.org>
1620
1621         check-webkit-style broken by r99773: "Could not determine the port"
1622         https://bugs.webkit.org/show_bug.cgi?id=72275
1623
1624         Reviewed by Adam Barth.
1625
1626         The TestExpectationsChecker was using a generic try/except block
1627         which caught all exceptions, so we didn't notice that failing
1628         to pass a Host to PortFactory was causing an exception in port instantiation.
1629         I've factored out the "lookup the port" logic into a separate function
1630         which I've now unittested.  This should fix the bug and prevent
1631         others like it from occuring the the future.
1632
1633         * Scripts/webkitpy/style/checkers/test_expectations.py:
1634         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1635
1636 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1637
1638         Add --css-grid-layout to build-webkit and the build systems
1639         https://bugs.webkit.org/show_bug.cgi?id=72320
1640
1641         Reviewed by Ojan Vafai.
1642
1643         * Scripts/build-webkit:
1644         Added the option.
1645
1646 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1647
1648         Unreviewed, rolling out r100192.
1649         http://trac.webkit.org/changeset/100192
1650         https://bugs.webkit.org/show_bug.cgi?id=72328
1651
1652         Caused infinite tests to fail (Requested by abarth on
1653         #webkit).
1654
1655         * Scripts/webkitpy/layout_tests/port/base.py:
1656         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1657
1658 2011-11-14  Tony Chang  <tony@chromium.org>
1659
1660         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1661         https://bugs.webkit.org/show_bug.cgi?id=72196
1662
1663         Reviewed by Ojan Vafai.
1664
1665         * Scripts/build-webkit:
1666
1667 2011-11-14  John Yani  <vanuan@gmail.com>
1668
1669         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1670         Override LOCALE to en_US.
1671
1672         Reviewed by Eric Seidel.
1673
1674         * Scripts/webkitpy/layout_tests/port/base.py:
1675
1676 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1677
1678         [Chromium] build-webkit silently drops the features flags
1679         https://bugs.webkit.org/show_bug.cgi?id=72293
1680
1681         Reviewed by Tony Chang.
1682
1683         Chromium still ignores @features but now we give a warning!
1684
1685         * Scripts/build-webkit: Check if one of the features is different
1686         from the default and print a warning in this case.
1687
1688 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1689
1690         run-leaks does not work on Lion?
1691         <http://webkit.org/b/71059>
1692         <rdar://problem/10428527>
1693
1694         Reviewed by Adam Roben.
1695
1696         The output of leaks(1) changed again in Lion to move the
1697         "leaks Report Version: 2.0" line from the first line of the
1698         output to just above the "Process " lines that run-leaks is
1699         interested in parsing.  This required using a more generic
1700         algorithm to find the start of the "Process " lines.
1701
1702         * Scripts/run-leaks:
1703         (parseLeaksOutput): Make the code to skip headers more generic.
1704         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1705         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1706         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1707
1708 2011-11-14  Lei Zhang  <thestig@chromium.org>
1709
1710         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1711         https://bugs.webkit.org/show_bug.cgi?id=72088
1712
1713         Reviewed by Tony Chang.
1714
1715         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1716
1717 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1718
1719         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1720         https://bugs.webkit.org/show_bug.cgi?id=72147
1721
1722         Reviewed by Adam Barth.
1723
1724         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1725
1726 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1727
1728         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1729
1730         Reviewed by Simon Hausmann.
1731
1732         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1733
1734 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1735
1736         [Qt] Disable plugins on X11 for WK2
1737
1738         Reviewed by Kenneth Rohde Christiansen.
1739
1740         Currently plugins are in-process and they crash in the likely case of
1741         a plugin installation that uses Qt 4, which beautifully clashes with the
1742         Qt 5 based QtWebProcess.
1743
1744         * qmake/mkspecs/features/features.prf:
1745
1746 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1747
1748         [Qt] Add support for config tests for Qt 5
1749
1750         This allows us to build and run configure-tests at build
1751         time to determine if a given platform feature is available.
1752
1753         Reviewed by Simon Hausmann.
1754
1755         * Scripts/build-webkit:
1756         * Scripts/webkitdirs.pm:
1757         (qtFeatureDefaults):
1758         * qmake/configure.pro: Added.
1759         * qmake/mkspecs/features/features.prf:
1760         * qmake/sync.profile: Added.
1761
1762 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1763
1764         [Qt] Remove the QStyle dependency in Qt's mobile theme
1765         https://bugs.webkit.org/show_bug.cgi?id=67773
1766
1767         This refactoring splits up RenderThemeQt with two
1768         subclasses, a QStyle-backed one, and a Mobile version
1769         that uses the old mobile theme for now.
1770
1771         QStyle availability is detected at compile time, and
1772         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1773         environment variable.
1774
1775         Reviewed by Simon Hausmann.
1776
1777         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1778         (WTR::activateFonts):
1779         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1780         based on availability of QtWidgets.
1781         * qmake/mkspecs/features/webcore.prf: cleanup.
1782
1783 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1784
1785         Unreviewed, rolling out r100116.
1786         http://trac.webkit.org/changeset/100116
1787
1788         r100104 was rolled out, so no longer needed
1789
1790         * Scripts/run-bindings-tests:
1791
1792 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1793
1794         Unreviewed, rolling out r100104.
1795         http://trac.webkit.org/changeset/100104
1796         https://bugs.webkit.org/show_bug.cgi?id=72247
1797
1798         broke windows builds
1799
1800         * Scripts/check-webkit-style:
1801         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1802         * Scripts/webkitpy/common/checkout/deps.py:
1803         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1804         * Scripts/webkitpy/common/checkout/scm/detection.py:
1805         * Scripts/webkitpy/common/checkout/scm/git.py:
1806         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1807         * Scripts/webkitpy/common/checkout/scm/svn.py:
1808         * Scripts/webkitpy/common/host.py:
1809         * Scripts/webkitpy/common/host_mock.py:
1810         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1811         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1812         * Scripts/webkitpy/layout_tests/port/base.py:
1813         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1814         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1815         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1816         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1817
1818 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1819
1820         Unreviewed, build fix after r100104. run-binding-tests broke.
1821
1822         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1823
1824 2011-11-13  Eric Seidel  <eric@webkit.org>
1825
1826         Add SCMDetector object to make scm detection mockable
1827         https://bugs.webkit.org/show_bug.cgi?id=72247
1828
1829         Reviewed by Adam Barth.
1830
1831         I think SCM detection may eventually be rolled into Checkout,
1832         but this patch at least makes it possible to mock code-paths
1833         which rely on scm detection.
1834         In the process of replacing callers of these free-functions
1835         I found that one of the functions was no longer used,
1836         and that one of the callers could instead just use the SCM
1837         object it already had access to through port.host.scm().
1838         I also discovered that I was not calling Host._initialize_scm()
1839         and thus host.scm() was always returning None!
1840
1841         * Scripts/check-webkit-style:
1842         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1843         * Scripts/webkitpy/common/checkout/deps.py:
1844         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1845         * Scripts/webkitpy/common/checkout/scm/detection.py:
1846         * Scripts/webkitpy/common/checkout/scm/git.py:
1847         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1848         * Scripts/webkitpy/common/checkout/scm/svn.py:
1849         * Scripts/webkitpy/common/host.py:
1850         * Scripts/webkitpy/common/host_mock.py:
1851         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1852         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1853         * Scripts/webkitpy/layout_tests/port/base.py:
1854         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1855         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1856         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1857         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1858
1859 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1860
1861         command line control of webcore log channels in chromium DumpRenderTree
1862         https://bugs.webkit.org/show_bug.cgi?id=72126
1863         
1864         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1865         what chromium takes.
1866
1867         Reviewed by Kent Tamura.
1868
1869         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1870         (main):
1871
1872 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1873
1874         [Qt] Fix minor config typo in the build tool documentation
1875         https://bugs.webkit.org/show_bug.cgi?id=72194
1876
1877         Reviewed by Andreas Kling.
1878
1879         * qmake/README:
1880
1881 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1882
1883         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1884         https://bugs.webkit.org/show_bug.cgi?id=49257
1885
1886         Adds the remaining missing layout test functionality for printing.
1887
1888         Reviewed by Darin Fisher.
1889
1890         * DumpRenderTree/chromium/LayoutTestController.cpp:
1891         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1892         (parsePageNumber): Method to parse JS arguments for a page number
1893         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1894         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1895         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1896         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1897         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1898
1899 2011-11-11  Darin Adler  <darin@apple.com>
1900
1901         Remove all releaseRef implementations except for RetainPtr
1902         https://bugs.webkit.org/show_bug.cgi?id=71423
1903
1904         Reviewed by Julien Chaffraix.
1905
1906         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1907         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1908
1909 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1910
1911         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1912         https://bugs.webkit.org/show_bug.cgi?id=72090
1913
1914         Reviewed by Eric Seidel.
1915
1916         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1917         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1918
1919         yay! r100002.
1920
1921         * Scripts/webkitpy/common/checkout/changelog.py:
1922         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1923
1924 2011-11-11  Tony Chang  <tony@chromium.org>
1925
1926         Remove --force from gclient sync.  The bots seem to have made it past
1927         the update step.
1928
1929         * Scripts/update-webkit:
1930
1931 2011-11-11  Tony Chang  <tony@chromium.org>
1932
1933         Add --force to gclient sync. Once the cq bots cycle, we can remove
1934         this since it slows down the normal sync.
1935
1936         * Scripts/update-webkit:
1937
1938 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1939
1940         When --force is used, also use --reset
1941         https://bugs.webkit.org/show_bug.cgi?id=72129
1942
1943         Reviewed by Dimitri Glazkov.
1944
1945         * Scripts/update-webkit-chromium:
1946
1947 2011-11-11  Tony Chang  <tony@chromium.org>
1948
1949         allow two chromium drivers to run at the same time in NRWT
1950         https://bugs.webkit.org/show_bug.cgi?id=72067
1951
1952         Reviewed by Dirk Pranke.
1953
1954         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1955             posix prevents the subprocesses from sharing the same fd for stdin.
1956             Sharing the same fd prevents us from closing the files unless all references
1957             to the fd are closed.
1958         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1959             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1960             the timeout override. It looks like it regressed in r95875.
1961
1962 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1963
1964         Unreviewed, rolling out r99964.
1965         http://trac.webkit.org/changeset/99964
1966         https://bugs.webkit.org/show_bug.cgi?id=72124
1967
1968         Broke too many Qt tests (Requested by tronical_ on #webkit).
1969
1970         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1971         (WTR::activateFonts):
1972         * qmake/mkspecs/features/features.prf:
1973         * qmake/mkspecs/features/webcore.prf:
1974
1975 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1976
1977         [Qt] Remove the QStyle dependency in Qt's mobile theme
1978         https://bugs.webkit.org/show_bug.cgi?id=67773
1979
1980         This refactoring splits up RenderThemeQt with two
1981         subclasses, a QStyle-backed one, and a Mobile version
1982         that uses the old mobile theme for now.
1983
1984         QStyle availability is detected at compile time, and
1985         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1986         environment variable.
1987
1988         Reviewed by Simon Hausmann.
1989
1990         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1991         (WTR::activateFonts):
1992         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1993         based on availability of QtWidgets.
1994         * qmake/mkspecs/features/webcore.prf: cleanup.
1995
1996 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1997
1998         [Qt] Add missing include to PlatformWebViewQt
1999
2000         Reviewed by Simon Hausmann.
2001
2002         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2003
2004 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2005
2006         [Qt] Fix incremental builds on Windows after buildsystem refactor
2007
2008         The qmake rules to ensure that we run make on the derived sources
2009         before running qmake on the target were inside a unix-scope, which
2010         resulted in flakey builds on Windows.
2011
2012         We now generate a rule on all platforms that ensures that "make qmake"
2013         will always run make on the derived sources. In addition, on platforms
2014         that have GNU make (where "make incremental" does not run "make qmake",
2015         but only "make"), we add a similar rule that ensures that any time the
2016         target makefile is regenerated we first run qmake and make on the derived
2017         sources. This rule relies on GNU make's order-only-prerequisites to
2018         not trigger a qmake-run of the target every time we run make.
2019
2020         https://bugs.webkit.org/show_bug.cgi?id=71778
2021
2022         Reviewed by Simon Hausmann.
2023
2024         * qmake/mkspecs/features/functions.prf:
2025
2026 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2027
2028         [Qt][WK2] Remove QWebNavigationController
2029         https://bugs.webkit.org/show_bug.cgi?id=72113
2030
2031         Reviewed by Andreas Kling.
2032
2033         Adapt to the move of the QWebNavigationController functions/properties to
2034         QQuickWebView.
2035
2036         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2037         * MiniBrowser/qt/qml/BrowserWindow.qml:
2038
2039 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2040
2041         [Qt] Build system tweak
2042
2043         Reviewed by Tor Arne Vestbø.
2044
2045         Be a good qmake citizen, return true from our linkStaticLibrary
2046         "test" function.
2047
2048         * qmake/mkspecs/features/functions.prf:
2049
2050 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2051
2052         [Qt] Add support for QT += webkit-private
2053
2054         Reviewed by Tor Arne Vestbø.
2055
2056         * qmake/qt_webkit.pri: Declare private headers.
2057
2058 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2059
2060         Unreviewed, build fix attempt after r99907. Since that revision
2061         GTK layout tests were not running at all...
2062
2063         * Scripts/webkitpy/layout_tests/port/gtk.py:
2064
2065 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2066
2067         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2068         https://bugs.webkit.org/show_bug.cgi?id=72001
2069
2070         Reviewed by Dirk Pranke.
2071
2072         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2073
2074 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2075
2076         bencher script should support remote benchmarking
2077         https://bugs.webkit.org/show_bug.cgi?id=71618
2078
2079         Rubber-stamped by Geoff Garen.
2080         
2081         Added the following features:
2082         
2083         - Benchmark report tells you the hostname and machine model (according to
2084           'sysctl hw.model') of the machine you did the run on, and svn revision number
2085           (according to 'svn info') of the VMs you're testing.
2086         
2087         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2088           acceptable, in addition to just host, in which case your username is used)
2089           and it automatically packages the build directories of the VMs you're testing,
2090           sends them to the remote machine along with your copy of the bencher script
2091           and all of the options you passed.  This pretty much seamlessly allows you
2092           to run a set of benchmarks on any machine that is sufficiently compatible with
2093           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2094           must now include a tempPath setting that tells bencher where to put files
2095           when that machine is used as a slave in a remote benchmarking run.
2096           
2097         - Added yet another way of specifying which benchmarks to run. This was sort of
2098           necessary for --remote to work as expected. Previously, you either said what
2099           suites to exclude (for example --exclude-sunspider) or that you only wanted
2100           to run one suite to the exclusion of others (--sunspider-only). But it's
2101           often better to just be able to specify the list of suites you want. This is
2102           now supported. You can say, for example, --v8 --sunspider, which means, just
2103           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2104           still supported.
2105
2106         * Scripts/bencher:
2107
2108 2011-11-10  Tony Chang  <tony@chromium.org>
2109
2110         Lazily start DRT instances in NRWT
2111         https://bugs.webkit.org/show_bug.cgi?id=72038
2112
2113         Reviewed by Eric Seidel.
2114
2115         Just a refactoring, no new tests.
2116
2117         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2118         * Scripts/webkitpy/layout_tests/port/chromium.py:
2119         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2120         * Scripts/webkitpy/layout_tests/port/test.py:
2121         * Scripts/webkitpy/layout_tests/port/webkit.py:
2122
2123 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2124
2125         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2126         https://bugs.webkit.org/show_bug.cgi?id=72057
2127
2128         Reviewed by Eric Seidel.
2129
2130         Make the regular expression more explicit.
2131
2132         * Scripts/webkitpy/common/checkout/changelog.py:
2133         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2134
2135 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2136
2137         [Qt] X11 plugins need to be reworked for Qt5
2138         https://bugs.webkit.org/show_bug.cgi?id=70023
2139
2140         Reviewed by Simon Hausmann.
2141
2142         Rework our basic plugin support in a way that does
2143         not need a bridge between Qt and X. The solution is
2144         based on getting the content drawed by the plugin
2145         from the server as an image and creating a QImage
2146         from it.
2147
2148         * qmake/mkspecs/features/features.prf: Enable X11
2149         plugins if Qt is built with the xcb-xlib backend.
2150
2151 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2152
2153         [Qt] Fix keyboard related layout tests after API refactoring
2154
2155         Reviewed by Tor Arne Vestbø.
2156
2157         Send key events to the handling page item, not the view.
2158
2159         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2160         (WTR::PlatformWebView::sendEvent):
2161         (WTR::PlatformWebView::postEvent):
2162
2163 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2164
2165         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2166         https://bugs.webkit.org/show_bug.cgi?id=71940
2167
2168         Reviewed by Philippe Normand.
2169
2170         * GNUmakefile.am:
2171         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2172         ENABLE_* variables are part of the environment.
2173
2174 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2175
2176         [Qt] Fix focus related layout tests after API refactoring
2177
2178         Reviewed by Tor Arne Vestbø.
2179
2180         Make sure the focus is set on the page now, not on the view
2181         (which doesn't actually handle the focus).
2182
2183         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2184         (WTR::WrapperWindow::WrapperWindow):
2185         (WTR::WrapperWindow::handleStatusChanged):
2186
2187 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2188
2189         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2190         https://bugs.webkit.org/show_bug.cgi?id=71355
2191
2192         Reviewed by Kenneth Rohde Christiansen.
2193
2194         Make MiniBrowser and WebKitTestRunner work again after the
2195         merge.
2196
2197         * MiniBrowser/qt/BrowserWindow.cpp:
2198         (BrowserWindow::BrowserWindow):
2199         (BrowserWindow::webView):
2200         * MiniBrowser/qt/MiniBrowser.pro:
2201         * MiniBrowser/qt/MiniBrowser.qrc:
2202         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2203         * MiniBrowser/qt/main.cpp:
2204         * MiniBrowser/qt/qml/BrowserWindow.qml:
2205         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2206         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2207         * WebKitTestRunner/PlatformWebView.h:
2208         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2209         (WTR::PlatformWebView::PlatformWebView):
2210
2211 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2212
2213         [Qt] Change semantics of the haveQt() function to match API promises
2214
2215         Having Qt 5 does not imply that we have Qt 4, from an API point of
2216         view, as a major version can in theory break BC/SC. Our minimum
2217         version of Qt 4 will always be the latest released version of Qt 4,
2218         so the only place we should use haveQt(4, x) is when checking for
2219         the minimum requirements.
2220
2221         Reviewed by Simon Hausmann.
2222
2223         * qmake/mkspecs/features/default_pre.prf:
2224         * qmake/mkspecs/features/features.prf:
2225         * qmake/mkspecs/features/functions.prf:
2226
2227 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2228
2229         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2230         https://bugs.webkit.org/show_bug.cgi?id=69411
2231
2232         Reviewed by Martin Robinson.
2233
2234         * WebKitTestRunner/EventSenderProxy.h:
2235         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2236         * WebKitTestRunner/TestController.cpp:
2237         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2238         use the EventSender instead of WebProcess Event Simulation.
2239         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2240         (WTR::WTREventQueueItem::WTREventQueueItem):
2241         (WTR::EventSenderProxy::EventSenderProxy):
2242         (WTR::getMouseButtonModifiers):
2243         (WTR::eventSenderButtonToGDKButton):
2244         (WTR::EventSenderProxy::createMouseButtonEvent):
2245         (WTR::EventSenderProxy::updateClickCountForButton):
2246         (WTR::EventSenderProxy::replaySavedEvents):
2247         (WTR::EventSenderProxy::sendOrQueueEvent):
2248         (WTR::webkitModifiersToGDKModifiers):
2249         (WTR::getGDKKeySymForKeyRef):
2250         (WTR::EventSenderProxy::keyDown):
2251         (WTR::EventSenderProxy::mouseDown):
2252         (WTR::EventSenderProxy::mouseUp):
2253         (WTR::EventSenderProxy::mouseMoveTo):
2254         (WTR::EventSenderProxy::mouseScrollBy):
2255         (WTR::EventSenderProxy::leapForward):
2256
2257 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2258
2259         [Qt] Enable exports and constructor functions in static libs
2260
2261         Reviewed by Tor Arne Vestbø.
2262
2263         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2264         mac/win32-msvc equivalents when linking static libraries into a shared
2265         library or executable.
2266
2267 2011-11-09  Hayato Ito  <hayato@chromium.org>
2268
2269         [NRWT] Make results.html aware of reference filename in reftests.
2270         https://bugs.webkit.org/show_bug.cgi?id=71574
2271
2272         Reviewed by Ryosuke Niwa.
2273
2274         If a reference filename is different from the default one, include that in result summary
2275         so results.html can link to the correct reference file.
2276
2277         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2278         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2279
2280 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2281
2282         [wx] Unreviewed build fix. Update project files and
2283         add LTC stubs for new methods.
2284
2285         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2286         (LayoutTestController::addChromeInputField):
2287         (LayoutTestController::removeChromeInputField):
2288         (LayoutTestController::focusWebView):
2289         (LayoutTestController::setBackingScaleFactor):
2290         * waf/build/settings.py:
2291
2292 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2293
2294         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2295
2296         * wx/install-unix-extras:
2297
2298 2011-11-09  Eric Seidel  <eric@webkit.org>
2299
2300         Remove the concept of platform-dependent unittests
2301         https://bugs.webkit.org/show_bug.cgi?id=71963
2302
2303         Unreviewed.  Fix test-webkitpy on cygwin.
2304
2305         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2306
2307 2011-11-09  Dana Jansens  <danakj@chromium.org>
2308
2309         Add cc-bugs group to watch changes in chromium graphics
2310         https://bugs.webkit.org/show_bug.cgi?id=71690
2311
2312         Reviewed by David Levin.
2313
2314         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2315         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2316         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2317         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2318
2319 2011-11-09  Eric Seidel  <eric@webkit.org>
2320
2321         Remove more platform-dependent unittests
2322         https://bugs.webkit.org/show_bug.cgi?id=71971
2323
2324         Reviewed by Adam Barth.
2325
2326         Tests which only run on a couple platforms will break.
2327         All tests should run on all platforms where possible.
2328
2329         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2330         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2331         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2332         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2333
2334 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2335
2336         Merge in results to the test results server even if build numbers conflict
2337         https://bugs.webkit.org/show_bug.cgi?id=71967
2338
2339         Reviewed by Tony Chang.
2340
2341         This was initially meant to be a sanity check that we don't
2342         enter duplicate runs, but it turns out that we can reasonably get
2343         in these situations when a builder is clobbered (e.g. the build
2344         numbers start over again from 0).
2345
2346         * TestResultServer/model/jsonresults.py:
2347         * TestResultServer/model/jsonresults_unittest.py:
2348
2349 2011-11-09  Eric Seidel  <eric@webkit.org>
2350
2351         Remove the concept of platform-dependent unittests
2352         https://bugs.webkit.org/show_bug.cgi?id=71963
2353
2354         Reviewed by Adam Barth.
2355
2356         These have been the source of never-ending sadness.
2357         We'd change behavior and forget to update results in
2358         some unittests because they were only run on certain platforms.
2359         This change removes a large source of these platform-dependent
2360         unittests, which was caused by the port_maker stuff.
2361
2362         It's possible that this change will break test-webkitpy
2363         on some platforms, but that will be a one-time cost.
2364         I will fix the breakage by removing the platform-dependantness
2365         of any such broken tests.
2366
2367         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2368         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2369         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2370         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2371         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2372         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2373         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2374         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2375         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2376         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2377         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2378         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2379         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2380
2381 2011-11-09  Eric Seidel  <eric@webkit.org>
2382
2383         Make the Port object have a Host
2384         https://bugs.webkit.org/show_bug.cgi?id=71961
2385
2386         Reviewed by Adam Barth.
2387
2388         This has been a long time coming.
2389         Now that Port has a Host object, it's very easy
2390         to write unittests which use a properly mocked Port.
2391         Soon we will remove the executive, filesystem and user
2392         members of Port and get everything through the Host.
2393
2394         Note how in many callsites we're actually removing
2395         explicit mocks, since we're now always going to get the
2396         correct Executive/User/FileSystem from the
2397         Host and callsites don't need to be careful to pass each one.
2398
2399         This is prep-work for adding a new Environment member to
2400         Host and needing to be able to access the Environment
2401         member from Port functions w/o needing to pass an Environment
2402         object (or appropriate Mock) every place we create a Port object.
2403         Now that we have a single Host object to reach out through, its
2404         simple to add additional functionality (like Environment) while
2405         keeping our unittests properly mocked.
2406
2407         * Scripts/webkitpy/common/host.py:
2408         * Scripts/webkitpy/common/net/credentials_unittest.py:
2409         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2410         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2411         * Scripts/webkitpy/layout_tests/port/apple.py:
2412         * Scripts/webkitpy/layout_tests/port/base.py:
2413         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2414         * Scripts/webkitpy/layout_tests/port/chromium.py:
2415         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2416         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2417         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2418         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2419         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2420         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2421         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2422         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2423         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2424         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2425         * Scripts/webkitpy/layout_tests/port/efl.py:
2426         * Scripts/webkitpy/layout_tests/port/factory.py:
2427         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2428         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2429         * Scripts/webkitpy/layout_tests/port/gtk.py:
2430         * Scripts/webkitpy/layout_tests/port/mac.py:
2431         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2432         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2433         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2434         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2435         * Scripts/webkitpy/layout_tests/port/qt.py:
2436         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2437         * Scripts/webkitpy/layout_tests/port/test.py:
2438         * Scripts/webkitpy/layout_tests/port/webkit.py:
2439         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2440         * Scripts/webkitpy/layout_tests/port/win.py:
2441         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2442         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2443         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2444         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2445         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2446
2447 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2448
2449         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2450         https://bugs.webkit.org/show_bug.cgi?id=71561
2451
2452         Reviewed by Dimitri Glazkov.
2453
2454         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2455         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2456
2457 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2458
2459         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2460         https://bugs.webkit.org/show_bug.cgi?id=66772
2461
2462         Reviewed by Simon Fraser.
2463
2464         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2465         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2466
2467         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2468         in the FrameLoadDelegate and print the output in response to the notification.
2469
2470         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2471         (-[FrameLoadDelegate init]):
2472         (-[FrameLoadDelegate dealloc]):
2473         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2474
2475 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2476
2477         [GTK][DRT] window internals object is not reset after each test
2478         https://bugs.webkit.org/show_bug.cgi?id=71890
2479
2480         Reviewed by Martin Robinson.
2481
2482         Call WebCoreTestSupport::resetInternalsObject without going
2483         through DumpRenderTreeSupport.
2484
2485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2486         (runTest):
2487
2488 2011-11-09  Beth Dakin  <bdakin@apple.com>
2489
2490         Build fix.
2491
2492         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2493         (AccessibilityUIElement::uiElementAttributeValue):
2494
2495 2011-11-09  Beth Dakin  <bdakin@apple.com>
2496
2497         Speculative build fix.
2498
2499         * DumpRenderTree/AccessibilityUIElement.h:
2500
2501 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2502
2503         Unreviewed build fix.
2504
2505         * DumpRenderTree/AccessibilityUIElement.cpp:
2506         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2507         A bad merge added this check that is making the bots sad.
2508
2509 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2510
2511         AX: crash when accessing selectedTab in a tab list
2512         https://bugs.webkit.org/show_bug.cgi?id=70938
2513
2514         Reviewed by Beth Dakin.
2515
2516         Add the ability to retrieve an element through an arbitrary attribute.
2517
2518         * DumpRenderTree/AccessibilityUIElement.cpp:
2519         (uiElementAttributeValueCallback):
2520         (AccessibilityUIElement::uiElementAttributeValue):
2521         (AccessibilityUIElement::getJSClass):
2522         * DumpRenderTree/AccessibilityUIElement.h:
2523         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2524         (AccessibilityUIElement::uiElementAttributeValue):
2525
2526 2011-11-09  Andy Wingo  <wingo@igalia.com>
2527
2528         Add webkitdirs.pm:getArchitecture implementation for GTK
2529         https://bugs.webkit.org/show_bug.cgi?id=71370
2530
2531         Reviewed by Xan Lopez.
2532
2533         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2534         implementation for ports using autotools, so that a vanilla
2535         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2536         to build-jsc on x86-64 machines.
2537
2538 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2539
2540         Unreviewed, rolling out r99707.
2541         http://trac.webkit.org/changeset/99707
2542
2543         Re-enable until we can disable it together with tests in one
2544         shot.
2545
2546         * qmake/mkspecs/features/features.prf:
2547
2548 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2549
2550         [Qt] Disable use of QtUiTools if the library/module is not found
2551
2552         We rely on the lookup order of prf files to inject our own uitools.prf
2553         that will verify that QtUiTools is in fact present before allowing the
2554         CONFIG += uitools to have any effect.
2555
2556         Reviewed by Simon Hausmann.
2557
2558         * DumpRenderTree/qt/DumpRenderTree.pro:
2559         * QtTestBrowser/QtTestBrowser.pro:
2560         * qmake/mkspecs/features/uitools.prf: Added.
2561
2562 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2563
2564         Unreviewed, rolling out r99701.
2565         http://trac.webkit.org/changeset/99701
2566
2567         Breaks Qt mac build
2568
2569         * qmake/mkspecs/features/functions.prf:
2570
2571 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2572
2573         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2574
2575         Reviewed by Tor Arne Vestbø.
2576
2577         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2578         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2579         is not up to the task of full XSLT support, so we should disable it.
2580
2581 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2582
2583         [Qt] Enable exports and constructor functions in static libs
2584
2585         Reviewed by Tor Arne Vestbø.
2586
2587         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2588         mac/win32-msvc equivalents when linking static libraries into a shared
2589         library or executable.
2590
2591 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2592
2593         [GTK][DRT] window internals object is not reset after each test
2594         https://bugs.webkit.org/show_bug.cgi?id=71890
2595
2596         Reviewed by Xan Lopez.
2597
2598         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2599         (runTest): reset the Internals object after each test.
2600
2601 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2602
2603         [Qt] Detect presence of QtUiTools and enable it only when available
2604
2605         The disable_uitools option was a workaround for missing detection.
2606
2607         Reviewed by Simon Hausmann.
2608
2609         * QtTestBrowser/QtTestBrowser.pro:
2610         * qmake/mkspecs/features/default_post.prf:
2611         * qmake/mkspecs/features/default_pre.prf:
2612
2613 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2614
2615         [Qt] Don't override config for the build_pass of debug_and_release
2616
2617         Qmake will parse the profile once for each configuration (debug and
2618         release), with the build_pass option set. In that situation we don't
2619         want to override what qmake is setting explicitly, otherwise the
2620         debug-step will end up hitting all the release-scopes.
2621
2622         Reviewed by Simon Hausmann.
2623
2624         * qmake/mkspecs/features/default_pre.prf:
2625
2626 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2627
2628         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2629
2630         * qmake/mkspecs/features/functions.prf:
2631
2632 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2633
2634         [Qt] Centralize duplicated code for linking the static libs
2635
2636         Reviewed by Tor Arne Vestbø.
2637
2638         * qmake/mkspecs/features/functions.prf:
2639         * qmake/mkspecs/features/javascriptcore.prf:
2640         * qmake/mkspecs/features/webcore.prf:
2641         * qmake/mkspecs/features/webkit2.prf:
2642
2643 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2644
2645         [Qt] Build system cleanup
2646         https://bugs.webkit.org/show_bug.cgi?id=71815
2647
2648         Reviewed by Kenneth Rohde Christiansen.
2649
2650         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2651         static library.
2652         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2653         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2654
2655 2011-11-08  Hayato Ito  <hayato@chromium.org>
2656
2657         [NRWT] Make single_test_runner aware of reference filename of test_input.
2658         https://bugs.webkit.org/show_bug.cgi?id=71567
2659
2660         Reviewed by Ryosuke Niwa.
2661
2662         Make single_test_runner honor a reference filename of given test_input so that
2663         we can use any file as reference html, instead of depending on implicit naming convention.
2664         The typical use case is to support w3c reftests.
2665
2666         No tests since no functional changes until there is a client.
2667         Test should be easily written with future clients.
2668
2669         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2670         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2671         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2672         * Scripts/webkitpy/layout_tests/models/test_input.py:
2673
2674 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2675
2676         https://bugs.webkit.org/show_bug.cgi?id=71839
2677         Update the leaks bot OS to Lion.
2678         Update the config.json to reflect the update.
2679
2680         Reviewed by Stephanie Lewis.
2681
2682         * BuildSlaveSupport/build.webkit.org-config/config.json:
2683
2684 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2685
2686         Unreviewed, rolling out r99626.
2687         http://trac.webkit.org/changeset/99626
2688         https://bugs.webkit.org/show_bug.cgi?id=71866
2689
2690         "C++ exceptions cannot be disabled without influencing the
2691         Objective-C exceptions" (Requested by benjaminp on #webkit).
2692
2693         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2694
2695 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2696
2697         [Mac] Disable C++ exceptions from DumpRenderTree
2698         https://bugs.webkit.org/show_bug.cgi?id=71834
2699
2700         Reviewed by Darin Adler.
2701
2702         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2703         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2704         which leads to crashes long after the exception was raised.
2705
2706         This patch disabled C++ exceptions in order to catch the problems where
2707         they happen when a C++ exception is raised.
2708
2709         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2710
2711 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2712
2713         Moved myself to the reviewer list (yay!).
2714
2715         * Scripts/webkitpy/common/config/committers.py:
2716
2717 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2718
2719         Added myself as a committer.
2720
2721         * Scripts/webkitpy/common/config/committers.py:
2722
2723 2011-11-08  Andy Wingo  <wingo@igalia.com>
2724
2725         Skip some ECMAScript tests that fail on Linux in some time zones.
2726         https://bugs.webkit.org/show_bug.cgi?id=71371
2727
2728         Reviewed by Martin Robinson.
2729
2730         * Scripts/run-javascriptcore-tests: Skip some more tests.
2731
2732 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2733
2734         [Qt] Unreviewed trivial fix after build system refactoring.
2735
2736         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2737
2738 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2739
2740         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2741
2742         If a pro file needs to access the OBJECTS_DIR it should use the
2743         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2744         after defaults_post has been processed.
2745
2746         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2747         the command line will override whatever we set in defaults_pre.
2748
2749         Reviewed by Simon Hausmann.
2750
2751         * qmake/mkspecs/features/default_post.prf:
2752         * qmake/mkspecs/features/default_pre.prf:
2753
2754 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2755
2756         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2757
2758         Reviewed by Simon Hausmann.
2759
2760         * qmake/mkspecs/features/default_post.prf:
2761
2762 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2763
2764         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2765         https://bugs.webkit.org/show_bug.cgi?id=71680
2766
2767         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2768         complete urls in MiniBrowser.
2769
2770         Reviewed by Tor Arne Vestbø.
2771
2772         * MiniBrowser/qt/BrowserWindow.cpp:
2773         (BrowserWindow::BrowserWindow):
2774         (BrowserWindow::load):
2775         * MiniBrowser/qt/qml/BrowserWindow.qml:
2776         * MiniBrowser/qt/utils.cpp:
2777         (Utils::urlFromUserInput):
2778         * MiniBrowser/qt/utils.h:
2779         (Utils::Utils):
2780
2781 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2782
2783         Added myself as a committer.
2784
2785         * Scripts/webkitpy/common/config/committers.py:
2786
2787 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2788
2789         Unreviewed webkitpy test fix after r99512.
2790
2791         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2792         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2793
2794 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2795
2796         Added myself as a committer.
2797
2798         * Scripts/webkitpy/common/config/committers.py:
2799
2800 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2801
2802         Unreviewed, rolling out r99470.
2803         http://trac.webkit.org/changeset/99470
2804         https://bugs.webkit.org/show_bug.cgi?id=71740
2805
2806         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2807
2808         * Scripts/webkitpy/common/config/watchlist:
2809
2810 2011-11-07  Tony Chang  <tony@chromium.org>
2811
2812         [chromium] update flakiness dashboard to reflect current bots
2813
2814         Reviewed by Ojan Vafai.
2815
2816         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2817             bots and merged linux debug bots into a single bot.
2818         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2819         (setupExpectationsTest):
2820
2821 2011-11-07  Dana Jansens  <danakj@chromium.org>
2822
2823         Add cc-bugs group to watch changes in chromium graphics
2824         https://bugs.webkit.org/show_bug.cgi?id=71690
2825
2826         Reviewed by James Robinson.
2827
2828         * Scripts/webkitpy/common/config/watchlist:
2829
2830 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2831
2832         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2833         https://bugs.webkit.org/show_bug.cgi?id=70912
2834
2835         Reviewed by Ojan Vafai.
2836
2837         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2838         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2839
2840 2011-11-07  Eric Seidel  <eric@webkit.org>
2841
2842         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2843         https://bugs.webkit.org/show_bug.cgi?id=62199
2844
2845         Reviewed by Dirk Pranke.
2846
2847         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2848         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2849         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2850
2851 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2852
2853         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2854         https://bugs.webkit.org/show_bug.cgi?id=71485
2855
2856         Reviewed by Darin Fisher.
2857
2858         * DumpRenderTree/chromium/EventSender.cpp:
2859         (EventSender::scalePageBy):
2860         * DumpRenderTree/chromium/TestShell.cpp:
2861         (TestShell::resetTestController):
2862
2863 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2864
2865         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2866
2867         Allows us to not package up the whole Source/JavaScriptCore directory for the
2868         buildbots.
2869
2870         Reviewed-by Simon Hausmann.
2871
2872         * BuildSlaveSupport/built-product-archive:
2873         * Scripts/webkitdirs.pm:
2874         (jscProductDir):
2875
2876 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2877
2878         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2879
2880         Reviewed-by Simon Hausmann.
2881
2882         * qmake/mkspecs/features/default_post.prf:
2883
2884 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2885
2886         [Qt] Sanitize qmake paths correctly before comparing
2887
2888         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2889         which caused us to always generate derived webcore sources, but never build
2890         them. The bug has been fixed, and we now also sanitize paths for the injected
2891         bundle derived sources.
2892
2893         Reviewed by Simon Hausmann.
2894
2895         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2896         * qmake/mkspecs/features/functions.prf:
2897
2898 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2899
2900         [Qt] Print right order for changing feature defines
2901
2902         Reviewed by Simon Hausmann.
2903
2904         * Scripts/webkitdirs.pm:
2905         (buildQMakeProject):
2906
2907 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2908
2909         [Qt] Unreviewed trivial fix after build system refactoring.
2910
2911         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2912
2913 2011-11-06  Eric Seidel  <eric@webkit.org>
2914
2915         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2916         https://bugs.webkit.org/show_bug.cgi?id=66078
2917
2918         Unreviewed.  Add an assert about the type of "args"
2919         to our Executive Mocks and fix a piece of code
2920         from this patch which was hitting that assert
2921         when executing for real.
2922
2923         * Scripts/webkitpy/common/system/executive_mock.py:
2924         * Scripts/webkitpy/layout_tests/port/webkit.py:
2925
2926 2011-11-06  Eric Seidel  <eric@webkit.org>
2927
2928         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2929         https://bugs.webkit.org/show_bug.cgi?id=71629
2930
2931         Reviewed by Adam Barth.
2932
2933         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2934
2935 2011-11-06  Eric Seidel  <eric@webkit.org>
2936
2937         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2938         https://bugs.webkit.org/show_bug.cgi?id=66078
2939
2940         Reviewed by Adam Barth.
2941
2942         The runtime feature detection was fixed to work in bug 64472.
2943         In this bug I moved the symbol-based feature detection from
2944         popen() to Executive.run_command and cleaned up the callers
2945         and unittests to make sure that we're correctly parsing the
2946         nm output correctly.  The old code happened to work even though
2947         the runtime-features path was using "str in list" and the
2948         symbol features path was using "str in str" and it just happened
2949         to do what we wanted to.  Now runtime features and symbol feature
2950         blacklists are computed separately (and with better documentation).
2951
2952         This system remains confusing, partially because these are black-lists
2953         which are amended to whatever static blacklist may exist for the
2954         port as part of a Skipped list file.
2955
2956         For example, notice how the runtime feature list only has directory
2957         blacklists for a couple features.  If all features are off,
2958         how do we skip enough tests with only 2 entries in the blacklist map?
2959         The answer is that Windows is the only port to use runtime feature
2960         detection, and the win/Skipped file turns off all the other features
2961         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2962         which use symbol-based feature detection turn of mathml, wcss, etc
2963         using the blacklists found in _missing_symbol_to_skipped_tests.
2964
2965         I also noticed a couple places where we still referenced xhtmlmp
2966         even though support for such has been removed from WebKit.  Removed those.
2967
2968         This should result in no functional change.
2969
2970         * Scripts/webkitpy/layout_tests/port/gtk.py:
2971          - Use self._filesystem instead of os.path
2972         * Scripts/webkitpy/layout_tests/port/webkit.py:
2973         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2974
2975 2011-11-06  Dan Bernstein  <mitz@apple.com>
2976
2977         Made show-pretty-diff work when the input path contains spaces.
2978
2979         Reviewed by Anders Carlsson.
2980
2981         * Scripts/show-pretty-diff:
2982
2983 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2984
2985         [chromium] Use the security origin instead of the URL when checking notification permissions
2986         https://bugs.webkit.org/show_bug.cgi?id=71590
2987
2988         Reviewed by Adam Barth.
2989
2990         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2991         (NotificationPresenter::checkPermission):
2992         * DumpRenderTree/chromium/NotificationPresenter.h:
2993
2994 2011-11-05  Darin Adler  <darin@apple.com>
2995
2996         Fix a small leak in Mac version of LayoutTestController
2997         https://bugs.webkit.org/show_bug.cgi?id=71615
2998
2999         Reviewed by Mark Rowe.
3000
3001         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3002         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
3003         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
3004
3005 2011-11-04  Eric Seidel  <eric@webkit.org>
3006
3007         Upgrade to the latest Mechanize
3008         https://bugs.webkit.org/show_bug.cgi?id=71594
3009
3010         Reviewed by Adam Barth.
3011
3012         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
3013         Mechanize is no longer two separate libraries, so importing it is much simpler.
3014
3015         * Scripts/webkitpy/thirdparty/__init__.py:
3016
3017 2011-11-04  Stephen Chenney  <schenney@chromium.org>
3018
3019         Crash in ScrollAnimator.cpp
3020         https://bugs.webkit.org/show_bug.cgi?id=69865
3021
3022         The code in ScrollAnimator assumes that horizontal per-page mouse
3023         wheel events cannot happen, which is not true. This patch adds layout
3024         tests for all paging wheel event situations and fixes the broken
3025         horizontal case.
3026
3027         Reviewed by Anders Carlsson
3028
3029         * DumpRenderTree/chromium/EventSender.cpp:
3030         (EventSender::handleMouseWheel): Added the ability to specify that a
3031         mouse wheel event should be paging.
3032
3033 2011-11-04  Eric Seidel  <eric@webkit.org>
3034
3035         Remove deprecated free functions in port.factory
3036         https://bugs.webkit.org/show_bug.cgi?id=71494
3037
3038         Unreviewed.  Fix exception when running new-run-webkit-httpd.
3039
3040         * Scripts/new-run-webkit-httpd:
3041
3042 2011-11-04  Adam Roben  <aroben@apple.com>
3043
3044         Remove Leopard-specific code from build.webkit.org
3045
3046         We don't have any Leopard bots anymore.
3047
3048         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
3049
3050         Reviewed by Mark Rowe.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
3053         and StopATSServer steps.
3054         (unitTestsSupported): Removed check for mac-leopard.
3055         (TestFactory.__init__): Removed Leopard-specific steps.
3056
3057 2011-11-04  Eric Seidel  <eric@webkit.org>
3058
3059         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
3060         https://bugs.webkit.org/show_bug.cgi?id=71549
3061
3062         Reviewed by Adam Barth.
3063
3064         Several members of Host didn't really belong there
3065         and were instead specific to WebKitPatch, so I've moved
3066         them up onto that class.
3067
3068         * Scripts/webkitpy/common/host.py:
3069         * Scripts/webkitpy/common/host_mock.py:
3070         * Scripts/webkitpy/tool/main.py:
3071         * Scripts/webkitpy/tool/mocktool.py:
3072         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3073
3074 2011-11-04  Tony Chang  <tony@chromium.org>
3075
3076         garden-o-matic: bring back party time!
3077         https://bugs.webkit.org/show_bug.cgi?id=71582
3078
3079         Reviewed by Adam Barth.
3080
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
3082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
3083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
3084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3087
3088 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3089
3090         [EFL] DRT: Fix the order of the items in the dumped history list.
3091         https://bugs.webkit.org/show_bug.cgi?id=71562
3092
3093         It did not make much sense to hold the history list in a map, as we do not need
3094         the keys. And the printed items must be sorted by target, which is more easily
3095         done with a vector.
3096
3097         Should make tests such as http/tests/navigation/error404-frames.html pass.
3098
3099         Reviewed by Antonio Gomes.
3100
3101         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3102         (compareHistoryItemsByTarget):
3103         (dumpHistoryItem):
3104
3105 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3106
3107         [Qt] Remove ENABLE_SQLITE from qmake files
3108         https://bugs.webkit.org/show_bug.cgi?id=71546
3109
3110         Reviewed by Simon Hausmann.
3111
3112         * qmake/mkspecs/features/features.prf:
3113         * qmake/mkspecs/features/webcore.prf:
3114
3115 2011-11-04  Adam Barth  <abarth@webkit.org>
3116
3117         watchlist for WebIDL shouldn't trigger on Internals.idl
3118         https://bugs.webkit.org/show_bug.cgi?id=70657
3119
3120         Reviewed by David Levin.
3121
3122         Internals.idl isn't part of the Web-facing IDL in the project.
3123
3124         * Scripts/webkitpy/common/config/watchlist:
3125
3126 2011-11-04  Anders Carlsson  <andersca@apple.com>
3127
3128         Fix WKTR crash when running NPN_ConvertPoint test.
3129
3130         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3131
3132         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3133         (ConvertPoint::NPP_SetWindow):
3134
3135 2011-11-04  Anders Carlsson  <andersca@apple.com>
3136
3137         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3138         https://bugs.webkit.org/show_bug.cgi?id=71570
3139
3140         Reviewed by Simon Fraser.
3141
3142         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3143         (PluginTest::NPP_SetWindow):
3144         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3145         Remove the NPP parameter from NPP_SetWindow.
3146
3147         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3148         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3149         Remove the NPP parameter from NPP_SetWindow.
3150
3151         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3152         (PassDifferentNPPStruct::NPP_SetWindow):
3153         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3154
3155         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3156         (ConvertPoint::NPP_SetWindow):
3157         Run the test from NPP_SetWindow and call notifyDone() when done.
3158
3159         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3160         (NPP_SetWindow):
3161         Remove unnecessary parameter.
3162
3163 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3164
3165         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3166
3167         Rubber-stamped by Tor Arne Vestbø.
3168
3169         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3170         changed slightly after the refactoring.
3171
3172 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3173
3174         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3175
3176         Reviewed by Simon Hausmann.
3177
3178         * qmake/mkspecs/features/default_pre.prf:
3179
3180 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3181
3182         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3183
3184         Reviewed by Simmon Hausmann.
3185
3186         * qmake/mkspecs/features/default_pre.prf:
3187
3188 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3189
3190         [Qt] Disable STDIN check before cleaning build dir
3191
3192         It didn't work on the bots.
3193
3194         Reviewed by Ossy.
3195
3196         * Scripts/webkitdirs.pm:
3197
3198 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3199
3200         [Qt] Don't build all of webkit when running build-jsc
3201
3202         In case the whole webkit project was built, but we then subsequently
3203         want to build only JSC, we need to run make in the proper subdirectory.
3204
3205         This also means the incremental target needs to be added to all
3206         makefiles.
3207
3208         Reviewed by Simmon Hausmann.
3209
3210         * Scripts/webkitdirs.pm:
3211         (buildQMakeProject):
3212         * qmake/mkspecs/features/default_post.prf:
3213
3214 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3215
3216         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3217
3218         Reviewed by Tor Arne Vestbø.
3219
3220         * Scripts/webkitdirs.pm:
3221         (jscProductDir): jsc path changed.
3222
3223 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3224
3225         [Qt] Error out early if trying to build against Qt < 4.8
3226
3227         Reviewed by Simon Hausmann.
3228
3229         * qmake/mkspecs/features/default_pre.prf:
3230
3231 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3232
3233         Fix run-launcher for Qt and Gtk.
3234
3235         Rubber-stamped by Tor Arne Vestbø.
3236
3237         * Scripts/webkitdirs.pm:
3238         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3239
3240 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3241
3242         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3243
3244         Reviewed by Simon Hausmann.
3245
3246         * Scripts/build-webkit:
3247
3248 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3249
3250         [GTK] Use web view title as window title in MiniBrowser
3251         https://bugs.webkit.org/show_bug.cgi?id=71544
3252
3253         Reviewed by Philippe Normand.
3254
3255         * MiniBrowser/gtk/BrowserWindow.c:
3256         (webViewURIChanged): Removed extra space.
3257         (webViewTitleChanged): Set window title using
3258         webkit_web_view_get_title().
3259         (browser_window_init): Set initial default window title.
3260         (browserWindowConstructed): Connect to WebView notify::title
3261         signal.
3262
3263 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3264
3265         [Qt] Refactor and clean up the qmake build system
3266
3267         The qmake build system has accumulated a bit of cruft and redundancy
3268         over time. There's also a fairly tight coupling between how to build
3269         the various targets, and _what_ to build, making it harder to add new
3270         rules or sources. This patch aims to elevate these issues somewhat.
3271
3272         This is a short-list of the changes:
3273
3274           * The rules for how to build targets are now mostly contained as
3275             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3276             allows us to do pre- and post-processing of each project file,
3277             which helps to clean up the actual project files.
3278
3279           * Derived sources are no longer generated as a separate make-step
3280             but is part of each target's project file as a subdir. Makefile
3281             rules are used to ensure that we run make on the derived sources
3282             before running qmake on the actual target makefile. This makes
3283             it easier to keep a proper dependency between derived sources
3284             and the target.
3285
3286           * We use GNU make and the compiler to generate dependencies on
3287             UNIX-based systems running Qt 5. This allows us to lessen the
3288             need to run qmake, which should reduce compile time.
3289
3290           * WebKit2 is now build by default if building with Qt 5. It can
3291             be disabled by passing --no-webkit2 to build-webkit.
3292
3293         The result of these changes are hopefully a cleaner and easier
3294         build system to modify, and faster build times due to no longer
3295         running qmake on every single build. It's also a first step
3296         towards possibly generating the list of sources using another
3297         build system.
3298
3299         https://bugs.webkit.org/show_bug.cgi?id=71222
3300
3301         Reviewed by Simon Hausmann.
3302
3303         * DerivedSources.pro: Removed.
3304         * DumpRenderTree/qt/DumpRenderTree.pro:
3305         * DumpRenderTree/qt/ImageDiff.pro:
3306         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3307         * MiniBrowser/qt/MiniBrowser.pro:
3308         * QtTestBrowser/QtTestBrowser.pro:
3309         * QtTestBrowser/launcherwindow.cpp:
3310         (LauncherWindow::initializeView):
3311         (LauncherWindow::createChrome):
3312         (LauncherWindow::screenshot):
3313         * QtTestBrowser/launcherwindow.h:
3314         (WindowOptions::WindowOptions):
3315         * Scripts/build-webkit:
3316         (unlinkZeroFiles):
3317         * Scripts/webkitdirs.pm:
3318         (qtFeatureDefaults):
3319         (promptUser):
3320         (buildQMakeProject):
3321         * Tools.pro:
3322         * WebKitTestRunner/DerivedSources.pri: Added.
3323         * WebKitTestRunner/DerivedSources.pro: Removed.
3324         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3325         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3326         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3327         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3328         * WebKitTestRunner/Target.pri: Added.
3329         * WebKitTestRunner/WebKitTestRunner.pro:
3330         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3331         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3332         * qmake/README: Added.
3333         * qmake/mkspecs/features/default_post.prf: Added.
3334         * qmake/mkspecs/features/default_pre.prf: Added.
3335         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3336         * qmake/mkspecs/features/functions.prf: Added.
3337         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3338         * qmake/mkspecs/features/mac/default_post.prf: Added.
3339         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3340         * qmake/mkspecs/features/minimal_qt.prf: Added.
3341         * qmake/mkspecs/features/qtwebkit.prf: Added.
3342         * qmake/mkspecs/features/rpath.prf: Added.
3343         * qmake/mkspecs/features/unix/default_post.prf: Added.
3344         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3345         * qmake/mkspecs/features/valgrind.prf: Added.
3346         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3347         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3348         * qmake/mkspecs/features/win32/default_post.prf: Added.
3349         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3350         * qmake/syncqt-4.8: Added.
3351         (showUsage):
3352         ():
3353         (copyFile):
3354         (symlinkFile):
3355
3356 2011-11-04  Eric Seidel  <eric@webkit.org>
3357
3358         Remove deprecated free functions in port.factory
3359         https://bugs.webkit.org/show_bug.cgi?id=71494
3360
3361         Unreviewed.  Fixing exception seen when running test-webkitpy.
3362
3363         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3364         unittest, since that script is nearly ready to be deleted.  But I added
3365         it back at the last second and failed to run the tests. :(
3366         This fixes the exception the bots were seeing.
3367
3368         * Scripts/webkitpy/style/checkers/test_expectations.py:
3369         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3370         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3371
3372 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3373
3374         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3375         https://bugs.webkit.org/show_bug.cgi?id=71163
3376
3377         Reviewed by Ryosuke Niwa.
3378
3379         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3380         (WebPreferences::applyTo):
3381
3382 2011-11-03  Eric Seidel  <eric@webkit.org>
3383
3384         Remove deprecated free functions in port.factory
3385         https://bugs.webkit.org/show_bug.cgi?id=71494
3386
3387         Reviewed by Adam Barth.
3388
3389         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3390         free functions in factory.py.  To remove these required fixing all callsites
3391         to use MockHost, Host, or PortFactory where appropriate.  After this change
3392         we're only left with a handfull of places where we inappropraitely use a
3393         real Executive, FileSystem or User object during unittesting.
3394
3395         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3396          - These PortFactory overrides were from an earlier edition of my previous patch
3397            in the end, I removed MockPortFactory so all tests ended up with this same
3398            real PortFactory() with a MockHost.  This was simply redundent code.
3399         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3400          - Use MockHost to get a mocked-out PortFactory.
3401         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3402          - This code has no access to a Host object, so we just use a default PortFactory
3403            for now.  This will still incorrectly create real Executive/FileSystem objects
3404            durring unittesting, which is wrong. :(
3405         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3406          - Use a MockHost to get a mocked PortFactory.
3407         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3408          - Use a MockHost to get a mocked PortFactory.
3409         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3410          - ditto.
3411         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3412          - ditto.
3413         * Scripts/webkitpy/layout_tests/port/__init__.py:
3414          - factory.get no longer exists.  Yay!
3415         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3416          - Use a MockHost to get a mocked PortFactory.
3417            To do this efficiently, I created a helper function
3418            and combined all these (mostly redundant) tests into one test
3419            with several calls to the helper function.
3420         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3421          - Pass MockUser and MockExecutive in these port testing subclasses.
3422          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3423         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3424          - Awesome windows hacks should only happen on win32.  Once we started
3425            using MockExecutives these 'svn help' commands started printing in
3426            other tests, which is how I found this bug.
3427         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3428          - DryRunPort has no Host, so just use a PortFactory() directly.
3429            This will do the wrong thing if we're unittesting the DryRun port
3430            but it's no worse than the existing code.
3431         * Scripts/webkitpy/layout_tests/port/factory.py:
3432          - Remove the free functions.
3433          - Fix argument overriding to be able to override None.
3434         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3435          - Use a mocked-out PortFactory during testing.
3436         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3437          - Pass MockExecutive and MockUser to these manual Port instantiations.
3438         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3439          - No access to a Host object here, so just using PortFactory directly.
3440            This is wrong, but no more wrong than the existing code was.
3441         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3442          - Use a MockHost to get a mocked out PortFactory.
3443         * Scripts/webkitpy/layout_tests/port/test.py:
3444          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3445         * Scripts/webkitpy/layout_tests/port/win.py:
3446          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3447            now that we're actually passing MockExecutive to most Port instantiations during testing.
3448         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3449          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3450         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3451          - Host is the future.
3452         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3453          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3454            we don't need to pass MockUser explicitly, it does that automatically for us.
3455         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3456          - Use a MockHost to get a mocked out PortFactory.
3457         * Scripts/webkitpy/style/checkers/test_expectations.py:
3458          - We don't have access to a Host object, so using PortFactory() directly.
3459         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3460          - Remove unused variable.
3461         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3462          - Host isn't accessible here, so using PortFactory() directly, which
3463            although unfortunate is no worse than before.
3464         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3465          - Testing is much easier when you don't need to hack global state...
3466         * Scripts/webkitpy/tool/commands/expectations.py:
3467          - Use the port_factory on the tool.
3468         * Scripts/webkitpy/tool/commands/rebaseline.py:
3469          - ditto.
3470         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3471          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3472            the arguments in the right order.  Fixing that made it use a MockFileSystem
3473            (like it had been trying to), which then required us to actually populate
3474            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3475         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3476          - Get the port_factory from the tool.
3477         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3478          - Ditto.
3479         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3480          - Use a MockHost to get a mocked out Port object.
3481
3482 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3483
3484         [EFL] DRT: Allow choosing which backing store to use.
3485         https://bugs.webkit.org/show_bug.cgi?id=70532
3486
3487         Reviewed by Antonio Gomes.
3488
3489         This change makes it possible to change the backing store used by DRT
3490         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3491         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3492
3493         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3494         (DumpRenderTreeChrome::createView):
3495         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3496         (shouldUseSingleBackingStore):
3497         (chooseAndInitializeAppropriateSmartClass):
3498         (drtViewAdd):
3499         * DumpRenderTree/efl/DumpRenderTreeView.h:
3500
3501 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3502
3503         JS Test Harness: Remove more link tags
3504         https://bugs.webkit.org/show_bug.cgi?id=71339
3505
3506         Reviewed by Ojan Vafai.
3507
3508         * Scripts/make-new-script-test:
3509         (writeTestFile): Don't output <link>
3510
3511 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3512
3513         Reviewed by Martin Robinson.
3514
3515         [GTK] arguments passed to build-jsc are not taken into account
3516         https://bugs.webkit.org/show_bug.cgi?id=58333
3517
3518         * Scripts/build-jsc:
3519
3520 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3521
3522         [GTK] Show url of history items in a status bar in MiniBrowser
3523         https://bugs.webkit.org/show_bug.cgi?id=71474
3524
3525         Reviewed by Martin Robinson.
3526
3527         * MiniBrowser/gtk/BrowserWindow.c:
3528         (browserWindowSetStatusText): Set status text and show/hide the
3529         status label.
3530         (resetStatusText): Reset status text when history menu is hidden.
3531         (browserWindowHistoryItemSelected): Show url of currently selected
3532         history item.
3533         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3534         menu to reset the status text.
3535         (browserWindowConstructed): Use GtkOverlay if available to show
3536         status text.
3537
3538 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3539
3540         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3541         https://bugs.webkit.org/show_bug.cgi?id=71466
3542
3543         Reviewed by Martin Robinson.
3544
3545         * MiniBrowser/gtk/BrowserWindow.c:
3546         (browserWindowHistoryItemActivated): Go to selected back formard
3547         list item using webkit_web_view_go_to_back_forward_list_item()
3548         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3549         given GList of WebKitBackForwardListItems.
3550         (browserWindowUpdateNavigationActions): Enable/disable back and
3551         forward buttons depending on whether it's possible to go
3552         back/forward. Create a menu for back and forward toolbar buttons.
3553         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3554         (browserWindowConstructed): Connect to WebKitBackForwardList
3555         changed signal.
3556
3557 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3558
3559         [Qt] Remove Maemo specific code paths
3560         https://bugs.webkit.org/show_bug.cgi?id=71476
3561
3562         Reviewed by Kenneth Rohde Christiansen.
3563
3564         * QtTestBrowser/launcherwindow.cpp:
3565         (LauncherWindow::~LauncherWindow):
3566         (LauncherWindow::init):
3567         (LauncherWindow::showLinkHover):
3568         (LauncherWindow::selectElements):
3569         (LauncherWindow::showFPS):
3570         (LauncherWindow::updateFPS):
3571         * QtTestBrowser/launcherwindow.h:
3572         (WindowOptions::WindowOptions):
3573         * QtTestBrowser/locationedit.cpp:
3574         * QtTestBrowser/locationedit.h:
3575
3576 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3577
3578         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3579         https://bugs.webkit.org/show_bug.cgi?id=71461
3580
3581         Reviewed by Martin Robinson.
3582
3583         * MiniBrowser/gtk/BrowserWindow.c:
3584         (resetEntryProgress): Reset the entry progress after a while when
3585         load has been completed.
3586         (webViewLoadProgressChanged): Update location entry progress.
3587         (browserWindowConstructed): Connect to WebView
3588         notify::estimated-load-progress signal.
3589
3590 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3591
3592         [GTK] Remove WebKit2 C API from MiniBrowser
3593         https://bugs.webkit.org/show_bug.cgi?id=71459
3594
3595         Reviewed by Martin Robinson.
3596
3597         Use the GTK+ API instead to add minimum functionality. The other
3598         features will be ported to GTK+ API in following patches.
3599
3600         * MiniBrowser/gtk/BrowserWindow.c:
3601         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3602         (goBackCallback): Use webkit_web_view_go_back().
3603         (goForwardCallback): Use webkit_web_view_go_forward().
3604         (webViewURIChanged): Update location entry with current uri using
3605         webkit_web_view_get_uri().
3606         (browserWindowFinalize):
3607         (browserWindowGetProperty):
3608         (browserWindowSetProperty):
3609         (browser_window_init):
3610         (browserWindowConstructed): Connect to notify::uri signal of
3611         WebView to be notified when the URI changes.
3612         (browser_window_class_init):
3613         (browser_window_new): Use WebKitWebView.
3614         (browser_window_get_view): Use WebKitWebView
3615         * MiniBrowser/gtk/BrowserWindow.h:
3616         * MiniBrowser/gtk/GNUmakefile.am:
3617         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3618         * MiniBrowser/gtk/main.c:
3619         (loadURI): Use webkit_web_view_new().
3620         (main):
3621
3622 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3623
3624         [Qt] Unable to start MiniBrowser after run-webkit-tests
3625         https://bugs.webkit.org/show_bug.cgi?id=71469
3626
3627         Reviewed by Csaba Osztrogonác.
3628
3629         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3630         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3631         line arguments.