Tools/ChangeLog

   1 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
   2
   3         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
   4         https://bugs.webkit.org/show_bug.cgi?id=143664
   5
   6         Reviewed by Gyuyoung Kim.
   7
   8         * Scripts/webkitperl/FeatureList.pm:
   9
  10 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
  11
  12         [EFL] Enable Media Source
  13         https://bugs.webkit.org/show_bug.cgi?id=143635
  14
  15         Reviewed by Csaba Osztrogonác.
  16
  17         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
  18
  19 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
  20
  21         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
  22         https://bugs.webkit.org/show_bug.cgi?id=143646
  23
  24         Reviewed by David Kilzer.
  25
  26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
  27         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
  28
  29 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
  30
  31         Use en_US spell checker for tests on Mac instead of Multilingual
  32         https://bugs.webkit.org/show_bug.cgi?id=143641
  33
  34         Reviewed by Dan Bernstein.
  35
  36         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
  37         While at it, override NSUserDictionaryReplacementItems, so that user replacements
  38         cannot affect tests.
  39
  40         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
  41         Made this more like WebKit1 version.
  42
  43 2015-04-10  Tim Horton  <timothy_horton@apple.com>
  44
  45         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
  46         https://bugs.webkit.org/show_bug.cgi?id=143576
  47
  48         Reviewed by Simon Fraser.
  49
  50         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
  51         (TEST):
  52         Adopt.
  53
  54 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
  55
  56         Update my email address and expertise.
  57         https://bugs.webkit.org/show_bug.cgi?id=143586
  58
  59         Unreviewed, just update my info.
  60
  61         * Scripts/webkitpy/common/config/contributors.json:
  62
  63 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
  64
  65         Flakiness Dashboard not loading insecure content if loaded with https URL
  66         https://bugs.webkit.org/show_bug.cgi?id=143570
  67
  68         Reviewed by Alexey Proskuryakov.
  69
  70         * TestResultServer/app.yaml:
  71         * TestResultServer/static-dashboards/loader.js:
  72         Switch to https scheme.
  73
  74 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
  75
  76         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
  77         https://bugs.webkit.org/show_bug.cgi?id=142907
  78
  79         Reviewed by Carlos Garcia Campos.
  80
  81         * TestWebKitAPI/PlatformEfl.cmake:
  82         * TestWebKitAPI/PlatformGTK.cmake:
  83         * WebKitTestRunner/PlatformEfl.cmake:
  84         * WebKitTestRunner/PlatformGTK.cmake:
  85
  86 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
  87
  88         [Mac] Unreviewed test fix after r182584
  89         https://bugs.webkit.org/show_bug.cgi?id=143452
  90
  91         Put both of these tests back to their original state now that the underlying
  92         problem is fixed.
  93
  94         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
  95         (TestWebKitAPI::TEST):
  96         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
  97         (TestWebKitAPI::TEST):
  98
  99 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
 100
 101         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
 102         https://bugs.webkit.org/show_bug.cgi?id=143553
 103
 104         Reviewed by Ryosuke Niwa.
 105
 106         Remove the spurious printVMs left over from an earlier change.
 107
 108         * Scripts/run-jsc-benchmarks:
 109
 110 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 111
 112         [Mac] Unreviewed test fix after r182581
 113
 114         The behavior of control-left-click is controlled by a system preference.
 115         Our test bots have this turned off.
 116
 117         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
 118         (TestWebKitAPI::TEST):
 119         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
 120         (TestWebKitAPI::TEST):
 121
 122 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 123
 124         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
 125         https://bugs.webkit.org/show_bug.cgi?id=143452
 126         <rdar://problem/20437483>
 127
 128         Reviewed by Tim Horton.
 129
 130         Add a new API test to confirm that Cocoa mouse button press events are properly
 131         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
 132
 133         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
 134         some registered event handlers that the expected button press and context menu
 135         events are received.
 136
 137         The WK1 unit test creates an NSEvent with the desired button press state, and then
 138         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
 139         We check the resulting PlatformMouseEvent for proper state.
 140
 141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
 142         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
 143         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
 144         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
 145         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
 146         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
 147         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
 148         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 149         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
 150         mouse down events.
 151         * TestWebKitAPI/mac/PlatformWebViewMac.h:
 152
 153 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
 154
 155         [GTK] Add pango to jhbuild-optional.modules
 156         https://bugs.webkit.org/show_bug.cgi?id=143537
 157
 158         Reviewed by Martin Robinson.
 159
 160         * gtk/jhbuild-optional.modules: Add pango.
 161
 162 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 163
 164         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
 165         https://bugs.webkit.org/show_bug.cgi?id=143530
 166
 167         Reviewed by Žan Doberšek.
 168
 169         Assume that the default value for display (:0) is reserved and start checking on :1
 170         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
 171         and for X server named Xorg.bin (previous bug 1376599)
 172
 173         * Scripts/webkitpy/port/xvfbdriver.py:
 174         (XvfbDriver._next_free_display)
 175         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
 176         (XvfbDriverTest.test_start_no_pixel_tests):
 177         (XvfbDriverTest.test_start_pixel_tests):
 178         (XvfbDriverTest.test_start_arbitrary_worker_number):
 179         (XvfbDriverTest.test_next_free_display):
 180         (XvfbDriverTest.test_start_next_worker):
 181 2015-04-08  Alex Christensen  <achristensen@webkit.org>
 182
 183         Block popups from content extensions.
 184         https://bugs.webkit.org/show_bug.cgi?id=143497
 185
 186         Reviewed by Brady Eidson.
 187
 188         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 189         (TestWebKitAPI::TEST_F):
 190         Added popup test.
 191
 192 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
 193
 194         Add CMake build system for WinCairo port.
 195         https://bugs.webkit.org/show_bug.cgi?id=115944
 196
 197         Reviewed by Chris Dumez.
 198
 199         * CMakeLists.txt:
 200         * WinLauncher/CMakeLists.txt: Added.
 201
 202 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 203
 204         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
 205         https://bugs.webkit.org/show_bug.cgi?id=143521
 206
 207         Reviewed by Martin Robinson.
 208
 209         Add a way to detect unexpected web process crashes to WebViewTest,
 210         and a test case to testDOMCache to trigger the crash.
 211
 212         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
 213         (WebKitDOMNodeTest::testDOMCache):
 214         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
 215         (testWebKitWebViewProcessCrashed):
 216         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
 217         (WebViewTest::WebViewTest):
 218         (WebViewTest::webProcessCrashed):
 219         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
 220
 221 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
 222
 223         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
 224         rdar://problem/20461342
 225
 226         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 227
 228 2015-04-07  Commit Queue  <commit-queue@webkit.org>
 229
 230         Unreviewed, rolling out r182511.
 231         https://bugs.webkit.org/show_bug.cgi?id=143507
 232
 233         caused debug test failures (Requested by alexchristensen on
 234         #webkit).
 235
 236         Reverted changeset:
 237
 238         "Block popups from content extensions."
 239         https://bugs.webkit.org/show_bug.cgi?id=143497
 240         http://trac.webkit.org/changeset/182511
 241
 242 2015-04-07  Alex Christensen  <achristensen@webkit.org>
 243
 244         Block popups from content extensions.
 245         https://bugs.webkit.org/show_bug.cgi?id=143497
 246
 247         Reviewed by Brady Eidson.
 248
 249         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 250         (TestWebKitAPI::TEST_F):
 251         Added popup test.
 252
 253 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
 254
 255         Get the features.json files ready for open contributions
 256         https://bugs.webkit.org/show_bug.cgi?id=143436
 257
 258         Reviewed by Darin Adler.
 259
 260         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 261         (JSONFeaturesChecker.check):
 262         Extend the syntax checking a bit, but leave everything non-mandatory
 263         very loose until we figure what fields are important.
 264
 265 2015-04-07  Tim Horton  <timothy_horton@apple.com>
 266
 267         Expose and test fixedLayoutSize via modern WebKit SPI
 268         https://bugs.webkit.org/show_bug.cgi?id=143500
 269
 270         Reviewed by Simon Fraser.
 271
 272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 273         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
 274         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
 275         (TEST):
 276         Add a test that verifies that fixedLayoutSize works at all, that
 277         it persists through a navigation, and that turning it back off reverts to
 278         laying out at the size of the view.
 279
 280 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
 281
 282         Unreviewed. Add myself as a committer.
 283
 284         * Scripts/webkitpy/common/config/contributors.json:
 285
 286 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
 287
 288         [Win] Bots complain about missing /etc/catalog
 289         https://bugs.webkit.org/show_bug.cgi?id=143484
 290
 291         Reviewed by Chris Dumez.
 292
 293         The libxml2 build on Mac, iOS, and Windows does not provide the set
 294         of default catalog files. We do not actually need these for our
 295         purposes, but we get warnings and some bot flakiness because they
 296         are not present.
 297
 298         We can avoid both problems the same way the Mac and iOS ports do,
 299         by setting the XML_CATALOG_FILES environment variable to 'empty string',
 300         which avoid the warnings and bot problems.
 301
 302         * Scripts/webkitpy/port/win.py:
 303         (WinPort.setup_environ_for_server): Added.
 304
 305 2015-04-06  Sam Weinig  <sam@webkit.org>
 306
 307         Use content extensions in MiniBrowser.
 308         https://bugs.webkit.org/show_bug.cgi?id=143446
 309
 310         Reviewed by Alex Christensen.
 311
 312         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 313         * MiniBrowser/mac/AppDelegate.h:
 314         * MiniBrowser/mac/AppDelegate.m:
 315         (-[BrowserAppDelegate init]):
 316         (-[BrowserAppDelegate showExtensionsManager:]):
 317         (-[BrowserAppDelegate userContentContoller]):
 318         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 319         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 320         (-[ExtensionManagerWindowController init]):
 321         (-[ExtensionManagerWindowController windowDidLoad]):
 322         (-[ExtensionManagerWindowController add:]):
 323         (-[ExtensionManagerWindowController remove:]):
 324         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 325         * MiniBrowser/mac/MainMenu.xib:
 326
 327 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 328
 329         web-platform-tests server should retrieve the modules file relatively to its docroot path
 330         https://bugs.webkit.org/show_bug.cgi?id=142742
 331
 332         Reviewed by Darin Adler.
 333
 334         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 335         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
 336
 337 2015-04-06  Commit Queue  <commit-queue@webkit.org>
 338
 339         Unreviewed, rolling out r182445.
 340         https://bugs.webkit.org/show_bug.cgi?id=143459
 341
 342         broke 32 bit build (Requested by alexchristensen on #webkit).
 343
 344         Reverted changeset:
 345
 346         "Use content extensions in MiniBrowser."
 347         https://bugs.webkit.org/show_bug.cgi?id=143446
 348         http://trac.webkit.org/changeset/182445
 349
 350 2015-04-06  Sam Weinig  <sam@webkit.org>
 351
 352         Use content extensions in MiniBrowser.
 353         https://bugs.webkit.org/show_bug.cgi?id=143446
 354
 355         Reviewed by Alex Christensen.
 356
 357         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 358         * MiniBrowser/mac/AppDelegate.h:
 359         * MiniBrowser/mac/AppDelegate.m:
 360         (-[BrowserAppDelegate init]):
 361         (-[BrowserAppDelegate showExtensionsManager:]):
 362         (-[BrowserAppDelegate userContentContoller]):
 363         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 364         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 365         (-[ExtensionManagerWindowController init]):
 366         (-[ExtensionManagerWindowController windowDidLoad]):
 367         (-[ExtensionManagerWindowController add:]):
 368         (-[ExtensionManagerWindowController remove:]):
 369         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 370         * MiniBrowser/mac/MainMenu.xib:
 371
 372 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
 373
 374         [GTK] install-dependencies should prefer dnf to yum
 375         https://bugs.webkit.org/show_bug.cgi?id=143441
 376
 377         Reviewed by Martin Robinson.
 378
 379         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
 380
 381         * gtk/install-dependencies:
 382
 383 2015-04-06  Andy Estes  <aestes@apple.com>
 384
 385         [iOS] 'make clean' fails in Tools/WebKitTestRunner
 386         https://bugs.webkit.org/show_bug.cgi?id=143455
 387
 388         Reviewed by Dan Bernstein.
 389
 390         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
 391         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
 392
 393         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
 394
 395 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
 396
 397         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
 398         https://bugs.webkit.org/show_bug.cgi?id=143450
 399
 400         Reviewed by Anders Carlsson.
 401
 402         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
 403         Make sure that the view is actually closed, regardless of anything else that happens beneath.
 404         Also, removed unnecessary get() calls.
 405
 406 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
 407
 408         Reduce the dependency on Flash in regression tests
 409         https://bugs.webkit.org/show_bug.cgi?id=143391
 410
 411         Reviewed by Anders Carlsson.
 412
 413         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
 414         Only allow QuickTime and the test plug-in.
 415
 416 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 417
 418         W3C test importer should generate the modules installed dynamically to run wpt tests
 419         https://bugs.webkit.org/show_bug.cgi?id=142738
 420
 421         Reviewed by Ryosuke Niwa.
 422
 423         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
 424         The implementation is done within TestDownloader and it is activated for the WPT repository.
 425         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
 426
 427         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 428         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
 429         * Scripts/webkitpy/w3c/test_downloader.py:
 430         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
 431         (TestDownloader):
 432         (TestDownloader._git_submodules_description): Computes submodule description.
 433         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
 434         * Scripts/webkitpy/w3c/test_importer.py:
 435         (TestImporter.do_import): Added the possibility to post process the tests.
 436         (TestImporter):
 437         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
 438         (TestImporter.should_convert_test_harness_links): Updated according new options format.
 439         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 440         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
 441         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
 442         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
 443         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
 444         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
 445
 446 2015-04-05  Antti Koivisto  <antti@apple.com>
 447
 448         Bloom filter should support longer hashes
 449         https://bugs.webkit.org/show_bug.cgi?id=143419
 450
 451         Reviewed by Dan Bernstein.
 452
 453         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
 454         (TestWebKitAPI::generateRandomDigests):
 455         (TestWebKitAPI::TEST):
 456
 457 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 458
 459         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
 460         https://bugs.webkit.org/show_bug.cgi?id=143372
 461
 462         Reviewed by Darin Adler.
 463
 464         * Scripts/run-jsc-stress-tests:
 465
 466 2015-04-03  Antti Koivisto  <antti@apple.com>
 467
 468         Add non-counting bloom filter class
 469         https://bugs.webkit.org/show_bug.cgi?id=143366
 470
 471         Reviewed by Sam Weinig.
 472
 473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 474         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
 475         (TestWebKitAPI::generateRandomHashes):
 476         (TestWebKitAPI::TEST):
 477
 478 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 479
 480         FTL JIT tests should fail if LLVM library isn't available
 481         https://bugs.webkit.org/show_bug.cgi?id=143374
 482
 483         Reviewed by Mark Lam.
 484
 485         * Scripts/run-jsc-stress-tests:
 486
 487 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 488
 489         [EFL] Speedup jhbuild with disable running autogen.sh
 490         https://bugs.webkit.org/show_bug.cgi?id=143369
 491
 492         Reviewed by Gyuyoung Kim.
 493
 494         * efl/jhbuild.modules:
 495
 496 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 497
 498         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
 499         https://bugs.webkit.org/show_bug.cgi?id=143282
 500
 501         Reviewed by Daniel Bates.
 502
 503         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
 504
 505 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 506
 507         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
 508         https://bugs.webkit.org/show_bug.cgi?id=143240
 509         rdar://problem/19990425
 510
 511         Reviewed by Tim Horton.
 512
 513         * DumpRenderTree/mac/LayoutTestHelper.m:
 514         (colorProfileURLForDisplay):
 515         (saveDisplayColorProfiles):
 516         Gracefully handle it when the current profile cannot be retrieved, fixing at
 517         least one case when LayoutTestHelper couldn't start.
 518
 519         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 520         (Manager._set_up_run):
 521         (Manager._force_pixel_tests_if_needed):
 522         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
 523         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
 524         Return and check an error from start_helper().
 525
 526 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
 527
 528         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
 529         https://bugs.webkit.org/show_bug.cgi?id=143321
 530
 531         Reviewed by Alexey Proskuryakov.
 532
 533         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
 534
 535 2015-04-01  Enrica Casucci  <enrica@apple.com>
 536
 537         Injected bundle messages should be at the page level.
 538         https://bugs.webkit.org/show_bug.cgi?id=143283
 539
 540         Reviewed by Alexey Proskuryakov.
 541
 542         Updating WebKitTestRunner to use the new page level messaging.
 543         The author of this patch is Tim Horton, I just finished it.
 544
 545         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 546         (WTR::EventSendingController::mouseDown):
 547         (WTR::EventSendingController::mouseUp):
 548         (WTR::EventSendingController::mouseMoveTo):
 549         (WTR::EventSendingController::leapForward):
 550         (WTR::EventSendingController::scheduleAsynchronousClick):
 551         (WTR::EventSendingController::keyDown):
 552         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
 553         (WTR::EventSendingController::mouseScrollBy):
 554         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
 555         (WTR::EventSendingController::continuousMouseScrollBy):
 556         (WTR::EventSendingController::addTouchPoint):
 557         (WTR::EventSendingController::updateTouchPoint):
 558         (WTR::EventSendingController::setTouchModifier):
 559         (WTR::EventSendingController::setTouchPointRadius):
 560         (WTR::EventSendingController::touchStart):
 561         (WTR::EventSendingController::touchMove):
 562         (WTR::EventSendingController::touchEnd):
 563         (WTR::EventSendingController::touchCancel):
 564         (WTR::EventSendingController::clearTouchPoints):
 565         (WTR::EventSendingController::releaseTouchPoint):
 566         (WTR::EventSendingController::cancelTouchPoint):
 567         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 568         (WTR::InjectedBundle::didReceiveMessage):
 569         (WTR::InjectedBundle::didReceiveMessageToPage):
 570         (WTR::InjectedBundle::done):
 571         (WTR::InjectedBundle::outputText):
 572         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
 573         (WTR::InjectedBundle::postAddChromeInputField):
 574         (WTR::InjectedBundle::postRemoveChromeInputField):
 575         (WTR::InjectedBundle::postFocusWebView):
 576         (WTR::InjectedBundle::postSetBackingScaleFactor):
 577         (WTR::InjectedBundle::postSetWindowIsKey):
 578         (WTR::InjectedBundle::postSimulateWebNotificationClick):
 579         (WTR::InjectedBundle::postSetAddsVisitedLinks):
 580         (WTR::InjectedBundle::setGeolocationPermission):
 581         (WTR::InjectedBundle::setMockGeolocationPosition):
 582         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
 583         (WTR::InjectedBundle::setUserMediaPermission):
 584         (WTR::InjectedBundle::setCustomPolicyDelegate):
 585         (WTR::InjectedBundle::setHidden):
 586         (WTR::InjectedBundle::setCacheModel):
 587         (WTR::InjectedBundle::shouldProcessWorkQueue):
 588         (WTR::InjectedBundle::processWorkQueue):
 589         (WTR::InjectedBundle::queueBackNavigation):
 590         (WTR::InjectedBundle::queueForwardNavigation):
 591         (WTR::InjectedBundle::queueLoad):
 592         (WTR::InjectedBundle::queueLoadHTMLString):
 593         (WTR::InjectedBundle::queueReload):
 594         (WTR::InjectedBundle::queueLoadingScript):
 595         (WTR::InjectedBundle::queueNonLoadingScript):
 596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 597         (WTR::TestRunner::setHandlesAuthenticationChallenges):
 598         (WTR::TestRunner::setAuthenticationUsername):
 599         (WTR::TestRunner::setAuthenticationPassword):
 600         (WTR::TestRunner::secureEventInputIsEnabled):
 601         (WTR::TestRunner::setBlockAllPlugins):
 602         * WebKitTestRunner/TestController.cpp:
 603         (WTR::TestController::createWebViewWithOptions):
 604         (WTR::TestController::resetStateToConsistentValues):
 605         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
 606         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
 607         * WebKitTestRunner/TestController.h:
 608         * WebKitTestRunner/TestInvocation.cpp:
 609         (WTR::TestInvocation::invoke):
 610         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 611
 612 2015-04-01  Commit Queue  <commit-queue@webkit.org>
 613
 614         Unreviewed, rolling out r182174 and r182177.
 615         https://bugs.webkit.org/show_bug.cgi?id=143314
 616
 617         Try to correct EWS failures (Requested by bfulgham on
 618         #webkit).
 619
 620         Reverted changesets:
 621
 622         "Python SCM should be able to retrieve untracked files"
 623         https://bugs.webkit.org/show_bug.cgi?id=143135
 624         http://trac.webkit.org/changeset/182174
 625
 626         "[buildbot] clean-build script should remove untracked files
 627         and revert local changes too"
 628         https://bugs.webkit.org/show_bug.cgi?id=142400
 629         http://trac.webkit.org/changeset/182177
 630
 631 2015-04-01  Alex Christensen  <achristensen@webkit.org>
 632
 633         [Content Extensions] Properly handle regexes that match everything.
 634         https://bugs.webkit.org/show_bug.cgi?id=143281
 635
 636         Reviewed by Benjamin Poulain.
 637
 638         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 639         (TestWebKitAPI::testRequest):
 640         (TestWebKitAPI::makeBackend):
 641         (TestWebKitAPI::TEST_F):
 642         Removed duplicate code and added test.
 643
 644 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
 645
 646         Content Extensions: split the state machines to minimize prefix states
 647         https://bugs.webkit.org/show_bug.cgi?id=143253
 648
 649         Reviewed by Alex Christensen.
 650
 651         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 652         (TestWebKitAPI::TEST_F):
 653         (TestWebKitAPI::testPatternStatus):
 654
 655 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
 656
 657         Clean up Identifier factories to clarify the meaning of StringImpl*
 658         https://bugs.webkit.org/show_bug.cgi?id=143146
 659
 660         Reviewed by Filip Pizlo.
 661
 662         Simple API tests for StringImpl are added.
 663
 664         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 665         (TestWebKitAPI::TEST):
 666
 667 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
 668
 669         [EFL] Add AArch64 builder and tester bot to build.webkit.org
 670         https://bugs.webkit.org/show_bug.cgi?id=143092
 671
 672         Reviewed by Gyuyoung Kim.
 673
 674         * BuildSlaveSupport/build.webkit.org-config/config.json:
 675         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 676         (Factory.__init__):
 677         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 678
 679 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 680
 681         [buildbot] clean-build script should remove untracked files and revert local changes too
 682         https://bugs.webkit.org/show_bug.cgi?id=142400
 683
 684         Reviewed by Ryosuke Niwa.
 685
 686         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 687         A helper routine SCM.discard_untracked_files is added for that purpose.
 688
 689         * BuildSlaveSupport/clean-build:
 690         (main): Making call to Scripts/clean-webkit
 691         * Scripts/clean-webkit: Added.
 692         (main): Revert changes and delete untracked files.
 693         * Scripts/webkitpy/common/checkout/scm/scm.py:
 694         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 695         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 696         (SCMTest._shared_test_discard_untracked_files):
 697         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 698
 699 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 700
 701         Python SCM should be able to retrieve untracked files
 702         https://bugs.webkit.org/show_bug.cgi?id=143135
 703
 704         Reviewed by Ryosuke Niwa.
 705
 706         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
 707         Ignored files may be included or not in this list according boolean passed to the function.
 708
 709         * Scripts/webkitpy/common/checkout/scm/git.py:
 710         (Git.untracked_files):
 711         * Scripts/webkitpy/common/checkout/scm/scm.py:
 712         (SCM.untracked_files):
 713         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 714         (SCMTest._shared_test_untracked_files):
 715         (test_untracked_files):
 716         (GitSVNTest.test_untracked_files):
 717         * Scripts/webkitpy/common/checkout/scm/svn.py:
 718         (SVN.untracked_files):
 719
 720 2015-03-30  Alex Christensen  <achristensen@webkit.org>
 721
 722         [Content Extensions] Correctly handle regular expressions matching everything
 723         https://bugs.webkit.org/show_bug.cgi?id=143235
 724
 725         Reviewed by Benjamin Poulain.
 726
 727         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 728         (TestWebKitAPI::checkCompilerError):
 729         (TestWebKitAPI::TEST_F):
 730         Test ContentExtensionErrors.
 731
 732 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
 733
 734         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
 735         https://bugs.webkit.org/show_bug.cgi?id=143241
 736         rdar://problem/20351297
 737
 738         Reviewed by Mark Lam.
 739
 740         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
 741
 742 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 743
 744         [CMake][EFL] Remove redundant library link and include path
 745         https://bugs.webkit.org/show_bug.cgi?id=143221
 746
 747         Reviewed by Csaba Osztrogonác.
 748
 749         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
 750
 751 2015-03-30  Sam Weinig  <sam@webkit.org>
 752
 753         [Content Extensions] Flesh out the UserContentExtensionStore
 754         https://bugs.webkit.org/show_bug.cgi?id=143123
 755
 756         Reviewed by Benjamin Poulain.
 757
 758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 759         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
 760         Add tests for _WKUserContentExtensionStore.
 761
 762 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
 763
 764         Update install-dependencies Fedora packages after r181624
 765         https://bugs.webkit.org/show_bug.cgi?id=143215
 766
 767         Add json-glib, libv4l, openssl and pulseaudio development packages to
 768         the Fedora list providing we need them to build WebKit dependencies
 769         for this distribution.
 770
 771         Reviewed by Philippe Normand.
 772
 773         * gtk/install-dependencies:
 774
 775 2015-03-30  Commit Queue  <commit-queue@webkit.org>
 776
 777         Unreviewed, rolling out r182119.
 778         https://bugs.webkit.org/show_bug.cgi?id=143196
 779
 780         problem with syntax (Requested by youenn on #webkit).
 781
 782         Reverted changeset:
 783
 784         "[buildbot] clean-build script should remove untracked files
 785         and revert local changes too"
 786         https://bugs.webkit.org/show_bug.cgi?id=142400
 787         http://trac.webkit.org/changeset/182119
 788
 789 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
 790
 791         Start the features.json files
 792         https://bugs.webkit.org/show_bug.cgi?id=143207
 793
 794         Reviewed by Darin Adler.
 795
 796         I kept the style checking light. We'll have to figure
 797         what is the best format for each field.
 798
 799         * Scripts/webkitpy/style/checker.py:
 800         (CheckerDispatcher._create_checker):
 801         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 802         (JSONContributorsChecker.check):
 803         (JSONFeaturesChecker):
 804         (JSONFeaturesChecker.check):
 805
 806 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 807
 808         [buildbot] clean-build script should remove untracked files and revert local changes too
 809         https://bugs.webkit.org/show_bug.cgi?id=142400
 810
 811         Reviewed by Ryosuke Niwa.
 812
 813         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
 814
 815         * BuildSlaveSupport/clean-build:
 816         (main): Adding call to Tools/Scripts/clean-webkit.
 817         * Scripts/clean-webkit: Added.
 818         (main): Removes untracked and changed files.
 819         * Scripts/webkitpy/common/checkout/scm/git.py:
 820         (Git.untracked_files): Retrieves GIT untracked files.
 821         * Scripts/webkitpy/common/checkout/scm/scm.py:
 822         (SCM.untracked_files): Retrieves SVN untracked files.
 823         (SCM):
 824         (SCM.discard_untracked_files): Deletes untracked files/folders.
 825         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 826         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
 827         (test_untracked_files):
 828         (GitSVNTest.test_untracked_files):
 829         * Scripts/webkitpy/common/checkout/scm/svn.py:
 830         (SVN.untracked_files):
 831
 832 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 833
 834         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
 835         https://bugs.webkit.org/show_bug.cgi?id=143138
 836
 837         Reviewed by Csaba Osztrogonác.
 838
 839         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
 840         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
 841
 842         * ImageDiff/CMakeLists.txt:
 843         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
 844         * WebKitTestRunner/CMakeLists.txt: ditto.
 845
 846 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
 847
 848         Support building WTF on Windows without Cygwin
 849         https://bugs.webkit.org/show_bug.cgi?id=143084
 850
 851         Reviewed by Brent Fulgham.
 852
 853         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
 854         This patch also migrates to using File::Spec->catfile() for directory separators.
 855
 856         * Scripts/update-webkit-dependency:
 857         (wanted):
 858         * Scripts/update-webkit-support-libs:
 859         (wanted):
 860         (downloadExpectedVersionNumber):
 861         (zipFileVersion):
 862         (toUnixPath): Deleted.
 863         * Scripts/webkitdirs.pm:
 864         (determineSourceDir):
 865         (windowsSourceSourceDir):
 866         (windowsLibrariesDir):
 867         (windowsOutputDir):
 868         (checkInstalledTools):
 869         (buildVisualStudioProject):
 870
 871 2015-03-27  Alex Christensen  <achristensen@webkit.org>
 872
 873         Fix WinCairo bot.
 874         https://bugs.webkit.org/show_bug.cgi?id=143086
 875
 876         Reviewed by Brent Fulgham.
 877
 878         * Scripts/webkitdirs.pm:
 879         (buildVisualStudioProject):
 880         (runSvnUpdateAndResolveChangeLogs):
 881         Use ActivePerl-friendly perl.
 882
 883 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
 884
 885         URTBF after r182059 to fix the EFL build.
 886
 887         * TestWebKitAPI/CMakeLists.txt:
 888
 889 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
 890
 891         Layout test results URL loads in WK1 but not WK2 minibrowser
 892         https://bugs.webkit.org/show_bug.cgi?id=143117
 893
 894         Reviewed by Tim Horton.
 895
 896         * MiniBrowser/mac/WK2BrowserWindowController.m:
 897         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
 898         everything.
 899         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
 900
 901 2015-03-26  Jer Noble  <jer.noble@apple.com>
 902
 903         Add --allowed-host support to run-webkit-tests
 904         https://bugs.webkit.org/show_bug.cgi?id=142938
 905
 906         Reviewed by Brent Fulgham.
 907
 908         Accept --allowed-host arguments from run-webkit-tests and pass them through to
 909         DumpRenderTree and WebKitTestRunner.
 910
 911         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
 912         are placed in the wrong location. The argument is compared with each tests's path, and if a
 913         relative path or a path with '..' was used, results are placed alongside the test. Take the
 914         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
 915
 916         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 917         (parse_args):
 918         * Scripts/webkitpy/port/base.py:
 919         (Port.__init__):
 920         (Port.allowed_hosts):
 921         * Scripts/webkitpy/port/driver.py:
 922         (Driver.cmd_line):
 923
 924 2015-03-26  Jer Noble  <jer.noble@apple.com>
 925
 926         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
 927         https://bugs.webkit.org/show_bug.cgi?id=142931
 928
 929         Reviewed by Brent Fulgham.
 930
 931         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
 932         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
 933         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
 934         runtime.
 935
 936         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
 937         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
 938
 939         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
 940         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
 941         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
 942         the top loading frame from the page, as we do elsewhere in this class.
 943
 944         * DumpRenderTree/TestRunner.h:
 945         (TestRunner::allowedHosts):
 946         (TestRunner::setAllowedHosts):
 947         * DumpRenderTree/mac/DumpRenderTree.mm:
 948         (initializeGlobalsFromCommandLineOptions):
 949         (runTest):
 950         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 951         (isAllowedHost):
 952         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 953         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 954         (WTR::InjectedBundle::didReceiveMessage):
 955         (WTR::InjectedBundle::isAllowedHost):
 956         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 958         (WTR::isAllowedHost):
 959         (WTR::InjectedBundlePage::willSendRequestForFrame):
 960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 961         * WebKitTestRunner/Options.cpp:
 962         (WTR::handleOptionAllowedHost):
 963         (WTR::OptionsHandler::OptionsHandler):
 964         * WebKitTestRunner/Options.h:
 965         * WebKitTestRunner/TestController.cpp:
 966         (WTR::TestController::initialize):
 967         (WTR::TestController::resetStateToConsistentValues):
 968         * WebKitTestRunner/TestController.h:
 969
 970 2015-03-26  Brady Eidson  <beidson@apple.com>
 971
 972         Apply ContentExtension actions after redirects.
 973         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
 974
 975         Reviewed by Alex Christensen.
 976
 977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 978         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
 979           which is specifically interesting to a new test.
 980
 981 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 982
 983         [EFL] Disable building libseccomp on AArch64
 984         https://bugs.webkit.org/show_bug.cgi?id=143094
 985
 986         Reviewed by Gyuyoung Kim.
 987
 988         * efl/jhbuildrc:
 989
 990 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 991
 992         [jhbuild] git should use only 1 thread for cloning jhbuild
 993         https://bugs.webkit.org/show_bug.cgi?id=143095
 994
 995         Reviewed by Gyuyoung Kim.
 996
 997         * jhbuild/jhbuild-wrapper:
 998         (clone_jhbuild):
 999
1000 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1001
1002         Update prepare-ChangeLog to work with ES6 Class syntax
1003         https://bugs.webkit.org/show_bug.cgi?id=143069
1004
1005         Reviewed by Timothy Hatcher.
1006
1007         * Scripts/prepare-ChangeLog:
1008         (get_function_line_ranges_for_javascript):
1009         Better handle ES6 Class syntax.
1010
1011         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1012         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1013         (BaseClass):
1014         (DerivedClass):
1015         (DerivedClass.staticMethod):
1016         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1017         (DerivedClass.prototype.method):
1018         (DerivedClass.prototype.get getter):
1019         (namespace.MyClass):
1020         (namespace.MyClass.staticMethod):
1021         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1022         (namespace.MyClass.prototype.method):
1023         (namespace.MyClass.prototype.get getter):
1024         Proof!
1025
1026 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1027
1028         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1029         https://bugs.webkit.org/show_bug.cgi?id=142993
1030
1031         Reviewed by Mark Lam.
1032
1033         Bunch of support for testing executable allocation failure.
1034
1035         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1036         (fail):
1037         * Scripts/run-javascriptcore-tests:
1038         (runJSCStressTests):
1039         * Scripts/run-jsc-stress-tests:
1040
1041 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1042
1043         Fix Windows build from r181977.
1044
1045         Unreviewed.
1046
1047         * Scripts/update-webkit-dependency:
1048
1049 2015-03-25  Sam Weinig  <sam@webkit.org>
1050
1051         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1052
1053         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1054         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1055
1056 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1057
1058         Migrate update-webkit for Windows to not require Cygwin
1059         https://bugs.webkit.org/show_bug.cgi?id=143040
1060
1061         Reviewed by Brent Fulgham.
1062
1063         * Scripts/update-webkit-dependency:
1064         (wanted):
1065         (toUnixPath): Deleted.
1066         * Scripts/webkitdirs.pm:
1067         (fontExists):
1068         (checkInstalledTools):
1069         (setupAppleWinEnv):
1070
1071 2015-03-25  Sam Weinig  <sam@webkit.org>
1072
1073         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1074         https://bugs.webkit.org/show_bug.cgi?id=143059
1075
1076         Reviewed by Alex Christensen.
1077
1078         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1079         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1080         Update for new interface of compileRuleList().
1081
1082 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1083
1084         [Content Extensions] Add multi-DFA compiling and interpreting.
1085         https://bugs.webkit.org/show_bug.cgi?id=143010
1086
1087         Reviewed by Benjamin Poulain.
1088
1089         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1090         (TestWebKitAPI::testRequest):
1091         (TestWebKitAPI::TEST_F):
1092         Add some tests for ignore-previous-rules and large rulesets.
1093
1094 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1095
1096         Mavericks WK1 still runs JSC tests
1097         https://bugs.webkit.org/show_bug.cgi?id=143035
1098
1099         Reviewed by Csaba Osztrogonác.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1102         with other bots.
1103
1104         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1105         accordingly.
1106
1107 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1108
1109         Unreviewed, rolling out r181932.
1110         https://bugs.webkit.org/show_bug.cgi?id=143041
1111
1112         The test fails most of the time on bots (Requested by ap on
1113         #webkit).
1114
1115         Reverted changeset:
1116
1117         "[Content Extensions] Add multi-DFA compiling and
1118         interpreting."
1119         https://bugs.webkit.org/show_bug.cgi?id=143010
1120         http://trac.webkit.org/changeset/181932
1121
1122 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1123
1124         [Content Extensions] Add multi-DFA compiling and interpreting.
1125         https://bugs.webkit.org/show_bug.cgi?id=143010
1126
1127         Reviewed by Benjamin Poulain.
1128
1129         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1130         (TestWebKitAPI::testRequest):
1131         (TestWebKitAPI::TEST_F):
1132         Add some tests for ignore-previous-rules and large rulesets.
1133
1134 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1135
1136         Make URL filter patterns matching consistent and add a simple canonicalization step
1137         https://bugs.webkit.org/show_bug.cgi?id=142998
1138
1139         Reviewed by Alex Christensen.
1140
1141         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1142
1143 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1144
1145         [EFL] Add OpenWebRTC in jhbuild
1146         https://bugs.webkit.org/show_bug.cgi?id=142778
1147
1148         Reviewed by Gyuyoung Kim.
1149
1150         Original patch by Philippe Normand <pnormand@igalia.com>
1151
1152         * efl/install-dependencies: Dependencies for OpenWebRTC.
1153         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1154         the openwebrtc gst plugins.
1155
1156 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1157
1158         Regression(r181257): WTF_WorkQueue.Simple is flaky
1159         https://bugs.webkit.org/show_bug.cgi?id=142560
1160
1161         Remove the check that the refCount has returned to one after the
1162         individual tasks have completed. It's too nondeterministic when
1163         the reference count will be reduced.
1164
1165         Reviewed by Alexey Proskuryakov
1166
1167         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1168         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1169
1170 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1171
1172         [CMake][EFL] Put failure API test excutables into failure directory
1173         https://bugs.webkit.org/show_bug.cgi?id=142965
1174
1175         Reviewed by Csaba Osztrogonác.
1176
1177         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1178
1179         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1180         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1181
1182 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1183
1184         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1185         https://bugs.webkit.org/show_bug.cgi?id=142932
1186
1187         Reviewed by Darin Adler.
1188
1189         Add tests for the new features and fix some existing tests using the
1190         stringFromUTF8() utility recently added by Dhi.
1191
1192         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1193         (TestWebKitAPI::stringFromUTF8):
1194         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1195
1196 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1197
1198         [GTK] install-dependencies should install orc
1199         https://bugs.webkit.org/show_bug.cgi?id=142955
1200
1201         Reviewed by Martin Robinson.
1202
1203         Install orc, needed by openwebrtc
1204
1205         * gtk/install-dependencies:
1206
1207 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1208
1209         Detect when url filter pattern with groups match the empty string
1210         https://bugs.webkit.org/show_bug.cgi?id=142930
1211
1212         Reviewed by Sam Weinig.
1213
1214         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1215
1216 2015-03-22  Anders Carlsson  <andersca@apple.com>
1217
1218         _WKWebsiteDataStore should clear WebSQL databases
1219         https://bugs.webkit.org/show_bug.cgi?id=142947
1220
1221         Reviewed by Sam Weinig.
1222
1223         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1224
1225         * MiniBrowser/mac/WK2BrowserWindowController.m:
1226         (-[WK2BrowserWindowController fetchWebsiteData:]):
1227         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1228         (-[WK2BrowserWindowController clearWebsiteData:]):
1229
1230 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1231
1232         GCTimer should know keep track of nested GC phases
1233         https://bugs.webkit.org/show_bug.cgi?id=142675
1234
1235         Reviewed by Darin Adler.
1236
1237         Adds a tool to aid in parsing the GC phase timing output into a
1238         tree-like structure based on the parent-child relationships
1239         of nested GC phases.
1240
1241         * Scripts/parse-gc-phase-timings: Added.
1242         (Timing):
1243         (Timing.__init__):
1244         (Timing.__unicode__):
1245         (Timing.__str__):
1246         (Timing.__repr__):
1247         (parse_input):
1248         (print_timing_node):
1249         (print_timing_tree):
1250         (link_parents):
1251         (main):
1252
1253 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1254
1255         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1256
1257         * Scripts/webkitpy/common/config/ews.json:
1258
1259 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1260
1261         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1262         https://bugs.webkit.org/show_bug.cgi?id=142867
1263
1264         Rubber-stamped by Csaba Osztrogon.
1265
1266         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1267         a fixed revision for the openwebrtc-gst-plugins.
1268
1269 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1270
1271         Unreviewed build fix. Don't try to report stats for all benchmarks.
1272         Just report the geometric mean of preferred means.
1273
1274         * Scripts/run-jsc-benchmarks:
1275
1276 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1277
1278         run-jsc-benchmarks should only report preferred mean
1279         https://bugs.webkit.org/show_bug.cgi?id=142874
1280
1281         Reviewed by Geoffrey Garen.
1282
1283         Just collect statistics for the preferred mean.
1284
1285         * Scripts/run-jsc-benchmarks:
1286
1287 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1288
1289         [Content Extensions] Test regular expression parse failures.
1290         https://bugs.webkit.org/show_bug.cgi?id=142872
1291
1292         Reviewed by Benjamin Poulain.
1293
1294         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1295         (TestWebKitAPI::testPatternStatus):
1296         (TestWebKitAPI::TEST_F):
1297         Added tests for each parsing status.
1298
1299 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1300
1301         Fix API tests after r181754.
1302
1303         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1304         (TestWebKitAPI::testRequest):
1305
1306 2015-03-19  Brady Eidson  <beidson@apple.com>
1307
1308         Part of content extensions should apply css selectors
1309         https://bugs.webkit.org/show_bug.cgi?id=142604
1310
1311         Reviewed by Alex Christensen.
1312
1313         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1314         (WebCore::ContentExtensions::operator<<):
1315
1316 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1317
1318         [Win] Activate tests on EWS
1319         https://bugs.webkit.org/show_bug.cgi?id=142850
1320
1321         Reviewed by Alexey Proskuryakov.
1322
1323         * Scripts/webkitpy/common/config/ews.json: Add me as
1324         the EWS bot watcher, and activate tests.
1325
1326 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1327
1328         [GTK] Fix inspector userinterface related incremental build issue
1329         https://bugs.webkit.org/show_bug.cgi?id=142849
1330
1331         Reviewed by Carlos Garcia Campos.
1332
1333         * Scripts/webkitdirs.pm:
1334         (shouldRemoveCMakeCache):
1335
1336 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1337
1338         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1339         https://bugs.webkit.org/show_bug.cgi?id=142799
1340
1341         Reviewed by Brady Eidson.
1342
1343         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1344         (TestWebKitAPI::testPattern):
1345         (TestWebKitAPI::TEST_F):
1346         Start testing regex failures.
1347
1348 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1349
1350         Fix StringView typos after r181525 and r181558
1351         https://bugs.webkit.org/show_bug.cgi?id=142772
1352
1353         Reviewed by Darin Adler.
1354
1355         Add some tests in [1] to cover the StringView::startsWith,
1356         StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1357         StringView::endsWithIgnoringASCIICase implementations.
1358
1359         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1360         (TestWebKitAPI::TEST):
1361
1362 2015-03-18  Dana Burkart  <dburkart@apple.com>
1363
1364         Remove extraneous import to fix the build.
1365
1366         Unreviewed.
1367
1368         * Scripts/webkitpy/port/driver.py:
1369
1370 2015-03-18  Dana Burkart  <dburkart@apple.com>
1371
1372         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1373         https://bugs.webkit.org/show_bug.cgi?id=142547
1374
1375         Reviewed by Alexey Proskuryakov.
1376
1377         * Scripts/webkitpy/port/driver.py:
1378         (Driver._setup_environ_for_driver):
1379
1380 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1381
1382         Tweak how AppleSystemFontOSSubversion default is added
1383         https://bugs.webkit.org/show_bug.cgi?id=142835
1384
1385         Reviewed by Dan Bernstein.
1386
1387         * DumpRenderTree/mac/DumpRenderTree.mm:
1388         (setDefaultsToConsistentValuesForTesting):
1389
1390 2015-03-18  Dan Bernstein  <mitz@apple.com>
1391
1392         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1393         https://bugs.webkit.org/show_bug.cgi?id=142815
1394
1395         Reviewed by Darin Adler.
1396
1397         * Scripts/prepare-ChangeLog:
1398         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1399         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1400         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1401         warning only if a line ends without a backslash before the matching quotation mark was found.
1402
1403 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1404
1405         Remove unused "preprocessor" parameter to sub-CodeGenerators
1406         https://bugs.webkit.org/show_bug.cgi?id=142793
1407
1408         Reviewed by Darin Adler.
1409
1410         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1411         (new):
1412
1413 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1414
1415         [EFL] Bump gstreamer version to 1.4.4
1416         https://bugs.webkit.org/show_bug.cgi?id=142782
1417
1418         Reviewed by Philippe Normand.
1419
1420         * efl/jhbuild.modules:
1421         * efl/patches/gst-libav.patch:
1422         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1423         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1424
1425 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1426
1427         Fix the iOS build.
1428
1429         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1430         (WTR::InjectedBundle::platformInitialize):
1431
1432 2015-03-17  Dean Jackson  <dino@apple.com>
1433
1434         check-webkit-style should allow "bool a : 1"
1435         https://bugs.webkit.org/show_bug.cgi?id=142794
1436
1437         Reviewed by Brent Fulgham.
1438
1439         We should allow member bitfields of the form:
1440
1441         bool m_var : 1;
1442
1443         It seems that Visual Studio 8 was the last compiler that
1444         wasn't happy about not using unsigned here. We already have
1445         about 500 cases (in WebCore) where people were ignoring this rule.
1446
1447         * Scripts/webkitpy/style/checkers/cpp.py:
1448         (check_language): Allow "bool".
1449         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1450         (CppStyleTest.test_enum_bitfields):
1451         (CppStyleTest.test_plain_integral_bitfields):
1452
1453 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1454
1455         Compile character ranges targeting the same state as range check in the bytecode
1456         https://bugs.webkit.org/show_bug.cgi?id=142759
1457
1458         Reviewed by Alex Christensen.
1459
1460         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1461         (TestWebKitAPI::TEST_F):
1462
1463 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1464
1465         W3C test parser and converter should use test importer host
1466         https://bugs.webkit.org/show_bug.cgi?id=142729
1467
1468         Reviewed by Bem Jones-Bey.
1469
1470         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1471         This enables adding more TestImporter unit testing.
1472         This patch also ensures that the git object instantiated by TestDownloader is using the
1473         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1474
1475         * Scripts/webkitpy/common/system/filesystem_mock.py:
1476         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1477         * Scripts/webkitpy/w3c/test_downloader.py:
1478         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1479         (TestDownloader.checkout_test_repository): Making use of the new git function.
1480         * Scripts/webkitpy/w3c/test_importer.py:
1481         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1482         (TestImporter.import_tests): Adding host as parameter to the converter.
1483         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1484         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1485         (TestImporterTest):
1486         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1487         * Scripts/webkitpy/w3c/test_parser.py:
1488         (TestParser.__init__): Adding host as parameter constructor.
1489
1490 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1491
1492         [GTK] WebKitDOM objects leaking
1493         https://bugs.webkit.org/show_bug.cgi?id=118788
1494
1495         Reviewed by Darin Adler and Sergio Villar Senin.
1496
1497         Update DOMObjectCache unit test to check that DOM objects are also
1498         released when new contents are loaded in the web view, and the old
1499         document is detached from the frame.
1500
1501         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1502         (testWebKitDOMObjectCache):
1503         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1504         (runTest):
1505
1506 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1507
1508         W3C test importer default import folder should be LayoutTests/imported/w3c
1509         https://bugs.webkit.org/show_bug.cgi?id=142728
1510
1511         Reviewed by Bem Jones-Bey.
1512
1513         * Scripts/webkitpy/w3c/test_importer.py:
1514         (parse_args): Updating the default destination option value to 'imported/w3c'.
1515
1516 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1517
1518         [GTK] basic OpenWebRTC build support
1519         https://bugs.webkit.org/show_bug.cgi?id=142393
1520
1521         Reviewed by Carlos Garcia Campos.
1522
1523         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1524         is not the upstream OpenWebRTC repository. This temporary fork
1525         contains a few patches needed by WebKit for audio/video rendering.
1526
1527 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1528
1529         [CMake][EFL] Build test tools only for developer mode
1530         https://bugs.webkit.org/show_bug.cgi?id=142761
1531
1532         Reviewed by Csaba Osztrogonác.
1533
1534         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1535
1536         * CMakeLists.txt:
1537
1538 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1539
1540         Remove never used "useLayerOnTop" bindings generator argument
1541         https://bugs.webkit.org/show_bug.cgi?id=142773
1542
1543         Reviewed by Darin Adler.
1544
1545         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1546         (new):
1547
1548 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1549
1550         Enable ES6 classes by default
1551         https://bugs.webkit.org/show_bug.cgi?id=142774
1552
1553         Reviewed by Gavin Barraclough.
1554
1555         * Scripts/webkitperl/FeatureList.pm:
1556
1557 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1558
1559         Fix webkitpy tests after r181585.
1560
1561         Looks like "me" cannot be anyone's email, it's a special case.
1562
1563         * Scripts/webkitpy/common/config/contributors.json:
1564
1565 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1566
1567         Add tolerance to WebAudio tests
1568         https://bugs.webkit.org/show_bug.cgi?id=142676
1569
1570         Reviewed by Tim Horton.
1571
1572         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1573
1574         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1575         (TestResultWriter.create_audio_diff_and_write_result):
1576         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1577         (FailureAudio.write_failure):
1578         * Scripts/webkitpy/port/base.py:
1579         (Port.do_audio_results_differ):
1580         Diff audio failures.
1581
1582         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1583         tests to use real parseable WAV data, and got rid of base64, which there didn't
1584         seem to have been any reason for.
1585
1586 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1587
1588         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1589         https://bugs.webkit.org/show_bug.cgi?id=142720
1590
1591         Reviewed by Myles C. Maxfield.
1592
1593         Activate system copies of Microsoft fonts for the current process, thus overriding
1594         any other ones that could be preferred by the system otherwise.
1595
1596         * DumpRenderTree/mac/DumpRenderTree.mm:
1597         (activateSystemCoreWebFonts):
1598         (adjustFonts):
1599         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1600         (WTR::activateSystemCoreWebFonts):
1601         (WTR::activateFonts):
1602
1603 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1604
1605         Created Streams API watchlist
1606         https://bugs.webkit.org/show_bug.cgi?id=142684
1607
1608         Reviewed by Benjamin Poulain.
1609
1610         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1611         watchlist and added Benjamin, Youenn and me to it.
1612
1613 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1614
1615         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1616         https://bugs.webkit.org/show_bug.cgi?id=142715
1617
1618         Reviewed by Brent Fulgham.
1619
1620         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1621         (TestWebKitAPI::TEST):
1622
1623 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1624
1625         Change the exact attribute matching to be ASCII case-insensitive
1626         https://bugs.webkit.org/show_bug.cgi?id=142609
1627
1628         Reviewed by Darin Adler.
1629
1630         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1631         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1632
1633 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1634
1635         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1636         https://bugs.webkit.org/show_bug.cgi?id=134764
1637
1638         Reviewed by Ryosuke Niwa.
1639
1640         TestDownloader is introduced to download W3C tests from the official
1641         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1642         and https://github.com/w3c/csswg-test.git).
1643         TestDownloader clones the repositories and checkouts revisions of the tests
1644         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1645
1646         Similarly to https://codereview.chromium.org/148173016,
1647         TestDownloader copies part of the files based on the rules
1648         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1649
1650         TestDownloader is used by TestImporter when no source directory is provided.
1651
1652         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1653         (TestDownloader):
1654         (TestDownloader.default_options):
1655         (TestDownloader.load_test_repositories):
1656         (TestDownloader.__init__):
1657         (TestDownloader.checkout_test_repository):
1658         (TestDownloader._init_paths_from_expectations):
1659         (TestDownloader._add_test_suite_paths):
1660         (TestDownloader._empty_directory):
1661         (TestDownloader.copy_tests):
1662         (TestDownloader.download_tests):
1663         * Scripts/webkitpy/w3c/test_importer.py:
1664         (main):
1665         (parse_args):
1666         (TestImporter.__init__):
1667         (TestImporter.do_import):
1668         (TestImporter.test_downloader):
1669         (TestImporter.find_importable_tests.should_keep_subdir):
1670         (TestImporter.should_convert_test_harness_links):
1671         (TestImporter.import_tests):
1672         (TestImporter.write_import_log):
1673
1674 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1675
1676         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1677         https://bugs.webkit.org/show_bug.cgi?id=142630
1678
1679         Reviewed by Tim Horton.
1680
1681         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1682         Removed an ifdef that disabled the fix on Mavericks.
1683
1684 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1685
1686         Remove isWK2 cruft from webkitdirs.pm after r170426
1687         https://bugs.webkit.org/show_bug.cgi?id=142618
1688
1689         Reviewed by Daniel Bates.
1690
1691         * Scripts/webkitdirs.pm:
1692         (isWK2): Deleted.
1693
1694 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1695
1696         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1697         https://bugs.webkit.org/show_bug.cgi?id=138687
1698
1699         Reviewed by Carlos Garcia Campos.
1700
1701         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1702         affect other processes.
1703
1704         The implementation is imperfect, because the change happens asynchronously, but I
1705         don't expect it to be a problem in practice.
1706
1707         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1708         (WTR::InjectedBundle::beginTesting):
1709         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1710         (WTR::TestRunner::setAlwaysAcceptCookies):
1711         * WebKitTestRunner/TestInvocation.cpp:
1712         (WTR::TestInvocation::invoke):
1713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1714
1715 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1716
1717         [EFL] Enable building EFL 1.13 with NEON support
1718         https://bugs.webkit.org/show_bug.cgi?id=142619
1719
1720         Reviewed by Gyuyoung Kim.
1721
1722         * efl/jhbuild.modules:
1723
1724 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1725
1726         [Content Extensions] Add resource type and load type triggers.
1727         https://bugs.webkit.org/show_bug.cgi?id=142422
1728
1729         Reviewed by Benjamin Poulain.
1730
1731         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1732         (TestWebKitAPI::testRequest):
1733         (TestWebKitAPI::mainDocumentRequest):
1734         (TestWebKitAPI::TEST_F):
1735         (TestWebKitAPI::testURL): Deleted.
1736
1737 2015-03-10  Sam Weinig  <sam@webkit.org>
1738
1739         Allow adding a button in input elements for auto fill related functionality
1740         <rdar://problem/19782066>
1741         https://bugs.webkit.org/show_bug.cgi?id=142564
1742
1743         Reviewed by Anders Carlsson.
1744
1745         * WebKitTestRunner/TestController.cpp:
1746         (WTR::TestController::createOtherPage):
1747         (WTR::TestController::createWebViewWithOptions):
1748         Update for new callback.
1749
1750 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1751
1752         Add basic support for BOL and EOL assertions to the URL Filter parser
1753         https://bugs.webkit.org/show_bug.cgi?id=142568
1754
1755         Reviewed by Alex Christensen.
1756
1757         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1758         (TestWebKitAPI::TEST_F):
1759
1760 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1761
1762         [GTK] Add support for handling TLS errors to MiniBrowser
1763         https://bugs.webkit.org/show_bug.cgi?id=142576
1764
1765         Reviewed by Sergio Villar Senin.
1766
1767         It's useful for testing TLS errors handling itself, but also to
1768         allow ignoring TLS errors when testing.
1769
1770         * MiniBrowser/gtk/BrowserWindow.c:
1771         (webViewLoadFailedWithTLSerrors):
1772         (browserWindowConstructed):
1773
1774 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1775
1776         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1777         https://bugs.webkit.org/show_bug.cgi?id=142569
1778
1779         Reviewed by David Hyatt.
1780
1781         Test Optional::valueOrCompute().
1782
1783         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1784         (TestWebKitAPI::TEST):
1785
1786 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1787
1788         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1789         https://bugs.webkit.org/show_bug.cgi?id=126688
1790
1791         Reviewed by Gustavo Noronha Silva.
1792
1793         * CMakeLists.txt: Build testing tools only for developer builds,
1794         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1795         * MiniBrowser/gtk/CMakeLists.txt: Only add
1796         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1797         and add a rule to install the MiniBrowser.
1798         * MiniBrowser/gtk/main.c:
1799         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1800         builds.
1801
1802 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1803
1804         Add some DateMath tests to TestWebKitAPI
1805         https://bugs.webkit.org/show_bug.cgi?id=142565
1806
1807         Reviewed by Alexey Proskuryakov.
1808
1809         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1810         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1811         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1813         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1814
1815 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1816
1817         Regression(r181257): WTF_WorkQueue.Simple is flaky
1818         https://bugs.webkit.org/show_bug.cgi?id=142560
1819
1820         Unreviewed attempt to improve test stability.
1821
1822         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1823         the WorkQueue a little later to redue flakiness.
1824
1825 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1826
1827         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1828         https://bugs.webkit.org/show_bug.cgi?id=142555
1829
1830         Reviewed by Simon Fraser.
1831
1832         * DumpRenderTree/mac/DumpRenderTree.mm:
1833         (setDefaultsToConsistentValuesForTesting):
1834         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1835         (WTR::InjectedBundle::platformInitialize):
1836
1837 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1838
1839         Use unsigned for HashSet size.
1840         https://bugs.webkit.org/show_bug.cgi?id=142518
1841
1842         Reviewed by Benjamin Poulain.
1843
1844         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1845         (TestWebKitAPI::TEST):
1846         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1847         (TestWebKitAPI::testInitialCapacity):
1848         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1849         (TestWebKitAPI::TEST):
1850
1851 2015-03-10  Daniel Bates  <dabates@apple.com>
1852
1853         [iOS] Add WebKitSystemInterface for iOS 8.2
1854         https://bugs.webkit.org/show_bug.cgi?id=142505
1855
1856         Rubber-stamped by Anders Carlsson.
1857
1858         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1859         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1860         copy-webkitlibraries-to-product-directory in r181286.
1861
1862         * Scripts/copy-webkitlibraries-to-product-directory:
1863
1864 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1865
1866         Extend URL filter's Term definition to support groups/subpatterns
1867         https://bugs.webkit.org/show_bug.cgi?id=142519
1868
1869         Reviewed by Alex Christensen.
1870
1871         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1872         (TestWebKitAPI::testURL):
1873
1874 2015-03-06  Jer Noble  <jer.noble@apple.com>
1875
1876         Add an option to run-webkit-tests to override the LayoutTests/ directory
1877         https://bugs.webkit.org/show_bug.cgi?id=142418
1878
1879         Reviewed by David Kilzer.
1880
1881         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1882         directory. The base port will parse the options during initialization and store the override
1883         location if present. layout_tests_dir() will return this overridden location if set.
1884
1885         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1886         (parse_args):
1887         * Scripts/webkitpy/port/base.py:
1888         (Port.__init__):
1889         (Port.layout_tests_dir):
1890
1891 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1892
1893         [CMake] Enable WorkQueue tests for CMake ports
1894         https://bugs.webkit.org/show_bug.cgi?id=142473
1895
1896         Reviewed by Darin Adler.
1897
1898         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1899         the list of source files.
1900         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1901         to the list of include directories for EFL.
1902
1903 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1904
1905         Attempt to fix timeouts on iOS Simulator layout tests
1906
1907         * Scripts/webkitpy/port/ios.py:
1908         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1909         Simulator end after the first 50 tests time out.  Some analysis
1910         this past weekend shows that the 'Booted' status in the output
1911         of `xcrun simctl list` is not sufficient (and watching the test
1912         run shows that SpringBoard hasn't fully started to the point
1913         where it's displaying icons on the home screen).  The workaround
1914         until we have a better fix is to add an arbitrary timeout to let
1915         SpringBoard finish launching.  In practice, 15 seconds is
1916         probably enough, but 30 seconds should nearly always work.
1917
1918 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1919
1920         Unreviewed. Add myself as a committer.
1921
1922         * Scripts/webkitpy/common/config/contributors.json:
1923
1924 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1925
1926         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1927
1928         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1929         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1930         an expectation that will fail if we hit the race condition.
1931         This test is inherently racy and will deadlock if the first job
1932         for queue2 takes the mutex lock before the second job for
1933         queue1.
1934
1935 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1936
1937         [Win] WTF::WorkQueue does not balance ref/deref properly
1938         https://bugs.webkit.org/show_bug.cgi?id=142471
1939
1940         Reviewed by Antti Koivisto.
1941
1942         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1943         (TestWebKitAPI::TEST): Check that the refcount is correct.
1944
1945 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1946
1947         Do not show passing test result on output of EFL layout test
1948         https://bugs.webkit.org/show_bug.cgi?id=142380
1949
1950         Reviewed by Darin Adler.
1951
1952         To show passing tests has caused inconvenience when we detect problem tests
1953         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1954         in order not to show passing tests in the output of EFL layout test.
1955
1956         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1957         (RunWebKitTests.start):
1958
1959 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1960
1961         Unreviewed build fix.
1962
1963         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1964         (TestWebKitAPI::TEST): Remove two unused variables.
1965
1966 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1967
1968         Add some WorkQueue tests to TestWebKitAPI
1969         https://bugs.webkit.org/show_bug.cgi?id=142447
1970
1971         Reviewed by Sam Weinig.
1972
1973         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1974         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1976         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1977         (TestWebKitAPI::simpleTest):
1978         (TestWebKitAPI::longTest):
1979         (TestWebKitAPI::thirdTest):
1980         (TestWebKitAPI::finishedTests):
1981         (TestWebKitAPI::TEST):
1982         (TestWebKitAPI::longTest2):
1983
1984 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1985
1986         Remove willDestroyFrame in WKBundlePageLoaderClient
1987         https://bugs.webkit.org/show_bug.cgi?id=142389
1988
1989         Reviewed by Anders Carlsson.
1990
1991         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1992         (WTR::InjectedBundlePage::InjectedBundlePage):
1993
1994 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1995
1996         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1997         https://bugs.webkit.org/show_bug.cgi?id=142433
1998
1999         Reviewed by Darin Adler.
2000
2001         Include more TestWebKitAPI tests when building for Windows. Also
2002         fix a build error in MetaAllocator.cpp caused by one of the
2003         Microsoft headers #defining 'small'.
2004
2005         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2006         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2007         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2008
2009 2015-03-06  Sam Weinig  <sam@webkit.org>
2010
2011         [Content Extensions] Move compiling of content extensions to the UIProcess
2012         https://bugs.webkit.org/show_bug.cgi?id=142402
2013
2014         Reviewed by Benjamin Poulain.
2015
2016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2017         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2018         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2019         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2020         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2021         (TestWebKitAPI::TEST_F):
2022         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2023         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2024         is now abstract).
2025
2026 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2027
2028         [Win] Correct Windows build.
2029
2030         Rubberstamped by Michael Saboff
2031
2032         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2033         in the GOTO labels.
2034
2035 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2036
2037         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2038         https://bugs.webkit.org/show_bug.cgi?id=142385
2039
2040         Reviewed by Sergio Villar Senin.
2041
2042         Use stack allocated GMainLoopSources to make sure they are
2043         cancelled automatically if the test finishes before they have
2044         been processed.
2045
2046         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2047         (testWebViewSyncRequestOnMaxConns):
2048
2049 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2050
2051         Remove Mountain Lion libraries since ML isn't supported
2052         https://bugs.webkit.org/show_bug.cgi?id=142332
2053
2054         Reviewed by Darin Adler.
2055
2056         * Scripts/copy-webkitlibraries-to-product-directory:
2057
2058 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2059
2060         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2061         https://bugs.webkit.org/show_bug.cgi?id=142083
2062
2063         Reviewed by Simon Fraser.
2064
2065         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2066
2067         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2068         (WebPlatformTestServer._copy_webkit_test_files):
2069
2070 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2071
2072         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2073         https://bugs.webkit.org/show_bug.cgi?id=141946
2074
2075         Reviewed by Ryosuke Niwa.
2076
2077         Check in ircbot.py and irclib.py to avoid network problems in the future.
2078
2079         * Scripts/webkitpy/common/net/irc/ircbot.py:
2080         * Scripts/webkitpy/thirdparty/__init__.py:
2081         (AutoinstallImportHook.find_module):
2082         (AutoinstallImportHook._install_irc): Deleted.
2083         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2084         (ThirdpartyTest.test_imports):
2085         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2086         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2087         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2088
2089 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2090
2091         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2092
2093         See also fix to config.json in r181097.
2094
2095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2096         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2097         bots.
2098
2099 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2100
2101         run-jsc-stress-tests should determine the architecture from ELF binaries
2102         https://bugs.webkit.org/show_bug.cgi?id=142335
2103
2104         Reviewed by Darin Adler.
2105
2106         * Scripts/run-jsc-stress-tests:
2107
2108 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2109
2110         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2111         <http://webkit.org/b/142226>
2112
2113         Reviewed by Darin Adler.
2114
2115         * Scripts/webkitpy/port/ios.py:
2116         (IOSSimulatorPort.default_baseline_search_path): Switch the
2117         TestExpectations order of ios-simulator-wk2 from this:
2118           ios-simulator-wk2, wk2, ios-simulator
2119         To this:
2120           ios-simulator-wk2, ios-simualtor, wk2
2121
2122 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2123
2124         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2125         https://bugs.webkit.org/show_bug.cgi?id=142370
2126
2127         Reviewed by Dean Jackson.
2128
2129         * Scripts/webkitdirs.pm:
2130         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2131         logs, one for warnings, the other for errors.
2132         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2133         into the standard BuildOutput.htm document.
2134
2135 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2136
2137         Dashboard has trouble parsing iOS test output
2138         <http://webkit.org/b/142364>
2139
2140         Reviewed by Alex Christensen.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2143         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2144         Add fallback path to build a regex using 'matchString' so that
2145         it matches anywhere in the line.  In practice, 'matchString' is
2146         a prefix for the label following the number.
2147
2148 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2149
2150         Fix linker warnings in TestWebKitAPI.
2151         https://bugs.webkit.org/show_bug.cgi?id=141912
2152
2153         Reviewed by David Kilzer.
2154
2155         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2156         Do not export TearDownTestCase or SetUpTestCase symbols.
2157
2158 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2159
2160         [Win] Unreviewed EWS fix.
2161
2162         * Scripts/webkitdirs.pm:
2163         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2164         the EWS output more usable.
2165
2166 2015-03-05  Chris Dumez  <cdumez@apple.com>
2167
2168         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2169         https://bugs.webkit.org/show_bug.cgi?id=142350
2170
2171         Reviewed by Michael Saboff and Benjamin Poulain.
2172
2173         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2174         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2175
2176         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2177         (TestWebKitAPI::TEST):
2178
2179 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2180
2181         [Win] Ensure build target directory exists when launching MSBuild
2182         https://bugs.webkit.org/show_bug.cgi?id=142360
2183
2184         Reviewed by Dean Jackson.
2185
2186         Create the build output directory (if it doesn't exist) before
2187         launching MSBuild so that it can immediately begin writing logs.
2188
2189         * Scripts/webkitdirs.pm:
2190         (buildVisualStudioProject):
2191
2192 2015-03-05  Chris Dumez  <cdumez@apple.com>
2193
2194         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2195         https://bugs.webkit.org/show_bug.cgi?id=142325
2196
2197         Reviewed by Csaba Osztrogonác.
2198
2199         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2200         As a result, "--webkit-test-runner / -2" parameters are replaced by
2201         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2202         than WebKitTestRunner.
2203
2204         * BuildSlaveSupport/build.webkit.org-config/config.json:
2205         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2206         (RunWebKit1Tests):
2207         (RunWebKit1Tests.start):
2208         (RunWebKit1LeakTests):
2209         (RunWebKit1LeakTests.start):
2210         (RunAndUploadPerfTestsWebKit1):
2211         (RunAndUploadPerfTestsWebKit1.start):
2212         (TestFactory):
2213         (TestWebKit1LeaksFactory):
2214         (TestWebKit1LeaksFactory.__init__):
2215         (TestWebKit1Factory):
2216         (TestWebKit1AllButJSCFactory):
2217         (TestAllButJSCFactory):
2218         (BuildAndPerfTestWebKit1Factory):
2219         (BuildAndPerfTestWebKit1Factory.__init__):
2220         (BuildAndPerfTestFactory):
2221         (BuildAndPerfTestFactory.__init__):
2222         (DownloadAndPerfTestWebKit1Factory):
2223         (DownloadAndPerfTestWebKit1Factory.__init__):
2224         (DownloadAndPerfTestFactory):
2225         (DownloadAndPerfTestFactory.__init__):
2226         (RunWebKitLeakTests): Deleted.
2227         (RunWebKitLeakTests.start): Deleted.
2228         (RunWebKit2Tests): Deleted.
2229         (RunWebKit2Tests.start): Deleted.
2230         (RunAndUploadPerfTestsWebKit2): Deleted.
2231         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2232         (TestLeaksFactory): Deleted.
2233         (TestLeaksFactory.__init__): Deleted.
2234         (TestWebKit2Factory): Deleted.
2235         (TestWebKit2AndJSCFactory): Deleted.
2236         (BuildAndPerfTestWebKit2Factory): Deleted.
2237         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2238         (DownloadAndPerfTestWebKit2Factory): Deleted.
2239         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2241         (parse_args):
2242         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2243         (PerfTestsRunner._parse_args):
2244         * Scripts/webkitpy/port/port_testcase.py:
2245         (PortTestCase.test_build_driver):
2246
2247 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2248
2249         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2250         https://bugs.webkit.org/show_bug.cgi?id=140845
2251
2252         Reviewed by David Kilzer.
2253
2254         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2255         and generate suitable build commands to drive a full build from our
2256         existing solution files.
2257
2258         * Scripts/webkitdirs.pm:
2259         (msBuildInstallDir): Added.
2260         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2261         line arguments to drive the build.
2262         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2263         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2264         to specify build architecture.
2265         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2266         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2267         bother looking for CoreUI or SafariTheme build logs.
2268
2269 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2270
2271         [buildbot] mastercfg_unittest.py should be runnable easily
2272         https://bugs.webkit.org/show_bug.cgi?id=142219
2273
2274         Reviewed by Chris Dumez.
2275
2276         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2277         the last Twisted version works together with this buildbot version.
2278
2279         * Scripts/webkitpy/common/system/autoinstall.py:
2280         (AutoInstaller): Added prepend_to_search_path argument to be able
2281         to prefer autoinstalled package to system package.
2282         (AutoInstaller.__init__):
2283         (AutoInstaller._set_up_target_dir):
2284         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2285         (AutoInstaller._prepare_package):
2286         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2287         * Scripts/webkitpy/thirdparty/__init__.py:
2288         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2289
2290 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2291
2292         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2293         https://bugs.webkit.org/show_bug.cgi?id=131162
2294
2295         Reviewed by Gyuyoung Kim.
2296
2297         * MiniBrowser/efl/main.c:
2298         (on_download_request):
2299         (on_download_finished):
2300         (on_download_failed):
2301         (window_create):
2302         Adapt download callbacks to new callback mechanism
2303
2304 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2305
2306         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2307
2308         In r180927 we updated the libsoup version used by the jhbuild. In
2309         this new version the sniffer uses image/x-icon instead of
2310         image/vnd.microsoft.icon for blank.ico resource.
2311
2312         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2313         (testWebResourceMimeType):
2314
2315 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2316
2317         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2318         https://bugs.webkit.org/show_bug.cgi?id=142244
2319
2320         Reviewed by Sergio Villar Senin.
2321
2322         Check that the SSL server doesn't process any request in case of
2323         TLS errors when the policy is set to FAIL.
2324
2325         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2326         (testTLSErrorsPolicy):
2327         (testTLSErrorsRedirect):
2328         (testTLSErrorsHTTPAuth):
2329         (testLoadFailedWithTLSErrors):
2330         (testSubresourceLoadFailedWithTLSErrors):
2331         (httpsServerCallback):
2332
2333 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2334
2335         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2336         https://bugs.webkit.org/show_bug.cgi?id=141154
2337
2338         Reviewed by Jer Noble.
2339
2340         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2341
2342         For the sake of completeness WebKitTestRunner should specify temporary
2343         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2344
2345         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2346         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2347         to get data storage paths. Only Mac port has an actual implementation of it.
2348         However, WebKitTestRunner overrides them in favour of unique temporary dir
2349         which is taken from libraryPathForTesting().
2350
2351         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2352         is not implemented for EFL and GTK ports it returns an empty string.
2353         All default data folders besides MediaKeys are overridden in TestRunner
2354         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2355         env variable.
2356
2357         GTK port does not enable encrypted keys by default so
2358         WebMediaKeyStorageManager::initialize() code path is never triggered.
2359
2360         * WebKitTestRunner/TestController.cpp:
2361         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2362         WebKit ports.
2363
2364 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2365
2366         [buildbot] Add regression test to check which builder runs which tests
2367         https://bugs.webkit.org/show_bug.cgi?id=142166
2368
2369         Reviewed by Alexey Proskuryakov.
2370
2371         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2372         (BuildStepsConstructorTest.createTest):
2373         (BuildStepsTest):
2374         (BuildStepsTest.generateTests):
2375         (BuildStepsTest.createTest):
2376         (BuildStepsTest.createTest.doTest):
2377         (BuildStepsTest.test_unnecessary_expected_results):
2378
2379 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2380
2381         Unreviewed, rolling out r181054.
2382         https://bugs.webkit.org/show_bug.cgi?id=142320
2383
2384         Broke the api tests (Requested by sundiamonde on #webkit).
2385
2386         Reverted changeset:
2387
2388         "Fix linker warnings in TestWebKitAPI."
2389         https://bugs.webkit.org/show_bug.cgi?id=141912
2390         http://trac.webkit.org/changeset/181054
2391
2392 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2393
2394         Fix linker warnings in TestWebKitAPI.
2395         https://bugs.webkit.org/show_bug.cgi?id=141912
2396
2397         Reviewed by David Kilzer.
2398
2399         * TestWebKitAPI/Configurations/Base.xcconfig:
2400         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2401
2402 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2403
2404         [Mac] Set SystemUIFontSelect in DRT and WKTR
2405         https://bugs.webkit.org/show_bug.cgi?id=142303
2406
2407         Reviewed by Myles C. Maxfield.
2408
2409         * DumpRenderTree/mac/DumpRenderTree.mm:
2410         (setDefaultsToConsistentValuesForTesting):
2411         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2412         (WTR::InjectedBundle::platformInitialize):
2413
2414 2015-03-04  Chris Dumez  <cdumez@apple.com>
2415
2416         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2417         https://bugs.webkit.org/show_bug.cgi?id=142314
2418         <rdar://problem/20046835>
2419
2420         Reviewed by Ryosuke Niwa.
2421
2422         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2423         to get WK2 code coverage.
2424
2425         * BuildSlaveSupport/build.webkit.org-config/config.json:
2426
2427 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2428
2429         Move content extensions test to properly named directory.
2430         https://bugs.webkit.org/show_bug.cgi?id=142299
2431
2432         Reviewed by Tim Horton.
2433
2434         * WebKitTestRunner/mac/TestControllerMac.mm:
2435         (WTR::TestController::platformConfigureViewForTest):
2436
2437 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2438
2439         W3C test importer should use filesystem instead of os.walk
2440         https://bugs.webkit.org/show_bug.cgi?id=142085
2441
2442         Reviewed by Bem Jones-Bey.
2443
2444         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2445         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2446         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2447
2448         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2449         Added a unit test to check that test importer is now black-box testable using a Mock system.
2450
2451         * Scripts/webkitpy/common/system/filesystem.py:
2452         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2453         (FileSystem.dirs_under.filter_all):
2454         * Scripts/webkitpy/common/system/filesystem_mock.py:
2455         (MockFileSystem.dirs_under):
2456         (MockFileSystem.dirs_under.filter_all):
2457         (MockFileSystem.getsize):
2458         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2459         (MockFileSystemTest.test_dirs_under):
2460         (MockFileSystemTest.test_dirs_under.filter_dir):
2461         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2462         (RealFileSystemTest.test_sep):
2463         (RealFileSystemTest):
2464         (RealFileSystemTest.test_dirs_under):
2465         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2466         * Scripts/webkitpy/w3c/test_importer.py:
2467         (TestImporter.do_import):
2468         (TestImporter.find_importable_tests.should_keep_subdir):
2469         (TestImporter.find_importable_tests):
2470         (TestImporter.should_keep_subdir): Deleted.
2471         (TestImporter.should_skip_file): Deleted.
2472         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2473         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2474
2475 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2476
2477         [WebEditingTester] Add support for the find and replace bar
2478         https://bugs.webkit.org/show_bug.cgi?id=142247
2479
2480         Reviewed by Enrica Casucci.
2481
2482         While it's not hooked up yet in WKWebView, adding support for the
2483         find bar to WebEditingTester will help us implement that functionality.
2484
2485         * WebEditingTester/AppDelegate.h:
2486         * WebEditingTester/AppDelegate.m:
2487         (-[WebEditingAppDelegate performTextFinderAction:]):
2488         * WebEditingTester/MainMenu.xib:
2489         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2490
2491         * WebEditingTester/WK2WebDocumentController.m:
2492         (-[WK2WebDocumentController awakeFromNib]):
2493         (-[WK2WebDocumentController performTextFinderAction:]):
2494         (-[WK2WebDocumentController findBarView]):
2495         (-[WK2WebDocumentController setFindBarView:]):
2496         (-[WK2WebDocumentController isFindBarVisible]):
2497         (-[WK2WebDocumentController setFindBarVisible:]):
2498         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2499         (-[WK2WebDocumentController layout]):
2500         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2501         pointing at the WKWebView (currently nothing will work, but the bar will
2502         show up). Install and uninstall the bar as needed.
2503
2504         * WebEditingTester/WebDocument.xib:
2505         Don't use a full-size content view. There's no need, and it makes find
2506         bar layout harder.
2507
2508         * WebEditingTester/WebDocumentController.h:
2509         * WebEditingTester/WebDocumentController.m:
2510         (-[WebDocumentController performTextFinderAction:]):
2511
2512 2015-03-03  Sam Weinig  <sam@webkit.org>
2513
2514         [Content Extensions] Split parsing and compiling of content extensions into their own files
2515         https://bugs.webkit.org/show_bug.cgi?id=142259
2516
2517         Reviewed by Anders Carlsson.
2518
2519         Add basic unit test for the content filter compiler.
2520
2521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2522         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2523         (WebCore::ContentExtensions::operator<<):
2524         (TestWebKitAPI::ContentFilterTest::SetUp):
2525         (TestWebKitAPI::TEST_F):
2526
2527 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2528
2529         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2530         https://bugs.webkit.org/show_bug.cgi?id=142230
2531
2532         Reviewed by Csaba Osztrogonác.
2533
2534         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2535         (TestFactory):
2536         (TestFactory.getProduct): Added
2537         (TestFactory.__init__): moved downloader to getProduct
2538         (BuildAndTestFactory):
2539         (BuildAndTestFactory.getProduct): Added
2540         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2541         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2542
2543 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2544
2545         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2546         https://bugs.webkit.org/show_bug.cgi?id=142225
2547
2548         Reviewed by Carlos Garcia Campos.
2549
2550         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2551         (testWebViewWebContextLifetime):
2552         (beforeAll):
2553
2554 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2555
2556         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2557         <http://webkit.org/b/142243>
2558
2559         Reviewed by Alexey Proskuryakov.
2560
2561         * WebKitTestRunner/TestController.cpp:
2562         (WTR::TestController::webProcessName):
2563         (WTR::TestController::networkProcessName):
2564         - Return the same process name on iOS and Mac because they both
2565           use the same process name for local engineering builds.
2566
2567 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2568
2569         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2570         <http://webkit.org/b/141872>
2571
2572         Reviewed by Alex Christensen.
2573
2574         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2575         semi-colons in various places and fix whitespace.
2576         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2577         constants.
2578         (_IncludeState.__init__): Add self._visited_soft_link_section
2579         boolean state variable.
2580         (_IncludeState.visited_soft_link_section): Getter for
2581         self._visited_soft_link_section.
2582         (_IncludeState.check_next_include_order): Update state machine
2583         for soft-link headers.  Add check that soft-link headers always
2584         appear last.
2585         (_classify_include): Add check for soft-link header type.
2586         (check_include_line): Return early if there is a soft-link
2587         header error.
2588
2589         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2590         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2591         including soft-link headers.
2592         (OrderOfIncludesTest.test_classify_include): Add test for
2593         _SOFT_LINK_HEADER type.
2594
2595 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2596
2597         build.webkit.org/dashboard: Don't repeatedly handle each test type
2598         https://bugs.webkit.org/show_bug.cgi?id=142211
2599
2600         Reviewed by Tim Horton and Matt Hanson.
2601
2602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2603         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2604         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2605         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2606         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2607         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2608         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2609         Removed functions that build a link to test step results. The buildbot provides
2610         these links in JSON.
2611
2612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2613         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2614         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2615         We can easily add them to the map as needed.
2616         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2617         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2618         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2619         and then build a BuildbotTestResults object, which was strange.
2620         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2621
2622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2623         Corrected an unrelated assertion that was buggy, and kept firing.
2624
2625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2626         (BuildbotTestResults):
2627         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2628         (BuildbotTestResults.prototype._parseResults):
2629         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2630         Moved the code for parsing JSON results for a single step here.
2631
2632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2633         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2634         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2635         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2636         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2637         (BuildbotTesterQueueView.prototype.update): Deleted.
2638         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2639         Updated for the new data structures. One behavior change is that we now display individual
2640         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2641         test failures, 3 platform api test failures".
2642
2643 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2644
2645         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2646         https://bugs.webkit.org/show_bug.cgi?id=142094
2647
2648         Reviewed by Csaba Osztrogonác.
2649
2650         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2651         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2652         (TestFactory):
2653         (TestFactory.__init__): Made running of JSC tests conditional.
2654         (TestAllButJSCFactory):
2655         (TestJSCFactory): Added.
2656         (TestJSCFactory.__init__):
2657         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2658
2659 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2660
2661         `build-webkit --help` is wrong about how to build for the iOS simulator
2662         <http://webkit.org/b/142223>
2663
2664         Reviewed by Csaba Osztrogonác.
2665
2666         * Scripts/build-webkit: Fix help.
2667
2668 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2669
2670         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2671
2672         * gtk/jhbuild.modules:
2673
2674 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2675
2676         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2677         https://bugs.webkit.org/show_bug.cgi?id=141508
2678
2679         Reviewed by Sergio Villar Senin.
2680
2681         Add a unit test to check that synchronous XHRs load even if the
2682         maximum connection limits are reached.
2683
2684         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2685         (testWebViewSyncRequestOnMaxConns):
2686         (serverCallback):
2687         (beforeAll):
2688         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2689
2690 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2691
2692         Update the name of ASan build step.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2695
2696 2015-03-02  Jer Noble  <jer.noble@apple.com>
2697
2698         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2699         https://bugs.webkit.org/show_bug.cgi?id=142121
2700
2701         Reviewed by Simon Fraser.
2702
2703         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2704         that the initial and final screen rects for the web content are as expected.
2705
2706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2707         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2708         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2709         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2710         (runJavaScriptAlert):
2711         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2712         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2713         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2714         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2715         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2716         (TestWebKitAPI::TEST_F):
2717
2718 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2719
2720         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2721
2722         Follow-up fix for:
2723
2724         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2725         <http://webkit.org/b/142145>
2726
2727         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2728         (-[LTRelayController _environmentVariables]): Fix think-o.
2729
2730 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2731
2732         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2733         <http://webkit.org/b/142145>
2734
2735         Reviewed by Simon Fraser.
2736
2737         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2738         (-[LTRelayController _environmentVariables]): Add.
2739         (-[LTRelayController launchApp]): Use -_environmentVariables.
2740
2741 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2742
2743         [iOS] Stop running webkit-build-directory on every layout test
2744
2745         This was originally fixed by David Farler for Bug 135409 in
2746         r172602.
2747
2748         * Scripts/webkitpy/port/ios.py:
2749         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2750         run webkit-build-directory every time it's called.
2751
2752 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2753
2754         W3C importer should use filesystem instead of shutil/host
2755         https://bugs.webkit.org/show_bug.cgi?id=142012
2756
2757         Reviewed by Bem Jones-Bey.
2758
2759         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2760
2761         * Scripts/webkitpy/w3c/test_importer.py:
2762         (main):
2763         (TestImporter.do_import):
2764         (TestImporter.find_importable_tests):
2765         (TestImporter.import_tests):
2766         (TestImporter.remove_deleted_files):
2767         (TestImporter.write_import_log):
2768
2769 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2770
2771         W3C test importer should use filesystem to read and write files
2772         https://bugs.webkit.org/show_bug.cgi?id=142084
2773
2774         Reviewed by Bem Jones-Bey.
2775
2776         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2777
2778         * Scripts/webkitpy/w3c/test_importer.py:
2779         (TestImporter.import_tests):
2780         (TestImporter.remove_deleted_files):
2781         (TestImporter.write_import_log):
2782
2783 2015-02-27  Sam Weinig  <sam@webkit.org>
2784
2785         Add WebKit2 SPI to create a DOM File object
2786         https://bugs.webkit.org/show_bug.cgi?id=142109
2787
2788         Reviewed by Tim Horton.
2789
2790         Add a test for WKBundleFileHandleRef.
2791
2792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2793         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2794         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2795         (TestWebKitAPI::didFinishLoadForFrame):
2796         (TestWebKitAPI::TEST):
2797         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2798         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2799         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2800
2801 2015-02-27  Michael Saboff  <msaboff@apple.com>
2802
2803         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2804         https://bugs.webkit.org/show_bug.cgi?id=142112
2805
2806         Reviewed by Filip Pizlo.
2807
2808         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2809         <someDir> as the library path.
2810
2811         * Scripts/run-jsc-benchmarks:
2812
2813 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2814
2815         [WinCairo] Unreviewed build fix.
2816
2817         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2818         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2819
2820 2015-02-27  Anders Carlsson  <andersca@apple.com>
2821
2822         Add infrastructure for handling website data in the network process
2823         https://bugs.webkit.org/show_bug.cgi?id=142092
2824
2825         Reviewed by Andreas Kling.
2826
2827         Add a menu item that will fetch all website data, delete the returned data records, and
2828         fetch all website data again so we can confirm that it's all empty.
2829
2830         * MiniBrowser/mac/WK2BrowserWindowController.m:
2831         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2832
2833 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2834
2835         [Win] Remove remaining SafariTheme cruft
2836         https://bugs.webkit.org/show_bug.cgi?id=142075
2837
2838         Reviewed by Anders Carlsson.
2839
2840         Remove reference to SafariTheme-switching preference.
2841
2842         * DumpRenderTree/win/DumpRenderTree.cpp:
2843         (resetWebPreferencesToConsistentValues):
2844         (prepareConsistentTestingEnvironment):
2845
2846 2015-02-26  Doug Russell  <d_russell@apple.com>
2847
2848         AX: Expose caret browsing preference to accessibility API
2849         https://bugs.webkit.org/show_bug.cgi?id=141862
2850
2851         Reviewed by Chris Fleizach.
2852
2853         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2854         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2855
2856         * DumpRenderTree/AccessibilityUIElement.cpp:
2857         (setBoolAttributeValueCallback):
2858         (selectedTextMarkerRangeCallback):
2859         (resetSelectedTextMarkerRangeCallback):
2860         (AccessibilityUIElement::setBoolAttributeValue):
2861         (AccessibilityUIElement::selectedTextMarkerRange):
2862         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2863         (AccessibilityUIElement::getJSClass):
2864         * DumpRenderTree/AccessibilityUIElement.h:
2865         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2866         (AccessibilityUIElement::setBoolAttributeValue):
2867         (AccessibilityUIElement::selectedTextMarkerRange):
2868         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2869         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2870         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2871         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2872         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2873         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2874         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2875         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2876         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2877         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2878         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2879
2880 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2881
2882         [Win] Remove WebKitExportGenerator project (and related)
2883         https://bugs.webkit.org/show_bug.cgi?id=142035
2884
2885         Reviewed by Dean Jackson.
2886
2887         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2888         build log from WebKitExportGenerator.
2889
2890 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         [EFL] Bump EFL version to 1.13.0
2893         https://bugs.webkit.org/show_bug.cgi?id=141708
2894
2895         Reviewed by Gyuyoung Kim.
2896
2897         * efl/jhbuild.modules:
2898
2899 2015-02-26  Sam Weinig  <sam@webkit.org>
2900
2901         Check in missing WebEditingTester.xcconfig file.
2902
2903         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2904
2905 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2906
2907         [webkitpy] Remove skipped file related crufts
2908         https://bugs.webkit.org/show_bug.cgi?id=142046
2909
2910         Reviewed by Ryosuke Niwa.
2911
2912         * Scripts/webkitpy/port/base.py:
2913         (Port.skipped_layout_tests):
2914         (Port._tests_from_skipped_file_contents): Deleted.
2915         (Port): Deleted.
2916         (Port._expectations_from_skipped_files): Deleted.
2917         * Scripts/webkitpy/port/mac_unittest.py:
2918         (MacTest.test_default_timeout_ms):
2919         (MacTest): Deleted.
2920         (test_tests_from_skipped_file_contents): Deleted.
2921
2922 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2923
2924         [Win] Unreviewed WinCairo build fix after r180653.
2925
2926         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2927
2928         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2929         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2930         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2931         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2932         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2933
2934 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2935
2936         [Win] Use WEBCORE_EXPORT instead of Definition file
2937         https://bugs.webkit.org/show_bug.cgi?id=141734
2938
2939         Reviewed by Alex Christensen.
2940
2941         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2942         Use a precompiled header so we can define our export macros properly.
2943         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2944         Visual studio automatic update stuff.
2945         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2946         Set up Precompiled Header use for project..
2947         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2948         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2949         declarations for building DumpRenderTree as a client of
2950         WebCore/WebKit.
2951
2952 2015-02-25  Mark Lam  <mark.lam@apple.com>
2953
2954         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2955         <https://webkit.org/b/141672>
2956
2957         Reviewed by Alexey Proskuryakov.
2958
2959         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2960         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2961         implementation that we can tell ASan to ignore.
2962
2963         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2964         which isn't effective for working around this issue.
2965
2966         * asan/webkit-asan-ignore.txt:
2967
2968 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2969
2970         CodeBlock crashes when dumping op_push_name_scope
2971         https://bugs.webkit.org/show_bug.cgi?id=141953
2972
2973         Reviewed by Filip Pizlo.
2974
2975         * Scripts/run-jsc-stress-tests:
2976
2977 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2978
2979         W3C test importer should use argparse instead of optparse
2980         https://bugs.webkit.org/show_bug.cgi?id=142013
2981
2982         Reviewed by Bem Jones-Bey.
2983
2984         * Scripts/webkitpy/w3c/test_importer.py:
2985         (main): Updating according argparse.
2986         (parse_args): Moving from optparse to argparse.
2987
2988 2015-02-25  Brady Eidson  <beidson@apple.com>
2989
2990         Get rid of TestInvocation::pathOrURL
2991         https://bugs.webkit.org/show_bug.cgi?id=142021
2992
2993         Reviewed by Tim Horton.
2994
2995         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2996         but most code that uses it expected an absolute path.
2997
2998         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2999
3000         * WebKitTestRunner/TestController.cpp:
3001         (WTR::TestController::updateWebViewSizeForTest):
3002         (WTR::TestController::updateWindowScaleForTest):
3003         (WTR::shouldUseFixedLayout):
3004         (WTR::TestController::updateLayoutTypeForTest):
3005
3006         * WebKitTestRunner/TestInvocation.cpp:
3007         (WTR::TestInvocation::TestInvocation):
3008         (WTR::TestInvocation::urlContains):
3009         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3010         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3011         (WTR::TestInvocation::invoke):
3012         (WTR::shouldLogFrameLoadDelegates): Deleted.
3013         (WTR::shouldLogHistoryClientCallbacks): Deleted.
3014         * WebKitTestRunner/TestInvocation.h:
3015         (WTR::TestInvocation::pathOrURL): Deleted.
3016
3017         * WebKitTestRunner/ios/TestControllerIOS.mm:
3018         (WTR::shouldMakeViewportFlexible):
3019         (WTR::TestController::platformConfigureViewForTest):
3020
3021         * WebKitTestRunner/mac/TestControllerMac.mm:
3022         (WTR::shouldUseThreadedScrolling):
3023         (WTR::TestController::platformConfigureViewForTest):
3024
3025 2015-02-25  Brady Eidson  <beidson@apple.com>
3026
3027         Layout test support for user content filters
3028         https://bugs.webkit.org/show_bug.cgi?id=142018
3029
3030         Reviewed by Tim Horton.
3031
3032         * WebKitTestRunner/TestController.cpp:
3033         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
3034
3035         * WebKitTestRunner/mac/TestControllerMac.mm:
3036         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
3037           file before loading the test itself.
3038
3039 2015-02-24  Sam Weinig  <sam@webkit.org>
3040
3041         Convert WebEditingTester to use xcconfig files
3042         https://bugs.webkit.org/show_bug.cgi?id=141879
3043
3044         Reviewed by Darin Adler.
3045
3046         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
3047
3048         * WebEditingTester/Configurations: Added.
3049         * WebEditingTester/Configurations/Base.xcconfig: Added.
3050         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
3051         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3052
3053 2015-02-24  Andy Estes  <aestes@apple.com>
3054
3055         Teach MiniBrowser how to disable per-window web processes
3056         https://bugs.webkit.org/show_bug.cgi?id=141988
3057
3058         Reviewed by Darin Adler.
3059
3060         * MiniBrowser/mac/AppDelegate.m:
3061         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3062         * MiniBrowser/mac/SettingsController.h:
3063         * MiniBrowser/mac/SettingsController.m:
3064         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3065         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3066         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3067         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3068
3069 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3070
3071         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3072         https://bugs.webkit.org/show_bug.cgi?id=141889
3073
3074         Reviewed by Darin Adler.
3075
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3077
3078 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3079
3080         REGRESSION(r179429): Can't type comments in Facebook
3081         https://bugs.webkit.org/show_bug.cgi?id=141859
3082
3083         Reviewed by Brent Fulgham.
3084
3085         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3086
3087         * DumpRenderTree/mac/DumpRenderTree.mm:
3088         (resetWebPreferencesToConsistentValues):
3089         * DumpRenderTree/win/DumpRenderTree.cpp:
3090         (resetWebPreferencesToConsistentValues):
3091         * WebKitTestRunner/TestController.cpp:
3092         (WTR::TestController::resetPreferencesToConsistentValues):
3093
3094 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3095
3096         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3097         https://bugs.webkit.org/show_bug.cgi?id=141867
3098
3099         Reviewed by Anders Carlsson.
3100
3101         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3102         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3103         be shared with the new test.
3104         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3105         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3106         (testLoadAlternateHTMLForLocalPage):
3107         (beforeAll):
3108
3109 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3110
3111         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3112         <http://webkit.org/b/141900>
3113
3114         Reviewed by Myles C. Maxfield.
3115
3116         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3117         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3118         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3119         - Rename to share code with iOS.
3120         - Add USE(APPKIT) around AppKit-specific headers and code.
3121         - Fix a check-webkit-style warning.
3122         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3123         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3124         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3125         - Remove ios/ActivateFontsIOS.mm.
3126         - Fix InjectedBundle/cocoa group to represent the directory on
3127           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3128
3129 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3130
3131         Unreviewed, rolling out r180547 and r180550.
3132         https://bugs.webkit.org/show_bug.cgi?id=141957
3133
3134         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3135
3136         Reverted changesets:
3137
3138         "REGRESSION(r179429): Can't type comments in Facebook"
3139         https://bugs.webkit.org/show_bug.cgi?id=141859
3140         http://trac.webkit.org/changeset/180547
3141
3142         "Constructor returning null should construct an object instead
3143         of null"
3144         https://bugs.webkit.org/show_bug.cgi?id=141640
3145         http://trac.webkit.org/changeset/180550
3146
3147 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3148
3149         REGRESSION(r179429): Can't type comments in Facebook
3150         https://bugs.webkit.org/show_bug.cgi?id=141859
3151
3152         Reviewed by Geoffrey Garen.
3153
3154         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3155
3156         * DumpRenderTree/mac/DumpRenderTree.mm:
3157         (resetWebPreferencesToConsistentValues):
3158         * WebKitTestRunner/TestController.cpp:
3159         (WTR::TestController::resetPreferencesToConsistentValues):
3160
3161 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3162
3163         [EFL] fix eo errors
3164         https://bugs.webkit.org/show_bug.cgi?id=141909
3165
3166         Reviewed by Gyuyoung Kim.
3167
3168         Fix eo errors that occur whenever minibrowser is launched.
3169         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3170         - elm_obj_win_resize_object_add's first parameter should be elm_win
3171
3172         * MiniBrowser/efl/main.c:
3173         (window_create):
3174
3175 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3176
3177         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3178
3179         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3180         (TestWebKitAPI::TEST):
3181
3182 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3183
3184         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3185         https://bugs.webkit.org/show_bug.cgi?id=141935
3186
3187         Reviewed by Myles C. Maxfield.
3188
3189         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3190         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3191         tests for assigning from nullptr.
3192
3193 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3194
3195         WTF::WeakPtr should have a 'forget' method.
3196         https://bugs.webkit.org/show_bug.cgi?id=141923
3197
3198         Reviewed by Myles C. Maxfield.
3199
3200         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3201         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3202
3203 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3204
3205         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3206         https://bugs.webkit.org/show_bug.cgi?id=141920
3207
3208         Reviewed by Tim Horton.
3209
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3211         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3212         Do the same thing as we do for regular green bubbles.
3213
3214 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3215
3216         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3217         https://bugs.webkit.org/show_bug.cgi?id=141925
3218
3219         Reviewed by Tim Horton.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3222         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3223
3224 2015-02-23  Anders Carlsson  <andersca@apple.com>
3225
3226         Add API for fetching website data records to _WKWebsiteDataStore
3227         https://bugs.webkit.org/show_bug.cgi?id=141926
3228
3229         Reviewed by Beth Dakin.
3230
3231         * MiniBrowser/mac/MainMenu.xib:
3232         * MiniBrowser/mac/WK2BrowserWindowController.m:
3233         (-[WK2BrowserWindowController fetchWebsiteData:]):
3234         Add menu item to fetch and dump website data.
3235
3236 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3237
3238         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3239         <http://webkit.org/b/141884>
3240
3241         Reviewed by Alexey Proskuryakov.
3242
3243         * Scripts/webkitpy/port/leakdetector.py:
3244         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3245         snowleopard, lion and older leaks.  Add known leak for
3246         mavericks, but check Port.operating_system before calling
3247         Port.is_mavericks.
3248         * Scripts/webkitpy/port/mac.py:
3249         (MacPort.is_snowleopard): Delete.
3250         (MacPort.is_lion): Delete.
3251         (MacPort.is_mavericks): Add.
3252
3253 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3254
3255         build.webkit.org/dashboard should filter out commits to other branches
3256         https://bugs.webkit.org/show_bug.cgi?id=140362
3257
3258         Reviewed by Tim Horton.
3259
3260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3261         (BuildbotQueue):
3262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3263         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3264         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3265         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3266         (BuildbotQueueView.prototype.revisionContentForIteration):
3267         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3268         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3269         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3271         (Trac.prototype.get oldestRecordedRevisionNumber):
3272         (Trac.prototype.commitsOnBranch):
3273         (Trac.prototype._xmlTimelineURL):
3274         (Trac.prototype._convertCommitInfoElementToObject):
3275         (Trac.prototype._update):
3276         (Trac.prototype.startPeriodicUpdates):
3277         (Trac.prototype.loadMoreHistoricalData):
3278         (Trac.prototype.update): Deleted.
3279
3280 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3281
3282         Tests don't work on some bots: Failed to stop wptwk
3283         https://bugs.webkit.org/show_bug.cgi?id=141235
3284
3285         Reviewed by Ryosuke Niwa.
3286
3287         Logging of server subprocesses in launcher script.
3288         Killing of server subprocesses when stopping/before starting.
3289         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3290
3291         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3292         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3293         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3294         (WebPlatformTestServer.__init__):
3295         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3296         (WebPlatformTestServer):
3297         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3298         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3299         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3300         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3301         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3302         (TestWebPlatformTestServer):
3303         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3304
3305 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3306
3307         [WebEditingTester] Allow dropping HTML files on the app
3308         https://bugs.webkit.org/show_bug.cgi?id=141834
3309
3310         Reviewed by Simon Fraser.
3311
3312         * WebEditingTester/AppDelegate.m:
3313         (-[WebEditingAppDelegate openDocument:]):
3314         (-[WebEditingAppDelegate application:openFile:]):
3315         Implement application:openFile:, factoring file loading code out of openDocument.
3316
3317         * WebEditingTester/Info.plist:
3318         Register as an editor for HTML files.
3319
3320         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3321         Enrica is not an organization.
3322
3323 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3324
3325         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3326         https://bugs.webkit.org/show_bug.cgi?id=141833
3327
3328         Reviewed by Anders Carlsson.
3329
3330         * WebEditingTester/AppDelegate.h:
3331         * WebEditingTester/AppDelegate.m:
3332         (-[WebEditingAppDelegate newEditor:]):
3333         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3334         (-[WebEditingAppDelegate validateMenuItem:]):
3335         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3336         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3337         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3338         (-[WebEditingAppDelegate showOperations:]): Deleted.
3339         * WebEditingTester/MainMenu.xib:
3340         The WK abbreviation is unnaturally grating in menu items for some reason.
3341
3342 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3343
3344         [WebEditingTester] Add a custom protocol for loading canned content
3345         https://bugs.webkit.org/show_bug.cgi?id=141830
3346
3347         Reviewed by Enrica Casucci.
3348
3349         Add a canned:// protocol handler, which can be used to emulate behaviors
3350         in WebKit client apps (like Mail) that use custom protocol handlers,
3351         which can have important effects on editing (mostly, the URLs are only
3352         valid inside of the client application, but not when copied/dragged out).
3353
3354         For now, we only support two canned files:
3355
3356             canned://dice is a PNG of dice (stolen from LayoutTests/)
3357             canned://text is the string "canned text" served as text/html
3358
3359         In the future we could support things like very large (generated) files,
3360         progressive loading, etc. to further simulate conditions in other apps.
3361
3362         * WebEditingTester/AppDelegate.m:
3363         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3364         Register the protocol with CFNetwork, and the scheme with WebKit2.
3365
3366         * WebEditingTester/Canned Content/dice.png: Added.
3367         * WebEditingTester/CannedContent.h: Added.
3368         * WebEditingTester/CannedContent.m: Added.
3369         (-[CannedContent initWithRequest:cachedResponse:client:]):
3370         (+[CannedContent canonicalRequestForRequest:]):
3371         (+[CannedContent canInitWithRequest:]):
3372         We only want to handle canned:// URLs.
3373
3374         (-[CannedContent startLoading]):
3375         For now, immediately load the two files we know about.
3376         Otherwise, immediately fail the load.
3377
3378         (-[CannedContent stopLoading]):
3379         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3380
3381 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3382
3383         [WebEditingTester] Implement an open panel
3384         https://bugs.webkit.org/show_bug.cgi?id=141829
3385
3386         Reviewed by Simon Fraser.
3387
3388         * WebEditingTester/AppDelegate.m:
3389         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3390         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3391         (-[WebEditingAppDelegate openDocument:]):
3392         Add an open panel (with radio buttons to pick which WebKit to open with).
3393         Loads the file as an HTML string.
3394
3395 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3396
3397         [WebEditingTester] @properties, dot syntax, and remember the window position
3398         https://bugs.webkit.org/show_bug.cgi?id=141843
3399
3400         Reviewed by Tim Horton.
3401
3402         Modernize a bit with more dot syntax, use @property for the web views,
3403         and give the main window an Autosave name so it remembers the widow position.
3404
3405         * WebEditingTester/WK1WebDocumentController.m:
3406         (-[WK1WebDocumentController awakeFromNib]):
3407         (-[WK1WebDocumentController loadHTMLString:]):
3408         * WebEditingTester/WK2WebDocumentController.m:
3409         (-[WK2WebDocumentController awakeFromNib]):
3410         * WebEditingTester/WebDocument.xib:
3411
3412 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3413
3414         [WebEditingTester] Hook up key equivalents for new window action
3415         https://bugs.webkit.org/show_bug.cgi?id=141828
3416
3417         Reviewed by Enrica Casucci.
3418
3419         * WebEditingTester/AppDelegate.h:
3420         * WebEditingTester/AppDelegate.m:
3421         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3422         (-[WebEditingAppDelegate newEditor:]):
3423         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3424         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3425         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3426         (defaultConfiguration): Deleted.
3427         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3428         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3429         Remove unused application termination code.
3430         Update new-window menu item key equivalents when launching and when
3431         changing the use-WebKit2-by-default setting.
3432         Make WebDocumentController subclasses all initialized the same way,
3433         and use that to factor out alloc/init.
3434         Rename loadContent to loadHTMLString for future use.
3435
3436         * WebEditingTester/MainMenu.xib:
3437         Add default key equivalents.
3438         Cmd-N will always make the default kind of window (controlled by the pref).
3439         Cmd-Opt-N will always make the other kind.
3440         The menu items are configured as alternates so they only show up if you
3441         press alt (just like in MiniBrowser).
3442
3443         * WebEditingTester/WK1WebDocumentController.m:
3444         (-[WK1WebDocumentController loadHTMLString:]):
3445         (-[WK1WebDocumentController loadContent]): Deleted.
3446         * WebEditingTester/WK2WebDocumentController.h:
3447         * WebEditingTester/WK2WebDocumentController.m:
3448         (defaultConfiguration):
3449         (-[WK2WebDocumentController awakeFromNib]):
3450         (-[WK2WebDocumentController loadHTMLString:]):
3451         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3452         (-[WK2WebDocumentController dealloc]): Deleted.
3453         * WebEditingTester/WebDocumentController.h:
3454         * WebEditingTester/WebDocumentController.m:
3455         (-[WebDocumentController init]):
3456         (-[WebDocumentController initWithWindow:]):
3457         (+[WebDocumentController defaultEditingSource]):
3458         (-[WebDocumentController loadHTMLString:]):
3459         (-[WebDocumentController windowDidLoad]): Deleted.
3460         (-[WebDocumentController defaultEditingSource]): Deleted.
3461         (-[WebDocumentController applicationTerminating]): Deleted.
3462         (-[WebDocumentController loadContent]): Deleted.
3463
3464 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3465
3466         [WebEditingTester] ARC-ify WebEditingTester
3467         https://bugs.webkit.org/show_bug.cgi?id=141827
3468
3469         Reviewed by Sam Weinig.
3470
3471         * WebEditingTester/AppDelegate.m:
3472         (-[WebEditingAppDelegate showOperations:]):
3473         * WebEditingTester/EditingOperations.m:
3474         (editingOperations):
3475         * WebEditingTester/WK1WebDocumentController.m:
3476         (-[WK1WebDocumentController dealloc]): Deleted.
3477         * WebEditingTester/WK2WebDocumentController.m:
3478         (-[WK2WebDocumentController dealloc]): Deleted.
3479         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3480         Turn on ARC and remove a few retain/release/autorelease calls.
3481         We don't need to implement dealloc in either document controller
3482         because WebView and WKWebView's UIDelegate property does not hold a
3483         strong reference.
3484
3485 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3486
3487         [WebEditingTester] Factor out list of editing operations
3488         https://bugs.webkit.org/show_bug.cgi?id=141826
3489
3490         Reviewed by Sam Weinig.
3491
3492         * WebEditingTester/AppDelegate.m:
3493         (-[WebEditingAppDelegate showOperations:]):
3494         * WebEditingTester/EditingOperations.h: Added.
3495         * WebEditingTester/EditingOperations.m: Added.
3496         (editingOperations):
3497         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3498         Move EditingOperations array to its own file, and make it an NSArray
3499         instead of a C array. Adjust accordingly in showOperations:.
3500
3501 2015-02-20  Michael Saboff  <msaboff@apple.com>
3502
3503         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3504         https://bugs.webkit.org/show_bug.cgi?id=141676
3505
3506         Reviewed by Filip Pizlo.
3507
3508         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3509         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3510         large string expression that we want to eval.
3511
3512         * Scripts/run-jsc-stress-tests:
3513
3514 2015-02-19  Daniel Bates  <dabates@apple.com>
3515
3516         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3517         https://bugs.webkit.org/show_bug.cgi?id=141815
3518         <rdar://problem/19893933>
3519
3520         Reviewed by Simon Fraser.
3521
3522         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3523         was booted by iOS Simulator in a previous run of run-webkit-test.
3524
3525         * Scripts/webkitpy/port/ios.py:
3526         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3527         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3528         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3529
3530 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3531
3532         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3533         <http://webkit.org/b/141799>
3534
3535         Reviewed by Alex Christensen.
3536
3537         * Scripts/webkitpy/style/checkers/cpp.py:
3538         (_IncludeState.check_next_include_order): Don't emit a warning
3539         if the primary header exists and the source file name ends with
3540         "SoftLink.cpp".  Add 'filename' argument to method.
3541         (check_include_line): Pass in 'filename'.
3542
3543         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3544         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3545         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3546         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3547         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3548         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3549         - Add test filename arguments for calls to
3550           check_next_include_order().
3551         (OrderOfIncludesTest.test_primary_header): Add test for a file
3552         name ending in "SoftLink.cpp".
3553
3554 2015-02-18  Enrica Casucci  <enrica@apple.com>
3555
3556         Add new tool to test editable Webviews.
3557         https://bugs.webkit.org/show_bug.cgi?id=141772
3558
3559         Reviewed by Tim Horton.
3560
3561         Adding WebEditingTester, a Cocoa application to
3562         test WK1 and Wk2 views in editable mode.
3563
3564         * WebEditingTester: Added.
3565         * WebEditingTester/AppDelegate.h: Added.
3566         * WebEditingTester/AppDelegate.m: Added.
3567         (-[WebEditingAppDelegate init]):
3568         (defaultConfiguration):
3569         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3570         (-[WebEditingAppDelegate applicationWillTerminate:]):
3571         (-[WebEditingAppDelegate newEditor:]):
3572         (-[WebEditingAppDelegate showOperations:]):
3573         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3574         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3575         (-[WebEditingAppDelegate validateMenuItem:]):
3576         * WebEditingTester/Info.plist: Added.
3577         * WebEditingTester/MainMenu.xib: Added.
3578         * WebEditingTester/WK1WebDocumentController.h: Added.
3579         * WebEditingTester/WK1WebDocumentController.m: Added.
3580         (-[WK1WebDocumentController awakeFromNib]):
3581         (-[WK1WebDocumentController loadContent]):
3582         (-[WK1WebDocumentController dealloc]):
3583         (-[WK1WebDocumentController pasteAsMarkup:]):
3584         * WebEditingTester/WK2WebDocumentController.h: Added.
3585         * WebEditingTester/WK2WebDocumentController.m: Added.
3586         (-[WK2WebDocumentController initWithConfiguration:]):
3587         (-[WK2WebDocumentController pasteAsMarkup:]):
3588         (-[WK2WebDocumentController awakeFromNib]):
3589         (-[WK2WebDocumentController dealloc]):
3590         (-[WK2WebDocumentController loadContent]):
3591         * WebEditingTester/WebDocument.xib: Added.
3592         * WebEditingTester/WebDocumentController.h: Added.
3593         * WebEditingTester/WebDocumentController.m: Added.
3594         (-[WebDocumentController initWithWindow:]):
3595         (-[WebDocumentController windowDidLoad]):
3596         (-[WebDocumentController defaultEditingSource]):
3597         (-[WebDocumentController applicationTerminating]):
3598         (-[WebDocumentController loadContent]):
3599         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3600         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3601         * WebEditingTester/main.m: Added.
3602         (main):
3603
3604 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3605
3606         Run JSC tests on ARM EFL bots
3607         https://bugs.webkit.org/show_bug.cgi?id=141165
3608
3609         Reviewed by Alexey Proskuryakov.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/config.json:
3612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3613         (RunJavaScriptCoreTests.countFailures):
3614         (RunRemoteJavaScriptCoreTests):
3615         (RunRemoteJavaScriptCoreTests.start):
3616         (BuildAndRemoteJSCTestsFactory):
3617         (BuildAndRemoteJSCTestsFactory.__init__):
3618
3619 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3620
3621         Streamline unexported function build fixes
3622         https://bugs.webkit.org/show_bug.cgi?id=141761
3623
3624         Reviewed by Alex Christensen.
3625
3626         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3627         We don't need to ignore symbols that are not exported due to the .unexp file.
3628
3629 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3630
3631         Remove more references to WebCore.exp.in
3632         https://bugs.webkit.org/show_bug.cgi?id=141747
3633
3634         Reviewed by Alexey Proskuryakov.
3635
3636         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3637         (ShouldBuildTest):
3638
3639 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3640
3641         Windows test results should not fall back to mac-mountainlion after r180176
3642         https://bugs.webkit.org/show_bug.cgi?id=141719
3643
3644         Reviewed by Brent Fulgham.
3645
3646         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3647         (_should_file_trigger_build):
3648         * Scripts/webkitpy/port/win.py:
3649         (WinPort.default_baseline_search_path):
3650         * Scripts/webkitpy/port/win_unittest.py:
3651         (WinPortTest.test_baseline_search_path):
3652
3653 2015-02-17  Daniel Bates  <dabates@apple.com>
3654
3655         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3656         https://bugs.webkit.org/show_bug.cgi?id=141718
3657
3658         Reviewed by Alex Christensen.
3659
3660         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3661
3662         * Scripts/webkitpy/port/ios.py:
3663         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3664         Log a error and return False if we are unable to boot the simulator device so that the caller can take
3665         appropriate action, say exit(3) before running any layout tests.
3666         * Scripts/webkitpy/xcode/simulator.py:
3667         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3668         with the specified UDID.
3669         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3670         with the specified UDID can successfully boot and shut down. We make at most two attempts to
3671         boot and shut down the device, erasing the device between tries so as to restore the device
3672         to a known good state.
3673
3674 2015-02-17  Daniel Bates  <dabates@apple.com>
3675
3676         run_webkit_tests.py should not know about iOS Simulator details
3677         https://bugs.webkit.org/show_bug.cgi?id=141711
3678
3679         Reviewed by Alex Christensen.
3680
3681         Run_webkit_tests.py should only parse the iOS-specific command
3682         line options --runtime and --device-type. Let the port-specific
3683         logic in ios.py validate the parsed options and instantiate
3684         internal data structures.
3685
3686         Currently run_webkit_tests.py parses the iOS-specific command
3687         line options --runtime and --device-type, validates them, and
3688         instantiates internal data structures from the parsed strings.
3689         Instead the validation logic and instantiation of internal
3690         data structures should be handled by the iOS port object.
3691
3692         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3693         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3694         and instantiate internal data structures for them.
3695         * Scripts/webkitpy/port/driver.py:
3696         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3697         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3698         respectively.
3699         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3700         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3701         object from --runtime, if specified. Otherwise, instantiates a Runtime
3702         object for the latest installed iphonesimulator SDK version.
3703         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3704         object from --device-type, if specified. Otherwise, instantiates
3705         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3706         machine, respectively.
3707         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3708         runtime is available to use.
3709         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3710         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3711         * Scripts/webkitpy/xcode/simulator.py:
3712         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3713         with a runtime identifier for the specified iOS version.
3714
3715 2015-02-17  Dana Burkart  <dburkart@apple.com>
3716
3717         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3718         https://bugs.webkit.org/show_bug.cgi?id=141672
3719
3720         Reviewed by David Kilzer.
3721
3722         * asan/webkit-asan-ignore.txt:
3723
3724 2015-02-17  Alex Christensen  <achristensen@webkit.org>
3725
3726         Remove WebCore.exp.in and clean up.
3727         https://bugs.webkit.org/show_bug.cgi?id=141491
3728
3729         Reviewed by Andreas Kling.
3730
3731         * Scripts/sort-export-file: Removed.
3732         * Scripts/webkitpy/style/checker.py:
3733         (_all_categories):
3734         (FileType):
3735         (CheckerDispatcher._file_type):
3736         (CheckerDispatcher._create_checker):
3737         Don't check if the export files are sorted.
3738         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3739         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3740
3741 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3742
3743         Unreviewed. Fix GTK+ make distcheck.
3744
3745         Do not exclude bmalloc directory from the tarball.
3746
3747         * gtk/manifest.txt.in:
3748
3749 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3750
3751         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3752
3753         I forgot to add the return of a bool function.
3754
3755         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3756         (WebKitDOMNodeTest::testDOMCache):
3757
3758 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3759
3760         [GTK] GObject DOM bindings object are cached forever
3761         https://bugs.webkit.org/show_bug.cgi?id=141558
3762
3763         Reviewed by Sergio Villar Senin.
3764
3765         Add checks for all DOM objects to ensure they are not leaked. Also
3766         add a dedicated test for the DOM Object Cache.
3767
3768         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3769         (WebKitDOMNodeFilterTest::testTreeWalker):
3770         (WebKitDOMNodeFilterTest::testNodeIterator):
3771         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3772         (WebKitDOMNodeTest::testHierarchyNavigation):
3773         (WebKitDOMNodeTest::testInsertion):
3774         (WebKitDOMNodeTest::testTagNames):
3775         (WebKitDOMNodeTest::testDOMCache):
3776         (registerTests):
3777         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3778         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3779         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3780         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3781         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3782         (testWebKitDOMObjectCache):
3783         (beforeAll):
3784         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3785         (documentLoadedCallback):
3786
3787 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3788
3789         [GTK] WebKitFrame objects are never released
3790         https://bugs.webkit.org/show_bug.cgi?id=141641
3791
3792         Reviewed by Martin Robinson.
3793
3794         Add a way to check GObjects leaks for WebProcess tests and check
3795         WebKitFrame objects are not leaked.
3796
3797         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3798         (WebKitFrameTest::testMainFrame):
3799         (WebKitFrameTest::testURI):
3800         (WebKitFrameTest::testJavaScriptContext):
3801         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3802         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3803         (runTest):
3804         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3805
3806 2015-02-16  Tim Horton  <timothy_horton@apple.com>
3807
3808         Fix the MiniBrowser build with newer clang
3809
3810         * MiniBrowser/mac/SettingsController.m:
3811         (-[SettingsController _toggleBooleanDefault:]):
3812         * MiniBrowser/mac/WK1BrowserWindowController.m:
3813         (-[WK1BrowserWindowController windowWillClose:]):
3814         * MiniBrowser/mac/WK2BrowserWindowController.m:
3815         (-[WK2BrowserWindowController windowWillClose:]):
3816         NSApp is id and clang gets confused about which -delegate we're talking about.
3817
3818 2015-02-16  Antti Koivisto  <antti@apple.com>
3819
3820         Develop/Disable Caches does not properly disable disk cache
3821         https://bugs.webkit.org/show_bug.cgi?id=141636
3822
3823         Reviewed by Anders Carlsson.
3824
3825         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3826         the network process too.
3827
3828         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3829
3830         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3831         (WTR::InjectedBundle::beginTesting):
3832         (WTR::InjectedBundle::setCacheModel):
3833         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3834         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3835
3836             Forward to TestController.
3837
3838         (WTR::TestRunner::setCacheModel):
3839         * WebKitTestRunner/TestInvocation.cpp:
3840         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3841
3842 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
3843
3844         Unreviewed. Add myself as a committer.
3845
3846         * Scripts/webkitpy/common/config/contributors.json:
3847
3848 2015-02-15  David Kilzer  <ddkilzer@apple.com>
3849
3850         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
3851         <http://webkit.org/b/141607>
3852
3853         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
3854         externals in Source/WebCore/Configurations/WebCore.unexp when
3855         building with Xcode 5.x.
3856         (readXcode5SymbolsToIgnore): Add.
3857
3858 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
3859
3860         [EFL] fix Evas GL engine error.
3861         https://bugs.webkit.org/show_bug.cgi?id=141621
3862
3863         Reviewed by Gyuyoung Kim.
3864
3865         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
3866
3867         * MiniBrowser/efl/main.c:
3868         (elm_main):
3869
3870 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
3871
3872         [buildbot] Enable run-api-tests on release Mac bots
3873         https://bugs.webkit.org/show_bug.cgi?id=141518
3874
3875         Reviewed by Darin Adler.
3876
3877         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3878         (RunUnitTests):
3879         (BuildFactory.__init__):
3880         (TestFactory.__init__):
3881         (BuildAndTestFactory.__init__):
3882         (RunUnitTests.start): Deleted.
3883         (unitTestsSupported): Deleted.
3884
3885 2015-02-13  Anders Carlsson  <andersca@apple.com>
3886
3887         Add a move constructor and move assignment operator to Deque
3888         https://bugs.webkit.org/show_bug.cgi?id=141571
3889
3890         Reviewed by Andreas Kling.
3891
3892         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3893         (TestWebKitAPI::TEST):
3894
3895 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3896
3897         run-jsc-stress-tests --remote should skip profiler tests
3898         https://bugs.webkit.org/show_bug.cgi?id=141470
3899
3900         Reviewed by Filip Pizlo.
3901
3902         * Scripts/run-jsc-stress-tests:
3903
3904 2015-02-13  Anders Carlsson  <andersca@apple.com>
3905
3906         Add an initializer list constructor to Deque
3907         https://bugs.webkit.org/show_bug.cgi?id=141565
3908
3909         Reviewed by Andreas Kling.
3910
3911         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3912         (TestWebKitAPI::TEST):
3913
3914 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3915
3916         [buildbot] Remove buildJSCTool cruft from master.cfg
3917         https://bugs.webkit.org/show_bug.cgi?id=141513
3918
3919         Reviewed by Alexey Proskuryakov.
3920
3921         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3922         (RunJavaScriptCoreTests):
3923         (RunJavaScriptCoreTests.start):
3924         (RunWebKitTests):
3925         (RunWebKitTests.start):
3926         (TestFactory.__init__):
3927         (TestLeaksFactory.__init__):
3928         (RunJavaScriptCoreTests.__init__): Deleted.
3929         (RunWebKitTests.__init__): Deleted.
3930
3931 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3932
3933         Unreviewed, remove empty directories.
3934
3935         * DumpRenderTree/gtk: Removed.
3936         * DumpRenderTree/gtk/fonts: Removed.
3937         * DumpRenderTree/unix: Removed.
3938         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
3939         * GtkLauncher: Removed.
3940         * TestWebKitAPI/Tests/WebKitGtk: Removed.
3941         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
3942         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
3943         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
3944
3945 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3946
3947         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
3948         https://bugs.webkit.org/show_bug.cgi?id=141519
3949
3950         Reviewed by Alexey Proskuryakov.
3951
3952         * Scripts/build-webkittestrunner:
3953
3954 2015-02-12  Alex Christensen  <achristensen@webkit.org>
3955
3956         Removed empty directory.
3957
3958         * WinCELauncher: Removed.
3959
3960 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3961
3962         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
3963         https://bugs.webkit.org/show_bug.cgi?id=141202
3964
3965         Reviewed by Darin Adler.
3966
3967         * Scripts/run-jsc-stress-tests:
3968
3969 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
3970
3971         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
3972         https://bugs.webkit.org/show_bug.cgi?id=141517
3973
3974         Reviewed by Anders Carlsson.
3975
3976         We do not need to locate or use the DLL's that came with Safari, so stop
3977         failing when we cannot find them. Also remove some old Qt cruft from this
3978         script.
3979
3980         * BuildSlaveSupport/built-product-archive:
3981         (archiveBuiltProduct):
3982         (extractBuiltProduct):
3983
3984 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
3985
3986         [Win] [64-bit] Work around MSVC2013 Runtime Bug
3987         https://bugs.webkit.org/show_bug.cgi?id=141498
3988         <rdar://problem/19803642>
3989
3990         Reviewed by Anders Carlsson.
3991
3992         Disable FMA3 instruction use in the MSVC math library to
3993         work around a VS2013 runtime crash. We can remove this
3994         workaround when we switch to VS2015.
3995
3996         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
3997         disable FMA3 support.
3998         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
3999         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
4000         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
4001         * Scripts/webkitperl/httpd.pm: Ditto.
4002         * TestWebKitAPI/win/main.cpp: Ditto.
4003         * WinLauncher/Common.cpp: Ditto.
4004         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
4005
4006 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
4007
4008         run-jsc-stress-tests should accept remote host config from JSON file
4009         https://bugs.webkit.org/show_bug.cgi?id=141509
4010
4011         Reviewed by Michael Saboff.
4012
4013         * Scripts/run-javascriptcore-tests:
4014         (runJSCStressTests):
4015         * Scripts/run-jsc-stress-tests:
4016
4017 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4018
4019         [GTK] Add API to allow overriding the default color chooser implementation
4020         https://bugs.webkit.org/show_bug.cgi?id=98935
4021
4022         Reviewed by Gustavo Noronha Silva.
4023
4024         Add a color chooser implementation for MiniBrowser using
4025         GtkPopover when the GTK+ version is recent enough.
4026         And a test case to check the new color chooser API.
4027
4028         * MiniBrowser/gtk/BrowserWindow.c:
4029         (colorChooserRGBAChanged):
4030         (popoverColorClosed):
4031         (colorChooserRequestFinished):
4032         (runColorChooserCallback):
4033         (browserWindowConstructed):
4034         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
4035         (testWebViewColorChooserRequest):
4036         (beforeAll):
4037
4038 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
4039
4040         Make run-jsc-stress-tests --remote work with make-based runner
4041         https://bugs.webkit.org/show_bug.cgi?id=141079
4042
4043         Reviewed by Darin Adler.
4044
4045         * Scripts/run-javascriptcore-tests:
4046         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
4047         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
4048         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
4049         to avoid code duplication.
4050
4051 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
4052
4053         run-jsc-stress tests should detect the number of processors on the remote machine too
4054         https://bugs.webkit.org/show_bug.cgi?id=141196
4055
4056         Reviewed by Darin Adler.
4057
4058         * Scripts/run-javascriptcore-tests:
4059         (runJSCStressTests): Pass through the --child-processes argument.
4060         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
4061         to detect the number of local and remote processors with the same algorithm.
4062         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
4063         same as $numProcessors.
4064
4065 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
4066
4067         run-jsc-stress-tests should pass JSC_timeout to remote hosts
4068         https://bugs.webkit.org/show_bug.cgi?id=141164
4069
4070         Reviewed by Darin Adler.
4071
4072         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
4073
4074         * Scripts/run-jsc-stress-tests:
4075
4076 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
4077
4078         [GTK] Add default color chooser implementation using GtkColorChooserDialog
4079         https://bugs.webkit.org/show_bug.cgi?id=141392
4080
4081         Reviewed by Gustavo Noronha Silva.
4082
4083         Enable INPUT_TYPE_COLOR by default for GTK+ port.
4084
4085         * Scripts/webkitperl/FeatureList.pm:
4086
4087 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
4088
4089         run-jsc-stress-tests shell test runner should run tests in fixed order
4090         https://bugs.webkit.org/show_bug.cgi?id=141383
4091
4092         Reviewed by Darin Adler.
4093
4094         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
4095
4096 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
4097
4098         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
4099         https://bugs.webkit.org/show_bug.cgi?id=140485
4100
4101         Reviewed by Anders Carlsson.
4102
4103         Implement takeFocus() as a way to set focus through accessibility wrappers.
4104
4105         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4106         (AccessibilityUIElement::takeFocus):
4107         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4108         (WTR::AccessibilityUIElement::takeFocus):
4109
4110 2015-02-08  Darin Adler  <darin@apple.com>
4111
4112         Remove the SVG instance tree
4113         https://bugs.webkit.org/show_bug.cgi?id=140602
4114
4115         Reviewed by Dean Jackson.
4116
4117         * Scripts/check-for-global-initializers: Removed special case for
4118         SVGElementInstance.o.
4119
4120 2015-02-07  David Kilzer  <ddkilzer@apple.com>
4121
4122         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
4123         <http://webkit.org/b/141365>
4124
4125         Reviewed by Daniel Bates.
4126
4127         * Scripts/webkitpy/xcode/simulator.py:
4128         (Simulator): Add unavailable_version_re precompiled regex.
4129         (Simulator._parse_devices): Check for unavailable versions and
4130         ignore them if found when parsing the output of
4131         `xcrun simctl list`.
4132         * Scripts/webkitpy/xcode/simulator_unittest.py:
4133         (test_unavailable_devices): Add test with output from
4134         `xcrun simctl list` with unavailable runtimes that fails before
4135         the fix.
4136
4137 2015-02-07  Chris Dumez  <cdumez@apple.com>
4138
4139         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
4140         https://bugs.webkit.org/show_bug.cgi?id=141321
4141
4142         Reviewed by Darin Adler.
4143
4144         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
4145
4146 2015-02-07  David Kilzer  <ddkilzer@apple.com>
4147
4148         [iOS] Make Simulator class testable
4149         <http://webkit.org/b/141358>
4150
4151         Rubber-stamped by Darin Adler.
4152
4153         * Scripts/webkitpy/common/system/platforminfo.py:
4154         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
4155         command to here from Simulator.refresh() in xcode/simulator.py
4156         so that the output of the command can be mocked.
4157
4158         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4159         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
4160         to None.
4161         (MockPlatformInfo.xcode_simctl_list): Add method that returns
4162         self.expected_xcode_simctl_list expectation.
4163
4164         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
4165         and license header.
4166         (Simulator.__init__): Add optional 'host' parameter to make it
4167         possible to pass in a mock object for testing.  Set self._host
4168         to 'host' parameter or create Host() object.
4169         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
4170         method.
4171
4172         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
4173         for current code.
4174         (SimulatorTest):
4175         (SimulatorTest.setUp):
4176         (SimulatorTest._set_expected_xcrun_simctl_list):
4177         (SimulatorTest.test_simulator_device_types):
4178         (test_invalid_device_types_header):
4179         (test_invalid_runtimes_header):
4180         (test_invalid_devices_header):
4181
4182 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
4183
4184         run-jsc-stress-tests --remote should use the default ssh port
4185         https://bugs.webkit.org/show_bug.cgi?id=141287
4186
4187         Reviewed by Darin Adler.
4188
4189         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
4190
4191 2015-02-06  Dana Burkart  <dburkart@apple.com>
4192
4193         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
4194         https://bugs.webkit.org/show_bug.cgi?id=141349
4195
4196         Reviewed by Alexey Proskuryakov.
4197
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4199         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4200         (BuildbotTesterQueueView.prototype.update):
4201
4202 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
4203
4204         Report network process crashes during layout tests
4205         https://bugs.webkit.org/show_bug.cgi?id=139646
4206
4207         Reviewed by Anders Carlsson.
4208
4209         * WebKitTestRunner/TestController.cpp:
4210         (WTR::TestController::initialize):
4211         (WTR::TestController::networkProcessName):
4212         (WTR::TestController::networkProcessDidCrash):
4213         * WebKitTestRunner/TestController.h:
4214
4215 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
4216
4217         run-jsc-stress-tests --remote should create remote directory before copying the bundle
4218         https://bugs.webkit.org/show_bug.cgi?id=141329
4219
4220         Reviewed by Michael Saboff.
4221
4222         * Scripts/run-jsc-stress-tests:
4223
4224 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4225
4226         [GTK] Remove WebKitWebView::close-notification signal
4227         https://bugs.webkit.org/show_bug.cgi?id=141330
4228
4229         Reviewed by Gustavo Noronha Silva.
4230
4231         Update notifications unit tests according to the API changes, and
4232         add a test case to check that onclose event is fired when a
4233         notification is closed by the user.
4234
4235         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4236         (testWebViewNotification):
4237
4238 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
4239
4240         Dashboard doesn't consider building ASan a productive step
4241         https://bugs.webkit.org/show_bug.cgi?id=141312
4242
4243         Reviewed by Simon Fraser.
4244
4245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4246
4247 2015-02-05  Daniel Bates  <dabates@apple.com>
4248
4249         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
4250         https://bugs.webkit.org/show_bug.cgi?id=141306
4251
4252         Reviewed by Alexey Proskuryakov.
4253
4254         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
4255         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
4256         existent runtime.
4257
4258         * Scripts/webkitpy/xcode/simulator.py:
4259         (Runtime.from_identifier):
4260
4261 2015-02-05  Daniel Bates  <dabates@apple.com>
4262
4263         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
4264         https://bugs.webkit.org/show_bug.cgi?id=139746
4265         <rdar://problem/19283658>
4266
4267         Reviewed by Alexey Proskuryakov.
4268
4269         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
4270         if the simulator device is not in state Booted.
4271
4272         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
4273         launching/relaunching the iOS Simulator app and a simulator app can only be installed
4274         on a device that is in the Booted state. LayoutTestRelay may run before the
4275         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
4276         We should defer executing LayoutTestRelay until the simulator device booted by
4277         iOS Simulator is in the Booted state.
4278
4279         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
4280         Simulator methods with the module name, simulator.
4281         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
4282         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
4283         before launching iOS Simulator to boot it.
4284         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
4285         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
4286         * Scripts/webkitpy/xcode/simulator.py:
4287         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
4288         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
4289         interested in the state of the device are more likely interested in the current state of the device as
4290         opposed to the state of the device when the Device object was created.
4291         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
4292         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
4293         from both this function and Simulator.device_state().
4294         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
4295         (Simulator.DeviceState): Added; class of constants.
4296         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
4297         device is in the specified state.
4298         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
4299         (Simulator.device_directory): Added.
4300         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
4301
4302 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
4303
4304         Disable retries on Mac debug testers
4305         https://bugs.webkit.org/show_bug.cgi?id=141296
4306
4307         Reviewed by Simon Fraser.
4308
4309         * BuildSlaveSupport/build.webkit.org-config/config.json:
4310
4311 2015-02-05  Dan Bernstein  <mitz@apple.com>
4312
4313         Need a way to force $xcodeSDK in webkitdirs.pm
4314         https://bugs.webkit.org/show_bug.cgi?id=141291
4315
4316         Reviewed by Anders Carlsson.
4317
4318         * Scripts/webkitdirs.pm:
4319         (setXcodeSDK): Added.
4320
4321 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
4322
4323         [Streams API] Implement a barebone ReadableStream interface
4324         https://bugs.webkit.org/show_bug.cgi?id=141045
4325
4326         Reviewed by Benjamin Poulain.
4327
4328         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
4329
4330 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
4331
4332         filter-build-webkit: reduce more unfiltered output
4333         https://bugs.webkit.org/show_bug.cgi?id=141282
4334
4335         Reviewed by Daniel Bates.
4336
4337         * Scripts/filter-build-webkit:
4338         Report CompileDTraceScript and Preprocess lines as successful.
4339
4340 2015-02-04  Dana Burkart  <dburkart@apple.com>
4341
4342         Botwatcher's Dashboard is cramped
4343         https://bugs.webkit.org/show_bug.cgi?id=140273
4344
4345         Reviewed by Alexey Proskuryakov.
4346
4347         Add a heading key which will allow for arbitrary headings in builder queues.
4348
4349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4350         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
4351         (BuildbotBuilderQueueView.prototype.update):