2011-02-06 Robert Hogan <robert@webkit.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-06  Robert Hogan  <robert@webkit.org>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] Clear page's groupName even when not in DRT
6         https://bugs.webkit.org/show_bug.cgi?id=53874
7
8         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
9         (WebCore::DumpRenderTree::windowCloseRequested):
10
11 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
12
13         Reviewed by Andreas Kling.
14
15         [CMake] Add dependencies for Visual Studio projects
16         https://bugs.webkit.org/show_bug.cgi?id=53773
17
18         Add a WebKit dependecy to WinCELauncher, so CMake can 
19         generate the correct build order for the solution.
20
21         * CMakeListsWinCE.txt:
22
23 2011-02-06  Andreas Kling  <kling@webkit.org>
24
25         Reviewed by Antonio Gomes.
26
27         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
28         https://bugs.webkit.org/show_bug.cgi?id=53869
29
30         * MiniBrowser/qt/BrowserView.cpp:
31         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
32         * MiniBrowser/qt/BrowserWindow.cpp:
33         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
34         * MiniBrowser/qt/BrowserWindow.h:
35
36 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
37
38         Reviewed by Dan Bernstein.
39
40         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
41         https://bugs.webkit.org/show_bug.cgi?id=42690
42         <rdar://problem/8213851>
43
44         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
45         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
46         (WTR::InjectedBundlePage::willSendRequestForFrame):
47         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
48         (WTR::LayoutTestController::LayoutTestController):
49         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
50         (WTR::LayoutTestController::willSendRequestReturnsNull):
51         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
52
53 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
54
55         Unreviewed, rolling out r77720.
56         http://trac.webkit.org/changeset/77720
57         https://bugs.webkit.org/show_bug.cgi?id=53854
58
59         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
60         #webkit).
61
62         * Scripts/webkitpy/common/system/executive.py:
63
64 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
65
66         Unreviewed, rolling out r77725.
67         http://trac.webkit.org/changeset/77725
68         https://bugs.webkit.org/show_bug.cgi?id=53844
69
70         It broke Qt minimal build (Requested by Ossy_ on #webkit).
71
72         * QtTestBrowser/launcherwindow.cpp:
73         (LauncherWindow::createChrome):
74         * QtTestBrowser/launcherwindow.h:
75         (WindowOptions::WindowOptions):
76         * QtTestBrowser/main.cpp:
77         (LauncherApplication::handleUserOptions):
78
79 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
80
81         Reviewed by Adam Barth.
82
83         [GTK] plugins/plugin-document-back-forward.html fails
84         https://bugs.webkit.org/show_bug.cgi?id=53833
85
86         Add the new "alert on load" functionality for the Unix version of the
87         test plugin. This functionality was originally introduced in r77706.
88
89         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
90         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
91
92 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
93
94         Reviewed by Andreas Kling.
95
96         Local Storage settings can be enable/disable from "Develop" menu
97         https://bugs.webkit.org/show_bug.cgi?id=52296
98
99         * QtTestBrowser/launcherwindow.cpp:
100         (LauncherWindow::createChrome):
101         (LauncherWindow::toggleLocalStorage):
102         (LauncherWindow::toggleOfflineStorageDatabase):
103         (LauncherWindow::toggleOfflineWebApplicationCache):
104         (LauncherWindow::setOfflineStorageDefaultQuota):
105         * QtTestBrowser/launcherwindow.h:
106         (WindowOptions::WindowOptions):
107         * QtTestBrowser/main.cpp:
108         (LauncherApplication::handleUserOptions):
109
110 2011-02-04  Tony Chang  <tony@chromium.org>
111
112         Reviewed by Eric Seidel.
113
114         get test-webkitpy running on win32 python
115         https://bugs.webkit.org/show_bug.cgi?id=53822
116
117         The test harness crashes with a WindowsError because it can't find
118         'svn' when using subprocess.Popen.  This gets us past the error
119         so we can see the failing tests on the Chromium Win Release Tests
120         bot.
121
122         * Scripts/webkitpy/common/system/executive.py:
123
124 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
125
126         Reviewed by Gustavo Noronha Silva.
127
128         [GTK] fast/events/pagehide-timeout.html fails
129         https://bugs.webkit.org/show_bug.cgi?id=53771
130
131         Add knowledge of the document browser cache model the DRT. When resetting
132         WebKit settings to consistent values between tests, default to the document
133         browser cache model.
134
135         * DumpRenderTree/gtk/DumpRenderTree.cpp:
136         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
137         cache model between tests.
138         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
139         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
140         document browser cache model.
141
142 2011-02-04  Adam Barth  <abarth@webkit.org>
143
144         Reviewed by Eric Seidel.
145
146         PluginDocuments don't create widgets for plugins on back/forward
147         https://bugs.webkit.org/show_bug.cgi?id=53474
148
149         Teach the test plugin how to call alert on load.
150
151         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
152         (NPP_New):
153
154 2011-02-04  Adam Roben  <aroben@apple.com>
155
156         Add a test case for encode/decode of FormData/FormDataElement
157
158         If the fix made in r77401 is broken, this new test will crash.
159
160         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
161
162         Reviewed by Sam Weinig.
163
164         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
165         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
166
167         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
168         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
169         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
170         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
171         form, an return the session state data.
172         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
173         and restore it into another WKPage.
174
175         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
176
177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
178         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
179         * TestWebKitAPI/win/copy-resources.cmd:
180         Added new files.
181
182 2011-02-04  Adam Roben  <aroben@apple.com>
183
184         Move code to run JavaScript tests into its own files
185
186         This will allow other tests to use this mechanism.
187
188         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
189         world
190
191         Reviewed by Sam Weinig.
192
193         * TestWebKitAPI/JavaScriptTest.cpp: Added.
194         * TestWebKitAPI/JavaScriptTest.h: Added.
195         Moved code here...
196
197         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
198
199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
200         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
201         Added the new files.
202
203 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
204
205         Reviewed by Mihai Parparita.
206
207         merge test expectations for chromium, chromium-gpu. The
208         chromium-gpu port will no longer maintain its own
209         test expectations file.
210
211         Also add in a graphics_type() call on the port object to
212         determine what graphics type to use in the test configuration,
213         and log the configuration as a config setting.
214
215         https://bugs.webkit.org/show_bug.cgi?id=53562
216
217         * Scripts/webkitpy/layout_tests/port/base.py:
218         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
219         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
220         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
221
222 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
223
224         Reviewed by Pavel Feldman.
225
226         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
227         https://bugs.webkit.org/show_bug.cgi?id=53781
228
229         * Scripts/check-inspector-strings:
230
231 2011-02-04  Adam Roben  <aroben@apple.com>
232
233         Include the crashing function in the link to a crash log on Mac
234
235         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
236         function that crashed on Mac
237
238         Reviewed by David Kilzer.
239
240         * Scripts/old-run-webkit-tests:
241         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
242         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
243         the crash log.
244
245 2011-02-04  Adam Roben  <aroben@apple.com>
246
247         Link to Mac crash logs from results.html
248
249         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
250         results.html
251
252         Reviewed by David Kilzer.
253
254         * Scripts/old-run-webkit-tests:
255         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
256         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
257
258 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
259
260         Reviewed by Dan Bernstein.
261
262         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
263         https://bugs.webkit.org/show_bug.cgi?id=52897
264         <rdar://problem/8898294>
265
266         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
267         (WTR::InjectedBundlePage::InjectedBundlePage):
268         (WTR::InjectedBundlePage::willSendRequestForFrame):
269         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
270
271 2011-02-03  Ivan Krstić  <ike@apple.com>
272
273         Unreviewed.
274
275         Adding myself to committers.py.
276
277         * Scripts/webkitpy/common/config/committers.py:
278
279 2011-02-03  James Kozianski  <koz@chromium.org>
280
281         Reviewed by Dimitri Glazkov.
282
283         Add navigator.registerProtocolHandler behind a flag.
284         https://bugs.webkit.org/show_bug.cgi?id=52609
285
286         * Scripts/build-webkit:
287
288 2011-02-03  Hayato Ito  <hayato@chromium.org>
289
290         Reviewed by Eric Seidel.
291
292         [NRWT] Remove TestArgs class, which is wrongly used.
293
294         https://bugs.webkit.org/show_bug.cgi?id=53063
295
296         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
297         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
298         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
299         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
300         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
301         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
302
303 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
304
305         Reviewed by Kenneth Russell.
306
307         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
308         https://bugs.webkit.org/show_bug.cgi?id=53714
309
310         * Scripts/build-webkit: change --3d-canvas build option
311           to set ENABLE_WEBGL
312
313 2011-02-03  Hayato Ito  <hayato@chromium.org>
314
315         Reviewed by Tony Chang.
316
317         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
318         move _run_single_test() and _process_output() functions from
319         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
320
321         This is clean up and acts as a preparation for elimination of test_types/*
322         classes. These classes will move to the single_test_runner module introduced
323         in this patch.
324
325         https://bugs.webkit.org/show_bug.cgi?id=53004
326
327         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
328         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
329         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
330         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
331         * Scripts/webkitpy/layout_tests/port/base.py:
332         * Scripts/webkitpy/layout_tests/port/chromium.py:
333         * Scripts/webkitpy/layout_tests/port/dryrun.py:
334         * Scripts/webkitpy/layout_tests/port/test.py:
335         * Scripts/webkitpy/layout_tests/port/webkit.py:
336         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
337         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
338         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
339
340 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
341
342         Unreviewed, build fix.
343
344         Delete a line that was accidentally missed in r77586; without it
345         there is still a race between the two threads.
346
347         https://bugs.webkit.org/show_bug.cgi?id=51572
348
349         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
350
351 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
352
353         Reviewed by Tony Chang.
354
355         nrwt: handle "broken pipe" notifications from DRT more cleanly.
356
357         https://bugs.webkit.org/show_bug.cgi?id=52927
358
359         * Scripts/webkitpy/layout_tests/port/server_process.py:
360         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
361
362 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
363
364         Reviewed by Kenneth Russell.
365
366         Update, resubmit change to bug 51572. I think the race that was
367         fixed in r76703 caused the hang that caused us to roll this
368         patch out before, so I'd like to try again.
369
370         https://bugs.webkit.org/show_bug.cgi?id=51572
371
372         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
373         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
374
375 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
376
377         Unreviewed.
378
379         Adding myself to committers.py.
380
381         * Scripts/webkitpy/common/config/committers.py:
382
383 2011-02-03  Adam Roben  <aroben@apple.com>
384
385         Include the crashing function in the link to a crash log
386
387         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
388         function that crashed
389
390         Reviewed by David Kilzer.
391
392         * Scripts/old-run-webkit-tests:
393         (crashLocation): Added. Returns the location of the crash.
394         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
395         could be determined.
396
397 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
398
399         Unreviewed, build fix.
400
401         Actually make the changes suggested by Mihai in his review
402         of bug 53720 :(
403
404         https://bugs.webkit.org/show_bug.cgi?id=53720
405
406         * Scripts/webkitpy/layout_tests/port/test_files.py:
407         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
408
409 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
410
411         Reviewed by Mihai Parparita.
412
413         new-run-webkit-tests: Fix bug introduced in r77434 that was
414         causing us to run the canvas GPU tests on the Mac GPU port. This
415         bug revealed that we were not setting the port.name() field
416         properly in many cases, so I've cleaned up all of that code, and
417         removed a few comments about "version-specific" GPU ports that
418         don't exist and just confused things.
419
420         Testing also revealed that port.abspath_for_test() wasn't
421         normalizing paths on Windows properly, so I fixed that as well.
422
423         https://bugs.webkit.org/show_bug.cgi?id=53719
424
425         * Scripts/webkitpy/layout_tests/port/base.py:
426         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
427         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
428
429 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
430
431         Reviewed by Mihai Parparita.
432
433         new-run-webkit-tests: fix normalization of paths on windows when gathering files
434
435         r77434 introduced a bug that was causing the test expectations
436         for the GPU ports to not be treated properly. It turns out that
437         when we gathered the list of test files on Windows, we would
438         return paths of the form "c:\LayoutTests/fast/canvas", and the
439         mixture of backslashes and forward slashes was confusing things.
440
441         This patch normalizes all of the filenames returned from
442         test_files.find(), and adds better tests for this (fixing a
443         couple of other bugs found in the meantime).
444
445         https://bugs.webkit.org/show_bug.cgi?id=53720
446
447         * Scripts/webkitpy/layout_tests/port/test.py:
448         * Scripts/webkitpy/layout_tests/port/test_files.py:
449         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
450
451 2011-02-03  Adam Roben  <aroben@apple.com>
452
453         Add links to Windows crash logs in results.html
454
455         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
456         results.html
457
458         Reviewed by David Kilzer.
459
460         * Scripts/old-run-webkit-tests:
461         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
462         createDebuggerCommandFile).
463         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
464         tool has exited.
465         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
466         it into the test results directory tree. Only implemented for Cygwin currently.
467         (findNewestFileMatchingGlob): Added. Does what it says.
468         (htmlForResultsSection): Only link to files that exist.
469         (linksForErrorTest): Add a link to the crash log.
470         (deleteExpectedAndActualResults): Delete any old crash log for this test.
471         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
472         hardcoding it here.
473
474 2011-02-03  Adam Roben  <aroben@apple.com>
475
476         Tell the debugger the path to the WebKit source tree when saving a crash log
477
478         This allows the debugger to include the crashing line of code in the log.
479
480         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
481         of code
482
483         Reviewed by Sam Weinig.
484
485         * Scripts/old-run-webkit-tests:
486         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
487         file and returns the path to that file. The commands we pass came from
488         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
489         WebKit source code lives.
490         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
491         line using -c, save them to a file and specify the path to that file using -cf. This works
492         around what is presumably a bug in Windows's command line parsing, where having multiple
493         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
494         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
495         together to make them easier to modify in the future.
496
497 2011-02-02  Sam Weinig  <sam@webkit.org>
498
499         Reviewed by Anders Carlsson.
500
501         Add notification of the end of a rubber band.
502         <rdar://problem/8940648>
503
504         * MiniBrowser/mac/BrowserWindowController.m:
505         (-[BrowserWindowController awakeFromNib]):
506         * WebKitTestRunner/TestController.cpp:
507         (WTR::TestController::createOtherPage):
508         (WTR::TestController::initialize):
509         Stub out the new WKUIClient function.
510
511 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
512
513         Unreviewed.
514
515         Adding myself to committers.py.
516
517         * Scripts/webkitpy/common/config/committers.py:
518
519 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
520
521         Reviewed by Csaba Osztrogonác.
522
523         [Qt][WK2] MiniBrowser's window size should be 800x600
524         https://bugs.webkit.org/show_bug.cgi?id=53670
525
526         Make layout test failure debugging easier.
527         * MiniBrowser/qt/BrowserWindow.cpp:
528         (BrowserWindow::BrowserWindow):
529
530 2011-02-02  Andy Estes  <aestes@apple.com>
531
532         Reviewed by Mark Rowe.
533
534         'update-webkit' should handle OpenSource and Internal using different
535         VCSs.
536
537         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
538         Internal directory.
539
540 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
541
542         Reviewed by Mihai Parparita.
543
544         new-run-webkit-tests: hardcode the directories to scan for tests
545         for GPU bots instead of SKIPping them. See bug 53562 for some
546         context, but we will now hard-code the list of directories to
547         use by default instead of skipping over directories in the
548         expectations file. We do this so that we will be able to merge
549         the expectations files without getting conflicting SKIP
550         directives. Note that this change will reduce the # of tests
551         being run on the Mac GPU bots, because we're accidentally
552         including some today.
553
554         https://bugs.webkit.org/show_bug.cgi?id=53631
555
556         * Scripts/webkitpy/layout_tests/port/base.py:
557         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
558         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
559
560 2011-02-02  Sam Weinig  <sam@webkit.org>
561
562         Reviewed by Beth Dakin.
563
564         Add ChromeClient function to paint custom overhang areas.
565         https://bugs.webkit.org/show_bug.cgi?id=53639
566
567         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
568         (WTR::InjectedBundlePage::InjectedBundlePage):
569         Stub out new callback.
570
571 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
572
573         Reviewed by Tony Chang.
574
575         new-run-webkit-tests: support chromium code paths in mock_drt
576
577         https://bugs.webkit.org/show_bug.cgi?id=53471
578
579         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
580         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
581
582 2011-02-02  Adam Klein  <adamk@chromium.org>
583
584         Reviewed by Tony Chang.
585
586         Update new-run-webkit-tests --chromium to put output under Source/...
587         https://bugs.webkit.org/show_bug.cgi?id=53612
588
589         * BuildSlaveSupport/test-result-archive:
590         * Scripts/webkitpy/layout_tests/port/chromium.py:
591
592 2011-01-28  Tony Chang  <tony@chromium.org>
593
594         Reviewed by Eric Seidel.
595
596         [chromium] remove --use-test-shell from NRWT
597         https://bugs.webkit.org/show_bug.cgi?id=53346
598
599         I've already started removing some of the bindings like eventSender so
600         this already doesn't work isn't useful.  Also updated some comments to
601         refer to DRT instead of test_shell.
602
603         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
604         * Scripts/webkitpy/layout_tests/port/chromium.py:
605         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
606         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
607         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
608         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
609         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
610         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
611
612 2011-02-02  Steve Lacey  <sjl@chromium.org>
613
614         Reviewed by Eric Carlson.
615
616         Implement basic media statistics on media elements.
617         https://bugs.webkit.org/show_bug.cgi?id=53322
618
619         * Scripts/build-webkit:
620
621 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
622
623         [wx] Build fixes for wxWebKit.
624
625         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
626         (LayoutTestController::setSerializeHTTPLoads):
627         * wx/browser/wscript:
628         * wx/build/build_utils.py:
629         * wx/build/settings.py:
630
631 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
632
633         Reviewed by Mihai Parparita.
634
635         new-run-webkit-tests: stop skipping so many tests
636
637         r77163 introduced a regression where we weren't resetting test
638         expectations properly and were skipping too many tests as a
639         result. This patch fixes that and adds a test for it.
640
641         https://bugs.webkit.org/show_bug.cgi?id=53551
642
643         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
644         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
645
646 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
647
648         Reviewed by Tony Chang.
649
650         new-run-webkit-tests: add first stub of test_runner2. This
651         will add support for the 'inline', 'threads', and 'processes'
652         flags to --worker-model, but for now the implementatios just
653         fall back on the old ones.
654
655         https://bugs.webkit.org/show_bug.cgi?id=53157
656
657         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
658         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
659
660 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
661
662         Reviewed by James Robinson.
663
664         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
665         https://bugs.webkit.org/show_bug.cgi?id=53522
666
667         * Scripts/run-chromium-webkit-unit-tests:
668
669 2011-02-01  Adam Barth  <abarth@webkit.org>
670
671         Reviewed by Mihai Parparita.
672
673         Using Control-C to cancel webkit-patch or other python tools causes
674         unpleasant traceback console spew
675         https://bugs.webkit.org/show_bug.cgi?id=53462
676
677         Catch the exception and don't print the stack trace.
678
679         * Scripts/webkit-patch:
680
681 2011-02-01  Scott Cameron  <sccameron@rim.com>
682
683         Reviewed by Daniel Bates.
684
685         Use Windows format for MinGW HTTPD path.
686         https://bugs.webkit.org/show_bug.cgi?id=53503
687
688         * Scripts/webkitperl/httpd.pm:
689           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
690             so that we don't have to escape the space characters in the path. Also,
691             changed path to Windows-style path and removed FIXME comment.
692
693 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
694
695         Reviewed by Andreas Kling.
696
697         [Qt][WK2] Add a way to use shared process model in MiniBrowser
698         https://bugs.webkit.org/show_bug.cgi?id=53090
699
700         * MiniBrowser/qt/BrowserView.cpp:
701         (BrowserView::BrowserView): Removed the m_context member.
702         From now the context is guaranteed to be non-null and we
703         don't need to store that in the object.
704         * MiniBrowser/qt/BrowserView.h:
705         * MiniBrowser/qt/BrowserWindow.cpp:
706         Added static bool to determine that new windows need to be
707         created with their own context or not. Use the same context
708         and web process by default to be inilne with the other ports.
709         (BrowserWindow::BrowserWindow):
710         (BrowserWindow::newWindow):
711         * MiniBrowser/qt/BrowserWindow.h:
712         * MiniBrowser/qt/main.cpp:
713         (main): Added command line switch to be able to use the
714         non-shared process model. Simplify the handling of the command line
715         switches a little bit.
716
717 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
718
719         Reviewed by Andreas Kling.
720
721         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
722         https://bugs.webkit.org/show_bug.cgi?id=53491
723
724         * MiniBrowser/qt/BrowserWindow.cpp:
725         (BrowserWindow::BrowserWindow):
726         (BrowserWindow::toggleFullScreenMode):
727         * MiniBrowser/qt/BrowserWindow.h:
728
729 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
730
731         Reviewed by Andreas Kling.
732
733         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
734         https://bugs.webkit.org/show_bug.cgi?id=53489
735
736         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
737         to Settings menu.
738
739         * MiniBrowser/qt/BrowserWindow.cpp:
740         (BrowserWindow::BrowserWindow):
741         (BrowserWindow::toggleFrameFlattening):
742         (BrowserWindow::toggleDisableJavaScript):
743         (BrowserWindow::toggleAutoLoadImages):
744         * MiniBrowser/qt/BrowserWindow.h:
745
746 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
747
748         Reviewed by Tony Chang.
749
750         [Chromium] Switch chromium-mac to use ChromiumDriver
751         https://bugs.webkit.org/show_bug.cgi?id=53461
752         
753         For the sake of consistency with the other Chromium platforms (and so
754         that chromium-mac picks up special flags like --enable-hardware-gpu),
755         switch chromium-mac from the WebKitDriver to ChromiumDriver.
756
757         * Scripts/webkitpy/layout_tests/port/chromium.py:
758
759 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
760
761         Reviewed by Mihai Parparita.
762
763         The current modifier parsing code in test_expectations is
764         fragile and hard-coded, so it's not easy to understand the logic
765         or easily add new types of modifiers (like GPU vs. CPU testing
766         for graphics tests, or 32-bit vs. 64-bit differences).
767
768         This is the first of two patches that will add in more generic
769         support and then eliminate the GPU-specific test expectations
770         files for Chromium.
771
772         This patch adds two standalone objects for handling modifiers. The
773         rules for interpreting modifiers, precedence, and conflicts are
774         given in the docstring to the ModifierMatcher class, which
775         returns ModifierMatchResult objects.
776         
777         This patch also adds routines to the Port interface and a
778         default set of values in the base object, in order to obtain the
779         values needed on a given test run. These values are then passed
780         to the expectation parser. This also allows us to clean up the
781         logic used to lint all of the different configurations in a
782         single test_expectations.txt file.
783
784         The next patch will merge in the separate GPU expectations file.
785
786         https://bugs.webkit.org/show_bug.cgi?id=51222
787
788         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
789         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
790         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
791         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
792         * Scripts/webkitpy/layout_tests/port/base.py:
793         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
794         * Scripts/webkitpy/layout_tests/port/chromium.py:
795         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
796         * Scripts/webkitpy/layout_tests/port/test.py:
797         * Scripts/webkitpy/layout_tests/port/webkit.py:
798         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
799         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
800         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
801         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
802         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
803
804 2011-01-31  Scott Cameron  <sccameron@rim.com>
805
806         Reviewed by Daniel Bates.
807
808         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
809         https://bugs.webkit.org/show_bug.cgi?id=50036
810
811         This will add an Apache2.2 configuration file and modifies scripts to allow
812         running an httpd server in an MSYS environment.
813
814         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
815         in order to allow for simple installation/execution.  Simply install the latest
816         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
817         be able to execute run-webkit-httpd.
818         
819
820         * Scripts/run-webkit-httpd:
821         * Scripts/webkitperl/httpd.pm:
822
823 2011-01-31  Tony Chang  <tony@chromium.org>
824
825         Reviewed by Eric Seidel.
826
827         mac DRT should report RTL scroll offset relative to top right corner
828         https://bugs.webkit.org/show_bug.cgi?id=53324
829
830         * DumpRenderTree/mac/DumpRenderTree.mm:
831         (dumpFrameScrollPosition):
832
833 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
834
835         Reviewed by Andreas Kling.
836
837         [Qt] Add Take Screen Shot action to MiniBrowser
838         https://bugs.webkit.org/show_bug.cgi?id=53422
839
840         Add Take Screen Shot action to MiniBrowser's view menu.
841
842         * MiniBrowser/qt/BrowserWindow.cpp:
843         (BrowserWindow::BrowserWindow):
844         (BrowserWindow::screenshot):
845         * MiniBrowser/qt/BrowserWindow.h:
846
847 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
848
849         Reviewed by Xan Lopez.
850
851         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
852         https://bugs.webkit.org/show_bug.cgi?id=53379
853
854         Remove left over #ifdef's. I thought all of the conditional code
855         had been freed from the condition, but I forgot to check DRT.
856
857         * DumpRenderTree/gtk/DumpRenderTree.cpp:
858         (resetDefaultsToConsistentValues):
859         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
860         (LayoutTestController::setAlwaysAcceptCookies):
861
862 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
863
864         Unreviewed, build fix.
865
866         Fix regression introduced in r77093 - path.rsplit() doesn't
867         take keyword arguments.
868
869         https://bugs.webkit.org/show_bug.cgi?id=53326
870
871         * Scripts/webkitpy/common/system/filesystem_mock.py:
872
873 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
874
875         Reviewed by Mihai Parparita.
876
877         Add more unit tests for rebaseline-chromium-webkit-tests. This
878         change involves restructuring a bunch of r-c-w-t code to make it
879         more testable as well. We also add wrapper classes for handling
880         testing zip files and fetching URLs.
881
882         https://bugs.webkit.org/show_bug.cgi?id=53040
883
884         * Scripts/webkitpy/common/system/urlfetcher.py:
885         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
886         * Scripts/webkitpy/common/system/zipfileset_mock.py:
887         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
888         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
889         * Scripts/webkitpy/tool/mocktool.py:
890
891 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
892
893         Reviewed by Eric Seidel.
894
895         Clean up of the filesystem-related modules used in webkitpy.
896         I've added relpath() to the filesystem interface, modified
897         ospath.relpath() so that it could work with the filesystem
898         interface, and modified the fileset* routines to use the
899         filesystem interface consistently.
900
901         This patch also adds a close() routine to the fileset routines
902         to indicate that the caller is done with the fileset. This
903         allows zipfileset to clean up after itself when it creates
904         tempfiles to store downloads.
905
906         https://bugs.webkit.org/show_bug.cgi?id=53326
907
908         * Scripts/webkitpy/common/system/directoryfileset.py:
909         * Scripts/webkitpy/common/system/fileset.py:
910         * Scripts/webkitpy/common/system/filesystem.py:
911         * Scripts/webkitpy/common/system/filesystem_mock.py:
912         * Scripts/webkitpy/common/system/filesystem_unittest.py:
913         * Scripts/webkitpy/common/system/ospath.py:
914         * Scripts/webkitpy/common/system/zipfileset.py:
915         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
916
917 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
918
919         Reviewed by Csaba Osztrogonác.
920
921         [Qt][WK2]REGRESSION (r76991): Fix build errors
922         https://bugs.webkit.org/show_bug.cgi?id=53400
923
924         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
925         and remove WebKit2Prefix.h from the build.
926         * MiniBrowser/qt/MiniBrowser.pro:
927
928 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
929
930         Unreviewed.
931
932         [Qt][WK2] Buildfix.
933
934         * MiniBrowser/qt/MiniBrowser.pro:
935
936 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
937
938         Reviewed by Adam Roben.
939         
940         define NOMINMAX when building ImageDiff, as we do elsewhere.
941
942         Add various clampToInt() methods to MathExtras.h
943         https://bugs.webkit.org/show_bug.cgi?id=52910
944
945         * DumpRenderTree/win/ImageDiffCommon.vsprops:
946
947 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
948
949         Reviewed by Darin Adler.
950
951         WebKitTestRunner needs layoutTestController.setPOSIXLocale
952         https://bugs.webkit.org/show_bug.cgi?id=42682
953
954         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
955         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
956         (WTR::InjectedBundle::resetLocalSettings):
957         (WTR::InjectedBundle::didReceiveMessage):
958         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
959         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
960         (WTR::LayoutTestController::setPOSIXLocale):
961         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
962
963 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
964  
965          Reviewed by Mihai Parparita.
966  
967          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
968  
969          This patch re-enables this test and changes it to
970          handle all of the mac platform versions, not just the one
971          it is running on.
972  
973          https://bugs.webkit.org/show_bug.cgi?id=53356
974  
975          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
976  
977 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
978
979         Unreviewed, build fix.
980
981         Take two. The fix in 77023 didn't work, because we were
982         still calling path.abspath_to_uri, which calls _cygpath under
983         the covers, and it appears the cygpath on the bots does
984         something different than it does on my machine. This patch
985         removes the calls to path.abspath_to_uri, so it should be safe.
986         If it doesn't work, I'll roll it out along with r76982 and 77023.
987
988         https://bugs.webkit.org/show_bug.cgi?id=53126
989
990         * Scripts/webkitpy/layout_tests/port/test.py:
991
992 2011-01-28  David Kilzer  <ddkilzer@apple.com>
993
994         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
995         <http://webkit.org/b/53353>
996
997         Reviewed by Mark Rowe.
998
999         * Scripts/webkitdirs.pm:
1000         (checkRequiredSystemConfig): Check the Xcode marketing version
1001         in addition to the DevCoreTools build version before complaining
1002         about an old version of Xcode.  Also make the Mac OS X version
1003         check use Perl's built-in version string comparitor.
1004
1005 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1006
1007         Unreviewed, build fix.
1008
1009         Work around breakage on Win 7 Release bot caused by r76982
1010         and the fact that windows ports use "file:////" instead of
1011         "file:///". Ideally the test code should be isolated from
1012         this, but it isn't yet. Will fix properly in a bit.
1013
1014         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1015
1016 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1017
1018         Reviewed by Tony Chang.
1019
1020         new-run-webkit-tests: change worker model values to
1021         "old-inline", "old-threads" in preparation for test_runner2 /
1022         multiprocessing changes.
1023
1024         https://bugs.webkit.org/show_bug.cgi?id=53156
1025
1026         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1027         * Scripts/webkitpy/layout_tests/port/base.py:
1028         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1029         * Scripts/webkitpy/layout_tests/port/mac.py:
1030         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1031
1032 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1033
1034         Reviewed by Tony Chang.
1035
1036         committers.py - add an IRC nickname for dpranke
1037         https://bugs.webkit.org/show_bug.cgi?id=53335
1038
1039         * Scripts/webkitpy/common/config/committers.py:
1040
1041 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1042
1043         Reviewed by Tony Chang.
1044
1045         new-run-webkit-tests: add a "mock DRT" port implementation
1046         and a separate class that emulates what we expect the
1047         DumpRenderTree behavior to be.
1048
1049         This will eventually replace port/dryrun.py and allow us to get
1050         better test coverage of the new-run-webkit-tests code as well as
1051         a reference for what new-run-webkit-tests expects from DRT.
1052
1053         This is the first attempt at this, and it is pretty bare-boned. It
1054         really only has been tested on the 'mac' port (and a little on
1055         the 'chromium-mac' port.
1056
1057         https://bugs.webkit.org/show_bug.cgi?id=53126
1058
1059         * Scripts/webkitpy/common/system/filesystem_mock.py:
1060         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1061         * Scripts/webkitpy/layout_tests/port/factory.py:
1062         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1063         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1064         * Scripts/webkitpy/layout_tests/port/test.py:
1065
1066 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1067
1068         Unreviewed. Removing .swp file checked in by mistake.
1069
1070         * Scripts/.webkitdirs.pm.swp: Removed.
1071
1072 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1073
1074         Reviewed by David Kilzer.
1075
1076         Space not necessary for undefined feature
1077         https://bugs.webkit.org/show_bug.cgi?id=53317
1078
1079         * Scripts/build-webkit:
1080
1081 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1082
1083         Reviewed by Andreas Kling.
1084
1085         Reset NetworkAccessManager to clean up credentials from previous tests.
1086         This change causes no performance overhead either.
1087         https://bugs.webkit.org/show_bug.cgi?id=36688
1088
1089         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1090         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1091         (WebCore::DumpRenderTree::open):
1092         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1093
1094 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1095
1096         Reviewed by Andreas Kling.
1097
1098         [Qt] Add Zoom Text Only action to MiniBrowser
1099         https://bugs.webkit.org/show_bug.cgi?id=53297
1100
1101         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1102
1103         * MiniBrowser/qt/BrowserWindow.cpp:
1104         (BrowserWindow::BrowserWindow):
1105         (BrowserWindow::zoomIn):
1106         (BrowserWindow::zoomOut):
1107         (BrowserWindow::resetZoom):
1108         (BrowserWindow::toggleZoomTextOnly):
1109         (BrowserWindow::applyZoom):
1110         * MiniBrowser/qt/BrowserWindow.h:
1111
1112 2011-01-28  Adam Barth  <abarth@webkit.org>
1113
1114         Reviewed by Eric Seidel.
1115
1116         Add webkit-patch roll-chromium-deps
1117         https://bugs.webkit.org/show_bug.cgi?id=53288
1118
1119         This command updates the Source/WebKit/chromium/DEPS file with the
1120         last-known good revision of Chromium (or a revision specified on the
1121         command line).  I'd eventually like to turn this into a SheriffBot
1122         command, but this is the first step.
1123
1124         This patch somewhat sprawled because I needed to move a bunch of code
1125         out of ChangeLog that should never have been there in the first place.
1126         Also, I had to fix a bug in MockUser in order to test the new command.
1127
1128         * Scripts/webkitpy/common/checkout/api.py:
1129         * Scripts/webkitpy/common/checkout/changelog.py:
1130         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1131         * Scripts/webkitpy/common/checkout/deps.py: Added.
1132         * Scripts/webkitpy/common/config/urls.py:
1133         * Scripts/webkitpy/tool/commands/__init__.py:
1134         * Scripts/webkitpy/tool/commands/download_unittest.py:
1135         * Scripts/webkitpy/tool/commands/roll.py: Added.
1136         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1137         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1138         * Scripts/webkitpy/tool/mocktool.py:
1139         * Scripts/webkitpy/tool/steps/__init__.py:
1140         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1141         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1142         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1143         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1144         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1145         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1146
1147 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1148
1149         Reviewed by Laszlo Gombos.
1150
1151         Get rid of prefix header dependency for WebKit2 build system
1152         https://bugs.webkit.org/show_bug.cgi?id=50174
1153
1154         Change the style checker so that it enforces config.h include for
1155         WebKit2.
1156
1157         * Scripts/webkitpy/style/checker.py:
1158
1159 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1160
1161         Reviewed by Darin Adler.
1162
1163         execCommand("Paste") doesn't work in WebKitTestRunner
1164         https://bugs.webkit.org/show_bug.cgi?id=52785
1165
1166         Enable both of the settings needed to allow paste.
1167         
1168         * WebKitTestRunner/TestController.cpp:
1169         (WTR::TestController::resetStateToConsistentValues):
1170
1171 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1172
1173         Reviewed by Andreas Kling.
1174
1175         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1176         https://bugs.webkit.org/show_bug.cgi?id=48440
1177
1178         Preserve user input when toggling use of QGraphicsView
1179
1180         * QtTestBrowser/launcherwindow.cpp:
1181         (LauncherWindow::initializeView):
1182         (LauncherWindow::loadFinished):
1183         * QtTestBrowser/launcherwindow.h:
1184         * QtTestBrowser/mainwindow.cpp:
1185         (MainWindow::addressUrl):
1186         * QtTestBrowser/mainwindow.h:
1187
1188 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1189
1190         Reviewed by Mihai Parparita.
1191
1192         new-run-webkit-tests: turn off pixel tests correctly by default
1193         for webkit-based ports. r70013 (bug 47510) used
1194         port.set_option_default() to attempt to set default values, but
1195         that didn't work correctly. I have removed set_option_default
1196         for now since it was only being used in two places and in three
1197         useless unit tests. There is a separate bug open to fix the
1198         option parsing (48095), so this workaround is fine for now.
1199
1200         https://bugs.webkit.org/show_bug.cgi?id=53217
1201
1202         * Scripts/webkitpy/layout_tests/port/webkit.py:
1203         * Scripts/webkitpy/layout_tests/port/base.py:
1204         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1205
1206 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1207
1208         Rubber-stamped by Ariya Hidayat.
1209
1210         Trivial crash fix in WTR.
1211
1212         * WebKitTestRunner/TestController.cpp:
1213         (WTR::TestController::initialize): Increase the size
1214         of the vector by one to be able to store the null character.
1215
1216 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1217
1218         Reviewed by Csaba Osztrogonác.
1219
1220         [Qt][WK2] WTR should be initialized in the same way as DRT
1221         https://bugs.webkit.org/show_bug.cgi?id=53240
1222
1223         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1224         (WTR::activateFonts): Added missing initialization steps.
1225
1226 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1227
1228         Unreviewed. 
1229
1230         Adding myself to committers.py.
1231
1232         * Scripts/webkitpy/common/config/committers.py:
1233
1234 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1235
1236         Reviewed by Csaba Osztrogonác.
1237
1238         [Qt] [Symbian] Move project files into Source
1239         https://bugs.webkit.org/show_bug.cgi?id=52891
1240
1241         Fix the Symbian build after the project files
1242         are moved to Source directory. On Symbian qmake
1243         needs to run in the same directory where the main
1244         pro files (WebKit.pro, Tools.pro) are located.
1245
1246         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1247         is located before running qmake for Symbian. Qmake on Symbian
1248         does not properly honor the "-o" option, work it around by setting
1249         the name of the Makefile to bld.inf.
1250
1251 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1252
1253         Reviewed by Andreas Kling.
1254
1255         [Qt] Add simple zooming features to MiniBrowser
1256         https://bugs.webkit.org/show_bug.cgi?id=53231
1257
1258         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1259
1260         * MiniBrowser/qt/BrowserWindow.cpp:
1261         (BrowserWindow::BrowserWindow):
1262         (BrowserWindow::zoomIn):
1263         (BrowserWindow::zoomOut):
1264         (BrowserWindow::resetZoom):
1265         (BrowserWindow::updateUserAgentList):
1266         (BrowserWindow::applyZoom):
1267         * MiniBrowser/qt/BrowserWindow.h:
1268
1269 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1270
1271         Reviewed by Dan Bernstein.
1272
1273         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1274         https://bugs.webkit.org/show_bug.cgi?id=42319
1275         
1276         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1277
1278         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1279         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1280         (WTR::LayoutTestController::showWebInspector):
1281         (WTR::LayoutTestController::closeWebInspector):
1282         (WTR::LayoutTestController::evaluateInWebInspector):
1283         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1284         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1285         * WebKitTestRunner/TestInvocation.cpp:
1286         (WTR::shouldOpenWebInspector):
1287         (WTR::TestInvocation::invoke):
1288         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1289
1290 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1291
1292         Reviewed by Xan Lopez.
1293
1294         [GTK] Pixel dumps do not include scrollbars in output images
1295         https://bugs.webkit.org/show_bug.cgi?id=53216
1296
1297         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1298         that have scrollbars.
1299
1300         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1301         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1302         instead of the web view itself.
1303
1304 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1305
1306         Reviewed by Mihai Parparita.
1307
1308         Fix regression introduced in r76322 ... new-run-webkit-tests
1309         was attempting to save the image diff output as a UTF-8-encoded
1310         file.
1311
1312         https://bugs.webkit.org/show_bug.cgi?id=53210
1313
1314         * Scripts/webkitpy/layout_tests/port/webkit.py:
1315
1316 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1317
1318         Unreviewed, rolling out r76709.
1319         http://trac.webkit.org/changeset/76709
1320         https://bugs.webkit.org/show_bug.cgi?id=53194
1321
1322         "broke python tests on non-snowleopard platforms" (Requested
1323         by dpranke on #webkit).
1324
1325         * Scripts/webkitpy/layout_tests/port/factory.py:
1326         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1327         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1328
1329 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1330
1331         Reviewed by Tony Chang.
1332
1333         new-run-webkit-tests: add a "mock DRT" port implementation
1334         and a separate class that emulates what we expect the
1335         DumpRenderTree behavior to be.
1336
1337         This will eventually replace port/dryrun.py and allow us to get
1338         better test coverage of the new-run-webkit-tests code as well as
1339         a reference for what new-run-webkit-tests expects from DRT.
1340
1341         This is the first attempt at this, and it is pretty bare-boned. It
1342         really only has been tested on the 'mac' port (and a little on
1343         the 'chromium-mac' port.
1344
1345         https://bugs.webkit.org/show_bug.cgi?id=53126
1346
1347         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1348         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1349         * Scripts/webkitpy/layout_tests/port/factory.py:
1350
1351 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1352
1353         Reviewed by Tony Chang.
1354
1355         Add '--no-timeout' option to Chromium DRT to ease debugging.
1356         https://bugs.webkit.org/show_bug.cgi?id=52873
1357
1358         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1359         (main):
1360
1361 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1362
1363         Reviewed by Andreas Kling.
1364
1365         [Qt] Fix qt_minimal build
1366         https://bugs.webkit.org/show_bug.cgi?id=53172
1367
1368         * QtTestBrowser/locationedit.h:
1369
1370 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1371
1372         Reviewed by Antonio Gomes.
1373
1374         QtTestBrowser should have a UI Setting to disable plugins
1375         https://bugs.webkit.org/show_bug.cgi?id=52408
1376         
1377         Added a new action item named "Disable Plugins"
1378         under the "Settings" menu. 
1379
1380         * QtTestBrowser/launcherwindow.cpp:
1381         (LauncherWindow::createChrome):
1382         (LauncherWindow::togglePlugins):
1383         * QtTestBrowser/launcherwindow.h:
1384
1385 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1386
1387         Reviewed by Adam Barth.
1388
1389         Move main CMakeLists.txt into Source directory
1390         https://bugs.webkit.org/show_bug.cgi?id=52888
1391
1392         * Scripts/webkitdirs.pm:
1393
1394 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1395
1396         Reviewed by Eric Seidel.
1397
1398         Improve label text in submit-to-ews
1399         https://bugs.webkit.org/show_bug.cgi?id=53130
1400
1401         * QueueStatusServer/templates/submittoews.html:
1402
1403 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1404
1405         Reviewed by Antonio Gomes.
1406
1407         QtTestBrowser should have a UI Settings to prevent loading images
1408         https://bugs.webkit.org/show_bug.cgi?id=52409
1409         
1410         Added a new action item named "DisableAutoLoadImages"
1411         under the "Settings" menu 
1412
1413         * QtTestBrowser/launcherwindow.cpp:
1414         (LauncherWindow::createChrome):
1415         (LauncherWindow::toggleAutoLoadImages):
1416         * QtTestBrowser/launcherwindow.h:
1417
1418 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1419
1420         Reviewed by Tony Chang.
1421
1422         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1423         classes, test_expectations.py. This change adds "test-win" and
1424         "test-mac" variants to the test port so that we can better test
1425         rebaselining, and adds a MockUser() object for reuse in testing.
1426
1427         https://bugs.webkit.org/show_bug.cgi?id=53036
1428
1429         * Scripts/webkitpy/common/system/filesystem.py:
1430         * Scripts/webkitpy/common/system/filesystem_mock.py:
1431         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1432         * Scripts/webkitpy/layout_tests/port/factory.py:
1433         * Scripts/webkitpy/layout_tests/port/base.py:
1434         * Scripts/webkitpy/layout_tests/port/test.py:
1435         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1436         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1437         * Scripts/webkitpy/tool/mocktool.py:
1438
1439 2011-01-25  Tony Chang  <tony@chromium.org>
1440
1441         Reviewed by Dimitri Glazkov.
1442
1443         [chromium] remove unused layoutTestController callback
1444         https://bugs.webkit.org/show_bug.cgi?id=53103
1445
1446         This method is used by a test_shell_test, but not needed by DRT.
1447
1448         * DumpRenderTree/chromium/LayoutTestController.cpp:
1449         (LayoutTestController::LayoutTestController):
1450         * DumpRenderTree/chromium/LayoutTestController.h:
1451
1452 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1453
1454         Reviewed by Andreas Kling.
1455
1456         [GTK] Remove 64 bits release bot from the buildbot master
1457         https://bugs.webkit.org/show_bug.cgi?id=52899
1458
1459         Removes the 64 bits release slave from the buildbot configuration,
1460         so that we can use it as an EWS.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/config.json:
1463
1464 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1465
1466         Reviewed by Dan Bernstein.
1467
1468         Implement database quota callback to fix storage tests on WebKit2 bot
1469         https://bugs.webkit.org/show_bug.cgi?id=53064
1470
1471         * WebKitTestRunner/TestController.cpp:
1472         (WTR::exceededDatabaseQuota):
1473         (WTR::TestController::createOtherPage):
1474         (WTR::TestController::initialize):
1475
1476 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1477
1478         Reviewed by Anders Carlsson.
1479
1480         Use designated temp directory for the database for WebKit2
1481         https://bugs.webkit.org/show_bug.cgi?id=53052
1482         
1483         Adopt the new WK2 API for this.
1484
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::libraryPathForTesting):
1487         (WTR::TestController::initialize):
1488         * WebKitTestRunner/TestController.h:
1489         * WebKitTestRunner/mac/TestControllerMac.mm:
1490         (WTR::TestController::platformLibraryPathForTesting):
1491         * WebKitTestRunner/qt/TestControllerQt.cpp:
1492         (WTR::TestController::platformLibraryPathForTesting):
1493         * WebKitTestRunner/win/TestControllerWin.cpp:
1494         (WTR::TestController::platformLibraryPathForTesting):
1495
1496 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1497
1498         Reviewed by Stephanie Lewis.
1499
1500         Add a new Leopard test bot.
1501
1502         * BuildSlaveSupport/build.webkit.org-config/config.json:
1503
1504 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1505
1506         Reviewed by Adam Barth.
1507
1508         Add EFL Builder to core waterfall
1509         https://bugs.webkit.org/show_bug.cgi?id=52704
1510
1511         Add EFL Builder to the core waterfall again.
1512
1513         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1514         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1515
1516 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1517
1518         Reviewed by Tony Chang.
1519
1520         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1521         https://bugs.webkit.org/show_bug.cgi?id=52872
1522
1523         Force disabling proxy to resolve the problem.
1524
1525         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1526         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1527
1528 2011-01-24  Andreas Kling  <kling@webkit.org>
1529
1530         Reviewed by Darin Adler.
1531
1532         check-webkit-style: Update exemptions following Source/ move.
1533         https://bugs.webkit.org/show_bug.cgi?id=53017
1534
1535         * Scripts/webkitpy/style/checker.py:
1536         * Scripts/webkitpy/style/checker_unittest.py:
1537
1538 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1539
1540         Rubber-stamped by Csaba Osztrogonác.
1541
1542         [Qt] Move project files into Source
1543         https://bugs.webkit.org/show_bug.cgi?id=52891
1544
1545         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1546
1547 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1548
1549         Reviewed by Yury Semikhatsky.
1550
1551         Web Inspector: Find duplicate strings in localizedStrings.js
1552
1553         https://bugs.webkit.org/show_bug.cgi?id=53005
1554
1555         * Scripts/check-inspector-strings:
1556
1557 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1558
1559         Reviewed by Andreas Kling.
1560
1561         [Qt] Regroup MiniBrowser's menubar and add open file action
1562         https://bugs.webkit.org/show_bug.cgi?id=53000
1563
1564         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1565
1566         * MiniBrowser/qt/BrowserWindow.cpp:
1567         (BrowserWindow::BrowserWindow):
1568         (BrowserWindow::openFile):
1569         (BrowserWindow::~BrowserWindow):
1570         * MiniBrowser/qt/BrowserWindow.h:
1571
1572 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1573
1574         Unreviewed fix after r76496
1575
1576         [Qt] Move project files into Source
1577         https://bugs.webkit.org/show_bug.cgi?id=52891
1578
1579         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1580         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1581         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1582
1583 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1584
1585         Reviewed by Csaba Osztrogonác.
1586
1587         [Qt] Move project files into Source
1588         https://bugs.webkit.org/show_bug.cgi?id=52891
1589
1590         * DerivedSources.pro: Renamed from DerivedSources.pro.
1591         * DumpRenderTree/qt/DumpRenderTree.pro:
1592         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1593         * MiniBrowser/DerivedSources.pro:
1594         * MiniBrowser/qt/MiniBrowser.pro:
1595         * QtTestBrowser/QtTestBrowser.pro:
1596         * Scripts/webkitdirs.pm:
1597         * Tools.pro: Added.
1598         * WebKitTestRunner/DerivedSources.pro:
1599         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1600         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1601
1602 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1603
1604         Reviewed by Dan Bernstein.
1605
1606         Beefed up --threaded mode to catch even more kinds of errors.
1607         https://bugs.webkit.org/show_bug.cgi?id=52971
1608
1609         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1610         context group to force JSC to mark multiple threads. (This used to be
1611         the default, but it changed in SnowLeopard.)
1612         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1613         to give threading mistakes more chances to show themselves.
1614         (startJavaScriptThreads):
1615         (stopJavaScriptThreads):
1616
1617 2011-01-22  Robert Hogan  <robert@webkit.org>
1618
1619         Reviewed by Andreas Kling.
1620
1621         [Qt] Support layoutTestController.addURLToRedirect()
1622         https://bugs.webkit.org/show_bug.cgi?id=52956
1623
1624         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1625         (LayoutTestController::addURLToRedirect):
1626         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1627
1628 2011-01-22  Robert Hogan  <robert@webkit.org>
1629
1630         Reviewed by Kenneth Rohde Christiansen.
1631
1632         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1633         https://bugs.webkit.org/show_bug.cgi?id=49802
1634
1635         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1636         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1637         (WebCore::DumpRenderTree::open):
1638
1639 2011-01-21  Adam Barth  <abarth@webkit.org>
1640
1641         Reviewed by Maciej Stachowiak.
1642
1643         Disable mac_unittest.py that fails on some of the Mac bots
1644         https://bugs.webkit.org/show_bug.cgi?id=52947
1645
1646         As noted in the comment, this test does not appear to be correct
1647         because the function this test is testing returns different results
1648         depending on which flavor of Mac the test is run on.  This patch
1649         disable the test.  Hopefully we can re-enable the test once we've
1650         probably insulated the test from its environment.
1651
1652         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1653
1654 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1655
1656         Reviewed by Mihai Parparita.
1657
1658         Fix bug introduced in r76322 that caused NRWT to not actually
1659         read the Skipped files properly.
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=52771
1662
1663         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1664         * Scripts/webkitpy/layout_tests/port/webkit.py:
1665         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1666
1667 2011-01-21  Sam Weinig  <sam@webkit.org>
1668
1669         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1670
1671         WebKitTestRunner needs the HOME environment variable to be set.
1672         <rdar://problem/8896573>
1673
1674         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1675         it exists.
1676
1677 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1678
1679         Reviewed by Eric Seidel.
1680
1681         Suppress a few remaining integration tests so that none of the
1682         layout_test unit tests ever read from the filesystem or launch
1683         subprocesses that aren't part of the unit tests.
1684
1685         Also fix a minor bug in the printing unit tests that was
1686         incorrectly relying on sys.argv.
1687
1688         https://bugs.webkit.org/show_bug.cgi?id=52863
1689
1690         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1691         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1692         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1693
1694 2011-01-21  Darin Adler  <darin@apple.com>
1695
1696        Fix Mac build.
1697
1698         * MiniBrowser/mac/BrowserWindowController.m:
1699         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1700
1701 2011-01-20  Darin Adler  <darin@apple.com>
1702
1703         Reviewed by Dan Bernstein.
1704
1705         WebKit2: Implement showModalDialog
1706         https://bugs.webkit.org/show_bug.cgi?id=52855
1707
1708         This fixes WebKitTestRunner to compile, but more work is probably
1709         needed to get it to pass the tests.
1710
1711         * WebKitTestRunner/TestController.cpp:
1712         (WTR::TestController::runModal): Added. Calls through to the
1713         platform-specific version of runModal.
1714         (WTR::TestController::createOtherPage): Changed to be a private
1715         static member function so it can refer to runModal, which is
1716         a private static member function.
1717         (WTR::TestController::initialize): Pass 0 for the runModal
1718         function since we don't need to run the main window modal.
1719         I suspect this is wrong and will need to change.
1720         * WebKitTestRunner/TestController.h: Added declarations for
1721         the functions added above.
1722         * WebKitTestRunner/mac/TestControllerMac.mm:
1723         (WTR::TestController::runModal): Added. Untested implementation.
1724         * WebKitTestRunner/qt/TestControllerQt.cpp:
1725         (WTR::TestController::runModal): Added.
1726         * WebKitTestRunner/win/TestControllerWin.cpp:
1727         (WTR::TestController::runModal): Added.
1728
1729 2011-01-21  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by Adam Barth.
1732
1733         Split Host object off from WebKitPatch for easier re-use
1734         https://bugs.webkit.org/show_bug.cgi?id=52284
1735
1736         new-run-webkit-tests and other tools are eventually going to want one of these.
1737         Basically you need to inherit from this class if you want to pretend to be a
1738         self.tool object for Steps/Commands.
1739
1740         * Scripts/webkitpy/common/host.py: Added.
1741         * Scripts/webkitpy/tool/main.py:
1742
1743 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1744
1745         Reviewed by Adam Barth.
1746
1747         Disable the tests that start and stop the http server and web
1748         server, so that we don't have to worry about port collisions on
1749         the bots.
1750
1751         https://bugs.webkit.org/show_bug.cgi?id=52861
1752
1753         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1754
1755 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1756
1757         Reviewed by Eric Seidel.
1758
1759         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1760         
1761         https://bugs.webkit.org/show_bug.cgi?id=52772
1762         
1763         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1764
1765 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1766
1767         Reviewed by Eric Siedel.
1768
1769         nrwt: clean up almost all remaining port references, remove
1770         unnecessary import clauses. The only remaining references are
1771         in places where a mock filesystem makes no sense or can't be
1772         used, and in one routine in port/google_chrome_unittest that
1773         I'll rewrite in a separate patch.
1774
1775         https://bugs.webkit.org/show_bug.cgi?id=52771
1776
1777         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1778         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1779         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1780         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1781         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1782         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1783         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1784         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1785         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1786         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1787         * Scripts/webkitpy/layout_tests/port/gtk.py:
1788         * Scripts/webkitpy/layout_tests/port/mac.py:
1789         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1790         * Scripts/webkitpy/layout_tests/port/qt.py:
1791         * Scripts/webkitpy/layout_tests/port/webkit.py:
1792         * Scripts/webkitpy/layout_tests/port/win.py:
1793         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1794
1795 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1796
1797         Reviewed by Mihai Parparita.
1798
1799         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=52762
1802
1803         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1804         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1805
1806 2011-01-20  Tony Chang  <tony@chromium.org>
1807
1808         Reviewed by Ojan Vafai.
1809
1810         [chromium] fix the paths used for the rebaseline tool
1811         https://bugs.webkit.org/show_bug.cgi?id=52857
1812
1813         Some of the bots were renamed so the path to grab the results zip
1814         file has changed.
1815
1816         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1817
1818 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1819
1820         Reviewed by Tony Chang.
1821
1822         Fix bug introduced in r72688 / bug 52768 that broke the
1823         generation of the output filename links in the results.html
1824         output. Apparently none of the unit tests actually checked to
1825         make sure the generated links were correct :(
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=52854
1828
1829         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1830         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1831
1832 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1833
1834         Reviewed by Darin Adler.
1835
1836         https://bugs.webkit.org/show_bug.cgi?id=52849
1837         Make window.print work with WebKit2
1838
1839         * MiniBrowser/mac/BrowserWindowController.m:
1840         (-[BrowserWindowController awakeFromNib]):
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::createOtherPage):
1843         (WTR::TestController::initialize):
1844         Added zeroes to WKPageUIClient structures to avoid build failures.
1845
1846 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1847
1848         Reviewed by Eric Seidel.
1849
1850         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1851
1852         https://bugs.webkit.org/show_bug.cgi?id=52756
1853
1854         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1855         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1856         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1857         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1858         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1859         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1860
1861 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1862
1863         Reviewed by Antonio Gomes.
1864
1865         QtTestBrowser should have a seperate menu for Settings
1866         https://bugs.webkit.org/show_bug.cgi?id=52817
1867         
1868         Added a new menu item named "Settings"
1869         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1870
1871         * QtTestBrowser/launcherwindow.cpp:
1872         (LauncherWindow::createChrome):
1873
1874 2011-01-20  Sam Weinig  <sam@webkit.org>
1875
1876         Reviewed by John Sullivan.
1877
1878         Update update-webkit-localizable-strings with new path to WebKit.
1879
1880         * Scripts/update-webkit-localizable-strings:
1881
1882 2011-01-20  James Robinson  <jamesr@chromium.org>
1883
1884         Reviewed by Darin Fisher.
1885
1886         Implement mozilla's requestAnimationFrame API
1887         https://bugs.webkit.org/show_bug.cgi?id=51218
1888
1889         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1890
1891         * DumpRenderTree/chromium/WebViewHost.cpp:
1892         (invokeScheduleComposite):
1893         (WebViewHost::scheduleAnimation):
1894         (WebViewHost::paintInvalidatedRegion):
1895         * DumpRenderTree/chromium/WebViewHost.h:
1896
1897 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1898
1899         Reviewed by Adam Roben.
1900
1901         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1902         https://bugs.webkit.org/show_bug.cgi?id=42327
1903
1904         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1905         for methods that take their normal arguments but also a JSContextRef.
1906         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1907         for evaluateScriptInIsolatedWorld.
1908         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1909         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1910         this call is for an isolated world.
1911         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1912         (WTR::worldMap): Helper to create a world map.
1913         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1914         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1915         added LayoutTestController API.
1916         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1917
1918 2011-01-19  Adam Roben  <aroben@apple.com>
1919
1920         Convert paths in environment variables back to msys-style inside commit-log-editor
1921
1922         When this script gets run from inside git commit, msys-style paths in the environment will
1923         have been turned into Windows-style paths with forward slashes. This screws up functions
1924         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1925         the paths back to msys-style before doing anything else.
1926
1927         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1928         using msysgit's Perl and multiple ChangeLogs have been edited
1929
1930         Reviewed by David Kilzer.
1931
1932         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1933         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1934         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1935
1936 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1937
1938         [Win] Unreviewed build fix after r76248.
1939
1940         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1941
1942 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1943
1944         Reviewed by Csaba Osztrogonác.
1945
1946         Refactoring of the custom allocation framework
1947         https://bugs.webkit.org/show_bug.cgi?id=49897
1948
1949         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1950         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1951         equivalent macro implementation at the necessary places.
1952 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1953
1954         Unreviewed. 
1955
1956         Adding myself to committers.py.
1957
1958         * Scripts/webkitpy/common/config/committers.py:
1959
1960 2011-01-20  Adam Barth  <abarth@webkit.org>
1961
1962         Reviewed by Tony Chang.
1963
1964         Chromium builders don't delete unversioned directories when DEPS change
1965         https://bugs.webkit.org/show_bug.cgi?id=52745
1966
1967         If we pass this option to gclient sync, gclient will delete directories
1968         that are no longer part of DEPS instead of leaving them around to
1969         confuse us later.  Apparently, the downstream buildbots use this option
1970         already.
1971
1972         * Scripts/update-webkit-chromium:
1973
1974 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1975
1976         Unreviewed, build fix - I pulled this patch in to fix an issue
1977         revealed by r76195 running on some new bots). Also fix a couple
1978         of other issues revealed in testing.
1979
1980         nrwt: remove fs refs from layout_package/json*
1981
1982         https://bugs.webkit.org/show_bug.cgi?id=52754
1983
1984         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1985         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1986         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1987         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1988         * Scripts/webkitpy/layout_tests/port/base.py:
1989
1990 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1991
1992         Unreviewed, build fix.
1993
1994         Fix a couple of minor bugs discovered while bringing up new bots
1995         for testing.
1996
1997         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1999
2000 2011-01-19  James Robinson  <jamesr@chromium.org>
2001
2002         Unreviewed, rolling out r76194.
2003         http://trac.webkit.org/changeset/76194
2004         https://bugs.webkit.org/show_bug.cgi?id=51218
2005
2006         Caused mysterious compile failure on the chromium win
2007         build.webkit.org bots
2008
2009         * DumpRenderTree/chromium/WebViewHost.cpp:
2010         (WebViewHost::paintInvalidatedRegion):
2011         * DumpRenderTree/chromium/WebViewHost.h:
2012
2013 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2014
2015         Reviewed by Mihai Parparita.
2016
2017         remove fs refs from test_runner, dump_render_tree_thread
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=52753
2020
2021         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2022         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2023         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2024         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2025
2026 2011-01-19  James Robinson  <jamesr@chromium.org>
2027
2028         Reviewed by Darin Fisher.
2029
2030         Implement mozilla's requestAnimationFrame API
2031         https://bugs.webkit.org/show_bug.cgi?id=51218
2032
2033         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2034
2035         * DumpRenderTree/chromium/WebViewHost.cpp:
2036         (invokeScheduleComposite):
2037         (WebViewHost::scheduleAnimation):
2038         (WebViewHost::paintInvalidatedRegion):
2039         * DumpRenderTree/chromium/WebViewHost.h:
2040
2041 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2042
2043         Unreviewed, build fix.
2044
2045         Fix a few incorrect "self._filesystem" references introduced in
2046         r76184.
2047
2048         * Scripts/webkitpy/layout_tests/port/chromium.py:
2049         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2050
2051 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2052
2053         Reviewed by Mihai Parparita.
2054
2055         add a .sep property, abspath(), isabs(), mtime(), and
2056         open_text_file_for_writing() to filesystem modules. Some of
2057         these properties are not needed in this patch but will be needed
2058         in subsequent patches (I'm doing this to avoid having to track
2059         multiple versions of a single file).
2060
2061         Also, change most of the port/* modules to use the filesystem
2062         objects instead of referencing the filesystem directly.
2063
2064         https://bugs.webkit.org/show_bug.cgi?id=52748
2065
2066         * Scripts/webkitpy/common/system/filesystem.py:
2067         * Scripts/webkitpy/common/system/filesystem_mock.py:
2068         * Scripts/webkitpy/layout_tests/port/__init__.py:
2069         * Scripts/webkitpy/layout_tests/port/base.py:
2070         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2071         * Scripts/webkitpy/layout_tests/port/chromium.py:
2072         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2073         * Scripts/webkitpy/layout_tests/port/config.py:
2074         * Scripts/webkitpy/layout_tests/port/test.py:
2075         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2076
2077 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2078
2079         Reviewed by Anders Carlsson.
2080
2081         If resetting between tests times out, treat it as a WebProcess crash
2082         https://bugs.webkit.org/show_bug.cgi?id=52757
2083
2084         * WebKitTestRunner/TestController.cpp:
2085         (WTR::TestController::runTest):
2086
2087 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2088
2089         Reviewed by Darin Adler.
2090
2091         https://bugs.webkit.org/show_bug.cgi?id=52739
2092         Make it possible for a WebKit2 client to print headers and footers
2093
2094         Added dummy implementations for new printing UIClient calls.
2095
2096         * MiniBrowser/mac/BrowserWindowController.m:
2097         (-[BrowserWindowController awakeFromNib]):
2098         * WebKitTestRunner/TestController.cpp:
2099         (WTR::createOtherPage):
2100         (WTR::TestController::initialize):
2101
2102 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2103
2104         Reviewed by Ojan Vafai.
2105
2106         Change webkitpy/layout_tests/port/test.py to use the
2107         in-memory filesystem for cleaner unit testing. This
2108         change allows us to kill a lot of code that was
2109         specific to the test port, at the cost of being a
2110         little less clear about how things would work if
2111         you didn't have a filesystem.
2112
2113         https://bugs.webkit.org/show_bug.cgi?id=52605
2114
2115         * Scripts/webkitpy/layout_tests/port/test.py:
2116
2117 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2118
2119         Unreviewed, build fix.
2120
2121         Fix test failure caused by committing attachment 79368 instead
2122         of attachment 79461 on bug 52604.
2123
2124         * Scripts/webkitpy/common/system/filesystem_mock.py:
2125
2126 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2127
2128         Reviewed by Mihai Parparita.
2129
2130         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2131         unit testing. os.walk() is too much of a hassle to implement on
2132         top of the in-memory mock filesystem and adding the necessary
2133         interface to files_under() gives clients a cleaner API anyway
2134         (for this particular usage model).
2135
2136         https://bugs.webkit.org/show_bug.cgi?id=52691
2137
2138         * Scripts/webkitpy/common/system/filesystem.py:
2139         * Scripts/webkitpy/common/system/filesystem_mock.py:
2140         * Scripts/webkitpy/layout_tests/port/test_files.py:
2141         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2142
2143 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2144
2145         Reviewed by Tony Chang.
2146
2147         Change more modules in the layout-tests code to use the
2148         filesystem wrapper for cleaner unit testing.
2149
2150         This patch also adds the glob() wrapper to the filesystem
2151         abstraction.
2152         
2153         https://bugs.webkit.org/show_bug.cgi?id=52604
2154
2155         * Scripts/webkitpy/layout_tests/port/test_files.py:
2156         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2157         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2158         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2159         * Scripts/webkitpy/common/system/filesystem.py:
2160         * Scripts/webkitpy/common/system/filesystem_mock.py:
2161
2162 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2163
2164         Unreviewed.
2165
2166         Updating my email addresses and irc nick.
2167
2168         * Scripts/webkitpy/common/config/committers.py:
2169
2170 2011-01-19  Tony Chang  <tony@chromium.org>
2171
2172         Reviewed by Mihai Parparita.
2173
2174         [chromium] [linux] if check-sys-deps fails, output the failure reason
2175         https://bugs.webkit.org/show_bug.cgi?id=52671
2176
2177         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2178             error handler functions.
2179         * Scripts/webkitpy/layout_tests/port/chromium.py:
2180             output the error text from --check-sys-deps
2181         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2182
2183 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2184
2185         Reviewed by Andreas Kling.
2186
2187         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2188         https://bugs.webkit.org/show_bug.cgi?id=52554
2189         
2190         QtNetworkAccessManager is created in a thread and set as
2191         member variable in QWebPage. When the thread is destroyed
2192         the object is still used. So fix will set the object to
2193         NULL once the thread is destroyed.
2194
2195         * QtTestBrowser/launcherwindow.cpp:
2196         (LauncherWindow::~LauncherWindow):
2197
2198 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2199
2200         Rubber stamped by Csaba Osztrogonac
2201
2202         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2203
2204 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2205
2206         Reviewed by Tony Chang.
2207
2208         new-run-webkit-tests: add a --build-directory command line argument
2209
2210         Official Google Chrome builds use a non-standard build directory
2211         location. This patch adds a --build-directory argument that
2212         allows that location to be specified on the command line. Only
2213         Chromium-based builds will use this flag for now, but anyone can
2214         in the future.
2215
2216         There are no unit tests for this since it's difficult to test
2217         until mock filesystems are fully supported in the code. This was
2218         tested by hand for now.
2219
2220         https://bugs.webkit.org/show_bug.cgi?id=52694
2221
2222         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2223         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2224         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2226
2227 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2228
2229         Not reviewed. Bot fix.
2230
2231         Remove an inadvertently committed debugging print.
2232
2233         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2234         (LayoutTestController::notifyDone):
2235
2236 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2237
2238         Reviewed by Sam Weinig.
2239
2240         WebKitTestRunner should track loading more like DumpRenderTree
2241         https://bugs.webkit.org/show_bug.cgi?id=52692
2242
2243         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2244         This makes some tests that call notifyDone multiple times pass.
2245         
2246         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2247         (WTR::InjectedBundle::InjectedBundle):
2248         (WTR::InjectedBundle::done):
2249         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2250         (WTR::InjectedBundle::topLoadingFrame):
2251         (WTR::InjectedBundle::setTopLoadingFrame):
2252         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2253         (WTR::InjectedBundlePage::InjectedBundlePage):
2254         (WTR::InjectedBundlePage::stopLoading):
2255         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2256         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2257         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2258         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2259         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2260         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2261         (WTR::LayoutTestController::notifyDone):
2262         * WebKitTestRunner/TestController.cpp:
2263         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2264
2265 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2266
2267         Reviewed by Kent Tamura.
2268
2269         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2270         https://bugs.webkit.org/show_bug.cgi?id=52678
2271         
2272         Update path now that WebKit is inside Source.
2273
2274         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2275
2276 2011-01-18  Robert Hogan  <robert@webkit.org>
2277
2278         Reviewed by Simon Hausmann.
2279
2280         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2281         https://bugs.webkit.org/show_bug.cgi?id=44282
2282
2283         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2284         (WebCore::DumpRenderTree::dump):
2285
2286 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2287
2288         Reviewed by Mihai Parparita.
2289
2290         Fix a small race condition that could cause the unit tests for
2291         new-run-webkit-tests to fail in a multithreaded environment.
2292         There was a small window in the code where one thread would
2293         check to see if a thread had raised an exception, do something,
2294         and then check to see if the thread was alive. If the other
2295         thread raised an exception and exited in between these two
2296         steps, the exception would be lost. Flipping the order of the
2297         two checks fixes the race, since we will now always check for an
2298         exception on the thread before exiting.
2299
2300         https://bugs.webkit.org/show_bug.cgi?id=51579
2301
2302         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2303
2304 2011-01-18  Eric Seidel  <eric@webkit.org>
2305
2306         Reviewed by Adam Barth.
2307
2308         commit-queue dies when test archiving fails
2309         https://bugs.webkit.org/show_bug.cgi?id=52617
2310
2311         I looked at the machine and it had 10 archives already
2312         thus find_unused_name was returning None.  I've upped
2313         the limit to 100 (per bug) and tested the case where
2314         find_unused_name returns None (making archive return None).
2315
2316         * Scripts/webkitpy/common/system/workspace.py:
2317         * Scripts/webkitpy/common/system/workspace_unittest.py:
2318         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2319         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2320         * Scripts/webkitpy/tool/commands/queues.py:
2321
2322 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2323
2324         Reviewed by Ojan Vafai.
2325
2326         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2327         filesystem. Also fix a couple of "with" statements missed by
2328         r76050.
2329
2330         https://bugs.webkit.org/show_bug.cgi?id=52487
2331
2332         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2333
2334 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2335
2336         Reviewed by Martin Robinson.
2337
2338         [Gtk] Build fixes for gtk3 build
2339         https://bugs.webkit.org/show_bug.cgi?id=52648
2340
2341         * DumpRenderTree/gtk/EventSender.cpp:
2342         (beginDragWithFilesCallback):
2343
2344 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2345
2346         Reviewed by Mihai Parparita.
2347
2348         Update rebaseline-chromium-webkit-tests to use filesystem objects
2349         instead of direct references to os.path, shutil, tempfile, etc.
2350
2351         This patch doesn't change anything, but will allow subsequent
2352         patches to change the unit tests to no longer use the real
2353         filesystem.
2354
2355         This patch adds a bunch more methods to the filesystem object as
2356         well.
2357
2358         https://bugs.webkit.org/show_bug.cgi?id=52482
2359
2360         * Scripts/webkitpy/common/system/filesystem.py:
2361         * Scripts/webkitpy/common/system/filesystem_mock.py:
2362         * Scripts/webkitpy/tool/commands/queues.py:
2363         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2364         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2365
2366 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2367
2368         Reviewed by Mihai Parparita.
2369
2370         new-run-webkit-tests shouldn't crash when you try to run a
2371         directory containing only skipped files.
2372
2373         https://bugs.webkit.org/show_bug.cgi?id=52478
2374         
2375         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2376         * Scripts/webkitpy/layout_tests/port/test.py:
2377         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2378
2379 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2380
2381         Reviewed by Gustavo Noronha Silva.
2382
2383         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2384         https://bugs.webkit.org/show_bug.cgi?id=40833
2385
2386         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2387         GTK+ event sender.
2388         (dragWithFilesDragDataGetCallback): Added.
2389         (dragWithFilesDragEndCallback): Added.
2390         (beginDragWithFilesCallback): Added.
2391
2392 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2393
2394         Reviewed by Adam Barth.
2395
2396         ews: Add additional watcher to efl ews
2397         https://bugs.webkit.org/show_bug.cgi?id=52613
2398
2399         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2400
2401         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2402
2403 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2404
2405         Reviewed by Alexey Proskuryakov.
2406
2407         Fix some headers with missing or misspelled #ifndef guards
2408         https://bugs.webkit.org/show_bug.cgi?id=52545
2409
2410         * DumpRenderTree/chromium/TestEventPrinter.h:
2411         * DumpRenderTree/chromium/WebPreferences.h:
2412
2413 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2414
2415         Reviewed by Anders Carlsson.
2416
2417         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2418         navigating back to an unreachable URL
2419         https://bugs.webkit.org/show_bug.cgi?id=52388
2420
2421         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2422
2423         * DumpRenderTree/LayoutTestController.cpp:
2424         (queueLoadHTMLStringCallback):
2425         (LayoutTestController::queueLoadHTMLString):
2426         (LayoutTestController::queueLoadAlternateHTMLString):
2427         * DumpRenderTree/LayoutTestController.h:
2428
2429         * DumpRenderTree/WorkQueueItem.h:
2430         (LoadHTMLStringItem::LoadHTMLStringItem):
2431
2432         * DumpRenderTree/chromium/LayoutTestController.cpp:
2433         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2434         (WorkItemLoadHTMLString::run):
2435         (LayoutTestController::queueLoadHTMLString):
2436
2437         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2438         (LoadHTMLStringItem::invoke):
2439         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2440         (LoadHTMLStringItem::invoke):
2441         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2442         (LoadHTMLStringItem::invoke):
2443
2444 2011-01-17  Dan Bernstein  <mitz@apple.com>
2445
2446         Rubber-stamped by Mark Rowe.
2447
2448         Update xcodeproj svn:ignore to include xcuserdata.
2449
2450         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2451         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2452         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2453         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2454         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2455
2456 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2457
2458         Unreviewed fix after r75908.
2459
2460         Move WebKit into Source
2461         https://bugs.webkit.org/show_bug.cgi?id=52530
2462
2463         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2464
2465 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2466
2467         Unreviewed.
2468
2469         Remove accidentally committed debug printing after r75908.
2470
2471         * Scripts/webkitdirs.pm:
2472
2473 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2474
2475         Unreviewed.
2476
2477         Add myself to committers list
2478         https://bugs.webkit.org/show_bug.cgi?id=52566
2479
2480         * Scripts/webkitpy/common/config/committers.py:
2481
2482 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2483
2484         Reviewed by Jeremy Orlow.
2485
2486         GeolocationController should call stopUpdating on destruction
2487         https://bugs.webkit.org/show_bug.cgi?id=52216
2488
2489         fast/dom/Geolocation/window-close-crash.html requires that a
2490         Geolocation watch be started in a secondary window. Consequently,
2491         we need to allow geolocation permission and provide a mock
2492         geolocation position for the secondary window's
2493         GeolocationClientMock.
2494
2495         * DumpRenderTree/chromium/LayoutTestController.cpp:
2496         (LayoutTestController::setGeolocationPermission):
2497         (LayoutTestController::setMockGeolocationPosition):
2498         (LayoutTestController::setMockGeolocationError):
2499         * DumpRenderTree/chromium/TestShell.h:
2500         (TestShell::windowList):
2501
2502 2011-01-16  Adam Barth  <abarth@webkit.org>
2503
2504         Update more include paths to reflect WebKit move.
2505
2506         * DumpRenderTree/chromium/EventSender.cpp:
2507         (EventSender::keyDown):
2508         (EventSender::needsShiftModifier):
2509         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2510         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2511
2512 2011-01-16  Kent Tamura  <tkent@chromium.org>
2513
2514         Unreviewed, Chromium build fix.
2515
2516         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2517
2518 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2519
2520         Build fix for GTK+ after source directory movement.
2521
2522         * GNUmakefile.am: Correct include paths.
2523
2524 2011-01-16  Adam Barth  <abarth@webkit.org>
2525
2526         Teach svn-apply about WebKit move.
2527
2528         * Scripts/VCSUtils.pm:
2529
2530 2011-01-16  Adam Barth  <abarth@webkit.org>
2531
2532         Rubber-stamped by Eric Seidel.
2533
2534         Move WebKit into Source
2535         https://bugs.webkit.org/show_bug.cgi?id=52530
2536
2537         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2538         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2539         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2540         * DumpRenderTree/qt/GCControllerQt.cpp:
2541         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2542         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2543         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2544         * DumpRenderTree/wscript:
2545         * QtTestBrowser/launcherwindow.h:
2546         * Scripts/build-webkit:
2547         * Scripts/webkitdirs.pm:
2548
2549 2011-01-15  Adam Barth  <abarth@webkit.org>
2550
2551         Teach svn-apply about WebKit2 move.
2552
2553         * Scripts/VCSUtils.pm:
2554
2555 2011-01-15  Adam Barth  <abarth@webkit.org>
2556
2557         Rubber-stamped by Eric Seidel.
2558
2559         Move WebKit2 into Source
2560         https://bugs.webkit.org/show_bug.cgi?id=52438
2561
2562         * MiniBrowser/qt/MiniBrowser.pro:
2563         * Scripts/build-webkit:
2564         * Scripts/do-file-rename:
2565         * Scripts/do-webcore-rename:
2566         * Scripts/test-webkitpy:
2567         * Scripts/webkitdirs.pm:
2568         * Scripts/webkitpy/style/checker.py:
2569         * WebKitTestRunner/DerivedSources.pro:
2570         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2571         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2572
2573 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2574
2575         Reviewed by David Levin.
2576
2577         [chromium] remove obsolete createView method
2578         https://bugs.webkit.org/show_bug.cgi?id=52437
2579
2580         * DumpRenderTree/chromium/WebViewHost.cpp:
2581         (WebViewHost::createView):
2582         * DumpRenderTree/chromium/WebViewHost.h:
2583
2584 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2585
2586         Reviewed by Geoff Garen.
2587
2588         ShouldLoadResourceForFrame should use strings, not URLs.
2589         https://bugs.webkit.org/show_bug.cgi?id=52476
2590
2591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2592         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2594
2595 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2596
2597         Reviewed by David Levin.
2598
2599         Add Tony Gentilcore as a reviewer
2600         https://bugs.webkit.org/show_bug.cgi?id=52480
2601
2602         * Scripts/webkitpy/common/config/committers.py:
2603
2604 2011-01-14  David Levin  <levin@chromium.org>
2605
2606         Reviewed by Eric Seidel.
2607
2608         check-webkit-style: _FunctionState should keep track of where the function name starts.
2609         https://bugs.webkit.org/show_bug.cgi?id=52454
2610
2611         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2612         _FunctionState and logic for setting it correctly.
2613         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2614
2615 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2616
2617         Reviewed by David Levin.
2618
2619         Add support to DumpRenderTree to use the GPU rather than software renderer
2620         https://bugs.webkit.org/show_bug.cgi?id=52333
2621
2622         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2623         (main):
2624         * Scripts/webkitpy/layout_tests/port/chromium.py:
2625         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2626
2627 2011-01-14  Tony Chang  <tony@chromium.org>
2628
2629         Reviewed by Kent Tamura.
2630
2631         [chromium] update fonts.conf to fix 6 linux tests in drt
2632         https://bugs.webkit.org/show_bug.cgi?id=52411
2633
2634         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2635             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2636
2637 2011-01-14  Eric Seidel  <eric@webkit.org>
2638
2639         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2640
2641         Reviewed by Adam Barth.
2642
2643         Fix when running Tools/Scripts/check-webkit-style without arguments.
2644         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2645
2646         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2647         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2648
2649 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2650
2651         Reviewed by David Levin.
2652
2653         Store the tempdir object in a variable so it doesn't get deleted too early.
2654         https://bugs.webkit.org/show_bug.cgi?id=51875
2655
2656         * Scripts/update-webkit-auxiliary-libs:
2657         * Scripts/update-webkit-support-libs:
2658
2659 2011-01-14  Eric Seidel  <eric@webkit.org>
2660
2661         Unreviewed.  Make it work in python 2.5.
2662
2663         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2664         https://bugs.webkit.org/show_bug.cgi?id=49158
2665
2666         * Scripts/webkitpy/common/checkout/api_unittest.py:
2667
2668 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2669
2670         Unreviewed, rolling out r75774.
2671         http://trac.webkit.org/changeset/75774
2672         https://bugs.webkit.org/show_bug.cgi?id=52431
2673
2674         gtk builds were broken (Requested by loislo2 on #webkit).
2675
2676         * Scripts/webkitpy/common/checkout/scm.py:
2677
2678 2011-01-14  David Levin  <levin@chromium.org>
2679
2680         Reviewed by Shinichiro Hamaji.
2681
2682         check-webkit-style: _FunctionState should detect pure functions.
2683         https://bugs.webkit.org/show_bug.cgi?id=52428
2684
2685         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2686         is a pure virtual function.
2687         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2688         virtual functions are correctly detected.
2689
2690 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2691
2692         Reviewed by Yury Semikhatsky.
2693
2694         Just small fix for problem with check-webkit-style.
2695         It just didn't work for this patch.
2696         Old code can't concatenate a list of strings with None.
2697
2698         * Scripts/webkitpy/common/checkout/scm.py:
2699
2700 2011-01-13  David Levin  <levin@chromium.org>
2701
2702         Reviewed by Shinichiro Hamaji.
2703
2704         check-webkit-style: _FunctionState should use Position to know where items are.
2705         https://bugs.webkit.org/show_bug.cgi?id=52424
2706
2707         * Scripts/webkitpy/style/checkers/cpp.py:
2708         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2709         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2710         did some minor clean-up.
2711         (*): Other changes are simply about converting to use the Position's in_FunctionState
2712         instead of line numbers.
2713         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2714         to verify the positions stored in _FunctionState.
2715
2716 2011-01-13  Eric Seidel  <eric@webkit.org>
2717
2718         Reviewed by David Levin.
2719
2720         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2721         https://bugs.webkit.org/show_bug.cgi?id=49158
2722
2723         This is not the most elegant, but it is a very safe fix to this bug.
2724         One advantage of catching ScriptError like this instead of adding a
2725         new added_or_modified_files or fixing all changed_files callers
2726         to use a more specific change_files variant, is that we catch
2727         all kinds of ScriptErrors which might cause our (non-essential)
2728         suggest-reviewers code to fail out.  This should make passing
2729         --suggest-reviewers to webkit-patch upload much more robust
2730         and may even make it possible for us to make it default.
2731
2732         The root of the problem here is that SCM.changed_files includes
2733         deleted ChangeLog paths (from moves, etc) which then when we ask
2734         SVN/Git for the contents of the file at that revision, the command
2735         errors out and Executive.run_command raises a ScriptError.
2736
2737         In the future we might fix this differently by making all current
2738         callers of chagned_files use a more specific method for requesting
2739         what types of changes they're interested in (adds, modifies, deletes, etc.)
2740
2741         * Scripts/webkitpy/common/checkout/api.py:
2742         * Scripts/webkitpy/common/checkout/api_unittest.py:
2743
2744 2011-01-13  Dan Bernstein  <mitz@apple.com>
2745
2746         Reviewed by Alexey Proskuryakov.
2747
2748         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2749         https://bugs.webkit.org/show_bug.cgi?id=52419
2750
2751         Allow to further control the behavior of the willSendRequest delegate callback by making it
2752         set a different URL in the new request.
2753
2754         * DumpRenderTree/LayoutTestController.cpp:
2755         (addURLToRedirectCallback): Added.
2756         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2757         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2758         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2759         * DumpRenderTree/LayoutTestController.h:
2760         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2761         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2762         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2763         change the URL in the new request to the redirect destination.
2764
2765 2011-01-13  Eric Seidel  <eric@webkit.org>
2766
2767         Reviewed by Mihai Parparita.
2768
2769         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2770         https://bugs.webkit.org/show_bug.cgi?id=52416
2771
2772         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2773         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2774
2775         I also added FIXMEs about the changed_files returning deleted files problem
2776         which is causing the other most common exception for suggest-reviewers
2777         (and is probably breaking sheriff-bots blame detection).
2778
2779         * Scripts/webkitpy/common/checkout/api.py:
2780         * Scripts/webkitpy/common/checkout/api_unittest.py:
2781         * Scripts/webkitpy/common/checkout/scm.py:
2782
2783 2011-01-13  Eric Seidel  <eric@webkit.org>
2784
2785         Reviewed by Adam Barth.
2786
2787         results archives from commit-queue are too large to upload
2788         https://bugs.webkit.org/show_bug.cgi?id=52405
2789
2790         * Scripts/webkitpy/common/system/filesystem.py:
2791         * Scripts/webkitpy/common/system/filesystem_mock.py:
2792         * Scripts/webkitpy/tool/commands/queues.py:
2793
2794 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2795
2796         Reviewed by Martin Robinson.
2797
2798         [gtk] Zero-sized font does not yet work
2799         https://bugs.webkit.org/show_bug.cgi?id=49793
2800
2801         Set minimum-font-size to 0 for the DRT.
2802
2803         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2804         (resetDefaultsToConsistentValues):
2805
2806 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2807
2808         Reviewed by Darin Adler.
2809
2810         Make old-run-webkit-tests more robust on buildbots
2811         https://bugs.webkit.org/show_bug.cgi?id=52364
2812
2813         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2814
2815 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2816
2817         Reviewed by Darin Adler.
2818
2819         Make old-run-webkit-tests more robust on buildbots
2820         https://bugs.webkit.org/show_bug.cgi?id=52364
2821
2822         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2823
2824 2011-01-13  Tony Chang  <tony@chromium.org>
2825
2826         Reviewed by Kent Tamura.
2827
2828         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2829         https://bugs.webkit.org/show_bug.cgi?id=52332
2830
2831         Forked Info.plist is not longer needed.
2832
2833         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2834
2835 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2836
2837         Reviewed by Timothy Hatcher.
2838
2839         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2840         to be passed directly to WebInspector.UIString
2841
2842         https://bugs.webkit.org/show_bug.cgi?id=52365
2843
2844         * Scripts/check-inspector-strings:
2845
2846 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2847
2848         Unreviewed, rolling out r74881.
2849         http://trac.webkit.org/changeset/74881
2850         https://bugs.webkit.org/show_bug.cgi?id=52357
2851
2852         The EFL builder has been red for days (Requested by abarth on
2853         #webkit).
2854
2855         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2856         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2857
2858 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2859
2860         Reviewed by David Levin.
2861
2862         Add beforeunload support to WebKitTestRunner
2863         https://bugs.webkit.org/show_bug.cgi?id=52353
2864         
2865         This makes a number of currently failing tests pass.
2866
2867         * WebKitTestRunner/TestController.cpp:
2868         (WTR::runBeforeUnloadConfirmPanel):
2869         (WTR::createOtherPage):
2870         (WTR::TestController::initialize):
2871
2872 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2873
2874         Reviewed by Sam Weinig.
2875
2876         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2877         https://bugs.webkit.org/show_bug.cgi?id=52330
2878
2879         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2880         a web process crash.
2881         * WebKitTestRunner/TestController.cpp:
2882         (WTR::TestController::initialize): Set up a processDidCrash
2883         callback.
2884         (WTR::TestController::processDidCrash): Report that the Web process
2885         crashed.
2886         * WebKitTestRunner/TestController.h:
2887
2888 2011-01-12  David Levin  <levin@chromium.org>
2889
2890         Reviewed by Shinichiro Hamaji.
2891
2892         check-webkit-style -- close_expression function doesn't work correctly.
2893         https://bugs.webkit.org/show_bug.cgi?id=52272
2894
2895         * Scripts/webkitpy/style/checkers/cpp.py:
2896         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2897         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2898         generally useful (for upcoming code changes).
2899         (close_expression): Changed to use Position for input and output.
2900         Also, fixed many bugs such as only working correctly for parenthesis,
2901         not working correctly if given an offset in a line and not finding
2902         the real closing element if there were multiple closing elements in
2903         the same line.
2904         (detect_functions): Adjusted due to the change in arguments for
2905         close_expression.
2906         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2907         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2908         two positions are the same.
2909         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2910         (CppStyleTest.test_close_expression): Added tests to catch the issues
2911         that were fixed.
2912
2913 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2914
2915         Unreviewed, rolling out r75576.
2916         http://trac.webkit.org/changeset/75576
2917         https://bugs.webkit.org/show_bug.cgi?id=52304
2918
2919         broke rebaseline-chromium-webkit-test (Requested by thakis on
2920         #webkit).
2921
2922         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2923         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2924         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2925         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2926         * Scripts/webkitpy/layout_tests/port/base.py:
2927         * Scripts/webkitpy/layout_tests/port/chromium.py:
2928         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2929         * Scripts/webkitpy/layout_tests/port/test.py:
2930         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2931         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2932         * Scripts/webkitpy/style/checkers/test_expectations.py:
2933         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2934
2935 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2936
2937         Reviewed by Darin Adler.
2938
2939         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2940         https://bugs.webkit.org/show_bug.cgi?id=52307
2941
2942         * Scripts/old-run-webkit-tests:
2943
2944 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2945
2946         Reviewed by Martin Robinson.
2947
2948         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2949         https://bugs.webkit.org/show_bug.cgi?id=50867
2950
2951         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2952         TestNetscapePlugin.cpp 
2953
2954         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2955         * Scripts/webkitdirs.pm:
2956
2957 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2958
2959         Reviewed by Pavel Feldman.
2960
2961         Add check-inspector-strings script.
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=52295
2964
2965         * Scripts/check-inspector-strings: Added.
2966
2967 2011-01-12  Adam Roben  <aroben@apple.com>
2968
2969         Advertise the .testnetscape file extension on Windows
2970
2971         Fixes <http://webkit.org/b/52298>
2972         plugins/no-mime-with-valid-extension.html fails on Windows
2973
2974         Reviewed by Dan Bernstein.
2975
2976         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2977         FileExtents field to map the .testnetscape file extension to the
2978         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2979
2980 2011-01-12  Adam Barth  <abarth@webkit.org>
2981
2982         Reviewed by Eric Seidel.
2983
2984         Make webkit-patch support subdirectories for SVN checkouts
2985         https://bugs.webkit.org/show_bug.cgi?id=52261
2986
2987         os.relpath does not exist on Python 2.5, so we need to call our version
2988         of the API.
2989
2990         * Scripts/webkitpy/common/checkout/scm.py:
2991
2992 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2993
2994         Reviewed by Eric Seidel.
2995
2996         Close additional pages opened during a test once the test completes.
2997         https://bugs.webkit.org/show_bug.cgi?id=52276
2998
2999         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3000         (WTR::InjectedBundle::done):
3001
3002 2011-01-11  David Levin  <levin@chromium.org>
3003
3004         Reviewed by Eric Seidel.
3005
3006         Errors should be separated from the command line in bot messages.
3007         https://bugs.webkit.org/show_bug.cgi?id=52275
3008
3009         * Scripts/webkitpy/common/system/executive.py:
3010         (ScriptError.message_with_output): Added a newline to separate the command
3011         line from the errors.
3012         * Scripts/webkitpy/common/system/executive_unittest.py:
3013         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3014         paths in message_with_output.
3015
3016 2011-01-11  Eric Seidel  <eric@webkit.org>
3017
3018         Unreviewed.
3019
3020         commit-queue should know how to upload archived results (for test flakes or general failures)
3021         https://bugs.webkit.org/show_bug.cgi?id=52048
3022
3023         The zips are mostly empty due to forgetting -r.
3024         Expected diffs were not being pulled from the archive due
3025         to the archive having longer paths than I realized.
3026
3027         * Scripts/webkitpy/common/system/workspace.py:
3028         * Scripts/webkitpy/common/system/workspace_unittest.py:
3029         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3030         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3031
3032 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3033
3034         Reviewed by Ojan Vafai.
3035
3036         The current modifier parsing code in test_expectations is
3037         fragile and hard-coded, so it's not easy to understand the logic
3038         or easily add new types of modifiers (like GPU vs. CPU testing
3039         for graphics tests, or 32-bit vs. 64-bit differences).
3040
3041         This is the first of two patches that will add in more generic
3042         support and then eliminate the GPU-specific test expectations
3043         files for Chromium.
3044
3045         This patch adds two standalone objects for handling modifiers. The
3046         rules for interpreting modifiers, precedence, and conflicts are
3047         given in the docstring to the ModifierMatcher class, which
3048         returns ModifierMatchResult objects.
3049         
3050         This patch also adds routines to the Port interface and a
3051         default set of values in the base object, in order to obtain the
3052         values needed on a given test run. These values are then passed
3053         to the expectation parser. This also allows us to clean up the
3054         logic used to lint all of the different configurations in a
3055         single test_expectations.txt file.
3056
3057         The next patch will merge in the separate GPU expectations file.
3058
3059         https://bugs.webkit.org/show_bug.cgi?id=51222
3060
3061         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3062         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3063         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3064         * Scripts/webkitpy/layout_tests/port/base.py:
3065         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3066         * Scripts/webkitpy/layout_tests/port/chromium.py:
3067         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3068         * Scripts/webkitpy/layout_tests/port/test.py:
3069         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3070         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3071
3072 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3073
3074         Reviewed by Adam Barth.
3075
3076         Make webkit-patch support subdirectories for SVN checkouts
3077         https://bugs.webkit.org/show_bug.cgi?id=52261
3078
3079         * Scripts/webkitpy/common/checkout/scm.py:
3080         * Scripts/webkitpy/style_references.py:
3081         * Scripts/webkitpy/tool/main.py:
3082         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3083
3084 2011-01-11  Eric Seidel  <eric@webkit.org>
3085
3086         Unreviewed.
3087
3088         commit-queue should know how to upload archived results (for test flakes or general failures)
3089         https://bugs.webkit.org/show_bug.cgi?id=52048
3090
3091         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3092         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3093
3094         * Scripts/webkitpy/common/system/workspace.py:
3095         * Scripts/webkitpy/common/system/workspace_unittest.py:
3096         * Scripts/webkitpy/tool/commands/queues.py:
3097
3098 2011-01-11  Sam Weinig  <sam@webkit.org>
3099
3100         Roll r75474 back in.
3101
3102 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3103
3104         Reviewed by Kenneth Rohde Christiansen.
3105
3106         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3107         https://bugs.webkit.org/show_bug.cgi?id=51204
3108
3109         * QtTestBrowser/webpage.h:
3110         (QtNAMThread::QtNAMThread):
3111         (QtNAMThread::networkAccessManager):
3112         (QtNAMThread::run):
3113
3114 2011-01-11  Peter Varga  <pvarga@webkit.org>
3115
3116         Unreviewed.
3117
3118         Add myself to committers' list.
3119
3120         * Scripts/webkitpy/common/config/committers.py:
3121
3122 2011-01-11  Eric Seidel  <eric@webkit.org>
3123
3124         Reviewed by Adam Barth.
3125
3126         commit-queue should know how to upload archived results (for test flakes or general failures)
3127         https://bugs.webkit.org/show_bug.cgi?id=52048
3128
3129         Now the queue will always upload results.  Either the entire zip, or just
3130         the diffs.txt in the case of text failures.
3131
3132         This should make understanding flakes much easier, and paves the way
3133         for having the EWS run layout tests (and upload failures).
3134
3135         In order to upload .zip files I had to teach bugzilla.py to autodetect
3136         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3137         for .patch files, I have it add one before calling guess_type.
3138
3139         We may find that always uploading the whole zip instead of just the -diffs.txt
3140         file is preferable, but for now I'm keeping the old behavior because it makes
3141         quickly understanding text failures easy.
3142
3143         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3144         * Scripts/webkitpy/common/system/workspace.py: Added.
3145         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3146         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3147         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3148         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3149         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3150         * Scripts/webkitpy/tool/commands/queues.py:
3151         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3152
3153 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3154
3155         Unreviewed, rolling out r75464.
3156         http://trac.webkit.org/changeset/75464
3157         https://bugs.webkit.org/show_bug.cgi?id=52193
3158
3159         Followup rollout for 75474 (Requested by Ossy on #webkit).
3160
3161         * MiniBrowser/mac/BrowserWindowController.m:
3162         (-[BrowserWindowController awakeFromNib]):
3163         * MiniBrowser/win/BrowserView.cpp:
3164         (BrowserView::create):
3165         * WebKitTestRunner/TestController.cpp:
3166         (WTR::createOtherPage):
3167         (WTR::TestController::initialize):
3168
3169 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3170
3171         Reviewed by Csaba Osztrogonác.
3172
3173         [Qt] Baseline qt_minimal configuration
3174         https://bugs.webkit.org/show_bug.cgi?id=51313
3175
3176         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3177         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3178         QT_NO_UNDOSTACK guard.
3179
3180         * QtTestBrowser/launcherwindow.cpp:
3181         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3182         guards.
3183         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3184         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3185         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3186         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3187
3188         * QtTestBrowser/launcherwindow.h:
3189         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3190         * QtTestBrowser/locationedit.h: Ditto.
3191
3192         * QtTestBrowser/mainwindow.cpp:
3193         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3194         QT_NO_UNDOSTACK guards.
3195         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3196         (MainWindow::changeLocation): Ditto.
3197         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3198         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3199
3200         * QtTestBrowser/webpage.cpp:
3201         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3202         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3203
3204         * QtTestBrowser/webview.cpp:
3205         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3206         (WebViewGraphicsBased::animatedYFlip): Ditto.
3207
3208 2011-01-10  Sam Weinig  <sam@webkit.org>
3209
3210         Fix build.
3211
3212         * MiniBrowser/mac/BrowserWindowController.m:
3213         (-[BrowserWindowController awakeFromNib]):
3214         * MiniBrowser/win/BrowserView.cpp:
3215         (BrowserView::create):
3216         * WebKitTestRunner/TestController.cpp:
3217         (WTR::createOtherPage):
3218         (WTR::TestController::initialize):
3219
3220 2011-01-10  Eric Seidel  <eric@webkit.org>
3221
3222         Reviewed by Ojan Vafai.
3223
3224         style-queue messages are way too long for big patches
3225         https://bugs.webkit.org/show_bug.cgi?id=52161
3226
3227         We definitely could build much fancier list-to-string-with-limit functions
3228         but this should be sufficient for our needs at the moment.
3229
3230         * Scripts/webkitpy/common/system/executive.py:
3231         * Scripts/webkitpy/common/system/executive_unittest.py:
3232
3233 2011-01-10  Tony Chang  <tony@chromium.org>
3234
3235         Unreviewed, rolling out r75398.
3236         http://trac.webkit.org/changeset/75398
3237         https://bugs.webkit.org/show_bug.cgi?id=52008
3238
3239         Some layout tests are crashing on Chromium Win.
3240
3241         * DumpRenderTree/chromium/WebViewHost.cpp:
3242         (WebViewHost::updatePaintRect):
3243         * DumpRenderTree/chromium/WebViewHost.h:
3244
3245 2011-01-10  Adam Roben  <aroben@apple.com>
3246
3247         Roll out r75392
3248
3249         It isn't needed now that r75289 has been rolled out.
3250
3251         * Scripts/run-javascriptcore-tests:
3252
3253 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3254
3255         Reviewed by Anders Carlsson.
3256
3257         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3258         https://bugs.webkit.org/show_bug.cgi?id=52160
3259
3260         * WebKitTestRunner/mac/TestControllerMac.mm:
3261         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3262         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3263         anyway.
3264
3265 2011-01-10  Tony Chang  <tony@chromium.org>
3266
3267         Reviewed by Mihai Parparita.
3268
3269         [chromium] fix for animated gif layout tests
3270         https://bugs.webkit.org/show_bug.cgi?id=52008
3271
3272         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3273             to trigger gif animations.
3274         (WebViewHostPaintTask::WebViewHostPaintTask):
3275         (WebViewHostPaintTask::runIfValid):
3276         (WebViewHost::updatePaintRect):
3277         * DumpRenderTree/chromium/WebViewHost.h:
3278         (WebViewHost::taskList):
3279
3280 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3281
3282         Reviewed by Xan Lopez.
3283
3284         [GTK] Fix gtk2 compilation for master
3285         https://bugs.webkit.org/show_bug.cgi?id=51885
3286
3287         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3288         (createBitmapContextFromWebView): Replaced the old
3289         gdk_drawable_get_size with gdk_pixmap_get_size.
3290
3291 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3292
3293         Reviewed by Laszlo Gombos.
3294
3295         [WINCE] Reenable NPAPI after r75203
3296         https://bugs.webkit.org/show_bug.cgi?id=52109
3297
3298         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3299         it with !isEfl(), because EFL port does not support NPAPI (yet).
3300
3301         * Scripts/build-webkit:
3302
3303 2011-01-10  Adam Roben  <aroben@apple.com>
3304
3305         Skip some asserting JS tests
3306
3307         See <http://webkit.org/b/52156>.
3308
3309         * Scripts/run-javascriptcore-tests:
3310
3311 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3312
3313         Reviewed by Xan Lopez.
3314
3315         [GTK] build-webkit disable Blob support via arguments passed to automake
3316         https://bugs.webkit.org/show_bug.cgi?id=52097
3317
3318         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3319         build-webkit.
3320
3321 2011-01-10  Adam Roben  <aroben@apple.com>
3322
3323         Use the same name and description for TestNetscapePlugin on Windows and
3324         Mac
3325
3326         Fixes <http://webkit.org/b/52151>
3327         fast/frames/iframe-reparenting-plugins.html fails on Windows
3328
3329         Reviewed by Steve Falkenburg.
3330
3331         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3332         the name and description from Mac's Info.plist.
3333
3334 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3335
3336         Reviewed by Laszlo Gombos.
3337
3338         [Qt][WK2] Guard gcc-specific syntax
3339
3340         Non-gcc based compliers choke on the "-include"
3341         syntax for preinclude, place guard around it.
3342
3343         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3344         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3345
3346 2011-01-10  Andreas Kling  <kling@webkit.org>
3347
3348         Reviewed by Simon Hausmann.
3349
3350         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3351         https://bugs.webkit.org/show_bug.cgi?id=52111
3352
3353         When getting a createNewPage() callback from QWKPage, create the
3354         new page with the same QWKContext as the page that is passed to
3355         the callback.
3356
3357         * MiniBrowser/qt/BrowserView.h:
3358         * MiniBrowser/qt/BrowserWindow.cpp:
3359         (newPageFunction):
3360         (BrowserWindow::BrowserWindow):
3361         * MiniBrowser/qt/BrowserWindow.h:
3362
3363 2011-01-10  Andreas Kling  <kling@webkit.org>
3364
3365         Reviewed by Kenneth Rohde Christiansen.
3366
3367         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3368
3369         BrowserView set its own useless createNewPage() callback on QWKPage.
3370         This was immediately overridden by BrowserWindow anyway, so remove
3371         the BrowserView one.
3372
3373         * MiniBrowser/qt/BrowserView.cpp:
3374         (BrowserView::BrowserView):
3375
3376 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3377
3378         Reviewed by Jeremy Orlow.
3379
3380         [Chromium] Remove non-client-based Geolocation code
3381         https://bugs.webkit.org/show_bug.cgi?id=50921
3382
3383         * DumpRenderTree/chromium/LayoutTestController.cpp:
3384         (LayoutTestController::setGeolocationPermission):
3385         (LayoutTestController::setMockGeolocationPosition):
3386         (LayoutTestController::setMockGeolocationError):
3387         * DumpRenderTree/chromium/WebViewHost.cpp:
3388         (WebViewHost::geolocationClientMock):
3389         (WebViewHost::reset):
3390         * DumpRenderTree/chromium/WebViewHost.h:
3391
3392 2011-01-10  Eric Seidel  <eric@webkit.org>
3393
3394         Reviewed by Adam Barth.
3395
3396         Commit bot tried to land r? cq+ patch
3397         https://bugs.webkit.org/show_bug.cgi?id=36638
3398
3399         It should now be possible to post a patch with r? and cq+ and the
3400         commit-queue will correctly wait for the r+ before attempting to land the patch.
3401         (This was a feature requested by several users.)
3402
3403         One caveat: We don't actually reject r-, cq+ patches from the queue
3404         (we just ignore them), but I think that's OK for now.
3405
3406         I also noticed that setting r- once a commit-queue node had grabbed
3407         a patch would not properly cancel the landing.  That's fixed and
3408         tested in this patch.
3409
3410         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3411         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3412         * Scripts/webkitpy/tool/bot/feeders.py:
3413         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3414
3415 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3416
3417         Reviewed by Kenneth Rohde Christiansen.
3418
3419         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3420         https://bugs.webkit.org/show_bug.cgi?id=51934
3421
3422         When accessing the network from the destructor of QWebPage, the network access manager
3423         was already deleted because the object WebPage was already destructed.
3424
3425         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3426         The object is now destructed in the destructor of QObject.
3427
3428         * QtTestBrowser/webpage.cpp:
3429         (WebPage::WebPage):
3430         (WebPage::setQnamThreaded):
3431         * QtTestBrowser/webpage.h:
3432         (QtNAMThread::QtNAMThread):
3433
3434 2011-01-08  Eric Seidel  <eric@webkit.org>
3435
3436         Reviewed by Ojan Vafai.
3437
3438         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3439         https://bugs.webkit.org/show_bug.cgi?id=52067
3440
3441         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3442         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3443
3444         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3445
3446 2011-01-08  Eric Seidel  <eric@webkit.org>
3447
3448         Reviewed by Mihai Parparita.
3449
3450         commit-queue hangs when the ChangeLog diff is bad
3451         https://bugs.webkit.org/show_bug.cgi?id=52072
3452
3453         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3454         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3455
3456 2011-01-08  Adam Barth  <abarth@webkit.org>
3457
3458         Teach svn-apply how to re-write WebCore to Source/WebCore.
3459
3460         * Scripts/VCSUtils.pm:
3461
3462 2011-01-07  Adam Barth  <abarth@webkit.org>
3463
3464         Rubber-stamped by Eric Seidel.
3465
3466         Move WebCore to Source
3467         https://bugs.webkit.org/show_bug.cgi?id=52050
3468
3469         Update the tools to understand WebCore's new location.
3470
3471         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3472         * DumpRenderTree/wscript:
3473         * GNUmakefile.am:
3474         * Scripts/build-webkit:
3475         * Scripts/do-file-rename:
3476         * Scripts/do-webcore-rename:
3477         * Scripts/generate-qt-inspector-resource:
3478         * Scripts/prepare-ChangeLog:
3479         * Scripts/run-bindings-tests:
3480         * Scripts/update-iexploder-cssproperties:
3481         * Scripts/update-sources-list.py:
3482         * Scripts/update-webkit-localizable-strings:
3483         * Scripts/webkitdirs.pm:
3484         * Scripts/webkitpy/common/config/build.py:
3485         * Scripts/webkitpy/common/config/build_unittest.py:
3486         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3487         * Scripts/webkitpy/style/checker.py:
3488         * Scripts/webkitpy/style/checker_unittest.py:
3489         * WebKitTestRunner/DerivedSources.pro:
3490         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3491         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3492         * wx/browser/wscript:
3493         * wx/build/settings.py:
3494
3495 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3496
3497         Reviewed by Sam Weinig.
3498
3499         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3500         https://bugs.webkit.org/show_bug.cgi?id=52086
3501
3502         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3503         (WTR::InjectedBundle::didReceiveMessage):
3504         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3505         (WTR::LayoutTestController::notifyDone):
3506         * WebKitTestRunner/TestController.cpp:
3507         (WTR::TestController::resetStateToConsistentValues):
3508         (WTR::TestController::run):
3509
3510 2011-01-07  James Robinson  <jamesr@chromium.org>
3511
3512         Revert "Implement mozilla's animationTime property"
3513         https://bugs.webkit.org/show_bug.cgi?id=51952
3514
3515         This approach isn't quite right.
3516
3517         * DumpRenderTree/chromium/WebViewHost.cpp:
3518         (WebViewHost::paintInvalidatedRegion):
3519
3520 2011-01-07  Adam Roben  <aroben@apple.com>
3521
3522         Build master fix
3523
3524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3525         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3526
3527 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3528
3529         Reviewed by Csaba Osztrogonác.
3530
3531         run-qtwebkit-tests should be able to kill a testsuite.
3532
3533         Add new option in the script that can setup a timeout for a test.
3534         If the test execution takes more then specified time then the test
3535         would be terminated.
3536
3537         [Qt] run-qtwebkit-tests needs timeout
3538         https://bugs.webkit.org/show_bug.cgi?id=51894
3539
3540         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3541         * Scripts/run-qtwebkit-tests:
3542
3543 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3544
3545         Unreviewed fix after r75233.
3546
3547         Based on idea from Eric Seidel.
3548
3549         Add remote zip file handling to webkitpy.
3550         https://bugs.webkit.org/show_bug.cgi?id=50901
3551
3552         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3553
3554 2011-01-07  Shane Stephens  <shanestephens@google.com>
3555
3556         Reviewed by Eric Seidel.
3557
3558         svn-apply: should support git binary delta diffs
3559         https://bugs.webkit.org/show_bug.cgi?id=38864
3560
3561         * Scripts/VCSUtils.pm:
3562         * Scripts/svn-apply:
3563
3564 2011-01-06  Julie Parent  <jparent@chromium.org>
3565
3566         Reviewed by Eric Seidel.
3567
3568         Test Result Server not removing old results.
3569         https://bugs.webkit.org/show_bug.cgi?id=52012
3570
3571         * TestResultServer/model/jsonresults.py:
3572         Fix off-by-one: Truncate if >= num_runs, not just >.
3573         * TestResultServer/model/jsonresults_unittest.py:
3574         Add unit test to test that merging in a new result with the same value
3575         as the last result causes previous result to fall off.
3576
3577 2011-01-06  James Kozianski  <koz@chromium.org>
3578
3579         Reviewed by Mihai Parparita.
3580
3581         Add classes to provide a consistent interface to a set of files.
3582         https://bugs.webkit.org/show_bug.cgi?id=50901
3583
3584         These classes allow us to write code that is agnostic to whether a
3585         particular set of files resides in a local directory or in a zip file
3586         on a remote machine.
3587
3588         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3589         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3590         * Scripts/webkitpy/common/system/fileset.py: Added.
3591         * Scripts/webkitpy/common/system/filesystem.py:
3592         * Scripts/webkitpy/common/system/filesystem_mock.py:
3593         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3594         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3595
3596 2011-01-06  Eric Seidel  <eric@webkit.org>
3597
3598         Reviewed by Adam Barth.
3599
3600         NetworkTransaction should log the url it is retrying
3601         https://bugs.webkit.org/show_bug.cgi?id=52043
3602
3603         * Scripts/webkitpy/common/net/networktransaction.py:
3604         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3605
3606 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3607
3608         Windows build fix.
3609         Import os before using it.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3612
3613 2011-01-06  Eric Seidel  <eric@webkit.org>
3614
3615         Reviewed by Adam Barth.
3616
3617         StyleQueue fails to report errors when patches have many files
3618         https://bugs.webkit.org/show_bug.cgi?id=52042
3619
3620         This is one of at least two errors preventing style error reporting at the moment.
3621         When we moved to passing the list of files to check explicitly,
3622         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3623         We could change the type of the QueueStatus.message type, or we could
3624         just teach statusserver.py how to clamp values (and warn when it does).
3625         I chose the latter path.
3626
3627         * Scripts/webkitpy/common/net/statusserver.py:
3628
3629 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3630
3631         Reviewed by Stephanie Lewis.
3632         
3633         Fix syntax error in script.
3634
3635         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3636         https://bugs.webkit.org/show_bug.cgi?id=51996
3637
3638         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3639
3640 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3641
3642         Unreviewed, fixing WinCE build after r75196.
3643
3644         WinCE port does not (yet) support NPAPI.
3645
3646         * Scripts/build-webkit:
3647
3648 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3649
3650         Reviewed by Darin Adler.
3651
3652         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3653         https://bugs.webkit.org/show_bug.cgi?id=52015
3654
3655         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3656         after the platform has been detected, otherwise the script will
3657         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3658         detection.
3659
3660 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3661
3662         Reviewed by Eric Seidel.
3663
3664         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3665         https://bugs.webkit.org/show_bug.cgi?id=51346
3666
3667         * Scripts/build-webkit:
3668
3669 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3670
3671         Reviewed by Adam Roben.
3672
3673         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3674         https://bugs.webkit.org/show_bug.cgi?id=51996
3675         
3676         After the configuration directory change, we were archiving the incorrect directory for
3677         build product, so we were running tests on the wrong binaries.
3678         
3679         This change archives the correct directory, and also unarchives it into a configuration-
3680         specific directory.
3681
3682         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3683         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3684
3685 2011-01-06  Eric Seidel  <eric@webkit.org>
3686
3687         Reviewed by Mihai Parparita.
3688
3689         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3690         https://bugs.webkit.org/show_bug.cgi?id=52002
3691
3692         See an example of this here:
3693         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3694
3695         It's due to the fact that we pass around TestFailure() instance
3696         objects and yet expect them to all compare to be the same.
3697
3698         This is bad.  We should either have shared instances of these values
3699         or we should just pass around the class names.  There are already hacks
3700         in place to make TestFailure objects pass equality tests, I just added
3701         a __hash__ implementation so they can be used in sets as expected.
3702
3703         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3704         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3705
3706 2011-01-06  Evan Martin  <evan@chromium.org>
3707
3708         Reviewed by Tony Chang.
3709
3710         [gdb] handle inaccessible memory and UChar*
3711         https://bugs.webkit.org/show_bug.cgi?id=52003
3712
3713         To pretty-print a UChar*, we just grope around in&