a6f2591c70d831c8e6a33d28c604d82011b7708a
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-01  Hajime Morrita  <morrita@chromium.org>
2
3         JS_INLINE and WTF_INLINE should be visible from WebCore
4         https://bugs.webkit.org/show_bug.cgi?id=73191
5
6         Reviewed by Kevin Ollivier.
7
8         Removed macro definitions which is now provided by Platform.h
9
10         * DumpRenderTree/chromium/config.h:
11         * DumpRenderTree/config.h:
12         * TestWebKitAPI/config.h:
13         * WebKitTestRunner/config.h:
14
15 2011-12-01  Hayato Ito  <hayato@chromium.org>
16
17         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
18         https://bugs.webkit.org/show_bug.cgi?id=73406
19
20         Reviewed by Ryosuke Niwa.
21
22         WebKitPort's image_diff uses tolerance='0.1' in default.
23         When reftests fail, we should use tolerace=0 when diff-ing images.
24
25         Since ImageDiff on chromium port doesn't use tolerance value as of now,
26         this change doesn't affect chromium port's behavior.
27
28         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
29         (write_test_result):
30         * Scripts/webkitpy/layout_tests/port/base.py:
31         (Port.diff_image):
32         * Scripts/webkitpy/layout_tests/port/chromium.py:
33         (ChromiumPort.diff_image):
34         * Scripts/webkitpy/layout_tests/port/test.py:
35         (TestPort.diff_image):
36         * Scripts/webkitpy/layout_tests/port/webkit.py:
37         (WebKitPort.diff_image):
38         (WebKitPort._start_image_diff_process):
39         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
40         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
41
42 2011-12-01  Adam Klein  <adamk@chromium.org>
43
44         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
45         https://bugs.webkit.org/show_bug.cgi?id=73599
46
47         Reviewed by Ojan Vafai.
48
49         * TestResultServer/static-dashboards/builders.js:
50         * TestResultServer/static-dashboards/dashboard_base.js:
51         ():
52         (htmlForTestTypeSwitcher):
53         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
54         (testHtmlForTestTypeSwitcherGroup):
55
56 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
57
58         Parse reftest.list and extract types of ref tests
59         https://bugs.webkit.org/show_bug.cgi?id=66837
60
61         Reviewed by Dirk Pranke.
62
63         Add support for reftest.list to base port.
64
65         * Scripts/webkitpy/common/find_files.py:
66         (find):
67         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
68         (SingleTestRunner.__init__):
69         * Scripts/webkitpy/layout_tests/port/base.py:
70         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
71         to a dictionary of {test path: ("==" or "!=", reference file path)}
72         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
73         (Port._reference_file_for): Added; obtains the reference file name given a test name.
74         (Port.is_reftest): Added; Calls _reference_file_for.
75         (Port.reftest_expected_filename): Calls _reference_file_for.
76         (Port.reftest_expected_mismatch_filename): Ditto.
77         (Port.find_test_files):
78         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
79         -expected, -expected-mismach, -ref, or -notref as a reference file.
80         (_is_test_file):
81         (_parse_reftest_list): Added.
82         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
83         (PortTest.test_is_test_file):
84         (PortTest.test_parse_reftest_list):
85         * Scripts/webkitpy/layout_tests/port/dryrun.py:
86         (DryrunDriver.run_test):
87         * Scripts/webkitpy/layout_tests/port/test.py:
88         (unit_test_filesystem.add_test_file):
89         (unit_test_filesystem.add_file):
90         (unit_test_filesystem):
91         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
92         (get_tests_run.RecordingTestDriver.run_test):
93         (MainTest.test_unexpected_failures):
94         (MainTest.test_missing_and_unexpected_results):
95         (EndToEndTest.test_end_to_end):
96         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
97         (Rebaseliner._compile_rebaselining_tests):
98
99 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
100
101         Unreviewed, rolling out r101711.
102         http://trac.webkit.org/changeset/101711
103         https://bugs.webkit.org/show_bug.cgi?id=73605
104
105         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
106
107         * Scripts/webkitpy/style/checker.py:
108         (_all_categories):
109         (FileType):
110         (CheckerDispatcher._file_type):
111         (CheckerDispatcher._create_checker):
112         * Scripts/webkitpy/style/checker_unittest.py:
113         (CheckerDispatcherDispatchTest.assert_checker_cpp):
114         (CheckerDispatcherDispatchTest.test_cpp_paths):
115         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
116         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
117
118 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
119
120         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
121
122         * Scripts/webkitpy/common/config/watchlist:
123
124 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
125
126         [GTK] Read fonts from the jhbuild root
127         https://bugs.webkit.org/show_bug.cgi?id=73487
128
129         Reviewed by Gustavo Noronha Silva.
130
131         Read fonts from the jhbuild root instead of from the system. This will ensure
132         that all testers use the same fonts instead of leaving this up to luck.
133
134         * DumpRenderTree/gtk/DumpRenderTree.cpp:
135         (initializeFonts): Load fonts from jhbuild root.
136         * Scripts/webkitpy/layout_tests/port/gtk.py:
137         (GtkPort.setup_environ_for_server): Pass an environment variable containing
138         the path to the jhbuild root.
139         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
140         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
141
142 2011-12-01  Adam Roben  <aroben@apple.com>
143
144         Teach check-webkit-style how to check the syntax of JSON files
145
146         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
147
148         Reviewed by Darin Adler.
149
150         * Scripts/webkitpy/style/checker.py:
151         (_all_categories): Added JSONChecker's categories to the set of all categories.
152         (FileType): Added a JSON type. Incremented other types.
153         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
154         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
155
156         * Scripts/webkitpy/style/checker_unittest.py:
157         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
158         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
159
160         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
161         which would have matched our other checkers, because I couldn't figure out how to call
162         "json.loads" without hitting namespace conflicts.)
163         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
164         just the modified lines from a patch.
165         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
166         exception.
167         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
168         try to extract a line number.
169
170         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
171         (MockErrorHandler.__init__):
172         (MockErrorHandler.turn_off_line_filtering):
173         (MockErrorHandler.__call__):
174         Helper class. Copied from xml_unittest.py.
175
176         (JSONCheckerTest.test_line_number_from_json_exception): Test the
177         line_number_from_json_exception helper method.
178
179         (JSONCheckerTest.assert_no_error):
180         (JSONCheckerTest.assert_error):
181         Helper methods to assert that we did or didn't get an error.
182
183         (JSONCheckerTest.mock_handle_style_error): Helper method.
184
185         (JSONCheckerTest.test_conflict_marker):
186         (JSONCheckerTest.test_single_quote):
187         (JSONCheckerTest.test_init):
188         (JSONCheckerTest.test_missing_closing_brace):
189         (JSONCheckerTest.test_no_error):
190         Test various cases.
191
192 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
193
194         [GTK] Add a helper function to find the current executable's path
195         https://bugs.webkit.org/show_bug.cgi?id=73473
196
197         Reviewed by Gustavo Noronha Silva.
198
199         Update MiniBrowser to not pass the binary directory as an environment variable.
200         This means that you can move the binaries around without it breaking.
201
202         * MiniBrowser/gtk/main.c:
203         (main): No longer set the environment variable.
204         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
205         * WebKitTestRunner/gtk/main.cpp:  Ditto.
206
207 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
208
209         Unreviewed. Fix bad file =(.
210
211         * gtk/jhbuild.modules:
212         * Scripts/webkitdirs.pm:
213         (runAutogenForAutotoolsProject):
214
215 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
216
217         [GTK] Add freetype to our jhbuild setup
218         https://bugs.webkit.org/show_bug.cgi?id=73488
219
220         Reviewed by Martin Robinson.
221
222         This adds the first library to our jhbuild setup, and makes sure
223         build-webkit calls autogen.sh and make with jhbuild, so that the
224         environment is properly set.
225
226         * Scripts/webkitdirs.pm:
227         (saveSum):
228         (hashFile):
229         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
230         call autogen under jhbuild run;
231         (mustRunAutogen): generalized the arguments change checking to also force
232         running autogen when jhbuild files change;
233         (buildAutotoolsProject): run make under jhbuild;
234         * gtk/jhbuild.modules: add freetype.
235
236 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
237
238         Fix WebKitTestRunner compile warnings with XCode 3.2
239         https://bugs.webkit.org/show_bug.cgi?id=73378
240
241         Reviewed by Chris Fleizach.
242
243         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
244         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
245         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
246         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
247         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
248         (WTR::AccessibilityUIElement::AccessibilityUIElement):
249         (WTR::AccessibilityUIElement::verticalScrollbar):
250
251 2011-12-01  Adam Roben  <aroben@apple.com>
252
253         Allow committers to use their Trac credentials to force builds on the buildbots
254
255         Fixes <http://webkit.org/b/73353>
256
257         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
258         three files to do its job: a config file that contains a list of WebKit committer usernames,
259         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
260         those two files.
261
262         Reviewed by Darin Adler.
263
264         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
265         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
266         whether credentials were valid or not.
267         (CommitterAuth.__init__): Just store the path to auth.json.
268         (CommitterAuth.auth_json): Load, parse, and return auth.json.
269         (CommitterAuth.auth_json_filename): Return the path to auth.json.
270         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
271         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
272         checking those conditions.
273         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
274         false otherwise or if an exception was thrown.
275         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
276         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
277
278         (CommitterAuth.open_auth_json_file):
279         (CommitterAuth.open_trac_credentials_file):
280         (CommitterAuth.open_webkit_committers_file):
281         Open the specified file. These are mostly useful for testing purposes.
282
283         (CommitterAuth.trac_credentials_filename):
284         (CommitterAuth.webkit_committers_filename):
285         Return the path to the specified file by retrieving it from auth.json.
286
287         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
288         of WebKit committers from it.
289
290         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
291         (CMStringIO.__enter__):
292         (CMStringIO.__exit__):
293         Helper class that makes it possible to use StringIO with the "with" statement.
294
295         (open_override): Helper context manager for overriding the global "open" function
296         temporarily.
297
298         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
299         tests.
300         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
301         "open" to test that the expected path was opened.
302         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
303         successfully.
304         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
305         somehow have no Trac account can't authenticate.
306
307         (CommitterAuthTest.test_fail_to_open_auth_json_file):
308         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
309         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
310         Test what happens when we can't open the three files we depend upon.
311
312         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
313         an authentication class.
314
315         (CommitterAuthTest.test_invalid_auth_json_file):
316         (CommitterAuthTest.test_invalid_committers_file):
317         (CommitterAuthTest.test_invalid_trac_credentials_file):
318         (CommitterAuthTest.test_missing_auth_json_keys):
319         Test what happens when the three files we depend upon are invalid in some way.
320
321         (CommitterAuthTest.test_open_auth_json_file):
322         (CommitterAuthTest.test_open_trac_credentials_file):
323         (CommitterAuthTest.test_open_webkit_committers_file):
324         Test that we open the expected paths.
325
326         (CommitterAuthTest.test_trac_credentials_filename):
327         (CommitterAuthTest.test_webkit_committers_filename):
328         Test that we extract filenames out of auth.json correctly.
329
330         (CommitterAuthTest.test_non_committer_fails):
331         (CommitterAuthTest.test_unknown_user_fails):
332         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
333         (CommitterAuthTest.test_wrong_password_fails):
334         Test various failed authentication attempts.
335
336         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
337         committers out of the committers file correctly.
338
339         (CommitterAuthTest.fake_auth_json_file):
340         (CommitterAuthTest.invalid_auth_json_file):
341         (CommitterAuthTest.fake_committers_file):
342         (CommitterAuthTest.invalid_committers_file):
343         (CommitterAuthTest.fake_htdigest_file):
344         (CommitterAuthTest.invalid_htdigest_file):
345         Return various fake files for testing.
346
347         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
348         to be used for authentication in the web interface, and specify that only authenticated
349         users may force builds.
350
351 2011-12-01  Adam Roben  <aroben@apple.com>
352
353         Add an HTDigestParser class to webkitpy
354
355         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
356
357         This class can be used to parse Apache's htdigest files and check whether a given
358         username/realm/password tuple is present in the file. Eventually this will be used for
359         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
360
361         Reviewed by Eric Seidel.
362
363         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
364         (HTDigestParser.__init__): Stores the parsed representation of the file.
365         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
366         password and returns whether the resulting tuple is present in the file.
367         (HTDigestParser.entries): Just returns the parsed representation of the file.
368         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
369         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
370         whole file as invalid and all authentication attempts will fail.
371
372         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
373         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
374         optionally appended with some extra data, generates the expected entries.
375         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
376         authenticate, and tuples not present cannot.
377         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
378         fake_htdigest_file.
379
380         (HTDigestParserTest.test_empty_file):
381         (HTDigestParserTest.test_too_few_colons):
382         (HTDigestParserTest.test_too_many_colons):
383         (HTDigestParserTest.test_invalid_hash):
384         Test various forms of invalid files.
385
386         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
387
388 2011-12-01  Philippe Normand  <pnormand@igalia.com>
389
390         [GTK] Make the new 64-bit Release bot part of the core set
391         https://bugs.webkit.org/show_bug.cgi?id=73570
392
393         Reviewed by Adam Roben.
394
395         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
396         Debug bot which was already part of the core set. The GTK
397         gardeners are willing to actively maintain it.
398
399         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
400         (BuildBot.__init__):
401         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
402         (test_builder_name_regexps):
403
404 2011-12-01  Philippe Normand  <pnormand@igalia.com>
405
406         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
407         https://bugs.webkit.org/show_bug.cgi?id=73547
408
409         Reviewed by Adam Roben.
410
411         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
412         the 32-bit Debug configuration to 64-bit Release. The new slave is
413         a 64-bit machine already. The 32-bit slave will be shut down.
414
415 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
416
417         [GTK] build-jsc should not trigger gtkdoc generation
418         https://bugs.webkit.org/show_bug.cgi?id=73552
419
420         Reviewed by Philippe Normand.
421
422         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
423         that build-jsc does not try to generate gtkdoc.
424
425         * Scripts/webkitdirs.pm:
426         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
427
428 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
429
430         tests_run0.txt gets clobbered when re-running failing tests
431         https://bugs.webkit.org/show_bug.cgi?id=63844
432
433         Reviewed by Dirk Pranke.
434
435         * Scripts/webkitpy/layout_tests/controllers/manager.py:
436         (Manager.results_directory):
437         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
438         (AbstractWorker.__init__):
439         (_ManagerConnection.start_worker):
440         (_InlineManager.start_worker):
441         (_MultiProcessManager.start_worker):
442         (_WorkerConnection.__init__):
443         (_InlineWorkerConnection.__init__):
444         (_MultiProcessWorkerConnection.__init__):
445         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
446         (_TestWorker.__init__):
447         (_TestsMixin.test_cancel):
448         (_TestsMixin.test_done):
449         (_TestsMixin.test_unknown_message):
450         (InterfaceTest.test_managerconnection_is_abstract):
451         (InterfaceTest.test_workerconnection_is_abstract):
452         * Scripts/webkitpy/layout_tests/controllers/worker.py:
453         (Worker.__init__):
454         (Worker.safe_init):
455         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
456         (MainTest.test_retries_directory):
457
458 2011-12-01  Adam Roben  <aroben@apple.com>
459
460         Buildbot fix
461
462         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
463         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
464         it possible for build steps to reference things like the buildbotURL property of the config.
465
466 2011-11-30  Adam Roben  <aroben@apple.com>
467
468         Use curl for downloading builds to test slaves
469
470         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
471         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
472         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
473         overhead (courtesy of the Twisted framework).
474
475         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
476         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
477         This should make the test slaves quite a bit faster, and should ease the CPU load on
478         build.webkit.org a bit.
479
480         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
481
482         Reviewed by Mark Rowe.
483
484         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
485         to Test slaves. It's run just before DownloadBuiltProduct.
486         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
487         download.
488         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
489         FileDownload used to do this for us automatically.
490
491 2011-11-21  Philippe Normand  <pnormand@igalia.com>
492
493         [GTK] enable-webaudio websetting
494         https://bugs.webkit.org/show_bug.cgi?id=69836
495
496         Reviewed by Martin Robinson.
497
498         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
499         (LayoutTestController::overridePreference): Update WebKitGTK
500         enable-webaudio setting when a layout test requests it.
501
502 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
503
504         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
505         https://bugs.webkit.org/show_bug.cgi?id=73079
506
507         The idea is to have performance tests for WebInspector.
508         I was suggested to put these tests into PerformanceTests/inspector.
509         They produce output in a format that is suitable for chromium perf bot drawing scripts.
510
511         I'd like to reuse code for scanning folders for test files.
512         Because of the fact that original test_files.py has common and layout specific parts
513         I decided to extract the generic part and put it into webkitpy/common
514         I think the two packages with name test_files look strange but I have no idea about a better name.
515
516         Reviewed by Dirk Pranke.
517
518         * Scripts/run-inspector-perf-tests.py: Added.
519         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
520         (find):
521         (_normalize):
522         * Scripts/webkitpy/common/find_files_unittest.py: Added.
523         (MockWinFileSystem.join):
524         (MockWinFileSystem):
525         (MockWinFileSystem.normpath):
526         (TestWinNormalize.assert_filesystem_normalizes):
527         (TestWinNormalize.test_mocked_win):
528         (TestWinNormalize):
529         (TestWinNormalize.test_win):
530         * Scripts/webkitpy/layout_tests/port/base.py:
531         (Port.tests):
532         (Port.find_test_files):
533         (Port._driver_class):
534         (is_reference_html_file):
535         (_has_supported_extension):
536         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
537         (PortTest.test_find_no_paths_specified):
538         (PortTest.test_find_one_test):
539         (PortTest.test_find_glob):
540         (PortTest.test_find_with_skipped_directories):
541         (PortTest.test_find_with_skipped_directories_2):
542         (PortTest):
543         (PortTest.test_is_test_file):
544         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
545         (_tests):
546         * Scripts/webkitpy/layout_tests/port/test.py:
547         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
548         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
549         * Scripts/webkitpy/performance_tests/__init__.py: Added.
550         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
551         (PerfTestsRunner.__init__):
552         (PerfTestsRunner._parse_args):
553         (PerfTestsRunner._collect_tests._is_test_file):
554         (PerfTestsRunner._collect_tests):
555         (PerfTestsRunner.run):
556         (PerfTestsRunner._run_tests_set):
557         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
558         (MainTest.TestPort):
559         (MainTest.TestPort.create_driver):
560         (MainTest.TestDriver.run_test):
561         (MainTest.TestDriver):
562         (MainTest.TestDriver.stop):
563         (MainTest.create_runner):
564         (MainTest.run_test):
565         (MainTest.test_run_passing_test):
566         (MainTest.test_run_silent_test):
567         (MainTest.test_run_failed_test):
568         (MainTest.test_run_tonguey_test):
569         (MainTest.test_run_timeout_test):
570         (MainTest.test_run_crash_test):
571         (MainTest.test_run_test_set):
572         (MainTest.test_collect_tests):
573         (MainTest):
574         (MainTest.test_parse_args):
575         * Scripts/webkitpy/tool/commands/rebaseline.py:
576         (OptimizeBaselines.execute):
577         (AnalyzeBaselines.execute):
578
579 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
580
581         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
582         https://bugs.webkit.org/show_bug.cgi?id=70838
583
584         Reviewed by James Robinson.
585
586         * DumpRenderTree/chromium/TestShell.cpp:
587         (TestShell::resetWebSettings):
588         * DumpRenderTree/chromium/TestShell.h:
589         (TestShell::threadedCompositingEnabled):
590         * DumpRenderTree/chromium/WebPreferences.cpp:
591         (WebPreferences::reset):
592         (WebPreferences::applyTo):
593         * DumpRenderTree/chromium/WebPreferences.h:
594         * DumpRenderTree/chromium/WebViewHost.cpp:
595         (WebViewHost::WebViewHost):
596         (WebViewHost::~WebViewHost):
597
598 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
599
600         AX: Nodes are reporting that focus can be set when they really can't
601         https://bugs.webkit.org/show_bug.cgi?id=72791
602
603         Reviewed by Beth Dakin.
604
605         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
606         (AccessibilityUIElement::isFocusable):
607         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
608         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
609         (WTR::AccessibilityUIElement::isFocusable):
610
611 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
612
613         Moved myself to the reviewers list.
614
615         * Scripts/webkitpy/common/config/committers.py:
616
617 2011-11-30  David Levin  <levin@chromium.org>
618
619         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
620         https://bugs.webkit.org/show_bug.cgi?id=73415
621
622         Reviewed by Darin Fisher.
623
624         * DumpRenderTree/chromium/WebViewHost.cpp:
625         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
626         it being moved to a new interface and having the parameter removed.
627         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
628
629 2011-11-30  Adam Roben  <aroben@apple.com>
630
631         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
632
633         This will make it a lot easier to investigate build failures on the bots.
634
635         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
636
637         Reviewed by Eric Seidel.
638
639         * Scripts/webkitpy/common/system/executive_mock.py:
640         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
641         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
642         seen in practice.
643
644         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
645         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
646         The Printer was modifying the root logger in way that would cause my new tests in
647         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
648         seem important to the functioning of this test, and passing False makes Printer not modify
649         the root logger.
650
651         * Scripts/webkitpy/layout_tests/port/webkit.py:
652         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
653         up when --verbose is passed but not otherwise.
654         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
655         output at the ERROR level so it will always show up.
656
657         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
658         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
659         cases. Test that the build scripts' output is logged when --verbose is passed or the build
660         fails.
661
662 2011-11-30  Adam Roben  <aroben@apple.com>
663
664         Add a way to set OutputCapture's log level
665
666         This will be used by some unit tests I'm planning to add.
667
668         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
669
670         Reviewed by Eric Seidel.
671
672         * Scripts/webkitpy/common/system/outputcapture.py:
673         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
674         level we ever used before this patch.
675         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
676         being tested uses. Sets the log level for any current or future logging handlers.
677         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
678
679         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
680         (OutputCaptureTest.setUp): Create an OutputCapture to test.
681         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
682         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
683         was logged.
684         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
685         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
686         level.
687
688 2011-11-29  Beth Dakin  <bdakin@apple.com>
689
690         https://bugs.webkit.org/show_bug.cgi?id=72751
691         WebKit2.MouseMoveAfterCrash API test is failing 
692
693         Reviewed by Sam Weinig.
694
695         Like DumpRenderTree, the NSWindow should act as an active window.
696         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
697         (-[ActiveOffscreenWindow isKeyWindow]):
698         (TestWebKitAPI::PlatformWebView::PlatformWebView):
699
700 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
701
702         Add step to update gtk dependencies to the buildbot
703         https://bugs.webkit.org/show_bug.cgi?id=73455
704
705         Reviewed by Martin Robinson.
706
707         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
708
709 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
710
711         [Qt] Add a fullscreen option to MiniBrowser.
712         https://bugs.webkit.org/show_bug.cgi?id=73445
713
714         Reviewed by Noam Rosenthal.
715
716         This bypasses the compositor on the N9 to increase performances
717         and remove the huge useless gray bar part of the window frame
718         at the bottom.
719
720         * MiniBrowser/qt/BrowserWindow.cpp:
721         (BrowserWindow::BrowserWindow):
722         * MiniBrowser/qt/MiniBrowserApplication.cpp:
723         (printHelp):
724         (MiniBrowserApplication::handleUserOptions):
725         * MiniBrowser/qt/MiniBrowserApplication.h:
726         (WindowOptions::setStartFullScreen):
727         (WindowOptions::startFullScreen):
728
729 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
730
731         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
732         https://bugs.webkit.org/show_bug.cgi?id=73425
733
734         Reviewed by Gustavo Noronha Silva.
735
736         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
737         ensure that the jhbuild root is up-to-date. Currently the only module is
738         the font module.
739
740         * Scripts/update-webkitgtk-libs: Added.
741         * gtk/common.py: Added a helper to get the number of CPUs.
742         * gtk/jhbuild.modules: Added.
743         * gtk/jhbuildrc: Added.
744
745 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
746
747         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
748
749         Reviewed by Csaba Osztrogonác.
750
751         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
752         instead of one that pulls in JavaScriptCore headers.
753         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
754         with load(javascriptcore).
755
756 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
757
758         Unreviewed, rolling out r101440 and r101442.
759         http://trac.webkit.org/changeset/101440
760         http://trac.webkit.org/changeset/101442
761         https://bugs.webkit.org/show_bug.cgi?id=73429
762
763         multiple crashes on layout tests (Requested by hayato on
764         #webkit).
765
766         * DumpRenderTree/chromium/TestShell.cpp:
767         (TestShell::resetWebSettings):
768         * DumpRenderTree/chromium/TestShell.h:
769         * DumpRenderTree/chromium/WebPreferences.cpp:
770         (WebPreferences::reset):
771         (WebPreferences::applyTo):
772         * DumpRenderTree/chromium/WebPreferences.h:
773         * DumpRenderTree/chromium/WebViewHost.cpp:
774         (WebViewHost::WebViewHost):
775         (WebViewHost::~WebViewHost):
776
777 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
778
779         [Chromium] Fix broken DRT build for Aura Linux
780         https://bugs.webkit.org/show_bug.cgi?id=72667
781
782         Reviewed by Tony Chang.
783
784         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
785
786         The following changes have been made:
787
788           1. Renamed TestShellAndroid to TestShellLinux.
789           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
790           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
791
792         * DumpRenderTree/DumpRenderTree.gypi:
793         * DumpRenderTree/chromium/EventSender.cpp:
794         (EventSender::keyDown):
795         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
796         * DumpRenderTree/chromium/TestShellGtk.cpp:
797         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
798         (AlarmHandler):
799         (TestShell::waitTestFinished):
800         (setupFontconfig):
801         (platformInit):
802         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
803         (checkLayoutTestSystemDependencies):
804         (openStartupDialog):
805
806 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
807
808         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
809         https://bugs.webkit.org/show_bug.cgi?id=73328
810
811         Reviewed by Kent Tamura.
812
813         * DumpRenderTree/chromium/LayoutTestController.cpp:
814         (LayoutTestController::enableFixedLayoutMode):
815         (LayoutTestController::setFixedLayoutSize):
816
817 2011-11-29  Hayato Ito  <hayato@chromium.org>
818
819         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
820         https://bugs.webkit.org/show_bug.cgi?id=73381
821
822         Reviewed by Ryosuke Niwa.
823
824         This is a quick fix for the breakage of tests on non-chromium port.
825         We should implement diff_image later on non-chromium ports.
826
827         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
828         (write_test_result):
829
830 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
831
832         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
833         https://bugs.webkit.org/show_bug.cgi?id=72489
834
835         Reviewed by Eric Seidel.
836
837         Before the this fix always added "qt" option for the option list
838         * Scripts/run-webkit-tests:
839         * Scripts/webkitpy/layout_tests/port/qt.py:
840
841 2011-11-29  David Levin  <levin@chromium.org>
842
843         Add a way to revert a variable to its previous value after leaving a scope.
844         https://bugs.webkit.org/show_bug.cgi?id=73371
845
846         Reviewed by Adam Barth.
847
848         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
849         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
851         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
852         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
853         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
854
855 2011-11-28  Kentaro Hara  <haraken@chromium.org>
856
857         Implement [Supplemental] IDL and support it in run-bindings-tests
858         https://bugs.webkit.org/show_bug.cgi?id=73162
859
860         Reviewed by Adam Barth.
861
862         run-bindings-tests supports the [Supplemental] IDL in the following way.
863             (1) It creates a file |x| listing all IDL files.
864             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
865             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
866                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
867                 including all attributes in IDL files that are supplementing the IDL file |z|.
868
869         * Scripts/run-bindings-tests:
870         (generate_from_idl):
871         (generate_supplemental_dependency):
872         (detect_changes):
873         (run_tests):
874         (main):
875
876 2011-11-18  Nat Duca  <nduca@chromium.org>
877
878         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
879         https://bugs.webkit.org/show_bug.cgi?id=70838
880
881         Reviewed by James Robinson.
882
883         * DumpRenderTree/chromium/TestShell.cpp:
884         (TestShell::resetWebSettings):
885         * DumpRenderTree/chromium/TestShell.h:
886         (TestShell::threadedCompositingEnabled):
887         * DumpRenderTree/chromium/WebPreferences.cpp:
888         (WebPreferences::reset):
889         (WebPreferences::applyTo):
890         * DumpRenderTree/chromium/WebPreferences.h:
891         * DumpRenderTree/chromium/WebViewHost.cpp:
892         (WebViewHost::WebViewHost):
893         (WebViewHost::~WebViewHost):
894
895 2011-11-29  Ojan Vafai  <ojan@chromium.org>
896
897         List of builders in the flakiness dashboard is out of date
898         https://bugs.webkit.org/show_bug.cgi?id=73347
899
900         Reviewed by Adam Barth.
901
902         The chromium gpu bots no longer run layout tests, so kill that
903         group entirely.
904
905         * TestResultServer/static-dashboards/builders.js:
906         * TestResultServer/static-dashboards/dashboard_base.js:
907
908 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
909
910         [Qt] Don't hard-code the list of WebKit2 generated sources
911
912         The generated sources are... wait for it... generated. So
913         use the generator itself to figure out which sources we need
914         to compile.
915
916         Reviewed by Simon Hausmann.
917
918         * qmake/mkspecs/features/default_post.prf:
919
920 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
921
922         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
923         https://bugs.webkit.org/show_bug.cgi?id=73216
924
925         Reviewed by Philippe Normand.
926
927         Add a script that tries to sniff out 'make dist' problems without running
928         'make dist.' 'make distcheck' takes a very long time to run and this should
929         reduce the amount of times it needs to be run consecutively.
930
931         * gtk/common.py:
932         (get_build_path.is_valid_build_directory): Guess the source directory
933         by the existence of the GNUmakefile instead of the .libs directory. This
934         allows one to run the script after running autogen.sh but before fully
935         building.
936         * gtk/find-make-dist-errors: Added.
937
938 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
939
940         [Qt] Remove use of internal headers in the MiniBrowser
941
942         Reviewed by Simon Hausmann.
943
944         * MiniBrowser/qt/MiniBrowser.pro:
945
946 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
947
948         [Qt] Fix debug-shlib build without webkit2
949
950         Reviewed by Tor Arne Vestbø.
951
952         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
953
954 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
955
956         [Qt][WK2] Unreviewed buildfix after r101307.
957
958         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
959
960 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
961
962         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
963         https://bugs.webkit.org/show_bug.cgi?id=72848
964
965         Add option to build-webkit.
966
967         Reviewed by Dimitri Glazkov.
968
969         * Scripts/build-webkit:
970
971 2011-11-28  Ojan Vafai  <ojan@chromium.org>
972
973         gtest normalization in the test results server is sometimes wrong
974         https://bugs.webkit.org/show_bug.cgi?id=73262
975
976         Reviewed by Tony Chang.
977
978         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
979         entries in the incremental JSON, one of the entries will have the correct data
980         from the run and the other will have dummy no-data values. Make sure to
981         always pick the one with real data.
982
983         * TestResultServer/model/jsonresults.py:
984         (JsonResults._remove_gtest_modifiers):
985         * TestResultServer/model/jsonresults_unittest.py:
986         (JsonResultsTest.test_remove_gtest_modifiers):
987
988 2011-11-28  Ojan Vafai  <ojan@chromium.org>
989
990         Some of the results.json files have results/times entries at the directory level
991         https://bugs.webkit.org/show_bug.cgi?id=73261
992
993         Reviewed by Tony Chang.
994
995         This is just a bug that got introduced in a temporary push of the results server.
996         This patch repairs the broken files. After all the bots have cycled, we can simplify
997         this code to just assert that results/times are not at the directory level.
998
999         Also, when catching exceptions, log the full stacktrace.
1000
1001         * TestResultServer/model/jsonresults.py:
1002         (_is_directory):
1003         (JsonResults._load_json):
1004         (JsonResults._merge_tests):
1005         (JsonResults.merge):
1006         * TestResultServer/model/jsonresults_unittest.py:
1007         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
1008
1009 2011-11-28  Tony Chang  <tony@chromium.org>
1010
1011         ews bots should pass --force to update-webkit-chromium
1012         https://bugs.webkit.org/show_bug.cgi?id=73230
1013
1014         Reviewed by Adam Barth.
1015
1016         This makes it less likely for gclient changes to break the bots (e.g.,
1017         if a DEPS repository moves or is switched to a branch).
1018
1019         Also pass --force when using |build-webkit --update-chromium| since this
1020         appears to only be used by the bots.
1021
1022         Take 2: Add Options.non_interactive to update.py's options() method.
1023
1024         * Scripts/update-webkit:
1025         * Scripts/webkitdirs.pm:
1026         (determineIsChromium): Add --force-update to update-webkit --chromium.
1027         (forceChromiumUpdate):
1028         (buildChromium): Pass --force to update-webkit-chromium.
1029         * Scripts/webkitpy/tool/steps/update.py:
1030         (Update.run): Add --force-update if non-interactive (i.e., bots).
1031         * Scripts/webkitpy/tool/steps/update_unittest.py:
1032
1033 2011-11-28  Tony Chang  <tony@chromium.org>
1034
1035         Revert r101279, broke the ews and cq bots.
1036
1037         * Scripts/update-webkit:
1038         * Scripts/webkitdirs.pm:
1039         (determineIsChromium):
1040         (buildChromium):
1041         * Scripts/webkitpy/common/config/ports.py:
1042         (WebKitPort.update_webkit_command):
1043         (ChromiumPort.update_webkit_command):
1044         * Scripts/webkitpy/common/config/ports_mock.py:
1045         (MockPort.update_webkit_command):
1046         * Scripts/webkitpy/tool/steps/update.py:
1047         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
1048
1049 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1050
1051         testlistjson on the test results server doesn't understand hierarchical results format
1052         https://bugs.webkit.org/show_bug.cgi?id=73246
1053
1054         Reviewed by Tony Chang.
1055
1056         * TestResultServer/model/jsonresults.py:
1057         (JsonResults._delete_results_and_times):
1058         Instead of just getting the top-level keys, we now walk the tests tree and
1059         delete the results and times values.
1060
1061         * TestResultServer/model/jsonresults_unittest.py:
1062         Simplify the test harness to take in the same JSON format for the tests
1063         that the actual results.json uses instead of something very similar but
1064         needlessly different. This also allows for testing the broken case of
1065         results and times values being at non-leaf level.
1066
1067 2011-11-28  Tony Chang  <tony@chromium.org>
1068
1069         ews bots should pass --force to update-webkit-chromium
1070         https://bugs.webkit.org/show_bug.cgi?id=73230
1071
1072         Reviewed by Adam Barth.
1073
1074         This makes it less likely for gclient changes to break the bots (e.g.,
1075         if a DEPS repository moves or is switched to a branch).
1076
1077         Also pass --force when using |build-webkit --update-chromium| since this
1078         appears to only be used by the bots.
1079
1080         * Scripts/update-webkit:
1081         * Scripts/webkitdirs.pm:
1082         (determineIsChromium): Add --force-update to update-webkit --chromium.
1083         (forceChromiumUpdate):
1084         (buildChromium): Pass --force to update-webkit-chromium.
1085         * Scripts/webkitpy/tool/steps/update.py:
1086         (Update.run): Add --force-update if non-interactive (i.e., bots).
1087         * Scripts/webkitpy/tool/steps/update_unittest.py:
1088
1089 2011-11-28  Michael Saboff  <msaboff@apple.com>
1090
1091         Fixed help message for --exclude-kraken to say that
1092         it excludes Kraken and not SunSpider.
1093
1094         Rubber-stamped by Filip Pizlo.
1095
1096         * Scripts/bencher:
1097
1098 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1099
1100         Unreviewed, rolling out r101273.
1101         http://trac.webkit.org/changeset/101273
1102         https://bugs.webkit.org/show_bug.cgi?id=73244
1103
1104         multiple test failures and timeouts (Requested by tony^work on
1105         #webkit).
1106
1107         * DumpRenderTree/DumpRenderTree.gypi:
1108         * DumpRenderTree/chromium/EventSender.cpp:
1109         (EventSender::keyDown):
1110         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1111         (AlarmHandler):
1112         (TestShell::waitTestFinished):
1113         (platformInit):
1114         (openStartupDialog):
1115         (checkLayoutTestSystemDependencies):
1116         * DumpRenderTree/chromium/TestShellGtk.cpp:
1117         (AlarmHandler):
1118         (setupFontconfig):
1119         (TestShell::waitTestFinished):
1120         (platformInit):
1121         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
1122         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1123
1124 2011-11-28  John Yani  <vanuan@gmail.com>
1125
1126         new-run-webkit-tests is locale dependent
1127         https://bugs.webkit.org/show_bug.cgi?id=68691
1128
1129         Reviewed and modified by Eric Seidel.
1130
1131         This is a simpler version of John's patch which I'm landing.
1132         This just engages the hacks from the Host constructor on a global
1133         basis.
1134
1135         * Scripts/webkitpy/common/host.py:
1136         (Host.__init__):
1137         (Host._engage_awesome_locale_hacks):
1138
1139 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
1140
1141         [Chromium] Fix broken DRT build for Aura Linux
1142         https://bugs.webkit.org/show_bug.cgi?id=72667
1143
1144         Reviewed by Tony Chang.
1145
1146         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
1147
1148         The following changes have been made:
1149
1150           1. Renamed TestShellAndroid to TestShellLinux.
1151           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
1152           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
1153
1154         * DumpRenderTree/DumpRenderTree.gypi:
1155         * DumpRenderTree/chromium/EventSender.cpp:
1156         (EventSender::keyDown):
1157         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1158         * DumpRenderTree/chromium/TestShellGtk.cpp:
1159         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1160         (AlarmHandler):
1161         (TestShell::waitTestFinished):
1162         (setupFontconfig):
1163         (platformInit):
1164         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
1165         (checkLayoutTestSystemDependencies):
1166         (openStartupDialog):
1167
1168 2011-11-28  Eric Seidel  <eric@webkit.org>
1169
1170         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
1171         https://bugs.webkit.org/show_bug.cgi?id=71983
1172
1173         Reviewed by Adam Barth.
1174
1175         We'll add more code to Environment overtime,
1176         allowing us to mock out more of our direct interactions with os.environ.
1177
1178         This patch also makes run_command print the passed in environment.
1179
1180         * Scripts/webkitpy/common/host_mock.py:
1181         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1182         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1183         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1184         * Scripts/webkitpy/common/system/executive.py:
1185         * Scripts/webkitpy/common/system/executive_mock.py:
1186         * Scripts/webkitpy/layout_tests/port/webkit.py:
1187         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1188         * Scripts/webkitpy/tool/commands/download_unittest.py:
1189         * Scripts/webkitpy/tool/steps/build.py:
1190
1191 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
1192
1193         [Qt] Build system fixes against V8.
1194
1195         Reviewed by Tor Arne Vestbø.
1196
1197         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
1198         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
1199         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
1200
1201 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1202
1203         Make sure the useFixedLayout feature is consistently handled
1204         https://bugs.webkit.org/show_bug.cgi?id=73212
1205
1206         Reviewed by Simon Hausmann.
1207
1208         The web page parameters are set to our Qt defaults and are now altered
1209         in the WebKitTestRunner.
1210
1211         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1212         (WTR::WrapperWindow::WrapperWindow):
1213
1214 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
1215
1216         [Qt] WTF should be built as separate static library
1217         https://bugs.webkit.org/show_bug.cgi?id=73201
1218
1219         Reviewed by Tor Arne Vestbø.
1220
1221         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
1222         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
1223         thus wtf dependency.
1224         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
1225         * WebKitTestRunner/Target.pri: Ditto.
1226         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
1227         consider wtf, too.
1228         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
1229         moved into wtf.prf.
1230         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
1231         link in libwtf.
1232         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
1233
1234 2011-11-28  Kentaro Hara  <haraken@chromium.org>
1235
1236         run-bindings-tests shows diff error for a newly added binding test
1237         https://bugs.webkit.org/show_bug.cgi?id=73179
1238
1239         Reviewed by Adam Barth.
1240
1241         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
1242         run-bindings-tests just shows diff error because reference files
1243         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
1244
1245             FAIL: (V8) V8TestSupplemental.h
1246             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
1247
1248         Instead, this patch treats a non-existent reference file as an empty file and
1249         shows the result of the newly added binding test, like this:
1250
1251             FAIL: (V8) V8TestSupplemental.h
1252             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
1253             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
1254             @@ -0,0 +1,84 @@
1255             +/*
1256             +    This file is part of the WebKit open source project.
1257             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
1258             +
1259             (omitted)
1260
1261         * Scripts/run-bindings-tests:
1262         (detect_changes): Just added an -N option to the diff command.
1263
1264 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
1265
1266         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
1267         https://bugs.webkit.org/show_bug.cgi?id=73165
1268
1269         Reviewed by Philippe Normand.
1270
1271         Fix some syntax errors in this script and remove an unused variable.
1272
1273         * gtk/generate-gtkdoc:
1274         (get_webkit2_options.src_path): 
1275         (get_webkit2_options):
1276         (get_webkit1_options.src_path):
1277
1278 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
1279
1280         [wx] Unreviewed build fix. Enable the inspector.
1281         
1282         * waf/build/settings.py:
1283
1284 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
1285
1286         Try to fix the build after r101174.
1287
1288         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
1289
1290 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
1291
1292         [GTK] Integrate build-gtkdoc into build-webkit and make
1293         https://bugs.webkit.org/show_bug.cgi?id=72626
1294
1295         Reviewed by Philippe Normand.
1296
1297         * GNUmakefile.am: Added support for new scripts and "make docs".
1298         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
1299         (buildAutotoolsProject):
1300         * gtk/generate-gtkdoc: Added.
1301         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
1302
1303 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1304
1305         [Qt] Add support for using OWRT with Qt5
1306         https://bugs.webkit.org/show_bug.cgi?id=72947
1307
1308         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
1309
1310         Reviewed by Csaba Osztrogonác.
1311
1312         * Scripts/old-run-webkit-tests:
1313
1314 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
1315
1316         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
1317         https://bugs.webkit.org/show_bug.cgi?id=73126
1318
1319         No need to have a separate client call for this. The front-end can store messages
1320         which arrive before front-end loaded and dispatch them later. This happens in layout
1321         tests only by the way as all other messages should be initiated by the front-end code.
1322
1323         Reviewed by Pavel Feldman.
1324
1325         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1326         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1327         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1328         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1329
1330 2011-11-24  Kentaro Hara  <haraken@chromium.org>
1331
1332         Replace subprocess.call() with subprocess.Popen()
1333         https://bugs.webkit.org/show_bug.cgi?id=73105
1334
1335         Reviewed by Adam Barth.
1336
1337         Currently, the stdout and stderr of the child processes of run-bindings-tests
1338         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
1339         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
1340         between a parent process and a child process. This patch replaces subprocess.call() with
1341         subprocess.Popen() and synchronizes the stdout and stderr between them.
1342         This patch also makes output messages of run-bindings-tests more readable.
1343
1344         With this patch, the output messages of run-bindings-tests look like as follows:
1345
1346             PASS: (CPP) WebDOMTestObj.h
1347             PASS: (CPP) WebDOMTestObj.cpp
1348             FAIL: (CPP) WebDOMTestInterface.h
1349             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
1350             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
1351             @@ -23,7 +23,7 @@
1352              #ifndef WebDOMTestInterface_h
1353              #define WebDOMTestInterface_h
1354
1355             -#if ENABLE(Condition1) || ENABLE(Condition2)
1356             +#if ENABLE(Condition1) || ENABLE(Condition3)
1357
1358              #include <WebDOMObject.h>
1359              #include <WebDOMString.h>
1360              @@ -53,5 +53,5 @@
1361              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
1362
1363              #endif
1364             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
1365             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
1366             PASS: (CPP) WebDOMFloat64Array.cpp
1367             PASS: (CPP) WebDOMFloat64Array.h
1368
1369             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
1370
1371         * Scripts/run-bindings-tests:
1372         (generate_from_idl):
1373         (detect_changes):
1374         (run_tests):
1375         (main):
1376
1377 2011-11-24  Kentaro Hara  <haraken@chromium.org>
1378
1379         Fix the current working directory of run-bindings-tests
1380         https://bugs.webkit.org/show_bug.cgi?id=73106
1381
1382         Reviewed by Adam Barth.
1383
1384         Currently, run-bindings-tests outputs the following error
1385         (although it outputs "all tests passed!" in the end):
1386
1387             Testing the ObjC generator on TestObj.idl
1388             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
1389             gcc: warning: '-x objective-c' after last input file has no effect
1390             gcc: no input files
1391
1392         This is because CodeGeneratorObjC.pm assumes that the current working directory
1393         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
1394         Thus, this patch changes it to WebKit/Source/.
1395
1396         * Scripts/run-bindings-tests:
1397         (generate_from_idl):
1398         (main):
1399
1400 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1401
1402         [Qt] Get rid of the buildDirForSource() function in the build system
1403
1404         At some point the plan was to allow for running qmake on sub-trees
1405         of the sources, into the top level build directory, but this is no
1406         longer possible, so no reason to keep the convenience function around.
1407
1408         Reviewed by Simon Hausmann.
1409
1410         * WebKitTestRunner/DerivedSources.pri:
1411         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1412         * qmake/mkspecs/features/default_post.prf:
1413         * qmake/mkspecs/features/default_pre.prf:
1414         * qmake/mkspecs/features/functions.prf:
1415         * qmake/mkspecs/features/javascriptcore.prf:
1416         * qmake/mkspecs/features/webcore.prf:
1417         * qmake/mkspecs/features/webkit2.prf:
1418
1419 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1420
1421         Unreviewed, rolling out r101107.
1422         http://trac.webkit.org/changeset/101107
1423         https://bugs.webkit.org/show_bug.cgi?id=73062
1424
1425         Breaks the commit-queue (Requested by abarth on #webkit).
1426
1427         * Scripts/webkitpy/common/host.py:
1428         (Host._engage_awesome_windows_hacks):
1429         * Scripts/webkitpy/common/host_mock.py:
1430         (MockHost.__init__):
1431         * Scripts/webkitpy/common/system/environment.py: Removed.
1432         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
1433         * Scripts/webkitpy/common/system/executive.py:
1434         (Executive._run_command_with_teed_output):
1435         (Executive.run_and_throw_if_fail):
1436         * Scripts/webkitpy/common/system/executive_mock.py:
1437         (MockExecutive.run_and_throw_if_fail):
1438         (MockExecutive.run_command):
1439         * Scripts/webkitpy/layout_tests/port/webkit.py:
1440         (WebKitPort._driver_build_script_name):
1441         (WebKitPort._run_script):
1442         (WebKitPort._build_driver):
1443         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1444         (test_build_driver):
1445         * Scripts/webkitpy/tool/commands/download_unittest.py:
1446         * Scripts/webkitpy/tool/steps/build.py:
1447         (Build.build):
1448
1449 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1450
1451         Unreviewed, rolling out r101110.
1452         http://trac.webkit.org/changeset/101110
1453         https://bugs.webkit.org/show_bug.cgi?id=73057
1454
1455         The bots have now cycled and this patch is no longer needed.
1456
1457         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1458         (Manager._upload_json_files):
1459
1460 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1461
1462         Temporarily save the incremental results json in order to identify bug
1463         https://bugs.webkit.org/show_bug.cgi?id=73057
1464
1465         Reviewed by Dean Jackson.
1466
1467         The test results server needed to be rolled back from tip of tree
1468         due to a JSON merging bug. It's hard to identify what the bug is without
1469         the raw data.
1470
1471         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1472         (Manager._upload_json_files):
1473
1474 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1475
1476         Merging two version 4 results hits an error in the test results server
1477         https://bugs.webkit.org/show_bug.cgi?id=73042
1478
1479         Reviewed by Adam Barth.
1480
1481         The old code assumed that if the aggregate results value was not a leaf
1482         value that the incremental results would exist, which is just totally
1483         wrong. Added a test for that case as well.
1484
1485         * TestResultServer/model/jsonresults.py:
1486         (JsonResults._merge_tests):
1487         * TestResultServer/model/jsonresults_unittest.py:
1488         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
1489         (JsonResultsTest.test_merge_build_directory_hierarchy):
1490
1491 2011-11-23  Eric Seidel  <eric@webkit.org>
1492
1493         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
1494         https://bugs.webkit.org/show_bug.cgi?id=71983
1495
1496         Reviewed by Adam Barth.
1497
1498         We'll add more code to Environment overtime,
1499         allowing us to mock out more of our direct interactions with os.environ.
1500
1501         This patch also makes run_command print the passed in environment.
1502
1503         * Scripts/webkitpy/common/host_mock.py:
1504         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1505         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1506         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1507         * Scripts/webkitpy/common/system/executive.py:
1508         * Scripts/webkitpy/common/system/executive_mock.py:
1509         * Scripts/webkitpy/layout_tests/port/webkit.py:
1510         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1511         * Scripts/webkitpy/tool/commands/download_unittest.py:
1512         * Scripts/webkitpy/tool/steps/build.py:
1513
1514 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1515
1516         [Qt] Re-generate QtWebKit API forwarding headers when API changes
1517
1518         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
1519         so we need sync.profile to live in the same directory as the project file
1520         that will be touched when adding/removing API (api.pri in our case).
1521
1522         Since the WebKit2 APIs live in a separate static library, we have to
1523         add the project file for WebKit2 as a dependency of the api.pri file
1524         as well, so that any changes to the WebKit2 API will still trigger a
1525         run of qmake (and then syncqt).
1526
1527         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
1528         that the forwarding headers are still generated in the root build dir,
1529         not in the Source dir along with the internal forwarding headers.
1530
1531         Reviewed by Andreas Kling.
1532
1533         * qmake/mkspecs/features/default_pre.prf:
1534         * qmake/mkspecs/features/functions.prf:
1535
1536 2011-11-23  Johnny Ding  <jnd@chromium.org>
1537
1538         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
1539         https://bugs.webkit.org/show_bug.cgi?id=72950
1540
1541         Reviewed by Tony Chang.
1542
1543         * DumpRenderTree/chromium/LayoutTestController.cpp:
1544         (LayoutTestController::queueLoadHTMLString):
1545
1546 2011-11-23  Adam Barth  <abarth@webkit.org>
1547
1548         garden-o-matic should display a message if it can't find results to display
1549         https://bugs.webkit.org/show_bug.cgi?id=72991
1550
1551         Reviewed by Dimitri Glazkov.
1552
1553         Not all failures (e.g., TIMEOUT) have results that we can display.
1554         This patch adds a short message so that the user can see that we're
1555         done trying to load the results.
1556
1557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1560
1561 2011-11-23  Adam Barth  <abarth@webkit.org>
1562
1563         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
1564         https://bugs.webkit.org/show_bug.cgi?id=72992
1565
1566         Reviewed by Dimitri Glazkov.
1567
1568         This patch also prepares us to list other sorts of failures, like
1569         performance and unit test.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1575
1576 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
1577
1578         Add new Chromium tests to the flakiness dashboard
1579         https://bugs.webkit.org/show_bug.cgi?id=72997
1580
1581         Reviewed by Ojan Vafai.
1582
1583         * TestResultServer/static-dashboards/dashboard_base.js:
1584         ():
1585
1586 2011-11-23  Adam Barth  <abarth@webkit.org>
1587
1588         garden-o-matic should support AUDIO failures
1589         https://bugs.webkit.org/show_bug.cgi?id=69477
1590
1591         Reviewed by Dimitri Glazkov.
1592
1593         This is a first iteration at supporting AUDIO failures in
1594         garden-o-matic.  We'll probably need to iterate a bit when we have a
1595         real audio failure in the tree to play with.  For example, we'll
1596         probably want to add and <audio> element to the "Examine" view to hear
1597         the differences, but that all can be done in a subsequent patch.
1598
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1600
1601 2011-11-23  Scott Graham  <scottmg@chromium.org>
1602
1603         Adding gamepad support
1604         https://bugs.webkit.org/show_bug.cgi?id=69451
1605
1606         Reviewed by Darin Fisher.
1607
1608         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
1609         gamepad data that will be retrieved when JS code pulls via API access.
1610
1611         * DumpRenderTree/DumpRenderTree.gypi:
1612         * DumpRenderTree/chromium/GamepadController.cpp: Added.
1613         (GamepadController::GamepadController):
1614         (GamepadController::bindToJavascript):
1615         (GamepadController::reset):
1616         (GamepadController::connect):
1617         (GamepadController::disconnect):
1618         (GamepadController::setId):
1619         (GamepadController::setButtonCount):
1620         (GamepadController::setButtonData):
1621         (GamepadController::setAxisCount):
1622         (GamepadController::setAxisData):
1623         (GamepadController::fallbackCallback):
1624         * DumpRenderTree/chromium/GamepadController.h: Added.
1625         * DumpRenderTree/chromium/TestShell.cpp:
1626         (TestShell::TestShell):
1627         (TestShell::resetTestController):
1628         (TestShell::bindJSObjectsToWindow):
1629         * DumpRenderTree/chromium/TestShell.h:
1630         (TestShell::gamepadController):
1631
1632 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1633
1634         [CMake] Move the top-level logic to the top-level directory.
1635         https://bugs.webkit.org/show_bug.cgi?id=72685
1636
1637         Reviewed by Brent Fulgham.
1638
1639         * CMakeLists.txt: Added.
1640         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
1641         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
1642         * Scripts/webkitdirs.pm:
1643         (generateBuildSystemFromCMakeProject):
1644         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
1645
1646 2011-11-17  Vincent Scheib  <scheib@chromium.org>
1647
1648         Pointer Lock: Initial Tests for navigator.webkitPonter
1649         https://bugs.webkit.org/show_bug.cgi?id=72659
1650
1651         Reviewed by Darin Fisher.
1652
1653         * DumpRenderTree/chromium/TestShell.cpp:
1654         (TestShell::TestShell):
1655             Enabling PointerLock in TestShell
1656
1657 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
1658
1659         Update flakiness dashboard for new Chromium builders and tests
1660         https://bugs.webkit.org/show_bug.cgi?id=72931
1661
1662         Reviewed by Ojan Vafai.
1663
1664         * TestResultServer/static-dashboards/builders.js:
1665         * TestResultServer/static-dashboards/dashboard_base.js:
1666
1667 2011-11-22  Adam Roben  <aroben@apple.com>
1668
1669         Remove some debugging code I accidentally left in r101005
1670
1671         * Scripts/prepare-ChangeLog:
1672         (get_function_line_ranges_for_python):
1673
1674 2011-11-22  Adam Roben  <aroben@apple.com>
1675
1676         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
1677
1678         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
1679         classes/methods in Python source files
1680
1681         Reviewed by Dan Bates.
1682
1683         * Scripts/prepare-ChangeLog:
1684         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
1685         or that use python as their interpreter. Modified the code that extracts the interpreter to
1686         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
1687         scripts.
1688         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
1689         for class/def lines and generate ranges based on them.
1690
1691 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
1692
1693         [GTK] Enable WebSocket hybi tests
1694         https://bugs.webkit.org/show_bug.cgi?id=72870
1695
1696         Reviewed by Xan Lopez.
1697
1698         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1699         (resetDefaultsToConsistentValues):
1700         Reset the setting value to the default value (true).
1701         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1702         (LayoutTestController::overridePreference):
1703         Change the setting value through a function in DumpRenderTreeSupportGtk.
1704
1705 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
1706
1707         ChangeLogEntry should be able to parse entries with multiple authors
1708         https://bugs.webkit.org/show_bug.cgi?id=72690
1709
1710         Reviewed by Eric Seidel.
1711
1712         Support multi-author change log entries in ChangeLogEntry. Split author names using
1713         the same logic as splitting reviewer names. _authors now stores list of dictionaries
1714         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
1715         accounts because some contributors are never listed in committers.py. 
1716
1717         * Scripts/webkitpy/common/checkout/changelog.py:
1718         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1719         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
1720         throws an exception when the argument is None.
1721
1722 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
1723
1724         [Qt] Speed up debug builds.
1725         https://bugs.webkit.org/show_bug.cgi?id=72882
1726
1727         Reviewed by Tor Arne Vestbø.
1728
1729         Introduce a special type of build that replaces the static jsc/wc/wk2
1730         static libraries with shared libraries, that individually are much faster
1731         to link and don't require relinking into the big library when changing just
1732         one file in one module. It can be enabled with
1733         --qmakearg="CONFIG+=force_static_libs_as_shared"
1734
1735         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
1736         disable symbol visibility, static linkage and enable rpath.
1737         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
1738         we need to link the convenience libraries together or not and renamed linkStaticLibrary
1739         to just linkLibrary (because linkage is not necessarily static).
1740         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
1741         link against jsc/wc/wk2 when linking app code against QtWebKit.
1742         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
1743         function.
1744         * qmake/mkspecs/features/webcore.prf: Ditto.
1745         * qmake/mkspecs/features/webkit2.prf: Ditto.
1746
1747 2011-11-21  Adam Klein  <adamk@chromium.org>
1748
1749         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
1750         https://bugs.webkit.org/show_bug.cgi?id=72898
1751
1752         Reviewed by Ojan Vafai.
1753
1754         Also removed a comment that was going to be more trouble to keep up to
1755         date than seemed worthwhile (the code is now the documentation).
1756
1757         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1758
1759 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1760
1761         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
1762         https://bugs.webkit.org/show_bug.cgi?id=72895
1763
1764         Reviewed by Chris Fleizach.
1765
1766         * DumpRenderTree/chromium/WebViewHost.cpp:
1767         (WebViewHost::postAccessibilityNotification):
1768
1769 2011-11-21  Philippe Normand  <pnormand@igalia.com>
1770
1771         Unreviewed, run-gtk-tests temporary workaround after r98500.
1772
1773         * Scripts/run-gtk-tests: Try to find the build directory like in
1774         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
1775
1776 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1777
1778         [GTK] Add a way to skip unit tests in the bots
1779         https://bugs.webkit.org/show_bug.cgi?id=72879
1780
1781         Reviewed by Philippe Normand.
1782
1783         Rewrite the script in python to make it easier for everybody to
1784         change it and add support for skipping tests.
1785
1786         * Scripts/run-gtk-tests:
1787
1788 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
1789
1790         [EFL] Add more appcache functions to ewk_settings.
1791         https://bugs.webkit.org/show_bug.cgi?id=72143
1792
1793         Reviewed by Kenneth Rohde Christiansen.
1794
1795         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1796         (LayoutTestController::clearAllApplicationCaches):
1797         (LayoutTestController::setAppCacheMaximumSize): Use the right
1798         function, this is not related to the memory cache, but rather to the
1799         appcache.
1800
1801 2011-11-18  Adam Roben  <aroben@apple.com>
1802
1803         Make NRWT consider all lines of output from parse-malloc-history, not just the first
1804
1805         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
1806         found" even when there are more than 1 unique leaks
1807
1808         Reviewed by Darin Adler.
1809
1810         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1811         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
1812         "^" will be considered to match the beginning of any line, not only the beginning of the
1813         string.
1814
1815         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1816         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
1817         fake output and updated expectations to match.
1818
1819 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
1820
1821         [Qt] Clean up MiniBrowser project file after recent changes
1822         https://bugs.webkit.org/show_bug.cgi?id=72869
1823
1824         Reviewed by Simon Hausmann.
1825
1826         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
1827
1828         * MiniBrowser/qt/MiniBrowser.pro:
1829
1830 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1831
1832         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
1833         https://bugs.webkit.org/show_bug.cgi?id=72479
1834
1835         Reviewed by Chris Fleizach.
1836
1837         * DumpRenderTree/AccessibilityUIElement.cpp:
1838         (getIsSelectedOptionActiveCallback):
1839         (AccessibilityUIElement::getJSClass):
1840         * DumpRenderTree/AccessibilityUIElement.h:
1841         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1842         (AccessibilityUIElement::AccessibilityUIElement):
1843         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
1844         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1845         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1846         (AccessibilityUIElement::isSelectedOptionActive):
1847         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1848         (AccessibilityUIElement::isSelectedOptionActive):
1849         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1850         (AccessibilityUIElement::isSelectedOptionActive):
1851
1852 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
1853
1854         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
1855         https://bugs.webkit.org/show_bug.cgi?id=72859
1856
1857         Reviewed by Eric Seidel.
1858         
1859         * Scripts/new-run-webkit-websocketserver:
1860
1861 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
1862
1863         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
1864         https://bugs.webkit.org/show_bug.cgi?id=72655
1865
1866         Reviewed by Hajime Morita.
1867
1868         Fixed the calculation of offset.
1869
1870         * DumpRenderTree/chromium/WebViewHost.cpp:
1871         (WebViewHost::finishLastTextCheck):
1872
1873 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1874
1875         Change the final place where we use version 3 of the results json output
1876         https://bugs.webkit.org/show_bug.cgi?id=72838
1877
1878         Reviewed by Adam Barth.
1879
1880         This converts the json from being a flat map of test name --> results
1881         to being hierarchical by directory. This will make the json files 
1882         considerably smaller.
1883
1884         Also cleaned up some functions that were returning/checking boolean values
1885         that were always True.
1886
1887         * TestResultServer/model/jsonresults.py:
1888         * TestResultServer/model/jsonresults_unittest.py:
1889
1890 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1891
1892         Include the master name when querying the test results server.
1893         This will soon be required since leaving the master name out mean
1894         that multiple files could match the query.
1895
1896         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1897
1898 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1899
1900         Fix jsonp callback code to add the callback if json content
1901         is not jsonp.
1902         * TestResultServer/handlers/testfilehandler.py:
1903
1904 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
1905
1906         Modify dashboard_base.js to optionally accept version 4 results json.
1907
1908         Reviewed by Ojan Vafai.
1909
1910         * TestResultServer/static-dashboards/dashboard_base.js:
1911         (ADD_RESULTS):
1912         (flattenTrie):
1913         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1914         (testFlattenTrie):
1915
1916 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1917
1918         Stop storing results files as jsonp in the test results server
1919         https://bugs.webkit.org/show_bug.cgi?id=72814
1920
1921         Reviewed by Adam Barth.
1922
1923         * TestResultServer/model/jsonresults.py:
1924         * TestResultServer/model/jsonresults_unittest.py:
1925
1926 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1927
1928         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
1929         https://bugs.webkit.org/show_bug.cgi?id=72813
1930
1931         Reviewed by Adam Barth.
1932
1933         Once this lands, we can start storing pure json in the test results server and then
1934         we can delete the code with all the FIXMEs added here.
1935
1936         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1937         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1938         Only add jsonp for full_results.json.
1939         * TestResultServer/model/jsonresults.py:
1940         * TestResultServer/model/jsonresults_unittest.py:
1941         Accept pure json uploads.
1942         * TestResultServer/static-dashboards/dashboard_base.js:
1943         (appendJSONScriptElementFor):
1944         Use the callback parameter so that the server can start returning pure json if it's left out.
1945
1946 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1947
1948         Allow json NRWT downloads to be pure json and not jsonp
1949         https://bugs.webkit.org/show_bug.cgi?id=72809
1950
1951         Reviewed by Adam Barth.
1952
1953         I'm moving the server to storing and serving up raw json instead of jsonp.
1954         You can still get the jsonp by passing a "callback" parameter, but there's no
1955         need for run-webkit-tests to get jsonp when all it wants is the raw json.
1956
1957         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1958         Make the wrapper stripping only happen if the json is actually wrapped.
1959         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1960
1961 2011-11-18  Daniel Bates  <dbates@rim.com>
1962
1963         Add CMake build infrastructure for the BlackBerry port
1964         https://bugs.webkit.org/show_bug.cgi?id=72768
1965
1966         Reviewed by Antonio Gomes.
1967
1968         Add optional --blackberry command line argument to build-webkit to build the
1969         BlackBerry port.
1970
1971         * Scripts/build-webkit:
1972         * Scripts/webkitdirs.pm:
1973         (determineBaseProductDir):
1974         (argumentsForConfiguration):
1975         (builtDylibPathForName):
1976         (determineIsQt):
1977         (isBlackBerry): Added.
1978         (determineIsBlackBerry): Added.
1979         (blackberryTargetArchitecture): Added.
1980         (isAppleWebKit):
1981
1982 2011-11-18  James Robinson  <jamesr@chromium.org>
1983
1984         Unreviewed, rolling out r100835.
1985         http://trac.webkit.org/changeset/100835
1986         https://bugs.webkit.org/show_bug.cgi?id=72778
1987
1988         Broke some page scale tests
1989
1990         * DumpRenderTree/chromium/EventSender.cpp:
1991         (EventSender::scalePageBy):
1992
1993 2011-11-18  Adam Barth  <abarth@webkit.org>
1994
1995         Prepare to move manual-tests out of WebCore
1996         https://bugs.webkit.org/show_bug.cgi?id=72782
1997
1998         Reviewed by Eric Seidel.
1999
2000         Update this file to refer to the new location of ManualTests.
2001
2002         * Scripts/webkitpy/common/config/build.py:
2003
2004 2011-11-18  James Robinson  <jamesr@chromium.org>
2005
2006         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
2007         https://bugs.webkit.org/show_bug.cgi?id=72778
2008
2009         Reviewed by Kenneth Russell.
2010
2011         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
2012
2013         * DumpRenderTree/chromium/EventSender.cpp:
2014         (EventSender::scalePageBy):
2015
2016 2011-11-18  Scott Graham  <scottmg@chromium.org>
2017
2018         IDL changes for gamepad support
2019         https://bugs.webkit.org/show_bug.cgi?id=71753
2020
2021         Reviewed by Adam Barth.
2022
2023         Runtime enable gamepad in chromium test shell.
2024
2025         * DumpRenderTree/chromium/TestShell.cpp:
2026         (TestShell::TestShell):
2027
2028 2011-10-27  Darin Fisher  <darin@chromium.org>
2029
2030         [chromium] Improve fullscreen API
2031         https://bugs.webkit.org/show_bug.cgi?id=70477
2032
2033         Reviewed by Adam Barth.
2034
2035         Implement enter/exitFullScreen.  The implementation is asynchronous,
2036         via postDelayedTask, to simulate how the browser actually behaves.
2037
2038         * DumpRenderTree/chromium/WebViewHost.cpp:
2039         (WebViewHost::enterFullScreen):
2040         (WebViewHost::exitFullScreen):
2041         (WebViewHost::setAddressBarURL):
2042         (WebViewHost::enterFullScreenNow):
2043         (WebViewHost::exitFullScreenNow):
2044         * DumpRenderTree/chromium/WebViewHost.h:
2045
2046 2011-11-18  Adam Roben  <aroben@apple.com>
2047
2048         Ignore an ANGLE leak that is not WebKit's fault
2049
2050         * Scripts/old-run-webkit-tests:
2051         (countAndPrintLeaks):
2052         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2053         (LeakDetector._callstacks_to_exclude_from_leaks):
2054         Added ScanFromString to the call stacks to exclude on all OS versions.
2055
2056 2011-11-18  Adam Roben  <aroben@apple.com>
2057
2058         Ignore another Lion-specific leak that is not WebKit's fault
2059
2060         * Scripts/old-run-webkit-tests:
2061         (countAndPrintLeaks):
2062         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2063         (LeakDetector._callstacks_to_exclude_from_leaks):
2064         Added SecTransformExecute to the call stacks to exclude.
2065
2066 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
2067
2068         [Qt] Enable WebSocket hybi tests
2069         https://bugs.webkit.org/show_bug.cgi?id=72687
2070
2071         Reviewed by Simon Hausmann.
2072
2073         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
2074
2075         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2076         (WebCore::WebPage::resetSettings):
2077         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2078         (LayoutTestController::overridePreference):
2079
2080 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
2081
2082         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
2083         https://bugs.webkit.org/show_bug.cgi?id=72707
2084
2085         Reviewed by Philippe Normand.
2086
2087         Make new-run-webkit-tests use the right path to locate the test
2088         plugin used by WebKitTestRunner.
2089
2090         * Scripts/webkitpy/layout_tests/port/gtk.py:
2091
2092 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
2093
2094         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
2095         https://bugs.webkit.org/show_bug.cgi?id=72697
2096
2097         Reviewed by Kenneth Rohde Christiansen.
2098
2099         * Tools.pro: Make WTR linux only for the moment.
2100         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
2101         * WebKitTestRunner/Target.pri: Ditto.
2102         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
2103         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
2104
2105 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2106
2107         [Qt] Change default size of the MiniBrowser
2108
2109         Reviewed by Simon Hausmann.
2110
2111         As we lay out desktop pages using the width of 980, change our default
2112         size to 980x735 so that we are not scaling down by default.
2113
2114         * MiniBrowser/qt/MiniBrowserApplication.h:
2115         (WindowOptions::WindowOptions):
2116
2117 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2118
2119         [EFL] Clean up the use of DATA_DIR in the buildsystem
2120         https://bugs.webkit.org/show_bug.cgi?id=72681
2121
2122         Reviewed by Daniel Bates.
2123
2124         Instead of adding -DDATA_DIR in all scopes, only define it in
2125         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
2126         it.
2127
2128         We can then define DATA_DIR to the generated theme directory for
2129         EWebLauncher, since it's what we want here.
2130
2131         * CMakeListsEfl.txt:
2132
2133 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2134
2135         [EFL] Move platform includes last in DRT's include directories.
2136         https://bugs.webkit.org/show_bug.cgi?id=72684
2137
2138         Reviewed by Daniel Bates.
2139
2140         This is the first step in fixing the build when a platform include (in
2141         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
2142         is included instead of WebKit's.
2143
2144         * DumpRenderTree/efl/CMakeLists.txt:
2145
2146 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
2147
2148         fuzzy_match doesn't recognize "Dan B" or "hyatt"
2149         https://bugs.webkit.org/show_bug.cgi?id=72636
2150
2151         Reviewed by Eric Seidel.
2152
2153         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
2154         and user names of email addreses such as rniwa in rniwa@webkit.org.
2155
2156         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
2157
2158         * Scripts/webkitpy/common/config/committers.py:
2159         * Scripts/webkitpy/common/config/committers_unittest.py:
2160
2161 2011-11-17  Eric Seidel  <eric@webkit.org>
2162
2163         Remove support for running check-webkit-style w/o a webkit checkout
2164         https://bugs.webkit.org/show_bug.cgi?id=72678
2165
2166         Reviewed by Adam Barth.
2167
2168         After talking to Dave Levin we've decided to remove this
2169         code.  I know of no users of check-webkit-style w/o a webkit checkout
2170         and this needlessly adds complexity.
2171
2172         * Scripts/webkitpy/style/main.py:
2173
2174 2011-11-17  Eric Seidel  <eric@webkit.org>
2175
2176         Remove more direct uses of os.path
2177         https://bugs.webkit.org/show_bug.cgi?id=72677
2178
2179         Reviewed by Adam Barth.
2180
2181         Remove more uses of os.path, including refactoring
2182         CommitterValidator to use a Host object instead of
2183         manual hacks to emulate what SCM and FileSystem provide.
2184
2185         * Scripts/webkitpy/common/checkout/changelog.py:
2186         * Scripts/webkitpy/common/config/committervalidator.py:
2187         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2188         * Scripts/webkitpy/common/system/filesystem_mock.py:
2189          - Turns out none of our unittests actually looked at this path.
2190            now I've made it be a valid path.
2191         * Scripts/webkitpy/tool/bot/feeders.py:
2192         * Scripts/webkitpy/tool/commands/queues.py:
2193
2194 2011-11-17  Eric Seidel  <eric@webkit.org>
2195
2196         Teach TextFileReader about FileSystem
2197         https://bugs.webkit.org/show_bug.cgi?id=72673
2198
2199         Reviewed by Adam Barth.
2200
2201         Unfortunately TextFileReader doesn't use FileSystem
2202         everywhere yet, so we can't move the unittests to
2203         using MockFileSystem, but we're close.
2204
2205         * Scripts/webkitpy/style/filereader.py:
2206         * Scripts/webkitpy/style/filereader_unittest.py:
2207         * Scripts/webkitpy/style/main.py:
2208
2209 2011-11-17  Eric Seidel  <eric@webkit.org>
2210
2211         Give check-webkit-style a Host
2212         https://bugs.webkit.org/show_bug.cgi?id=72670
2213
2214         Reviewed by Adam Barth.
2215
2216         * Scripts/webkitpy/common/checkout/scm/detection.py:
2217         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2218          - We don't run these unittests, but this one was looking for the wrong exception.
2219         * Scripts/webkitpy/style/main.py:
2220         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2221          - This was create a new scm object even though it already had one?
2222
2223 2011-11-17  Eric Seidel  <eric@webkit.org>
2224
2225         Move check-webkit-style change_directory code to more modern mocks
2226         https://bugs.webkit.org/show_bug.cgi?id=72664
2227
2228         Reviewed by Adam Barth.
2229
2230         * Scripts/check-webkit-style:
2231         * Scripts/webkitpy/style/main.py:
2232         * Scripts/webkitpy/style/main_unittest.py:
2233
2234 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
2235
2236         [GTK] enable ref tests
2237         https://bugs.webkit.org/show_bug.cgi?id=72601
2238
2239         Re-enable ref tests. Run the driver under evenly numbered display if performing
2240         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
2241         being run in an already used Xvfb instance if pixel tests are disabled.
2242
2243         Reviewed by Tony Chang.
2244
2245         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
2246         after the process is killed
2247
2248 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2249
2250         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
2251         https://bugs.webkit.org/show_bug.cgi?id=72620
2252
2253         Reviewed by David Levin.
2254
2255         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
2256         adding the suffix the cpp file. One example of false positive
2257         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
2258
2259         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
2260         basename contains the cpp's basename.
2261         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2262
2263 2011-11-17  Eric Seidel  <eric@webkit.org>
2264
2265         Move check-webkit-style's guts into webkitpy/style/main.py
2266         https://bugs.webkit.org/show_bug.cgi?id=72657
2267
2268         Reviewed by Adam Barth.
2269
2270         * Scripts/check-webkit-style:
2271         * Scripts/webkitpy/style/main.py:
2272
2273 2011-11-17  Eric Seidel  <eric@webkit.org>
2274
2275         new-run-webkit-tests is locale dependent
2276         https://bugs.webkit.org/show_bug.cgi?id=68691
2277
2278         Reviewed by Adam Barth.
2279
2280         Make NRWT use a clean environment, just like ORWT did.
2281
2282         * Scripts/webkitpy/layout_tests/port/base.py:
2283         * Scripts/webkitpy/layout_tests/port/chromium.py:
2284         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2285         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2286         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2287         * Scripts/webkitpy/layout_tests/port/efl.py:
2288         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2289         * Scripts/webkitpy/layout_tests/port/mac.py:
2290         * Scripts/webkitpy/layout_tests/port/qt.py:
2291         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2292         * Scripts/webkitpy/layout_tests/port/webkit.py:
2293         * Scripts/webkitpy/layout_tests/port/win.py:
2294
2295 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
2296
2297         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
2298         https://bugs.webkit.org/show_bug.cgi?id=72615
2299
2300         Reviewed by James Robinson.
2301
2302         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2303
2304 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
2305
2306         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
2307         https://bugs.webkit.org/show_bug.cgi?id=72595
2308
2309         Reviewed by Noam Rosenthal.
2310
2311         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2312         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
2313         ensure the registration of the DRTNode JS bindings.
2314         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2315         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
2316         registration of QWebElement (now done implicitly through QWebPage ->
2317         QtWebElementRunTime::initialize code path)
2318
2319 2011-11-17  Adam Roben  <aroben@apple.com>
2320
2321         Fix a crash-inducing typo I introduced in r100648
2322
2323         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
2324         handling a crashing test
2325
2326         Reviewed by Adam Barth.
2327
2328         * Scripts/webkitpy/layout_tests/port/chromium.py:
2329         (ChromiumDriver.run_test): Get the driver name from the port.
2330
2331         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2332         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
2333         right crashed process name.
2334
2335 2011-11-17  Adam Roben  <aroben@apple.com>
2336
2337         Fix NRWT's parsing of the number of excluded leaks
2338
2339         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
2340         leaks were excluded
2341
2342         Reviewed by Adam Barth.
2343
2344         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2345         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
2346         regular expression match, not the entire matched string.
2347
2348         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2349         (LeakDetectorTest): Added some example output that shows how things look when leaks are
2350         excluded.
2351         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
2352         correctly.
2353
2354 2011-11-17  Adam Roben  <aroben@apple.com>
2355
2356         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
2357
2358         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
2359         when web process crashes, but WebProcess crash log should get saved instead
2360
2361         Reviewed by Eric Seidel.
2362
2363         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2364         (write_test_result): Simplified a little to share more code between the case where we
2365         crashed when running the test and where we crashed when checking the expected rendering for
2366         a reftest. Changed to pass the crashed process name down to write_crash_report.
2367         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
2368         along to CrashLogs.find_newest_log rather than always using the driver name.
2369
2370         * Scripts/webkitpy/layout_tests/port/chromium.py:
2371         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
2372         crashed.
2373
2374         * Scripts/webkitpy/layout_tests/port/test.py:
2375         (TestInstance.__init__): Initialize new web_process_crash attribute.
2376         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
2377         test this patch adds.
2378         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
2379         specifies that the driver crashed or the web process crashed.
2380
2381         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2382         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
2383         which we pretend the web process crashed rather than the driver process.
2384
2385         (MainTest.test_run_singly_actually_runs_tests):
2386         (MainTest.test_unexpected_failures):
2387         (EndToEndTest.test_end_to_end):
2388         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
2389
2390 2011-11-17  Tony Chang  <tony@chromium.org>
2391
2392         [chromium] stop spamming features warning on every build
2393         https://bugs.webkit.org/show_bug.cgi?id=72629
2394
2395         Reviewed by Ojan Vafai.
2396
2397         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
2398         $mediaStreamSupport is on by default for chromium, make the default
2399         for $blobSupport also on.
2400
2401         * Scripts/build-webkit:
2402
2403 2011-11-17  Adam Roben  <aroben@apple.com>
2404
2405         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
2406
2407         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
2408         that are supposed to be ignored
2409
2410         Reviewed by Adam Barth.
2411
2412         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2413         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
2414         required when passing arguments via the shell (which we aren't doing here). It is not
2415         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
2416
2417         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2418         (LeakDetectorTest.test_leaks_args): Updated expectations.
2419
2420 2011-11-17  Philippe Normand  <pnormand@igalia.com>
2421
2422         Unreviewed, run-bindings-tests fix after r91028.
2423
2424         * Scripts/run-bindings-tests: Use scm.detection module.
2425
2426 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
2427
2428         Silence a warning about control reaching the end of a non-void function
2429         https://bugs.webkit.org/show_bug.cgi?id=72616
2430
2431         Reviewed by Tony Gentilcore.
2432
2433         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2434         (AccessibilityUIElement::verticalScrollbar):
2435
2436 2011-11-17  Adam Roben  <aroben@apple.com>
2437
2438         Ignore some leaks in frameworks we link against on Lion
2439
2440         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
2441         aren't WebKit's fault
2442
2443         Reviewed by Antti Koivisto.
2444
2445         * Scripts/old-run-webkit-tests:
2446         (countAndPrintLeaks):
2447         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2448         (LeakDetector._callstacks_to_exclude_from_leaks):
2449         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
2450
2451         * Scripts/webkitpy/layout_tests/port/mac.py:
2452         (MacPort.is_lion): Added.
2453
2454         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2455         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
2456         methods.
2457
2458 2011-11-17  Philippe Normand  <pnormand@igalia.com>
2459
2460         [GTK] Disable ref tests
2461         https://bugs.webkit.org/show_bug.cgi?id=72599
2462
2463         Reviewed by Xan Lopez.
2464
2465         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
2466         tests to avoid massive flakiness.
2467
2468 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2469
2470         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
2471
2472         A new extension object has been added to QQuickWebView (the same approach should be used
2473         for other API classes that need experimental APIs). The QML extension mechanism is then
2474         built on top of the experimental object.
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=72522
2477
2478         Reviewed by Simon Hausmann.
2479
2480         * MiniBrowser/qt/BrowserWindow.cpp:
2481         (BrowserWindow::BrowserWindow):
2482         (BrowserWindow::webView):
2483         * MiniBrowser/qt/BrowserWindow.h:
2484         * MiniBrowser/qt/UrlLoader.cpp:
2485         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2486         * qmake/mkspecs/features/default_post.prf:
2487         * qmake/mkspecs/features/default_pre.prf:
2488         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
2489         * qmake/mkspecs/features/qtwebkit.prf:
2490
2491 2011-11-17  Adam Barth  <abarth@webkit.org>
2492
2493         Move test_results_uploader.py out of layout_package
2494         https://bugs.webkit.org/show_bug.cgi?id=72590
2495
2496         Reviewed by Eric Seidel.
2497
2498         Most of the lines of code in this file are wrong, but I've restrained
2499         myself and only changed a few of them to generalized this class to the
2500         common package.
2501
2502         This is part of a series of patches to remove layout_package.
2503
2504         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
2505         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2506         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
2507
2508 2011-11-17  Adam Barth  <abarth@webkit.org>
2509
2510         Unreviewed. Fix style nits in printing.py.
2511
2512         * Scripts/webkitpy/layout_tests/views/printing.py:
2513
2514 2011-11-17  Adam Barth  <abarth@webkit.org>
2515
2516         Minor style nits in run_webkit_tests.py
2517         https://bugs.webkit.org/show_bug.cgi?id=72583
2518
2519         Reviewed by Eric Seidel.
2520
2521         This patch just fixes some minor style issues as I work my way back
2522         into this code.
2523
2524         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2525
2526 2011-11-17  Adam Barth  <abarth@webkit.org>
2527
2528         Move test_result_writer out of layout_package
2529         https://bugs.webkit.org/show_bug.cgi?id=72586
2530
2531         Rubber-stamped by Eric Seidel.
2532
2533         This is part of a series of patches to remove layout_package.
2534
2535         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2536         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
2537         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
2538         * Scripts/webkitpy/tool/commands/rebaseline.py:
2539
2540 2011-11-17  Adam Barth  <abarth@webkit.org>
2541
2542         svn-apply shouldn't magically move files into Source anymore
2543         https://bugs.webkit.org/show_bug.cgi?id=72579
2544
2545         Reviewed by Eric Seidel.
2546
2547         The Source directory has existed for long enough that we don't need
2548         svn-apply to magically re-write old-style patches anymore.
2549
2550         * Scripts/VCSUtils.pm:
2551         (parseGitDiffHeader):
2552         (parseSvnDiffHeader):
2553
2554 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2555
2556         Add a list of contribution areas
2557         https://bugs.webkit.org/show_bug.cgi?id=72566
2558
2559         Reviewed by Eric Seidel.
2560
2561         Added ContributionAreas class.
2562
2563         * Scripts/webkitpy/common/config/contributionareas.py: Added.
2564         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
2565
2566 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2567
2568         Refactor ChangeLogTest.test_parse_reviewer_text
2569         https://bugs.webkit.org/show_bug.cgi?id=72572
2570
2571         Reviewed by Eric Seidel.
2572
2573         Refactored the test code by introduing two helper functions.
2574
2575         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2576
2577 2011-11-16  Eric Seidel  <eric@webkit.org>
2578
2579         Add SCMDetector object to make scm detection mockable
2580         https://bugs.webkit.org/show_bug.cgi?id=72247
2581
2582         Reviewed by Adam Barth.
2583
2584         I think SCM detection may eventually be rolled into Checkout,
2585         but this patch at least makes it possible to mock code-paths
2586         which rely on scm detection.
2587         In the process of replacing callers of these free-functions
2588         I found that one of the functions was no longer used,
2589         and that one of the callers could instead just use the SCM
2590         object it already had access to through port.host.scm().
2591         I also discovered that I was not calling Host._initialize_scm()
2592         and thus host.scm() was always returning None!
2593
2594         * Scripts/check-webkit-style:
2595         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2596         * Scripts/webkitpy/common/checkout/deps.py:
2597         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2598         * Scripts/webkitpy/common/checkout/scm/detection.py:
2599         * Scripts/webkitpy/common/checkout/scm/git.py:
2600         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2601         * Scripts/webkitpy/common/checkout/scm/svn.py:
2602         * Scripts/webkitpy/common/host.py:
2603         * Scripts/webkitpy/common/host_mock.py:
2604         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2605         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2606         * Scripts/webkitpy/layout_tests/port/base.py:
2607         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2609         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2610         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2611
2612 2011-11-16  Mark Rowe  <mrowe@apple.com>
2613
2614         Fix the build.
2615
2616         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
2617         Apply the workaround that we use in other projects to WebKitTestRunner.
2618
2619         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
2620         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2621         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
2622
2623 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2624
2625         [Qt] Fix build after WTR AX support
2626         https://bugs.webkit.org/show_bug.cgi?id=72560
2627
2628         Reviewed by Geoffrey Garen.
2629
2630         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2631         * WebKitTestRunner/InjectedBundle/Target.pri:
2632
2633 2011-11-16  Tony Chang  <tony@chromium.org>
2634
2635         repurpose the flexbox bot for grid layout
2636         https://bugs.webkit.org/show_bug.cgi?id=72557
2637
2638         Reviewed by Ryosuke Niwa.
2639
2640         Since new flexbox is enabled everywhere, we don't need this bot
2641         anymore.  However, work on grid layout has begun, so we can use this
2642         bot to compile with ENABLE_CSS_GRID_LAYOUT.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
2645         the bot on the waterfall, I will change the slave config to enable
2646         the compile flag and tests.
2647
2648 2011-11-11  Adrienne Walker  <enne@google.com>
2649
2650         [chromium] Expose mock scrollbars to window.internals
2651         https://bugs.webkit.org/show_bug.cgi?id=72195
2652
2653         Reviewed by James Robinson.
2654
2655         Because mock scrollbars are a global setting, reset between runs.
2656
2657         * DumpRenderTree/chromium/WebPreferences.cpp:
2658         (WebPreferences::applyTo):
2659
2660 2011-11-16  James Robinson  <jamesr@chromium.org>
2661
2662         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
2663         https://bugs.webkit.org/show_bug.cgi?id=72562
2664
2665         Reviewed by Dirk Pranke.
2666
2667         * DumpRenderTree/chromium/TestShell.cpp:
2668         (TestShell::runFileTest):
2669
2670 2011-11-16  Tony Chang  <tony@chromium.org>
2671
2672         [NRWT] speculative fix for multiple subprocess test on cygwin
2673         https://bugs.webkit.org/show_bug.cgi?id=72518
2674
2675         Reviewed by Adam Barth.
2676
2677         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
2678             tries to emulate posix fd behavior.
2679         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2680
2681 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2682
2683         Revert r100509; change was committed twice (first time as r100491).
2684         Unreviewed, build fix.
2685
2686         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2687
2688 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2689
2690         Run a dummy test in the gpu configurations if there's nothing to do.
2691         https://bugs.webkit.org/show_bug.cgi?id=72498
2692
2693         Reviewed by James Robinson.
2694
2695         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2696
2697 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2698
2699         contributors_by_fuzzy_match is super slow
2700         https://bugs.webkit.org/show_bug.cgi?id=72540
2701
2702         Reviewed by Eric Seidel.
2703
2704         Make contributors_by_name do case insensitive search using a dictionary.
2705
2706         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
2707         because that's the most common case.
2708
2709         * Scripts/webkitpy/common/config/committers.py:
2710         * Scripts/webkitpy/common/config/committers_unittest.py:
2711
2712 2011-11-16  David Levin  <levin@chromium.org>
2713
2714         check-webkit-style should recognize functions even if they have OVERRIDE after them.
2715         https://bugs.webkit.org/show_bug.cgi?id=72515
2716
2717         Reviewed by Adam Barth.
2718
2719         * Scripts/webkitpy/style/checkers/cpp.py:
2720         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2721
2722 2011-11-16  Tony Chang  <tony@chromium.org>
2723
2724         [NRWT] refactor drivers to require pixel_tests param
2725         https://bugs.webkit.org/show_bug.cgi?id=72517
2726
2727         Reviewed by Ojan Vafai.
2728
2729         No tests, just a refactoring.
2730
2731         * Scripts/webkitpy/layout_tests/port/chromium.py:
2732         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2733         * Scripts/webkitpy/layout_tests/port/webkit.py:
2734         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2735
2736 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2737
2738         Run a dummy test in the gpu configurations if there's nothing to do.
2739         https://bugs.webkit.org/show_bug.cgi?id=72498
2740
2741         Reviewed by James Robinson.
2742
2743         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2744
2745 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
2746
2747         WebKitTestRunner needs to support accessibility-related DRT APIs
2748         https://bugs.webkit.org/show_bug.cgi?id=42131
2749
2750         Reviewed by Beth Dakin.
2751
2752         Port the AX code in DRT to WKTestRunner by using IDL.
2753
2754         * DumpRenderTree/AccessibilityUIElement.cpp:
2755         (horizontalScrollbarCallback):
2756         (verticalScrollbarCallback):
2757         (AccessibilityUIElement::horizontalScrollbar):
2758         (AccessibilityUIElement::verticalScrollbar):
2759         (AccessibilityUIElement::getJSClass):
2760         * DumpRenderTree/AccessibilityUIElement.h:
2761         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2762         (AccessibilityUIElement::horizontalScrollbar):
2763         (AccessibilityUIElement::verticalScrollbar):
2764         * WebKitTestRunner/DerivedSources.make:
2765         * WebKitTestRunner/GNUmakefile.am:
2766         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
2767         (WTR::AccessibilityController::create):
2768         (WTR::AccessibilityController::AccessibilityController):
2769         (WTR::AccessibilityController::~AccessibilityController):
2770         (WTR::AccessibilityController::makeWindowObject):
2771         (WTR::AccessibilityController::wrapperClass):
2772         (WTR::AccessibilityController::rootElement):
2773         (WTR::AccessibilityController::focusedElement):
2774         (WTR::AccessibilityController::elementAtPoint):
2775         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
2776         (WTR::AccessibilityController::logFocusEvents):
2777         (WTR::AccessibilityController::logValueChangeEvents):
2778         (WTR::AccessibilityController::logScrollingStartEvents):
2779         (WTR::AccessibilityController::logAccessibilityEvents):
2780         (WTR::AccessibilityController::addNotificationListener):
2781         (WTR::AccessibilityController::notificationReceived):
2782         (WTR::AccessibilityController::resetToConsistentState):
2783         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
2784         (WTR::AccessibilityTextMarker::create):
2785         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2786         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
2787         (WTR::AccessibilityTextMarker::platformTextMarker):
2788         (WTR::AccessibilityTextMarker::wrapperClass):
2789         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
2790         (WTR::AccessibilityTextMarker::isEqual):
2791         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
2792         (WTR::AccessibilityTextMarkerRange::create):
2793         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2794         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2795         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
2796         (WTR::AccessibilityTextMarkerRange::wrapperClass):
2797         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
2798         (WTR::AccessibilityTextMarkerRange::isEqual):
2799         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
2800         (WTR::AccessibilityUIElement::create):
2801         (WTR::AccessibilityUIElement::wrapperClass):
2802         (WTR::AccessibilityUIElement::isValid):
2803         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2804         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2805         (WTR::AccessibilityUIElement::isEqual):
2806         (WTR::AccessibilityUIElement::elementAtPoint):
2807         (WTR::AccessibilityUIElement::childAtIndex):
2808         (WTR::AccessibilityUIElement::indexOfChild):
2809         (WTR::AccessibilityUIElement::childrenCount):
2810         (WTR::AccessibilityUIElement::titleUIElement):
2811         (WTR::AccessibilityUIElement::parentElement):
2812         (WTR::AccessibilityUIElement::takeFocus):
2813         (WTR::AccessibilityUIElement::takeSelection):
2814         (WTR::AccessibilityUIElement::addSelection):
2815         (WTR::AccessibilityUIElement::removeSelection):
2816         (WTR::AccessibilityUIElement::allAttributes):
2817         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2818         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2819         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2820         (WTR::AccessibilityUIElement::attributesOfChildren):
2821         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2822         (WTR::AccessibilityUIElement::increment):
2823         (WTR::AccessibilityUIElement::decrement):
2824         (WTR::AccessibilityUIElement::showMenu):
2825         (WTR::AccessibilityUIElement::press):
2826         (WTR::AccessibilityUIElement::stringAttributeValue):
2827         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2828         (WTR::AccessibilityUIElement::numberAttributeValue):
2829         (WTR::AccessibilityUIElement::boolAttributeValue):
2830         (WTR::AccessibilityUIElement::isAttributeSupported):
2831         (WTR::AccessibilityUIElement::isAttributeSettable):
2832         (WTR::AccessibilityUIElement::isActionSupported):
2833         (WTR::AccessibilityUIElement::role):
2834         (WTR::AccessibilityUIElement::subrole):
2835         (WTR::AccessibilityUIElement::roleDescription):
2836         (WTR::AccessibilityUIElement::title):
2837         (WTR::AccessibilityUIElement::description):
2838         (WTR::AccessibilityUIElement::language):
2839         (WTR::AccessibilityUIElement::stringValue):
2840         (WTR::AccessibilityUIElement::accessibilityValue):
2841         (WTR::AccessibilityUIElement::helpText):
2842         (WTR::AccessibilityUIElement::orientation):
2843         (WTR::AccessibilityUIElement::x):
2844         (WTR::AccessibilityUIElement::y):
2845         (WTR::AccessibilityUIElement::width):
2846         (WTR::AccessibilityUIElement::height):
2847         (WTR::AccessibilityUIElement::intValue):
2848         (WTR::AccessibilityUIElement::minValue):
2849         (WTR::AccessibilityUIElement::maxValue):
2850         (WTR::AccessibilityUIElement::valueDescription):
2851         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2852         (WTR::AccessibilityUIElement::selectedTextRange):
2853         (WTR::AccessibilityUIElement::isEnabled):
2854         (WTR::AccessibilityUIElement::isRequired):
2855         (WTR::AccessibilityUIElement::isFocused):
2856         (WTR::AccessibilityUIElement::isFocusable):
2857         (WTR::AccessibilityUIElement::isSelected):
2858         (WTR::AccessibilityUIElement::isSelectable):
2859         (WTR::AccessibilityUIElement::isMultiSelectable):
2860         (WTR::AccessibilityUIElement::setSelectedChild):
2861         (WTR::AccessibilityUIElement::selectedChildrenCount):
2862         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2863         (WTR::AccessibilityUIElement::isExpanded):
2864         (WTR::AccessibilityUIElement::isChecked):
2865         (WTR::AccessibilityUIElement::isVisible):
2866         (WTR::AccessibilityUIElement::isOffScreen):
2867         (WTR::AccessibilityUIElement::isCollapsed):
2868         (WTR::AccessibilityUIElement::isIgnored):
2869         (WTR::AccessibilityUIElement::hasPopup):
2870         (WTR::AccessibilityUIElement::hierarchicalLevel):
2871         (WTR::AccessibilityUIElement::clickPointX):
2872         (WTR::AccessibilityUIElement::clickPointY):
2873         (WTR::AccessibilityUIElement::documentEncoding):
2874         (WTR::AccessibilityUIElement::documentURI):
2875         (WTR::AccessibilityUIElement::url):
2876         (WTR::AccessibilityUIElement::speak):
2877         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2878         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2879         (WTR::AccessibilityUIElement::attributesOfColumns):
2880         (WTR::AccessibilityUIElement::attributesOfRows):
2881         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2882         (WTR::AccessibilityUIElement::attributesOfHeader):
2883         (WTR::AccessibilityUIElement::indexInTable):
2884         (WTR::AccessibilityUIElement::rowIndexRange):
2885         (WTR::AccessibilityUIElement::columnIndexRange):
2886         (WTR::AccessibilityUIElement::rowCount):
2887         (WTR::AccessibilityUIElement::columnCount):
2888         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2889         (WTR::AccessibilityUIElement::disclosedByRow):
2890         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2891         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2892         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2893         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2894         (WTR::AccessibilityUIElement::ariaDropEffects):
2895         (WTR::AccessibilityUIElement::lineForIndex):
2896         (WTR::AccessibilityUIElement::rangeForLine):
2897         (WTR::AccessibilityUIElement::boundsForRange):
2898         (WTR::AccessibilityUIElement::setSelectedTextRange):
2899         (WTR::AccessibilityUIElement::stringForRange):
2900         (WTR::AccessibilityUIElement::attributedStringForRange):
2901         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2902         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2903         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2904         (WTR::AccessibilityUIElement::horizontalScrollbar):
2905         (WTR::AccessibilityUIElement::verticalScrollbar):
2906         (WTR::AccessibilityUIElement::addNotificationListener):
2907         (WTR::AccessibilityUIElement::removeNotificationListener):
2908         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2909         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2910         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2911         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2912         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2913         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2914         (WTR::AccessibilityUIElement::textMarkerForPoint):
2915         (WTR::AccessibilityUIElement::previousTextMarker):
2916         (WTR::AccessibilityUIElement::nextTextMarker):
2917         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2918         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
2919         (WTR::AccessibilityUIElement::platformUIElement):
2920         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
2921         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
2922         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
2923         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
2924         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2925         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2926         (WTR::InjectedBundle::beginTesting):
2927         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2928         (WTR::InjectedBundle::accessibilityController):
2929         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2930         (WTR::InjectedBundlePage::didClearWindowForFrame):
2931         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2932         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
2933         (WTR::LayoutTestController::platformName):
2934         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
2935         (WTR::AccessibilityTextMarker::isEqual):
2936         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
2937         (WTR::AccessibilityTextMarkerRange::isEqual):
2938         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
2939         (+[NSString stringWithJSStringRef:]):
2940         (-[NSString createJSStringRef]):
2941         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
2942         (-[AccessibilityNotificationHandler dealloc]):
2943         (-[AccessibilityNotificationHandler _notificationReceived:]):
2944         (-[AccessibilityNotificationHandler setCallback:]):
2945         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2946         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2947         (WTR::AccessibilityUIElement::isEqual):
2948         (WTR::descriptionOfValue):
2949         (WTR::attributesOfElement):
2950         (WTR::concatenateAttributeAndValue):
2951         (WTR::convertNSArrayToVector):
2952         (WTR::descriptionOfElements):
2953         (WTR::AccessibilityUIElement::getLinkedUIElements):
2954         (WTR::AccessibilityUIElement::getDocumentLinks):
2955         (WTR::AccessibilityUIElement::getChildren):
2956         (WTR::AccessibilityUIElement::getChildrenWithRange):
2957         (WTR::AccessibilityUIElement::childrenCount):
2958         (WTR::AccessibilityUIElement::elementAtPoint):
2959         (WTR::AccessibilityUIElement::indexOfChild):
2960         (WTR::AccessibilityUIElement::childAtIndex):
2961         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2962         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2963         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2964         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2965         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2966         (WTR::AccessibilityUIElement::selectedChildrenCount):
2967         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2968         (WTR::AccessibilityUIElement::titleUIElement):
2969         (WTR::AccessibilityUIElement::parentElement):
2970         (WTR::AccessibilityUIElement::disclosedByRow):
2971         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2972         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2973         (WTR::AccessibilityUIElement::attributesOfChildren):
2974         (WTR::AccessibilityUIElement::allAttributes):
2975         (WTR::AccessibilityUIElement::stringAttributeValue):
2976         (WTR::AccessibilityUIElement::numberAttributeValue):
2977         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2978         (WTR::AccessibilityUIElement::boolAttributeValue):
2979         (WTR::AccessibilityUIElement::isAttributeSettable):
2980         (WTR::AccessibilityUIElement::isAttributeSupported):
2981         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2982         (WTR::AccessibilityUIElement::role):
2983         (WTR::AccessibilityUIElement::subrole):
2984         (WTR::AccessibilityUIElement::roleDescription):
2985         (WTR::AccessibilityUIElement::title):
2986         (WTR::AccessibilityUIElement::description):
2987         (WTR::AccessibilityUIElement::orientation):
2988         (WTR::AccessibilityUIElement::stringValue):
2989         (WTR::AccessibilityUIElement::language):
2990         (WTR::AccessibilityUIElement::helpText):
2991         (WTR::AccessibilityUIElement::x):
2992         (WTR::AccessibilityUIElement::y):
2993         (WTR::AccessibilityUIElement::width):
2994         (WTR::AccessibilityUIElement::height):
2995         (WTR::AccessibilityUIElement::clickPointX):
2996         (WTR::AccessibilityUIElement::clickPointY):
2997         (WTR::AccessibilityUIElement::intValue):
2998         (WTR::AccessibilityUIElement::minValue):
2999         (WTR::AccessibilityUIElement::maxValue):
3000         (WTR::AccessibilityUIElement::valueDescription):
3001         (WTR::AccessibilityUIElement::insertionPointLineNumber):
3002         (WTR::AccessibilityUIElement::isActionSupported):
3003         (WTR::AccessibilityUIElement::isEnabled):
3004         (WTR::AccessibilityUIElement::isRequired):
3005         (WTR::AccessibilityUIElement::isFocused):
3006         (WTR::AccessibilityUIElement::isSelected):
3007         (WTR::AccessibilityUIElement::isExpanded):
3008         (WTR::AccessibilityUIElement::isChecked):
3009         (WTR::AccessibilityUIElement::hierarchicalLevel):
3010         (WTR::AccessibilityUIElement::speak):
3011         (WTR::AccessibilityUIElement::ariaIsGrabbed):
3012         (WTR::AccessibilityUIElement::ariaDropEffects):
3013         (WTR::AccessibilityUIElement::lineForIndex):
3014         (WTR::AccessibilityUIElement::rangeForLine):
3015         (WTR::AccessibilityUIElement::boundsForRange):
3016         (WTR::AccessibilityUIElement::stringForRange):
3017         (WTR::AccessibilityUIElement::attributedStringForRange):
3018         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3019         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3020         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3021         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3022         (WTR::AccessibilityUIElement::attributesOfColumns):
3023         (WTR::AccessibilityUIElement::attributesOfRows):
3024         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3025         (WTR::AccessibilityUIElement::attributesOfHeader):
3026         (WTR::AccessibilityUIElement::rowCount):
3027         (WTR::AccessibilityUIElement::columnCount):
3028         (WTR::AccessibilityUIElement::indexInTable):
3029         (WTR::AccessibilityUIElement::rowIndexRange):
3030         (WTR::AccessibilityUIElement::columnIndexRange):
3031         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3032         (WTR::AccessibilityUIElement::horizontalScrollbar):
3033         (WTR::AccessibilityUIElement::verticalScrollbar):
3034         (WTR::AccessibilityUIElement::selectedTextRange):
3035         (WTR::AccessibilityUIElement::setSelectedTextRange):
3036         (WTR::AccessibilityUIElement::increment):
3037         (WTR::AccessibilityUIElement::decrement):
3038         (WTR::AccessibilityUIElement::showMenu):
3039         (WTR::AccessibilityUIElement::press):
3040         (WTR::AccessibilityUIElement::setSelectedChild):
3041         (WTR::AccessibilityUIElement::accessibilityValue):
3042         (WTR::AccessibilityUIElement::documentEncoding):
3043         (WTR::AccessibilityUIElement::documentURI):
3044         (WTR::AccessibilityUIElement::url):
3045         (WTR::AccessibilityUIElement::addNotificationListener):
3046         (WTR::AccessibilityUIElement::removeNotificationListener):
3047         (WTR::AccessibilityUIElement::isFocusable):
3048         (WTR::AccessibilityUIElement::isSelectable):
3049         (WTR::AccessibilityUIElement::isMultiSelectable):
3050         (WTR::AccessibilityUIElement::isVisible):
3051         (WTR::AccessibilityUIElement::isOffScreen):
3052         (WTR::AccessibilityUIElement::isCollapsed):
3053         (WTR::AccessibilityUIElement::isIgnored):
3054         (WTR::AccessibilityUIElement::hasPopup):
3055         (WTR::AccessibilityUIElement::takeFocus):
3056         (WTR::AccessibilityUIElement::takeSelection):
3057         (WTR::AccessibilityUIElement::addSelection):
3058         (WTR::AccessibilityUIElement::removeSelection):
3059         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3060         (WTR::AccessibilityUIElement::textMarkerRangeLength):
3061         (WTR::AccessibilityUIElement::previousTextMarker):
3062         (WTR::AccessibilityUIElement::nextTextMarker):
3063         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3064         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3065         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3066         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3067         (WTR::AccessibilityUIElement::textMarkerForPoint):
3068         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3069         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3070         (WTR::LayoutTestController::platformName):
3071         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3072         (WTR::LayoutTestController::platformName):
3073         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3074         (WTR::LayoutTestController::platformName):
3075         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3076         * WebKitTestRunner/win/InjectedBundle.vcproj:
3077
3078 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3079
3080         [Qt] Fix use of config.tests
3081
3082         We were checking @buildArgs to determine if the optional argument was
3083         passed or not, but this is not the right way to do that in Perl. The
3084         right way is to not use a prototype for the function, and to pass
3085         the list as a reference (to avoid list expansion). That way we can
3086         check the number of arguments, and choose the right code path based
3087         on that.
3088
3089         We were also missing a default-value of 0 for any feature that's not
3090         set in features.prf.
3091
3092         Reviewed by Kenneth Rohde Christiansen.
3093
3094         * Scripts/build-webkit:
3095         * Scripts/webkitdirs.pm:
3096         (qtFeatureDefaults):
3097         (buildQMakeProject):
3098
3099 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3100
3101         [Qt] Prospective fix for broken plugin tests
3102
3103         Don't hide symbols for the NPAPI test plugin
3104
3105         Rubber-stamped by Andreas Kling.
3106
3107         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3108
3109 2011-11-16  Adam Roben  <aroben@apple.com>
3110
3111         Move filenames/line numbers off to the right edge in Leaks Viewer
3112
3113         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
3114         because filenames/line numbers are right next to function names
3115
3116         Reviewed by Andreas Kling.
3117
3118         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
3119         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
3120         function name. Use the filename as the profile node's URL (we don't have enough info to
3121         compute a real URL currently) and the line number as the profile node's line number so the
3122         Inspector code will put them on the right side of the callstack graph.
3123
3124         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3125         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
3126         passed here, just filenames.
3127
3128         (WebInspector.linkifyURLAsNode):
3129         (WebInspector.linkifyResourceAsNode):
3130         Copied and slightly modified from inspector.js.
3131
3132 2011-11-16  Adam Roben  <aroben@apple.com>
3133
3134         Make Leaks Viewer load builds from the new Lion Leaks bot
3135
3136         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
3137
3138         Reviewed by Andreas Kling.
3139
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3141         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
3142         SnowLeopard one.
3143
3144 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3145
3146         [EFL] Clean up the offline apps-related functions in ewk_settings.
3147         https://bugs.webkit.org/show_bug.cgi?id=72132
3148
3149         Reviewed by Kenneth Rohde Christiansen.
3150
3151         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
3152         prefixes for code that is related only to the HTML5 app cache
3153         features.
3154
3155         Use `ewk_settings_application_cache' and
3156         `ewk_view_setting_application_cache' instead.
3157
3158         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3159         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3160
3161 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3162
3163         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
3164
3165         Reviewed by Tor Arne Vestbø.
3166
3167         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
3168         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
3169         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
3170         removes the .so.0.0.0 and just produces .so.
3171
3172 2011-11-16  Peter Beverloo  <peter@chromium.org>
3173
3174         Explicitly include unistd.h in TestNetscapePlugIn
3175         https://bugs.webkit.org/show_bug.cgi?id=72385
3176
3177         This is needed for the sleep() call in the indicateTestFailure method,
3178         which seems to be implicitly available for other platforms. This is not
3179         the case on Android.
3180
3181         Reviewed by Steve Block.
3182
3183         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3184
3185 2011-11-16  Peter Beverloo  <peter@chromium.org>
3186
3187         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
3188         https://bugs.webkit.org/show_bug.cgi?id=72384
3189
3190         Update to Android NDK r7, which was released last Friday. This adds
3191         support for RTTI and the -mimplicit-it gcc flag, which are required to
3192         respectively build ICU and Skia.
3193
3194         Reviewed by Steve Block.
3195
3196         * Scripts/update-webkit-chromium:
3197         * Scripts/webkitdirs.pm:
3198         (buildChromiumMakefile):
3199
3200 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
3201
3202         Unreviewed, rolling out r100266.
3203         http://trac.webkit.org/changeset/100266
3204
3205         Broke WTR.
3206
3207         * qmake/mkspecs/features/default_post.prf:
3208
3209 2011-11-16  Eric Seidel  <eric@webkit.org>
3210
3211         check-webkit-style broken by r99773: "Could not determine the port"
3212         https://bugs.webkit.org/show_bug.cgi?id=72275
3213
3214         Reviewed by Adam Barth.
3215
3216         I will continue engaging hacks, until windows improves.
3217
3218         * Scripts/webkitpy/common/host.py:
3219          - Host uses self.executive instead of self._executive like Port does.
3220          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
3221
3222 2011-11-16  Eric Seidel  <eric@webkit.org>
3223
3224         check-webkit-style broken by r99773: "Could not determine the port"
3225         https://bugs.webkit.org/show_bug.cgi?id=72275
3226
3227         Reviewed by Adam Barth.
3228
3229         Engage windows hacks harder.
3230
3231         This is a speculative fix for ChromiumWin.  We're now
3232         creating an SCM object much earlier, so we need to
3233         engage our "awesome" windows hacks earlier.
3234
3235         * Scripts/webkitpy/common/host.py:
3236         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3237
3238 2011-11-15  Darin Adler  <darin@apple.com>
3239
3240         DRT's uiElementAttributeValueCallback function is leaky
3241         https://bugs.webkit.org/show_bug.cgi?id=72453
3242
3243         Reviewed by Dan Bernstein.
3244
3245         * DumpRenderTree/AccessibilityUIElement.cpp:
3246         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
3247
3248 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
3249
3250         Implement edit-distance based reviewer recognition algorithm
3251         https://bugs.webkit.org/show_bug.cgi?id=72351
3252
3253         Reviewed by Eric Seidel.
3254
3255         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
3256         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
3257         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
3258         "build fix" to a reviewer's name (e.g. with with edit distance 9).
3259
3260         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
3261         the edit distance is implemented in edit_distance.py.
3262
3263         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
3264         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
3265
3266         * Scripts/webkitpy/common/checkout/changelog.py:
3267         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3268         * Scripts/webkitpy/common/config/committers.py:
3269         * Scripts/webkitpy/common/config/committers_unittest.py:
3270         * Scripts/webkitpy/common/editdistance.py: Added.
3271         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
3272         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3273         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
3274
3275 2011-11-15  Tony Chang  <tony@chromium.org>
3276
3277         Skip a failing webkitpy test on cygwin.
3278
3279         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3280
3281 2011-11-15  Sam Weinig  <sam@webkit.org>
3282
3283         TestWebKitAPI should not put its resources in the root products directory
3284         https://bugs.webkit.org/show_bug.cgi?id=72446
3285
3286         Reviewed by Anders Carlsson.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
3290         directory.
3291
3292         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3293         (TEST_F):
3294         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3295         (TestWebKitAPI::TEST):
3296         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3297         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3298         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3299         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
3300         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3301         (TestWebKitAPI::Util::createURLForResource):
3302         Update calls to retrieve files from the bundle to look in the newly
3303         created subdirectory.
3304
3305 2011-11-15  Tony Chang  <tony@chromium.org>
3306
3307         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
3308
3309         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3310
3311 2011-11-15  Tony Chang  <tony@chromium.org>
3312
3313         Unreviewed, fix test-webkitpy tests.  Move the check for image results
3314         earlier.
3315
3316         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3317         * Scripts/webkitpy/layout_tests/port/webkit.py:
3318
3319 2011-11-15  James Robinson  <jamesr@chromium.org>
3320
3321         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
3322         https://bugs.webkit.org/show_bug.cgi?id=72444
3323
3324         Reviewed by Adam Barth.
3325
3326         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3327
3328 2011-11-15  Tony Chang  <tony@chromium.org>
3329
3330         Unreviewed, better fix for ref tests failures on SL Intel bot.
3331         Revert the previous change and return None if pixel results from
3332         either the test page or the expected page is missing.
3333
3334         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3335         * Scripts/webkitpy/layout_tests/port/webkit.py:
3336
3337 2011-11-15  James Robinson  <jamesr@chromium.org>
3338
3339         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
3340         https://bugs.webkit.org/show_bug.cgi?id=72402
3341
3342         Reviewed by Dirk Pranke.
3343
3344         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
3345         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
3346         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
3347         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
3348         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
3349         compositing enabled.
3350
3351         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
3352         patch should not impact any tests.
3353
3354         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3355         (main):
3356         * DumpRenderTree/chromium/TestShell.cpp:
3357         (TestShell::TestShell):
3358         (TestShell::resetWebSettings):
3359         * DumpRenderTree/chromium/TestShell.h:
3360         (TestShell::setAcceleratedCompositingForVideoEnabled):
3361         * DumpRenderTree/chromium/WebPreferences.cpp:
3362         (WebPreferences::reset):
3363         (WebPreferences::applyTo):
3364         * DumpRenderTree/chromium/WebPreferences.h:
3365         * Scripts/webkitpy/layout_tests/port/chromium.py:
3366         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3367         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3368
3369 2011-11-15  Tony Chang  <tony@chromium.org>
3370
3371         Unreviewed, try to fix ref tests failures on SL Intel bot.
3372         It looks like ImageDiff isn't returning an image diff.
3373
3374         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3375
3376 2011-11-15  Tony Chang  <tony@chromium.org>
3377
3378         Unreviewed fix of ref-tests on GTK+.
3379         If a driver is never started, _xvfb_process is never set.
3380
3381         * Scripts/webkitpy/layout_tests/port/gtk.py:
3382
3383 2011-11-14  Tony Chang  <tony@chromium.org>
3384
3385         [NRWT] Reftests should run even when pixel tests are disabled.
3386         https://bugs.webkit.org/show_bug.cgi?id=60605
3387
3388         Reviewed by Dirk Pranke.
3389
3390         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
3391             Also add an assert to make sure we get image hashes back when running ref tests.
3392         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
3393         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3394         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
3395         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
3396             of starting a pixel driver if needed.  It handles the logic of sending the test
3397             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
3398         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3399         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
3400         * Scripts/webkitpy/layout_tests/port/webkit.py:
3401         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
3402         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
3403
3404 2011-11-15  David Kilzer  <ddkilzer@apple.com>
3405
3406         Don't use File::Slurp for run-leaks unit tests
3407         <http://webkit.org/b/72356>
3408
3409         Reviewed by Daniel Bates.
3410
3411         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
3412         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3413         Extracted common package logic into RunLeaks.pm.  Fixed call to
3414         RunLeaks::parseLeaksOutput().
3415         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3416         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3417
3418 2011-11-15  Peter Kasting  <pkasting@google.com>
3419
3420         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
3421         https://bugs.webkit.org/show_bug.cgi?id=72349
3422
3423         Reviewed by Adam Roben.
3424
3425         * Scripts/VCSUtils.pm:
3426         (isSVNDirectory):
3427
3428 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3429
3430         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
3431
3432         Reviewed by Tor Arne Vestbø.
3433
3434         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
3435         magic here where we handle all TEMPLATE = lib .pro files.
3436
3437 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3438
3439         [Qt] Unreviewed prospective --minimal build fix.
3440
3441         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
3442         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
3443
3444 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3445
3446         [Qt] Unreviewed --minimal build fix.
3447
3448         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
3449         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
3450         to make moc's preprocessor abort.
3451
3452 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
3453
3454         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
3455         https://bugs.webkit.org/show_bug.cgi?id=72156
3456
3457         Reviewed by Daniel Bates.
3458
3459         Similar to --makearg and --qmakearg, --cmakearg lets one pass
3460         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
3461
3462         * Scripts/build-webkit:
3463         * Scripts/webkitdirs.pm:
3464         (generateBuildSystemFromCMakeProject):
3465
3466 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
3467
3468         Improve ChangeLogEntry's reviewer parsing algorithm part 2
3469         https://bugs.webkit.org/show_bug.cgi?id=72340
3470
3471         Reviewed by Eric Seidel.
3472
3473         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
3474         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
3475
3476         * Scripts/webkitpy/common/checkout/changelog.py:
3477         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3478
3479 2011-11-14  Eric Seidel  <eric@webkit.org>
3480
3481         check-webkit-style broken by r99773: "Could not determine the port"
3482         https://bugs.webkit.org/show_bug.cgi?id=72275
3483
3484         Reviewed by Adam Barth.
3485
3486         The TestExpectationsChecker was using a generic try/except block
3487         which caught all exceptions, so we didn't notice that failing
3488         to pass a Host to PortFactory was causing an exception in port instantiation.
3489         I've factored out the "lookup the port" logic into a separate function
3490         which I've now unittested.  This should fix the bug and prevent
3491         others like it from occuring the the future.
3492
3493         * Scripts/webkitpy/style/checkers/test_expectations.py:
3494         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3495
3496 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
3497
3498         Add --css-grid-layout to build-webkit and the build systems
3499         https://bugs.webkit.org/show_bug.cgi?id=72320
3500
3501         Reviewed by Ojan Vafai.
3502
3503         * Scripts/build-webkit:
3504         Added the option.
3505
3506 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3507
3508         Unreviewed, rolling out r100192.
3509         http://trac.webkit.org/changeset/100192
3510         https://bugs.webkit.org/show_bug.cgi?id=72328
3511
3512         Caused infinite tests to fail (Requested by abarth on
3513         #webkit).
3514
3515         * Scripts/webkitpy/layout_tests/port/base.py:
3516         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3517
3518 2011-11-14  Tony Chang  <tony@chromium.org>
3519
3520         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
3521         https://bugs.webkit.org/show_bug.cgi?id=72196
3522
3523         Reviewed by Ojan Vafai.
3524
3525         * Scripts/build-webkit:
3526
3527 2011-11-14  John Yani  <vanuan@gmail.com>
3528
3529         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
3530         Override LOCALE to en_US.
3531
3532         Reviewed by Eric Seidel.
3533
3534         * Scripts/webkitpy/layout_tests/port/base.py:
3535
3536 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
3537
3538         [Chromium] build-webkit silently drops the features flags
3539         https://bugs.webkit.org/show_bug.cgi?id=72293
3540
3541         Reviewed by Tony Chang.
3542
3543         Chromium still ignores @features but now we give a warning!
3544
3545         * Scripts/build-webkit: Check if one of the features is different
3546         from the default and print a warning in this case.
3547
3548 2011-11-14  David Kilzer  <ddkilzer@apple.com>
3549
3550         run-leaks does not work on Lion?
3551         <http://webkit.org/b/71059>
3552         <rdar://problem/10428527>
3553
3554         Reviewed by Adam Roben.
3555
3556         The output of leaks(1) changed again in Lion to move the
3557         "leaks Report Version: 2.0" line from the first line of the
3558         output to just above the "Process " lines that run-leaks is
3559         interested in parsing.  This required using a more generic
3560         algorithm to find the start of the "Process " lines.
3561
3562         * Scripts/run-leaks:
3563         (parseLeaksOutput): Make the code to skip headers more generic.
3564         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
3565         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
3566         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
3567
3568 2011-11-14  Lei Zhang  <thestig@chromium.org>
3569
3570         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
3571         https://bugs.webkit.org/show_bug.cgi?id=72088
3572
3573         Reviewed by Tony Chang.
3574
3575         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3576
3577 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
3578
3579         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
3580         https://bugs.webkit.org/show_bug.cgi?id=72147
3581
3582         Reviewed by Adam Barth.
3583
3584         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3585
3586 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3587
3588         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
3589
3590         Reviewed by Simon Hausmann.
3591
3592         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
3593
3594 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
3595
3596         [Qt] Disable plugins on X11 for WK2
3597
3598         Reviewed by Kenneth Rohde Christiansen.
3599
3600         Currently plugins are in-process and they crash in the likely case of
3601         a plugin installation that uses Qt 4, which beautifully clashes with the
3602         Qt 5 based QtWebProcess.
3603
3604         * qmake/mkspecs/features/features.prf:
3605
3606 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3607
3608         [Qt] Add support for config tests for Qt 5
3609
3610         This allows us to build and run configure-tests at build
3611         time to determine if a given platform feature is available.
3612
3613         Reviewed by Simon Hausmann.
3614
3615         * Scripts/build-webkit:
3616         * Scripts/webkitdirs.pm:
3617         (qtFeatureDefaults):
3618         * qmake/configure.pro: Added.
3619         * qmake/mkspecs/features/features.prf:
3620         * qmake/sync.profile: Added.
3621
3622 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
3623
3624         [Qt] Remove the QStyle dependency in Qt's mobile theme
3625         https://bugs.webkit.org/show_bug.cgi?id=67773
3626
3627         This refactoring splits up RenderThemeQt with two
3628         subclasses, a QStyle-backed one, and a Mobile version
3629         that uses the old mobile theme for now.
3630
3631         QStyle availability is detected at compile time, and
3632         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
3633         environment variable.
3634
3635         Reviewed by Simon Hausmann.
3636
3637         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3638         (WTR::activateFonts):
3639         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
3640         based on availability of QtWidgets.
3641         * qmake/mkspecs/features/webcore.prf: cleanup.
3642
3643 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
3644
3645         Unreviewed, rolling out r100116.
3646         http://trac.webkit.org/changeset/100116
3647
3648         r100104 was rolled out, so no longer needed
3649
3650         * Scripts/run-bindings-tests:
3651
3652 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
3653
3654         Unreviewed, rolling out r100104.
3655         http://trac.webkit.org/changeset/100104
3656         https://bugs.webkit.org/show_bug.cgi?id=72247
3657
3658         broke windows builds
3659
3660         * Scripts/check-webkit-style:
3661         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3662         * Scripts/webkitpy/common/checkout/deps.py:
3663         * Scripts/webkitpy/common/checkout/scm/__init__.py:
3664         * Scripts/webkitpy/common/checkout/scm/detection.py:
3665         * Scripts/webkitpy/common/checkout/scm/git.py:
3666         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3667         * Scripts/webkitpy/common/checkout/scm/svn.py:
3668         * Scripts/webkitpy/common/host.py:
3669         * Scripts/webkitpy/common/host_mock.py:
3670         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3671         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3672         * Scripts/webkitpy/layout_tests/port/base.py:
3673         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3675         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3676         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3677
3678 2011-11-14  Philippe Normand  <pnormand@igalia.com>
3679
3680         Unreviewed, build fix after r100104. run-binding-tests broke.
3681
3682         * Scripts/run-bindings-tests: Explicitely use scm.detection.
3683
3684 2011-11-13  Eric Seidel  <eric@webkit.org>
3685
3686         Add SCMDetector object to make scm detection mockable
3687         https://bugs.webkit.org/show_bug.cgi?id=72247
3688
3689         Reviewed by Adam Barth.
3690
3691         I think SCM detection may eventually be rolled into Checkout,
3692         but this patch at least makes it possible to mock code-paths
3693         which rely on scm detection.
3694         In the process of replacing callers of these free-functions
3695         I found that one of the functions was no longer used,
3696         and that one of the callers could instead just use the SCM
3697         object it already had access to through port.host.scm().
3698         I also discovered that I was not calling Host._initialize_scm()
3699         and thus host.scm() was always returning None!
3700
3701         * Scripts/check-webkit-style:
3702         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3703         * Scripts/webkitpy/common/checkout/deps.py:
3704         * Scripts/webkitpy/common/checkout/scm/__init__.py:
3705         * Scripts/webkitpy/common/checkout/scm/detection.py:
3706         * Scripts/webkitpy/common/checkout/scm/git.py:
3707         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3708         * Scripts/webkitpy/common/checkout/scm/svn.py:
3709         * Scripts/webkitpy/common/host.py:
3710         * Scripts/webkitpy/common/host_mock.py:
3711         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3712         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3713         * Scripts/webkitpy/layout_tests/port/base.py:
3714         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3715         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3716         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3717         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3718
3719 2011-11-13  Gavin Peters  <gavinp@chromium.org>
3720
3721         command line control of webcore log channels in chromium DumpRenderTree
3722         https://bugs.webkit.org/show_bug.cgi?id=72126
3723         
3724         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
3725         what chromium takes.
3726
3727         Reviewed by Kent Tamura.
3728
3729         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3730         (main):
3731
3732 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
3733
3734         [Qt] Fix minor config typo in the build tool documentation
3735         https://bugs.webkit.org/show_bug.cgi?id=72194
3736
3737         Reviewed by Andreas Kling.
3738
3739         * qmake/README:
3740
3741 2011-11-11  Stephen Chenney  <schenney@chromium.org>
3742
3743         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
3744         https://bugs.webkit.org/show_bug.cgi?id=49257
3745
3746         Adds the remaining missing layout test functionality for printing.
3747
3748         Reviewed by Darin Fisher.
3749
3750         * DumpRenderTree/chromium/LayoutTestController.cpp:
3751         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
3752         (parsePageNumber): Method to parse JS arguments for a page number
3753         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
3754         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
3755         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
3756         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
3757         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
3758
3759 2011-11-11  Darin Adler  <darin@apple.com>
3760
3761         Remove all releaseRef implementations except for RetainPtr
3762         https://bugs.webkit.org/show_bug.cgi?id=71423
3763
3764         Reviewed by Julien Chaffraix.
3765
3766         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3767         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
3768
3769 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
3770
3771         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
3772         https://bugs.webkit.org/show_bug.cgi?id=72090
3773
3774         Reviewed by Eric Seidel.
3775
3776         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
3777         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
3778
3779         yay! r100002.
3780
3781         * Scripts/webkitpy/common/checkout/changelog.py:
3782         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3783
3784 2011-11-11  Tony Chang  <tony@chromium.org>
3785
3786         Remove --force from gclient sync.  The bots seem to have made it past
3787         the update step.
3788
3789         * Scripts/update-webkit:
3790
3791 2011-11-11  Tony Chang  <tony@chromium.org>
3792
3793         Add --force to gclient sync. Once the cq bots cycle, we can remove
3794         this since it slows down the normal sync.
3795
3796         * Scripts/update-webkit:
3797
3798 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
3799
3800         When --force is used, also use --reset
3801         https://bugs.webkit.org/show_bug.cgi?id=72129
3802
3803         Reviewed by Dimitri Glazkov.
3804
3805         * Scripts/update-webkit-chromium:
3806
3807 2011-11-11  Tony Chang  <tony@chromium.org>
3808
3809         allow two chromium drivers to run at the same time in NRWT
3810         https://bugs.webkit.org/show_bug.cgi?id=72067
3811
3812         Reviewed by Dirk Pranke.
3813
3814         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
3815             posix prevents the subprocesses from sharing the same fd for stdin.
3816             Sharing the same fd prevents us from closing the files unless all references
3817             to the fd are closed.
3818         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
3819             to adding a test for this, speed up a test (from 3sec to 0) by fixing
3820             the timeout override. It looks like it regressed in r95875.
3821
3822 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3823
3824         Unreviewed, rolling out r99964.
3825         http://trac.webkit.org/changeset/99964
3826         https://bugs.webkit.org/show_bug.cgi?id=72124
3827
3828         Broke too many Qt tests (Requested by tronical_ on #webkit).
3829
3830         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3831         (WTR::activateFonts):
3832         * qmake/mkspecs/features/features.prf:
3833         * qmake/mkspecs/features/webcore.prf:
3834
3835 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
3836
3837         [Qt] Remove the QStyle dependency in Qt's mobile theme
3838         https://bugs.webkit.org/show_bug.cgi?id=67773
3839
3840         This refactoring splits up RenderThemeQt with two
3841         subclasses, a QStyle-backed one, and a Mobile version
3842         that uses the old mobile theme for now.
3843
3844         QStyle availability is detected at compile time, and
3845         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
3846         environment variable.
3847
3848         Reviewed by Simon Hausmann.
3849
3850         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3851         (WTR::activateFonts):
3852         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
3853         based on availability of QtWidgets.
3854         * qmake/mkspecs/features/webcore.prf: cleanup.
3855
3856 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3857
3858         [Qt] Add missing include to PlatformWebViewQt
3859
3860         Reviewed by Simon Hausmann.
3861
3862         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3863
3864 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3865
3866         [Qt] Fix incremental builds on Windows after buildsystem refactor
3867
3868         The qmake rules to ensure that we run make on the derived sources
3869         before running qmake on the target were inside a unix-scope, which
3870         resulted in flakey builds on Windows.
3871
3872         We now generate a rule on all platforms that ensures that "make qmake"
3873         will always run make on the derived sources. In addition, on platforms
3874         that have GNU make (where "make incremental" does not run "make qmake",
3875         but only "make"), we add a similar rule that ensures that any time the
3876         target makefile is regenerated we first run qmake and make on the derived
3877         sources. This rule relies on GNU make's order-only-prerequisites to
3878         not trigger a qmake-run of the target every time we run make.
3879
3880         https://bugs.webkit.org/show_bug.cgi?id=71778
3881
3882         Reviewed by Simon Hausmann.
3883
3884         * qmake/mkspecs/features/functions.prf:
3885
3886 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3887
3888         [Qt][WK2] Remove QWebNavigationController
3889         https://bugs.webkit.org/show_bug.cgi?id=72113
3890
3891         Reviewed by Andreas Kling.
3892
3893         Adapt to the move of the QWebNavigationController functions/properties to
3894         QQuickWebView.
3895
3896         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3897         * MiniBrowser/qt/qml/BrowserWindow.qml:
3898
3899 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3900
3901         [Qt] Build system tweak
3902
3903         Reviewed by Tor Arne Vestbø.
3904
3905         Be a good qmake citizen, return true from our linkStaticLibrary
3906         "test" function.
3907
3908         * qmake/mkspecs/features/functions.prf:
3909
3910 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3911
3912         [Qt] Add support for QT += webkit-private
3913
3914         Reviewed by Tor Arne Vestbø.
3915
3916         * qmake/qt_webkit.pri: Declare private headers.
3917
3918 2011-11-11  Philippe Normand  <pnormand@igalia.com>
3919
3920         Unreviewed, build fix attempt after r99907. Since that revision
3921         GTK layout tests were not running at all...
3922
3923         * Scripts/webkitpy/layout_tests/port/gtk.py:
3924
3925 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
3926
3927         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
3928         https://bugs.webkit.org/show_bug.cgi?id=72001
3929
3930         Reviewed by Dirk Pranke.
3931
3932         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3933
3934 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
3935
3936         bencher script should support remote benchmarking
3937         https://bugs.webkit.org/show_bug.cgi?id=71618
3938
3939         Rubber-stamped by Geoff Garen.
3940         
3941         Added the following features:
3942         
3943         - Benchmark report tells you the hostname and machine model (according to
3944           'sysctl hw.model') of the machine you did the run on, and svn revision number
3945           (according to 'svn info') of the VMs you're testing.
3946         
3947         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
3948           acceptable, in addition to just host, in which case your username is used)
3949           and it automatically packages the build directories of the VMs you're testing,
3950           sends them to the remote machine along with your copy of the bencher script
3951           and all of the options you passed.  This pretty much seamlessly allows you
3952           to run a set of benchmarks on any machine that is sufficiently compatible with
3953           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
3954           must now include a tempPath setting that tells bencher where to put files
3955           when that machine is used as a slave in a remote benchmarking run.
3956           
3957         - Added yet another way of specifying which benchmarks to run. This was sort of
3958           necessary for --remote to work as expected. Previously, you either said what
3959           suites to exclude (for example --exclude-sunspider) or that you only wanted
3960           to run one suite to the exclusion of others (--sunspider-only). But it's
3961           often better to just be able to specify the list of suites you want. This is
3962           now supported. You can say, for example, --v8 --sunspider, which means, just
3963           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
3964           still supported.
3965
3966         * Scripts/bencher:
3967
3968 2011-11-10  Tony Chang  <tony@chromium.org>
3969
3970         Lazily start DRT instances in NRWT
3971         https://bugs.webkit.org/show_bug.cgi?id=72038
3972
3973         Reviewed by Eric Seidel.
3974
3975         Just a refactoring, no new tests.
3976
3977         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3978         * Scripts/webkitpy/layout_tests/port/chromium.py:
3979         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3980         * Scripts/webkitpy/layout_tests/port/test.py:
3981         * Scripts/webkitpy/layout_tests/port/webkit.py:
3982
3983 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
3984
3985         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
3986         https://bugs.webkit.org/show_bug.cgi?id=72057
3987
3988         Reviewed by Eric Seidel.
3989
3990         Make the regular expression more explicit.
3991
3992         * Scripts/webkitpy/common/checkout/changelog.py:
3993         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3994
3995 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
3996
3997         [Qt] X11 plugins need to be reworked for Qt5
3998         https://bugs.webkit.org/show_bug.cgi?id=70023
3999
4000         Reviewed by Simon Hausmann.
4001
4002         Rework our basic plugin support in a way that does
4003         not need a bridge between Qt and X. The solution is
4004         based on getting the content drawed by the plugin
4005         from the server as an image and creating a QImage
4006         from it.
4007
4008         * qmake/mkspecs/features/features.prf: Enable X11
4009         plugins if Qt is built with the xcb-xlib backend.
4010
4011 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
4012
4013         [Qt] Fix keyboard related layout tests after API refactoring
4014
4015         Reviewed by Tor Arne Vestbø.
4016
4017         Send key events to the handling page item, not the view.
4018
4019         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4020         (WTR::PlatformWebView::sendEvent):
4021         (WTR::PlatformWebView::postEvent):
4022
4023 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
4024
4025         [GTK] Make the ENABLE(FEATURE) macro work in DRT
4026         https://bugs.webkit.org/show_bug.cgi?id=71940
4027
4028         Reviewed by Philippe Normand.
4029
4030         * GNUmakefile.am:
4031         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
4032         ENABLE_* variables are part of the environment.
4033
4034 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
4035
4036         [Qt] Fix focus related layout tests after API refactoring
4037
4038         Reviewed by Tor Arne Vestbø.
4039
4040         Make sure the focus is set on the page now, not on the view
4041         (which doesn't actually handle the focus).
4042
4043         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4044         (WTR::WrapperWindow::WrapperWindow):
4045         (WTR::WrapperWindow::handleStatusChanged):
4046
4047 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
4048
4049         [Qt] Merge QTouchWebView and QDesktopWebView into one class
4050         https://bugs.webkit.org/show_bug.cgi?id=71355
4051
4052         Reviewed by Kenneth Rohde Christiansen.
4053
4054         Make MiniBrowser and WebKitTestRunner work again after the
4055         merge.
4056
4057         * MiniBrowser/qt/BrowserWindow.cpp:
4058         (BrowserWindow::BrowserWindow):
4059         (BrowserWindow::webView):
4060         * MiniBrowser/qt/MiniBrowser.pro:
4061         * MiniBrowser/qt/MiniBrowser.qrc:
4062         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4063         * MiniBrowser/qt/main.cpp:
4064         * MiniBrowser/qt/qml/BrowserWindow.qml:
4065         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
4066         * MiniBrowser/qt/qml/TouchView.qml: Removed.
4067         * WebKitTestRunner/PlatformWebView.h:
4068         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4069         (WTR::PlatformWebView::PlatformWebView):
4070
4071 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4072
4073         [Qt] Change semantics of the haveQt() function to match API promises
4074
4075         Having Qt 5 does not imply that we have Qt 4, from an API point of
4076         view, as a major version can in theory break BC/SC. Our minimum
4077         version of Qt 4 will always be the latest released version of Qt 4,
4078         so the only place we should use haveQt(4, x) is when checking for
4079         the minimum requirements.
4080
4081         Reviewed by Simon Hausmann.
4082
4083         * qmake/mkspecs/features/default_pre.prf:
4084         * qmake/mkspecs/features/features.prf:
4085         * qmake/mkspecs/features/functions.prf:
4086
4087 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
4088
4089         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
4090         https://bugs.webkit.org/show_bug.cgi?id=69411
4091
4092         Reviewed by Martin Robinson.
4093
4094         * WebKitTestRunner/EventSenderProxy.h:
4095         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4096         * WebKitTestRunner/TestController.cpp:
4097         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4098         use the EventSender instead of WebProcess Event Simulation.
4099         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4100         (WTR::WTREventQueueItem::WTREventQueueItem):
4101         (WTR::EventSenderProxy::EventSenderProxy):
4102         (WTR::getMouseButtonModifiers):
4103         (WTR::eventSenderButtonToGDKButton):
4104         (WTR::EventSenderProxy::createMouseButtonEvent):
4105         (WTR::EventSenderProxy::updateClickCountForButton):
4106         (WTR::EventSenderProxy::replaySavedEvents):
4107         (WTR::EventSenderProxy::sendOrQueueEvent):
4108         (WTR::webkitModifiersToGDKModifiers):
4109         (WTR::getGDKKeySymForKeyRef):
4110         (WTR::EventSenderProxy::keyDown):
4111         (WTR::EventSenderProxy::mouseDown):
4112         (WTR::EventSenderProxy::mouseUp):
4113         (WTR::EventSenderProxy::mouseMoveTo):
4114         (WTR::EventSenderProxy::mouseScrollBy):
4115         (WTR::EventSenderProxy::leapForward):
4116
4117 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
4118
4119         [Qt] Enable exports and constructor functions in static libs
4120
4121         Reviewed by Tor Arne Vestbø.
4122
4123         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
4124         mac/win32-msvc equivalents when linking static libraries into a shared
4125         library or executable.
4126
4127 2011-11-09  Hayato Ito  <hayato@chromium.org>
4128
4129         [NRWT] Make results.html aware of reference filename in reftests.
4130         https://bugs.webkit.org/show_bug.cgi?id=71574
4131
4132         Reviewed by Ryosuke Niwa.
4133
4134         If a reference filename is different from the default one, include that in result summary
4135         so results.html can link to the correct reference file.
4136
4137         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4138         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4139
4140 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
4141
4142         [wx] Unreviewed build fix. Update project files and
4143         add LTC stubs for new methods.
4144
4145         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4146         (LayoutTestController::addChromeInputField):
4147         (LayoutTestController::removeChromeInputField):
4148         (LayoutTestController::focusWebView):
4149         (LayoutTestController::setBackingScaleFactor):
4150         * waf/build/settings.py:
4151
4152 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
4153
4154         [wx] Unreviewed build fix. Support XCode 4 when building deps.
4155
4156         * wx/install-unix-extras:
4157
4158 2011-11-09  Eric Seidel  <eric@webkit.org>
4159
4160         Remove the concept of platform-dependent unittests
4161         https://bugs.webkit.org/show_bug.cgi?id=71963
4162
4163         Unreviewed.  Fix test-webkitpy on cygwin.
4164
4165         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4166
4167 2011-11-09  Dana Jansens  <danakj@chromium.org>
4168
4169         Add cc-bugs group to watch changes in chromium graphics
4170         https://bugs.webkit.org/show_bug.cgi?id=71690
4171
4172         Reviewed by David Levin.
4173
4174         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
4175         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
4176         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
4177         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
4178
4179 2011-11-09  Eric Seidel  <eric@webkit.org>
4180
4181         Remove more platform-dependent unittests
4182         https://bugs.webkit.org/show_bug.cgi?id=71971
4183
4184         Reviewed by Adam Barth.
4185
4186         Tests which only run on a couple platforms will break.
4187         All tests should run on all platforms where possible.
4188
4189         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4190         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4191         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4192         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4193
4194 2011-11-09  Ojan Vafai  <ojan@chromium.org>
4195
4196         Merge in results to the test results server even if build numbers conflict
4197         https://bugs.webkit.org/show_bug.cgi?id=71967
4198
4199         Reviewed by Tony Chang.
4200
4201         This was initially meant to be a sanity check that we don't
4202         enter duplicate runs, but it turns out that we can reasonably get
4203         in these situations when a builder is clobbered (e.g. the build
4204         numbers start over again from 0).
4205
4206         * TestResultServer/model/jsonresults.py:
4207         * TestResultServer/model/jsonresults_unittest.py:
4208
4209 2011-11-09  Eric Seidel  <eric@webkit.org>
4210
4211         Remove the concept of platform-dependent unittests
4212         https://bugs.webkit.org/show_bug.cgi?id=71963
4213
4214         Reviewed by Adam Barth.
4215
4216         These have been the source of never-ending sadness.
4217         We'd change behavior and forget to update results in
4218         some unittests because they were only run on certain platforms.
4219         This change removes a large source of these platform-dependent
4220         unittests, which was caused by the port_maker stuff.
4221
4222         It's possible that this change will break test-webkitpy
4223         on some platforms, but that will be a one-time cost.
4224         I will fix the breakage by removing the platform-dependantness
4225         of any such broken tests.
4226
4227         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4228         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4229         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4230         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4231         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4232         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4233         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
4234         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4235         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4236         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4237         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4238         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4239         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4240
4241 2011-11-09  Eric Seidel  <eric@webkit.org>
4242
4243         Make the Port object have a Host
4244         https://bugs.webkit.org/show_bug.cgi?id=71961
4245
4246         Reviewed by Adam Barth.
4247
4248         This has been a long time coming.
4249         Now that Port has a Host object, it's very easy
4250         to write unittests which use a properly mocked Port.
4251         Soon we will remove the executive, filesystem and user
4252         members of Port and get everything through the Host.
4253
4254         Note how in many callsites we're actually removing
4255         explicit mocks, since we're now always going to get the
4256         correct Executive/User/FileSystem from the
4257         Host and callsites don't need to be careful to pass each one.
4258
4259         This is prep-work for adding a new Environment member to
4260         Host and needing to be able to access the Environment
4261         member from Port functions w/o needing to pass an Environment
4262         object (or appropriate Mock) every place we create a Port object.
4263         Now that we have a single Host object to reach out through, its
4264         simple to add additional functionality (like Environment) while
4265         keeping our unittests properly mocked.
4266
4267         * Scripts/webkitpy/common/host.py:
4268         * Scripts/webkitpy/common/net/credentials_unittest.py: