2011-02-03 Hayato Ito <hayato@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-03  Hayato Ito  <hayato@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
6         move _run_single_test() and _process_output() functions from
7         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
8
9         This is clean up and acts as a preparation for elimination of test_types/*
10         classes. These classes will move to the single_test_runner module introduced
11         in this patch.
12
13         https://bugs.webkit.org/show_bug.cgi?id=53004
14
15         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
16         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
17         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
18         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
19         * Scripts/webkitpy/layout_tests/port/base.py:
20         * Scripts/webkitpy/layout_tests/port/chromium.py:
21         * Scripts/webkitpy/layout_tests/port/dryrun.py:
22         * Scripts/webkitpy/layout_tests/port/test.py:
23         * Scripts/webkitpy/layout_tests/port/webkit.py:
24         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
25         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
26         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
27
28 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
29
30         Unreviewed, build fix.
31
32         Delete a line that was accidentally missed in r77586; without it
33         there is still a race between the two threads.
34
35         https://bugs.webkit.org/show_bug.cgi?id=51572
36
37         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
38
39 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
40
41         Reviewed by Tony Chang.
42
43         nrwt: handle "broken pipe" notifications from DRT more cleanly.
44
45         https://bugs.webkit.org/show_bug.cgi?id=52927
46
47         * Scripts/webkitpy/layout_tests/port/server_process.py:
48         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
49
50 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
51
52         Reviewed by Kenneth Russell.
53
54         Update, resubmit change to bug 51572. I think the race that was
55         fixed in r76703 caused the hang that caused us to roll this
56         patch out before, so I'd like to try again.
57
58         https://bugs.webkit.org/show_bug.cgi?id=51572
59
60         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
61         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
62
63 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
64
65         Unreviewed.
66
67         Adding myself to committers.py.
68
69         * Scripts/webkitpy/common/config/committers.py:
70
71 2011-02-03  Adam Roben  <aroben@apple.com>
72
73         Include the crashing function in the link to a crash log
74
75         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
76         function that crashed
77
78         Reviewed by David Kilzer.
79
80         * Scripts/old-run-webkit-tests:
81         (crashLocation): Added. Returns the location of the crash.
82         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
83         could be determined.
84
85 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
86
87         Unreviewed, build fix.
88
89         Actually make the changes suggested by Mihai in his review
90         of bug 53720 :(
91
92         https://bugs.webkit.org/show_bug.cgi?id=53720
93
94         * Scripts/webkitpy/layout_tests/port/test_files.py:
95         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
96
97 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
98
99         Reviewed by Mihai Parparita.
100
101         new-run-webkit-tests: Fix bug introduced in r77434 that was
102         causing us to run the canvas GPU tests on the Mac GPU port. This
103         bug revealed that we were not setting the port.name() field
104         properly in many cases, so I've cleaned up all of that code, and
105         removed a few comments about "version-specific" GPU ports that
106         don't exist and just confused things.
107
108         Testing also revealed that port.abspath_for_test() wasn't
109         normalizing paths on Windows properly, so I fixed that as well.
110
111         https://bugs.webkit.org/show_bug.cgi?id=53719
112
113         * Scripts/webkitpy/layout_tests/port/base.py:
114         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
115         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
116
117 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
118
119         Reviewed by Mihai Parparita.
120
121         new-run-webkit-tests: fix normalization of paths on windows when gathering files
122
123         r77434 introduced a bug that was causing the test expectations
124         for the GPU ports to not be treated properly. It turns out that
125         when we gathered the list of test files on Windows, we would
126         return paths of the form "c:\LayoutTests/fast/canvas", and the
127         mixture of backslashes and forward slashes was confusing things.
128
129         This patch normalizes all of the filenames returned from
130         test_files.find(), and adds better tests for this (fixing a
131         couple of other bugs found in the meantime).
132
133         https://bugs.webkit.org/show_bug.cgi?id=53720
134
135         * Scripts/webkitpy/layout_tests/port/test.py:
136         * Scripts/webkitpy/layout_tests/port/test_files.py:
137         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
138
139 2011-02-03  Adam Roben  <aroben@apple.com>
140
141         Add links to Windows crash logs in results.html
142
143         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
144         results.html
145
146         Reviewed by David Kilzer.
147
148         * Scripts/old-run-webkit-tests:
149         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
150         createDebuggerCommandFile).
151         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
152         tool has exited.
153         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
154         it into the test results directory tree. Only implemented for Cygwin currently.
155         (findNewestFileMatchingGlob): Added. Does what it says.
156         (htmlForResultsSection): Only link to files that exist.
157         (linksForErrorTest): Add a link to the crash log.
158         (deleteExpectedAndActualResults): Delete any old crash log for this test.
159         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
160         hardcoding it here.
161
162 2011-02-03  Adam Roben  <aroben@apple.com>
163
164         Tell the debugger the path to the WebKit source tree when saving a crash log
165
166         This allows the debugger to include the crashing line of code in the log.
167
168         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
169         of code
170
171         Reviewed by Sam Weinig.
172
173         * Scripts/old-run-webkit-tests:
174         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
175         file and returns the path to that file. The commands we pass came from
176         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
177         WebKit source code lives.
178         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
179         line using -c, save them to a file and specify the path to that file using -cf. This works
180         around what is presumably a bug in Windows's command line parsing, where having multiple
181         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
182         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
183         together to make them easier to modify in the future.
184
185 2011-02-02  Sam Weinig  <sam@webkit.org>
186
187         Reviewed by Anders Carlsson.
188
189         Add notification of the end of a rubber band.
190         <rdar://problem/8940648>
191
192         * MiniBrowser/mac/BrowserWindowController.m:
193         (-[BrowserWindowController awakeFromNib]):
194         * WebKitTestRunner/TestController.cpp:
195         (WTR::TestController::createOtherPage):
196         (WTR::TestController::initialize):
197         Stub out the new WKUIClient function.
198
199 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
200
201         Unreviewed.
202
203         Adding myself to committers.py.
204
205         * Scripts/webkitpy/common/config/committers.py:
206
207 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
208
209         Reviewed by Csaba Osztrogonác.
210
211         [Qt][WK2] MiniBrowser's window size should be 800x600
212         https://bugs.webkit.org/show_bug.cgi?id=53670
213
214         Make layout test failure debugging easier.
215         * MiniBrowser/qt/BrowserWindow.cpp:
216         (BrowserWindow::BrowserWindow):
217
218 2011-02-02  Andy Estes  <aestes@apple.com>
219
220         Reviewed by Mark Rowe.
221
222         'update-webkit' should handle OpenSource and Internal using different
223         VCSs.
224
225         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
226         Internal directory.
227
228 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
229
230         Reviewed by Mihai Parparita.
231
232         new-run-webkit-tests: hardcode the directories to scan for tests
233         for GPU bots instead of SKIPping them. See bug 53562 for some
234         context, but we will now hard-code the list of directories to
235         use by default instead of skipping over directories in the
236         expectations file. We do this so that we will be able to merge
237         the expectations files without getting conflicting SKIP
238         directives. Note that this change will reduce the # of tests
239         being run on the Mac GPU bots, because we're accidentally
240         including some today.
241
242         https://bugs.webkit.org/show_bug.cgi?id=53631
243
244         * Scripts/webkitpy/layout_tests/port/base.py:
245         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
246         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
247
248 2011-02-02  Sam Weinig  <sam@webkit.org>
249
250         Reviewed by Beth Dakin.
251
252         Add ChromeClient function to paint custom overhang areas.
253         https://bugs.webkit.org/show_bug.cgi?id=53639
254
255         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
256         (WTR::InjectedBundlePage::InjectedBundlePage):
257         Stub out new callback.
258
259 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
260
261         Reviewed by Tony Chang.
262
263         new-run-webkit-tests: support chromium code paths in mock_drt
264
265         https://bugs.webkit.org/show_bug.cgi?id=53471
266
267         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
268         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
269
270 2011-02-02  Adam Klein  <adamk@chromium.org>
271
272         Reviewed by Tony Chang.
273
274         Update new-run-webkit-tests --chromium to put output under Source/...
275         https://bugs.webkit.org/show_bug.cgi?id=53612
276
277         * BuildSlaveSupport/test-result-archive:
278         * Scripts/webkitpy/layout_tests/port/chromium.py:
279
280 2011-01-28  Tony Chang  <tony@chromium.org>
281
282         Reviewed by Eric Seidel.
283
284         [chromium] remove --use-test-shell from NRWT
285         https://bugs.webkit.org/show_bug.cgi?id=53346
286
287         I've already started removing some of the bindings like eventSender so
288         this already doesn't work isn't useful.  Also updated some comments to
289         refer to DRT instead of test_shell.
290
291         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
292         * Scripts/webkitpy/layout_tests/port/chromium.py:
293         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
294         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
295         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
296         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
297         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
298         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
299
300 2011-02-02  Steve Lacey  <sjl@chromium.org>
301
302         Reviewed by Eric Carlson.
303
304         Implement basic media statistics on media elements.
305         https://bugs.webkit.org/show_bug.cgi?id=53322
306
307         * Scripts/build-webkit:
308
309 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
310
311         [wx] Build fixes for wxWebKit.
312
313         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
314         (LayoutTestController::setSerializeHTTPLoads):
315         * wx/browser/wscript:
316         * wx/build/build_utils.py:
317         * wx/build/settings.py:
318
319 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
320
321         Reviewed by Mihai Parparita.
322
323         new-run-webkit-tests: stop skipping so many tests
324
325         r77163 introduced a regression where we weren't resetting test
326         expectations properly and were skipping too many tests as a
327         result. This patch fixes that and adds a test for it.
328
329         https://bugs.webkit.org/show_bug.cgi?id=53551
330
331         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
332         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
333
334 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
335
336         Reviewed by Tony Chang.
337
338         new-run-webkit-tests: add first stub of test_runner2. This
339         will add support for the 'inline', 'threads', and 'processes'
340         flags to --worker-model, but for now the implementatios just
341         fall back on the old ones.
342
343         https://bugs.webkit.org/show_bug.cgi?id=53157
344
345         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
346         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
347
348 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
349
350         Reviewed by James Robinson.
351
352         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
353         https://bugs.webkit.org/show_bug.cgi?id=53522
354
355         * Scripts/run-chromium-webkit-unit-tests:
356
357 2011-02-01  Adam Barth  <abarth@webkit.org>
358
359         Reviewed by Mihai Parparita.
360
361         Using Control-C to cancel webkit-patch or other python tools causes
362         unpleasant traceback console spew
363         https://bugs.webkit.org/show_bug.cgi?id=53462
364
365         Catch the exception and don't print the stack trace.
366
367         * Scripts/webkit-patch:
368
369 2011-02-01  Scott Cameron  <sccameron@rim.com>
370
371         Reviewed by Daniel Bates.
372
373         Use Windows format for MinGW HTTPD path.
374         https://bugs.webkit.org/show_bug.cgi?id=53503
375
376         * Scripts/webkitperl/httpd.pm:
377           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
378             so that we don't have to escape the space characters in the path. Also,
379             changed path to Windows-style path and removed FIXME comment.
380
381 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
382
383         Reviewed by Andreas Kling.
384
385         [Qt][WK2] Add a way to use shared process model in MiniBrowser
386         https://bugs.webkit.org/show_bug.cgi?id=53090
387
388         * MiniBrowser/qt/BrowserView.cpp:
389         (BrowserView::BrowserView): Removed the m_context member.
390         From now the context is guaranteed to be non-null and we
391         don't need to store that in the object.
392         * MiniBrowser/qt/BrowserView.h:
393         * MiniBrowser/qt/BrowserWindow.cpp:
394         Added static bool to determine that new windows need to be
395         created with their own context or not. Use the same context
396         and web process by default to be inilne with the other ports.
397         (BrowserWindow::BrowserWindow):
398         (BrowserWindow::newWindow):
399         * MiniBrowser/qt/BrowserWindow.h:
400         * MiniBrowser/qt/main.cpp:
401         (main): Added command line switch to be able to use the
402         non-shared process model. Simplify the handling of the command line
403         switches a little bit.
404
405 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
406
407         Reviewed by Andreas Kling.
408
409         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
410         https://bugs.webkit.org/show_bug.cgi?id=53491
411
412         * MiniBrowser/qt/BrowserWindow.cpp:
413         (BrowserWindow::BrowserWindow):
414         (BrowserWindow::toggleFullScreenMode):
415         * MiniBrowser/qt/BrowserWindow.h:
416
417 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
418
419         Reviewed by Andreas Kling.
420
421         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
422         https://bugs.webkit.org/show_bug.cgi?id=53489
423
424         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
425         to Settings menu.
426
427         * MiniBrowser/qt/BrowserWindow.cpp:
428         (BrowserWindow::BrowserWindow):
429         (BrowserWindow::toggleFrameFlattening):
430         (BrowserWindow::toggleDisableJavaScript):
431         (BrowserWindow::toggleAutoLoadImages):
432         * MiniBrowser/qt/BrowserWindow.h:
433
434 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
435
436         Reviewed by Tony Chang.
437
438         [Chromium] Switch chromium-mac to use ChromiumDriver
439         https://bugs.webkit.org/show_bug.cgi?id=53461
440         
441         For the sake of consistency with the other Chromium platforms (and so
442         that chromium-mac picks up special flags like --enable-hardware-gpu),
443         switch chromium-mac from the WebKitDriver to ChromiumDriver.
444
445         * Scripts/webkitpy/layout_tests/port/chromium.py:
446
447 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
448
449         Reviewed by Mihai Parparita.
450
451         The current modifier parsing code in test_expectations is
452         fragile and hard-coded, so it's not easy to understand the logic
453         or easily add new types of modifiers (like GPU vs. CPU testing
454         for graphics tests, or 32-bit vs. 64-bit differences).
455
456         This is the first of two patches that will add in more generic
457         support and then eliminate the GPU-specific test expectations
458         files for Chromium.
459
460         This patch adds two standalone objects for handling modifiers. The
461         rules for interpreting modifiers, precedence, and conflicts are
462         given in the docstring to the ModifierMatcher class, which
463         returns ModifierMatchResult objects.
464         
465         This patch also adds routines to the Port interface and a
466         default set of values in the base object, in order to obtain the
467         values needed on a given test run. These values are then passed
468         to the expectation parser. This also allows us to clean up the
469         logic used to lint all of the different configurations in a
470         single test_expectations.txt file.
471
472         The next patch will merge in the separate GPU expectations file.
473
474         https://bugs.webkit.org/show_bug.cgi?id=51222
475
476         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
477         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
478         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
479         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
480         * Scripts/webkitpy/layout_tests/port/base.py:
481         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
482         * Scripts/webkitpy/layout_tests/port/chromium.py:
483         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
484         * Scripts/webkitpy/layout_tests/port/test.py:
485         * Scripts/webkitpy/layout_tests/port/webkit.py:
486         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
487         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
488         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
489         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
490         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
491
492 2011-01-31  Scott Cameron  <sccameron@rim.com>
493
494         Reviewed by Daniel Bates.
495
496         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
497         https://bugs.webkit.org/show_bug.cgi?id=50036
498
499         This will add an Apache2.2 configuration file and modifies scripts to allow
500         running an httpd server in an MSYS environment.
501
502         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
503         in order to allow for simple installation/execution.  Simply install the latest
504         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
505         be able to execute run-webkit-httpd.
506         
507
508         * Scripts/run-webkit-httpd:
509         * Scripts/webkitperl/httpd.pm:
510
511 2011-01-31  Tony Chang  <tony@chromium.org>
512
513         Reviewed by Eric Seidel.
514
515         mac DRT should report RTL scroll offset relative to top right corner
516         https://bugs.webkit.org/show_bug.cgi?id=53324
517
518         * DumpRenderTree/mac/DumpRenderTree.mm:
519         (dumpFrameScrollPosition):
520
521 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
522
523         Reviewed by Andreas Kling.
524
525         [Qt] Add Take Screen Shot action to MiniBrowser
526         https://bugs.webkit.org/show_bug.cgi?id=53422
527
528         Add Take Screen Shot action to MiniBrowser's view menu.
529
530         * MiniBrowser/qt/BrowserWindow.cpp:
531         (BrowserWindow::BrowserWindow):
532         (BrowserWindow::screenshot):
533         * MiniBrowser/qt/BrowserWindow.h:
534
535 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
536
537         Reviewed by Xan Lopez.
538
539         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
540         https://bugs.webkit.org/show_bug.cgi?id=53379
541
542         Remove left over #ifdef's. I thought all of the conditional code
543         had been freed from the condition, but I forgot to check DRT.
544
545         * DumpRenderTree/gtk/DumpRenderTree.cpp:
546         (resetDefaultsToConsistentValues):
547         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
548         (LayoutTestController::setAlwaysAcceptCookies):
549
550 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
551
552         Unreviewed, build fix.
553
554         Fix regression introduced in r77093 - path.rsplit() doesn't
555         take keyword arguments.
556
557         https://bugs.webkit.org/show_bug.cgi?id=53326
558
559         * Scripts/webkitpy/common/system/filesystem_mock.py:
560
561 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
562
563         Reviewed by Mihai Parparita.
564
565         Add more unit tests for rebaseline-chromium-webkit-tests. This
566         change involves restructuring a bunch of r-c-w-t code to make it
567         more testable as well. We also add wrapper classes for handling
568         testing zip files and fetching URLs.
569
570         https://bugs.webkit.org/show_bug.cgi?id=53040
571
572         * Scripts/webkitpy/common/system/urlfetcher.py:
573         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
574         * Scripts/webkitpy/common/system/zipfileset_mock.py:
575         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
576         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
577         * Scripts/webkitpy/tool/mocktool.py:
578
579 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
580
581         Reviewed by Eric Seidel.
582
583         Clean up of the filesystem-related modules used in webkitpy.
584         I've added relpath() to the filesystem interface, modified
585         ospath.relpath() so that it could work with the filesystem
586         interface, and modified the fileset* routines to use the
587         filesystem interface consistently.
588
589         This patch also adds a close() routine to the fileset routines
590         to indicate that the caller is done with the fileset. This
591         allows zipfileset to clean up after itself when it creates
592         tempfiles to store downloads.
593
594         https://bugs.webkit.org/show_bug.cgi?id=53326
595
596         * Scripts/webkitpy/common/system/directoryfileset.py:
597         * Scripts/webkitpy/common/system/fileset.py:
598         * Scripts/webkitpy/common/system/filesystem.py:
599         * Scripts/webkitpy/common/system/filesystem_mock.py:
600         * Scripts/webkitpy/common/system/filesystem_unittest.py:
601         * Scripts/webkitpy/common/system/ospath.py:
602         * Scripts/webkitpy/common/system/zipfileset.py:
603         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
604
605 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
606
607         Reviewed by Csaba Osztrogonác.
608
609         [Qt][WK2]REGRESSION (r76991): Fix build errors
610         https://bugs.webkit.org/show_bug.cgi?id=53400
611
612         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
613         and remove WebKit2Prefix.h from the build.
614         * MiniBrowser/qt/MiniBrowser.pro:
615
616 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
617
618         Unreviewed.
619
620         [Qt][WK2] Buildfix.
621
622         * MiniBrowser/qt/MiniBrowser.pro:
623
624 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
625
626         Reviewed by Adam Roben.
627         
628         define NOMINMAX when building ImageDiff, as we do elsewhere.
629
630         Add various clampToInt() methods to MathExtras.h
631         https://bugs.webkit.org/show_bug.cgi?id=52910
632
633         * DumpRenderTree/win/ImageDiffCommon.vsprops:
634
635 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
636
637         Reviewed by Darin Adler.
638
639         WebKitTestRunner needs layoutTestController.setPOSIXLocale
640         https://bugs.webkit.org/show_bug.cgi?id=42682
641
642         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
643         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
644         (WTR::InjectedBundle::resetLocalSettings):
645         (WTR::InjectedBundle::didReceiveMessage):
646         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
647         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
648         (WTR::LayoutTestController::setPOSIXLocale):
649         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
650
651 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
652  
653          Reviewed by Mihai Parparita.
654  
655          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
656  
657          This patch re-enables this test and changes it to
658          handle all of the mac platform versions, not just the one
659          it is running on.
660  
661          https://bugs.webkit.org/show_bug.cgi?id=53356
662  
663          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
664  
665 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
666
667         Unreviewed, build fix.
668
669         Take two. The fix in 77023 didn't work, because we were
670         still calling path.abspath_to_uri, which calls _cygpath under
671         the covers, and it appears the cygpath on the bots does
672         something different than it does on my machine. This patch
673         removes the calls to path.abspath_to_uri, so it should be safe.
674         If it doesn't work, I'll roll it out along with r76982 and 77023.
675
676         https://bugs.webkit.org/show_bug.cgi?id=53126
677
678         * Scripts/webkitpy/layout_tests/port/test.py:
679
680 2011-01-28  David Kilzer  <ddkilzer@apple.com>
681
682         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
683         <http://webkit.org/b/53353>
684
685         Reviewed by Mark Rowe.
686
687         * Scripts/webkitdirs.pm:
688         (checkRequiredSystemConfig): Check the Xcode marketing version
689         in addition to the DevCoreTools build version before complaining
690         about an old version of Xcode.  Also make the Mac OS X version
691         check use Perl's built-in version string comparitor.
692
693 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
694
695         Unreviewed, build fix.
696
697         Work around breakage on Win 7 Release bot caused by r76982
698         and the fact that windows ports use "file:////" instead of
699         "file:///". Ideally the test code should be isolated from
700         this, but it isn't yet. Will fix properly in a bit.
701
702         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
703
704 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
705
706         Reviewed by Tony Chang.
707
708         new-run-webkit-tests: change worker model values to
709         "old-inline", "old-threads" in preparation for test_runner2 /
710         multiprocessing changes.
711
712         https://bugs.webkit.org/show_bug.cgi?id=53156
713
714         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
715         * Scripts/webkitpy/layout_tests/port/base.py:
716         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
717         * Scripts/webkitpy/layout_tests/port/mac.py:
718         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
719
720 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
721
722         Reviewed by Tony Chang.
723
724         committers.py - add an IRC nickname for dpranke
725         https://bugs.webkit.org/show_bug.cgi?id=53335
726
727         * Scripts/webkitpy/common/config/committers.py:
728
729 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
730
731         Reviewed by Tony Chang.
732
733         new-run-webkit-tests: add a "mock DRT" port implementation
734         and a separate class that emulates what we expect the
735         DumpRenderTree behavior to be.
736
737         This will eventually replace port/dryrun.py and allow us to get
738         better test coverage of the new-run-webkit-tests code as well as
739         a reference for what new-run-webkit-tests expects from DRT.
740
741         This is the first attempt at this, and it is pretty bare-boned. It
742         really only has been tested on the 'mac' port (and a little on
743         the 'chromium-mac' port.
744
745         https://bugs.webkit.org/show_bug.cgi?id=53126
746
747         * Scripts/webkitpy/common/system/filesystem_mock.py:
748         * Scripts/webkitpy/layout_tests/port/dryrun.py:
749         * Scripts/webkitpy/layout_tests/port/factory.py:
750         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
751         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
752         * Scripts/webkitpy/layout_tests/port/test.py:
753
754 2011-01-28  Pratik Solanki  <psolanki@apple.com>
755
756         Unreviewed. Removing .swp file checked in by mistake.
757
758         * Scripts/.webkitdirs.pm.swp: Removed.
759
760 2011-01-28  Pratik Solanki  <psolanki@apple.com>
761
762         Reviewed by David Kilzer.
763
764         Space not necessary for undefined feature
765         https://bugs.webkit.org/show_bug.cgi?id=53317
766
767         * Scripts/build-webkit:
768
769 2011-01-28  Chang Shu  <chang.shu@nokia.com>
770
771         Reviewed by Andreas Kling.
772
773         Reset NetworkAccessManager to clean up credentials from previous tests.
774         This change causes no performance overhead either.
775         https://bugs.webkit.org/show_bug.cgi?id=36688
776
777         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
778         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
779         (WebCore::DumpRenderTree::open):
780         * DumpRenderTree/qt/DumpRenderTreeQt.h:
781
782 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
783
784         Reviewed by Andreas Kling.
785
786         [Qt] Add Zoom Text Only action to MiniBrowser
787         https://bugs.webkit.org/show_bug.cgi?id=53297
788
789         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
790
791         * MiniBrowser/qt/BrowserWindow.cpp:
792         (BrowserWindow::BrowserWindow):
793         (BrowserWindow::zoomIn):
794         (BrowserWindow::zoomOut):
795         (BrowserWindow::resetZoom):
796         (BrowserWindow::toggleZoomTextOnly):
797         (BrowserWindow::applyZoom):
798         * MiniBrowser/qt/BrowserWindow.h:
799
800 2011-01-28  Adam Barth  <abarth@webkit.org>
801
802         Reviewed by Eric Seidel.
803
804         Add webkit-patch roll-chromium-deps
805         https://bugs.webkit.org/show_bug.cgi?id=53288
806
807         This command updates the Source/WebKit/chromium/DEPS file with the
808         last-known good revision of Chromium (or a revision specified on the
809         command line).  I'd eventually like to turn this into a SheriffBot
810         command, but this is the first step.
811
812         This patch somewhat sprawled because I needed to move a bunch of code
813         out of ChangeLog that should never have been there in the first place.
814         Also, I had to fix a bug in MockUser in order to test the new command.
815
816         * Scripts/webkitpy/common/checkout/api.py:
817         * Scripts/webkitpy/common/checkout/changelog.py:
818         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
819         * Scripts/webkitpy/common/checkout/deps.py: Added.
820         * Scripts/webkitpy/common/config/urls.py:
821         * Scripts/webkitpy/tool/commands/__init__.py:
822         * Scripts/webkitpy/tool/commands/download_unittest.py:
823         * Scripts/webkitpy/tool/commands/roll.py: Added.
824         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
825         * Scripts/webkitpy/tool/commands/upload_unittest.py:
826         * Scripts/webkitpy/tool/mocktool.py:
827         * Scripts/webkitpy/tool/steps/__init__.py:
828         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
829         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
830         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
831         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
832         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
833         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
834
835 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
836
837         Reviewed by Laszlo Gombos.
838
839         Get rid of prefix header dependency for WebKit2 build system
840         https://bugs.webkit.org/show_bug.cgi?id=50174
841
842         Change the style checker so that it enforces config.h include for
843         WebKit2.
844
845         * Scripts/webkitpy/style/checker.py:
846
847 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
848
849         Reviewed by Darin Adler.
850
851         execCommand("Paste") doesn't work in WebKitTestRunner
852         https://bugs.webkit.org/show_bug.cgi?id=52785
853
854         Enable both of the settings needed to allow paste.
855         
856         * WebKitTestRunner/TestController.cpp:
857         (WTR::TestController::resetStateToConsistentValues):
858
859 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
860
861         Reviewed by Andreas Kling.
862
863         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
864         https://bugs.webkit.org/show_bug.cgi?id=48440
865
866         Preserve user input when toggling use of QGraphicsView
867
868         * QtTestBrowser/launcherwindow.cpp:
869         (LauncherWindow::initializeView):
870         (LauncherWindow::loadFinished):
871         * QtTestBrowser/launcherwindow.h:
872         * QtTestBrowser/mainwindow.cpp:
873         (MainWindow::addressUrl):
874         * QtTestBrowser/mainwindow.h:
875
876 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
877
878         Reviewed by Mihai Parparita.
879
880         new-run-webkit-tests: turn off pixel tests correctly by default
881         for webkit-based ports. r70013 (bug 47510) used
882         port.set_option_default() to attempt to set default values, but
883         that didn't work correctly. I have removed set_option_default
884         for now since it was only being used in two places and in three
885         useless unit tests. There is a separate bug open to fix the
886         option parsing (48095), so this workaround is fine for now.
887
888         https://bugs.webkit.org/show_bug.cgi?id=53217
889
890         * Scripts/webkitpy/layout_tests/port/webkit.py:
891         * Scripts/webkitpy/layout_tests/port/base.py:
892         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
893
894 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
895
896         Rubber-stamped by Ariya Hidayat.
897
898         Trivial crash fix in WTR.
899
900         * WebKitTestRunner/TestController.cpp:
901         (WTR::TestController::initialize): Increase the size
902         of the vector by one to be able to store the null character.
903
904 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
905
906         Reviewed by Csaba Osztrogonác.
907
908         [Qt][WK2] WTR should be initialized in the same way as DRT
909         https://bugs.webkit.org/show_bug.cgi?id=53240
910
911         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
912         (WTR::activateFonts): Added missing initialization steps.
913
914 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
915
916         Unreviewed. 
917
918         Adding myself to committers.py.
919
920         * Scripts/webkitpy/common/config/committers.py:
921
922 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
923
924         Reviewed by Csaba Osztrogonác.
925
926         [Qt] [Symbian] Move project files into Source
927         https://bugs.webkit.org/show_bug.cgi?id=52891
928
929         Fix the Symbian build after the project files
930         are moved to Source directory. On Symbian qmake
931         needs to run in the same directory where the main
932         pro files (WebKit.pro, Tools.pro) are located.
933
934         * Scripts/webkitdirs.pm: Change to the directory where the pro file
935         is located before running qmake for Symbian. Qmake on Symbian
936         does not properly honor the "-o" option, work it around by setting
937         the name of the Makefile to bld.inf.
938
939 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
940
941         Reviewed by Andreas Kling.
942
943         [Qt] Add simple zooming features to MiniBrowser
944         https://bugs.webkit.org/show_bug.cgi?id=53231
945
946         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
947
948         * MiniBrowser/qt/BrowserWindow.cpp:
949         (BrowserWindow::BrowserWindow):
950         (BrowserWindow::zoomIn):
951         (BrowserWindow::zoomOut):
952         (BrowserWindow::resetZoom):
953         (BrowserWindow::updateUserAgentList):
954         (BrowserWindow::applyZoom):
955         * MiniBrowser/qt/BrowserWindow.h:
956
957 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
958
959         Reviewed by Dan Bernstein.
960
961         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
962         https://bugs.webkit.org/show_bug.cgi?id=42319
963         
964         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
965
966         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
967         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
968         (WTR::LayoutTestController::showWebInspector):
969         (WTR::LayoutTestController::closeWebInspector):
970         (WTR::LayoutTestController::evaluateInWebInspector):
971         (WTR::LayoutTestController::setTimelineProfilingEnabled):
972         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
973         * WebKitTestRunner/TestInvocation.cpp:
974         (WTR::shouldOpenWebInspector):
975         (WTR::TestInvocation::invoke):
976         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
977
978 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
979
980         Reviewed by Xan Lopez.
981
982         [GTK] Pixel dumps do not include scrollbars in output images
983         https://bugs.webkit.org/show_bug.cgi?id=53216
984
985         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
986         that have scrollbars.
987
988         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
989         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
990         instead of the web view itself.
991
992 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
993
994         Reviewed by Mihai Parparita.
995
996         Fix regression introduced in r76322 ... new-run-webkit-tests
997         was attempting to save the image diff output as a UTF-8-encoded
998         file.
999
1000         https://bugs.webkit.org/show_bug.cgi?id=53210
1001
1002         * Scripts/webkitpy/layout_tests/port/webkit.py:
1003
1004 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1005
1006         Unreviewed, rolling out r76709.
1007         http://trac.webkit.org/changeset/76709
1008         https://bugs.webkit.org/show_bug.cgi?id=53194
1009
1010         "broke python tests on non-snowleopard platforms" (Requested
1011         by dpranke on #webkit).
1012
1013         * Scripts/webkitpy/layout_tests/port/factory.py:
1014         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1015         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1016
1017 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1018
1019         Reviewed by Tony Chang.
1020
1021         new-run-webkit-tests: add a "mock DRT" port implementation
1022         and a separate class that emulates what we expect the
1023         DumpRenderTree behavior to be.
1024
1025         This will eventually replace port/dryrun.py and allow us to get
1026         better test coverage of the new-run-webkit-tests code as well as
1027         a reference for what new-run-webkit-tests expects from DRT.
1028
1029         This is the first attempt at this, and it is pretty bare-boned. It
1030         really only has been tested on the 'mac' port (and a little on
1031         the 'chromium-mac' port.
1032
1033         https://bugs.webkit.org/show_bug.cgi?id=53126
1034
1035         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1036         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1037         * Scripts/webkitpy/layout_tests/port/factory.py:
1038
1039 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1040
1041         Reviewed by Tony Chang.
1042
1043         Add '--no-timeout' option to Chromium DRT to ease debugging.
1044         https://bugs.webkit.org/show_bug.cgi?id=52873
1045
1046         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1047         (main):
1048
1049 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1050
1051         Reviewed by Andreas Kling.
1052
1053         [Qt] Fix qt_minimal build
1054         https://bugs.webkit.org/show_bug.cgi?id=53172
1055
1056         * QtTestBrowser/locationedit.h:
1057
1058 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1059
1060         Reviewed by Antonio Gomes.
1061
1062         QtTestBrowser should have a UI Setting to disable plugins
1063         https://bugs.webkit.org/show_bug.cgi?id=52408
1064         
1065         Added a new action item named "Disable Plugins"
1066         under the "Settings" menu. 
1067
1068         * QtTestBrowser/launcherwindow.cpp:
1069         (LauncherWindow::createChrome):
1070         (LauncherWindow::togglePlugins):
1071         * QtTestBrowser/launcherwindow.h:
1072
1073 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1074
1075         Reviewed by Adam Barth.
1076
1077         Move main CMakeLists.txt into Source directory
1078         https://bugs.webkit.org/show_bug.cgi?id=52888
1079
1080         * Scripts/webkitdirs.pm:
1081
1082 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1083
1084         Reviewed by Eric Seidel.
1085
1086         Improve label text in submit-to-ews
1087         https://bugs.webkit.org/show_bug.cgi?id=53130
1088
1089         * QueueStatusServer/templates/submittoews.html:
1090
1091 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1092
1093         Reviewed by Antonio Gomes.
1094
1095         QtTestBrowser should have a UI Settings to prevent loading images
1096         https://bugs.webkit.org/show_bug.cgi?id=52409
1097         
1098         Added a new action item named "DisableAutoLoadImages"
1099         under the "Settings" menu 
1100
1101         * QtTestBrowser/launcherwindow.cpp:
1102         (LauncherWindow::createChrome):
1103         (LauncherWindow::toggleAutoLoadImages):
1104         * QtTestBrowser/launcherwindow.h:
1105
1106 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1107
1108         Reviewed by Tony Chang.
1109
1110         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1111         classes, test_expectations.py. This change adds "test-win" and
1112         "test-mac" variants to the test port so that we can better test
1113         rebaselining, and adds a MockUser() object for reuse in testing.
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=53036
1116
1117         * Scripts/webkitpy/common/system/filesystem.py:
1118         * Scripts/webkitpy/common/system/filesystem_mock.py:
1119         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1120         * Scripts/webkitpy/layout_tests/port/factory.py:
1121         * Scripts/webkitpy/layout_tests/port/base.py:
1122         * Scripts/webkitpy/layout_tests/port/test.py:
1123         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1124         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1125         * Scripts/webkitpy/tool/mocktool.py:
1126
1127 2011-01-25  Tony Chang  <tony@chromium.org>
1128
1129         Reviewed by Dimitri Glazkov.
1130
1131         [chromium] remove unused layoutTestController callback
1132         https://bugs.webkit.org/show_bug.cgi?id=53103
1133
1134         This method is used by a test_shell_test, but not needed by DRT.
1135
1136         * DumpRenderTree/chromium/LayoutTestController.cpp:
1137         (LayoutTestController::LayoutTestController):
1138         * DumpRenderTree/chromium/LayoutTestController.h:
1139
1140 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1141
1142         Reviewed by Andreas Kling.
1143
1144         [GTK] Remove 64 bits release bot from the buildbot master
1145         https://bugs.webkit.org/show_bug.cgi?id=52899
1146
1147         Removes the 64 bits release slave from the buildbot configuration,
1148         so that we can use it as an EWS.
1149
1150         * BuildSlaveSupport/build.webkit.org-config/config.json:
1151
1152 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1153
1154         Reviewed by Dan Bernstein.
1155
1156         Implement database quota callback to fix storage tests on WebKit2 bot
1157         https://bugs.webkit.org/show_bug.cgi?id=53064
1158
1159         * WebKitTestRunner/TestController.cpp:
1160         (WTR::exceededDatabaseQuota):
1161         (WTR::TestController::createOtherPage):
1162         (WTR::TestController::initialize):
1163
1164 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1165
1166         Reviewed by Anders Carlsson.
1167
1168         Use designated temp directory for the database for WebKit2
1169         https://bugs.webkit.org/show_bug.cgi?id=53052
1170         
1171         Adopt the new WK2 API for this.
1172
1173         * WebKitTestRunner/TestController.cpp:
1174         (WTR::TestController::libraryPathForTesting):
1175         (WTR::TestController::initialize):
1176         * WebKitTestRunner/TestController.h:
1177         * WebKitTestRunner/mac/TestControllerMac.mm:
1178         (WTR::TestController::platformLibraryPathForTesting):
1179         * WebKitTestRunner/qt/TestControllerQt.cpp:
1180         (WTR::TestController::platformLibraryPathForTesting):
1181         * WebKitTestRunner/win/TestControllerWin.cpp:
1182         (WTR::TestController::platformLibraryPathForTesting):
1183
1184 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1185
1186         Reviewed by Stephanie Lewis.
1187
1188         Add a new Leopard test bot.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/config.json:
1191
1192 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1193
1194         Reviewed by Adam Barth.
1195
1196         Add EFL Builder to core waterfall
1197         https://bugs.webkit.org/show_bug.cgi?id=52704
1198
1199         Add EFL Builder to the core waterfall again.
1200
1201         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1202         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1203
1204 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1205
1206         Reviewed by Tony Chang.
1207
1208         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1209         https://bugs.webkit.org/show_bug.cgi?id=52872
1210
1211         Force disabling proxy to resolve the problem.
1212
1213         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1214         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1215
1216 2011-01-24  Andreas Kling  <kling@webkit.org>
1217
1218         Reviewed by Darin Adler.
1219
1220         check-webkit-style: Update exemptions following Source/ move.
1221         https://bugs.webkit.org/show_bug.cgi?id=53017
1222
1223         * Scripts/webkitpy/style/checker.py:
1224         * Scripts/webkitpy/style/checker_unittest.py:
1225
1226 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1227
1228         Rubber-stamped by Csaba Osztrogonác.
1229
1230         [Qt] Move project files into Source
1231         https://bugs.webkit.org/show_bug.cgi?id=52891
1232
1233         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1234
1235 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1236
1237         Reviewed by Yury Semikhatsky.
1238
1239         Web Inspector: Find duplicate strings in localizedStrings.js
1240
1241         https://bugs.webkit.org/show_bug.cgi?id=53005
1242
1243         * Scripts/check-inspector-strings:
1244
1245 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1246
1247         Reviewed by Andreas Kling.
1248
1249         [Qt] Regroup MiniBrowser's menubar and add open file action
1250         https://bugs.webkit.org/show_bug.cgi?id=53000
1251
1252         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1253
1254         * MiniBrowser/qt/BrowserWindow.cpp:
1255         (BrowserWindow::BrowserWindow):
1256         (BrowserWindow::openFile):
1257         (BrowserWindow::~BrowserWindow):
1258         * MiniBrowser/qt/BrowserWindow.h:
1259
1260 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1261
1262         Unreviewed fix after r76496
1263
1264         [Qt] Move project files into Source
1265         https://bugs.webkit.org/show_bug.cgi?id=52891
1266
1267         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1268         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1269         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1270
1271 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1272
1273         Reviewed by Csaba Osztrogonác.
1274
1275         [Qt] Move project files into Source
1276         https://bugs.webkit.org/show_bug.cgi?id=52891
1277
1278         * DerivedSources.pro: Renamed from DerivedSources.pro.
1279         * DumpRenderTree/qt/DumpRenderTree.pro:
1280         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1281         * MiniBrowser/DerivedSources.pro:
1282         * MiniBrowser/qt/MiniBrowser.pro:
1283         * QtTestBrowser/QtTestBrowser.pro:
1284         * Scripts/webkitdirs.pm:
1285         * Tools.pro: Added.
1286         * WebKitTestRunner/DerivedSources.pro:
1287         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1288         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1289
1290 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1291
1292         Reviewed by Dan Bernstein.
1293
1294         Beefed up --threaded mode to catch even more kinds of errors.
1295         https://bugs.webkit.org/show_bug.cgi?id=52971
1296
1297         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1298         context group to force JSC to mark multiple threads. (This used to be
1299         the default, but it changed in SnowLeopard.)
1300         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1301         to give threading mistakes more chances to show themselves.
1302         (startJavaScriptThreads):
1303         (stopJavaScriptThreads):
1304
1305 2011-01-22  Robert Hogan  <robert@webkit.org>
1306
1307         Reviewed by Andreas Kling.
1308
1309         [Qt] Support layoutTestController.addURLToRedirect()
1310         https://bugs.webkit.org/show_bug.cgi?id=52956
1311
1312         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1313         (LayoutTestController::addURLToRedirect):
1314         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1315
1316 2011-01-22  Robert Hogan  <robert@webkit.org>
1317
1318         Reviewed by Kenneth Rohde Christiansen.
1319
1320         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1321         https://bugs.webkit.org/show_bug.cgi?id=49802
1322
1323         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1324         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1325         (WebCore::DumpRenderTree::open):
1326
1327 2011-01-21  Adam Barth  <abarth@webkit.org>
1328
1329         Reviewed by Maciej Stachowiak.
1330
1331         Disable mac_unittest.py that fails on some of the Mac bots
1332         https://bugs.webkit.org/show_bug.cgi?id=52947
1333
1334         As noted in the comment, this test does not appear to be correct
1335         because the function this test is testing returns different results
1336         depending on which flavor of Mac the test is run on.  This patch
1337         disable the test.  Hopefully we can re-enable the test once we've
1338         probably insulated the test from its environment.
1339
1340         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1341
1342 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1343
1344         Reviewed by Mihai Parparita.
1345
1346         Fix bug introduced in r76322 that caused NRWT to not actually
1347         read the Skipped files properly.
1348
1349         https://bugs.webkit.org/show_bug.cgi?id=52771
1350
1351         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1352         * Scripts/webkitpy/layout_tests/port/webkit.py:
1353         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1354
1355 2011-01-21  Sam Weinig  <sam@webkit.org>
1356
1357         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1358
1359         WebKitTestRunner needs the HOME environment variable to be set.
1360         <rdar://problem/8896573>
1361
1362         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1363         it exists.
1364
1365 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1366
1367         Reviewed by Eric Seidel.
1368
1369         Suppress a few remaining integration tests so that none of the
1370         layout_test unit tests ever read from the filesystem or launch
1371         subprocesses that aren't part of the unit tests.
1372
1373         Also fix a minor bug in the printing unit tests that was
1374         incorrectly relying on sys.argv.
1375
1376         https://bugs.webkit.org/show_bug.cgi?id=52863
1377
1378         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1379         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1380         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1381
1382 2011-01-21  Darin Adler  <darin@apple.com>
1383
1384        Fix Mac build.
1385
1386         * MiniBrowser/mac/BrowserWindowController.m:
1387         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1388
1389 2011-01-20  Darin Adler  <darin@apple.com>
1390
1391         Reviewed by Dan Bernstein.
1392
1393         WebKit2: Implement showModalDialog
1394         https://bugs.webkit.org/show_bug.cgi?id=52855
1395
1396         This fixes WebKitTestRunner to compile, but more work is probably
1397         needed to get it to pass the tests.
1398
1399         * WebKitTestRunner/TestController.cpp:
1400         (WTR::TestController::runModal): Added. Calls through to the
1401         platform-specific version of runModal.
1402         (WTR::TestController::createOtherPage): Changed to be a private
1403         static member function so it can refer to runModal, which is
1404         a private static member function.
1405         (WTR::TestController::initialize): Pass 0 for the runModal
1406         function since we don't need to run the main window modal.
1407         I suspect this is wrong and will need to change.
1408         * WebKitTestRunner/TestController.h: Added declarations for
1409         the functions added above.
1410         * WebKitTestRunner/mac/TestControllerMac.mm:
1411         (WTR::TestController::runModal): Added. Untested implementation.
1412         * WebKitTestRunner/qt/TestControllerQt.cpp:
1413         (WTR::TestController::runModal): Added.
1414         * WebKitTestRunner/win/TestControllerWin.cpp:
1415         (WTR::TestController::runModal): Added.
1416
1417 2011-01-21  Eric Seidel  <eric@webkit.org>
1418
1419         Reviewed by Adam Barth.
1420
1421         Split Host object off from WebKitPatch for easier re-use
1422         https://bugs.webkit.org/show_bug.cgi?id=52284
1423
1424         new-run-webkit-tests and other tools are eventually going to want one of these.
1425         Basically you need to inherit from this class if you want to pretend to be a
1426         self.tool object for Steps/Commands.
1427
1428         * Scripts/webkitpy/common/host.py: Added.
1429         * Scripts/webkitpy/tool/main.py:
1430
1431 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1432
1433         Reviewed by Adam Barth.
1434
1435         Disable the tests that start and stop the http server and web
1436         server, so that we don't have to worry about port collisions on
1437         the bots.
1438
1439         https://bugs.webkit.org/show_bug.cgi?id=52861
1440
1441         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1442
1443 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1444
1445         Reviewed by Eric Seidel.
1446
1447         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1448         
1449         https://bugs.webkit.org/show_bug.cgi?id=52772
1450         
1451         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1452
1453 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1454
1455         Reviewed by Eric Siedel.
1456
1457         nrwt: clean up almost all remaining port references, remove
1458         unnecessary import clauses. The only remaining references are
1459         in places where a mock filesystem makes no sense or can't be
1460         used, and in one routine in port/google_chrome_unittest that
1461         I'll rewrite in a separate patch.
1462
1463         https://bugs.webkit.org/show_bug.cgi?id=52771
1464
1465         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1466         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1467         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1468         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1469         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1470         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1471         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1472         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1473         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1474         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1475         * Scripts/webkitpy/layout_tests/port/gtk.py:
1476         * Scripts/webkitpy/layout_tests/port/mac.py:
1477         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1478         * Scripts/webkitpy/layout_tests/port/qt.py:
1479         * Scripts/webkitpy/layout_tests/port/webkit.py:
1480         * Scripts/webkitpy/layout_tests/port/win.py:
1481         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1482
1483 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1484
1485         Reviewed by Mihai Parparita.
1486
1487         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1488
1489         https://bugs.webkit.org/show_bug.cgi?id=52762
1490
1491         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1492         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1493
1494 2011-01-20  Tony Chang  <tony@chromium.org>
1495
1496         Reviewed by Ojan Vafai.
1497
1498         [chromium] fix the paths used for the rebaseline tool
1499         https://bugs.webkit.org/show_bug.cgi?id=52857
1500
1501         Some of the bots were renamed so the path to grab the results zip
1502         file has changed.
1503
1504         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1505
1506 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1507
1508         Reviewed by Tony Chang.
1509
1510         Fix bug introduced in r72688 / bug 52768 that broke the
1511         generation of the output filename links in the results.html
1512         output. Apparently none of the unit tests actually checked to
1513         make sure the generated links were correct :(
1514
1515         https://bugs.webkit.org/show_bug.cgi?id=52854
1516
1517         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1518         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1519
1520 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1521
1522         Reviewed by Darin Adler.
1523
1524         https://bugs.webkit.org/show_bug.cgi?id=52849
1525         Make window.print work with WebKit2
1526
1527         * MiniBrowser/mac/BrowserWindowController.m:
1528         (-[BrowserWindowController awakeFromNib]):
1529         * WebKitTestRunner/TestController.cpp:
1530         (WTR::createOtherPage):
1531         (WTR::TestController::initialize):
1532         Added zeroes to WKPageUIClient structures to avoid build failures.
1533
1534 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1535
1536         Reviewed by Eric Seidel.
1537
1538         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1539
1540         https://bugs.webkit.org/show_bug.cgi?id=52756
1541
1542         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1543         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1544         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1545         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1546         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1547         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1548
1549 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1550
1551         Reviewed by Antonio Gomes.
1552
1553         QtTestBrowser should have a seperate menu for Settings
1554         https://bugs.webkit.org/show_bug.cgi?id=52817
1555         
1556         Added a new menu item named "Settings"
1557         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1558
1559         * QtTestBrowser/launcherwindow.cpp:
1560         (LauncherWindow::createChrome):
1561
1562 2011-01-20  Sam Weinig  <sam@webkit.org>
1563
1564         Reviewed by John Sullivan.
1565
1566         Update update-webkit-localizable-strings with new path to WebKit.
1567
1568         * Scripts/update-webkit-localizable-strings:
1569
1570 2011-01-20  James Robinson  <jamesr@chromium.org>
1571
1572         Reviewed by Darin Fisher.
1573
1574         Implement mozilla's requestAnimationFrame API
1575         https://bugs.webkit.org/show_bug.cgi?id=51218
1576
1577         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1578
1579         * DumpRenderTree/chromium/WebViewHost.cpp:
1580         (invokeScheduleComposite):
1581         (WebViewHost::scheduleAnimation):
1582         (WebViewHost::paintInvalidatedRegion):
1583         * DumpRenderTree/chromium/WebViewHost.h:
1584
1585 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1586
1587         Reviewed by Adam Roben.
1588
1589         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1590         https://bugs.webkit.org/show_bug.cgi?id=42327
1591
1592         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1593         for methods that take their normal arguments but also a JSContextRef.
1594         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1595         for evaluateScriptInIsolatedWorld.
1596         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1597         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1598         this call is for an isolated world.
1599         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1600         (WTR::worldMap): Helper to create a world map.
1601         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1602         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1603         added LayoutTestController API.
1604         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1605
1606 2011-01-19  Adam Roben  <aroben@apple.com>
1607
1608         Convert paths in environment variables back to msys-style inside commit-log-editor
1609
1610         When this script gets run from inside git commit, msys-style paths in the environment will
1611         have been turned into Windows-style paths with forward slashes. This screws up functions
1612         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1613         the paths back to msys-style before doing anything else.
1614
1615         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1616         using msysgit's Perl and multiple ChangeLogs have been edited
1617
1618         Reviewed by David Kilzer.
1619
1620         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1621         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1622         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1623
1624 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1625
1626         [Win] Unreviewed build fix after r76248.
1627
1628         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1629
1630 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1631
1632         Reviewed by Csaba Osztrogonác.
1633
1634         Refactoring of the custom allocation framework
1635         https://bugs.webkit.org/show_bug.cgi?id=49897
1636
1637         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1638         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1639         equivalent macro implementation at the necessary places.
1640 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1641
1642         Unreviewed. 
1643
1644         Adding myself to committers.py.
1645
1646         * Scripts/webkitpy/common/config/committers.py:
1647
1648 2011-01-20  Adam Barth  <abarth@webkit.org>
1649
1650         Reviewed by Tony Chang.
1651
1652         Chromium builders don't delete unversioned directories when DEPS change
1653         https://bugs.webkit.org/show_bug.cgi?id=52745
1654
1655         If we pass this option to gclient sync, gclient will delete directories
1656         that are no longer part of DEPS instead of leaving them around to
1657         confuse us later.  Apparently, the downstream buildbots use this option
1658         already.
1659
1660         * Scripts/update-webkit-chromium:
1661
1662 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1663
1664         Unreviewed, build fix - I pulled this patch in to fix an issue
1665         revealed by r76195 running on some new bots). Also fix a couple
1666         of other issues revealed in testing.
1667
1668         nrwt: remove fs refs from layout_package/json*
1669
1670         https://bugs.webkit.org/show_bug.cgi?id=52754
1671
1672         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1673         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1674         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1675         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1676         * Scripts/webkitpy/layout_tests/port/base.py:
1677
1678 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1679
1680         Unreviewed, build fix.
1681
1682         Fix a couple of minor bugs discovered while bringing up new bots
1683         for testing.
1684
1685         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1687
1688 2011-01-19  James Robinson  <jamesr@chromium.org>
1689
1690         Unreviewed, rolling out r76194.
1691         http://trac.webkit.org/changeset/76194
1692         https://bugs.webkit.org/show_bug.cgi?id=51218
1693
1694         Caused mysterious compile failure on the chromium win
1695         build.webkit.org bots
1696
1697         * DumpRenderTree/chromium/WebViewHost.cpp:
1698         (WebViewHost::paintInvalidatedRegion):
1699         * DumpRenderTree/chromium/WebViewHost.h:
1700
1701 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1702
1703         Reviewed by Mihai Parparita.
1704
1705         remove fs refs from test_runner, dump_render_tree_thread
1706
1707         https://bugs.webkit.org/show_bug.cgi?id=52753
1708
1709         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1710         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1711         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1712         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1713
1714 2011-01-19  James Robinson  <jamesr@chromium.org>
1715
1716         Reviewed by Darin Fisher.
1717
1718         Implement mozilla's requestAnimationFrame API
1719         https://bugs.webkit.org/show_bug.cgi?id=51218
1720
1721         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1722
1723         * DumpRenderTree/chromium/WebViewHost.cpp:
1724         (invokeScheduleComposite):
1725         (WebViewHost::scheduleAnimation):
1726         (WebViewHost::paintInvalidatedRegion):
1727         * DumpRenderTree/chromium/WebViewHost.h:
1728
1729 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1730
1731         Unreviewed, build fix.
1732
1733         Fix a few incorrect "self._filesystem" references introduced in
1734         r76184.
1735
1736         * Scripts/webkitpy/layout_tests/port/chromium.py:
1737         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1738
1739 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1740
1741         Reviewed by Mihai Parparita.
1742
1743         add a .sep property, abspath(), isabs(), mtime(), and
1744         open_text_file_for_writing() to filesystem modules. Some of
1745         these properties are not needed in this patch but will be needed
1746         in subsequent patches (I'm doing this to avoid having to track
1747         multiple versions of a single file).
1748
1749         Also, change most of the port/* modules to use the filesystem
1750         objects instead of referencing the filesystem directly.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=52748
1753
1754         * Scripts/webkitpy/common/system/filesystem.py:
1755         * Scripts/webkitpy/common/system/filesystem_mock.py:
1756         * Scripts/webkitpy/layout_tests/port/__init__.py:
1757         * Scripts/webkitpy/layout_tests/port/base.py:
1758         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1759         * Scripts/webkitpy/layout_tests/port/chromium.py:
1760         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1761         * Scripts/webkitpy/layout_tests/port/config.py:
1762         * Scripts/webkitpy/layout_tests/port/test.py:
1763         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1764
1765 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1766
1767         Reviewed by Anders Carlsson.
1768
1769         If resetting between tests times out, treat it as a WebProcess crash
1770         https://bugs.webkit.org/show_bug.cgi?id=52757
1771
1772         * WebKitTestRunner/TestController.cpp:
1773         (WTR::TestController::runTest):
1774
1775 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1776
1777         Reviewed by Darin Adler.
1778
1779         https://bugs.webkit.org/show_bug.cgi?id=52739
1780         Make it possible for a WebKit2 client to print headers and footers
1781
1782         Added dummy implementations for new printing UIClient calls.
1783
1784         * MiniBrowser/mac/BrowserWindowController.m:
1785         (-[BrowserWindowController awakeFromNib]):
1786         * WebKitTestRunner/TestController.cpp:
1787         (WTR::createOtherPage):
1788         (WTR::TestController::initialize):
1789
1790 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1791
1792         Reviewed by Ojan Vafai.
1793
1794         Change webkitpy/layout_tests/port/test.py to use the
1795         in-memory filesystem for cleaner unit testing. This
1796         change allows us to kill a lot of code that was
1797         specific to the test port, at the cost of being a
1798         little less clear about how things would work if
1799         you didn't have a filesystem.
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=52605
1802
1803         * Scripts/webkitpy/layout_tests/port/test.py:
1804
1805 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1806
1807         Unreviewed, build fix.
1808
1809         Fix test failure caused by committing attachment 79368 instead
1810         of attachment 79461 on bug 52604.
1811
1812         * Scripts/webkitpy/common/system/filesystem_mock.py:
1813
1814 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1815
1816         Reviewed by Mihai Parparita.
1817
1818         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1819         unit testing. os.walk() is too much of a hassle to implement on
1820         top of the in-memory mock filesystem and adding the necessary
1821         interface to files_under() gives clients a cleaner API anyway
1822         (for this particular usage model).
1823
1824         https://bugs.webkit.org/show_bug.cgi?id=52691
1825
1826         * Scripts/webkitpy/common/system/filesystem.py:
1827         * Scripts/webkitpy/common/system/filesystem_mock.py:
1828         * Scripts/webkitpy/layout_tests/port/test_files.py:
1829         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1830
1831 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1832
1833         Reviewed by Tony Chang.
1834
1835         Change more modules in the layout-tests code to use the
1836         filesystem wrapper for cleaner unit testing.
1837
1838         This patch also adds the glob() wrapper to the filesystem
1839         abstraction.
1840         
1841         https://bugs.webkit.org/show_bug.cgi?id=52604
1842
1843         * Scripts/webkitpy/layout_tests/port/test_files.py:
1844         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1845         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1846         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1847         * Scripts/webkitpy/common/system/filesystem.py:
1848         * Scripts/webkitpy/common/system/filesystem_mock.py:
1849
1850 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1851
1852         Unreviewed.
1853
1854         Updating my email addresses and irc nick.
1855
1856         * Scripts/webkitpy/common/config/committers.py:
1857
1858 2011-01-19  Tony Chang  <tony@chromium.org>
1859
1860         Reviewed by Mihai Parparita.
1861
1862         [chromium] [linux] if check-sys-deps fails, output the failure reason
1863         https://bugs.webkit.org/show_bug.cgi?id=52671
1864
1865         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1866             error handler functions.
1867         * Scripts/webkitpy/layout_tests/port/chromium.py:
1868             output the error text from --check-sys-deps
1869         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1870
1871 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1872
1873         Reviewed by Andreas Kling.
1874
1875         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1876         https://bugs.webkit.org/show_bug.cgi?id=52554
1877         
1878         QtNetworkAccessManager is created in a thread and set as
1879         member variable in QWebPage. When the thread is destroyed
1880         the object is still used. So fix will set the object to
1881         NULL once the thread is destroyed.
1882
1883         * QtTestBrowser/launcherwindow.cpp:
1884         (LauncherWindow::~LauncherWindow):
1885
1886 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1887
1888         Rubber stamped by Csaba Osztrogonac
1889
1890         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1891
1892 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1893
1894         Reviewed by Tony Chang.
1895
1896         new-run-webkit-tests: add a --build-directory command line argument
1897
1898         Official Google Chrome builds use a non-standard build directory
1899         location. This patch adds a --build-directory argument that
1900         allows that location to be specified on the command line. Only
1901         Chromium-based builds will use this flag for now, but anyone can
1902         in the future.
1903
1904         There are no unit tests for this since it's difficult to test
1905         until mock filesystems are fully supported in the code. This was
1906         tested by hand for now.
1907
1908         https://bugs.webkit.org/show_bug.cgi?id=52694
1909
1910         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1911         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1912         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1914
1915 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1916
1917         Not reviewed. Bot fix.
1918
1919         Remove an inadvertently committed debugging print.
1920
1921         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1922         (LayoutTestController::notifyDone):
1923
1924 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1925
1926         Reviewed by Sam Weinig.
1927
1928         WebKitTestRunner should track loading more like DumpRenderTree
1929         https://bugs.webkit.org/show_bug.cgi?id=52692
1930
1931         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1932         This makes some tests that call notifyDone multiple times pass.
1933         
1934         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1935         (WTR::InjectedBundle::InjectedBundle):
1936         (WTR::InjectedBundle::done):
1937         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1938         (WTR::InjectedBundle::topLoadingFrame):
1939         (WTR::InjectedBundle::setTopLoadingFrame):
1940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1941         (WTR::InjectedBundlePage::InjectedBundlePage):
1942         (WTR::InjectedBundlePage::stopLoading):
1943         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1944         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1945         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1946         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1947         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1948         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1949         (WTR::LayoutTestController::notifyDone):
1950         * WebKitTestRunner/TestController.cpp:
1951         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1952
1953 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1954
1955         Reviewed by Kent Tamura.
1956
1957         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1958         https://bugs.webkit.org/show_bug.cgi?id=52678
1959         
1960         Update path now that WebKit is inside Source.
1961
1962         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1963
1964 2011-01-18  Robert Hogan  <robert@webkit.org>
1965
1966         Reviewed by Simon Hausmann.
1967
1968         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1969         https://bugs.webkit.org/show_bug.cgi?id=44282
1970
1971         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1972         (WebCore::DumpRenderTree::dump):
1973
1974 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1975
1976         Reviewed by Mihai Parparita.
1977
1978         Fix a small race condition that could cause the unit tests for
1979         new-run-webkit-tests to fail in a multithreaded environment.
1980         There was a small window in the code where one thread would
1981         check to see if a thread had raised an exception, do something,
1982         and then check to see if the thread was alive. If the other
1983         thread raised an exception and exited in between these two
1984         steps, the exception would be lost. Flipping the order of the
1985         two checks fixes the race, since we will now always check for an
1986         exception on the thread before exiting.
1987
1988         https://bugs.webkit.org/show_bug.cgi?id=51579
1989
1990         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1991
1992 2011-01-18  Eric Seidel  <eric@webkit.org>
1993
1994         Reviewed by Adam Barth.
1995
1996         commit-queue dies when test archiving fails
1997         https://bugs.webkit.org/show_bug.cgi?id=52617
1998
1999         I looked at the machine and it had 10 archives already
2000         thus find_unused_name was returning None.  I've upped
2001         the limit to 100 (per bug) and tested the case where
2002         find_unused_name returns None (making archive return None).
2003
2004         * Scripts/webkitpy/common/system/workspace.py:
2005         * Scripts/webkitpy/common/system/workspace_unittest.py:
2006         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2007         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2008         * Scripts/webkitpy/tool/commands/queues.py:
2009
2010 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2011
2012         Reviewed by Ojan Vafai.
2013
2014         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2015         filesystem. Also fix a couple of "with" statements missed by
2016         r76050.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=52487
2019
2020         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2021
2022 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2023
2024         Reviewed by Martin Robinson.
2025
2026         [Gtk] Build fixes for gtk3 build
2027         https://bugs.webkit.org/show_bug.cgi?id=52648
2028
2029         * DumpRenderTree/gtk/EventSender.cpp:
2030         (beginDragWithFilesCallback):
2031
2032 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2033
2034         Reviewed by Mihai Parparita.
2035
2036         Update rebaseline-chromium-webkit-tests to use filesystem objects
2037         instead of direct references to os.path, shutil, tempfile, etc.
2038
2039         This patch doesn't change anything, but will allow subsequent
2040         patches to change the unit tests to no longer use the real
2041         filesystem.
2042
2043         This patch adds a bunch more methods to the filesystem object as
2044         well.
2045
2046         https://bugs.webkit.org/show_bug.cgi?id=52482
2047
2048         * Scripts/webkitpy/common/system/filesystem.py:
2049         * Scripts/webkitpy/common/system/filesystem_mock.py:
2050         * Scripts/webkitpy/tool/commands/queues.py:
2051         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2052         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2053
2054 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2055
2056         Reviewed by Mihai Parparita.
2057
2058         new-run-webkit-tests shouldn't crash when you try to run a
2059         directory containing only skipped files.
2060
2061         https://bugs.webkit.org/show_bug.cgi?id=52478
2062         
2063         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2064         * Scripts/webkitpy/layout_tests/port/test.py:
2065         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2066
2067 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2068
2069         Reviewed by Gustavo Noronha Silva.
2070
2071         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2072         https://bugs.webkit.org/show_bug.cgi?id=40833
2073
2074         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2075         GTK+ event sender.
2076         (dragWithFilesDragDataGetCallback): Added.
2077         (dragWithFilesDragEndCallback): Added.
2078         (beginDragWithFilesCallback): Added.
2079
2080 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2081
2082         Reviewed by Adam Barth.
2083
2084         ews: Add additional watcher to efl ews
2085         https://bugs.webkit.org/show_bug.cgi?id=52613
2086
2087         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2088
2089         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2090
2091 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2092
2093         Reviewed by Alexey Proskuryakov.
2094
2095         Fix some headers with missing or misspelled #ifndef guards
2096         https://bugs.webkit.org/show_bug.cgi?id=52545
2097
2098         * DumpRenderTree/chromium/TestEventPrinter.h:
2099         * DumpRenderTree/chromium/WebPreferences.h:
2100
2101 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2102
2103         Reviewed by Anders Carlsson.
2104
2105         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2106         navigating back to an unreachable URL
2107         https://bugs.webkit.org/show_bug.cgi?id=52388
2108
2109         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2110
2111         * DumpRenderTree/LayoutTestController.cpp:
2112         (queueLoadHTMLStringCallback):
2113         (LayoutTestController::queueLoadHTMLString):
2114         (LayoutTestController::queueLoadAlternateHTMLString):
2115         * DumpRenderTree/LayoutTestController.h:
2116
2117         * DumpRenderTree/WorkQueueItem.h:
2118         (LoadHTMLStringItem::LoadHTMLStringItem):
2119
2120         * DumpRenderTree/chromium/LayoutTestController.cpp:
2121         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2122         (WorkItemLoadHTMLString::run):
2123         (LayoutTestController::queueLoadHTMLString):
2124
2125         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2126         (LoadHTMLStringItem::invoke):
2127         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2128         (LoadHTMLStringItem::invoke):
2129         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2130         (LoadHTMLStringItem::invoke):
2131
2132 2011-01-17  Dan Bernstein  <mitz@apple.com>
2133
2134         Rubber-stamped by Mark Rowe.
2135
2136         Update xcodeproj svn:ignore to include xcuserdata.
2137
2138         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2139         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2141         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2142         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2143
2144 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2145
2146         Unreviewed fix after r75908.
2147
2148         Move WebKit into Source
2149         https://bugs.webkit.org/show_bug.cgi?id=52530
2150
2151         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2152
2153 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2154
2155         Unreviewed.
2156
2157         Remove accidentally committed debug printing after r75908.
2158
2159         * Scripts/webkitdirs.pm:
2160
2161 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2162
2163         Unreviewed.
2164
2165         Add myself to committers list
2166         https://bugs.webkit.org/show_bug.cgi?id=52566
2167
2168         * Scripts/webkitpy/common/config/committers.py:
2169
2170 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2171
2172         Reviewed by Jeremy Orlow.
2173
2174         GeolocationController should call stopUpdating on destruction
2175         https://bugs.webkit.org/show_bug.cgi?id=52216
2176
2177         fast/dom/Geolocation/window-close-crash.html requires that a
2178         Geolocation watch be started in a secondary window. Consequently,
2179         we need to allow geolocation permission and provide a mock
2180         geolocation position for the secondary window's
2181         GeolocationClientMock.
2182
2183         * DumpRenderTree/chromium/LayoutTestController.cpp:
2184         (LayoutTestController::setGeolocationPermission):
2185         (LayoutTestController::setMockGeolocationPosition):
2186         (LayoutTestController::setMockGeolocationError):
2187         * DumpRenderTree/chromium/TestShell.h:
2188         (TestShell::windowList):
2189
2190 2011-01-16  Adam Barth  <abarth@webkit.org>
2191
2192         Update more include paths to reflect WebKit move.
2193
2194         * DumpRenderTree/chromium/EventSender.cpp:
2195         (EventSender::keyDown):
2196         (EventSender::needsShiftModifier):
2197         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2198         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2199
2200 2011-01-16  Kent Tamura  <tkent@chromium.org>
2201
2202         Unreviewed, Chromium build fix.
2203
2204         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2205
2206 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2207
2208         Build fix for GTK+ after source directory movement.
2209
2210         * GNUmakefile.am: Correct include paths.
2211
2212 2011-01-16  Adam Barth  <abarth@webkit.org>
2213
2214         Teach svn-apply about WebKit move.
2215
2216         * Scripts/VCSUtils.pm:
2217
2218 2011-01-16  Adam Barth  <abarth@webkit.org>
2219
2220         Rubber-stamped by Eric Seidel.
2221
2222         Move WebKit into Source
2223         https://bugs.webkit.org/show_bug.cgi?id=52530
2224
2225         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2226         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2227         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2228         * DumpRenderTree/qt/GCControllerQt.cpp:
2229         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2230         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2231         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2232         * DumpRenderTree/wscript:
2233         * QtTestBrowser/launcherwindow.h:
2234         * Scripts/build-webkit:
2235         * Scripts/webkitdirs.pm:
2236
2237 2011-01-15  Adam Barth  <abarth@webkit.org>
2238
2239         Teach svn-apply about WebKit2 move.
2240
2241         * Scripts/VCSUtils.pm:
2242
2243 2011-01-15  Adam Barth  <abarth@webkit.org>
2244
2245         Rubber-stamped by Eric Seidel.
2246
2247         Move WebKit2 into Source
2248         https://bugs.webkit.org/show_bug.cgi?id=52438
2249
2250         * MiniBrowser/qt/MiniBrowser.pro:
2251         * Scripts/build-webkit:
2252         * Scripts/do-file-rename:
2253         * Scripts/do-webcore-rename:
2254         * Scripts/test-webkitpy:
2255         * Scripts/webkitdirs.pm:
2256         * Scripts/webkitpy/style/checker.py:
2257         * WebKitTestRunner/DerivedSources.pro:
2258         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2259         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2260
2261 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2262
2263         Reviewed by David Levin.
2264
2265         [chromium] remove obsolete createView method
2266         https://bugs.webkit.org/show_bug.cgi?id=52437
2267
2268         * DumpRenderTree/chromium/WebViewHost.cpp:
2269         (WebViewHost::createView):
2270         * DumpRenderTree/chromium/WebViewHost.h:
2271
2272 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2273
2274         Reviewed by Geoff Garen.
2275
2276         ShouldLoadResourceForFrame should use strings, not URLs.
2277         https://bugs.webkit.org/show_bug.cgi?id=52476
2278
2279         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2280         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2281         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2282
2283 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2284
2285         Reviewed by David Levin.
2286
2287         Add Tony Gentilcore as a reviewer
2288         https://bugs.webkit.org/show_bug.cgi?id=52480
2289
2290         * Scripts/webkitpy/common/config/committers.py:
2291
2292 2011-01-14  David Levin  <levin@chromium.org>
2293
2294         Reviewed by Eric Seidel.
2295
2296         check-webkit-style: _FunctionState should keep track of where the function name starts.
2297         https://bugs.webkit.org/show_bug.cgi?id=52454
2298
2299         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2300         _FunctionState and logic for setting it correctly.
2301         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2302
2303 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2304
2305         Reviewed by David Levin.
2306
2307         Add support to DumpRenderTree to use the GPU rather than software renderer
2308         https://bugs.webkit.org/show_bug.cgi?id=52333
2309
2310         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2311         (main):
2312         * Scripts/webkitpy/layout_tests/port/chromium.py:
2313         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2314
2315 2011-01-14  Tony Chang  <tony@chromium.org>
2316
2317         Reviewed by Kent Tamura.
2318
2319         [chromium] update fonts.conf to fix 6 linux tests in drt
2320         https://bugs.webkit.org/show_bug.cgi?id=52411
2321
2322         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2323             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2324
2325 2011-01-14  Eric Seidel  <eric@webkit.org>
2326
2327         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2328
2329         Reviewed by Adam Barth.
2330
2331         Fix when running Tools/Scripts/check-webkit-style without arguments.
2332         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2333
2334         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2335         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2336
2337 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2338
2339         Reviewed by David Levin.
2340
2341         Store the tempdir object in a variable so it doesn't get deleted too early.
2342         https://bugs.webkit.org/show_bug.cgi?id=51875
2343
2344         * Scripts/update-webkit-auxiliary-libs:
2345         * Scripts/update-webkit-support-libs:
2346
2347 2011-01-14  Eric Seidel  <eric@webkit.org>
2348
2349         Unreviewed.  Make it work in python 2.5.
2350
2351         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2352         https://bugs.webkit.org/show_bug.cgi?id=49158
2353
2354         * Scripts/webkitpy/common/checkout/api_unittest.py:
2355
2356 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2357
2358         Unreviewed, rolling out r75774.
2359         http://trac.webkit.org/changeset/75774
2360         https://bugs.webkit.org/show_bug.cgi?id=52431
2361
2362         gtk builds were broken (Requested by loislo2 on #webkit).
2363
2364         * Scripts/webkitpy/common/checkout/scm.py:
2365
2366 2011-01-14  David Levin  <levin@chromium.org>
2367
2368         Reviewed by Shinichiro Hamaji.
2369
2370         check-webkit-style: _FunctionState should detect pure functions.
2371         https://bugs.webkit.org/show_bug.cgi?id=52428
2372
2373         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2374         is a pure virtual function.
2375         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2376         virtual functions are correctly detected.
2377
2378 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2379
2380         Reviewed by Yury Semikhatsky.
2381
2382         Just small fix for problem with check-webkit-style.
2383         It just didn't work for this patch.
2384         Old code can't concatenate a list of strings with None.
2385
2386         * Scripts/webkitpy/common/checkout/scm.py:
2387
2388 2011-01-13  David Levin  <levin@chromium.org>
2389
2390         Reviewed by Shinichiro Hamaji.
2391
2392         check-webkit-style: _FunctionState should use Position to know where items are.
2393         https://bugs.webkit.org/show_bug.cgi?id=52424
2394
2395         * Scripts/webkitpy/style/checkers/cpp.py:
2396         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2397         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2398         did some minor clean-up.
2399         (*): Other changes are simply about converting to use the Position's in_FunctionState
2400         instead of line numbers.
2401         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2402         to verify the positions stored in _FunctionState.
2403
2404 2011-01-13  Eric Seidel  <eric@webkit.org>
2405
2406         Reviewed by David Levin.
2407
2408         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2409         https://bugs.webkit.org/show_bug.cgi?id=49158
2410
2411         This is not the most elegant, but it is a very safe fix to this bug.
2412         One advantage of catching ScriptError like this instead of adding a
2413         new added_or_modified_files or fixing all changed_files callers
2414         to use a more specific change_files variant, is that we catch
2415         all kinds of ScriptErrors which might cause our (non-essential)
2416         suggest-reviewers code to fail out.  This should make passing
2417         --suggest-reviewers to webkit-patch upload much more robust
2418         and may even make it possible for us to make it default.
2419
2420         The root of the problem here is that SCM.changed_files includes
2421         deleted ChangeLog paths (from moves, etc) which then when we ask
2422         SVN/Git for the contents of the file at that revision, the command
2423         errors out and Executive.run_command raises a ScriptError.
2424
2425         In the future we might fix this differently by making all current
2426         callers of chagned_files use a more specific method for requesting
2427         what types of changes they're interested in (adds, modifies, deletes, etc.)
2428
2429         * Scripts/webkitpy/common/checkout/api.py:
2430         * Scripts/webkitpy/common/checkout/api_unittest.py:
2431
2432 2011-01-13  Dan Bernstein  <mitz@apple.com>
2433
2434         Reviewed by Alexey Proskuryakov.
2435
2436         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2437         https://bugs.webkit.org/show_bug.cgi?id=52419
2438
2439         Allow to further control the behavior of the willSendRequest delegate callback by making it
2440         set a different URL in the new request.
2441
2442         * DumpRenderTree/LayoutTestController.cpp:
2443         (addURLToRedirectCallback): Added.
2444         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2445         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2446         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2447         * DumpRenderTree/LayoutTestController.h:
2448         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2449         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2450         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2451         change the URL in the new request to the redirect destination.
2452
2453 2011-01-13  Eric Seidel  <eric@webkit.org>
2454
2455         Reviewed by Mihai Parparita.
2456
2457         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2458         https://bugs.webkit.org/show_bug.cgi?id=52416
2459
2460         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2461         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2462
2463         I also added FIXMEs about the changed_files returning deleted files problem
2464         which is causing the other most common exception for suggest-reviewers
2465         (and is probably breaking sheriff-bots blame detection).
2466
2467         * Scripts/webkitpy/common/checkout/api.py:
2468         * Scripts/webkitpy/common/checkout/api_unittest.py:
2469         * Scripts/webkitpy/common/checkout/scm.py:
2470
2471 2011-01-13  Eric Seidel  <eric@webkit.org>
2472
2473         Reviewed by Adam Barth.
2474
2475         results archives from commit-queue are too large to upload
2476         https://bugs.webkit.org/show_bug.cgi?id=52405
2477
2478         * Scripts/webkitpy/common/system/filesystem.py:
2479         * Scripts/webkitpy/common/system/filesystem_mock.py:
2480         * Scripts/webkitpy/tool/commands/queues.py:
2481
2482 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2483
2484         Reviewed by Martin Robinson.
2485
2486         [gtk] Zero-sized font does not yet work
2487         https://bugs.webkit.org/show_bug.cgi?id=49793
2488
2489         Set minimum-font-size to 0 for the DRT.
2490
2491         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2492         (resetDefaultsToConsistentValues):
2493
2494 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2495
2496         Reviewed by Darin Adler.
2497
2498         Make old-run-webkit-tests more robust on buildbots
2499         https://bugs.webkit.org/show_bug.cgi?id=52364
2500
2501         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2502
2503 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2504
2505         Reviewed by Darin Adler.
2506
2507         Make old-run-webkit-tests more robust on buildbots
2508         https://bugs.webkit.org/show_bug.cgi?id=52364
2509
2510         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2511
2512 2011-01-13  Tony Chang  <tony@chromium.org>
2513
2514         Reviewed by Kent Tamura.
2515
2516         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2517         https://bugs.webkit.org/show_bug.cgi?id=52332
2518
2519         Forked Info.plist is not longer needed.
2520
2521         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2522
2523 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2524
2525         Reviewed by Timothy Hatcher.
2526
2527         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2528         to be passed directly to WebInspector.UIString
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=52365
2531
2532         * Scripts/check-inspector-strings:
2533
2534 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2535
2536         Unreviewed, rolling out r74881.
2537         http://trac.webkit.org/changeset/74881
2538         https://bugs.webkit.org/show_bug.cgi?id=52357
2539
2540         The EFL builder has been red for days (Requested by abarth on
2541         #webkit).
2542
2543         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2544         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2545
2546 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2547
2548         Reviewed by David Levin.
2549
2550         Add beforeunload support to WebKitTestRunner
2551         https://bugs.webkit.org/show_bug.cgi?id=52353
2552         
2553         This makes a number of currently failing tests pass.
2554
2555         * WebKitTestRunner/TestController.cpp:
2556         (WTR::runBeforeUnloadConfirmPanel):
2557         (WTR::createOtherPage):
2558         (WTR::TestController::initialize):
2559
2560 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2561
2562         Reviewed by Sam Weinig.
2563
2564         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2565         https://bugs.webkit.org/show_bug.cgi?id=52330
2566
2567         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2568         a web process crash.
2569         * WebKitTestRunner/TestController.cpp:
2570         (WTR::TestController::initialize): Set up a processDidCrash
2571         callback.
2572         (WTR::TestController::processDidCrash): Report that the Web process
2573         crashed.
2574         * WebKitTestRunner/TestController.h:
2575
2576 2011-01-12  David Levin  <levin@chromium.org>
2577
2578         Reviewed by Shinichiro Hamaji.
2579
2580         check-webkit-style -- close_expression function doesn't work correctly.
2581         https://bugs.webkit.org/show_bug.cgi?id=52272
2582
2583         * Scripts/webkitpy/style/checkers/cpp.py:
2584         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2585         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2586         generally useful (for upcoming code changes).
2587         (close_expression): Changed to use Position for input and output.
2588         Also, fixed many bugs such as only working correctly for parenthesis,
2589         not working correctly if given an offset in a line and not finding
2590         the real closing element if there were multiple closing elements in
2591         the same line.
2592         (detect_functions): Adjusted due to the change in arguments for
2593         close_expression.
2594         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2595         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2596         two positions are the same.
2597         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2598         (CppStyleTest.test_close_expression): Added tests to catch the issues
2599         that were fixed.
2600
2601 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2602
2603         Unreviewed, rolling out r75576.
2604         http://trac.webkit.org/changeset/75576
2605         https://bugs.webkit.org/show_bug.cgi?id=52304
2606
2607         broke rebaseline-chromium-webkit-test (Requested by thakis on
2608         #webkit).
2609
2610         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2611         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2612         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2613         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2614         * Scripts/webkitpy/layout_tests/port/base.py:
2615         * Scripts/webkitpy/layout_tests/port/chromium.py:
2616         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2617         * Scripts/webkitpy/layout_tests/port/test.py:
2618         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2619         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2620         * Scripts/webkitpy/style/checkers/test_expectations.py:
2621         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2622
2623 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2624
2625         Reviewed by Darin Adler.
2626
2627         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2628         https://bugs.webkit.org/show_bug.cgi?id=52307
2629
2630         * Scripts/old-run-webkit-tests:
2631
2632 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2633
2634         Reviewed by Martin Robinson.
2635
2636         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2637         https://bugs.webkit.org/show_bug.cgi?id=50867
2638
2639         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2640         TestNetscapePlugin.cpp 
2641
2642         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2643         * Scripts/webkitdirs.pm:
2644
2645 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2646
2647         Reviewed by Pavel Feldman.
2648
2649         Add check-inspector-strings script.
2650
2651         https://bugs.webkit.org/show_bug.cgi?id=52295
2652
2653         * Scripts/check-inspector-strings: Added.
2654
2655 2011-01-12  Adam Roben  <aroben@apple.com>
2656
2657         Advertise the .testnetscape file extension on Windows
2658
2659         Fixes <http://webkit.org/b/52298>
2660         plugins/no-mime-with-valid-extension.html fails on Windows
2661
2662         Reviewed by Dan Bernstein.
2663
2664         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2665         FileExtents field to map the .testnetscape file extension to the
2666         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2667
2668 2011-01-12  Adam Barth  <abarth@webkit.org>
2669
2670         Reviewed by Eric Seidel.
2671
2672         Make webkit-patch support subdirectories for SVN checkouts
2673         https://bugs.webkit.org/show_bug.cgi?id=52261
2674
2675         os.relpath does not exist on Python 2.5, so we need to call our version
2676         of the API.
2677
2678         * Scripts/webkitpy/common/checkout/scm.py:
2679
2680 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2681
2682         Reviewed by Eric Seidel.
2683
2684         Close additional pages opened during a test once the test completes.
2685         https://bugs.webkit.org/show_bug.cgi?id=52276
2686
2687         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2688         (WTR::InjectedBundle::done):
2689
2690 2011-01-11  David Levin  <levin@chromium.org>
2691
2692         Reviewed by Eric Seidel.
2693
2694         Errors should be separated from the command line in bot messages.
2695         https://bugs.webkit.org/show_bug.cgi?id=52275
2696
2697         * Scripts/webkitpy/common/system/executive.py:
2698         (ScriptError.message_with_output): Added a newline to separate the command
2699         line from the errors.
2700         * Scripts/webkitpy/common/system/executive_unittest.py:
2701         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2702         paths in message_with_output.
2703
2704 2011-01-11  Eric Seidel  <eric@webkit.org>
2705
2706         Unreviewed.
2707
2708         commit-queue should know how to upload archived results (for test flakes or general failures)
2709         https://bugs.webkit.org/show_bug.cgi?id=52048
2710
2711         The zips are mostly empty due to forgetting -r.
2712         Expected diffs were not being pulled from the archive due
2713         to the archive having longer paths than I realized.
2714
2715         * Scripts/webkitpy/common/system/workspace.py:
2716         * Scripts/webkitpy/common/system/workspace_unittest.py:
2717         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2718         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2719
2720 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2721
2722         Reviewed by Ojan Vafai.
2723
2724         The current modifier parsing code in test_expectations is
2725         fragile and hard-coded, so it's not easy to understand the logic
2726         or easily add new types of modifiers (like GPU vs. CPU testing
2727         for graphics tests, or 32-bit vs. 64-bit differences).
2728
2729         This is the first of two patches that will add in more generic
2730         support and then eliminate the GPU-specific test expectations
2731         files for Chromium.
2732
2733         This patch adds two standalone objects for handling modifiers. The
2734         rules for interpreting modifiers, precedence, and conflicts are
2735         given in the docstring to the ModifierMatcher class, which
2736         returns ModifierMatchResult objects.
2737         
2738         This patch also adds routines to the Port interface and a
2739         default set of values in the base object, in order to obtain the
2740         values needed on a given test run. These values are then passed
2741         to the expectation parser. This also allows us to clean up the
2742         logic used to lint all of the different configurations in a
2743         single test_expectations.txt file.
2744
2745         The next patch will merge in the separate GPU expectations file.
2746
2747         https://bugs.webkit.org/show_bug.cgi?id=51222
2748
2749         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2750         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2751         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2752         * Scripts/webkitpy/layout_tests/port/base.py:
2753         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2754         * Scripts/webkitpy/layout_tests/port/chromium.py:
2755         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2756         * Scripts/webkitpy/layout_tests/port/test.py:
2757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2758         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2759
2760 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2761
2762         Reviewed by Adam Barth.
2763
2764         Make webkit-patch support subdirectories for SVN checkouts
2765         https://bugs.webkit.org/show_bug.cgi?id=52261
2766
2767         * Scripts/webkitpy/common/checkout/scm.py:
2768         * Scripts/webkitpy/style_references.py:
2769         * Scripts/webkitpy/tool/main.py:
2770         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2771
2772 2011-01-11  Eric Seidel  <eric@webkit.org>
2773
2774         Unreviewed.
2775
2776         commit-queue should know how to upload archived results (for test flakes or general failures)
2777         https://bugs.webkit.org/show_bug.cgi?id=52048
2778
2779         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2780         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2781
2782         * Scripts/webkitpy/common/system/workspace.py:
2783         * Scripts/webkitpy/common/system/workspace_unittest.py:
2784         * Scripts/webkitpy/tool/commands/queues.py:
2785
2786 2011-01-11  Sam Weinig  <sam@webkit.org>
2787
2788         Roll r75474 back in.
2789
2790 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2791
2792         Reviewed by Kenneth Rohde Christiansen.
2793
2794         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2795         https://bugs.webkit.org/show_bug.cgi?id=51204
2796
2797         * QtTestBrowser/webpage.h:
2798         (QtNAMThread::QtNAMThread):
2799         (QtNAMThread::networkAccessManager):
2800         (QtNAMThread::run):
2801
2802 2011-01-11  Peter Varga  <pvarga@webkit.org>
2803
2804         Unreviewed.
2805
2806         Add myself to committers' list.
2807
2808         * Scripts/webkitpy/common/config/committers.py:
2809
2810 2011-01-11  Eric Seidel  <eric@webkit.org>
2811
2812         Reviewed by Adam Barth.
2813
2814         commit-queue should know how to upload archived results (for test flakes or general failures)
2815         https://bugs.webkit.org/show_bug.cgi?id=52048
2816
2817         Now the queue will always upload results.  Either the entire zip, or just
2818         the diffs.txt in the case of text failures.
2819
2820         This should make understanding flakes much easier, and paves the way
2821         for having the EWS run layout tests (and upload failures).
2822
2823         In order to upload .zip files I had to teach bugzilla.py to autodetect
2824         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2825         for .patch files, I have it add one before calling guess_type.
2826
2827         We may find that always uploading the whole zip instead of just the -diffs.txt
2828         file is preferable, but for now I'm keeping the old behavior because it makes
2829         quickly understanding text failures easy.
2830
2831         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2832         * Scripts/webkitpy/common/system/workspace.py: Added.
2833         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2834         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2835         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2836         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2837         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2838         * Scripts/webkitpy/tool/commands/queues.py:
2839         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2840
2841 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2842
2843         Unreviewed, rolling out r75464.
2844         http://trac.webkit.org/changeset/75464
2845         https://bugs.webkit.org/show_bug.cgi?id=52193
2846
2847         Followup rollout for 75474 (Requested by Ossy on #webkit).
2848
2849         * MiniBrowser/mac/BrowserWindowController.m:
2850         (-[BrowserWindowController awakeFromNib]):
2851         * MiniBrowser/win/BrowserView.cpp:
2852         (BrowserView::create):
2853         * WebKitTestRunner/TestController.cpp:
2854         (WTR::createOtherPage):
2855         (WTR::TestController::initialize):
2856
2857 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2858
2859         Reviewed by Csaba Osztrogonác.
2860
2861         [Qt] Baseline qt_minimal configuration
2862         https://bugs.webkit.org/show_bug.cgi?id=51313
2863
2864         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2865         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2866         QT_NO_UNDOSTACK guard.
2867
2868         * QtTestBrowser/launcherwindow.cpp:
2869         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2870         guards.
2871         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2872         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2873         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2874         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2875
2876         * QtTestBrowser/launcherwindow.h:
2877         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2878         * QtTestBrowser/locationedit.h: Ditto.
2879
2880         * QtTestBrowser/mainwindow.cpp:
2881         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2882         QT_NO_UNDOSTACK guards.
2883         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2884         (MainWindow::changeLocation): Ditto.
2885         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2886         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2887
2888         * QtTestBrowser/webpage.cpp:
2889         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2890         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2891
2892         * QtTestBrowser/webview.cpp:
2893         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2894         (WebViewGraphicsBased::animatedYFlip): Ditto.
2895
2896 2011-01-10  Sam Weinig  <sam@webkit.org>
2897
2898         Fix build.
2899
2900         * MiniBrowser/mac/BrowserWindowController.m:
2901         (-[BrowserWindowController awakeFromNib]):
2902         * MiniBrowser/win/BrowserView.cpp:
2903         (BrowserView::create):
2904         * WebKitTestRunner/TestController.cpp:
2905         (WTR::createOtherPage):
2906         (WTR::TestController::initialize):
2907
2908 2011-01-10  Eric Seidel  <eric@webkit.org>
2909
2910         Reviewed by Ojan Vafai.
2911
2912         style-queue messages are way too long for big patches
2913         https://bugs.webkit.org/show_bug.cgi?id=52161
2914
2915         We definitely could build much fancier list-to-string-with-limit functions
2916         but this should be sufficient for our needs at the moment.
2917
2918         * Scripts/webkitpy/common/system/executive.py:
2919         * Scripts/webkitpy/common/system/executive_unittest.py:
2920
2921 2011-01-10  Tony Chang  <tony@chromium.org>
2922
2923         Unreviewed, rolling out r75398.
2924         http://trac.webkit.org/changeset/75398
2925         https://bugs.webkit.org/show_bug.cgi?id=52008
2926
2927         Some layout tests are crashing on Chromium Win.
2928
2929         * DumpRenderTree/chromium/WebViewHost.cpp:
2930         (WebViewHost::updatePaintRect):
2931         * DumpRenderTree/chromium/WebViewHost.h:
2932
2933 2011-01-10  Adam Roben  <aroben@apple.com>
2934
2935         Roll out r75392
2936
2937         It isn't needed now that r75289 has been rolled out.
2938
2939         * Scripts/run-javascriptcore-tests:
2940
2941 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2942
2943         Reviewed by Anders Carlsson.
2944
2945         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2946         https://bugs.webkit.org/show_bug.cgi?id=52160
2947
2948         * WebKitTestRunner/mac/TestControllerMac.mm:
2949         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2950         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2951         anyway.
2952
2953 2011-01-10  Tony Chang  <tony@chromium.org>
2954
2955         Reviewed by Mihai Parparita.
2956
2957         [chromium] fix for animated gif layout tests
2958         https://bugs.webkit.org/show_bug.cgi?id=52008
2959
2960         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2961             to trigger gif animations.
2962         (WebViewHostPaintTask::WebViewHostPaintTask):
2963         (WebViewHostPaintTask::runIfValid):
2964         (WebViewHost::updatePaintRect):
2965         * DumpRenderTree/chromium/WebViewHost.h:
2966         (WebViewHost::taskList):
2967
2968 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2969
2970         Reviewed by Xan Lopez.
2971
2972         [GTK] Fix gtk2 compilation for master
2973         https://bugs.webkit.org/show_bug.cgi?id=51885
2974
2975         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2976         (createBitmapContextFromWebView): Replaced the old
2977         gdk_drawable_get_size with gdk_pixmap_get_size.
2978
2979 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2980
2981         Reviewed by Laszlo Gombos.
2982
2983         [WINCE] Reenable NPAPI after r75203
2984         https://bugs.webkit.org/show_bug.cgi?id=52109
2985
2986         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2987         it with !isEfl(), because EFL port does not support NPAPI (yet).
2988
2989         * Scripts/build-webkit:
2990
2991 2011-01-10  Adam Roben  <aroben@apple.com>
2992
2993         Skip some asserting JS tests
2994
2995         See <http://webkit.org/b/52156>.
2996
2997         * Scripts/run-javascriptcore-tests:
2998
2999 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3000
3001         Reviewed by Xan Lopez.
3002
3003         [GTK] build-webkit disable Blob support via arguments passed to automake
3004         https://bugs.webkit.org/show_bug.cgi?id=52097
3005
3006         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3007         build-webkit.
3008
3009 2011-01-10  Adam Roben  <aroben@apple.com>
3010
3011         Use the same name and description for TestNetscapePlugin on Windows and
3012         Mac
3013
3014         Fixes <http://webkit.org/b/52151>
3015         fast/frames/iframe-reparenting-plugins.html fails on Windows
3016
3017         Reviewed by Steve Falkenburg.
3018
3019         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3020         the name and description from Mac's Info.plist.
3021
3022 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3023
3024         Reviewed by Laszlo Gombos.
3025
3026         [Qt][WK2] Guard gcc-specific syntax
3027
3028         Non-gcc based compliers choke on the "-include"
3029         syntax for preinclude, place guard around it.
3030
3031         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3032         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3033
3034 2011-01-10  Andreas Kling  <kling@webkit.org>
3035
3036         Reviewed by Simon Hausmann.
3037
3038         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3039         https://bugs.webkit.org/show_bug.cgi?id=52111
3040
3041         When getting a createNewPage() callback from QWKPage, create the
3042         new page with the same QWKContext as the page that is passed to
3043         the callback.
3044
3045         * MiniBrowser/qt/BrowserView.h:
3046         * MiniBrowser/qt/BrowserWindow.cpp:
3047         (newPageFunction):
3048         (BrowserWindow::BrowserWindow):
3049         * MiniBrowser/qt/BrowserWindow.h:
3050
3051 2011-01-10  Andreas Kling  <kling@webkit.org>
3052
3053         Reviewed by Kenneth Rohde Christiansen.
3054
3055         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3056
3057         BrowserView set its own useless createNewPage() callback on QWKPage.
3058         This was immediately overridden by BrowserWindow anyway, so remove
3059         the BrowserView one.
3060
3061         * MiniBrowser/qt/BrowserView.cpp:
3062         (BrowserView::BrowserView):
3063
3064 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3065
3066         Reviewed by Jeremy Orlow.
3067
3068         [Chromium] Remove non-client-based Geolocation code
3069         https://bugs.webkit.org/show_bug.cgi?id=50921
3070
3071         * DumpRenderTree/chromium/LayoutTestController.cpp:
3072         (LayoutTestController::setGeolocationPermission):
3073         (LayoutTestController::setMockGeolocationPosition):
3074         (LayoutTestController::setMockGeolocationError):
3075         * DumpRenderTree/chromium/WebViewHost.cpp:
3076         (WebViewHost::geolocationClientMock):
3077         (WebViewHost::reset):
3078         * DumpRenderTree/chromium/WebViewHost.h:
3079
3080 2011-01-10  Eric Seidel  <eric@webkit.org>
3081
3082         Reviewed by Adam Barth.
3083
3084         Commit bot tried to land r? cq+ patch
3085         https://bugs.webkit.org/show_bug.cgi?id=36638
3086
3087         It should now be possible to post a patch with r? and cq+ and the
3088         commit-queue will correctly wait for the r+ before attempting to land the patch.
3089         (This was a feature requested by several users.)
3090
3091         One caveat: We don't actually reject r-, cq+ patches from the queue
3092         (we just ignore them), but I think that's OK for now.
3093
3094         I also noticed that setting r- once a commit-queue node had grabbed
3095         a patch would not properly cancel the landing.  That's fixed and
3096         tested in this patch.
3097
3098         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3099         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3100         * Scripts/webkitpy/tool/bot/feeders.py:
3101         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3102
3103 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3104
3105         Reviewed by Kenneth Rohde Christiansen.
3106
3107         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3108         https://bugs.webkit.org/show_bug.cgi?id=51934
3109
3110         When accessing the network from the destructor of QWebPage, the network access manager
3111         was already deleted because the object WebPage was already destructed.
3112
3113         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3114         The object is now destructed in the destructor of QObject.
3115
3116         * QtTestBrowser/webpage.cpp:
3117         (WebPage::WebPage):
3118         (WebPage::setQnamThreaded):
3119         * QtTestBrowser/webpage.h:
3120         (QtNAMThread::QtNAMThread):
3121
3122 2011-01-08  Eric Seidel  <eric@webkit.org>
3123
3124         Reviewed by Ojan Vafai.
3125
3126         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3127         https://bugs.webkit.org/show_bug.cgi?id=52067
3128
3129         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3130         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3131
3132         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3133
3134 2011-01-08  Eric Seidel  <eric@webkit.org>
3135
3136         Reviewed by Mihai Parparita.
3137
3138         commit-queue hangs when the ChangeLog diff is bad
3139         https://bugs.webkit.org/show_bug.cgi?id=52072
3140
3141         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3142         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3143
3144 2011-01-08  Adam Barth  <abarth@webkit.org>
3145
3146         Teach svn-apply how to re-write WebCore to Source/WebCore.
3147
3148         * Scripts/VCSUtils.pm:
3149
3150 2011-01-07  Adam Barth  <abarth@webkit.org>
3151
3152         Rubber-stamped by Eric Seidel.
3153
3154         Move WebCore to Source
3155         https://bugs.webkit.org/show_bug.cgi?id=52050
3156
3157         Update the tools to understand WebCore's new location.
3158
3159         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3160         * DumpRenderTree/wscript:
3161         * GNUmakefile.am:
3162         * Scripts/build-webkit:
3163         * Scripts/do-file-rename:
3164         * Scripts/do-webcore-rename:
3165         * Scripts/generate-qt-inspector-resource:
3166         * Scripts/prepare-ChangeLog:
3167         * Scripts/run-bindings-tests:
3168         * Scripts/update-iexploder-cssproperties:
3169         * Scripts/update-sources-list.py:
3170         * Scripts/update-webkit-localizable-strings:
3171         * Scripts/webkitdirs.pm:
3172         * Scripts/webkitpy/common/config/build.py:
3173         * Scripts/webkitpy/common/config/build_unittest.py:
3174         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3175         * Scripts/webkitpy/style/checker.py:
3176         * Scripts/webkitpy/style/checker_unittest.py:
3177         * WebKitTestRunner/DerivedSources.pro:
3178         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3179         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3180         * wx/browser/wscript:
3181         * wx/build/settings.py:
3182
3183 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3184
3185         Reviewed by Sam Weinig.
3186
3187         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3188         https://bugs.webkit.org/show_bug.cgi?id=52086
3189
3190         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3191         (WTR::InjectedBundle::didReceiveMessage):
3192         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3193         (WTR::LayoutTestController::notifyDone):
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::TestController::resetStateToConsistentValues):
3196         (WTR::TestController::run):
3197
3198 2011-01-07  James Robinson  <jamesr@chromium.org>
3199
3200         Revert "Implement mozilla's animationTime property"
3201         https://bugs.webkit.org/show_bug.cgi?id=51952
3202
3203         This approach isn't quite right.
3204
3205         * DumpRenderTree/chromium/WebViewHost.cpp:
3206         (WebViewHost::paintInvalidatedRegion):
3207
3208 2011-01-07  Adam Roben  <aroben@apple.com>
3209
3210         Build master fix
3211
3212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3213         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3214
3215 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3216
3217         Reviewed by Csaba Osztrogonác.
3218
3219         run-qtwebkit-tests should be able to kill a testsuite.
3220
3221         Add new option in the script that can setup a timeout for a test.
3222         If the test execution takes more then specified time then the test
3223         would be terminated.
3224
3225         [Qt] run-qtwebkit-tests needs timeout
3226         https://bugs.webkit.org/show_bug.cgi?id=51894
3227
3228         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3229         * Scripts/run-qtwebkit-tests:
3230
3231 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3232
3233         Unreviewed fix after r75233.
3234
3235         Based on idea from Eric Seidel.
3236
3237         Add remote zip file handling to webkitpy.
3238         https://bugs.webkit.org/show_bug.cgi?id=50901
3239
3240         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3241
3242 2011-01-07  Shane Stephens  <shanestephens@google.com>
3243
3244         Reviewed by Eric Seidel.
3245
3246         svn-apply: should support git binary delta diffs
3247         https://bugs.webkit.org/show_bug.cgi?id=38864
3248
3249         * Scripts/VCSUtils.pm:
3250         * Scripts/svn-apply:
3251
3252 2011-01-06  Julie Parent  <jparent@chromium.org>
3253
3254         Reviewed by Eric Seidel.
3255
3256         Test Result Server not removing old results.
3257         https://bugs.webkit.org/show_bug.cgi?id=52012
3258
3259         * TestResultServer/model/jsonresults.py:
3260         Fix off-by-one: Truncate if >= num_runs, not just >.
3261         * TestResultServer/model/jsonresults_unittest.py:
3262         Add unit test to test that merging in a new result with the same value
3263         as the last result causes previous result to fall off.
3264
3265 2011-01-06  James Kozianski  <koz@chromium.org>
3266
3267         Reviewed by Mihai Parparita.
3268
3269         Add classes to provide a consistent interface to a set of files.
3270         https://bugs.webkit.org/show_bug.cgi?id=50901
3271
3272         These classes allow us to write code that is agnostic to whether a
3273         particular set of files resides in a local directory or in a zip file
3274         on a remote machine.
3275
3276         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3277         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3278         * Scripts/webkitpy/common/system/fileset.py: Added.
3279         * Scripts/webkitpy/common/system/filesystem.py:
3280         * Scripts/webkitpy/common/system/filesystem_mock.py:
3281         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3282         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3283
3284 2011-01-06  Eric Seidel  <eric@webkit.org>
3285
3286         Reviewed by Adam Barth.
3287
3288         NetworkTransaction should log the url it is retrying
3289         https://bugs.webkit.org/show_bug.cgi?id=52043
3290
3291         * Scripts/webkitpy/common/net/networktransaction.py:
3292         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3293
3294 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3295
3296         Windows build fix.
3297         Import os before using it.
3298
3299         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3300
3301 2011-01-06  Eric Seidel  <eric@webkit.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         StyleQueue fails to report errors when patches have many files
3306         https://bugs.webkit.org/show_bug.cgi?id=52042
3307
3308         This is one of at least two errors preventing style error reporting at the moment.
3309         When we moved to passing the list of files to check explicitly,
3310         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3311         We could change the type of the QueueStatus.message type, or we could
3312         just teach statusserver.py how to clamp values (and warn when it does).
3313         I chose the latter path.
3314
3315         * Scripts/webkitpy/common/net/statusserver.py:
3316
3317 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3318
3319         Reviewed by Stephanie Lewis.
3320         
3321         Fix syntax error in script.
3322
3323         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3324         https://bugs.webkit.org/show_bug.cgi?id=51996
3325
3326         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3327
3328 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3329
3330         Unreviewed, fixing WinCE build after r75196.
3331
3332         WinCE port does not (yet) support NPAPI.
3333
3334         * Scripts/build-webkit:
3335
3336 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3337
3338         Reviewed by Darin Adler.
3339
3340         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3341         https://bugs.webkit.org/show_bug.cgi?id=52015
3342
3343         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3344         after the platform has been detected, otherwise the script will
3345         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3346         detection.
3347
3348 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3349
3350         Reviewed by Eric Seidel.
3351
3352         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3353         https://bugs.webkit.org/show_bug.cgi?id=51346
3354
3355         * Scripts/build-webkit:
3356
3357 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3358
3359         Reviewed by Adam Roben.
3360
3361         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3362         https://bugs.webkit.org/show_bug.cgi?id=51996
3363         
3364         After the configuration directory change, we were archiving the incorrect directory for
3365         build product, so we were running tests on the wrong binaries.
3366         
3367         This change archives the correct directory, and also unarchives it into a configuration-
3368         specific directory.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3371         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3372
3373 2011-01-06  Eric Seidel  <eric@webkit.org>
3374
3375         Reviewed by Mihai Parparita.
3376
3377         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3378         https://bugs.webkit.org/show_bug.cgi?id=52002
3379
3380         See an example of this here:
3381         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3382
3383         It's due to the fact that we pass around TestFailure() instance
3384         objects and yet expect them to all compare to be the same.
3385
3386         This is bad.  We should either have shared instances of these values
3387         or we should just pass around the class names.  There are already hacks
3388         in place to make TestFailure objects pass equality tests, I just added
3389         a __hash__ implementation so they can be used in sets as expected.
3390
3391         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3392         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3393
3394 2011-01-06  Evan Martin  <evan@chromium.org>
3395
3396         Reviewed by Tony Chang.
3397
3398         [gdb] handle inaccessible memory and UChar*
3399         https://bugs.webkit.org/show_bug.cgi?id=52003
3400
3401         To pretty-print a UChar*, we just grope around in the memory
3402         looking for a terminating NUL.  We need to handle the exception
3403         that can occur when we poke into an invalid location.
3404
3405         Additionally, the logic for choosing which pretty-printer would
3406         early return before hitting the point where we'd use the UChar*
3407         printer.  (Did this ever work?  How did it regress?)
3408
3409         * gdb/webkit.py:
3410
3411 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3412
3413         Reviewed by Ada Chan.
3414
3415         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3416         https://bugs.webkit.org/show_bug.cgi?id=51969
3417         
3418         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3419
3420         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3421         (WTR::InjectedBundlePage::InjectedBundlePage):
3422         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3424
3425 2011-01-06  James Robinson  <jamesr@chromium.org>
3426
3427         Reviewed by Simon Fraser.
3428
3429         Implement mozilla's animationTime property
3430         https://bugs.webkit.org/show_bug.cgi?id=51952
3431
3432         Chromium DRT support for webkitAnimationTime.
3433
3434         * DumpRenderTree/chromium/WebViewHost.cpp:
3435         (WebViewHost::paintInvalidatedRegion):
3436
3437 2011-01-06  Julie Parent  <jparent@chromium.org>
3438
3439         Reviewed by Tony Chang.
3440
3441         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3442         https://bugs.webkit.org/show_bug.cgi?id=51217
3443
3444         * TestResultServer/model/jsonresults.py:
3445         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3446         Adds missing documentation.
3447         * TestResultServer/model/jsonresults_unittest.py:
3448         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3449         Update test_merge to take a number of builds to truncate at.
3450
3451 2011-01-06  Adam Barth  <abarth@webkit.org>
3452
3453         Reviewed by Eric Seidel.
3454
3455         The EWS should log outside of the working directory
3456         https://bugs.webkit.org/show_bug.cgi?id=51986
3457
3458         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3459         script, which will actually clean the working copy back to a pristine
3460         state instead of leaving untracked directories and ignored files.
3461
3462         * Scripts/webkitpy/tool/commands/queues.py:
3463         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3464
3465 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3466
3467         Windows build fix.
3468         Back out attempted change to built-product-archive.
3469
3470         * BuildSlaveSupport/built-product-archive:
3471
3472 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3473
3474         Windows build fix.
3475         Include configuration name when unpacking a build archive.
3476
3477         Needed, since we split Windows build results into configuration-specific directories
3478         under WebKitOutputDir.
3479
3480         * BuildSlaveSupport/built-product-archive:
3481
3482 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3483
3484         Reviewed by Darin Adler.
3485
3486         Debug and Release builds on Windows clobber each other
3487         https://bugs.webkit.org/show_bug.cgi?id=49185
3488
3489         Changes the structure of WebKitBuild build products directory so we
3490         completely separate each build configuration into independent directories.
3491         
3492         Although we previously had per-configuration directories for obj, this change adds
3493         per-configuration directories for bin, lib, obj, and include. Each configuration's
3494         build products are stored within a directory inside of WebKitBuild.
3495         
3496         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3497         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3498
3499         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3500         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3501         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3502         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3503         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3504         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3505         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3506         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3507         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3508         * FindSafari/FindSafari.vcproj:
3509         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3510         * MiniBrowser/MiniBrowserPostBuild.cmd:
3511         * MiniBrowser/MiniBrowserPreBuild.cmd:
3512         * Scripts/webkitdirs.pm:
3513         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3514         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3515         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3516         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3517         * TestWebKitAPI/win/copy-resources.cmd:
3518         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3519         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3520         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3521         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3522         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3523         * WebKitTestRunner/win/InjectedBundle.vcproj:
3524         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3525         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3526         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3527         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3528         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3529         * WinLauncher/WinLauncherCommon.vsprops:
3530         * WinLauncher/WinLauncherPostBuild.cmd:
3531         * WinLauncher/WinLauncherPreBuild.cmd:
3532
3533 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3534
3535         Reviewed by Ariya Hidayat.
3536
3537         [Qt] TestNetscapePlugin doesn't link on OS X
3538         https://bugs.webkit.org/show_bug.cgi?id=51948
3539
3540         Only add a dependency on libX11 on X11 systems
3541
3542         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3543
3544 2011-01-05  Jeff Miller  <jeffm@apple.com>
3545
3546         Reviewed by Adam Roben.
3547
3548         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3549         https://bugs.webkit.org/show_bug.cgi?id=51970
3550
3551         * Scripts/webkitpy/style/checker.py:
3552         Add -readability/naming for WebKit2 C API directories.
3553
3554 2011-01-05  Eric Seidel  <eric@webkit.org>
3555
3556         Unreviewed, just fixing one more log error from my previous python patch.
3557
3558         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3559         https://bugs.webkit.org/show_bug.cgi?id=51802
3560
3561         webkit-patch failure-reason was logging about parsing errors
3562         due to my misunderstanding of how BeautifulSoup.findAll worked.
3563
3564         Fixed, and added a unit test.
3565
3566         * Scripts/webkitpy/common/net/layouttestresults.py:
3567         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3568
3569 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3570
3571         Reviewed by Kenneth Rohde Christiansen.
3572
3573         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3574         https://bugs.webkit.org/show_bug.cgi?id=51951
3575
3576         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3577         to create new window from WebKit.
3578
3579         * MiniBrowser/qt/BrowserWindow.cpp:
3580         (newPageFunction):
3581         (BrowserWindow::BrowserWindow):
3582         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3583         (BrowserWindow::newWindow):
3584         (BrowserWindow::updateUserAgentList):
3585         (BrowserWindow::showUserAgentDialog):
3586         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3587         define the type of the backing store used for new windows.
3588         * MiniBrowser/qt/main.cpp:
3589         (main):
3590
3591 2011-01-05  Eric Seidel  <eric@webkit.org>
3592
3593         Reviewed by Ojan Vafai.
3594
3595         commit-queue should report failure type when reporting flaky tests
3596         https://bugs.webkit.org/show_bug.cgi?id=51900
3597
3598         This patch was a ridiculous amount of plumbing.  In the end I like
3599         the NRWT-style TestResult class even less.  But now we're passing
3600         a list of TestResult objects from the queue to the FlakyTestReporter.
3601         Thus the FlakyTestReporter can more easily report what type of failure
3602         occurred.
3603
3604         In the process, I found that I was not alone in finding TestResult
3605         cumbersome to use.  A bunch of code was trying to create a TestResult
3606         object with default values.  However since the constructor didn't make
3607         this easy, some places were getting it wrong (including the TestResult unit test)!
3608         I've fixed the TestResult constructor to have default values for non-essential
3609         arguments.
3610
3611         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3612         * Scripts/webkitpy/common/net/layouttestresults.py:
3613         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3614         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3615         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3616         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3617         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3618         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3619         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3620         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3621         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3622         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3623         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3624         * Scripts/webkitpy/tool/commands/queues.py:
3625         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3626
3627 2011-01-05  Eric Seidel  <eric@webkit.org>
3628
3629         Unreviewed.
3630
3631         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3632         https://bugs.webkit.org/show_bug.cgi?id=51802
3633
3634         Add another unit test to cover a previously missing import.
3635
3636         * Scripts/webkitpy/common/net/layouttestresults.py:
3637         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3638
3639 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3640
3641         Reviewed by David Levin.
3642
3643         Add mihaip@chromium.org as a reviewer
3644         https://bugs.webkit.org/show_bug.cgi?id=51966
3645         
3646         Add myself as a reviewer.
3647
3648         * Scripts/webkitpy/common/config/committers.py:
3649
3650 2011-01-05  James Simonsen  <simonjam@chromium.org>
3651
3652         Unreviewed. Adding myself to the list of committers.
3653
3654         * Scripts/webkitpy/common/config/committers.py:
3655
3656 2011-01-05  Eric Seidel  <eric@webkit.org>
3657
3658         Unreviewed.
3659
3660         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3661         https://bugs.webkit.org/show_bug.cgi?id=51802
3662
3663         Fix two exceptions seen on the bots after my original commit.
3664
3665         * Scripts/webkitpy/common/net/layouttestresults.py:
3666         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3667
3668 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3669
3670         Reviewed by Andreas Kling.
3671
3672         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3673         https://bugs.webkit.org/show_bug.cgi?id=51750
3674
3675         * QtTestBrowser/main.cpp:
3676         (LauncherApplication::handleUserOptions):
3677          Local storage settings can be enable form command line arguments for
3678          QtTestBrowser.
3679
3680 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3681
3682         Reviewed by Martin Robinson.
3683
3684         GTK: AX: DRT needs to use correct root object method.
3685         https://bugs.webkit.org/show_bug.cgi?id=51911
3686
3687         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3688         (AccessibilityController::rootElement):
3689
3690 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3691
3692         Rubber-stamped by Csaba Osztrogonác.
3693
3694         Based on idea from Péter Gál.
3695
3696         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3697
3698 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3699
3700         Reviewed by Adam Barth.
3701
3702         sheriff-bot should be able to do multi-revision rollouts
3703         https://bugs.webkit.org/show_bug.cgi?id=51176
3704
3705         * Scripts/webkitpy/tool/bot/irc_command.py: