[GTK] update-webkitgtk-libs should use mesa tarball
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
2
3         [GTK] update-webkitgtk-libs should use mesa tarball
4
5         https://bugs.webkit.org/show_bug.cgi?id=150470
6
7         update-webkitgtk-libs downloads all build dependencies; in fixing
8         bug 148941 mesa was switched from ftp to git access.  Now an http
9         tarball is available, which is preferred over accessing via git.
10
11         Reviewed by Philippe Normand
12
13         * gtk/jhbuild.modules:
14         Mesa access changed to http tarball.
15
16 2015-10-22  Sam Weinig  <sam@webkit.org>
17
18         Navigations on the same host (but with different schemes and ports) should not trigger universal links
19         <rdar://problem/22811325>
20         https://bugs.webkit.org/show_bug.cgi?id=150481
21
22         Reviewed by Dan Bernstein.
23
24         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
25         Update test to test that navigations on the same host but with different schemes does not
26         trigger universal links, but that changes in the host do.
27
28 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
29
30         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
31         https://bugs.webkit.org/show_bug.cgi?id=150428
32
33         Reviewed by Antti Koivisto.
34
35         Added a regression test using WebKit API test.
36
37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
38         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
39         (TestWebKitAPI::didFinishLoadForFrame):
40         (TestWebKitAPI::TEST):
41
42 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
43
44         Unreviewed. Fix GTK+ build after r191423.
45
46         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
47
48         * gtk/webkitdom.py:
49         (WebKitDOMDocGenerator):
50
51 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
52
53         [Win][EFL][GTK] webkitpy test failed after r191374.
54         https://bugs.webkit.org/show_bug.cgi?id=150433
55
56         Reviewed by Alexey Proskuryakov.
57
58         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
59         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
60         (CrashLogsTest.test_find_log_darwin): Same.
61
62 2015-10-21  Brian Burg  <bburg@apple.com>
63
64         Unreviewed, update watchlist for JS builtins.
65
66         Add a category for JS builtins code generator, similar to other generators.
67
68         Add a nag message to rebaseline builtins generator tests when touching
69         code generator files in Source/JavaScriptCore/Scripts/builtins/.
70
71         * Scripts/webkitpy/common/config/watchlist:
72
73 2015-10-21  Brian Burg  <bburg@apple.com>
74
75         Restructure generate-js-bindings script to be modular and testable
76         https://bugs.webkit.org/show_bug.cgi?id=149929
77
78         Reviewed by Alex Christensen.
79
80         Add a stub shell script and basic webkitpy support for running builtins
81         generator tests.
82
83         * Scripts/run-builtins-generator-tests: Added.
84         (main):
85         * Scripts/webkitpy/codegen/__init__.py: Added.
86         * Scripts/webkitpy/codegen/main.py: Added.
87
88             The only interesting difference here from the inspector protocol
89             generator equivalent is that this implementation decodes the target
90             framework and output mode (combined or separate) from the test's file name.
91
92         (BuiltinsGeneratorTests):
93         (BuiltinsGeneratorTests.__init__):
94         (BuiltinsGeneratorTests.generate_from_js_builtins):
95         (BuiltinsGeneratorTests.write_error_file):
96         (BuiltinsGeneratorTests.detect_changes):
97         (BuiltinsGeneratorTests.run_tests):
98         (BuiltinsGeneratorTests.main):
99
100 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
101
102         run-webkit-tests does not copy all crash logs for layout test failures on Mac
103         https://bugs.webkit.org/show_bug.cgi?id=150407
104         <rdar://problem/22239750>
105
106         Reviewed by Alexey Proskuryakov.
107
108         * Scripts/webkitpy/port/mac.py:
109         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
110         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
111         the log directory.
112         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
113         from log directory and merge them with the list of already crashed tests.
114
115 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
116
117         Failures in PutStackSinkingPhase should be less severe
118         https://bugs.webkit.org/show_bug.cgi?id=150400
119
120         Reviewed by Geoffrey Garen.
121
122         Add a test mode for no PutStackSinkingPhase.
123
124         * Scripts/run-jsc-stress-tests:
125
126 2015-10-21  Nan Wang  <n_wang@apple.com>
127
128         AX: Expose table size and cell indexes on iOS
129         https://bugs.webkit.org/show_bug.cgi?id=150366
130
131         Reviewed by Chris Fleizach.
132
133         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
134         (AccessibilityUIElement::rowCount):
135         (AccessibilityUIElement::columnCount):
136         (AccessibilityUIElement::indexInTable):
137         (AccessibilityUIElement::numberAttributeValue):
138         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
139         (WTR::AccessibilityUIElement::numberAttributeValue):
140         (WTR::AccessibilityUIElement::rowCount):
141         (WTR::AccessibilityUIElement::columnCount):
142         (WTR::AccessibilityUIElement::indexInTable):
143
144 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
145
146         W3C test importer should not import reference files as regular tests
147         https://bugs.webkit.org/show_bug.cgi?id=150331
148
149         Reviewed by Darin Adler.
150
151         Updated test_parser to return information that a file can be a referencefile or a manual test.
152         Updated test importer to skip those files.
153         Updated/Added test parser unit tests accordingly.
154
155         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
156         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
157         to mark these files as Skip, since they are not direct tests. 
158
159         * Scripts/webkitpy/w3c/test_importer.py:
160         (TestImporter.__init__):
161         (TestImporter.find_importable_tests):
162         (TestImporter.import_tests):
163         * Scripts/webkitpy/w3c/test_parser.py:
164         (TestParser.analyze_test):
165         * Scripts/webkitpy/w3c/test_parser_unittest.py:
166         (test_analyze_non_html_file):
167         (test_reference_test):
168
169 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
170
171         run-webkit-tests does not copy all crash logs for layout test failures on iOS
172         https://bugs.webkit.org/show_bug.cgi?id=150056
173         <rdar://problem/9280656>
174
175         Reviewed by Alexey Proskuryakov.
176
177         * Scripts/webkitpy/common/system/crashlogs.py:
178         (CrashLogs.find_all_logs): Generic method to find all crash logs.
179         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
180         It iterates through log directory and returns all the logs based on timestamp.
181         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
182         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
183         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
184         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
185         * Scripts/webkitpy/layout_tests/controllers/manager.py:
186         (Manager.run): Modified start_time to start counting before simulator launch
187         so that we can capture crashes during simualator launch.
188         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
189         any test which is not already marked as CRASH to the run_results.
190         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
191         (TestExpectationsModel.get_expectations_string): return PASS in case there
192         are no expectations defined for this test.
193         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
194         (summarize_results): Add other_crashes in a separte category in full_results.json.
195         * Scripts/webkitpy/port/ios.py:
196         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
197         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
198         from the log directory.
199         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
200         logs from log directory and merge them with the list of already crashed tests.
201
202 2015-10-20  Dana Burkart  <dburkart@apple.com>
203
204         Fix the build
205
206         Unreviewed.
207
208         My previous patch was missing a necessary space character.
209
210         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
211
212 2015-10-20  Dana Burkart  <dburkart@apple.com>
213
214         svn-apply fails to apply binary diffs in some cases
215         https://bugs.webkit.org/show_bug.cgi?id=64647
216
217         Reviewed by Daniel Bates.
218
219         * Scripts/VCSUtils.pm:
220         (decodeGitBinaryPatchDeltaSize): Modified.
221         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
222         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
223
224 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
225
226         Mac Debug EWS never finishes when there are failures
227         https://bugs.webkit.org/show_bug.cgi?id=150334
228
229         Reviewed by Daniel Bates.
230
231         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
232         * Scripts/webkitpy/tool/commands/queues.py:
233
234 2015-10-20  Philippe Normand  <pnormand@igalia.com>
235
236         [GTK] Enable OpenWebRTC test video/audio sources in tests
237
238         This is needed because we can't expect the buildbots to have
239         webcam/mic devices plugged in.
240
241         Rubber-stamped by Carlos Garcia Campos.
242
243         * Scripts/run-gtk-tests:
244         (TestRunner._setup_testing_environment):
245         * Scripts/webkitpy/port/gtk.py:
246         (GtkPort.setup_environ_for_server):
247
248 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
249
250         Rename the PICTURE_SIZES flag to CURRENTSRC
251         https://bugs.webkit.org/show_bug.cgi?id=150275
252
253         Reviewed by Dean Jackson.
254
255         * Scripts/webkitperl/FeatureList.pm:
256
257 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
258
259         Unreviewed, add myself to the committers list.
260
261         * Scripts/webkitpy/common/config/contributors.json:
262
263 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
264
265         Add new EWS queues to bot watcher's dashboard
266         https://bugs.webkit.org/show_bug.cgi?id=150297
267
268         Reviewed by Darin Adler.
269
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
271         (BubbleQueueServer):
272
273 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
274
275         REGRESSION(r190262): User media unit test failures after r190262
276         https://bugs.webkit.org/show_bug.cgi?id=149580
277
278         Reviewed by Carlos Garcia Campos.
279
280         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
281         So we do not need to skip them anymore.
282
283         * Scripts/run-gtk-tests:
284         (TestRunner): Deleted.
285
286 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
287
288         Add historical addresses to contributors.json
289         https://bugs.webkit.org/show_bug.cgi?id=150227
290
291         Reviewed by Darin Adler.
292
293         * Scripts/webkitpy/common/config/contributors.json:
294
295 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
296
297         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
298         https://bugs.webkit.org/show_bug.cgi?id=150307
299
300         Reviewed by Brent Fulgham.
301
302         The DLL build rules have been changed to generate "{Name}Lib.DLL",
303         but these changes have not yet been applied to the Visual Studio builds.
304
305         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
306
307 2015-10-16  Andreas Kling  <akling@apple.com>
308
309         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
310         <https://webkit.org/b/150153>
311
312         Unreviewed.
313
314         Just use simple arrays of LChar and UChar for this test instead of creating String
315         objects and then getting the characters8()/characters16() from them, since that
316         doesn't guarantee null-termination (the bug.)
317
318         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
319         (TestWebKitAPI::TEST):
320         (TestWebKitAPI::build): Deleted.
321
322 2015-10-16  Tim Horton  <timothy_horton@apple.com>
323
324         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
325         https://bugs.webkit.org/show_bug.cgi?id=150255
326
327         Reviewed by Simon Fraser.
328
329         * Scripts/run-api-tests:
330         (runTest):
331         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
332         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
333         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
334         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
335         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
336         Don't set the layout size until after the load finishes and we're waiting
337         for the reply, so that there is no race between the new size coming in
338         and us waiting for it.
339
340 2015-10-16  Anders Carlsson  <andersca@apple.com>
341
342         WebEditingDelegate should be a formal protocol
343         https://bugs.webkit.org/show_bug.cgi?id=150254
344         <rdar://problem/23149847>
345
346         Reviewed by Dan Bernstein.
347
348         * DumpRenderTree/mac/EditingDelegate.h:
349         Conform to the WebEditingDelegate protocol.
350
351 2015-10-16  Tim Horton  <timothy_horton@apple.com>
352
353         Hook up autolayout intrinsic sizing for WKWebView
354         https://bugs.webkit.org/show_bug.cgi?id=150219
355         <rdar://problem/20016905>
356
357         Reviewed by Simon Fraser.
358
359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
360         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
361         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
362         (-[AutoLayoutWKWebView load:expectingContentSize:]):
363         (-[AutoLayoutWKWebView expectContentSizeChange:]):
364         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
365         (TEST):
366         Add a variety of tests, including one which catches the bug that
367         the WebCore part of this patch fixes.
368
369 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
370
371         Update the help message of --system-malloc
372         https://bugs.webkit.org/show_bug.cgi?id=150169
373
374         Reviewed by Geoffrey Garen.
375
376         * Scripts/webkitperl/FeatureList.pm:
377
378 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
379
380         Update ImportExpectations according currently imported wpt tests
381         https://bugs.webkit.org/show_bug.cgi?id=150158
382
383         Reviewed by Chris Dumez.
384
385         * Scripts/webkitpy/w3c/test_downloader.py:
386         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
387
388 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
389
390         Unreviewed, Update my email address.
391
392         * Scripts/webkitpy/common/config/contributors.json:
393
394 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
395
396         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
397         https://bugs.webkit.org/show_bug.cgi?id=84960
398
399         Reviewed by Žan Doberšek.
400
401         * Scripts/run-gtk-tests:
402         (TestRunner): Unskip tests using SessionState.
403         * TestWebKitAPI/PlatformGTK.cmake: Add
404         WKPageCopySessionStateWithFiltering test.
405
406 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
407
408         [GTK] Missing return value on TestWebExtensions.cpp:193
409         https://bugs.webkit.org/show_bug.cgi?id=149755
410
411         Unreviewed. Add missing return value.
412
413         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
414         (permissionRequestCallback):
415
416 2015-10-14  Andy Estes  <aestes@apple.com>
417
418         [iOS] build-dumprendertree does not build ImageDiff
419         https://bugs.webkit.org/show_bug.cgi?id=150152
420
421         Reviewed by Tim Horton.
422
423         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
424         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
425         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
426         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
427
428         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
429         fine on that platform, and results in ImageDiff being built.
430
431         * Scripts/build-dumprendertree:
432
433 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
434
435         [Win] Enforce launcher/library naming scheme
436         https://bugs.webkit.org/show_bug.cgi?id=150124
437
438         Reviewed by Alex Christensen.
439
440         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
441         * MiniBrowser/win/CMakeLists.txt: Ditto.
442         * TestWebKitAPI/PlatformWin.cmake: Ditto.
443         * win/DLLLauncher/DLLLauncherMain.cpp:
444         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
445         original {name}.dll.
446
447 2015-10-14  Andreas Kling  <akling@apple.com>
448
449         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
450         <https://webkit.org/b/150135>
451
452         Reviewed by Geoffrey Garen.
453
454         Add a new WTF API test that covers this issue.
455
456         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
457         (TestWebKitAPI::build):
458         (TestWebKitAPI::TEST):
459
460 2015-10-14  Alex Christensen  <achristensen@webkit.org>
461
462         Add SPI for reloading without content blockers
463         https://bugs.webkit.org/show_bug.cgi?id=150058
464         rdar://problem/22742222
465
466         Reviewed by Sam Weinig.
467
468         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
469         (WTR::TestController::cocoaResetStateToConsistentValues):
470         * WebKitTestRunner/mac/TestControllerMac.mm:
471         (WTR::TestController::platformConfigureViewForTest):
472
473 2015-10-14  Mark Lam  <mark.lam@apple.com>
474
475         Rename some JSC option names to be more uniform.
476         https://bugs.webkit.org/show_bug.cgi?id=150127
477
478         Reviewed by Geoffrey Garen.
479
480         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
481         * Scripts/run-jsc-stress-tests:
482
483 2015-10-14  Anders Carlsson  <andersca@apple.com>
484
485         Change the bundle app cache APIs to take a page
486         https://bugs.webkit.org/show_bug.cgi?id=150123
487
488         Reviewed by Sam Weinig.
489
490         Update APIs.
491
492         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
493         (WTR::InjectedBundle::beginTesting):
494         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
495         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
497         (WTR::TestRunner::clearAllApplicationCaches):
498         (WTR::TestRunner::clearApplicationCacheForOrigin):
499         (WTR::TestRunner::setAppCacheMaximumSize):
500         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
501         (WTR::TestRunner::originsWithApplicationCache):
502
503 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
504
505         Update web-platform-tests tools to the latest revision
506         https://bugs.webkit.org/show_bug.cgi?id=149645
507
508         Reviewed by Darin Adler.
509
510         Disabling git submodules information conversion to json install file for web-platform-tests.
511         Disabling related python unit tests.
512         The tools submodules contain submodules and the conversion tool does not support that yet.
513
514         Updating wpt launcher script to aling it with web-platform-test main script.
515
516         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
517         (main):
518         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
519         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
520         * Scripts/webkitpy/w3c/test_importer_unittest.py:
521         (TestImporterTest.test_submodules_generation):
522
523 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
524
525         More debug queue build fixing.
526
527         Preserve the build style in one more place. Changed mock build_style from "both"
528         to "release", as we don't support testing both debug and release.
529
530         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
531         (MockCommitQueue.archive_last_test_results):
532         (MockCommitQueue):
533         (MockCommitQueue.build_style):
534         (MockCommitQueue.did_pass_testing_ews):
535         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
536         (PatchAnalysisTask._test):
537         (PatchAnalysisTask._build_and_test_without_patch):
538         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
539         (EarlyWarningSystemTest._default_expected_logs):
540         * Scripts/webkitpy/tool/commands/queues_unittest.py:
541
542 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
543
544         More debug queue build fixing.
545
546         Add build_style argument to derived classes as well.
547
548         * Scripts/webkitpy/common/config/ports.py:
549         (MacPort):
550         (MacPort.run_webkit_tests_command):
551         (WinPort.run_bindings_tests_command):
552         (WinPort):
553         (WinPort.run_webkit_tests_command):
554         (GtkWK2Port.build_webkit_command):
555         (GtkWK2Port):
556         (GtkWK2Port.run_webkit_tests_command):
557
558 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
559
560         [iOS] Build fix
561
562         Unreviewed.
563
564         Mach-O section names are limited to 16 characters.
565
566         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
567         * DumpRenderTree/mac/DumpRenderTree.mm:
568         (activateFontsIOS):
569
570 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
571
572         Build fix for mac-debug EWS queue.
573
574         Unreviewed.
575
576         Pass --debug to run-webkit-tests.
577
578         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
579         will need to be substantially modified to work in EWS, so the dummy implementation
580         was not helpful.
581
582         * Scripts/webkitpy/common/config/ports.py:
583         (DeprecatedPort.run_javascriptcore_tests_command):
584         (DeprecatedPort):
585         (DeprecatedPort.run_webkit_tests_command):
586         (DeprecatedPort.run_python_unittests_command):
587         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
588         * Scripts/webkitpy/common/config/ports_mock.py:
589         (MockPort.run_javascriptcore_tests_command):
590         (MockPort):
591         (MockPort.run_webkit_tests_command):
592         (MockPort.run_bindings_tests_command):
593         (MockPort.run_webkit_unit_tests_command): Deleted.
594         * Scripts/webkitpy/tool/commands/download_unittest.py:
595         * Scripts/webkitpy/tool/steps/runtests.py:
596         (RunTests.run):
597         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
598         (RunTestsTest.test_webkit_run_unit_tests):
599         * Scripts/webkitpy/tool/steps/steps_unittest.py:
600         (StepsTest.test_runtests_args):
601
602 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
603
604         [Win] Generate Crash Traces
605         https://bugs.webkit.org/show_bug.cgi?id=150103
606
607         Reviewed by Daniel Bates.
608
609         We were using an exception filter to try to emit "#CRASHED" to stderr
610         when a test program crashed. However, the modern Python implementation
611         seems capable of recognizing crashes on its own. Furthermore, registering
612         the exception handler was preventing the JIT debugger (NTSD) from
613         automatically attaching to the crashing program, so we were not getting
614         crash traces.
615         
616         * DumpRenderTree/win/DumpRenderTree.cpp:
617         (main): Don't register an exception filter.
618         (exceptionFilter): Deleted.
619         * Scripts/webkitpy/common/system/crashlogs.py:
620         (CrashLogs): Add another regular expression to handle a second crash trace
621         syntax I encountered during testing.
622         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
623         try the new one. The PID found by the new expression is in hexadecimal, so
624         convert it to an integer before returning it.
625         * Scripts/webkitpy/port/driver.py:
626         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
627         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
628         check for "#CRASHED" after stripping off the EOL characters.
629         * Scripts/webkitpy/port/win.py:
630         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
631         invocation. This is apparently used to signal an event when the debugger is finished.
632
633 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
634
635         Mac Debug and 32-bit queues should be separate
636         https://bugs.webkit.org/show_bug.cgi?id=150092
637
638         Reviewed by Lucas Forschler.
639
640         * QueueStatusServer/config/queues.py:
641         * QueueStatusServer/model/queues.py:
642         (Queue._capitalize_after_dash):
643         (Queue._caplitalize_after_dash): Deleted.
644         * Scripts/webkitpy/common/config/ews.json:
645
646 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
647
648         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
649         https://bugs.webkit.org/show_bug.cgi?id=150085
650
651         Reviewed by Carlos Garcia Campos.
652
653         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
654
655 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
656
657         Unreviewed, add myself to the committers list.
658
659         * Scripts/webkitpy/common/config/contributors.json:
660
661 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
662
663         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
664         https://bugs.webkit.org/show_bug.cgi?id=149983
665
666         Reviewed by Dan Bates.
667
668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
669         (BubbleQueueServer):
670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
671
672 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
673
674         Fix webkitpy tests after r190922.
675
676         * Scripts/webkitpy/common/config/ews.json:
677         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
678         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
679
680 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
681
682         Add a Mac debug EWS queue
683         https://bugs.webkit.org/show_bug.cgi?id=150069
684
685         Reviewed by Geoffrey Garen.
686
687         * QueueStatusServer/config/queues.py:
688         * Scripts/webkitpy/common/config/ews.json:
689         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
690         (AbstractEarlyWarningSystem):
691         (AbstractEarlyWarningSystem.archive_last_test_results):
692         (AbstractEarlyWarningSystem.build_style):
693         (AbstractEarlyWarningSystem.refetch_patch):
694         (AbstractEarlyWarningSystem.load_ews_classes):
695
696 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
697
698         [GTK] Update jhbuild's version of harfbuzz
699         https://bugs.webkit.org/show_bug.cgi?id=149749
700
701         Reviewed by Martin Robinson.
702
703         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
704
705         * gtk/jhbuild.modules: Updated details for harfbuzz.
706
707 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
708
709         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
710         https://bugs.webkit.org/show_bug.cgi?id=150026
711
712         Reviewed by Philippe Normand.
713
714         Backport upstream patch from gst-plugins-bad so that the right version
715         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
716         gets compiled properly, avoiding crashes on runtime while running tests.
717
718         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
719         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
720
721 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
722
723         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
724         https://bugs.webkit.org/show_bug.cgi?id=149777
725
726         Reviewed by Simon Fraser.
727
728         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
729         to the list of tests to preinstall at startup time.
730
731         Also, update the generation of the 'name' table in the FontWithFeatures font.
732
733         * DumpRenderTree/mac/DumpRenderTree.mm:
734         (allowedFontFamilySet):
735         (activateTestingFonts):
736         (activateFontsIOS):
737         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
738         (Generator::generate):
739         (Generator::appendCFFTable):
740         (Generator::appendNameSubtable):
741         (Generator::appendNAMETable):
742         * FontWithFeatures/FontWithFeatures/main.cpp:
743         (main):
744         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
745         (WTR::allowedFontFamilySet):
746         (WTR::activateFonts):
747         * WebKitTestRunner/mac/TestControllerMac.mm:
748         (WTR::allowedFontFamilySet):
749
750 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
751
752         Unreviewed. Add Jinyoung Hur as a committer. 
753
754         * Scripts/webkitpy/common/config/contributors.json:
755
756 2015-10-10  Dan Bernstein  <mitz@apple.com>
757
758         [iOS] Remove unnecessary iOS version checks
759         https://bugs.webkit.org/show_bug.cgi?id=150002
760
761         Reviewed by Alexey Proskuryakov.
762
763         * WebKitTestRunner/ios/HIDEventGenerator.mm:
764         (-[HIDEventGenerator _createIOHIDEventType:]):
765         (-[HIDEventGenerator _sendHIDEvent:]):
766         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
767         * WebKitTestRunner/ios/UIKitSPI.h:
768
769 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
770
771         Unreviewed, rolling out r190689
772         https://bugs.webkit.org/show_bug.cgi?id=149992
773
774         Fixed in other repository.
775
776         Reverted changesets:
777
778         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
779         https://bugs.webkit.org/show_bug.cgi?id=149897
780
781 2015-10-09  Brian Burg  <bburg@apple.com>
782
783         Teach webkitperl how to figure out IOS versions from the SDK
784         https://bugs.webkit.org/show_bug.cgi?id=149963
785
786         Reviewed by Daniel Bates.
787
788         It should be easier to check the major and minor version of IOS SDKs.
789
790         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
791         * Scripts/webkitdirs.pm:
792         (splitVersionString): Added.
793         (determineOSXVersion): Use splitVersionString.
794         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
795         (iosVersion): Added.
796
797 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
798
799         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
800         https://bugs.webkit.org/show_bug.cgi?id=149960
801
802         Reviewed by Tim Horton.
803         
804         Use adoptWK(), and null out some members (file is not using ARC).
805
806         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
807         (UIScriptContext::uiScriptComplete):
808         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
809         (-[TestRunnerWKWebView dealloc]):
810
811 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
812
813         Remove ENABLE_SUID_SANDBOX_LINUX cruft
814         https://bugs.webkit.org/show_bug.cgi?id=149954
815
816         Reviewed by Darin Adler.
817
818         * Scripts/webkitperl/FeatureList.pm:
819
820 2015-10-09  Daniel Bates  <dabates@apple.com>
821
822         Make iOS builders generate debug information in a separate dSYM file
823         https://bugs.webkit.org/show_bug.cgi?id=149696
824
825         Reviewed by Darin Adler.
826
827         Similar to the Mac builders, the iOS builders should write debug information
828         into a separate dSYM file instead of including such information in the binary
829         itself (default Xcode behavior)
830
831         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
832         (CompileWebKit.start):
833
834 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
835
836         Fix webkitpy tests after r190779
837         https://bugs.webkit.org/show_bug.cgi?id=149949
838
839         Reviewed by Ryosuke Niwa.
840
841         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
842         (BenchmarkResults.format):
843         (BenchmarkResults._format_values):
844
845 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
846
847         Extend run-benchmark script to support human-readable results conversion.
848         https://bugs.webkit.org/show_bug.cgi?id=149944
849
850         Reviewed by Ryosuke Niwa.
851
852         Add '--read-results-json' and '--no-adjust-unit' options.
853         '--read-results-json' option converts result file to human readable format.
854         '--no-adjust-unit' option skips scientific notation convertion.
855         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
856
857         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
858         (BenchmarkResults.format):
859         (BenchmarkResults._format_tests):
860         (BenchmarkResults._format_values):
861         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
862         (BenchmarkRunner.__init__):
863         (BenchmarkRunner._run_benchmark):
864         (BenchmarkRunner._dump):
865         (BenchmarkRunner.show_results):
866         (BenchmarkRunner._show_results): Deleted.
867         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
868         (parse_args):
869         (start):
870
871 2015-10-08  Daniel Bates  <dabates@apple.com>
872
873         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
874         https://bugs.webkit.org/show_bug.cgi?id=149945
875
876         Reviewed by Dan Bernstein.
877
878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
882         (WebKitBuildbot):
883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
884         (table.queue-grid tr.platform.ios-9 img.logo):
885
886 2015-10-08  Daniel Bates  <dabates@apple.com>
887
888         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
889         https://bugs.webkit.org/show_bug.cgi?id=149943
890
891         Reviewed by Dan Bernstein.
892
893         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
894         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
895
896         * Scripts/build-webkit:
897
898 2015-10-08  Daniel Bates  <dabates@apple.com>
899
900         Add LLVM binaries for iOS 9 device
901         https://bugs.webkit.org/show_bug.cgi?id=149913
902
903         Reviewed by Filip Pizlo.
904
905         Implement support for building LLVM for ARM64-based iOS devices.
906
907         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
908         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
909         an existing build earlier in the file such that remove previously built
910         libraries before building/copying new ones (if applicable).
911         (fileContains): Moved function outside of if-block.
912         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
913         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
914         added logic to build LLVM for ARM64-based iOS devices.
915         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
916         LLVM into the WebKitBuild directory.
917
918 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
919
920         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
921         https://bugs.webkit.org/show_bug.cgi?id=149848
922
923         Reviewed by Darin Adler.
924
925         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
926
927 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
928
929         [Win] Support 64-bit Build and Testing
930         https://bugs.webkit.org/show_bug.cgi?id=149904
931
932         Reviewed by Daniel Bates.
933
934         Extend our existing scripts to support 64-bit build and test operations on
935         Windows.
936
937         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
938         Windows always builds the whole stack.
939         * Scripts/webkit-build-directory: Add an option to return the location of
940         the executable files produced by a specific configuration. This change is
941         actually useful for Gtk and EFL, too.
942         * Scripts/webkitdirs.pm:
943         (executableProductDir): Added. This function appends the proper binary
944         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
945         (jscProductDir): Use the new 'executableProductDir' method.
946         (setPathForRunningWebKitApp): Ditto.
947         (runSafari): Ditto.
948         (runMiniBrowser): Ditto.
949         * Scripts/webkitpy/port/factory.py:
950         (configuration_options): Add a 64-bit option, used on Windows to specify
951         which binary target should be used for testing.
952         * Scripts/webkitpy/port/win.py:
953         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
954         processes when needed.
955         (WinPort._build_path): Add the correct binary target path to _build_path.
956         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
957         64-bit paths for 64-bit tests.
958         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
959         NTSD debugger does not understand this argument.
960
961 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
962
963         Test font-variant-* and font-feature-settings with TrueType fonts
964         https://bugs.webkit.org/show_bug.cgi?id=149776
965
966         Reviewed by Simon Fraser.
967
968         This test extends our existing FontWithFeatures project to be able to generate a
969         TrueType font. This font is conceptually similar as the existing OpenType font,
970         except the feature -> character mapping is different.
971
972         The font itself only supports the following characters:
973         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
974         However, the shape of these letters are either an X or a check mark.
975         The letter "A" always is a check mark.
976         The letter "B" always is an X.
977         Each font feature has an letter associated with it. When the font feature is enabled,
978         that letter is shown as a check mark. For example, when
979         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
980         mark.
981
982         Here are the mappings of font features to letters:
983         kLigaturesType / kCommonLigaturesOnSelector: C
984         kLigaturesType / kContextualLigaturesOnSelector: D
985         kLigaturesType / kRareLigaturesOnSelector: G
986         kLigaturesType / kHistoricalLigaturesOnSelector: I
987         kContextualAlternatesType / kContextualAlternatesOnSelector: L
988         kVerticalPositionType / kInferiorsSelector: O
989         kVerticalPositionType / kSuperiorsSelector: P
990         kLowerCaseType / kLowerCaseSmallCapsSelector: S
991         kUpperCaseType / kUpperCaseSmallCapsSelector: V
992         kLowerCaseType / kLowerCasePetiteCapsSelector: T
993         kUpperCaseType / kUpperCasePetiteCapsSelector: W
994         kLetterCaseType / 14: Y
995         kStyleOptionsType / kTitlingCapsSelector: a
996         kNumberCaseType / kUpperCaseNumbersSelector: c
997         kNumberCaseType / kLowerCaseNumbersSelector: d
998         kNumberSpacingType / kProportionalNumbersSelector: f
999         kNumberSpacingType / kMonospacedNumbersSelector: g
1000         kFractionsType / kDiagonalFractionsSelector: i
1001         kFractionsType / kVerticalFractionsSelector: j
1002         kVerticalPositionType / kOrdinalsSelector: Q
1003         kTypographicExtrasType / kSlashedZeroOnSelector: k
1004         kLigaturesType / kHistoricalLigaturesOnSelector: K
1005         kCharacterShapeType / kJIS1978CharactersSelector: m
1006         kCharacterShapeType / kJIS1983CharactersSelector: n
1007         kCharacterShapeType / kJIS1990CharactersSelector: o
1008         kCharacterShapeType / kJIS2004CharactersSelector: p
1009         kCharacterShapeType / kSimplifiedCharactersSelector: q
1010         kCharacterShapeType / kTraditionalCharactersSelector: r
1011         kTextSpacingType / kMonospacedTextSelector: t
1012         kTextSpacingType / kProportionalTextSelector: u
1013         kRubyKanaType / kRubyKanaOnSelector: v
1014
1015         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1016         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1017         (CFFBuilder::moveTo):
1018         (CFFBuilder::lineTo):
1019         (GLYFBuilder::GLYFBuilder):
1020         (GLYFBuilder::takeResult):
1021         (GLYFBuilder::moveTo):
1022         (GLYFBuilder::lineTo):
1023         (GLYFBuilder::closePath):
1024         (GLYFBuilder::writePoint):
1025         (GLYFBuilder::append16):
1026         (generateBoxCharString):
1027         (generateCheckCharString):
1028         (generateXCharString):
1029         (itemForGlyph):
1030         (Generator::generate):
1031         (Generator::insertSelector):
1032         (Generator::insertFeature):
1033         (Generator::generateFeatureDescription):
1034         (Generator::appendCFFTable):
1035         (Generator::appendGLYFTable):
1036         (Generator::appendLOCATable):
1037         (Generator::appendFEATTable):
1038         (Generator::appendMetamorphosisChain):
1039         (Generator::appendMORXTable):
1040         (Generator::appendHEADTable):
1041         (Generator::appendHMTXTable):
1042         (Generator::appendNameSubtable):
1043         (Generator::append2ByteASCIIString):
1044         (Generator::appendNAMETable):
1045         (generateFont):
1046         (CFFBuilder::curveToCubic): Deleted.
1047         (charStringForGlyph): Deleted.
1048         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1049         * FontWithFeatures/FontWithFeatures/main.cpp:
1050         (constructFontWithTrueTypeFeature):
1051         (constructFontWithOpenTypeFeature):
1052         (drawText):
1053         (main):
1054         (drawTextWithFeature): Deleted.
1055
1056 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1057
1058         Unreviewed, rolling out r190572, r190593, r190594, and
1059         r190639.
1060         https://bugs.webkit.org/show_bug.cgi?id=149897
1061
1062         Breaks Mavericks build (Requested by litherum on #webkit).
1063
1064         Reverted changesets:
1065
1066         "Allow WKRetainPtrs to be used as keys in hashing data
1067         structures"
1068         https://bugs.webkit.org/show_bug.cgi?id=149762
1069         http://trac.webkit.org/changeset/190572
1070
1071         "REGRESSION(189668?): http/tests/notifications/events.html
1072         flakily asserts or times out"
1073         https://bugs.webkit.org/show_bug.cgi?id=149218
1074         http://trac.webkit.org/changeset/190593
1075
1076         "Prospective Mavericks build fix."
1077         http://trac.webkit.org/changeset/190594
1078
1079         "Post-review cleanup after r190572."
1080         http://trac.webkit.org/changeset/190639
1081
1082 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1083
1084         [GTK] Add autocleanups
1085         https://bugs.webkit.org/show_bug.cgi?id=149588
1086
1087         Reviewed by Darin Adler.
1088
1089         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1090         (AutocleanupsTest::create):
1091         (AutocleanupsTest::testWebProcessAutocleanups):
1092         (registerTests):
1093         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1094         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1095         (testUIProcessAutocleanups):
1096         (testWebProcessAutocleanups):
1097         (beforeAll):
1098         (afterAll):
1099
1100 2015-10-06  Brian Burg  <bburg@apple.com>
1101
1102         Unreviewed, try to fix the iOS 8 build after r190368.
1103
1104         On older versions, IOHIDEventCreateForceEvent is not available.
1105
1106         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1107         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1108
1109 2015-10-06  Keith Miller  <keith_miller@apple.com>
1110
1111         Add gmalloc option to run-javascriptcore-tests.
1112         https://bugs.webkit.org/show_bug.cgi?id=149858
1113
1114         Reviewed by Geoffrey Garen.
1115
1116         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1117         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1118
1119         * Scripts/run-javascriptcore-tests:
1120
1121 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1122
1123         Post-review cleanup after r190572.
1124
1125         Unreviewed.
1126
1127         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1128
1129 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1130
1131         [Win] Unreviewed build correction.
1132
1133         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1134         are soft-linked at runtime.
1135
1136 2015-10-06  Keith Miller  <keith_miller@apple.com>
1137
1138         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1139         https://bugs.webkit.org/show_bug.cgi?id=149815
1140
1141         Reviewed by Filip Pizlo.
1142
1143         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1144         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1145         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1146         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1147         so should just use one test runner.
1148
1149         * Scripts/run-javascriptcore-tests:
1150         (runJSCStressTests):
1151         (runMozillaTests): Deleted.
1152         (defaultJsDriverArgsForMozillaTests): Deleted.
1153         * Scripts/run-jsc-stress-tests:
1154
1155 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1156
1157         [GTK] Make update-webkitgtk-libs work behind firewall
1158
1159         update-webkitgtk-libs can work behind a firewall with changes to
1160         a few packages.  Where outbound git and active FTP connections
1161         fail, using http protocol succeeds.  Most packages are
1162         already accessed using http.
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=148941
1165
1166         Reviewed by Martin Robinson.
1167
1168         Tools
1169         * gtk/jhbuild.modules:
1170             Replace git URLs with http.  Remove no longer used ftp repositories.
1171             Update argument for libxml2's autogen.sh script (--without-python
1172             is ignored; --with-python=no is correct).
1173         * jhbuild/jhbuild-wrapper:
1174             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1175             http://git.gnome.org/browse/jhbuild.
1176
1177 2015-10-06  Daniel Bates  <dbates@webkit.org>
1178
1179         Enable XSLT when building WebKit for iOS using the public iOS SDK
1180         https://bugs.webkit.org/show_bug.cgi?id=149827
1181
1182         Reviewed by Alexey Proskuryakov.
1183
1184         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1185         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1186         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1187         headers cannot be found.
1188
1189         * Scripts/configure-xcode-for-ios-development:
1190         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1191
1192 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1193
1194         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1195         https://bugs.webkit.org/show_bug.cgi?id=149218
1196
1197         Reviewed by Alexey Proskuryakov.
1198
1199         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1200         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1201         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1202         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1203         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1204         WebNotificationProvider must be updated to appropriately handle multiple
1205         WKNotificationManagerRefs in flight at the same time.
1206
1207         * WebKitTestRunner/WebNotificationProvider.cpp:
1208         (WTR::WebNotificationProvider::~WebNotificationProvider):
1209         (WTR::WebNotificationProvider::showWebNotification):
1210         (WTR::WebNotificationProvider::closeWebNotification):
1211         (WTR::WebNotificationProvider::addNotificationManager):
1212         (WTR::WebNotificationProvider::removeNotificationManager):
1213         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1214         (WTR::WebNotificationProvider::reset):
1215         * WebKitTestRunner/WebNotificationProvider.h:
1216
1217 2015-10-05  Daniel Bates  <dabates@apple.com>
1218
1219         Disable Bitcode when building for iOS device
1220         https://bugs.webkit.org/show_bug.cgi?id=149818
1221
1222         Reviewed by Alexey Proskuryakov.
1223
1224         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1225         when building for iOS device.
1226
1227         * Scripts/webkitdirs.pm:
1228         (XcodeOptions):
1229
1230 2015-10-05  Daniel Bates  <dabates@apple.com>
1231
1232         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1233         https://bugs.webkit.org/show_bug.cgi?id=140828
1234         <rdar://problem/19520599>
1235
1236         Reviewed by Alexey Proskuryakov.
1237
1238         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1239         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1240         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1241         to build-webkit.
1242
1243         * Scripts/webkitdirs.pm:
1244         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1245         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1246         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1247         (hasIOSDevelopmentCertificate): Added.
1248
1249 2015-10-05  Daniel Bates  <dabates@apple.com>
1250
1251         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1252         https://bugs.webkit.org/show_bug.cgi?id=149766
1253
1254         Reviewed by Alexey Proskuryakov.
1255
1256         Create network storage testing session on iOS.
1257
1258         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1259         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1260         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1261         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1262         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1263         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1264         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1265         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1266         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1267
1268         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1269         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1270         returns a non-null pointer to a cookie store.
1271
1272         * DumpRenderTree/mac/DumpRenderTree.mm:
1273         (prepareConsistentTestingEnvironment):
1274
1275 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1276
1277         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1278         available.
1279
1280         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1281         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1282
1283 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1284
1285         Allow WKRetainPtrs to be used as keys in hashing data structures
1286         https://bugs.webkit.org/show_bug.cgi?id=149762
1287
1288         Reviewed by Anders Carlsson.
1289
1290         * TestWebKitAPI/PlatformGTK.cmake:
1291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1292         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1293         (TestWebKitAPI::TEST):
1294
1295 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1296
1297         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1298         available, and tidy up the #ifdefs in the UIKitSPI header.
1299
1300         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1301         (-[HIDEventGenerator _sendHIDEvent:]):
1302         * WebKitTestRunner/ios/UIKitSPI.h:
1303
1304 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1305
1306         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1307         https://bugs.webkit.org/show_bug.cgi?id=149792
1308
1309         Reviewed by Martin Robinson.
1310
1311         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1312         for WebKitTestRunner multiple times.
1313
1314 2015-10-04  Daniel Bates  <dabates@apple.com>
1315
1316         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1317         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1318
1319         For now, support calling build-layouttestrelay without --ios-simulator so long
1320         as we are building on a Mac.
1321
1322         * Scripts/build-layouttestrelay:
1323
1324 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1325
1326         Support Trac 1.0.x XML timeline link format
1327         https://bugs.webkit.org/show_bug.cgi?id=149786
1328
1329         Reviewed by Lucas Forschler.
1330
1331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1332         (Trac.prototype._convertCommitInfoElementToObject):
1333
1334 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1335
1336         Fix some errors on bot watcher's dashboard
1337         https://bugs.webkit.org/show_bug.cgi?id=149789
1338
1339         Reviewed by Lucas Forschler.
1340
1341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1342         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1343         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1344
1345 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1346
1347         Bot watcher's dashboard builders should turn yellow when svn fails
1348         https://bugs.webkit.org/show_bug.cgi?id=149791
1349
1350         Reviewed by Lucas Forschler.
1351
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1353         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1354         (BuildbotBuilderQueueView.prototype.update):
1355
1356 2015-10-02  Daniel Bates  <dabates@apple.com>
1357
1358         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1359         https://bugs.webkit.org/show_bug.cgi?id=149769
1360
1361         Reviewed by Alexey Proskuryakov.
1362
1363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1367         (WebKitBuildbot):
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1369         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1370
1371 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1372
1373         REGRESSION(r190370): Speedometer spits out an extra console message
1374         https://bugs.webkit.org/show_bug.cgi?id=149720
1375
1376         Unreviewed. Temporarily ignore the console error message.
1377
1378         * Scripts/webkitpy/performance_tests/perftest.py:
1379         (PerfTest._filter_output):
1380
1381 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1382
1383         Provide "--no-ninja" option to avoid using Ninja
1384         https://bugs.webkit.org/show_bug.cgi?id=149757
1385
1386         Reviewed by Alex Christensen.
1387
1388         Add a new command line argument understood by webkitdirs.pm so
1389         that we can conditionally avoid using Ninja. This is an
1390         'opt-out' argument, so no existing Ninja users should be affected.
1391         
1392         * Scripts/webkitdirs.pm:
1393         (canUseNinja): Check for option and block ninja if present.
1394
1395 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1396
1397         Flakiness dashboard should support OS X El Capitan
1398         https://bugs.webkit.org/show_bug.cgi?id=149648
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1403
1404 2015-10-02  Daniel Bates  <dabates@apple.com>
1405
1406         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1407         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1408
1409         For now, pass --ios-simulator.
1410
1411         * Scripts/webkitpy/port/ios.py:
1412         (IOSSimulatorPort._build_relay):
1413
1414 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1415
1416         Remove a "nullable" that breaks the iOS 8 build.
1417
1418         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1419         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1420
1421 2015-10-02  Daniel Bates  <dabates@apple.com>
1422
1423         LayoutTestRelay is not built and archived when building for iOS Simulator
1424         https://bugs.webkit.org/show_bug.cgi?id=149753
1425
1426         Reviewed by Alexey Proskuryakov and Andy Estes.
1427
1428         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1429         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1430         product archive when building for iOS Simulator, respectively.
1431
1432         * BuildSlaveSupport/built-product-archive:
1433         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1434         differentiate between iOS device and iOS Simulator platforms.
1435         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1436         from determineWebKitBuildDirectories() into this function so that it can be used by both
1437         determineWebKitBuildDirectories() and archiveBuiltProduct().
1438         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1439         webkitBuildDirectoryForConfigurationAndPlatform().
1440         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1441         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1442         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1443         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1444         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1445         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1446         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1447         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1448         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1449         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1450         * Scripts/build-layouttestrelay:
1451             - Remove unnecessary include of Perl module POSIX.
1452             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1453         * Scripts/build-webkit:
1454             - Invoke script build-layouttestrelay when building for iOS Simulator.
1455
1456 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1457
1458         [Win] Unreviewed test fix.
1459
1460         You cannot run 'run-webkit-tests' from the command line because it does not know
1461         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1462         because they explicitly set use the 'root' argument to provide the full path to
1463         the test binaries.
1464
1465         * Scripts/webkitpy/port/win.py:
1466         (WinPort._build_path): Added.
1467
1468 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1469
1470         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1471         https://bugs.webkit.org/show_bug.cgi?id=149430
1472         rdar://problem/22742222
1473
1474         Reviewed by Geoffrey Garen.
1475
1476         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1477         (WTR::TestController::cocoaResetStateToConsistentValues):
1478         * WebKitTestRunner/mac/TestControllerMac.mm:
1479         (WTR::TestController::platformConfigureViewForTest):
1480         Test what happens when you disable content blockers from the SPI.
1481
1482 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1483
1484         [Win] Unreviewed build fix for run-api-tests
1485
1486         * Scripts/run-api-tests:
1487         (testToolPaths): Windows run needs to specify the binary path.
1488
1489 2015-10-01  Daniel Bates  <dabates@apple.com>
1490
1491         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1492         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1493
1494         Following r190424 we can now rely on webkit-build-directory to return the path to
1495         the correct configuration-specific build directory on Windows.
1496
1497         * BuildSlaveSupport/built-product-archive:
1498         (archiveBuiltProduct):
1499
1500 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1501
1502         [Win] Unreviewed build fix.
1503
1504         * Scripts/webkitdirs.pm:
1505         (setupAppleWinEnv): Use 64-bit build tools if available
1506
1507 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1508
1509         [Win] Fix TestWebKitAPI build under CMake.
1510
1511         Reviewed by Alex Christensen.
1512
1513         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1514         for Psapi.lib.
1515
1516 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1517
1518         [Win] Fix behavior of webkit-build-directory script
1519         https://bugs.webkit.org/show_bug.cgi?id=149718
1520
1521         Reviewed by Alex Christensen.
1522
1523         * Scripts/webkitdirs.pm:
1524         (determineConfigurationProductDir): Do not include the binary
1525         sub-directory in the configuration product directory output.
1526         (jscProductDir): Append correct binary path for Windows build.
1527         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1528         (runSafari): Update for revised productDir behavior.
1529         (runMiniBrowser): Ditto.
1530
1531 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1532
1533         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1534         use iOS SDK, like with all the others.
1535
1536         * Scripts/build-webkit:
1537
1538 2015-10-01  Daniel Bates  <dabates@apple.com>
1539
1540         Attempt to fix the iOS 9 Simulator testers
1541
1542         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1543         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1544         LayoutTestRelay when building for iOS Simulator.
1545
1546         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1547         * Scripts/build-webkit:
1548
1549 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1550
1551         [GTK] Websites with invalid auth header keep loading forever
1552         https://bugs.webkit.org/show_bug.cgi?id=149710
1553
1554         Reviewed by Martin Robinson.
1555
1556         Add test case to check that we can authenticate sites with an
1557         empty realm.
1558
1559         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1560         (testWebViewAuthenticationEmptyRealm):
1561         (serverCallback):
1562         (beforeAll):
1563
1564 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1565
1566         [Mac] Make run-api-tests work with System Integrity Protection
1567         https://bugs.webkit.org/show_bug.cgi?id=149711
1568         rdar://problem/22928202
1569
1570         Reviewed by Dan Bernstein.
1571
1572         * Scripts/run-api-tests:
1573         (runTest):
1574         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1575
1576 2015-10-01  Daniel Bates  <dabates@apple.com>
1577
1578         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1579         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1580
1581         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1582         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1583         specific build directory.
1584
1585         * BuildSlaveSupport/built-product-archive:
1586         (archiveBuiltProduct):
1587
1588 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1589
1590         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1591         https://bugs.webkit.org/show_bug.cgi?id=145837
1592
1593         Reviewed by Philippe Normand.
1594
1595         * efl/jhbuild.modules:
1596         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1597         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1598
1599 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1600
1601         Unreviewed. Fix the iOS build after r190407.
1602
1603         * WebKitTestRunner/ios/IOKitSPI.h:
1604
1605 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1606
1607         Implement keyboard event sending for iOS in WebKitTestRunner
1608         https://bugs.webkit.org/show_bug.cgi?id=149676
1609
1610         Reviewed by Simon Fraser.
1611
1612         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1613         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1614         allows us to run code when the keyboard is shown or hidden.
1615
1616         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1617         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1618         (WTR::UIScriptController::setDidShowKeyboardCallback):
1619         (WTR::UIScriptController::didShowKeyboardCallback):
1620         (WTR::UIScriptController::setDidHideKeyboardCallback):
1621         (WTR::UIScriptController::didHideKeyboardCallback):
1622         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1623         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1624         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1625         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1626         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1627         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1628         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1629                 the notifications that the keyboard has been raised or lowered.
1630         (-[TestRunnerWKWebView _keyboardDidShow:]):
1631         (-[TestRunnerWKWebView _keyboardDidHide:]):
1632         * WebKitTestRunner/ios/HIDEventGenerator.h:
1633         * WebKitTestRunner/ios/HIDEventGenerator.m:
1634         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1635         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1636         (hidUsageCodeForCharacter): Ditto.
1637         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1638                 a keyDown event in WebKit.
1639         * WebKitTestRunner/ios/IOKitSPI.h:
1640         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1641
1642 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1643
1644         Unreviewed, rolling out r190399.
1645
1646         Tests are still failing even after r190362
1647
1648         Reverted changeset:
1649
1650         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1651         http://trac.webkit.org/changeset/190399
1652
1653 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1654
1655         [jhbuild] switch to new upstream usrsctp library
1656         https://bugs.webkit.org/show_bug.cgi?id=149494
1657
1658         Reviewed by Philippe Normand.
1659
1660         * efl/jhbuild.modules:
1661         * gtk/jhbuild.modules:
1662
1663 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1664
1665         Unreviewed. Unskip GTK+ user media unit tests after r190362.
1666
1667         They should pass now.
1668
1669         * Scripts/run-gtk-tests:
1670         (TestRunner):
1671
1672 2015-09-30  Daniel Bates  <dabates@apple.com>
1673
1674         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1675         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1676
1677         * BuildSlaveSupport/built-product-archive:
1678         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1679         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1680
1681 2015-09-30  Daniel Bates  <dabates@apple.com>
1682
1683         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1684         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1685
1686         Actually, we need to pass --configuration to script webkit-build-directory to have
1687         it return the path to the configuration-specific build directory.
1688
1689         * BuildSlaveSupport/built-product-archive:
1690         (determineWebKitBuildDirectories):
1691
1692 2015-09-30  Daniel Bates  <dabates@apple.com>
1693
1694         built-product-archive archives incorrect build directory for iOS port
1695         https://bugs.webkit.org/show_bug.cgi?id=149695
1696
1697         Reviewed by Darin Adler.
1698
1699         Fixes an issue where the script built-product-archive archives a non-existent
1700         build directory for the iOS port. Without loss of generality, the script assumes
1701         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1702         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1703
1704         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1705         to determine the top-level build directory and computes the configuration-specific
1706         build directory to be the concatenation of the the top-level build directory and
1707         the configuration (e.g. Release). This is incorrect. Instead we should call
1708         webkit-build-directory omitting the flag --top-level to compute the path to the
1709         configuration-specific build directory.
1710
1711         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1712         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1713         its purpose and added global variable _configurationBuildDirectory to store the path
1714         to the configuration-specific build directory. Ensure that we have a non-empty string
1715         for both the top-level and configuration-specific build directories.
1716         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1717         Compute the configuration-specific build directory and store it in the global variable
1718         _configurationBuildDirectory.
1719         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1720         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1721         as needed.
1722         (determineWebKitBuildDirectory): Deleted.
1723
1724 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
1725
1726         [EFL] css3/device-adapt/* tests failed after r190335.
1727         https://bugs.webkit.org/show_bug.cgi?id=149655
1728
1729         Reviewed by Simon Fraser.
1730
1731         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1732         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1733
1734         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1735         (WTR::shouldUseFixedLayout):
1736
1737 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
1738
1739         Extend JetStream timeout for slow devices.
1740
1741         Reviewed by Chris Dumez.
1742
1743         Extend JetStream timeout to 20 minutes.
1744
1745         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1746
1747 2015-09-30  Daniel Bates  <dabates@apple.com>
1748
1749         Rename iOS builders/testers to include version
1750         https://bugs.webkit.org/show_bug.cgi?id=149685
1751
1752         Reviewed by Simon Fraser.
1753
1754         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1755         make it clear to a reader the version of iOS these builders/testers are using.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/config.json:
1758         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1759
1760 2015-09-30  Daniel Bates  <dabates@apple.com>
1761
1762         Add iOS criterion for triggering a build
1763         https://bugs.webkit.org/show_bug.cgi?id=149679
1764
1765         Rubber-stamped by Alexey Proskuryakov.
1766
1767         First pass at defining criterion for triggering an iOS build.
1768
1769         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1770         (_should_file_trigger_build):
1771         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1772         (ShouldBuildTest):
1773         (ShouldBuildTest.test_should_build):
1774
1775 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1776
1777         [iOS] Allow tests to generate user gestures for UI testing
1778         https://bugs.webkit.org/show_bug.cgi?id=149653
1779
1780         Reviewed by Tim Horton.
1781
1782         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1783         and to listen for completion of scrolling and zooming in the WKWebView.
1784         
1785         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1786         which hides the complexity of creating these events. Event dispatch is asynchronous.
1787         We detect when the last event has been handled by dispatching a vendor-specific event,
1788         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1789         
1790         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1791         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1792         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1793         single and double taps.
1794         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1795         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1796         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1797         (UIScriptContext::unregisterCallback):
1798         (UIScriptContext::callbackWithID):
1799         (UIScriptContext::fireCallback):
1800         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1801         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1802         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1803         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1804         (WTR::UIScriptController::setDidEndZoomingCallback):
1805         (WTR::UIScriptController::didEndZoomingCallback):
1806         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1807         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1808         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1809         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1810         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1811         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1812         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1813         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1814         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1815         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1816         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1817         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1818         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1819         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1820         (simpleDragCurve):
1821         (calculateNextLocation):
1822         (delayBetweenMove):
1823         (+[HIDEventGenerator sharedHIDEventGenerator]):
1824         (+[HIDEventGenerator nextEventCallbackID]):
1825         (-[HIDEventGenerator init]):
1826         (-[HIDEventGenerator _createIOHIDEventType:]):
1827         (-[HIDEventGenerator _sendHIDEvent:]):
1828         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1829         (-[HIDEventGenerator _updateTouchPoints:count:]):
1830         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1831         (-[HIDEventGenerator touchDown:touchCount:]):
1832         (-[HIDEventGenerator touchDown:]):
1833         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1834         (-[HIDEventGenerator liftUp:touchCount:]):
1835         (-[HIDEventGenerator liftUp:]):
1836         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1837         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1838         (-[HIDEventGenerator tap:completionBlock:]):
1839         (-[HIDEventGenerator doubleTap:completionBlock:]):
1840         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1841         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1842         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1843         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1844         (-[HIDEventGenerator markerEventReceived:]):
1845         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1846         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1847         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1848         (WTR::globalToContentCoordinates):
1849         (WTR::UIScriptController::singleTapAtPoint):
1850         (WTR::UIScriptController::doubleTapAtPoint):
1851         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1852         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1853         * WebKitTestRunner/ios/mainIOS.mm:
1854         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1855
1856 2015-09-30  Dana Burkart  <dburkart@apple.com>
1857
1858         git-add-reviewer should trim trailing spaces/newlines
1859         https://bugs.webkit.org/show_bug.cgi?id=149513
1860
1861         Reviewed by Darin Adler.
1862
1863         * Scripts/git-add-reviewer:
1864         (nonInteractive):
1865
1866 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1867
1868         REGRESSION(r190262): User media unit test failures after r190262
1869         https://bugs.webkit.org/show_bug.cgi?id=149580
1870
1871         Reviewed by Darin Adler.
1872
1873         * WebKitTestRunner/TestController.cpp:
1874         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1875           order to WKUserMediaPermissionRequestAllow.
1876
1877 2015-09-30  Daniel Bates  <dabates@apple.com>
1878
1879         Add iOS builders and testers
1880         https://bugs.webkit.org/show_bug.cgi?id=149549
1881
1882         Reviewed by Alexey Proskuryakov.
1883
1884         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1885         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1888         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1889
1890 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1891
1892         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1893         https://bugs.webkit.org/show_bug.cgi?id=149674
1894
1895         Reviewed by Lucas Forschler.
1896
1897         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1898         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1899
1900 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1901
1902         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1903         have an associated trac instance.
1904         https://bugs.webkit.org/show_bug.cgi?id=149673
1905
1906         Reviewed by Alexey Proskuryakov.
1907
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1909         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1910         have an associated trac instance.
1911
1912 2015-09-30  Daniel Bates  <dabates@apple.com>
1913
1914         Prioritize testing latest build request on iOS test bots
1915         https://bugs.webkit.org/show_bug.cgi?id=149669
1916
1917         Reviewed by Darin Adler.
1918
1919         We should prioritize testing of the latest build request on the iOS test bots
1920         as we do for Mac and Windows test bots.
1921
1922         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1923         (loadBuilderConfig):
1924
1925 2015-09-30  Daniel Bates  <dabates@apple.com>
1926
1927         Add buildbot category for iOS builders and testers
1928         https://bugs.webkit.org/show_bug.cgi?id=149667
1929
1930         Reviewed by Darin Adler.
1931
1932         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1933         for iOS to the build.webkit.org home page.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1936         (loadBuilderConfig):
1937         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1938
1939 2015-09-30  Daniel Bates  <dabates@apple.com>
1940
1941         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1942         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1943
1944         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1945         in <http://trac.webkit.org/changeset/190351>.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1948         (CompileWebKit.start):
1949
1950 2015-09-30  Daniel Bates  <dabates@apple.com>
1951
1952         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1953         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1954
1955         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1956         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1959         (CompileWebKit.start):
1960
1961 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1962
1963         bot210 was configured for a queue instead of bot126.
1964         
1965         Unreviewed config.json fix.
1966         
1967         * BuildSlaveSupport/build.webkit.org-config/config.json:
1968
1969 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1970
1971         Bring El Capitan buildbot infrastructure online.
1972         https://bugs.webkit.org/show_bug.cgi?id=149605
1973         
1974         Reviewed by Darin Adler.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/config.json:
1977
1978 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1979
1980         [GTK] Deprecation warnings in DOMNodeTest
1981         https://bugs.webkit.org/show_bug.cgi?id=149663
1982
1983         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1984         need to update the tests to use webkit_dom_document_query_selector_all
1985         to avoid compilation warnings.
1986
1987         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1988         (the suggested replacement for the deprecated function).
1989
1990         Reviewed by Carlos Garcia Campos.
1991
1992         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1993         (WebKitDOMNodeTest::testTagNamesNodeList):
1994         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1995         (registerTests):
1996         (WebKitDOMNodeTest::testTagNames): Deleted.
1997         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1998         (prepareDOMForTagNamesTests):
1999         (testWebKitDOMNodeTagNamesNodeList):
2000         (testWebKitDOMNodeTagNamesHTMLCollection):
2001         (beforeAll):
2002         (testWebKitDOMNodeTagNames): Deleted.
2003
2004 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2005
2006         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2007         https://bugs.webkit.org/show_bug.cgi?id=149650
2008
2009         Reviewed by Tim Horton.
2010         
2011         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2012         looks at the file path, and not the custom options that come from file comments.
2013         
2014         Fix by computing TestOptions before making the TestInvocation, and setting them
2015         as const TestInvocation data. This meant changing various call sites to take
2016         the std::string pathOrURL, rather than the TestInvocation itself.
2017         
2018         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2019
2020         * WebKitTestRunner/CMakeLists.txt:
2021         * WebKitTestRunner/TestController.cpp:
2022         (WTR::TestController::ensureViewSupportsOptionsForTest):
2023         (WTR::testPath):
2024         (WTR::createTestURL):
2025         (WTR::updateTestOptionsFromTestHeader):
2026         (WTR::TestController::testOptionsForTest):
2027         (WTR::TestController::updateWebViewSizeForTest):
2028         (WTR::TestController::updateWindowScaleForTest):
2029         (WTR::TestController::runTest):
2030         * WebKitTestRunner/TestController.h:
2031         * WebKitTestRunner/TestInvocation.cpp:
2032         (WTR::TestInvocation::TestInvocation):
2033         (WTR::TestInvocation::invoke):
2034         (WTR::createWKURL): Deleted.
2035         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2036         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2037         * WebKitTestRunner/TestInvocation.h:
2038         (WTR::TestInvocation::options):
2039         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2040         (WTR::pathContains):
2041         (WTR::shouldMakeViewportFlexible):
2042         (WTR::shouldUseFixedLayout):
2043         (WTR::isSVGTestPath):
2044         (WTR::isHiDPITestPath):
2045         (WTR::TestOptions::TestOptions):
2046         * WebKitTestRunner/TestOptions.h:
2047         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2048         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2049         (WTR::pathContains):
2050         (WTR::shouldUseFixedLayout):
2051         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2052         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2053         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2054         * WebKitTestRunner/ios/TestControllerIOS.mm:
2055         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2056         * WebKitTestRunner/mac/TestControllerMac.mm:
2057         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2058
2059 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2060
2061         Flakiness dashboard should support OS X El Capitan
2062         https://bugs.webkit.org/show_bug.cgi?id=149648
2063
2064         Reviewed by Alexey Proskuryakov.
2065
2066         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2067         difference between new appscale and old Google App Engine implementation.
2068         * TestResultServer/app.yaml: Same.
2069         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2070
2071 2015-09-29  Daniel Bates  <dabates@apple.com>
2072
2073         configure-xcode-for-ios-development does not work with Xcode 7
2074         https://bugs.webkit.org/show_bug.cgi?id=149640
2075
2076         Reviewed by Alexey Proskuryakov.
2077
2078         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2079         because it cannot find the Xcode specification files for iOS simulator and device. These
2080         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2081         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2082         new specification files with the added definitions (as we did in older versions of Xcode)
2083         in order for Xcode 7 to honor these definitions.
2084
2085         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2086         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2087         (updateXcode7SpecificationFile): Added.
2088         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2089         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2090         appropriate success message.
2091         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2092         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2093         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2094
2095 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2096
2097         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2098         https://bugs.webkit.org/show_bug.cgi?id=149639
2099
2100         Reviewed by Alex Christensen.
2101
2102         * Scripts/VCSUtils.pm:
2103         (exitStatus): Use 'isWindows()' method.
2104         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2105         an error. This method could probably just go away.
2106         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2107         always changing to Unix style. 
2108         (unixPath): Added. Needed so Windows can always show a Unix path in the
2109         ChangeLog file.
2110         (changeLogName): Work around the fact that 'getpwuid' is not available on
2111         a pure Windows build of Perl.
2112         * Scripts/prepare-ChangeLog:
2113         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2114         path on Windows.
2115         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2116         support using arrays for 'open' arguments.
2117         (resolveChangeLogsPath): Ditto.
2118         (resolveConflictedChangeLogs): Use new helper functions.
2119         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2120         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2121         quotes. Unix systems are happy either way.
2122         (statusCommand): Ditto.
2123         * Scripts/webkitdirs.pm:
2124         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2125
2126 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2127
2128         [Win] Unreviewed 64-bit build fix after switch to CMake.
2129
2130         * Scripts/webkitdirs.pm:
2131         (determineIsWin64FromArchitecture): Added.
2132
2133 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2134
2135         printing does not use minimum page zoom factor
2136         https://bugs.webkit.org/show_bug.cgi?id=108507
2137
2138         Reviewed by Darin Adler.
2139
2140         WebKitTestRunner always takes the snapshots from the UI process
2141         (expect for IOS), so in the case of printing, the layout in the
2142         web view is not the expected one. When printing, we need to take
2143         the snapshot in the web process and ensure it's rendered with a
2144         PrintContext.
2145
2146         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2147         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2148         kWKSnapshotOptionsPrinting option to
2149         WKBundlePageCreateSnapshotWithOptions() when printing.
2150
2151 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2152
2153         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2154         https://bugs.webkit.org/show_bug.cgi?id=149595
2155
2156         Reviewed by Tim Horton.
2157
2158         All ports except IOS implement
2159         PlatformWebView::windowSnapshotImage() to generate the snapshot
2160         for the pixel tests in the UI process. But we are still generating
2161         a snapshot for pixel tests in the Web process too, that is passed
2162         to the UI process but ignored.
2163         Whether a pixel result is needed or not, is only known by the web
2164         process depending on whether the test called dumpAsText with
2165         dumpPixels == true or not. Since the pixels are now dump in the UI
2166         process, we need to pass that information to the UI process when
2167         the test is done. For that we set a PixelResultIsPending bool
2168         parameter to the Done message, and we only add the PixelResult
2169         when UI process doesn't need to generate the pixels dump.
2170
2171         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2172         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2173         m_pixelResultIsPending to false on reset.
2174         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2175         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2176         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2177         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2178         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2180         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2181         port.
2182         * WebKitTestRunner/TestInvocation.cpp:
2183         (WTR::TestInvocation::dumpResults): Use either the pixel result
2184         from the web process or generate a pixel result from the web view
2185         if need it.
2186         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2187         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2188         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2189         is created by the caller now, but the CG implementation needs to
2190         know if it's a Web or UI process snapshot.
2191         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2192         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2193         cairo surface for the given image.
2194         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2195         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2196         CGContext for the given image.
2197
2198 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2199
2200         Fix JS errors on dashboard metrics page
2201         https://bugs.webkit.org/show_bug.cgi?id=149608
2202
2203         Reviewed by Alexey Proskuryakov.
2204
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2206         (initPlatformsByFamily): 
2207         (updateHiddenPlatforms):
2208         (parsePlatformFamily): Deleted.
2209         (updateToggleButtons): Deleted.
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2211         (updateHiddenPlatforms): Added to remove errors.
2212         (initPlatformsByFamily): Added to remove errors.
2213         (unhiddenQueues): Updated to use Settings.
2214         (documentReady): Added logic to add toggle buttons to the settings menu.
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2216         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2217         MetricsMain.js to Settings.
2218         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2219         MetricsMain.js to Settings.
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2221         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2222
2223 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2224
2225         Appscale query fails because of missing index
2226         https://bugs.webkit.org/show_bug.cgi?id=149609
2227
2228         Reviewed by Darin Adler.
2229
2230         * QueueStatusServer/index.yaml: Added the required index.
2231
2232 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2233
2234         [Win] Fix the 64-bit build after switch to cmake.
2235
2236         Reviewed by Alex Christensen.
2237
2238         * Scripts/webkitdirs.pm:
2239         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2240         run a 64-bit build.
2241
2242 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2243
2244         [Win] Allow Windows to run test-webkitpy without Cygwin
2245         https://bugs.webkit.org/show_bug.cgi?id=149602
2246
2247         Reviewed by Alex Christensen.
2248
2249         These changes mostly shift from hard-coded paths using UNIX-style
2250         separators to Python's "os.path.join" syntax that uses the correct
2251         path separator for each platform.
2252         
2253         * Scripts/webkitpy/common/system/path.py:
2254         (cygpath): Don't pass paths through Cygpath on native Windows.
2255         * Scripts/webkitpy/port/win.py:
2256         (WinPort._path_to_apache): Use os.path.join.
2257         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2258         in 64-bit environments).
2259         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2260         * Scripts/webkitpy/style/checker_unittest.py:
2261         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2262         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2263         (GlobalVariablesTest): Ditto.
2264         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2265         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2266         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2267         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2268         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2269         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2270         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2271         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2272         (StyleProcessor_CodeCoverageTest): Ditto.
2273         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2274         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2275         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2276         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2277         manual string concatenation of paths.
2278
2279 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2280
2281         Add bugzilla addresses of committers to contributors.json
2282         https://bugs.webkit.org/show_bug.cgi?id=149520
2283
2284         Reviewed by Darin Adler.
2285
2286         * Scripts/webkitpy/common/config/contributors.json:
2287
2288 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2289
2290         validate-committer-lists -b shouldn't need edituser privileges
2291         https://bugs.webkit.org/show_bug.cgi?id=149519
2292
2293         Reviewed by Darin Adler.
2294
2295         * Scripts/validate-committer-lists:
2296         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2297         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2298         (BugzillaQueries.is_invalid_bugzilla_email):
2299         (BugzillaQueries): Deleted.
2300         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2301
2302 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2303
2304         Unreviewed. Gardening: skip media stream tests failing after r190262.
2305
2306         * Scripts/run-gtk-tests:
2307         (TestRunner):
2308
2309 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2310
2311         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2312         https://bugs.webkit.org/show_bug.cgi?id=149571
2313
2314         Reviewed by Dan Bernstein.
2315
2316         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2317
2318         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2319         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2320         * LayoutTestRelay/Configurations/Base.xcconfig:
2321         * MiniBrowser/Configurations/Base.xcconfig:
2322         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2323         * TestWebKitAPI/Configurations/Base.xcconfig:
2324         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2325         * WebEditingTester/Configurations/Base.xcconfig:
2326         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2327         * WebKitTestRunner/Configurations/Base.xcconfig:
2328         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2329         * WebKitTestRunner/iOS.xcconfig: Removed.
2330
2331 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2332
2333         Clean up user media request internal API
2334         https://bugs.webkit.org/show_bug.cgi?id=149527
2335
2336         Reviewed by Tim Horton.
2337
2338         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2339         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2340
2341         * WebKitTestRunner/TestController.cpp:
2342         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2343
2344 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2345
2346         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2347         https://bugs.webkit.org/show_bug.cgi?id=149577
2348
2349         Reviewed by Tim Horton.
2350         
2351         When calling testRunner.runUIScript() from a page load event, the script could run
2352         in the UI process before the current remote layer tree transaction had been handled
2353         there. This meant that runUIScript() could query state which was about to change.
2354         
2355         Fix by delaying the execution of the UI script until a layer tree transaction has
2356         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2357
2358         * WebKitTestRunner/TestInvocation.cpp:
2359         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2360         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2361         * WebKitTestRunner/TestInvocation.h:
2362
2363 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2364
2365         [Mac] Media tests start to time out after a few days of bot uptime
2366         https://bugs.webkit.org/show_bug.cgi?id=149468
2367
2368         Reviewed by Darin Adler.
2369
2370         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2371         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2372         all temporary and cache files go to a custom location.
2373
2374         * Scripts/webkitpy/port/base.py:
2375         * Scripts/webkitpy/port/driver.py:
2376         * Scripts/webkitpy/port/mac.py:
2377         * Scripts/webkitpy/port/win.py:
2378         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2379
2380 2015-09-25  Dan Bernstein  <mitz@apple.com>
2381
2382         Removed MiniBrowser.entitlements.
2383
2384         Rubber-stamped by Anders Carlsson.
2385
2386         The entitlements weren’t used anyway.
2387
2388         * MiniBrowser/MiniBrowser.entitlements: Removed.
2389         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2390
2391 2015-09-24  Daniel Bates  <dabates@apple.com>
2392
2393         Add WebKitSystemInterface for iOS 9.0
2394         https://bugs.webkit.org/show_bug.cgi?id=149550
2395
2396         Rubber-stamped by Alexey Proskuryakov.
2397
2398         * Scripts/copy-webkitlibraries-to-product-directory:
2399
2400 2015-09-24  Daniel Bates  <dabates@apple.com>
2401
2402         Support building for arbitrary architectures
2403         https://bugs.webkit.org/show_bug.cgi?id=149539
2404
2405         Reviewed by Alexey Proskuryakov.
2406
2407         Teach buildbot to pass the architectures associated with the builder to build-webkit
2408         when building on OS X and iOS. As a side effect of this change we now support building
2409         universal binaries when multiples architectures are specified.
2410
2411         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2412         (CompileWebKit.start):
2413
2414 2015-09-24  Daniel Bates  <dabates@apple.com>
2415
2416         Fix the build after <http://trac.webkit.org/changeset/190212>
2417         (http://trac.webkit.org/changeset/190212)
2418
2419         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2420
2421         * BuildSlaveSupport/built-product-archive:
2422         (main):
2423
2424 2015-09-24  Daniel Bates  <dabates@apple.com>
2425
2426         Support running unit tests on iOS Simulator test bot
2427         https://bugs.webkit.org/show_bug.cgi?id=149536
2428
2429         Reviewed by Alexey Proskuryakov.
2430
2431         Implements support for running unit tests on a iOS test bot. At the time of writing,
2432         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2435         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2436         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2437
2438 2015-09-24  Daniel Bates  <dabates@apple.com>
2439
2440         Add support infrastructure for OpenSource iOS builders and testers
2441         https://bugs.webkit.org/show_bug.cgi?id=149534
2442
2443         Reviewed by Darin Adler.
2444
2445         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2446         scripts about iOS.
2447
2448         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2449         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2450         --ios-simulator or --device for a builder/tester whose full platform name begins with
2451         "ios-simulator" or "ios", respectively.
2452         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2453         * BuildSlaveSupport/built-product-archive:
2454         (main): Pass the full platform name to determineWebKitBuildDirectory().
2455         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2456         command line flag when building for iOS.
2457         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2458         parameter fullPlatform. This parameter was originally added in r125066 to support the
2459         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2460         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2461         * BuildSlaveSupport/clean-build:
2462         (main): Call script webkit-build-directory with the appropriate command line flag when
2463         building for iOS.
2464         * BuildSlaveSupport/delete-stale-build-files:
2465         (main): Use the same logic for iOS as we do for Mac.
2466         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2467         flag when building for iOS.
2468         * BuildSlaveSupport/test-result-archive:
2469         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2470
2471 2015-09-24  Daniel Bates  <dabates@apple.com>
2472
2473         Remove Chromium-specific changes to script built-product-archive
2474         https://bugs.webkit.org/show_bug.cgi?id=149530
2475
2476         Rubber-stamped by Csaba Osztrogonác.
2477
2478         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2479         Chromium code has long since been removed from the OpenSource WebKit Project.
2480
2481         * BuildSlaveSupport/built-product-archive:
2482         (createZipManually):
2483         (createZip):
2484         (archiveBuiltProduct):
2485
2486 2015-09-24  Dan Bernstein  <mitz@apple.com>
2487
2488         Build fix.
2489
2490         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2491
2492 2015-09-24  Mark Lam  <mark.lam@apple.com>
2493
2494         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2495
2496         * Scripts/webkitpy/common/config/contributors.json:
2497
2498 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2499
2500         Unreviewed. Fix GObject DOM API breaks after r190120.
2501
2502         Bring back code removed in r169931 to handle documentation of
2503         deleted classes.
2504
2505         * gtk/webkitdom.py:
2506         (WebKitDOMDocGenerator):
2507         (WebKitDOMDocGenerator.write_deleted_classes):
2508         (WebKitDOMDocGenerator.generate):
2509         (write_deleted_classes):
2510         (WebKitDOMDocGeneratorSections._deleted_class):
2511         (WebKitDOMDocGeneratorSections._deleted_class.in):
2512         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2513         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2514
2515 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2516
2517         [Cocoa] [Font Features] Implement font-variant-*
2518         https://bugs.webkit.org/show_bug.cgi?id=148413
2519
2520         Reviewed by Darin Adler.
2521
2522         Update test font to use "lnum" feature.
2523
2524         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2525         (Generator::appendGSUBTable):
2526
2527 2015-09-22  Andy Estes  <aestes@apple.com>
2528
2529         ContentFiltering.AllowDownloadAfterAddData is very flaky
2530         https://bugs.webkit.org/show_bug.cgi?id=148885
2531         <rdar://problem/22729563>
2532
2533         Reviewed by Alexey Proskuryakov.
2534
2535         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2536         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2537         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2538
2539         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2540         (downloadTest):
2541
2542 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2543
2544         Mavericks: Media tests start to time out after a few days of bot uptime
2545         https://bugs.webkit.org/show_bug.cgi?id=149468
2546
2547         Reviewed by Chris Dumez.
2548
2549         * Scripts/webkitpy/port/base.py:
2550         * Scripts/webkitpy/port/driver.py:
2551         * Scripts/webkitpy/port/mac.py:
2552
2553 2015-09-22  Nan Wang  <n_wang@apple.com>
2554
2555         Unreviewed, add myself to the committers list.
2556
2557         * Scripts/webkitpy/common/config/contributors.json:
2558
2559 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2560
2561         Remove 'nullable' to fix older iOS builds.
2562
2563         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2564         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2565
2566 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2567
2568         [Win] Show tiled drawing debug overlay on Windows
2569         https://bugs.webkit.org/show_bug.cgi?id=149426
2570
2571         Reviewed by Dean Jackson.
2572
2573         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2574         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2575         * MiniBrowser/win/Common.cpp:
2576         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2577         flag if needed.
2578         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2579
2580 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2581
2582         [Win] Use command-line argument to launch in regular or High DPI mode.
2583         https://bugs.webkit.org/show_bug.cgi?id=149417
2584
2585         Reviewed by Dean Jackson.
2586
2587         * MiniBrowser/win/Common.cpp:
2588         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2589         very start of execution, before the MiniBrowser.dll is loaded.
2590         * win/DLLLauncher/DLLLauncherMain.cpp:
2591         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2592         present. On WinCairo, always use High DPI.
2593
2594 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2595
2596         32-bit Mac build fix attempt after r190065.
2597
2598         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2599
2600 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2601
2602         [OS X] Update for Xcode 7.0 on Yosemite
2603         https://bugs.webkit.org/show_bug.cgi?id=149389
2604
2605         Reviewed by Dan Bernstein.
2606
2607         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2608         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2609         Removed unneeded declarations - conforming to a protocol is sufficient.
2610
2611         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2612         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2613         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2614         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2615
2616 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2617
2618         Add the ability for tests to run script in the UI process in WebKitTestRunner
2619         https://bugs.webkit.org/show_bug.cgi?id=149356
2620
2621         Reviewed by Tim Horton.
2622
2623         This change adds testRunner.runUIScript(script, callback), which allows a test
2624         to execute script in a JSContext which runs in the UI process. That context
2625         has bindings exposed through the UIScriptController interface; currently one test
2626         function, and some iOS-specific functions are included. UIScriptController can be
2627         async with a callback, and runUIScript() itself is asynchronous. When the UI 
2628         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2629         is a string passed back to the web process, and given to the runUIScript()
2630         callback function.
2631         
2632         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2633
2634         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2635         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2637         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2638         complete, call back into TestRunner.
2639         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2640         (WTR::nextUIScriptCallbackID):
2641         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2642         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2644         * WebKitTestRunner/PlatformWebView.h:
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::updateTestOptionsFromTestHeader):
2647         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2648         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2649         * WebKitTestRunner/TestInvocation.cpp:
2650         (WTR::TestInvocation::shouldUseFixedLayout):
2651         (WTR::TestInvocation::shouldUseThreadedScrolling):
2652         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2653         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2654         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2655         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2656         * WebKitTestRunner/TestInvocation.h:
2657         * WebKitTestRunner/TestOptions.h:
2658         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2659         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2661         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2662         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2663         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2664         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2665         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2666         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2667         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2668         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2669         (WTR::UIScriptController::doAsyncTask):
2670         (WTR::UIScriptController::zoomToScale):
2671         (WTR::UIScriptController::zoomScale):
2672         (WTR::UIScriptController::minimumZoomScale):
2673         (WTR::UIScriptController::maximumZoomScale):
2674         (WTR::UIScriptController::contentVisibleRect):
2675         * WebKitTestRunner/mac/EventSenderProxy.mm:
2676         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2677         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2678         * WebKitTestRunner/mac/TestControllerMac.mm:
2679         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2680         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2681         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2682         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2683         (UIScriptContext::UIScriptContext):
2684         (UIScriptContext::~UIScriptContext):
2685         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2686         asynchronous, call the callback.
2687         (UIScriptContext::nextTaskCallbackID):
2688         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2689         that has a callback). Has to store the callbackID of the script, so code called from the completion
2690         callback knows which UI script invoked it.
2691         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2692         (UIScriptContext::uiScriptComplete):
2693         (UIScriptContext::objectFromRect): Make a JS object from a rect.
2694         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2695         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2696         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2697         (WTR::UIScriptController::UIScriptController):
2698         (WTR::UIScriptController::makeWindowObject):
2699         (WTR::UIScriptController::wrapperClass):
2700         (WTR::UIScriptController::doAsyncTask):
2701         (WTR::UIScriptController::zoomToScale):
2702         (WTR::UIScriptController::zoomScale):
2703         (WTR::UIScriptController::minimumZoomScale):
2704         (WTR::UIScriptController::maximumZoomScale):
2705         (WTR::UIScriptController::contentVisibleRect):
2706         (WTR::UIScriptController::uiScriptComplete):
2707         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2708         (WTR::UIScriptController::create):
2709         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2710
2711 2015-09-21  Tim Horton  <timothy_horton@apple.com>
2712
2713         Turn on threaded scrolling by default in the tests
2714         https://bugs.webkit.org/show_bug.cgi?id=149377
2715
2716         Reviewed by Simon Fraser.
2717
2718         * WebKitTestRunner/mac/TestControllerMac.mm:
2719         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2720         (WTR::shouldUseThreadedScrolling): Deleted.
2721         Turn on threaded scrolling by default.
2722
2723 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2724
2725         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2726         https://bugs.webkit.org/show_bug.cgi?id=149252
2727
2728         Reviewed by Darin Adler.
2729
2730         In case of glib tests the test runner notifies about tests
2731         crashing, but for google tests we don't get any feedback, which
2732         means that in case of a test crashing we get a list of **PASS**
2733         messages and at the summary we are notified that the test suite
2734         has failed, but it's impossible to know which test cases have failed.
2735
2736         * Scripts/run-gtk-tests:
2737         (TestRunner._run_google_test): Add a **CRASH** message if test
2738         case crashed.
2739
2740 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2741
2742         WebKitTestRunner can leak user content script results between tests
2743         https://bugs.webkit.org/show_bug.cgi?id=149391
2744
2745         Reviewed by Sam Weinig.
2746
2747         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2748         about:blank, and thus about:blank doesn't have unintended side effects.
2749
2750         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2751         (WTR::InjectedBundle::beginTesting):
2752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2753         (WTR::InjectedBundlePage::resetAfterTest):
2754
2755 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2756
2757         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2758         https://bugs.webkit.org/show_bug.cgi?id=149384
2759
2760         Reviewed by Chris Fleizach.
2761
2762         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2763         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2764         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2765         regardless of whether someone else holds a reference (we also call -stopListening in
2766         -dealloc).
2767
2768         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2769         (AccessibilityController::platformResetToConsistentState):
2770         (AccessibilityController::addNotificationListener):
2771         Ditto.
2772
2773 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2774
2775         Remove XHR_TIMEOUT compilation guard
2776         https://bugs.webkit.org/show_bug.cgi?id=149260
2777
2778         Reviewed by Benjamin Poulain.
2779
2780         * Scripts/webkitperl/FeatureList.pm:
2781
2782 2015-09-19  Dan Bernstein  <mitz@apple.com>
2783
2784         Attempted build fix.
2785
2786         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2787
2788 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2789
2790         Unreviewed, rolling out r189908.
2791         https://bugs.webkit.org/show_bug.cgi?id=149368
2792
2793         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2794
2795         Reverted changeset:
2796
2797         "printing does not use minimum page zoom factor"
2798         https://bugs.webkit.org/show_bug.cgi?id=108507
2799         http://trac.webkit.org/changeset/189908
2800
2801 2015-09-18  Andy Estes  <aestes@apple.com>
2802
2803         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2804         https://bugs.webkit.org/show_bug.cgi?id=149360
2805
2806         Reviewed by Tim Horton.
2807
2808         Added an API test.
2809
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2812         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2813         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2814         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2815         (TEST):
2816         * TestWebKitAPI/ios/pages.pages: Added.
2817
2818 2015-09-18  Nan Wang  <n_wang@apple.com>
2819
2820         AX: Implement ARIA 1.1 @aria-current on iOS
2821         https://bugs.webkit.org/show_bug.cgi?id=149297
2822
2823         Reviewed by Chris Fleizach.
2824
2825         Added support to test aria-current on iOS.
2826
2827         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2828         (AccessibilityUIElement::stringAttributeValue):
2829         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2830         (WTR::AccessibilityUIElement::stringAttributeValue):
2831
2832 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2833
2834         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2835         https://bugs.webkit.org/show_bug.cgi?id=149352
2836
2837         Reviewed by Simon Fraser.
2838
2839         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2840         m_context can be null. This may indicate a bug in webkitpy too, but
2841         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2842         wrong with opening and immediately closing it.
2843
2844 2015-09-18  Daniel Bates  <dabates@apple.com>
2845
2846         isGitSVNDirectory() returns true when Git is not installed
2847         https://bugs.webkit.org/show_bug.cgi?id=149351
2848
2849         Reviewed by Alexey Proskuryakov.
2850
2851         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2852         Git is not installed on the machine.
2853
2854         * Scripts/VCSUtils.pm:
2855         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2856         status code 0 (success).
2857
2858 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2859
2860         Prevent build-webkit from building four times on Windows 
2861         https://bugs.webkit.org/show_bug.cgi?id=149336
2862
2863         Reviewed by Brent Fulgham.
2864
2865         * Scripts/build-webkit:
2866         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2867         They're built all at once.
2868         * Scripts/webkitdirs.pm:
2869         (buildVisualStudioProject):
2870         (cmakeGeneratedBuildfile):
2871         Don't generate the Visual Studio solution if it already exists.
2872         It will run CMake again if necessary.
2873
2874 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2875
2876         [iOS WK2] WTR fails to set the key window in the UIKit sense
2877         https://bugs.webkit.org/show_bug.cgi?id=149325
2878
2879         Reviewed by Tim Horton.
2880
2881         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2882         This causes UIKit to bypass code that actually sets the key window, resulting in
2883         [UIAppliation sharedApplication].keyWindow always being nil.
2884
2885         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2886         -[WebKitTestRunnerWindow isKeyWindow] call super.
2887
2888         * WebKitTestRunner/PlatformWebView.h:
2889         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2890         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2891         (WTR::PlatformWebView::setWindowIsKey):
2892         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2893         (WTR::PlatformWebView::setWindowIsKey):
2894         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2895         (-[WebKitTestRunnerWindow isKeyWindow]):
2896         (WTR::PlatformWebView::PlatformWebView):
2897         (WTR::PlatformWebView::~PlatformWebView):
2898         (WTR::PlatformWebView::setWindowIsKey):
2899         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2900         (WTR::PlatformWebView::setWindowIsKey):
2901
2902 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2903
2904         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2905         https://bugs.webkit.org/show_bug.cgi?id=149321
2906
2907         Reviewed by Tim Horton.
2908         
2909         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
2910         enabled the "testing" viewport configuration, which disables page scaling.
2911         
2912         If we're running viewport tests, we want the normal web page configuration.
2913         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2914         based on whether the test is in a "viewport" directory.
2915
2916         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2917         (WTR::InjectedBundle::beginTesting):
2918         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2919         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2920         * WebKitTestRunner/TestInvocation.cpp:
2921         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2922         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2923         (WTR::TestInvocation::shouldMakeViewportFlexible):
2924         (WTR::TestInvocation::invoke):
2925         * WebKitTestRunner/TestInvocation.h:
2926         * WebKitTestRunner/ios/TestControllerIOS.mm:
2927         (WTR::TestController::platformConfigureViewForTest):
2928         (WTR::shouldMakeViewportFlexible): Deleted.
2929
2930 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2931
2932         Give iOS WebKitTestRunner a launch storyboard
2933         https://bugs.webkit.org/show_bug.cgi?id=149314
2934
2935         Reviewed by Dan Bates.
2936         
2937         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2938         that it's been built for specific device configurations, and puts the window
2939         at the top of the screen. This simplifies coordinate conversions in a future patch.
2940
2941         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2942         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2943         * WebKitTestRunner/ios/Launch.storyboard: Added.
2944
2945 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2946
2947         Update licence in r189890
2948         https://bugs.webkit.org/show_bug.cgi?id=149306
2949
2950         Reviewed by Dean Jackson.
2951
2952         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2953         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2954         * FontWithFeatures/FontWithFeatures/main.cpp:
2955
2956 2015-09-17  Mark Lam  <mark.lam@apple.com>
2957
2958         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2959         https://bugs.webkit.org/show_bug.cgi?id=149285
2960
2961         Reviewed by Saam Barati.
2962
2963         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2964
2965         * Scripts/run-javascriptcore-tests:
2966         (runJSCStressTests):
2967
2968 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2969
2970         Switch AppleWin build to use CMake
2971         https://bugs.webkit.org/show_bug.cgi?id=149163
2972
2973         Reviewed by Brent Fulgham.
2974
2975         * Scripts/build-webkit:
2976         * Scripts/run-api-tests:
2977         (runTest):
2978         (listAllTests):
2979         (prepareEnvironmentForRunningTestTool):
2980         (testToolPaths):
2981         (testToolPath): Deleted.
2982         Run the API tests as separate executables on Windows.
2983         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2984         * Scripts/webkitdirs.pm:
2985         (checkRequiredSystemConfig):
2986         (jhbuildWrapperPrefixIfNeeded):
2987         (generateBuildSystemFromCMakeProject):
2988         Fix configuration quirks.
2989
2990 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2991
2992         Added toggle options for hiding and showing certain platform families on the dashboard.
2993         https://bugs.webkit.org/show_bug.cgi?id=148403
2994
2995         Reviewed by David Kilzer.
2996
2997         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2998         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2999         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3000         in lieu of an "all" button in the toggle menu.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3003         (parsePlatformFamily): Helper function to parse out a platform family.
3004         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3005         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3006         (updateToggleButtons): Updates the status of the toggle buttons.
3007         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3008         (documentReady): Added creation of toggle buttons.
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3010         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3011         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3012         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3013         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3015         (QueueView): Updated to use hiddenPlatformFamilies.
3016         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3018         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3019         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3020         (Settings.prototype.toggleHiddenPlatform): Deleted.
3021         (Settings.prototype.clearHiddenPlatforms): Deleted.
3022         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3024         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3025         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3026         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3027         (table.queue-grid tr.headers th):
3028         (div.settingsWrapper.hide):
3029         (div.settingsWrapper):
3030         (div.familyToggleWrapper):
3031         (div.platformFamilyToggleButton):
3032         (div.platformFamilyShowToggleButton:not(:last-child)):
3033         (div.familyShown):
3034         (div.accessibilityButton):
3035         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3036         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3037         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3038         platformFamilyToggleButton and settingsWrapper class.
3039         (.accessibilityButton): Deleted.
3040
3041 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3042
3043         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3044         https://bugs.webkit.org/show_bug.cgi?id=148904
3045
3046         Reviewed by Myles Maxfield.
3047
3048         * WebKitTestRunner/TestController.cpp:
3049         (WTR::parseBooleanTestHeaderValue):
3050         (WTR::updateViewOptionsFromTestHeader):
3051         Check for the key "useThreadedScrolling".
3052         Add some code to check for "true" and "false" for boolean options.
3053
3054         (WTR::TestController::viewOptionsForTest):
3055         Apply the test's overrides last, even after the platform's.
3056
3057 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3058
3059         printing does not use minimum page zoom factor
3060         https://bugs.webkit.org/show_bug.cgi?id=108507
3061
3062         Reviewed by Darin Adler.
3063
3064         WebKitTestRunner always takes the snapshots from the UI process
3065         (expect for IOS), so in the case of printing, the layout in the
3066         web view is not the expected one. When printing, we need to take
3067         the snapshot in the web process and ensure it's rendered with a
3068         PrintContext.
3069
3070         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3071         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3072         kWKSnapshotOptionsPrinting option to
3073         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3074         printing, don't even create the snapshot, since it will be ignored
3075         by the UI process that always creates its own from the WebView (expect for IOS platform)
3076         * WebKitTestRunner/TestInvocation.cpp:
3077         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3078         received from the web process if any when comparing pixel
3079         results. Now we only receive a snapshot from the web process in
3080         case of printing, or when platform is IOS. Otherwhise, generate
3081         the snapshot from the WebView as usual.
3082         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3083         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3084         is created by the caller now, but the CG implementation needs to
3085         know if it's a Web or UI process snapshot.
3086         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3087         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3088         cairo surface for the given image.
3089         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3090         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3091         CGContext for the given image.
3092
3093 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3094
3095         Create a font which can be used for testing font features
3096         https://bugs.webkit.org/show_bug.cgi?id=149237
3097
3098         Reviewed by Simon Fraser.
3099
3100         This patch adds a new project in the Tools/ directory which generates a font which can
3101         be used for testing font features. This is a standalone project consisting of two files:
3102         1. A file which actually generates the byte vector representing the font. This file has
3103         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3104         specific, and only relies on the C++ STL.
3105         2. A file with a main() which calls generateFont() and writes out the font, as well as
3106         uses the font to render some demonstration text into a .png file. This file is platform
3107         specific.
3108
3109         The font itself only supports the following characters:
3110         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3111         However, the shape of these letters are either an X or a check mark.
3112
3113         The letter "A" always is a check mark.
3114         The letter "B" always is an X.
3115         Without any font features turned on, the rest of the letters are shown as X.
3116
3117         Each font feature has an letter associated with it. When the font feature is enabled,
3118         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3119         as a check mark.
3120
3121         Here are the mappings of font features to letters:
3122         liga: C
3123         clig: D
3124         dlig: E
3125         hlig: F
3126         calt: G
3127         subs: H
3128         sups: I
3129         smcp: J
3130         c2sc: K
3131         pcap: L
3132         c2pc: M
3133         unic: N
3134         titl: O
3135         onum: P
3136         pnum: Q
3137         tnum: R
3138         frac: S
3139         afrc: T
3140         ordn: U
3141         zero: V
3142         hist: W
3143         jp78: X
3144         jp83: Y
3145         jp90: Z
3146         jp04: a
3147         smpl: b
3148         trad: c
3149         fwid: d
3150         pwid: e
3151         ruby: f
3152
3153         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3154         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3155         (integralLog2):
3156         (roundDownToPowerOfTwo):
3157         (isFourByteAligned):
3158         (clampTo):
3159         (append32):
3160         (writeCFFEncodedNumber):
3161         (CFFBuilder::CFFBuilder):
3162         (CFFBuilder::takeResult):
3163         (CFFBuilder::moveTo):
3164         (CFFBuilder::lineTo):
3165         (CFFBuilder::curveToCubic):
3166         (CFFBuilder::closePath):
3167         (CFFBuilder::writePoint):
3168         (generateBoxCharString):
3169         (generateCheckCharString):
3170         (generateXCharString):
3171         (charStringForGlyph):
3172         (Generator::generate):
3173         (Generator::Placeholder::Placeholder):
3174         (Generator::Placeholder::populate):
3175         (Generator::Placeholder::~Placeholder):
3176         (Generator::placeholder):
3177         (Generator::append16):
3178         (Generator::append32):
3179         (Generator::append32BitCode):
3180         (Generator::overwrite16):
3181         (Generator::overwrite32):
3182         (Generator::appendCFFTable):
3183         (Generator::appendSubstitutionSubtable):
3184         (Generator::appendScriptSubtable):
3185         (Generator::appendGSUBTable):
3186         (Generator::appendOS2Table):
3187         (Generator::appendFormat12CMAPTable):
3188         (Generator::appendFormat4CMAPTable):
3189         (Generator::appendCMAPTable):
3190         (Generator::appendHEADTable):
3191         (Generator::appendHHEATable):
3192         (Generator::appendHMTXTable):
3193         (Generator::appendMAXPTable):
3194         (Generator::appendNAMETable):
3195         (Generator::appendPOSTTable):
3196         (Generator::calculateChecksum):
3197         (Generator::appendTable):
3198         (generateFont):
3199         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3200         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3201         (drawTextWithFeature):
3202         (main):
3203
3204 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3205
3206         Unreviewed, rolling out r189875 and r189878.
3207         https://bugs.webkit.org/show_bug.cgi?id=149235
3208
3209         cygwin cmake build not ready yet (Requested by alexchristensen
3210         on #webkit).
3211
3212         Reverted changesets:
3213
3214         "Switch AppleWin build to use CMake"
3215         https://bugs.webkit.org/show_bug.cgi?id=149163
3216         http://trac.webkit.org/changeset/189875
3217
3218         "Cygwin build fix after r189875"
3219         http://trac.webkit.org/changeset/189878
3220
3221 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3222
3223         Cygwin build fix after r189875
3224
3225         * Scripts/build-webkit:
3226         * Scripts/webkitdirs.pm:
3227         (jhbuildWrapperPrefixIfNeeded):
3228         (generateBuildSystemFromCMakeProject):
3229         Make things work with cygwin and cmake.
3230
3231 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3232
3233         Switch AppleWin build to use CMake
3234         https://bugs.webkit.org/show_bug.cgi?id=149163
3235
3236         Reviewed by Brent Fulgham.
3237
3238         * Scripts/build-webkit:
3239         Build with CMake.
3240         * Scripts/run-api-tests:
3241         (runTest):
3242         (listAllTests):
3243         (prepareEnvironmentForRunningTestTool):
3244         (testToolPaths):
3245         (testToolPath): Deleted.
3246         Run the API tests as separate executables on Windows.
3247         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3248
3249 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
3250
3251         Add newer build.webkit.org pages to robots.txt
3252         https://bugs.webkit.org/show_bug.cgi?id=149219
3253
3254         Reviewed by Darin Adler.
3255
3256         Indexing bot watcher's dashboard can't be good.
3257
3258         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3259
3260 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3261
3262         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3263
3264         * BuildSlaveSupport/built-product-archive:
3265         (unzipArchive):
3266
3267 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3268
3269         [EFL] Fix the help message of separated web process option of MiniBrowser
3270         https://bugs.webkit.org/show_bug.cgi?id=149212
3271
3272         Reviewed by Gyuyoung Kim.
3273
3274         * MiniBrowser/efl/main.c:
3275
3276 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3277
3278         Fix python syntax after r189851.
3279
3280         * BuildSlaveSupport/built-product-archive:
3281         (unzipArchive):
3282         For loops need a colon.
3283
3284 2015-09-15  Alex Christensen  <achristensen@webkit.org>
3285
3286         Fix Windows test bots after changing to non-cygwin build
3287         https://bugs.webkit.org/show_bug.cgi?id=149196
3288
3289         Reviewed by Daniel Bates.
3290
3291         * BuildSlaveSupport/built-product-archive:
3292         (unzipArchive):
3293         Using different versions of python makes what I think is https://bugs.python.org/issue15795
3294         prevent us from executing files from the archive on the test bots.
3295
3296 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
3297
3298         Add ShadowRoot interface and Element.prototype.attachShadow
3299         https://bugs.webkit.org/show_bug.cgi?id=149187
3300
3301         Reviewed by Antti Koivisto.
3302
3303         * Scripts/webkitperl/FeatureList.pm:
3304
3305 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
3306
3307         Appscale queue status json output lacks bots
3308         https://bugs.webkit.org/show_bug.cgi?id=149194
3309         <rdar://problem/22171089>
3310
3311         Reviewed by Alexey Proskuryakov.
3312
3313         * QueueStatusServer/handlers/queuestatusjson.py:
3314         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3315         * QueueStatusServer/index.yaml: Index according to appscale requirements.
3316
3317 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
3318
3319         [Win] Provide a means for viewing the layer tree
3320         https://bugs.webkit.org/show_bug.cgi?id=149165
3321
3322         Reviewed by Simon Fraser.
3323
3324         Update MiniBrowser with a new Debug menu option that will
3325         dump the current layer tree to the debug console.
3326         
3327         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3328         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3329         * MiniBrowser/win/Common.cpp:
3330         (WndProc): Add handler for 'Print Layer Tree' menu option.
3331         * MiniBrowser/win/MiniBrowser.cpp:
3332         (MiniBrowser::printLayerTree): Added Handler.
3333         * MiniBrowser/win/MiniBrowser.h:
3334
3335 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
3336
3337         WebKitTestRunner declarative language setting is broken for iOS
3338         https://bugs.webkit.org/show_bug.cgi?id=149119
3339
3340         Unreviewed.
3341
3342         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3343         lost in the final version which got committed. This simply implements the existing
3344         OS X behavior on iOS.
3345
3346         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3347         (WTR::InjectedBundle::platformInitialize):
3348
3349 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
3350
3351         Unreviewed, add myself to committers list.
3352
3353         * Scripts/webkitpy/common/config/contributors.json:
3354
3355 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3356
3357         [Cocoa] Allow testing with the system language
3358         https://bugs.webkit.org/show_bug.cgi?id=148671
3359
3360         Reviewed by Anders Carlsson and Alexey Proskuryakov.
3361
3362         React to tests marked with language=lang1,lang2,etc in their header.
3363         Once this information is parsed, pass it to
3364         WKContextConfigurationSetOverrideLanguages().
3365
3366         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3367         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3368         list.
3369         * WebKitTestRunner/TestController.cpp:
3370         (WTR::TestController::createWebViewWithOptions): Call
3371         WKContextConfigurationSetOverrideLanguages().
3372         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3373         * WebKitTestRunner/TestOptions.h:
3374         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3375         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3376         option to restart the web process.
3377         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3378         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3379
3380 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3381
3382         [WKTR] Allow changing the WKContextConfiguration between successive tests
3383         https://bugs.webkit.org/show_bug.cgi?id=148833
3384
3385         Reviewed by Tim Horton.
3386
3387         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3388         However, there are certain tests which require specifying options in this object. This patch makes
3389         our existing code for recreating the test runner web view also recreate the WKContext.
3390
3391         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3392         class.
3393
3394         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3395         * WebKitTestRunner/PlatformWebView.h:
3396         (WTR::PlatformWebView::options):
3397         * WebKitTestRunner/TestController.cpp:
3398         (WTR::TestController::initialize):
3399         (WTR::TestController::generateContextConfiguration):
3400         (WTR::TestController::generatePageConfiguration):
3401         (WTR::TestController::createWebViewWithOptions):
3402         (WTR::TestController::ensureViewSupportsOptionsForTest):
3403         (WTR::updateContextConfigurationOptionsFromTestHeader):
3404         (WTR::TestController::contextConfigurationOptionsForTest):
3405         (WTR::TestController::platformCreateWebView):
3406         (WTR::TestController::platformCreateOtherPage):
3407         (WTR::updateViewOptionsFromTestHeader): Deleted.
3408         (WTR::TestController::viewOptionsForTest): Deleted.
3409         * WebKitTestRunner/TestController.h:
3410         (WTR::TestController::injectedBundlePath):
3411         (WTR::TestController::testPluginDirectory):
3412         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3413         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3414         (WTR::TestController::platformCreateWebView):
3415         (WTR::TestController::platformCreateOtherPage):
3416         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3417         (WTR::PlatformWebView::PlatformWebView):
3418         (WTR::PlatformWebView::viewSupportsOptions):
3419         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3420         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3421         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3422         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3423         (WTR::PlatformWebView::PlatformWebView):
3424         (WTR::PlatformWebView::viewSupportsOptions):
3425         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3426         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3427         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3428         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3429         (WTR::PlatformWebView::PlatformWebView):
3430         (WTR::PlatformWebView::viewSupportsOptions):
3431         * WebKitTestRunner/ios/TestControllerIOS.mm:
3432         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3433         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3434         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3435         (WTR::PlatformWebView::PlatformWebView):
3436         (WTR::PlatformWebView::viewSupportsOptions):
3437         * WebKitTestRunner/mac/TestControllerMac.mm:
3438         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3439         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3440
3441 2015-09-11  Michael Saboff  <msaboff@apple.com>
3442
3443         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
3444         https://bugs.webkit.org/show_bug.cgi?id=149083
3445
3446         Reviewed by Alexey Proskuryakov.
3447
3448         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
3449
3450         * DumpRenderTree/mac/LayoutTestHelper.m:
3451         (colorProfileURLForDisplay):
3452
3453 2015-09-11  Saam barati  <sbarati@apple.com>
3454
3455         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
3456         https://bugs.webkit.org/show_bug.cgi?id=149058
3457
3458         Reviewed by Geoffrey Garen.
3459
3460         * Scripts/run-jsc-stress-tests:
3461
3462 2015-09-10  Commit Queue  <commit-queue@webkit.org>
3463
3464         Unreviewed, rolling out r189595.
3465         https://bugs.webkit.org/show_bug.cgi?id=149052
3466
3467         The tests still fail (Requested by ap on #webkit).
3468
3469         Reverted changeset:
3470
3471         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
3472         error -1"
3473         https://bugs.webkit.org/show_bug.cgi?id=142929
3474         http://trac.webkit.org/changeset/189595
3475
3476 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
3477
3478         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
3479         https://bugs.webkit.org/show_bug.cgi?id=142929
3480
3481         Reviewed by Brent Fulgham.
3482
3483         Silence the logging. We'll track fixing the root cause in Radar.
3484
3485         * Scripts/webkitpy/port/mac.py:
3486         (MacPort.stderr_patterns_to_strip): Added a FIXME.
3487
3488         * Scripts/webkitpy/port/win.py:
3489         (WinPort.logging_patterns_to_strip): Added.
3490
3491 2015-09-09  Andy Estes  <aestes@apple.com>
3492
3493         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
3494         https://bugs.webkit.org/show_bug.cgi?id=149022
3495
3496         Reviewed by Daniel Bates.
3497
3498         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
3499         did not account for this.
3500
3501         * Scripts/webkitpy/xcode/simulator.py:
3502         (Simulator): Optionally matched a revision at the end of a runtime version number.
3503         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
3504
3505 2015-09-09  Andy Estes  <aestes@apple.com>
3506
3507         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
3508         https://bugs.webkit.org/show_bug.cgi?id=149029
3509         <rdar://problem/22432624>
3510
3511         Reviewed by Daniel Bates.
3512
3513         * Scripts/webkitpy/xcode/simulator.py:
3514         (Simulator): Taught to parse tvOS runtimes.
3515         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3516
3517 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3518
3519         Fix bit rot on bot watcher's dashboard page
3520         https://bugs.webkit.org/show_bug.cgi?id=149012
3521
3522         Reviewed by Tim Horton.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3525         The code path used by the metrics page was trying to add properties to an undefined.
3526
3527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3528         Silence an expection that would occur when the step has no logs. This should never
3529         happen, but it did (perhaps buildbot was misconfigured for a while).
3530
3531 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3532
3533         Update LayoutTestRelay xcconfig file.
3534
3535         Rubber-stamped by Dan Bernstein.
3536
3537         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3538
3539 2015-09-09  Saam barati  <sbarati@apple.com>
3540
3541         DFG should have a debugging option that runs a phase that flushes all locals
3542         https://bugs.webkit.org/show_bug.cgi?id=148916
3543
3544         Reviewed by Filip Pizlo.
3545
3546         * Scripts/run-jsc-stress-tests:
3547
3548 2015-09-09  Commit Queue  <commit-queue@webkit.org>
3549
3550         Unreviewed, rolling out r189530 and r189534.
3551         https://bugs.webkit.org/show_bug.cgi?id=148996
3552
3553         Caused assertion failures on Yosemite (Requested by litherum
3554         on #webkit).
3555
3556         Reverted changesets:
3557
3558         "[WKTR] Allow changing the WKContextConfiguration between
3559         successive tests"
3560         https://bugs.webkit.org/show_bug.cgi?id=148833
3561         http://trac.webkit.org/changeset/189530
3562
3563         "[Cocoa] Fix the tests after r189530"
3564         http://trac.webkit.org/changeset/189534
3565
3566 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3567
3568         [Cocoa] Fix the tests after r189530
3569
3570         Unreviewed.
3571
3572         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3573         (WTR::initializeWebViewConfiguration):
3574
3575 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3576
3577         [WKTR] Allow changing the WKContextConfiguration between successive tests
3578         https://bugs.webkit.org/show_bug.cgi?id=148833
3579
3580         Reviewed by Tim Horton.
3581
3582         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3583         However, there are certain tests which require specifying options in this object. This patch makes
3584         our existing code for recreating the test runner web view also recreate the WKContext.
3585
3586         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3587         class.
3588
3589         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3590         * WebKitTestRunner/PlatformWebView.h:
3591         (WTR::PlatformWebView::options):
3592         * WebKitTestRunner/TestController.cpp:
3593         (WTR::TestController::initialize):
3594         (WTR::TestController::generateContextConfiguration):
3595         (WTR::TestController::generatePageConfiguration):
3596         (WTR::TestController::createWebViewWithOptions):
3597         (WTR::TestController::ensureViewSupportsOptionsForTest):
3598         (WTR::updateContextConfigurationOptionsFromTestHeader):
3599         (WTR::TestController::contextConfigurationOptionsForTest):
3600<