a2d691541780f5df9ca75673676f0174a818aed0
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         W3C test importer should sort the list of files when generating the w3c-import.log
4         https://bugs.webkit.org/show_bug.cgi?id=141156
5
6         Reviewed by Bem Jones-Bey.
7
8         Sort explicitly the list of imported files written in the w3c-import.log.
9         Removed logging of the import date.
10
11         * Scripts/webkitpy/w3c/test_importer.py:
12         (TestImporter.write_import_log):
13
14 2015-02-04  Daniel Bates  <dabates@apple.com>
15
16         test-webkitpy fails on Mac without iphoneos SDK
17         https://bugs.webkit.org/show_bug.cgi?id=141255
18         <rdar://problem/19619691>
19
20         Reviewed by David Kilzer and Alexey Proskuryakov.
21
22         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
23         should not require the iphoneos SDK to be installed to run the webkitpy tests.
24
25         * Scripts/webkitpy/common/system/platforminfo.py:
26         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
27         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
28         to standard output if the SDK is installed to return the empty string if the SDK is
29         not installed.
30         * Scripts/webkitpy/common/system/platforminfo_mock.py:
31         (MockPlatformInfo.xcode_sdk_version): Added.
32         * Scripts/webkitpy/port/ios.py:
33         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
34         to get the version of the iphoneos SDK, if installed.
35
36 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
37
38         run-webkit-tests doesn't always capture ASan violation reports
39         https://bugs.webkit.org/show_bug.cgi?id=141231
40
41         Reviewed by Darin Adler.
42
43         * Scripts/webkitpy/port/driver.py:
44         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
45         by the driver already (as is the case with ASan violations, which are printed to
46         stderr).
47         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
48         report.
49         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
50         a separate variable for reporting.
51
52 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
53
54         [webkitpy] Add platform specific Skipped file mechanism for performance tests
55         https://bugs.webkit.org/show_bug.cgi?id=141152
56
57         Reviewed by Csaba Osztrogonác.
58
59         Support a test-expectation-like syntax in performance tests' skipped files.
60         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
61
62         * Scripts/webkitpy/port/base.py:
63         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
64
65         * Scripts/webkitpy/port/base_unittest.py:
66         (PortTest.test_skipped_perf_tests): Test the new syntax.
67
68 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
69
70         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
71         https://bugs.webkit.org/show_bug.cgi?id=141236
72
73         Reviewed by Sam Weinig.
74
75         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
76         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
77
78 2015-02-04  Chris Dumez  <cdumez@apple.com>
79
80         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
81         https://bugs.webkit.org/show_bug.cgi?id=141192
82
83         Reviewed by Benjamin Poulain.
84
85         Add API tests for Vector::removeFirst(value) and
86         Vector::removeAll(value).
87
88         * TestWebKitAPI/Tests/WTF/Vector.cpp:
89         (TestWebKitAPI::TEST):
90
91 2015-02-03  Tim Horton  <timothy_horton@apple.com>
92
93         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
94         https://bugs.webkit.org/show_bug.cgi?id=141217
95
96         Reviewed by Sam Weinig.
97
98         * WebKitTestRunner/TestController.cpp:
99         (WTR::copyWebCryptoMasterKey):
100         (WTR::TestController::createOtherPage):
101         (WTR::TestController::createWebViewWithOptions):
102         (WTR::TestController::ensureViewSupportsOptions):
103         (WTR::TestController::didCommitNavigation):
104         (WTR::TestController::didFinishNavigation):
105         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
106         (WTR::TestController::didReceiveAuthenticationChallenge):
107         (WTR::TestController::decidePolicyForPluginLoad):
108         (WTR::TestController::decidePolicyForNavigationAction):
109         (WTR::TestController::decidePolicyForNavigationResponse):
110         (WTR::TestController::didCommitLoadForFrame): Deleted.
111         (WTR::TestController::didFinishLoadForFrame): Deleted.
112         * WebKitTestRunner/TestController.h:
113         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
114
115 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
116
117         Unreviewed. Add myself as a committer.
118
119         * Scripts/webkitpy/common/config/contributors.json:
120
121 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
122
123         [Win] Unreviewed test fix.
124
125         * DumpRenderTree/win/PolicyDelegate.cpp:
126         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
127         so was not matching expected output.
128
129 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
130
131         Unreviewed. Moving myself to the committer section at last.
132
133         * Scripts/webkitpy/common/config/contributors.json:
134
135 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
136
137         [Win] Tests fail because DRT reports '(null)' instead of an empty string
138         https://bugs.webkit.org/show_bug.cgi?id=141205
139
140         Reviewed by Anders Carlsson.
141
142         * DumpRenderTree/win/HistoryDelegate.cpp:
143         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
144         properly so that we match expected DumpRenderTree output.
145
146 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
147
148         [GTK] TestWebKitAccessibility is not skipped
149         https://bugs.webkit.org/show_bug.cgi?id=141179
150
151         Reviewed by Carlos Garcia Campos.
152
153         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
154         skipped, and it apparently works reliably on the bots.
155
156         * Scripts/run-gtk-tests:
157         (TestRunner):
158
159 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
160
161         run-perf-tests: allow to specify a wrapper command.
162         https://bugs.webkit.org/show_bug.cgi?id=141172
163
164         Reviewed by Ryosuke Niwa.
165
166         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
167         (parse_args): Update text to indicate is also valid for WTR.
168         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
169         (PerfTestsRunner._parse_args): Add wrapper command.
170
171 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
172
173         [Win] Correct version parsing warning in update-webkit
174         https://bugs.webkit.org/show_bug.cgi?id=141200
175
176         Reviewed by Anders Carlsson.
177
178         * Scripts/webkitdirs.pm:
179         (setupAppleWinEnv): Strip out any specific version build level
180         from the Cygwin version information.
181   
182
183 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
184
185         [Win] Attempt to improve the reliability of HTTP service
186         https://bugs.webkit.org/show_bug.cgi?id=141191
187
188         Reviewed by Darin Adler.
189
190         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
191         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
192         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
193         when stopping the service doesn't do so on its own (for Windows runs).
194
195 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
196
197         Web platform test server should not need to create __init__.py files
198         https://bugs.webkit.org/show_bug.cgi?id=141030
199
200         Reviewed by Ryosuke Niwa.
201
202         W3C TestImporter ensures that copied __init__.py files are not empty.
203         If needed, a comment is inserted in __init__.py files.
204         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
205
206         * Scripts/webkitpy/common/system/filesystem.py:
207         (FileSystem.getsize):
208         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
209         (TestWebPlatformTestServer.test_start_cmd):
210         (TestWebPlatformTestServer):
211         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
212         * Scripts/webkitpy/w3c/test_importer.py:
213         (TestImporter.import_tests):
214
215 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
216
217         Unreviewed. Moving myself to the committer section.
218
219         * Scripts/webkitpy/common/config/contributors.json:
220
221 2015-02-02  Saam Barati  <saambarati1@gmail.com>
222
223         Create tests for JSC's Control Flow Profiler
224         https://bugs.webkit.org/show_bug.cgi?id=141123
225
226         Reviewed by Filip Pizlo.
227
228         * Scripts/run-javascriptcore-tests:
229         (runJSCStressTests):
230         * Scripts/run-jsc-stress-tests:
231
232 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
233
234         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
235         https://bugs.webkit.org/show_bug.cgi?id=141158
236
237         Reviewed by Darin Adler.
238
239         * Scripts/run-jsc-stress-tests:
240
241 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
242
243         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
244         https://bugs.webkit.org/show_bug.cgi?id=141142
245
246         Reviewed by Carlos Garcia Campos.
247
248         * MiniBrowser/gtk/BrowserWindow.c:
249         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
250
251 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
252
253         Web platform test server is not always launching properly on Mac EWS bots
254         https://bugs.webkit.org/show_bug.cgi?id=141141
255
256         Unreviewed.
257
258         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
259         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
260
261 2015-01-31  Sam Weinig  <sam@webkit.org>
262
263         Remove even more Mountain Lion support
264         https://bugs.webkit.org/show_bug.cgi?id=141124
265
266         Reviewed by Alexey Proskuryakov.
267
268         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
269         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
270         * DumpRenderTree/mac/Configurations/Base.xcconfig:
271         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
272         * DumpRenderTree/mac/DumpRenderTree.mm:
273         (activateTestingFonts):
274         (prepareConsistentTestingEnvironment):
275         * DumpRenderTree/mac/EventSendingController.mm:
276         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
277         (-[EventSendingController contextClick]):
278         * DumpRenderTree/mac/TextInputController.m:
279         * LayoutTestRelay/Configurations/Base.xcconfig:
280         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
281         * MiniBrowser/Configurations/Base.xcconfig:
282         * MiniBrowser/Configurations/DebugRelease.xcconfig:
283         * MiniBrowser/mac/WK2BrowserWindowController.m:
284         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
285         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
286         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
287         * TestWebKitAPI/Configurations/Base.xcconfig:
288         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
289         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
290         (-[DownloadDelegate _downloadDidFinish:]):
291         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
294         (TestWebKitAPI::InjectedBundleController::platformInitialize):
295         * WebKitLauncher/Configurations/Base.xcconfig:
296         * WebKitTestRunner/Configurations/Base.xcconfig:
297         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
298         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
299         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
300         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
301         (WTR::activateFonts):
302         * WebKitTestRunner/TestController.cpp:
303         (WTR::TestController::initialize):
304         (WTR::TestController::webProcessName):
305         * WebKitTestRunner/mac/EventSenderProxy.mm:
306         * asan/asan.xcconfig:
307
308 2015-01-31  Commit Queue  <commit-queue@webkit.org>
309
310         Unreviewed, rolling out r179408.
311         https://bugs.webkit.org/show_bug.cgi?id=141117
312
313         This didn't fully fix the issue (Requested by anttik on
314         #webkit).
315
316         Reverted changeset:
317
318         "OSObjectPtr does not work with dispatch_data_t on Maverics"
319         https://bugs.webkit.org/show_bug.cgi?id=141081
320         http://trac.webkit.org/changeset/179408
321
322 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
323
324         https://trac.webkit.org/changeset/179439 breaks a python test
325         https://bugs.webkit.org/show_bug.cgi?id=141114
326
327         Unreviewed.
328
329         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
330         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
331
332 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
333
334         Import W3C web platform tests infrastructure
335         https://bugs.webkit.org/show_bug.cgi?id=140934
336
337         Reviewed by Ryosuke Niwa.
338
339         Loading necessary web platform tests modules before launching server.
340         Ensuring that some empty __init__.py files are present and create them if necessary. 
341
342         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
343         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
344
345 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
346
347         [Win] Another unreviewed test fix.
348
349         Correct copy/paste error in buildbot handling.
350
351         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
352         (LayoutTestApacheHttpd.__init__):
353         (LayoutTestApacheHttpd._get_apache_config_file_path):
354
355 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
356
357         [Win] Unreviewed test fix.
358
359         Correct path handling based on failures on test bots to get things running again.
360
361         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
362         (LayoutTestApacheHttpd.__init__):
363         (LayoutTestApacheHttpd._get_apache_config_file_path):
364
365 2015-01-30  Chris Dumez  <cdumez@apple.com>
366
367         Unreviewed. Fix Windows build after r179409.
368
369         * DumpRenderTree/win/TestRunnerWin.cpp:
370         (TestRunner::notifyDone):
371         (TestRunner::queueLoad):
372
373 2015-01-30  Chris Dumez  <cdumez@apple.com>
374
375         Rename shared() static member functions to singleton() for singleton classes.
376         https://bugs.webkit.org/show_bug.cgi?id=141088
377
378         Reviewed by Ryosuke Niwa and Benjamin Poulain.
379
380         Rename shared() static member functions to singleton() for singleton
381         classes as per the recent coding style change.
382
383 2015-01-30  Antti Koivisto  <antti@apple.com>
384
385         OSObjectPtr does not work with dispatch_data_t on Maverics
386         https://bugs.webkit.org/show_bug.cgi?id=141081
387
388         Reviewed by Pratik Solanki.
389
390         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
391         (TestWebKitAPI::TEST):
392
393 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
394
395         [Win] Switch to Apache on Windows
396         https://bugs.webkit.org/show_bug.cgi?id=141060
397
398         Reviewed by Alexey Proskuryakov.
399
400         Update our scripts under Windows (and Cygwin) to locate and use
401         the XAMPP installation of Apache for running tests.
402
403         * Scripts/run-webkit-httpd:
404         * Scripts/webkitperl/httpd.pm:
405         (getHTTPDPath):
406         (getDefaultConfigForTestDirectory):
407         (getHTTPDConfigPathForTestDirectory):
408         * Scripts/webkitpy/common/system/executive_unittest.py:
409         (ExecutiveTest.serial_test_kill_process):
410         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
411         (LayoutTestApacheHttpd.__init__):
412         (LayoutTestApacheHttpd._get_apache_config_file_path):
413         (LayoutTestApacheHttpd._stop_running_server):
414         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
415         (HttpServerBase._is_server_running_on_all_ports):
416         * Scripts/webkitpy/port/base.py:
417         (Port._apache_config_file_name_for_platform):
418         * Scripts/webkitpy/port/port_testcase.py:
419         (test_apache_config_file_name_for_platform):
420         * Scripts/webkitpy/port/win.py:
421         (WinPort.show_results_html_file):
422         (WinPort._uses_apache):
423         (WinPort):
424         (WinPort._path_to_apache):
425
426 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
427
428         Built result takes too long to be compressed on bots
429         https://bugs.webkit.org/show_bug.cgi?id=141056
430
431         Reviewed by Daniel Bates.
432
433         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
434
435         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
436
437 2015-01-29  Sam Weinig  <sam@webkit.org>
438
439         Remove support for screen font substitution
440         https://bugs.webkit.org/show_bug.cgi?id=141038
441
442         Reviewed by Tim Horton.
443
444         * DumpRenderTree/win/DumpRenderTree.cpp:
445         (resetWebPreferencesToConsistentValues):
446         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
447
448 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
449
450         Make run-jsc-stress-tests --remote work on Linux too
451         https://bugs.webkit.org/show_bug.cgi?id=141000
452
453         Reviewed by Darin Adler.
454
455         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
456         use bash/dash compatible signal names, use Linux/Mac compatible find options,
457         use bash/dash compatible functions.
458         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
459
460 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
461
462         [buildbot] Simplify jscore-test buildstep
463         https://bugs.webkit.org/show_bug.cgi?id=140821
464
465         Reviewed by Alexey Proskuryakov.
466
467         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
468         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
469         (RunJavaScriptCoreTests.countFailures): Added.
470         (RunJavaScriptCoreTests.commandComplete): Deleted.
471         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
472         (RunJavaScriptCoreTests.getText): Deleted.
473         (RunJavaScriptCoreTests.getText2): Deleted.
474         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
475         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
476         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
477         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
478         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
479
480 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
481
482         Unreviewed, revert r179337, we don't need this dependency.
483
484         * efl/install-dependencies:
485         * gtk/install-dependencies:
486
487 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
488
489         Unreviewed. Moving myself to the committer section.
490
491         * Scripts/webkitpy/common/config/contributors.json:
492
493 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
494
495         URTBF after r179326, added uuid-dev package as new dependency.
496
497         * efl/install-dependencies:
498         * gtk/install-dependencies:
499
500 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
501
502         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
503         https://bugs.webkit.org/show_bug.cgi?id=140673
504
505         Reviewed by Sam Weinig.
506
507         * Scripts/dtrace/trace-webkit2-messages.d: Added.
508         Add a DTrace script that outputs a small blob of JSON per message.
509
510 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
511
512         Removed fastMallocForbid / fastMallocAllow
513         https://bugs.webkit.org/show_bug.cgi?id=141012
514
515         Reviewed by Mark Hahnenberg.
516
517         Fixed a test bug I noticed while testing.
518
519         * DumpRenderTree/JavaScriptThreading.cpp:
520         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
521         accessing javaScriptThreads -- otherwise, you'll ASSERT.
522
523 2015-01-28  Dana Burkart  <dburkart@apple.com>
524
525         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
526         https://bugs.webkit.org/show_bug.cgi?id=141015
527
528         Reviewed by Alexey Proskuryakov.
529
530         * asan/asan.xcconfig:
531
532 2015-01-28  Sam Weinig  <sam@webkit.org>
533
534         Fix the build.
535
536         * Scripts/copy-webkitlibraries-to-product-directory:
537
538 2015-01-28  Lucas Forschler  <lforschler@apple.com>
539
540         Increase the FileUpload block size in an attempt to improve network performance.
541         
542         Reviewed by Alexey Proskuryakov.
543         
544         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
545         (UploadBuiltProduct.__init__):
546
547 2015-01-28  Dana Burkart  <dburkart@apple.com>
548
549         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
550         https://bugs.webkit.org/show_bug.cgi?id=136765
551
552         Reviewed by Alexey Proskuryakov.
553
554         * DumpRenderTree/mac/Configurations/Base.xcconfig:
555         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
556         * LayoutTestRelay/Configurations/Base.xcconfig:
557         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
558         * MiniBrowser/Configurations/Base.xcconfig:
559         * MiniBrowser/Configurations/DebugRelease.xcconfig:
560         * TestWebKitAPI/Configurations/Base.xcconfig:
561         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
562         * WebKitLauncher/Configurations/Base.xcconfig:
563         * WebKitTestRunner/Configurations/Base.xcconfig:
564         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
565
566 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
567
568         AX: [ATK] Implement support for new AtkRole types for MathML
569         https://bugs.webkit.org/show_bug.cgi?id=140916
570
571         Reviewed by Chris Fleizach.
572
573         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
574         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
575
576 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
577
578         [GTK] Stop removing color marks from unit tests output
579         https://bugs.webkit.org/show_bug.cgi?id=140996
580
581         Reviewed by Philippe Normand.
582
583         Since r178236 google tests use a custom simplified output without
584         any colors, so we don't need to handle the case of non ttys to
585         remove the color marks.
586
587         * Scripts/run-gtk-tests:
588         (TestRunner.__init__):
589         (TestRunner._run_test_command.parse_line):
590
591 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
594         https://bugs.webkit.org/show_bug.cgi?id=131731
595
596         Reviewed by Žan Doberšek.
597
598         A web page loaded offscreen is in prerender state not hidden.
599
600         * Scripts/run-gtk-tests:
601         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
602         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
603         (testWebViewPageVisibility):
604
605 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
606
607         Partially revert r178802.
608
609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
611
612 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
613
614         build.webkit.org/dashboard asserts on some commits
615         https://bugs.webkit.org/show_bug.cgi?id=140926
616
617         Reviewed by Tim Horton.
618
619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
620         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
621
622 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
623
624         Make flakiness dashboard OS list actually match test_expectations.py
625         https://bugs.webkit.org/show_bug.cgi?id=140969
626
627         Reviewed by Ryosuke Niwa.
628
629         * TestResultServer/static-dashboards/flakiness_dashboard.js:
630
631 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
632
633         [Win] WinLauncher crashes on eleventh site visited
634         https://bugs.webkit.org/show_bug.cgi?id=140960
635
636         Reviewed by Anders Carlsson.
637
638         * WinLauncher/WinLauncher.cpp:
639         (WinLauncher::showLastVisitedSites): Don't access off the end of
640         the history array.
641
642 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
643
644         [Mac] Disable building Java applets by default
645         https://bugs.webkit.org/show_bug.cgi?id=140957
646         rdar://problem/19619529
647
648         Reviewed by Anders Carlsson.
649
650         It was actually already disabled unconditionally, by accident.
651
652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
653         * Scripts/webkitpy/port/mac.py:
654         (MacPort._check_port_build):
655         (MacPort._build_java_test_support):
656
657 2015-01-27  Daniel Bates  <dabates@apple.com>
658
659         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
660         https://bugs.webkit.org/show_bug.cgi?id=140949
661
662         Reviewed by Alexey Proskuryakov.
663
664         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
665         builders so that run-webkit-tests can lint the appropriate TestExpectation
666         files.
667
668         * Scripts/webkitpy/port/builders.py:
669         * Scripts/webkitpy/port/ios.py:
670         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
671         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
672         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
673         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
674         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
675         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
676         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
677
678
679 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
680
681         Update bots on the flakiness dashboard
682         https://bugs.webkit.org/show_bug.cgi?id=140956
683
684         Reviewed by Ryosuke Niwa.
685
686         * TestResultServer/static-dashboards/builders.jsonp:
687         * TestResultServer/static-dashboards/flakiness_dashboard.js:
688
689 2015-01-27  Daniel Bates  <dabates@apple.com>
690
691         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
692         https://bugs.webkit.org/show_bug.cgi?id=140942
693
694         Reviewed by Alexey Proskuryakov.
695
696         The directory LayoutTests/platform/wk2 contains test expectations and test results that
697         are applicable to all WebKit2 ports. We should make use of this information when
698         running layout tests using iOS WebKit2.
699
700         Additionally, make use of the convenience function Port._wk2_port_name() for the name
701         of the WebKit2 port instead of directly using string concatenation.
702
703         * Scripts/webkitpy/port/ios.py:
704         (IOSSimulatorPort.default_baseline_search_path):
705
706 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
707
708         [Win] Disable FTL stress tests
709         https://bugs.webkit.org/show_bug.cgi?id=140932
710
711         Reviewed by Brent Fulgham.
712
713         * Scripts/run-javascriptcore-tests:
714
715 2015-01-27  Daniel Bates  <dabates@apple.com>
716
717         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
718         https://bugs.webkit.org/show_bug.cgi?id=140939
719
720         Reviewed by Eric Carlson.
721
722         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
723
724         * Scripts/webkitdirs.pm:
725         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
726         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
727         and define a function called wanted.
728
729 2015-01-27  Daniel Bates  <dabates@apple.com>
730
731         Teach run-webkit-app --simulator how to install custom built app
732         https://bugs.webkit.org/show_bug.cgi?id=140691
733
734         Fix inadvertent omission of directory test flag in expression to check for the
735         existence of the iOS simulator device-specific directory for user installed apps.
736
737         * Scripts/webkitdirs.pm:
738         (hasUserInstalledAppInSimulatorDevice):
739
740 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
741
742         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
743         https://bugs.webkit.org/show_bug.cgi?id=87426
744         <rdar://problem/11527899>
745
746         Reviewed by Darin Adler.
747
748         Revise COMPtr to work better with our HashMap implementation. Use
749         modern loop syntax.
750
751         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
752         (AccessibilityController::~AccessibilityController):
753         (AccessibilityController::winNotificationReceived):
754         * DumpRenderTree/win/DumpRenderTree.cpp:
755         (dumpBackForwardListForAllWindows):
756
757 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
758
759         [Win] Enable JSC stress tests by default
760         https://bugs.webkit.org/show_bug.cgi?id=128307
761
762         Reviewed by Brent Fulgham.
763
764         * Scripts/run-javascriptcore-tests:
765
766 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
767
768         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
769         arguments for build and test scripts
770         https://bugs.webkit.org/show_bug.cgi?id=139748
771
772         Reviewed by Daniel Bates.
773
774         There was much confusion resulting from the multitude of aliases used to build/test for
775         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
776         tests directory.
777
778         This fixes an issue where run-api-tests and some other scripts failed when run with
779         --simulator.
780
781         * Scripts/build-webkit:
782         * Scripts/package-root:
783         (usage):
784         * Scripts/webkitdirs.pm:
785         (argumentsForConfiguration):
786         (determineXcodeSDK):
787         * Scripts/webkitpy/port/factory.py:
788         (platform_options):
789
790 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
791
792         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
793         https://bugs.webkit.org/show_bug.cgi?id=140203
794         rdar://problem/19198492
795
796         Reviewed by Sam Weinig.
797
798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
799         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
800         (TEST):
801
802 2015-01-26  David Kilzer  <ddkilzer@apple.com>
803
804         Add iOS EWS to build.webkit.org/dashboard
805         <http://webkit.org/b/140627>
806
807         Reviewed by Alexey Proskuryakov.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
812         (BubbleQueueServer): Add ios-ews queue info.
813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
814         Add iOS8Device platform.
815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
816         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
817         iOS device logo.
818
819 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
820
821         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
822         https://bugs.webkit.org/show_bug.cgi?id=140896
823
824         Reviewed by Michael Saboff.
825         
826         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
827         makes our script do this.
828         
829         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
830         this would be harder given llvm's autoconf setup.
831
832         * Scripts/copy-webkitlibraries-to-product-directory:
833
834 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
835
836         Update bot assignments.
837
838         * BuildSlaveSupport/build.webkit.org-config/config.json:
839
840 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
841
842         Integrate WP python server into WebKit test framework
843         https://bugs.webkit.org/show_bug.cgi?id=127094
844
845         Reviewed by Ryosuke Niwa.
846
847         This patch adds W3C web server (wptserver) as a new HTTP server.
848         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
849         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
850
851         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
852         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
853         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
854
855         * Scripts/webkitpy/common/system/executive_mock.py:
856         (MockProcess.communicate):
857         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
858         (LayoutTestRunner.__init__):
859         (LayoutTestRunner.run_tests):
860         (LayoutTestRunner.start_servers):
861         (LayoutTestRunner.stop_servers):
862         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
863         (LayoutTestRunnerTests._run_tests):
864         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
865         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
866         (LayoutTestRunnerTests):
867         (LayoutTestRunnerTests.test_servers_started):
868         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
869         (Manager.__init__):
870         (Manager._is_http_test):
871         (Manager._is_web_platform_test):
872         (Manager._run_tests):
873         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
874         (ManagerTest.test_needs_servers.get_wpt_doc_root):
875         (ManagerTest.test_needs_servers.get_manager):
876         (ManagerTest.test_needs_servers):
877         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
878         (parse_args):
879         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
880         (main):
881         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
882         (doc_root):
883         (base_url):
884         (WebPlatformTestServer):
885         (WebPlatformTestServer.__init__):
886         (WebPlatformTestServer._set_start_cmd):
887         (WebPlatformTestServer._copy_webkit_test_files):
888         (WebPlatformTestServer._clean_webkit_test_files):
889         (WebPlatformTestServer._prepare_config):
890         (WebPlatformTestServer._spawn_process):
891         (WebPlatformTestServer._stop_running_server):
892         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
893         (TestWebPlatformTestServer):
894         (TestWebPlatformTestServer.test_start_cmd):
895         * Scripts/webkitpy/port/base.py:
896         (Port.__init__):
897         (Port.to.start_web_platform_test_server):
898         (Port.to):
899         (Port.to.web_platform_test_server_doc_root):
900         (Port.to.web_platform_test_server_base_url):
901         (Port.to.stop_web_platform_test_server):
902         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
903         (Driver.__init__):
904         (Driver.is_web_platform_test):
905         (Driver.test_to_uri):
906         (Driver.uri_to_test):
907         (Driver._command_from_driver_input):
908         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
909         (DriverTest.test_test_to_uri):
910         (DriverTest.test_uri_to_test):
911
912 2015-01-26  Daniel Bates  <dabates@apple.com>
913
914         Teach run-webkit-app --simulator how to install custom built app
915         https://bugs.webkit.org/show_bug.cgi?id=140691
916
917         Reviewed by David Kilzer.
918
919         We should teach run-webkit-app --simulator how to install a custom built app.
920
921         Currently run-webkit-app --simulator can only run a system app or an app that
922         was installed using the simctl command line tool. For convenience we should
923         teach run-webkit-app --simulator how to install a custom built app.
924
925         As a side effect of this change run-safari --simulator will install and run
926         a custom built of MobileSafari (if it exists).
927
928         * Scripts/webkitdirs.pm:
929         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
930         Perl from the structure of the device.plist file.
931         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
932         file system check to determine the plist path for a Mac app bundle.
933         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
934         it will complain that it cannot find the file: "Domain ... does not exist".
935         (appDisplayNameFromBundle): Ditto.
936         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
937         until a simulator device is the specified state.
938         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
939         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
940         the specified device.
941         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
942         As implied by its name, this function will not return until the specified simulator
943         device UDID is in the shutdown state.
944         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
945         device with the specified UDID.
946         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
947         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
948         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
949         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
950         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
951         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
952         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
953         (hasUserInstalledAppInSimulatorDevice): Added.
954         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
955         "Booted" state.
956         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
957         switching between a system installed app and a custom built version of the same app (e.g.
958         custom build of MobileSafari) will erase all contents and settings in the simulator device.
959         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
960         as that was the only caller of this function.
961         (bootedIOSSimulatorDevice): Deleted.
962         (openIOSSimulator): Deleted.
963
964 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
965
966         Update bot assignments.
967
968         * BuildSlaveSupport/build.webkit.org-config/config.json:
969
970 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
971
972         Leaks bot shouldn't run JSC tests
973         https://bugs.webkit.org/show_bug.cgi?id=140877
974
975         Reviewed by Darin Adler.
976
977         Shaves off 48 minutes of time.
978
979         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
980         (TestLeaksFactory): Slim down the leaks queue.
981
982         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
983         * Scripts/webkitpy/port/ios.py:
984         (IOSSimulatorPort.print_leaks_summary):
985         * Scripts/webkitpy/port/mac.py:
986         (MacPort.print_leaks_summary):
987         Don't yell when leaks are detected.
988
989 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
990
991         Refactor run-javascriptcore-tests
992         https://bugs.webkit.org/show_bug.cgi?id=140824
993
994         Reviewed by Darin Adler.
995
996         Separated mozilla, stress test code paths and
997         determining skipped mozilla tests into subroutines.
998
999         * Scripts/run-javascriptcore-tests:
1000         (runMozillaTests):
1001         (runJSCStressTests):
1002         (defaultJsDriverArgsForMozillaTests):
1003
1004 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1005
1006         [buildbot] Fix grammar of TestWithFailureCount
1007         https://bugs.webkit.org/show_bug.cgi?id=140884
1008
1009         Reviewed by Alexey Proskuryakov.
1010
1011         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1012         (TestWithFailureCount):
1013         (TestWithFailureCount.commandComplete):
1014         (TestWithFailureCount.getText2):
1015         (RunUnitTests):
1016         (RunPythonTests):
1017         (RunPerlTests):
1018         (RunLLINTCLoopTests):
1019         (Run32bitJSCTests):
1020         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1021         (RunLLINTCLoopTestsTest.test_failure):
1022         (Run32bitJSCTestsTest.test_failure):
1023         (RunUnitTestsTest.assertFailures):
1024
1025 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1026
1027         Unreviewed. Moving myself to the committer section.
1028
1029         * Scripts/webkitpy/common/config/contributors.json:
1030
1031 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1032
1033         [GTK] gtkdoc does not appear in DevHelp
1034         https://bugs.webkit.org/show_bug.cgi?id=139369
1035
1036         Reviewed by Philippe Normand.
1037
1038         * gtk/generate-gtkdoc: Create the generators in the main function
1039         and use them to get the local cross renference dependencies. Also
1040         pass the generator module name to webkitdom.write_doc_files().
1041         (get_gtkdoc_module_paths): Receive a list of local cross reference
1042         dependencies.
1043         (get_generator_for_config): Set the main_sgml_file property of the
1044         GtkDoc object from the configuration file.
1045         (generate_documentation): Generate the documentation for the given
1046         generator.
1047         (generate_documentation_for_config): Deleted.
1048         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1049         * gtk/webkitdom.py:
1050         (write_doc_files): Receive the module name used to build the
1051         -sections.txt filename.
1052
1053 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1054
1055         Unreviewed, rolling out r179107.
1056         https://bugs.webkit.org/show_bug.cgi?id=140880
1057
1058         The GCC in the bots doesn't support the AsyncTask
1059         implementation (Requested by KaL on #webkit).
1060
1061         Reverted changeset:
1062
1063         "[GTK] Enable IndexedDB"
1064         https://bugs.webkit.org/show_bug.cgi?id=98932
1065         http://trac.webkit.org/changeset/179107
1066
1067 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1068
1069         [EFL] Bump libseccomp version to 2.1.1
1070         https://bugs.webkit.org/show_bug.cgi?id=140357
1071
1072         Reviewed by Gyuyoung Kim.
1073
1074         * efl/jhbuild.modules:
1075
1076 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1077
1078         [GTK] Enable IndexedDB
1079         https://bugs.webkit.org/show_bug.cgi?id=98932
1080
1081         Reviewed by Žan Doberšek.
1082
1083         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1084
1085 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1086
1087         Would like leaks bot results at build.webkit.org/dashboard
1088         https://bugs.webkit.org/show_bug.cgi?id=122657
1089
1090         Reviewed by Darin Adler.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1093         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1094         than necessary, could use the ones from buildbot in more places.
1095
1096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1097         (BuildbotQueue): Reflect configuration option for leaks queues.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1100         Add leaks queues to performance column. First, leaks are about performance indeed,
1101         and second, this is where we have some space to spare.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1104         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1105         least a year.
1106
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1108         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1109         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1110         results - once the results are loaded, all rows are currently higher than that.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1113         (.leaks-popover): Added.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1116         Added.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1119         Load BuildbotLeaksQueueView.js.
1120
1121 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1122
1123         [Win] Add WebKit message loop interface.
1124         https://bugs.webkit.org/show_bug.cgi?id=140857
1125
1126         Reviewed by Brent Fulgham.
1127
1128         Added message loop interface which will run the message loop,
1129         and perform required tasks (like calling CFRunLoopRunInMode)
1130         on each iteration of the loop.
1131
1132         * WinLauncher/WinMain.cpp:
1133         (wWinMain): Use new message loop interface.
1134
1135 2015-01-24  Dan Bernstein  <mitz@apple.com>
1136
1137         update-webkit’s --internal option is unused
1138         https://bugs.webkit.org/show_bug.cgi?id=140861
1139
1140         Reviewed by Anders Carlsson.
1141
1142         * Scripts/update-webkit: Removed the option.
1143
1144 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1145
1146         DumpRenderTree needs to run with Windows native controls on Windows
1147         https://bugs.webkit.org/show_bug.cgi?id=25592
1148
1149         Reviewed by Anders Carlsson.
1150
1151         * DumpRenderTree/win/DumpRenderTree.cpp:
1152         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1153         (prepareConsistentTestingEnvironment): Ditto.
1154
1155 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1156
1157         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1158         <http://webkit.org/b/140787>
1159
1160         Reviewed by Daniel Bates.
1161
1162         * Scripts/webkitpy/port/ios.py:
1163         (IOSPort.determine_full_port_name): Instead of checking the type
1164         of the current host, test if /usr/bin/xcrun exists before trying
1165         to use it.
1166
1167 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1168
1169         Fix the false positive build failures on the Windows buildbots
1170         https://bugs.webkit.org/show_bug.cgi?id=140819
1171
1172         Reviewed by Brent Fulgham.
1173
1174         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1175         the default 20 minutes is enough for others since they produce output during the build.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1178         (BuildFactory.__init__):
1179
1180 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1181
1182         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1183         https://bugs.webkit.org/show_bug.cgi?id=140839
1184
1185         Reviewed by Dean Jackson.
1186
1187         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1188         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1189         from the IA2Locale structure and pass it to DRT.
1190
1191 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1192
1193         [Win] Update DRT Accessibility implementation to better match Mac.
1194         https://bugs.webkit.org/show_bug.cgi?id=140830
1195
1196         Reviewed by Dean Jackson.
1197
1198         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1199         (AccessibilityUIElement::titleUIElement):
1200         (AccessibilityUIElement::parentElement):
1201         (convertToDRTLabel):
1202         (AccessibilityUIElement::role):
1203         (AccessibilityUIElement::title):
1204         (AccessibilityUIElement::description):
1205         (AccessibilityUIElement::stringValue):
1206         (AccessibilityUIElement::helpText):
1207         (AccessibilityUIElement::isFocused):
1208
1209 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1210
1211         REGRESSION: run-perf-tests --profiler= seems to have broken
1212         https://bugs.webkit.org/show_bug.cgi?id=113528
1213
1214         Reviewed by Daniel Bates.
1215
1216         The problem is that "perf --record" (or the equivalent call for
1217         other profilers) is never called whenever there is a wrapper
1218         option in the port. We should inject the profiler call first
1219         (should it exists) and then use the port wrapper.
1220
1221         * Scripts/webkitpy/port/driver.py:
1222         (Driver._command_wrapper):
1223         * Scripts/webkitpy/port/driver_unittest.py:
1224         (DriverTest.test_profiler_and_wrapper): New unit test.
1225
1226 2015-01-22  David Kilzer  <ddkilzer@apple.com>
1227
1228         configure-xcode-for-ios-development needs to import webkitdirs.pm
1229         <http://webkit.org/b/140704>
1230
1231         Fixes the following runtime error:
1232
1233             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
1234
1235         * Scripts/configure-xcode-for-ios-development: Add back code to
1236         import webkitdirs.pm for the exitStatus() method.  Not sure why
1237         I removed it before patch review.
1238
1239 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
1240
1241         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
1242         https://bugs.webkit.org/show_bug.cgi?id=140795
1243
1244         Reviewed by Jon Honeycutt.
1245
1246         * BuildSlaveSupport/build.webkit.org-config/config.json:
1247         r178847 accidentally remove the scheduler for this bot. Re-add it to the
1248         Yosemite scheduler.
1249
1250 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
1251
1252         [Win] Expose missing editing features through WebView interface
1253         https://bugs.webkit.org/show_bug.cgi?id=140773
1254         <rdar://problem/19565421>
1255
1256         Reviewed by Dean Jackson.
1257
1258         Connect the various WebView editing delegate methods to our
1259         test infrastructure. Also prefer _bstr_t to raw BSTR types
1260         to simplify life cycle management.
1261
1262         * DumpRenderTree/win/DumpRenderTree.cpp:
1263         (resetWebViewToConsistentStateBeforeTesting):
1264         * DumpRenderTree/win/EditingDelegate.cpp:
1265         (EditingDelegate::QueryInterface):
1266         (dumpPath):
1267         (dump):
1268         (EditingDelegate::shouldBeginEditingInDOMRange):
1269         (EditingDelegate::shouldEndEditingInDOMRange):
1270         (EditingDelegate::shouldInsertNode):
1271         (EditingDelegate::shouldInsertText):
1272         (EditingDelegate::shouldDeleteDOMRange):
1273         (EditingDelegate::shouldChangeSelectedDOMRange):
1274         (EditingDelegate::shouldApplyStyle):
1275         (EditingDelegate::shouldChangeTypingStyle):
1276         (EditingDelegate::doPlatformCommand):
1277         (EditingDelegate::webViewDidBeginEditing):
1278         (EditingDelegate::webViewDidChange):
1279         (EditingDelegate::webViewDidEndEditing):
1280         (EditingDelegate::webViewDidChangeTypingStyle):
1281         (EditingDelegate::webViewDidChangeSelection):
1282         (EditingDelegate::checkSpellingOfString):
1283         (EditingDelegate::onNotify):
1284         * DumpRenderTree/win/EditingDelegate.h:
1285
1286 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1287
1288         Add a build flag for ES6 class syntax
1289         https://bugs.webkit.org/show_bug.cgi?id=140760
1290
1291         Reviewed by Michael Saboff.
1292
1293         * Scripts/webkitperl/FeatureList.pm:
1294
1295 2015-01-22  Daniel Bates  <dabates@apple.com>
1296
1297         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
1298         runtime in simctl output
1299         https://bugs.webkit.org/show_bug.cgi?id=140751
1300
1301         Reviewed by David Kilzer.
1302
1303         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
1304         with an error because it does not know how to parse the output of the simctl tool
1305         to identify an Apple Internal runtime.
1306
1307         * Scripts/webkitpy/xcode/simulator.py:
1308         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
1309         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
1310         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
1311         the runtime is an internal runtime.
1312         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
1313         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
1314         appropriate value.
1315         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
1316         it updates the appropriate Runtime object.
1317         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
1318         looking up a Runtime object for an internal runtime.
1319
1320 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
1321
1322         LeaksViewer doesn't show recent builds if there are less than 10
1323         https://bugs.webkit.org/show_bug.cgi?id=140716
1324
1325         Reviewed by Tim Horton.
1326
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1328
1329 2015-01-22  Lucas Forschler  <lforschler@apple.com>
1330
1331         Add Apple build slaves.
1332         Fixed text alignment for slave list.
1333         
1334         Unreviewed.
1335         
1336         * BuildSlaveSupport/build.webkit.org-config/config.json:
1337
1338 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1339
1340         Teach build.webkit.org about bot308 and bot309.
1341         
1342         Unreviewed.
1343         
1344         * BuildSlaveSupport/build.webkit.org-config/config.json:
1345
1346 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1347
1348         Add two Apple Mavericks slaves.
1349         
1350         Unreviewed.
1351         
1352         * BuildSlaveSupport/build.webkit.org-config/config.json:
1353
1354 2015-01-21  Daniel Bates  <dabates@apple.com>
1355
1356         Add iOS WebKit1 TestExpectation file
1357         https://bugs.webkit.org/show_bug.cgi?id=140739
1358
1359         Reviewed by David Kilzer.
1360
1361         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
1362         expectations in directory LayoutTests/platform/ios-simulator-wk1.
1363
1364         * Scripts/webkitpy/port/ios.py:
1365         (IOSSimulatorPort.default_baseline_search_path):
1366
1367 2015-01-21  David Kilzer  <ddkilzer@apple.com>
1368
1369         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
1370         <http://webkit.org/b/140704>
1371
1372         Reviewed by Daniel Bates.
1373
1374         * Scripts/configure-xcode-for-ios-development:
1375         - Update copyright.
1376         - Remove FIXME addressed by r178709.
1377         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
1378         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
1379         missing headers from iphonesimulator SDK to iphoneos SDK.
1380         (sdkDirectory): Add method that returns SDK directory.
1381         (sdkPlatformDirectory): Extract method from
1382         xcodeSDKSpecificationsPath() that returns SDK platform
1383         directory.
1384         (xcodeSDKSpecificationsPath): Update to use
1385         sdkPlatformDirectory().
1386
1387 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
1388
1389         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
1390         https://bugs.webkit.org/show_bug.cgi?id=140731
1391
1392         Reviewed by Tim Horton.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1395         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
1396
1397 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
1398
1399         [Win] eventSender does not support scalePageBy
1400         https://bugs.webkit.org/show_bug.cgi?id=140726
1401         <rdar://problem/19549865>
1402
1403         Reviewed by Dean Jackson.
1404
1405         * DumpRenderTree/win/EventSender.cpp:
1406         (scalePageByCallback): Provide implementation using new WebView method.
1407
1408 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1409
1410         Remove Apple Mountain Lion Build & Test slaves.
1411         
1412         Unreviewed.
1413
1414         * BuildSlaveSupport/build.webkit.org-config/config.json:
1415
1416 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1417
1418         Remove ENABLE(INSPECTOR) ifdef guards
1419         https://bugs.webkit.org/show_bug.cgi?id=140668
1420
1421         Reviewed by Darin Adler.
1422
1423         * DumpRenderTree/mac/TestRunnerMac.mm:
1424         (TestRunner::showWebInspector):
1425         (TestRunner::closeWebInspector):
1426         (TestRunner::evaluateInWebInspector):
1427         * Scripts/webkitperl/FeatureList.pm:
1428         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1429         (WTR::TestRunner::showWebInspector):
1430         (WTR::TestRunner::closeWebInspector):
1431         (WTR::TestRunner::evaluateInWebInspector):
1432         * WebKitTestRunner/TestInvocation.cpp:
1433         (WTR::TestInvocation::invoke):
1434
1435 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
1436
1437         Update build.webkit.org/dashboard to match current Mac queues.
1438
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
1442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1446         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
1447         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
1448
1449 2015-01-20  Lucas Forschler  <lforschler@apple.com>
1450
1451         Update Apple MountainLion Leaks slave to Yosemite
1452         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
1453         
1454         Unreviewed.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/config.json:
1457
1458 2015-01-20  Lucas Forschler  <lforschler@apple.com>
1459
1460         Update LeaksViewer from MountainLion to Yosemite
1461         
1462         Reviewed by Alexey Proskuryakov.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1465         (LeaksViewer._displayURLPrompt):
1466
1467 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
1468
1469         Fix EWS python unit tests and address code comments as per 140476
1470         https://bugs.webkit.org/show_bug.cgi?id=140637
1471
1472         Reviewed by David Kilzer.
1473
1474         * Scripts/webkitpy/port/base.py:
1475         (Port):
1476         (Port.__init__):
1477         Adds DEFAULT_ARCHITECTURE member.
1478         (Port.architecture):
1479         Removes architecture member and instead uses
1480         self.get_option('architecture'). Also removes redundant architecture
1481         method.
1482         (Port.set_architecture):
1483         Adds a setter for the architecture variable to be able to set a flag
1484         upon modification.
1485         (Port.test_configuration):
1486         Uses self.architecture() instead of self._architecture.
1487         * Scripts/webkitpy/port/ios.py:
1488         Overrides DEFAULT_ARCHITECTURE.
1489         (IOSPort):
1490         (IOSPort.determine_full_port_name):
1491         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
1492         strip. Fixes regex to not match arbitrary characters after the
1493         relevent digits are matched.
1494         (IOSPort.__init__):
1495         Removes old _architecture defaulting strategy.
1496         (IOSPort._build_driver_flags):
1497         Uses self.architecture() instead of self._architecture.
1498         (IOSSimulatorPort):
1499         Overrides DEFAULT_ARCHITECTURE.
1500         (IOSSimulatorPort.__init__):
1501         Removes old _architecture defaulting strategy.
1502         * Scripts/webkitpy/port/mac.py:
1503         (MacPort):
1504         Overrides DEFAULT_ARCHITECTURE.
1505         (MacPort.__init__):
1506         Removes old _architecture defaulting strategy.
1507         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1508         (AbstractEarlyWarningSystem.run_command):
1509         Checks the did_override_architecture flag to determine whether to add
1510         the --architecture option.
1511         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1512         Uses ews.architecture rather than trying to discern the correct
1513         architecture using a port object.
1514         (EarlyWarningSystemTest._default_expected_logs):
1515         * Scripts/webkitpy/tool/commands/queues.py:
1516         Removes use of optparse, and removes the import statement.
1517         (AbstractQueue.__init__):
1518         (PatchProcessingQueue.begin_work_queue):
1519
1520 2015-01-20  Sam Weinig  <sam@webkit.org>
1521
1522         Attempt to fix Mountain Lion and EFL tests.
1523
1524         * WebKitTestRunner/TestController.cpp:
1525         (WTR::TestController::initialize):
1526         Disable Process-per-tab and network process on Mountain Lion and EFL.
1527
1528 2015-01-20  Darin Adler  <darin@apple.com>
1529
1530         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
1531         https://bugs.webkit.org/show_bug.cgi?id=140679
1532
1533         Reviewed by Anders Carlsson.
1534
1535         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1536         Removed a reference to SVGElementInstanceList.
1537
1538 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1539
1540         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
1541         https://bugs.webkit.org/show_bug.cgi?id=140028
1542
1543         Reviewed by Carlos Garcia Campos.
1544
1545         This won't work as expected, since this function is called before the
1546         WebViewTest constructor completes.
1547
1548         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1549
1550 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1551
1552         configure-xcode-for-ios-development needs to update iPhoneOS SDK
1553         <http://webkit.org/b/140661>
1554
1555         Reviewed by Daniel Bates.
1556
1557         * Scripts/configure-xcode-for-ios-development: Add for() loop to
1558         run createXcodeSpecificationFilesForSDKIfNeeded() for both
1559         "iphoneos" and "iphonesimulator" SDKs.
1560         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
1561         the main body of the script.
1562
1563 2015-01-20  Tomas Popela  <tpopela@redhat.com>
1564
1565         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
1566         https://bugs.webkit.org/show_bug.cgi?id=139443
1567
1568         Reviewed by Carlos Garcia Campos.
1569
1570         Create the new test cases for setting the editable property on the web
1571         view and on the contenteditable enabled document. Also rework the
1572         current tests that are expecting that the web view is editable.
1573
1574         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1575         (loadTestHtml):
1576         (testWebViewEditorCutCopyPasteNonEditable):
1577         (testWebViewEditorCutCopyPasteEditable):
1578         (testWebViewEditorSelectAllNonEditable):
1579         (testWebViewEditorSelectAllEditable):
1580         (runEditorEditableCutTests):
1581         (testWebViewEditorEditableOnNonEditable):
1582         (testWebViewEditorEditableOnContentEditable):
1583         (testWebViewEditorNonEditable):
1584         (beforeAll):
1585         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1586         (WebViewTest::isEditable):
1587         (WebViewTest::setEditable):
1588
1589 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1590
1591         [GTK] Add an option to create WebKitWebView snapshots with transparent background
1592         https://bugs.webkit.org/show_bug.cgi?id=140617
1593
1594         Reviewed by Gustavo Noronha Silva.
1595
1596         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1597         (testWebViewSnapshot): Check that the same snapshot with
1598         transparent background is different than the default one filled
1599         with white.
1600
1601 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1602
1603         [GTK] Add API to change the WebKitWebView background color
1604         https://bugs.webkit.org/show_bug.cgi?id=140610
1605
1606         Reviewed by Gustavo Noronha Silva.
1607
1608         Add --bg-color command line option to MiniBrowser to be able to
1609         manually test the API passing any RGBA color to MiniBrowser.
1610         Also add a simple unit test to check that getting and setting
1611         colors from the API point of view.
1612
1613         * MiniBrowser/gtk/BrowserWindow.c:
1614         (browser_window_set_background_color):
1615         * MiniBrowser/gtk/BrowserWindow.h:
1616         * MiniBrowser/gtk/main.c:
1617         (createBrowserWindow):
1618         (parseBackgroundColor):
1619         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1620         (testWebViewBackgroundColor):
1621         (beforeAll):
1622
1623 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
1624
1625         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
1626         https://bugs.webkit.org/show_bug.cgi?id=140665
1627
1628         Reviewed by Brian Burg.
1629
1630         * DumpRenderTree/win/UIDelegate.cpp:
1631         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
1632         match expected test output.
1633
1634 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
1635
1636         Remove the support for custom suffixes on ChangeLog
1637         https://bugs.webkit.org/show_bug.cgi?id=140648
1638
1639         Reviewed by David Kilzer.
1640
1641         Custom suffixes were used for the iOS branch of WebKit.
1642         Now that everything is opensource, there is no need for it.
1643
1644         * Scripts/VCSUtils.pm:
1645         (changeLogSuffix): Deleted.
1646         (changeLogFileName): Deleted.
1647         * Scripts/commit-log-editor:
1648         * Scripts/prepare-ChangeLog:
1649         (getLatestChangeLogs):
1650         (generateNewChangeLogs):
1651         (generateFileList):
1652         * Scripts/resolve-ChangeLogs:
1653         (findChangeLog):
1654
1655 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1656
1657         Adjust naming of action menu SPI
1658         https://bugs.webkit.org/show_bug.cgi?id=140644
1659         <rdar://problem/19448129>
1660
1661         Reviewed by Brian Weinstein.
1662
1663         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1664         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
1665         (TestWebKitAPI::TEST):
1666
1667 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1668
1669         [GTK] Generate the make dist manifest from a CMake template file
1670         https://bugs.webkit.org/show_bug.cgi?id=139387
1671
1672         Reviewed by Martin Robinson.
1673
1674         Remove the code that performs variable substitution on manifest.txt.
1675         Replace the custom variables used in that file with CMake variables.
1676
1677         * gtk/make-dist.py:
1678         (Manifest.add_directory):
1679         (Manifest.get_full_source_path):
1680         (Manifest.process_line):
1681         (Manifest.resolve_variables): Deleted.
1682         (Manifest.get_full_tarball_path): Deleted.
1683         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
1684
1685 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
1686
1687         [Win] Correct merge error in last commit.
1688
1689         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1690         (findAccessibleObjectById): Undo accidental paste made during landing.
1691
1692 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
1693
1694         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
1695         https://bugs.webkit.org/show_bug.cgi?id=139906
1696
1697         Reviewed by Dean Jackson.
1698
1699         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
1700         to use them. This patch fixes that.
1701
1702         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1703         (findAccessibleObjectById):
1704         (AccessibilityController::focusedElement):
1705         (logEventProc):
1706         (notificationListenerProc):
1707         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1708         (AccessibilityUIElement::getChildAtIndex):
1709         (AccessibilityUIElement::titleUIElement):
1710         (self):
1711         (AccessibilityUIElement::role):
1712         (AccessibilityUIElement::valueDescription):
1713         (accessibilityState):
1714         (AccessibilityUIElement::isChecked):
1715         * DumpRenderTree/win/DumpRenderTree.cpp:
1716         (dumpFrameScrollPosition):
1717         (dumpFramesAsText):
1718         * DumpRenderTree/win/PolicyDelegate.cpp:
1719         (PolicyDelegate::decidePolicyForNavigationAction):
1720         * DumpRenderTree/win/UIDelegate.cpp:
1721         (UIDelegate::exceededDatabaseQuota):
1722         * WinLauncher/Common.cpp:
1723         (setWindowText):
1724
1725 2015-01-19  Dean Jackson  <dino@apple.com>
1726
1727         Add "override" to fix the build with newer clangs.
1728
1729         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1730         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
1731
1732 2015-01-19  David Kilzer  <ddkilzer@apple.com>
1733
1734         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
1735         <http://webkit.org/b/140623>
1736
1737         Reviewed by Daniel Bates.
1738
1739         * Scripts/build-webkit: Update help for --device switch.
1740         * Scripts/webkitdirs.pm:
1741         (determineXcodeSDK): When passing --device, prefer the internal
1742         iOS SDK if it exists, else fall back to the external iOS SDK.
1743         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
1744         xcodebuild instead of trying to sanitize values.
1745
1746 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
1747
1748         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
1749         https://bugs.webkit.org/show_bug.cgi?id=140606
1750
1751         Reviewed by Csaba Osztrogonác.
1752
1753         * Scripts/webkitpy/bindings/main.py:
1754         (BindingsTests.generate_supplemental_dependency):
1755         (BindingsTests.main):
1756
1757 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1758
1759         [GTK] [WK2] TestWebKitWebView snapshot fails
1760         https://bugs.webkit.org/show_bug.cgi?id=120404
1761
1762         Reviewed by Žan Doberšek.
1763
1764         Rework the test to make sure the snapshot is always created at the
1765         desired size.
1766
1767         * Scripts/run-gtk-tests:
1768         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
1769         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1770         (testWebViewSnapshot): Use a fixed size for the document, and
1771         disable scrollbars to make sure the visible area is always the
1772         WebView size.
1773         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1774         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
1775         and height parameters to create the window with a given size.
1776         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1777
1778 2015-01-18  David Kilzer  <ddkilzer@apple.com>
1779
1780         iOS EWS queue name should be consistent
1781         <http://webkit.org/b/140585>
1782
1783         Reviewed by Daniel Bates.
1784
1785         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
1786         to 'ios'.
1787         * Scripts/webkitpy/common/config/ports.py: Ditto.
1788         (DeprecatedPort.port):
1789         (IOSPort):
1790         * Scripts/webkitpy/port/ios.py: Ditto.
1791         (IOSPort):
1792
1793         * Scripts/webkitpy/port/factory.py:
1794         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
1795         appears before ios.IOSPort.  If this is not done,
1796         `run-webkit-tests --ios-simulator` will get the wrong Port class
1797         (IOSPort instead of IOSSimulatorPort) due to the way that
1798         PortFactory.get() uses prefix matching of <Port>.port_name to
1799         find the correct class to use.
1800
1801 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
1802
1803         build.webkit.org/dashboard: OS X EWS is now on Mavericks
1804         https://bugs.webkit.org/show_bug.cgi?id=140595
1805
1806         Reviewed by Csaba Osztrogonác.
1807
1808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1809         (BubbleQueueServer):
1810
1811 2015-01-17  David Kilzer  <ddkilzer@apple.com>
1812
1813         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
1814
1815         * Scripts/webkitpy/port/ios.py:
1816         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
1817         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
1818         the Mountain Lion and Mavericks bots.
1819
1820 2015-01-17  David Kilzer  <ddkilzer@apple.com>
1821
1822         Attempt to fix webkitpy tests on GTK Linux ports
1823
1824         * Scripts/webkitpy/port/ios.py:
1825         (IOSPort.determine_full_port_name): Set a sensible default if
1826         not running on a Mac platform or if no iOS SDK is installed.
1827
1828 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
1829
1830         Create iOS-EWS client queue
1831         https://bugs.webkit.org/show_bug.cgi?id=140476
1832
1833         Reviewed by Alexey Proskuryakov.
1834
1835         * EWSTools/start-queue-mac.sh:
1836         Adds call to configure-xcode-for-ios-development for iOS EWS.
1837         * Scripts/webkitpy/common/config/ews.json:
1838         Adds the iOS EWS config entry.
1839         * Scripts/webkitpy/common/config/ports.py:
1840         (DeprecatedPort.port):
1841         Adds IOSPort to the port map.
1842         (IOSPort):
1843         (IOSPort.build_webkit_command):
1844         Adds --sdk=iphoneos to the webkit build command.
1845         * Scripts/webkitpy/port/base.py:
1846         (Port.architecture):
1847         Adds an accessor for the architecture member variable.
1848         * Scripts/webkitpy/port/factory.py:
1849         (PortFactory):
1850         Adds IOSPort to the port class list.
1851         * Scripts/webkitpy/port/ios.py:
1852         Adds the IOSPort to encapsulate iOS-specific things.
1853         (IOSPort):
1854         (IOSPort.determine_full_port_name):
1855         (IOSPort.__init__):
1856         (IOSPort._build_driver_flags):
1857         (IOSPort.operating_system):
1858         * Scripts/webkitpy/tool/commands/download_unittest.py:
1859         Adds the archetecture option to the mock options.
1860         (DownloadCommandsTest._default_options):
1861         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1862         Appends the archetecture option into calls to webkit-patch.
1863         (AbstractEarlyWarningSystem.review_patch):
1864         (AbstractEarlyWarningSystem.run_command):
1865         (AbstractEarlyWarningSystem.load_ews_classes):
1866         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1867         Adds logic to soothe the unittest now that --architecture is being
1868         thrown around everywhere.
1869         (EarlyWarningSystemTest._default_expected_logs):
1870         * Scripts/webkitpy/tool/commands/queues.py:
1871         Adds glue code to ferry the --architecture option around.
1872         (AbstractQueue.__init__):
1873         (PatchProcessingQueue.begin_work_queue):
1874         * Scripts/webkitpy/tool/steps/abstractstep.py:
1875         Adds the archetecture option to all AbstractSteps so that
1876         EarlyWarningSystem doesn't start shoving --architecture into
1877         unsuspecting commands.
1878         (AbstractStep.options):
1879         * Scripts/webkitpy/tool/steps/build.py:
1880         Translates the --architecture option into an ARCHS= format to pass to
1881         build-webkit.
1882         (Build.build):
1883         * Scripts/webkitpy/tool/steps/options.py:
1884         Adds a definition for the --architecture option.
1885         (Options):
1886
1887 2015-01-16  Sam Weinig  <sam@webkit.org>
1888
1889         Add a basic configuration object for WKView
1890         https://bugs.webkit.org/show_bug.cgi?id=140559
1891
1892         Reviewed by Anders Carlsson.
1893
1894         Add tests for WKPageConfigurationRef.
1895
1896         * TestWebKitAPI/PlatformWebView.h:
1897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1898         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
1899         (TestWebKitAPI::TEST):
1900         (TestWebKitAPI::didFinishLoadForFrame):
1901         (TestWebKitAPI::setPageLoaderClient):
1902         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1903         (TestWebKitAPI::PlatformWebView::initialize):
1904         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1905
1906 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
1907
1908         WeakPtr functions crash when created with default constructor
1909         https://bugs.webkit.org/show_bug.cgi?id=140479
1910
1911         Reviewed by Andreas Kling.
1912
1913         Add WeakPtr API tests.
1914
1915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1916         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
1917         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
1918
1919 2015-01-16  Chris Dumez  <cdumez@apple.com>
1920
1921         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
1922         https://bugs.webkit.org/show_bug.cgi?id=140568
1923
1924         Reviewed by Alexey Proskuryakov.
1925
1926         Fix the script parsing CSSPropertyNames.in to stop splitting lines
1927         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
1928         e.g. "Longhands=background-position-x|background-position-y".
1929         This would confuse the script and treat this as a CSS property:
1930         "background-position-x|background-position-y".
1931
1932         We now split on white space and treat the first string on the line
1933         to be the property name (this is the syntax in this file).
1934
1935         * Scripts/webkitpy/w3c/test_converter.py:
1936         (_W3CTestConverter.__init__):
1937         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1938
1939 2015-01-16  Daniel Bates  <dabates@apple.com>
1940
1941         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
1942         https://bugs.webkit.org/show_bug.cgi?id=135589
1943
1944         Reviewed by David Kilzer.
1945
1946         Derived from a patch by David Farler.
1947
1948         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
1949         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
1950         in terms of the simctl command line utility.
1951
1952         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
1953         (eraseIOSSimulatorDevice): Added.
1954         (bootedIOSSimulatorDevice): Added.
1955         (iosSimulatorApplicationsPath): Added.
1956         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
1957         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
1958         (quitIOSSimulator): Added.
1959         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
1960         the specified name and currently selected iOS runtime.
1961         (isIOSSimulatorSystemInstalledApp): Added.
1962         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
1963         (deleteiOSSimulatorDevice): Deleted.
1964         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
1965         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
1966
1967 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
1968
1969         Resurrect the WinCairo bot.
1970         https://bugs.webkit.org/show_bug.cgi?id=139908
1971
1972         Reviewed by Csaba Osztrogonác.
1973
1974         * BuildSlaveSupport/build.webkit.org-config/config.json:
1975         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1976         (appendCustomBuildFlags):
1977         * BuildSlaveSupport/test-result-archive:
1978         (archiveTestResults):
1979         Add WinCairo buildbot.
1980
1981 2015-01-16  Chris Dumez  <cdumez@apple.com>
1982
1983         webkit-patch should auto-install the keyring python module
1984         https://bugs.webkit.org/show_bug.cgi?id=140547
1985
1986         Reviewed by David Kilzer.
1987
1988         Auto-install the keyring python module. This is the module that
1989         webkit-patch uses for cross-platform access to the keyring
1990         service.
1991
1992         Without this module, if the password if not in the keychain,
1993         webkit-patch will keep asking for your username / password and
1994         never remember them.
1995
1996         * Scripts/webkitpy/common/net/credentials.py:
1997         * Scripts/webkitpy/thirdparty/__init__.py:
1998         (AutoinstallImportHook.find_module):
1999         (AutoinstallImportHook._install_keyring):
2000
2001 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2002
2003         Remove ENABLE(SQL_DATABASE) guards
2004         https://bugs.webkit.org/show_bug.cgi?id=140434
2005
2006         Reviewed by Darin Adler.
2007
2008         * Scripts/webkitperl/FeatureList.pm:
2009
2010 2015-01-15  Daniel Bates  <dabates@apple.com>
2011
2012         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2013         https://bugs.webkit.org/show_bug.cgi?id=139685
2014         <rdar://problem/19281317>
2015
2016         Reviewed by Simon Fraser.
2017
2018         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2019         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2020
2021         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2022         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2023         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2024         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2025         dumping the test result again. Instead we want DRT to dump the test result synchronously
2026         such that we capture the state of the web page either when the page is loaded or when
2027         window.testRunner.notifyDone() is called.
2028
2029         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2030         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2031         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2032         flush CA transactions to the window.
2033         * DumpRenderTree/mac/DumpRenderTree.mm:
2034         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2035         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2036         (dump): Renamed; formerly named dumpTestResults().
2037         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2038         enabling repaint support on iOS.
2039         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2040         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2041         (dumpTestResults): Deleted.
2042
2043 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2044
2045         [Win] Miscellaneous DRT fixes
2046         https://bugs.webkit.org/show_bug.cgi?id=116562
2047
2048         Reviewed by Tim Horton.
2049
2050         While investigating the cause of several Windows crashes, I found:
2051         (1) Messy conversions to and from BSTR types
2052         (2) Weird mixes of wide-string and narrow string conversions
2053         (3) Passing nullptr to some CoreFoundation routines that do not
2054             permit null arguments.
2055         (4) Commands to link the executable to the VS2005 runtime.
2056
2057         This patch cleans up these issues to improve DRT reliability on
2058         Windows.
2059
2060         * DumpRenderTree/cg/ImageDiffCG.cpp:
2061         (main): Get rid of VS2005 runtime linking.
2062         * DumpRenderTree/win/DumpRenderTree.cpp:
2063         (urlSuitableForTestResult): Protect against being asked
2064         to process an empty URL.
2065         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2066         than converting to/from wchar_t buffers.
2067         (runTest): Simplify string and BSTR handling.
2068         (createWebViewAndOffscreenWindow): Ditto.
2069         (main): Get rid of VS2005 runtime linking.
2070         * DumpRenderTree/win/TestRunnerWin.cpp:
2071         (jsStringRefToWString): Simplify code.
2072         (TestRunner::pathToLocalResource):
2073         (TestRunner::setUserStyleSheetLocation):
2074         * TestWebKitAPI/win/main.cpp: Get rid of
2075         VS2005 runtime linking.
2076         * win/DLLLauncher/DLLLauncherMain.cpp:
2077         (wWinMain): Ditto.
2078
2079 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2080
2081         Stop hardcoding mac-mountainlion in commit queue
2082         https://bugs.webkit.org/show_bug.cgi?id=140492
2083
2084         Reviewed by Anders Carlsson.
2085
2086         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2087         there should be no change in behavior, because:
2088         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2089         using it to create a port object.
2090         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2091         is actually correct to use "mac" for the name there. We only used to get the expected
2092         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2093         for unknown deprecated port names.
2094
2095         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2096
2097 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2098
2099         Create iOS-EWS server queue
2100         https://bugs.webkit.org/show_bug.cgi?id=140473
2101
2102         Reviewed by Benjamin Poulain.
2103
2104         * QueueStatusServer/app.yaml: Updates the SVN version number.
2105         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2106         * QueueStatusServer/model/queues.py:         
2107         (Queue.display_name): Makes sure the display name is pretty!
2108
2109 2015-01-14  Daniel Bates  <dabates@apple.com>
2110
2111         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2112         https://bugs.webkit.org/show_bug.cgi?id=140301
2113         <rdar://problem/19389266>
2114
2115         Reviewed by Jon Honeycutt.
2116
2117         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2118         with an unavailable runtime.
2119
2120         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2121         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2122         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2123         specified runtime cannot be used because it is unavailable.
2124         * Scripts/webkitpy/port/ios.py:
2125         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2126         which was formerly named testing_device.
2127         * Scripts/webkitpy/xcode/simulator.py:
2128         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2129         more robust than looking up the simulator device by name and runtime. This approach also
2130         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2131         unavailable runtimes under the same iOS heading it would use to show it as available).
2132         (Simulator.find_device_by_udid): Added.
2133         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2134         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2135         (Simulator.available_runtimes): Added.
2136         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2137         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2138         first element of the sorted list is the runtime with the highest version number.
2139         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2140
2141 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2142
2143         Remove WK2 Windows cruft
2144         https://bugs.webkit.org/show_bug.cgi?id=140440
2145
2146         Reviewed by Anders Carlsson.
2147
2148         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2149         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2150         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2151
2152 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2153
2154         Fix TestWTF failed in TestWebKitAPI
2155         https://bugs.webkit.org/show_bug.cgi?id=140333
2156
2157         Reviewed by Sam Weinig.
2158
2159         Clear the std::ostringstream before starting test.
2160
2161         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2162         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2163
2164 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2165
2166         TestWebKitWebContext depends on British English spellcheck dictionary
2167         https://bugs.webkit.org/show_bug.cgi?id=140403
2168
2169         Reviewed by Martin Robinson.
2170
2171         Install all English hunspell dictionaries on Fedora and Arch.
2172
2173         * gtk/install-dependencies:
2174
2175 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2176
2177         [GTK] install-dependencies should grok dnf
2178         https://bugs.webkit.org/show_bug.cgi?id=140396
2179
2180         Reviewed by Martin Robinson.
2181
2182         Fedora: install dependencies with dnf if yum is not installed.
2183
2184         * gtk/install-dependencies:
2185
2186 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2187
2188         [EFL][GTK] Fix build after r178309  
2189         https://bugs.webkit.org/show_bug.cgi?id=140381
2190
2191         Reviewed by Gyuyoung Kim.
2192
2193         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2194
2195 2015-01-11  Sam Weinig  <sam@webkit.org>
2196
2197         Remove support for SharedWorkers
2198         https://bugs.webkit.org/show_bug.cgi?id=140344
2199
2200         Reviewed by Anders Carlsson.
2201
2202         * Scripts/webkitperl/FeatureList.pm:
2203
2204 2015-01-12  Anders Carlsson  <andersca@apple.com>
2205
2206         Make delegates conform to formal delegate protocols
2207         https://bugs.webkit.org/show_bug.cgi?id=140370
2208
2209         Reviewed by Dan Bernstein.
2210
2211         * DumpRenderTree/mac/TestRunnerMac.mm:
2212         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2213         (TestRunner::setGeolocationPermission):
2214
2215 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2216
2217         build-webkit: silence output of 'which'
2218         https://bugs.webkit.org/show_bug.cgi?id=140278
2219
2220         Reviewed by Daniel Bates.
2221
2222         Use a more elegent test for the existance of ninja and eclipse.
2223
2224         * Scripts/webkitdirs.pm:
2225         (commandExists): Don't assume the command supports --version
2226         (canUseNinja): Use commandExists()
2227         (canUseEclipse): Use commandExists()
2228
2229 2015-01-09  Sam Weinig  <sam@webkit.org>
2230
2231         Update the output format for run-api-tests
2232         https://bugs.webkit.org/show_bug.cgi?id=140332
2233
2234         Reviewed by Dan Bernstein.
2235
2236         Changes the output format for run-api-tests be a bit simpler (no longer 
2237         indented based on suite, as we were not really using suite very well) but
2238         also include details in the case of failure.
2239
2240         Changes verbose mode to no longer spew out the gtest default printer output,
2241         as the custom printer now includes the failure information.
2242
2243         * Scripts/run-api-tests:
2244         (runTestsBySuite):
2245         (runTest):
2246         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
2247         with colorized variants and strip out leaks spew (the leaks can be added back using
2248         the new --show-leaks argument).
2249
2250         * TestWebKitAPI/TestsController.cpp:
2251         (TestWebKitAPI::Printer::OnTestPartResult):
2252         (TestWebKitAPI::Printer::OnTestEnd):
2253         (TestWebKitAPI::TestsController::run):
2254         Implement a custom result printer that just prints out the information we want.
2255
2256 2015-01-09  Sam Weinig  <sam@webkit.org>
2257
2258         TestWebKitAPI should print out the lists that fail at the end
2259         https://bugs.webkit.org/show_bug.cgi?id=140329
2260
2261         Reviewed by Tim Horton.
2262
2263         * Scripts/run-api-tests:
2264         (runTestsBySuite):
2265         Print out failures and timeouts in all modes, not just verbose.
2266
2267 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
2268
2269         Make bmalloc work with ASan
2270         https://bugs.webkit.org/show_bug.cgi?id=140194
2271
2272         Reviewed by Mark Lam.
2273
2274         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
2275         ASan automatically (by forwarding to system malloc at runtime).
2276
2277 2015-01-09  Daniel Bates  <dabates@apple.com>
2278
2279         [iOS] Make DumpRenderTree build with public SDK
2280         https://bugs.webkit.org/show_bug.cgi?id=140311
2281
2282         Reviewed by Sam Weinig.
2283
2284         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
2285         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
2286         Additionally, remove unused header CoreGraphics/CGFontDB.h.
2287
2288         * DumpRenderTree/mac/DumpRenderTree.mm:
2289         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
2290
2291 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
2292
2293         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
2294         https://bugs.webkit.org/show_bug.cgi?id=140300
2295
2296         Reviewed by Simon Fraser.
2297
2298         * WebKitTestRunner/TestController.cpp:
2299         (WTR::TestController::createOtherPage):
2300         (WTR::TestController::updateWindowScaleForTest):
2301         (WTR::TestController::configureViewForTest):
2302         * WebKitTestRunner/TestController.h:
2303
2304 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2305
2306         Unreviewed. Moving myself to the committer section.
2307
2308         * Scripts/webkitpy/common/config/contributors.json:
2309
2310 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2311
2312         Add a script to check for platform layering violations
2313         https://bugs.webkit.org/show_bug.cgi?id=140248
2314
2315         Reviewed by Darin Adler.
2316
2317         It prints all the cases where files inside platform include
2318         headers that are not in platform directory.
2319
2320         * Scripts/check-for-platform-layering-violations: Added.
2321         (get_platform_headers):
2322         (check_source_file):
2323
2324 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2325
2326         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
2327         https://bugs.webkit.org/show_bug.cgi?id=139884
2328
2329         Reviewed by Tim Horton.
2330
2331         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2332         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
2333         what the "nominal resolution" is, but this appears to work in practice.
2334
2335 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
2336
2337         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
2338         https://bugs.webkit.org/show_bug.cgi?id=140256
2339
2340         Reviewed by Anders Carlsson.
2341
2342         * DumpRenderTree/win/DumpRenderTree.cpp:
2343         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
2344         running with heap validation checks.
2345         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
2346         the "svg\\W3C-SVG-1.1" test directory.
2347         (removeFontFallbackIfPresent): Use nullptr instead of 0.
2348         * DumpRenderTree/win/TestRunnerWin.cpp:
2349         (TestRunner::clearPersistentUserStyleSheet): Ditto.
2350
2351 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2352
2353         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2354         https://bugs.webkit.org/show_bug.cgi?id=140218
2355
2356         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
2357         Undone an accidental change - check for self.has_crashed() again. This code path
2358         is for ports that don't have a signal handler printing #CRASHED when main process
2359         crashes.
2360
2361         * Scripts/webkitpy/port/driver_unittest.py:
2362         (DriverTest.test_check_for_driver_crash.assert_crash):
2363         (DriverTest.test_check_for_driver_crash):
2364         Updated the tests, all changes are expected.
2365
2366 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2367
2368         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2369         https://bugs.webkit.org/show_bug.cgi?id=140218
2370
2371         Reviewed by Darin Adler.
2372
2373         * Scripts/webkitpy/port/driver.py:
2374         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
2375         "process crashed" condition. These don't make sense together - it's either a crash
2376         or a timeout, and we should detect those properly at a much lower level.
2377         (Driver.run_test): Ditto.
2378         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
2379         cases.
2380
2381         * WebKitTestRunner/TestController.h:
2382         * WebKitTestRunner/TestController.cpp:
2383         (WTR::TestController::webProcessName): 
2384         (WTR::TestController::processDidCrash):
2385         Factored out hardcoded child process names, as we now use these in two places.
2386
2387         * WebKitTestRunner/TestInvocation.cpp:
2388         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
2389         process name, so that it can be sampled (fixes sampling on Mavericks and above).
2390
2391 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
2392
2393         Reorder my list of email addresses, keeping the Bugzilla address at the
2394         top since Bugzilla and other webkitpy scripts rely on that ordering.
2395
2396         * Scripts/webkitpy/common/config/contributors.json:
2397
2398 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
2399
2400         Moving myself to the reviewers section and updating
2401         the list of my email addresses.
2402
2403         * Scripts/webkitpy/common/config/contributors.json:
2404
2405 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2406
2407         [GTK] Build gtk-doc without gtkdoc-mktmpl
2408         https://bugs.webkit.org/show_bug.cgi?id=140225
2409
2410         Reviewed by Darin Adler.
2411
2412         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
2413         don't modify the tmpl files that it generates, it's not doing anything
2414         for us.
2415
2416         * gtk/gtkdoc.py:
2417         (GTKDoc.generate):
2418         (GTKDoc._run_gtkdoc_scangobj):
2419         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
2420
2421 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
2422
2423         [GTK][ThreadedCompositor] Add support for threaded compositor.
2424         https://bugs.webkit.org/show_bug.cgi?id=118265
2425
2426         Reviewed by Martin Robinson.
2427
2428         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
2429         autotools build systems. The feature is disabled by default.
2430         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
2431         from the feature flags.
2432
2433         * Scripts/webkitperl/FeatureList.pm:
2434
2435 2015-01-07  Daniel Bates  <dabates@apple.com>
2436
2437         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2438         https://bugs.webkit.org/show_bug.cgi?id=137371
2439
2440         Reviewed by David Kilzer.
2441
2442         Use SPI wrapper headers instead of directly referencing private SPI headers.
2443
2444         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2445         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2446         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
2447         to the list of iOS header search directories so that we can include header UIKitSPI.h.
2448         * DumpRenderTree/mac/DumpRenderTree.mm:
2449         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2450         * DumpRenderTree/mac/EventSendingController.mm:
2451         * DumpRenderTree/mac/TestRunnerMac.mm:
2452
2453 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2454
2455         Unreviewed, rolling out r178068.
2456         https://bugs.webkit.org/show_bug.cgi?id=140235
2457
2458         Breaks the iOS build (Requested by enrica on #webkit).
2459
2460         Reverted changeset:
2461
2462         "[iOS] Make WebKit2 build with public iOS SDK and more build
2463         fixes for DRT"
2464         https://bugs.webkit.org/show_bug.cgi?id=137371
2465         http://trac.webkit.org/changeset/178068
2466
2467 2015-01-07  Daniel Bates  <dabates@apple.com>
2468
2469         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2470         https://bugs.webkit.org/show_bug.cgi?id=137371
2471
2472         Reviewed by David Kilzer.
2473
2474         Use SPI wrapper headers instead of directly referencing private SPI headers.
2475
2476         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2477         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2478         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
2479         to the list of header search directories so that we can include header UIKitSPI.h.
2480         * DumpRenderTree/mac/DumpRenderTree.mm:
2481         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2482         * DumpRenderTree/mac/EventSendingController.mm:
2483         * DumpRenderTree/mac/TestRunnerMac.mm:
2484
2485 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
2486
2487         [Win] Unreviewed test change to improve run reproducibility
2488
2489         * Scripts/webkitpy/port/win.py:
2490         (WinPort.default_child_processes): Run a single DRT instance to help
2491         identify failures caused by earlier test runs.
2492
2493 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
2494
2495         Myles C. Maxfield is a reviewer now
2496         https://bugs.webkit.org/show_bug.cgi?id=140196
2497
2498         Reviewed by Dean Jackson.
2499
2500         * Scripts/webkitpy/common/config/contributors.json:
2501
2502 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
2503
2504         Make webkit-patch try harder to find keychain credentials
2505         https://bugs.webkit.org/show_bug.cgi?id=140170
2506
2507         Reviewed by Ryosuke Niwa.
2508
2509         When the user manually enters a password into webkit-patch, we hand that off to the
2510         Keyring Python module. However, that module creates a generic password entry instead
2511         of an internet password entry. We should look for both kinds.
2512
2513         * Scripts/webkitpy/common/net/credentials.py:
2514         (Credentials._run_security_tool):
2515         (Credentials._credentials_from_keychain):
2516         * Scripts/webkitpy/common/net/credentials_unittest.py:
2517         (test_security_output_parse_entry_not_found):
2518         (_assert_security_call):
2519
2520 2015-01-06  Anders Carlsson  <andersca@apple.com>
2521
2522         Try to fix the Mountain Lion build.
2523
2524         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2525         (TestWebKitAPI::didGetImageForMatchResult):
2526
2527 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
2528
2529         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
2530         https://bugs.webkit.org/show_bug.cgi?id=140095
2531
2532         Reviewed by Anders Carlsson.
2533
2534         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
2535         builds, but not in debug ones.
2536
2537 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
2538
2539         [Win] Extend WinLauncher with support for Page Zoom
2540         https://bugs.webkit.org/show_bug.cgi?id=140152
2541
2542         Reviewed by Anders Carlsson.
2543
2544         * WinLauncher/Common.cpp:
2545         (WndProc):
2546         * WinLauncher/WinLauncher.cpp:
2547         (WinLauncher::resetZoom):
2548         (WinLauncher::zoomIn):
2549         (WinLauncher::zoomOut):
2550         * WinLauncher/WinLauncher.h:
2551         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
2552         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2553         * win/DLLLauncher/DLLLauncherMain.cpp:
2554         (wWinMain):
2555
2556 2015-01-06  Anders Carlsson  <andersca@apple.com>
2557
2558         Fix API tests that are broken under HiDPI
2559         https://bugs.webkit.org/show_bug.cgi?id=140146
2560
2561         Reviewed by Tim Horton.
2562
2563         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2564         (TestWebKitAPI::didGetImageForMatchResult):
2565         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
2566
2567         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2568         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
2569         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
2570         out in a window that has a backing scale factor of 1.
2571  
2572         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2573         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
2574         Ditto.
2575
2576 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
2577
2578         ADDRESS_SANITIZER macro is overloaded
2579         https://bugs.webkit.org/show_bug.cgi?id=140130
2580
2581         Reviewed by Anders Carlsson.
2582
2583         * WebKitTestRunner/TestController.cpp: Use the new macro.
2584
2585 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
2586
2587         Remove some stale class names in check-for-inappropriate-objc-class-names
2588         https://bugs.webkit.org/show_bug.cgi?id=140104
2589
2590         Reviewed by Darin Adler.
2591
2592         * Scripts/check-for-inappropriate-objc-class-names:
2593         These UIWK* classes no longer exist.
2594
2595 2015-01-05  Anders Carlsson  <andersca@apple.com>
2596
2597         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
2598         https://bugs.webkit.org/show_bug.cgi?id=140096
2599         rdar://problem/19368938
2600
2601         Reviewed by Alexey Proskuryakov.
2602
2603         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
2604         since clientInfo points to a web view, not the test controller.
2605
2606         * WebKitTestRunner/TestController.cpp:
2607         (WTR::TestController::createOtherPage):
2608
2609 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
2610
2611         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
2612         https://bugs.webkit.org/show_bug.cgi?id=140077
2613
2614         Reviewed by Csaba Osztrogonác.
2615
2616         WebKit C SPI is available on EFL,GTK.
2617         Changed the define order to pass the API test.
2618
2619         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2620         (TestWebKitAPI::TEST):
2621
2622 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
2623
2624         Simplify WebKitTestRunner timeout tracking
2625         https://bugs.webkit.org/show_bug.cgi?id=140036
2626
2627         Reviewed by Darin Adler.
2628
2629         The code for configuring timeouts was mostly dead, because run-webkit-tests never
2630         passes the --timeout option to WebKitTestRunner.
2631
2632         * WebKitTestRunner/Options.h:
2633         * WebKitTestRunner/Options.cpp:
2634         (WTR::Options::Options):
2635         (WTR::OptionsHandler::OptionsHandler):
2636         (WTR::handleOptionTimeout): Deleted.
2637         Removed support for --timeout. Timeouts are passed for each test individually,
2638         and defaults are good enough for the rare cases where WebKitTestRunner is run
2639         manually without run-webkit-tests.
2640
2641         * WebKitTestRunner/TestController.cpp:
2642         (WTR::TestController::TestController):
2643         (WTR::TestController::initialize):
2644         (WTR::TestController::resetStateToConsistentValues):
2645         (WTR::TestController::reattachPageToWebProcess):
2646         (WTR::TestController::runUntil):
2647         * WebKitTestRunner/TestController.h:
2648         Simplified runUntil by passing the actual timeout, not an enum.
2649         Increased short timeout for ASan enabled builds, as WebProcess launching takes
2650         quite a while.
2651
2652         * WebKitTestRunner/TestInvocation.cpp:
2653         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
2654
2655         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2656         (WTR::TestController::platformRunUntil):
2657         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2658         (WTR::TestController::platformRunUntil):
2659         Build fixes.
2660
2661 2015-01-02  Anders Carlsson  <andersca@apple.com>
2662
2663         Remove now unused storage tracker glue from DumpRenderTree
2664         https://bugs.webkit.org/show_bug.cgi?id=140045
2665
2666         Reviewed by Darin Adler.
2667
2668         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2669         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
2670         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
2671         * DumpRenderTree/TestRunner.cpp:
2672         (TestRunner::staticFunctions):
2673         (syncLocalStorageCallback): Deleted.
2674         (observeStorageTrackerNotificationsCallback): Deleted.
2675         (deleteAllLocalStorageCallback): Deleted.
2676         (deleteLocalStorageForOriginCallback): Deleted.
2677         (localStorageDiskUsageForOriginCallback): Deleted.
2678         (originsWithLocalStorageCallback): Deleted.
2679         * DumpRenderTree/TestRunner.h:
2680         * DumpRenderTree/mac/DumpRenderTree.mm:
2681         (allocateGlobalControllers):
2682         (releaseGlobalControllers):
2683         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2684         * DumpRenderTree/mac/TestRunnerMac.mm:
2685         (TestRunner::syncLocalStorage): Deleted.
2686         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
2687         (TestRunner::observeStorageTrackerNotifications): Deleted.
2688         (TestRunner::deleteAllLocalStorage): Deleted.
2689         (TestRunner::originsWithLocalStorage): Deleted.
2690         (TestRunner::deleteLocalStorageForOrigin): Deleted.
2691         * DumpRenderTree/win/TestRunnerWin.cpp:
2692         (TestRunner::syncLocalStorage): Deleted.
2693         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
2694         (TestRunner::observeStorageTrackerNotifications): Deleted.
2695         (TestRunner::deleteAllLocalStorage): Deleted.
2696         (TestRunner::originsWithLocalStorage): Deleted.
2697         (TestRunner::deleteLocalStorageForOrigin): Deleted.
2698
2699 2015-01-01  Darin Adler  <darin@apple.com>
2700
2701         We often misspell identifier as "identifer"
2702         https://bugs.webkit.org/show_bug.cgi?id=140025
2703
2704         Reviewed by Michael Saboff.
2705
2706         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2707         * Scripts/webkitdirs.pm:
2708         (appIdentifierFromBundle):
2709         (installAndLaunchIOSWebKitAppInSimulator):
2710         Fix misspellings
2711
2712 2015-01-01  Zalan Bujtas  <zalan@apple.com>
2713
2714         Saturated arithmetics: Incorrect float/double clamping.
2715         https://bugs.webkit.org/show_bug.cgi?id=139888
2716         rdar://problem/19330885
2717
2718         Reviewed by Simon Fraser.
2719
2720         Clamp float and double values correctly when applying saturated arithmetics.
2721
2722         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2723         (TestWebKitAPI::TEST):
2724
2725 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
2726
2727         [EFL] Bump version of ATK used by jhbuild to 2.15.2
2728         https://bugs.webkit.org/show_bug.cgi?id=139816
2729
2730         Reviewed by Gyuyoung Kim.
2731
2732         Bump version of ATK used by jhbuild to 2.15.2
2733
2734         * efl/jhbuild.modules:
2735
2736 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
2737
2738         [jhBuild] cairo build error (-flto)
2739         https://bugs.webkit.org/show_bug.cgi?id=139056
2740
2741         Reviewed by Philippe Normand.
2742
2743         cairo fails to link  with gcc 4.9 due to lto
2744         related issue. This problem has been partially
2745         addressed by cairo:
2746         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
2747         use the cairo --disable-lto option and remove jhbuild
2748         makeargs fixes the issue.
2749
2750         * gtk/jhbuild.modules:
2751         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
2752
2753 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
2754         [Mac] Enable kerning, ligatures, and printer fonts 
2755         https://bugs.webkit.org/show_bug.cgi?id=139970
2756
2757         Rubber stamped by Simon Fraser.
2758
2759         Flip the switch.
2760
2761         * DumpRenderTree/mac/DumpRenderTree.mm:
2762         * WebKitTestRunner/TestController.cpp:
2763         * WebKitTestRunner/mac/main.mm:
2764
2765 2014-12-26  Dan Bernstein  <mitz@apple.com>
2766
2767         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2768         https://bugs.webkit.org/show_bug.cgi?id=139950
2769
2770         Reviewed by David Kilzer.
2771
2772         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2773         in a manner that works with Xcode 5.1.1.
2774
2775 2014-12-24  Dan Bernstein  <mitz@apple.com>
2776
2777         Engineering builds of MiniBrowser ignore deprecated declaration warnings
2778         https://bugs.webkit.org/show_bug.cgi?id=139941
2779
2780         Reviewed by Darin Adler.
2781
2782         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
2783         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
2784         to YES.
2785         * MiniBrowser/mac/AppDelegate.m:
2786         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
2787         deprecated NSOKButton.
2788
2789 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2790
2791         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
2792         https://bugs.webkit.org/show_bug.cgi?id=134763
2793
2794         Reviewed by Ryosuke Niwa.
2795
2796         Adding an option to disable test harness link conversion.
2797
2798         * Scripts/webkitpy/w3c/test_converter.py:
2799         (convert_for_webkit):
2800         (_W3CTestConverter.__init__):
2801         (_W3CTestConverter.convert_attributes_if_needed):
2802         * Scripts/webkitpy/w3c/test_importer.py:
2803         (parse_args):
2804         (TestImporter.import_tests):
2805
2806 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2807
2808         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
2809         https://bugs.webkit.org/show_bug.cgi?id=139933
2810
2811         Reviewed by Daniel Bates.
2812
2813         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
2814         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
2815         until ReportCrash lets it go.
2816
2817         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
2818         even get the actual crash log eventually - even when it times out waiting for the log, it
2819         makes a second lookup at the very end, after all tests finish. There may be further
2820         improvements needed here, but this small fix addresses most cases that happen in practice.
2821
2822         * DumpRenderTree/mac/DumpRenderTree.mm:
2823         (writeCrashedMessageOnFatalError):
2824         (dumpRenderTree):
2825         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
2826
2827         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
2828         unhelpful comment.
2829
2830 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2831
2832         Don't force -O1 for debug ASan builds
2833         https://bugs.webkit.org/show_bug.cgi?id=139926
2834
2835         Reviewed by Darin Adler.
2836
2837         * asan/asan.xcconfig:
2838
2839 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2840
2841         Simplify building with ASan
2842         https://bugs.webkit.org/show_bug.cgi?id=139916
2843
2844         Reviewed by Mark Rowe.
2845
2846         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
2847         We could also update Configuration file format, but that's a little scary because
2848         of how many places in code read it.
2849
2850         * Scripts/webkitdirs.pm:
2851         (determineASanIsEnabled): Read it from ASan configuration file.
2852         (argumentsForConfiguration): Added a FIXME.
2853         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
2854         (XcodeOptions): Pass the options needed for ASan.
2855
2856         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
2857         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
2858         that automatically.
2859
2860 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2861
2862         TestWebKitAPI build is broken when ASan is enabled
2863         https://bugs.webkit.org/show_bug.cgi?id=139902
2864
2865         Reviewed by Darin Adler.
2866
2867         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2868         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
2869         Inherit linker flags from DebugRelease, which respects ASAN.
2870
2871 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
2872
2873         Sort the Xcode project file.
2874
2875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2876
2877 2014-12-22  Lucas Forschler  <lforschler@apple.com>
2878
2879         Update apple-mac-114 to bot629.
2880         
2881         Unreviewed.
2882         
2883         * BuildSlaveSupport/build.webkit.org-config/config.json:
2884
2885 2014-12-22  Lucas Forschler  <lforschler@apple.com>
2886
2887         Replace Apple bot104 with bot124.
2888         
2889         Unreviewed.
2890         
2891         * BuildSlaveSupport/build.webkit.org-config/config.json:
2892
2893 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
2894
2895         URTBF after r177639.
2896
2897         * TestWebKitAPI/CMakeLists.txt:
2898
2899 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2900
2901         [EFL] MiniBrowser steals web view's focus
2902         https://bugs.webkit.org/show_bug.cgi?id=139482
2903
2904         Reviewed by Gyuyoung Kim.
2905
2906         Although we set focus on ewk_view while MiniBrowser initialization
2907         Ecore steals it in a favor of main window. As a result
2908         focused element on web page is unable to receive events.
2909
2910         * MiniBrowser/efl/main.c:
2911         (window_create):
2912         Prevent window from stealing web view's focus on start up.
2913
2914 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
2915
2916         [Win] Revise DRT logic to match Mac.
2917
2918         Rubberstamped by Anders Carlsson.
2919
2920         Update the Windows logic to perform initialization of preferences and WebKit
2921         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
2922         the same circumstances as the Mac version.
2923
2924         * DumpRenderTree/win/DumpRenderTree.cpp:
2925         (dump):
2926         (resetWebPreferencesToConsistentValues):
2927         (setDefaultsToConsistentValuesForTesting):
2928         (resetWebViewToConsistentStateBeforeTesting):
2929         (sizeWebViewForCurrentTest):
2930         (runTest):
2931         (createWebViewAndOffscreenWindow):
2932         (allocateGlobalControllers):
2933         (prepareConsistentTestingEnvironment):
2934         (main):
2935         (resetDefaultsToConsistentValues): Deleted.
2936
2937 2014-12-19  Roger Fong  <roger_fong@apple.com>
2938
2939         Unreviewed. Rollout r177605.
2940
2941         * EWSTools/start-queue-win.sh:
2942
2943 2014-12-19  Roger Fong  <roger_fong@apple.com>
2944
2945         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
2946
2947         * EWSTools/start-queue-win.sh:
2948
2949 2014-12-19  Daniel Bates  <dabates@apple.com>
2950
2951         [iOS] Add WebKitSystemInterface for iOS 8.1
2952         https://bugs.webkit.org/show_bug.cgi?id=139831
2953
2954         Reviewed by Alexey Proskuryakov.
2955
2956         Implement support in copy-webkitlibraries-to-product-directory to copy
2957         WebKitSystemInterface for iOS to the product directory and have build-webkit
2958         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
2959
2960         * Scripts/build-webkit:
2961         * Scripts/copy-webkitlibraries-to-product-directory:
2962
2963 2014-12-19  Daniel Bates  <dabates@apple.com>
2964
2965         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
2966         https://bugs.webkit.org/show_bug.cgi?id=139829
2967
2968         Reviewed by Alexey Proskuryakov.
2969
2970         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
2971         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
2972         expects the Xcode SDK to be specified using the --sdk-name command line argument.
2973
2974         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
2975         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
2976         logic to both avoid duplicating effort and make the command line options for
2977         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
2978         with the approach used in other WebKit tools.
2979
2980         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
2981         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
2982         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
2983
2984         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
2985         improve the readability of the code.
2986         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
2987         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
2988         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
2989         be included in a library.
2990         (unpackIfNecessary): Modified to call executeRanlib().
2991
2992 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
2993
2994         REGRESSION (177368): Some tests started to immediately time out
2995         https://bugs.webkit.org/show_bug.cgi?id=139826
2996
2997         Reviewed by Daniel Bates.
2998
2999         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
3000         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
3001         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
3002         ends in a load failure, we don't dump, so we used to leak the timer.
3003         
3004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
3005         Added a comment.
3006
3007 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3008
3009         [Win] Add accessor for serializing HTTP loads
3010         https://bugs.webkit.org/show_bug.cgi?id=139817
3011
3012         Reviewed by Mark Lam.
3013
3014         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
3015         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
3016         remove some redundant code from the destructor.
3017
3018 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3019
3020         Clean up a fix for performance test bot failing to build
3021         https://bugs.webkit.org/show_bug.cgi?id=139818
3022
3023         Reviewed by Csaba Osztrogonác.
3024
3025         The "_1" in step name was annoying.
3026
3027         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3028         (CleanBuildIfScheduled.start):
3029         (RunAndUploadPerfTests):
3030         (DownloadAndPerfTestFactory.__init__):
3031         (DownloadAndPerfTestWebKit2Factory.__init__):
3032         (CleanBuildUnconditionally): Deleted.
3033         (CleanBuildUnconditionally.start): Deleted.
3034
3035 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
3036
3037         REGRESSION(r177535): It broke the GTK performance bot
3038         https://bugs.webkit.org/show_bug.cgi?id=139811
3039
3040         Reviewed by Carlos Garcia Campos.
3041
3042         Trigger clean build only on mac platform.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3045         (DownloadAndPerfTestFactory.__init__):
3046         (DownloadAndPerfTestWebKit2Factory.__init__):
3047
3048 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
3049
3050         Unreviewed, moved myself to the list of committers.
3051
3052         * Scripts/webkitpy/common/config/contributors.json:
3053
3054 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3055
3056         [Win] Update DumpRenderTree to more closely match Mac version
3057         https://bugs.webkit.org/show_bug.cgi?id=139799
3058
3059         Reviewed by Tim Horton.
3060
3061         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3062         (AccessibilityController::accessibleElementById): Correct
3063         use of BSTR to avoid leak.
3064         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
3065         update to match Mac version more closely.
3066         (dumpFramesAsText):
3067         (dump):
3068         (resetDefaultsToConsistentValues):
3069         (resetWebViewToConsistentStateBeforeTesting):
3070         (sizeWebViewForCurrentTest):
3071         (runTest):
3072         (openWindows):
3073         (windowToWebViewMap):
3074         (createWebViewAndOffscreenWindow):
3075         (sharedCFURLCache):
3076         (initializeGlobalsFromCommandLineOptions):
3077         (main):
3078         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3079         (TestRunner::addDisallowedURL):
3080         (TestRunner::applicationCacheDiskUsageForOrigin):
3081         (TestRunner::syncLocalStorage):
3082         (TestRunner::localStorageDiskUsageForOrigin):
3083         (TestRunner::observeStorageTrackerNotifications):
3084         (TestRunner::clearApplicationCacheForOrigin):
3085         (TestRunner::originsWithApplicationCache):
3086         (TestRunner::deleteAllLocalStorage):
3087         (TestRunner::setStorageDatabaseIdleInterval):
3088         (TestRunner::closeIdleLocalStorageDatabases):
3089         (TestRunner::originsWithLocalStorage):
3090         (TestRunner::deleteLocalStorageForOrigin):
3091         (TestRunner::copyDecodedHostName):
3092         (TestRunner::copyEncodedHostName):
3093         (TestRunner::keepWebHistory):
3094         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3095         (TestRunner::setAppCacheMaximumSize):
3096         (TestRunner::setCustomPolicyDelegate):
3097         (TestRunner::goBack):
3098         (TestRunner::setDefersLoading):
3099         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3100         (TestRunner::setMockDeviceOrientation):
3101         (TestRunner::setMockGeolocationPosition):
3102         (TestRunner::setMockGeolocationPositionUnavailableError):
3103         (TestRunner::setIconDatabaseEnabled):
3104         (TestRunner::setMainFrameIsFirstResponder):
3105         (TestRunner::setSpatialNavigationEnabled):
3106         (TestRunner::setPluginsEnabled):
3107         (TestRunner::setAutomaticLinkDetectionEnabled):
3108         (TestRunner::setUseDashboardCompatibilityMode):
3109         (TestRunner::dispatchPendingLoadRequests):
3110         (TestRunner::findString):
3111         (TestRunner::setCacheModel):
3112         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3113         (TestRunner::setWebViewEditable):
3114         (TestRunner::authenticateSession):
3115         (TestRunner::abortModal):
3116         (TestRunner::setSerializeHTTPLoads):
3117         (TestRunner::addChromeInputField):
3118         (TestRunner::removeChromeInputField):
3119         (TestRunner::focusWebView):
3120         (TestRunner::setBackingScaleFactor):
3121         (TestRunner::grantWebNotificationPermission):
3122         (TestRunner::denyWebNotificationPermission):
3123         (TestRunner::removeAllWebNotificationPermissions):
3124         (TestRunner::simulateWebNotificationClick):
3125
3126 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
3127
3128         Add strong typing to RefCounter interface, return value as a bool.
3129         https://bugs.webkit.org/show_bug.cgi?id=139776
3130
3131         Reviewed by Geoff Garen.
3132
3133         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
3134         This means there is no compile time type checking to prevent mistakes. Update the count()
3135         method to token<>(), templated on type used to identify the token being returned.
3136         Calls to token<T>() will return a result of type RefCounter::Token<T>.
3137
3138         There are a few problems with the fact the counter will return you an exact count of the
3139         number of outstanding tokens:
3140           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
3141             to do so if the value is only readable as a boolean.
3142           - It is desirable to provide the value as an argument to the callback, however to make
3143             this useful for integer values it is also necessary to indicate the direction of change
3144             (0->1 is often interesting where 2->1 is not).
3145           - There is a mismatch between the precision of returning a count, and the inherent
3146             imprecision of a token based mechanism, where it may be difficult to guarantee
3147             absolutely no unnecessary refcount churn, and thus unintentional counter values.
3148
3149         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3150         (TestWebKitAPI::TEST):
3151             - update API test.
3152
3153 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3154
3155         Disable retries on Mac Release WK2 testers
3156         https://bugs.webkit.org/show_bug.cgi?id=139798
3157
3158         Reviewed by Simon Fraser.
3159
3160         * BuildSlaveSupport/build.webkit.org-config/config.json:
3161
3162 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3163
3164         Perf tests frequently fail saying "build not up to date"
3165         https://bugs.webkit.org/show_bug.cgi?id=139786
3166
3167         Illegitimately yet authoritatively reviewed by Lucas Forschler.
3168
3169         Undo the rest of the first fix, and implement the behavior differently.
3170
3171         is_clean isn't automatically forwarded from config.json to properties.
3172
3173         * BuildSlaveSupport/build.webkit.org-config/config.json:
3174         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3175         (CleanBuildUnconditionally):
3176         (CleanBuildUnconditionally.start):
3177         (DownloadAndPerfTestFactory.__init__):
3178         (DownloadAndPerfTestWebKit2Factory.__init__):
3179
3180 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3181
3182         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
3183         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
3184         found nothing.
3185
3186         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3187         (BuildAndPerfTestFactory):
3188         (BuildAndPerfTestWebKit2Factory):
3189
3190 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3191
3192         Perf tests frequently fail saying "build not up to date"
3193         https://bugs.webkit.org/show_bug.cgi?id=139786
3194
3195         Reviewed by Ryosuke Niwa.
3196
3197         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
3198         directory to get rid of stale precompiled headers, and let it rebuild
3199         DumpRenderTree each time, that's fast.
3200
3201         Also, removed unused "build and perf test" code.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/config.json:
3204
3205 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3206
3207         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
3208
3209         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
3210         it easier to see what steps are missing when running under Windows.
3211
3212         * DumpRenderTree/win/TestRunnerWin.cpp:
3213         (TestRunner::callShouldCloseOnWebView):
3214         (TestRunner::clearAllApplicationCaches):
3215         (TestRunner::applicationCacheDiskUsageForOrigin):
3216         (TestRunner::syncLocalStorage):
3217         (TestRunner::localStorageDiskUsageForOrigin):
3218         (TestRunner::observeStorageTrackerNotifications):
3219         (TestRunner::clearApplicationCacheForOrigin):
3220         (TestRunner::originsWithApplicationCache):
3221         (TestRunner::clearAllDatabases):
3222         (TestRunner::deleteAllLocalStorage):
3223         (TestRunner::setStorageDatabaseIdleInterval):
3224         (TestRunner::closeIdleLocalStorageDatabases):
3225         (TestRunner::originsWithLocalStorage):
3226         (TestRunner::deleteLocalStorageForOrigin):
3227         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3228         (jsStringRefToWString):
3229         (TestRunner::setAppCacheMaximumSize):
3230         (TestRunner::setDatabaseQuota):
3231         (TestRunner::goBack):
3232         (TestRunner::setDefersLoading):
3233         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3234         (TestRunner::setAutomaticLinkDetectionEnabled):
3235         (TestRunner::dispatchPendingLoadRequests):
3236         (TestRunner::overridePreference):
3237         (TestRunner::removeAllVisitedLinks):
3238         (TestRunner::waitForPolicyDelegate):
3239         (TestRunner::resetPageVisibility):
3240         (TestRunner::setPageVisibility):
3241         (TestRunner::grantWebNotificationPermission):
3242         (TestRunner::denyWebNotificationPermission):
3243         (TestRunner::removeAllWebNotificationPermissions):
3244         (TestRunner::simulateWebNotificationClick):
3245         (TestRunner::simulateLegacyWebNotificationClick):
3246
3247 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3248
3249         [Win] Correct Windows tests after Bug 139149 (edit)
3250         https://bugs.webkit.org/show_bug.cgi?id=139781
3251
3252         Reviewed by Anders Carlsson.
3253
3254         * DumpRenderTree/win/TestRunnerWin.cpp:
3255         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
3256         interface.
3257
3258 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
3259
3260         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
3261         https://bugs.webkit.org/show_bug.cgi?id=139748
3262
3263         Reviewed by Daniel Bates.
3264         
3265         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
3266         have all been updated.
3267
3268         * Scripts/webkitpy/port/factory.py:
3269         (platform_options):
3270
3271 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
3272
3273         Build more of TestWebKitAPI for iOS
3274         https://bugs.webkit.org/show_bug.cgi?id=139747
3275
3276         Reviewed by Daniel Bates.
3277         
3278         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
3279         which excluded some tests that should be run for iOS.
3280         
3281         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
3282         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
3283         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
3284         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
3285         
3286         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
3287         to share code between Mac and iOS.
3288
3289         * TestWebKitAPI/Configurations/Base.xcconfig:
3290         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3291         * TestWebKitAPI/InjectedBundleController.cpp:
3292         * TestWebKitAPI/InjectedBundleMain.cpp:
3293         * TestWebKitAPI/JavaScriptTest.cpp:
3294         * TestWebKitAPI/PlatformUtilities.cpp:
3295         * TestWebKitAPI/PlatformUtilities.h:
3296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3297         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3298         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3299         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3300         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3301         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
3302         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
3303         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3304         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3305         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3306         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
3307         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3308         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
3309         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
3310         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
3311         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3312         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3313         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3314         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3315         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3316         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3317         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3318         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3319         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3320         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3321         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3322         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3323         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
3324         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
3325         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3326         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3327         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3328         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3329         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
3330         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
3331         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
3332         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
3333         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
3334         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3335         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
3336         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
3337         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
3338         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3339         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
3340         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3341         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3342         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3343         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3344         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
3345         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3346         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3347         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3348         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3349         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3350         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
3351         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
3352         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
3353         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
3354         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3355         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3356         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
3357         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3358         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
3359         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3360         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
3361         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3362         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3363         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
3364         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
3365         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
3366         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3367         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
3368         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
3369         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
3370         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
3371         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
3372         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
3373         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
3374         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3375         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3376         (TestWebKitAPI::TEST):
3377         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3378         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3379         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3380         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
3381         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
3382         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
3383         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3384         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
3385         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
3386         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
3387         (TEST):
3388         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3389         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3390         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3391         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
3392         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3393         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
3394         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3395         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3396         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
3397         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3398         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
3399         (TestWebKitAPI::Util::run):
3400         (TestWebKitAPI::Util::sleep):
3401         (TestWebKitAPI::Util::toSTD):
3402         * TestWebKitAPI/config.h:
3403         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
3404         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3405         (TestWebKitAPI::Util::run): Deleted.
3406         (TestWebKitAPI::Util::sleep): Deleted.
3407         (TestWebKitAPI::Util::toSTD): Deleted.
3408
3409 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3410
3411         [GTK] Add support for FTL JIT on ARM64
3412         https://bugs.webkit.org/show_bug.cgi?id=139677
3413
3414         Reviewed by Csaba Osztrogonác.
3415
3416         * gtk/jhbuild-optional.modules:
3417         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
3418         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
3419
3420 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
3421
3422         [GTK] Implement webkit_web_view_is_playing_audio()
3423         https://bugs.webkit.org/show_bug.cgi?id=138918
3424
3425         Reviewed by Carlos Garcia Campos.
3426
3427         Add test case case for webkit_web_view_is_playing_audio() and the
3428         WebKitWebView::is-playing-audio property.
3429
3430         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3431         (urlForResource): Utility function to get URLs pointing to resources
3432         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
3433         (testWebViewIsPlayingAudio): Added.
3434         (beforeAll):
3435         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3436         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
3437         API tests resources directory, or the WebKit2 C API tests resources
3438         directory. The default value of the flag is to use the WebKit2 GTK
3439         one, to avoid having to change existing tests.
3440         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3441         (isPlayingAudioChanged): Added.
3442         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
3443         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3444
3445 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3446
3447         [GTK] [EFL] Enable per_test_timeout
3448         https://bugs.webkit.org/show_bug.cgi?id=139771
3449
3450         Reviewed by Csaba Osztrogonác.
3451
3452         This is needed to make WKTR use either the default port timeout, or the
3453         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
3454         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
3455
3456         * Scripts/webkitpy/port/efl.py:
3457         (EflPort.supports_per_test_timeout): Enabled.
3458         * Scripts/webkitpy/port/gtk.py:
3459         (GtkPort.supports_per_test_timeout): Enabled.
3460
3461 2014-12-17  Lucas Forschler  <lforschler@apple.com>
3462
3463         Move Apple buildbot slaves to their new home.
3464         
3465         Reviewed by Roger Fong.
3466
3467         * BuildSlaveSupport/build.webkit.org-config/config.json:
3468
3469 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
3470
3471         REGRESSION (r177363): Gtk and Efl testing is broken
3472         https://bugs.webkit.org/show_bug.cgi?id=139734
3473
3474         Reviewed by Simon Fraser.
3475
3476         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3477         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
3478         affected both script and tool timeout. This is still the right place for this logic,
3479         but it would be a larger refactoring than I can do right now.
3480
3481         * Scripts/webkitpy/port/base.py:
3482         (Port.supports_per_test_timeout): Added a FIXME.
3483         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
3484         to avoid making tests take more time.
3485
3486         * Scripts/webkitpy/port/driver.py:
3487         (Driver.run_test): Adjust script timeout here.
3488         (Driver._check_for_driver_timeout): Fix the timeout detection.
3489         (Driver._read_block): Actually use the timeout detection code.
3490
3491         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
3492         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
3493
3494         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
3495         Update results for the new default.
3496
3497         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3498         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
3499         actually a good one.
3500
3501 2014-12-17  Commit Queue  <commit-queue@webkit.org>
3502
3503         Unreviewed, rolling out r177456.
3504         https://bugs.webkit.org/show_bug.cgi?id=139749
3505
3506         Broke webkitpy and Mac tests (Requested by ap on #webkit).
3507
3508         Reverted changeset:
3509
3510         "REGRESSION (r177363): Gtk and Efl testing is broken"
3511         https://bugs.webkit.org/show_bug.cgi?id=139734
3512         http://trac.webkit.org/changeset/177456
3513
3514 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
3515
3516         REGRESSION (r177363): Gtk and Efl testing is broken
3517         https://bugs.webkit.org/show_bug.cgi?id=139734
3518
3519         Reviewed by Simon Fraser.
3520
3521         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3522         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
3523         affected both script and tool timeout. This is still the right place for this logic,
3524         but it would be a larger refactoring than I can do right now.
3525
3526         * Scripts/webkitpy/port/base.py:
3527         (Port.supports_per_test_timeout): Added a FIXME.
3528         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
3529         to avoid making tests take more time.
3530
3531         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
3532
3533         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
3534         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
3535
3536 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3537
3538         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
3539         https://bugs.webkit.org/show_bug.cgi?id=139725
3540
3541         Reviewed by Martin Robinson.
3542
3543         The timeout is already in milliseconds, so we don't need to do any conversion.
3544
3545         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3546         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3547
3548 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
3549
3550         [EFL]Fix build warning in MiniBrowser
3551         https://bugs.webkit.org/show_bug.cgi?id=139723
3552
3553         Reviewed by Darin Adler.
3554
3555         The warning is caused by the compiler wanting the first argument to be a
3556         string literal, not a dynamically created string.
3557
3558         * MiniBrowser/efl/main.c:
3559         (quit):
3560
3561 2014-12-16  Sam Weinig  <sam@webkit.org>
3562
3563         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
3564         https://bugs.webkit.org/show_bug.cgi?id=139718
3565
3566         Reviewed by Mark Rowe.
3567
3568         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
3569         files into a static lib which the command line utility can link link against.
3570         This will allow us to create a TestWebKitAPI.app that can run on iOS.
3571
3572         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3573         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575
3576 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
3577
3578         Sort out timeout implementations in DRT and WKTR
3579         https://bugs.webkit.org/show_bug.cgi?id=139671
3580
3581         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
3582         with the tool.
3583
3584         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3585         (RunTest.test_hung_thread):
3586
3587 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
3588
3589         Sort out timeout implementations in DRT and WKTR
3590         https://bugs.webkit.org/show_bug.cgi?id=139671
3591
3592         Reviewed by Simon Fraser.
3593
3594         Test timeout implementation had many deficiencies, please see the bug for details.
3595         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
3596         [ Slow ] modifiers should work a lot better.
3597
3598         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
3599         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
3600         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
3601         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
3602         DumpRenderTree already read the --timeout option from command line, and webkitpy
3603         was already configured to pass it on Mac and iOS. Let's actually use it.
3604         TestCommand already had the same 30 second default, so this doesn't change behavior
3605         when DRT is ran manually without the option.
3606         Windows DumpRenderTree will need to be fixed separately (that's easy).
3607
3608         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
3609         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
3610         slightly better to use stderr in both, as this is an out of band message, but
3611         that's a larger refactoring, and the difference is minimal in practice.
3612
3613         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3614         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
3615         different. We want the tool to reliably detect timeouts that can be detected, and
3616         not race with the script for that.
3617
3618         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
3619         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
3620         is honored inmore cases, that could make tests run slower.
3621         * Scripts/webkitpy/port/driver.py:
3622         (Driver.__init__):
3623         (Driver.run_test):
3624         (Driver.cmd_line):
3625         (Driver._check_for_driver_timeout):
3626         Detect tests that have the timeout output, and make these have the proper Timeout result.
3627
3628         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
3629         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
3630
3631         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3632         (WTR::TestRunner::setCustomTimeout): Deleted.
3633         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3634         (WTR::TestRunner::setCustomTimeout):
3635         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3636         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3637         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3638         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3639         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
3640         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3641         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3642         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3643         Updated to use a timeout passed from UI process, which used to be ignored.
3644
3645         * WebKitTestRunner/TestController.cpp:
3646         (WTR::TestController::TestController):
3647         (WTR::TestController::runUntil):
3648         (WTR::TestController::getCustomTimeout): Deleted.
3649         * WebKitTestRunner/TestController.h:
3650         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
3651         Changed default message timeouts to match new run-webkit-tests timeout. These don't
3652         affect ports where timeout is passed per test (shouldn't they all be like that?).
3653
3654         * WebKitTestRunner/TestInvocation.cpp:
3655         (WTR::TestInvocation::invoke):
3656         (WTR::TestInvocation::setCustomTimeout): Deleted.
3657         * WebKitTestRunner/TestInvocation.h:
3658         (WTR::TestInvocation::setCustomTimeout):
3659         (WTR::TestInvocation::customTimeout):
3660         Ditto.
3661
3662 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3663
3664         [EFL] Add logging domain for MiniBrowser
3665         https://bugs.webkit.org/show_bug.cgi?id=139642
3666
3667         Reviewed by Gyuyoung Kim.
3668
3669         Similarly to EWebKit2, provide logging facility for MiniBrowser
3670         based on Eina Log module to have a convenient way to display
3671         all/subset/none messages for EFL based libraries and MiniBrowser.
3672
3673         Usage:
3674         1. Disable all messages:
3675            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
3676
3677         2. Enable all messages:
3678            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
3679
3680         3. Enable MiniBrowser and EWebkit2 messages only:
3681            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
3682
3683         More information and examples you can find here:
3684         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
3685
3686         * MiniBrowser/efl/main.c:
3687         (on_mouse_wheel):
3688         (on_window_resize):
3689         (save_page_contents_callback):
3690         (script_execute_callback):
3691         (on_key_down):
3692         (on_download_request):
3693         (on_download_finished):
3694         (on_download_failed):
3695         (quit):
3696         (on_refresh_button_clicked):
3697         (on_stop_button_clicked):
3698         (navigation_button_longpress_process):
3699         (on_popup_menu_item_clicked):
3700         (popup_menu_populate):
3701         (on_popup_menu_show):
3702         (on_window_create):
3703         (context_menu_item_selected_cb):
3704         (context_menu_populate):
3705         (on_context_menu_show):
3706         (on_context_menu_hide):
3707         (on_navigation_policy_decision):
3708         (window_create):
3709         (parse_cookies_policy):
3710         (elm_main):
3711         (has_scheme):
3712         (list_item_label_get):
3713         (on_popup_menu_hide):
3714         (on_window_close):
3715         (on_home_button_clicked):
3716         Replace locally info() macro with newly introduced
3717         one which uses Eina Log module. There is no logic change.
3718
3719 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3720
3721         [EFL] FTL JIT not working on ARM64
3722         https://bugs.webkit.org/show_bug.cgi?id=139295
3723
3724         Reviewed by Michael Saboff.
3725
3726         Added patches for llvm to add ARM64 support for FTL JIT
3727
3728         * efl/jhbuild.modules:
3729         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
3730         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
3731
3732 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3733
3734         Move Said to the committers section.
3735
3736         * Scripts/webkitpy/common/config/contributors.json:
3737
3738 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3739
3740         Implement Data Detectors immediate actions for WebKit2
3741         https://bugs.webkit.org/show_bug.cgi?id=139617
3742         <rdar://problem/19198539>
3743
3744         Reviewed by Beth Dakin.
3745
3746         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3747         (TestWebKitAPI::TEST):
3748         Temporarily disable the action menu tests while the
3749         underlying code is in flux.
3750
3751 2014-12-14  Andreas Kling  <akling@apple.com>
3752
3753         Replace PassRef with Ref/Ref&& across the board.
3754         <https://webkit.org/b/139587>
3755
3756         Reviewed by Darin Adler.
3757
3758         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3759         (TestWebKitAPI::passWithRef):
3760         (TestWebKitAPI::TEST):
3761         (TestWebKitAPI::passWithPassRef): Deleted.
3762         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3763         (TestWebKitAPI::TEST):
3764         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3765         (TestWebKitAPI::TEST):
3766         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3767         (TestWebKitAPI::createTestValue):
3768
3769 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3770
3771         [EFL] MiniBrowser's window_create may return NULL
3772         https://bugs.webkit.org/show_bug.cgi?id=139585
3773
3774         Reviewed by Gyuyoung Kim.
3775
3776         Move NULL checking before using object which window_create
3777         returns.
3778
3779         * MiniBrowser/efl/main.c:
3780         (elm_main):
3781
3782 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
3783
3784         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
3785         https://bugs.webkit.org/show_bug.cgi?id=73030
3786
3787         Reviewed by Anders Carlsson.
3788
3789         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
3790         database to empty to avoid having it fetch default favicons at random times.
3791         DumpRenderTree also disables it, and also it has a way for tests to temporarily
3792         enable it.
3793
3794 2014-12-12  Lucas Forschler  <lforschler@apple.com>
3795
3796         Update Apple owned build slaves after infrastructure update.
3797         
3798         Reviewed by Ryosuke Niwa.
3799
3800         * BuildSlaveSupport/build.webkit.org-config/config.json:
3801
3802 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3803
3804         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
3805         https://bugs.webkit.org/show_bug.cgi?id=139537
3806
3807         Reviewed by Carlos Garcia Campos.
3808
3809         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
3810         of get_dependencies_path().
3811         * jhbuild/jhbuildutils.py:
3812         (get_dependencies_path): Fix the function to return the new
3813         dependencies path: DependenciesPORT.
3814         (enter_jhbuild_environment_if_available): Pass the port name
3815         when invoking get_dependencies_path().
3816
3817 2014-12-10  Lucas Forschler  <lforschler@apple.com>
3818
3819         Update Apple owned build slaves.
3820         
3821         Rubber-stamped by Dana Burkart.
3822         
3823         * BuildSlaveSupport/build.webkit.org-config/config.json:
3824
3825 2014-12-10  Daniel Bates  <dabates@apple.com>
3826
3827         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
3828         timeout instead of test failure
3829         https://bugs.webkit.org/show_bug.cgi?id=139525
3830
3831         Reviewed by Zalan Bujtas.
3832
3833         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
3834         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
3835         output.
3836
3837         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
3838         for the WebThread to spin its run loop before dumping its output. A test that
3839         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
3840         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
3841         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
3842         because run-webkit-tests may terminate a DumpRenderTree.app process when it
3843         exceeds its process time limit (defaults to 35ms) regardless of whether such
3844         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
3845
3846         * Scripts/webkitpy/port/ios.py:
3847         (IOSSimulatorPort.default_timeout_ms):
3848
3849 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3850
3851         [GTK][WK2] Add HTML5 Notifications support
3852         https://bugs.webkit.org/show_bug.cgi?id=61140
3853
3854         Reviewed by Carlos Garcia Campos.
3855
3856         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
3857         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3858         (testWebViewNotification):
3859         (beforeAll):
3860         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
3861         (permissionRequestDialogCallback):
3862         (webViewDecidePermissionRequest):
3863         (geolocationRequestDialogCallback): Deleted.
3864
3865 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
3866
3867         Fix webkitpy test expectation
3868
3869         Not sure what I messed up, but TOTAL_SKIPS was not right.
3870
3871         * Scripts/webkitpy/port/test.py:
3872
3873 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
3874
3875         Remove virtual test support from webkitpy
3876         https://bugs.webkit.org/show_bug.cgi?id=139427
3877
3878         Reviewed by Alexey Proskuryakov.
3879
3880         It seems that the only concrete client of virtual tests is the unit tests :D
3881
3882         This patch tries to clean as much useless code as possible.
3883
3884         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3885         (RunTest.test_tolerance):
3886         (RunTest.test_virtual): Deleted.
3887         * Scripts/webkitpy/layout_tests/views/printing.py:
3888         (Printer._print_test_trace):
3889         * Scripts/webkitpy/port/base.py:
3890         (Port.expected_filename):
3891         (Port.tests):
3892         (Port.test_isfile):
3893         (Port.test_isdir):
3894         (Port.sample_process):
3895         (Port.find_system_pid):
3896         (Port.test_expectations_file_position):
3897         (Port.virtual_test_suites): Deleted.
3898         (Port): Deleted.
3899         (Port.populated_virtual_test_suites): Deleted.
3900         (Port._virtual_tests): Deleted.
3901         (Port.lookup_virtual_test_base): Deleted.
3902         (Port.lookup_virtual_test_args): Deleted.
3903         (VirtualTestSuite): Deleted.
3904         (VirtualTestSuite.__init__): Deleted.
3905         (VirtualTestSuite.__repr__): Deleted.
3906         * Scripts/webkitpy/port/base_unittest.py:
3907         (PortTest.test_test_exists):
3908         (PortTest.test_test_isfile):
3909         (PortTest.test_test_isdir):
3910         (PortTest.test_tests):
3911         * Scripts/webkitpy/port/driver.py:
3912         (DriverProxy.run_test): Deleted.
3913         * Scripts/webkitpy/port/test.py:
3914         (TestPort._skipped_tests_for_unsupported_features):
3915         (TestPort.all_baseline_variants):
3916         (TestPort.virtual_test_suites): Deleted.
3917         * Scripts/webkitpy/tool/commands/queries.py:
3918         (PrintBaselines.__init__):
3919         (PrintBaselines.execute):
3920         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3921         (PrintBaselinesTest.test_basic):
3922         (PrintBaselinesTest.test_multiple):
3923         (PrintBaselinesTest.test_csv):
3924
3925 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3926
3927         Blink Merge: Remove 'http_lock' code from webkitpy
3928         https://bugs.webkit.org/show_bug.cgi?id=136722
3929
3930         Reviewed by Alexey Proskuryakov.
3931
3932         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
3933         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
3934
3935         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3936         (LayoutTestRunner.__init__):
3937         (LayoutTestRunner.run_tests):
3938         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
3939         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
3940         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3941         (FakePrinter.flush):
3942         (LayoutTestRunnerTests._runner):
3943         (LayoutTestRunnerTests._run_tests):
3944         (LayoutTestRunnerTests.test_servers_started):
3945         (LockCheckingRunner): Deleted.
3946         (LockCheckingRunner.__init__): Deleted.
3947         (LockCheckingRunner.handle_finished_list): Deleted.
3948         (LayoutTestRunnerTests.test_http_locking): Deleted.
3949         * Scripts/webkitpy/port/base.py:
3950         (Port.__init__):
3951         (Port.to.http_server_supports_ipv6):
3952         (Port.to.stop_websocket_server):
3953         (Port.to.acquire_http_lock): Deleted.
3954         (Port.to.release_http_lock): Deleted.
3955         * Scripts/webkitpy/port/http_lock.py: Removed.
3956         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
3957         * Scripts/webkitpy/port/ios.py:
3958         (IOSSimulatorPort.show_results_html_file):
3959         (IOSSimulatorPort.acquire_http_lock): Deleted.
3960         (IOSSimulatorPort): Deleted.
3961         (IOSSimulatorPort.release_http_lock): Deleted.
3962         * Scripts/webkitpy/port/mac.py:
3963         (MacPort.show_results_html_file):
3964         (MacPort): Deleted.
3965         (MacPort.acquire_http_lock): Deleted.
3966         (MacPort.release_http_lock): Deleted.
3967         * Scripts/webkitpy/port/mock_drt.py:
3968         (MockDRTPort.start_websocket_server):
3969         (MockDRTPort.stop_websocket_server):
3970         (MockDRTPort.acquire_http_lock): Deleted.
3971         (MockDRTPort.release_http_lock): Deleted.
3972         * Scripts/webkitpy/port/mock_drt_unittest.py:
3973         (MockDRTPortTest.test_uses_apache):
3974         (MockDRTPortTest.integration_test_http_lock): Deleted.
3975         * Scripts/webkitpy/port/port_testcase.py:
3976         (PortTestCase.assert_servers_are_up):
3977         (PortTestCase.integration_test_http_lock): Deleted.
3978         * Scripts/webkitpy/port/test.py:
3979         (TestPort.start_websocket_server):
3980         (TestPort.stop_websocket_server):
3981         (TestPort.acquire_http_lock): Deleted.
3982         (TestPort.release_http_lock): Deleted.
3983
3984 2014-12-09  Alberto Garcia  <berto@igalia.com>
3985
3986         convertToUTF8String converts null string to empty string
3987         https://bugs.webkit.org/show_bug.cgi?id=133904
3988
3989         Reviewed by Carlos Garcia Campos.
3990
3991         Test that trying to get the value of a non-existent attribute
3992         returns 0 instead of an empty string.
3993
3994         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3995         (WebKitDOMNodeTest::testInsertion):
3996
3997 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
3998
3999         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
4000         https://bugs.webkit.org/show_bug.cgi?id=139070
4001
4002         Reviewed by Carlos Garcia Campos.
4003
4004         * gtk/jhbuild.modules:
4005
4006 2014-12-08  Tim Horton  <timothy_horton@apple.com>
4007
4008         Add action menu tests
4009         https://bugs.webkit.org/show_bug.cgi?id=139156
4010
4011         Reviewed by Dean Jackson.
4012
4013         * TestWebKitAPI/PlatformWebView.h:
4014         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4015         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4016         Add a mechanism allowing tests to provide their own WKView subclass.
4017
4018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4019         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
4020         Add a file with lots of menu targets.
4021
4022         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
4023         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
4024         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
4025         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
4026         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
4027
4028         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
4029
4030         (TestWebKitAPI::didFinishLoadForFrameCallback):
4031         (TestWebKitAPI::didFinishDownloadCallback):
4032         (TestWebKitAPI::didCreateDownloadDestinationCallback):
4033         Watch downloads and ensure that they match the content we expect.
4034
4035         (TestWebKitAPI::watchPasteboardForString):
4036         (TestWebKitAPI::watchPasteboardForImage):
4037         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
4038         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
4039         (TestWebKitAPI::javaScriptStringCallback):
4040         (TestWebKitAPI::javaScriptBoolCallback):
4041         (TestWebKitAPI::callJavaScriptReturningString):
4042         (TestWebKitAPI::callJavaScriptReturningBool):
4043         (TestWebKitAPI::watchEditableAreaForString):
4044         (TestWebKitAPI::waitForVideoReady):
4045         (TestWebKitAPI::retrieveSelection):
4046         (TestWebKitAPI::retrieveSelectionInElement):
4047         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
4048         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
4049         Add many helpers for testing, especially to make asynchronous things synchronous.
4050
4051         (TestWebKitAPI::windowPointForTarget):
4052         (TestWebKitAPI::inset8):
4053         Hard-code points in action-menu-targets.html for hit testing.
4054
4055         (TestWebKitAPI::TEST):
4056         Add a suite of tests for WebKit2 action menus.
4057
4058         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
4059         (TestWebKitAPI::createActionContextForPhoneNumber):
4060         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
4061         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
4062         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
4063         (TestWebKitAPI::ActionMenuTest::drawRect):
4064         (TestWebKitAPI::ActionMenuTest::didCreatePage):
4065         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
4066         so that we can test that infrastructure.
4067
4068 2014-12-08  Philippe Normand  <pnormand@igalia.com>
4069
4070         [GTK] UserMedia Permission Request API
4071         https://bugs.webkit.org/show_bug.cgi?id=136449
4072
4073         Reviewed by Carlos Garcia Campos.
4074
4075         The GTK version of the MiniBrowser has gained UserMedia permission
4076         request support.
4077
4078         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
4079         requires user permission to access audio/video devices.
4080         (permissionRequestDialogCallback):
4081         (webViewDecidePermissionRequest):
4082         (geolocationRequestDialogCallback): Deleted.
4083
4084 2014-12-08  Anders Carlsson  <andersca@apple.com>
4085
4086         Add a stubbed out method for clearing out the website data store
4087         https://bugs.webkit.org/show_bug.cgi?id=139404
4088
4089         Reviewed by Antti Koivisto.
4090
4091         Add a debug menu item for testing clearing of website data.
4092
4093         * MiniBrowser/mac/MainMenu.xib:
4094         * MiniBrowser/mac/WK2BrowserWindowController.m:
4095         (-[WK2BrowserWindowController clearWebsiteData:]):
4096
4097 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
4098
4099         Update style checker to deal with "const override"
4100         https://bugs.webkit.org/show_bug.cgi?id=139371
4101
4102         Reviewed by Csaba Osztrogonác.
4103
4104         check-webkit-style shouldn't complain about an open brace to start a
4105         line after a function definition with const override.
4106
4107         * Scripts/webkitpy/style/checkers/cpp.py:
4108         (check_braces):
4109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4110         (CppStyleTest.test_brace_at_begin_of_line):
4111
4112 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4113
4114         [GTK] Fix GObject DOM bindings API break tests after r176920
4115         https://bugs.webkit.org/show_bug.cgi?id=139368
4116
4117         Reviewed by Gustavo Noronha Silva.
4118
4119         Remove the @version from the symbol name before comparing.
4120
4121         * gtk/check-for-webkitdom-api-breaks:
4122         (read_expected_api):
4123
4124 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4125
4126         Remove the option to automatically update the GObject DOM bindings symbols file
4127         https://bugs.webkit.org/show_bug.cgi?id=139366
4128
4129         Reviewed by Martin Robinson.
4130
4131         It's currently broken, because symbols now need to be in a
4132         specific order. Now that the symbols file only contains stable
4133         API, it's not a problem to manually update it every time new API
4134         is added.
4135
4136         * gtk/check-for-webkitdom-api-breaks:
4137         (read_expected_api):
4138         (check_api):
4139         (write_expected_api): Deleted.
4140
4141 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4142
4143         [GTK] Use GMainLoopSource in WebKitTestRunner
4144         https://bugs.webkit.org/show_bug.cgi?id=138831
4145
4146         Reviewed by Sergio Villar Senin.
4147
4148         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4149         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
4150         (WTR::TestRunner::platformInitialize):
4151         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
4152         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
4153         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
4154         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4155         (WTR::TestController::notifyDone):
4156         (WTR::TestController::platformRunUntil):
4157         (WTR::cancelTimeout): Deleted.
4158
4159 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4160
4161         [GTK] Missing API detected in GObject DOM bindings after r176630
4162         https://bugs.webkit.org/show_bug.cgi?id=139201
4163
4164         Reviewed by Gustavo Noronha Silva.
4165
4166         Handle deprecated symbols again when generating the GObject DOM
4167         bindings documentation.
4168
4169         * gtk/webkitdom.py:
4170         (WebKitDOMDocGenerator):
4171         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
4172         (WebKitDOMDocGenerator.generate):
4173         (WebKitDOMDocGeneratorSections.__init__):
4174         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
4175         (WebKitDOMDocGeneratorSections.write_section):
4176
4177 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
4178
4179         [EFL][jhbuild] Fix libsoup build with clang
4180         https://bugs.webkit.org/show_bug.cgi?id=139088
4181
4182         Reviewed by Gyuyoung Kim.
4183
4184         * efl/jhbuild.modules:
4185         * efl/patches/soup-clang-warning-fix1.patch: Added.
4186         * efl/patches/soup-clang-warning-fix2.patch: Added.
4187
4188 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
4189
4190         [Mac] DumpRenderTree sets storage directory incorrectly
4191         https://bugs.webkit.org/show_bug.cgi?id=139347
4192
4193         Reviewed by Dan Bernstein.
4194
4195         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4196         Don't use user defaults to pass per-instance paths, as user defaults are shared
4197         across all instances.
4198
4199 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
4200
4201         AX: I cannot activate links on the mobile version of news.google.com
4202         https://bugs.webkit.org/show_bug.cgi?id=139330
4203
4204         Reviewed by Simon Fraser.
4205
4206         Implement press for iOS.
4207
4208         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4209         (AccessibilityUIElement::press):
4210
4211 2014-12-05  Daniel Bates  <dabates@apple.com>
4212
4213         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
4214         https://bugs.webkit.org/show_bug.cgi?id=139326
4215
4216         Reviewed by Anders Carlsson.
4217
4218         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
4219         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
4220         using the same scale factor as used in WebKit.
4221
4222         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4223         (createBitmapContextFromWebView):
4224
4225 2014-12-05  Anders Carlsson  <andersca@apple.com>
4226
4227         REGRESSION (r176677): All tests crash on Windows
4228         https://bugs.webkit.org/show_bug.cgi?id=139321
4229
4230         Reviewed by Alexey Proskuryakov.
4231
4232         * DumpRenderTree/win/DumpRenderTree.cpp:
4233         (runTest):
4234         Don't call CFRelease on the url while we have an outstanding pointer to its string,
4235         and use the right number of bytes when allocating the testURL buffer.
4236
4237 2014-12-05  Daniel Bates  <dabates@apple.com>
4238
4239         [iOS] DumpRenderTree produces many reference test mismatches
4240         https://bugs.webkit.org/show_bug.cgi?id=139314
4241
4242         Reviewed by Simon Fraser.
4243
4244         Fixes an issue where the scale factor used to render the snapshot taken by
4245         DumpRenderTree may differ from the device scale factor. In particular, the
4246         scale factor used to render a snapshot of a test may differ from the scale
4247         factor used to render the snapshot of its expected result.
4248
4249         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
4250         snapshot the UIWebBrowserView. This SPI always render using a scale factor
4251         of one when the backing store for the LegacyTileLayer objects were out-of-
4252         date regardless of the device scale factor. Instead we should use UIImage
4253         and CALayer API to perform the snapshot with respect to the device scale
4254         factor.
4255
4256         Additionally write iOS pixel dump support logic in terms of existing
4257         DumpRenderTree abstractions so as to support generating and comparing
4258         pixel dump checksums as well as make the iOS code more consistent with
4259         the logic used by other ports.
4260
4261         * DumpRenderTree/PixelDumpSupport.cpp:
4262         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
4263         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4264         (BitmapContext::createFromUIImage): Added.
4265         (BitmapContext::pixelData): Added.
4266         (BitmapContext::BitmapContext): Added.
4267         (computeMD5HashStringForBitmapContext): Added.
4268         (dumpBitmap): Added.
4269         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
4270         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
4271
4272 2014-12-05  Anders Carlsson  <andersca@apple.com>
4273
4274         Give all web pages a website data store
4275         https://bugs.webkit.org/show_bug.cgi?id=139317
4276
4277         Reviewed by Tim Horton.
4278
4279         * MiniBrowser/mac/AppDelegate.m:
4280         (-[BrowserAppDelegate newPrivateWindow:]):
4281         Don't release the controller - it's implicitly retained by the window.
4282
4283 2014-12-05  Daniel Bates  <dabates@apple.com>
4284
4285         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
4286         https://bugs.webkit.org/show_bug.cgi?id=137581
4287         <rdar://problem/18642906>
4288
4289         Reviewed by Simon Fraser.
4290
4291         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
4292         of the test that proceeded the currently running test.
4293
4294         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4295         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout